WebKit-https.git
9 years ago2011-02-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Feb 2011 18:29:27 +0000 (18:29 +0000)]
2011-02-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: navigation does not work after reopening frontend.
        https://bugs.webkit.org/show_bug.cgi?id=54879

        Test: http/tests/inspector-enabled/open-close-open.html

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::setFrontend):
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::unmute):
        * inspector/InspectorState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 21 Feb 2011 18:03:36 +0000 (18:03 +0000)]
2011-02-21  Martin Robinson  <mrobinson@igalia.com>

        Add results for tests missing results and unskip a test that
        is passing locally and when run manually on the bots.

        * platform/gtk/Skipped: Unskip tests that are now passing.
        * platform/gtk/editing/deleting/non-smart-delete-expected.checksum: Added.
        * platform/gtk/editing/deleting/non-smart-delete-expected.png: Added.
        * platform/gtk/editing/deleting/non-smart-delete-expected.txt: Added.
        * platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.checksum: Added.
        * platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.png: Added.
        * platform/gtk/fast/repaint/no-caret-repaint-in-non-content-editable-element-expected.txt: Added.
        * platform/gtk/fast/runin/generated2-expected.checksum: Added.
        * platform/gtk/fast/runin/generated2-expected.png: Added.
        * platform/gtk/fast/runin/generated2-expected.txt: Added.
        * platform/gtk/fast/runin/generated3-expected.checksum: Added.
        * platform/gtk/fast/runin/generated3-expected.png: Added.
        * platform/gtk/fast/runin/generated3-expected.txt: Added.
        * platform/gtk/fast/runin/generated4-expected.checksum: Added.
        * platform/gtk/fast/runin/generated4-expected.png: Added.
        * platform/gtk/fast/runin/generated4-expected.txt: Added.
        * platform/gtk/media/video-aspect-ratio-expected.checksum: Added.
        * platform/gtk/media/video-aspect-ratio-expected.png: Added.
        * platform/gtk/media/video-aspect-ratio-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 21 Feb 2011 18:01:36 +0000 (18:01 +0000)]
2011-02-21  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed added more tests with pixel differences between bots.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoProtect the PluginView when evaluating javascript: URLs
aroben@apple.com [Mon, 21 Feb 2011 17:48:50 +0000 (17:48 +0000)]
Protect the PluginView when evaluating javascript: URLs

Fixes <http://webkit.org/b/54884> <rdar://problem/9030864>
plugins/get-url-with-javascript-destroying-plugin.html crashing on Windows since it was
added

Reviewed by Sam Weinig.

* plugins/PluginView.cpp:
(WebCore::PluginView::performRequest): Protect the PluginView, not just its parent frame,
when evaluating javascript: URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 21 Feb 2011 17:44:40 +0000 (17:44 +0000)]
2011-02-21  Martin Robinson  <mrobinson@igalia.com>

        Fix GTK+ build after r79223.

        * GNUmakefile.am: Add file missing from the source list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-14 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 21 Feb 2011 17:35:47 +0000 (17:35 +0000)]
2011-02-14  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: audits should not warn about gzip compression for 304s
        https://bugs.webkit.org/show_bug.cgi?id=54343

        Do not run compression-related audits on 304 resources.
Drive-by: handle multi-encoding resources (Content-Encoding: sdhc,gzip) correctly.
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.GzipRule.prototype.doRun):
        (WebInspector.AuditRules.GzipRule.prototype._isCompressed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed expectations change to mark tests as timing out.
atwilson@chromium.org [Mon, 21 Feb 2011 17:25:37 +0000 (17:25 +0000)]
Unreviewed expectations change to mark tests as timing out.

Many tests started timing out on the chrome mac canaries around r79035
https://bugs.webkit.org/show_bug.cgi?id=54885

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed expectations change - ignore styles-update-from-js.html failures on chromi...
atwilson@chromium.org [Mon, 21 Feb 2011 16:36:45 +0000 (16:36 +0000)]
Unreviewed expectations change - ignore styles-update-from-js.html failures on chromium-win.

Web Inspector: inspector/styles/styles-update-from-js.html is sporadically failing on chromium win bots
https://bugs.webkit.org/show_bug.cgi?id=54882

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother followup to 79223: correct QT project file
antonm@chromium.org [Mon, 21 Feb 2011 16:36:39 +0000 (16:36 +0000)]
Another followup to 79223: correct QT project file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFollowup to 79223: forgotten file
antonm@chromium.org [Mon, 21 Feb 2011 16:18:05 +0000 (16:18 +0000)]
Followup to 79223: forgotten file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Mon, 21 Feb 2011 16:13:35 +0000 (16:13 +0000)]
2011-02-21  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Implement WorkQueue::sheduleWorkAfterDelay
        https://bugs.webkit.org/show_bug.cgi?id=54878

        * Platform/qt/WorkQueueQt.cpp:
        (WorkQueue::scheduleWorkAfterDelay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Mon, 21 Feb 2011 16:01:41 +0000 (16:01 +0000)]
2011-02-08  Anton Muhin  <antonm@chromium.org>

       Reviewed by Adam Barth and Alexey Proskuryakov.

       Propagate security origin of parent document into HTML documents created with DOMImplementation
       https://bugs.webkit.org/show_bug.cgi?id=53611

       This restores invariant that JS wrappers residing in the same JS context should come
       from the same security origin.

       Absence of regressions is covered by the current tests.  Different security origin of
       DOMImplementation is difficult to check with layout tests as DOMImplementation
       resides in the same JS context as parent document and therefore there are no security origin checks.
       This is observable however in C++.

       * Android.jscbindings.mk:
       * CMakeLists.txt:
       * WebCore.gypi:
       * WebCore.pro:
       * WebCore.vcproj/WebCore.vcproj:
       * WebCore.xcodeproj/project.pbxproj:
       * bindings/v8/V8GCController.cpp:
       (WebCore::NodeGrouperVisitor::visitDOMWrapper):
       * dom/DOMImplementation.cpp:
       (WebCore::DOMImplementation::DOMImplementation):
       (WebCore::DOMImplementation::createDocument):
       * dom/DOMImplementation.h:
       (WebCore::DOMImplementation::create):
       (WebCore::DOMImplementation::documentDestroyed):
       (WebCore::DOMImplementation::parentDocument):
       * dom/DOMImplementation.idl:
       * dom/Document.cpp:
       (WebCore::Document::~Document):
       (WebCore::Document::implementation):
       * dom/Document.h:
2011-02-21  Anton Muhin  <antonm@chromium.org>

       Reviewed by Adam Barth and Alexey Proskuryakov.

       Propagate security origin of parent document into HTML documents created with DOMImplementation
       https://bugs.webkit.org/show_bug.cgi?id=53611

       Additional test which checks case when parent document can be collected while
       its implementation is alive.

       * fast/dom/gc-9.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExport JSObject::s_info from JavaScriptCore.dll
aroben@apple.com [Mon, 21 Feb 2011 15:55:45 +0000 (15:55 +0000)]
Export JSObject::s_info from JavaScriptCore.dll

This matches what we do for all other ClassInfo objects that WebCore needs access to.

Fixes <http://webkit.org/b/54881> REGRESSION (r79132): Lots of tests crashing in
JSCell::inherits on Windows

Reviewed by Sam Weinig.

* runtime/JSObject.h: Added JS_EXPORTDATA to s_info.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Mon, 21 Feb 2011 15:03:28 +0000 (15:03 +0000)]
2011-02-21  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: [Text editor] Optimize editing updates in gutter panel
        https://bugs.webkit.org/show_bug.cgi?id=54866

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype.set startEditingListener):
        (WebInspector.TextViewer.prototype.set endEditingListener):
        (WebInspector.TextViewer.prototype.endUpdates):
        (WebInspector.TextViewer.prototype._enterInternalTextChangeMode):
        (WebInspector.TextViewer.prototype._exitInternalTextChangeMode):
        (WebInspector.TextEditorChunkedPanel.prototype._chunkNumberForLine):
        (WebInspector.TextEditorGutterPanel.prototype._expandChunks):
        (WebInspector.TextEditorGutterPanel.prototype.textChanged):
        (WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed the change log entry for r79219.
rniwa@webkit.org [Mon, 21 Feb 2011 14:44:38 +0000 (14:44 +0000)]
Fixed the change log entry for r79219.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Alexander Pavlov <apavlov@chromium.org>
rniwa@webkit.org [Mon, 21 Feb 2011 14:42:10 +0000 (14:42 +0000)]
2011-02-21  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Audits] Image dimensions in inline style not checked
        https://bugs.webkit.org/show_bug.cgi?id=54738

        * inspector/audits/audits-panel-functional-expected.txt:
        * inspector/audits/audits-panel-functional.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 21 Feb 2011 14:40:30 +0000 (14:40 +0000)]
2011-02-21  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Audits] Image dimensions in inline style not checked
        https://bugs.webkit.org/show_bug.cgi?id=54738

        * inspector/audits/audits-panel-functional-expected.txt:
        * inspector/audits/audits-panel-functional.html:
2011-02-21  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Audits] Image dimensions in inline style not checked
        https://bugs.webkit.org/show_bug.cgi?id=54738

        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 21 Feb 2011 14:38:24 +0000 (14:38 +0000)]
2011-02-21  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: create and destroy DOM agent along with InspectorAgent
        https://bugs.webkit.org/show_bug.cgi?id=54875

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/InstrumentingAgents.h: Added. Agents that want to instrument WebCore should register themselve
        on this object.
        (WebCore::InstrumentingAgents::InstrumentingAgents):
        (WebCore::InstrumentingAgents::~InstrumentingAgents):
        (WebCore::InstrumentingAgents::inspectorBrowserDebuggerAgent):
        (WebCore::InstrumentingAgents::setInspectorBrowserDebuggerAgent):
        (WebCore::InstrumentingAgents::inspectorConsoleAgent):
        (WebCore::InstrumentingAgents::setInspectorConsoleAgent):
        (WebCore::InstrumentingAgents::inspectorDOMAgent):
        (WebCore::InstrumentingAgents::setInspectorDOMAgent):
        (WebCore::InstrumentingAgents::inspectorDOMStorageAgent):
        (WebCore::InstrumentingAgents::setInspectorDOMStorageAgent):
        (WebCore::InstrumentingAgents::inspectorDatabaseAgent):
        (WebCore::InstrumentingAgents::setInspectorDatabaseAgent):
        (WebCore::InstrumentingAgents::inspectorDebuggerAgent):
        (WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
        (WebCore::InstrumentingAgents::inspectorProfilerAgent):
        (WebCore::InstrumentingAgents::setInspectorProfilerAgent):
        (WebCore::InstrumentingAgents::inspectorResourceAgent):
        (WebCore::InstrumentingAgents::setInspectorResourceAgent):
        (WebCore::InstrumentingAgents::inspectorRuntimeAgent):
        (WebCore::InstrumentingAgents::setInspectorRuntimeAgent):
        (WebCore::InstrumentingAgents::inspectorStorageAgent):
        (WebCore::InstrumentingAgents::setInspectorStorageAgent):
        (WebCore::InstrumentingAgents::inspectorTimelineAgent):
        (WebCore::InstrumentingAgents::setInspectorTimelineAgent):
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        (WebCore::InspectorAgent::createFrontendLifetimeAgents):
        (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
        (WebCore::InspectorAgent::didCommitLoad):
        (WebCore::InspectorAgent::domContentLoadedEventFired):
        (WebCore::InspectorAgent::loadEventFired):
        * inspector/InspectorAgent.h:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::InspectorCSSAgent):
        (WebCore::InspectorCSSAgent::~InspectorCSSAgent):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
        (WebCore::InspectorConsoleAgent::clearConsoleMessages):
        (WebCore::InspectorConsoleAgent::clearFrontend):
        (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
        (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
        (WebCore::InspectorConsoleAgent::addConsoleMessage):
        * inspector/InspectorConsoleAgent.h:
        * inspector/InspectorDOMAgent.cpp: DOM agent now lives even when the front-end is not attached.
        (WebCore::InspectorDOMAgent::InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::setFrontend): Add DOM agent to the set of active agents when the front-end
        is attached.
        (WebCore::InspectorDOMAgent::clearFrontend):
        * inspector/InspectorDOMAgent.h:
        (WebCore::InspectorDOMAgent::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 21 Feb 2011 14:33:24 +0000 (14:33 +0000)]
2011-02-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79029.
        http://trac.webkit.org/changeset/79029
        https://bugs.webkit.org/show_bug.cgi?id=54869

        Revert unnecessary Chromium rebaseline (Requested by apavlov
        on #webkit).

        * platform/chromium-win/inspector/styles-update-from-js-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 21 Feb 2011 14:29:44 +0000 (14:29 +0000)]
2011-02-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] [REGRESSION] After r79130, spell tests did not work
        https://bugs.webkit.org/show_bug.cgi?id=54860

        * WebCoreSupport/TextCheckerClientEnchant.cpp:
        (WebKit::TextCheckerClientEnchant::checkSpellingOfString): Avoided
        freeing the default PangoLanguage.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings): Initialized list of dictionaries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 21 Feb 2011 14:16:18 +0000 (14:16 +0000)]
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Skip fast/events/menu-keydown-on-hidden-element.html on Mac WebKit 2 since it requires EventSender.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 21 Feb 2011 14:07:24 +0000 (14:07 +0000)]
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Remove incorrect Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 21 Feb 2011 13:27:42 +0000 (13:27 +0000)]
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Skip fast/events/selectionchange-user-initiated.html added by r79208 on Mac WebKit 2.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Kristian Amlie <kristian.amlie@nokia.com>
commit-queue@webkit.org [Mon, 21 Feb 2011 13:10:15 +0000 (13:10 +0000)]
2011-02-21  Kristian Amlie  <kristian.amlie@nokia.com>

        Reviewed by Andreas Kling.

        Switched to compiler based detection, where the error actually is.

        It is not the platform that needs the workaround, it is the compiler.

        QtWebKit fails to compile on Windows XP with msvc-2008
        https://bugs.webkit.org/show_bug.cgi?id=54746

        * bytecode/CodeBlock.h:
        * runtime/RegExpObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][V8]REGRESSION(r79157): Fix build
ossy@webkit.org [Mon, 21 Feb 2011 13:05:15 +0000 (13:05 +0000)]
[Qt][V8]REGRESSION(r79157): Fix build
https://bugs.webkit.org/show_bug.cgi?id=54871

Reviewed by Andreas Kling.

* bridge/npruntime_internal.h: Add one more undef because of evil X11 macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-16 Vitaly Repeshko <vitalyr@chromium.org>
vitalyr@chromium.org [Mon, 21 Feb 2011 11:49:41 +0000 (11:49 +0000)]
2011-02-16  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Mihai Parparita.

        [V8] SerializedScriptValue: fix JS exception handling.
        https://bugs.webkit.org/show_bug.cgi?id=54555

        Added checks for exceptions and empty handles:
        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::Serializer::Serializer):
        (WebCore::Serializer::serialize):
        (WebCore::Serializer::checkException):
        (WebCore::Serializer::reportFailure):
        (WebCore::Serializer::ArrayState::advance):
        (WebCore::Serializer::AbstractObjectState::AbstractObjectState):
        (WebCore::Serializer::AbstractObjectState::advance):
        (WebCore::Serializer::push):
        (WebCore::Serializer::handleError):
        (WebCore::Serializer::newObjectState):
        (WebCore::Serializer::doSerialize):
        (WebCore::SerializedScriptValue::SerializedScriptValue):

2011-02-16  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Mihai Parparita.

        [V8] SerializedScriptValue: fix JS exception handling.
        https://bugs.webkit.org/show_bug.cgi?id=54555

        Added an exception throwing test case:
        * fast/dom/Window/window-postmessage-clone-expected.txt:
        * fast/dom/Window/window-postmessage-clone.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 21 Feb 2011 11:24:41 +0000 (11:24 +0000)]
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Add selectionchange event
        https://bugs.webkit.org/show_bug.cgi?id=45712

        Added a test to ensure WebKit fires selectionchange event for the correct document
        when the document has an iframe, and a test to ensure selectionchange events are fired
        on user-initiated events.

        * fast/events/selectionchange-iframe-expected.txt: Added.
        * fast/events/selectionchange-iframe.html: Added.
        * fast/events/selectionchange-user-initiated-expected.txt: Added.
        * fast/events/selectionchange-user-initiated.html: Added.
2011-02-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Add selectionchange event
        https://bugs.webkit.org/show_bug.cgi?id=45712

        Added the support for asynchronous selectionchange event, which is fired whenever selection is changed.
        This event is not cancelable and does not bubble. An event listener can be attached to a document by
        body element's onselectionchange attribute or via document's onselectionchange property.

        Note that WebKit's implementation fires the event asynchronously whereas Internet Explorer's implementation
        fires it synchronously. This implies that a script that modify selection (e.g. via selection's addRange)
        will not observe the event before the control returns to JavaScript.

        See also: http://msdn.microsoft.com/en-us/library/ms536968(VS.85).aspx

        Tests: fast/events/selectionchange-iframe.html
               fast/events/selectionchange-user-initiated.html

        * dom/Document.cpp:
        (WebCore::Document::enqueueDocumentEvent): Added.
        * dom/Document.h: Added selectionchange event listener.
        * dom/Document.idl: Added onselectionchagne attribute.
        * dom/EventNames.h: Added selectionchange
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection): Fires selectionchange event.
        * html/HTMLAttributeNames.in: Added onselectionchange.
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute): Handles onselectionchange attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 21 Feb 2011 11:20:48 +0000 (11:20 +0000)]
Unreviewed.

REGRESSION(r79157): plugins/get-url-with-javascript-destroying-plugin.html make the next test crash
https://bugs.webkit.org/show_bug.cgi?id=54863

* platform/qt/Skipped: Unskip the innocent plugins/get-user-agent-with-null-npp-from-npp-new.html
and skip the real culprit plugins/get-url-with-javascript-destroying-plugin.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 21 Feb 2011 11:16:36 +0000 (11:16 +0000)]
2011-02-21  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: protocol error messages are dumping incorrectly in Layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=54859

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Feb 2011 11:12:51 +0000 (11:12 +0000)]
2011-02-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] inspector/debugger/dom-breakpoints.html TIMEOUTs
        https://bugs.webkit.org/show_bug.cgi?id=54638

        * http/tests/inspector/change-iframe-src.html:
        * http/tests/inspector/debugger-test.js:
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest):
        (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
        (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite.runner):
        (initialize_DebuggerTest.InspectorTest.runDebuggerTestSuite):
        (initialize_DebuggerTest.InspectorTest.waitUntilPaused):
        (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack.step1):
        (initialize_DebuggerTest.InspectorTest.waitUntilPausedAndDumpStack):
        (initialize_DebuggerTest.InspectorTest.waitUntilResumed):
        (initialize_DebuggerTest.InspectorTest.resumeExecution):
        (initialize_DebuggerTest.InspectorTest.showScriptSource):
        (initialize_DebuggerTest.InspectorTest._showScriptSource):
        (initialize_DebuggerTest.InspectorTest.expandProperties.expandNextPath):
        (initialize_DebuggerTest.InspectorTest.expandProperties):
        * http/tests/inspector/elements-test.js:
        (initialize_ElementTest.InspectorTest.nodeWithId.processChildren):
        (initialize_ElementTest.InspectorTest.nodeWithId):
        (initialize_ElementTest.InspectorTest.selectNodeWithId.mycallback):
        (initialize_ElementTest.InspectorTest.selectNodeWithId):
        (initialize_ElementTest.InspectorTest.expandElementsTree.mycallback):
        (initialize_ElementTest.InspectorTest.expandElementsTree):
        (initialize_ElementTest):
        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.evaluateInConsole):
        (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump.mycallback):
        (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump):
        (initialize_InspectorTest.InspectorTest.evaluateInPage.mycallback):
        (initialize_InspectorTest.InspectorTest.evaluateInPage):
        (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout):
        (initialize_InspectorTest.InspectorTest.reloadPage):
        (initialize_InspectorTest.InspectorTest.runAfterPendingDispatches):
        (initialize_InspectorTest.InspectorTest.runTestSuite.runner):
        (initialize_InspectorTest.InspectorTest.runTestSuite):
        (initialize_InspectorTest.InspectorTest.safeWrap):
        * http/tests/inspector/resource-parameters.html:
        * inspector/console/console-assert.html:
        * inspector/console/console-trace-in-eval.html:
        * inspector/console/console-trace.html:
        * inspector/debugger/dom-breakpoints-expected.txt:
        * inspector/debugger/dom-breakpoints.html:
        * inspector/extensions/extensions-audits-tests.js:
        (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits):
        (initialize_ExtensionsAuditsTest):
        * inspector/styles/styles-iframe.html:
        * inspector/styles/styles-update-from-js.html:
        * inspector/timeline/timeline-network-resource.html:
        * inspector/timeline/timeline-script-tag-1.html:
        * inspector/timeline/timeline-script-tag-2.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Feb 2011 11:03:19 +0000 (11:03 +0000)]
2011-02-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: generate protocol documentation based on IDL.
        https://bugs.webkit.org/show_bug.cgi?id=54822

        * inspector/CodeGeneratorInspector.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 21 Feb 2011 10:55:52 +0000 (10:55 +0000)]
2011-02-21  Alejandro G. Castro  <alex@igalia.com>

        Fixed typo in gtk Skipped list.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 21 Feb 2011 10:40:45 +0000 (10:40 +0000)]
Unreviewed.

[Qt]REGRESSION(r79157): plugins/get-user-agent-with-null-npp-from-npp-new.html crashes
https://bugs.webkit.org/show_bug.cgi?id=54863

Paper over one more regression to make Qt buildbot happy and green.

* platform/qt/Skipped: Add plugins/get-user-agent-with-null-npp-from-npp-new.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-18 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 21 Feb 2011 10:19:43 +0000 (10:19 +0000)]
2011-02-18  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] media/audio-delete-while-slider-thumb-clicked.html still flaky
        https://bugs.webkit.org/show_bug.cgi?id=54747

        * media/audio-delete-while-slider-thumb-clicked.html: Autoplay the
        media element and trigger the seek after playback started.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
philn@webkit.org [Mon, 21 Feb 2011 10:12:29 +0000 (10:12 +0000)]
2011-02-21  Andoni Morales Alastruey  <amorales@flumotion.com>

        Reviewed by Martin Robinson.

        [GStreamer] Add URI queries support in webkitwebsrc
        https://bugs.webkit.org/show_bug.cgi?id=54627

        This allow replying to URI queries from downstream elements
        with the uri currently set in the source element.

        No new tests, this feature is dedicated to internal GStreamer use,
        such as the upcoming HTTP Live Streaming element.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (webKitWebSrcQuery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 21 Feb 2011 10:11:15 +0000 (10:11 +0000)]
2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed expectation update.

        * platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
        * platform/chromium-linux/animations/3d/matrix-transform-type-animation-expected.png: Added.
        * platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
        * platform/chromium-mac/animations/3d/matrix-transform-type-animation-expected.png: Added.
        * platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.checksum: Added.
        * platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.png: Added.
        * platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 21 Feb 2011 09:58:54 +0000 (09:58 +0000)]
Unreviewed.

[Qt] Possible DRT bug revealed by r72003
https://bugs.webkit.org/show_bug.cgi?id=49538

After r79103 we don't need Qt specific expected results
$for these tests because of whitespace differences.

* platform/qt/fast/forms/formaction-attribute-expected.txt: Removed.
* platform/qt/fast/forms/formmethod-attribute-button-html-expected.txt: Removed.
* platform/qt/fast/forms/formtarget-attribute-button-html-expected.txt: Removed.
* platform/qt/fast/forms/mailto/formenctype-attribute-button-html-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Andoni Morales Alastruey <amorales@flumotion.com>
philn@webkit.org [Mon, 21 Feb 2011 09:33:16 +0000 (09:33 +0000)]
2011-02-21  Andoni Morales Alastruey  <amorales@flumotion.com>

        Reviewed by Martin Robinson.

        [GStreamer] Add 'location' property in webkitwebsrc
        https://bugs.webkit.org/show_bug.cgi?id=54628

        No new tests, this feature is dedicated to internal GStreamer use,
        such as the upcoming HTTP Live Streaming element.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (webkit_web_src_class_init):
        (webKitWebSrcSetProperty):
        (webKitWebSrcGetProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 21 Feb 2011 09:28:48 +0000 (09:28 +0000)]
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Done the rename. All calls to node() are replaced by calls to deprecatedNode().

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setComposition): Check the nullity of startContainer() instead of startPosition()->node().
        (WebKit::WebViewImpl::confirmComposition): Ditto.
        (WebKit::WebViewImpl::textInputType):
        (WebKit::WebViewImpl::caretOrSelectionBounds):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Replaced the call to node() by a call to containerNode() because the returned node is
        used to determine whether or not the selected contents are editable and such a check
        must be done against the container node.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleKeyboardEvent):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Done the rename. All calls to node() are replaced by calls to deprecatedNode().

        * webkit/webkitwebview.cpp:
        (webkit_web_view_popup_menu_handler):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        * WebView/WebFrame.mm:
        (-[WebFrame _smartDeleteRangeForProposedRange:]):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Replaced the call to node() by a call to containerNode() because the returned node is
        used to determine whether or not the selected contents are editable and such a check
        must be done against the container node.

        * WebCoreSupport/EditorClientHaiku.cpp:
        (WebCore::EditorClientHaiku::handleKeyboardEvent):
2011-02-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        Rename Position::node() to Position::deprecatedNode()
        https://bugs.webkit.org/show_bug.cgi?id=54622

        Done the rename. All calls to node() are replaced by calls to deprecatedNode() except when
        calls were of the form node()->document() and node()->inDocument() in which case they were
        replaced by anchorNode()->document() and anchorNode()->inDocument() respectively.

        * WebCore.exp.in: Added Position::containerNode.

        The rest abbreviated for simplicity. Please see svn log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 21 Feb 2011 09:00:14 +0000 (09:00 +0000)]
2011-02-21 MORITA Hajime  <morrita@google.com>

        Another unreviewed attempt to expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 21 Feb 2011 08:16:40 +0000 (08:16 +0000)]
2011-02-20  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add WebResourceCacheDataManager to the compilation after r78848
        https://bugs.webkit.org/show_bug.cgi?id=54732

        Added resource cache manager API to GTK+ compilation after r78848.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 21 Feb 2011 08:12:08 +0000 (08:12 +0000)]
2011-02-21  MORITA Hajime  <morrita@google.com>

        Unreviewed expectation update. (Removes invalid lines.)

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 21 Feb 2011 07:26:45 +0000 (07:26 +0000)]
2011-02-20 MORITA Hajime  <morrita@google.com>

        Unreviewed expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-16 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 07:21:32 +0000 (07:21 +0000)]
2011-02-16  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        keyboard support for extending/shrinking comment context
        https://bugs.webkit.org/show_bug.cgi?id=54612

        ctrl+shift+up/down will extend/shrink the comment context when
        a comment is focused or when one is being edited.

        Also, switch over to using keydown instead of keypress events.
        This lets us share code for handling escape and other key events.
        Also, keypress is evil and should die.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 07:09:28 +0000 (07:09 +0000)]
2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Recommit accidental revert.
        r79180 accidentally revereted r79178.
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 07:04:03 +0000 (07:04 +0000)]
2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] add more help information
        https://bugs.webkit.org/show_bug.cgi?id=54847

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 06:46:05 +0000 (06:46 +0000)]
2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] use 'r' to focus the review select element
        https://bugs.webkit.org/show_bug.cgi?id=54845

        This allows for quick keyboard access to the toolbar items.
        Hit r to get to the review select element. Then you can
        tab to the cq/preview/publish elements.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 06:41:43 +0000 (06:41 +0000)]
2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] don't let lines/diffblocks be mouse focusable
        https://bugs.webkit.org/show_bug.cgi?id=54851

        Unfortunately, this will only work once https://bugs.webkit.org/show_bug.cgi?id=54727
        is committed. In the interim, it won't break anything.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 06:39:45 +0000 (06:39 +0000)]
2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] use keydown instead of keypress
        https://bugs.webkit.org/show_bug.cgi?id=54849

        There is no functional change. This is just a cleanup
        to make future patches (e.g. https://bugs.webkit.org/show_bug.cgi?id=54612)
        cleaner.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 06:37:26 +0000 (06:37 +0000)]
2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] fix layout nit
        https://bugs.webkit.org/show_bug.cgi?id=54848

        There is occasionally an off-by-one in the 50% width
        calculation. This ensures that the add lines always
        line up with the shared context lines.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 21 Feb 2011 05:48:13 +0000 (05:48 +0000)]
2011-02-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        test-webkitpy: stop skipping a bunch of tests on win32
        https://bugs.webkit.org/show_bug.cgi?id=54788

        * Scripts/webkitpy/common/net/testoutputset_unittest.py:
        * Scripts/webkitpy/test/main.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 05:44:14 +0000 (05:44 +0000)]
2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] make escape hide the preview form
        https://bugs.webkit.org/show_bug.cgi?id=54844

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix (remove includes).
barraclough@apple.com [Mon, 21 Feb 2011 05:37:29 +0000 (05:37 +0000)]
Build fix (remove includes).

* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSHistoryCustom.cpp:
* bindings/js/JSLocationCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 05:37:03 +0000 (05:37 +0000)]
2011-02-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [codereviewtool] make enter work when an individual line is focused
        https://bugs.webkit.org/show_bug.cgi?id=54843

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=54839
barraclough@apple.com [Mon, 21 Feb 2011 05:18:40 +0000 (05:18 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=54839
Remove PrototypeFunction, NativeFunctionWrapper, and GlobalEvalFunction.

Reviewed by Oliver Hunt.

Historically, Native functions used to be represented by PrototypeFunctions, however
since introducing call optimizations to the JIT this has used JSFunctions for host
calls too. At the point this change was made, the interpreter continued to use
PrototypeFunctions, however since fallback from the JIT to interpreter was introduced
the interpreter has had to be able to run using host functions represented using
JSFunctions - leading to an unnecessary and redundant divergence in behaviour between
interpreter only builds, and situations where the JIT has fallen back to interpreting.

NativeFunctionWrapper only existed to select between PrototypeFunction and JSFunction
for wrappers for host functions, and as such can also be removed.

GlobalEvalFunction is a redundant wrapper that happens to be derived from
PrototypeFunction. It existed to hold a reference to the global object - but since all
functions how derive from JSObjectWithGlobalObject, this no longer requires an
additional class to provide this functionality.

Source/JavaScriptCore:

* JavaScriptCore.JSVALUE32_64only.exp:
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
    Removed symbols / references to files.

* runtime/GlobalEvalFunction.cpp: Removed.
* runtime/GlobalEvalFunction.h: Removed.
* runtime/NativeFunctionWrapper.h: Removed.
* runtime/PrototypeFunction.cpp: Removed.
* runtime/PrototypeFunction.h: Removed.
    Removed.

* runtime/Executable.cpp:
(JSC::NativeExecutable::~NativeExecutable):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::NativeExecutable):
(JSC::JSFunction::nativeFunction):
* runtime/JSFunction.cpp:
(JSC::callHostFunctionAsConstructor):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::getCallData):
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::getCTIStub):
    Added interpreter-friendly constructors for NativeExecutables.

* bytecompiler/BytecodeGenerator.cpp:
* interpreter/Interpreter.cpp:
* jit/JITStubs.cpp:
* jsc.cpp:
* runtime/ArrayConstructor.cpp:
* runtime/BooleanPrototype.cpp:
* runtime/BooleanPrototype.h:
* runtime/CallData.h:
* runtime/DateConstructor.cpp:
* runtime/DateConstructor.h:
* runtime/ErrorPrototype.cpp:
* runtime/ErrorPrototype.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSGlobalObjectFunctions.cpp:
* runtime/Lookup.cpp:
* runtime/NumberPrototype.cpp:
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
* runtime/ObjectPrototype.h:
* runtime/RegExpPrototype.cpp:
* runtime/RegExpPrototype.h:
* runtime/SmallStrings.h:
* runtime/StringConstructor.cpp:
* runtime/StringConstructor.h:
    Removed use of redundant classes.

Source/WebCore:

* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSHistoryCustom.cpp:
* bindings/js/JSLocationCustom.cpp:
    Removed use of redundant classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 21 Feb 2011 05:07:52 +0000 (05:07 +0000)]
2011-02-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        Fix various bugs related to handling of dir separators and real
        vs. fake filesystems that were causing test-webkitpy to fail
        tests on win32. These bugs have a variety of causes but are
        lumped together because they should be easy to review.

        https://bugs.webkit.org/show_bug.cgi?id=54700

        * Scripts/webkitpy/common/net/testoutput.py:
          Here we were using os.path.sep but not escaping it prior to
          using in a regexp, which  caused bad things on win32.
        * Scripts/webkitpy/common/net/testoutput_unittest.py:
          Same here.
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
          Here we were using the native filesystem instead of the mock
          filesystem, making some tests unnecessarily platform dependent.
          Also we weren't setting the default configuration for the
          TestChromiumWinPort.
        * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
          Here we *shouldn't* use os.path.join(), just so the code becomes
          less platform dependent.
        * Scripts/webkitpy/style/checker.py:
          Here we should be using os.path.sep instead of "/"; the tests
          require the native filesystem.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
          Here the underlying code is using os.path.sep, so we probably
          should as well.
        * Scripts/webkitpy/style/test_expectations_unittest.py:
          Here we should be using the filesystem hanging of the port
          object (which is the mocked filesystem) rather than the native
          one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 21 Feb 2011 04:59:28 +0000 (04:59 +0000)]
2011-02-20  MORITA Hajime  <morrita@google.com>

        Unreviewed expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Sheriff Bot <webkit.review.bot@gmail.com>
tkent@chromium.org [Mon, 21 Feb 2011 04:37:38 +0000 (04:37 +0000)]
2011-02-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79169.
        http://trac.webkit.org/changeset/79169
        https://bugs.webkit.org/show_bug.cgi?id=54846

        Made unexpected results for tests without CJK characters
        (Requested by tkent on #webkit).

        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
        (WebCore::FontPlatformData::orientation):
        * platform/graphics/skia/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Mon, 21 Feb 2011 03:58:09 +0000 (03:58 +0000)]
2011-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Fix coding style errors in tiled BS and ewk_window_feature.h
        https://bugs.webkit.org/show_bug.cgi?id=54842

        Fix style errors in ewk files.

        * ewk/ewk_tiled_backing_store.h:
        * ewk/ewk_tiled_matrix.h:
        * ewk/ewk_tiled_model.h:
        * ewk/ewk_window_features.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in WebProcess at com.apple.WebCore: WebCore::Page::goToItem + 46
weinig@apple.com [Mon, 21 Feb 2011 03:43:43 +0000 (03:43 +0000)]
Crash in WebProcess at com.apple.WebCore: WebCore::Page::goToItem + 46
<rdar://problem/8942726>

Reviewed by Dan Bernstein.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
Defend agains null HistoryItems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Chun-Lung Huang <alvincl.huang@gmail.com>
tkent@chromium.org [Mon, 21 Feb 2011 03:28:22 +0000 (03:28 +0000)]
2011-02-20  Chun-Lung Huang  <alvincl.huang@gmail.com>

        Reviewed by Kent Tamura.

        On Chromium Windows, glyphs in vertical text tests are rotated 90
        degrees clockwise. https://bugs.webkit.org/show_bug.cgi?id=51450

        This platform dependent patch makes Chromium Windows show the
        vertical writing text correctly. Job was done by adding a prefix '@'
        in front of the font family name (Windows Only). No new tests added.

        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.h:
        (WebCore::FontPlatformData::orientation):
        * platform/graphics/skia/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 21 Feb 2011 03:26:11 +0000 (03:26 +0000)]
2011-02-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dirk Schulze.

        REGRESSION (r73369-r73405): transform animation interpolates incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=54793

        After the refactoring in r73380, the ending state for some types of
        accelerated animations was computed incorrectly, because the TransformationMatrix
        wasn't reset to identity before the ending value transformations were applied.

        Fix by cleaning up the code to use explicit, separate values for
        starting and ending values. Only matrix-type animations had this
        issue, but cleaned up other clauses similarly.

        Test: animations/3d/matrix-transform-type-animation.html

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9028929> REGRESSION (r75897): Scaling applied twice to an iframe...
mitz@apple.com [Mon, 21 Feb 2011 03:06:48 +0000 (03:06 +0000)]
<rdar://problem/9028929> REGRESSION (r75897): Scaling applied twice to an iframe with a transformed ancestor

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/frames/iframe-scale-applied-twice.html

* page/FrameView.cpp:
(WebCore::FrameView::create): Set the initial bounds of the view to match the
frame size.
* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect): Based on bounds, not frame size.
(WebCore::ScrollView::updateScrollbars): Ditto.
(WebCore::ScrollView::setFrameRect): Moved code that really handles bounds size
change to setBoundsSize().
(WebCore::ScrollView::setBoundsSize): Added.
(WebCore::ScrollView::setInitialBoundsSize): Added. Sets the bounds size but does
not update anything.
(WebCore::ScrollView::frameRectsChanged): Based on bounds, not frame size.
(WebCore::ScrollView::scrollbarCornerPresent): Ditto.
* platform/ScrollView.h:
(WebCore::ScrollView::boundsSize): Added this getter.
* platform/Widget.h:
(WebCore::Widget::resize): Set the bounds size to the frame size.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint): Fixed an error in the indirect drawing code
path where the buffer rect was resized to capture only the damaged part, but was
still drawn in the original location.

LayoutTests:

* fast/frames/iframe-scale-applied-twice-expected.txt: Added.
* fast/frames/iframe-scale-applied-twice.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-17 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 02:45:29 +0000 (02:45 +0000)]
2011-02-17  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        use shift+j/k to focus next/previous line
        https://bugs.webkit.org/show_bug.cgi?id=54723

        Tested on a large Hyatt change to confirm it performed fine.
        (https://bugs.webkit.org/attachment.cgi?id=82533&action=review)

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-17 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 02:38:53 +0000 (02:38 +0000)]
2011-02-17  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        fix escape handling in code review tool
        https://bugs.webkit.org/show_bug.cgi?id=54722

        This broke with http://trac.webkit.org/changeset/78948.
        Apparently jquery events get a wrapped object that
        does not expose keyIdentifier.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-17 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 02:36:32 +0000 (02:36 +0000)]
2011-02-17  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        create comments when hitting enter with a focused diff
        https://bugs.webkit.org/show_bug.cgi?id=54719

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-17 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 21 Feb 2011 02:29:11 +0000 (02:29 +0000)]
2011-02-17  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        use actual browser focus in the code review tool
        https://bugs.webkit.org/show_bug.cgi?id=54726

        This makes keyboard handling play better with focusable element
        (i.e. links/textareas/buttons). Also, in theory, this makes
        the review tool more amenable to screen readers (I think).

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Ami Fischman <fischman@chromium.org>
commit-queue@webkit.org [Mon, 21 Feb 2011 02:20:54 +0000 (02:20 +0000)]
2011-02-20  Ami Fischman  <fischman@chromium.org>

        Reviewed by Kent Tamura.

        Remove flakiness from media/video-poster.html by using event callbacks
        instead of 100ms timeouts and hoping that states have transitioned in
        time (!).
        Removed seemingly-outdated BUG_DRT annotation from test_expectation.

        https://bugs.webkit.org/show_bug.cgi?id=54685
        http://crbug.com/60845

        * media/video-poster.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-21 Benjamin Kalman <kalman@chromium.org>
kalman@chromium.org [Mon, 21 Feb 2011 01:35:27 +0000 (01:35 +0000)]
2011-02-21 Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        Make editing/selection/extend-selection tests more human readable and hand-runnable
        https://bugs.webkit.org/show_bug.cgi?id=54712

        Three changes to achieve this:
          - Column-align the "right:", "left:", "forward:", and "backward:" labels in the output.
          - Add buttons to switch between LTR and RTL (the test will switch everything to RTL but LTR is useful).
          - Fix typo causing failing tests to have a js error (rather than layout error).

        Expected results need to change due to column alignment.

        * editing/selection/extend-selection-character-expected.txt:
        * editing/selection/extend-selection-word-expected.txt:
        * editing/selection/resources/extend-selection.js:
        (logMismatchingPositions):
        (runSelectionTestsWithGranularity):
        (getTestNodeContainer.createButton.button.onmousedown):
        (getTestNodeContainer.createButton):
        (getTestNodeContainer.createButtonToSwitchDirection):
        (getTestNodeContainer):
        (createNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Eric Seidel.
ap@apple.com [Mon, 21 Feb 2011 01:07:34 +0000 (01:07 +0000)]
    Reviewed by Eric Seidel.

        Tighten up access permissions by using libxslt API
        https://bugs.webkit.org/show_bug.cgi?id=52688
        <rdar://problem/8909191>

        * xml/XSLTProcessorLibxslt.cpp: (WebCore::XSLTProcessor::transformToString): We are only
        interested in a string result, so let libxslt know about that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 21 Feb 2011 00:35:34 +0000 (00:35 +0000)]
2011-02-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r79104.
        http://trac.webkit.org/changeset/79104
        https://bugs.webkit.org/show_bug.cgi?id=54835

        Might have caused flaky canaries (Requested by tonyg-cr on
        #webkit).

        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::canTakeNextToken):
        (WebCore::HTMLDocumentParser::pumpTokenizer):
        * html/parser/HTMLParserScheduler.cpp:
        (WebCore::isLayoutTimerActive):
        * html/parser/HTMLParserScheduler.h:
        (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
        * page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 21 Feb 2011 00:09:23 +0000 (00:09 +0000)]
2011-02-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej Stachowiak.

        Crash when a plug-in requests a javascript: url that destroys the plug-in
        https://bugs.webkit.org/show_bug.cgi?id=54837
        <rdar://problem/9005475>

        Add new plug-in test.

        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
        (PluginTest::NPN_GetURL):
        * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
        * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp: Added.
        (GetURLWithJavaScriptURLDestroyingPlugin::GetURLWithJavaScriptURLDestroyingPlugin):
        (GetURLWithJavaScriptURLDestroyingPlugin::NPP_New):
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2011-02-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej Stachowiak.

        Crash when a plug-in requests a javascript: url that destroys the plug-in
        https://bugs.webkit.org/show_bug.cgi?id=54837
        <rdar://problem/9005475>

        Add test.

        * plugins/get-url-with-javascript-destroying-plugin-expected.txt: Added.
        * plugins/get-url-with-javascript-destroying-plugin.html: Added.
2011-02-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej Stachowiak.

        Crash when a plug-in requests a javascript: url that destroys the plug-in
        https://bugs.webkit.org/show_bug.cgi?id=54837
        <rdar://problem/9005475>

        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::destroy):
        Null out m_pluginController.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::performJavaScriptURLRequest):
        Don't access the frame through m_pluginElement since it will be nulled out
        when the plug-in is destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sun, 20 Feb 2011 23:04:32 +0000 (23:04 +0000)]
2011-02-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Fix another crash when a plug-in is destroyed when evaluating JavaScript
        https://bugs.webkit.org/show_bug.cgi?id=54834
        <rdar://problem/9013384>

        This contains three separate fixes:

        - In unprotectPluginFromDestruction we can't just destroy the plug-in once
          the count reaches zero, because the plug-in might still have code executing
          on the stack. To fix this we use a zero-delay timer to defer destruction
          of the plug-in.

        - Trying to get the NPObject for the window using NPN_GetValue would return
          NPERR_NO_ERROR, even if the returned NPObject was null. Fix this to return
          NPERR_GENERIC_ERROR instead.

        - Protect the plug-in from destruction anytime an NPAPI call that sends a
          synchronous IPC message is made.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::PluginControllerProxy):
        (WebKit::PluginControllerProxy::destroy):
        (WebKit::PluginControllerProxy::unprotectPluginFromDestruction):
        * PluginProcess/PluginControllerProxy.h:
        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::PluginDestructionProtector::PluginDestructionProtector):
        (WebKit::NPN_GetValue):
        (WebKit::NPN_Evaluate):
        (WebKit::NPN_GetProperty):
        (WebKit::NPN_SetProperty):
        (WebKit::NPN_RemoveProperty):
        (WebKit::NPN_HasProperty):
        (WebKit::NPN_HasMethod):
        (WebKit::NPN_Enumerate):
        (WebKit::NPN_Construct):
        (WebKit::NPN_GetValueForURL):
        (WebKit::NPN_SetValueForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 20 Feb 2011 22:27:58 +0000 (22:27 +0000)]
2011-02-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG animation - analyze attribute type for animation
        https://bugs.webkit.org/show_bug.cgi?id=54542

        Check dynamic update of attributeName. The test fails at the moment, because of some wrong
        internal mapping. Tested update manually with gdb. Working on a fix to get this test pass
        as well.

        * svg/animations/animate-dynamic-update-attributeName-expected.txt: Added.
        * svg/animations/animate-dynamic-update-attributeName.html: Added.
        * svg/animations/script-tests/animate-dynamic-update-attributeName.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
2011-02-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG animation - analyze attribute type for animation
        https://bugs.webkit.org/show_bug.cgi?id=54542

        Analyze animated attribute type to determine the kind of animation. Removed enum PropertyType and replace it
        with AnimatedAttributeType instead. More cleanup of the animation code.
        Added missing fillAttributeToPropertyTypeMap() for SVGGElement.

        Use QualifiedName instead of AtomicStrings for attribute names. This makes it easier to handle animated attributes
        from a different namespace like xlink:href. The rest of the SVG code is using QualifiedNames as well.

        No change of functionality on the animation code. The changes for the <g>-element affect animateTransform. Sadly
        animateTransform is not supported by our SVG animation test script at the moment. Can still be tested manually
        with the W3C test suite in trunk.

        The change on SVGUseElement gets covered by animate-elem-39-t.svg

        Test: svg/animations/animate-dynamic-update-attributeName.html

        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::SVGAnimateElement):
        (WebCore::SVGAnimateElement::hasValidAttributeType):
        (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::inheritsFromProperty):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        (WebCore::SVGAnimateElement::resetToBaseValue):
        (WebCore::SVGAnimateElement::applyResultsToTarget):
        (WebCore::SVGAnimateElement::calculateDistance):
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::hasValidAttributeType):
        (WebCore::parsePoint):
        (WebCore::SVGAnimateMotionElement::resetToBaseValue):
        (WebCore::SVGAnimateMotionElement::calculateAnimatedValue):
        (WebCore::SVGAnimateMotionElement::calculateDistance):
        * svg/SVGAnimateMotionElement.h:
        * svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::hasValidAttributeType):
        (WebCore::SVGAnimateTransformElement::determineAnimatedAttributeType):
        (WebCore::SVGAnimateTransformElement::resetToBaseValue):
        (WebCore::SVGAnimateTransformElement::calculateAnimatedValue):
        (WebCore::SVGAnimateTransformElement::calculateFromAndByValues):
        (WebCore::SVGAnimateTransformElement::applyResultsToTarget):
        (WebCore::SVGAnimateTransformElement::calculateDistance):
        * svg/SVGAnimateTransformElement.h:
        * svg/SVGAnimationElement.cpp:
        (WebCore::parseKeyTimes):
        (WebCore::parseKeySplines):
        (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty):
        (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
        (WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced):
        (WebCore::solveEpsilon):
        (WebCore::SVGAnimationElement::calculatePercentFromKeyPoints):
        (WebCore::SVGAnimationElement::currentValuesFromKeyPoints):
        (WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
        (WebCore::SVGAnimationElement::startedActiveInterval):
        * svg/SVGAnimationElement.h:
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::fillAttributeToPropertyTypeMap):
        * svg/SVGGElement.cpp:
        (WebCore::SVGGElement::attributeToPropertyTypeMap):
        (WebCore::SVGGElement::fillAttributeToPropertyTypeMap): Added to fill the animated attribute map for this element.
        * svg/SVGGElement.h:
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::fillAttributeToPropertyTypeMap): Changed attribute type to AnimatedString for xlink:href.
        * svg/animation/SMILTimeContainer.cpp:
        (WebCore::SMILTimeContainer::baseValueFor):
        (WebCore::SMILTimeContainer::updateAnimations):
        * svg/animation/SMILTimeContainer.h:
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::SVGSMILElement):
        (WebCore::constructQualifiedName): Create a QualifiedName from a attribute name.
        (WebCore::SVGSMILElement::insertedIntoDocument): Update local varaible of attribute name.
        (WebCore::SVGSMILElement::removedFromDocument): Ditto.
        (WebCore::SVGSMILElement::attributeChanged): Ditto.
        * svg/animation/SVGSMILElement.h:
        (WebCore::SVGSMILElement::attributeName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBUILD FIX: Add missing UNUSED_PARAM() when !ENABLE(FULLSCREEN_API)
ddkilzer@apple.com [Sun, 20 Feb 2011 21:16:46 +0000 (21:16 +0000)]
BUILD FIX: Add missing UNUSED_PARAM() when !ENABLE(FULLSCREEN_API)

Not reviewed.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForFullScreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Sun, 20 Feb 2011 09:28:01 +0000 (09:28 +0000)]
2011-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement PlatformKeyboardEvent::getCurrentModifierState()
        https://bugs.webkit.org/show_bug.cgi?id=52880

        * platform/gtk/KeyEventGtk.cpp:
        (WebCore::PlatformKeyboardEvent::getCurrentModifierState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-20 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Sun, 20 Feb 2011 09:22:06 +0000 (09:22 +0000)]
2011-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Bump GTK+3 dependency to 3.0
        https://bugs.webkit.org/show_bug.cgi?id=54394

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSet the svn:mime-type property of some PNG files to image/png
mitz@apple.com [Sun, 20 Feb 2011 08:50:07 +0000 (08:50 +0000)]
Set the svn:mime-type property of some PNG files to image/png

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-19 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 20 Feb 2011 03:10:29 +0000 (03:10 +0000)]
2011-02-19  Andreas Kling  <kling@webkit.org>

        Reviewed by Oliver Hunt.

        DragController should use Color::serialized() when passing colors to CSSStyleDeclaration
        https://bugs.webkit.org/show_bug.cgi?id=54545

        * page/DragController.cpp:
        (WebCore::DragController::concludeEditDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Sun, 20 Feb 2011 01:00:32 +0000 (01:00 +0000)]
2011-02-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix for Symbian.

        [Symbian] Revert the removal of linking
        against hal after r79126.

        Dependency on the hal library can not be removed
        as it is still used (e.g. in MarkStackSymbian.cpp).

        * JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-19 Lukasz Slachciak <l.slachciak@samsung.com>
commit-queue@webkit.org [Sun, 20 Feb 2011 00:44:42 +0000 (00:44 +0000)]
2011-02-19  Lukasz Slachciak  <l.slachciak@samsung.com>

        Reviewed by Andreas Kling.

        [EFL] Eliminated error when .webkit directory doesn't exist.
        https://bugs.webkit.org/show_bug.cgi?id=54813

        * ewk/ewk_main.cpp:
        (_ewk_init_body):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInterpreter build fix.
barraclough@apple.com [Sun, 20 Feb 2011 00:05:44 +0000 (00:05 +0000)]
Interpreter build fix.

* runtime/ArrayConstructor.cpp:
* runtime/BooleanPrototype.cpp:
* runtime/DateConstructor.cpp:
* runtime/ErrorPrototype.cpp:
* runtime/FunctionPrototype.cpp:
* runtime/Lookup.cpp:
* runtime/NumberPrototype.cpp:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectPrototype.cpp:
* runtime/RegExpPrototype.cpp:
* runtime/StringConstructor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd phase in addition to momentumPhase to platform wheel events
weinig@apple.com [Sat, 19 Feb 2011 23:59:55 +0000 (23:59 +0000)]
Add phase in addition to momentumPhase to platform wheel events
Part of <rdar://problem/8945362>

Reviewed by Anders Carlsson.

Rename existing phase to momentumPhase.

../WebCore:

* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::momentumPhase):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::handleWheelEvent):
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
* platform/mac/WheelEventMac.mm:
(WebCore::momentumPhaseForEvent):
(WebCore::phaseForEvent):
(WebCore::PlatformWheelEvent::PlatformWheelEvent):

../WebKit2:

* Shared/WebEvent.h:
(WebKit::WebWheelEvent::momentumPhase):
* Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
* Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
* Shared/mac/WebEventFactory.mm:
(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
(WebKit::WebEventFactory::createWebWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoQt build fix.
barraclough@apple.com [Sat, 19 Feb 2011 22:41:03 +0000 (22:41 +0000)]
Qt build fix.

* bridge/runtime_method.h:
(JSC::RuntimeMethod::createStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoQt build fix.
barraclough@apple.com [Sat, 19 Feb 2011 22:32:28 +0000 (22:32 +0000)]
Qt build fix.

* bridge/qt/qt_instance.cpp:
* bridge/qt/qt_pixmapruntime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix!!
barraclough@apple.com [Sat, 19 Feb 2011 22:27:41 +0000 (22:27 +0000)]
Build fix!!

* JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix!!
barraclough@apple.com [Sat, 19 Feb 2011 22:24:37 +0000 (22:24 +0000)]
Windows build fix!!

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoQt build fix.
barraclough@apple.com [Sat, 19 Feb 2011 22:18:39 +0000 (22:18 +0000)]
Qt build fix.

* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getMethod):
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapInstance::getMethod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix!
barraclough@apple.com [Sat, 19 Feb 2011 22:12:57 +0000 (22:12 +0000)]
Windows build fix!

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix!
barraclough@apple.com [Sat, 19 Feb 2011 22:04:48 +0000 (22:04 +0000)]
Build fix!

* JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-19 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 19 Feb 2011 21:57:28 +0000 (21:57 +0000)]
2011-02-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Crash when trying to take a snapshot of an uninitialized plug-in
        https://bugs.webkit.org/show_bug.cgi?id=54812

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::notifyWidget):
        Don't try to create a snapshot of the plug-in if it hasn't been initialized.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 54786 - Devirtualize JSCell::classInfo()
barraclough@apple.com [Sat, 19 Feb 2011 21:55:44 +0000 (21:55 +0000)]
Bug 54786 - Devirtualize JSCell::classInfo()

Reviewed by Sam Weinig.

Instead of making a virtual function call, add a pointer to the ClassInfo
onto Structure.

This removes a virtual function call, and paves the way towards removing all
the createStructure methods, and StructureFlags/AnonymousSlotCount properties
(these should be able to move onto ClassInfo).

Calls to Structure::create must now pass a pointer to the ClassInfo for the
structure. All objects now have a ClassInfo pointer, non-object cell types
still do not.

Changes are most mechanical, involving three steps:
    * Remove virtual classInfo() methods.
    * Add &s_info parameter to calls to Structure::create.
    * Rename ClassInfo static members on classes from 'info' to 's_info',
      for consistency.

Source/JavaScriptCore:

* API/JSCallbackConstructor.cpp:
* API/JSCallbackConstructor.h:
* API/JSCallbackFunction.cpp:
* API/JSCallbackFunction.h:
* API/JSCallbackObject.cpp:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* API/JSObjectRef.cpp:
* API/JSValueRef.cpp:
* API/JSWeakObjectMapRefPrivate.cpp:
* JavaScriptCore.exp:
* debugger/Debugger.cpp:
* debugger/DebuggerActivation.h:
* debugger/DebuggerCallFrame.cpp:
* interpreter/Interpreter.cpp:
* jit/JITCall32_64.cpp:
* jit/JITOpcodes.cpp:
* jit/JITStubs.cpp:
* profiler/Profiler.cpp:
* runtime/Arguments.cpp:
* runtime/Arguments.h:
* runtime/ArrayConstructor.cpp:
* runtime/ArrayPrototype.cpp:
* runtime/ArrayPrototype.h:
* runtime/BooleanObject.cpp:
* runtime/BooleanObject.h:
* runtime/BooleanPrototype.cpp:
* runtime/DateConstructor.cpp:
* runtime/DateInstance.cpp:
* runtime/DateInstance.h:
* runtime/DatePrototype.cpp:
* runtime/DatePrototype.h:
* runtime/ErrorInstance.cpp:
* runtime/ErrorInstance.h:
* runtime/ErrorPrototype.cpp:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:
* runtime/GetterSetter.h:
* runtime/GlobalEvalFunction.h:
* runtime/InternalFunction.cpp:
* runtime/InternalFunction.h:
* runtime/JSAPIValueWrapper.h:
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
* runtime/JSObject.h:
* runtime/JSObjectWithGlobalObject.h:
* runtime/JSPropertyNameIterator.h:
* runtime/JSStaticScopeObject.h:
* runtime/JSString.h:
* runtime/JSVariableObject.h:
* runtime/JSWrapperObject.h:
* runtime/JSZombie.cpp:
* runtime/JSZombie.h:
* runtime/Lookup.cpp:
* runtime/MathObject.cpp:
* runtime/MathObject.h:
* runtime/NativeErrorConstructor.cpp:
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
* runtime/NumberConstructor.h:
* runtime/NumberObject.cpp:
* runtime/NumberObject.h:
* runtime/NumberPrototype.cpp:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectPrototype.cpp:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpConstructor.h:
* runtime/RegExpObject.cpp:
* runtime/RegExpObject.h:
* runtime/RegExpPrototype.cpp:
* runtime/ScopeChain.cpp:
* runtime/StringConstructor.cpp:
* runtime/StringObject.cpp:
* runtime/StringObject.h:
* runtime/StringObjectThatMasqueradesAsUndefined.h:
* runtime/StringPrototype.cpp:
* runtime/StringPrototype.h:
* runtime/Structure.cpp:
* runtime/Structure.h:

Source/JavaScriptGlue:

* JSUtils.cpp:
(KJSValueToJSObject):
(KJSValueToCFTypeInternal):
* UserObjectImp.cpp:
* UserObjectImp.h:
(UserObjectImp::createStructure):

Source/WebCore:

* WebCore.exp.in:
* bindings/js/JSAudioConstructor.cpp:
* bindings/js/JSAudioConstructor.h:
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDOMGlobalObject.cpp:
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowShell.cpp:
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSGeolocationCustom.cpp:
* bindings/js/JSImageConstructor.cpp:
* bindings/js/JSImageConstructor.h:
* bindings/js/JSImageDataCustom.cpp:
* bindings/js/JSOptionConstructor.cpp:
* bindings/js/JSOptionConstructor.h:
* bindings/js/JSWorkerContextBase.cpp:
* bindings/js/JSWorkerContextBase.h:
* bindings/js/SerializedScriptValue.cpp:
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/c/CRuntimeObject.cpp:
* bridge/c/CRuntimeObject.h:
* bridge/c/c_instance.cpp:
* bridge/jni/jsc/JNIUtilityPrivate.cpp:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
* bridge/jni/jsc/JavaRuntimeObject.cpp:
* bridge/jni/jsc/JavaRuntimeObject.h:
* bridge/jsc/BridgeJSC.cpp:
* bridge/objc/ObjCRuntimeObject.h:
* bridge/objc/ObjCRuntimeObject.mm:
* bridge/objc/objc_instance.mm:
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
* bridge/runtime_array.cpp:
* bridge/runtime_array.h:
* bridge/runtime_method.cpp:
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
* bridge/runtime_object.h:

Source/WebKit/mac:

* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
(WebKit::ProxyRuntimeMethod::createStructure):
* Plugins/Hosted/ProxyRuntimeObject.h:
(WebKit::ProxyRuntimeObject::createStructure):
* Plugins/Hosted/ProxyRuntimeObject.mm:
(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
* WebView/WebView.mm:
(aeDescFromJSValue):

Source/WebKit2:

* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::JSNPMethod):
* WebProcess/Plugins/Netscape/JSNPMethod.h:
(WebKit::JSNPMethod::createStructure):
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::JSNPObject):
* WebProcess/Plugins/Netscape/JSNPObject.h:
(WebKit::JSNPObject::createStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/54808> Change jsc target to build directly into JavaScriptCore...
ddkilzer@apple.com [Sat, 19 Feb 2011 21:15:23 +0000 (21:15 +0000)]
<webkit.org/b/54808> Change jsc target to build directly into JavaScriptCore.framework/Resources/jsc

Reviewed by Dan Bernstein.

* Configurations/Base.xcconfig: Added
JAVASCRIPTCORE_FRAMEWORKS_DIR variable.
* Configurations/JavaScriptCore.xcconfig: Used
JAVASCRIPTCORE_FRAMEWORKS_DIR to define INSTALL_PATH.
* JavaScriptCore.xcodeproj/project.pbxproj: Set the INSTALL_PATH
for Production configuration of jsc target.
(Copy Into Framework): Removed old build phase.
(Fix Framework Reference): Renamed build phase to "Copy Into
Framework".  Added "set -x" call to make the script print the
commands it is running.  Added code to exit early for Production
builds since this was never intended for them.  Added code to
copy jsc into the JavaScriptCore.framework/Resources directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-19 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Sat, 19 Feb 2011 21:06:04 +0000 (21:06 +0000)]
2011-02-19  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Martin Robinson.

        [GTK] Remove mandatory Enchant dependency
        https://bugs.webkit.org/show_bug.cgi?id=51587

        Add enable-spellcheck option which decides whether to use enchant.
        If disabled, WebKitGTK+ will not use enchant library.

        * configure.ac:
2011-02-19  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Martin Robinson.

        [GTK] Remove mandatory Enchant dependency
        https://bugs.webkit.org/show_bug.cgi?id=51587

        Extract TextCheckerClientEnchant From EditorClientGtk and remove
        enchant dependency from other files.

        * GNUmakefile.am:
        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::EditorClient):
        * WebCoreSupport/EditorClientGtk.h:
        (WebKit::EditorClient::textChecker):
        * WebCoreSupport/TextCheckerClientEnchant.cpp: Added.
        (WebKit::TextCheckerClientEnchant::TextCheckerClientEnchant):
        (WebKit::TextCheckerClientEnchant::~TextCheckerClientEnchant):
        (WebKit::TextCheckerClientEnchant::ignoreWordInSpellDocument):
        (WebKit::TextCheckerClientEnchant::learnWord):
        (WebKit::TextCheckerClientEnchant::checkSpellingOfString):
        (WebKit::TextCheckerClientEnchant::getAutoCorrectSuggestionForMisspelledWord):
        (WebKit::TextCheckerClientEnchant::checkGrammarOfString):
        (WebKit::TextCheckerClientEnchant::getGuessesForWord):
        (WebKit::getAvailableDictionariesCallback):
        (WebKit::TextCheckerClientEnchant::updateSpellCheckingLanguage):
        (WebKit::TextCheckerClientEnchant::freeSpellCheckingLanguage):
        * WebCoreSupport/TextCheckerClientEnchant.h: Added.
        (WebKit::TextCheckerClientEnchant::requestCheckingOfString):
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_finalize):
        (webkit_web_settings_set_property):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_settings_notify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-19 Zan Dobersek <zandobersek@gmail.com>
commit-queue@webkit.org [Sat, 19 Feb 2011 20:28:47 +0000 (20:28 +0000)]
2011-02-19  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Martin Robinson.

        [cairo][canvas] Drawing from/into float rectangles with width or height in range 0 to 1 fails
        https://bugs.webkit.org/show_bug.cgi?id=54491

        Enable another passing test after fixing float values rounding.

        * platform/gtk/Skipped:
2011-02-19  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Martin Robinson.

        [cairo][canvas] Drawing from/into float rectangles with width or height in range 0 to 1 fails
        https://bugs.webkit.org/show_bug.cgi?id=54491

        When width or height in float rectangle are in range (0, 0.5) or (-0.5, 0)
        and would round to 0, alter the behaviour to ensure that width or height are
        at least 1 pixel in size in these cases.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::roundToDevicePixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLLVM Compiler build fix.
mitz@apple.com [Sat, 19 Feb 2011 20:12:32 +0000 (20:12 +0000)]
LLVM Compiler build fix.

* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::blurLayerImage): Eliminated a file static that generated
a global initializer since the compiler does not evaluate sqrtf at compile time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename performLookupAtCurrentMouseLocation to performDictionaryLookupAtCurrentMouseLo...
weinig@apple.com [Sat, 19 Feb 2011 19:05:26 +0000 (19:05 +0000)]
Rename performLookupAtCurrentMouseLocation to performDictionaryLookupAtCurrentMouseLocation

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView performDictionaryLookupAtCurrentMouseLocation]):
* UIProcess/API/mac/WKViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-19 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Sat, 19 Feb 2011 18:05:16 +0000 (18:05 +0000)]
2011-02-19  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Symbian] OSAllocator implementation for Symbian OS.
        Manages both data and code region requests. V8 and Sunspider tested
        OK with interpreter. Not tested with JSC JIT yet as it has unrelated
        failures. Also no thread safety yet.
        https://bugs.webkit.org/show_bug.cgi?id=51128

        * JavaScriptCore.pri: removed HAL linkage
        * wtf/Bitmap.h:
        (WTF::::findRunOfZeros): find run of zeros in a bitmap. quick n dirty
        * wtf/OSAllocator.h:
        (WTF::OSAllocator::decommitAndRelease): decommit explicitly
        * wtf/OSAllocatorSymbian.cpp: Impl. of OSAllocator interface
        (WTF::allocateCodeChunk): utility for code chunks
        (WTF::deallocateCodeChunk): utility for code chunks
        (WTF::dataAllocatorInstance): getter for data allocator instance
        (WTF::OSAllocator::reserveUncommitted):
        (WTF::OSAllocator::releaseDecommitted):
        (WTF::OSAllocator::commit):
        (WTF::OSAllocator::decommit):
        (WTF::OSAllocator::reserveAndCommit):
        (WTF::PageAllocatorSymbian::PageAllocatorSymbian): maps requests
        to one underlying Symbian chunk
        (WTF::PageAllocatorSymbian::~PageAllocatorSymbian):
        (WTF::PageAllocatorSymbian::reserve):
        (WTF::PageAllocatorSymbian::release):
        (WTF::PageAllocatorSymbian::commit):
        (WTF::PageAllocatorSymbian::decommit):
        (WTF::PageAllocatorSymbian::contains):
        * wtf/PageAllocatorSymbian.h: Added.
        (WTF::SymbianChunk::SymbianChunk): wrapper around RChunk
        (WTF::SymbianChunk::~SymbianChunk):
        (WTF::SymbianChunk::contains):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-19 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Sat, 19 Feb 2011 16:06:32 +0000 (16:06 +0000)]
2011-02-19  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, fixed typo in the GTK+ skipped file.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-19 Yong Li <yoli@rim.com>
commit-queue@webkit.org [Sat, 19 Feb 2011 16:06:25 +0000 (16:06 +0000)]
2011-02-19  Yong Li  <yoli@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=54687
        When being built with armcc, "int" bit fields are treated as
        unsigned integers, which will fail the comparisons like "m_offset == -1".
        Using "signed" fixes the problem.

        * assembler/ARMAssembler.h:
        * assembler/ARMv7Assembler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@79124 268f45cc-cd09-0410-ab3c-d52691b4dbfc