commit-queue@webkit.org [Tue, 5 Apr 2011 15:10:18 +0000 (15:10 +0000)]
2011-04-05 Leandro Gracia Gil <leandrogracia@chromium.org>
Reviewed by Steve Block.
Factoring the creation of 'FunctionOnly' callbacks in V8.
https://bugs.webkit.org/show_bug.cgi?id=57760
This method creates a template from an existing functionality in V8GeolocationCustom.cpp
to V8Utilities to be used by the custom bindings of both Geolocation and the Media Stream API.
No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html
* bindings/v8/V8Utilities.cpp:
(WebCore::throwTypeMismatchException):
* bindings/v8/V8Utilities.h:
(WebCore::createFunctionOnlyCallback):
* bindings/v8/custom/V8GeolocationCustom.cpp:
(WebCore::V8Geolocation::getCurrentPositionCallback):
(WebCore::V8Geolocation::watchPositionCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 5 Apr 2011 15:07:22 +0000 (15:07 +0000)]
2011-04-05 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] Make WebKitLibraries optional for building QtWebKit
https://bugs.webkit.org/show_bug.cgi?id=57542
* Scripts/build-webkit:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 5 Apr 2011 14:48:14 +0000 (14:48 +0000)]
2011-04-05 Chang Shu <cshu@webkit.org>
Reviewed by Laszlo Gombos.
[Qt] MiniBrowser defaultUrl does not work
https://bugs.webkit.org/show_bug.cgi?id=57021
Match the behavior and coding of MiniBrowser to QtTestBrowser.
* MiniBrowser/qt/main.cpp:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
chang.shu@nokia.com [Tue, 5 Apr 2011 14:23:47 +0000 (14:23 +0000)]
2011-04-05 Chang Shu <cshu@webkit.org>
Unreviewed.
Unskip passed tests after bugs 57572, 57568, 42540, 42692 have been resolved.
* platform/qt-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Tue, 5 Apr 2011 13:40:06 +0000 (13:40 +0000)]
2011-04-05 Alejandro G. Castro <alex@igalia.com>
Another compilation fix after r82929 horrible patch merge.
* UIProcess/WebPageProxy.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 5 Apr 2011 13:39:52 +0000 (13:39 +0000)]
2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Andreas Kling.
Switch from Vector<UChar> to StringBuilder in bindings/
https://bugs.webkit.org/show_bug.cgi?id=57838
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyName):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyInfo):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 5 Apr 2011 13:38:17 +0000 (13:38 +0000)]
2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Andreas Kling.
Switch from Vector<UChar> to StringBuilder in accessibility/
https://bugs.webkit.org/show_bug.cgi?id=57837
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityDescriptionForElements):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Tue, 5 Apr 2011 13:26:46 +0000 (13:26 +0000)]
2011-04-05 Alejandro G. Castro <alex@igalia.com>
Fix compilation error after r82929.
* WebProcess/WebPage/WebPage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 5 Apr 2011 13:24:16 +0000 (13:24 +0000)]
2011-04-05 Andrey Adaikin <aandrey@google.com>
Reviewed by Pavel Feldman.
Web Inspector: Scripts with syntax errors are cropped in the UI
https://bugs.webkit.org/show_bug.cgi?id=57828
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.addMessageToSource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Tue, 5 Apr 2011 13:08:16 +0000 (13:08 +0000)]
2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Andreas Kling.
Cleanup StringConcatenate
https://bugs.webkit.org/show_bug.cgi?id=57836
Don't use PassRefPtr in local variables, properly store in RefPtrs and release on return.
Add a makeString() variant taking 9 arguments, needed by a follow-up patch.
* wtf/text/StringConcatenate.h:
(WTF::tryMakeString):
(WTF::makeString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Tue, 5 Apr 2011 13:07:30 +0000 (13:07 +0000)]
2011-04-05 Jade Han <jade.han@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [Symbian] Disable WebKitTestRunner for Symbian
https://bugs.webkit.org/show_bug.cgi?id=54977
This change is a preparation to enable building webkit2 for Symbian.
Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
* Tools.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Tue, 5 Apr 2011 12:54:19 +0000 (12:54 +0000)]
2011-04-05 Amruth Raj <amruthraj@motorola.com>, Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> and Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement WebPage class for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=54230
Added functions to handle the generation of commands from the
keycodes.
* GNUmakefile.am:
* Scripts/webkit2/messages.py:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::getEditorCommandsForKeyEvent):
* UIProcess/gtk/WebView.cpp:
(WebKit::backspaceCallback):
(WebKit::selectAllCallback):
(WebKit::cutClipboardCallback):
(WebKit::copyClipboardCallback):
(WebKit::pasteClipboardCallback):
(WebKit::toggleOverwriteCallback):
(WebKit::popupMenuCallback):
(WebKit::showHelpCallback):
(WebKit::deleteFromCursorCallback):
(WebKit::moveCursorCallback):
(WebKit::WebView::WebView):
(WebKit::WebView::getEditorCommandsForKeyEvent):
* UIProcess/gtk/WebView.h:
(WebKit::WebView::addPendingEditorCommand):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp: Added.
(WebKit::WebEditorClient::getEditorCommandsForKeyEvent):
(WebKit::WebEditorClient::executePendingEditorCommands):
(WebKit::WebEditorClient::handleKeyboardEvent):
(WebKit::WebEditorClient::handleInputMethodKeydown):
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/gtk/WebPageGtk.cpp: Added.
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::platformPreferencesDidChange):
(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::platformCanHandleRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 5 Apr 2011 12:52:05 +0000 (12:52 +0000)]
2011-04-05 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, add chromium-linux expectation for fast/ruby/overhang-vertical.html (the test changed in r82903).
* platform/chromium-linux/fast/ruby/overhang-vertical-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Tue, 5 Apr 2011 12:43:40 +0000 (12:43 +0000)]
[Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
https://bugs.webkit.org/show_bug.cgi?id=57832
Reviewed by Andreas Kling.
Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
* MiniBrowser/qt/UrlLoader.cpp:
(UrlLoader::UrlLoader):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 5 Apr 2011 12:04:47 +0000 (12:04 +0000)]
2011-04-05 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, revert bad rebaseline of english-lr-text-expected.html in r82918.
* platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 5 Apr 2011 11:45:29 +0000 (11:45 +0000)]
2011-04-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Remove onformchange and onforminput events/event handlers
https://bugs.webkit.org/show_bug.cgi?id=55755
<rdar://problem/9087969>
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-property-descriptors-expected.txt:
* fast/forms/formchange-event-expected.txt: Removed.
* fast/forms/formchange-event.html: Removed.
* fast/forms/forminput-event-expected.txt: Removed.
* fast/forms/forminput-event.html: Removed.
* fast/forms/script-tests/formchange-event.js: Removed.
* fast/forms/script-tests/forminput-event.js: Removed.
2011-04-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
Remove onformchange and onforminput events/event handlers
https://bugs.webkit.org/show_bug.cgi?id=55755
<rdar://problem/9087969>
Covered by existing tests.
* dom/Document.h:
* dom/Document.idl:
* dom/Element.h:
* dom/Element.idl:
* dom/Event.cpp:
(WebCore::Event::fromUserGesture):
* dom/EventNames.h:
* html/FormAssociatedElement.h:
* html/HTMLAttributeNames.in:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
* html/HTMLElement.h:
* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::isEnumeratable):
* html/HTMLFormElement.cpp:
* html/HTMLFormElement.h:
* html/HTMLFormElement.idl:
* html/HTMLInputElement.h:
* html/HTMLKeygenElement.h:
* html/HTMLObjectElement.h:
(WebCore::HTMLObjectElement::isEnumeratable):
* html/HTMLOutputElement.h:
(WebCore::HTMLOutputElement::isEnumeratable):
* html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::isEnumeratable):
* html/HTMLTextAreaElement.h:
(WebCore::HTMLTextAreaElement::isEnumeratable):
* page/DOMWindow.h:
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 5 Apr 2011 11:28:13 +0000 (11:28 +0000)]
2011-04-05 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, rebaseline Kusa-Makura-background-canvas.html on chromium-mac after r82903.
* platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Removed.
* platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum: Removed.
* platform/chromium-mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 5 Apr 2011 11:08:45 +0000 (11:08 +0000)]
2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82915.
http://trac.webkit.org/changeset/82915
https://bugs.webkit.org/show_bug.cgi?id=57825
Broke 270 chromium tests on win and linux (Requested by
podivilov on #webkit).
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::defaultGUIFont):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Tue, 5 Apr 2011 11:07:20 +0000 (11:07 +0000)]
2011-04-05 Zoltan Horvath <zoltan@webkit.org>
[Qt] Linux Release minimal build fix after r82919.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::loadURLListFromFile):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::loadURLListFromFile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 5 Apr 2011 10:58:52 +0000 (10:58 +0000)]
2011-04-05 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, remove unnecessary checksum files for fast/ruby tests.
* platform/chromium-linux/fast/blockflow/english-lr-text-expected.checksum: Removed.
* platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.checksum: Removed.
* platform/chromium-linux/fast/ruby/ruby-length-expected.checksum: Removed.
* platform/chromium-linux/fast/ruby/ruby-run-break-expected.checksum: Removed.
* platform/chromium-linux/fast/ruby/ruby-runs-expected.checksum: Removed.
* platform/chromium-linux/fast/ruby/ruby-runs-spans-expected.checksum: Removed.
* platform/chromium-linux/fast/ruby/ruby-trailing-expected.checksum: Removed.
* platform/chromium-linux/fast/ruby/rubyDOM-insert-rt-expected.checksum: Removed.
* platform/chromium-linux/fast/ruby/rubyDOM-insert-text1-expected.checksum: Removed.
* platform/chromium-linux/fast/ruby/rubyDOM-insert-text2-expected.checksum: Removed.
* platform/chromium-linux/fast/ruby/rubyDOM-insert-text3-expected.checksum: Removed.
* platform/chromium-linux/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Removed.
* platform/chromium-linux/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Removed.
* platform/chromium-linux/fast/ruby/rubyDOM-remove-text1-expected.checksum: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 5 Apr 2011 10:35:36 +0000 (10:35 +0000)]
[Qt] fast/ruby/overhang* tests fail
https://bugs.webkit.org/show_bug.cgi?id=57824
* platform/qt/Skipped:Add fast/ruby/overhang-horizontal.html and fast/ruby/overhang-vertical.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Tue, 5 Apr 2011 10:35:20 +0000 (10:35 +0000)]
2011-04-05 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Andreas Kling.
[Qt] Make URL loader accessible from testbrowser's menus
https://bugs.webkit.org/show_bug.cgi?id=57823
Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::loadURLListFromFile):
(BrowserWindow::~BrowserWindow):
* MiniBrowser/qt/BrowserWindow.h:
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::LauncherWindow):
(LauncherWindow::~LauncherWindow):
(LauncherWindow::createChrome):
(LauncherWindow::loadURLListFromFile):
* QtTestBrowser/launcherwindow.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 5 Apr 2011 10:26:12 +0000 (10:26 +0000)]
2011-04-05 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, update fast/ruby/* chromium expectations after r82903.
* platform/chromium-linux/fast/ruby/ruby-beforeafter-expected.png:
* platform/chromium-linux/fast/ruby/ruby-length-expected.png:
* platform/chromium-linux/fast/ruby/ruby-run-break-expected.png:
* platform/chromium-linux/fast/ruby/ruby-runs-expected.png:
* platform/chromium-linux/fast/ruby/ruby-runs-spans-expected.png:
* platform/chromium-linux/fast/ruby/ruby-trailing-expected.png:
* platform/chromium-linux/fast/ruby/rubyDOM-insert-rt-expected.png:
* platform/chromium-linux/fast/ruby/rubyDOM-insert-text1-expected.png:
* platform/chromium-linux/fast/ruby/rubyDOM-insert-text2-expected.png:
* platform/chromium-linux/fast/ruby/rubyDOM-insert-text3-expected.png:
* platform/chromium-linux/fast/ruby/rubyDOM-remove-rt1-expected.png:
* platform/chromium-linux/fast/ruby/rubyDOM-remove-rt2-expected.png:
* platform/chromium-linux/fast/ruby/rubyDOM-remove-text1-expected.png:
* platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.png: Added.
* platform/chromium-mac/fast/ruby/ruby-length-expected.png: Added.
* platform/chromium-mac/fast/ruby/ruby-run-break-expected.png: Added.
* platform/chromium-mac/fast/ruby/ruby-runs-expected.png: Added.
* platform/chromium-mac/fast/ruby/ruby-runs-spans-expected.png: Added.
* platform/chromium-mac/fast/ruby/ruby-trailing-expected.png: Added.
* platform/chromium-mac/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
* platform/chromium-mac/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
* platform/chromium-mac/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
* platform/chromium-mac/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
* platform/chromium-mac/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
* platform/chromium-mac/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
* platform/chromium-mac/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
* platform/chromium-win/fast/blockflow/english-lr-text-expected.checksum: Removed.
* platform/chromium-win/fast/blockflow/english-lr-text-expected.png:
* platform/chromium-win/fast/ruby/overhang-horizontal-expected.png: Added.
* platform/chromium-win/fast/ruby/overhang-vertical-expected.png: Added.
* platform/chromium-win/fast/ruby/ruby-beforeafter-expected.checksum: Removed.
* platform/chromium-win/fast/ruby/ruby-beforeafter-expected.png:
* platform/chromium-win/fast/ruby/ruby-beforeafter-expected.txt:
* platform/chromium-win/fast/ruby/ruby-length-expected.checksum: Removed.
* platform/chromium-win/fast/ruby/ruby-length-expected.png:
* platform/chromium-win/fast/ruby/ruby-length-expected.txt:
* platform/chromium-win/fast/ruby/ruby-run-break-expected.checksum: Removed.
* platform/chromium-win/fast/ruby/ruby-run-break-expected.png:
* platform/chromium-win/fast/ruby/ruby-run-break-expected.txt:
* platform/chromium-win/fast/ruby/ruby-runs-expected.checksum: Removed.
* platform/chromium-win/fast/ruby/ruby-runs-expected.png:
* platform/chromium-win/fast/ruby/ruby-runs-expected.txt:
* platform/chromium-win/fast/ruby/ruby-runs-spans-expected.checksum: Removed.
* platform/chromium-win/fast/ruby/ruby-runs-spans-expected.png:
* platform/chromium-win/fast/ruby/ruby-runs-spans-expected.txt:
* platform/chromium-win/fast/ruby/ruby-trailing-expected.checksum: Removed.
* platform/chromium-win/fast/ruby/ruby-trailing-expected.png:
* platform/chromium-win/fast/ruby/ruby-trailing-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.checksum: Removed.
* platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.png:
* platform/chromium-win/fast/ruby/rubyDOM-insert-rt-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.checksum: Removed.
* platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.png:
* platform/chromium-win/fast/ruby/rubyDOM-insert-text1-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-insert-text2-expected.checksum: Removed.
* platform/chromium-win/fast/ruby/rubyDOM-insert-text2-expected.png:
* platform/chromium-win/fast/ruby/rubyDOM-insert-text2-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-insert-text3-expected.checksum: Removed.
* platform/chromium-win/fast/ruby/rubyDOM-insert-text3-expected.png:
* platform/chromium-win/fast/ruby/rubyDOM-insert-text3-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-remove-rt1-expected.checksum: Removed.
* platform/chromium-win/fast/ruby/rubyDOM-remove-rt1-expected.png:
* platform/chromium-win/fast/ruby/rubyDOM-remove-rt1-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-remove-rt2-expected.checksum: Removed.
* platform/chromium-win/fast/ruby/rubyDOM-remove-rt2-expected.png:
* platform/chromium-win/fast/ruby/rubyDOM-remove-rt2-expected.txt:
* platform/chromium-win/fast/ruby/rubyDOM-remove-text1-expected.checksum: Removed.
* platform/chromium-win/fast/ruby/rubyDOM-remove-text1-expected.png:
* platform/chromium-win/fast/ruby/rubyDOM-remove-text1-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Tue, 5 Apr 2011 09:38:09 +0000 (09:38 +0000)]
2011-04-05 Hans Wennborg <hans@chromium.org>
Reviewed by Adam Barth
Clean up IndexedDB WebKit API
https://bugs.webkit.org/show_bug.cgi?id=57507
Rename the backend proxy files that didn't have Backend in their name.
Everything in WebKit should be in the WebKit namespace.
Put everything behind the feature flag so we're consistient.
Put the feature flag #if above includes.
* WebKit.gyp:
* src/IDBCallbacksProxy.cpp:
(WebKit::IDBCallbacksProxy::create):
(WebKit::IDBCallbacksProxy::IDBCallbacksProxy):
(WebKit::IDBCallbacksProxy::onError):
(WebKit::IDBCallbacksProxy::onSuccess):
* src/IDBCallbacksProxy.h:
* src/IDBCursorBackendProxy.cpp:
(WebKit::IDBCursorBackendProxy::create):
(WebKit::IDBCursorBackendProxy::IDBCursorBackendProxy):
* src/IDBCursorBackendProxy.h:
* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::create):
(WebKit::IDBDatabaseBackendProxy::IDBDatabaseBackendProxy):
(WebKit::IDBDatabaseBackendProxy::~IDBDatabaseBackendProxy):
(WebKit::IDBDatabaseBackendProxy::name):
(WebKit::IDBDatabaseBackendProxy::version):
(WebKit::IDBDatabaseBackendProxy::objectStoreNames):
(WebKit::IDBDatabaseBackendProxy::createObjectStore):
(WebKit::IDBDatabaseBackendProxy::deleteObjectStore):
(WebKit::IDBDatabaseBackendProxy::setVersion):
(WebKit::IDBDatabaseBackendProxy::transaction):
(WebKit::IDBDatabaseBackendProxy::close):
(WebKit::IDBDatabaseBackendProxy::open):
* src/IDBDatabaseCallbacksProxy.cpp:
(WebKit::IDBDatabaseCallbacksProxy::create):
(WebKit::IDBDatabaseCallbacksProxy::IDBDatabaseCallbacksProxy):
* src/IDBDatabaseCallbacksProxy.h:
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
(WebKit::IDBFactoryBackendProxy::open):
* src/IDBFactoryBackendProxy.h:
* src/IDBIndexBackendProxy.cpp:
(WebKit::IDBIndexBackendProxy::create):
(WebKit::IDBIndexBackendProxy::IDBIndexBackendProxy):
* src/IDBIndexBackendProxy.h:
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::create):
(WebKit::IDBObjectStoreBackendProxy::IDBObjectStoreBackendProxy):
(WebKit::IDBObjectStoreBackendProxy::~IDBObjectStoreBackendProxy):
(WebKit::IDBObjectStoreBackendProxy::name):
(WebKit::IDBObjectStoreBackendProxy::keyPath):
(WebKit::IDBObjectStoreBackendProxy::indexNames):
(WebKit::IDBObjectStoreBackendProxy::get):
(WebKit::IDBObjectStoreBackendProxy::put):
(WebKit::IDBObjectStoreBackendProxy::deleteFunction):
(WebKit::IDBObjectStoreBackendProxy::clear):
(WebKit::IDBObjectStoreBackendProxy::createIndex):
(WebKit::IDBObjectStoreBackendProxy::index):
(WebKit::IDBObjectStoreBackendProxy::deleteIndex):
(WebKit::IDBObjectStoreBackendProxy::openCursor):
* src/IDBObjectStoreBackendProxy.h: Added.
* src/IDBObjectStoreProxy.h: Removed.
* src/IDBTransactionBackendProxy.cpp:
(WebKit::IDBTransactionBackendProxy::create):
(WebKit::IDBTransactionBackendProxy::IDBTransactionBackendProxy):
(WebKit::IDBTransactionBackendProxy::objectStore):
* src/IDBTransactionBackendProxy.h:
(WebKit::IDBTransactionBackendProxy::getWebIDBTransaction):
* src/IDBTransactionCallbacksProxy.cpp:
(WebKit::IDBTransactionCallbacksProxy::create):
(WebKit::IDBTransactionCallbacksProxy::IDBTransactionCallbacksProxy):
* src/IDBTransactionCallbacksProxy.h:
* src/WebIDBCallbacksImpl.cpp:
(WebKit::WebIDBCallbacksImpl::onError):
(WebKit::WebIDBCallbacksImpl::onSuccess):
* src/WebIDBCallbacksImpl.h:
* src/WebIDBCursorImpl.cpp:
* src/WebIDBCursorImpl.h:
* src/WebIDBDatabaseCallbacksImpl.cpp:
(WebKit::WebIDBDatabaseCallbacksImpl::onVersionChange):
* src/WebIDBDatabaseCallbacksImpl.h:
* src/WebIDBDatabaseError.cpp:
* src/WebIDBDatabaseImpl.cpp:
* src/WebIDBDatabaseImpl.h:
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::WebIDBFactoryImpl):
* src/WebIDBFactoryImpl.h:
* src/WebIDBIndexImpl.cpp:
* src/WebIDBIndexImpl.h:
* src/WebIDBKey.cpp:
(WebKit::WebIDBKey::createFromValueAndKeyPath):
(WebKit::WebIDBKey::injectIDBKeyIntoSerializedValue):
* src/WebIDBKeyPath.cpp:
(WebKit::WebIDBKeyPath::operator const WTF::Vector<IDBKeyPathElement, 0>&):
* src/WebIDBKeyRange.cpp:
* src/WebIDBObjectStoreImpl.cpp:
* src/WebIDBObjectStoreImpl.h:
* src/WebIDBTransactionCallbacksImpl.cpp:
* src/WebIDBTransactionCallbacksImpl.h:
* src/WebIDBTransactionImpl.cpp:
* src/WebIDBTransactionImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Tue, 5 Apr 2011 09:27:58 +0000 (09:27 +0000)]
2011-04-05 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Stop preload scanning CSS when it's impossible to have another @import.
https://bugs.webkit.org/show_bug.cgi?id=57664
* fast/preloader/style-expected.txt:
* fast/preloader/style.html: Updated to test invalid @import statements.
2011-04-05 James Simonsen <simonjam@chromium.org>
Reviewed by Adam Barth.
Stop preload scanning CSS when it's impossible to have another @import.
https://bugs.webkit.org/show_bug.cgi?id=57664
@import statements are only allowed at the beginning of a CSS file.
Only comments or @charset can precede them. After seeing anything else,
abort early so that we:
- don't have to parse the rest of the CSS.
- don't preload something that the regular parser won't load.
* html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::scan): Terminate early if we're done with @imports.
(WebCore::CSSPreloadScanner::tokenize): Terminate early if we see a {} or any style rule.
(WebCore::CSSPreloadScanner::emitRule): Only @charset or @import are allowed to precede @import.
* html/parser/CSSPreloadScanner.h: Add DoneParsingImportRules state.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 5 Apr 2011 09:17:53 +0000 (09:17 +0000)]
2011-04-05 Takayoshi Kochi <kochi@chromium.org>
Reviewed by Tony Chang.
[chromium] Specify 'sans-serif' as a fallback to the default UI font
'Arial' for non-latin UI scripts (e.g. CJK).
https://bugs.webkit.org/show_bug.cgi?id=55035
No new tests, because it may still fail if the system is not configured
properly to resolve 'sans-serif' to existing real font file, thus even
manual test is hard to systematically tell it is working properly.
* rendering/RenderThemeChromiumSkia.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 5 Apr 2011 09:06:45 +0000 (09:06 +0000)]
2011-04-05 Sailesh Agrawal <sail@chromium.org>
Reviewed by Darin Fisher.
Don't clear existing files if the user cancels the file chooser dialog.
https://bugs.webkit.org/show_bug.cgi?id=55200
* src/WebFileChooserCompletionImpl.cpp:
(WebKit::WebFileChooserCompletionImpl::didChooseFile):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 5 Apr 2011 08:41:29 +0000 (08:41 +0000)]
2011-04-05 Kent Tamura <tkent@chromium.org>
Update a test affected by the behavior change of r82908.
https://bugs.webkit.org/show_bug.cgi?id=57636
* fast/forms/ValidityState-tooLong-textarea-expected.txt:
* fast/forms/script-tests/ValidityState-tooLong-textarea.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 5 Apr 2011 08:12:11 +0000 (08:12 +0000)]
2011-04-05 John Mellor <johnme@chromium.org>
Reviewed by Darin Fisher.
[chromium] Minor cleanup: simplify WebFrameImpl by using contentsToWindow instead of convertToContainingWindow.
https://bugs.webkit.org/show_bug.cgi?id=55681
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::find):
(WebKit::WebFrameImpl::scopeStringMatches):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Tue, 5 Apr 2011 08:07:30 +0000 (08:07 +0000)]
2011-04-05 Philippe Normand <pnormand@igalia.com>
Unreviewed, GTK rebaseline after r82903.
* platform/gtk/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
* platform/gtk/fast/ruby/ruby-beforeafter-expected.txt:
* platform/gtk/fast/ruby/ruby-length-expected.txt:
* platform/gtk/fast/ruby/ruby-run-break-expected.txt:
* platform/gtk/fast/ruby/ruby-runs-expected.txt:
* platform/gtk/fast/ruby/ruby-runs-spans-expected.txt:
* platform/gtk/fast/ruby/ruby-trailing-expected.txt:
* platform/gtk/fast/ruby/rubyDOM-insert-rt-expected.txt:
* platform/gtk/fast/ruby/rubyDOM-insert-text1-expected.txt:
* platform/gtk/fast/ruby/rubyDOM-insert-text2-expected.txt:
* platform/gtk/fast/ruby/rubyDOM-insert-text3-expected.txt:
* platform/gtk/fast/ruby/rubyDOM-remove-rt1-expected.txt:
* platform/gtk/fast/ruby/rubyDOM-remove-rt2-expected.txt:
* platform/gtk/fast/ruby/rubyDOM-remove-text1-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Tue, 5 Apr 2011 07:53:47 +0000 (07:53 +0000)]
2011-04-05 Adam Barth <abarth@webkit.org>
Roll Chromium DEPS.
* DEPS: Rolled!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 5 Apr 2011 07:30:47 +0000 (07:30 +0000)]
2011-04-05 Nancy Piedra <nancy.piedra@nokia.com>
Reviewed by Alexey Proskuryakov.
Improper use of " in video-can-play-type layout test
https://bugs.webkit.org/show_bug.cgi?id=57728
* media/video-can-play-type.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 5 Apr 2011 07:27:40 +0000 (07:27 +0000)]
2011-04-05 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Setting defaultValue on a textarea with a modified value still clobbers the value
https://bugs.webkit.org/show_bug.cgi?id=57636
* fast/forms/textarea-set-defaultvalue-after-value-expected.txt: Added.
* fast/forms/textarea-set-defaultvalue-after-value.html: Added.
2011-04-05 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Setting defaultValue on a textarea with a modified value still clobbers the value
https://bugs.webkit.org/show_bug.cgi?id=57636
If the dirty flag is true, we shouldn't update the value when the
defaultValue is updated
Test: fast/forms/textarea-set-defaultvalue-after-value.html
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::childrenChanged):
(WebCore::HTMLTextAreaElement::setDefaultValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 5 Apr 2011 07:25:57 +0000 (07:25 +0000)]
Remove duplicate API from WKContext
<rdar://problem/8727879>
https://bugs.webkit.org/show_bug.cgi?id=57815
Unreviewed buildfix after r82906.
Add UNUSED_PARAM to resourceCachesToClear, because
it is only used within #if USE(CFURLCACHE) guard.
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Tue, 5 Apr 2011 05:38:43 +0000 (05:38 +0000)]
Remove duplicate API from WKContext
<rdar://problem/8727879>
https://bugs.webkit.org/show_bug.cgi?id=57815
Reviewed by Brian Weinstein.
Source/WebKit2:
- Remove WKContextClearResourceCaches and WKContextClearApplicationCache in favor
of their more modern counterparts WKResourceCacheManagerClearCacheForAllOrigins
and WKApplicationCacheManagerDeleteAllEntries.
- Expand clearing functionality of WKResourceCacheManager by adding type of resources
to clear.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
Remove clearing bools.
* UIProcess/API/C/WKAPICast.h:
(WebKit::toResourceCachesToClear):
Update for new name of enum.
* UIProcess/API/C/WKContext.cpp:
* UIProcess/API/C/WKContext.h:
Remove WKContextClearResourceCaches and WKContextClearApplicationCache.
* UIProcess/API/C/WKResourceCacheManager.cpp:
(WKResourceCacheManagerClearCacheForOrigin):
(WKResourceCacheManagerClearCacheForAllOrigins):
* UIProcess/API/C/WKResourceCacheManager.h:
Add WKResourceCachesToClear enum and use it in the clearing functions.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::ensureWebProcess):
* UIProcess/WebContext.h:
* WebProcess/WebProcess.messages.in:
Remove clearing functions and setting of bools for clear on launch.
* UIProcess/WebFullScreenManagerProxy.cpp:
Remove unnecessary #include.
* UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):
* UIProcess/WebResourceCacheManagerProxy.h:
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
(WebKit::WebResourceCacheManager::clearCacheForAllOrigins):
* WebProcess/ResourceCache/WebResourceCacheManager.h:
* WebProcess/ResourceCache/WebResourceCacheManager.messages.in:
Add enum parameter describing what type of caches to clear.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::clearResourceCaches):
* WebProcess/WebProcess.h:
No longer need to use opaque type now that it is not a message receiver.
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 5 Apr 2011 05:33:40 +0000 (05:33 +0000)]
2011-04-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82876.
http://trac.webkit.org/changeset/82876
https://bugs.webkit.org/show_bug.cgi?id=57816
Caused a lot of test crashes (Requested by tkent on #webkit).
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/FastMalloc.cpp:
(WTF::tryFastMalloc):
(WTF::fastMalloc):
(WTF::tryFastCalloc):
(WTF::fastCalloc):
(WTF::fastFree):
(WTF::tryFastRealloc):
(WTF::fastRealloc):
(WTF::fastMallocSize):
(WTF::TCMalloc_PageHeap::isScavengerSuspended):
(WTF::TCMalloc_PageHeap::scheduleScavenger):
(WTF::TCMalloc_PageHeap::suspendScavenger):
(WTF::TCMalloc_PageHeap::signalScavenger):
(WTF::TCMallocStats::malloc):
(WTF::TCMallocStats::free):
(WTF::TCMallocStats::fastCalloc):
(WTF::TCMallocStats::tryFastCalloc):
(WTF::TCMallocStats::calloc):
(WTF::TCMallocStats::fastRealloc):
(WTF::TCMallocStats::tryFastRealloc):
(WTF::TCMallocStats::realloc):
(WTF::TCMallocStats::fastMallocSize):
* wtf/FastMalloc.h:
(WTF::Internal::fastMallocMatchValidationType):
(WTF::Internal::fastMallocMatchValidationValue):
(WTF::Internal::setFastMallocMatchValidationType):
(WTF::fastMallocMatchValidateFree):
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 5 Apr 2011 05:26:51 +0000 (05:26 +0000)]
2011-04-04 Kent Tamura <tkent@chromium.org>
Add a case label which was unexpectedly removed in r82899.
https://bugs.webkit.org/show_bug.cgi?id=50661
* css/CSSSelector.cpp:
(WebCore::CSSSelector::extractPseudoType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 5 Apr 2011 05:21:16 +0000 (05:21 +0000)]
<rdar://problem/7709452> Implement Default Ruby Overhang Behavior
https://bugs.webkit.org/show_bug.cgi?id=49334
Reviewed by Simon Fraser.
Source/WebCore:
Tests: fast/ruby/overhang-horizontal.html
fast/ruby/overhang-vertical.html
This is a first cut at ruby overhang. It allows ruby text to hang over other
text of equal or smaller size. Two notable omissions are that max preferred
width computation was not patched, so it will overshoot, and that overhang
ignores the width of the adjoining text runs.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust margins
of ruby runs for overhang.
(WebCore::RenderBlock::fitBelowFloats): Maintain the increase in line width to
compensate for overhang.
(WebCore::RenderBlock::findNextLineBreak): When encountering
a ruby run, increase the line width to account for the fact that overhang will be
collapsed.
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::getOverhang): Added. Allows ruby to overhang if
the adjoining renderer is text with equal or smaller font size.
* rendering/RenderRubyRun.h:
(WebCore::toRenderRubyRun):
LayoutTests:
* fast/ruby/overhang-horizontal-expected.checksum: Added.
* fast/ruby/overhang-horizontal-expected.png: Added.
* fast/ruby/overhang-horizontal-expected.txt: Added.
* fast/ruby/overhang-horizontal.html: Added.
* fast/ruby/overhang-vertical-expected.checksum: Added.
* fast/ruby/overhang-vertical-expected.png: Added.
* fast/ruby/overhang-vertical-expected.txt: Added.
* fast/ruby/overhang-vertical.html: Added.
* platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
* platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
* platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt:
* platform/mac/fast/blockflow/english-lr-text-expected.checksum:
* platform/mac/fast/blockflow/english-lr-text-expected.png:
* platform/mac/fast/ruby/ruby-beforeafter-expected.checksum:
* platform/mac/fast/ruby/ruby-beforeafter-expected.png:
* platform/mac/fast/ruby/ruby-beforeafter-expected.txt:
* platform/mac/fast/ruby/ruby-length-expected.checksum:
* platform/mac/fast/ruby/ruby-length-expected.png:
* platform/mac/fast/ruby/ruby-length-expected.txt:
* platform/mac/fast/ruby/ruby-run-break-expected.checksum:
* platform/mac/fast/ruby/ruby-run-break-expected.png:
* platform/mac/fast/ruby/ruby-run-break-expected.txt:
* platform/mac/fast/ruby/ruby-runs-expected.checksum:
* platform/mac/fast/ruby/ruby-runs-expected.png:
* platform/mac/fast/ruby/ruby-runs-expected.txt:
* platform/mac/fast/ruby/ruby-runs-spans-expected.checksum:
* platform/mac/fast/ruby/ruby-runs-spans-expected.png:
* platform/mac/fast/ruby/ruby-runs-spans-expected.txt:
* platform/mac/fast/ruby/ruby-trailing-expected.checksum:
* platform/mac/fast/ruby/ruby-trailing-expected.png:
* platform/mac/fast/ruby/ruby-trailing-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-rt-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-text1-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-text2-expected.txt:
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.png:
* platform/mac/fast/ruby/rubyDOM-insert-text3-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-rt1-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-rt2-expected.txt:
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.checksum:
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.png:
* platform/mac/fast/ruby/rubyDOM-remove-text1-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Tue, 5 Apr 2011 04:58:21 +0000 (04:58 +0000)]
2011-04-04 Adrienne Walker <enne@google.com>
Unreviewed, Chromium expectations update for tests broken after r82899.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 5 Apr 2011 04:41:22 +0000 (04:41 +0000)]
2011-04-04 MORITA Hajime <morrita@google.com>
Unreviewed expectations update following r82899.
* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
* platform/gtk/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Tue, 5 Apr 2011 04:37:05 +0000 (04:37 +0000)]
<webkit.org/b/57384> CFNetwork and WebCore load priorities should match
Reviewed by Alexey Proskuryakov.
Source/WebCore:
* WebCore.exp.in: Export wkSetHTTPPipeliningMaximumPriority().
* platform/mac/WebCoreSystemInterface.h:
(wkSetHTTPPipeliningMaximumPriority): Added function pointer
declaration.
* platform/mac/WebCoreSystemInterface.mm:
(wkSetHTTPPipeliningMaximumPriority): Added function pointer.
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Call
wkSetHTTPPipeliningMaximumPriority() to set the maximum HTTP
pipelining priority.
* platform/network/cf/ResourceRequestCFNet.h:
(WebCore::toResourceLoadPriority): Renamed from
mapHTTPPipeliningPriorityToResourceLoadPriority(). Updated to
to handle Unresolved case.
(WebCore::toHTTPPipeliningPriority): Renamed from
mapResourceLoadPriorityToHTTPPipeliningPriority(). Updated to
handle Unresolved case.
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest): Switched to
use toResourceLoadPriority().
(WebCore::ResourceRequest::doUpdatePlatformRequest): Switched to
use toHTTPPipeliningPriority(). Moved
shouldForceHTTPPipeliningPriorityHigh() check into the argument
of toHTTPPipeliningPriority() instead of hard-coding a
now-incorrect value.
Source/WebKit/mac:
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added initialization for
wkSetHTTPPipeliningMaximumPriority().
Source/WebKit2:
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Added initialization for
wkSetHTTPPipeliningMaximumPriority().
WebKitLibraries:
* WebKitSystemInterface.h:
(WKSetHTTPPipeliningMaximumPriority): Added declaration.
(WKExtractWordDefinitionTokenRangeFromContextualString): Added
missing declaration from r81890.
(WKShowWordDefinitionWindow): Ditto.
(WKHideWordDefinitionWindow): Ditto.
* libWebKitSystemInterfaceLeopard.a: Updated.
* libWebKitSystemInterfaceSnowLeopard.a: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Tue, 5 Apr 2011 02:01:56 +0000 (02:01 +0000)]
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Convert <meter> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50661
Updated expectations due to shadow structure chagne.
Also updated meter-styles.html pixel result because the render tree is now laid out
as normal flexboxes and its layout result is actually different,
especially if there are non-zero borders on shadow elements.
* fast/dom/HTMLMeterElement/meter-styles.html:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
Convert <meter> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50661
Eliminated a large part of <meter> custom layout code,
which is replaced by a shadow tree.
Note that the shadow tree is created on construction time and
will remain during the host HTMLMeterElement lifecycle.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setProperty):
* css/CSSMutableStyleDeclaration.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/html.css:
(meter):
(meter::-webkit-meter-bar):
(meter::-webkit-meter-optimum-value):
(meter::-webkit-meter-suboptimum-value):
(meter::-webkit-meter-even-less-good-value):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::~HTMLMeterElement):
(WebCore::HTMLMeterElement::parseMappedAttribute):
(WebCore::HTMLMeterElement::attach):
(WebCore::HTMLMeterElement::valueRatio):
(WebCore::HTMLMeterElement::didElementStateChange):
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLMeterElement.h:
* html/shadow/MeterShadowElement.cpp: Added.
(WebCore::MeterShadowElement::MeterShadowElement):
(WebCore::MeterShadowElement::meterElement):
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore::MeterBarElement::shadowPseudoId):
(WebCore::MeterValueElement::shadowPseudoId):
(WebCore::MeterValueElement::setWidthPercentage):
* html/shadow/MeterShadowElement.h: Added.
(WebCore::MeterBarElement::MeterBarElement):
(WebCore::MeterBarElement::create):
(WebCore::MeterValueElement::MeterValueElement):
(WebCore::MeterValueElement::create):
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::~RenderMeter):
(WebCore::RenderMeter::valueRatio):
* rendering/RenderMeter.h:
(WebCore::RenderMeter::renderName):
(WebCore::RenderMeter::isMeter):
(WebCore::RenderMeter::requiresForcedStyleRecalcPropagation):
(WebCore::RenderMeter::canHaveChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Tue, 5 Apr 2011 01:33:58 +0000 (01:33 +0000)]
2011-04-04 Oliver Hunt <oliver@apple.com>
Reviewed by Antti Koivisto.
Stop JSCell.h from including Structure.h
https://bugs.webkit.org/show_bug.cgi?id=57809
* runtime/GetterSetter.h:
* runtime/JSAPIValueWrapper.h:
* runtime/JSCell.h:
(JSC::JSCell::JSValue::toThisObject):
* runtime/JSString.h:
* runtime/ScopeChain.h:
* runtime/Structure.h:
(JSC::JSCell::isObject):
(JSC::JSCell::isString):
(JSC::JSCell::classInfo):
(JSC::JSCell::createDummyStructure):
(JSC::JSValue::needsThisConversion):
(JSC::MarkStack::internalAppend):
* runtime/StructureChain.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Tue, 5 Apr 2011 01:01:25 +0000 (01:01 +0000)]
Reviewed by Kevin Ollivier.
Move to using FrameView::resize to handle changes in view size.
https://bugs.webkit.org/show_bug.cgi?id=57805
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 5 Apr 2011 00:58:47 +0000 (00:58 +0000)]
2011-04-04 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Send NPCocoaEventFlagsChanged events
https://bugs.webkit.org/show_bug.cgi?id=57811
<rdar://problem/9215600>
* Shared/WebEvent.h:
(WebKit::WebEvent::capsLockKey):
Add CapsLock modifier and getter.
* Shared/mac/WebEventFactory.mm:
(WebKit::modifiersForEvent):
Check for NSAlphaShiftKeyMask and set the CapsLockKey modifier.
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::modifierFlags):
Check for CapsLockKey and set NSAlphaShiftKeyMask.
(WebKit::isFlagsChangedEvent):
Return whether a given event is a Cocoa flags changed event.
(WebKit::initializeKeyboardEvent):
If this is a flags changed event, set the event type to NPCocoaEventFlagsChanged.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 5 Apr 2011 00:09:59 +0000 (00:09 +0000)]
2011-04-04 Martin Robinson <mrobinson@igalia.com>
Build fix for GTK+ after r82876.
* Source/autotools/symbols.filter: Update the symbol filter to include new symbols
from WTF that DRT uses.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 5 Apr 2011 00:09:16 +0000 (00:09 +0000)]
2011-04-04 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Don't discard the backing stores of WKViews in the key window
https://bugs.webkit.org/show_bug.cgi?id=57808
<rdar://problem/9110793>
<rdar://problem/9194284>
<rdar://problem/9222216>
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::setBackingStoreIsDiscardable):
Add empty stub.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
Initialize m_isBackingStoreDiscardable to true.
(WebKit::DrawingAreaProxyImpl::setBackingStoreIsDiscardable):
Set m_isBackingStoreDiscardable and schedule or stop the discard backing store timer.
(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
Don't start the timer if m_isBackingStoreDiscardable is false.
* UIProcess/DrawingAreaProxyImpl.h:
Add m_isBackingStoreDiscardable.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::viewStateDidChange):
Mark the backing store as discardable if the view is hidden or if the containing window
is not active.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Mon, 4 Apr 2011 23:40:00 +0000 (23:40 +0000)]
2011-04-04 Adrienne Walker <enne@google.com>
Unreviewed, rolling out r82879.
http://trac.webkit.org/changeset/82879
Trying to fix 10.6 layout test expectations broke 10.5
* platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Added.
* platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Added.
* platform/chromium-mac/fast/html/details-no-summary1-expected.png: Added.
* platform/chromium-mac/fast/html/details-no-summary2-expected.png: Added.
* platform/chromium-mac/fast/html/details-no-summary3-expected.png: Added.
* platform/chromium-mac/fast/html/details-no-summary4-expected.png: Added.
* platform/chromium-mac/fast/html/details-open-javascript-expected.png: Added.
* platform/chromium-mac/fast/html/details-open1-expected.png: Added.
* platform/chromium-mac/fast/html/details-open2-expected.png: Added.
* platform/chromium-mac/fast/html/details-open3-expected.png: Added.
* platform/chromium-mac/fast/html/details-open4-expected.png: Added.
* platform/chromium-mac/fast/html/details-open5-expected.png: Added.
* platform/chromium-mac/fast/html/details-open6-expected.png: Added.
* platform/chromium-mac/fast/html/details-position-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Added.
* platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Added.
* platform/chromium-mac/fast/html/details-writing-mode-expected.png: Added.
* platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Added.
* platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Added.
* platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
* platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/nested-columns-expected.png:
* platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Added.
* platform/chromium-mac/fast/repaint/list-marker-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 4 Apr 2011 23:31:00 +0000 (23:31 +0000)]
2011-04-04 Tony Chang <tony@chromium.org>
Reviewed by Ojan Vafai.
[chromium] don't write .checksum files if a fallback platform has an embedded checksum
https://bugs.webkit.org/show_bug.cgi?id=57783
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Mon, 4 Apr 2011 23:23:06 +0000 (23:23 +0000)]
2011-04-04 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Adam Barth.
Introduce EventDispatchMediator abstraction, which encapsulate all
non-trivial logic around firing a specific type of an event.
https://bugs.webkit.org/show_bug.cgi?id=57562
Refactoring, covered by existing tests.
* dom/Event.cpp:
(WebCore::EventDispatchMediator::EventDispatchMediator): Added.
(WebCore::EventDispatchMediator::~EventDispatchMediator): Added.
(WebCore::EventDispatchMediator::dispatchEvent): Added.
(WebCore::EventDispatchMediator::event): Added.
* dom/Event.h: Added decl.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent): Changed to use EventDispatchMediator.
* dom/EventDispatcher.h: Updated decls.
* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEventDispatchMediator::KeyboardEventDispatchMediator): Added.
(WebCore::KeyboardEventDispatchMediator::dispatchEvent): Added.
* dom/KeyboardEvent.h: Updated decls
* dom/Node.cpp:
(WebCore::Node::dispatchEvent): Changed to use EventDispatchMediator.
(WebCore::Node::dispatchKeyEvent): Changed to use KeyboardEventDispatchMediator.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 4 Apr 2011 23:19:05 +0000 (23:19 +0000)]
2011-04-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Cairo] Memory leak in RefPtrCairo
https://bugs.webkit.org/show_bug.cgi?id=57758
No new tests. This just fixes a memory leak.
* platform/graphics/cairo/RefPtrCairo.cpp:
(WTF::derefIfNotNull): Deref should unref the cairo_font_fact_t, not reference it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Mon, 4 Apr 2011 23:17:49 +0000 (23:17 +0000)]
2011-04-04 Adrienne Walker <enne@google.com>
Unreviewed, rolling out r82880.
http://trac.webkit.org/changeset/82880
https://bugs.webkit.org/show_bug.cgi?id=50661
Meter elements not rendered in Chromium Linux layout tests.
* fast/dom/HTMLMeterElement/meter-styles.html:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
2011-04-04 Adrienne Walker <enne@google.com>
Unreviewed, rolling out r82880.
http://trac.webkit.org/changeset/82880
https://bugs.webkit.org/show_bug.cgi?id=50661
Meter elements not rendered in Chromium Linux layout tests
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSMutableStyleDeclaration.cpp:
* css/CSSMutableStyleDeclaration.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/html.css:
(meter):
(meter::-webkit-meter):
(meter::-webkit-meter-bar):
(meter::-webkit-meter-optimum-value):
(meter::-webkit-meter-suboptimal-value):
(meter::-webkit-meter-even-less-good-value):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::create):
(WebCore::HTMLMeterElement::parseMappedAttribute):
(WebCore::HTMLMeterElement::attach):
* html/HTMLMeterElement.h:
* html/shadow/MeterShadowElement.cpp: Removed.
* html/shadow/MeterShadowElement.h: Removed.
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::~RenderMeter):
(WebCore::RenderMeter::createPart):
(WebCore::RenderMeter::updateFromElement):
(WebCore::RenderMeter::layoutParts):
(WebCore::RenderMeter::styleDidChange):
(WebCore::RenderMeter::shouldHaveParts):
(WebCore::RenderMeter::valueRatio):
(WebCore::RenderMeter::barPartRect):
(WebCore::RenderMeter::valuePartRect):
(WebCore::RenderMeter::valuePseudoId):
(WebCore::RenderMeter::barPseudoId):
(WebCore::RenderMeter::detachShadows):
(WebCore::RenderMeter::updateShadows):
* rendering/RenderMeter.h:
(WebCore::RenderMeter::renderName):
(WebCore::RenderMeter::isMeter):
(WebCore::RenderMeter::shadowAttached):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 4 Apr 2011 23:11:16 +0000 (23:11 +0000)]
Fix clang build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 4 Apr 2011 23:08:30 +0000 (23:08 +0000)]
2011-04-04 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Adjust the list of flaky tests based on NRWT on webkit mac using
a 35 second timeout by default.
* platform/mac/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 22:49:22 +0000 (22:49 +0000)]
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
setContentEditable with true/false/inherit string is not working properly
https://bugs.webkit.org/show_bug.cgi?id=52058
Updated expected results after this patch fixes the set contenteditable issue.
* fast/dom/HTMLElement/set-false-expected.txt:
* fast/dom/HTMLElement/set-false.html:
* fast/dom/HTMLElement/set-inherit-parent-false-expected.txt:
* fast/dom/HTMLElement/set-inherit-parent-true-expected.txt:
* fast/dom/HTMLElement/set-true-expected.txt:
* fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt:
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
setContentEditable with true/false/inherit string is not working properly
https://bugs.webkit.org/show_bug.cgi?id=52058
Move isContentEditable from HTMLElement to Node. Thus, Node provides two functions for
checking editability: rendererIsEditable and isContentEdiable. The former is a fast path,
which does NOT trigger layout and only checks the render style of usermodify. The latter
updates the layout first to make sure the render style syncs with DOM contenteditable
attribute. Certain call sites that need to call isContentEditable rather than rendererIsEditable
are also updated in the patch. But a complete fix will follow up in bug 57244.
This patch fixes all the failed layout tests related to set contenteditable.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isReadOnly):
* dom/Node.cpp:
(WebCore::Node::isContentEditable):
(WebCore::Node::shouldUseInputMethod):
* dom/Node.h:
* html/HTMLElement.cpp:
* html/HTMLElement.h:
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
setContentEditable with true/false/inherit string is not working properly
https://bugs.webkit.org/show_bug.cgi?id=52058
Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
as rendererIsEditable is for WebCore internal use.
* src/WebNode.cpp:
(WebKit::WebNode::isContentEditable):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setFocus):
(WebKit::WebViewImpl::setComposition):
(WebKit::WebViewImpl::confirmComposition):
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
setContentEditable with true/false/inherit string is not working properly
https://bugs.webkit.org/show_bug.cgi?id=52058
Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
as rendererIsEditable is for WebCore internal use.
* WebCoreSupport/EditorClientHaiku.cpp:
(WebCore::EditorClientHaiku::handleKeyboardEvent):
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
setContentEditable with true/false/inherit string is not working properly
https://bugs.webkit.org/show_bug.cgi?id=52058
Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
as rendererIsEditable is for WebCore internal use.
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::handleKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Mon, 4 Apr 2011 22:37:24 +0000 (22:37 +0000)]
[wx] Unreviewed build fix, run uninstall when cleaning to remove built files from WebKitBuild.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 4 Apr 2011 22:36:20 +0000 (22:36 +0000)]
Remove accidental change to Platform.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 4 Apr 2011 22:33:42 +0000 (22:33 +0000)]
2011-04-04 Jade Han <jade.han@nokia.com>
Reviewed by Csaba Osztrogonác.
Symbian build fix.
https://bugs.webkit.org/show_bug.cgi?id=54977
* config.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Mon, 4 Apr 2011 22:25:18 +0000 (22:25 +0000)]
2011-04-04 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by NOBODY (OOPS!).
Bug 57689 - Extract scoping functionality from Document
https://bugs.webkit.org/show_bug.cgi?id=57689
Moved selfOnlyRef (renamed to guardRef), element ID, image map
and accesss key functionalities from Document to a new base
class TreeScope.
TreeShared: made removedLastRef protected
No new tests. (refactoring)
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::destroyScope):
(WebCore::Document::getElementById):
(WebCore::Document::childrenChanged):
(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::attach):
(WebCore::Document::detach):
* dom/Document.h:
(WebCore::Node::Node):
* dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getElementById):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
* dom/DocumentOrderedMap.h:
* dom/DOMAllInOne.cpp:
* dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::setDocument):
* dom/Node.h:
* dom/TreeScope.cpp: Added.
* dom/TreeScope.h: Added.
* platform/TreeShared.h:
(WebCore::TreeShared::removedLastRef): made protected
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 4 Apr 2011 22:20:29 +0000 (22:20 +0000)]
Add WKIconDatabase* headers to the WebKit2 export for Windows:
* win/WebKit2Generated.make:
Rubberstamped by Adam Roben.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 4 Apr 2011 22:15:57 +0000 (22:15 +0000)]
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Convert <meter> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50661
Updated expectations due to shadow structure chagne.
Also updated meter-styles.html pixel result because the render tree is now laid out
as normal flexboxes and its layout result is actually different,
especially if there are non-zero borders on shadow elements.
* fast/dom/HTMLMeterElement/meter-styles.html:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.png:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Dimitri Glazkov.
Convert <meter> shadow DOM to a DOM-based shadow.
https://bugs.webkit.org/show_bug.cgi?id=50661
Eliminated a large part of <meter> custom layout code,
which is replaced by a shadow tree.
Note that the shadow tree is created on construction time and
will remain during the host HTMLMeterElement lifecycle.
* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::setProperty):
* css/CSSMutableStyleDeclaration.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/html.css:
(meter):
(meter::-webkit-meter-bar):
(meter::-webkit-meter-optimum-value):
(meter::-webkit-meter-suboptimum-value):
(meter::-webkit-meter-even-less-good-value):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::~HTMLMeterElement):
(WebCore::HTMLMeterElement::parseMappedAttribute):
(WebCore::HTMLMeterElement::attach):
(WebCore::HTMLMeterElement::valueRatio):
(WebCore::HTMLMeterElement::didElementStateChange):
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLMeterElement.h:
* html/shadow/MeterShadowElement.cpp: Added.
(WebCore::MeterShadowElement::MeterShadowElement):
(WebCore::MeterShadowElement::meterElement):
(WebCore::MeterShadowElement::rendererIsNeeded):
(WebCore::MeterBarElement::shadowPseudoId):
(WebCore::MeterValueElement::shadowPseudoId):
(WebCore::MeterValueElement::setWidthPercentage):
* html/shadow/MeterShadowElement.h: Added.
(WebCore::MeterBarElement::MeterBarElement):
(WebCore::MeterBarElement::create):
(WebCore::MeterValueElement::MeterValueElement):
(WebCore::MeterValueElement::create):
* rendering/RenderMeter.cpp:
(WebCore::RenderMeter::RenderMeter):
(WebCore::RenderMeter::~RenderMeter):
(WebCore::RenderMeter::valueRatio):
* rendering/RenderMeter.h:
(WebCore::RenderMeter::renderName):
(WebCore::RenderMeter::isMeter):
(WebCore::RenderMeter::requiresForcedStyleRecalcPropagation):
(WebCore::RenderMeter::canHaveChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Mon, 4 Apr 2011 22:08:56 +0000 (22:08 +0000)]
2011-04-04 Adrienne Walker <enne@google.com>
Unreviewed, update Chromium Snow Leopard image baselines.
These were all minor font-related image differences.
* platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
* platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
* platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Removed.
* platform/chromium-mac/fast/html/details-no-summary1-expected.png: Removed.
* platform/chromium-mac/fast/html/details-no-summary2-expected.png: Removed.
* platform/chromium-mac/fast/html/details-no-summary3-expected.png: Removed.
* platform/chromium-mac/fast/html/details-no-summary4-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open-javascript-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open1-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open2-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open3-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open4-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open5-expected.png: Removed.
* platform/chromium-mac/fast/html/details-open6-expected.png: Removed.
* platform/chromium-mac/fast/html/details-position-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Removed.
* platform/chromium-mac/fast/html/details-writing-mode-expected.png: Removed.
* platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Removed.
* platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Removed.
* platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
* platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Removed.
* platform/chromium-mac/fast/multicol/nested-columns-expected.png:
* platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Removed.
* platform/chromium-mac/fast/repaint/list-marker-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 4 Apr 2011 22:07:05 +0000 (22:07 +0000)]
2011-04-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebGL support
https://bugs.webkit.org/show_bug.cgi?id=31517
* configure.ac: Update configure.ac to ensure that GL/GLX headers exist.
2011-04-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebGL support
https://bugs.webkit.org/show_bug.cgi?id=31517
Add WebGL support for the GTK+ bits of WebCore.
No new tests. This will be covered by the existing WebGL tests once
the bots are capable of running WebGL tests.
* GNUmakefile.am: Added new files required for WebGL support.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext): Extend #ifdef to cover GTK+ as well, which does not
yet support accelerated compositing.
* platform/graphics/ANGLEWebKitBridge.h: Update to reflect the fact that ANGLE isn't compiled as
a framework for GTK+.
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::platformTexture): Added a declaration of this method for Cairo.
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer): Ditto.
* platform/graphics/cairo/GraphicsContext3DCairo.cpp: Added.
(WebCore::GraphicsContext3D::getImageData): Added.
(WebCore::GraphicsContext3D::paintToCanvas): Added.
* platform/graphics/cairo/OpenGLShims.cpp: Added. This file controls loading of GL extension
functions dynamically. They have different names across the different vendors' GL implementations.
(WebCore::lookupOpenGLFunctionAddress): Added
(WebCore::openGLFunctionTable): Added
(WebCore::initializeOpenGLShims): Added
* platform/graphics/cairo/OpenGLShims.h: Added.
* platform/graphics/gtk/DrawingBufferGtk.cpp: Added.
(WebCore::DrawingBuffer::DrawingBuffer): Very generic implementation for Cairo.
(WebCore::DrawingBuffer::~DrawingBuffer): Ditto.
(WebCore::DrawingBuffer::didReset): Ditto.
(WebCore::DrawingBuffer::platformColorBuffer): Ditto.
* platform/graphics/gtk/GraphicsContext3DGtk.cpp: Added.
(WebCore::GraphicsContext3D::create): Initial implementation.
(WebCore::GraphicsContext3D::GraphicsContext3D): Ditto.
(WebCore::GraphicsContext3D::~GraphicsContext3D): Ditto.
(WebCore::GraphicsContext3D::makeContextCurrent): Ditto.
(WebCore::GraphicsContext3D::platformGraphicsContext3D): Ditto.
(WebCore::GraphicsContext3D::isGLES2Compliant): Ditto.
* platform/graphics/gtk/GraphicsContext3DInternal.cpp: Added.
(sharedDisplay): Added this shared display which is required by some
display drivers.
(WebCore::activeGraphicsContexts): This method keeps track of all active GraphicsContext3D
contexts, in order to clean them up at exit. This prevents crashes on certain OpenGL drivers.
(WebCore::GraphicsContext3DInternal::addActiveGraphicsContext): Ditto.
(WebCore::GraphicsContext3DInternal::removeActiveGraphicsContext): Ditto.
(WebCore::GraphicsContext3DInternal::cleanupActiveContextsAtExit): Ditto.
(WebCore::GraphicsContext3DInternal::create): Figure out the best way to create an OpenGL
context given the current environment.
(WebCore::GraphicsContext3DInternal::createPbufferContext): Pbuffer context initializer.
(WebCore::GraphicsContext3DInternal::createPixmapContext): Pixmap context initializer.
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): Initial implementation.
(WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): Ditto.
(WebCore::GraphicsContext3DInternal::makeContextCurrent): Ditto.
* platform/graphics/gtk/GraphicsContext3DInternal.h: Added.
* platform/graphics/opengl/Extensions3DOpenGL.cpp: Added generic implementation.
(WebCore::Extensions3DOpenGL::ensureEnabled): Ditto.
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshape): Test for the context using the public API rather than
the private bits that are specific to the Apple port.
2011-04-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebGL support
https://bugs.webkit.org/show_bug.cgi?id=31517
Add support for toggling WebGL at runtime when it's enabled.
* webkit/webkitwebsettings.cpp: Add the enable-webgl property. When ENABLE_WEBGL
is not enabled, it's a no-op.
(webkit_web_settings_class_init): Update to support enable-webgl.
(webkit_web_settings_set_property): Ditto.
(webkit_web_settings_get_property): Ditto.
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings): Ditto.
2011-04-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] WebGL support
https://bugs.webkit.org/show_bug.cgi?id=31517
Add support to the DRT for turning on WebGL when a layout tests requests it.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::overridePreference): Allow turning on WebGL from tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 4 Apr 2011 22:02:46 +0000 (22:02 +0000)]
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed a weak-handle-related leak in RegisterFile
https://bugs.webkit.org/show_bug.cgi?id=57793
* interpreter/RegisterFile.cpp: Nixed leaky GlobalObjectNotifier.
* interpreter/RegisterFile.h:
(JSC::RegisterFile::GlobalObjectOwner::finalize):
(JSC::RegisterFile::RegisterFile): Replaced GlobalObjectNotifier with
a per-RegisterFile weak handle owner, which does not leak.
* runtime/WeakGCPtr.h:
(JSC::WeakGCPtr::set): Allow set() to take a context argument, since
RegisterFile now needs this. (Seems like it was an accidental omission
all along.)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 4 Apr 2011 21:59:48 +0000 (21:59 +0000)]
2011-04-04 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make malloc validation useful
https://bugs.webkit.org/show_bug.cgi?id=57502
This patch changes FAST_MALLOC_MATCH_VALIDATION with a general
corruption check that tags the beginning and end of all allocations
to check for write overflows and overwrites the contents of
memory on free in order to (hopefully) show up use-after-free issues
sooner.
We also turn it on by default for debug builds.
* JavaScriptCore.exp:
* wtf/FastMalloc.cpp:
(WTF::tryFastMalloc):
(WTF::fastMalloc):
(WTF::tryFastCalloc):
(WTF::fastCalloc):
(WTF::fastFree):
(WTF::tryFastRealloc):
(WTF::fastRealloc):
(WTF::TCMalloc_PageHeap::isScavengerSuspended):
(WTF::TCMalloc_PageHeap::scheduleScavenger):
(WTF::TCMalloc_PageHeap::suspendScavenger):
(WTF::TCMalloc_PageHeap::signalScavenger):
(WTF::TCMallocStats::malloc):
(WTF::TCMallocStats::free):
(WTF::TCMallocStats::fastCalloc):
(WTF::TCMallocStats::tryFastCalloc):
(WTF::TCMallocStats::calloc):
(WTF::TCMallocStats::fastRealloc):
(WTF::TCMallocStats::tryFastRealloc):
(WTF::TCMallocStats::realloc):
* wtf/FastMalloc.h:
(WTF::Internal::fastMallocValidationHeader):
(WTF::Internal::fastMallocValidationSuffix):
(WTF::Internal::fastMallocMatchValidationType):
(WTF::Internal::setFastMallocMatchValidationType):
(WTF::fastMallocMatchValidateFree):
(WTF::fastMallocValidate):
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 4 Apr 2011 21:40:10 +0000 (21:40 +0000)]
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Renamed clearWeakPointers => updateWeakHandles and removed misleading comment
https://bugs.webkit.org/show_bug.cgi?id=57790
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::updateWeakHandles): Updated for rename.
* collector/handles/HandleHeap.h: Removed comment claiming that this
function should only be called during teardown, because it's actually
called after every GC pass.
* runtime/Heap.cpp:
(JSC::Heap::destroy):
(JSC::Heap::markRoots): Updated for rename.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 4 Apr 2011 21:29:56 +0000 (21:29 +0000)]
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Standardized handling of handles for immediate values
https://bugs.webkit.org/show_bug.cgi?id=57788
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::clearWeakPointers): Don't check for null or non-cell
values here, because our write barrier guarantees that such values are
not in the weak list.
(JSC::HandleHeap::writeBarrier): Standardized on checking for null before
checking for cell, and on using early return instead of if/else.
* collector/handles/HandleHeap.h:
(JSC::HandleHeap::deallocate):
(JSC::HandleHeap::makeWeak): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 4 Apr 2011 21:17:39 +0000 (21:17 +0000)]
2011-04-04 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Get rid of WebContext::process() in more places
https://bugs.webkit.org/show_bug.cgi?id=57787
Migrate calls to WebContext::process() over to sendToAllProcesses and
sendToAllProcessesRelaunchingThemIfNecessary.
Add FIXMEs for things that need to be fixed in order to support multiple web processes.
* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::cancel):
* UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::getSitesWithData):
(WebKit::WebPluginSiteDataManager::clearSiteData):
* UIProcess/VisitedLinkProvider.cpp:
(WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired):
* UIProcess/WebApplicationCacheManagerProxy.cpp:
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
* UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::providerDidChangePosition):
(WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::getLoadDecisionForIconURL):
(WebKit::WebIconDatabase::didFinishURLImport):
* UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
* UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname):
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames):
* UIProcess/WebResourceCacheManagerProxy.cpp:
(WebKit::WebResourceCacheManagerProxy::getCacheOrigins):
(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 4 Apr 2011 21:09:29 +0000 (21:09 +0000)]
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Not reviewed.
Removed a redundant variable from HandleHeap
https://bugs.webkit.org/show_bug.cgi?id=57786
Forgot to commit the file that actually removes the data member!
* collector/handles/HandleHeap.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 4 Apr 2011 21:04:39 +0000 (21:04 +0000)]
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Removed a redundant variable from HandleHeap
https://bugs.webkit.org/show_bug.cgi?id=57786
We don't need a specific variable to indicate that we're in the middle
of the finalization phase, since m_nextToFinalize already does this.
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::HandleHeap):
(JSC::HandleHeap::clearWeakPointers):
(JSC::HandleHeap::writeBarrier):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Mon, 4 Apr 2011 20:56:20 +0000 (20:56 +0000)]
Reviewed by Dan Bernstein.
REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51230
<rdar://problem/8780989>
<rdar://problem/9015250> REGRESSION (WebKit2): Key events not fired for modifier keys
* UIProcess/API/mac/WKView.mm:
(-[WKView flagsChanged:]): Ported from WebHTMLView.
(-[WKView _interpretKeyEvent:withCachedTextInputState:savingCommandsTo:WebCore::]):
AppKit isn't happy about attempts to interpret NSFlagsChanged, but WK2 lacked the check.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Mon, 4 Apr 2011 20:48:03 +0000 (20:48 +0000)]
Fix Windows build warning.
* WebCore.vcproj/WebCore.vcproj: Exclude EventQueue.cpp in Debug_All build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 4 Apr 2011 20:45:39 +0000 (20:45 +0000)]
Attempted Mac build fix, part III
* WebCore.exp.in: Export PlatformCALayer::setGeometryFlipped. Also resorted some symbols.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Mon, 4 Apr 2011 20:42:38 +0000 (20:42 +0000)]
Fix the Mac build.
* WebCore.exp.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Mon, 4 Apr 2011 20:40:35 +0000 (20:40 +0000)]
2011-04-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Renamed Finalizer => WeakHandleOwner (in preparation for adding a reachability callback)
https://bugs.webkit.org/show_bug.cgi?id=57775
Also renamed noFinalizer => emptyWeakOwner, since this is really an
optimization for a weak owner with empty callbacks.
* collector/handles/HandleHeap.cpp:
(JSC::HandleHeap::clearWeakPointers): Updated for renames. Removed
redundant initialization of m_nextToFinalize. Moved deletion check inside
weak owner check, since the weak owner can't delete the node if there is
no weak owner!
* collector/handles/HandleHeap.h:
(JSC::WeakHandleOwner::~WeakHandleOwner):
(JSC::HandleHeap::makeWeak): Updated for renames.
(JSC::HandleHeap::hasWeakOwner): Changed getFinalizer to hasWeakOwner,
to clarify this function's role in assertions.
(JSC::HandleHeap::Node::Node):
(JSC::HandleHeap::Node::makeWeak):
(JSC::HandleHeap::Node::isWeak):
(JSC::HandleHeap::Node::weakOwner):
(JSC::HandleHeap::Node::weakOwnerContext):
(JSC::HandleHeap::Node::emptyWeakOwner):
* interpreter/RegisterFile.cpp:
(JSC::RegisterFile::globalObjectCollectedNotifier):
* interpreter/RegisterFile.h:
* runtime/WeakGCMap.h:
* runtime/WeakGCPtr.h:
(JSC::WeakGCPtr::WeakGCPtr):
(JSC::WeakGCPtr::set): Updated for renames.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Mon, 4 Apr 2011 20:39:59 +0000 (20:39 +0000)]
2011-04-04 Adrienne Walker <enne@google.com>
Unreviewed, mark revoke-blob-url.html as CRASH for Chromium on Win.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 20:35:42 +0000 (20:35 +0000)]
2011-04-04 David Dorwin <ddorwin@chromium.org>
Reviewed by David Levin.
Chromium Mac crashes when entering fullscreen
https://bugs.webkit.org/show_bug.cgi?id=57483
Override extraFullScreenStyleSheet in RenderThemeChromiumMac to avoid hitting the ASSERT_NOT_REACHED in RenderThemeMac.
* WebCore.gyp/WebCore.gyp:
* rendering/RenderThemeChromiumMac.h:
* rendering/RenderThemeChromiumMac.mm:
(WebCore::RenderThemeChromiumMac::extraFullScreenStyleSheet):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 4 Apr 2011 20:32:46 +0000 (20:32 +0000)]
Attempted Mac build fix, part II
* WebCore.xcodeproj/project.pbxproj: Marked PlatformCALayerClient.h and
PlatformCAAnimation.h as private so that WebKit2 can #include them (transitively).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Mon, 4 Apr 2011 20:27:08 +0000 (20:27 +0000)]
Remove unused AnalyzeWithLargeStack code from Windows build files
https://bugs.webkit.org/show_bug.cgi?id=57771
Reviewed by Adam Roben.
This was used for us to build with prefast automatically,
but it is out-of-date and hasn't been used for some time.
Removing completely for now.
Source/WebCore:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCorePreBuild.cmd:
Source/WebKit/win:
* WebKit.vcproj/WebKitLibPreBuild.cmd:
Source/WebKit2:
* win/WebKitPreBuild.cmd:
WebKitLibraries:
* win/tools/vsprops/common.vsprops:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mdelaney@apple.com [Mon, 4 Apr 2011 20:26:26 +0000 (20:26 +0000)]
2011-04-01 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
[CG] Do not accelerate small canvases
https://bugs.webkit.org/show_bug.cgi?id=57596
No new tests. No outward behavior changes.
* platform/graphics/cg/ImageBufferCG.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 4 Apr 2011 20:21:18 +0000 (20:21 +0000)]
Attempted Mac build fix
* WebCore.xcodeproj/project.pbxproj: Marked PlatformCALayer.h and GraphicsLayerCA.h private
so that WebKit can #include them.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 4 Apr 2011 20:14:13 +0000 (20:14 +0000)]
Fix WinCE build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 4 Apr 2011 20:12:40 +0000 (20:12 +0000)]
Attempt to fix the Windows build.
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::setShouldPaintNativeControls):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 4 Apr 2011 19:40:47 +0000 (19:40 +0000)]
2011-04-04 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
Make it easier to send a message to all processes in a context
https://bugs.webkit.org/show_bug.cgi?id=57776
Add WebContext::sendToAllProcesses and WebContext::sendToAllProcessesRelaunchingThemIfNecessary
as a first step towards getting rid of WebContext::process() and getting rid of a class of crashers
where WebContext::process() is null.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::initializeHistoryClient):
(WebKit::WebContext::languageChanged):
(WebKit::WebContext::setAlwaysUsesComplexTextCodePath):
(WebKit::WebContext::registerURLSchemeAsEmptyDocument):
(WebKit::WebContext::registerURLSchemeAsSecure):
(WebKit::WebContext::setDomainRelaxationForbiddenForURLScheme):
(WebKit::WebContext::setCacheModel):
(WebKit::WebContext::setDefaultRequestTimeoutInterval):
(WebKit::WebContext::clearResourceCaches):
(WebKit::WebContext::clearApplicationCache):
(WebKit::WebContext::setEnhancedAccessibility):
(WebKit::WebContext::startMemorySampler):
Use sendToAllProcesses.
(WebKit::WebContext::stopMemorySampler):
Use sendToAllProcesses. This is a slight policy change where we now create a sandbox extension even
if there's no process around. Since this is a debugging tool it seems OK to do this.
* UIProcess/WebContext.h:
Get rid of hasValidProcess.
(WebKit::WebContext::sendToAllProcesses):
If we have a process and we can send messages to it, then do so.
(WebKit::WebContext::sendToAllProcessesRelaunchingThemIfNecessary):
Relaunch the web process and send the message.
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
Use sendToAllProcesses and sendToAllProcessesRelaunchingThemIfNecessary.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 4 Apr 2011 19:33:42 +0000 (19:33 +0000)]
Delete mt.dep files when doing a clean build due to .vsprops file changes
Apparently this is yet another file that Visual Studio can't figure out it needs to rebuild.
Fixes <http://webkit.org/b/57777> r82850 failed to build on Windows Debug (Build)
Reviewed by Brian Weinstein.
* JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:
(main): Added dep to the list of extensions we look for when choosing files to delete.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 4 Apr 2011 19:33:10 +0000 (19:33 +0000)]
Move a teensy bit of non-Mac-specific code up to LayerTreeHostCA
Fixes <http://webkit.org/b/57774> LayerTreeHostCA should know how to flip the root layer
Reviewed by Anders Carlsson.
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp:
(WebKit::LayerTreeHostCA::initialize): Cross-platformized and moved some code here...
* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::platformInitialize): ...from here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Mon, 4 Apr 2011 19:30:27 +0000 (19:30 +0000)]
WK2: Reproducible crash when dragging out of or over Safari window.
https://bugs.webkit.org/show_bug.cgi?id=57654
<rdar://problem/9139755>
Reviewed by Darin Adler.
AppKit does not retain the owner given to the pasteboard, therefore we
need to give the ownership of the retained pointer to NSPasteboard.
Also, dragImage will release the NSFilePromiseDragSource object, therefore
we retain it before calling dragImage to be able to control its lifetime.
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage): Passing ownership
of the pointer to AppKit when providing the owner pointer to the NSPasteboard
object.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformDragEnded): Retaining the NSFilePromiseDragSource
since dragImage will release it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Mon, 4 Apr 2011 19:19:01 +0000 (19:19 +0000)]
2011-03-30 Jer Noble <jer.noble@apple.com>
Reviewed by Dan Bernstein.
WebKit2: No "open in preview" contextual menu item for PDFs
https://bugs.webkit.org/show_bug.cgi?id=57527
Add support for opening a PDF in the associated application from the
context menu.
* UIProcess/API/mac/PDFViewController.mm:
(_applicationInfoForMIMEType): Added, copied from WebKit/WebPDFView.mm
(-[WKPDFView _openWithFinder:]): Added.
(-[WKPDFView hitTest:]): Added, copied from WebKit/WebPDFView.mm.
(-[WKPDFView menuForEvent:]): Added, adapted from WebKit/WebPDFVie.mm.
(-[WKPDFView validateUserInterfaceItem:]): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Mon, 4 Apr 2011 19:14:33 +0000 (19:14 +0000)]
Reviewed by Kevin Ollivier.
[wx] Implement support for temporary files.
https://bugs.webkit.org/show_bug.cgi?id=57772
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Mon, 4 Apr 2011 18:54:59 +0000 (18:54 +0000)]
Fix Windows build warning.
https://bugs.webkit.org/show_bug.cgi?id=57767
Reviewed by Brian Weinstein.
* win/tools/vsprops/common.vsprops:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 4 Apr 2011 18:41:15 +0000 (18:41 +0000)]
2011-04-01 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make StructureChain GC allocated
https://bugs.webkit.org/show_bug.cgi?id=56695
Make StructureChain GC allocated, and make the various owners
mark it correctly.
* JavaScriptCore.exp:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::derefStructures):
(JSC::CodeBlock::refStructures):
(JSC::CodeBlock::markAggregate):
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::derefStructures):
(JSC::PolymorphicAccessStructureList::markAggregate):
(JSC::Instruction::Instruction):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::markAggregate):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initPutByIdTransition):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
* collector/handles/Handle.h:
(JSC::HandleConverter::operator->):
(JSC::HandleConverter::operator*):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jneq_ptr):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_jneq_ptr):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::getPolymorphicAccessStructureListSlot):
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSCell.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::markIfNeeded):
* runtime/JSGlobalObject.h:
(JSC::Structure::prototypeChain):
* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::markChildrenDirect):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
(JSC::JSPropertyNameIterator::get):
(JSC::JSPropertyNameIterator::markChildren):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::setCachedPrototypeChain):
* runtime/JSZombie.cpp:
(JSC::JSZombie::leakedZombieStructure):
* runtime/JSZombie.h:
* runtime/MarkStack.h:
(JSC::MarkStack::append):
* runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep):
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransition):
* runtime/Structure.h:
(JSC::Structure::markAggregate):
* runtime/StructureChain.cpp:
(JSC::StructureChain::StructureChain):
(JSC::StructureChain::~StructureChain):
(JSC::StructureChain::markChildren):
* runtime/StructureChain.h:
(JSC::StructureChain::create):
(JSC::StructureChain::createStructure):
* runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::operator->):
2011-04-01 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make StructureChain GC allocated
https://bugs.webkit.org/show_bug.cgi?id=56695
Update for new Structure marking function
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::markChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 18:29:22 +0000 (18:29 +0000)]
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572
Unskip passed tests.
* platform/mac-wk2/Skipped:
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::decode):
(WebKit::WebPreferencesStore::overrideAllowFileAccessFromFileURLsForTestRunner):
* Shared/WebPreferencesStore.h:
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetAllowFileAccessFromFileURLs):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAllowFileAccessFromFileURLs):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 4 Apr 2011 18:00:32 +0000 (18:00 +0000)]
2011-04-04 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add support for the enumerated types in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=57761
* inspector/debugger/debugger-autocontinue-on-syntax-error.html:
* inspector/debugger/debugger-pause-on-exception.html:
2011-04-04 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add support for the enumerated types in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=57761
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setPauseOnExceptions):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::scriptImportedImpl):
* inspector/InspectorResourceAgent.cpp:
(WebCore::cachedResourceTypeString):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::setInitialXHRContent):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/ScriptsPanel.js:
* inspector/generate-inspector-idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 17:47:03 +0000 (17:47 +0000)]
2011-04-04 Jon Lee <jonlee@apple.com>
Reviewed by Eric Seidel.
add some directories to .gitignore (and svn:ignore) when opening projects in xcode4
https://bugs.webkit.org/show_bug.cgi?id=57646
* .gitignore: added xcode 4 related project and workspace directories that are not needed for checkin
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 4 Apr 2011 17:32:51 +0000 (17:32 +0000)]
2011-04-04 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: InspectorRuntimeAgent should not depend on Page
https://bugs.webkit.org/show_bug.cgi?id=57759
Descendants of InspectorRuntimeAgent should implement a method providing access to the default
inspected state used for console evaluations.
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent): runtime agent is created and deleted along with other agents.
(WebCore::InspectorAgent::setFrontend):
* inspector/InspectorAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::create):
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
* inspector/InspectorRuntimeAgent.h:
(WebCore::InspectorRuntimeAgent::InspectedStateProvider::~InspectedStateProvider):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 17:29:53 +0000 (17:29 +0000)]
2011-04-04 Keith Kyzivat <keith.kyzivat@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] DumpRenderTree breaks compilation in some uClibc environments
https://bugs.webkit.org/show_bug.cgi?id=57602
* DumpRenderTree/qt/main.cpp:
(get_backtrace):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 17:05:55 +0000 (17:05 +0000)]
2011-04-04 Yong Li <yoli@rim.com>
Reviewed by Antonio Gomes.
https://bugs.webkit.org/show_bug.cgi?id=55969
Add a test that verifies history scroll position is restored
when WebKit goes forward from an unreachable URL error page.
(Error page handling is only supported by Qt DRT.)
* platform/qt/fast/history/back-to-unreachable-url-then-forward-expected.txt: Added.
* platform/qt/fast/history/back-to-unreachable-url-then-forward.html: Added.
* platform/qt/fast/history/resources/check-scroll-position.html: Added.
2011-04-04 Yong Li <yoli@rim.com>
Reviewed by Antonio Gomes.
https://bugs.webkit.org/show_bug.cgi?id=55969
Fix the issue that document state is not saved when
going backward and ending up with error page.
Test: platform/qt/fast/history/back-to-unreachable-url-then-forward.html
(For manual test, load a non-existent html first, then load
fast/history/resources/check-scroll-position.html, then go
back and go forward. If it doesn't show "SUCCESS" at the bottom
of the page, your browser has failed the test)
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::load):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Mon, 4 Apr 2011 16:51:34 +0000 (16:51 +0000)]
[wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Mon, 4 Apr 2011 16:36:49 +0000 (16:36 +0000)]
Remove a test from the win-wk2 skipped list that does not exist.
fast/js/navigator-mimeTypes-length.html was changed and moved to plugins in r71651.
* platform/win-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Mon, 4 Apr 2011 16:20:50 +0000 (16:20 +0000)]
[Windows 7 WebKit2 Release Tests] 6 tests failing since being removed from the mac-wk2
skipped list in r82625.
https://bugs.webkit.org/show_bug.cgi?id=57705
Unreviewed, addd win-wk2 expected results for the tests in order to get the bots green.
* platform/win-wk2/editing: Added.
* platform/win-wk2/editing/selection: Added.
* platform/win-wk2/editing/selection/after-line-break-expected.txt: Added.
* platform/win-wk2/editing/selection/caret-ltr-right-expected.checksum: Added.
* platform/win-wk2/editing/selection/caret-ltr-right-expected.png: Added.
* platform/win-wk2/editing/selection/caret-ltr-right-expected.txt: Added.
* platform/win-wk2/editing/selection/caret-rtl-2-left-expected.checksum: Added.
* platform/win-wk2/editing/selection/caret-rtl-2-left-expected.png: Added.
* platform/win-wk2/editing/selection/caret-rtl-2-left-expected.txt: Added.
* platform/win-wk2/editing/selection/drag-text-delay-expected.txt: Added.
* platform/win-wk2/fast/repaint: Added.
* platform/win-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
Apparently the pixel results are similar enough to the win expected pixel results that no
special pixel results need to be added for win-wk2.
* platform/win-wk2/plugins/resize-from-plugin-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc