WebKit-https.git
8 years ago[Chromium] Rename WebKitClient to WebKitPlatformSupport
abarth@webkit.org [Wed, 31 Aug 2011 21:10:36 +0000 (21:10 +0000)]
[Chromium] Rename WebKitClient to WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=67309

Reviewed by Darin Fisher.

WebKitClient doesn't actually represent the WebKit Client.  Instead, it
represents supporting code for the WebKit Platform.  This patch renames
WebKitClient to WebKitPlatformSupport to make it easier for folks to
understand the difference between the Client and the Platform.

This patch includes shims so as not to break the Chromium build.  Once
the Chromium side is updated, I'll remove the shims.

* WebKit.gyp:
* public/WebFrameClient.h:
* public/WebKit.h:
(WebKit::webKitClient):
* public/WebKitClient.h: Removed.
* public/WebKitPlatformSupport.h: Copied from Source/WebKit/chromium/public/WebKitClient.h.
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
* src/ApplicationCacheHostInternal.h:
* src/AssociatedURLLoader.cpp:
* src/AsyncFileSystemChromium.cpp:
(WebCore::AsyncFileSystemChromium::AsyncFileSystemChromium):
* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestination::hardwareSampleRate):
* src/BlobRegistryProxy.cpp:
(WebCore::BlobRegistryProxy::BlobRegistryProxy):
* src/CCThreadImpl.cpp:
(WebKit::CCThreadImpl::CCThreadImpl):
* src/ChromiumCurrentTime.cpp:
(WTF::currentTime):
(WTF::monotonicallyIncreasingTime):
* src/ChromiumOSRandomSource.cpp:
(WTF::cryptographicallyRandomValuesFromOS):
* src/ChromiumThreading.cpp:
(WTF::ChromiumThreading::callOnMainThread):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::canShowMIMEType):
(WebKit::FrameLoaderClientImpl::userAgent):
* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::create):
* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
* src/LocalizedStrings.cpp:
(WebCore::query):
* src/PlatformBridge.cpp:
(WebCore::getCookieJar):
(WebCore::PlatformBridge::cacheMetadata):
(WebCore::PlatformBridge::clipboardIsFormatAvailable):
(WebCore::PlatformBridge::clipboardReadPlainText):
(WebCore::PlatformBridge::clipboardReadHTML):
(WebCore::PlatformBridge::clipboardReadImage):
(WebCore::PlatformBridge::clipboardGetSequenceNumber):
(WebCore::PlatformBridge::clipboardWriteSelection):
(WebCore::PlatformBridge::clipboardWritePlainText):
(WebCore::PlatformBridge::clipboardWriteURL):
(WebCore::PlatformBridge::clipboardWriteImage):
(WebCore::PlatformBridge::clipboardWriteData):
(WebCore::PlatformBridge::clipboardReadAvailableTypes):
(WebCore::PlatformBridge::clipboardReadData):
(WebCore::PlatformBridge::clipboardReadFilenames):
(WebCore::PlatformBridge::prefetchDNS):
(WebCore::PlatformBridge::fileExists):
(WebCore::PlatformBridge::deleteFile):
(WebCore::PlatformBridge::deleteEmptyDirectory):
(WebCore::PlatformBridge::getFileSize):
(WebCore::PlatformBridge::revealFolderInOS):
(WebCore::PlatformBridge::getFileModificationTime):
(WebCore::PlatformBridge::directoryName):
(WebCore::PlatformBridge::pathByAppendingComponent):
(WebCore::PlatformBridge::makeAllDirectories):
(WebCore::PlatformBridge::getAbsolutePath):
(WebCore::PlatformBridge::isDirectory):
(WebCore::PlatformBridge::filePathToURL):
(WebCore::PlatformBridge::openFile):
(WebCore::PlatformBridge::closeFile):
(WebCore::PlatformBridge::seekFile):
(WebCore::PlatformBridge::truncateFile):
(WebCore::PlatformBridge::readFromFile):
(WebCore::PlatformBridge::writeToFile):
(WebCore::PlatformBridge::ensureFontLoaded):
(WebCore::PlatformBridge::loadFont):
(WebCore::PlatformBridge::getFontFamilyForCharacters):
(WebCore::PlatformBridge::getRenderStyleForStrike):
(WebCore::PlatformBridge::databaseOpenFile):
(WebCore::PlatformBridge::databaseDeleteFile):
(WebCore::PlatformBridge::databaseGetFileAttributes):
(WebCore::PlatformBridge::databaseGetFileSize):
(WebCore::PlatformBridge::databaseGetSpaceAvailableForOrigin):
(WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath):
(WebCore::PlatformBridge::injectIDBKeyIntoSerializedValue):
(WebCore::PlatformBridge::signedPublicKeyAndChallengeString):
(WebCore::PlatformBridge::computedDefaultLanguage):
(WebCore::PlatformBridge::isSupportedImageMIMEType):
(WebCore::PlatformBridge::isSupportedJavaScriptMIMEType):
(WebCore::PlatformBridge::isSupportedNonImageMIMEType):
(WebCore::PlatformBridge::mimeTypeForExtension):
(WebCore::PlatformBridge::wellKnownMimeTypeForExtension):
(WebCore::PlatformBridge::mimeTypeFromFile):
(WebCore::PlatformBridge::preferredExtensionForMIMEType):
(WebCore::PlatformBridge::plugins):
(WebCore::PlatformBridge::loadPlatformImageResource):
(WebCore::PlatformBridge::loadPlatformAudioResource):
(WebCore::PlatformBridge::decodeAudioFileData):
(WebCore::PlatformBridge::sandboxEnabled):
(WebCore::PlatformBridge::setSharedTimerFiredFunction):
(WebCore::PlatformBridge::setSharedTimerFireInterval):
(WebCore::PlatformBridge::stopSharedTimer):
(WebCore::PlatformBridge::decrementStatsCounter):
(WebCore::PlatformBridge::incrementStatsCounter):
(WebCore::PlatformBridge::histogramCustomCounts):
(WebCore::PlatformBridge::histogramEnumeration):
(WebCore::PlatformBridge::suddenTerminationChanged):
(WebCore::PlatformBridge::paintButton):
(WebCore::PlatformBridge::paintMenuList):
(WebCore::PlatformBridge::paintScrollbarArrow):
(WebCore::PlatformBridge::paintScrollbarThumb):
(WebCore::PlatformBridge::paintScrollbarTrack):
(WebCore::PlatformBridge::paintSpinButton):
(WebCore::PlatformBridge::paintTextField):
(WebCore::PlatformBridge::paintTrackbar):
(WebCore::PlatformBridge::paintProgressBar):
(WebCore::PlatformBridge::getThemePartSize):
(WebCore::PlatformBridge::paintThemePart):
(WebCore::PlatformBridge::traceEventBegin):
(WebCore::PlatformBridge::traceEventEnd):
(WebCore::PlatformBridge::visitedLinkHash):
(WebCore::PlatformBridge::isLinkVisited):
(WebCore::PlatformBridge::memoryUsageMB):
(WebCore::PlatformBridge::actualMemoryUsageMB):
* src/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
* src/ResourceHandle.cpp:
(WebCore::ResourceHandleInternal::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
* src/SharedWorkerRepository.cpp:
(WebCore::SharedWorkerRepository::isAvailable):
(WebCore::SharedWorkerRepository::connect):
(WebCore::SharedWorkerRepository::documentDetached):
(WebCore::SharedWorkerRepository::hasSharedWorkers):
* src/SocketStreamHandle.cpp:
(WebCore::SocketStreamHandleInternal::connect):
* src/StorageEventDispatcherChromium.cpp:
(WebCore::StorageEventDispatcher::dispatch):
* src/StorageNamespaceProxy.cpp:
(WebCore::StorageNamespace::localStorageNamespace):
* src/WebKit.cpp:
(WebKit::generateEntropy):
(WebKit::initialize):
(WebKit::shutdown):
(WebKit::webKitPlatformSupport):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::supportsType):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::copy):
* src/WebViewImpl.cpp:
* src/WebWorkerClientImpl.cpp:
* src/WorkerAsyncFileSystemChromium.cpp:
(WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
* src/WorkerFileWriterCallbacksBridge.cpp:
(WebKit::WorkerFileWriterCallbacksBridge::initOnMainThread):
* tests/RunAllTests.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
abarth@webkit.org [Wed, 31 Aug 2011 21:07:30 +0000 (21:07 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-31

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMinor cleanup: remove inScriptExecution()
tonyg@chromium.org [Wed, 31 Aug 2011 21:03:23 +0000 (21:03 +0000)]
Minor cleanup: remove inScriptExecution()
https://bugs.webkit.org/show_bug.cgi?id=67276

Reviewed by Adam Barth.

At one point inScriptExecution() existed as a non-virtual duplicate of isExecutingScript()
to avoid virtual method calls from a tight loop. Now we aren't calling it anywhere perf
sensitive, so remove the duplication.

No new tests because no change in functionality.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::isExecutingScript):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
(WebCore::HTMLDocumentParser::notifyFinished):
* html/parser/HTMLDocumentParser.h:
(WebCore::HTMLDocumentParser::shouldDelayEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd queues.webkit.org/active-bots page to make it easy to see which bots are down
eric@webkit.org [Wed, 31 Aug 2011 20:58:17 +0000 (20:58 +0000)]
Add queues.webkit.org/active-bots page to make it easy to see which bots are down
https://bugs.webkit.org/show_bug.cgi?id=67314

Reviewed by Adam Barth.

Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
This makes it very easy for me to see which of my cr-jail bots might be down at any one time.

I also moved a bunch of code into dashboard.css which belonged there.

* QueueStatusServer/handlers/activebots.py: Added.
* QueueStatusServer/main.py:
* QueueStatusServer/stylesheets/dashboard.css:
(.queue_bubble):
(.queue_name):
(.last_heard_from):
(.status_text):
(.alive):
(.behind):
(.dead):
* QueueStatusServer/templates/activebots.html: Added.
* QueueStatusServer/templates/dashboard.html:
* QueueStatusServer/templates/recentstatus.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd new platform-specific results from r94211
robert@webkit.org [Wed, 31 Aug 2011 20:56:10 +0000 (20:56 +0000)]
Add new platform-specific results from r94211

Unreviewed.

* platform/gtk/css2.1/20110323/margin-applies-to-001-expected.txt: Added.
* platform/gtk/css2.1/20110323/margin-applies-to-002-expected.txt: Added.
* platform/gtk/css2.1/20110323/margin-applies-to-003-expected.txt: Added.
* platform/gtk/css2.1/20110323/margin-applies-to-004-expected.txt: Added.
* platform/gtk/css2.1/20110323/margin-applies-to-005-expected.txt: Added.
* platform/gtk/css2.1/20110323/margin-applies-to-006-expected.txt: Added.
* platform/gtk/css2.1/20110323/margin-applies-to-007-expected.txt: Added.
* platform/gtk/css2.1/20110323/margin-applies-to-008-expected.txt: Added.
* platform/gtk/css2.1/20110323/margin-applies-to-009-expected.txt: Added.
* platform/gtk/css2.1/20110323/margin-applies-to-010-expected.txt: Added.
* platform/gtk/css2.1/20110323/margin-applies-to-012-expected.txt: Added.
* platform/gtk/css2.1/20110323/margin-applies-to-013-expected.txt: Added.
* platform/gtk/css2.1/20110323/margin-applies-to-014-expected.txt: Added.
* platform/gtk/css2.1/20110323/margin-applies-to-015-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-001-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-002-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-003-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-004-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-005-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-006-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-007-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-008-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-009-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-010-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-012-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-013-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-014-expected.txt: Added.
* platform/mac/css2.1/20110323/margin-applies-to-015-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-001-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-002-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-003-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-004-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-005-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-006-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-007-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-008-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-009-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-010-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-012-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-013-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-014-expected.txt: Added.
* platform/qt/css2.1/20110323/margin-applies-to-015-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update test expectation due to r94206 and r94211.
levin@chromium.org [Wed, 31 Aug 2011 20:53:04 +0000 (20:53 +0000)]
[chromium] Update test expectation due to r94206 and r94211.

* platform/chromium-win/fast/borders/border-image-source-expected.png: Added.
* platform/chromium-win/fast/borders/border-image-source-expected.txt: Added.
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix XSS filter bypass by multiply decoding both the URL and the body
commit-queue@webkit.org [Wed, 31 Aug 2011 20:52:10 +0000 (20:52 +0000)]
Fix XSS filter bypass by multiply decoding both the URL and the body
snippet until they are in the most minimal form before comparison.
https://bugs.webkit.org/show_bug.cgi?id=66585

Patch by Tom Sepez <tsepez@chromium.org> on 2011-08-31
Reviewed by Adam Barth.

Source/WebCore:

* html/parser/XSSAuditor.cpp:
(WebCore::fullyDecodeString):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::isContainedInRequest):

LayoutTests:

* http/tests/security/xssAuditor/anchor-url-dom-write-location2.html:
* http/tests/security/xssAuditor/resources/echo-dom-write-unescaped-location.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed; new baselines (Skia on Mac, next chunk of 800 files)
caryclark@google.com [Wed, 31 Aug 2011 20:46:22 +0000 (20:46 +0000)]
Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
fast/overflow through svg/batik/text

* platform/chromium-mac/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
(remaining files omitted for brevity)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed; new baselines (Skia on Mac, next chunk of 800 files)
caryclark@google.com [Wed, 31 Aug 2011 20:32:14 +0000 (20:32 +0000)]
Unreviewed; new baselines (Skia on Mac, next chunk of 800 files)
Most files were inadvertantly excluded from earlier checkins.

* platform/chromium-mac/fast/overflow: Added.
(remaining files omitted for brevity)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate platform-specific results after r94211
robert@webkit.org [Wed, 31 Aug 2011 20:16:17 +0000 (20:16 +0000)]
Update platform-specific results after r94211

Unreviewed, update platform-specifc results.

* platform/gtk/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/captions3-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions3-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
* platform/qt/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/qt/tables/mozilla_expected_failures/core/captions2-expected.txt:
* platform/qt/tables/mozilla_expected_failures/core/captions3-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove CheckedArithmeticOperations.cpp to the intended location
oliver@apple.com [Wed, 31 Aug 2011 20:14:16 +0000 (20:14 +0000)]
Move CheckedArithmeticOperations.cpp to the intended location

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoadd unittest to validate the complete set of Chromium configurations
commit-queue@webkit.org [Wed, 31 Aug 2011 20:09:35 +0000 (20:09 +0000)]
add unittest to validate the complete set of Chromium configurations
https://bugs.webkit.org/show_bug.cgi?id=67211

Patch by Elliot Poger <epoger@google.com> on 2011-08-31
Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash with -webkit-radial-gradient(top) gradient
simon.fraser@apple.com [Wed, 31 Aug 2011 19:12:36 +0000 (19:12 +0000)]
Crash with -webkit-radial-gradient(top) gradient
https://bugs.webkit.org/show_bug.cgi?id=66686

Source/WebCore:

Reviewed by Darin Adler.

Null-check the current value after calling parseFillPosition(),
since it may be null for gradients with degenerate arguments.

Test: fast/gradients/css3-radial-gradient-crash.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseRadialGradient):

LayoutTests:

Reviewed by Darin Adler.

Test case with degenerate arguments in a radial gradient.

* fast/gradients/css3-radial-gradient-crash-expected.txt: Added.
* fast/gradients/css3-radial-gradient-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
thakis@chromium.org [Wed, 31 Aug 2011 19:08:24 +0000 (19:08 +0000)]
Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
https://bugs.webkit.org/show_bug.cgi?id=67297

Reviewed by Tony Chang.

Source/WebCore:

I need this to disable smooth scrolling in chromium tests. I'm making
the change to ScrollAnimatorMac to make unforking the file easier. I
changed scrollAnimatorEnabled() to default to true so that this change
is a no-op for Safari; in chromium the flag is set explicitly to true
or false anyway.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::scroll):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scroll):

Tools:

Explicitly disable smooth scrolling in chromium's DRT.

* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::applyTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Don't load resources with empty urls, since this
japhet@chromium.org [Wed, 31 Aug 2011 19:01:08 +0000 (19:01 +0000)]
Source/WebCore: Don't load resources with empty urls, since this
will resolve to the current document.
https://bugs.webkit.org/show_bug.cgi?id=30303

Reviewed by Darin Adler.

Test: http/tests/loading/empty-urls.html

* dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript): If src="", fail through
    to the error event case.
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseMappedAttribute): Ensure the url
    stays empty if we try to resolve an empty href.
* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement): Throw an error instead of
    loading if the src is empty in all cases, not just local files.

LayoutTests: Test updates for https://bugs.webkit.org/show_bug.cgi?id=30303.

Reviewed by Darin Adler.

* fast/images/load-img-with-empty-src-expected.txt:
* fast/images/load-img-with-empty-src.html: Expect the same behavior whether or not an empty src
    is in a local file document.
* fast/tokenizer/002-expected.txt: Added.
* fast/tokenizer/002.html: Make dumpAsText().
* fast/tokenizer/external-script-document-write_2-expected.txt: Added.
* fast/tokenizer/external-script-document-write_2.html:: Make dumpAsText().
* fast/tokenizer/script_extra_close-expected.txt: Added.
* fast/tokenizer/script_extra_close.html:: Make dumpAsText().
* http/tests/loading/empty-urls-expected.txt: Added.
* http/tests/loading/empty-urls.html: Added. Test empty urls with a bunch of subresource types
    and ensure their error event behavior matches the spec.
* platform/chromium-cg-mac/fast/tokenizer/002-expected.txt: Removed.
* platform/chromium-cg-mac/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
* platform/chromium-linux/fast/tokenizer/002-expected.png: Removed.
* platform/chromium-linux/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
* platform/chromium-linux/fast/tokenizer/script_extra_close-expected.png: Removed.
* platform/chromium-win/fast/tokenizer/002-expected.png: Removed.
* platform/chromium-win/fast/tokenizer/002-expected.txt: Removed.
* platform/chromium-win/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
* platform/chromium-win/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
* platform/chromium-win/fast/tokenizer/script_extra_close-expected.png: Removed.
* platform/chromium-win/fast/tokenizer/script_extra_close-expected.txt: Removed.
* platform/gtk/fast/tokenizer/002-expected.png: Removed.
* platform/gtk/fast/tokenizer/002-expected.txt: Removed.
* platform/gtk/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
* platform/gtk/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
* platform/gtk/fast/tokenizer/script_extra_close-expected.png: Removed.
* platform/gtk/fast/tokenizer/script_extra_close-expected.txt: Removed.
* platform/mac-leopard/fast/tokenizer/002-expected.png: Removed.
* platform/mac-leopard/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
* platform/mac-leopard/fast/tokenizer/script_extra_close-expected.png: Removed.
* platform/mac/fast/tokenizer/002-expected.png: Removed.
* platform/mac/fast/tokenizer/002-expected.txt: Removed.
* platform/mac/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
* platform/mac/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
* platform/mac/fast/tokenizer/script_extra_close-expected.png: Removed.
* platform/mac/fast/tokenizer/script_extra_close-expected.txt: Removed.
* platform/qt/fast/tokenizer/002-expected.png: Removed.
* platform/qt/fast/tokenizer/002-expected.txt: Removed.
* platform/qt/fast/tokenizer/external-script-document-write_2-expected.png: Removed.
* platform/qt/fast/tokenizer/external-script-document-write_2-expected.txt: Removed.
* platform/qt/fast/tokenizer/script_extra_close-expected.png: Removed.
* platform/qt/fast/tokenizer/script_extra_close-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove appearance and performance of layout test results.html
simon.fraser@apple.com [Wed, 31 Aug 2011 18:57:55 +0000 (18:57 +0000)]
Improve appearance and performance of layout test results.html
https://bugs.webkit.org/show_bug.cgi?id=67252

Reviewed by Adam Barth, Ojan Vafai.

Improve the appearance of the pixel result comparison overlay.

Change the overlay from painting pixels into a canvas one by one
to using images enlarged with 'image-rendering: -webkit-optimize-contrast",
which is very much faster.

* fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS 2.1 failure: margin-applies-to-015 fails, WebKit does not respect top margin...
robert@webkit.org [Wed, 31 Aug 2011 18:48:28 +0000 (18:48 +0000)]
CSS 2.1 failure: margin-applies-to-015 fails, WebKit does not respect top margin for table captions
https://bugs.webkit.org/show_bug.cgi?id=34763

Reviewed by Simon Fraser.

Source/WebCore:

* rendering/RenderTable.cpp:
(WebCore::RenderTable::adjustLogicalHeightForCaption): Added the caption's margin to the position calculation.

LayoutTests:

* css2.1/20110323/margin-applies-to-001.htm: Added.
* css2.1/20110323/margin-applies-to-002.htm: Added.
* css2.1/20110323/margin-applies-to-003.htm: Added.
* css2.1/20110323/margin-applies-to-004.htm: Added.
* css2.1/20110323/margin-applies-to-005.htm: Added.
* css2.1/20110323/margin-applies-to-006.htm: Added.
* css2.1/20110323/margin-applies-to-007.htm: Added.
* css2.1/20110323/margin-applies-to-008.htm: Added.
* css2.1/20110323/margin-applies-to-009.htm: Added.
* css2.1/20110323/margin-applies-to-010.htm: Added.
* css2.1/20110323/margin-applies-to-012.htm: Added.
* css2.1/20110323/margin-applies-to-013.htm: Added.
* css2.1/20110323/margin-applies-to-014.htm: Added.
* css2.1/20110323/margin-applies-to-015.htm: Added.
  - Added from http://test.csswg.org/suites/css2.1/20110323/html4/chapter-8.html
* platform/chromium-linux/css2.1/20110323/margin-applies-to-001-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-001-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-002-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-002-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-003-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-003-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-004-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-004-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-005-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-005-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-006-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-006-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-007-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-007-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-008-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-008-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-009-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-009-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-010-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-010-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-012-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-012-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-013-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-013-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-014-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-014-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-015-expected.png: Added.
* platform/chromium-linux/css2.1/20110323/margin-applies-to-015-expected.txt: Added.
  - Chromium-Linux results for  http://test.csswg.org/suites/css2.1/20110323/html4/chapter-8.html
* platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/core/captions2-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/core/captions3-expected.txt:
  - Updated to reflect position of table caption taking account of margin, matching Firefox where appropriate. Still some
    unrelated failures that prevent matching Firefox exactly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-31 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 31 Aug 2011 18:37:50 +0000 (18:37 +0000)]
2011-08-31  Oliver Hunt  <oliver@apple.com>

        Add Checked<> tests to windows build

        * TestWebKitAPI/win/TestWebKitAPI.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd support for checked arithmetic
oliver@apple.com [Wed, 31 Aug 2011 18:16:11 +0000 (18:16 +0000)]
Add support for checked arithmetic
https://bugs.webkit.org/show_bug.cgi?id=67095

Reviewed by Sam Weinig.

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Add a checked arithmetic class Checked<T> that provides overflow-safe
arithmetic over all integral types.  Checked<T> supports addition, subtraction
and multiplication, along with "bool" conversions and equality operators.

Checked<> can be used in either CRASH() on overflow or delayed failure modes,
although the default is to CRASH().

To ensure the code is actually in use (rather than checking in dead code) I've
made a couple of properties in YARR use Checked<int> and Checked<unsigned>
instead of raw value arithmetic.  This has resulted in a moderate set of changes,
to YARR - mostly adding .get() calls, but a couple of casts from unsigned long
to unsigned for some uses of sizeof, as Checked<> currently does not support
mixed signed-ness of types wider that 32 bits.

Happily the increased type safety of Checked<> means that it's not possible to
accidentally assign away precision, nor accidentally call integer overload of
a function instead of the bool version.

No measurable regression in performance, and SunSpider claims this patch to be
a progression of 0.3%.

* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CheckedArithmetic.h: Added.
(WTF::CrashOnOverflow::overflowed):
(WTF::CrashOnOverflow::clearOverflow):
(WTF::CrashOnOverflow::hasOverflowed):
(WTF::RecordOverflow::RecordOverflow):
(WTF::RecordOverflow::overflowed):
(WTF::RecordOverflow::clearOverflow):
(WTF::RecordOverflow::hasOverflowed):
(WTF::isInBounds):
(WTF::safeAdd):
(WTF::safeSub):
(WTF::safeMultiply):
(WTF::safeEquals):
(WTF::workAroundClangBug):
(WTF::Checked::Checked):
(WTF::Checked::operator=):
(WTF::Checked::operator++):
(WTF::Checked::operator--):
(WTF::Checked::operator!):
(WTF::Checked::operator UnspecifiedBoolType*):
(WTF::Checked::get):
(WTF::Checked::operator+=):
(WTF::Checked::operator-=):
(WTF::Checked::operator*=):
(WTF::Checked::operator==):
(WTF::Checked::operator!=):
(WTF::operator+):
(WTF::operator-):
(WTF::operator*):
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::atomPatternCharacter):
(JSC::Yarr::ByteCompiler::atomCharacterClass):
(JSC::Yarr::ByteCompiler::atomBackReference):
(JSC::Yarr::ByteCompiler::atomParentheticalAssertionEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd):
* yarr/YarrInterpreter.h:
(JSC::Yarr::ByteTerm::ByteTerm):
(JSC::Yarr::ByteTerm::CheckInput):
(JSC::Yarr::ByteTerm::UncheckInput):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generateAssertionEOL):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets):
* yarr/YarrPattern.h:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/WebCore:

Add a forwarding header for CheckedArithmetic.h

* ForwardingHeaders/wtf/CheckedArithmetic.h: Added.

../../../../Volumes/Data/git/WebKit/OpenSource/Tools:

Add test cases for Checked<>

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=67300
hyatt@apple.com [Wed, 31 Aug 2011 18:11:35 +0000 (18:11 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67300

Add the new border-image-source property (and its corresponding analogue for masks, mask-box-image-source).
Change the border-image parsing code to no longer consider "none" to represent the entire border-image
expression, but instead to just mean "none" for the image component of the expression.

Change the pending image code for border-image and mask-box-image to use the new *-source properties when
loading the image so that they're considered the same.

This is the first step towards eliminating the border-image parsing code in favor of just parsing it as
a shorthand instead, but for now I'm implementing each property one by one, and once they're all there,
we can cut over to border-image as a true shorthand.

Reviewed by Beth Dakin.

Added fast/borders/border-image-source.html.

Source/WebCore:

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseBorderImage):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):
(WebCore::CSSStyleSelector::loadPendingImages):
* rendering/style/NinePieceImage.h:
(WebCore::NinePieceImage::setImage):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::borderImageSource):
(WebCore::InheritedFlags::maskBoxImageSource):
(WebCore::InheritedFlags::setBorderImageSource):
(WebCore::InheritedFlags::setMaskBoxImageSource):
(WebCore::InheritedFlags::initialBorderImageSource):
(WebCore::InheritedFlags::initialMaskBoxImageSource):

LayoutTests:

* fast/borders/border-image-source.html: Added.
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed; new baselines (Skia on Mac, remainder of fast directory)
caryclark@google.com [Wed, 31 Aug 2011 17:54:23 +0000 (17:54 +0000)]
Unreviewed; new baselines (Skia on Mac, remainder of fast directory)

* platform/chromium-mac/fast/blockflow: Added.
(remaining files omitted for brevity)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove summary.html to garden-o-matic.html.
abarth@webkit.org [Wed, 31 Aug 2011 17:53:19 +0000 (17:53 +0000)]
Move summary.html to garden-o-matic.html.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] DRT linux should pass nativeKeyCode to plugins
noel.gordon@gmail.com [Wed, 31 Aug 2011 17:44:15 +0000 (17:44 +0000)]
[chromium] DRT linux should pass nativeKeyCode to plugins
https://bugs.webkit.org/show_bug.cgi?id=66679

Reviewed by Tony Chang.

Tools:

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
(simulated) nativeKeyCode for the given input keyboard code.

LayoutTests:

* platform/chromium-linux/plugins/keyboard-events-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Set the GrContext before SkGpuDevice is destroyed.
senorblanco@chromium.org [Wed, 31 Aug 2011 17:41:21 +0000 (17:41 +0000)]
[chromium] Set the GrContext before SkGpuDevice is destroyed.
https://bugs.webkit.org/show_bug.cgi?id=67296

When SkGpuDevice is destroyed, it frees the FBO used for accelerated
rendering.  If the wrong context is set (e.g., compositor context),
a crash may result.

Reviewed by Kenneth Russell.

No new tests.  (Unfortunately, wrong-context bugs are difficult to
express in a layout test).

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::~ImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTighen up UI for garden-o-matic tab strip
abarth@webkit.org [Wed, 31 Aug 2011 17:32:36 +0000 (17:32 +0000)]
Tighen up UI for garden-o-matic tab strip
https://bugs.webkit.org/show_bug.cgi?id=67266

Reviewed by Dimitri Glazkov.

This patch add CSS to move the tab strip to the edges of the page and
to remove some gratuitous border-radius.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic results view shouldn't be horrifically ugly
abarth@webkit.org [Wed, 31 Aug 2011 17:30:46 +0000 (17:30 +0000)]
garden-o-matic results view shouldn't be horrifically ugly
https://bugs.webkit.org/show_bug.cgi?id=67264

Reviewed by Dimitri Glazkov.

Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, fix inconsistent WebKit.gypi after r94106
nduca@chromium.org [Wed, 31 Aug 2011 17:20:58 +0000 (17:20 +0000)]
[Chromium] Unreviewed, fix inconsistent WebKit.gypi after r94106
https://bugs.webkit.org/show_bug.cgi?id=67288

* WebKit.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic needs a tabstrip
abarth@webkit.org [Wed, 31 Aug 2011 16:37:58 +0000 (16:37 +0000)]
garden-o-matic needs a tabstrip
https://bugs.webkit.org/show_bug.cgi?id=67263

Reviewed by Dimitri Glazkov.

This patch adds a basic tabstrip to garden-o-matic.  The results
details view now opens in the "Results" tab, and the user can flip back
and forth between the Summary and the Results tab quickly.  There's
also a stub for a "Commits" tab, which is disabled.

This patch isn't the most beautiful in the world, but it gets the ball
rolling on a multi-modal UI.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
kbalazs@webkit.org [Wed, 31 Aug 2011 16:34:38 +0000 (16:34 +0000)]
[Qt] Unreviewed gardening.
Unskip fast/files/create-blob-url.html after r94187

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up HTMLMediaElement behavior restrictions
eric.carlson@apple.com [Wed, 31 Aug 2011 16:31:24 +0000 (16:31 +0000)]
Clean up HTMLMediaElement behavior restrictions
https://bugs.webkit.org/show_bug.cgi?id=67231

Reviewed by Darin Adler.

No new tests, cleanup only.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Deal with enum and function renaming.
(WebCore::HTMLMediaElement::load): Call userGestureRequiredForLoad() instead of testing bits
    directly.
(WebCore::HTMLMediaElement::loadInternal): Deal with enum and function renaming.
(WebCore::HTMLMediaElement::play): Call userGestureRequiredForRateChange() instead of testing bits
    directly.
(WebCore::HTMLMediaElement::pause): Ditto.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::userGestureRequiredForLoad): Renamed.
(WebCore::HTMLMediaElement::userGestureRequiredForRateChange):
(WebCore::HTMLMediaElement::userGestureRequiredForFullscreen):
(WebCore::HTMLMediaElement::pageConsentRequiredForLoad):
(WebCore::HTMLMediaElement::addBehaviorRestriction):
(WebCore::HTMLMediaElement::removeBehaviorRestriction):

* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitEnterFullscreen): requireUserGestureForFullScreen renamed to
    userGestureRequiredForFullscreen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agounreviewed; new baselines (Skia on Mac, css3, edit, partial fast directories)
caryclark@google.com [Wed, 31 Aug 2011 16:20:20 +0000 (16:20 +0000)]
unreviewed; new baselines (Skia on Mac, css3, edit, partial fast directories)

* platform/chromium-mac/css3: Added.
* platform/chromium-mac/edit: Added.
* platform/chromium-mac/fast/backgrounds: Added.
(remaining files omitted for brevity)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnskip a test which now seems to be passing on GTK+.
mrobinson@webkit.org [Wed, 31 Aug 2011 16:09:35 +0000 (16:09 +0000)]
Unskip a test which now seems to be passing on GTK+.

* platform/gtk/Skipped: Unskip a test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Incorrect results for new fast/multicol tests added in r94084
kbalazs@webkit.org [Wed, 31 Aug 2011 15:25:57 +0000 (15:25 +0000)]
[Qt] Incorrect results for new fast/multicol tests added in r94084
https://bugs.webkit.org/show_bug.cgi?id=67293

Unreviwed gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-31 Andrei Popescu <andreip@google.com>
andreip@google.com [Wed, 31 Aug 2011 15:25:09 +0000 (15:25 +0000)]
2011-08-31  Andrei Popescu  <andreip@google.com>

Investigate current uses of OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66761

Unreviewed, build fix for ARM platforms.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInvestigate current uses of OS(ANDROID)
andreip@google.com [Wed, 31 Aug 2011 15:10:10 +0000 (15:10 +0000)]
Investigate current uses of OS(ANDROID)
https://bugs.webkit.org/show_bug.cgi?id=66761

Reviewed by Darin Adler.

Remove the last legacy Android code.

No new tests needed as the code wasn't tested in the first place.

Source/JavaScriptCore:

* wtf/Atomics.h:
* wtf/Platform.h:
* wtf/ThreadingPthreads.cpp:
(WTF::createThreadInternal):

Source/WebCore:

* bridge/jni/JNIUtility.cpp:
(JSC::Bindings::getJNIEnv):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agounreviewed; new baselines (Skia on Mac, css2.1 directory only)
caryclark@google.com [Wed, 31 Aug 2011 15:02:48 +0000 (15:02 +0000)]
unreviewed; new baselines (Skia on Mac, css2.1 directory only)

* platform/chromium-mac/css2.1: Added.
* platform/chromium-mac/css2.1/20110323: Added.
* platform/chromium-mac/css2.1/20110323/absolute-non-replaced-height-001-expected.png: Added.
(remaining files omitted for brevity)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94082.
commit-queue@webkit.org [Wed, 31 Aug 2011 14:52:50 +0000 (14:52 +0000)]
Unreviewed, rolling out r94082.
http://trac.webkit.org/changeset/94082
https://bugs.webkit.org/show_bug.cgi?id=67291

Breaks trunk (not canary) Chromium Mac builders upon WebKit
roll (Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-31

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add a convenience function to cast a QTransform to TransformationMatrix
noam.rosenthal@nokia.com [Wed, 31 Aug 2011 14:50:31 +0000 (14:50 +0000)]
[Qt] Add a convenience function to cast a QTransform to TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=67246

Reviewed by Andreas Kling.

No new functionality so no new tests.

* platform/graphics/qt/TransformationMatrixQt.cpp:
(WebCore::TransformationMatrix::TransformationMatrix):
* platform/graphics/transforms/TransformationMatrix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Unreviewed, revert part of r94168, the test didn't need result
philn@webkit.org [Wed, 31 Aug 2011 14:43:56 +0000 (14:43 +0000)]
    Unreviewed, revert part of r94168, the test didn't need result
        update. Proper fix is worked on in bug 66045.

        * fast/files/create-blob-url-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94176.
commit-queue@webkit.org [Wed, 31 Aug 2011 14:37:09 +0000 (14:37 +0000)]
Unreviewed, rolling out r94176.
http://trac.webkit.org/changeset/94176
https://bugs.webkit.org/show_bug.cgi?id=67290

This does not fix the build failure on Macs (Requested by
apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-31

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[skia] antialias images if we're rotated
reed@google.com [Wed, 31 Aug 2011 14:03:26 +0000 (14:03 +0000)]
[skia] antialias images if we're rotated
https://bugs.webkit.org/show_bug.cgi?id=67207

Reviewed by Stephen White.

Source/WebCore:

* platform/graphics/skia/ImageSkia.cpp:
(WebCore::hasNon90rotation):
(WebCore::paintSkBitmap):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewedly skip new failures.
kbalazs@webkit.org [Wed, 31 Aug 2011 13:37:12 +0000 (13:37 +0000)]
[Qt] Unreviewedly skip new failures.

It covers the following bugs:
  * Ping-pong with fast/files/create-blob-url-crash-expected.txt
    https://bugs.webkit.org/show_bug.cgi?id=67282
  * [Qt] css2.1/t090204-display-change-01-b-ao.html fails after r94084
    https://bugs.webkit.org/show_bug.cgi?id=67286

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Unreviewed, rebaseline GTK-specific font tests.
philn@webkit.org [Wed, 31 Aug 2011 13:24:14 +0000 (13:24 +0000)]
    Unreviewed, rebaseline GTK-specific font tests.

        * platform/gtk/fonts/complex-text-shadows-expected.txt:
        * platform/gtk/fonts/font-face-with-complex-text-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unskip API test for load signals order
caio.oliveira@openbossa.org [Wed, 31 Aug 2011 13:11:48 +0000 (13:11 +0000)]
[Qt] Unskip API test for load signals order
https://bugs.webkit.org/show_bug.cgi?id=67285

Reviewed by Andreas Kling.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::loadSignalsOrder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Having the "Metrics" pane open affects the node highlight display
apavlov@chromium.org [Wed, 31 Aug 2011 12:53:12 +0000 (12:53 +0000)]
Web Inspector: Having the "Metrics" pane open affects the node highlight display
https://bugs.webkit.org/show_bug.cgi?id=67278

Reviewed by Yury Semikhatsky.

* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._updateMetrics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-31 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 31 Aug 2011 12:50:36 +0000 (12:50 +0000)]
2011-08-31  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, build fix after r94167.

        * inspector/debugger/script-formatter.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
kbalazs@webkit.org [Wed, 31 Aug 2011 12:49:57 +0000 (12:49 +0000)]
[Qt] Unreviewed gardening.
Skipped the wrong test in a previous gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: console view does a style recalculation per each addMessage call.
loislo@chromium.org [Wed, 31 Aug 2011 12:13:47 +0000 (12:13 +0000)]
Web Inspector: console view does a style recalculation per each addMessage call.
https://bugs.webkit.org/show_bug.cgi?id=67198

It is bad from the performance point of view.

Reviewed by Yury Semikhatsky.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._isScrollIntoViewScheduled):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Incorrect results for svg/custom/getBBox-js.svg
kbalazs@webkit.org [Wed, 31 Aug 2011 12:07:26 +0000 (12:07 +0000)]
[Qt] Incorrect results for svg/custom/getBBox-js.svg
Unreviewed gardening.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed build fix. Restore debugger_script_source target dependency
apavlov@chromium.org [Wed, 31 Aug 2011 11:09:29 +0000 (11:09 +0000)]
[Chromium] Unreviewed build fix. Restore debugger_script_source target dependency
broken in http://trac.webkit.org/changeset/94082.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Unreviewed, unskip fast/css/square-button-appearance.html which
philn@webkit.org [Wed, 31 Aug 2011 11:02:54 +0000 (11:02 +0000)]
    Unreviewed, unskip fast/css/square-button-appearance.html which
        got baselines in r93953.

        * platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] 3 test started crashing somewhere between r93878-r93935
ossy@webkit.org [Wed, 31 Aug 2011 10:55:50 +0000 (10:55 +0000)]
[Qt] 3 test started crashing somewhere between r93878-r93935
https://bugs.webkit.org/show_bug.cgi?id=67197

* platform/qt/Skipped: Unskip tests, because bug was fixed by r94088.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Unreviewed, skip failing fast/loader/location-port.html test on
philn@webkit.org [Wed, 31 Aug 2011 10:53:15 +0000 (10:53 +0000)]
    Unreviewed, skip failing fast/loader/location-port.html test on
        GTK.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Wed, 31 Aug 2011 10:52:12 +0000 (10:52 +0000)]
[Qt] Unreviewed gardening.

Add Qt specific expected files after r94111, update Qt specific expected files after r94109.

Based on digging of Gabor Rapcsanyi.

* platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.png:
* platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
* platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.png:
* platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
* platform/qt/fast/preloader/document-write-noscript-expected.png: Added.
* platform/qt/fast/preloader/document-write-noscript-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Add and update platform specific expected files after...
ossy@webkit.org [Wed, 31 Aug 2011 10:42:00 +0000 (10:42 +0000)]
[Qt] Unreviewed gardening. Add and update platform specific expected files after r94109.

Based on digging of Gabor Rapcsanyi.

* platform/qt/fast/table/table-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-before-child-in-table-expected.txt:
* platform/qt/fast/table/table-before-child-style-update-expected.png: Added.
* platform/qt/fast/table/table-before-child-style-update-expected.txt: Added.
* platform/qt/fast/table/table-row-after-child-in-block-expected.txt:
* platform/qt/fast/table/table-row-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-row-before-child-in-block-expected.txt:
* platform/qt/fast/table/table-row-before-child-in-table-expected.txt:
* platform/qt/fast/table/table-row-before-child-style-update-expected.png: Added.
* platform/qt/fast/table/table-row-before-child-style-update-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Update platform specific expected files after r94147.
ossy@webkit.org [Wed, 31 Aug 2011 10:37:07 +0000 (10:37 +0000)]
[Qt] Unreviewed gardening. Update platform specific expected files after r94147.

Based on digging of Gabor Rapcsanyi.

* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEarly return in CSSPrimitiveValue::getDoubleValueInternal() omits additional invalid...
apavlov@chromium.org [Wed, 31 Aug 2011 10:20:27 +0000 (10:20 +0000)]
Early return in CSSPrimitiveValue::getDoubleValueInternal() omits additional invalid enums
https://bugs.webkit.org/show_bug.cgi?id=67139

Reviewed by Darin Adler.

* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion): Check if a given unit type can be converted to a double.
(WebCore::CSSPrimitiveValue::getDoubleValueInternal): Make use of the new method that explicitly lists all unit types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Unreviewed, GTK rebaseline after r93713 and r93909.
philn@webkit.org [Wed, 31 Aug 2011 10:11:33 +0000 (10:11 +0000)]
    Unreviewed, GTK rebaseline after r93713 and r93909.

        * fast/files/create-blob-url-crash-expected.txt:
        * platform/gtk/css2.1/t0602-c13-inheritance-00-e-expected.txt:
        * platform/gtk/css2.1/t090204-display-change-01-b-ao-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: rename sourceFile to uiSourceCode and get rid of sourceFileId where...
podivilov@chromium.org [Wed, 31 Aug 2011 10:02:57 +0000 (10:02 +0000)]
Web Inspector: rename sourceFile to uiSourceCode and get rid of sourceFileId where possible.
https://bugs.webkit.org/show_bug.cgi?id=67136

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.setBreakpoint):
(WebInspector.BreakpointManager.prototype._materializeBreakpoint):
(WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):
(WebInspector.BreakpointManager.prototype._addBreakpointToUI):
(WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI):
(WebInspector.BreakpointManager.prototype.set reset):
(WebInspector.BreakpointManager.prototype.debuggerReset):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.removeBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._createBreakpointItemId):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.prototype.update.didGetSourceLine):
(WebInspector.CallStackSidebarPane.prototype.update):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor.didGetLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):
(WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype.continueToLine):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsForUISourceCode):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
(WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
(WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
(WebInspector.PresentationBreakpoint):
(WebInspector.PresentationBreakpoint.prototype.get url):
(WebInspector.PresentationBreakpoint.prototype.loadSnippet):
(WebInspector.PresenationCallFrame):
(WebInspector.PresenationCallFrame.prototype.get url):
(WebInspector.PresenationCallFrame.prototype.select):
(WebInspector.PresenationCallFrame.prototype.sourceLine):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.get statusBarItems):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded.get if):
(WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.ScriptsPanel.prototype._consoleMessagesCleared):
(WebInspector.ScriptsPanel.prototype._consoleMessageAdded):
(WebInspector.ScriptsPanel.prototype._breakpointAdded):
(WebInspector.ScriptsPanel.prototype._breakpointRemoved):
(WebInspector.ScriptsPanel.prototype._debuggerPaused.else.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype.reset):
(WebInspector.ScriptsPanel.prototype._resetFilesSelect):
(WebInspector.ScriptsPanel.prototype.showAnchorLocation):
(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._showSourceFrameAndAddToHistory):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._removeSourceFrame):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
(WebInspector.ScriptsPanel.prototype._callFrameSelected.didGetSourceLocation):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.ScriptsPanel.prototype._filesSelectChanged):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.SourceFrameDelegateForScriptsPanel):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):

LayoutTests:

* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, rebaseline another multicol test expectation.
apavlov@chromium.org [Wed, 31 Aug 2011 09:20:54 +0000 (09:20 +0000)]
[Chromium] Unreviewed, rebaseline another multicol test expectation.

* platform/chromium-cg-mac-leopard/fast/multicol/overflow-across-columns-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, update Mac-Leopard expectations for multicol tests.
apavlov@chromium.org [Wed, 31 Aug 2011 09:12:53 +0000 (09:12 +0000)]
[Chromium] Unreviewed, update Mac-Leopard expectations for multicol tests.

* platform/chromium-cg-mac-leopard/fast/multicol/overflow-unsplittable-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/multicol/positive-leading-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebSocket] Prevent unnecessary pywebsocket warnings on layout tests.
commit-queue@webkit.org [Wed, 31 Aug 2011 09:06:24 +0000 (09:06 +0000)]
[WebSocket] Prevent unnecessary pywebsocket warnings on layout tests.
https://bugs.webkit.org/show_bug.cgi?id=67182

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-31
Reviewed by Kent Tamura.

Some layout tests for WebSocket raised Exception to prevent unnecessary
pywebsocket warning. But it doesn't work any more on pywebsocket 0.6b4.
Now pywebsocket support AbortedByUserException to prevent warning.
This change make raise AbortedByUserException instead of Exception.

handshake-fail-by-prepended-null_wsh.py didn't use Exception, but
expected abnormal closure on sending response could raise unexpected
Exception by chance. This change also takes care of it.

* http/tests/websocket/tests/hixie76/bad-handshake-crash_wsh.py:
* http/tests/websocket/tests/hixie76/frame-length-longer-than-buffer_wsh.py:
* http/tests/websocket/tests/hixie76/frame-length-overflow_wsh.py:
* http/tests/websocket/tests/hixie76/handshake-fail-by-maxlength_wsh.py:
* http/tests/websocket/tests/hixie76/handshake-fail-by-no-connection-header_wsh.py:
* http/tests/websocket/tests/hixie76/handshake-fail-by-no-cr_wsh.py:
* http/tests/websocket/tests/hixie76/handshake-fail-by-no-upgrade-header_wsh.py:
* http/tests/websocket/tests/hixie76/handshake-fail-by-prepended-null_wsh.py:
* http/tests/websocket/tests/hixie76/long-invalid-header_wsh.py:
* http/tests/websocket/tests/hybi/bad-handshake-crash_wsh.py:
* http/tests/websocket/tests/hybi/handshake-fail-by-extensions-header_wsh.py:
* http/tests/websocket/tests/hybi/handshake-fail-by-maxlength_wsh.py:
* http/tests/websocket/tests/hybi/handshake-fail-by-no-accept-header_wsh.py:
* http/tests/websocket/tests/hybi/handshake-fail-by-no-connection-header_wsh.py:
* http/tests/websocket/tests/hybi/handshake-fail-by-no-cr_wsh.py:
* http/tests/websocket/tests/hybi/handshake-fail-by-no-upgrade-header_wsh.py:
* http/tests/websocket/tests/hybi/handshake-fail-by-wrong-accept-header_wsh.py:
* http/tests/websocket/tests/hybi/long-invalid-header_wsh.py:
* http/tests/websocket/tests/hybi/masked-frames_wsh.py:
Use AbortedByUserException instead of Exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Fonts API refactoring.
commit-queue@webkit.org [Wed, 31 Aug 2011 08:45:32 +0000 (08:45 +0000)]
[EFL] Fonts API refactoring.
https://bugs.webkit.org/show_bug.cgi?id=66654

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-08-31
Reviewed by Hajime Morita.

There are too many similar API regarding to fonts.
Add one consistent API to set/get the font name for the font family.
Remove the previous font API.

* ewk/ewk_view.cpp:
(ewk_view_font_family_name_get):
(ewk_view_font_family_name_set):
* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebSocket: Load Blob in WebSocketChannel
yutak@chromium.org [Wed, 31 Aug 2011 08:35:54 +0000 (08:35 +0000)]
WebSocket: Load Blob in WebSocketChannel
https://bugs.webkit.org/show_bug.cgi?id=67013

Reviewed by Kent Tamura.

Add WebSocketChannel::enqueueBlobFrame(). It makes WebSocketChannel start loading a Blob
and send a WebSocket frame after the Blob is loaded.

While a Blob is being loaded, subsequent send() requests cannot be processed and are blocked.
Pending requests are stored in m_outgoingFrameQueue. When we have finished loading a Blob,
requests in the queue are allowed to get processed.

No new tests are added, because nobody uses enqueueBlobFrame() yet. New tests will be added
when WebSocket.send(Blob) is implemented, and they will cover this code change.

* websockets/WebSocketChannel.cpp:
ref() is called when m_blobLoader is allocated, and deref() is called in didFinishLoading()
or didFail(). This is necessary because WebSocketChannel must be able to receive callbacks
from FileReaderLoader even if the channel is referred from no other objects.
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::didStartLoading):
(WebCore::WebSocketChannel::didReceiveData):
(WebCore::WebSocketChannel::didFinishLoading):
(WebCore::WebSocketChannel::didFail):
When we have failed to load a Blob, fail() is called, and eventually didCloseSocketStream()
will be called. It will clean up the pending requests in the queue.
(WebCore::WebSocketChannel::enqueueBlobFrame):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
(WebCore::WebSocketChannel::abortOutgoingFrameQueue):
Cancel the Blob loader when the outgoing request queue is about to be aborted. The loader
will not invoke didFail() callback once it is canceled, thus we need to call didFail()
manually so that we can free up the loader and decrement the reference count.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebSocket: Receive binary message as ArrayBuffer
yutak@chromium.org [Wed, 31 Aug 2011 08:33:38 +0000 (08:33 +0000)]
WebSocket: Receive binary message as ArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=67180

Reviewed by Kent Tamura.

Source/WebCore:

Tests: http/tests/websocket/tests/hybi/receive-arraybuffer.html
       http/tests/websocket/tests/hybi/workers/receive-arraybuffer.html

* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data): Convert ArrayBuffer to JSValue.
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter): Convert ArrayBuffer to v8::Value.
* dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
* dom/MessageEvent.h:
Added DataTypeArrayBuffer and ArrayBuffer-related functions.
(WebCore::MessageEvent::create):
(WebCore::MessageEvent::dataAsArrayBuffer):
* websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveBinaryData):
Construct an ArrayBuffer from binaryData and raise MessageEvent.

LayoutTests:

* http/tests/websocket/tests/hybi/receive-arraybuffer-expected.txt: Added.
* http/tests/websocket/tests/hybi/receive-arraybuffer.html:
Added. Connect to binary-frames_wsh.py (which is also used from receive-blob.html) and
check the content of MessageEvent's data attribute.
* http/tests/websocket/tests/hybi/receive-blob.html:
Update function names to match ones in receive-arraybuffer.html.
* http/tests/websocket/tests/hybi/workers/receive-arraybuffer-expected.txt: Added.
* http/tests/websocket/tests/hybi/workers/receive-arraybuffer.html: Added.
* http/tests/websocket/tests/hybi/workers/resources/receive-arraybuffer.js: Added.
* http/tests/websocket/tests/hybi/workers/resources/receive-blob.js:
Same as receive-blob.html above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoExtract reference links from reftest test file.
commit-queue@webkit.org [Wed, 31 Aug 2011 08:18:58 +0000 (08:18 +0000)]
Extract reference links from reftest test file.
https://bugs.webkit.org/show_bug.cgi?id=66838

Patch by Ai Makabi <makabi@google.com> on 2011-08-31
Reviewed by Shinichiro Hamaji.

* Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
* Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
* Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Unreviewed, GTK rebaseline after r94109 and r93909.
philn@webkit.org [Wed, 31 Aug 2011 08:11:46 +0000 (08:11 +0000)]
    Unreviewed, GTK rebaseline after r94109 and r93909.

        * platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
        * platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
        * platform/gtk/fast/multicol/inherit-column-values-expected.txt: Added.
        * platform/gtk/fast/multicol/initial-column-values-expected.txt: Added.
        * platform/gtk/fast/multicol/single-line-expected.txt:
        * platform/gtk/fast/multicol/table-vertical-align-expected.txt:
        * platform/gtk/fast/repaint/multicol-repaint-expected.txt:
        * platform/gtk/fast/table/table-before-child-in-table-expected.txt:
        * platform/gtk/fast/table/table-before-child-style-update-expected.txt: Added.
        * platform/gtk/fast/table/table-row-after-child-in-block-expected.txt:
        * platform/gtk/fast/table/table-row-after-child-in-table-expected.txt:
        * platform/gtk/fast/table/table-row-before-child-in-block-expected.txt:
        * platform/gtk/fast/table/table-row-before-child-in-table-expected.txt:
        * platform/gtk/fast/table/table-row-before-child-style-update-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoinput color: onchange event is not fired when changing color from color chooser
keishi@webkit.org [Wed, 31 Aug 2011 08:08:29 +0000 (08:08 +0000)]
input color: onchange event is not fired when changing color from color chooser
https://bugs.webkit.org/show_bug.cgi?id=66848

Reviewed by Kent Tamura.

Source/WebCore:

Test: fast/forms/color/input-color-onchange-event.html

* WebCore.exp.in: Added calls used in Internals.cpp.
* html/ColorInputType.cpp:
(WebCore::ColorInputType::colorSelected): Dispatch change event.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::connectToColorChooser): Added. Called from Internals::connectColorChooserClient.
* html/HTMLInputElement.h:
* testing/Internals.cpp:
(WebCore::Internals::connectColorChooserClient): Added. Connects element as client to color chooser.
(WebCore::Internals::selectColorInColorChooser): Added. Simulate color selection in color chooser.
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* fast/forms/color/input-color-onchange-event-expected.txt: Added.
* fast/forms/color/input-color-onchange-event.html: Added. Tests if change event is fired when user selects color from color chooser.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Unreviewed, GTK rebaseline after r94147.
philn@webkit.org [Wed, 31 Aug 2011 07:38:05 +0000 (07:38 +0000)]
    Unreviewed, GTK rebaseline after r94147.

        * platform/gtk/fast/dom/Window/window-properties-expected.txt:
        * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/gtk/fast/dom/prototype-inheritance-expected.txt:
        * platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement Web IDL Constructor extended attribute in IDLParser.pm and CodeGeneratorV8.pm.
commit-queue@webkit.org [Wed, 31 Aug 2011 07:35:47 +0000 (07:35 +0000)]
Implement Web IDL Constructor extended attribute in IDLParser.pm and CodeGeneratorV8.pm.
https://bugs.webkit.org/show_bug.cgi?id=66536

Patch by Kentaro Hara <haraken@google.com> on 2011-08-31
Reviewed by Adam Barth.

The spec is here: http://www.w3.org/TR/WebIDL/#Constructor

[1] Introduced Web IDL 'Constructor' extended attribute.

[2] Added 'ConstructorWith=ScriptExecutionContext' extended attribute.
- The constructor passes ScriptExecutionContext to a XXX::create() method,
like XXX::create(..., context, ...).

[3] Added 'V8ConstructorSetsActiveDOMWrapper' extended attribute.
- The constructor calls V8DOMWrapper::setJSWrapperForActiveDOMObject()
instead of V8DOMWrapper::setJSWrapperForDOMObject().

[4] Added 'ConstructorRaisesException' extended attribute.
- A placeholder for ExceptionCode is passed to a XXX::create() method,
like XXX::create(..., ec).
- We can use 'ConstructorRaisesException' and 'ConstructorWith=ScriptExecutionContext' together.

Note:
- Constructor overloading is not yet implemented.
- We cannot yet specify [Optional] without CallWithDefaultValue.

Test: Source/WebCore/bindings/scripts/test/TestInterface.idl
      Source/WebCore/bindings/scripts/test/TestObj.idl

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader): Generates constructorCallback() header, if 'Constructor' is specified.
(GenerateFunctionCallback): Uses GenerateArgumentsCountCheck() and GenerateParametersCheck().
(GenerateArgumentsCountCheck): Splits out of GenerateFunctionCallback() for reuse.
(GenerateParametersCheck): Ditto.
(GenerateConstructorCallback): Generates constructorCallback() definition.
(GenerateImplementation):
* bindings/scripts/IDLParser.pm:
(parseExtendedAttributes): Previously, only a string in the "A=B, C, D, E=F" format can be parsed. This patch enables to parse a string in the "A=B, C, D, E=F, G(in DOMString s, in [H, I, J] DOMString t)" format.
(parseParameters): Splits out of ParseInterface() for reuse.
(ParseInterface): Uses parseParameters().
* bindings/scripts/IDLStructure.pm: Added domClass{constructor}. Changed the regular expression to extract the list of extended attributes.
* bindings/scripts/test/TestInterface.idl: Added all the extended attributes that this patch is going to introduce.
* bindings/scripts/test/TestObj.idl: Added 'Constructor'.
* bindings/scripts/test/V8/V8TestInterface.cpp: Updated the test result.
(WebCore::V8TestInterface::constructorCallback):
(WebCore::ConfigureV8TestInterfaceTemplate):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Ditto.
* bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
(WebCore::V8TestObj::constructorCallback):
* bindings/scripts/test/V8/V8TestObj.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago [GTK] gstreamer/ files directly related to the MediaPlayer need VIDEO guards
philn@webkit.org [Wed, 31 Aug 2011 07:02:12 +0000 (07:02 +0000)]
    [GTK] gstreamer/ files directly related to the MediaPlayer need VIDEO guards
        https://bugs.webkit.org/show_bug.cgi?id=67196

        Reviewed by Martin Robinson.

        Guard those files with ENABLE(VIDEO) so other features using
        GStreamer can be built even with VIDEO disabled.

        * platform/graphics/gstreamer/GStreamerGWorld.cpp:
        * platform/graphics/gstreamer/GStreamerGWorld.h:
        * platform/graphics/gstreamer/ImageGStreamer.h:
        * platform/graphics/gstreamer/ImageGStreamerCG.mm:
        * platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
        * platform/graphics/gstreamer/ImageGStreamerQt.cpp:
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
        * platform/graphics/gstreamer/PlatformVideoWindow.h:
        * platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp:
        * platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
        * platform/graphics/gstreamer/VideoSinkGStreamer.h:
        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago [webkitpy] missing log import in common/net/resultsjsonparser.py
philn@webkit.org [Wed, 31 Aug 2011 06:59:54 +0000 (06:59 +0000)]
    [webkitpy] missing log import in common/net/resultsjsonparser.py
        https://bugs.webkit.org/show_bug.cgi?id=65606

        Reviewed by Martin Robinson.

        * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago [stylechecker] complains about NULL usage in some gst_structure_ calls
philn@webkit.org [Wed, 31 Aug 2011 06:55:19 +0000 (06:55 +0000)]
    [stylechecker] complains about NULL usage in some gst_structure_ calls
        https://bugs.webkit.org/show_bug.cgi?id=67194

        Reviewed by Martin Robinson.

        Don't warn about NULL in some gst_structure_ calls. 0 can't be
        used for these, a proper sentinel is required.

        * Scripts/webkitpy/style/checkers/cpp.py:
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update result due to r94114.
levin@chromium.org [Wed, 31 Aug 2011 06:21:13 +0000 (06:21 +0000)]
[chromium] Update result due to r94114.

* platform/chromium-win/svg/custom/pan-direction-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/custom/pan-direction-expected.png.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update due to r94147.
levin@chromium.org [Wed, 31 Aug 2011 05:58:52 +0000 (05:58 +0000)]
[chromium] Update due to r94147.

* platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt: Copied from LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt.
* platform/chromium-mac/fast/events/constructors/custom-event-constructor-expected.txt: Added.
Several of these results are failures but that should be fixed by bug 66756.
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:
* platform/chromium/fast/events/constructors/custom-event-constructor-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove old-style UI from garden-o-matic
abarth@webkit.org [Wed, 31 Aug 2011 04:56:35 +0000 (04:56 +0000)]
Remove old-style UI from garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=67257

Reviewed by Dimitri Glazkov.

This code is nowhere near as awesome as the new hotness.  Let's remove
it so it doesn't weigh us down.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94142, r94144, r94145, and r94148.
rniwa@webkit.org [Wed, 31 Aug 2011 04:45:12 +0000 (04:45 +0000)]
Unreviewed, rolling out r94142, r94144, r94145, and r94148.
http://trac.webkit.org/changeset/94142
http://trac.webkit.org/changeset/94144
http://trac.webkit.org/changeset/94145
http://trac.webkit.org/changeset/94148
https://bugs.webkit.org/show_bug.cgi?id=67262

Broke isindex element (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-30

Source/WebCore:

* WebCore.order:
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isPasswordField):
(WebCore::AccessibilityRenderObject::isIndeterminate):
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityRenderObject::isChecked):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::applyProperty):
* dom/CheckedRadioButtons.cpp:
(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::removeButton):
* dom/Node.cpp:
(WebCore::Node::toInputElement):
* dom/Node.h:
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::isInPasswordField):
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::toInputElement):
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderThumb::layout):
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::hostInput):
(WebCore::trackLimiterElementOf):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::repeatingTimerFired):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
* page/DragController.cpp:
(WebCore::asFileInput):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::inputElement):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isChecked):
(WebCore::RenderTheme::isIndeterminate):

Source/WebKit/chromium:

* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::textFieldDidEndEditing):
(WebKit::EditorClientImpl::doTextFieldCommandFromEvent):
* src/WebInputElement.cpp:
(WebKit::toWebInputElement):
* src/WebPasswordFormUtils.cpp:
(WebKit::findPasswordFormFields):

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setAutofilled):
(DumpRenderTreeSupportGtk::setValueForUser):

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setAutofilled):
(DumpRenderTreeSupportQt::setValueForUser):
(DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoQuick fix for crashing tests caused by r94142.
levin@chromium.org [Wed, 31 Aug 2011 04:34:26 +0000 (04:34 +0000)]
Quick fix for crashing tests caused by r94142.

Tests:
  editing/execCommand/remove-format-elements.html
  fast/block/child-not-removed-from-parent-lineboxes-crash.html
  fast/forms/implicit-submission.html

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Allow
for isIndex element which is derived from HTMLInputElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd constructor for CustomEvent
weinig@apple.com [Wed, 31 Aug 2011 04:04:06 +0000 (04:04 +0000)]
Add constructor for CustomEvent
https://bugs.webkit.org/show_bug.cgi?id=67248

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/events/constructors/custom-event-constructor.html

* bindings/generic/EventConstructors.h:
Add definition for CustomEvent constructor.

* bindings/js/JSEventConstructors.cpp:
Add CustomEvent #includes.

* dom/CustomEvent.cpp:
(WebCore::CustomEventInit::CustomEventInit):
(WebCore::CustomEvent::CustomEvent):
* dom/CustomEvent.h:
(WebCore::CustomEvent::create):
Add Initializer./

* dom/CustomEvent.idl:
Make constructible.

* page/DOMWindow.idl:
Add CustomEvent attribute.

LayoutTests:

* fast/events/constructors/custom-event-constructor-expected.txt: Added.
* fast/events/constructors/custom-event-constructor.html: Added.
New test.

* fast/dom/constructed-objects-prototypes-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:
Updated for add window.CustomEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebSocket] update pywebsocket to 0.6b5.
commit-queue@webkit.org [Wed, 31 Aug 2011 02:48:01 +0000 (02:48 +0000)]
[WebSocket] update pywebsocket to 0.6b5.
https://bugs.webkit.org/show_bug.cgi?id=66924

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-08-30
Reviewed by Kent Tamura.

pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
0.6b3 or later supports a closing handshake handler and it is useful to
verify client's closing handshake implementation.
0.6b4 supports AbortedByUserException. It is useful to eliminate
unnecessary server warning messages on intended abnormal closures.
0.6b5 supports Python 2.5.1 or Mac 10.5.

* Scripts/webkitpy/thirdparty/__init__.py:
Update download URL and directory path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGTK build fix after r94142.
rniwa@webkit.org [Wed, 31 Aug 2011 02:13:24 +0000 (02:13 +0000)]
GTK build fix after r94142.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setAutofilled):
(DumpRenderTreeSupportGtk::setValueForUser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium build fix after r94142.
rniwa@webkit.org [Wed, 31 Aug 2011 01:41:19 +0000 (01:41 +0000)]
Chromium build fix after r94142.

* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::textFieldDidEndEditing):
(WebKit::EditorClientImpl::doTextFieldCommandFromEvent):
* src/WebPasswordFormUtils.cpp:
(WebKit::findPasswordFormFields):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] New baselines due to r94109.
levin@chromium.org [Wed, 31 Aug 2011 01:23:20 +0000 (01:23 +0000)]
[chromium] New baselines due to r94109.

* platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Removed.
* platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Removed.
* platform/chromium-linux/fast/table/table-after-child-in-table-expected.txt: Removed.
* platform/chromium-linux/fast/table/table-before-child-in-table-expected.txt: Removed.
* platform/chromium-linux/fast/table/table-row-after-child-in-block-expected.txt: Removed.
* platform/chromium-linux/fast/table/table-row-after-child-in-table-expected.txt: Removed.
* platform/chromium-linux/fast/table/table-row-before-child-in-block-expected.txt: Removed.
* platform/chromium-linux/fast/table/table-row-before-child-in-table-expected.txt: Removed.
* platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
* platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
* platform/chromium-win/fast/table/table-after-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-before-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-before-child-style-update-expected.png: Added.
* platform/chromium-win/fast/table/table-row-after-child-in-block-expected.txt:
* platform/chromium-win/fast/table/table-row-after-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-row-before-child-in-block-expected.txt:
* platform/chromium-win/fast/table/table-row-before-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-row-before-child-style-update-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGet rid of toInputElement()
rniwa@webkit.org [Wed, 31 Aug 2011 01:20:24 +0000 (01:20 +0000)]
Get rid of toInputElement()
https://bugs.webkit.org/show_bug.cgi?id=67175

Reviewed by Darin Adler.

Source/WebCore:

Got rid of Node::toInputElement and HTMLInputElement::toInputElement and replaced them by
a global toHTMLInputElement.

* WebCore.order:
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isPasswordField):
(WebCore::AccessibilityRenderObject::isIndeterminate):
(WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio):
(WebCore::AccessibilityRenderObject::isChecked):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithControl):
(WebCore::CSSStyleSelector::adjustRenderStyle):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
(WebCore::CSSStyleSelector::applyProperty):
* dom/CheckedRadioButtons.cpp:
(WebCore::CheckedRadioButtons::addButton):
(WebCore::CheckedRadioButtons::removeButton):
* dom/Node.cpp:
* dom/Node.h:
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::isInPasswordField):
* html/HTMLInputElement.h:
(WebCore::toHTMLInputElement):
* html/shadow/SliderThumbElement.cpp:
(WebCore::sliderThumbElementOf):
(WebCore::RenderSliderThumb::layout):
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::hostInput):
(WebCore::trackLimiterElementOf):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::shadowPseudoId):
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::defaultEventHandler):
(WebCore::SpinButtonElement::repeatingTimerFired):
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):
* page/DragController.cpp:
(WebCore::asFileInput):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::inputElement):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isChecked):
(WebCore::RenderTheme::isIndeterminate):

Source/WebKit/chromium:

* src/WebInputElement.cpp:
(WebKit::toWebInputElement):

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setAutofilled):
(DumpRenderTreeSupportQt::setValueForUser):
(DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeculative WinCairo build fix after r94093.
rniwa@webkit.org [Wed, 31 Aug 2011 01:05:15 +0000 (01:05 +0000)]
Speculative WinCairo build fix after r94093.

* platform/network/ResourceHandle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoadd a test for border/padding/margin on the flexbox container
ojan@chromium.org [Wed, 31 Aug 2011 00:29:46 +0000 (00:29 +0000)]
add a test for border/padding/margin on the flexbox container
https://bugs.webkit.org/show_bug.cgi?id=67243

Reviewed by Tony Chang.

* css3/flexbox/001-expected.txt:
* css3/flexbox/001.html:
* css3/flexbox/resources/flexbox.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMac build fix after r94128.
rniwa@webkit.org [Wed, 31 Aug 2011 00:26:51 +0000 (00:26 +0000)]
Mac build fix after r94128.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCorrectly report selected text range for accessibility APIs for role=textbox
commit-queue@webkit.org [Wed, 31 Aug 2011 00:21:18 +0000 (00:21 +0000)]
Correctly report selected text range for accessibility APIs for role=textbox
https://bugs.webkit.org/show_bug.cgi?id=65900

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-08-30
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/textbox-role-reports-selection.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::indexForVisiblePosition):
(WebCore::AccessibilityRenderObject::rootEditableElementForPosition):
(WebCore::AccessibilityRenderObject::nodeIsTextControl):
(WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
* accessibility/AccessibilityRenderObject.h:

LayoutTests:

* accessibility/textbox-role-reports-selection-expected.txt: Added.
* accessibility/textbox-role-reports-selection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, fix WebGL layout tests due to missing WebView pointer.
nduca@chromium.org [Wed, 31 Aug 2011 00:18:43 +0000 (00:18 +0000)]
Unreviewed, fix WebGL layout tests due to missing WebView pointer.

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe "port" property of an <a> whose href does not specify a port returns the wrong...
commit-queue@webkit.org [Wed, 31 Aug 2011 00:13:20 +0000 (00:13 +0000)]
The "port" property of an <a> whose href does not specify a port returns the wrong value
https://bugs.webkit.org/show_bug.cgi?id=66081

Source/WebCore:

HTMLAnchorElement now returns "" instead of "0" for unset port
Fixed KURLGoogle.cpp to have same behavior as KURL.cpp when setting port 0
Fixed Location.cpp to have same behavior as KURL.cpp when setting port 0

Patch by Rachel Blum <groby@chromium.org> on 2011-08-30
Reviewed by Adam Barth.

Tests: fast/dom/HTMLAnchorElement/get-href-attribute-port.html
       fast/dom/HTMLAnchorElement/set-href-attribute-port.html
       fast/loader/location-port.html
       fast/url/segments-from-data-url.html
       fast/url/segments.html
       fast/url/trivial-segments.html
       platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-port.html

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::port):
* page/Location.cpp:
(WebCore::Location::host):
(WebCore::Location::port):
(WebCore::Location::setPort):
* platform/KURLGoogle.cpp:
(WebCore::KURL::setPort):

LayoutTests:

Updated tests to reflect behavior change around invalid port strings.
Updated chromium location-port test to reflect chromium issues

Patch by Rachel Blum <groby@chromium.org> on 2011-08-30
Reviewed by Adam Barth.

* fast/dom/HTMLAnchorElement/get-href-attribute-port-expected.txt: Added.
* fast/dom/HTMLAnchorElement/get-href-attribute-port.html: Added.
* fast/dom/HTMLAnchorElement/script-tests/get-href-attribute-port.js: Added.
* fast/loader/location-port-expected.txt:
* fast/loader/location-port.html:
* fast/url/script-tests/segments-from-data-url.js:
* fast/url/script-tests/segments.js:
* fast/url/script-tests/trivial-segments.js:
* fast/url/segments-expected.txt:
* fast/url/segments-from-data-url-expected.txt:
* fast/url/trivial-segments-expected.txt:
* platform/chromium-cg-mac/fast/loader/location-port-expected.txt:
* platform/chromium-win/fast/loader/location-port-expected.txt:
* platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix pan scrolling on Windows to be clamped
commit-queue@webkit.org [Wed, 31 Aug 2011 00:03:40 +0000 (00:03 +0000)]
Fix pan scrolling on Windows to be clamped
https://bugs.webkit.org/show_bug.cgi?id=66910

Source/WebCore:

With the recent change to support rubberband scrolling on the Mac, pan
scrolling of overflow divs became unclamped and would scroll infinitely
and along an axis without a scrollbar.

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-30
Reviewed by Simon Fraser

Test: platform/win/fast/events/panScroll-correct-direction.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::panScrollFromPoint):
(WebCore::RenderLayer::scrollByRecursively):
* rendering/RenderLayer.h:

LayoutTests:

With the recent change to support rubberband scrolling on the Mac, pan
scrolling of overflow divs became unclamped and would scroll infinitely
and along an axis without a scrollbar.

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-30
Reviewed by Simon Fraser

* platform/mac/fast/frames/iframe-scaling-with-scroll-expected.png:
* platform/win/fast/events/panScroll-click-hyperlink-expected.txt: Added.
* platform/win/fast/events/panScroll-correct-direction-expected.txt: Added.
* platform/win/fast/events/panScroll-correct-direction.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThis patch makes the XMLHttpRequest method/header validation logic available as
commit-queue@webkit.org [Tue, 30 Aug 2011 23:55:52 +0000 (23:55 +0000)]
This patch makes the XMLHttpRequest method/header validation logic available as
static methods so URL loaders can perform the same checks for untrusted HTTP requests
coming from plugins.
https://bugs.webkit.org/show_bug.cgi?id=66909

Patch by Bill Budge <bbudge@chromium.org> on 2011-08-30
Reviewed by David Levin.

No new tests. Exposes no new functionality.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* platform/network/HTTPValidation.cpp: Added.
(WebCore::isValidHTTPToken):
(WebCore::isValidHTTPHeaderValue):
* platform/network/HTTPValidation.h: Added.
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::isAllowedHTTPMethod):
(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod):
(WebCore::XMLHttpRequest::isAllowedHTTPHeader):
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::setRequestHeader):
* xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't allow nodes of one context to be connected to nodes of another context
crogers@google.com [Tue, 30 Aug 2011 23:45:53 +0000 (23:45 +0000)]
Don't allow nodes of one context to be connected to nodes of another context
https://bugs.webkit.org/show_bug.cgi?id=67245

Source/WebCore:

Reviewed by Dimitri Glazkov.

Tests: updated webaudio/audionode.html

* webaudio/AudioNode.cpp:
(WebCore::AudioNode::connect):

LayoutTests:

Reviewed by Dimitri Glazkov.

* webaudio/audionode-expected.txt:
* webaudio/audionode.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWinCE build fix attempt after r94080.
rniwa@webkit.org [Tue, 30 Aug 2011 23:42:08 +0000 (23:42 +0000)]
WinCE build fix attempt after r94080.

* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::scrollRectIntoView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: WebCore part of <rdar://problem/9281695> Add text search API for...
mitz@apple.com [Tue, 30 Aug 2011 23:36:47 +0000 (23:36 +0000)]
Source/WebCore: WebCore part of <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
https://bugs.webkit.org/show_bug.cgi?id=67230

Reviewed by Darin Adler.

Test: TestWebKitAPI/Tests/mac/DOMRangeOfString.

* WebCore.exp.in: Export Page::rangeOfString().
* dom/Range.h: Added a default ASSERT_NO_EXCEPTION to a few more member functions.
* editing/Editor.cpp:
(WebCore::Editor::findString): Moved most of the logic into rangeOfString(), which this function
now calls, passing in the current selection as the reference range and setting the selection to
the returned range.
(WebCore::Editor::rangeOfString): Added. Contains the find logic from findString().
* editing/Editor.h:
* page/Page.cpp:
(WebCore::Page::rangeOfString): Added. This function is similar to findString(), but it takes an optional
reference range and returns a Range, rather than using the current selection as the reference range and setting the
selection to the next match.
* page/Page.h:

Source/WebKit/mac: <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
https://bugs.webkit.org/show_bug.cgi?id=67230

Reviewed by Darin Adler.

* WebView/WebHTMLView.mm:
* WebView/WebView.mm:
(coreOptions): Moved this function from WebHTMLView.mm to here and made
it accessible from both this file and WebHTMLView.mm.
(-[WebView DOMRangeOfString:relativeTo:options:]): Added this new API.
* WebView/WebViewInternal.h:
* WebView/WebViewPrivate.h:

Tools: Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
https://bugs.webkit.org/show_bug.cgi?id=67230

Reviewed by Darin Adler.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
* TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
(-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd additional convertValue overloads to JSDictionary
weinig@apple.com [Tue, 30 Aug 2011 23:34:42 +0000 (23:34 +0000)]
Add additional convertValue overloads to JSDictionary
https://bugs.webkit.org/show_bug.cgi?id=67244

Reviewed by Darin Adler.

Add overloads for convertValue that will be needed for Event
constructors.

* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
* bindings/js/JSDictionary.h:
Add overloads.  Remove #include of <runtime/Error.h> and just include
<interpreter/CallFrame.h>

* bindings/js/JSEventConstructors.cpp:
Add now necessary #include of <runtime/Error.h>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=67150
bdakin@apple.com [Tue, 30 Aug 2011 23:31:31 +0000 (23:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67150
Would like API to use a custom device scale factor for a particular WebView/WKView
-and corresponding-
<rdar://problem/10041016>

Reviewed by Darin Adler.

Source/WebKit/mac:

New API is _setOverrideBackingScaleFactor:(CGFloat)
* WebView/WebView.mm:
(-[WebView _setOverrideBackingScaleFactor:]):
(-[WebView _deviceScaleFactor]):
* WebView/WebViewData.h:
* WebView/WebViewPrivate.h:

Source/WebKit2:

New API is setOverrideBackingScaleFactor() on WKPage
* UIProcess/API/C/WKPage.cpp:
(WKPageGetOverrideBackingScaleFactor):
(WKPageSetOverrideBackingScaleFactor):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::deviceScaleFactor):
(WebKit::WebPageProxy::setOverrideBackingScaleFactor):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::overrideBackingScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd MediaSource API to HTMLMediaElement
commit-queue@webkit.org [Tue, 30 Aug 2011 23:15:56 +0000 (23:15 +0000)]
Add MediaSource API to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=64731

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-08-30
Reviewed by Eric Carlson.

.:

* configure.ac:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Tests: http/tests/media/media-source/webm/video-media-source-errors.html
       http/tests/media/media-source/webm/video-media-source-play.html
       http/tests/media/media-source/webm/video-media-source-seek.html
       http/tests/media/media-source/webm/video-media-source-state-changes.html

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* dom/EventNames.h:
* features.pri:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Added initializers for new member variables.
(WebCore::HTMLMediaElement::prepareForLoad): Close the media source before starting a new load.
(WebCore::HTMLMediaElement::loadResource):
    Fail loading if the media source url from another media element is used.
(WebCore::HTMLMediaElement::mediaEngineError):
    Make sure the source is in the closed state before firing an emptied event.
(WebCore::HTMLMediaElement::mediaPlayerSourceOpened):
    New method called by WebCore::MediaPlayer to signal when the source is open.
(WebCore::HTMLMediaElement::mediaPlayerSourceURL):
    New method called by the WebCore::MediaPlayer to determine what the media source URL is for this
    HTMLMediaElement instance.
(WebCore::HTMLMediaElement::seek):
    Disabled noSeekRequired optimization if a media source is open and resets the source state to SOURCE_OPEN if
    it was in the SOURCE_ENDED state when seek() was called.
(WebCore::HTMLMediaElement::webkitSourceAppend):
    New method for passing media data from JavaScript to the WebCore::MediaPlayer.
(WebCore::HTMLMediaElement::webkitSourceEndOfStream):
    New method that allows JavaScript to signal the end of the stream.
(WebCore::HTMLMediaElement::webkitSourceState): New method allowing JavaScript to read the current source state.
(WebCore::HTMLMediaElement::setSourceState): New method for updating the current source state.
(WebCore::HTMLMediaElement::userCancelledLoad):
    Transitions an open source to the closed state before firing an emptied event.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::webkitMediaSourceURL):
    New method providing the media source URL to JavaScript for this HTMLMediaElement instance.
* html/HTMLMediaElement.idl: Added new methods, attributes, and constants for the media source api.
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::sourceAppend):
    Stub implementation of new WebCore::MediaPlayerPrivateInterface::sourceAppend.
(WebCore::NullMediaPlayerPrivate::sourceEndOfStream):
    Stub implementation of new WebCore::MediaPlayerPrivateInterface::sourceEndOfStream.
(WebCore::MediaPlayer::sourceAppend): New method for receiving media data from WebCore::HTMLMediaElement.
(WebCore::MediaPlayer::sourceEndOfStream): New method for receiving end of stream from WebCore::HTMLMediaElement.
(WebCore::MediaPlayer::sourceOpened):
    New method called by the MediaPlayerPrivate object to notify the MediaPlayer when the source has opened.
(WebCore::MediaPlayer::sourceURL):
    New method called by the MediaPlayerPrivate implementation to get the media source URL from the MediaPlayer.
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerSourceOpened):
    Interface method used by the MediaPlayer to tell the HTMLMediaElement when the media source has been opened.
(WebCore::MediaPlayerClient::mediaPlayerSourceURL):
    Interface method used by the MediaPlayer to get the media source URL from the HTMLMediaElement.
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::sourceAppend):
    Interface method used by the MediaPlayer to pass media data to the MediaPlayerPrivate object.
(WebCore::MediaPlayerPrivateInterface::sourceEndOfStream):
    Interface method used by the MediaPlayer to pass end of stream information to the MediaPlayerPrivate object.

Source/WebKit/chromium:

* public/WebMediaPlayer.h:
(WebKit::WebMediaPlayer::sourceAppend):
(WebKit::WebMediaPlayer::sourceEndOfStream):
* public/WebMediaPlayerClient.h:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::sourceOpened):
(WebKit::WebMediaPlayerClientImpl::sourceURL):
(WebKit::WebMediaPlayerClientImpl::sourceAppend):
(WebKit::WebMediaPlayerClientImpl::sourceEndOfStream):
* src/WebMediaPlayerClientImpl.h:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/build-webkit:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

* http/tests/media/media-source/webm/video-media-source-errors-expected.txt: Added.
* http/tests/media/media-source/webm/video-media-source-errors.html: Added.
* http/tests/media/media-source/webm/video-media-source-play-expected.txt: Added.
* http/tests/media/media-source/webm/video-media-source-play.html: Added.
* http/tests/media/media-source/webm/video-media-source-seek-expected.txt: Added.
* http/tests/media/media-source/webm/video-media-source-seek.html: Added.
* http/tests/media/media-source/webm/video-media-source-state-changes-expected.txt: Added.
* http/tests/media/media-source/webm/video-media-source-state-changes.html: Added.
* http/tests/media/media-source/webm/webm-media-source.js: Added.
(getData):
(getHeaders):
(getClusterCount):
(getCluster):
(getClusterTimeForIndex):
(getClusterIndexForTimestamp):
(setSrcToMediaSourceURL):
(appendHeaders):
(appendCluster):
(appendUntilEndOfStream):
(logSourceState):
(getSourceStateName):
(expectSourceState):
* http/tests/media/resources/media-source/webm/test.webm: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-0: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-1: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-10: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-11: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-12: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-13: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-14: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-15: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-2: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-3: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-4: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-5: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-6: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-7: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-8: Added.
* http/tests/media/resources/media-source/webm/test.webm.cluster-9: Added.
* http/tests/media/resources/media-source/webm/test.webm.headers: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Chromium rebaselines for r94109.
inferno@chromium.org [Tue, 30 Aug 2011 23:09:05 +0000 (23:09 +0000)]
Unreviewed. Chromium rebaselines for r94109.

* platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.txt: Added.
* platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.txt: Added.
* platform/chromium-linux/fast/table/table-after-child-in-table-expected.txt: Added.
* platform/chromium-linux/fast/table/table-before-child-in-table-expected.txt: Added.
* platform/chromium-linux/fast/table/table-before-child-style-update-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-after-child-in-block-expected.txt: Added.
* platform/chromium-linux/fast/table/table-row-after-child-in-table-expected.txt: Added.
* platform/chromium-linux/fast/table/table-row-before-child-in-block-expected.txt: Added.
* platform/chromium-linux/fast/table/table-row-before-child-in-table-expected.txt: Added.
* platform/chromium-linux/fast/table/table-row-before-child-style-update-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor JS dictionary code into helper class and covert geolocation code to use it
weinig@apple.com [Tue, 30 Aug 2011 22:49:07 +0000 (22:49 +0000)]
Refactor JS dictionary code into helper class and covert geolocation code to use it
https://bugs.webkit.org/show_bug.cgi?id=67213

Reviewed by Darin Adler.

* GNUmakefile.list.am:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
Add new files.

* bindings/js/JSDictionary.cpp: Added.
(WebCore::JSDictionary::convertValue):
* bindings/js/JSDictionary.h: Added.
(WebCore::JSDictionary::JSDictionary):
(WebCore::JSDictionary::tryGetProperty):
Encapsulate dictionary initialization code into JSDictionary class.

* bindings/js/JSEventConstructors.cpp:
(WebCore::constructJSEventWithInitializer):
Use JSDictionary.

* bindings/js/JSGeolocationCustom.cpp:
(WebCore::setEnableHighAccuracy):
(WebCore::setTimeout):
(WebCore::setMaximumAge):
(WebCore::createPositionOptions):
Use JSDictionary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94119 268f45cc-cd09-0410-ab3c-d52691b4dbfc