WebKit-https.git
8 years agoWeb Inspector: introduce InspectorFrontendAPI for actions initiated from the applicat...
pfeldman@chromium.org [Mon, 21 Nov 2011 12:54:59 +0000 (12:54 +0000)]
Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985

Source/WebCore:

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

Reviewed by Yury Semikhatsky.

* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
(WebCore::InspectorFrontendClientLocal::isDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::setDebuggingEnabled):
(WebCore::InspectorFrontendClientLocal::isJavaScriptProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setJavaScriptProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::setTimelineProfilingEnabled):
(WebCore::InspectorFrontendClientLocal::isProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::startProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::stopProfilingJavaScript):
(WebCore::InspectorFrontendClientLocal::evaluateAsBoolean):
(WebCore::InspectorFrontendClientLocal::evaluateOnLoad):
* inspector/InspectorFrontendClientLocal.h:
* inspector/front-end/InspectorFrontendAPI.js: Added.
(InspectorFrontendAPI.isDebuggingEnabled):
(InspectorFrontendAPI.setDebuggingEnabled):
(InspectorFrontendAPI.isJavaScriptProfilingEnabled):
(InspectorFrontendAPI.setJavaScriptProfilingEnabled):
(InspectorFrontendAPI.isTimelineProfilingEnabled):
(InspectorFrontendAPI.setTimelineProfilingEnabled):
(InspectorFrontendAPI.isProfilingJavaScript):
(InspectorFrontendAPI.startProfilingJavaScript):
(InspectorFrontendAPI.stopProfilingJavaScript):
(InspectorFrontendAPI.setAttachedWindow):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.isRecordingProfile):
(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.stopRecordingProfile):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.get profilerEnabled):
(WebInspector.ProfilesPanel.prototype.enableProfiler):
(WebInspector.ProfilesPanel.prototype.disableProfiler):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype.get debuggingEnabled):
(WebInspector.ScriptsPanel.prototype.enableDebugging):
(WebInspector.ScriptsPanel.prototype.disableDebugging):
(WebInspector.ScriptsPanel.prototype.toggleDebugging):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._memoryOverviewItemSelected):
(WebInspector.TimelinePanel.prototype.setTimelineProfilingEnabled):
(WebInspector.TimelinePanel.prototype.get timelineProfilingEnabled):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

Source/WebKit/mac:

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

Reviewed by Yury Semikhatsky.

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController destroyInspectorView:]):
* WebInspector/WebInspector.mm:
(-[WebInspector showWindow]):
(-[WebInspector show:]):
(-[WebInspector showConsole:]):
(-[WebInspector isDebuggingJavaScript]):
(-[WebInspector toggleDebuggingJavaScript:]):
(-[WebInspector startDebuggingJavaScript:]):
(-[WebInspector stopDebuggingJavaScript:]):
(-[WebInspector isProfilingJavaScript]):
(-[WebInspector toggleProfilingJavaScript:]):
(-[WebInspector startProfilingJavaScript:]):
(-[WebInspector stopProfilingJavaScript:]):
(-[WebInspector isJavaScriptProfilingEnabled]):
(-[WebInspector setJavaScriptProfilingEnabled:]):
(-[WebInspector isTimelineProfilingEnabled]):
(-[WebInspector setTimelineProfilingEnabled:]):
(-[WebInspector setFrontend:]):
(-[WebInspector releaseFrontend]):
(-[WebInspector showWindow:]):
* WebInspector/WebInspectorFrontend.h:
* WebInspector/WebInspectorFrontend.mm:
(-[WebInspectorFrontend isDebuggingEnabled]):
(-[WebInspectorFrontend setDebuggingEnabled:]):
(-[WebInspectorFrontend isProfilingJavaScript]):
(-[WebInspectorFrontend startProfilingJavaScript]):
(-[WebInspectorFrontend stopProfilingJavaScript]):
(-[WebInspectorFrontend isJavaScriptProfilingEnabled]):
(-[WebInspectorFrontend setJavaScriptProfilingEnabled:]):
(-[WebInspectorFrontend isTimelineProfilingEnabled]):
(-[WebInspectorFrontend setTimelineProfilingEnabled:]):
* WebInspector/WebInspectorPrivate.h:

Source/WebKit/win:

Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.

Reviewed by Yury Semikhatsky.

* WebInspector.cpp:
(WebInspector::createInstance):
(WebInspector::WebInspector):
(WebInspector::webViewClosed):
(WebInspector::showConsole):
(WebInspector::isDebuggingJavaScript):
(WebInspector::toggleDebuggingJavaScript):
(WebInspector::isProfilingJavaScript):
(WebInspector::toggleProfilingJavaScript):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::isTimelineProfilingEnabled):
(WebInspector::setTimelineProfilingEnabled):
* WebInspector.h:
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:

LayoutTests:

Reviewed by Yury Semikhatsky.

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd .dir-locals.el file for better Emacs defaults
commit-queue@webkit.org [Mon, 21 Nov 2011 12:48:15 +0000 (12:48 +0000)]
Add .dir-locals.el file for better Emacs defaults
https://bugs.webkit.org/show_bug.cgi?id=72483

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-21
Reviewed by Xan Lopez.

* .dir-locals.el: Set appropriate directory-local variables for Emacs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInspector tests flakily crashing on Linux dbg canary
steveblock@google.com [Mon, 21 Nov 2011 12:46:07 +0000 (12:46 +0000)]
Inspector tests flakily crashing on Linux dbg canary
https://bugs.webkit.org/show_bug.cgi?id=72651

Add TIMEOUT expectation for inspector/styles/styles-cancel-editing.html.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Protocol] Retain a single universal method for loading a required...
apavlov@chromium.org [Mon, 21 Nov 2011 12:19:52 +0000 (12:19 +0000)]
Web Inspector: [Protocol] Retain a single universal method for loading a required combination of element styles
https://bugs.webkit.org/show_bug.cgi?id=72701

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
* inspector/InspectorCSSAgent.h:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.inlineCallback):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles.matchedCallback):
(WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.getMatchedStylesAsync):
(WebInspector.CSSStyleModel.prototype.getComputedStyleAsync):
(WebInspector.CSSStyleModel.prototype.getInlineStylesAsync):
* inspector/front-end/MetricsSidebarPane.js:
(WebInspector.MetricsSidebarPane.prototype._innerUpdate):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.get forcedPseudoClasses):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.inlineCallback):
(WebInspector.StylesSidebarPane.prototype._executeRebuildUpdate.computedCallback):
(WebInspector.StylesSidebarPane.prototype._innerUpdate):

LayoutTests:

* inspector/styles/get-set-stylesheet-text.html:
* inspector/styles/styles-formatting.html:
* inspector/styles/styles-new-API.html:
* inspector/styles/styles-source-offsets.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate .gitignore for latest WebKitLibraries
noel.gordon@gmail.com [Mon, 21 Nov 2011 12:19:33 +0000 (12:19 +0000)]
Update .gitignore for latest WebKitLibraries
https://bugs.webkit.org/show_bug.cgi?id=72851

Reviewed by Andreas Kling.

* .gitignore: updates to silence 'git status' about WebKitLibraries files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Update NEWS and configure.ac for 1.7.2 release
carlosgc@webkit.org [Mon, 21 Nov 2011 12:14:09 +0000 (12:14 +0000)]
[GTK] Update NEWS and configure.ac for 1.7.2 release
https://bugs.webkit.org/show_bug.cgi?id=72868

Reviewed by Xan Lopez.

.:

* configure.ac: Bumped version number.

Source/WebKit/gtk:

* NEWS: Added release notes for 1.7.2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit...
steveblock@google.com [Mon, 21 Nov 2011 12:02:30 +0000 (12:02 +0000)]
ASSERTION FAILED: fontCache()->generation() == m_generation (running new-run-webkit-tests)
https://bugs.webkit.org/show_bug.cgi?id=59552

Add CRASH expectation for jquery/offset.html.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r100856.
commit-queue@webkit.org [Mon, 21 Nov 2011 11:11:03 +0000 (11:11 +0000)]
Unreviewed, rolling out r100856.
http://trac.webkit.org/changeset/100856
https://bugs.webkit.org/show_bug.cgi?id=72867

New test fast/css/style-tag-display-none.html fails on
Chromium (Requested by steveblock on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-21

Source/WebCore:

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchUARules):

LayoutTests:

* fast/css/style-tag-display-none-expected.txt: Removed.
* fast/css/style-tag-display-none.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement Meta referrer
jochen@chromium.org [Mon, 21 Nov 2011 10:29:55 +0000 (10:29 +0000)]
Implement Meta referrer
https://bugs.webkit.org/show_bug.cgi?id=72674

Reviewed by Adam Barth.

Source/WebCore:

http://wiki.whatwg.org/wiki/Meta_referrer

Tests: http/tests/security/referrer-policy-always.html
       http/tests/security/referrer-policy-default.html
       http/tests/security/referrer-policy-https-always.html
       http/tests/security/referrer-policy-https-default.html
       http/tests/security/referrer-policy-https-never.html
       http/tests/security/referrer-policy-https-origin.html
       http/tests/security/referrer-policy-never.html
       http/tests/security/referrer-policy-origin.html
       http/tests/security/referrer-policy-redirect.html
       http/tests/security/referrer-policy-rel-noreferrer.html

* WebCore.exp.in: updated
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::processReferrerPolicy):
* dom/Document.h:
(WebCore::Document::referrerPolicy):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):
* html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::process):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::reportContentSecurityPolicyViolation):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadSubframe):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create):
* page/SecurityPolicy.cpp:
(WebCore::SecurityPolicy::generateReferrerHeader):
* page/SecurityPolicy.h:

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebFrame.h:
* public/WebReferrerPolicy.h: Added.
* public/WebSecurityPolicy.h:
* src/AssertMatchingEnums.cpp:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::referrerPolicy):
(WebKit::WebFrameImpl::setReferrerForRequest):
* src/WebFrameImpl.h:
* src/WebSecurityPolicy.cpp:
(WebKit::WebSecurityPolicy::generateReferrerHeader):

Source/WebKit/mac:

* Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
* Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::WebNetscapePluginStream):

Source/WebKit2:

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::loadURL):

LayoutTests:

* http/tests/security/referrer-policy-always-expected.txt: Added.
* http/tests/security/referrer-policy-always.html: Added.
* http/tests/security/referrer-policy-default-expected.txt: Added.
* http/tests/security/referrer-policy-default.html: Added.
* http/tests/security/referrer-policy-https-always-expected.txt: Added.
* http/tests/security/referrer-policy-https-always.html: Added.
* http/tests/security/referrer-policy-https-default-expected.txt: Added.
* http/tests/security/referrer-policy-https-default.html: Added.
* http/tests/security/referrer-policy-https-never-expected.txt: Added.
* http/tests/security/referrer-policy-https-never.html: Added.
* http/tests/security/referrer-policy-https-origin-expected.txt: Added.
* http/tests/security/referrer-policy-https-origin.html: Added.
* http/tests/security/referrer-policy-never-expected.txt: Added.
* http/tests/security/referrer-policy-never.html: Added.
* http/tests/security/referrer-policy-origin-expected.txt: Added.
* http/tests/security/referrer-policy-origin.html: Added.
* http/tests/security/referrer-policy-redirect-expected.txt: Added.
* http/tests/security/referrer-policy-redirect.html: Added.
* http/tests/security/referrer-policy-rel-noreferrer-expected.txt: Added.
* http/tests/security/referrer-policy-rel-noreferrer.html: Added.
* http/tests/security/resources/referrer-policy-log.php: Added.
* http/tests/security/resources/referrer-policy-redirect.html: Added.
* http/tests/security/resources/referrer-policy-start.html: Added.
* http/tests/security/resources/rel-noreferrer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: ApplicationCache view should show navigator.onLine indicator.
vsevik@chromium.org [Mon, 21 Nov 2011 10:22:00 +0000 (10:22 +0000)]
Web Inspector: ApplicationCache view should show navigator.onLine indicator.
https://bugs.webkit.org/show_bug.cgi?id=72618

Reviewed by Pavel Feldman.

* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::enable):
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView):
(WebInspector.ApplicationCacheItemsView.prototype.wasShown):
* inspector/front-end/ApplicationCacheModel.js:
(WebInspector.ApplicationCacheModel):
(WebInspector.ApplicationCacheModel.prototype.get onLine):
(WebInspector.ApplicationCacheModel.prototype._networkStateUpdated):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.showApplicationCache):
(WebInspector.ResourcesPanel.prototype._applicationCacheNetworkStateChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Fix make distcheck build.
carlosgc@webkit.org [Mon, 21 Nov 2011 09:55:02 +0000 (09:55 +0000)]
Unreviewed. Fix make distcheck build.

Source/WebCore:

* GNUmakefile.list.am:

Source/WebKit2:

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAccessibility: Multiselect list boxes need to report the active option in addition...
dmazzoni@google.com [Mon, 21 Nov 2011 09:50:39 +0000 (09:50 +0000)]
Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
https://bugs.webkit.org/show_bug.cgi?id=72479

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/multiselect-list-reports-active-option.html

* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isSelectedOptionActive):
* accessibility/AccessibilityListBoxOption.h:
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isSelectedOptionActive):

Source/WebKit/chromium:

Test: accessibility/multiselect-list-reports-active-option.html

* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::isSelectedOptionActive):

Tools:

* DumpRenderTree/AccessibilityUIElement.cpp:
(getIsSelectedOptionActiveCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::isSelectedOptionActive):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::isSelectedOptionActive):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::isSelectedOptionActive):

LayoutTests:

* accessibility/multiselect-list-reports-active-option.html: Added.
* platform/chromium/accessibility/multiselect-list-reports-active-option-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] WebSocket close tests are failing
yutak@chromium.org [Mon, 21 Nov 2011 09:42:57 +0000 (09:42 +0000)]
[Qt] WebSocket close tests are failing
https://bugs.webkit.org/show_bug.cgi?id=72865

Reviewed by Simon Hausmann.

Source/WebCore:

* platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::close):
Emit didCloseSocketStream() callback even before the connection is established.
Call m_socket->abort() to prevent "connected" signal from firing.

LayoutTests:

* platform/qt/Skipped:
Unskip five WebSocket tests. Remove "failing websocket tests" section,
as there are no tests in this section.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactoring: SpellChecker::requestCheckingFor should take Range instead of Node.
commit-queue@webkit.org [Mon, 21 Nov 2011 09:20:57 +0000 (09:20 +0000)]
Refactoring: SpellChecker::requestCheckingFor should take Range instead of Node.
https://bugs.webkit.org/show_bug.cgi?id=72847

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-21
Reviewed by Hajime Morita.

Covered by existing test.

* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
  Passes Range to requestCheckingFor instead of Node.
* editing/SpellChecker.cpp:
  Changed argument type from Node to Range.
  The corresponding changes are also done in dependent methods.
(WebCore::SpellChecker::initRequest):
(WebCore::SpellChecker::clearRequest):
(WebCore::SpellChecker::canCheckAsynchronously):
(WebCore::SpellChecker::isBusy):
(WebCore::SpellChecker::isValid):
(WebCore::SpellChecker::isCheckable):
(WebCore::SpellChecker::requestCheckingFor):
  Changed argument type from Node to Range.
(WebCore::SpellChecker::doRequestCheckingFor):
(WebCore::SpellChecker::didCheck):
* editing/SpellChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse Host().port_factory instead of webkitpy.layout_tests.port.factory.
commit-queue@webkit.org [Mon, 21 Nov 2011 09:12:09 +0000 (09:12 +0000)]
Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
https://bugs.webkit.org/show_bug.cgi?id=72859

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-21
Reviewed by Eric Seidel.

* Scripts/new-run-webkit-websocketserver:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAnother attempt at a build fix.
fpizlo@apple.com [Mon, 21 Nov 2011 08:37:44 +0000 (08:37 +0000)]
Another attempt at a build fix.

* dfg/DFGRepatch.h:
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Layout test does not return correct misspelling positions if there are...
commit-queue@webkit.org [Mon, 21 Nov 2011 06:28:06 +0000 (06:28 +0000)]
[Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
https://bugs.webkit.org/show_bug.cgi?id=72655

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-11-20
Reviewed by Hajime Morita.

Tools:

Fixed the calculation of offset.

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::finishLastTextCheck):

LayoutTests:

Fixed the calculation of offset, and added test cases having multiple misspelled words.

* editing/spelling/script-tests/spellcheck-paste.js:
  Added test cases having multiple misspelled words.
(verifyMarker):
(tests):
* editing/spelling/spellcheck-paste-expected.txt: Recreated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove old getFontFamilyForCharacters() and familyForChars() APIs.
bashi@chromium.org [Mon, 21 Nov 2011 06:10:24 +0000 (06:10 +0000)]
[Chromium] Remove old getFontFamilyForCharacters() and familyForChars() APIs.
https://bugs.webkit.org/show_bug.cgi?id=72844

Source/WebCore:

Respects bold and italic properties that is given by fontconfig.

Reviewed by Darin Fisher.

* platform/graphics/chromium/FontCacheLinux.cpp:
(WebCore::FontCache::getFontDataForCharacters): Removed #if and old logic.

Source/WebKit/chromium:

Removes old APIs for getting font family for given characters.

Reviewed by Darin Fisher.

* public/linux/WebFontInfo.h: Removed old familyForChars().
* public/linux/WebSandboxSupport.h: Removed old getFontFamilyForCharacters() and changed new getFontFamilyForCharacters() to be a pure virtual function.
* src/linux/WebFontInfo.cpp: Removes old familyForChars().

LayoutTests:

Font selection mechanism of Chromium Linux port has been improved. Rebaselines affected tests.

Reviewed by Darin Fisher.

* platform/chromium-linux/fast/text/cg-fallback-bolding-expected.png:
* platform/chromium-linux/fast/text/cg-fallback-bolding-expected.txt:
* platform/chromium-linux/fast/text/international/khmer-selection-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline for border change in r100528
commit-queue@webkit.org [Mon, 21 Nov 2011 05:37:24 +0000 (05:37 +0000)]
Rebaseline for border change in r100528
https://bugs.webkit.org/show_bug.cgi?id=72689

Patch by Ben Wells <benwells@chromium.org> on 2011-11-20
Reviewed by Stephen White.

* platform/chromium-cg-mac-snowleopard/fast/borders/mixed-border-styles-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/border-mixed-alpha-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-expected.png: Added.
* platform/chromium-mac/fast/borders/mixed-border-styles-expected.png: Removed.
* platform/chromium-win/fast/borders/border-mixed-alpha-expected.png: Added.
* platform/chromium-win/fast/borders/mixed-border-styles-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove qt/QtMobileWebStyle from the gyp projects
noel.gordon@gmail.com [Mon, 21 Nov 2011 05:18:02 +0000 (05:18 +0000)]
[chromium] Remove qt/QtMobileWebStyle from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=72843

Reviewed by Antonio Gomes.

platform/qt/QtMobileWebStyle.{h,cpp} were removed in r100123

* WebCore.gypi: remove platform/qt/QtMobileWebStyle.{h,cpp}

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed interpreter build fix.
fpizlo@apple.com [Mon, 21 Nov 2011 05:03:08 +0000 (05:03 +0000)]
Unreviewed interpreter build fix.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally):
* dfg/DFGRepatch.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rebaselined run-bindings-tests results.
haraken@chromium.org [Mon, 21 Nov 2011 05:01:09 +0000 (05:01 +0000)]
Unreviewed. Rebaselined run-bindings-tests results.

* bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
(WebDOMFloat64Array::WebDOMFloat64Array):
(WebDOMFloat64Array::impl):
(toWebCore):
(toWebKit):
* bindings/scripts/test/CPP/WebDOMFloat64Array.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove modulo operation on 32bit platforms
yuqiang.xian@intel.com [Mon, 21 Nov 2011 04:47:00 +0000 (04:47 +0000)]
Improve modulo operation on 32bit platforms
https://bugs.webkit.org/show_bug.cgi?id=72501

Reviewed by Filip Pizlo.

Extend softModulo to support X86 and MIPS in baseline JIT.
Apply the same optimization to 32bit DFG JIT.
1% gain on Kraken, tested on Linux Core i7 Nehalem 32bit.

* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::softModulo):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInline caches that refer to otherwise dead objects should be cleared
fpizlo@apple.com [Mon, 21 Nov 2011 04:45:17 +0000 (04:45 +0000)]
Inline caches that refer to otherwise dead objects should be cleared
https://bugs.webkit.org/show_bug.cgi?id=72311

Reviewed by Geoff Garen.

DFG code blocks now participate in the weak reference harvester fixpoint
so that they only consider themselves to be live if either they are
currently executing, or their owner is live and all of their weak references
are live. If not, the relevant code blocks are jettisoned.

Inline caches in both the old JIT and the DFG are now cleared if any of
their references are not marked at the end of a GC.

This is performance-neutral on SunSpider, V8, and Kraken. With the clear-
all-code-on-GC policy that we currently have, it shows a slight reduction
in memory usage. If we turn that policy off, it's pretty easy to come up
with an example program that will cause ToT to experience linear heap
growth, while with this patch, the heap stays small and remains at a
constant size.

* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::readCallTarget):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::readCallTarget):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::readCallTarget):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::readCallTarget):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::performTracingFixpointIteration):
(JSC::CodeBlock::visitWeakReferences):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::MethodCallLinkInfo::reset):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::visitWeak):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::visitWeakReferences):
* bytecode/StructureStubInfo.h:
(JSC::isGetByIdAccess):
(JSC::isPutByIdAccess):
(JSC::StructureStubInfo::reset):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGOperations.cpp:
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgRepatchByIdSelfAccess):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
* dfg/DFGRepatch.h:
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::resetPatchGetById):
(JSC::JIT::resetPatchPutById):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITWriteBarrier.h:
(JSC::JITWriteBarrierBase::clearToMaxUnsigned):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShowing the data overlay in OpenStreetMap doesn't work, zooming partially broken
fpizlo@apple.com [Mon, 21 Nov 2011 04:35:38 +0000 (04:35 +0000)]
Showing the data overlay in OpenStreetMap doesn't work, zooming partially broken
https://bugs.webkit.org/show_bug.cgi?id=71505

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The bytecode generator was assuming that call_varargs never reuses the base register
(i.e. the function being called) for the result. This is no longer true.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCallVarargs):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::ApplyFunctionCallDotNode::emitBytecode):

LayoutTests:

Reviewed by Oliver Hunt.

* fast/js/function-dot-apply-replace-base-expected.txt: Added.
* fast/js/function-dot-apply-replace-base.html: Added.
* fast/js/script-tests/cross-global-object-inline-global-var.js:
(done):
* fast/js/script-tests/function-dot-apply-replace-base.js: Added.
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG 32_64 should directly store double virtual registers on SetLocal
fpizlo@apple.com [Mon, 21 Nov 2011 03:32:02 +0000 (03:32 +0000)]
DFG 32_64 should directly store double virtual registers on SetLocal
https://bugs.webkit.org/show_bug.cgi?id=72845

Reviewed by Oliver Hunt.

2% win on Kraken.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r100691): Safari error pages and Growl notifications fail to load stylesheets
abarth@webkit.org [Mon, 21 Nov 2011 02:26:16 +0000 (02:26 +0000)]
REGRESSION(r100691): Safari error pages and Growl notifications fail to load stylesheets
https://bugs.webkit.org/show_bug.cgi?id=72836

Reviewed by Sam Weinig.

Source/WebCore:

This patch removes a (minor) security mitigation.  Previously, we tried
sequester "directory listings" into unique origins to make it more
difficult for an attacker to crawl the user's local file system.
Unfortunately, this mitigation doesn't really buy us much security
because if the attacker has access to local files, we've probably lost
anyway.

The larger problem, however, is that this condition is overly
complicated and has broken in sublte ways several times in its
(relatively short) lifetime.  In the cases reported in this bug, we see
that this check affects error pages in Safari and Growl notifications,
even those have nothing to do with directory listings.

If we have our heart set on this directory listing mitigation, we'll
need a more robust way of triggering the behavior than examining URLs
and guess whether they contain directory listings.  For example, if we
implement Allow-From or Access-Control-Deny-Origin, then the embedder
can supply those policies along with the directory listings.  Those
seem like much better solutions than the in-engine hack this patch
removes.

* page/SecurityOrigin.cpp:
(WebCore::shouldTreatAsUniqueOrigin):

LayoutTests:

Update test results to show that XMLHttpRequets for directory listings
aren't blocked.

* fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html:
* fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove DFG::JITCodeGenerator from the gyp projects
noel.gordon@gmail.com [Mon, 21 Nov 2011 02:03:53 +0000 (02:03 +0000)]
[chromium] Remove DFG::JITCodeGenerator from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=72842

Reviewed by Filip Pizlo.

dfg/DFGJITCodeGenerator.{h,cpp} were removed in r100244

* JavaScriptCore.gypi: remove dfg/DFGJITCodeGenerator.{h,cpp}

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange the final place where we use version 3 of the results json output
ojan@chromium.org [Mon, 21 Nov 2011 01:26:57 +0000 (01:26 +0000)]
Change the final place where we use version 3 of the results json output
https://bugs.webkit.org/show_bug.cgi?id=72838

Reviewed by Adam Barth.

This converts the json from being a flat map of test name --> results
to being hierarchical by directory. This will make the json files
considerably smaller.

Also cleaned up some functions that were returning/checking boolean values
that were always True.

* TestResultServer/model/jsonresults.py:
* TestResultServer/model/jsonresults_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-17 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Sun, 20 Nov 2011 23:55:31 +0000 (23:55 +0000)]
2011-10-17  Antonio Gomes  <agomes@rim.com>

        Pass a Frame* parameter in EditorClient::respondToChangedSelection
        https://bugs.webkit.org/show_bug.cgi?id=70248

        Reviewed by Ryosuke Niwa.

        Most of the port specific implementations of EditorClient::respondToChangedSelection
        (like EditorClient{Qt,Gtk,etc}) are wrongly relying on FocusController::focusedOrMainFrame
        method to get the Frame where the selection is happening on.

        It is not right, since a selection can be easily triggered in an inner
        frame that is not focused.

        No new tests since it is a hard thing to test without
        to hook into editor client in layout tests. We could
        change the "Dumped Delegate" messages, but it would
        require a rebasile of +1200 for a minor change.

        No new tests since it is a hard thing to test without
        to hook into editor client in layout tests. We could
        change the "Dumped Delegate" messages, but it would
        require a rebasile of +1200 for a minor change.

        Source/WebCore:
        * editing/Editor.cpp: Pass the Frame on where the selection is changing to the client.
        (WebCore::Editor::respondToChangedSelection): Ditto.
        (WebCore::Editor::changeSelectionAfterCommand): Ditto.
        (WebCore::EmptyEditorClient::respondToChangedSelection):
        * page/EditorClient.h:  Pass Frame* to indicate where the selection is happening.
        * loader/EmptyClients.h: Changed signature as per base class change.

        Source/WebKit/chromium:
        * src/EditorClientImpl.cpp: Make use of the newly added Frame* parameter.
        (WebKit::EditorClientImpl::respondToChangedSelection):
        * src/EditorClientImpl.h:

        Source/WebKit/efl:
        * WebCoreSupport/EditorClientEfl.cpp: Make use of the newly added Frame* parameter.
        (WebCore::EditorClientEfl::respondToChangedSelection):
        * WebCoreSupport/EditorClientEfl.h:

        Source/WebKit/gtk:
        * WebCoreSupport/EditorClientGtk.cpp: Make use of the newly added Frame* parameter.
        (WebKit::EditorClient::respondToChangedSelection):
        * WebCoreSupport/EditorClientGtk.h:

        Source/WebKit/mac:
        * WebCoreSupport/WebEditorClient.h: Make use of the newly added Frame* parameter.
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::respondToChangedSelection):

        Source/WebKit/qt:
        * WebCoreSupport/EditorClientQt.cpp: Make use of the newly added Frame* parameter.
        (WebCore::EditorClientQt::respondToChangedSelection):
        * WebCoreSupport/EditorClientQt.h:

        Source/WebKit/win:
        * WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter.
        (WebEditorClient::respondToChangedSelection):
        * WebCoreSupport/WebEditorClient.h:

        Source/WebKit/wx:
        * WebKitSupport/EditorClientWx.cpp: Make use of the newly added Frame* parameter.
        (WebCore::EditorClientWx::respondToChangedSelection):
        * WebKitSupport/EditorClientWx.h:

        Source/WebKit2:
        * WebProcess/WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter.
        (WebKit::WebEditorClient::respondToChangedSelection):
        * WebProcess/WebCoreSupport/WebEditorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInclude the master name when querying the test results server.
ojan@chromium.org [Sun, 20 Nov 2011 23:40:12 +0000 (23:40 +0000)]
Include the master name when querying the test results server.
This will soon be required since leaving the master name out mean
that multiple files could match the query.

* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/72646> Disable deprecation warnings around code where we cannot...
mrowe@apple.com [Sun, 20 Nov 2011 22:55:45 +0000 (22:55 +0000)]
<webkit.org/b/72646> Disable deprecation warnings around code where we cannot easily
switch away from the deprecated APIs.

Reviewed by Sam Weinig.

Source/WebCore:

* platform/mac/WebCoreNSStringExtras.mm:
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::reportErrorToClient):

Source/WebKit/mac:

* Plugins/WebBasePluginPackage.mm:
* Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage _tryLoad]):

Source/WebKit2:

* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd WebNode::hasEventListeners for Android
abarth@webkit.org [Sun, 20 Nov 2011 16:40:40 +0000 (16:40 +0000)]
Add WebNode::hasEventListeners for Android
https://bugs.webkit.org/show_bug.cgi?id=72817

Reviewed by Darin Fisher.

Expose this EventTarget interface in the Chromium WebKit API for use by
Android.

* public/WebNode.h:
* src/WebNode.cpp:
(WebKit::WebNode::hasEventListeners):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Add GestureFlingStart and GestureFlingCancel to WebGestureEvent for Android
abarth@webkit.org [Sun, 20 Nov 2011 16:38:57 +0000 (16:38 +0000)]
[Chromium] Add GestureFlingStart and GestureFlingCancel to WebGestureEvent for Android
https://bugs.webkit.org/show_bug.cgi?id=72819

Reviewed by Darin Fisher.

These gesture types are used with FlingAnimator for scrolling.

* public/WebInputEvent.h:
(WebKit::WebInputEvent::isScrollGestureEventType):
(WebKit::WebGestureEvent::WebGestureEvent):
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Add WebInputEventFactory for Android
abarth@webkit.org [Sun, 20 Nov 2011 16:36:25 +0000 (16:36 +0000)]
[Chromium] Add WebInputEventFactory for Android
https://bugs.webkit.org/show_bug.cgi?id=67890

Reviewed by Darin Fisher.

Like every Chromium OS, Android needs a WebInputFactory.

* WebKit.gyp:
* public/android/WebInputEventFactory.h: Added.
* src/android/WebInputEventFactory.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] Build fix after GeneratedImage refactoring.
kevino@webkit.org [Sun, 20 Nov 2011 04:25:44 +0000 (04:25 +0000)]
[wx] Build fix after GeneratedImage refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] C++ bindings build fix for move of array classes to WTF.
kevino@webkit.org [Sun, 20 Nov 2011 04:19:06 +0000 (04:19 +0000)]
[wx] C++ bindings build fix for move of array classes to WTF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Update various compositing baselines and expectations.
jamesr@google.com [Sun, 20 Nov 2011 02:12:56 +0000 (02:12 +0000)]
[chromium] Update various compositing baselines and expectations.

* platform/chromium-cg-mac-leopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
* platform/chromium-cg-mac-leopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/chromium-cg-mac-leopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/geometry/clipped-video-controller-expected.png:
* platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
* platform/chromium-cg-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Removed.
* platform/chromium-cg-mac-snowleopard/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png:
* platform/chromium-mac-leopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
* platform/chromium-mac-leopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/chromium-mac-leopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/clipped-video-controller-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png: Removed.
* platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Removed.
* platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
* platform/chromium-mac/compositing/scaling/tiled-layer-recursion-expected.png: Removed.
* platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
* platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
* platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Copied from LayoutTests/platform/chromium-linux/compositing/scaling/tiled-layer-recursion-expected.png.
* platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
* platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
* platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
* platform/chromium/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
* platform/chromium/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
* platform/chromium/compositing/geometry/video-fixed-scrolling-expected.png: Added.
* platform/chromium/compositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Renamed from LayoutTests/platform/chromium-win/compositing/layer-creation/spanOverlapsCanvas-expected.txt.
* platform/chromium/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/chromium/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/chromium/compositing/scaling/tiled-layer-recursion-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/compositing/scaling/tiled-layer-recursion-expected.png.
* platform/chromium/compositing/self-painting-layers-expected.png:
* platform/chromium/compositing/video-page-visibility-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix jsonp callback code to add the callback if json content
ojan@chromium.org [Sun, 20 Nov 2011 02:09:19 +0000 (02:09 +0000)]
Fix jsonp callback code to add the callback if json content
is not jsonp.
* TestResultServer/handlers/testfilehandler.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoModify dashboard_base.js to optionally accept version 4 results json.
ojan@chromium.org [Sun, 20 Nov 2011 01:52:06 +0000 (01:52 +0000)]
Modify dashboard_base.js to optionally accept version 4 results json.

Patch by Alice Boxhall <aboxhall@chromium.org> on 2011-11-19
Reviewed by Ojan Vafai.

* TestResultServer/static-dashboards/dashboard_base.js:
(ADD_RESULTS):
(flattenTrie):
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
(testFlattenTrie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStop storing results files as jsonp in the test results server
ojan@chromium.org [Sun, 20 Nov 2011 01:47:13 +0000 (01:47 +0000)]
Stop storing results files as jsonp in the test results server
https://bugs.webkit.org/show_bug.cgi?id=72814

Reviewed by Adam Barth.

* TestResultServer/model/jsonresults.py:
* TestResultServer/model/jsonresults_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the dependence on jsonp from more of new-run-webkit-tests and the test results...
ojan@chromium.org [Sun, 20 Nov 2011 01:13:19 +0000 (01:13 +0000)]
Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
https://bugs.webkit.org/show_bug.cgi?id=72813

Reviewed by Adam Barth.

Once this lands, we can start storing pure json in the test results server and then
we can delete the code with all the FIXMEs added here.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
Only add jsonp for full_results.json.
* TestResultServer/model/jsonresults.py:
* TestResultServer/model/jsonresults_unittest.py:
Accept pure json uploads.
* TestResultServer/static-dashboards/dashboard_base.js:
(appendJSONScriptElementFor):
Use the callback parameter so that the server can start returning pure json if it's left out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAllow json NRWT downloads to be pure json and not jsonp
ojan@chromium.org [Sun, 20 Nov 2011 00:04:53 +0000 (00:04 +0000)]
Allow json NRWT downloads to be pure json and not jsonp
https://bugs.webkit.org/show_bug.cgi?id=72809

Reviewed by Adam Barth.

I'm moving the server to storing and serving up raw json instead of jsonp.
You can still get the jsonp by passing a "callback" parameter, but there's no
need for run-webkit-tests to get jsonp when all it wants is the raw json.

* Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
Make the wrapper stripping only happen if the json is actually wrapped.
* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove gamepad to Modules/ (+ some cleanup)
commit-queue@webkit.org [Sat, 19 Nov 2011 20:51:42 +0000 (20:51 +0000)]
Move gamepad to Modules/ (+ some cleanup)
https://bugs.webkit.org/show_bug.cgi?id=72785

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-19
Reviewed by Adam Barth.

Source/WebCore:

Move main files from page/ to Modules/gamepad/. #include guard the
gamepad header inclusions in Navigator.cpp to avoid including for
ports that do not enable GAMEPAD.

* Modules/gamepad/Gamepad.cpp: Renamed from Source/WebCore/page/Gamepad.cpp.
(WebCore::Gamepad::Gamepad):
(WebCore::Gamepad::axes):
(WebCore::Gamepad::buttons):
(WebCore::Gamepad::~Gamepad):
* Modules/gamepad/Gamepad.h: Renamed from Source/WebCore/page/Gamepad.h.
* Modules/gamepad/Gamepad.idl: Renamed from Source/WebCore/page/Gamepad.idl.
* Modules/gamepad/GamepadList.cpp: Renamed from Source/WebCore/page/GamepadList.cpp.
(WebCore::GamepadList::~GamepadList):
(WebCore::GamepadList::set):
(WebCore::GamepadList::length):
(WebCore::GamepadList::item):
* Modules/gamepad/GamepadList.h: Renamed from Source/WebCore/page/GamepadList.h.
(WebCore::GamepadList::create):
(WebCore::GamepadList::GamepadList):
* Modules/gamepad/GamepadList.idl: Renamed from Source/WebCore/page/GamepadList.idl.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* page/Navigator.cpp:

LayoutTests:

Use standard pre/post js test harness rather than custom one.

* gamepad/gamepad-api-expected.txt:
* gamepad/gamepad-api.html:
* gamepad/gamepad-test.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r100834.
commit-queue@webkit.org [Sat, 19 Nov 2011 20:15:12 +0000 (20:15 +0000)]
Unreviewed, rolling out r100834.
http://trac.webkit.org/changeset/100834
https://bugs.webkit.org/show_bug.cgi?id=72806

this patch makes Qt run-webkit-test exit before finishing
(Requested by igoroliveira on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-19

Source/WebCore:

* platform/graphics/texmap/TextureMapperNode.cpp:
* platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/WebCoreArgumentCoders.h:
* Shared/WebLayerTreeInfo.cpp:
(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):
* Shared/WebLayerTreeInfo.h:
* UIProcess/LayerTreeHostProxy.h:
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::pauseAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove WebCore/ForwardingHeaders/runtime/JSObjectWithGlobalObject.h because
commit-queue@webkit.org [Sat, 19 Nov 2011 20:08:06 +0000 (20:08 +0000)]
Remove WebCore/ForwardingHeaders/runtime/JSObjectWithGlobalObject.h because
JSObjectWithGlobalObject.h has been removed.
https://bugs.webkit.org/show_bug.cgi?id=72794

r94701 removed JSObjectWithGlobalObject.h.

Patch by Huang Dongsung <luxtella@company100.net> on 2011-11-19
Reviewed by Oliver Hunt.

* ForwardingHeaders/runtime/JSObjectWithGlobalObject.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector:[protocol] actual JSON messages do not conform to Inspector.json in...
vsevik@chromium.org [Sat, 19 Nov 2011 17:32:21 +0000 (17:32 +0000)]
Web Inspector:[protocol] actual JSON messages do not conform to Inspector.json in InspectorApplicationCacheAgent.cpp
https://bugs.webkit.org/show_bug.cgi?id=72734

Reviewed by Timothy Hatcher.

* inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r98542): Chromium: CSS text is rendered on page
commit-queue@webkit.org [Sat, 19 Nov 2011 15:34:58 +0000 (15:34 +0000)]
REGRESSION(r98542): Chromium: CSS text is rendered on page
https://bugs.webkit.org/show_bug.cgi?id=71703

Patch by David Barr <davidbarr@chromium.org> on 2011-11-19
Reviewed by Antti Koivisto.

Source/WebCore:

Matched UA declarations uncacheable when using simpleDefaultStyleSheet.

Test: fast/css/style-tag-display-none.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchUARules):

LayoutTests:

* fast/css/style-tag-display-none-expected.txt: Added.
* fast/css/style-tag-display-none.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r100854.
nduca@chromium.org [Sat, 19 Nov 2011 12:52:54 +0000 (12:52 +0000)]
Unreviewed, rolling out r100854.
http://trac.webkit.org/changeset/100854

Rollout DEPS roll. Made chromium bots cry.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS 109696->110838
nduca@chromium.org [Sat, 19 Nov 2011 12:24:20 +0000 (12:24 +0000)]
Unreviewed.  Rolled DEPS 109696->110838

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add the map file symbols export as a dependency of the final qmake target.
hausmann@webkit.org [Sat, 19 Nov 2011 11:28:03 +0000 (11:28 +0000)]
[Qt] Add the map file symbols export as a dependency of the final qmake target.
https://bugs.webkit.org/show_bug.cgi?id=72740

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2011-11-19
Reviewed by Simon Hausmann.

Add the symbols file part of the target dependencies.

* Source/api.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWhen loading a MHTML document, make sure we set the base URL before
jcivelli@chromium.org [Sat, 19 Nov 2011 08:45:01 +0000 (08:45 +0000)]
When loading a MHTML document, make sure we set the base URL before
we notify the frame was committed (so the document has the right base
URL when the notification happens).
https://bugs.webkit.org/show_bug.cgi?id=72788

Reviewed by Adam Barth.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntegrate Source/WTF with the Chromium build system
abarth@webkit.org [Sat, 19 Nov 2011 08:25:10 +0000 (08:25 +0000)]
Integrate Source/WTF with the Chromium build system
https://bugs.webkit.org/show_bug.cgi?id=72790

Reviewed by Eric Seidel.

Source/WebCore:

Add a dependency on the new WTF.

* WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

Add a dependency on the new WTF.

* WebKit.gyp:

Source/WTF:

Rename the target in this file to "newwtf" to avoid naming conflicts.

* WTF.gyp/WTF.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWTF should have an Xcode project
abarth@webkit.org [Sat, 19 Nov 2011 08:09:22 +0000 (08:09 +0000)]
WTF should have an Xcode project
https://bugs.webkit.org/show_bug.cgi?id=71752

Patch by Mark Rowe <mrowe@apple.com> on 2011-11-19
Reviewed by Adam Barth.

This adds an Xcode project that includes only Stub.cpp and Stub.h.
They’re built in to a library at the appropriate path for each
configuration (WebKitBuild/{Debug,Release}/libWTF.a and
/usr/local/lib/libWTF.a) and headers are installed in to the
appropriate location (WebKitBuild/{Debug,Release}/usr/local/include/wtf
and /usr/local/include/wtf). I tested building WTF in this project and
everything appears to build except for DateMath.cpp (due to bug 71747).
I have not yet done any work on making JavaScriptCore and other
projects use the built products of this new project.

* Configurations: Added.
* Configurations/Base.xcconfig: Copied from Source/JavaScriptCore/Configurations/Base.xcconfig.
* Configurations/CompilerVersion.xcconfig: Copied from Source/JavaScriptCore/Configurations/CompilerVersion.xcconfig.
* Configurations/DebugRelease.xcconfig: Copied from Source/JavaScriptCore/Configurations/DebugRelease.xcconfig.
* Configurations/WTF.xcconfig: Copied from Source/WebKit2/Configurations/Shim.xcconfig.
* WTF.xcodeproj: Added.
* WTF.xcodeproj/project.pbxproj: Added.
* config.h: Copied from Source/JavaScriptCore/config.h.
* icu: Added.
* icu/LICENSE: Copied from Source/JavaScriptCore/icu/LICENSE.
* icu/README: Copied from Source/JavaScriptCore/icu/README.
* icu/unicode: Added.
* icu/unicode/parseerr.h: Copied from Source/JavaScriptCore/icu/unicode/parseerr.h.
* icu/unicode/platform.h: Copied from Source/JavaScriptCore/icu/unicode/platform.h.
* icu/unicode/putil.h: Copied from Source/JavaScriptCore/icu/unicode/putil.h.
* icu/unicode/uchar.h: Copied from Source/JavaScriptCore/icu/unicode/uchar.h.
* icu/unicode/ucnv.h: Copied from Source/JavaScriptCore/icu/unicode/ucnv.h.
* icu/unicode/ucnv_err.h: Copied from Source/JavaScriptCore/icu/unicode/ucnv_err.h.
* icu/unicode/ucol.h: Copied from Source/JavaScriptCore/icu/unicode/ucol.h.
* icu/unicode/uconfig.h: Copied from Source/JavaScriptCore/icu/unicode/uconfig.h.
* icu/unicode/uenum.h: Copied from Source/JavaScriptCore/icu/unicode/uenum.h.
* icu/unicode/uiter.h: Copied from Source/JavaScriptCore/icu/unicode/uiter.h.
* icu/unicode/uloc.h: Copied from Source/JavaScriptCore/icu/unicode/uloc.h.
* icu/unicode/umachine.h: Copied from Source/JavaScriptCore/icu/unicode/umachine.h.
* icu/unicode/unorm.h: Copied from Source/JavaScriptCore/icu/unicode/unorm.h.
* icu/unicode/urename.h: Copied from Source/JavaScriptCore/icu/unicode/urename.h.
* icu/unicode/uscript.h: Copied from Source/JavaScriptCore/icu/unicode/uscript.h.
* icu/unicode/uset.h: Copied from Source/JavaScriptCore/icu/unicode/uset.h.
* icu/unicode/ustring.h: Copied from Source/JavaScriptCore/icu/unicode/ustring.h.
* icu/unicode/utf.h: Copied from Source/JavaScriptCore/icu/unicode/utf.h.
* icu/unicode/utf16.h: Copied from Source/JavaScriptCore/icu/unicode/utf16.h.
* icu/unicode/utf8.h: Copied from Source/JavaScriptCore/icu/unicode/utf8.h.
* icu/unicode/utf_old.h: Copied from Source/JavaScriptCore/icu/unicode/utf_old.h.
* icu/unicode/utypes.h: Copied from Source/JavaScriptCore/icu/unicode/utypes.h.
* icu/unicode/uversion.h: Copied from Source/JavaScriptCore/icu/unicode/uversion.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] [WebSocket] export WebSocketChannel interface for plugins
commit-queue@webkit.org [Sat, 19 Nov 2011 07:19:57 +0000 (07:19 +0000)]
[Chromium] [WebSocket] export WebSocketChannel interface for plugins
https://bugs.webkit.org/show_bug.cgi?id=72016

Source/WebCore:

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-18
Reviewed by Darin Fisher.

Add a interface to send raw binary data.
This interface is used by WebWebSocketChannel implementation
in WebKit API.

No new tests because just export a interface.

* websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
* websockets/WebSocketChannel.h:

Source/WebKit/chromium:

Add WebSocket and WebSocketClient to WebKit API.

Currently, only WebSocketStreamHandle class is exported to WebKit API.
WebSocketStreamHandle implements bi-directional communication ports.
If plugins handles the WebSocket protocol, WebSocketChannel and
WebSocketChannelClient must be exported as WebSocket because they are
the classes which implement the WebSocket protocol stack.

Normally, we use WebWebSocketChannel and WebWebSocketChannelClient as
their class names. But here we use just WebSocket and WebSocketClient
because of avoiding WebWeb prefix and class name confliction on
header include.

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-11-18
Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebSocket.h: Added.
(WebKit::WebSocket::~WebSocket):
* public/WebSocketClient.h: Added.
(WebKit::WebSocketClient::~WebSocketClient):
* src/WebRuntimeFeatures.cpp: Insert websockets directory to include path in order to avoid filename confliction.
(WebKit::WebRuntimeFeatures::enableSockets): Use WebCore namespace explicitly.
* src/WebSocket.cpp: Added.
(WebKit::WebSocket::create):
* src/WebSocketImpl.cpp: Added.
(WebKit::WebSocketImpl::WebSocketImpl):
(WebKit::WebSocketImpl::~WebSocketImpl):
(WebKit::WebSocketImpl::connect):
(WebKit::WebSocketImpl::subprotocol):
(WebKit::WebSocketImpl::sendText):
(WebKit::WebSocketImpl::sendBinary):
(WebKit::WebSocketImpl::bufferedAmount):
(WebKit::WebSocketImpl::close):
(WebKit::WebSocketImpl::fail):
(WebKit::WebSocketImpl::disconnect):
(WebKit::WebSocketImpl::didConnect):
(WebKit::WebSocketImpl::didReceiveMessage):
(WebKit::WebSocketImpl::didReceiveBinaryData):
(WebKit::WebSocketImpl::didReceiveMessageError):
(WebKit::WebSocketImpl::didStartClosingHandshake):
(WebKit::WebSocketImpl::didClose):
* src/WebSocketImpl.h: Added.
(WebKit::WebSocketImpl::isNull):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPixel results missing for fast/regions/render-region-custom-style-mark.html
mihnea@adobe.com [Sat, 19 Nov 2011 07:11:05 +0000 (07:11 +0000)]
Pixel results missing for fast/regions/render-region-custom-style-mark.html
https://bugs.webkit.org/show_bug.cgi?id=72775

Reviewed by Adam Barth.

* platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=72591
commit-queue@webkit.org [Sat, 19 Nov 2011 06:05:05 +0000 (06:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=72591
Remove document.width / document.height

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-18
Reviewed by Darin Adler.

Source/WebCore:

Removed document.width/document.height from JS bindings,
but keeping the same for ObjC bindings. Also it should use
document.body.clientWidth and document.body.clientHeight instead.

* html/HTMLDocument.idl:

LayoutTests:

As support for document.width / document.height has been
removed it should use document.body.clientWidth and document.body.clientHeight
respectively.

* fast/dom/document-width-height-force-layout-expected.txt:
* fast/dom/document-width-height-force-layout.html:
Modified test case to use document.body.clientWidth and document.body.clientHeight.
* fullscreen/video-specified-size-expected.txt:
* fullscreen/video-specified-size.html:
Modified test case to use document.body.clientWidth.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the GTK+ build.
mrobinson@webkit.org [Sat, 19 Nov 2011 05:24:30 +0000 (05:24 +0000)]
Fix the GTK+ build.

* page/Navigator.idl: Properly disable the webkitGamepads API if gamepad
isn't enabled at compile time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed, add one failing test to the Skipped list.
yutak@chromium.org [Sat, 19 Nov 2011 05:10:39 +0000 (05:10 +0000)]
[Qt] Unreviewed, add one failing test to the Skipped list.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd CMake build infrastructure for the BlackBerry port
dbates@webkit.org [Sat, 19 Nov 2011 03:56:59 +0000 (03:56 +0000)]
Add CMake build infrastructure for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=72768

.:

Reviewed by Adam Barth and Antonio Gomes.

* Source/CMakeLists.txt: Add the BlackBerry port and support for building on QNX.
* Source/cmake/OptionsBlackBerry.cmake: Added.
* Source/cmake/OptionsCommon.cmake: Add QNX QCC-variant of CODE_GENERATOR_PREPROCESSOR.
  We may be able to fold this into the non-MSVC CODE_GENERATOR_PREPROCESSOR.

Source/JavaScriptCore:

Reviewed by Antonio Gomes.

* PlatformBlackBerry.cmake: Added.
* shell/PlatformBlackBerry.cmake: Added.
* wtf/PlatformBlackBerry.cmake: Added.

Source/WebCore:

Reviewed by Antonio Gomes.

* CMakeLists.txt: At this time the BlackBerry port doesn't support generating
  DOM bindings from the SVG IDLs. See WebKit bug #72773.
* PlatformBlackBerry.cmake: Added.

Source/WebKit:

Reviewed by Antonio Gomes.

* blackberry: Added.
* blackberry/CMakeListsBlackBerry.txt: Added.

Tools:

Reviewed by Antonio Gomes.

Add optional --blackberry command line argument to build-webkit to build the
BlackBerry port.

* Scripts/build-webkit:
* Scripts/webkitdirs.pm:
(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(determineIsQt):
(isBlackBerry): Added.
(determineIsBlackBerry): Added.
(blackberryTargetArchitecture): Added.
(isAppleWebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd another isfinite assertion failure for fast/borders/
adamk@chromium.org [Sat, 19 Nov 2011 03:40:59 +0000 (03:40 +0000)]
Add another isfinite assertion failure for fast/borders/
https://bugs.webkit.org/show_bug.cgi?id=72053

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r100826.
adamk@chromium.org [Sat, 19 Nov 2011 03:18:49 +0000 (03:18 +0000)]
Unreviewed, rolling out r100826.
http://trac.webkit.org/changeset/100826
https://bugs.webkit.org/show_bug.cgi?id=72786

Broke Chromium Mac build (Requested by aklein on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-18

Source/WebCore:

* page/ChromeClient.h:
* page/FrameView.cpp:
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollbarStyleChanged):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

Source/WebKit2:

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::scrollbarStyleChanged):
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline after r100819.
adamk@chromium.org [Sat, 19 Nov 2011 03:05:27 +0000 (03:05 +0000)]
Rebaseline after r100819.

Unreviewed gardening.

* platform/chromium-mac-leopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png.
* platform/chromium-mac-snowleopard/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix reviewed by lines in ChangeLogs
jamesr@google.com [Sat, 19 Nov 2011 03:04:15 +0000 (03:04 +0000)]
Fix reviewed by lines in ChangeLogs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] composited layers are blurry with a zoom-in page scale factor
jamesr@google.com [Sat, 19 Nov 2011 03:02:31 +0000 (03:02 +0000)]
[chromium] composited layers are blurry with a zoom-in page scale factor
https://bugs.webkit.org/show_bug.cgi?id=71225

Source/WebCore:

Patch by Alpha Lam <hclam@chromium.org> on 2011-11-18
Reviewed by James.

Pass contents scale factor to the compositor such that it can:
1. Adjust contentBounds() of the compositoer layers with content scale.
2. Apply the content scale in the painter for texture update in better resolution.
3. Apply the content scale to the dirty rect in CanvasLayerTextureUpdater.

This change fixed blurry problem for all tiled layer types and is not limited to
position:fixed layers.

Tests: compositing/geometry/fixed-position-composited-page-scale-down.html
       compositing/geometry/fixed-position-composited-page-scale.html
       compositing/geometry/fixed-position-iframe-composited-page-scale-down.html
       compositing/geometry/fixed-position-iframe-composited-page-scale.html
       compositing/geometry/fixed-position-transform-composited-page-scale-down.html
       compositing/geometry/fixed-position-transform-composited-page-scale.html

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::contentsScale):
(WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged):
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::prepareToUpdate):
(WebCore::ImageLayerChromium::needsContentsScale):
* platform/graphics/chromium/ImageLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setContentsScale):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::needsContentsScale):
(WebCore::LayerChromium::contentsScale):
* platform/graphics/chromium/LayerTextureUpdater.h:
* platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
(WebCore::LayerTextureUpdaterCanvas::paintContents):
(WebCore::LayerTextureUpdaterBitmap::prepareToUpdate):
(WebCore::LayerTextureUpdaterSkPicture::prepareToUpdate):
* platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::needsContentsScale):
(WebCore::TiledLayerChromium::contentBounds):
(WebCore::TiledLayerChromium::prepareToUpdate):
* platform/graphics/chromium/TiledLayerChromium.h:

Source/WebKit/chromium:

Patch by Alpha Lam <hclam@chromium.org> on 2011-11-18
Reviewed by James.

Implements GraphicsLayerClient to return values for pageScaleFactor and deviceScaleFactor. They are used to determine contents scale factor compositer layers.

* src/PageOverlay.cpp:
(WebKit::OverlayGraphicsLayerClientImpl::deviceScaleFactor):
(WebKit::OverlayGraphicsLayerClientImpl::pageScaleFactor):

LayoutTests:

Added test cases that has position:fixed and page scale.

Patch by Alpha Lam <hclam@chromium.org> on 2011-11-18
Reviewed by James.

* compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Added.
* compositing/geometry/fixed-position-composited-page-scale-down.html: Added.
* compositing/geometry/fixed-position-composited-page-scale-expected.txt: Added.
* compositing/geometry/fixed-position-composited-page-scale.html: Added.
* compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.txt: Added.
* compositing/geometry/fixed-position-iframe-composited-page-scale-down.html: Added.
* compositing/geometry/fixed-position-iframe-composited-page-scale-expected.txt: Added.
* compositing/geometry/fixed-position-iframe-composited-page-scale.html: Added.
* compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.txt: Added.
* compositing/geometry/fixed-position-transform-composited-page-scale-down.html: Added.
* compositing/geometry/fixed-position-transform-composited-page-scale-expected.txt: Added.
* compositing/geometry/fixed-position-transform-composited-page-scale.html: Added.
* platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
* platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
* platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
* platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
* platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove manual-tests out of WebCore.
abarth@webkit.org [Sat, 19 Nov 2011 02:43:03 +0000 (02:43 +0000)]
Move manual-tests out of WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r100835.
jamesr@google.com [Sat, 19 Nov 2011 02:40:33 +0000 (02:40 +0000)]
Unreviewed, rolling out r100835.
http://trac.webkit.org/changeset/100835
https://bugs.webkit.org/show_bug.cgi?id=72778

Broke some page scale tests

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::scalePageBy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPrepare to move manual-tests out of WebCore
abarth@webkit.org [Sat, 19 Nov 2011 02:36:58 +0000 (02:36 +0000)]
Prepare to move manual-tests out of WebCore
https://bugs.webkit.org/show_bug.cgi?id=72782

Reviewed by Eric Seidel.

.:

Update these files to refer to the new location of ManualTests.

* .gitattributes:
* Source/cmake/WebKitPackaging.cmake:

Tools:

Update this file to refer to the new location of ManualTests.

* Scripts/webkitpy/common/config/build.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Set min/max page scale factors when calling eventSender.scalePageBy to...
jamesr@google.com [Sat, 19 Nov 2011 02:25:54 +0000 (02:25 +0000)]
[chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
https://bugs.webkit.org/show_bug.cgi?id=72778

Reviewed by Kenneth Russell.

Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::scalePageBy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2][Qt] Move Accelerated Composite animations to UIProcess
igor.oliveira@openbossa.org [Sat, 19 Nov 2011 02:23:32 +0000 (02:23 +0000)]
[WK2][Qt] Move Accelerated Composite animations to UIProcess
https://bugs.webkit.org/show_bug.cgi?id=72753

Source/WebCore:

Add helper method to synchronize animations in TextureMapper.

Reviewed by Noam Rosenthal.

* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::syncAnimationsRecursively):
* platform/graphics/texmap/TextureMapperNode.h:

Source/WebKit2:

Currently, all the accelerated compositing animations are applied in WebProcess and
for each frame generated, WebProcess needs to sync with UIProcess.

This patch moves the accelerated compositing animations to UIProcess reducing the
amount of synchronization messages between WebProcess and UIProcess, this is done
sending animations information to UIProcess.

Reviewed by Noam Rosenthal.

* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):

Encode/Decode RefPtr<Animation> instead of Animation class. This facilitates
the data serialization.

* Shared/WebCoreArgumentCoders.h:
* Shared/WebLayerTreeInfo.cpp:
(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):
(WebKit::WebLayerAnimation::encode):
(WebKit::WebLayerAnimation::decode):

Create WebLayerAnimation struct, it is used to send animation information
to UIProcess.

* Shared/WebLayerTreeInfo.h:
(WebKit::WebLayerAnimation::WebLayerAnimation):
* UIProcess/LayerTreeHostProxy.h:
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::LayerTreeHostProxy):
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):
(WebKit::LayerTreeHostProxy::updateSceneGraphUpdateTimerFired):
(WebKit::LayerTreeHostProxy::syncLayerParameters):
* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::addAnimation):
(WebCore::WebGraphicsLayer::pauseAnimation):
(WebCore::WebGraphicsLayer::removeAnimation):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIDL changes for gamepad support
commit-queue@webkit.org [Sat, 19 Nov 2011 02:03:15 +0000 (02:03 +0000)]
IDL changes for gamepad support
https://bugs.webkit.org/show_bug.cgi?id=71753

Patch by Scott Graham <scottmg@chromium.org> on 2011-11-18
Reviewed by Adam Barth.

Source/WebCore:

IDL changes and associated plumbing to expose list of gamepad objects
on navigator object (per current spec). Full patch is
https://bugs.webkit.org/show_bug.cgi?id=69451. Only basic existence
test until more plumbing in future patches.

Test: gamepad/gamepad-api.html

* WebCore.gypi:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebkitGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGamepadsEnabled):
* page/Gamepad.cpp: Added.
(WebCore::Gamepad::Gamepad):
(WebCore::Gamepad::axes):
(WebCore::Gamepad::buttons):
(WebCore::Gamepad::~Gamepad):
* page/Gamepad.h: Added.
* page/Gamepad.idl: Added.
* page/GamepadList.cpp: Added.
(WebCore::GamepadList::~GamepadList):
(WebCore::GamepadList::set):
(WebCore::GamepadList::length):
(WebCore::GamepadList::item):
* page/GamepadList.h: Added.
(WebCore::GamepadList::create):
(WebCore::GamepadList::GamepadList):
* page/GamepadList.idl: Added.
* page/Navigator.cpp:
(WebCore::Navigator::webkitGamepads):
* page/Navigator.h:
* page/Navigator.idl:

Source/WebKit/chromium:

Update to use vendor-prefixed enable.

* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableGamepad):
(WebKit::WebRuntimeFeatures::isGamepadEnabled):

Tools:

Runtime enable gamepad in chromium test shell.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

LayoutTests:

Add basic api existence test.

* gamepad/gamepad-api-expected.txt: Added.
* gamepad/gamepad-api.html: Added.
* gamepad/gamepad-test.js: Added.
(logConsole):
(testExpected):
(reportExpected):
(waitForEventAndEnd):
(waitForEvent._eventCallback):
(waitForEvent):
(waitForEventAndTest._eventCallback):
(waitForEventAndTest):
(waitForEventTestAndEnd):
(endTest):
(logResult):
(consoleWrite):
* platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r100693.
commit-queue@webkit.org [Sat, 19 Nov 2011 01:48:13 +0000 (01:48 +0000)]
Unreviewed, rolling out r100693.
http://trac.webkit.org/changeset/100693
https://bugs.webkit.org/show_bug.cgi?id=72779

This patch caused a rendering regression (see bug 72770)
(Requested by philip__ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-18

Source/WebCore:

* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):

LayoutTests:

* fast/layers/layer-absolute-parent-opacity-expected.png: Removed.
* fast/layers/layer-absolute-parent-opacity-expected.txt: Removed.
* fast/layers/layer-absolute-parent-opacity.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReflection on composited element doesn't update if the element changes to show no...
simon.fraser@apple.com [Sat, 19 Nov 2011 01:17:12 +0000 (01:17 +0000)]
Reflection on composited element doesn't update if the element changes to show no content
https://bugs.webkit.org/show_bug.cgi?id=72774

Source/WebCore:

Reviewed by Chris Marrin.

When a style change results in a reflected element losing its backing store,
we need to clear the backing stores on the layer clones as well.

Test: compositing/reflections/become-simple-composited-reflection.html

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):

LayoutTests:

Reviewed by Chris Marrin.

Test that removes the background-color of a reflected, composited element.

* compositing/reflections/become-simple-composited-reflection-expected.png: Added.
* compositing/reflections/become-simple-composited-reflection-expected.txt: Added.
* compositing/reflections/become-simple-composited-reflection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert the encoding of JavaScriptGlue/Change from MacRoman to UTF-8 as it should be.
rniwa@webkit.org [Sat, 19 Nov 2011 01:12:06 +0000 (01:12 +0000)]
Convert the encoding of JavaScriptGlue/Change from MacRoman to UTF-8 as it should be.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG JIT fails speculation on InstanceOf if the base is not an object
fpizlo@apple.com [Sat, 19 Nov 2011 01:00:34 +0000 (01:00 +0000)]
DFG JIT fails speculation on InstanceOf if the base is not an object
https://bugs.webkit.org/show_bug.cgi?id=72709

Reviewed by Geoff Garen.

InstanceOf already leverages the fact that we only allow the default
hasInstance implementation. So, if the base is predicted to possibly
be not an object and the CFA has not yet proven otherwise, InstanceOf
will abstain from speculating cell and instead return false if the
base is not a cell.

This appears to be a 1% speed-up on V8 on the V8 harness. 3-4% or so
speed-up in earley-boyer. Neutral according to bencher on SunSpider,
V8, and Kraken. In 32-bit, it's a 0.5% win on SunSpider and a 1.9%
win on V8 even on my harness, due to a 12.5% win on earley-boyer.

I also took this opportunity to make the code for InstanceOf common
between the two JITs. This was partially successful, in that the
"common code" has a bunch of #if's, but overall it seems like a code
size reduction.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileInstanceOf):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Use correct backing store for ChromiumDataObject in pasteboard writes.
dcheng@chromium.org [Sat, 19 Nov 2011 00:46:42 +0000 (00:46 +0000)]
[chromium] Use correct backing store for ChromiumDataObject in pasteboard writes.
https://bugs.webkit.org/show_bug.cgi?id=72767

Source/WebCore:

Reviewed by Tony Chang.

Covered by existing tests.

* editing/chromium/EditorChromium.cpp:
(WebCore::Editor::newGeneralClipboard):
* page/chromium/EventHandlerChromium.cpp:
(WebCore::EventHandler::createDraggingClipboard):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
(WebCore::ChromiumDataObject::containsFilenames):
(WebCore::ChromiumDataObject::ChromiumDataObject):
* platform/chromium/ChromiumDataObject.h:
(WebCore::ChromiumDataObject::createFromPasteboard):
(WebCore::ChromiumDataObject::create):
(WebCore::ChromiumDataObject::storageMode):
* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::hasData):

Source/WebKit/chromium:

Reviewed by Tony Chang.

* src/WebDragData.cpp:
(WebKit::WebDragData::initialize):
(WebKit::WebDragData::assign):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash with ranges across a detached, reparented node tree
cevans@google.com [Sat, 19 Nov 2011 00:43:23 +0000 (00:43 +0000)]
Crash with ranges across a detached, reparented node tree
https://bugs.webkit.org/show_bug.cgi?id=72757

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/dom/move-detached-child-in-range.html

* dom/RangeBoundaryPoint.h:
(WebCore::RangeBoundaryPoint::childBefore): protect the raw child node from getting pulled from under us.

LayoutTests:

* fast/dom/move-detached-child-in-range-expected.txt: Added.
* fast/dom/move-detached-child-in-range.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=72551
bdakin@apple.com [Sat, 19 Nov 2011 00:31:44 +0000 (00:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=72551
When the recommended scrollbar style changes, WKView's tracking options should
adjust accordingly
-and corresponding-
<rdar://problem/10409328>

Reviewed by Darin Adler.

Source/WebCore:

This new ChromeClient function is called when the recommended scrollbar style
changes. This way, WebKit can respond to the change by adjusting its mouse
tracking.
* page/ChromeClient.h:
(WebCore::ChromeClient::recommendedScrollbarStyleDidChange):

Existing ScrollableArea function scrollbarStyleChanged() now takes an int
indicating the new scrollbar style and a bool indicating whether it is necessary
to force an update. It used to be the case that this function was ONLY used to
force an update (and only called when an updated was needed), but now that it must
also call into the ChromeClient, it is necessary to include a bool tracking
whether we need to force an update. New implementation on FrameView is responsible
for calling ChromeClient, and then that calls into the pre-existing ScrollView
function for the forceUpdate part.
* page/FrameView.cpp:
(WebCore::FrameView::scrollbarStyleChanged):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView:: scrollbarStyleChanged):
* platform/ScrollView.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollbarStyleChanged):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::updateScrollerStyle):

Source/WebKit2:

These new functions take care of passing along the
recommendedScrollbarStyleDidChange() message that originates in the ChromeClient.
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::recommendedScrollbarStyleDidChange):
* WebProcess/WebCoreSupport/WebChromeClient.h:

This is where we actually respond to the recommendedScrollbarStyleDidChange
message. We remove the existing tracking area and create a new tracking area with
the appropriate tracking options.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::recommendedScrollbarStyleDidChange):

BuiltInPDFView inherits from WebCore::ScrollableArea, so scrollbarStyleChanged()
must now take two parameters like the one in ScrollableArea.
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::scrollbarStyleChanged):
* WebProcess/Plugins/PDF/BuiltInPDFView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse canplay instead of canplaythrough in http/tests/media to prevent timeout
adamk@chromium.org [Sat, 19 Nov 2011 00:29:14 +0000 (00:29 +0000)]
Use canplay instead of canplaythrough in http/tests/media to prevent timeout
https://bugs.webkit.org/show_bug.cgi?id=72758

Allow these tests to timeout until the bug is fixed.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixes several more void functions in RenderObject that return values.
knorton@google.com [Sat, 19 Nov 2011 00:23:03 +0000 (00:23 +0000)]
Fixes several more void functions in RenderObject that return values.
https://bugs.webkit.org/show_bug.cgi?id=72750

Reviewed by Adam Barth.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateBeforeAfterContent):
(WebCore::RenderBlock::addChildToContinuation):
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):
(WebCore::RenderBlock::addChild):
(WebCore::RenderBlock::addChildIgnoringContinuation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add some useful text to existing debug dump
commit-queue@webkit.org [Sat, 19 Nov 2011 00:14:49 +0000 (00:14 +0000)]
[chromium] Add some useful text to existing debug dump
https://bugs.webkit.org/show_bug.cgi?id=72576

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-11-18
Reviewed by James Robinson.

No new tests needed.

* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::dumpLayerProperties):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::dumpSurface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoForgot to completely de-virtualize isDynamicScope
mhahnenberg@apple.com [Sat, 19 Nov 2011 00:12:13 +0000 (00:12 +0000)]
Forgot to completely de-virtualize isDynamicScope
https://bugs.webkit.org/show_bug.cgi?id=72763

Reviewed by Darin Adler.

* runtime/JSActivation.h: Removed virtual keyword.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-24 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 18 Nov 2011 23:35:14 +0000 (23:35 +0000)]
2011-10-24  Darin Fisher  <darin@chromium.org>

        [chromium] Improve fullscreen API
        https://bugs.webkit.org/show_bug.cgi?id=70477

        Reviewed by Adam Barth.

        Move fullscreen entry points from WebView to WebWidget since they are
        just about widget geometry.

        Delay webkitfullscreenchange event until we know that we have entered
        fullscreen mode.  This is accomplished by expanding the WebKit APIs to
        differentiate will{Enter,Exit} from did{Enter,Exit} state changes.

        WebViewImpl is forced to keep a reference to the requested fullscreen
        element while we are requesting to enter fullscreen mode.  Once in
        fullscreen mode, we switch to keeping only a reference to the Frame
        containing the fullscreen element, which we drop upon exiting
        fullscreen mode.

        * public/WebView.h:
        * public/WebViewClient.h:
        * public/WebWidget.h:
        (WebKit::WebWidget::willEnterFullScreen):
        (WebKit::WebWidget::didEnterFullScreen):
        (WebKit::WebWidget::willExitFullScreen):
        (WebKit::WebWidget::didExitFullScreen):
        * public/WebWidgetClient.h:
        (WebKit::WebWidgetClient::enterFullScreen):
        (WebKit::WebWidgetClient::exitFullScreen):
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::supportsFullscreenForNode):
        (WebKit::ChromeClientImpl::enterFullscreenForNode):
        (WebKit::ChromeClientImpl::exitFullscreenForNode):
        (WebKit::ChromeClientImpl::supportsFullScreenForElement):
        (WebKit::ChromeClientImpl::enterFullScreenForElement):
        (WebKit::ChromeClientImpl::exitFullScreenForElement):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::willEnterFullScreen):
        (WebKit::WebViewImpl::didEnterFullScreen):
        (WebKit::WebViewImpl::willExitFullScreen):
        (WebKit::WebViewImpl::didExitFullScreen):
        (WebKit::WebViewImpl::enterFullScreenForElement):
        (WebKit::WebViewImpl::exitFullScreenForElement):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG...
fpizlo@apple.com [Fri, 18 Nov 2011 23:29:20 +0000 (23:29 +0000)]
Crash in JSC::DFG::OSRExitCompiler::compileExit(JSC::DFG::OSRExit const&, JSC::DFG::SpeculationRecovery*)
https://bugs.webkit.org/show_bug.cgi?id=72292

Reviewed by Darin Adler.

Fix this for 32_64.

* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scroll...
xji@chromium.org [Fri, 18 Nov 2011 23:22:37 +0000 (23:22 +0000)]
REGRESSION: rtl horizontal scrollbar / resize bug - Body shifts on resize when scrolled all the way to the left
https://bugs.webkit.org/show_bug.cgi?id=70395

Reviewed by Tony Chang.

Source/WebCore:

This patch fixes the problem in Mac and Chromium Mac.

The existing test fast/dom/rtl-scroll-to-leftmost-and-resize.html seems does not really work in Mac DRT
(the browswer window is not resized). It works in Chromium-Mac. And Chromium-Mac's code
is forked from Mac.

* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):

LayoutTests:

The test still marks as FAIL in test_expectations because cg-mac might need rebase.

* platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/chromium-mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r99924): broke 2 pasteboard tests on GTK
mrobinson@webkit.org [Fri, 18 Nov 2011 23:09:03 +0000 (23:09 +0000)]
REGRESSION (r99924): broke 2 pasteboard tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=72131

Reviewed by Tony Chang.

Source/WebCore:

* platform/gtk/ClipboardGtk.cpp:
(WebCore::ClipboardGtk::clearData): Call clearAll now.
(WebCore::ClipboardGtk::clearAllData): Call clearAllExceptFilenames now.
* platform/gtk/DataObjectGtk.cpp:
(WebCore::DataObjectGtk::clearAllExceptFilenames): Renamed from clear.
(WebCore::DataObjectGtk::clearAll): Added this method which also clear filenames.
* platform/gtk/DataObjectGtk.h:
* platform/gtk/PasteboardGtk.cpp: Call clear before setting new clipboard data.
(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::Pasteboard::writePlainText): Ditto.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::Pasteboard::writeImage): Ditto.
* platform/gtk/PasteboardHelper.cpp:
(WebCore::clearClipboardContentsCallback): Use the clearAll method now.

Source/WebKit/gtk:

* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::setSelectionPrimaryClipboardIfNeeded): Use the new clearAll method.

LayoutTests:

* platform/gtk/Skipped: Unskip passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Wk2] Add an API test for scroll request from javascript
commit-queue@webkit.org [Fri, 18 Nov 2011 23:01:32 +0000 (23:01 +0000)]
[Qt][Wk2] Add an API test for scroll request from javascript
https://bugs.webkit.org/show_bug.cgi?id=72407

New API test added for QQuickWebView for javascript scroll request
Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2011-11-18
Reviewed by Simon Hausmann.

* UIProcess/API/qt/tests/html/scroll.html: Added.
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
(tst_QQuickWebView::scrollRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayout Test accessibility/anonymous-render-block-in-continuation-causes-crash.html...
adamk@chromium.org [Fri, 18 Nov 2011 22:52:56 +0000 (22:52 +0000)]
Layout Test accessibility/anonymous-render-block-in-continuation-causes-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72761

Mark test as PASS TIMEOUT as it occasionally times out on the bots.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] The exclusions tests are all passing. Remove the
tony@chromium.org [Fri, 18 Nov 2011 22:26:57 +0000 (22:26 +0000)]
[chromium] The exclusions tests are all passing. Remove the
test_expectations.txt entry for them.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Test fast/events/dropzone-002.html is failing on Leopard
adamk@chromium.org [Fri, 18 Nov 2011 22:24:52 +0000 (22:24 +0000)]
[chromium] Test fast/events/dropzone-002.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=61625

Test is no longer failing since the end of October.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize ExecutableBase::intrinsic
mhahnenberg@apple.com [Fri, 18 Nov 2011 22:13:37 +0000 (22:13 +0000)]
De-virtualize ExecutableBase::intrinsic
https://bugs.webkit.org/show_bug.cgi?id=72548

Reviewed by Oliver Hunt.

* runtime/Executable.cpp:
(JSC::ExecutableBase::intrinsic): Dynamic cast to NativeExecutable. If successful, call intrinsic, otherwise return default value.
* runtime/Executable.h:
* runtime/JSCell.h:
(JSC::jsDynamicCast): Add jsDynamicCast that duplicates the functionality of dynamic_cast in C++ but uses ClassInfo
rather than requiring C++ RTTI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline chromium expectations after r100800.
adamk@chromium.org [Fri, 18 Nov 2011 21:42:13 +0000 (21:42 +0000)]
Rebaseline chromium expectations after r100800.
Note that previous rebaseline was actually meant for r100786.

Unreviewed gardening.

* platform/chromium-win/animations/additive-transform-animations-expected.png: Added.
* platform/chromium-win/animations/additive-transform-animations-expected.txt: Added.
* platform/chromium/animations/additive-transform-animations-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline chromium expectations after r100800.
adamk@chromium.org [Fri, 18 Nov 2011 21:39:52 +0000 (21:39 +0000)]
Rebaseline chromium expectations after r100800.

Unreviewed gardening.

* platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png: Added.
* platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayout Test fast/writing-mode/japanese-rl-text-with-broken-font.html is flaky
adamk@chromium.org [Fri, 18 Nov 2011 21:26:23 +0000 (21:26 +0000)]
Layout Test fast/writing-mode/japanese-rl-text-with-broken-font.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=66900

Re-adding SNOWLEOPARD flakiness on CG bots that seems to have been
erroneously removed.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAccess key should work on all elements.
commit-queue@webkit.org [Fri, 18 Nov 2011 21:19:14 +0000 (21:19 +0000)]
Access key should work on all elements.
https://bugs.webkit.org/show_bug.cgi?id=71854

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-11-18
Reviewed by Ryosuke Niwa.

Source/WebCore:

All HTML elements can have the accesskey content attribute set.
Specification http://dev.w3.org/html5/spec/Overview.html#the-accesskey-attribute
Adding "accessKey" attribute to HTMLElement.idl file as [Reflect].

Test: fast/forms/access-key-for-all-elements.html

* bindings/objc/PublicDOMInterfaces.h: Moved properties form subclass to base class.
* html/BaseButtonInputType.cpp:
(WebCore::BaseButtonInputType::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
* html/BaseButtonInputType.h: Ditto
* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::accessKeyAction): Ditto
* html/BaseCheckableInputType.h: Ditto
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::accessKeyAction): Ditto
* html/HTMLAnchorElement.h: Ditto
* html/HTMLAnchorElement.idl: Removed redundant IDL attribute entries.
* html/HTMLAreaElement.idl: Removed redundant IDL attribute entries.
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
* html/HTMLButtonElement.h: Ditto
* html/HTMLButtonElement.idl: Removed redundant IDL attribute entries.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
If the element does not have a defined activation behavior, fire a click event at the element.
* html/HTMLElement.h: Ditto
* html/HTMLElement.idl: Added accessKey IDL attribute.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
* html/HTMLInputElement.h: Ditto
* html/HTMLInputElement.idl: Removed redundant IDL attribute entries.
* html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
* html/HTMLLabelElement.h: Ditto
* html/HTMLLabelElement.idl: Removed redundant IDL attribute entries.
* html/HTMLLegendElement.cpp:
(WebCore::HTMLLegendElement::accessKeyAction): Renamed variable sendToAnyElement to sendMouseEvents.
* html/HTMLLegendElement.h: Ditto
* html/HTMLLegendElement.idl: Removed redundant IDL attribute entries.
* html/HTMLOptGroupElement.h: Renamed variable sendToAnyElement to sendMouseEvents.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::accessKeyAction): Ditto
* html/HTMLSelectElement.h: Ditto
* html/HTMLTextAreaElement.h: Ditto
* html/HTMLTextAreaElement.idl: Removed redundant IDL attribute entries.
* html/HiddenInputType.h: Renamed variable sendToAnyElement to sendMouseEvents.
* html/InputType.h: Ditto
* html/RangeInputType.cpp:
(WebCore::RangeInputType::accessKeyAction): Ditto
* html/RangeInputType.h: Ditto

LayoutTests:

Added test case to check whether all elements can also have accessKey attribute.

* fast/forms/access-key-expected.txt:
* fast/forms/access-key-for-all-elements-expected.txt: Added.
* fast/forms/access-key-for-all-elements.html: Added.
* fast/forms/access-key.html: Added more test coverage for select and textarea elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLayout Test accessibility/loading-iframe-sends-notification.html is slow on Win dbg
adamk@chromium.org [Fri, 18 Nov 2011 20:07:26 +0000 (20:07 +0000)]
Layout Test accessibility/loading-iframe-sends-notification.html is slow on Win dbg
https://bugs.webkit.org/show_bug.cgi?id=72747

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove expectation for fast/js/delete-syntax.html, which seems to have
adamk@chromium.org [Fri, 18 Nov 2011 19:57:02 +0000 (19:57 +0000)]
Remove expectation for fast/js/delete-syntax.html, which seems to have
been fixed by http://code.google.com/p/v8/source/detail?r=9993.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove IMAGE suppression for css3/images/cross-fade-overflow-position.html
adamk@chromium.org [Fri, 18 Nov 2011 19:32:58 +0000 (19:32 +0000)]
Remove IMAGE suppression for css3/images/cross-fade-overflow-position.html
to let me use garden-o-matic for rebaselining.

Unreviewed gardening.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInfinite recursion in WebCore::RenderInline::computeRectForRepaint
jchaffraix@webkit.org [Fri, 18 Nov 2011 19:20:32 +0000 (19:20 +0000)]
Infinite recursion in WebCore::RenderInline::computeRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=52144

Reviewed by Tony Chang.

The bug got fixed, landing the test. As I could not test the old test case, it is
landed as-is (apart from making it dumpAsText which was deemed safe).

* editing/execCommand/infinite-recursion-computeRectForRepaint-expected.txt: Added.
* editing/execCommand/infinite-recursion-computeRectForRepaint.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Appearance of compound transform animations under apps linked on...
simon.fraser@apple.com [Fri, 18 Nov 2011 19:18:19 +0000 (19:18 +0000)]
Source/WebCore: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
https://bugs.webkit.org/show_bug.cgi?id=72641
and
<rdar://problem/10314267>

Reviewed by Dean Jackson.

GraphicsLayerCA contains a "linked on or after" check to account for a bug in
Core Animation on SnowLeopard and earlier, which is that CA would apply the list
of animations in reverse order.

Our previous fix was incorrect, because it only adjusted the 'additive' property
of the animation list based on ordering, rather than flipping the entire list.
This change reverses the list of animations before giving them to CA, which fixes
the bug.

Test: animations/additive-transform-animations.html

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
* platform/graphics/ca/GraphicsLayerCA.h:

LayoutTests: Appearance of compound transform animations under apps linked on SnowLeopard is incorrect
https://bugs.webkit.org/show_bug.cgi?id=72641

Reviewed by Dean Jackson.

Pixel test for a hardware-animated tranform, where order of operations matters.

* animations/additive-transform-animations-expected.png: Added.
* animations/additive-transform-animations.html: Added.
* platform/mac/animations/additive-transform-animations-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@100800 268f45cc-cd09-0410-ab3c-d52691b4dbfc