WebKit-https.git
15 years agoBug #: 4946
eseidel [Tue, 20 Sep 2005 22:09:09 +0000 (22:09 +0000)]
Bug #: 4946
Submitted by: eseidel
Reviewed by: mjs
        Pickup latest Ecma changes from KDE, including
        adding in the SVG ecma bindings and DOM 3 LS bindings.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4946

        * WebCore.xcodeproj/project.pbxproj:
        * kdom/bindings/IDLCodeGenerator.pm:
        * kdom/bindings/IDLCodeGeneratorCpp.pm:
        * kdom/bindings/IDLCodeGeneratorEcmaInterface.pm: Added.
        * kdom/bindings/IDLCodeGeneratorJs.pm:
        * kdom/bindings/idl/core/Attr.idl:
        * kdom/bindings/idl/core/CharacterData.idl:
        * kdom/bindings/idl/core/DOMConfiguration.idl:
        * kdom/bindings/idl/core/DOMException.idl:
        * kdom/bindings/idl/core/DOMImplementation.idl:
        * kdom/bindings/idl/core/DOMImplementationList.idl: Removed.
        * kdom/bindings/idl/core/DOMImplementationSource.idl: Removed.
        * kdom/bindings/idl/core/DOMString.idl: Removed.
        * kdom/bindings/idl/core/Document.idl:
        * kdom/bindings/idl/core/Element.idl:
        * kdom/bindings/idl/core/NameList.idl: Removed.
        * kdom/bindings/idl/core/NamedNodeMap.idl:
        * kdom/bindings/idl/core/Node.idl:
        * kdom/bindings/idl/core/ProcessingInstruction.idl:
        * kdom/bindings/idl/core/Text.idl:
        * kdom/bindings/idl/core/UserDataHandler.idl: Removed.
        * kdom/bindings/idl/css/CSSCharsetRule.idl:
        * kdom/bindings/idl/css/CSSMediaRule.idl:
        * kdom/bindings/idl/css/CSSPageRule.idl:
        * kdom/bindings/idl/css/CSSPrimitiveValue.idl:
        * kdom/bindings/idl/css/CSSRule.idl:
        * kdom/bindings/idl/css/CSSStyleDeclaration.idl:
        * kdom/bindings/idl/css/CSSStyleRule.idl:
        * kdom/bindings/idl/css/CSSStyleSheet.idl:
        * kdom/bindings/idl/css/CSSValue.idl:
        * kdom/bindings/idl/css/ViewCSS.idl: Removed.
        * kdom/bindings/idl/events/DocumentEvent.idl:
        * kdom/bindings/idl/events/EventException.idl:
        * kdom/bindings/idl/events/EventTarget.idl:
        * kdom/bindings/idl/ls/DOMImplementationLS.idl: Added.
        * kdom/bindings/idl/ls/LSException.idl: Added.
        * kdom/bindings/idl/ls/LSInput.idl: Added.
        * kdom/bindings/idl/ls/LSOutput.idl: Added.
        * kdom/bindings/idl/ls/LSParser.idl: Added.
        * kdom/bindings/idl/ls/LSParserFilter.idl: Added.
        * kdom/bindings/idl/ls/LSResourceResolver.idl: Added.
        * kdom/bindings/idl/ls/LSSerializer.idl: Added.
        * kdom/bindings/idl/ls/LSSerializerFilter.idl: Added.
        * kdom/bindings/idl/ls/kdomdefs.idl: Added.
        * kdom/bindings/idl/range/Range.idl:
        * kdom/bindings/idl/range/RangeException.idl:
        * kdom/bindings/idl/stylesheets/LinkStyle.idl:
        * kdom/bindings/idl/stylesheets/MediaList.idl:
        * kdom/bindings/idl/traversal/DocumentTraversal.idl:
        * kdom/bindings/idl/traversal/NodeIterator.idl:
        * kdom/bindings/idl/traversal/TreeWalker.idl:
        * kdom/bindings/idl/xpath/XPathEvaluator.idl:
        * kdom/bindings/idl/xpath/XPathException.idl:
        * kdom/bindings/idl/xpath/XPathExpression.idl:
        * kdom/bindings/idl/xpath/XPathNSResolver.idl:
        * kdom/bindings/idl/xpath/XPathNamespace.idl:
        * kdom/bindings/idl/xpath/XPathResult.idl:
        * kdom/bindings/idl/xpointer/XPointerException.idl:
        * kdom/bindings/kdombinder.sh:
        * kdom/bindings/kdomidl.pl:
        * kdom/core/CDFInterface.cpp:
        (CDFInterface::ecmaInterface):
        * kdom/core/CDFInterface.h:
        * kdom/ecma/DOMBridge.h:
        (KDOM::DOMRWBridge::put):
        * kdom/ecma/DOMLookup.h:
        * kdom/ecma/Ecma.cpp:
        (Ecma::Private::Private):
        (Ecma::setup):
        (Ecma::setupDocument):
        (Ecma::interface):
        (Ecma::createEventListener):
        (KDOM::getDOMNode):
        (KDOM::getDOMEvent):
        * kdom/ecma/Ecma.h:
        * kdom/ecma/EcmaInterface.h: Removed.
        * kdom/ecma/GlobalObject.cpp:
        (GlobalObject::get):
        (GlobalObjectFunc::callAsFunction):
        (ScheduledAction::execute):
        (GlobalQObject::parentDestroyed):
        (GlobalQObject::clearTimeout):
        (GlobalQObject::timerEvent):
        * kdom/ecma/GlobalObject.h:
        (KDOM::GlobalObject::):
        * kdom/ecma/ScriptInterpreter.cpp:
        * khtml/khtml_part.cpp:
        (KHTMLPart::begin):
        * khtml/xml/dom_docimpl.cpp:
        (DOMImplementationImpl::createKDOMDocument):
        * khtml/xml/dom_docimpl.h:
        * ksvg2/bindings/idl/svg/GetSVGDocument.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAngle.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimateElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedLength.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedRect.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedString.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl: Added.
        * ksvg2/bindings/idl/svg/SVGAnimationElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGCircleElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGClipPathElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGColor.idl: Added.
        * ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGCursorElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGDOMImplementation.idl: Added.
        * ksvg2/bindings/idl/svg/SVGDefsElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGDescElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGDocument.idl: Added.
        * ksvg2/bindings/idl/svg/SVGElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGElementInstance.idl: Added.
        * ksvg2/bindings/idl/svg/SVGElementInstanceList.idl: Added.
        * ksvg2/bindings/idl/svg/SVGEllipseElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGEvent.idl: Added.
        * ksvg2/bindings/idl/svg/SVGException.idl: Added.
        * ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFEBlendElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFECompositeElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFEFloodElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFEImageElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFEMergeElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFETileElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFilterElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl: Added.
        * ksvg2/bindings/idl/svg/SVGFitToViewBox.idl: Added.
        * ksvg2/bindings/idl/svg/SVGGElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGGradientElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGICCColor.idl: Added.
        * ksvg2/bindings/idl/svg/SVGImageElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGLangSpace.idl: Added.
        * ksvg2/bindings/idl/svg/SVGLength.idl: Added.
        * ksvg2/bindings/idl/svg/SVGLengthList.idl: Added.
        * ksvg2/bindings/idl/svg/SVGLineElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGLocatable.idl: Added.
        * ksvg2/bindings/idl/svg/SVGMarkerElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGMatrix.idl: Added.
        * ksvg2/bindings/idl/svg/SVGNumber.idl: Added.
        * ksvg2/bindings/idl/svg/SVGNumberList.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPaint.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPathElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPathSeg.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPathSegArc.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPathSegLineto.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPathSegList.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPatternElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPoint.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPointList.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPolygonElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPolylineElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl: Added.
        * ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGRect.idl: Added.
        * ksvg2/bindings/idl/svg/SVGRectElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGRenderingIntent.idl: Added.
        * ksvg2/bindings/idl/svg/SVGSVGElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGScriptElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGSetElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGStopElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGStringList.idl: Added.
        * ksvg2/bindings/idl/svg/SVGStylable.idl: Added.
        * ksvg2/bindings/idl/svg/SVGStyleElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGSwitchElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGSymbolElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGTSpanElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGTests.idl: Added.
        * ksvg2/bindings/idl/svg/SVGTextContentElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGTextElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGTitleElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGTransform.idl: Added.
        * ksvg2/bindings/idl/svg/SVGTransformList.idl: Added.
        * ksvg2/bindings/idl/svg/SVGTransformable.idl: Added.
        * ksvg2/bindings/idl/svg/SVGURIReference.idl: Added.
        * ksvg2/bindings/idl/svg/SVGUnitTypes.idl: Added.
        * ksvg2/bindings/idl/svg/SVGUseElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGViewElement.idl: Added.
        * ksvg2/bindings/idl/svg/SVGZoomAndPan.idl: Added.
        * ksvg2/bindings/idl/svg/SVGZoomEvent.idl: Added.
        * ksvg2/bindings/idl/svg/kdomdefs.idl: Added.
        * ksvg2/ecma/EcmaInterface.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 5058
eseidel [Tue, 20 Sep 2005 09:40:06 +0000 (09:40 +0000)]
Bug #: 5058
Submitted by: Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by: eseidel
        * kdom/ecma/Ecma.cpp: ProtectedValue -> ProtectedPtr<ValueImp>
        build fix after mjs' recent ProtectedValue removal.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5058

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 5037
eseidel [Tue, 20 Sep 2005 08:33:06 +0000 (08:33 +0000)]
Bug #: 5037
Submitted by: eseidel
Reviewed by: mjs
Moved MIME type support from a hard coded list
        (in two places) to single lists in the corresponding
        *Representation classes.  Also moved the list of types
        supported by WebCore (WebHTMLRepresentation) into WebCore.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5037

        * WebView.subproj/WebDataSource.m:
        (addTypesFromClass): new inline function
        (+[WebDataSource _repTypesAllowImageTypeOmission:]):
        * WebView.subproj/WebFrameView.m:
        (addTypesFromClass): new inline function
        (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
        * WebView.subproj/WebHTMLRepresentation.h:
        * WebView.subproj/WebHTMLRepresentation.m:
        (+[WebHTMLRepresentation supportedMIMETypes]):
        * WebView.subproj/WebHTMLView.m:
        (+[WebHTMLView supportedMIMETypes]):
        * WebView.subproj/WebHTMLViewPrivate.h:
        * WebView.subproj/WebImageRepresentation.h:
        * WebView.subproj/WebImageRepresentation.m:
        (+[WebImageRepresentation supportedMIMETypes]):
        * WebView.subproj/WebImageView.h:
        * WebView.subproj/WebImageView.m:
        (+[WebImageView supportedMIMETypes]):
        * WebView.subproj/WebPDFRepresentation.h:
        * WebView.subproj/WebPDFRepresentation.m:
        (+[WebPDFRepresentation supportedMIMETypes]):
        * WebView.subproj/WebPDFView.h:
        * WebView.subproj/WebPDFView.m:
        (+[WebPDFView supportedMIMETypes]):
        * WebView.subproj/WebTextRepresentation.h:
        * WebView.subproj/WebTextRepresentation.m:
        (+[WebTextRepresentation supportedMIMETypes]):
        * WebView.subproj/WebTextView.h:
        * WebView.subproj/WebTextView.m:
        (+[WebTextView supportedMIMETypes]):
        * WebView.subproj/WebView.m:
        (+[WebView _viewClass:andRepresentationClass:forMIMEType:]):
        (+[WebView MIMETypesShownAsHTML]): updated to match style
        (+[WebView setMIMETypesShownAsHTML:]): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 5037
eseidel [Tue, 20 Sep 2005 08:31:48 +0000 (08:31 +0000)]
Bug #: 5037
Submitted by: eseidel
Reviewed by: mjs
        Moved MIME types list from WebKit into WebCore.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5037

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (+[WebCoreBridge supportedMIMETypes]): added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Rolled in fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4892
ggaren [Tue, 20 Sep 2005 08:10:35 +0000 (08:10 +0000)]
    - Rolled in fix for bugzilla.opendarwin.org/show_bug.cgi?id=4892
          Date constructor has problems with months larger than 11

        Test cases added:

        * layout-tests/fast/js/date-big-constructor-expected.txt: Added.
        * layout-tests/fast/js/date-big-constructor.html: Added.

        Reviewed by darin.

        * kjs/date_object.cpp:
        (KJS::fillStructuresUsingDateArgs):
        (KJS::makeTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Added test case for fix to http://bugzilla.opendarwin.org/show_bug.cgi...
ggaren [Tue, 20 Sep 2005 08:08:57 +0000 (08:08 +0000)]
    - Added test case for fix to bugzilla.opendarwin.org/show_bug.cgi?id=4892
          Date constructor has problems with months larger than 11

        Test cases added:

        * layout-tests/fast/js/date-big-constructor-expected.txt: Added.
        * layout-tests/fast/js/date-big-constructor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Rolled in fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5053
ggaren [Tue, 20 Sep 2005 08:07:57 +0000 (08:07 +0000)]
    - Rolled in fix for bugzilla.opendarwin.org/show_bug.cgi?id=5053
          Need to restore int/long changes to simple_number.h

        Test cases added:

        * layout-tests/fast/js/date-big-constructor-expected.txt: Added.
        * layout-tests/fast/js/date-big-constructor.html: Added.

        Reviewed by darin.

        * kjs/date_object.cpp:
        (KJS::fillStructuresUsingDateArgs):
        (KJS::makeTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Rolled in fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4247
ggaren [Tue, 20 Sep 2005 07:55:54 +0000 (07:55 +0000)]
    - Rolled in fix for bugzilla.opendarwin.org/show_bug.cgi?id=4247
          addEventListener in Obj-C does not work

        No layout test because we don't have test machinery for the Obj-C bindings yet.

        Reviewed by eric.

        * kwq/DOM.mm:
        (-[DOMNode addEventListener:::]):
        (-[DOMNode removeEventListener:::]):
        (ObjCEventListener::find):
        (ObjCEventListener::create):
        (ObjCEventListener::ObjCEventListener):
        (ObjCEventListener::~ObjCEventListener):
        (ObjCEventListener::handleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Rolled in fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4849
ggaren [Tue, 20 Sep 2005 07:46:54 +0000 (07:46 +0000)]
    - Rolled in fix for bugzilla.opendarwin.org/show_bug.cgi?id=4849
          htmltokenizer.cpp won't compile with TOKEN_DEBUG defined

        No test case because this is a build fix.

        Reviewed by darin.

        * khtml/html/htmltokenizer.cpp:
        (khtml::HTMLTokenizer::parseComment):
        (khtml::HTMLTokenizer::parseTag):
        (khtml::HTMLTokenizer::write):
        (khtml::HTMLTokenizer::processToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 4613
eseidel [Tue, 20 Sep 2005 01:23:12 +0000 (01:23 +0000)]
Bug #: 4613
Submitted by: eseidel
Reviewed by: darin
        * Scripts/run-webkit-tests: added --guard-malloc option
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4613

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=5028
ggaren [Mon, 19 Sep 2005 21:53:22 +0000 (21:53 +0000)]
    - Fixed bugzilla.opendarwin.org/show_bug.cgi?id=5028
          9 layout tests fail following the change from long to int

        - Rolled out changes to simple_number.h, and added fits(long long)
          and SimpleNumber::fits(unsigned long long) to the old system.

        Reviewed by mjs.

        * kjs/simple_number.h:
        (KJS::SimpleNumber::):
        (KJS::SimpleNumber::value):
        (KJS::SimpleNumber::fits):
        (KJS::SimpleNumber::integerFits):
        (KJS::SimpleNumber::make):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #:
bdakin [Mon, 19 Sep 2005 20:54:11 +0000 (20:54 +0000)]
Bug #:
Submitted by:
Reviewed by:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
mjs [Mon, 19 Sep 2005 18:52:13 +0000 (18:52 +0000)]
    Reviewed by Geoff.

- fixed <rdar://problem/4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Make sure to lock using the InterpreterLock class in all places that need it
(including anything that uses the collector, the parser, the protect count hash table,
and anything that allocates via fast_malloc).

Added assertions to ensure that main_thread_malloc and friends are
only called on the main thread.

Also changed main_thread_free to schedule a free on the main
thread if called from a background thread. This contingency is
rare, but unavoidable in the case that JavaScript runs on
background threads, since then objects can be garbage collected on
any thread.

        Test cases added: Node, this is impossible to reproduce in Safari without the use of
PAC files.

        * Makefile.am:
        * khtml/dom/dom_misc.h:
        * khtml/ecma/kjs_events.cpp:
        (JSAbstractEventListener::handleEvent):
        (JSLazyEventListener::parseCode):
        (KJS::getDOMEvent):
        * khtml/ecma/kjs_events.h:
        * khtml/ecma/kjs_proxy.cpp:
        (KJSProxyImpl::~KJSProxyImpl):
        (KJSProxyImpl::evaluate):
        (KJSProxyImpl::clear):
        (KJSProxyImpl::createHTMLEventHandler):
        (KJSProxyImpl::initScript):
        * khtml/ecma/kjs_traversal.cpp:
        (JSNodeFilterCondition::acceptNode):
        * khtml/ecma/kjs_traversal.h:
        * khtml/ecma/kjs_window.cpp:
        (Window::clear):
        (ScheduledAction::execute):
        * khtml/ecma/kjs_window.h:
        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::send):
        (KJS::XMLHttpRequest::abort):
        (KJS::XMLHttpRequest::slotFinished):
        * khtml/misc/main_thread_malloc.cpp:
        (khtml::main_thread_malloc):
        (khtml::main_thread_calloc):
        (khtml::main_thread_free):
        (khtml::main_thread_realloc):
        (khtml::initialize_scheduled_free_list):
        (khtml::drain_scheduled_free_list):
        (khtml::schedule_free_on_main_thread):
        (khtml::public_fREe):
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::bindingRootObject):
        (KWQKHTMLPart::windowScriptObject):
        (KWQKHTMLPart::saveLocationProperties):
        (KWQKHTMLPart::restoreLocationProperties):
        (KWQKHTMLPart::openURLFromPageCache):
        (KWQKHTMLPart::cleanupPluginRootObjects):
        * kwq/KWQPageState.mm:
        (-[KWQPageState clear]):
        * kwq/KWQTimer.h:
        * kwq/KWQTimer.mm:
        (-[KWQMainThreadPerformTarget initWithFunction:]):
        (-[KWQMainThreadPerformTarget callFunction:]):
        (QTimer::immediateSingleShotOnMainThread):
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge saveDocumentToPageCache]):
        * kwq/WebCoreJavaScript.mm:
        (+[WebCoreJavaScript rootObjectClasses]):
        (+[WebCoreJavaScript garbageCollect]):
        * kwq/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame evaluateWebScript:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #:
mjs [Mon, 19 Sep 2005 18:10:38 +0000 (18:10 +0000)]
Bug #:
Submitted by:
Reviewed by:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
mjs [Mon, 19 Sep 2005 06:57:28 +0000 (06:57 +0000)]
    Reviewed by Geoff.

- fixed <rdar://problem/4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)

Make sure to lock using the InterpreterLock class in all places that need it
(including anything that uses the collector, the parser, the protect count hash table,
and anything that allocates via fast_malloc).

Also added assertions to ensure that the locking rules are followed for the relevant
resources.

        * Makefile.am:
        * bindings/NP_jsobject.cpp:
        (identifierFromNPIdentifier):
        (_NPN_Invoke):
        (_NPN_Evaluate):
        (_NPN_GetProperty):
        (_NPN_SetProperty):
        (_NPN_RemoveProperty):
        (_NPN_HasProperty):
        (_NPN_HasMethod):
        (_NPN_SetException):
        * bindings/jni/jni_jsobject.cpp:
        (JSObject::call):
        (JSObject::eval):
        (JSObject::getMember):
        (JSObject::setMember):
        (JSObject::removeMember):
        (JSObject::getSlot):
        (JSObject::setSlot):
        (JSObject::toString):
        (JSObject::convertJObjectToValue):
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (-[WebScriptObject evaluateWebScript:]):
        (-[WebScriptObject setValue:forKey:]):
        (-[WebScriptObject valueForKey:]):
        (-[WebScriptObject removeWebScriptKey:]):
        (-[WebScriptObject stringRepresentation]):
        (-[WebScriptObject webScriptValueAtIndex:]):
        (-[WebScriptObject setWebScriptValueAtIndex:value:]):
        (+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]):
        * bindings/runtime.cpp:
        (Instance::createRuntimeObject):
        * bindings/runtime_root.h:
        * bindings/testbindings.cpp:
        (main):
        * bindings/testbindings.mm:
        (main):
        * kjs/fast_malloc.cpp:
        (KJS::kjs_fast_malloc):
        (KJS::kjs_fast_calloc):
        (KJS::kjs_fast_free):
        (KJS::kjs_fast_realloc):
        * kjs/fast_malloc.h:
        * kjs/identifier.h:
        * kjs/internal.cpp:
        (InterpreterImp::InterpreterImp):
        (InterpreterImp::clear):
        (InterpreterImp::mark):
        (InterpreterImp::checkSyntax):
        (InterpreterImp::evaluate):
        * kjs/internal.h:
        (KJS::InterpreterImp::globalObject):
        * kjs/interpreter.cpp:
        (Interpreter::evaluate):
        * kjs/interpreter.h:
        (KJS::InterpreterLock::InterpreterLock):
        (KJS::InterpreterLock::~InterpreterLock):
        * kjs/nodes.h:
        * kjs/protect.h:
        (KJS::ProtectedValue::ProtectedValue):
        (KJS::ProtectedValue::~ProtectedValue):
        (KJS::ProtectedValue::operator=):
        (KJS::ProtectedObject::ProtectedObject):
        (KJS::ProtectedObject::~ProtectedObject):
        (KJS::ProtectedObject::operator=):
        (KJS::ProtectedReference::ProtectedReference):
        (KJS::ProtectedReference::~ProtectedReference):
        (KJS::ProtectedReference::operator=):
        * kjs/protected_object.h:
        * kjs/protected_values.cpp:
        (KJS::ProtectedValues::getProtectCount):
        (KJS::ProtectedValues::increaseProtectCount):
        (KJS::ProtectedValues::decreaseProtectCount):
        * kjs/string_object.cpp:
        (StringObjectImp::StringObjectImp):
        * kjs/testkjs.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 5045
eseidel [Sun, 18 Sep 2005 21:45:29 +0000 (21:45 +0000)]
Bug #:  5045
Submitted by: eseidel
Reviewed by: none needed, svg build fix only.
        * WebCore+SVG/DrawDocument.mm:
        (-[DrawView primaryView]): cast to DrawView * (newer gcc fix)
        * kdom/cache/KDOMLoader.cpp:
        (Loader::slotFinished): toLong -> toInt
        * ksvg2/svg/SVGAngleImpl.cpp:
        (SVGAngleImpl::setValueAsString): toFloat -> toDouble
        * ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
        (SVGComponentTransferFunctionElementImpl::parseAttribute): ditto
        * ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
        (SVGFEGaussianBlurElementImpl::parseAttribute): ditto
        * ksvg2/svg/SVGFEOffsetElementImpl.cpp:
        (SVGFEOffsetElementImpl::parseAttribute): ditto
        * ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
        (SVGFETurbulenceElementImpl::parseAttribute): ditto
        * ksvg2/svg/SVGFitToViewBoxImpl.cpp:
        (SVGFitToViewBoxImpl::parseViewBox): ditto
        * ksvg2/svg/SVGNumberListImpl.cpp:
        (SVGNumberListImpl::parse): ditto
        * ksvg2/svg/SVGStopElementImpl.cpp:
        (SVGStopElementImpl::parseAttribute): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * WebView.subproj/WebImageView.m:
sullivan [Sat, 17 Sep 2005 00:09:13 +0000 (00:09 +0000)]
    * WebView.subproj/WebImageView.m:
        (-[WebImageView copy:]):
        fixed build-breaking silly error in previous checkin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Omernick
sullivan [Fri, 16 Sep 2005 23:55:21 +0000 (23:55 +0000)]
    Reviewed by Tim Omernick

        - fixed <rdar://problem/4256557> CrashTracer: 238 crashes in Safari at
        com.apple.AppKit: -[NSPasteboard setData:forType:] + 188

        * WebView.subproj/WebImageView.m:
        (-[WebImageView copy:]):
        declare types to pasteboard before starting to set their data
        (-[WebImageView writeSelectionToPasteboard:types:]):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by geoff
justing [Fri, 16 Sep 2005 23:34:16 +0000 (23:34 +0000)]
    Reviewed by geoff

        Removed a script that is only used by apple internal developers

        * Scripts/update-webkitsysteminterface: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
adele [Fri, 16 Sep 2005 23:09:59 +0000 (23:09 +0000)]
WebCore:

        Rolling out the fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4924
            QPainter should use CGContext as much as possible rather than NSGraphicsContext
        since it caused a performance regression.

WebKit:

        Rolling out the fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=4924
            QPainter should use CGContext as much as possible rather than NSGraphicsContext
        since it caused a performance regression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
adele [Fri, 16 Sep 2005 23:04:13 +0000 (23:04 +0000)]
    Reviewed by Maciej.

        * Scripts/prepare-ChangeLog: Allow semicolons for protocols too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
adele [Fri, 16 Sep 2005 22:42:30 +0000 (22:42 +0000)]
JavaScriptCore:

        Change by Darin, reviewed by me and Maciej.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547
        use int instead of long for 32-bit (to prepare for LP64 compiling)

        * bindings/c/c_class.h:
        (KJS::Bindings::CClass::constructorAt):
        (KJS::Bindings::CClass::numConstructors):
        * bindings/c/c_runtime.h:
        (KJS::Bindings::CMethod::numParameters):
        * bindings/jni/jni_class.cpp:
        (JavaClass::JavaClass):
        * bindings/jni/jni_class.h:
        (KJS::Bindings::JavaClass::constructorAt):
        (KJS::Bindings::JavaClass::numConstructors):
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bindings/jni/jni_jsobject.cpp:
        (JSObject::convertJObjectToValue):
        (JSObject::listFromJArray):
        * bindings/jni/jni_runtime.cpp:
        (JavaMethod::JavaMethod):
        * bindings/jni/jni_runtime.h:
        (KJS::Bindings::JavaConstructor::_commonCopy):
        (KJS::Bindings::JavaConstructor::parameterAt):
        (KJS::Bindings::JavaConstructor::numParameters):
        (KJS::Bindings::JavaMethod::_commonCopy):
        (KJS::Bindings::JavaMethod::parameterAt):
        (KJS::Bindings::JavaMethod::numParameters):
        * bindings/npapi.h:
        * bindings/objc/WebScriptObject.mm:
        (listFromNSArray):
        * bindings/objc/objc_class.h:
        (KJS::Bindings::ObjcClass::constructorAt):
        (KJS::Bindings::ObjcClass::numConstructors):
        * bindings/objc/objc_instance.h:
        * bindings/objc/objc_runtime.h:
        * bindings/objc/objc_runtime.mm:
        (ObjcMethod::numParameters):
        * bindings/runtime.h:
        * kjs/identifier.h:
        * kjs/internal.h:
        * kjs/property_slot.h:
        (KJS::PropertySlot::setCustomIndex):
        (KJS::PropertySlot::index):
        (KJS::PropertySlot::):
        * kjs/regexp_object.cpp:
        (RegExpObjectImp::backrefGetter):
        (RegExpObjectImp::getOwnPropertySlot):
        * kjs/simple_number.h:
        (KJS::SimpleNumber::):
        (KJS::SimpleNumber::value):
        (KJS::SimpleNumber::fits):
        (KJS::SimpleNumber::integerFits):
        (KJS::SimpleNumber::make):
        * kjs/string_object.cpp:
        (substituteBackreferences):
        * kjs/ustring.cpp:
        (KJS::UString::from):
        (KJS::UString::toUInt32):
        (KJS::UString::find):
        (KJS::UString::rfind):
        * kjs/ustring.h:
        * kjs/value.cpp:
        (KJS::jsNumber):
        * kjs/value.h:

WebCore:

        Change by Darin, reviewed by me and Maciej.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547
        use int instead of long for 32-bit (to prepare for LP64 compiling)

        Changed longs (which IDL files use as 32-bit) to ints

        * ForwardingHeaders/khtml_pagecache.h:
        * khtml/css/css_base.h:
        (DOM::StyleListImpl::length):
        (DOM::StyleListImpl::item):
        * khtml/css/css_computedstyle.cpp:
        (DOM::CSSComputedStyleDeclarationImpl::length):
        (DOM::CSSComputedStyleDeclarationImpl::item):
        * khtml/css/css_computedstyle.h:
        * khtml/css/css_ruleimpl.cpp:
        (CSSMediaRuleImpl::append):
        (CSSMediaRuleImpl::insertRule):
        (CSSMediaRuleImpl::cssText):
        (CSSRuleListImpl::CSSRuleListImpl):
        (CSSRuleListImpl::deleteRule):
        (CSSRuleListImpl::insertRule):
        * khtml/css/css_ruleimpl.h:
        (DOM::CSSRuleListImpl::length):
        (DOM::CSSRuleListImpl::item):
        (DOM::CSSMediaRuleImpl::deleteRule):
        * khtml/css/css_stylesheetimpl.cpp:
        (CSSStyleSheetImpl::insertRule):
        (CSSStyleSheetImpl::addRule):
        (CSSStyleSheetImpl::deleteRule):
        (StyleSheetListImpl::length):
        (StyleSheetListImpl::item):
        * khtml/css/css_stylesheetimpl.h:
        (DOM::MediaListImpl::length):
        (DOM::MediaListImpl::item):
        * khtml/css/css_valueimpl.cpp:
        (DOM::CSSMutableStyleDeclarationImpl::length):
        (DOM::CSSMutableStyleDeclarationImpl::item):
        * khtml/css/css_valueimpl.h:
        (DOM::CSSValueListImpl::length):
        (DOM::CSSValueListImpl::item):
        * khtml/dom/css_rule.h:
        * khtml/dom/css_stylesheet.h:
        * khtml/dom/css_value.h:
        * khtml/dom/dom2_events.cpp:
        (DOM::UIEvent::detail):
        (DOM::UIEvent::initUIEvent):
        (DOM::MouseEvent::screenX):
        (DOM::MouseEvent::screenY):
        (DOM::MouseEvent::clientX):
        (DOM::MouseEvent::clientY):
        (DOM::MouseEvent::initMouseEvent):
        (DOM::KeyboardEvent::keyLocation):
        (DOM::KeyboardEvent::initKeyboardEvent):
        * khtml/dom/dom2_events.h:
        * khtml/dom/dom2_range.h:
        * khtml/dom/dom2_traversal.cpp:
        (DOM::NodeIterator::whatToShow):
        (DOM::TreeWalker::whatToShow):
        * khtml/dom/dom2_traversal.h:
        * khtml/dom/dom_node.h:
        * khtml/ecma/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclaration::getOwnPropertySlot):
        (KJS::DOMStyleSheetList::getOwnPropertySlot):
        (KJS::DOMMediaList::getOwnPropertySlot):
        (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction):
        (KJS::DOMCSSRuleList::getOwnPropertySlot):
        (KJS::DOMCSSValueList::getOwnPropertySlot):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNodeList::getOwnPropertySlot):
        (KJS::DOMNodeList::callAsFunction):
        (KJS::DOMNamedNodeMap::getOwnPropertySlot):
        (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
        * khtml/ecma/kjs_events.cpp:
        (KJS::DOMEvent::getValueProperty):
        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLElement::getOwnPropertySlot):
        (KJS::KJS::HTMLElement::put):
        (KJS::HTMLCollection::getOwnPropertySlot):
        (KJS::KJS::HTMLCollection::callAsFunction):
        (KJS::KJS::HTMLSelectCollection::put):
        * khtml/ecma/kjs_navigator.cpp:
        (KJS::Plugins::getOwnPropertySlot):
        (KJS::MimeTypes::getOwnPropertySlot):
        (KJS::Plugin::getOwnPropertySlot):
        * khtml/editing/apply_style_command.cpp:
        (khtml::ApplyStyleCommand::splitTextAtStartIfNeeded):
        (khtml::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
        (khtml::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
        * khtml/editing/break_blockquote_command.cpp:
        (khtml::BreakBlockquoteCommand::doApply):
        * khtml/editing/composite_edit_command.cpp:
        (khtml::CompositeEditCommand::insertNodeAt):
        (khtml::CompositeEditCommand::splitTextNode):
        (khtml::CompositeEditCommand::splitTextNodeContainingElement):
        (khtml::CompositeEditCommand::insertTextIntoNode):
        (khtml::CompositeEditCommand::deleteTextFromNode):
        (khtml::CompositeEditCommand::replaceTextInNode):
        (khtml::CompositeEditCommand::deleteInsignificantText):
        * khtml/editing/composite_edit_command.h:
        * khtml/editing/delete_from_text_node_command.cpp:
        (khtml::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
        * khtml/editing/delete_from_text_node_command.h:
        (khtml::DeleteFromTextNodeCommand::offset):
        (khtml::DeleteFromTextNodeCommand::count):
        * khtml/editing/insert_into_text_node_command.cpp:
        (khtml::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
        * khtml/editing/insert_into_text_node_command.h:
        (khtml::InsertIntoTextNodeCommand::offset):
        * khtml/editing/insert_paragraph_separator_command.cpp:
        (khtml::InsertParagraphSeparatorCommand::doApply):
        * khtml/editing/insert_text_command.cpp:
        (khtml::InsertTextCommand::input):
        (khtml::InsertTextCommand::insertSpace):
        * khtml/editing/insert_text_command.h:
        (khtml::InsertTextCommand::charactersAdded):
        * khtml/editing/join_text_nodes_command.h:
        * khtml/editing/markup.cpp:
        (khtml::startMarkup):
        (khtml::completeURLs):
        * khtml/editing/move_selection_command.cpp:
        (khtml::MoveSelectionCommand::doApply):
        * khtml/editing/rebalance_whitespace_command.cpp:
        (khtml::RebalanceWhitespaceCommand::doApply):
        * khtml/editing/rebalance_whitespace_command.h:
        * khtml/editing/replace_selection_command.cpp:
        (khtml::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted):
        * khtml/editing/replace_selection_command.h:
        * khtml/editing/selection.cpp:
        (khtml::Selection::debugPosition):
        * khtml/editing/split_text_node_command.cpp:
        (khtml::SplitTextNodeCommand::SplitTextNodeCommand):
        * khtml/editing/split_text_node_command.h:
        (khtml::SplitTextNodeCommand::offset):
        * khtml/editing/split_text_node_containing_element.cpp:
        (khtml::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
        * khtml/editing/split_text_node_containing_element_command.h:
        * khtml/editing/visible_position.cpp:
        (khtml::VisiblePosition::VisiblePosition):
        (khtml::VisiblePosition::deepEquivalent):
        (khtml::VisiblePosition::rangeCompliantEquivalent):
        (khtml::VisiblePosition::maxOffset):
        (khtml::VisiblePosition::character):
        (khtml::VisiblePosition::debugPosition):
        * khtml/editing/visible_position.h:
        * khtml/editing/visible_range.h:
        * khtml/editing/visible_text.cpp:
        (khtml::CircularSearchBuffer::length):
        (khtml::TextIterator::TextIterator):
        (khtml::TextIterator::handleTextNode):
        (khtml::TextIterator::handleTextBox):
        (khtml::TextIterator::emitCharacter):
        (khtml::TextIterator::range):
        (khtml::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
        (khtml::SimplifiedBackwardsTextIterator::handleReplacedElement):
        (khtml::SimplifiedBackwardsTextIterator::emitCharacter):
        (khtml::SimplifiedBackwardsTextIterator::emitNewlineForBROrText):
        (khtml::CharacterIterator::range):
        (khtml::CharacterIterator::advance):
        (khtml::CharacterIterator::string):
        (khtml::WordAwareIterator::length):
        (khtml::CircularSearchBuffer::append):
        (khtml::CircularSearchBuffer::neededCharacters):
        (khtml::CircularSearchBuffer::isMatch):
        (khtml::TextIterator::rangeLength):
        (khtml::TextIterator::rangeFromLocationAndLength):
        (khtml::plainText):
        (khtml::findPlainText):
        * khtml/editing/visible_text.h:
        (khtml::TextIterator::length):
        (khtml::SimplifiedBackwardsTextIterator::length):
        (khtml::CharacterIterator::length):
        (khtml::CharacterIterator::characterOffset):
        * khtml/editing/visible_units.cpp:
        (khtml::startOfLine):
        (khtml::endOfLine):
        (khtml::startOfParagraph):
        (khtml::endOfParagraph):
        * khtml/html/html_blockimpl.cpp:
        (HTMLPreElementImpl::width):
        (HTMLPreElementImpl::setWidth):
        * khtml/html/html_blockimpl.h:
        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLFormElementImpl::length):
        (DOM::HTMLGenericFormElementImpl::tabIndex):
        (DOM::HTMLGenericFormElementImpl::setTabIndex):
        (DOM::HTMLInputElementImpl::selectionStart):
        (DOM::HTMLInputElementImpl::selectionEnd):
        (DOM::HTMLInputElementImpl::setSelectionStart):
        (DOM::HTMLInputElementImpl::setSelectionEnd):
        (DOM::HTMLInputElementImpl::setSelectionRange):
        (DOM::HTMLInputElementImpl::setMaxLength):
        (DOM::HTMLInputElementImpl::setSize):
        (DOM::HTMLSelectElementImpl::selectedIndex):
        (DOM::HTMLSelectElementImpl::setSelectedIndex):
        (DOM::HTMLSelectElementImpl::length):
        (DOM::HTMLSelectElementImpl::remove):
        (DOM::HTMLSelectElementImpl::setSize):
        (DOM::HTMLOptionElementImpl::index):
        (DOM::HTMLOptionElementImpl::setIndex):
        (DOM::HTMLTextAreaElementImpl::selectionStart):
        (DOM::HTMLTextAreaElementImpl::selectionEnd):
        (DOM::HTMLTextAreaElementImpl::setSelectionStart):
        (DOM::HTMLTextAreaElementImpl::setSelectionEnd):
        (DOM::HTMLTextAreaElementImpl::setSelectionRange):
        (DOM::HTMLTextAreaElementImpl::setCols):
        (DOM::HTMLTextAreaElementImpl::setRows):
        (DOM::HTMLOptionsCollectionImpl::length):
        (DOM::HTMLOptionsCollectionImpl::setLength):
        (DOM::HTMLOptionsCollectionImpl::item):
        * khtml/html/html_formimpl.h:
        (DOM::HTMLInputElementImpl::maxLength):
        (DOM::HTMLInputElementImpl::maxResults):
        (DOM::HTMLSelectElementImpl::minWidth):
        (DOM::HTMLSelectElementImpl::size):
        (DOM::HTMLTextAreaElementImpl::cols):
        (DOM::HTMLTextAreaElementImpl::rows):
        * khtml/html/html_imageimpl.cpp:
        (HTMLImageElementImpl::width):
        (HTMLImageElementImpl::height):
        (HTMLImageElementImpl::border):
        (HTMLImageElementImpl::setBorder):
        (HTMLImageElementImpl::setHeight):
        (HTMLImageElementImpl::hspace):
        (HTMLImageElementImpl::setHspace):
        (HTMLImageElementImpl::vspace):
        (HTMLImageElementImpl::setVspace):
        (HTMLImageElementImpl::setWidth):
        (HTMLImageElementImpl::x):
        (HTMLImageElementImpl::y):
        (HTMLAreaElementImpl::tabIndex):
        (HTMLAreaElementImpl::setTabIndex):
        * khtml/html/html_imageimpl.h:
        * khtml/html/html_inlineimpl.cpp:
        (DOM::HTMLAnchorElementImpl::tabIndex):
        (DOM::HTMLAnchorElementImpl::setTabIndex):
        * khtml/html/html_inlineimpl.h:
        * khtml/html/html_listimpl.cpp:
        (DOM::HTMLOListElementImpl::setStart):
        (DOM::HTMLLIElementImpl::value):
        (DOM::HTMLLIElementImpl::setValue):
        * khtml/html/html_listimpl.h:
        (DOM::HTMLUListElementImpl::start):
        (DOM::HTMLOListElementImpl::start):
        * khtml/html/html_miscimpl.cpp:
        (DOM::HTMLCollectionImpl::calcLength):
        (DOM::HTMLCollectionImpl::length):
        (DOM::HTMLCollectionImpl::item):
        (DOM::HTMLFormCollectionImpl::calcLength):
        (DOM::HTMLFormCollectionImpl::item):
        * khtml/html/html_miscimpl.h:
        * khtml/html/html_objectimpl.cpp:
        (DOM::HTMLObjectElementImpl::tabIndex):
        (DOM::HTMLObjectElementImpl::setTabIndex):
        * khtml/html/html_objectimpl.h:
        * khtml/html/html_tableimpl.cpp:
        (DOM::HTMLTableElementImpl::insertRow):
        (DOM::HTMLTableElementImpl::deleteRow):
        (DOM::HTMLTableSectionElementImpl::insertRow):
        (DOM::HTMLTableSectionElementImpl::deleteRow):
        (DOM::HTMLTableRowElementImpl::rowIndex):
        (DOM::HTMLTableRowElementImpl::sectionRowIndex):
        (DOM::HTMLTableRowElementImpl::insertCell):
        (DOM::HTMLTableRowElementImpl::deleteCell):
        (DOM::HTMLTableCellElementImpl::cellIndex):
        (DOM::HTMLTableCellElementImpl::setColSpan):
        (DOM::HTMLTableCellElementImpl::setRowSpan):
        (DOM::HTMLTableColElementImpl::setSpan):
        * khtml/html/html_tableimpl.h:
        (DOM::HTMLTableColElementImpl::span):
        * khtml/html/htmlparser.cpp:
        (HTMLParser::handleError):
        * khtml/html/htmltokenizer.cpp:
        (khtml::HTMLTokenizer::processToken):
        * khtml/khtml_events.cpp:
        (khtml::MouseEvent::offset):
        * khtml/khtml_events.h:
        (khtml::MouseReleaseEvent::MouseReleaseEvent):
        * khtml/khtml_part.cpp:
        (KHTMLPart::restoreURL):
        (KHTMLPart::stopLoading):
        (KHTMLPart::receivedFirstData):
        (KHTMLPart::slotFinished):
        (KHTMLPart::begin):
        (KHTMLPart::slotViewFrameSource):
        (KHTMLPart::selectFrameElementInParentIfFullySelected):
        * khtml/khtml_part.h:
        * khtml/khtmlpart_p.h:
        (KHTMLPartPrivate::KHTMLPartPrivate):
        * khtml/misc/loader.h:
        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::positionForRenderer):
        * khtml/rendering/render_br.cpp:
        (RenderBR::caretMinOffset):
        (RenderBR::caretMaxOffset):
        (RenderBR::caretMaxRenderedOffset):
        (RenderBR::inlineBox):
        * khtml/rendering/render_br.h:
        * khtml/rendering/render_form.cpp:
        (RenderLineEdit::selectionStart):
        (RenderLineEdit::selectionEnd):
        (RenderLineEdit::setSelectionStart):
        (RenderLineEdit::setSelectionEnd):
        (RenderLineEdit::setSelectionRange):
        (RenderTextArea::calcMinMaxWidth):
        (RenderTextArea::selectionStart):
        (RenderTextArea::selectionEnd):
        (RenderTextArea::setSelectionStart):
        (RenderTextArea::setSelectionEnd):
        (RenderTextArea::setSelectionRange):
        * khtml/rendering/render_form.h:
        * khtml/rendering/render_frames.cpp:
        (RenderPartObject::updateWidget):
        * khtml/rendering/render_line.cpp:
        (khtml::InlineBox::caretMinOffset):
        (khtml::InlineBox::caretMaxOffset):
        (khtml::InlineBox::caretMaxRenderedOffset):
        * khtml/rendering/render_line.h:
        * khtml/rendering/render_list.cpp:
        (RenderListMarker::calcMinMaxWidth):
        * khtml/rendering/render_list.h:
        (khtml::RenderListItem::value):
        (khtml::RenderListItem::setValue):
        * khtml/rendering/render_object.cpp:
        (RenderObject::caretMinOffset):
        (RenderObject::caretMaxOffset):
        (RenderObject::caretMaxRenderedOffset):
        (RenderObject::previousOffset):
        (RenderObject::nextOffset):
        (RenderObject::inlineBox):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_replaced.cpp:
        (RenderReplaced::caretMinOffset):
        (RenderReplaced::caretMaxOffset):
        (RenderReplaced::caretMaxRenderedOffset):
        * khtml/rendering/render_replaced.h:
        * khtml/rendering/render_table.h:
        (khtml::RenderTableCell::cellIndex):
        (khtml::RenderTableCell::setCellIndex):
        * khtml/rendering/render_text.cpp:
        (InlineTextBox::paintMarker):
        (InlineTextBox::paintMarkedTextUnderline):
        (InlineTextBox::caretMinOffset):
        (InlineTextBox::caretMaxOffset):
        (InlineTextBox::caretMaxRenderedOffset):
        (RenderText::previousOffset):
        (RenderText::nextOffset):
        (InlineTextBox::positionForOffset):
        (RenderText::caretMinOffset):
        (RenderText::caretMaxOffset):
        (RenderText::caretMaxRenderedOffset):
        (RenderText::inlineBox):
        * khtml/rendering/render_text.h:
        * khtml/xml/dom2_eventsimpl.cpp:
        (DOM::EventImpl::timeStamp):
        (DOM::UIEventImpl::UIEventImpl):
        (DOM::UIEventImpl::initUIEvent):
        (DOM::UIEventImpl::layerX):
        (DOM::UIEventImpl::layerY):
        (DOM::UIEventImpl::pageX):
        (DOM::UIEventImpl::pageY):
        (DOM::UIEventImpl::which):
        (DOM::MouseRelatedEventImpl::MouseRelatedEventImpl):
        (DOM::MouseRelatedEventImpl::pageX):
        (DOM::MouseRelatedEventImpl::pageY):
        (DOM::MouseEventImpl::MouseEventImpl):
        (DOM::MouseEventImpl::initMouseEvent):
        (DOM::MouseEventImpl::which):
        (DOM::KeyboardEventImpl::KeyboardEventImpl):
        (DOM::KeyboardEventImpl::initKeyboardEvent):
        (DOM::KeyboardEventImpl::which):
        (DOM::WheelEventImpl::WheelEventImpl):
        * khtml/xml/dom2_eventsimpl.h:
        (DOM::UIEventImpl::detail):
        (DOM::UIEventWithKeyStateImpl::UIEventWithKeyStateImpl):
        (DOM::MouseRelatedEventImpl::screenX):
        (DOM::MouseRelatedEventImpl::screenY):
        (DOM::MouseRelatedEventImpl::clientX):
        (DOM::MouseRelatedEventImpl::clientY):
        (DOM::MouseRelatedEventImpl::layerX):
        (DOM::MouseRelatedEventImpl::layerY):
        (DOM::KeyboardEventImpl::keyLocation):
        (DOM::WheelEventImpl::wheelDelta):
        * khtml/xml/dom2_rangeimpl.cpp:
        (DOM::RangeImpl::RangeImpl):
        (DOM::RangeImpl::startOffset):
        (DOM::RangeImpl::endOffset):
        (DOM::RangeImpl::setStart):
        (DOM::RangeImpl::setEnd):
        (DOM::RangeImpl::compareBoundaryPoints):
        (DOM::RangeImpl::processContents):
        (DOM::RangeImpl::checkNodeWOffset):
        * khtml/xml/dom2_rangeimpl.h:
        * khtml/xml/dom2_traversalimpl.cpp:
        (DOM::TraversalImpl::TraversalImpl):
        (DOM::TreeWalkerImpl::TreeWalkerImpl):
        * khtml/xml/dom2_traversalimpl.h:
        (DOM::TraversalImpl::whatToShow):
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::createNodeIterator):
        (DocumentImpl::createTreeWalker):
        (DocumentImpl::processHttpEquiv):
        (DocumentImpl::removeMarkers):
        (DocumentImpl::copyMarkers):
        (DocumentImpl::markersForNode):
        (DocumentImpl::shiftMarkers):
        * khtml/xml/dom_docimpl.h:
        * khtml/xml/dom_elementimpl.cpp:
        (ElementImpl::openTagStartToString):
        (NamedAttrMapImpl::item):
        (NamedAttrMapImpl::getAttributeItem):
        (NamedAttrMapImpl::removeAttribute):
        * khtml/xml/dom_elementimpl.h:
        (DOM::NamedAttrMapImpl::length):
        (DOM::NamedAttrMapImpl::attributeItem):
        (DOM::NamedMappedAttrMapImpl::attributeItem):
        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::NodeImpl::normalize):
        (DOM::NodeImpl::nodeIndex):
        (DOM::NodeImpl::childNodeCount):
        (DOM::NodeImpl::childNode):
        (DOM::NodeImpl::maxOffset):
        (DOM::NodeImpl::maxDeepOffset):
        (DOM::NodeImpl::caretMinOffset):
        (DOM::NodeImpl::caretMaxOffset):
        (DOM::NodeImpl::caretMaxRenderedOffset):
        (DOM::NodeImpl::previousOffset):
        (DOM::NodeImpl::nextOffset):
        (DOM::ContainerNodeImpl::childNodeCount):
        (DOM::ContainerNodeImpl::childNode):
        (DOM::NodeListImpl::recursiveLength):
        (DOM::NodeListImpl::recursiveItem):
        (DOM::NodeListImpl::itemById):
        (DOM::ChildNodeListImpl::length):
        (DOM::ChildNodeListImpl::item):
        (DOM::TagNodeListImpl::length):
        (DOM::TagNodeListImpl::item):
        (DOM::NameNodeListImpl::length):
        (DOM::NameNodeListImpl::item):
        * khtml/xml/dom_nodeimpl.h:
        * khtml/xml/dom_position.cpp:
        (DOM::Position::Position):
        (DOM::Position::previous):
        (DOM::Position::next):
        (DOM::Position::renderedOffset):
        (DOM::Position::equivalentRangeCompliantPosition):
        (DOM::Position::rendersInDifferentPosition):
        (DOM::Position::trailingWhitespacePosition):
        (DOM::Position::debugPosition):
        * khtml/xml/dom_position.h:
        (DOM::Position::offset):
        * khtml/xml/dom_textimpl.cpp:
        (CharacterDataImpl::length):
        (CharacterDataImpl::substringData):
        (CharacterDataImpl::insertData):
        (CharacterDataImpl::deleteData):
        (CharacterDataImpl::replaceData):
        (CharacterDataImpl::checkCharDataOperation):
        (CharacterDataImpl::maxOffset):
        (CharacterDataImpl::caretMinOffset):
        (CharacterDataImpl::caretMaxOffset):
        (CharacterDataImpl::caretMaxRenderedOffset):
        (TextImpl::splitText):
        * khtml/xml/dom_textimpl.h:
        * kwq/DOM-CSS.mm:
        (-[DOMStyleSheetList length]):
        (-[DOMStyleSheetList item:]):
        (-[DOMCSSStyleSheet insertRule::]):
        (-[DOMCSSStyleSheet deleteRule:]):
        (-[DOMMediaList length]):
        (-[DOMMediaList item:]):
        (-[DOMCSSRuleList length]):
        (-[DOMCSSRuleList item:]):
        (-[DOMCSSMediaRule insertRule::]):
        (-[DOMCSSMediaRule deleteRule:]):
        (-[DOMCSSStyleDeclaration length]):
        (-[DOMCSSStyleDeclaration item:]):
        (-[DOMCSSValueList length]):
        (-[DOMCSSValueList item:]):
        * kwq/DOM.mm:
        (-[DOMNamedNodeMap item:]):
        (-[DOMNamedNodeMap length]):
        (-[DOMNodeList item:]):
        (-[DOMNodeList length]):
        (-[DOMCharacterData length]):
        (-[DOMCharacterData substringData::]):
        (-[DOMCharacterData insertData::]):
        (-[DOMCharacterData deleteData::]):
        (-[DOMCharacterData replaceData:::]):
        (-[DOMText splitText:]):
        (-[DOMRange description]):
        (-[DOMRange startOffset]):
        (-[DOMRange endOffset]):
        (-[DOMRange setStart::]):
        (-[DOMRange setEnd::]):
        (-[DOMNodeIterator whatToShow]):
        (-[DOMTreeWalker whatToShow]):
        (-[DOMDocument createNodeIterator::::]):
        (-[DOMDocument createTreeWalker::::]):
        * kwq/DOMCSS.h:
        * kwq/DOMCore.h:
        * kwq/DOMEvents.h:
        (-[DOMMouseEvent initMouseEvent:::::::::::::::]):
        * kwq/DOMEvents.mm:
        (-[DOMMouseEvent screenX]):
        (-[DOMMouseEvent screenY]):
        (-[DOMMouseEvent clientX]):
        (-[DOMMouseEvent clientY]):
        (-[DOMMouseEvent initMouseEvent:::::::::::::::]):
        (-[DOMUIEvent detail]):
        (-[DOMUIEvent initUIEvent:::::]):
        * kwq/DOMExtensions.h:
        * kwq/DOMHTML.h:
        * kwq/DOMHTML.mm:
        (-[DOMHTMLCollection length]):
        (-[DOMHTMLCollection item:]):
        (-[DOMHTMLOptionsCollection length]):
        (-[DOMHTMLOptionsCollection setLength:]):
        (-[DOMHTMLOptionsCollection item:]):
        (-[DOMHTMLFormElement length]):
        (-[DOMHTMLSelectElement selectedIndex]):
        (-[DOMHTMLSelectElement setSelectedIndex:]):
        (-[DOMHTMLSelectElement length]):
        (-[DOMHTMLSelectElement setLength:]):
        (-[DOMHTMLSelectElement size]):
        (-[DOMHTMLSelectElement setSize:]):
        (-[DOMHTMLSelectElement tabIndex]):
        (-[DOMHTMLSelectElement setTabIndex:]):
        (-[DOMHTMLSelectElement remove:]):
        (-[DOMHTMLOptionElement index]):
        (-[DOMHTMLInputElement maxLength]):
        (-[DOMHTMLInputElement setMaxLength:]):
        (-[DOMHTMLInputElement size]):
        (-[DOMHTMLInputElement setSize:]):
        (-[DOMHTMLInputElement tabIndex]):
        (-[DOMHTMLInputElement setTabIndex:]):
        (-[DOMHTMLTextAreaElement cols]):
        (-[DOMHTMLTextAreaElement setCols:]):
        (-[DOMHTMLTextAreaElement rows]):
        (-[DOMHTMLTextAreaElement setRows:]):
        (-[DOMHTMLTextAreaElement tabIndex]):
        (-[DOMHTMLTextAreaElement setTabIndex:]):
        (-[DOMHTMLButtonElement tabIndex]):
        (-[DOMHTMLButtonElement setTabIndex:]):
        (-[DOMHTMLOListElement start]):
        (-[DOMHTMLOListElement setStart:]):
        (-[DOMHTMLLIElement value]):
        (-[DOMHTMLLIElement setValue:]):
        (-[DOMHTMLPreElement width]):
        (-[DOMHTMLPreElement setWidth:]):
        (-[DOMHTMLAnchorElement tabIndex]):
        (-[DOMHTMLAnchorElement setTabIndex:]):
        (-[DOMHTMLImageElement height]):
        (-[DOMHTMLImageElement setHeight:]):
        (-[DOMHTMLImageElement hspace]):
        (-[DOMHTMLImageElement setHspace:]):
        (-[DOMHTMLImageElement vspace]):
        (-[DOMHTMLImageElement setVspace:]):
        (-[DOMHTMLImageElement width]):
        (-[DOMHTMLImageElement setWidth:]):
        (-[DOMHTMLObjectElement hspace]):
        (-[DOMHTMLObjectElement setHspace:]):
        (-[DOMHTMLObjectElement tabIndex]):
        (-[DOMHTMLObjectElement setTabIndex:]):
        (-[DOMHTMLObjectElement vspace]):
        (-[DOMHTMLObjectElement setVspace:]):
        (-[DOMHTMLAppletElement hspace]):
        (-[DOMHTMLAppletElement setHspace:]):
        (-[DOMHTMLAppletElement vspace]):
        (-[DOMHTMLAppletElement setVspace:]):
        (-[DOMHTMLAreaElement tabIndex]):
        (-[DOMHTMLAreaElement setTabIndex:]):
        (-[DOMHTMLTableSectionElement insertRow:]):
        (-[DOMHTMLTableSectionElement deleteRow:]):
        (-[DOMHTMLTableElement insertRow:]):
        (-[DOMHTMLTableElement deleteRow:]):
        (-[DOMHTMLTableColElement span]):
        (-[DOMHTMLTableColElement setSpan:]):
        (-[DOMHTMLTableRowElement rowIndex]):
        (-[DOMHTMLTableRowElement sectionRowIndex]):
        (-[DOMHTMLTableRowElement insertCell:]):
        (-[DOMHTMLTableRowElement deleteCell:]):
        (-[DOMHTMLTableCellElement cellIndex]):
        (-[DOMHTMLTableCellElement colSpan]):
        (-[DOMHTMLTableCellElement setColSpan:]):
        (-[DOMHTMLTableCellElement rowSpan]):
        (-[DOMHTMLTableCellElement setRowSpan:]):
        (-[DOMHTMLEmbedElement height]):
        (-[DOMHTMLEmbedElement setHeight:]):
        (-[DOMHTMLEmbedElement width]):
        (-[DOMHTMLEmbedElement setWidth:]):
        * kwq/DOMRange.h:
        * kwq/DOMStylesheets.h:
        * kwq/DOMTraversal.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::advanceToNextMisspelling):
        (KWQKHTMLPart::openURLFromPageCache):
        (KWQKHTMLPart::markMisspellings):
        * kwq/KWQString.h:
        * kwq/KWQString.mm:
        (QString::toShort):
        (QString::toUShort):
        (QString::toInt):
        (QString::toUInt):
        * kwq/KWQTextEdit.h:
        * kwq/KWQTextEdit.mm:
        (QTextEdit::selectionStart):
        (QTextEdit::selectionEnd):
        (QTextEdit::setSelectionStart):
        (QTextEdit::setSelectionEnd):
        (QTextEdit::setSelectionRange):
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge convertToNSRange:DOM::]):

WebKit:

        Change by Darin, reviewed by me and Maciej.

        Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=4547
        use int instead of long for 32-bit (to prepare for LP64 compiling)

        * Plugins.subproj/npapi.m: changed types to match those defined in npapi.h
        (NPN_MemAlloc):
        (NPN_MemFlush):
        (NPN_PostURLNotify):
        (NPN_PostURL):
        (NPN_Write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Dave Hyatt. Test case reviewed by Vicki Murley.
tomernic [Fri, 16 Sep 2005 18:55:10 +0000 (18:55 +0000)]
    Reviewed by Dave Hyatt.  Test case reviewed by Vicki Murley.

<rdar://problem/3572507> Flash in div with display:none style will not redraw when style changed to display:block (3479)

        Test cases added:
        * manual-tests/show-hide-object.html: Added.
        * manual-tests/resources/spinbox.swf: Added.

        * khtml/html/html_objectimpl.cpp:
        (DOM::HTMLObjectElementImpl::detach):
Set needWidgetUpdate to true so that the widget is updated on the next attach().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 4907
eseidel [Fri, 16 Sep 2005 06:36:18 +0000 (06:36 +0000)]
Bug #: 4907
Submitted by: eseidel
Reviewed by: mjs
        * khtml/xml/dom_textimpl.cpp:
        (TextImpl::rendererIsNeeded):
        One line change to prevent adding text objects as direct
        children to FrameSet objects in the render tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Dave Hyatt.
harrison [Thu, 15 Sep 2005 23:50:19 +0000 (23:50 +0000)]
    Reviewed by Dave Hyatt.

        <rdar://problem/4244976> reproducible hang at ocharleys.com in VisiblePosition::initDownstream

        Problem is that RenderText::nextOffset() passes an empty string the UBreakIterator, which returns
        UBRK_DONE (-1) from ubrk_following, and that -1 is used without question as return result of
        nextOffset().  Fixed by checking for UBRK_DONE and returning offset+1 in that case.  Similar
        change in RenderText::previousOffset().

        Test cases added:
        * layout-tests/editing/selection/extend-by-word-002-expected.checksum: Added.
        * layout-tests/editing/selection/extend-by-word-002-expected.png: Added.
        * layout-tests/editing/selection/extend-by-word-002-expected.txt: Added.
        * layout-tests/editing/selection/extend-by-word-002.html: Added.

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::updateFirstLetter):
        Added comments.  Slight format adjustments.

        * khtml/rendering/render_text.cpp:
        (getCharacterBreakIterator):
        Slight format adjustment.

        (RenderText::previousOffset):
        (RenderText::nextOffset):
        Check for UBRK_DONE.

        (RenderTextFragment::RenderTextFragment)
        (RenderTextFragment::RenderTextFragment)
        Fixed parameter names.

        (m_generatedContentStr):
        * khtml/rendering/render_text.h:
        Fixed parameter names in the two RenderTextFragment constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed, tweaked, and landed by Darin.
darin [Thu, 15 Sep 2005 05:22:57 +0000 (05:22 +0000)]
    Reviewed, tweaked, and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3809
          Should default to UTF-8 or UTF-16 for application/xml documents with omitted charset and encoding declaration

        Test cases added:
        * layout-tests/fast/encoding/xml-utf-8-default.xml: Added.
        * layout-tests/fast/encoding/xml-utf-8-default-expected.txt: Added.

        * khtml/misc/decoder.cpp: (Decoder::decode): Always set encoding when we see an XML header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * layout-tests/fast/dom/set-innerHTML-expected.txt: Updated test result now...
darin [Thu, 15 Sep 2005 05:16:58 +0000 (05:16 +0000)]
    * layout-tests/fast/dom/set-innerHTML-expected.txt: Updated test result now that DumpRenderTree handles
        this case properly. The old expected result just had the word "error"!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4291
darin [Thu, 15 Sep 2005 05:13:52 +0000 (05:13 +0000)]
    - fixed bugzilla.opendarwin.org/show_bug.cgi?id=4291
          dumpAsText doesn't work with XHTML documents

        * DumpRenderTree/DumpRenderTree.m: (dump): Dump the innerText of the document element
        rather than of the body element. This works with typical XHTML documents. We can probably
        do something even better in the long run, but this fixes the immediate issue.

        - separate tweak

        * Scripts/run-webkit-tests: Show the results in the current built Safari by using
        run-safari instead of just using "open", which often runs another copy of Safari instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by john
justing [Thu, 15 Sep 2005 01:26:12 +0000 (01:26 +0000)]
    Reviewed by john

        Fixes <rdar://problem/4237479> REGRESSION (Cambridge-Denver): old QuickTime movie continues to play sound after reload
        We were adding the movie to the document twice after the changes were added to handle fallback content.
        There are some errors for which we should not render fall back content

        * Misc.subproj/WebKitErrorsPrivate.h:
        Introduced WebKitErrorPlugInWillHandleLoad to represent the cancel we do
        to prevent loading plugin content twice

        * Plugins.subproj/WebPluginDocumentView.m:
        (-[WebPluginDocumentView dataSourceUpdated:]): Ditto

        * WebView.subproj/WebDataSource.m:
        (-[WebDataSource _receivedMainResourceError:complete:]):
        Don't handleFallbackContent on WebKitErrorPlugInWillHandleLoad or on a user cancel

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by john
justing [Thu, 15 Sep 2005 01:25:54 +0000 (01:25 +0000)]
    Reviewed by john

        Test cases added: none, method rename

        Part of fix for <rdar://problem/4237479> REGRESSION (Cambridge-Denver): old QuickTime movie continues to play sound after reload

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge handleFallbackContent]):
        Renamed bridge method mainResourceError to handleFallbackContent, since there are some
        main resource errors for which we should not render fallback content.  E.G user cancels
        and the cancel we do to prevent loading plugin content twice (see <rdar://problem/4258008>)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
harrison [Thu, 15 Sep 2005 00:57:26 +0000 (00:57 +0000)]
    Reviewed by Eric.

        <rdar://problem/4057623> AX: Dictionary Panel crash in AXAttributeStringSetStyle in Safari (Dictionary has workaround)

        Test cases added: None.  Manual testing is way to awkward, and automated testing
        is not possible.  Filed following bug to get automation.
        <rdar://problem/4256882> Need automated testing support for accessibility APIs

        * kwq/KWQAccObject.mm:
        (AXAttributedStringAppendText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Dave Hyatt.
vicki [Thu, 15 Sep 2005 00:20:58 +0000 (00:20 +0000)]
    Reviewed by Dave Hyatt.

- fixed <rdar://problem/4255274> REGRESSION: in some cases, link jumping to images is broken (4964)

        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::ContainerNodeImpl::getUpperLeftCorner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
thatcher [Wed, 14 Sep 2005 23:54:14 +0000 (23:54 +0000)]
    Reviewed by Eric.

        * WebKit.xcodeproj/project.pbxproj:
        made WebDashboardRegion.h a private header

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John.
darin [Wed, 14 Sep 2005 21:06:55 +0000 (21:06 +0000)]
    Reviewed by John.

        No easy way to test this in layout tests, so no test added.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4984
          REGRESSION placeholder border left behind after image finishes loading

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4985
          REGRESSION assertion failure in KWQPainter.mm:841

        * kwq/KWQPainter.mm:
        (QPainter::save): Do nothing if painting is disabled.
        (QPainter::restore): Ditto.
        (QPainter::drawRect): Inset so that we "frame" the rectangle rather than "stroking" the
        rectangle. The former draws inside the rectangle but the latter draws centered on the
        edge of the rectangle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin [Wed, 14 Sep 2005 16:21:29 +0000 (16:21 +0000)]
WebCore:

        Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4924
          QPainter should use CGContext as much as possible rather than NSGraphicsContext

        * kwq/KWQPainter.h: Made no-op xForm be an inline. Reformatted to remove extraneous spaces.
        Removed clearFocusRing. Changed the name of various private functions to remove underscore
        prefix, and reorganize them.

        * kwq/KWQPainter.mm:
        (QPainterPrivate::QPainterPrivate): Remove the NSBezierPath for focus.
        (QPainterPrivate::~QPainterPrivate): Ditto.
        (QPainter::save): Use CGContext instead of NSGraphicsContext.
        (QPainter::restore): Ditto.
        (QPainter::drawRect): Use CGContextFillRect instead of _fillRectXX, and
        CGContextStrokeRect instead of NSFrameRect.
        (QPainter::setFillColor): Added. Sets CGContext fill color based on brush.
        (QPainter::setFillColorFromCurrentBrush): Added. Sets CGContext fill color based on QPainter's
        current brush.
        (QPainter::setFillColorFromCurrentPen): Added. Sets CGContext fill color based on QPainter's
        current pen.
        (QPainter::setStrokeColorAndLineWidthFromCurrentPen): Added. Set CGContext stroke color and
        line width based on QPainter's current pen.
        (QPainter::drawLine): Use CGContextStrokeLineSegments instead of NSBezierPath.
        (QPainter::drawEllipse): Use CGContextFillEllipseInRect instead of CGContextFillPath and
        CGContextStrokeEllipseInRect instead of CGContextStrokePath.
        (QPainter::drawArc): Removed some uneeded type casts, changed to call the new private functions,
        currentContext and setStrokeColorAndLineWidthFromCurrentPen.
        (QPainter::drawConvexPolygon): Use new private functions, also use CGContextDrawPath in the
        case where we want to both fill and stroke the polygon.
        (QPainter::getCompositeOperation): Remove unneeded cast.
        (QPainter::setCompositeOperation): Map from name to operation here rather than relying on the
        code on the WebKit side to do it (allows us to remove names entirely from the WebKit side).
        (QPainter::compositeOperatorFromString): Remove a local variable and some casts.
        (getBlendedColorComponent): Rewrote to do the same computation without any conversion to float.
        (QPainter::fillRect): Use CGContextFillRect instead of _fillRectXXX.
        (QPainter::addClip): Use CGContextClipToRect instead of NSBezierPath.
        (QPainter::addRoundedRectClip): Add missing call to CGContextBeginPath.
        (QPainter::beginTransparencyLayer): Use CGContextSaveGState instead of NSGraphicsContext.
        (QPainter::endTransparencyLayer): Use CGContextRestoreGState instead of NSGraphicsContext.
        (QPainter::initFocusRing): Use CGContextBeginPath instead of creating an NSBezierPath.
        (QPainter::addFocusRingRect): Use CGContextAddRect instead of NSBezierPath.
        (QPainter::drawFocusRing): Use CGContextFillPath instead of NSBezierPath.

        * khtml/rendering/render_flow.cpp: (RenderFlow::paintFocusRing): Remove call to clearFocusRing. No longer exists.
        * khtml/rendering/render_object.cpp: (RenderObject::paintOutline): Ditto.

        * kwq/WebCoreImageRendererFactory.h: Remove setCGCompositeOperationFromString method.

WebKit:

        Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4924
          QPainter should use CGContext as much as possible rather than NSGraphicsContext

        * WebCoreSupport.subproj/WebImageRendererFactory.m: Remove setCGCompositeOperationFromString
        method, no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Justin.
harrison [Wed, 14 Sep 2005 03:43:02 +0000 (03:43 +0000)]
    Reviewed by Justin.

        <rdar://problem/4204892> Correcting incorrect spelling in Mail causes others to lose their red squiggles

        Fixed by having SplitTextNodeCommand::doApply copy the markers to the new node, and having SplitTextNodeCommand::doUnapply
        copy the markers from the merged-in node to the combined node.

        btw - filed <rdar://problem/4256492> "WebCore editing automated layout tests verify spelling markers"
        so that we can automate tests for this.

        Test cases added:
        * manual-tests/keep_spelling_markers.html: Added.

        * khtml/editing/split_text_node_command.cpp:
        (khtml::SplitTextNodeCommand::doApply):
        (khtml::SplitTextNodeCommand::doUnapply):
        Call new copyMarkers() function.

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::removeMarkers):
        (DocumentImpl::addMarker):
        (DocumentImpl::copyMarkers):
        (DocumentImpl::markersForNode):
        (DocumentImpl::shiftMarkers):
        * khtml/xml/dom_docimpl.h:
        (DOM::DocumentMarker::):
        Added copyMarkers() function.  Reorganized code for clarity.

        * khtml/xml/dom_textimpl.cpp:
        (CharacterDataImpl::setData):
        (CharacterDataImpl::deleteData):
        (CharacterDataImpl::replaceData):
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::respondToChangedSelection):
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge unmarkAllMisspellings]):
        Update calls to marker functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Justin Garcia, Darin Adler.
tomernic [Tue, 13 Sep 2005 20:51:36 +0000 (20:51 +0000)]
    Reviewed by Justin Garcia, Darin Adler.

- <rdar://problem/3163393> Safari does not support Windowless mode in Flash

        * Plugins.subproj/WebBaseNetscapePluginView.h:
Added 'isTransparent' instance variable.

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):
When updating a plugin in "windowless" (transparent) mode, clip drawing to the dirty
region of the opaque ancestor.  This means that a partially-transparent plugin, which
by definition does not clear its port on redraw, will not overdraw the valid parts
of its port.
        (-[WebBaseNetscapePluginView sendEvent:]):
Disabled the "green debug background" for transparent plugins -- since they are not
expected to cover their entire port every redraw, this debug code makes no sense.
        (-[WebBaseNetscapePluginView setVariable:value:]):
Implemented -setVariable:value:, which is called from NPN_SetValue() (previously
unimplemented).
Right now we only handle NPPVpluginTransparentBool; if we choose to handle the other
plugin variables, then we may do so here.
        * Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
Added SPI for -[WebBaseNetscapePluginView setVariable:value].
        * Plugins.subproj/npapi.m:
        (NPN_SetValue):
Implemented this function so that plugins may set state (such as window mode).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: none
eseidel [Mon, 12 Sep 2005 21:53:31 +0000 (21:53 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: none, build fix only for svg.
        Fixes build after qstring() -> string() rename this weekend.

        * kdom/Helper.cpp:
        (parseLength):
        * kdom/core/DOMStringImpl.cpp:
        (DOMStringImpl::toInt):
        * kdom/core/DocumentImpl.cpp:
        (DocumentImpl::getId):
        * kdom/css/CSSStyleSelector.cpp:
        (checkPseudoState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
darin [Mon, 12 Sep 2005 04:42:30 +0000 (04:42 +0000)]
    Reviewed by John Sullivan.

        - fixed <rdar://problem/4126166> using JavaScript-assigned accesskeys crashes Safari - DOM::NodeImpl::dispatchEvent

        Test cases added:
        * layout-tests/fast/events/access-key-self-destruct.html: Added.
        * layout-tests/fast/events/access-key-self-destruct-expected.txt: Added.

        * khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchMouseEvent): Ref the node for the duration
        with a SharedPtr; this helps in cases where the last reference to the node goes away inside the
        event handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoForgot to check this in (was mentioned in ChangeLog).
darin [Mon, 12 Sep 2005 03:43:01 +0000 (03:43 +0000)]
Forgot to check this in (was mentioned in ChangeLog).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
darin [Mon, 12 Sep 2005 03:40:38 +0000 (03:40 +0000)]
    Reviewed by Eric.

        - changed back the name of a couple of string() functions that were renamed to qstring() by accident

        * kwq/KWQString.h: (QConstString::string): Changed function name back to string() from qstring().
        This is a function from Qt, so the name needs to match Qt -- that's just how KWQ works.

        * khtml/xml/dom_atomicstringlist.h: Changed the name of the function that returns the current
        AtomicString to string() back from qstring()!

        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::matchRules): Use string() instead of qstring().
        (khtml::checkPseudoState): Ditto.
        (khtml::CSSStyleSelector::checkOneSelector): Ditto.
        * khtml/dom/dom_string.cpp: (DOM::DOMString::percentage): Ditto.
        * khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::finish): Ditto.
        * khtml/xml/dom_stringimpl.cpp:
        (DOM::DOMStringImpl::DOMStringImpl): Small tweak to streamline a tiny bit by using an already-computed
        boolean instead of re-checking a couple of data members.
        (DOM::parseLength): Use string() instead of qstring().
        (DOM::DOMStringImpl::toInt): Ditto.

        - removed some dead code

        * khtml/xml/dom_elementimpl.cpp: Removed XMLElementImpl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebKit:
darin [Sun, 11 Sep 2005 17:04:19 +0000 (17:04 +0000)]
WebKit:

        Reviewed, tweaked, and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4286
          .Mac prefpane crashes when Safari using CVS WebKit is running

        * WebView.subproj/WebView.m: (-[WebView initWithFrame:frameName:groupName:]):
        If ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH, and WEBKIT_UNSET_DYLD_FRAMEWORK_PATH
        is set in the environment, then unset DYLD_FRAMEWORK_PATH.

        * WebKit.xcodeproj/project.pbxproj: Set ENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH
        in configurations other than Default -- we don't want that code in production
        builds, but we want it in builds we do ourselves and nightly builds.

WebKitTools:

        Reviewed, tweaked, and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4286
          .Mac prefpane crashes when Safari using CVS WebKit is running

        * Scripts/run-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH.
        * Scripts/run-webkit-app: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 4932
eseidel [Sun, 11 Sep 2005 10:41:16 +0000 (10:41 +0000)]
Bug #: 4932
Submitted by: eseidel
Reviewed by: self, only affects SVG; build fix.
        * JavaScriptCore.xcodeproj/project.pbxproj: Fixed JSC+SVG
        Fixed JavaScriptCore+SVG after PCRE 6.1 merger.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4932

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * Scripts/run-webkit-tests: Oops. Use spaces, not tabs.
darin [Sun, 11 Sep 2005 09:28:00 +0000 (09:28 +0000)]
    * Scripts/run-webkit-tests: Oops. Use spaces, not tabs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
darin [Sun, 11 Sep 2005 09:23:53 +0000 (09:23 +0000)]
    Reviewed by Eric.

        * Scripts/run-webkit-tests: Sort tests with a new "pathcmp" function that's better in
        two ways: 1) puts all files in a directory before any files in a subdirectory, and
        2) sort file names with numeric digits in them in a logical way, so test-33 will come
        before test-3.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and landed by Darin.
darin [Sun, 11 Sep 2005 05:27:30 +0000 (05:27 +0000)]
    Reviewed and landed by Darin.

        * Makefile.vc: Added.
        * README-Win32.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and landed by Darin.
darin [Sat, 10 Sep 2005 21:33:18 +0000 (21:33 +0000)]
    Reviewed and landed by Darin.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4820
          hexadecimal HTML entities split across TCP packets are not parsed correctly

        Wasn't able to make a layout test for this because there's no easy way to
        simulate separate writes to the tokenizer.

        * khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseEntity):
        Rolled back to code more like the original KDE stuff -- our change broke this --
        but changed the limit so it works with 8-character entities.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - remove test case I just added -- it's not working
darin [Sat, 10 Sep 2005 21:22:37 +0000 (21:22 +0000)]
    - remove test case I just added -- it's not working

        * layout-tests/fast/dom/document-write-infinite-recursion-expected.txt: Removed.
        * layout-tests/fast/dom/document-write-infinite-recursion.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Sat, 10 Sep 2005 21:03:44 +0000 (21:03 +0000)]
    Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4806
          REGRESSION <area> elements misnested inside <div> elements not working

        Test cases added:
        * layout-tests/fast/parser/area-in-div.html: Added.
        * layout-tests/fast/parser/area-in-div-expected.txt: Added.

        * khtml/html/htmlparser.h: Declared mapCreateErrorCheck.
        * khtml/html/htmlparser.cpp:
        (HTMLParser::handleError): Fix formatting and indentation.
        (HTMLParser::formCreateErrorCheck): Added code to create the form too, so we can
        squirrel the form pointer away. Return false to prevent the factory from creating it.
        (HTMLParser::mapCreateErrorCheck): Added. Same kind of thing here, but without the logic
        that prevents creating a form if there's already a form open.
        (HTMLParser::getNode): Added the code to put the map function into the table. Also
        removed the form special-case code here that accomplishes what is now done inside the
        formCreateErrorCheck above instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Sat, 10 Sep 2005 20:47:15 +0000 (20:47 +0000)]
    Reviewed by Maciej.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4367
          Crash when executing setTimeout / Date / document.write Javascript (bugtraq)

        Test cases added:
        * layout-tests/fast/dom/document-write-infinite-recursion.html: Added.
        * layout-tests/fast/dom/document-write-infinite-recursion-expected.txt: Added.

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::implicitClose): Simplify a bit to make more readable. Remove the
        code to delete the tokenizer an extra time -- that can end up deleting the newly
        created tokenizer that's still needed for the newly opened page.
        (DocumentImpl::write): Added an assertion to catch the badness that caused
        infinite recursion so it's easier to recognize next time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed compilation for WebCore (another try)
darin [Sat, 10 Sep 2005 19:10:24 +0000 (19:10 +0000)]
    - fixed compilation for WebCore (another try)

        * kjs/simple_number.h: Added more "using" lines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed compilation for WebCore
darin [Sat, 10 Sep 2005 18:58:55 +0000 (18:58 +0000)]
    - fixed compilation for WebCore

        * kjs/simple_number.h: Have to include <cmath> here to work around a bug in the GCC
        standard C++ library headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Windows changes by Krzysztof Kowalczyk <kkowalczyk@gmail.com>.
darin [Sat, 10 Sep 2005 18:24:44 +0000 (18:24 +0000)]
    Windows changes by Krzysztof Kowalczyk <kkowalczyk@gmail.com>.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4870
          win portability: fix IS_NEGATIVE_ZERO macro in simple_number.h

        * kjs/simple_number.h:
        (KJS::isNegativeZero): Added. Inline function. Has a case for Windows that
        uses _fpclass and a case for other platforms that uses signbit.
        (KJS::SimpleNumber::fits): Use inline isNegativeZero instead of macro IS_NEGATIVE_ZERO.

        * kjs/internal.cpp: Remove definition of now-unneeded negZero global.

        * kjs/value.cpp: Touched the file because Xcode didn't know it needed to
        recompile it.

        - improved test engine

        * tests/mozilla/jsDriver.pl: Sort tests in numeric order instead of using
        a plain-ASCII sort; now test 33 will be after test 5 in any given set of
        numbered tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and landed by Darin.
darin [Sat, 10 Sep 2005 17:36:09 +0000 (17:36 +0000)]
    Reviewed and landed by Darin.

        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
        Removed unused local variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - add expected success result for newly-enabled test
darin [Sat, 10 Sep 2005 16:50:45 +0000 (16:50 +0000)]
    - add expected success result for newly-enabled test

        * layout-tests/dom/html/level2/html/HTMLIFrameElement11-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Dave Hyatt.
vicki [Sat, 10 Sep 2005 06:10:09 +0000 (06:10 +0000)]
    Reviewed by Dave Hyatt.

- fix <rdar://problem/4234256> REGRESSION: image tag broken in TOT

        Test cases added:
        * layout-tests/fast/replaced/image-tag-expected.checksum: Added.
        * layout-tests/fast/replaced/image-tag-expected.png: Added.
        * layout-tests/fast/replaced/image-tag-expected.txt: Added.
        * layout-tests/fast/replaced/image-tag.html: Added.

* khtml/html/htmlnames.h:
        * khtml/html/htmlfactory.cpp:
        (DOM::HTMLElementFactory::createHTMLElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
tomernic [Fri, 9 Sep 2005 22:14:43 +0000 (22:14 +0000)]
    Reviewed by John Sullivan.

        * History.subproj/WebBackForwardList.m:
        (-[WebBackForwardList removeItem:]):
SPI to remove a given WebHistoryItem.

        * History.subproj/WebBackForwardListPrivate.h: Added.

        * WebKit.xcodeproj/project.pbxproj:
Added WebBackForwardListPrivate.h as a private header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
sullivan [Fri, 9 Sep 2005 18:34:58 +0000 (18:34 +0000)]
WebCore:

        Reviewed by Tim Omernick.

        Test cases added: none, doesn't affect layout

        - fixed <rdar://problem/4250792> Find in HTML doesn't reveal match if only match was already selected

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::findString):
        If we end up finding the previously-selected text, just go through the normal success code path
        instead of bailing out early.

WebKit:

        Reviewed by Tim Omernick.

        fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4070:
        Find in plain text won't find only occurrence if it overlaps selection

        * Misc.subproj/WebSearchableTextView.m:
        (-[NSString findString:selectedRange:options:wrap:]):
        in the wrap case, extend the search range far enough that text overlapping the
        selection (including the exact-match case) will be considered.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed overloaded versions of throwError so that they substitute *all*
darin [Fri, 9 Sep 2005 01:19:19 +0000 (01:19 +0000)]
    - fixed overloaded versions of throwError so that they substitute *all*
          expected parameters into the message string -- some versions used to
          skip parameters, resulting in "%s" being printed in the error message.

        Reviewed by Geoff.

        * kjs/nodes.h: Updated declarations to use "const &" and not to name parameters
        * kjs/nodes.cpp: (Node::throwError): Updated to match above and add one missing
        call to substitute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
darin [Fri, 9 Sep 2005 00:51:07 +0000 (00:51 +0000)]
    Reviewed by Geoff.

        - updated to PCRE 6.1

        The original PCRE 6.1 sources are checked into the tree with the tag
        "pcre-6-1" for reference. What we're checking in right now is the original
        plus our changes to make it support UTF-16 and at least one other tweak
        (vertical tab considered whitespace). Our work to get our changes was
        done on "pcre-6-1-branch", with an anchor at "pcre-6-1-anchor" so you can
        see the evolution of the UTF-16 changes.

        Note also that there was one small change made here that's not on the branch
        in pcre_compile.c.

        * Info.plist: Updated the part of the copyright message that's about PCRE.

        * JavaScriptCore.xcodeproj/project.pbxproj: Added new PCRE source files,
        removed obsolete ones.

        * pcre/AUTHORS: Updated to PCRE 6.1. Includes credits for Apple's UTF-16
        changes, but not the credits for Google's C++ wrapper, since we don't include that.
        * pcre/COPYING: Updated to PCRE 6.1.
        * pcre/LICENCE: Ditto.
        * pcre/dftables.c: Ditto.
        * pcre/pcre-config.h: Ditto.
        * pcre/pcre.h: Ditto.

        * pcre/pcre_compile.c: Added for PCRE 6.1.
        * pcre/pcre_config.c: Ditto.
        * pcre/pcre_exec.c: Ditto.
        * pcre/pcre_fullinfo.c: Ditto.
        * pcre/pcre_get.c: Ditto.
        * pcre/pcre_globals.c: Ditto.
        * pcre/pcre_info.c: Ditto.
        * pcre/pcre_internal.h: Ditto.
        * pcre/pcre_maketables.c: Ditto.
        * pcre/pcre_ord2utf8.c: Ditto.
        * pcre/pcre_printint.c: Ditto.
        * pcre/pcre_refcount.c: Ditto.
        * pcre/pcre_study.c: Ditto.
        * pcre/pcre_tables.c: Ditto.
        * pcre/pcre_try_flipped.c: Ditto.
        * pcre/pcre_ucp_findchar.c: Ditto.
        * pcre/pcre_version.c: Ditto.
        * pcre/pcre_xclass.c: Ditto.
        * pcre/ucp.h: Ditto.
        * pcre/ucp_findchar.c: Ditto.
        * pcre/ucpinternal.h: Ditto.
        * pcre/ucptable.c: Ditto.

        * pcre/get.c: Removed.
        * pcre/internal.h: Removed.
        * pcre/maketables.c: Removed.
        * pcre/pcre.c: Removed.
        * pcre/study.c: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
vicki [Thu, 8 Sep 2005 22:54:35 +0000 (22:54 +0000)]
    Reviewed by John Sullivan.

- fixed <rdar://problem/4168089> CRASH: Using A9 Maps new interface (also occurs on google maps)

        * khtml/xml/dom_elementimpl.cpp:
        (ElementImpl::getAttributeNS): add a check for the document, before checking to see if this is an HTML document

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by darin
justing [Thu, 8 Sep 2005 21:38:10 +0000 (21:38 +0000)]
    Reviewed by darin

        * Scripts/update-webkitsysteminterface: Added.
        Builds webkitsysteminterface and moves the built product and header into WebKitLibraries

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by darin
justing [Thu, 8 Sep 2005 21:35:30 +0000 (21:35 +0000)]
    Reviewed by darin

        WebCore portion of multipart/x-mixed-replace support

        * khtml/misc/loader.cpp:
        (Request::Request):
        (Loader::slotReceivedResponse):
        Only allow a multipart load for images, clear out the old multipart section to prepare for a replace
        (Loader::slotData):
        Multipart sections are delivered to the coreLoader by WebKit all at once, send eof to CachedImage::data
        * khtml/misc/loader.h:
        (khtml::CachedObject::isImage): Added
        (khtml::CachedImage::isImage):
        * kwq/KWQKJobClasses.h:
        * kwq/KWQKJobClasses.mm:
        (KIO::TransferJob::cancel):
        Added a way to cancel a subresource loader from WebCore
        * kwq/KWQLoader.h:
        * kwq/KWQLoader.mm:
        (KWQResponseIsMultipart):
        * kwq/KWQResourceLoader.h:
        * kwq/KWQResourceLoader.mm:
        (-[KWQResourceLoader jobCanceledLoad]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by darin
justing [Thu, 8 Sep 2005 21:35:08 +0000 (21:35 +0000)]
    Reviewed by darin

        WebKit portion of multipart/x-mixed-replace support

        * WebCoreSupport.subproj/WebSubresourceLoader.m:
        (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
        Subresource case: Check for Foundation level multipart support
        (-[WebSubresourceLoader didReceiveResponse:]):
        Send previously received data in a multipart section to the coreLoader
        (-[WebSubresourceLoader didReceiveData:lengthReceived:]):
        Don't send data to the coreLoader until it has been completely received
        * WebView.subproj/WebDataSource.m:
        (-[WebDataSource _startLoading:]):
        Main resource case: check for Foundation level multipart support
        (+[WebDataSource _repTypesAllowImageTypeOmission:]):
        Some server apps send data right after declaring content multipart/x-mixed-replace, and expect it to be treated as html
        (-[WebDataSource _commitIfReady:]):
        Don't ask the WebFrame to close its old WebDataSource when loading a multipart section, because we're going to reuse it
        (-[WebDataSource _receivedData:]):
        For non text/html multipart sections, we commit the data all at once, at the end
        (-[WebDataSource _doesProgressiveLoadWithMIMEType:]):
        Added heuristic for when to commit the load incrementally
        (-[WebDataSource _commitLoadWithData:]):
        Moved from _receivedData into its own function
        (-[WebDataSource _revertToProvisionalState]):
        (-[WebDataSource _setupForReplaceByMIMEType:]):
        Commits the data received for the previous multipart section if it wasn't loaded progresively, clears out the WebFrame and WebDatasource for the next multipart section
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _transitionToCommitted:]):
        The very first multipart section is treated as a normal load, so that the back/forward list and history are updated.
        All later sections have a new load type, WebFrameLoadTypeReplace, and are treated like reloads
        (-[WebFrame _checkLoadCompleteForThisFrame]): Ditto
        (-[WebFrame _itemForRestoringDocState]): Ditto
        (-[WebFrame _setupForReplace]):
        Clears out the WebFrame for the next multipart section
        * WebView.subproj/WebFrameInternal.h:
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFrameView.m:
        (+[WebFrameView _viewTypesAllowImageTypeOmission:]): See above
        * WebView.subproj/WebLoader.h:
        * WebView.subproj/WebLoader.m:
        (-[NSURLProtocol clearResourceData]):
        (-[NSURLProtocol setSupportsMultipartContent:]):
        * WebView.subproj/WebMainResourceLoader.m: Straightforward
        (-[WebMainResourceLoader didReceiveResponse:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * WebKitSystemInterface.h: Update to latest
justing [Thu, 8 Sep 2005 21:33:50 +0000 (21:33 +0000)]
    * WebKitSystemInterface.h: Update to latest
        * libWebKitSystemInterface.a: ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Don Melton.
vicki [Thu, 8 Sep 2005 19:57:28 +0000 (19:57 +0000)]
    Reviewed by Don Melton.

- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4891 (HTMLIFrameElement11.js checks for
wrong title, causes false failure) and enabled HTMLIFrameElement11.html

        * layout-tests/dom/html/level2/html/HTMLIFrameElement11.js: check for correct title of resources/frame.html

        * layout-tests/dom/html/level2/html/HTMLIFrameElement11.html: Added.
        * layout-tests/dom/html/level2/html/HTMLIFrameElement11.html-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago -fixed gcc 4.0 build bustage due to inconsitent return type
ggaren [Thu, 8 Sep 2005 18:05:21 +0000 (18:05 +0000)]
    -fixed gcc 4.0 build bustage due to inconsitent return type

        Reviewed by john.

        * kwq/KWQTextField.mm:
        (-[NSTextField _KWQ_currentEditor]): editor is now cast as an NSTextView
        instead of an NSText (which makes sense regardless of build bustage,
        given that we first test for isKindOfClass:[NSTextView class] before defining editor)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 4863
eseidel [Thu, 8 Sep 2005 08:03:42 +0000 (08:03 +0000)]
Bug #: 4863
Submitted by: eseidel
Reviewed by: darin
        Merged various changes from KDE, including:
        Qt3->Qt4 change: QWMatrix -> QMatrix
        A few remaining DOMString -> DOMStringImpl changes
        KRenderingDevicePaintServer now inherits KCanvasResource
        Various whitespace adjustments.
        Fewer, clearer logs from kcanvas/device/quartz code.
        DOM exception support.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4863

        * ForwardingHeaders/qmatrix.h: Added.
        * WebCore+SVG/DrawDocument.mm:
        (-[DrawDocumentPrivate init]):
        (-[DrawDocumentPrivate dealloc]):
        (-[DrawDocumentPrivate setPrimaryView:]):
        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/KCanvas.cpp:
        (KCanvas::~KCanvas):
        (KCanvas::reset):
        * kcanvas/KCanvasContainer.cpp:
        (KCanvasContainer::bbox):
        (KCanvasContainer::collisions):
        (KCanvasContainer::first):
        (KCanvasContainer::last):
        * kcanvas/KCanvasContainer.h:
        * kcanvas/KCanvasFilters.cpp:
        * kcanvas/KCanvasFilters.h:
        * kcanvas/KCanvasMatrix.cpp:
        (KCanvasMatrix::KCanvasMatrix):
        (KCanvasMatrix::operator=):
        (KCanvasMatrix::operator==):
        (KCanvasMatrix::operator!=):
        (KCanvasMatrix::translate):
        (KCanvasMatrix::multiply):
        (KCanvasMatrix::scale):
        (KCanvasMatrix::rotate):
        (KCanvasMatrix::rotateFromVector):
        (KCanvasMatrix::skewX):
        (KCanvasMatrix::skewY):
        (KCanvasMatrix::qmatrix):
        * kcanvas/KCanvasMatrix.h:
        * kcanvas/KCanvasRegistry.cpp:
        (operator<<):
        * kcanvas/KCanvasRegistry.h:
        * kcanvas/KCanvasResources.cpp:
        (KCanvasResource::KCanvasResource):
        (KCanvasMarker::draw):
        * kcanvas/KCanvasResources.h:
        * kcanvas/KCanvasTreeDebug.cpp:
        (operator<<):
        * kcanvas/KCanvasView.cpp:
        (KCanvasView::setCanvas):
        * kcanvas/KCanvasView.h:
        * kcanvas/device/KRenderingFillPainter.cpp:
        (KRenderingFillPainter::draw):
        * kcanvas/device/KRenderingPaintServer.h:
        (KRenderingPaintServer::KRenderingPaintServer):
        * kcanvas/device/KRenderingPaintServerGradient.cpp:
        (KRenderingPaintServerGradient::Private::Private):
        (KRenderingPaintServerGradient::KRenderingPaintServerGradient):
        (KRenderingPaintServerGradient::listener):
        (KRenderingPaintServerGradient::setListener):
        * kcanvas/device/KRenderingPaintServerGradient.h:
        * kcanvas/device/KRenderingPaintServerPattern.cpp:
        (KRenderingPaintServerPattern::Private::Private):
        (KRenderingPaintServerPattern::KRenderingPaintServerPattern):
        (KRenderingPaintServerPattern::listener):
        (KRenderingPaintServerPattern::setListener):
        * kcanvas/device/KRenderingPaintServerPattern.h:
        * kcanvas/device/KRenderingStrokePainter.cpp:
        (KRenderingStrokePainter::setPaintServer):
        (KRenderingStrokePainter::draw):
        * kcanvas/device/KRenderingStyle.cpp:
        (KRenderingStyle::Private::Private):
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (KCanvasFilterQuartz::prepareFilter):
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        (cgGradientCallback):
        (KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
        (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
        (KRenderingPaintServerLinearGradientQuartz::draw):
        (KRenderingPaintServerRadialGradientQuartz::draw):
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (KRenderingPaintServerPatternQuartz::draw):
        (KRenderingPaintServerImageQuartz::draw):
        * kdom/KDOMSettings.cpp:
        (KDOMSettings::init):
        (KDOMSettings::strToAdvice):
        * kdom/Shared.h:
        (KDOM::KDOM_SAFE_SET):
        * kdom/backends/libxml/LibXMLParser.cpp:
        (sax_start_doc):
        (sax_internal_subset):
        (sax_entity_decl):
        * kdom/bindings/IDLParser.pm:
        * kdom/bindings/IDLStructure.pm:
        * kdom/cache/KDOMCache.h:
        * kdom/cache/KDOMCachedObject.h:
        * kdom/cache/KDOMLoader.cpp:
        (DocumentLoader::setAutoloadImages):
        * kdom/cache/KDOMLoader.h:
        * kdom/core/AttrImpl.cpp:
        (AttrImpl::value):
        (AttrImpl::setPrefix):
        * kdom/core/DOMConfigurationImpl.cpp:
        (DOMConfigurationImpl::normalizeCharacters):
        * kdom/core/DOMImplementationImpl.cpp:
        (DOMImplementationImpl::DOMImplementationImpl):
        (DOMImplementationImpl::createDocument):
        (DOMImplementationImpl::idToType):
        * kdom/core/DOMImplementationImpl.h:
        * kdom/core/DocumentImpl.cpp:
        (DocumentImpl::removeListenerType):
        (DocumentImpl::getId):
        * kdom/core/DocumentTypeImpl.cpp:
        (DocumentTypeImpl::internalSubset):
        * kdom/core/NamedAttrMapImpl.cpp:
        (NamedAttrMapImpl::setValue):
        (NamedAttrMapImpl::dispatchAttrMutationEvent):
        * kdom/core/NamedNodeMapImpl.cpp:
        (RONamedNodeMapImpl::getNamedItem):
        * kdom/core/NodeImpl.cpp:
        (NodeBaseImpl::removeChildren):
        (NodeImpl::lookupNamespaceURI):
        * kdom/core/ProcessingInstructionImpl.cpp:
        (ProcessingInstructionImpl::ProcessingInstructionImpl):
        (ProcessingInstructionImpl::~ProcessingInstructionImpl):
        * kdom/core/ProcessingInstructionImpl.h:
        * kdom/core/domattrs.c:
        * kdom/css/CSSPrimitiveValueImpl.cpp:
        (FontFamilyValueImpl::FontFamilyValueImpl):
        * kdom/css/CSSStyleRuleImpl.cpp:
        (CSSStyleRuleImpl::parseString):
        * kdom/css/CSSStyleRuleImpl.h:
        * kdom/css/CSSStyleSelector.cpp:
        (CSSStyleSelector::CSSStyleSelector):
        (CSSStyleSelector::styleForElement):
        (CSSStyleSelector::applyRule):
        (CSSStyleSelector::getLangAttribute):
        * kdom/css/CSSStyleSelector.h:
        * kdom/css/CSSStyleSheetImpl.cpp:
        (CSSStyleSheetImpl::type):
        * kdom/css/CSSValueImpl.cpp:
        (ShadowValueImpl::cssText):
        * kdom/css/Font.h:
        * kdom/css/LinkStyleImpl.cpp: Added.
        (LinkStyleImpl::LinkStyleImpl):
        (LinkStyleImpl::~LinkStyleImpl):
        (LinkStyleImpl::sheet):
        * kdom/css/LinkStyleImpl.h: Added.
        * kdom/css/MediaListImpl.cpp:
        (MediaListImpl::setMediaText):
        * kdom/css/RectImpl.cpp:
        * kdom/css/RectImpl.h:
        (KDOM::RectImpl::top):
        (KDOM::RectImpl::right):
        (KDOM::RectImpl::bottom):
        (KDOM::RectImpl::left):
        * kdom/css/RenderStyle.cpp:
        (RenderStyle::diff):
        * kdom/css/RenderStyle.h:
        * kdom/css/RenderStyleDefs.cpp:
        (StyleInheritedData::StyleInheritedData):
        (StyleInheritedData::operator==):
        * kdom/css/RenderStyleDefs.h:
        * kdom/css/StyleBaseImpl.cpp:
        (CSSSelector::print):
        (CSSSelector::extractPseudoType):
        * kdom/events/EventTargetImpl.cpp:
        (EventTargetImpl::addEventListener):
        * kdom/kdom.h:
        (KDOM::):
        * kdom/ls/DOMImplementationLSImpl.cpp: Added.
        (DOMImplementationLSImpl::DOMImplementationLSImpl):
        (DOMImplementationLSImpl::~DOMImplementationLSImpl):
        (DOMImplementationLSImpl::createLSParser):
        (DOMImplementationLSImpl::createLSInput):
        (DOMImplementationLSImpl::createLSOutput):
        (DOMImplementationLSImpl::createLSSerializer):
        * kdom/ls/DOMImplementationLSImpl.h: Added.
        * kdom/ls/LSParserImpl.cpp:
        (LSParserImpl::parseURI):
        * kdom/ls/LSParserImpl.h:
        * kdom/ls/LSResourceResolverImpl.cpp:
        (LSResourceResolverImpl::resolveResource):
        * kdom/ls/LSResourceResolverImpl.h:
        * kdom/ls/LSSerializerImpl.cpp:
        (LSSerializerImpl::newLine):
        (LSSerializerImpl::writeToString):
        (LSSerializerImpl::escape):
        (LSSerializerImpl::escapeAttribute):
        * kdom/ls/LSSerializerImpl.h:
        * kdom/parser/KDOMParser.cpp:
        (Parser::handleError):
        (Parser::bufferForUrl):
        * kdom/range/RangeImpl.cpp:
        (RangeImpl::toString):
        * kdom/range/RangeImpl.h:
        * kdom/scripts/cssmakeprops:
        * kdom/scripts/cssmakevalues:
        * kdom/xpointer/PointerPartImpl.cpp:
        (PointerPartImpl::PointerPartImpl):
        * kdom/xpointer/ShortHandImpl.cpp:
        (ShortHandImpl::ShortHandImpl):
        * kdom/xpointer/XPointerEvaluatorImpl.cpp:
        (XPointerEvaluatorImpl::createXPointer):
        * kdom/xpointer/XPointerResultImpl.h:
        * kdom/xpointer/kdomxpointer.h:
        (KDOM::XPointer::):
        * ksvg2/KSVGFactory.cpp:
        (KSVGFactory::createPartObject):
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        * ksvg2/events/SVGEventImpl.cpp:
        (SVGEventImpl::SVGEventImpl):
        (SVGEventImpl::initEvent):
        * ksvg2/events/SVGEventImpl.h:
        (KSVG::):
        * ksvg2/events/SVGZoomEventImpl.cpp:
        (SVGZoomEventImpl::SVGZoomEventImpl):
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        (KCanvasRenderingStyle::updateFill):
        (KCanvasRenderingStyle::updateStroke):
        (KCanvasRenderingStyle::startMarker):
        (KCanvasRenderingStyle::midMarker):
        (KCanvasRenderingStyle::endMarker):
        (KCanvasRenderingStyle::filter):
        * ksvg2/misc/KSVGTimeScheduler.cpp:
        (SVGTimer::notifyAll):
        * ksvg2/svg/SVGAnimateColorElementImpl.cpp:
        (SVGAnimateColorElementImpl::handleTimerEvent):
        * ksvg2/svg/SVGAnimateElementImpl.cpp:
        (SVGAnimateElementImpl::handleTimerEvent):
        * ksvg2/svg/SVGAnimationElementImpl.cpp:
        (SVGAnimationElementImpl::targetAttribute):
        (SVGAnimationElementImpl::setTargetAttribute):
        * ksvg2/svg/SVGAnimationElementImpl.h:
        * ksvg2/svg/SVGCursorElementImpl.cpp: Added.
        (SVGCursorElementImpl::SVGCursorElementImpl):
        (SVGCursorElementImpl::~SVGCursorElementImpl):
        (SVGCursorElementImpl::x):
        (SVGCursorElementImpl::y):
        (SVGCursorElementImpl::parseAttribute):
        (SVGCursorElementImpl::notifyFinished):
        * ksvg2/svg/SVGCursorElementImpl.h: Added.
        (KSVG::SVGCursorElementImpl::pixmap):
        * ksvg2/svg/SVGDOMImplementationImpl.cpp:
        (SVGDOMImplementationImpl::hasFeature):
        (SVGDOMImplementationImpl::createDocumentType):
        (SVGDOMImplementationImpl::createDocument):
        (SVGDOMImplementationImpl::typeToId):
        (SVGDOMImplementationImpl::idToType):
        * ksvg2/svg/SVGDocumentImpl.cpp:
        (SVGDocumentImpl::SVGDocumentImpl):
        (SVGDocumentImpl::createSVGElement):
        (SVGDocumentImpl::createElement):
        (SVGDocumentImpl::createElementNS):
        (SVGDocumentImpl::createEvent):
        (SVGDocumentImpl::notifyFinished):
        (SVGDocumentImpl::defaultNS):
        (SVGDocumentImpl::executeScripts):
        (SVGDocumentImpl::prepareMouseEvent):
        (SVGDocumentImpl::dispatchUIEvent):
        (SVGDocumentImpl::dispatchMouseEvent):
        * ksvg2/svg/SVGDocumentImpl.h:
        * ksvg2/svg/SVGElementImpl.cpp:
        (SVGElementImpl::getId):
        (SVGElementImpl::xmlbase):
        (SVGElementImpl::tryGetAttribute):
        (SVGElementImpl::tryGetAttributeNS):
        (SVGElementImpl::parseAttribute):
        (SVGElementImpl::addSVGEventListener):
        * ksvg2/svg/SVGElementImpl.h:
        * ksvg2/svg/SVGGradientElementImpl.cpp:
        (SVGGradientElementImpl::parseAttribute):
        * ksvg2/svg/SVGHelper.cpp:
        (SVGHelper::PercentageOfViewport):
        * ksvg2/svg/SVGImageElementImpl.cpp:
        (SVGImageElementImpl::notifyFinished):
        * ksvg2/svg/SVGLengthListImpl.cpp:
        (SVGLengthListImpl::parse):
        * ksvg2/svg/SVGLinearGradientElementImpl.cpp:
        (SVGLinearGradientElementImpl::x2):
        * ksvg2/svg/SVGMatrixImpl.cpp:
        (SVGMatrixImpl::SVGMatrixImpl):
        (SVGMatrixImpl::postMultiply):
        (SVGMatrixImpl::postTranslate):
        (SVGMatrixImpl::postScale):
        (SVGMatrixImpl::postScaleNonUniform):
        (SVGMatrixImpl::postRotate):
        (SVGMatrixImpl::postRotateFromVector):
        (SVGMatrixImpl::postFlipX):
        (SVGMatrixImpl::postFlipY):
        (SVGMatrixImpl::postSkewX):
        (SVGMatrixImpl::postSkewY):
        (SVGMatrixImpl::multiply):
        (SVGMatrixImpl::setMatrix):
        (SVGMatrixImpl::qmatrix):
        * ksvg2/svg/SVGMatrixImpl.h:
        * ksvg2/svg/SVGPatternElementImpl.cpp:
        (SVGPatternElementImpl::parseAttribute):
        * ksvg2/svg/SVGSVGElementImpl.cpp:
        (SVGSVGElementImpl::width):
        (SVGSVGElementImpl::height):
        (SVGSVGElementImpl::contentScriptType):
        (SVGSVGElementImpl::contentStyleType):
        (SVGSVGElementImpl::setContentStyleType):
        (SVGSVGElementImpl::createEvent):
        * ksvg2/svg/SVGSVGElementImpl.h:
        * ksvg2/svg/SVGScriptElementImpl.cpp:
        (SVGScriptElementImpl::parseAttribute):
        (SVGScriptElementImpl::executeScript):
        * ksvg2/svg/SVGScriptElementImpl.h:
        * ksvg2/svg/SVGSetElementImpl.cpp:
        (SVGSetElementImpl::handleTimerEvent):
        * ksvg2/svg/SVGStyleElementImpl.cpp:
        (SVGStyleElementImpl::xmlspace):
        (SVGStyleElementImpl::type):
        (SVGStyleElementImpl::media):
        (SVGStyleElementImpl::title):
        (SVGStyleElementImpl::childrenChanged):
        * ksvg2/svg/SVGStyledElementImpl.cpp:
        (SVGStyledElementImpl::attach):
        * ksvg2/svg/SVGTransformableImpl.cpp:
        (SVGTransformableImpl::updateSubtreeMatrices):
        (SVGTransformableImpl::parseAttribute):
        (SVGTransformableImpl::parseTransformAttribute):
        * ksvg2/svg/SVGTransformableImpl.h:
        * kwq/KWQNamespace.h:
        (Qt::): Added LayoutDirection for Qt4 support
        * kwq/KWQWMatrix.h: #define mapping QMatrix to QWMatrix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago -added layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4781
ggaren [Wed, 7 Sep 2005 23:27:41 +0000 (23:27 +0000)]
    -added layout test for bugzilla.opendarwin.org/show_bug.cgi?id=4781
        Date.setMonth fails with big values due to overflow

        Fix is in JavaScriptCore.

        Test cases added:

        * layout-tests/fast/js/date-big-setmonth-expected.txt: Added.
        * layout-tests/fast/js/date-big-setmonth.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago -fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4781
ggaren [Wed, 7 Sep 2005 23:27:28 +0000 (23:27 +0000)]
    -fixed bugzilla.opendarwin.org/show_bug.cgi?id=4781
        Date.setMonth fails with big values due to overflow

        Reviewed by darin.

        * kjs/date_object.cpp:
        (timetUsingCF): for consistency, changed return statement to invalidDate instead of LONG_MAX
        (KJS::fillStructuresUsingTimeArgs): modified for readability
        (KJS::fillStructuresUsingDateArgs): new function analogous to fillStructuresUsingTimeArgs
        (KJS::DateProtoFuncImp::callAsFunction): modified to use fillStructuresUsingDateArgs
        (KJS::DateObjectImp::construct): moved variable declaration to proper scope
        (KJS::DateObjectFuncImp::callAsFunction): moved variable declaration to proper scope

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago -updated expected test results to reflect fix for
ggaren [Wed, 7 Sep 2005 22:08:55 +0000 (22:08 +0000)]
    -updated expected test results to reflect fix for
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4698
        kjs does not allow named functions in function expressions

        * tests/mozilla/expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Justin.
vicki [Wed, 7 Sep 2005 18:10:38 +0000 (18:10 +0000)]
    Reviewed by Justin.

        - fix <rdar://problem/4246096> REGRESSION links to named anchors don't scroll to the right place (4825)

        This is really just a better fix for 4233844. Also consolidated manual-tests/scrollToAnchorWithNewline.html
and the test case from Bugzilla bug 4825 into manual-tests/scrollToAnchor.html.

        Test cases added:
        * manual-tests/scrollToAnchor.html: Added.

        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::ContainerNodeImpl::getUpperLeftCorner): when calculating scroll position, skip child nodes of the anchor
        if they do not have text boxes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 4868
eseidel [Wed, 7 Sep 2005 08:00:28 +0000 (08:00 +0000)]
Bug #: 4868
Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel
        * kcanvas/KCanvasCreator.cpp:
        (KCanvasCreator::createCanvasPathData):
        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (KRenderingDeviceQuartz::contextForImage):
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
        * ksvg2/svg/SVGDocumentImpl.cpp:
        (SVGDocumentImpl::~SVGDocumentImpl):
        Fixed several leaks.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4868

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
darin [Wed, 7 Sep 2005 02:38:35 +0000 (02:38 +0000)]
    Reviewed by John Sullivan.

        - fixed storage leaks; one of the leaks caused these 3 bugs:

        <rdar://problem/4231952> leaks of DOMStringImpl called from HTMLTokenizer::processToken, seen running WebKit tests
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4797>

        <rdar://problem/4233800> leak inside DOM::DocumentImpl::DocumentImpl, seen running webkit tests
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4795>

        <rdar://problem/4232812> leaks of NodeImpl called from HTMLParser::textCreateErrorCheck, seen running webkit tests
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4796>

        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::setOuterHTML): Put ref/deref around call to replaceChild to avoid leaking the node being replaced.
        (HTMLElementImpl::setOuterText): Put ref/deref around call to replaceChild to avoid leaking the node being replaced.
        Also changed removeChild calls to use remove instead, both for simplicity and to fix the leak without having
        to add a SharedPtr or ref/deref pair.

        * khtml/html/html_tableimpl.cpp:
        (DOM::HTMLTableElementImpl::setCaption): Put ref/deref around call to replaceChild to avoid leaking the node being
        replaced.
        (DOM::HTMLTableElementImpl::setTHead): Ditto.
        (DOM::HTMLTableElementImpl::setTFoot): Ditto.
        (DOM::HTMLTableElementImpl::setTBody): Tweaked a bit to match the other functions as closely as possible.
        No leak here.

        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::NodeImpl::remove): Added ref/deref to avoid leaking the node being removed.
        (DOM::NodeImpl::normalize): Changed two calls to removeChild to calls to remove to prevent leaks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by harrison
justing [Tue, 6 Sep 2005 23:53:10 +0000 (23:53 +0000)]
    Reviewed by harrison

        Fixes <rdar://problem/3976872> REGRESSION (Mail): Pasted lines of plain text don't get the proper style if pasted into newlines

        For style matched paste, style information was gathered incorrectly.

        Test cases added:
        * layout-tests/editing/pasteboard/3976872-expected.txt: Added.
        * layout-tests/editing/pasteboard/3976872.html: Added.

        * khtml/editing/replace_selection_command.cpp:
        (khtml::ReplaceSelectionCommand::doApply):
        Even though the startBlock (selection.start().node()->enclosingBlockFlowElement) is where manipulation
        begins on a paste, it can be missing necessary style information.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed build bustage from last checkin.
ggaren [Tue, 6 Sep 2005 23:46:39 +0000 (23:46 +0000)]
    - fixed build bustage from last checkin.

        Reviewed by haytt.

        * History.subproj/WebBackForwardList.m:
        (-[WebBackForwardList pageCacheSize]): updated debug printf since we no
        longer have a variable called 'multiplier'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reduce the # of cached pages for a back/forward list. The old cache would cache the
hyatt [Tue, 6 Sep 2005 21:40:13 +0000 (21:40 +0000)]
Reduce the # of cached pages for a back/forward list.  The old cache would cache the
following per tab:
> 1gb memory = 16 pages per tab/window
> 512mb memory = 8 pages per tab/window
<= 512mb memory = 4 pages per tab/window

This consumes far too much memory and is way too aggressive.  The new cache sizes are
as follows:
>= 1gb memory = 3 pages per tab/window
>= 512mb memory = 2 pages per tab/window
< 512mb memory = 1 page per tab/window

        Reviewed by john

        * History.subproj/WebBackForwardList.m:
        (-[WebBackForwardList pageCacheSize]):
        * WebView.subproj/WebPreferences.m:
        (+[WebPreferences initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 4864
eseidel [Tue, 6 Sep 2005 10:19:02 +0000 (10:19 +0000)]
Bug #: 4864
Submitted by: Tobias Lidskog <tobiaslidskog@mac.com>
Reviewed by: eseidel
        Don't create empty fill/stroke servers if fill/stroke
        are specified as "none".
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4864

        Test cases updated:
        * svg-tests/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/coords-units-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/filters-color-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/filters-example-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/linkingCircle-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/linkingToc-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-02-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-03-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/paths-data-04-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/rects-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/rects_b-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-align-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-align-02-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-align-03-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-intro-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-tref-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/text-ws-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/toc-sv-expected.txt:
        * svg-tests/W3C-SVG-1.1/Resources/toc-svcmp-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/color-prof-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/color-prop-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/color-prop-02-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/color-prop-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-units-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-units-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-units-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-example-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-image-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-light-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-events-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-order-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-order-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-order-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-a-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-a-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-a-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-a-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-path-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-path-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-path-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-path-04-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/masking-path-05-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-render-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-03-f-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-05-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-06-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/paths-data-07-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-elems-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-elems-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-elems-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-elems-06-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-elems-07-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-elems-08-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-groups-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/render-groups-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/script-handle-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/script-handle-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/script-handle-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/script-handle-04-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-group-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-group-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-image-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-image-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-image-03-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-image-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-image-05-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/styling-css-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/styling-css-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/styling-css-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-align-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-align-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-align-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-align-04-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-align-05-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-align-06-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-deco-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-intro-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-intro-02-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-intro-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-intro-04-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-path-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-text-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-text-03-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-tref-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-ws-01-t-expected.txt:
        * svg-tests/W3C-SVG-1.1/text-ws-02-t-expected.txt:

        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        (KCanvasRenderingStyle::updateFill):
        (KCanvasRenderingStyle::updateStroke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
darin [Mon, 5 Sep 2005 23:12:44 +0000 (23:12 +0000)]
    Reviewed by John Sullivan.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4846
          REGRESSION: Carbon WebKit applications don't work at all

        * Carbon.subproj/HIWebView.m: Remove lots of unneeded declarations of private stuff.
        (Draw): Call WKNSWindowOverrideCGContext and WKNSWindowRestoreCGContext rather
        than calling a non-existent setCGContext: method on the context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
darin [Mon, 5 Sep 2005 23:10:18 +0000 (23:10 +0000)]
    Reviewed by John Sullivan.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4822
          REGRESSION dragging does not stop when you release the mouse button in Google Maps

        Test cases added:
        * layout-tests/fast/dom/Window/window-remove-event-listener.html: Added.
        * layout-tests/fast/dom/Window/window-remove-event-listener-expected.txt: Added.

        * khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
        Fixed typo where window.removeEventListener would call addEventListener!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
darin [Mon, 5 Sep 2005 22:41:37 +0000 (22:41 +0000)]
    Reviewed by John Sullivan.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4493
          add qualifiedName checking for empty string

        * khtml/xml/dom_docimpl.cpp:
        (qualifiedNameIsValid): Added.
        (qualifiedNameIsMalformed): Added.
        (DOMImplementationImpl::createDocumentType): Added checks and exceptions using above functions.
        (DOMImplementationImpl::createDocument): Ditto.

        * layout-tests/dom/html/level2/core/createDocument08-expected.txt: Updated to expect success.
        * layout-tests/dom/html/level2/core/createDocumentType04-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
sullivan [Mon, 5 Sep 2005 22:26:06 +0000 (22:26 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        Test cases added: none, doesn't affect layout

        - fixed <rdar://problem/4211999> Safari quits when click-drag-hold an image that is
        set to automatically change.

        * khtml/khtmlview.cpp:
        (KHTMLView::updateDragAndDrop):
        add missing nil check

WebKit:

        Reviewed by Dave Hyatt.

        - change related to <rdar://problem/4211999> Safari quits when click-drag-hold an image
        that is set to automatically change.

        * WebView.subproj/WebHTMLView.m:
        (-[NSArray namesOfPromisedFilesDroppedAtDestination:]):
        handle nil wrapper with ERROR and early return rather than ASSERT, since we now know
        of a way to reproduce this (written up as 4244861)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
darin [Mon, 5 Sep 2005 22:22:40 +0000 (22:22 +0000)]
    Reviewed by John Sullivan.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4357
          crash related to animated GIFs, reproducible in non-Safari WebKit application

        * WebCoreSupport.subproj/WebImageData.m:
        (removeAnimatingRendererFromView): Added.
        (removeFromDictionary): Added.
        (-[WebImageData removeAnimatingRenderer:]): Rewrote using CF functions rather than
        NS functions so that we never retain the views, since this can be called from
        a view's dealloc method.
        (setNeedsDisplayInAnimationRect): Added.
        (-[WebImageData _nextFrame:]): Rewrote as above, even though in this case it can't
        be called from the dealloc method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
darin [Mon, 5 Sep 2005 20:25:17 +0000 (20:25 +0000)]
    Reviewed by John Sullivan.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4025
          Reproducible crash (infinite recursion?) choosing Make Link from text field's contextual menu

        * kwq/KWQTextField.mm:
        (-[KWQTextFieldController textView:shouldChangeTextInRange:replacementString:]):
        Allow a replacement string of nil.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and landed by Darin.
darin [Mon, 5 Sep 2005 17:18:59 +0000 (17:18 +0000)]
    Reviewed and landed by Darin.

        - added a test case that covers 8-digit hexadecimal entities

        * layout-tests/fast/parser/hex-entities-length.html: Added.
        * layout-tests/fast/parser/hex-entities-length-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
darin [Mon, 5 Sep 2005 04:01:24 +0000 (04:01 +0000)]
    Reviewed by John Sullivan.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4274
          REGRESSION: canvas draws when window loses focus (flipped and in wrong position!)
        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4755
          "CGContext*: invalid context" messages dumped to the console (may indicate a performance hit)

        * khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::paint):
        Don't try to paint if painting is disabled.

        * kwq/KWQPainter.mm:
        (QPainter::addClip): Do nothing if painting is disabled.
        (QPainter::addRoundedRectClip): Ditto.
        (QPainter::currentContext): Assert that painting is not disabled.
        (QPainter::beginTransparencyLayer): Do nothing if painting is disabled.
        (QPainter::endTransparencyLayer): Ditto.
        (QPainter::setShadow): Ditto.
        (QPainter::clearShadow): Ditto.
        (QPainter::initFocusRing): Ditto.
        (QPainter::addFocusRingRect): Ditto.
        (QPainter::drawFocusRing): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
darin [Mon, 5 Sep 2005 03:43:03 +0000 (03:43 +0000)]
    Reviewed by John Sullivan.

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4393
          REGRESSION: Unconfirmed text ignored in input type=text

        Test cases added:
        * manual-tests/input-type-text-unconfirmed-inline-input.html: Added.

        * kwq/KWQTextField.mm:
        (-[KWQTextFieldController controlTextDidBeginEditing:]): Call
        setWantsNotificationForMarkedText:YES on the field editor so we get
        "text did change" calls even for changes to the marked text.
        (-[KWQTextFieldController controlTextDidChange:]): Only call the bridge
        when we have changes and there is no marked text -- this is good because
        the bridge is used to implement form auto-fill and preserves the existing
        behavior. A more elegant future fix would be to notify the bridge more often
        and have the auto-fill code itself implement the "don't auto-fill when there
        is marked text" rule.
        (-[NSTextField _KWQ_currentEditor]): Change type to NSTextView so we can
        use this function to code NSTextView-specific stuff. The field editors are
        always subclasses of NSTextView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * kjs/identifier.cpp: Fix comment, add missing include.
darin [Sun, 4 Sep 2005 21:38:32 +0000 (21:38 +0000)]
    * kjs/identifier.cpp: Fix comment, add missing include.
        (Follow-on to changes from yesterday.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - added a layout test from Bugzilla for a bug that was fixed a while back
darin [Sun, 4 Sep 2005 20:56:31 +0000 (20:56 +0000)]
    - added a layout test from Bugzilla for a bug that was fixed a while back

        * layout-tests/fast/parser/script-tag-with-trailing-slash-expected.txt: Added.
        * layout-tests/fast/parser/script-tag-with-trailing-slash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * WebKitSystemInterface.h: Update to latest
darin [Sun, 4 Sep 2005 19:53:34 +0000 (19:53 +0000)]
    * WebKitSystemInterface.h: Update to latest
        * libWebKitSystemInterface.a: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - temporarily disable LEAKS messages that are giving too many false positives
darin [Sun, 4 Sep 2005 09:55:08 +0000 (09:55 +0000)]
    - temporarily disable LEAKS messages that are giving too many false positives
          we'll turn these back on again once we get them to really mean something.

        * khtml/xml/dom_elementimpl.cpp: (ElementImplCounter::~ElementImplCounter):
        Commented out the code to fprintf.
        * khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImplCounter::~NodeImplCounter): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: none
eseidel [Sun, 4 Sep 2005 09:22:48 +0000 (09:22 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: none
        No review needed, only affects SVG, removing unused files.

        * WebCore.xcodeproj/project.pbxproj: removed ksvg2/Scripts group.
        * ksvg2/scripts/ksvgstatus.xsl: Removed.
        * ksvg2/scripts/regressiontest.sh: Removed.
        * ksvg2/scripts/regressiontestsetup.sh: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: none
eseidel [Sun, 4 Sep 2005 09:10:54 +0000 (09:10 +0000)]
Bug #: none
Submitted by: eseidel
Reviewed by: none
        No review needed, only affects SVG, only replacing line endings.

        * ksvg2/svg/SVGFEBlendElementImpl.h: CRLF -> LF
        * ksvg2/svg/SVGFEFloodElementImpl.h: CRLF -> LF
        Fixed two files with windows line endings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed the build
darin [Sun, 4 Sep 2005 08:23:40 +0000 (08:23 +0000)]
    - fixed the build

        * khtml/rendering/break_lines.cpp: Added missing include of <qstring.h>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed and landed by Darin.
darin [Sun, 4 Sep 2005 07:42:31 +0000 (07:42 +0000)]
    Reviewed and landed by Darin.

        - fixed <rdar://problem/3698926> so slow it feels like a hang calling UCFindTextBreak() tons of times at forum.presence-pc.com (4789)
          also http://bugzilla.opendarwin.org/show_bug.cgi?id=4789

        No test cases added because this is a performance fix. Existing test cases continue to work.

        * khtml/rendering/break_lines.h: Declare the new nextBreakablePosition and also define a new
        isBreakable function that adds an in/out "next breakable position" parameter.
        * khtml/rendering/break_lines.cpp: (khtml::nextBreakablePosition): Replaced the old isBreakable
        with this function.

        * khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): Call the new version of
        isBreakable that uses the previously-found "next breakable" position until we pass it rather
        than analyzing each position separately to see if we can break there.

        * khtml/rendering/render_text.cpp: (RenderText::calcMinMaxWidth): Call the new isBreakable, and
        also do some things to streamline and perhaps speed up: a) use an index withing the string rather
        than within the word when finding a word break, b) use a cached copy of the string base pointer
        and the string length rather than repeatedly dereferencing str, c) use a cached copy of the current
        character rather than repeatedly fetching it. Darin also changed one confusing use of ? : to just
        use && instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed, tweaked and landed by Darin.
darin [Sun, 4 Sep 2005 06:21:54 +0000 (06:21 +0000)]
    Reviewed, tweaked and landed by Darin.

        - another try at some of the Windows compilation fixes
          should fix these bugs: 4546, 4831, 4834, 4643, 4830, 4832, 4833, 4835

        * kjs/collector.cpp: Add missing <setjmp.h> include.
        * kjs/date_object.cpp: Fix broken copysign macro.
        * kjs/dtoa.cpp: Move macro definitions down after all header includes.
        * kjs/fast_malloc.cpp: Add missing <assert.h> and <stddef.h> includes.
        * kjs/function.cpp: Remove broken isxdigit definition.
        * kjs/grammar.y: Add a missing semicolon (and remove an excess one).
        * kjs/identifier.cpp: Turn off AVOID_STATIC_CONSTRUCTORS because the placement new syntax
        doesn't seem to work in Visual C++ (I'm surprised to hear that, by the way).
        * kjs/value.h: Made ValueImp's destructor virtual because otherwise pointers to ValueImp
        on the stack aren't right for garbage collection on Windows (don't think it works that
        way with gcc's virtual table scheme, but it's a harmless change).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed, tweaked and landed by Darin.
darin [Sun, 4 Sep 2005 01:18:13 +0000 (01:18 +0000)]
    Reviewed, tweaked and landed by Darin.

        - some Windows compilation fixes, hoping to fix the problems reported in these bugs:
          4627, 4629, 4630, 4631, 4632, 4633, 4634, 4635, 4636, 4637, 4639, 4640, 4641, 4644, 4645

        * kjs/collector.cpp: Include <windows.h> on WIN32. Put thread-related code inside
        KJS_MULTIPLE_THREADS #if directives.
        (KJS::Collector::markCurrentThreadConservatively): Use NT_TIB to find the stack base on Win32.

        * kjs/config.h: Define HAVE_SYS_TIMEB_H for Win32.

        * kjs/date_object.cpp: Add include of <limits.h>. Add definitions of strncasecmp, isfinite, and
        copysign for Win32.
        (KJS::KRFCDate_parseDate): Move "errno = 0" line down closer to the first call to strol -- I believe
        that on Win32 there's some other call before that setting errno.

        * kjs/date_object.h: Remove unneeded include of <sys/time.h>.

        * kjs/dtoa.cpp: Add an undef of strtod, needed on Win32.

        * kjs/fast_malloc.cpp: Put #if !WIN32 around some customization that's not appropriate on Win32.
        (KJS::region_list_append): Add a missing cast so this Win32-specific function compiles in C++.
        (KJS::sbrk): Change parameter type to match the declaration.

        * kjs/function.cpp: (isxdigit): Define a locale-independent isxdigit on Win32.

        * kjs/function.h: Remove unneeded friend class Function for FunctionImp.

        * kjs/identifier.cpp: Took out the APPLE_CHANGES from around the AVOID_STATIC_CONSTRUCTORS
        define. We ultimately intend to phase out APPLE_CHANGES entirely. Also fix the
        non-AVOID_STATIC_CONSTRUCTORS code path.

        * kjs/internal.cpp: Remove uneeded include of <strings.h>, which was confused with <string.h>!
        Add a Win32 implementation of copysign. Put the threads code inside KJS_MULTIPLE_THREADS.

        * kjs/internal.h: Define a KJS_MULTIPLE_THREADS macro on non-Win32 only. Later we can make this
        specific to Mac OS X if we like.

        * kjs/interpreter_map.cpp: Add missing include of <stdlib.h>.

        * kjs/list.cpp:
        (KJS::ListImp::markValues): Use std::min instead of MIN.
        (KJS::List::copy): Ditto.
        (KJS::List::copyTail): Ditto.

        * kjs/math_object.cpp: (signbit): Add a Win32 implementation of signbit.

        * kjs/nodes.cpp: (Node::finalCheck): Use unsigned instead of uint.
        Put the use of always_inline inside __GNUC__.

        * kjs/number_object.cpp: (NumberProtoFuncImp::callAsFunction): Use "10.0" instead of "10"
        inside all the calls to pow to avoid ambiguity caused by overloading of pow on Win32, seen
        when passing an int rather than a double or float.

        * kjs/operations.cpp:
        (KJS::isInf): Add Win32 implementation.
        (KJS::isPosInf): Add Win32 implementation.
        (KJS::isNegInf): Add Win32 implementation.

        * kjs/regexp.cpp: Use unsigned instead of uint.
        * kjs/regexp.h: Ditto.
        * kjs/regexp_object.cpp: Ditto.
        * kjs/regexp_object.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago This patch substantially reworks how mouse clicking and double clicking work in...
hyatt [Sat, 3 Sep 2005 23:10:02 +0000 (23:10 +0000)]
This patch substantially reworks how mouse clicking and double clicking work in the DOM.

(1) screenY has been fixed so that it is no longer flipped.  This makes the values consistent with
other browsers on the Mac (like Firefox) and with Windows.

(2) For synthetic events delivered when the click() method is invoked, the values are simply set to 0
and false (e.g., for button, shiftKey, detail and so on).  This behavior matches Firefox.  WinIE uses
the current key and mouse state, but this just results in delivery of nonsense data, so we have opted
to match Firefox.

(3) onclick now exactly matches the DOM "click" event definition.  This means that onclick will now
fire on every single click (regardless of the click count), and onclick will now be considered the same
event as "click", meaning addEventListener "click"s and onclicks can interleave and work correctly during
the bubbling phase.  This behavior again deviates deliberately from WinIE and matches Firefox.  (In WinIE,
the onclick and ondblclick events are mutually exclusive, with click representing an odd clickCount and
dblclick representing an even clickCount).

(4) ondblclick has been changed to fire only when clickCount is exactly 2.  This matches Firefox.  dblclick
remains a separate synthetic event that fires independently of click with a clickCount of 2.  This also
matches Firefox behavior.

(5) mouseover and mouseout have been patched not to fire when they occur on a disabled control.  More generally, no
mouse event will be delivered to a disabled element.  The current check only examines the target node, and this
is not good enough (but can be improved in a later patch).  Some nodes will be children of disabled ancestors (e.g.,
options or children of a <button), and this is not yet taken into account.

(6) The behavior of shifting focus on a mousedown has been fixed to not occur if preventDefault has been set.  This
matches Firefox.

        Reviewed by darin

        * khtml/ecma/kjs_binding.cpp:
        (KJS::ScriptInterpreter::wasRunByUserGesture):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNode::getValueProperty):
        (KJS::DOMNode::putValueProperty):
        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        (KJS::Window::put):
        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::parseMappedAttribute):
        (HTMLElementImpl::click):
        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLInputElementImpl::defaultEventHandler):
        * khtml/html/html_inlineimpl.cpp:
        (DOM::HTMLAnchorElementImpl::defaultEventHandler):
        * khtml/khtmlview.cpp:
        (KHTMLViewPrivate::reset):
        (KHTMLView::viewportMousePressEvent):
        (KHTMLView::viewportMouseDoubleClickEvent):
        (KHTMLView::dispatchMouseEvent):
        * khtml/rendering/render_form.cpp:
        (RenderFormElement::slotClicked):
        * khtml/rendering/render_replaced.cpp:
        (RenderWidget::sendConsumedMouseUp):
        (RenderWidget::eventFilter):
        * khtml/rendering/render_replaced.h:
        * khtml/xml/EventNames.h:
        * khtml/xml/dom_nodeimpl.cpp:
        (DOM::NodeImpl::dispatchMouseEvent):
        (DOM::NodeImpl::dispatchSimulatedMouseEvent):
        * khtml/xml/dom_nodeimpl.h:
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject mouseButtonListener]):
        * kwq/KWQEvent.h:
        (QMouseEvent::globalX):
        (QMouseEvent::globalY):
        (QMouseEvent::clickCount):
        * kwq/KWQEvent.mm:
        (positionForEvent):
        (globalPositionForEvent):
        (QMouseEvent::QMouseEvent):
        * kwq/KWQWidget.mm:
        (QWidget::sendConsumedMouseUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed a mistake in the DOM tests, and an organizational issue that made...
darin [Sat, 3 Sep 2005 20:45:35 +0000 (20:45 +0000)]
    - fixed a mistake in the DOM tests, and an organizational issue that made them hard to
          run with run-webkit-tests (because run-webkit-tests assumes that any file with an .html
          extension is one of the tests)

        * layout-tests/dom/html/level2/html/HTMLFrameElement09-expected.txt: Updated to expect success.
        The failure we were seeing was due to an incorrect title in frame.html.

        * layout-tests/dom/html/level2/html/HTMLFrameElement09.html: Updated to get at iframe.html
        and frame.html from the resources subdirectory.

        * layout-tests/dom/html/level2/html/HTMLIFrameElement11.html-disabled: Updated to get at iframe.html
        and frame.html from the resources subdirectory.

        * layout-tests/dom/html/level2/html/frame.html: Removed. Since this is not a test, moved it into the
        resources subdirectory so the layout test engine won't see it.
        * layout-tests/dom/html/level2/html/iframe.html: Ditto.

        * layout-tests/dom/html/level2/html/resources/frame.html: Moved down here from the directory above.
        Adjusted URLs that specify resources still in the directory above to use "../" to find those.
        Also corrected the title of the file which was incorrect and causing HTMLFrameElement09 to fail.
        * layout-tests/dom/html/level2/html/resources/iframe.html: More of the same.

        * layout-tests/dom/html/level2/html/frame-expected.txt: Removed. This was not a test, so it
        should not have expected results.
        * layout-tests/dom/html/level2/html/iframe-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBug #: 4790
eseidel [Sat, 3 Sep 2005 08:02:28 +0000 (08:02 +0000)]
Bug #: 4790
Submitted by: eseidel
Reviewed by: none
        No review requested (only affects SVG), continuation of 4790.

        * WebCore.xcodeproj/project.pbxproj: updated include path
        * kdom/core/DocumentImpl.h: updated #include
        * kdom/xpointer/ElementSchemeImpl.h: ditto.
        * kdom/xpointer/ShortHandImpl.h: ditto.
        * kdom/xpointer/XMLNSSchemeImpl.h: ditto.
        * kdom/xpointer/XPath1SchemeImpl.h: ditto.
        * kdom/xpointer/XPointerSchemeImpl.h: ditto.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4790

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@10453 268f45cc-cd09-0410-ab3c-d52691b4dbfc