WebKit-https.git
11 years ago2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 14 Apr 2009 00:21:32 +0000 (00:21 +0000)]
2009-04-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by David Hyatt.

        Check document for nullity to avoid crashing on GTK+, when
        creating the WebView.

        * page/FrameView.cpp:
        (WebCore::FrameView::needsLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Forgot to capitalize the "US".
adachan@apple.com [Tue, 14 Apr 2009 00:19:46 +0000 (00:19 +0000)]
    Forgot to capitalize the "US".

        * platform/text/win/TextBreakIteratorInternalICUWin.cpp:
        (WebCore::currentTextBreakLocaleID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/6564956> URL field double-click selects entire domain, rather...
adachan@apple.com [Tue, 14 Apr 2009 00:10:14 +0000 (00:10 +0000)]
    <rdar://problem/6564956> URL field double-click selects entire domain, rather than single word or entire URL
        Revert back to the old word breaking behavior by using en_US_POSIX locale.

        Reviewed by Steve Falkenburg.

        * platform/text/win/TextBreakIteratorInternalICUWin.cpp:
        (WebCore::currentTextBreakLocaleID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin.
kdecker@apple.com [Mon, 13 Apr 2009 23:42:35 +0000 (23:42 +0000)]
    Reviewed by Darin.

        <rdar://problem/6784955> REGRESSION: closing a tab containing a PDF causes world leaks

        Simplify the _trackFirstResponder method by just caching the value instead of retaining
        a Cocoa object.

        * WebView/WebPDFView.h: Eliminated trackedFirstResponder object and replaced it with
        a firstResponderIsPDFDocumentView boolean.
        * WebView/WebPDFView.mm:
        (-[WebPDFView dealloc]): Removed no longer necessary ASSERT.
        (-[WebPDFView viewWillMoveToWindow:]): Removed call to release and nil-out trackedFirstResponder,
        which no longer exists. In the new code all we do now is set firstResponderIsPDFDocumentView to NO.
        (-[WebPDFView _trackFirstResponder]): Rewrote this method to just cache the value instead
        of retaining an object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 13 Apr 2009 22:36:43 +0000 (22:36 +0000)]
2009-04-13  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        * Scripts/check-for-exit-time-destructors: Add ERROR: and WARNING: prefixes to
        make these scripts work better with the build window in new versions of Xcode.
        * Scripts/check-for-global-initializers: Ditto.
        * Scripts/check-for-weak-vtables: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 13 Apr 2009 22:18:32 +0000 (22:18 +0000)]
2009-04-13  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        * platform/cf/BinaryPropertyList.cpp: Added comment.
        * platform/cf/BinaryPropertyList.h: Fixed mistakes in comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Mon, 13 Apr 2009 22:16:57 +0000 (22:16 +0000)]
WebCore:

2009-04-13  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
        https://bugs.webkit.org/show_bug.cgi?id=25158
        rdar://problem/6769693

        Test: editing/selection/click-after-nested-block.html

        * rendering/RenderBlock.cpp:
        (WebCore::isChildHitTestCandidate): Added. Helper so the two loops in positionForPoint
        can share code.
        (WebCore::RenderBlock::positionForPoint): Removed unneeded special case for first
        child box. Changed special case for last child box to propertly handle the various
        types of child box that are not hit test candidates (the same ones already handled
        by the hit test loop below), adding in a loop so we find the last candidate.

LayoutTests:

2009-04-13  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 25158: hit testing doesn't work right in some cases involving anonymous blocks
        https://bugs.webkit.org/show_bug.cgi?id=25158
        rdar://problem/6769693

        * editing/selection/click-after-nested-block-expected.txt: Added.
        * editing/selection/click-after-nested-block.html: Added.

        * fast/events/pointer-events-expected.txt: Updated since this is now a plain-text test.
        * fast/events/pointer-events.html: Changed this to a plain-text test, because the old
        results reflected a difference in hit testing behavior that this test was not intended
        to exercise and it's better to have the test be more cross-platform. Also removed
        unneeded use of waitUntilDone.

        * fast/js/finally-codegen-failure.html: Replaced with standard wrapper created by
        running the make-js-test-wrappers script. If we want to include type and charset
        attributes in the script elements, we can change make-js-test-wrappers to do that
        for all tests at some point.
        * fast/js/function-apply-aliased.html: Ditto.
        * fast/js/function-call-aliased.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
ggaren@apple.com [Mon, 13 Apr 2009 21:44:54 +0000 (21:44 +0000)]
JavaScriptCore:

2009-04-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Disabled another JavaScriptCore test because it fails on Windows but
        not Mac, so it makes the bots red.

        * tests/mozilla/expected.html:

WebKitTools:

2009-04-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Disabled another JavaScriptCore test because it fails on Windows but
        not Mac, so it makes the bots red.

        * Scripts/run-javascriptcore-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate accessibility layout test from last checkin.
hyatt@apple.com [Mon, 13 Apr 2009 21:39:29 +0000 (21:39 +0000)]
Update accessibility layout test from last checkin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebcore:
hyatt@apple.com [Mon, 13 Apr 2009 21:34:21 +0000 (21:34 +0000)]
Webcore:

2009-04-13  David Hyatt  <hyatt@apple.com>

        Reviewed by Sam Weinig.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=25125.  Rework scrolling so that a layout happens first when
        it's already needed so that the code doesn't end up making bad decisions based off invalid document sizes.

        * WebCore.base.exp:
        * page/FrameView.h:
        (WebCore::FrameView::visibleContentsResized):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::ScrollView):
        (WebCore::ScrollView::updateScrollbars):
        * platform/ScrollView.h:

WebKit/mac:

2009-04-13  David Hyatt  <hyatt@apple.com>

        Reviewed by Sam Weinig.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=25125.  Rework scrolling so that a layout happens first when
        it's already needed so that the code doesn't end up making bad decisions based off invalid document sizes.

        This patch also eliminates WebHTMLView's separate notion of needing a layout and just consolidates it with
        WebCore's notion of needing layout.

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView updateScrollers]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _frameOrBoundsChanged]):
        (-[WebHTMLView initWithFrame:]):
        (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
        (-[WebHTMLView setNeedsLayout:]):
        (-[WebHTMLView _layoutIfNeeded]):
        (-[WebHTMLView _needsLayout]):
        * WebView/WebHTMLViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows part 2 of <rdar://5438063> Saving history containing 100,000 entries causes...
aroben@apple.com [Mon, 13 Apr 2009 21:31:02 +0000 (21:31 +0000)]
Windows part 2 of <rdar://5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing

WebCore:

        Add SharedBuffer::wrapCFData

        This is the CF-equivalent of wrapNSData.

        Reviewed by Brady Eidson.

        * platform/SharedBuffer.h:
        * platform/cf/SharedBufferCF.cpp:
        (WebCore::SharedBuffer::wrapCFData):

WebKit/win:

        Windows part 2 of <rdar://5438063> Saving history containing 100,000
        entries causes pauses of 2s while browsing

        Reviewed by Brady Eidson.

        * Interfaces/IWebHistoryPrivate.idl: Added data, analagous to
        WebKit/mac's -[WebHistory _data] method.

        * WebHistory.cpp:
        (WebHistory::saveHistoryGuts): Changed to call data() to get the data for
        saving.
        (WebHistory::data): Added. Returns the data for saving as an IStream.
        (WebHistory::data): Added. Returns the data for saving as a CFDataRef.

        * WebHistory.h: Added data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 13 Apr 2009 21:27:14 +0000 (21:27 +0000)]
2009-04-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Holger Freyther.

        Further massage tests to disable tests that are failingto make the
        results more useful.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
ggaren@apple.com [Mon, 13 Apr 2009 21:09:43 +0000 (21:09 +0000)]
JavaScriptCore:

2009-04-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Disabled two JavaScriptCore tests because they fail on Window or Mac but
        not both, so they make the bots red.

        * tests/mozilla/expected.html: Updated expected results.

WebKitTools:

2009-04-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Disabled two JavaScriptCore tests because they fail on Window or Mac but
        not both, so they make the bots red.

        * Scripts/run-javascriptcore-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdding a comment to my previous code change.
justin.garcia@apple.com [Mon, 13 Apr 2009 20:57:04 +0000 (20:57 +0000)]
Adding a comment to my previous code change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 13 Apr 2009 20:55:49 +0000 (20:55 +0000)]
2009-04-13  Darin Adler  <darin@apple.com>

        * WebView/WebViewPrivate.h: Updated comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - build fix
mitz@apple.com [Mon, 13 Apr 2009 20:48:38 +0000 (20:48 +0000)]
    - build fix

        * page/EventHandler.cpp:
        (WebCore::documentPointForWindowPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
antti@apple.com [Mon, 13 Apr 2009 20:46:34 +0000 (20:46 +0000)]
WebCore:

2009-04-13  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6740294> Increase the connection count per host

        Try to use six connections per host if possible.

        * WebCore.base.exp:
        * loader/loader.cpp:
        (WebCore::Loader::Loader):
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
        * platform/network/ResourceRequestBase.cpp:
        (WebCore::initMaximumHTTPConnectionCountPerHost):
        * platform/network/ResourceRequestBase.h:
        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::initMaximumHTTPConnectionCountPerHost):

WebKit/mac:

2009-04-13  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6740294> Increase the connection count per host

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):

WebKitLibraries:

2009-04-13  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6740294> Increase the connection count per host

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
justin.garcia@apple.com [Mon, 13 Apr 2009 20:38:03 +0000 (20:38 +0000)]
WebCore:

2009-04-13  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Adele Peterson.

        https://bugs.webkit.org/show_bug.cgi?id=25153
        Can't place the caret into text field that scrolls the window on focus

        We refetch the target node in the shadow node case, and when we do so the window coordinate for the mouse event may
        be invalid because of scrolling that the focus handler did.  Cache the document point (that we derived from the window
        coordinate) and use that any time we refetch.

        * page/EventHandler.cpp:
        (WebCore::documentPointForWindowPoint):
        (WebCore::EventHandler::handleMousePressEvent):
        (WebCore::EventHandler::prepareMouseEvent):

LayoutTests:

2009-04-13  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Adele Peterson.

        <rdar://problem/6748324> REGRESSION (Kirkwood): Can't type in Netflix search field

        * fast/forms/25153-expected.txt: Added.
        * fast/forms/25153.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 13 Apr 2009 20:29:45 +0000 (20:29 +0000)]
2009-04-13  Sam Weinig  <sam@webkit.org>

        Fix bad expected result.

        * fast/frames/frame-unload-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 13 Apr 2009 20:26:42 +0000 (20:26 +0000)]
2009-04-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Rename JavaScriptCanOpenWindowsAutomatically to javaScriptCanOpenWindowsAutomatically
        to conform to our style guidelines.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::allowPopUp):
        * page/Settings.h:
        (WebCore::Settings::javaScriptCanOpenWindowsAutomatically):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 13 Apr 2009 20:24:43 +0000 (20:24 +0000)]
2009-04-13  Geoffrey Garen  <ggaren@apple.com>

        Mac build fix: Made another header private.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Jian Li <jianli@chromium.org>
dimich@chromium.org [Mon, 13 Apr 2009 20:20:53 +0000 (20:20 +0000)]
2009-04-13  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=25121
        Upstream changes to handle error messages from V8 when running worker script.

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::reportFatalErrorInV8):
        (WebCore::handleConsoleMessage):
        (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
        (WebCore::WorkerContextExecutionProxy::dispose):
        (WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
        (WebCore::WorkerContextExecutionProxy::evaluate):
        * bindings/v8/WorkerContextExecutionProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 13 Apr 2009 20:18:06 +0000 (20:18 +0000)]
2009-04-13  Brady Eidson  <beidson@apple.com>

        Reviewed by Tim Hatcher

        Tweak my last check-in, moving the thread violation check up to the API-level calls so the logging is more
        useful to developers/users.

        * WebView/WebFrame.mm:
        (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): If not on the main thread, only
          perform the "call on main thead" workaround, as the log/exception raising is now up at the API level.
        (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Perform a thread violation check here so logging
          is more meaningful.
        (-[WebFrame loadHTMLString:baseURL:]): Ditto.
        (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 13 Apr 2009 20:16:36 +0000 (20:16 +0000)]
2009-04-13  Geoffrey Garen  <ggaren@apple.com>

        Build fix: Made setInlineEventListenerForType not inline, since Document
        calls it now. Made RegisteredEventListener.h a private header on Mac,
        so WebKit can use it.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::setInlineEventListenerForType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
mitz@apple.com [Mon, 13 Apr 2009 20:14:47 +0000 (20:14 +0000)]
    Reviewed by Sam Weinig.

        - fix <rdar://problem/6404439> REGRESSION: Overlapping text and other
          layout issues in View Sample feature of MYOB FIrstEdge v3

        * page/Navigator.cpp:
        (WebCore::shouldHideFourDot): Added "tdqm_loader.js" to the list of
        JavaScript files this quirk applies to.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 13 Apr 2009 20:03:18 +0000 (20:03 +0000)]
2009-04-13  Brady Eidson  <beidson@apple.com>

        Reviewed by Kevin Decker

        <rdar://problem/6712063> Garmin WebUpdater crashes

        * WebView/WebFrame.mm:
        (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):  If not called on the main thread,
          add a ThreadViolationCheckRoundTwo() call to either log or raise an exception.  In the case where it's
          only a log, reschedule the _loadData call to occur on the main thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Mon, 13 Apr 2009 19:50:32 +0000 (19:50 +0000)]
WebCore:

2009-04-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Move open and showModalDialog functions out of JSDOMWindowBase
        and into JSDOMWindow by partially generating them.

        This slightly changes the behavior of getting window.showModalDialog
        when the embedding app does not support it to return undefined regardless
        of shadowing.  This should not be an issue in a practice, but will be addressed
        when we add a generic way to handle runtime specialization of property
        access.

        * DerivedSources.make: Remove JSDOMWindowBase.lut.h
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::):
        (WebCore::JSDOMWindowBase::getOwnPropertySlot): Move canShowModalDialog check from
        here to JSDOMWindow::customGetOwnPropertySlot.
        (WebCore::JSDOMWindowBase::put): Remove dead code.
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::createWindow):
        (WebCore::JSDOMWindow::open):
        (WebCore::JSDOMWindow::showModalDialog):
        * bindings/js/JSDOMWindowCustom.h:
        (WebCore::JSDOMWindow::customGetOwnPropertySlot):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::parseModalDialogFeatures): Move from JSDOMWindowBase.
        (WebCore::DOMWindow::allowPopUp): Ditto.
        (WebCore::DOMWindow::canShowModalDialog): Ditto.
        (WebCore::DOMWindow::canShowModalDialogNow): Ditto.
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

LayoutTests:

2009-04-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Update tests after moving showModalDialog from JSDOMWindowBase to
        JSDOMWindow and slightly changing the behavior when showModalDialog
        is not available, as is the case for DumpRenderTree.

        * fast/dom/Window/window-function-frame-getter-precedence-expected.txt:
        * fast/dom/Window/window-properties-expected.txt:
        * platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 13 Apr 2009 19:43:47 +0000 (19:43 +0000)]
2009-04-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Moved storage for window event listeners into the window object.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::addEventListener):
        (WebCore::JSDOMWindow::removeEventListener): Add / remove window event
        listeners to / from the window object.

        * dom/Document.cpp:
        (WebCore::Document::removeAllEventListeners):
        (WebCore::Document::clear):
        (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute): Moved
        a bunch of code to the DOMWindow class, and left behind a few calls through
        to DOMWindow, to support legacy clients. (Eventually, these will go away, too.)

        * dom/Document.h: ditto.

        * dom/Node.cpp:
        (WebCore::Node::dispatchGenericEvent):
        (WebCore::Node::dispatchWindowEvent): Dipatch window events on the window
        object, not the document.

        * dom/Node.h:
        * dom/RegisteredEventListener.h: Moved RegisteredEventListenerVector
        declaration, since it's required in more places now.

        * history/CachedFrame.cpp:
        (WebCore::CachedFrame::clear): Updated for rename. Also, remove event
        listeners before detaching and clearing the document's window pointer,
        since the the document needs its window pointer in order to tell the window
        to clear its event listeners.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading):
        (WebCore::FrameLoader::canCachePageContainingThisFrame):
        (WebCore::FrameLoader::logCanCacheFrameDecision): Updated for rename, and
        movement of window event listeners into the window.

        * loader/ImageDocument.cpp:
        (WebCore::ImageDocument::createDocumentStructure): Updated for movement
        of window event listeners into the window.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::handleEvent):
        (WebCore::DOMWindow::addEventListener):
        (WebCore::DOMWindow::removeEventListener):
        (WebCore::DOMWindow::removeAllEventListeners):
        (WebCore::DOMWindow::hasEventListener):
        (WebCore::DOMWindow::setInlineEventListenerForType):
        (WebCore::DOMWindow::removeInlineEventListenerForType):
        (WebCore::DOMWindow::inlineEventListenerForType):
        (WebCore::DOMWindow::addPendingFrameUnloadEventCount):
        (WebCore::DOMWindow::removePendingFrameUnloadEventCount):
        (WebCore::DOMWindow::addPendingFrameBeforeUnloadEventCount):
        (WebCore::DOMWindow::removePendingFrameBeforeUnloadEventCount):
        * page/DOMWindow.h: Moved a bunch of code to the DOMWindow class, from the Document.

        * page/Frame.cpp:
        (WebCore::Frame::shouldClose): Updated for movement of window event listeners into the window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Mon, 13 Apr 2009 19:05:51 +0000 (19:05 +0000)]
2009-04-13  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=25149

        The Geolocation timer needs to start after the UA has granted permission.

        * bindings/js/JSGeolocationCustom.cpp: Use PassRefPtr<PositionOptions>
        (WebCore::JSGeolocation::getCurrentPosition):
        (WebCore::JSGeolocation::watchPosition):
        * page/Geolocation.cpp: Add a RefPtr<PositionOptions> so it can be used
        later when the timer is started. Change PositionOptions* to PassRefPtr<PositionOptions>
        where needed.
        (WebCore::Geolocation::GeoNotifier::GeoNotifier):
        (WebCore::Geolocation::GeoNotifier::startTimer):
        (WebCore::Geolocation::getCurrentPosition):
        (WebCore::Geolocation::watchPosition):
        (WebCore::Geolocation::setIsAllowed): Start the timer is the UA allows
        (WebCore::Geolocation::startTimer):
        (WebCore::Geolocation::startTimersForOneShots):
        (WebCore::Geolocation::startTimersForWatchers):
        (WebCore::Geolocation::startTimers):
        * page/Geolocation.h:
        (WebCore::Geolocation::GeoNotifier::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Pamela Greene <pam@chromium.org>
pam@chromium.org [Mon, 13 Apr 2009 18:01:58 +0000 (18:01 +0000)]
2009-04-13  Pamela Greene  <pam@chromium.org>

        Reviewed by Darin Fisher.

        Fix Chromium (V8) build by renaming methods to match changes
        in http://trac.webkit.org/changeset/42377.

        https://bugs.webkit.org/show_bug.cgi?id=25141

        * bindings/v8/ScheduledAction.cpp:
     (WebCore::ScheduledAction::execute): updateRendering() -> updateStyleIfNeeded()
        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::handleEvent): updateDocumentsRendering() -> updateStyleForAllDocuments()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 13 Apr 2009 17:52:42 +0000 (17:52 +0000)]
2009-04-13  Darin Adler  <darin@apple.com>

        * Scripts/make-js-test-wrappers: Added another exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Darin Fisher <darin@chromium.org>
darin@chromium.org [Mon, 13 Apr 2009 17:47:33 +0000 (17:47 +0000)]
2009-04-13  Darin Fisher  <darin@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=25136
        CRASH in DocumentLoader::removeSubresourceLoader due to null m_frame

        Test: fast/frames/frame-unload-crash.html

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::updateLoading): Added null check of m_frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Mon, 13 Apr 2009 17:38:38 +0000 (17:38 +0000)]
WebCore:

2009-04-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Put the MessagePort constructor back in ENABLE_CHANNEL_MESSAGING.

        * page/DOMWindow.idl:

LayoutTests:

2009-04-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Tim Hatcher.

        Update test results after putting the MessagePort constructor
        back in ENABLE_CHANNEL_MESSAGING.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/js/global-constructors-expected.txt:
        * platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Mon, 13 Apr 2009 17:24:20 +0000 (17:24 +0000)]
2009-04-13  Greg Bolsinga  <bolsinga@apple.com>

        Fix GTK build break.

        * platform/gtk/GeolocationServiceGtk.cpp:
        (WebCore::GeolocationServiceGtk::updatePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 13 Apr 2009 17:14:44 +0000 (17:14 +0000)]
2009-04-13  David Hyatt  <hyatt@apple.com>

        Reviewed by Darin Adler and Dan Bernstein.

        Assertion in updateStyleForAllDocuments.  Make sure to unscheduleStyleRecalc when an object goes into
        the page cache.  Disallow scheduling of style recalcs on a document that is already in the page cache.
        Schedule a style recalc if needed when an object comes out of the page cache.

        * dom/Document.cpp:
        (WebCore::Document::scheduleStyleRecalc):
        (WebCore::Document::setInPageCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Correctly sort (program) scripts in the Scripts panel popup menu.
timothy@apple.com [Mon, 13 Apr 2009 17:11:05 +0000 (17:11 +0000)]
    Correctly sort (program) scripts in the Scripts panel popup menu.

        Reviewed by Ada Chan.

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu): Refactor the code
        and sort "(program)" options by the sourceID to maintain some order.
        * inspector/front-end/utilities.js:
        (indexOfObjectInListSortedByFunction): Fix a bug where identical objects would cause
        an incorrect return value that confuses insertionIndexForObjectInListSortedByFunction.
        Just set 'first' and break so the correct result will be returned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Greg Bolsinga <bolsinga@apple.com>
bolsinga@apple.com [Mon, 13 Apr 2009 17:07:26 +0000 (17:07 +0000)]
2009-04-13  Greg Bolsinga  <bolsinga@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24770

        Add custom code for Coordinates that returns null when required by the
        Geolocation spec.

        http://dev.w3.org/geo/api/spec-source.html#coordinates

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSCoordinatesCustom.cpp: Added.
        (WebCore::JSCoordinates::altitude): returns null if the value cannot be provided.
        (WebCore::JSCoordinates::altitudeAccuracy): Ditto
        (WebCore::JSCoordinates::heading): Ditto
        (WebCore::JSCoordinates::speed): Ditto
        * page/Coordinates.h:
        (WebCore::Coordinates::create): Add 'canProvide' parameters and values
        (WebCore::Coordinates::canProvideAltitude):
        (WebCore::Coordinates::canProvideAltitudeAccuracy):
        (WebCore::Coordinates::canProvideHeading):
        (WebCore::Coordinates::canProvideSpeed):
        (WebCore::Coordinates::Coordinates):
        * page/Coordinates.idl: specify custom getters
        * platform/mac/GeolocationServiceMac.mm: Set the values correctly if they cannot be provided.
        (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 13 Apr 2009 16:27:06 +0000 (16:27 +0000)]
2009-04-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=22898
        [GTK] need proper API for printing

        Added simple printing unit tests.

        * tests/testwebframe.c:
        (print_requested_cb):
        (print_timeout):
        (test_webkit_web_frame_printing):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Mon, 13 Apr 2009 16:26:52 +0000 (16:26 +0000)]
2009-04-13  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=22898
        [GTK] need proper API for printing

        Implement proper printing API, using the GTK+ printing API.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::print):
        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:
        * webkit/webkitwebframe.h:
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 13 Apr 2009 16:15:57 +0000 (16:15 +0000)]
2009-04-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Holger Freyther.

        Reworked the skipped tests listing so that it is easier to find
        tests that are skipped but pass using diff. Enable all tests that
        are passing, and disable failing tests except for a few crashers
        and known regressions. This is an effort to make the build slave
        output more useful when it is back.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
adele@apple.com [Mon, 13 Apr 2009 15:12:41 +0000 (15:12 +0000)]
WebCore:

2009-04-13  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line

        Test: editing/inserting/5510537.html

        * editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): If the break insertion position
        is at the beginning of the topmost quote, then just insert the <br> before the blockquote.  Otherwise, if the break
        insertion position is at the beginning of any quote, adjust the position so the break comes before the current quote level
        so we don't end up with an empty line in that quote in addition to the new line we're adding with the <br>.

LayoutTests:

2009-04-13  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Test for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line

        * editing/inserting/5510537.html: Added.
        * platform/mac/editing/inserting/5510537-expected.checksum: Added.
        * platform/mac/editing/inserting/5510537-expected.png: Added.
        * platform/mac/editing/inserting/5510537-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-11 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 13 Apr 2009 14:46:26 +0000 (14:46 +0000)]
2009-04-11  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Fix problem when encoding history files with duplicate integer arrays near the end of the file.
        This results in an assertion failure, and if assertions are turned off, corrupted output.

        When writing an integer array it's important not to add an object reference to the
        aggregate buffer. The writing of the array does not depend on the aggregate buffer. But,
        more importantly, it's possible this instance integer array is a duplicate and won't be
        written out. If so, there's no guarantee there's enough space in the aggregate buffer to
        store the object references (the references will be ignored). In some cases the aggregate
        buffer can then overrun the data being written; normally this is prevented by the fact that
        the data being written will include a copy of the aggregate buffer.

        Also removed a bit of unneeded dead code to handle the integer -1.

        * platform/cf/BinaryPropertyList.cpp:
        (WebCore::BinaryPropertyListPlan::BinaryPropertyListPlan): Removed unneeded
        m_integerNegativeOneObjectReference, since property lists support only non-negative integers.
        (WebCore::BinaryPropertyListPlan::writeInteger): Removed support for
        m_integerNegativeOneObjectReference.
        (WebCore::BinaryPropertyListPlan::integerObjectReference): Ditto.
        (WebCore::BinaryPropertyListSerializer::writeIntegerWithoutAddingAggregateObjectReference):
        Added. Factored out most of writeInteger, for use in writeIntegerArray, without calling
        addAggregateObjectReference.
        (WebCore::BinaryPropertyListSerializer::writeInteger): Changed to call the new
        writeIntegerWithoutAddingAggregateObjectReference function.
        (WebCore::BinaryPropertyListSerializer::writeIntegerArray): Call the new
        writeIntegerWithoutAddingAggregateObjectReference function and therefore remove the
        code to save and restore m_currentAggregateBufferByte, which is no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed Qt build fix
zecke@webkit.org [Mon, 13 Apr 2009 11:31:26 +0000 (11:31 +0000)]
Unreviewed Qt build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Mon, 13 Apr 2009 00:41:41 +0000 (00:41 +0000)]
WebCore:

2009-04-12  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Move the event and crypto attributes and the captureEvents and releaseEvents
        functions out of JSDOMWindowBase by partially generating them.

        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::currentEvent): Make const.
        * bindings/js/JSDOMGlobalObject.h:
        * bindings/js/JSDOMWindowBase.cpp:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::crypto): Not implemented.
        (WebCore::JSDOMWindow::event):
        (WebCore::JSDOMWindow::captureEvents): Not implemented.
        (WebCore::JSDOMWindow::releaseEvents): Ditto.
        * page/DOMWindow.idl:

LayoutTests:

2009-04-12  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Update test result for new nop window.crypto behavior.

        * http/tests/security/cross-frame-access-get-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-12 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sun, 12 Apr 2009 23:42:28 +0000 (23:42 +0000)]
2009-04-12  Sam Weinig  <sam@webkit.org>

        Update results.

        * fast/dom/Window/window-properties-expected.txt:
        * fast/js/global-constructors-expected.txt:
        * platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
weinig@apple.com [Sun, 12 Apr 2009 23:10:36 +0000 (23:10 +0000)]
WebCore:

2009-04-12  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Move more attributes out of JSDOMWindowBase by
        partially generating them.

        - Expose the MessagePort constructor.

        * bindings/js/JSDOMGlobalObject.h:
        (WebCore::getDOMConstructor):
        * bindings/js/JSDOMWindowBase.cpp:
        (setJSDOMWindowBaseEvent):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::image):
        (WebCore::JSDOMWindow::option):
        (WebCore::JSDOMWindow::audio):
        (WebCore::JSDOMWindow::webKitPoint):
        (WebCore::JSDOMWindow::webKitCSSMatrix):
        (WebCore::JSDOMWindow::xMLHttpRequest):
        (WebCore::JSDOMWindow::xSLTProcessor):
        (WebCore::JSDOMWindow::messageChannel):
        (WebCore::JSDOMWindow::worker):
        * page/DOMWindow.idl:

LayoutTests:

2009-04-12  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Update tests after making MessageChannel completely missing when not
        compiling with support for it (and removing it from the tests because
        we never compile with support for it right now) and exposing the MessagePort
        constructor.

        * fast/dom/constructors-cached-expected.txt:
        * fast/dom/dom-constructors-expected.txt:
        * fast/dom/dom-constructors.html:
        * fast/dom/resources/constructors-cached.js:
        * platform/mac-leopard/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago A resource's filename is not correct after a redirect in the Inspector.
timothy@apple.com [Sun, 12 Apr 2009 17:57:28 +0000 (17:57 +0000)]
    A resource's filename is not correct after a redirect in the Inspector.

        Reviewed by Dan Bernstein.

        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::updateScriptObject): Fix a typo in the
        lastPathComponent property name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
adele@apple.com [Sun, 12 Apr 2009 16:24:02 +0000 (16:24 +0000)]
WebCore:

2009-04-12  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Test: editing/inserting/6609479-1.html

        Follow-up to <rdar://problem/6609479>.

        Before my last change, a Mail blockquote would've been broken up earlier, and you would've been guaranteed that the inserted content
        was at the start of a paragraph.  Now we need to check for that explicitly, and only merge the start of the inserted content if it is
        at the start of a paragraph.

        * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart):

LayoutTests:

2009-04-12  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Another test for <rdar://problem/6609479>.  This covers inserting HTML in a quoted table.

        * editing/inserting/6609479-1-expected.txt: Added.
        * editing/inserting/6609479-1.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
adele@apple.com [Sun, 12 Apr 2009 05:49:44 +0000 (05:49 +0000)]
WebCore:

2009-04-11  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table

        Test: editing/inserting/6609479.html

        Don't break a blockquote if pasting or inserting into a table.

        * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
        * editing/TypingCommand.cpp: (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):

LayoutTests:

2009-04-11  Adele Peterson  <adele@apple.com>

        Reviewed by Dan Bernstein.

        Tests for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table

        * editing/inserting/5418891.html: Changed test so it doesn't involve tables.
        * editing/inserting/6609479-expected.txt: Added.
        * editing/inserting/6609479.html: Added.
        * platform/mac/editing/inserting/5418891-expected.checksum:
        * platform/mac/editing/inserting/5418891-expected.png:
        * platform/mac/editing/inserting/5418891-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sun, 12 Apr 2009 01:11:51 +0000 (01:11 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix <rdar://problem/6643103> Unscaled values from body.scrollHeight

        Test: fast/css/zoom-body-scroll.html

        Adjust scroll{Left,Top,Width,Height} values for zoom in getters and
        setters.

        * html/HTMLBodyElement.cpp:
        (WebCore::adjustForZoom):
        (WebCore::HTMLBodyElement::scrollLeft):
        (WebCore::HTMLBodyElement::setScrollLeft):
        (WebCore::HTMLBodyElement::scrollTop):
        (WebCore::HTMLBodyElement::setScrollTop):
        (WebCore::HTMLBodyElement::scrollHeight):
        (WebCore::HTMLBodyElement::scrollWidth):

LayoutTests:

        Reviewed by Darin Adler.

        - test for <rdar://problem/6643103> Unscaled values from body.scrollHeight

        * fast/css/zoom-body-scroll-expected.txt: Added.
        * fast/css/zoom-body-scroll.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Jon Honeycutt.
mitz@apple.com [Sat, 11 Apr 2009 05:40:47 +0000 (05:40 +0000)]
    Reviewed by Jon Honeycutt.

        - fix <rdar://problem/6752340> Light blue-green background in content
          area in Mail

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        Use device white, rather than calibrated white, as the default
        background color.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Allow page navigation and reload while stopped at a breakpoint.
timothy@apple.com [Sat, 11 Apr 2009 05:31:05 +0000 (05:31 +0000)]
    Allow page navigation and reload while stopped at a breakpoint.

        <rdar://problem/6781108> Having a breakpoint active prevents page reload

        Reviewed by Darin Adler.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didContinue): Call the resumedScript function.
        * inspector/InspectorController.h: Added didContinue.
        * inspector/JavaScriptDebugListener.h: Ditto.
        * inspector/JavaScriptDebugServer.cpp:
        (WebCore::JavaScriptDebugServer::pauseIfNeeded): Call didContinue on the listeners.
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.debuggerResumed): Update the interface and state.
        * inspector/front-end/inspector.js:
        (WebInspector.resumedScript): Call ScriptsPanel.debuggerResumed.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Call resumeDebugger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Land corrected results for complex-character-based-fallback.html
aroben@apple.com [Sat, 11 Apr 2009 02:18:18 +0000 (02:18 +0000)]
    Land corrected results for complex-character-based-fallback.html

        * platform/win/fast/text/international/complex-character-based-fallback-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-10 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 11 Apr 2009 00:56:41 +0000 (00:56 +0000)]
2009-04-10  Darin Adler  <darin@apple.com>

        Rubber stamped by Adam Roben.

        Disabled fast/dom/gc-8.html, which was using Timer in an unsafe way that now
        triggers an assertion.

        We'll reenable the test after fixing the problem. But this is a test-only problem.

        * fast/dom/gc-8.html: Removed.
        * fast/dom/gc-8.html-disabled: Copied from fast/dom/gc-8.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago <rdar://problem/6676024> REGRESSION (PB-40B1): Safari crashes on launch on...
sfalken@apple.com [Sat, 11 Apr 2009 00:47:22 +0000 (00:47 +0000)]
    <rdar://problem/6676024> REGRESSION (PB-40B1): Safari crashes on launch on tablet PC

        r21436 changed the semantics of AXObjectCache::get() to not create
        objects on demand. Changing this get() call into a getOrCreate() call
        fixes the crash.

        Rubber stamped by Jon Honeycutt.

        * AccessibleDocument.cpp:
        (AccessibleDocument::AccessibleDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-10 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 11 Apr 2009 00:43:15 +0000 (00:43 +0000)]
2009-04-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Adele Peterson.

        Remove unused include for JSLock.

        * page/mac/FrameMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-10 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 11 Apr 2009 00:41:57 +0000 (00:41 +0000)]
2009-04-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Add back the keepAlive timer for after the script execution to
        protect the callers of evaluate, as was part of the original intent
        of timer.

        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::evaluate):
        * page/mac/FrameMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Sat, 11 Apr 2009 00:39:05 +0000 (00:39 +0000)]
    Reviewed by Anders Carlsson.

        - test and expected result updates following r42379

        * fast/text/offsetForPosition-cluster-at-zero-expected.txt: Updated
        results.
        * fast/text/offsetForPosition-cluster-at-zero.html: Removed
        font-dependent alert that was accidently left in this test.
        * platform/mac-tiger/fast/text/international/thai-line-breaks-expected.checksum:
        * platform/mac-tiger/fast/text/international/thai-line-breaks-expected.png:
        * platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:
        * platform/mac-tiger/fast/text/monospace-width-cache-expected.checksum: Added.
        * platform/mac-tiger/fast/text/monospace-width-cache-expected.png: Added.
        * platform/mac-tiger/fast/text/monospace-width-cache-expected.txt: Added.
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fixed https://bugs.webkit.org/show_bug.cgi?id=25137
cmarrin@apple.com [Sat, 11 Apr 2009 00:26:09 +0000 (00:26 +0000)]
    Fixed https://bugs.webkit.org/show_bug.cgi?id=25137

        If we reload, the animation controller sticks around and has
        a stale animation time. So the needed delay is computed wrong.
        I added a reset of the animation timer on load.

        I did not do a test case because this only happens on reload so I
        couldn't make an automated test. I tried using an iframe and using
        reload() but that doesn't tickle the bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add our new test font to the list that DRT knows about
aroben@apple.com [Sat, 11 Apr 2009 00:13:01 +0000 (00:13 +0000)]
    Add our new test font to the list that DRT knows about

        Reviewed by Dan Bernstein.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (initialize): Added WebKit Layout Tests 2.ttf.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-10 Grace Kloba <klobag@gmail.com>
darin@apple.com [Sat, 11 Apr 2009 00:10:39 +0000 (00:10 +0000)]
2009-04-10  Grace Kloba  <klobag@gmail.com>

        Reviewed by Darin Adler.

        Move WORKERS header files inside ENABLE(WORKERS).
        So if WORKERS is not enabled and the generated files are not generated, the build is still working.

        * bindings/js/JSDOMGlobalObject.cpp:
        * bindings/js/JSMessageChannelConstructor.cpp:
        * bindings/js/ScheduledAction.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Fri, 10 Apr 2009 23:59:39 +0000 (23:59 +0000)]
WebCore:

2009-04-10  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson.

        <rdar://problem/6773515> crash in push_heap inside WebCore when printing

        The crash was due to manipulating a timer on a different thread than the one it was created on.
        This adds some diagnostics so we'll catch that kind of mistake immediately.

        * platform/Timer.cpp:
        (WebCore::TimerBase::TimerBase): Store the thread identifier in debug versions.
        (WebCore::TimerBase::start): Assert it's the same thread the timer was created on.
        (WebCore::TimerBase::stop): Ditto.
        (WebCore::TimerBase::isActive): Ditto.
        (WebCore::TimerBase::setNextFireTime): Ditto.

        * platform/Timer.h: Added the thread identifier data member.

WebKit/mac:

2009-04-10  Darin Adler  <darin@apple.com>

        Reviewed by Brady Eidson.

        <rdar://problem/6773515> crash in push_heap inside WebCore when printing

        The crash was due to manipulating a timer on a different thread than the one it was created on.

        * History/WebHistoryItem.mm:
        (-[WebWindowWatcher windowWillClose:]): Call later on main thread, if called on non-main thread.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView windowDidBecomeKey:]): Ditto.
        (-[WebHTMLView windowDidResignKey:]): Ditto.
        (-[WebHTMLView windowWillClose:]): Ditto.
        (-[WebHTMLView _updateControlTints]): Added. Factored out the non-thread-safe part of
        our override of _windowChangedKeyState.
        (-[WebHTMLView _windowChangedKeyState]): Call _updateControlTints later on main thread, if
        called on non-main thread.
        * WebView/WebPreferences.mm:
        (-[WebPreferences _postPreferencesChangesNotification]): Call later on main thread, if called
        on non-main thread

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Add our invidual IDL files back to Interfaces.vcproj, but disable them
aroben@apple.com [Fri, 10 Apr 2009 23:39:48 +0000 (23:39 +0000)]
    Add our invidual IDL files back to Interfaces.vcproj, but disable them

        This allows the IDL files to be found in Solution Explorer.

        Rubber-stamped in advance by Steve Falkenburg.

        * WebKit.vcproj/Interfaces.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-10 Chris Marrin <cmarrin@apple.com>
simon.fraser@apple.com [Fri, 10 Apr 2009 23:19:00 +0000 (23:19 +0000)]
2009-04-10  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=25108

        If you remove a class with a transition while that transition is running
        the animation timer will continue to fire after the transition is finished.
        This has no visual indication, but it does drain the processor. And in some
        cases it might even cause a glitch in future animations. Unfortunately there
        is no way to test this without putting in printfs.

        This happens because the animation logic is never traversed after a transition
        is removed, so we never get a chance to cleanup. So I added cleanup in the logic
        that fires the dispatch of the last style change when the animation finishes.

        Test: transitions/remove-transition-style.html

        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::updateTransitions):
        (WebCore::CompositeAnimation::animate):
        (WebCore::CompositeAnimation::cleanupFinishedAnimations):
        * page/animation/CompositeAnimation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-10 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 10 Apr 2009 22:52:11 +0000 (22:52 +0000)]
2009-04-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Fix for <rdar://problem/6648858>
        CrashTracer: [REGRESSION(Safari 4)] 60 crashes in Safari at com.apple.WebCore • WebCore::ScriptController::evaluate + 241

        The Frame (and therefore ScriptController) were being destroyed
        during JavaScript execution causing the JSDOMWindowShell to become
        null.

        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::evaluate): Use a RefPtr to protect the Frame
        instead of the keep-alive timer, since a nested event loop used from with-in
        JavaScript execution could cause the timer to fire before returning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Apr 2009 22:27:00 +0000 (22:27 +0000)]
2009-04-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Timothy Hatcher.

        https://bugs.webkit.org/show_bug.cgi?id=25133
        Fix an error in InspectorController's bindings, clean up a few header
        includes, make empty object construction in ScriptObject less ambiguous.

        * bindings/js/JSInspectorControllerCustom.cpp:
        (WebCore::JSInspectorController::setSetting): Send correct argument from
            the bindings.
        * bindings/js/ScriptObject.cpp:
        (WebCore::ScriptObject::createNew): Added.
        * bindings/js/ScriptObject.h: Removed constructor, added decl for createNew.
        * inspector/ConsoleMessage.cpp: Remove unused header.
        * inspector/ConsoleMessage.h: Ditto.
        * inspector/InspectorResource.cpp:
        (WebCore::createHeadersObject): Changed to use ScriptObject::createNew.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Adam Roben.
mitz@apple.com [Fri, 10 Apr 2009 21:50:50 +0000 (21:50 +0000)]
    Reviewed by Adam Roben.

        - re-enable css2.1 tests that were disabled following r42379 and make
          them use a different fallback font for certain characters, to get
          the vertical metrics to match Mac

        * platform/win/Skipped:
        * platform/win/css2.1/resources/Mac-compatible-font-fallback.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fixed https://bugs.webkit.org/show_bug.cgi?id=25134
cmarrin@apple.com [Fri, 10 Apr 2009 21:44:48 +0000 (21:44 +0000)]
    Fixed https://bugs.webkit.org/show_bug.cgi?id=25134

        This both fixes a bug where I was not sending in the right time
        to continue the animation and was not recomputing current time
        when coming out of suspend.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-10 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 10 Apr 2009 20:48:29 +0000 (20:48 +0000)]
2009-04-10  Eric Carlson  <eric.carlson@apple.com>

        WebKitSystemInterface changes for <rdar://problem/6646998>

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRevert an unintentional logic change in r42400.
timothy@apple.com [Fri, 10 Apr 2009 20:41:03 +0000 (20:41 +0000)]
Revert an unintentional logic change in r42400.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 10 Apr 2009 20:17:01 +0000 (20:17 +0000)]
2009-04-10  Simon Fraser  <simon.fraser@apple.com>

        Fix the leopard build by updating WebKitSystemInterface.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.
timothy@apple.com [Fri, 10 Apr 2009 20:07:41 +0000 (20:07 +0000)]
Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.

WebKit:

2009-04-10  Timothy Hatcher  <timothy@apple.com>

        Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.

        Rubber-stamped by Mark Rowe.

        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2009-04-10  Timothy Hatcher  <timothy@apple.com>

        Remove DOMDocumentPrivate.h now that <rdar://problem/6730996> is fixed.

        Rubber-stamped by Mark Rowe.

        * Misc/DOMDocumentPrivate.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Give Windows's <select> popup menus drop shadows
aroben@apple.com [Fri, 10 Apr 2009 20:05:35 +0000 (20:05 +0000)]
    Give Windows's <select> popup menus drop shadows

        Rubber-stamped by Steve Falkenburg.

        No test possible.

        * platform/win/PopupMenuWin.cpp:
        (WebCore::registerPopup): Use the CS_DROPSHADOW window class style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix a bug in the Web Inspector where it would show scripts
timothy@apple.com [Fri, 10 Apr 2009 20:00:15 +0000 (20:00 +0000)]
    Fix a bug in the Web Inspector where it would show scripts
        from previous pages when toggling the debugger off and back on.

        https://bugs.webkit.org/show_bug.cgi?id=25095
        rdar://problem/6769970

        Reviewed by John Sullivan.

        * bindings/js/ScriptCachedFrameData.cpp:
        (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): Null out the
        debugger for the scriptController. This balances the attachDebugger
        that was already in ScriptCachedFrameData::restore.
        (WebCore::ScriptCachedFrameData::restore): Clean up an if statement.
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::clearWindowShell): Clear the debugger from
        the current window before setting the new window.
        * inspector/JavaScriptDebugServer.cpp:
        (WebCore::JavaScriptDebugServer::recompileAllJSFunctions): Only accumulate
        source providers for code associated this as the debugger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-10 Pierre d'Herbemont <pdherbemont@apple.com>
eric.carlson@apple.com [Fri, 10 Apr 2009 19:17:20 +0000 (19:17 +0000)]
2009-04-10  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Adele Peterson.

        <rdar://problem/6646998> Avoid starting QTKitServer if possible

        When possible avoid asking QTKit for the MIME types that require QTKitServer
        when running 64-bit.

        * WebCore.base.exp: Added new entry point.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::addFileTypesToCache): Add an NSArray of types to the cache.
        (WebCore::mimeCommonTypesCache): Add all "common" QTKit types to the cache.
        (WebCore::mimeModernTypesCache): Add only "modern" QTKit types to the cache (this list does
        not start QTKitServer if it is not already running).
        (WebCore::MediaPlayerPrivate::getSupportedTypes): Refactored.
        (WebCore::MediaPlayerPrivate::supportsType): Look in list of "modern" types first to avoid
        starting QTKitServer if possible.

        * platform/mac/WebCoreSystemInterface.h: Add wkQTIncludeOnlyModernMediaFileTypes.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.

2009-04-10  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Adele Peterson.

        <rdar://problem/6646998> Avoid starting QTKitServer if possible

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Init QTIncludeOnlyModernMediaFileTypes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Turn on window animations for <select> popup menus
aroben@apple.com [Fri, 10 Apr 2009 18:55:50 +0000 (18:55 +0000)]
    Turn on window animations for <select> popup menus

        We turned these off back when <select> popup menus were partially
        transparent. Now that they're opaque, there's no reason not to
        animate them.

        Reviewed by Steve Falkenburg.

        No test possible.

        * platform/win/PopupMenuWin.cpp:
        (WebCore::PopupMenu::show): Remove the #ifdef that was disabling the
        window animation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - skip failures following r42379 until they are addressed by code
mitz@apple.com [Fri, 10 Apr 2009 18:39:02 +0000 (18:39 +0000)]
    - skip failures following r42379 until they are addressed by code
          changes or test changes

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Fri, 10 Apr 2009 18:32:50 +0000 (18:32 +0000)]
WebCore:

        Reviewed by Sam Weinig.

        - fix a regression from r42379 which made zero-width characters affect
          line height

        Test: fixes fast/text/wide-zero-width-space.html

        * platform/graphics/mac/FontMacATSUI.mm:
        (WebCore::overrideLayoutOperation): Add to the fallback font list set
        here, and only if the glyph is not zero-width...
        (WebCore::ATSULayoutParameters::initialize): ...instead of doing it
        here. This matches WidthIterator's behavior.

LayoutTests:

        Reviewed by Sam Weinig.

        - revert broken test results that were checked in with r42379, now that
          the regression is fixed

        * platform/mac/fast/text/wide-zero-width-space-expected.checksum:
        * platform/mac/fast/text/wide-zero-width-space-expected.png:
        * platform/mac/fast/text/wide-zero-width-space-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Update Windows results for complex-character-based-fallback.html
aroben@apple.com [Fri, 10 Apr 2009 18:31:55 +0000 (18:31 +0000)]
    Update Windows results for complex-character-based-fallback.html

        Rubber-stamped by Dan Bernstein.

        * platform/win/fast/text/international/complex-character-based-fallback-expected.checksum:
        * platform/win/fast/text/international/complex-character-based-fallback-expected.png:
        * platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
        Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-10 Darin Fisher <darin@chromium.org>
darin@chromium.org [Fri, 10 Apr 2009 17:39:04 +0000 (17:39 +0000)]
2009-04-10  Darin Fisher  <darin@chromium.org>

        Fixing build bustage caused by warnings being treated as errors.
        1- A local variable was only be used inside a debug assertion, which
           caused grief for the release build.
        2- Missing initializer for member 'DocumentMarker::activeMatch'

        * dom/Document.cpp:
        (WebCore::Document::addMarker):
        (WebCore::Document::setMarkersActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-10 Finnur Thorarinsson <finnur.webkit@gmail.com>
darin@chromium.org [Fri, 10 Apr 2009 17:24:22 +0000 (17:24 +0000)]
2009-04-10  Finnur Thorarinsson  <finnur.webkit@gmail.com>

        Reviewed by John Sullivan.

        Fixing: https://bugs.webkit.org/show_bug.cgi?id=25117
        (TextMatches don't have a concept of active match)

        For the ports that use the DocumentMarker as highlighting for FindInPage it is
        useful to have a flag that specifies which marker is active, so it can be drawn
        in a different color.

        This allows me to remove the hack to use the SelectionController to highlight
        the active match (in the ChromiumWin port).

        * dom/Document.cpp:
        (WebCore::Document::setMarkersActive):
        * dom/Document.h:
        * dom/DocumentMarker.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintTextMatchMarker):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::platformActiveTextSearchHighlightColor):
        (WebCore::RenderTheme::platformInactiveTextSearchHighlightColor):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumWin::platformActiveTextSearchHighlightColor):
        (WebCore::RenderThemeChromiumWin::platformInactiveTextSearchHighlightColor):
        * rendering/RenderThemeChromiumWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-10 Pamela Greene <pam@chromium.org>
pam@chromium.org [Fri, 10 Apr 2009 17:13:52 +0000 (17:13 +0000)]
2009-04-10  Pamela Greene  <pam@chromium.org>

        Reviewed by Dimitri Glazkov.

        Build fix for Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=12440

        * page/chromium/FrameChromium.cpp:
        (WebCore::computePageRectsForFrame): change docWidth() to overflowWidth()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/gtk/
kov@webkit.org [Fri, 10 Apr 2009 12:03:02 +0000 (12:03 +0000)]
WebKit/gtk/

2009-04-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=25124
        [GTK] many strings still missing translation calls

        Mark the missing strings for translation.

        * webkit/webkitdownload.cpp:
        (_WebKitDownloadPrivate::webkit_download_cancel):
        * webkit/webkitsoupauthdialog.c:
        (show_auth_dialog):
        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init):
        * webkit/webkitwebinspector.cpp:
        (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
        * webkit/webkitwebnavigationaction.cpp:
        (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init):
        * webkit/webkitwebsettings.cpp:
        (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
        * webkit/webkitwebview.cpp:

WebKit/gtk/po/

2009-04-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Holger Freyther.

        https://bugs.webkit.org/show_bug.cgi?id=25124
        [GTK] many strings still missing translation calls

        Extracting translation for the files that got translation calls.

        * POTFILES:
        * de.po:
        * pt_BR.po:
        * webkit.pot:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - remove two files I just checked in by accident
mitz@apple.com [Fri, 10 Apr 2009 05:42:03 +0000 (05:42 +0000)]
    - remove two files I just checked in by accident

        * platform/mac/fast/events/pointer-events-expected.txt: Removed.
        * platform/mac/fast/events/pointer-events.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Mark Rowe.
mitz@apple.com [Fri, 10 Apr 2009 05:36:11 +0000 (05:36 +0000)]
    Reviewed by Mark Rowe.

        - moved some Leopard-and-earlier results into platform/mac-leopard and
          added new results under platform/mac

        * platform/mac-leopard/fast/text/complex-text-opacity-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.checksum.
        * platform/mac-leopard/fast/text/complex-text-opacity-expected.png: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.png.
        * platform/mac-leopard/fast/text/complex-text-opacity-expected.txt: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.txt.
        * platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum.
        * platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
        * platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
        * platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum.
        * platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png.
        * platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt.
        * platform/mac/fast/events/pointer-events-expected.txt: Added.
        * platform/mac/fast/events/pointer-events.html: Added.
        * platform/mac/fast/text/atsui-multiple-renderers-expected.checksum:
        * platform/mac/fast/text/atsui-multiple-renderers-expected.png:
        * platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
        * platform/mac/fast/text/complex-text-opacity-expected.checksum: Replaced.
        * platform/mac/fast/text/complex-text-opacity-expected.png: Replaced.
        * platform/mac/fast/text/complex-text-opacity-expected.txt: Replaced.
        * platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum: Replaced.
        * platform/mac/fast/text/international/bidi-AN-after-L-expected.png: Replaced.
        * platform/mac/fast/text/international/bidi-AN-after-L-expected.txt: Replaced.
        * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Added.
        * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
        * platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
        * platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum: Added.
        * platform/mac/fast/text/international/bidi-CS-after-AN-expected.png: Added.
        * platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
        * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Replaced.
        * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Replaced.
        * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Replaced.
        * platform/mac/fast/text/international/bidi-neutral-run-expected.checksum: Added.
        * platform/mac/fast/text/international/bidi-neutral-run-expected.png: Added.
        * platform/mac/fast/text/international/bidi-neutral-run-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-09 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 10 Apr 2009 03:58:00 +0000 (03:58 +0000)]
2009-04-09  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Unreviewed Gtk build fix for undefined reference: g_thread_init.
        Add GLIB_LIBS to DRT and GtkLauncher build config.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove two tests from the skipped list now that <rdar://problem/6718460> has been...
mrowe@apple.com [Fri, 10 Apr 2009 03:38:54 +0000 (03:38 +0000)]
Remove two tests from the skipped list now that <rdar://problem/6718460> has been addressed.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSkip a few tests that are currently failing.
mrowe@apple.com [Fri, 10 Apr 2009 03:38:51 +0000 (03:38 +0000)]
Skip a few tests that are currently failing.

Rubber-stamped by Oliver Hunt.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rubber-stamped by Mark Rowe.
mitz@apple.com [Fri, 10 Apr 2009 03:23:09 +0000 (03:23 +0000)]
    Rubber-stamped by Mark Rowe.

        - update Tiger-only test results after r42379

        * platform/mac-tiger/fast/lists/w3-list-styles-expected.txt:
        * platform/mac-tiger/fast/text/cg-fallback-bolding-expected.txt:
        * platform/mac-tiger/fast/text/international/thai-line-breaks-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-09 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 10 Apr 2009 03:15:05 +0000 (03:15 +0000)]
2009-04-09  David Hyatt  <hyatt@apple.com>

        Reviewed by Oliver Hunt

        Add a timer for style recalc (similar to the one used for scheduling layouts).  For now in order
        to reduce the risk of regressions, I have left in all the synchronous machinery for updating style
        following DOM events and JavaScript timeouts.  Eventually these calls will be removed.

        Where the timer will really kick in and be useful is for clients that do style changes from
        Objective-C DOM bindings or that execute JavaScript to manipulate style from the JavaScriptCore C API.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::insertBefore):
        (WebCore::ContainerNode::replaceChild):
        (WebCore::ContainerNode::removeChild):
        (WebCore::ContainerNode::appendChild):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        (WebCore::Document::scheduleStyleRecalc):
        (WebCore::Document::unscheduleStyleRecalc):
        (WebCore::Document::styleRecalcTimerFired):
        (WebCore::Document::updateStyleForAllDocuments):
        (WebCore::Document::detach):
        * dom/Document.h:
        * dom/Node.cpp:
        (WebCore::Node::setNeedsStyleRecalc):
        (WebCore::Node::lazyAttach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoLand Windows-specific results for three forms tests since the Windows results match...
mrowe@apple.com [Fri, 10 Apr 2009 02:24:51 +0000 (02:24 +0000)]
Land Windows-specific results for three forms tests since the Windows results match the Leopard results.

Rubber-stamped by Adam Roben.

* platform/win/fast/forms/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/file-input-disabled-expected.txt.
* platform/win/fast/forms/input-text-maxlength-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt.
* platform/win/fast/forms/input-text-paste-maxlength-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6586787> JS debugger does not work in 64-bit
oliver@apple.com [Fri, 10 Apr 2009 01:49:53 +0000 (01:49 +0000)]
<rdar://problem/6586787> JS debugger does not work in 64-bit

Reviewed by Gavin Barraclough

Don't truncate the source id in JSCallFrame

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows part 1 of <rdar://problem/5438063> Saving history containing 100,000 entries...
aroben@apple.com [Fri, 10 Apr 2009 01:17:25 +0000 (01:17 +0000)]
Windows part 1 of <rdar://problem/5438063> Saving history containing 100,000 entries causes pauses of 2s while browsing

WebCore:

        Start compiling HistoryPropertyList on Windows

        Reviewed by Darin Adler.

        * WebCore.vcproj/WebCore.vcproj: Added HistoryPropertyList and its
        dependencies to the project. Copy headers from history/cf to
        $WebKitOutputDir.
        * history/cf/HistoryPropertyList.cpp: Added StringExtras.h so that
        this file will compile on Windows.

WebKit/win:

        Windows part 1 of <rdar://problem/5438063> Saving history containing
        100,000 entries causes pauses of 2s while browsing

        Use HistoryPropertyListWriter to implement IWebHistory::saveToURL.

        Reviewed by Darin Adler.

        * WebHistory.cpp:
        (WebHistoryWriter::WebHistoryWriter): Added.
        (WebHistoryWriter::writeHistoryItems): Added. Loop backwards through
        the entries for each date, and pass the corresponding
        WebCore::HistoryItem to writeHistoryItem.
        (WebHistory::saveHistoryGuts): Use WebHistoryWriter to serialize
        m_entriesByDate, then write the serialized data to disk using
        CFWriteStream.

        * WebHistory.h: Removed datesArray.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUpdate test results to account for a slight change in +[NSColor disabledControlTextCo...
mrowe@apple.com [Fri, 10 Apr 2009 01:13:39 +0000 (01:13 +0000)]
Update test results to account for a slight change in +[NSColor disabledControlTextColor].

Rubber-stamped by Dan Bernstein.

* platform/mac-leopard/fast/forms/disabled-select-change-index-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.checksum.
* platform/mac-leopard/fast/forms/disabled-select-change-index-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.png.
* platform/mac-leopard/fast/forms/disabled-select-change-index-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.txt.
* platform/mac-leopard/fast/forms/file-input-disabled-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.checksum.
* platform/mac-leopard/fast/forms/file-input-disabled-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.png.
* platform/mac-leopard/fast/forms/file-input-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file-input-disabled-expected.txt.
* platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.checksum.
* platform/mac-leopard/fast/forms/input-text-maxlength-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.png.
* platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-maxlength-expected.txt.
* platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum: Renamed from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.checksum.
* platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.png.
* platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-paste-maxlength-expected.txt.
* platform/mac/fast/forms/disabled-select-change-index-expected.txt:
* platform/mac/fast/forms/file-input-disabled-expected.txt:
* platform/mac/fast/forms/input-text-maxlength-expected.txt:
* platform/mac/fast/forms/input-text-paste-maxlength-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Fri, 10 Apr 2009 01:00:20 +0000 (01:00 +0000)]
WebCore:

2009-04-09  Dan Bernstein  <mitz@apple.com>

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6166612> Text boxes' metrics should be based on
          the actual fonts used in them, not just the primary font

        Covered by many existing layout tests

        * platform/graphics/Font.cpp:
        (WebCore::Font::floatWidth): Added a fallbackFonts parameter. If the
        platform supports collecting fallback fonts in its complex font path
        and fallbackFonts is not null, all fallback fonts used for the text run
        will be added to it.

        * platform/graphics/Font.h:
        (WebCore::Font::width): Ditto.

        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::glyphDataForCharacter): Removed an unnecessary namespace
        qualifier.
        (WebCore::Font::floatWidthForSimpleText): Added a fallbackFonts
        parameter, which is passed down to WidthIterator.

        * platform/graphics/WidthIterator.cpp:
        (WebCore::WidthIterator::WidthIterator): Added a fallbackFonts parameter
        and used it to initialize the m_fallbackFonts member.
        (WebCore::WidthIterator::advance): Track the fonts being used and add
        any fallback fonts to the m_fallbackFonts set. Make sure to only add
        non-small-caps fonts.

        * platform/graphics/WidthIterator.h:

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
        implementation that returns false, meaning this platform's
        implementation of floatWidthForComplexText() does not populate the
        fallbackFonts set.
        (WebCore::Font::floatWidthForComplexText): Updated for the new
        prototype.

        * platform/graphics/chromium/FontLinux.cpp: Ditto.

        * platform/graphics/gtk/FontGtk.cpp: Ditto.

        * platform/graphics/mac/CoreTextController.cpp:
        (WebCore::CoreTextController::CoreTextController): Added a fallbackFonts
        parameter and used it to initialize the m_fallbackFonts member.
        (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Add
        fallback fonts to m_fallbackFonts.

        * platform/graphics/mac/CoreTextController.h:

        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
        implementation that returns true, indicating that the Mac
        implementations of floatWidthForComplexText() populate the fallbackFonts
        set.
        * platform/graphics/mac/FontMacATSUI.mm:
        (WebCore::ATSULayoutParameters::ATSULayoutParameters): Added a
        fallbackFonts parameter and used it to initialize the m_fallbackFonts
        member.
        (WebCore::ATSULayoutParameters::initialize): Add fallback fonts to
        m_fallbackFonts.
        (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
        parameter, which is passed down to ATSULayoutParameters.

        * platform/graphics/mac/FontMacCoreText.cpp:
        (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
        parameter, which is passed down to CoreTextController.

        * platform/graphics/win/FontWin.cpp:
        (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
        implementation that returns true, indicating that the
        UniscribeController-based implementations of floatWidthForComplexText()
        populate the fallbackFonts set.
        (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
        parameter, which is passed down to UniscribeController.

        * platform/graphics/win/UniscribeController.cpp:
        (WebCore::UniscribeController::UniscribeController): Added a
        fallbackfonts parameter and used it to initialize m_fallbackFonts.
        (WebCore::UniscribeController::advance): Add fallback fonts to
        m_fallbackFonts.

        * platform/graphics/win/UniscribeController.h:

        * platform/graphics/wx/FontWx.cpp:
        (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
        implementation that returns false, meaning this platform's
        implementation of floatWidthForComplexText() does not populate the
        fallbackFonts set.
        (WebCore::Font::floatWidthForComplexText): Updated for the new
        prototype.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::computeLogicalBoxHeights): For an InlineTextBox
        with multiple fonts, compute a common baseline and line height by
        considering all fonts' ascents and descents (and line spacing, if
        applicable).

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::setFallbackFonts): Added. Temporarily stores
        the set of fallback fonts in a vector.
        (WebCore::InlineTextBox::takeFallbackFonts): Added. Returns the fallback
        fonts previously stored and removes them from storage.

        * rendering/InlineTextBox.h:

        * rendering/RenderText.cpp:
        (WebCore::RenderText::RenderText): Initialized the
        m_knownNotToUseFallbackFonts to false.
        (WebCore::RenderText::styleDidChange): Reset
        m_knownNotToUseFallbackFonts to false if the style difference is such that
        affects layout.
        (WebCore::RenderText::widthFromCache): Added a fallbackFonts parameter,
        which is passed down to Font::width().
        (WebCore::RenderText::trimmedPrefWidths): Updated for the change to
        widthFromCache().
        (WebCore::RenderText::calcPrefWidths): Made this call a private version
        of calcPrefWidths() that takes a fallbackFonts parameter and set the
        m_knownNotToUseFallbackFonts to true if the set comes back empty.
        The private version passes the fallbackFonts set to widthFromCache().
        (WebCore::RenderText::setText): Reset m_knownNotToUseFallbackFonts to
        false.
        (WebCore::RenderText::createFallbackFontMetricsBox): Added.
        (WebCore::RenderText::width): Added a fallbackFonts parameter, which is
        passed down to calcPrefWidths(), widthFromCache() and Font::width().
        Set m_knownNotToUseFallbackFonts to true when appropriate.

        * rendering/RenderText.h:

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::constructLine): Added an assertion and a continue
        statement to remove one level of indentation.
        (WebCore::RenderBlock::computeHorizontalPositionsForLine): Temporarily
        store the set of fallback fonts in the InlineTextBox.
        (WebCore::RenderBlock::computeVerticalPositionsForLine): Added an
        assertion.

LayoutTests:

2009-04-09  Dan Bernstein  <mitz@apple.com>

        Reviewed by Dave Hyatt.

        - updated results for <rdar://problem/6166612> Text boxes' metrics should be based on
          the actual fonts used in them, not just the primary font

        * editing/selection/extend-selection-bidi-expected.txt:
        * fast/text/offsetForPosition-cluster-at-zero-expected.txt:
        * platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.checksum:
        * platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.png:
        * platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.txt:
        * platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
        * platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.png:
        * platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt:
        * platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.checksum:
        * platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.png:
        * platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt:
        * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum:
        * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png:
        * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
        * platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
        * platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
        * platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
        * platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
        * platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
        * platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
        * platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
        * platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
        * platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
        * platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
        * platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
        * platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
        * platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
        * platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
        * platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
        * platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
        * platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
        * platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
        * platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum:
        * platform/mac/css2.1/t0905-c414-flt-02-c-expected.png:
        * platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
        * platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum:
        * platform/mac/css2.1/t0905-c414-flt-03-c-expected.png:
        * platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
        * platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum:
        * platform/mac/css2.1/t0905-c414-flt-04-c-expected.png:
        * platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
        * platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
        * platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
        * platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
        * platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
        * platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png:
        * platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
        * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
        * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
        * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
        * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
        * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
        * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
        * platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum:
        * platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
        * platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
        * platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
        * platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
        * platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
        * platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum:
        * platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
        * platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
        * platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum:
        * platform/mac/css2.1/t090501-c414-flt-01-b-expected.png:
        * platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt:
        * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
        * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
        * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
        * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
        * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
        * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
        * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
        * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
        * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
        * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
        * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
        * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
        * platform/mac/css2.1/t1202-counter-03-b-expected.checksum:
        * platform/mac/css2.1/t1202-counter-03-b-expected.png:
        * platform/mac/css2.1/t1202-counter-03-b-expected.txt:
        * platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
        * platform/mac/css2.1/t1202-counter-04-b-expected.png:
        * platform/mac/css2.1/t1202-counter-04-b-expected.txt:
        * platform/mac/css2.1/t1202-counter-09-b-expected.checksum:
        * platform/mac/css2.1/t1202-counter-09-b-expected.png:
        * platform/mac/css2.1/t1202-counter-09-b-expected.txt:
        * platform/mac/css2.1/t1202-counters-03-b-expected.checksum:
        * platform/mac/css2.1/t1202-counters-03-b-expected.png:
        * platform/mac/css2.1/t1202-counters-03-b-expected.txt:
        * platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
        * platform/mac/css2.1/t1202-counters-04-b-expected.png:
        * platform/mac/css2.1/t1202-counters-04-b-expected.txt:
        * platform/mac/css2.1/t1202-counters-09-b-expected.checksum:
        * platform/mac/css2.1/t1202-counters-09-b-expected.png:
        * platform/mac/css2.1/t1202-counters-09-b-expected.txt:
        * platform/mac/editing/deleting/5144139-2-expected.checksum:
        * platform/mac/editing/deleting/5144139-2-expected.png:
        * platform/mac/editing/deleting/5144139-2-expected.txt:
        * platform/mac/editing/input/devanagari-ligature-expected.checksum:
        * platform/mac/editing/input/devanagari-ligature-expected.png:
        * platform/mac/editing/input/devanagari-ligature-expected.txt:
        * platform/mac/editing/pasteboard/copy-paste-bidi-expected.checksum:
        * platform/mac/editing/pasteboard/copy-paste-bidi-expected.png:
        * platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
        * platform/mac/editing/selection/caret-rtl-2-expected.checksum:
        * platform/mac/editing/selection/caret-rtl-2-expected.png:
        * platform/mac/editing/selection/caret-rtl-2-expected.txt:
        * platform/mac/editing/selection/caret-rtl-expected.checksum:
        * platform/mac/editing/selection/caret-rtl-expected.png:
        * platform/mac/editing/selection/caret-rtl-expected.txt:
        * platform/mac/editing/selection/extend-selection-bidi-expected.checksum:
        * platform/mac/editing/selection/extend-selection-bidi-expected.png:
        * platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum:
        * platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png:
        * platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt:
        * platform/mac/fast/css/rtl-ordering-expected.checksum:
        * platform/mac/fast/css/rtl-ordering-expected.png:
        * platform/mac/fast/css/rtl-ordering-expected.txt:
        * platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
        * platform/mac/fast/css/text-overflow-ellipsis-expected.png:
        * platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
        * platform/mac/fast/css/text-security-expected.checksum:
        * platform/mac/fast/css/text-security-expected.png:
        * platform/mac/fast/css/text-security-expected.txt:
        * platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
        * platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
        * platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
        * platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
        * platform/mac/fast/encoding/invalid-UTF-8-expected.png:
        * platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
        * platform/mac/fast/events/updateLayoutForHitTest-expected.checksum:
        * platform/mac/fast/events/updateLayoutForHitTest-expected.png:
        * platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
        * platform/mac/fast/forms/select-visual-hebrew-expected.checksum:
        * platform/mac/fast/forms/select-visual-hebrew-expected.png:
        * platform/mac/fast/forms/select-visual-hebrew-expected.txt:
        * platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
        * platform/mac/fast/forms/select-writing-direction-natural-expected.png:
        * platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
        * platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
        * platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
        * platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
        * platform/mac/fast/lists/w3-list-styles-expected.checksum:
        * platform/mac/fast/lists/w3-list-styles-expected.png:
        * platform/mac/fast/lists/w3-list-styles-expected.txt:
        * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
        * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
        * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
        * platform/mac/fast/text/capitalize-boundaries-expected.checksum:
        * platform/mac/fast/text/capitalize-boundaries-expected.png:
        * platform/mac/fast/text/capitalize-boundaries-expected.txt:
        * platform/mac/fast/text/cg-fallback-bolding-expected.checksum:
        * platform/mac/fast/text/cg-fallback-bolding-expected.png:
        * platform/mac/fast/text/cg-fallback-bolding-expected.txt:
        * platform/mac/fast/text/complex-text-opacity-expected.checksum:
        * platform/mac/fast/text/complex-text-opacity-expected.png:
        * platform/mac/fast/text/complex-text-opacity-expected.txt:
        * platform/mac/fast/text/in-rendered-text-rtl-expected.checksum:
        * platform/mac/fast/text/in-rendered-text-rtl-expected.png:
        * platform/mac/fast/text/in-rendered-text-rtl-expected.txt:
        * platform/mac/fast/text/international/001-expected.checksum:
        * platform/mac/fast/text/international/001-expected.png:
        * platform/mac/fast/text/international/001-expected.txt:
        * platform/mac/fast/text/international/002-expected.checksum:
        * platform/mac/fast/text/international/002-expected.png:
        * platform/mac/fast/text/international/002-expected.txt:
        * platform/mac/fast/text/international/003-expected.checksum:
        * platform/mac/fast/text/international/003-expected.png:
        * platform/mac/fast/text/international/003-expected.txt:
        * platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
        * platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
        * platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
        * platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum:
        * platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png:
        * platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt:
        * platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
        * platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
        * platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
        * platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
        * platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
        * platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
        * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
        * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
        * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
        * platform/mac/fast/text/international/bidi-european-terminators-expected.checksum:
        * platform/mac/fast/text/international/bidi-european-terminators-expected.png:
        * platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
        * platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum:
        * platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png:
        * platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt:
        * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
        * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
        * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
        * platform/mac/fast/text/international/bidi-innertext-expected.checksum:
        * platform/mac/fast/text/international/bidi-innertext-expected.png:
        * platform/mac/fast/text/international/bidi-innertext-expected.txt:
        * platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
        * platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
        * platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
        * platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
        * platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
        * platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
        * platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
        * platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
        * platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
        * platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum:
        * platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
        * platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
        * platform/mac/fast/text/international/bidi-listbox-expected.checksum:
        * platform/mac/fast/text/international/bidi-listbox-expected.png:
        * platform/mac/fast/text/international/bidi-listbox-expected.txt:
        * platform/mac/fast/text/international/bidi-menulist-expected.checksum:
        * platform/mac/fast/text/international/bidi-menulist-expected.png:
        * platform/mac/fast/text/international/bidi-menulist-expected.txt:
        * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
        * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
        * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
        * platform/mac/fast/text/international/bidi-override-expected.checksum:
        * platform/mac/fast/text/international/bidi-override-expected.png:
        * platform/mac/fast/text/international/bidi-override-expected.txt:
        * platform/mac/fast/text/international/hindi-spacing-expected.checksum:
        * platform/mac/fast/text/international/hindi-spacing-expected.png:
        * platform/mac/fast/text/international/hindi-spacing-expected.txt:
        * platform/mac/fast/text/international/rtl-caret-expected.checksum:
        * platform/mac/fast/text/international/rtl-caret-expected.png:
        * platform/mac/fast/text/international/rtl-caret-expected.txt:
        * platform/mac/fast/text/international/thai-line-breaks-expected.checksum:
        * platform/mac/fast/text/international/thai-line-breaks-expected.png:
        * platform/mac/fast/text/international/thai-line-breaks-expected.txt:
        * platform/mac/fast/text/international/wrap-CJK-001-expected.checksum:
        * platform/mac/fast/text/international/wrap-CJK-001-expected.png:
        * platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
        * platform/mac/fast/text/wide-zero-width-space-expected.checksum:
        * platform/mac/fast/text/wide-zero-width-space-expected.png:
        * platform/mac/fast/text/wide-zero-width-space-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Hyatt.
kdecker@apple.com [Fri, 10 Apr 2009 00:24:44 +0000 (00:24 +0000)]
    Reviewed by Hyatt.

        <rdar://problem/4680397> tearing seen because deferred updates are disabled

        * WebView/WebFrameView.mm:
        (-[WebFrameView initWithFrame:]): Don't call WKDisableCGDeferredUpdates on post-Leopard if
        NSAppKitVersionNumberWithDeferredWindowDisplaySupport is defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-09 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Fri, 10 Apr 2009 00:05:02 +0000 (00:05 +0000)]
2009-04-09  David Hyatt  <hyatt@apple.com>

        Reviewed by Adam Roben

        Rename all of the changed()/setChanged()/setDocumentChanged() methods to mention style recalc
        explicitly instead.

        * bindings/js/JSCustomPositionCallback.cpp:
        (WebCore::JSCustomPositionCallback::handleEvent):
        * bindings/js/JSCustomPositionErrorCallback.cpp:
        (WebCore::JSCustomPositionErrorCallback::handleEvent):
        * bindings/js/JSCustomSQLStatementCallback.cpp:
        (WebCore::JSCustomSQLStatementCallback::handleEvent):
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        (WebCore::JSCustomSQLTransactionCallback::handleEvent):
        * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
        (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
        * bindings/js/JSCustomVoidCallback.cpp:
        (WebCore::JSCustomVoidCallback::handleEvent):
        * bindings/js/JSCustomXPathNSResolver.cpp:
        (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSAbstractEventListener::handleEvent):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):
        * bindings/js/ScriptControllerMac.mm:
        (WebCore::updateStyleIfNeededForBindings):
        (WebCore::ScriptController::initJavaJSBindings):
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::removeProperty):
        (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
        (WebCore::CSSMutableStyleDeclaration::setProperty):
        (WebCore::CSSMutableStyleDeclaration::setStringProperty):
        (WebCore::CSSMutableStyleDeclaration::setImageProperty):
        (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
        (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
        (WebCore::CSSMutableStyleDeclaration::setCssText):
        (WebCore::CSSMutableStyleDeclaration::merge):
        (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
        * css/CSSMutableStyleDeclaration.h:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::allVisitedStateChanged):
        (WebCore::CSSStyleSelector::SelectorChecker::visitedStateChanged):
        * css/CSSVariablesDeclaration.cpp:
        (WebCore::CSSVariablesDeclaration::removeVariable):
        (WebCore::CSSVariablesDeclaration::setVariable):
        (WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc):
        * css/CSSVariablesDeclaration.h:
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::insertBefore):
        (WebCore::ContainerNode::replaceChild):
        (WebCore::ContainerNode::removeChild):
        (WebCore::ContainerNode::appendChild):
        (WebCore::ContainerNode::detach):
        (WebCore::ContainerNode::setFocus):
        (WebCore::ContainerNode::setActive):
        (WebCore::ContainerNode::setHovered):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        (WebCore::Document::scheduleStyleRecalc):
        (WebCore::Document::unscheduleStyleRecalc):
        (WebCore::Document::recalcStyle):
        (WebCore::Document::updateStyleIfNeeded):
        (WebCore::Document::updateStyleForAllDocuments):
        (WebCore::Document::updateLayout):
        (WebCore::Document::implicitClose):
        (WebCore::Document::prepareMouseEvent):
        (WebCore::Document::setFocusedNode):
        (WebCore::Document::setCSSTarget):
        * dom/Document.h:
        * dom/Element.cpp:
        (WebCore::Element::recalcStyle):
        (WebCore::checkForSiblingStyleChanges):
        * dom/InputElement.cpp:
        (WebCore::InputElement::parseMaxLengthAttribute):
        * dom/MouseRelatedEvent.cpp:
        (WebCore::MouseRelatedEvent::receivedTarget):
        * dom/Node.cpp:
        (WebCore::Node::Node):
        (WebCore::Node::setNeedsStyleRecalc):
        (WebCore::Node::lazyAttach):
        (WebCore::Node::dispatchGenericEvent):
        * dom/Node.h:
        (WebCore::Node::needsStyleRecalc):
        (WebCore::Node::childNeedsStyleRecalc):
        (WebCore::Node::setChildNeedsStyleRecalc):
        * dom/OptionElement.cpp:
        (WebCore::OptionElement::setSelectedState):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElementData::evaluateScript):
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::attributeChanged):
        (WebCore::StyledElement::classAttributeChanged):
        (WebCore::StyledElement::parseMappedAttribute):
        * dom/Text.cpp:
        (WebCore::Text::recalcStyle):
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::insertErrorMessageBlock):
        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::enable):
        * editing/Editor.cpp:
        (WebCore::Editor::setBaseWritingDirection):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::nodeWillBeRemoved):
        (WebCore::SelectionController::layout):
        (WebCore::SelectionController::focusedOrActiveStateChanged):
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::parseMappedAttribute):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::setInnerText):
        (WebCore::HTMLElement::isContentEditable):
        (WebCore::HTMLElement::isContentRichlyEditable):
        (WebCore::HTMLElement::contentEditable):
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::updateWidget):
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::parseMappedAttribute):
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::parseMappedAttribute):
        (WebCore::HTMLFrameSetElement::recalcStyle):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseMappedAttribute):
        (WebCore::HTMLInputElement::setChecked):
        (WebCore::HTMLInputElement::setIndeterminate):
        (WebCore::HTMLInputElement::setValue):
        (WebCore::HTMLInputElement::setAutofilled):
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::finishParsingChildren):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::updateWidget):
        (WebCore::HTMLObjectElement::finishParsingChildren):
        (WebCore::HTMLObjectElement::childrenChanged):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::recalcStyle):
        (WebCore::HTMLSelectElement::restoreState):
        (WebCore::HTMLSelectElement::setRecalcListItems):
        (WebCore::HTMLSelectElement::reset):
        (WebCore::HTMLSelectElement::typeAheadFind):
        * html/HTMLTableElement.cpp:
        (WebCore::setTableCellsChanged):
        (WebCore::HTMLTableElement::parseMappedAttribute):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::setValue):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading):
        (WebCore::FrameLoader::executeScript):
        (WebCore::FrameLoader::gotoAnchor):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::alert):
        (WebCore::DOMWindow::confirm):
        (WebCore::DOMWindow::prompt):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::hoverTimerFired):
        * page/FrameView.cpp:
        (WebCore::FrameView::layout):
        (WebCore::FrameView::needsLayout):
        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::setNeedsStyleRecalc):
        (WebCore::AnimationBase::updateStateMachine):
        * page/animation/AnimationBase.h:
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
        (WebCore::AnimationControllerPrivate::clear):
        (WebCore::AnimationControllerPrivate::updateAnimationTimer):
        (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
        (WebCore::AnimationControllerPrivate::startupdateStyleIfNeededDispatcher):
        (WebCore::AnimationControllerPrivate::addEventToDispatch):
        (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
        (WebCore::AnimationControllerPrivate::animationTimerFired):
        (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
        (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
        (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
        (WebCore::AnimationController::cancelAnimations):
        * page/animation/AnimationControllerPrivate.h:
        * page/animation/ImplicitAnimation.cpp:
        (WebCore::ImplicitAnimation::sendTransitionEvent):
        * page/animation/KeyframeAnimation.cpp:
        (WebCore::KeyframeAnimation::endAnimation):
        (WebCore::KeyframeAnimation::sendAnimationEvent):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::updateDragState):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::selectionBounds):
        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::svgAttributeChanged):
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
        * svg/SVGCursorElement.cpp:
        (WebCore::SVGCursorElement::svgAttributeChanged):
        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::setNeedsUpdate):
        * svg/SVGForeignObjectElement.cpp:
        (WebCore::addCSSPropertyAndNotifyAttributeMap):
        * svg/SVGStopElement.cpp:
        (WebCore::SVGStopElement::parseMappedAttribute):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::parseMappedAttribute):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::svgAttributeChanged):
        (WebCore::SVGUseElement::childrenChanged):
        (WebCore::SVGUseElement::recalcStyle):
        * svg/animation/SMILTimeContainer.cpp:
        (WebCore::SMILTimeContainer::updateAnimations):
        * wml/WMLAElement.cpp:
        (WebCore::WMLAElement::parseMappedAttribute):
        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::setValue):
        (WebCore::WMLInputElement::parseMappedAttribute):
        * wml/WMLNoopElement.cpp:
        (WebCore::WMLNoopElement::insertedIntoDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-09 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Thu, 9 Apr 2009 23:53:16 +0000 (23:53 +0000)]
2009-04-09  John Sullivan  <sullivan@apple.com>

        <rdar://problem/6775682> WebKit's support for SnowLeopard sudden termination for
        downloads is broken and should be removed

        Reviewed by Darin Adler

        * Misc/WebDownload.m:
        (-[WebDownloadInternal downloadDidBegin:]):
        remove disableSuddenTermination call
        (-[WebDownloadInternal downloadDidFinish:]):
        remove enableSuddenTermination call
        (-[WebDownloadInternal download:didFailWithError:]):
        remove enableSuddenTermination call

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-04-09 Brett Wilson <brettw@chromium.org>
brettw@chromium.org [Thu, 9 Apr 2009 23:52:45 +0000 (23:52 +0000)]
2009-04-09  Brett Wilson  <brettw@chromium.org>

        Reviewed by NOBODY (OOPS!).

        When there is a shadow set but it specifies "no shadow", clear the
        shadow shader. This will prevent Chromium from thinking there's a
        shadow and using the Skia codepath rather than Windows.

        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::setPlatformShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Simon Fraser.
eric@webkit.org [Thu, 9 Apr 2009 23:01:55 +0000 (23:01 +0000)]
    Reviewed by Simon Fraser.

        Crash when accessing svg.viewport on a detached SVGSVGElement
        https://bugs.webkit.org/show_bug.cgi?id=25105

        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::isOutermostSVG): return "true" that we are the "outermost" SVG element if we have no parent.  (The spec is unclear as t
o what behavior we should have in this case, and I doubt anyone cares for now).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42374 268f45cc-cd09-0410-ab3c-d52691b4dbfc