WebKit-https.git
4 years agoUnreviewed, rolling out r190520, some tests assert / crash.
joepeck@webkit.org [Fri, 2 Oct 2015 22:24:07 +0000 (22:24 +0000)]
Unreviewed, rolling out r190520, some tests assert / crash.

Source/JavaScriptCore:

* CMakeLists.txt:
* DerivedSources.make:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Heap.cpp:
(JSC::Heap::willStartCollection): Deleted.
(JSC::Heap::didFinishCollection): Deleted.
* heap/Heap.h:
(JSC::Heap::addObserver): Deleted.
(JSC::Heap::removeObserver): Deleted.
* heap/HeapObserver.h: Removed.
* heap/MarkedSpace.h:
* inspector/InspectorEnvironment.h:
* inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::vm): Deleted.
* inspector/JSGlobalObjectInspectorController.h:
* inspector/agents/InspectorHeapAgent.cpp: Removed.
* inspector/agents/InspectorHeapAgent.h: Removed.
* inspector/protocol/Heap.json: Removed.

Source/WebCore:

* ForwardingHeaders/heap/HeapObserver.h: Removed.
* ForwardingHeaders/inspector/agents/InspectorHeapAgent.h: Removed.
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController): Deleted.
(WebCore::InspectorController::vm): Deleted.
* inspector/InspectorController.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::vm): Deleted.
* inspector/WorkerInspectorController.h:

Source/WebInspectorUI:

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Main.js:
(WebInspector.loaded): Deleted.
* UserInterface/Base/Utilities.js:
(value): Deleted.
* UserInterface/Controllers/HeapManager.js: Removed.
* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager): Deleted.
(WebInspector.TimelineManager.prototype._garbageCollected): Deleted.
* UserInterface/Images/TimelineRecordGarbageCollection.svg: Removed.
* UserInterface/Main.html:
* UserInterface/Models/GarbageCollection.js: Removed.
* UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.EventType.displayName):
(WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection): Deleted.
* UserInterface/Protocol/HeapObserver.js: Removed.
* UserInterface/Test.html:
* UserInterface/Test/Test.js:
(WebInspector.loaded): Deleted.
* UserInterface/Views/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
(WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent): Deleted.
(WebInspector.ScriptTimelineDataGridNode): Deleted.
* UserInterface/Views/ScriptTimelineOverviewGraph.js:
(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
* UserInterface/Views/ScriptTimelineView.js:
(WebInspector.ScriptTimelineView.prototype._processPendingRecords):
* UserInterface/Views/SourceCodeTimelineTreeElement.js:
(WebInspector.SourceCodeTimelineTreeElement):
* UserInterface/Views/TimelineIcons.css:
(.garbage-collection-profile-record .icon): Deleted.
* UserInterface/Views/TimelineRecordBar.css:
(.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment): Deleted.
* UserInterface/Views/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar.createCombinedBars):
* UserInterface/Views/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement):

LayoutTests:

* inspector/heap/garbageCollected-expected.txt: Removed.
* inspector/heap/garbageCollected.html: Removed.
* inspector/heap/gc-expected.txt: Removed.
* inspector/heap/gc.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd the test runner for a new a graphics benchmark
commit-queue@webkit.org [Fri, 2 Oct 2015 22:15:22 +0000 (22:15 +0000)]
Add the test runner for a new a graphics benchmark
https://bugs.webkit.org/show_bug.cgi?id=149683

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-02
Reviewed by Ryosuke Niwa.

The test runner collects the selected test suites and the running options
from its home page. It loops through all the tests, runs them and collects
their running results. At the end, it shows summary results and a final
score. It can also show a chart for a test sampled data.

* Animometer: Added.
* Animometer/runner: Added.
* Animometer/runner/resources: Added.

* Animometer/runner/animometer.html: Added.
* Animometer/runner/resources/animometer.css: Added.
The benchmark runner page and css.

* Animometer/runner/resources/animometer.js: Added.
(window.benchmarkRunnerClient.willAddTestFrame): Called after the test <iframe> is created.
(window.benchmarkRunnerClient.didRunTest): Called after running a test is finished.
(window.benchmarkRunnerClient.willStartFirstIteration): Called at the beginning before running any test.
(window.benchmarkRunnerClient.didRunSuites): Called after running all tests of a suite.
(window.benchmarkRunnerClient.didFinishLastIteration): Called after running the last test.

(showSection): Shows a section in the animometer.html page.
(startTest): Called when the "Start Test" button is clicked.
(showResults): Called after finishing all the tests.
(showGraph): Called when "Click..." button in the "Samples" column of the results table is clicked

* Animometer/runner/resources/benchmark-runner.js: Copied from PerformanceTests/Speedometer/resources/benchmark-runner.js.
(BenchmarkRunnerState): Tracks the current running <suite, test>
(BenchmarkRunnerState.prototype.currentSuite): Returns the current running suite.
(BenchmarkRunnerState.prototype.currentTest): Returns the current running test.
(BenchmarkRunnerState.prototype.isFirstTest): Returns true if we are running the first test in the current suite.
(BenchmarkRunnerState.prototype.next): Advances to the next test.
(BenchmarkRunnerState.prototype.prepareCurrentTest): Creates a new <iframe> and waits for it to load a test.

(BenchmarkRunner): Manages running the tests and communicating with the benchmarkRunnerClient.
(BenchmarkRunner.prototype.waitForElement): Waits for an element to be created.
(BenchmarkRunner.prototype._appendFrame): Creates a new <iframe> element.
(BenchmarkRunner.prototype._removeFrame): Removed the current <iframe> element.
(BenchmarkRunner.prototype._runTestAndRecordResults): Runs the current test and saves its results.
(BenchmarkRunner.prototype.step): Either runs the current test if there is or start a new iteration.
(BenchmarkRunner.prototype.runAllSteps): Loops to run all the tests and move to the next iteration.
(this._runNextIteration): Starts a new iteration or show the results.
(BenchmarkRunner.prototype.runMultipleIterations): Loops to run all the iterations and show the results
(BenchmarkRunner.prototype._finalize): Finalizes the current iteration and starts a new one.

(SimplePromise): Deleted.
(SimplePromise.prototype.then): Deleted.
(SimplePromise.prototype.resolve): Deleted.
(BenchmarkTestStep): Deleted.
(Fibonacci): Deleted.
SimplePromise was moved t Animometer/resources/extensions.js because it is used by the runner and the tests.

(BenchmarkRunner.prototype._waitAndWarmUp): Deleted.
(BenchmarkRunner.prototype._runTest): Deleted.
(BenchmarkState.prototype.currentSuite): Deleted.
(BenchmarkState.prototype.currentTest): Deleted.
(BenchmarkState.prototype.next): Deleted.
(BenchmarkState.prototype.isFirstTest): Deleted.
(BenchmarkState.prototype.prepareCurrentSuite): Deleted.
BenchmarkState was renamed to BenchmarkRunnerState to not be confused with the tests BenchmarkState.

* Animometer/runner/resources/d3.min.js: Copied from Websites/perf.webkit.org/public/v2/js/d3/d3.min.js.
Needed for drawing charts for the sampled scores and frame rates.

* Animometer/runner/resources/graph.js: Added.
(graph): Draws a chart for a test sampled data. It shows two y-axes: one for the animated items and the second for FPS.

* Skipped: Skip the Animometer benchmark for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoProvide "--no-ninja" option to avoid using Ninja
bfulgham@apple.com [Fri, 2 Oct 2015 21:44:10 +0000 (21:44 +0000)]
Provide "--no-ninja" option to avoid using Ninja
https://bugs.webkit.org/show_bug.cgi?id=149757

Reviewed by Alex Christensen.

Add a new command line argument understood by webkitdirs.pm so
that we can conditionally avoid using Ninja. This is an
'opt-out' argument, so no existing Ninja users should be affected.

* Scripts/webkitdirs.pm:
(canUseNinja): Check for option and block ninja if present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFlakiness dashboard should support OS X El Capitan
commit-queue@webkit.org [Fri, 2 Oct 2015 21:38:57 +0000 (21:38 +0000)]
Flakiness dashboard should support OS X El Capitan
https://bugs.webkit.org/show_bug.cgi?id=149648

Patch by Aakash Jain <aakash_jain@apple.com> on 2015-10-02
Reviewed by Alexey Proskuryakov.

* TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling back in r190450
ggaren@apple.com [Fri, 2 Oct 2015 21:16:20 +0000 (21:16 +0000)]
Unreviewed, rolling back in r190450
https://bugs.webkit.org/show_bug.cgi?id=149727

The cause of the crash was a CodeBlock, after surviving a call to
deleteAllCode by virtue of being in the remembered set, trying to mark
its inlined CodeBlocks via pointers from its inlined executables.
Since deleteAllCode clears those pointers, the CodeBlock would ASSERT.
(Any other choice to retain a CodeBlock after deleteAllCode -- for
example, conservative marking -- could trigger the same bug.)

The fix is for InlineCallFrame to point directly to its inlined CodeBlock
instead of pointing indirectly via an executable. This guarantees that
CodeBlocks are GC safe regardless of whether we've called deleteAllCode.

Restored changesets:

"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190450

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Option-Click on a property name in the Computed view should jump to...
commit-queue@webkit.org [Fri, 2 Oct 2015 21:11:47 +0000 (21:11 +0000)]
Web Inspector: Option-Click on a property name in the Computed view should jump to resource view
https://bugs.webkit.org/show_bug.cgi?id=149521

Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2015-10-02
Reviewed by Timothy Hatcher.

* UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype.effectivePropertyForName):
Now tries to search for a non-canonical property before falling back to
the canonical version.

* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
If the user option-clicks the goto arrow, it shows the source for the
property instead.

* UserInterface/Views/ComputedStyleDetailsPanel.js:
(WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty.delegateShowProperty):
(WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty):
Attempts to show the source of the given property. Will fallback to
highlighting the property in the rules panel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Include Garbage Collection Event in Timeline
commit-queue@webkit.org [Fri, 2 Oct 2015 20:40:47 +0000 (20:40 +0000)]
Web Inspector: Include Garbage Collection Event in Timeline
https://bugs.webkit.org/show_bug.cgi?id=142510

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-02
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* CMakeLists.txt:
* DerivedSources.make:
* JavaScriptCore.xcodeproj/project.pbxproj:

* heap/HeapObserver.h:
* heap/Heap.cpp:
(JSC::Heap::willStartCollection):
(JSC::Heap::didFinishCollection):
* heap/Heap.h:
(JSC::Heap::addObserver):
(JSC::Heap::removeObserver):
Allow observers on heap to add hooks for starting / ending garbage collection.

* inspector/InspectorEnvironment.h:
* inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::vm):
* inspector/JSGlobalObjectInspectorController.h:
Access the VM through the InspectorEnvironment as it won't change.

* inspector/agents/InspectorHeapAgent.cpp: Added.
(Inspector::InspectorHeapAgent::InspectorHeapAgent):
(Inspector::InspectorHeapAgent::~InspectorHeapAgent):
(Inspector::InspectorHeapAgent::didCreateFrontendAndBackend):
(Inspector::InspectorHeapAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorHeapAgent::enable):
(Inspector::InspectorHeapAgent::disable):
(Inspector::InspectorHeapAgent::gc):
(Inspector::protocolTypeForHeapOperation):
(Inspector::InspectorHeapAgent::willGarbageCollect):
(Inspector::InspectorHeapAgent::didGarbageCollect):
* inspector/agents/InspectorHeapAgent.h: Added.
* inspector/protocol/Heap.json: Added.
New domain and agent to handle tasks related to the JavaScriptCore heap.

Source/WebCore:

Tests: inspector/heap/garbageCollected.html
       inspector/heap/gc.html

* ForwardingHeaders/heap/HeapObserver.h: Added.
* ForwardingHeaders/inspector/agents/InspectorHeapAgent.h: Added.
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
Forwarding headers.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::vm):
* inspector/InspectorController.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::vm):
* inspector/WorkerInspectorController.h:
Implement InspectorEnvironment::vm and create a Heap agent for the
Page inspector controller.

Source/WebInspectorUI:

* UserInterface/Base/Utilities.js:
(Array.prototype.parition):
Helper to partition an Array into two arrays.

* UserInterface/Main.html:
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Main.js:
(WebInspector.loaded):
* UserInterface/Test.html:
* UserInterface/Test/Test.js:
(WebInspector.loaded):
* UserInterface/Protocol/HeapObserver.js:
(WebInspector.HeapObserver.prototype.garbageCollected):
(WebInspector.HeapObserver):
Create the new observer and manager.

* UserInterface/Models/GarbageCollection.js:
(WebInspector.GarbageCollection):
(WebInspector.GarbageCollection.fromPayload):
(WebInspector.GarbageCollection.prototype.get type):
(WebInspector.GarbageCollection.prototype.get startTime):
(WebInspector.GarbageCollection.prototype.get endTime):
(WebInspector.GarbageCollection.prototype.get duration):
Model object for Heap.GarbageCollection.

* UserInterface/Controllers/HeapManager.js:
(WebInspector.HeapManager):
(WebInspector.HeapManager.prototype.garbageCollected):
Dispatch events with.

* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype._garbageCollected):
Include new GC Timeline Events as Script events.

* UserInterface/Views/ScriptTimelineOverviewGraph.js:
(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
For the Script overview, make two sets of bars, one for Scripts and one for GCs.
The GCs bar will be on top of the the Scripts bar. This is particularly useful
since a GC can happen during script execution.

* UserInterface/Views/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
(WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
(WebInspector.ScriptTimelineDataGridNode):
Give a NaN call count to top level Script DataGridNodes.
In the UI, display the empty placeholder for NaN call counts.

* UserInterface/Images/TimelineRecordGarbageCollection.svg: Added.
* UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
(WebInspector.ScriptTimelineRecord.EventType.displayName):
* UserInterface/Views/ScriptTimelineView.js:
(WebInspector.ScriptTimelineView.prototype._processPendingRecords):
* UserInterface/Views/SourceCodeTimelineTreeElement.js:
(WebInspector.SourceCodeTimelineTreeElement):
* UserInterface/Views/TimelineIcons.css:
(.garbage-collection-profile-record .icon):
* UserInterface/Views/TimelineRecordBar.css:
(.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment):
UI for GC events.

* UserInterface/Views/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar.createCombinedBars):
Simplify by storing start time into a variable.

* UserInterface/Views/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement):
Icon for GC events.

LayoutTests:

* inspector/heap/garbageCollected-expected.txt: Added.
* inspector/heap/garbageCollected.html: Added.
* inspector/heap/gc-expected.txt: Added.
* inspector/heap/gc.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
dbates@webkit.org [Fri, 2 Oct 2015 20:38:34 +0000 (20:38 +0000)]
Fix run-webkit-tests --ios-simulator after <trac.webkit.org/changeset/190515>
(https://bugs.webkit.org/show_bug.cgi?id=149753)

For now, pass --ios-simulator.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort._build_relay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTest gardening.
simon.fraser@apple.com [Fri, 2 Oct 2015 20:37:28 +0000 (20:37 +0000)]
Test gardening.

* TestExpectations:
* platform/gtk/TestExpectations:
* platform/ios-simulator/TestExpectations:
* platform/mac-wk1/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove a "nullable" that breaks the iOS 8 build.
simon.fraser@apple.com [Fri, 2 Oct 2015 20:18:21 +0000 (20:18 +0000)]
Remove a "nullable" that breaks the iOS 8 build.

* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[MSE] Browser crashes when appending invalid data to MSE source buffer
jer.noble@apple.com [Fri, 2 Oct 2015 19:51:21 +0000 (19:51 +0000)]
[MSE] Browser crashes when appending invalid data to MSE source buffer
https://bugs.webkit.org/show_bug.cgi?id=149689

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-source/media-source-stpp-crash.html

Bail out early (as specced) after disconnecting the SourceBuffer from its MediaSource.

* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):

LayoutTests:

* media/content/stpp.mp4: Added.
* media/media-source/media-source-stpp-crash-expected.txt: Added.
* media/media-source/media-source-stpp-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoLayoutTestRelay is not built and archived when building for iOS Simulator
dbates@webkit.org [Fri, 2 Oct 2015 19:43:09 +0000 (19:43 +0000)]
LayoutTestRelay is not built and archived when building for iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=149753

Reviewed by Alexey Proskuryakov and Andy Estes.

Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
product archive when building for iOS Simulator, respectively.

* BuildSlaveSupport/built-product-archive:
(main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
differentiate between iOS device and iOS Simulator platforms.
(webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
from determineWebKitBuildDirectories() into this function so that it can be used by both
determineWebKitBuildDirectories() and archiveBuiltProduct().
(determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
webkitBuildDirectoryForConfigurationAndPlatform().
(createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
for the limitation that ditto(1) can only accept a single directory to archive on its command line.
(archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
* Scripts/build-layouttestrelay:
    - Remove unnecessary include of Perl module POSIX.
    - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
* Scripts/build-webkit:
    - Invoke script build-layouttestrelay when building for iOS Simulator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoASSERTION FAILED: param >= 0 in AnimationBase::updateStateMachine()
simon.fraser@apple.com [Fri, 2 Oct 2015 19:36:32 +0000 (19:36 +0000)]
ASSERTION FAILED: param >= 0 in AnimationBase::updateStateMachine()
https://bugs.webkit.org/show_bug.cgi?id=149737
rdar://problem/19017465

Reviewed by Dean Jackson.

CoreAnimation can give us an animation beginTime that is slightly into the future,
which results in 'param' here being < 0, so relax the assertion slightly.

Fixes lots of assertions running iOS WK2 layout tests.

* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WinCairo] Fix linker warnings.
peavo@outlook.com [Fri, 2 Oct 2015 18:33:49 +0000 (18:33 +0000)]
[WinCairo] Fix linker warnings.
https://bugs.webkit.org/show_bug.cgi?id=149754

Reviewed by Alex Christensen.

Avoid compiling these files twice, they are already included in
RenderingAllInOne.cpp.

* PlatformWinCairo.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoText selection is inaccurate in Wikipedia pages when starting navigation from wikiped...
enrica@apple.com [Fri, 2 Oct 2015 18:29:03 +0000 (18:29 +0000)]
Text selection is inaccurate in Wikipedia pages when starting navigation from wikipedia.org.
https://bugs.webkit.org/show_bug.cgi?id=149756
rdar://problem/22332409

Reviewed by Tim Horton.

When loading a new document into the same WebPage object, we need
to clear the assisted node, since there is no guarantee that the
node will be blurred. The bug is caused by the use of a stale
assisted node to constrain the point where the gesture occurs.
A fix for this problem was landed in http://trac.webkit.org/changeset/179885
where the cleanup was added when FrameLoaderClient::detach2 was called.
This method doesn't seem to be called any longer for the main frame,
so the correct solution is to add the cleanup to didCommitLoad in WebPage.
I've also added some checks to webSelectionsRects and selectedTextRange to avoid
the use of postLayoutData when the selection is none.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView webSelectionRects]):
(-[WKContentView selectedTextRange]):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::detachedFromParent2): Removed call to resetAssistedNodeForFrame.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad): Added call to resetAssistedNodeForFrame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Unreviewed test fix.
bfulgham@apple.com [Fri, 2 Oct 2015 17:58:21 +0000 (17:58 +0000)]
[Win] Unreviewed test fix.

You cannot run 'run-webkit-tests' from the command line because it does not know
to append the binary subdirectory (bin32/bin64). We don't see this on our builders
because they explicitly set use the 'root' argument to provide the full path to
the test binaries.

* Scripts/webkitpy/port/win.py:
(WinPort._build_path): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSource/WebCore:
achristensen@apple.com [Fri, 2 Oct 2015 17:46:25 +0000 (17:46 +0000)]
Source/WebCore:
Reloading without content blockers doesn't apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

Test: http/tests/contentextensions/disable-blocker.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::userContentExtensionsEnabled):
(WebCore::DocumentLoader::setUserContentExtensionsEnabled):
Store and use the state of whether content blockers are enabled or not on the DocumentLoader
so that it stays constant for a document's entire life.  This state comes from the Page when
making the DocumentLoader in WebKit2.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequestInternal):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::open):
* page/UserContentController.cpp:
(WebCore::UserContentController::removeAllUserContentExtensions):
(WebCore::UserContentController::processContentExtensionRulesForLoad):
(WebCore::UserContentController::actionsForResourceLoad):
* page/UserContentController.h:

Source/WebKit2:
Reloading without content blockers doesn't apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createDocumentLoader):
Copy the state of whether content extensions are disabled from the Page to the DocumentLoader
when making a DocumentLoader.

Tools:
Reloading without content blockers doesn't apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaResetStateToConsistentValues):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformConfigureViewForTest):
Test what happens when you disable content blockers from the SPI.

LayoutTests:
Reloading without content blockers doesn’t apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

* http/tests/contentextensions/disable-blocker-expected.txt: Added.
* http/tests/contentextensions/disable-blocker.html: Added.
* http/tests/contentextensions/disable-blocker.html.json: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Fix indentation of console message parameters
nvasilyev@apple.com [Fri, 2 Oct 2015 15:13:32 +0000 (15:13 +0000)]
Web Inspector: Fix indentation of console message parameters
https://bugs.webkit.org/show_bug.cgi?id=149740

Reviewed by Darin Adler.

* UserInterface/Views/ConsoleMessageView.css:
(.console-message .console-message-stack-trace-container > li):
(.console-message .console-message-extra-parameters-container > li::before):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agopopstate is fired at the wrong time on load
commit-queue@webkit.org [Fri, 2 Oct 2015 15:13:05 +0000 (15:13 +0000)]
popstate is fired at the wrong time on load
https://bugs.webkit.org/show_bug.cgi?id=94265

Patch by Antoine Quint <graouts@apple.com> on 2015-10-02
Reviewed by Darin Adler.

Source/WebCore:

Don't fire popstate event on initial document load

According to the specification [1], a popstate event should only be fired
when the document has a "last entry" and the entry being navigated to isn't
it.  A document is created without a "last entry" and gets one just after
this check when it is first navigated to, so a popstate should be fired any
time a document is navigated to except for the first time after it has been
created.

Patch adapted from work by jl@opera.com on Blink [2].

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#traverse-the-history (step 12-14 in particular)
[2] https://src.chromium.org/viewvc/blink?revision=165221&view=revision

* dom/Document.cpp:
(WebCore::Document::implicitClose):

Source/WebKit2:

Ensure we have a valid page before trying to get to its drawingArea as this could lead
to a crash as observed with fast/loader/stateobjects/pushstate-object-types.html.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::restoreViewState):

LayoutTests:

Updating tests that relied on a "popstate" event being fired at page load.

* fast/history/same-document-iframes-changing-fragment-expected.txt:
* fast/history/same-document-iframes-changing-pushstate-expected.txt:
* fast/loader/javascript-url-iframe-remove-on-navigate.html:
* fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
* fast/loader/stateobjects/document-destroyed-navigate-back.html:
* fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html:
* fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html:
* fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html:
* fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html:
* fast/loader/stateobjects/popstate-fires-on-history-traversal-expected.txt:
* fast/loader/stateobjects/popstate-fires-on-history-traversal.html:
* fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt:
* fast/loader/stateobjects/popstate-fires-with-page-cache.html:
* fast/loader/stateobjects/pushstate-object-types.html:
* fast/loader/stateobjects/pushstate-then-replacestate.html:
* fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
* fast/loader/stateobjects/replacestate-then-pushstate.html:
* fast/loader/stateobjects/resources/popstate-fires-with-page-cache-1.html:
* fast/loader/stateobjects/resources/popstate-fires-with-page-cache-2.html:
* fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html:
* http/tests/history/popstate-fires-with-pending-requests.html:
* http/tests/navigation/redirect-on-back-updates-history-item-expected.txt:
* http/tests/navigation/redirect-on-reload-updates-history-item-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Web Inspector: Add GTK+ icons for new plus icons in the style sidebar
agomez@igalia.com [Fri, 2 Oct 2015 14:08:18 +0000 (14:08 +0000)]
[GTK] Web Inspector: Add GTK+ icons for new plus icons in the style sidebar
https://bugs.webkit.org/show_bug.cgi?id=149227

Reviewed by Carlos Garcia Campos.

* UserInterface/Images/gtk/NewTabPlus.svg: Updated.
* UserInterface/Images/gtk/Plus13.svg: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.
* UserInterface/Images/gtk/Plus15.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[CSS Grid Layout] Support for Content Alignment in grid layout
jfernandez@igalia.com [Fri, 2 Oct 2015 12:14:49 +0000 (12:14 +0000)]
[CSS Grid Layout] Support for Content Alignment in grid layout
https://bugs.webkit.org/show_bug.cgi?id=145520

Reviewed by Darin Adler.

Source/WebCore:

According to CSS Box Alignment specification, Content Distribution
alignment controls alignment of the box's content within the box. The
alignment container is the grid container's content box. The alignment
subjects are the grid tracks.

This patch implements Grid Layout support for Content Distribution
alignment along both block/column and inline/row axis, which are handled
by align-content and justify-content properties respectively.

This patch provides support for overflow handling, similar to what
Self Alignment provides with grid items, and both <content-position>
and <content-distribution> values.

Baseline Alignment is still missing because it requires some additional
behavior to be supported on grids before considering its implementation.

Tests: css3/overwrite-content-alignment.html
       css3/overwrite-self-alignment.html
       fast/css-grid-layout/grid-align-content-distribution-vertical-lr.html
       fast/css-grid-layout/grid-align-content-distribution-vertical-rl.html
       fast/css-grid-layout/grid-align-content-distribution.html
       fast/css-grid-layout/grid-align-content-vertical-lr.html
       fast/css-grid-layout/grid-align-content-vertical-rl.html
       fast/css-grid-layout/grid-align-content.html
       fast/css-grid-layout/grid-content-alignment-overflow.html
       fast/css-grid-layout/grid-content-alignment-with-different-sized-tracks.html
       fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr.html
       fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl.html
       fast/css-grid-layout/grid-content-alignment-with-span.html
       fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html
       fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html
       fast/css-grid-layout/grid-justify-content-distribution.html
       fast/css-grid-layout/grid-justify-content-vertical-lr.html
       fast/css-grid-layout/grid-justify-content-vertical-rl.html
       fast/css-grid-layout/grid-justify-content.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
(WebCore::RenderFlexibleBox::alignFlexLines):
* rendering/RenderGrid.cpp:
(WebCore::ContentAlignmentData::ContentAlignmentData):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::resolveContentDistributionFallback):
(WebCore::offsetToStartEdge):
(WebCore::offsetToEndEdge):
(WebCore::contentDistributionOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionColumnOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionRowOffset):
(WebCore::RenderGrid::findChildLogicalPosition):
(WebCore::RenderGrid::computePreferredLogicalWidths): Deleted.
(WebCore::RenderGrid::autoPlacementMajorAxisDirection): Deleted.
(WebCore::RenderGrid::autoPlacementMinorAxisDirection): Deleted.
(WebCore::RenderGrid::cachedGridCoordinate): Deleted.
(WebCore::RenderGrid::rowPositionForChild): Deleted.
* rendering/RenderGrid.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::resolvedAlignContentPosition):
(WebCore::RenderStyle::resolvedAlignContentDistribution):
(WebCore::RenderStyle::resolvedJustifyContentPosition):
(WebCore::RenderStyle::resolvedJustifyContentDistribution):
* rendering/style/RenderStyle.h:

LayoutTests:

Content Distribution alignment controls alignment of the box's
content within the box. The alignment container is the grid
container's content box. The alignment subjects are the grid
tracks.

In addition to the tests to verify the new functionality, I've
added some tests to check out that the new complex values are
overwritten properly.

I had to modify the grid-item-margin-auto-columns-rows-horizontal-rtl
test because when using RTL direction the whole grid must flow form
right to left, not only its items, so I rebaselined text expectations
to adapt it to the new behavior.

* css3/overwrite-content-alignment-expected.txt: Added.
* css3/overwrite-content-alignment.html: Added.
* css3/overwrite-self-alignment-expected.txt: Added.
* css3/overwrite-self-alignment.html: Added.
* fast/css-grid-layout/grid-align-content-distribution-expected.txt: Added.
* fast/css-grid-layout/grid-align-content-distribution-vertical-lr-expected.txt: Added.
* fast/css-grid-layout/grid-align-content-distribution-vertical-lr.html: Added.
* fast/css-grid-layout/grid-align-content-distribution-vertical-rl-expected.txt: Added.
* fast/css-grid-layout/grid-align-content-distribution-vertical-rl.html: Added.
* fast/css-grid-layout/grid-align-content-distribution.html: Added.
* fast/css-grid-layout/grid-align-content-expected.txt: Added.
* fast/css-grid-layout/grid-align-content-vertical-lr-expected.txt: Added.
* fast/css-grid-layout/grid-align-content-vertical-lr.html: Added.
* fast/css-grid-layout/grid-align-content-vertical-rl-expected.txt: Added.
* fast/css-grid-layout/grid-align-content-vertical-rl.html: Added.
* fast/css-grid-layout/grid-align-content.html: Added.
* fast/css-grid-layout/grid-content-alignment-overflow-expected.txt: Added.
* fast/css-grid-layout/grid-content-alignment-overflow.html: Added.
* fast/css-grid-layout/grid-content-alignment-with-different-sized-tracks.html: Added.
* fast/css-grid-layout/grid-content-alignment-with-different-sized-tracks-expected.txt: Added.
* fast/css-grid-layout/grid-content-alignment-with-span-expected.txt: Added.
* fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr-expected.txt: Added.
* fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr.html: Added.
* fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl-expected.txt: Added.
* fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl.html: Added.
* fast/css-grid-layout/grid-content-alignment-with-span.html: Added.
* fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-rtl-expected.html:
* fast/css-grid-layout/grid-justify-content-distribution-expected.txt: Added.
* fast/css-grid-layout/grid-justify-content-distribution-vertical-lr-expected.txt: Added.
* fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html: Added.
* fast/css-grid-layout/grid-justify-content-distribution-vertical-rl-expected.txt: Added.
* fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html: Added.
* fast/css-grid-layout/grid-justify-content-distribution.html: Added.
* fast/css-grid-layout/grid-justify-content-expected.txt: Added.
* fast/css-grid-layout/grid-justify-content-vertical-lr-expected.txt: Added.
* fast/css-grid-layout/grid-justify-content-vertical-lr.html: Added.
* fast/css-grid-layout/grid-justify-content-vertical-rl-expected.txt: Added.
* fast/css-grid-layout/grid-justify-content-vertical-rl.html: Added.
* fast/css-grid-layout/grid-justify-content.html: Added.
* fast/css-grid-layout/resources/grid.css:
(.firstRowThirdColumn):
(.firstRowFourthColumn):
(.secondRowThirdColumn):
(.secondRowFourthColumn):
(.thirdRowFirstColumn):
(.thirdRowSecondColumn):
(.fourthRowFirstColumn):
(.fourthRowSecondColumn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAttempted build fix.
dino@apple.com [Fri, 2 Oct 2015 11:07:40 +0000 (11:07 +0000)]
Attempted build fix.

* DerivedSources.make:
* page/make_settings.pl:
(printGetterAndSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoExpose WEBGL_debug_renderer_info
dino@apple.com [Fri, 2 Oct 2015 10:53:53 +0000 (10:53 +0000)]
Expose WEBGL_debug_renderer_info
https://bugs.webkit.org/show_bug.cgi?id=149735
<rdar://problem/18343500>

Reviewed by Simon Fraser.

Source/WebCore:

Enable the extension that allows content to query
for the GPUs vendor and details.

Now that we're enabling this, there was no need for
the internal setting that identified privileged situations.
However, since this meant that WEBGL_debug_shaders was
also exposed, I explicitly disable it since it is
not yet conformant.

Test: fast/canvas/webgl/webgl-debug-renderer-info.html
as well as the general conformance suite.

* html/canvas/WebGL2RenderingContext.cpp: No need to guard around allowPrivilegedExtensions().
(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
* html/canvas/WebGLRenderingContext.cpp: Ditto.
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::allowPrivilegedExtensions): Deleted.
* html/canvas/WebGLRenderingContextBase.h:
* page/Settings.in: Remove privilegedWebGLExtensions.
* platform/graphics/opengl/Extensions3DOpenGL.cpp: Forbid the translated shader
extension while it is still buggy.
(WebCore::Extensions3DOpenGL::supportsExtension):

LayoutTests:

Modify a test from the 1.0.2 conformance suite to make sure
we're actually enabling and passing the info.

* fast/canvas/webgl/webgl-debug-renderer-info-expected.txt: Added.
* fast/canvas/webgl/webgl-debug-renderer-info.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the #if guard in PointerLockController.cpp
ossy@webkit.org [Fri, 2 Oct 2015 05:44:59 +0000 (05:44 +0000)]
Fix the #if guard in PointerLockController.cpp
https://bugs.webkit.org/show_bug.cgi?id=149705

Reviewed by Gyuyoung Kim.

* page/PointerLockController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago2015-10-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 2 Oct 2015 04:48:24 +0000 (04:48 +0000)]
2015-10-01  Geoffrey Garen  <ggaren@apple.com>

        Unreviewed, rolling out r190450
        https://bugs.webkit.org/show_bug.cgi?id=148560

        Crashes seen on el cap wk1 bots.

        Reverted changesets:

        "CodeBlock should be a GC object"
        https://bugs.webkit.org/show_bug.cgi?id=149727
        http://trac.webkit.org/changeset/190450

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::inferredName):
        (JSC::CodeBlock::dumpAssumingJITType):
        (JSC::CodeBlock::CodeBlock):
        (JSC::CodeBlock::~CodeBlock):
        (JSC::CodeBlock::setNumParameters):
        (JSC::CodeBlock::specialOSREntryBlockOrNull):
        (JSC::CodeBlock::visitStrongly):
        (JSC::CodeBlock::visitAggregate):
        (JSC::CodeBlock::shouldVisitStrongly):
        (JSC::CodeBlock::isKnownToBeLiveDuringGC):
        (JSC::CodeBlock::shouldJettisonDueToWeakReference):
        (JSC::CodeBlock::shouldJettisonDueToOldAge):
        (JSC::CodeBlock::determineLiveness):
        (JSC::CodeBlock::visitWeakReferences):
        (JSC::CodeBlock::finalizeLLIntInlineCaches):
        (JSC::CodeBlock::finalizeBaselineJITInlineCaches):
        (JSC::CodeBlock::finalizeUnconditionally):
        (JSC::CodeBlock::visitOSRExitTargets):
        (JSC::CodeBlock::unlinkIncomingCalls):
        (JSC::CodeBlock::linkIncomingCall):
        (JSC::CodeBlock::newReplacement):
        (JSC::ProgramCodeBlock::replacement):
        (JSC::ModuleProgramCodeBlock::replacement):
        (JSC::EvalCodeBlock::replacement):
        (JSC::FunctionCodeBlock::replacement):
        (JSC::ProgramCodeBlock::capabilityLevelInternal):
        (JSC::ModuleProgramCodeBlock::capabilityLevelInternal):
        (JSC::EvalCodeBlock::capabilityLevelInternal):
        (JSC::FunctionCodeBlock::capabilityLevelInternal):
        (JSC::WebAssemblyCodeBlock::replacement):
        (JSC::WebAssemblyCodeBlock::capabilityLevelInternal):
        (JSC::CodeBlock::jettison):
        (JSC::CodeBlock::capabilityLevel):
        (JSC::FunctionCodeBlock::destroy): Deleted.
        (JSC::WebAssemblyCodeBlock::destroy): Deleted.
        (JSC::ProgramCodeBlock::destroy): Deleted.
        (JSC::ModuleProgramCodeBlock::destroy): Deleted.
        (JSC::EvalCodeBlock::destroy): Deleted.
        (JSC::CodeBlock::finishCreation): Deleted.
        (JSC::CodeBlock::setAlternative): Deleted.
        (JSC::CodeBlock::visitWeakly): Deleted.
        (JSC::CodeBlock::visitChildren): Deleted.
        (JSC::timeToLive): Deleted.
        (JSC::CodeBlock::WeakReferenceHarvester::visitWeakReferences): Deleted.
        (JSC::CodeBlock::UnconditionalFinalizer::finalizeUnconditionally): Deleted.
        (JSC::CodeBlock::replacement): Deleted.
        (JSC::CodeBlock::computeCapabilityLevel): Deleted.
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::unlinkedCodeBlock):
        (JSC::CodeBlock::addressOfNumParameters):
        (JSC::CodeBlock::offsetOfNumParameters):
        (JSC::CodeBlock::alternative):
        (JSC::CodeBlock::setAlternative):
        (JSC::CodeBlock::forEachRelatedCodeBlock):
        (JSC::CodeBlock::specializationKind):
        (JSC::CodeBlock::instructionCount):
        (JSC::CodeBlock::setJITCode):
        (JSC::CodeBlock::hasBaselineJITProfiling):
        (JSC::CodeBlock::capabilityLevelState):
        (JSC::CodeBlock::addConstant):
        (JSC::CodeBlock::appendExceptionHandler):
        (JSC::CodeBlock::setConstantRegisters):
        (JSC::CodeBlock::replaceConstant):
        (JSC::GlobalCodeBlock::GlobalCodeBlock):
        (JSC::ProgramCodeBlock::ProgramCodeBlock):
        (JSC::ModuleProgramCodeBlock::ModuleProgramCodeBlock):
        (JSC::EvalCodeBlock::EvalCodeBlock):
        (JSC::EvalCodeBlock::variable):
        (JSC::EvalCodeBlock::numVariables):
        (JSC::EvalCodeBlock::unlinkedEvalCodeBlock):
        (JSC::FunctionCodeBlock::FunctionCodeBlock):
        (JSC::WebAssemblyCodeBlock::WebAssemblyCodeBlock):
        (JSC::ExecState::uncheckedR):
        (JSC::CodeBlock::clearMarks):
        (JSC::CodeBlockSet::mark):
        (JSC::ScriptExecutable::forEachCodeBlock):
        (JSC::ProgramCodeBlock::create): Deleted.
        (JSC::ProgramCodeBlock::createStructure): Deleted.
        (JSC::ModuleProgramCodeBlock::create): Deleted.
        (JSC::ModuleProgramCodeBlock::createStructure): Deleted.
        (JSC::EvalCodeBlock::create): Deleted.
        (JSC::EvalCodeBlock::createStructure): Deleted.
        (JSC::FunctionCodeBlock::create): Deleted.
        (JSC::FunctionCodeBlock::createStructure): Deleted.
        (JSC::WebAssemblyCodeBlock::create): Deleted.
        (JSC::WebAssemblyCodeBlock::createStructure): Deleted.
        (JSC::CodeBlock::clearVisitWeaklyHasBeenCalled): Deleted.
        * bytecode/DeferredCompilationCallback.cpp:
        (JSC::DeferredCompilationCallback::DeferredCompilationCallback):
        (JSC::DeferredCompilationCallback::~DeferredCompilationCallback):
        (JSC::DeferredCompilationCallback::compilationDidComplete):
        * bytecode/DeferredCompilationCallback.h:
        * bytecode/EvalCodeCache.h:
        (JSC::EvalCodeCache::tryGet):
        (JSC::EvalCodeCache::getSlow):
        * bytecode/PolymorphicAccess.cpp:
        (JSC::AccessCase::generate):
        (JSC::PolymorphicAccess::regenerate):
        * bytecode/StructureStubInfo.cpp:
        (JSC::StructureStubInfo::addAccessCase):
        * dfg/DFGByteCodeParser.cpp:
        (JSC::DFG::ByteCodeParser::parse):
        * dfg/DFGDesiredTransitions.cpp:
        (JSC::DFG::DesiredTransition::reallyAdd):
        * dfg/DFGDesiredWeakReferences.cpp:
        (JSC::DFG::DesiredWeakReferences::reallyAdd):
        * dfg/DFGDriver.cpp:
        (JSC::DFG::compile):
        * dfg/DFGGraph.cpp:
        (JSC::DFG::Graph::Graph):
        * dfg/DFGJITCode.h:
        (JSC::DFG::JITCode::osrEntryBlock): Deleted.
        (JSC::DFG::JITCode::setOSREntryBlock): Deleted.
        (JSC::DFG::JITCode::clearOSREntryBlock): Deleted.
        * dfg/DFGJITFinalizer.cpp:
        (JSC::DFG::JITFinalizer::finalize):
        (JSC::DFG::JITFinalizer::finalizeFunction):
        (JSC::DFG::JITFinalizer::finalizeCommon):
        * dfg/DFGOSRExitCompilerCommon.cpp:
        (JSC::DFG::adjustAndJumpToTarget):
        * dfg/DFGOperations.cpp:
        * dfg/DFGPlan.cpp:
        (JSC::DFG::Plan::Plan):
        (JSC::DFG::Plan::reallyAdd):
        (JSC::DFG::Plan::notifyReady):
        (JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
        (JSC::DFG::Plan::finalizeAndNotifyCallback):
        (JSC::DFG::Plan::key):
        (JSC::DFG::Plan::clearCodeBlockMarks):
        (JSC::DFG::Plan::checkLivenessAndVisitChildren):
        (JSC::DFG::Plan::rememberCodeBlocks): Deleted.
        * dfg/DFGPlan.h:
        * dfg/DFGToFTLDeferredCompilationCallback.cpp:
        (JSC::DFG::ToFTLDeferredCompilationCallback::ToFTLDeferredCompilationCallback):
        (JSC::DFG::ToFTLDeferredCompilationCallback::~ToFTLDeferredCompilationCallback):
        (JSC::DFG::ToFTLDeferredCompilationCallback::create):
        (JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
        (JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):
        * dfg/DFGToFTLDeferredCompilationCallback.h:
        * dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
        (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::ToFTLForOSREntryDeferredCompilationCallback):
        (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::~ToFTLForOSREntryDeferredCompilationCallback):
        (JSC::DFG::Ref<ToFTLForOSREntryDeferredCompilationCallback>ToFTLForOSREntryDeferredCompilationCallback::create):
        (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
        (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):
        * dfg/DFGToFTLForOSREntryDeferredCompilationCallback.h:
        * dfg/DFGWorklist.cpp:
        (JSC::DFG::Worklist::completeAllPlansForVM):
        (JSC::DFG::Worklist::clearCodeBlockMarks):
        (JSC::DFG::completeAllPlansForVM):
        (JSC::DFG::clearCodeBlockMarks):
        (JSC::DFG::Worklist::rememberCodeBlocks): Deleted.
        (JSC::DFG::rememberCodeBlocks): Deleted.
        * dfg/DFGWorklist.h:
        (JSC::DFG::worklistForIndexOrNull):
        * ftl/FTLJITFinalizer.cpp:
        (JSC::FTL::JITFinalizer::finalizeFunction):
        * heap/CodeBlockSet.cpp:
        (JSC::CodeBlockSet::~CodeBlockSet):
        (JSC::CodeBlockSet::add):
        (JSC::CodeBlockSet::clearMarksForFullCollection):
        (JSC::CodeBlockSet::clearMarksForEdenCollection):
        (JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced):
        (JSC::CodeBlockSet::remove):
        (JSC::CodeBlockSet::traceMarked):
        (JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
        (JSC::CodeBlockSet::dump):
        * heap/CodeBlockSet.h:
        * heap/Heap.cpp:
        (JSC::Heap::markRoots):
        (JSC::Heap::clearLivenessData):
        (JSC::Heap::traceCodeBlocksAndJITStubRoutines):
        (JSC::Heap::deleteAllCodeBlocks):
        (JSC::Heap::deleteAllUnlinkedCodeBlocks):
        (JSC::Heap::clearUnmarkedExecutables):
        (JSC::Heap::willStartCollection):
        * interpreter/Interpreter.cpp:
        (JSC::eval):
        * jit/GCAwareJITStubRoutine.h:
        * jit/JITCode.h:
        (JSC::JITCode::isJIT):
        (JSC::JITCode::timeToLive):
        (JSC::JITCode::isLowerTier):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_enter):
        * jit/JITOperations.cpp:
        * jit/JITToDFGDeferredCompilationCallback.cpp:
        (JSC::JITToDFGDeferredCompilationCallback::create):
        (JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
        (JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):
        * jit/JITToDFGDeferredCompilationCallback.h:
        * jit/Repatch.cpp:
        (JSC::tryCacheGetByID):
        (JSC::tryCachePutByID):
        (JSC::tryRepatchIn):
        (JSC::linkFor):
        (JSC::linkPolymorphicCall):
        * llint/LLIntSlowPaths.cpp:
        (JSC::LLInt::LLINT_SLOW_PATH_DECL):
        (JSC::LLInt::setUpCall):
        * runtime/CommonSlowPaths.cpp:
        (JSC::SLOW_PATH_DECL):
        * runtime/CommonSlowPaths.h:
        (JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
        (JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):
        * runtime/Executable.cpp:
        (JSC::ExecutableBase::clearCode):
        (JSC::ScriptExecutable::installCode):
        (JSC::ScriptExecutable::newCodeBlockFor):
        (JSC::ScriptExecutable::newReplacementCodeBlockFor):
        (JSC::ScriptExecutable::prepareForExecutionImpl):
        (JSC::EvalExecutable::visitChildren):
        (JSC::EvalExecutable::clearCode):
        (JSC::ProgramExecutable::checkSyntax):
        (JSC::ProgramExecutable::visitChildren):
        (JSC::ProgramExecutable::clearCode):
        (JSC::ModuleProgramExecutable::visitChildren):
        (JSC::ModuleProgramExecutable::clearCode):
        (JSC::FunctionExecutable::baselineCodeBlockFor):
        (JSC::FunctionExecutable::visitChildren):
        (JSC::FunctionExecutable::clearCode):
        (JSC::FunctionExecutable::fromGlobalCode):
        (JSC::WebAssemblyExecutable::visitChildren):
        (JSC::WebAssemblyExecutable::clearCode):
        (JSC::WebAssemblyExecutable::prepareForExecution):
        * runtime/Executable.h:
        (JSC::ExecutableBase::generatedJITCodeForCall):
        (JSC::ScriptExecutable::prepareForExecution):
        (JSC::ExecutableBase::clearCodeVirtual):
        * runtime/VM.cpp:
        (JSC::VM::VM):
        * runtime/VM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Unreviewed build fix for run-api-tests
bfulgham@apple.com [Fri, 2 Oct 2015 04:35:27 +0000 (04:35 +0000)]
[Win] Unreviewed build fix for run-api-tests

* Scripts/run-api-tests:
(testToolPaths): Windows run needs to specify the binary path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoConvert focused-input-should-assist-on-touch.html into an automated test
wenson_hsieh@apple.com [Fri, 2 Oct 2015 04:27:32 +0000 (04:27 +0000)]
Convert focused-input-should-assist-on-touch.html into an automated test
https://bugs.webkit.org/show_bug.cgi?id=149724

Reviewed by Simon Fraser.

.:

Remove a manual test that can now be rewritten as an automated test.

* ManualTests/ios/focused-input-should-assist-on-touch.html: Removed.

LayoutTests:

Tests that an input that focuses itself on touch and then prevents default is
able to trigger node assistance, even when it is already focused before the
user gesture.

* fast/events/ios/focused-input-should-assist-on-touch-expected.txt: Added.
* fast/events/ios/focused-input-should-assist-on-touch.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCodeBlock should be a GC object
ggaren@apple.com [Fri, 2 Oct 2015 03:45:53 +0000 (03:45 +0000)]
CodeBlock should be a GC object
https://bugs.webkit.org/show_bug.cgi?id=149727

Reviewed by Filip Pizlo.

We want CodeBlock to be a GC object:

(1) Sane write barriers. Because CodeBlock wasn't a GC object, we couldn't
execute a write barrier on it. This caused us to do weird things that
were hard to reason about, like executing a barrier on a related executable
(even though the executable might stop pointing to the CodeBlock before
the next GC), or pretending that an object had written to itself. Now,
when we write to a CodeBlock, we barrier the CodeBlock, and that's that.

(2) Simpler marking and destruction logic. There's no need to have a
custom remembered set or a destruction fixpoint if we just obey normal
GC rules.

* bytecode/CodeBlock.cpp:
(JSC::FunctionCodeBlock::destroy):
(JSC::WebAssemblyCodeBlock::destroy):
(JSC::ProgramCodeBlock::destroy):
(JSC::ModuleProgramCodeBlock::destroy):
(JSC::EvalCodeBlock::destroy): Add ClassInfo and destroy functions
because our GC object model requires them.

Note that we do not set the needsDestruction flag. Since CodeBlock needs
eager destruction, it runs its destructors through CodeBlockSet,
and not through normal object sweeping.

(JSC::CodeBlock::finishCreation): Factor out finishCreation from the
constructor because our GC object model requires it. Change write
barriers to note the CodeBlock as the owner.

(JSC::CodeBlock::~CodeBlock): Refactor to use the shared
unlinkIncomingCalls() function instead of rolling a copy by hand.

(JSC::CodeBlock::visitWeakly): New helper function for owner executables
to do weak marking that might jettison a CodeBlock. Our new GC logic
says that a CodeBlock pointer is a strong reference by default, and
clients need to opt in if they want to allow a CodeBlock to jettison.
This is easier to get right because it means that only those
specific owners that want jettison behavior need to worry about it,
while all other pointers are valid by default.

(JSC::CodeBlock::visitChildren): The default visit function keeps
everything alive.

(JSC::CodeBlock::shouldVisitStrongly):
(JSC::CodeBlock::isKnownToBeLiveDuringGC): No need to keep special state
anymore. If we're marked, we're live -- just like any other object.

(JSC::timeToLive): Move this code into CodeBlock.cpp so you can mess
with it without recompiling, and also because it's really a CodeBlock
policy.

(JSC::CodeBlock::WeakReferenceHarvester::visitWeakReferences):
(JSC::CodeBlock::UnconditionalFinalizer::finalizeUnconditionally): Use
internal objects for virtual callbacks because GC objects can't have
vtables.

(JSC::CodeBlock::unlinkIncomingCalls): Remove a fast path check that does
not exist in the copy of this code in ~CodeBlock because it is not
actually an optimization.

(JSC::CodeBlock::replacement):
(JSC::CodeBlock::computeCapabilityLevel): Make these functions generic
instead of virtual because GC objects can't have vtables.

(JSC::CodeBlock::visitStrongly): Deleted.
(JSC::CodeBlock::visitAggregate): Deleted.
(JSC::CodeBlock::visitWeakReferences): Deleted.
(JSC::CodeBlock::finalizeUnconditionally): Deleted.
(JSC::ProgramCodeBlock::replacement): Deleted.
(JSC::ModuleProgramCodeBlock::replacement): Deleted.
(JSC::EvalCodeBlock::replacement): Deleted.
(JSC::FunctionCodeBlock::replacement): Deleted.
(JSC::ProgramCodeBlock::capabilityLevelInternal): Deleted.
(JSC::ModuleProgramCodeBlock::capabilityLevelInternal): Deleted.
(JSC::EvalCodeBlock::capabilityLevelInternal): Deleted.
(JSC::FunctionCodeBlock::capabilityLevelInternal): Deleted.
(JSC::WebAssemblyCodeBlock::replacement): Deleted.
(JSC::WebAssemblyCodeBlock::capabilityLevelInternal): Deleted.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::unlinkedCodeBlock):
(JSC::CodeBlock::addressOfNumParameters):
(JSC::CodeBlock::offsetOfNumParameters):
(JSC::CodeBlock::alternative):
(JSC::CodeBlock::forEachRelatedCodeBlock):
(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::hasBaselineJITProfiling):
(JSC::CodeBlock::capabilityLevelState):
(JSC::CodeBlock::addConstant):
(JSC::CodeBlock::appendExceptionHandler):
(JSC::CodeBlock::setConstantRegisters):
(JSC::CodeBlock::replaceConstant):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::create):
(JSC::ProgramCodeBlock::createStructure):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::ModuleProgramCodeBlock::create):
(JSC::ModuleProgramCodeBlock::createStructure):
(JSC::ModuleProgramCodeBlock::ModuleProgramCodeBlock):
(JSC::EvalCodeBlock::create):
(JSC::EvalCodeBlock::createStructure):
(JSC::EvalCodeBlock::variable):
(JSC::EvalCodeBlock::numVariables):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::EvalCodeBlock::unlinkedEvalCodeBlock):
(JSC::FunctionCodeBlock::create):
(JSC::FunctionCodeBlock::createStructure):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::WebAssemblyCodeBlock::create):
(JSC::WebAssemblyCodeBlock::createStructure):
(JSC::WebAssemblyCodeBlock::WebAssemblyCodeBlock):
(JSC::ExecState::uncheckedR):
(JSC::CodeBlock::clearVisitWeaklyHasBeenCalled):
(JSC::CodeBlockSet::mark):
(JSC::ScriptExecutable::forEachCodeBlock):
(JSC::CodeBlock::setAlternative): Deleted.
(JSC::CodeBlock::clearMarks): Deleted. Lots of mechanical changes to
match the logic changes above.

* bytecode/DeferredCompilationCallback.cpp:
(JSC::DeferredCompilationCallback::DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::~DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::compilationDidComplete):
* bytecode/DeferredCompilationCallback.h: Provide a profiledDFGCodeBlock
to all compilation callbacks instead of requiring the callback to
store the profiledDFGCodeBlock. This is how the rest of compilation
around the callback works anyway, and it is easier to do things this
way than to think about how a non-GC malloc'd object should keep its
CodeBlock alive.

* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):
* bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerate):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::addAccessCase): Change the owner for write
barrier purposes to CodeBlock.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGDesiredTransitions.cpp:
(JSC::DFG::DesiredTransition::reallyAdd):
* dfg/DFGDesiredWeakReferences.cpp:
(JSC::DFG::DesiredWeakReferences::reallyAdd):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph): Ditto.

* dfg/DFGJITCode.h:
(JSC::DFG::JITCode::osrEntryBlock):
(JSC::DFG::JITCode::setOSREntryBlock):
(JSC::DFG::JITCode::clearOSREntryBlock): Use helper functions for
accessing osrEntryBlock to help with write barrier stuff.

* dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):
(JSC::DFG::JITFinalizer::finalizeCommon):
* dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::adjustAndJumpToTarget): Use CodeBlock as owner instead of
executable.

* dfg/DFGOperations.cpp:
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::reallyAdd):
(JSC::DFG::Plan::notifyReady):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::finalizeAndNotifyCallback):
(JSC::DFG::Plan::key):
(JSC::DFG::Plan::rememberCodeBlocks):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
(JSC::DFG::Plan::clearCodeBlockMarks): Deleted.
* dfg/DFGPlan.h: Use normal GC write barrier concepts to model the fact
that the compiler writes to CodeBlocks.

* dfg/DFGToFTLDeferredCompilationCallback.cpp:
(JSC::DFG::ToFTLDeferredCompilationCallback::ToFTLDeferredCompilationCallback):
(JSC::DFG::ToFTLDeferredCompilationCallback::~ToFTLDeferredCompilationCallback):
(JSC::DFG::ToFTLDeferredCompilationCallback::create):
(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):
* dfg/DFGToFTLDeferredCompilationCallback.h:
* dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::ToFTLForOSREntryDeferredCompilationCallback):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::~ToFTLForOSREntryDeferredCompilationCallback):
(JSC::DFG::Ref<ToFTLForOSREntryDeferredCompilationCallback>ToFTLForOSREntryDeferredCompilationCallback::create):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):
* dfg/DFGToFTLForOSREntryDeferredCompilationCallback.h: We always have
a profiledDFGCodeBlock passed to use -- see above.

* dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::completeAllPlansForVM):
(JSC::DFG::Worklist::rememberCodeBlocks):
(JSC::DFG::completeAllPlansForVM):
(JSC::DFG::rememberCodeBlocks):
(JSC::DFG::Worklist::clearCodeBlockMarks): Deleted.
(JSC::DFG::clearCodeBlockMarks): Deleted.
* dfg/DFGWorklist.h:
(JSC::DFG::worklistForIndexOrNull): Renamed to use remembered set terminology.

* ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):

* heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::~CodeBlockSet):
(JSC::CodeBlockSet::add):
(JSC::CodeBlockSet::clearMarksForFullCollection):
(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced): No need for a fixpoint
anymore since the GC can tell us if we are live.

(JSC::CodeBlockSet::remove):
(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
(JSC::CodeBlockSet::dump):
(JSC::CodeBlockSet::clearMarksForEdenCollection): Deleted. No need for
this logic anymore since the GC will clear our mark bit.

(JSC::CodeBlockSet::traceMarked): Deleted. No need for this marking
fixpoint anymore either.

* heap/CodeBlockSet.h:

* heap/Heap.cpp:
(JSC::Heap::markRoots): Moved some of this logic around to make the
algorithm clearer.

(JSC::Heap::deleteAllCodeBlocks): Deleting CodeBlocks can only clear
pointers immediately; they won't fully delete until the next GC and sweep.

* interpreter/Interpreter.cpp:
(JSC::eval):
* jit/GCAwareJITStubRoutine.h: CodeBlock is owner now.

* jit/JITCode.h:
(JSC::JITCode::isJIT):
(JSC::JITCode::isLowerTier):
(JSC::JITCode::timeToLive): Deleted.

* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_enter): CodeBlock is owner now.

* jit/JITOperations.cpp:
* jit/JITToDFGDeferredCompilationCallback.cpp:
(JSC::JITToDFGDeferredCompilationCallback::create):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):
* jit/JITToDFGDeferredCompilationCallback.h:

* jit/Repatch.cpp:
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryRepatchIn):
(JSC::linkFor):
(JSC::linkPolymorphicCall):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::setUpCall):
* runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal): CodeBlock is owner now.

* runtime/Executable.cpp:
(JSC::ExecutableBase::clearCode): Provide a generic clearCode() so that
it can be used on any Executable. This fixes a very subtle bug where
deleteAllCode() does not remove CodeBlocks from non-function executables
that have been saved in stack traces.

(JSC::ScriptExecutable::installCode): WriteBarrier requires special
handling for pointers that may be null.

(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::newReplacementCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl): Update for interface
changes.

(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::ModuleProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
(JSC::WebAssemblyExecutable::visitChildren): Visit weakly because we want
to participate in jettisoning.

(JSC::WebAssemblyExecutable::prepareForExecution):
(JSC::EvalExecutable::clearCode): Deleted.
(JSC::ProgramExecutable::clearCode): Deleted.
(JSC::ModuleProgramExecutable::clearCode): Deleted.
(JSC::FunctionExecutable::clearCode): Deleted.
(JSC::WebAssemblyExecutable::clearCode): Deleted.

* runtime/Executable.h:
(JSC::ExecutableBase::generatedJITCodeForCall):
(JSC::ScriptExecutable::prepareForExecution):
(JSC::ExecutableBase::clearCodeVirtual): Deleted.

* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h: Provide structures because our GC requires it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRollout r190446 for the moment. It broke the build.
dino@apple.com [Fri, 2 Oct 2015 02:15:11 +0000 (02:15 +0000)]
Rollout r190446 for the moment. It broke the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Simplify filterableData processing
commit-queue@webkit.org [Fri, 2 Oct 2015 01:53:45 +0000 (01:53 +0000)]
Web Inspector: Simplify filterableData processing
https://bugs.webkit.org/show_bug.cgi?id=149730

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-01
Reviewed by Timothy Hatcher.

* UserInterface/Views/BreakpointTreeElement.js:
(WebInspector.BreakpointTreeElement.prototype.get filterableData):
* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.matchTextFilter):
* UserInterface/Views/ResourceTreeElement.js:
(WebInspector.ResourceTreeElement.prototype.get filterableData):
* UserInterface/Views/ScriptTimelineView.js:
(WebInspector.ScriptTimelineView.prototype.matchTreeElementAgainstCustomFilters): Deleted.
* UserInterface/Views/SearchResultTreeElement.js:
(WebInspector.SearchResultTreeElement.prototype.get filterableData):
(WebInspector.SearchResultTreeElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, fix build warning after r190434
ljaehun.lim@samsung.com [Fri, 2 Oct 2015 01:29:52 +0000 (01:29 +0000)]
Unreviewed, fix build warning after r190434

Fix error: variable ‘interruption’ set but not used [-Werror=unused-but-set-variable]

* testing/Internals.cpp:
(WebCore::Internals::beginMediaSessionInterruption):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoExpose WEBGL_debug_renderer_info
dino@apple.com [Fri, 2 Oct 2015 01:09:42 +0000 (01:09 +0000)]
Expose WEBGL_debug_renderer_info
https://bugs.webkit.org/show_bug.cgi?id=149735
<rdar://problem/18343500>

Reviewed by Simon Fraser.

Source/WebCore:

Enable the extension that allows content to query
for the GPUs vendor and details.

Now that we're enabling this, there was no need for
the internal setting that identified privileged situations.
However, since this meant that WEBGL_debug_shaders was
also exposed, I explicitly disable it since it is
not yet conformant.

Test: fast/canvas/webgl/webgl-debug-renderer-info.html
as well as the general conformance suite.

* html/canvas/WebGL2RenderingContext.cpp: No need to guard around allowPrivilegedExtensions().
(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
* html/canvas/WebGLRenderingContext.cpp: Ditto.
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::allowPrivilegedExtensions): Deleted.
* html/canvas/WebGLRenderingContextBase.h:
* page/Settings.in: Remove privilegedWebGLExtensions.
* platform/graphics/opengl/Extensions3DOpenGL.cpp: Forbid the translated shader
extension while it is still buggy.
(WebCore::Extensions3DOpenGL::supportsExtension):

LayoutTests:

Modify a test from the 1.0.2 conformance suite to make sure
we're actually enabling and passing the info.

* fast/canvas/webgl/webgl-debug-renderer-info-expected.txt: Added.
* fast/canvas/webgl/webgl-debug-renderer-info.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRebaselining fast/text/mark-matches-overflow-clip.html for Win
commit-queue@webkit.org [Fri, 2 Oct 2015 00:21:28 +0000 (00:21 +0000)]
Rebaselining fast/text/mark-matches-overflow-clip.html for Win
https://webkit.org/b/149728

Unreviewed test gardening.

Patch by Ryan Haddad <ryanhaddad@apple.com> on 2015-10-01

* platform/win/fast/text/mark-matches-overflow-clip-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago.:
bfulgham@apple.com [Fri, 2 Oct 2015 00:09:42 +0000 (00:09 +0000)]
.:
[Win] Unreviewed CMake build fix.

* Source/cmake/OptionsWin.cmake: Clean up options setttings,
and make sure exception handling is turned off.

Tools:
Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

Following r190424 we can now rely on webkit-build-directory to return the path to
the correct configuration-specific build directory on Windows.

Patch by Daniel Bates <dabates@apple.com> on 2015-10-01

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAnother attempt to fix the Windows builders after <https://trac.webkit.org/changeset...
dbates@webkit.org [Fri, 2 Oct 2015 00:03:58 +0000 (00:03 +0000)]
Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

Following r190424 we can now rely on webkit-build-directory to return the path to
the correct configuration-specific build directory on Windows.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed test fix after r190434.
bfulgham@apple.com [Thu, 1 Oct 2015 23:43:06 +0000 (23:43 +0000)]
Unreviewed test fix after r190434.

One test was not updated to pass the new required interruption type
argument to 'internals.beginMediaSessionInterruption'.

* webaudio/audiocontext-state-interrupted-expected.txt:
* webaudio/audiocontext-state-interrupted.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Do not immediately create all ProfileNodeTreeElements when showing...
commit-queue@webkit.org [Thu, 1 Oct 2015 23:34:09 +0000 (23:34 +0000)]
Web Inspector: Do not immediately create all ProfileNodeTreeElements when showing JavaScript and Events timeline
https://bugs.webkit.org/show_bug.cgi?id=149726

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-01
Reviewed by Timothy Hatcher.

* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.shouldFilterPopulate):
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
We were populating during filtering if there were any custom filters.
However the TimelineSidebarPanel has custom filters (based on time and type)
but those don't need to trigger population. Delay population until it
would actually be needed (like a text search).

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.shouldFilterPopulate):
Do not populate on filter via this custom filters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: REGRESSION (r189567): Toolbar collapses when inspector at minimum...
mattbaker@apple.com [Thu, 1 Oct 2015 23:33:06 +0000 (23:33 +0000)]
Web Inspector: REGRESSION (r189567): Toolbar collapses when inspector at minimum height with console open
https://bugs.webkit.org/show_bug.cgi?id=149725

Reviewed by Timothy Hatcher.

CSS Flexible Box Layout Module Level 1 introduces a new `auto` initial value for the min-{width|height}
of flex box items, breaking some areas of the inspector UI. This is fixed by setting a min-height of
zero for the #main <div>.

* UserInterface/Views/Main.css:
(#main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove unnecessary SpecialFastCaseProfiles.
mark.lam@apple.com [Thu, 1 Oct 2015 23:21:39 +0000 (23:21 +0000)]
Remove unnecessary SpecialFastCaseProfiles.
https://bugs.webkit.org/show_bug.cgi?id=149729

Reviewed by Saam Barati.

The current baseline code creates special fast case profiles records for
bytecodes that don't need them.  This was done to keep the DFG from crashing when
it searches for such a profile and don't find one.  Instead, we will fix the code
to check for the existence of the profile before dereferencing it to get a count.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::numberOfArrayProfiles):
(JSC::CodeBlock::arrayProfiles):
(JSC::CodeBlock::addArrayProfile):
(JSC::CodeBlock::likelyToTakeSpecialFastCase): Deleted.  Not used.
(JSC::CodeBlock::likelyToTakeAnySlowCase): Deleted.   Not used.
* jit/JITArithmetic.cpp:

(JSC::JIT::compileBinaryArithOp):
- Only op_mul needs the profile.  So, only allocate it in the op_mul case.

(JSC::JIT::emit_op_mul):
- These op_mul cases create the profile but never increments its counter.
  Hence, we can get rid of these.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] AirPlay should not stop when the screen locks
bfulgham@apple.com [Thu, 1 Oct 2015 22:32:56 +0000 (22:32 +0000)]
[iOS] AirPlay should not stop when the screen locks
https://bugs.webkit.org/show_bug.cgi?id=148315
<rdar://problem/22770703>

Patch by Eric Carlson <eric.carlson@apple.com> on 2015-10-01
Reviewed by Jer Noble.

Source/WebCore:

Tested by media/video-interruption-with-resume-allowing-play.html
          media/video-interruption-with-resume-not-allowing-play.html

* Modules/webaudio/AudioContext.h: overrideBackgroundPlaybackRestriction ->
  shouldOverrideBackgroundPlaybackRestriction.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::suspendPlayback): Fix a typo in the logging.
(WebCore::HTMLMediaElement::mayResumePlayback): Ditto.
(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction): Renamed from
  overrideBackgroundPlaybackRestriction.
(WebCore::HTMLMediaElement::overrideBackgroundPlaybackRestriction): Deleted.
* html/HTMLMediaElement.h:

* platform/audio/PlatformMediaSession.cpp:
(WebCore::stateName):
(WebCore::interruptionName): New, log the name of the interruption.
(WebCore::PlatformMediaSession::beginInterruption): Log the interruption type. Don't
  increment the interruption counter if we are going to ignore it. Incorporate logic
  from doInterruption.
(WebCore::PlatformMediaSession::doInterruption): Deleted.
(WebCore::PlatformMediaSession::shouldDoInterruption): Deleted.
(WebCore::PlatformMediaSession::forceInterruption): Deleted.

* platform/audio/PlatformMediaSession.h: Add SuspendedUnderLock interruption type.
* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground): Deleted.
* platform/audio/PlatformMediaSessionManager.h:

* platform/audio/ios/MediaSessionManagerIOS.h:
* platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::applicationDidEnterBackground): Call beginInterruption
  when appropriate.

LayoutTests:

* media/video-interruption-with-resume-allowing-play.html:
* media/video-interruption-with-resume-not-allowing-play.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSlot elements should support fallback contents
rniwa@webkit.org [Thu, 1 Oct 2015 20:36:34 +0000 (20:36 +0000)]
Slot elements should support fallback contents
https://bugs.webkit.org/show_bug.cgi?id=149701

Reviewed by Antti Koivisto.

Source/WebCore:

Following discussions on Github discussions [1] [2], we're adding the default rule of `display: contents`
on slot elements and making slot elements render its children when there are no assigned nodes [3].

Make these changes by attaching renderers on direct-children of slot elements when there are no assigned
nodes during render tree construction. Note `display: contents` will be aded in webkit.org/b/149439.

[1] https://github.com/w3c/webcomponents/issues/317
[2] https://github.com/w3c/webcomponents/issues/308
[3] https://github.com/w3c/webcomponents/issues/308#issuecomment-143655347

Tests: fast/shadow-dom/css-scoping-shadow-slot-fallback.html
       fast/shadow-dom/shadow-layout-after-slot-fallback-changes.html

* style/StyleResolveTree.cpp:
(WebCore::Style::attachSlotAssignees):
(WebCore::Style::detachSlotAssignees):
(WebCore::Style::resolveSlotAssignees):

LayoutTests:

Added tests for fallback contents in slot elements. One of them could be safely submitted to CSS WG,
and the other one is a style recalc test.

* fast/shadow-dom/css-scoping-shadow-slot-fallback-expected.html: Added.
* fast/shadow-dom/css-scoping-shadow-slot-fallback.html: Added.
* fast/shadow-dom/shadow-layout-after-slot-fallback-changes-expected.html: Added.
* fast/shadow-dom/shadow-layout-after-slot-fallback-changes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[ES6] Add TypedArray.prototype functionality.
keith_miller@apple.com [Thu, 1 Oct 2015 20:20:10 +0000 (20:20 +0000)]
[ES6] Add TypedArray.prototype functionality.
https://bugs.webkit.org/show_bug.cgi?id=148035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patch should add most of the functionality for
the prototype properties of TypedArray objects in ES6.
There are a few exceptions to this, which will be added
in upcoming patches:

1) First we do not use the species constructor for some
of the TypedArray prototype functions (namely: map, filter,
slice, and subarray). That will need to be added when
species constructors are finished.

2) TypedArrays still have a length, byteOffset, byteLength,
and buffer are still attached to the TypedArray instance (in
the spec they are on the TypedArray.prototype instance object)
since the JIT currently assumes those properties are fixed.

3) The TypedArray.constructor property is not added yet
as it should point to the TypedArray instance object,
which will be added in a future patch.

* CMakeLists.txt:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* builtins/TypedArray.prototype.js: Added.
(every):
(find):
(findIndex):
(forEach):
(some):
(sort.min):
(sort.merge):
(sort.mergeSort):
(sort):
(reduce):
(reduceRight):
(map):
(filter):
(toLocaleString):
* runtime/ArrayPrototype.cpp:
* runtime/ArrayPrototype.h:
* runtime/CommonIdentifiers.h:
* runtime/JSGenericTypedArrayView.h:
(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValue):
(JSC::JSGenericTypedArrayView::setRangeToValue):
(JSC::JSGenericTypedArrayView::sort):
(JSC::JSGenericTypedArrayView::purifyArray):
(JSC::JSGenericTypedArrayView::sortComparison):
(JSC::JSGenericTypedArrayView::sortFloat):
* runtime/JSGenericTypedArrayViewInlines.h:
* runtime/JSGenericTypedArrayViewPrototypeFunctions.h: Added.
(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncEntries):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncKeys):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoGetterFuncLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteOffset):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncValues):
* runtime/JSGenericTypedArrayViewPrototypeInlines.h:
(JSC::JSGenericTypedArrayViewPrototype<ViewClass>::finishCreation):
(JSC::genericTypedArrayViewProtoFuncSet): Deleted.
(JSC::genericTypedArrayViewProtoFuncSubarray): Deleted.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* runtime/JSObject.h:
* runtime/JSTypedArrayPrototypes.cpp:
* runtime/JSTypedArrayPrototypes.h:
* runtime/JSTypedArrayViewPrototype.cpp: Added.
(JSC::typedArrayViewPrivateFuncLength):
(JSC::typedArrayViewPrivateFuncSort):
(JSC::typedArrayViewProtoFuncSet):
(JSC::typedArrayViewProtoFuncEntries):
(JSC::typedArrayViewProtoFuncCopyWithin):
(JSC::typedArrayViewProtoFuncFill):
(JSC::typedArrayViewProtoFuncLastIndexOf):
(JSC::typedArrayViewProtoFuncIndexOf):
(JSC::typedArrayViewProtoFuncJoin):
(JSC::typedArrayViewProtoFuncKeys):
(JSC::typedArrayViewProtoGetterFuncLength):
(JSC::typedArrayViewProtoGetterFuncByteLength):
(JSC::typedArrayViewProtoGetterFuncByteOffset):
(JSC::typedArrayViewProtoFuncReverse):
(JSC::typedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncSlice):
(JSC::typedArrayViewProtoFuncValues):
(JSC::JSTypedArrayViewPrototype::JSTypedArrayViewPrototype):
(JSC::JSTypedArrayViewPrototype::finishCreation):
(JSC::JSTypedArrayViewPrototype::create):
(JSC::JSTypedArrayViewPrototype::createStructure):
* runtime/JSTypedArrayViewPrototype.h: Copied from Source/JavaScriptCore/runtime/JSTypedArrayPrototypes.cpp.
* tests/es6.yaml:
* tests/stress/resources/standalone-pre.js: Added.
(description):
(debug):
(escapeString):
(testPassed):
(testFailed):
(areNumbersEqual):
(areArraysEqual):
(isMinusZero):
(isTypedArray):
(isResultCorrect):
(stringify):
(shouldBe):
(dfgShouldBe):
(shouldBeType):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldBeUndefined):
(shouldNotThrow):
(shouldThrow):
(dfgCompiled):
(dfgIncrement):
(noInline):
(finishJSTest):
* tests/stress/resources/typedarray-test-helper-functions.js: Added.
(forEachTypedArray):
(isSameFunctionForEachTypedArrayPrototype.eq):
(isSameFunctionForEachTypedArrayPrototype):
(hasSameValues):
(foo):
(testPrototypeFunctionHelper):
(testPrototypeFunctionOnSigned):
(testPrototypeFunctionOnFloat):
(testPrototypeFunction):
(tester):
(testPrototypeReceivesArray):
* tests/stress/typedarray-copyWithin.js: Added.
* tests/stress/typedarray-every.js: Added.
(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-fill.js: Added.
* tests/stress/typedarray-filter.js: Added.
(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-find.js: Added.
(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-findIndex.js: Added.
(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-forEach.js: Added.
(checkCorrect.let.list):
(checkCorrect):
(createChecker):
(foo):
(changeArray):
(isBigEnoughAndException):
* tests/stress/typedarray-indexOf.js: Added.
(keepEven):
* tests/stress/typedarray-lastIndexOf.js: Added.
* tests/stress/typedarray-map.js: Added.
(even):
(evenAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-reduce.js: Added.
(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-reduceRight.js: Added.
(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-slice.js: Added.
* tests/stress/typedarray-some.js: Added.
(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-sort.js: Added.
(sortBackwards):
(compareException):

LayoutTests:

Fixed tests for new toString behavior on TypedArrays.

* fast/canvas/webgl/type-conversion-test-expected.txt:
* fast/dom/Window/window-postmessage-clone-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Fix TestWebKitAPI build under CMake.
bfulgham@apple.com [Thu, 1 Oct 2015 20:18:10 +0000 (20:18 +0000)]
[Win] Fix TestWebKitAPI build under CMake.

Reviewed by Alex Christensen.

* TestWebKitAPI/PlatformWin.cmake: Add missing link command
for Psapi.lib.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Clip string previews
nvasilyev@apple.com [Thu, 1 Oct 2015 19:54:15 +0000 (19:54 +0000)]
Web Inspector: Clip string previews
https://bugs.webkit.org/show_bug.cgi?id=149708

Only show first 140 characters in strings previews.

Reviewed by Joseph Pecoraro.

* UserInterface/Base/Utilities.js:
(String.prototype.truncate): Added.
A smart trancate function that doesn't split words.

* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._shouldConsiderObjectLossless):
* UserInterface/Views/FormattedValue.js:
(WebInspector.FormattedValue.createElementForTypesAndValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Another CMake build fix
bfulgham@apple.com [Thu, 1 Oct 2015 19:50:10 +0000 (19:50 +0000)]
[Win] Another CMake build fix

* PlatformWin.cmake: Add missing Psapi.lib to link list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Fix behavior of webkit-build-directory script
bfulgham@apple.com [Thu, 1 Oct 2015 19:38:49 +0000 (19:38 +0000)]
[Win] Fix behavior of webkit-build-directory script
https://bugs.webkit.org/show_bug.cgi?id=149718

Reviewed by Alex Christensen.

* Scripts/webkitdirs.pm:
(determineConfigurationProductDir): Do not include the binary
sub-directory in the configuration product directory output.
(jscProductDir): Append correct binary path for Windows build.
(setPathForRunningWebKitApp): Include properly binary subdirectories.
(runSafari): Update for revised productDir behavior.
(runMiniBrowser): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoLatch does not clear when a scroll snap animation is triggered
bfulgham@apple.com [Thu, 1 Oct 2015 19:31:22 +0000 (19:31 +0000)]
Latch does not clear when a scroll snap animation is triggered
https://bugs.webkit.org/show_bug.cgi?id=149681
<rdar://problem/22733922>

Reviewed by Simon Fraser.

Source/WebCore:

Test: tiled-drawing/scrolling/latched-div-with-scroll-snap.html

The scroll snap animation logic bypasses some of the normal clean-up code used
for wheel event handling. When this happens, the scroll latching state is not
cleared. In some cases this "stale" latch state is used when starting a new
gesture in the same frame. This causes the wrong page element to receive the
mouse wheel events, and hilarity ensues.

* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformNotifyIfEndGesture): Clear latched state when
ending the gesture.

LayoutTests:

Add a new test that confirms latched state is cleared when scroll snap animations
are triggered.

* tiled-drawing/scrolling/latched-div-with-scroll-snap-expected.txt: Added.
* tiled-drawing/scrolling/latched-div-with-scroll-snap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove some tests that now pass.
simon.fraser@apple.com [Thu, 1 Oct 2015 19:12:51 +0000 (19:12 +0000)]
Remove some tests that now pass.

* TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Unreviewed CMake build fixes.
bfulgham@apple.com [Thu, 1 Oct 2015 18:47:58 +0000 (18:47 +0000)]
[Win] Unreviewed CMake build fixes.

Source/WebCore:

* CMakeLists.txt: Match original Windows build flags for WebCoreTest.
* PlatformAppleWin.cmake: Use the same build defines as the
original Windows build.

Source/WebKit:

* CMakeLists.txt: Set the same build definitions as the original
project file.
* PlatformWin.cmake: Remove some soft-linked files from the static
link commands. Set build flags to match original project files.

Source/WTF:

* wtf/CMakeLists.txt: Correct build flags to match
the original project files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd iOS touch event test
simon.fraser@apple.com [Thu, 1 Oct 2015 18:26:42 +0000 (18:26 +0000)]
Add iOS touch event test
https://bugs.webkit.org/show_bug.cgi?id=149688

Reviewed by Ryosuke Niwa.

Basic touch event test that synthesizes touches in the UI process.

* TestExpectations:
* fast/events/touch/ios/touch-event-expected.txt: Added.
* fast/events/touch/ios/touch-event.html: Added.
* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoStop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
ap@apple.com [Thu, 1 Oct 2015 18:14:19 +0000 (18:14 +0000)]
Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
use iOS SDK, like with all the others.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoNetwork cache: Subresource referer header wrong after cached redirect
antti@apple.com [Thu, 1 Oct 2015 18:09:07 +0000 (18:09 +0000)]
Network cache: Subresource referer header wrong after cached redirect
https://bugs.webkit.org/show_bug.cgi?id=149709
rdar://problem/22917174

Reviewed by Chris Dumez.

Source/WebKit2:

If a main resource is loaded from a cache entry that involved redirects the document
will end up setting the Referer-headers of the subresources to the request URL not the redirected URL

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):

    If a cache entry involved a redirect synthesize a minimal willSendRequest message so that WebCore side
    runs through the same code paths as when receiving a redirect from network.

LayoutTests:

* http/tests/cache/redirect-referer-expected.html: Added.
* http/tests/cache/redirect-referer.html: Added.
* http/tests/cache/resources/load-and-check-referer.php: Added.
* http/tests/cache/resources/permanent-redirect.php: Added.
* http/tests/cache/resources/redirect-referer-iframe.html: Added.
* http/tests/cache/resources/redirect-referer-iframe-expected.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoaccessibility/mac/aria-expanded-notifications.html is flaky
mmaxfield@apple.com [Thu, 1 Oct 2015 17:45:59 +0000 (17:45 +0000)]
accessibility/mac/aria-expanded-notifications.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=149510

Reviewed by Chris Fleizach.

The problem is triggered by our resumable parser. AXLoadComplete gets called
synchronously from DocumentLoader::finishedLoading(). This means that the order of
the AXLoadComplete message isn't FIFO.

If the parser yielded previously, the AXLoadComplete will be handled after some AX
messages had been handled.

If the parser hadn't yielded, the AXLoadComplete will be the first message
processed (no matter what had been queued up before it).

Because making the AXLoadComplete message asynchonous is not desirable, the
solution is to relax the test to handle various orderings.

* accessibility/mac/aria-expanded-notifications-expected.txt:
* accessibility/mac/aria-expanded-notifications.html:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Adjust font size of Developer Tools using Command,+ or Command,-
bburg@apple.com [Thu, 1 Oct 2015 17:42:21 +0000 (17:42 +0000)]
Web Inspector: Adjust font size of Developer Tools using Command,+ or Command,-
https://bugs.webkit.org/show_bug.cgi?id=149590

Patch by João Oliveira <hello@jxs.pt> on 2015-09-30
Reviewed by Joseph Pecoraro.

Patch by João Oliveira and Brian Burg.

Source/WebCore:

Expose the frontend page's zoom factor so we can implement relative zoom.

* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::zoomFactor): Added.
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* page/Frame.h:
(WebCore::Frame::pageZoomFactor):

Source/WebInspectorUI:

* UserInterface/Base/Main.js:
(WebInspector.contentLoaded): Add global keyboard shortcuts for zoom in and zoom out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAttempt to fix the iOS 9 Simulator testers
dbates@webkit.org [Thu, 1 Oct 2015 17:38:21 +0000 (17:38 +0000)]
Attempt to fix the iOS 9 Simulator testers

Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
LayoutTestRelay when building for iOS Simulator.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoIntroduce SymbolUse optimization into CompareEq and CompareStrictEq
utatane.tea@gmail.com [Thu, 1 Oct 2015 17:20:44 +0000 (17:20 +0000)]
Introduce SymbolUse optimization into CompareEq and CompareStrictEq
https://bugs.webkit.org/show_bug.cgi?id=149616

Reviewed by Saam Barati.

Since ES6 Symbols are used as an enum value[1] (And WebKit inspector do so for Esprima's type of nodes),
optimizing equality comparison for symbols makes much sense.

This patch leverages SymbolUse for CompareEq and CompareStrictEq.
Optimizations for both DFG and FTL are implemented.

[1]: http://www.2ality.com/2014/12/es6-symbols.html

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateSymbol):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::extractStringImplFromBinarySymbols):
(JSC::DFG::SpeculativeJIT::compileSymbolEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleSymbolEquality):
* dfg/DFGSpeculativeJIT.h:
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCompareStrictEq):
* tests/stress/symbol-equality.js: Added.
(shouldBe):
(equal):
(strictEqual):
(list.forEach.result.set 1):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Websites with invalid auth header keep loading forever
carlosgc@webkit.org [Thu, 1 Oct 2015 17:18:28 +0000 (17:18 +0000)]
[GTK] Websites with invalid auth header keep loading forever
https://bugs.webkit.org/show_bug.cgi?id=149710

Reviewed by Martin Robinson.

Source/WebCore:

We don't correctly handle a null realm from the server when
retrieving and storing credentials from libsecret. First
secret_attributes_build() fails because we pass a null domain, and
we pass null attributes to secret_service_search() that returns
early on a g_return macro and the callback is never called so the
load doesn't continue after the auth challenge.

* platform/network/gtk/CredentialBackingStore.cpp:
(WebCore::createAttributeHashTableFromChallenge):
(WebCore::CredentialBackingStore::credentialForChallenge):
(WebCore::CredentialBackingStore::storeCredentialsForChallenge):

Source/WebKit2:

Do not show the remember credentials checkbutton in the auth
dialog if the realm is empty.

* UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:
(webkitAuthenticationDialogInitialize):

Tools:

Add test case to check that we can authenticate sites with an
empty realm.

* TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
(testWebViewAuthenticationEmptyRealm):
(serverCallback):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Mac] Make run-api-tests work with System Integrity Protection
ap@apple.com [Thu, 1 Oct 2015 17:16:40 +0000 (17:16 +0000)]
[Mac] Make run-api-tests work with System Integrity Protection
https://bugs.webkit.org/show_bug.cgi?id=149711
rdar://problem/22928202

Reviewed by Dan Bernstein.

* Scripts/run-api-tests:
(runTest):
(archCommandLineArgumentsForRestrictedEnvironmentVariables):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAttempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
dbates@webkit.org [Thu, 1 Oct 2015 17:10:30 +0000 (17:10 +0000)]
Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
For now, use the path to the top-level WebKit build directory instead of using the configuration-
specific build directory.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMove <a ping> tests from LayoutTests/http/tests/navigation to LayoutTests/http/tests...
dbates@webkit.org [Thu, 1 Oct 2015 16:43:34 +0000 (16:43 +0000)]
Move <a ping> tests from LayoutTests/http/tests/navigation to LayoutTests/http/tests/navigation/ping-attribute
https://bugs.webkit.org/show_bug.cgi?id=148828

Reviewed by Alexey Proskuryakov.

Towards adding <area ping> tests (bug #79438), we should move the existing <a ping> tests from
LayoutTests/http/tests/navigation to LayoutTests/http/tests/navigation/ping-attribute and rename
them so as to make it clear from their name that they test the ping attribute on a HTML a element.

* http/tests/navigation/ping-attribute/anchor-cookie-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-cookie-expected.txt.
* http/tests/navigation/ping-attribute/anchor-cookie.html: Renamed from LayoutTests/http/tests/navigation/ping-cookie.html.
* http/tests/navigation/ping-attribute/anchor-cross-origin-expected.txt: Added.
* http/tests/navigation/ping-attribute/anchor-cross-origin-from-https-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin-from-https-expected.txt.
* http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin-from-https.html.
* http/tests/navigation/ping-attribute/anchor-cross-origin.html: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin.html.
* http/tests/navigation/ping-attribute/anchor-same-origin-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-same-origin-expected.txt.
* http/tests/navigation/ping-attribute/anchor-same-origin.html: Renamed from LayoutTests/http/tests/navigation/ping-same-origin.html.
* http/tests/navigation/ping-attribute/resources/check-ping.php: Added.
* http/tests/navigation/ping-attribute/resources/delete-ping.php: Added.
* http/tests/navigation/ping-attribute/resources/ping-file-path.php: Added.
* http/tests/navigation/ping-attribute/resources/save-Ping.php: Added.
* http/tests/navigation/ping-cross-origin-expected.txt: Removed.
* platform/ios-simulator-wk2/TestExpectations: Updated as needed for the above file renames.
* platform/win/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
ossy@webkit.org [Thu, 1 Oct 2015 15:39:03 +0000 (15:39 +0000)]
[EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
https://bugs.webkit.org/show_bug.cgi?id=145837

Reviewed by Philippe Normand.

* efl/jhbuild.modules:
* efl/patches/openwebrtc-clang-warning-fix.patch: Added.
* efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed. Fix the iOS build after r190407.
wenson_hsieh@apple.com [Thu, 1 Oct 2015 15:18:03 +0000 (15:18 +0000)]
Unreviewed. Fix the iOS build after r190407.

* WebKitTestRunner/ios/IOKitSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImplement keyboard event sending for iOS in WebKitTestRunner
wenson_hsieh@apple.com [Thu, 1 Oct 2015 14:28:38 +0000 (14:28 +0000)]
Implement keyboard event sending for iOS in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=149676

Reviewed by Simon Fraser.

Tools:

Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
allows us to run code when the keyboard is shown or hidden.

* WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
* WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::setDidShowKeyboardCallback):
(WTR::UIScriptController::didShowKeyboardCallback):
(WTR::UIScriptController::setDidHideKeyboardCallback):
(WTR::UIScriptController::didHideKeyboardCallback):
(WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
(WTR::UIScriptController::platformSetDidShowKeyboardCallback):
(WTR::UIScriptController::platformSetDidHideKeyboardCallback):
* WebKitTestRunner/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
        the notifications that the keyboard has been raised or lowered.
(-[TestRunnerWKWebView _keyboardDidShow:]):
(-[TestRunnerWKWebView _keyboardDidHide:]):
* WebKitTestRunner/ios/HIDEventGenerator.h:
* WebKitTestRunner/ios/HIDEventGenerator.m:
(-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
(shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
(hidUsageCodeForCharacter): Ditto.
(-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
        a keyDown event in WebKit.
* WebKitTestRunner/ios/IOKitSPI.h:
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:

LayoutTests:

Adds a new basic test for the oninput event listener when typing in a text field.

* fast/events/ios/input-value-after-oninput-expected.txt: Added.
* fast/events/ios/input-value-after-oninput.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r190399.
carlosgc@webkit.org [Thu, 1 Oct 2015 13:38:46 +0000 (13:38 +0000)]
Unreviewed, rolling out r190399.

Tests are still failing even after r190362

Reverted changeset:

"Unreviewed. Unskip GTK+ user media unit tests after r190362."
http://trac.webkit.org/changeset/190399

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Web Inspector: Add GTK+ icons for the numerical input and slider based Visual...
agomez@igalia.com [Thu, 1 Oct 2015 13:38:41 +0000 (13:38 +0000)]
[GTK] Web Inspector: Add GTK+ icons for the numerical input and slider based Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147847

Reviewed by Carlos Garcia Campos.

* UserInterface/Images/gtk/VisualStylePropertyLinked.svg: Added.
* UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Web Inspector: Add GTK+ icons for the different types of non-numerical Visual...
agomez@igalia.com [Thu, 1 Oct 2015 13:36:00 +0000 (13:36 +0000)]
[GTK] Web Inspector: Add GTK+ icons for the different types of non-numerical Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147846

Reviewed by Carlos Garcia Campos.

* UserInterface/Images/gtk/AUTHORS: Updated.
* UserInterface/Images/gtk/ClearBoth.svg: Added.
* UserInterface/Images/gtk/ClearLeft.svg: Added.
* UserInterface/Images/gtk/ClearRight.svg: Added.
* UserInterface/Images/gtk/CubicBezier.svg: Updated.
* UserInterface/Images/gtk/FloatLeft.svg: Added.
* UserInterface/Images/gtk/FloatRight.svg: Added.
* UserInterface/Images/gtk/FontStyleItalic.svg: Added.
* UserInterface/Images/gtk/FontStyleNormal.svg: Added.
* UserInterface/Images/gtk/FontVariantSmallCaps.svg: Added.
* UserInterface/Images/gtk/TextAlignCenter.svg: Added.
* UserInterface/Images/gtk/TextAlignJustify.svg: Added.
* UserInterface/Images/gtk/TextAlignLeft.svg: Added.
* UserInterface/Images/gtk/TextAlignRight.svg: Added.
* UserInterface/Images/gtk/TextDecorationLineThrough.svg: Added.
* UserInterface/Images/gtk/TextDecorationOverline.svg: Added.
* UserInterface/Images/gtk/TextDecorationUnderline.svg: Added.
* UserInterface/Images/gtk/TextTransformCapitalize.svg: Added.
* UserInterface/Images/gtk/TextTransformLowercase.svg: Added.
* UserInterface/Images/gtk/TextTransformUppercase.svg: Added.
* UserInterface/Images/gtk/VisualStyleNone.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRefactor binding generator to factor JS DOM class m_impl handling
youenn.fablet@crf.canon.fr [Thu, 1 Oct 2015 13:07:55 +0000 (13:07 +0000)]
Refactor binding generator to factor JS DOM class m_impl handling
https://bugs.webkit.org/show_bug.cgi?id=149660

Reviewed by Darin Adler.

Added JSDOMWrapperWithImplementation template class to move m_impl out of the binding generator.
Updated custom bindings to use impl() instead of m_impl directly.
Updated binding generator accordingly.

Covered by existing tests and binding tests.

* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapperWithImplementation::impl):
(WebCore::JSDOMWrapperWithImplementation::~JSDOMWrapperWithImplementation):
(WebCore::JSDOMWrapperWithImplementation::JSDOMWrapperWithImplementation):
(WebCore::JSDOMWrapperWithImplementation::releaseImpl):
* bindings/js/JSGeolocationCustom.cpp:
(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):
* bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):
* bindings/scripts/CodeGeneratorJS.pm:
(GetParentClassName):
(GetImplClassName):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObject::JSTestActiveDOMObject):
(WebCore::JSTestActiveDOMObject::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::JSTestActiveDOMObject::~JSTestActiveDOMObject):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor): Deleted.
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::~JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(WebCore::JSTestCustomNamedGetter::~JSTestCustomNamedGetter):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::jsTestEventConstructorAttr1): Deleted.
* bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::JSTestEventConstructor::~JSTestEventConstructor):
(WebCore::JSTestEventConstructor::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::JSTestEventTarget):
(WebCore::JSTestEventTarget::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTarget::~JSTestEventTarget):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestException::JSTestException):
(WebCore::JSTestException::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestException.h:
(WebCore::JSTestException::~JSTestException):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachable::JSTestGenerateIsReachable):
(WebCore::jsTestGenerateIsReachableConstructor): Deleted.
* bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
(WebCore::JSTestGenerateIsReachable::~JSTestGenerateIsReachable):
(WebCore::JSTestGenerateIsReachable::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterface::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::jsTestJSBuiltinConstructorConstructor): Deleted.
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:
(WebCore::JSTestJSBuiltinConstructor::~JSTestJSBuiltinConstructor):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::jsTestMediaQueryListListenerConstructor): Deleted.
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::~JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListener::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::jsTestNamedConstructorConstructor): Deleted.
* bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::JSTestNamedConstructor::~JSTestNamedConstructor):
(WebCore::JSTestNamedConstructor::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministic::JSTestNondeterministic):
(WebCore::jsTestNondeterministicNondeterministicReadonlyAttr): Deleted.
* bindings/scripts/test/JS/JSTestNondeterministic.h:
(WebCore::JSTestNondeterministic::~JSTestNondeterministic):
(WebCore::JSTestNondeterministic::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObj::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::~JSTestObj):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):
(WebCore::jsTestOverloadedConstructorsConstructor): Deleted.
* bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::JSTestOverloadedConstructors::~JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins):
(WebCore::JSTestOverrideBuiltins::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
(WebCore::JSTestOverrideBuiltins::~JSTestOverrideBuiltins):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfaceValue): Deleted.
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::~JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterface::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefs::JSTestTypedefs):
(WebCore::JSTestTypedefs::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::JSTestTypedefs::~JSTestTypedefs):
* bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattribute::JSattribute):
(WebCore::jsattributeReadonly): Deleted.
* bindings/scripts/test/JS/JSattribute.h:
(WebCore::JSattribute::~JSattribute):
(WebCore::JSattribute::finishCreation): Deleted.
* bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonly::JSreadonly):
(WebCore::jsreadonlyConstructor): Deleted.
* bindings/scripts/test/JS/JSreadonly.h:
(WebCore::JSreadonly::~JSreadonly):
(WebCore::JSreadonly::finishCreation): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the ARM build after r190192
ossy@webkit.org [Thu, 1 Oct 2015 12:35:38 +0000 (12:35 +0000)]
Fix the ARM build after r190192
https://bugs.webkit.org/show_bug.cgi?id=149620

Reviewed by Darin Adler.

* platform/graphics/FontFeatureSettings.h:
(WebCore::fontFeatureTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Streams API] Add support for private WebCore JS builtins functions
youenn.fablet@crf.canon.fr [Thu, 1 Oct 2015 12:30:43 +0000 (12:30 +0000)]
[Streams API] Add support for private WebCore JS builtins functions
https://bugs.webkit.org/show_bug.cgi?id=149518

Reviewed by Darin Adler.

Source/JavaScriptCore:

Adding API to add private identifiers on the fly.
This is used to support private JS Builtin functions/private JS Builtin names in WebCore.

* builtins/BuiltinNames.h:
(JSC::BuiltinNames::appendExternalName):
* runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::appendExternalName):
* runtime/CommonIdentifiers.h:

Source/WebCore:

Using ReadableStream tee method as a testbed to add support for private WebCore JS builtins functions.
Private functions are hooked to JSDOMWindowBase, as it is the one connected to WebCoreClientData.
WebCoreClientData is responsible to export the private function symbols to the VM.

Updated generate-js-builtins script to generate a class that can create and own all JS functions.
This class is used by JSDOMWindowBase to create the JS builtin functions.
It is also used to manage the GC of these objects.

Covered by rebased tests.

* CMakeLists.txt: Adding ReadableStreamInternals builtin files.
* DerivedSources.cpp: Ditto.
* DerivedSources.make: Ditto.
* Modules/streams/ReadableStream.idl: Adding tee declaration as builtin
* Modules/streams/ReadableStream.js:
(tee): Calling @teeReadableStream
* Modules/streams/ReadableStreamInternals.js: Barebone @teeReadableStream implementation.
(teeReadableStream):
* WebCore.vcxproj/WebCore.vcxproj: Adding ReadableStreamInternals builtin files.
* WebCore.xcodeproj/project.pbxproj: Adding ReadableStreamInternals builtin files.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase): Creating ReadableStreamInternalsBuiltinFunctions object.
(WebCore::JSDOMWindowBase::finishCreation): Creating builtin functions through ReadableStreamInternalsBuiltinFunctions and registering them to the JS engine.
(WebCore::JSDOMWindowBase::visitChildren): Ensuring GC does not collect private builtin functions through ReadableStreamInternalsBuiltinFunctions object
* bindings/js/JSDOMWindowBase.h:
* bindings/js/WebCoreJSClientData.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Exporting private names of ReadableStreamInternalsBuiltins
(WebCore::WebCoreJSClientData::readableStreamBuiltins):
(WebCore::WebCoreJSClientData::readableStreamInternalsBuiltins):
* generate-js-builtins: Adding support for ReadableStreamInternalsBuiltinFunctions and exportNames.

LayoutTests:

Rebasing tests now that tee is appearing in the IDL, although not yet conformant in its implementation.

* streams/reference-implementation/readable-stream-expected.txt:
* streams/reference-implementation/readable-stream-tee-expected.txt:
* streams/reference-implementation/readable-stream-templated-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[jhbuild] switch to new upstream usrsctp library
ossy@webkit.org [Thu, 1 Oct 2015 10:52:37 +0000 (10:52 +0000)]
[jhbuild] switch to new upstream usrsctp library
https://bugs.webkit.org/show_bug.cgi?id=149494

Reviewed by Philippe Normand.

* efl/jhbuild.modules:
* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed. Unskip GTK+ user media unit tests after r190362.
carlosgc@webkit.org [Thu, 1 Oct 2015 09:28:49 +0000 (09:28 +0000)]
Unreviewed. Unskip GTK+ user media unit tests after r190362.

They should pass now.

* Scripts/run-gtk-tests:
(TestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoBinding generator should make mutable CachedAttribute member fields
youenn.fablet@crf.canon.fr [Thu, 1 Oct 2015 08:12:40 +0000 (08:12 +0000)]
Binding generator should make mutable CachedAttribute member fields
https://bugs.webkit.org/show_bug.cgi?id=148056

Reviewed by Chris Dumez.

Making mutable CachedAttribute member fields.
Removing const_cast from custom binding code.
Rebased bindings tests.

No change in behavior.

* bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::state):
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data):
* bindings/js/JSPopStateEventCustom.cpp:
(WebCore::cacheState):
(WebCore::JSPopStateEvent::state):
* bindings/js/JSReadableStreamReaderEventCustom.cpp:
(WebCore::JSReadableStreamReader::closed):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::response):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Streams API] Update readable-stream tests against latest reference
calvaris@igalia.com [Thu, 1 Oct 2015 07:44:11 +0000 (07:44 +0000)]
[Streams API] Update readable-stream tests against latest reference
https://bugs.webkit.org/show_bug.cgi?id=149668

Reviewed by Darin Adler.

* streams/reference-implementation/readable-stream-expected.txt: Updated expectations.
* streams/reference-implementation/readable-stream.html: Updated tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Stream API] Add pending checkpoints for up-to-date readable stream related tests...
calvaris@igalia.com [Thu, 1 Oct 2015 07:41:12 +0000 (07:41 +0000)]
[Stream API] Add pending checkpoints for up-to-date readable stream related tests and fix checkpoint URL
https://bugs.webkit.org/show_bug.cgi?id=149666

Reviewed by Darin Adler.

* streams/readable-stream-reader-read.html:
* streams/reference-implementation/abstract-ops.html:
* streams/reference-implementation/bad-strategies.html:
* streams/reference-implementation/bad-underlying-sources.html:
* streams/reference-implementation/pipe-to-options.html:
* streams/reference-implementation/pipe-to.html:
* streams/reference-implementation/readable-stream-cancel.html:
* streams/reference-implementation/writable-stream-abort.html:
* streams/reference-implementation/writable-stream.html: Added and fixed checkpoint URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Streams API] Create ByteLengthQueuingStrategy object as per spec
calvaris@igalia.com [Thu, 1 Oct 2015 07:38:52 +0000 (07:38 +0000)]
[Streams API] Create ByteLengthQueuingStrategy object as per spec
https://bugs.webkit.org/show_bug.cgi?id=147153

Reviewed by Darin Adler.

Source/WebCore:

Added ByteLengthQueuingStream class as the spec defines at https://streams.spec.whatwg.org/#blqs-class.

Tests are covered by current set.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreJSBuiltins.cpp: Added build instructions.
* Modules/streams/ByteLengthQueuingStrategy.idl: Added.
* Modules/streams/ByteLengthQueuingStrategy.js: Copied from Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp.
(size): Return byteLength attribute of the chunk.
(initializeByteLengthQueuingStrategy): Initialize the highWaterMark property.
* bindings/js/WebCoreJSClientData.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Initialize the blqs builtins.
(WebCore::WebCoreJSClientData::byteLengthQueuingStrategyBuiltins): Return the attribute.

LayoutTests:

* js/dom/global-constructors-attributes-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt: Added ByteLengthQueuingStrategy to the
constructor expectations.
* streams/reference-implementation/brand-checks.html:
* streams/reference-implementation/byte-length-queuing-strategy.html: Removed reference to
byte-length-queuing-strategy.js as it should be now builtin in WebKit.
* streams/reference-implementation/resources/byte-length-queuing-strategy.js: Removed.
(ByteLengthQueuingStrategy): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoClean up all uses of PassRefPtr in Modules/geolocation
gyuyoung.kim@webkit.org [Thu, 1 Oct 2015 07:22:50 +0000 (07:22 +0000)]
Clean up all uses of PassRefPtr in Modules/geolocation
https://bugs.webkit.org/show_bug.cgi?id=149552

Reviewed by Darin Adler.

* Modules/geolocation/GeoNotifier.cpp:
(WebCore::GeoNotifier::GeoNotifier):
(WebCore::GeoNotifier::setFatalError):
* Modules/geolocation/GeoNotifier.h:
(WebCore::GeoNotifier::create):
* Modules/geolocation/Geolocation.cpp:
(WebCore::createGeoposition):
(WebCore::createPositionError):
(WebCore::Geolocation::Watchers::add):
(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::startRequest):
* Modules/geolocation/Geolocation.h:
* Modules/geolocation/GeolocationError.h:
* Modules/geolocation/GeolocationPosition.h:
* Modules/geolocation/Geoposition.h:
(WebCore::Geoposition::create):
(WebCore::Geoposition::isolatedCopy):
(WebCore::Geoposition::Geoposition):
* Modules/geolocation/PositionError.h:
* Modules/geolocation/PositionOptions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, cleanup after r190385
ljaehun.lim@samsung.com [Thu, 1 Oct 2015 06:00:26 +0000 (06:00 +0000)]
Unreviewed, cleanup after r190385

TypedArray.prototype.js is removed at r190385.
Remove it from CMakeLists.txt as well.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAnother attempt to fix the build after <https://trac.webkit.org/changeset/190387>
dbates@webkit.org [Thu, 1 Oct 2015 05:54:09 +0000 (05:54 +0000)]
Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

* BuildSlaveSupport/built-product-archive:
(determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
(extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAttempt to fix the build after <https://trac.webkit.org/changeset/190387>
dbates@webkit.org [Thu, 1 Oct 2015 05:45:06 +0000 (05:45 +0000)]
Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

Actually, we need to pass --configuration to script webkit-build-directory to have
it return the path to the configuration-specific build directory.

* BuildSlaveSupport/built-product-archive:
(determineWebKitBuildDirectories):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agobuilt-product-archive archives incorrect build directory for iOS port
dbates@webkit.org [Thu, 1 Oct 2015 04:57:46 +0000 (04:57 +0000)]
built-product-archive archives incorrect build directory for iOS port
https://bugs.webkit.org/show_bug.cgi?id=149695

Reviewed by Darin Adler.

Fixes an issue where the script built-product-archive archives a non-existent
build directory for the iOS port. Without loss of generality, the script assumes
the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.

Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
to determine the top-level build directory and computes the configuration-specific
build directory to be the concatenation of the the top-level build directory and
the configuration (e.g. Release). This is incorrect. Instead we should call
webkit-build-directory omitting the flag --top-level to compute the path to the
configuration-specific build directory.

* BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
(main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
its purpose and added global variable _configurationBuildDirectory to store the path
to the configuration-specific build directory. Ensure that we have a non-empty string
for both the top-level and configuration-specific build directories.
(determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
Compute the configuration-specific build directory and store it in the global variable
_configurationBuildDirectory.
(archiveBuiltProduct): Modified to use _configurationBuildDirectory.
(extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
as needed.
(determineWebKitBuildDirectory): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL] css3/device-adapt/* tests failed after r190335.
commit-queue@webkit.org [Thu, 1 Oct 2015 04:21:13 +0000 (04:21 +0000)]
[EFL] css3/device-adapt/* tests failed after r190335.
https://bugs.webkit.org/show_bug.cgi?id=149655

Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2015-09-30
Reviewed by Simon Fraser.

device-adapt/* tests need the fixedLayout option but useFixedLayout option is
overwritten by updatePlatformSpecificViewOptionsForTest after r190335.

* WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::shouldUseFixedLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r190367 and r190373.
commit-queue@webkit.org [Thu, 1 Oct 2015 04:16:42 +0000 (04:16 +0000)]
Unreviewed, rolling out r190367 and r190373.
https://bugs.webkit.org/show_bug.cgi?id=149694

Windows build broken (Requested by smfr on #webkit).

Reverted changesets:

"[ES6] Add TypedArray.prototype functionality."
https://bugs.webkit.org/show_bug.cgi?id=148035
http://trac.webkit.org/changeset/190367

"Unreviewed Windows buildfix."
http://trac.webkit.org/changeset/190373

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL][Gtk] Try to fix the build after r190379.
commit-queue@webkit.org [Thu, 1 Oct 2015 03:55:37 +0000 (03:55 +0000)]
[EFL][Gtk] Try to fix the build after r190379.
https://bugs.webkit.org/show_bug.cgi?id=149693

Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2015-09-30
Reviewed by Gyuyoung Kim.

* Modules/indexeddb/server/MemoryIDBBackingStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSource/WebCore:
commit-queue@webkit.org [Thu, 1 Oct 2015 03:17:26 +0000 (03:17 +0000)]
Source/WebCore:
Add support for the imageSmoothingQuality property for CanvasRenderingContext2D.
https://bugs.webkit.org/show_bug.cgi?id=149541

Patch by Katlyn Graff <kgraff@apple.com> on 2015-09-30
Reviewed by Ryosuke Niwa.

As documented here: https://html.spec.whatwg.org/multipage/scripting.html#image-smoothing
Exposes the smooothing quality of algorithms used for scaling images. Valid input
values are low, medium, and high: associated algorithms are expected to vary for
differing hardware. setImageSmoothingQuality provides a handle into CGInterpolationQuality.

Test: fast/canvas/canvas-imageSmoothingQuality.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::smoothingToInterpolationQuality):
(WebCore::CanvasRenderingContext2D::imageSmoothingQuality):
(WebCore::CanvasRenderingContext2D::setImageSmoothingQuality):
(WebCore::CanvasRenderingContext2D::setImageSmoothingEnabled):
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:
Tests support for imageSmoothingQuality attribute of Canvas element.
https://bugs.webkit.org/show_bug.cgi?id=149541

Patch by Katlyn Graff <kgraff@apple.com> on 2015-09-30
Reviewed by Ryosuke Niwa.

Tests low, medium, high, and default values, value persistence when
imageSmoothingEnabled is changed, and invalid input.

* fast/canvas/canvas-imageSmoothingQuality-expected.txt: Added.
* fast/canvas/canvas-imageSmoothingQuality.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGraphicsContext3D::mappedSymbolName should initialize count variable
dino@apple.com [Thu, 1 Oct 2015 01:39:47 +0000 (01:39 +0000)]
GraphicsContext3D::mappedSymbolName should initialize count variable
https://bugs.webkit.org/show_bug.cgi?id=149692
<rdar://problem/22871304>

Reviewed by Simon Fraser.

While debugging another WebGL issue, I noticed that some
OpenGL renderers can get into a state where they
drop resources (e.g. a GPU reset). If we don't detect that
in time, we might try to ask for the currently attached
resources and our in-parameter will not be set. In this
case, initialize it to zero so that we don't do silly things.

* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::mappedSymbolName): Initialize count to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Reduce `delete` in Timeline related classes
commit-queue@webkit.org [Thu, 1 Oct 2015 01:32:26 +0000 (01:32 +0000)]
Web Inspector: Reduce `delete` in Timeline related classes
https://bugs.webkit.org/show_bug.cgi?id=149686

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-09-30
Reviewed by Timothy Hatcher.

* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype.capturingStopped):
* UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
(WebInspector.TimelineDataGrid.prototype._sort):
(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
* UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.updateLayout):
(WebInspector.TimelineOverview.prototype._handleScrollEvent):
* UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeOutlineScrolled):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridScrolled):

* UserInterface/Views/ProbeSetDataGrid.js:
(WebInspector.ProbeSetDataGrid):
(WebInspector.ProbeSetDataGrid.prototype._teardownData):
Remove an unused member variable as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCrash in gleLookupHashObject when context is lost
dino@apple.com [Thu, 1 Oct 2015 01:29:52 +0000 (01:29 +0000)]
Crash in gleLookupHashObject when context is lost
https://bugs.webkit.org/show_bug.cgi?id=149690
<rdar://problem/22751585>
<rdar://problem/22465495>

Reviewed by Simon Fraser.

When we received notification that the GPU has reset,
we were nulling out and deleting our OpenGL contexts
and then trying to do it all over again. The fix was
to flip the order of operations.

While there I added some logging, and changed the
way we check GPU status to make sure we do a check
after the first draw call.

Unfortunately we can't test automatically because it
involves resetting the GPU which can possibly cause
concurrent tests to fail.

* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::checkGPUStatusIfNecessary): Move forceContextLost()
to be the first thing we do after we've realised we need to
bail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd UniqueIDBDatabase object, IDBBackingStore objects, and a database operation thread.
beidson@apple.com [Thu, 1 Oct 2015 01:04:19 +0000 (01:04 +0000)]
Add UniqueIDBDatabase object, IDBBackingStore objects, and a database operation thread.
https://bugs.webkit.org/show_bug.cgi?id=149678

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/opendatabase-request-event.html

- UniqueIDBDatabase represents a specific IDB database instance that can have multiple
  connections to it.
- IDBBackingStore is an abstract representation of a unique database's backing store,
  and has a concrete in-memory implementation for now.
- The database thread exists on IDBServer and is for offloading actual database I/O from
  the main thread.

* CMakeLists.txt:

* Modules/indexeddb/IDBDatabaseIdentifier.cpp:
(WebCore::IDBDatabaseIdentifier::isolatedCopy):
* Modules/indexeddb/IDBDatabaseIdentifier.h:

* Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::openDatabase):
(WebCore::IDBClient::IDBConnectionToServer::didOpenDatabase):
* Modules/indexeddb/client/IDBConnectionToServer.h:
* Modules/indexeddb/client/IDBConnectionToServerDelegate.h:

* Modules/indexeddb/client/IDBFactoryImpl.cpp:
(WebCore::IDBClient::IDBFactory::openInternal):

* Modules/indexeddb/server/IDBBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClientDelegate.h.
(WebCore::IDBServer::IDBBackingStore::~IDBBackingStore):

* Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::didOpenDatabase):
* Modules/indexeddb/server/IDBConnectionToClient.h:
* Modules/indexeddb/server/IDBConnectionToClientDelegate.h:

* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::IDBServer):
(WebCore::IDBServer::IDBServer::getOrCreateUniqueIDBDatabase):
(WebCore::IDBServer::IDBServer::createBackingStore):
(WebCore::IDBServer::IDBServer::openDatabase):
(WebCore::IDBServer::IDBServer::deleteDatabase):
(WebCore::IDBServer::IDBServer::postDatabaseTask):
(WebCore::IDBServer::IDBServer::postDatabaseTaskReply):
(WebCore::IDBServer::IDBServer::databaseThreadEntry):
(WebCore::IDBServer::IDBServer::databaseRunLoop):
(WebCore::IDBServer::IDBServer::handleTaskRepliesOnMainThread):
* Modules/indexeddb/server/IDBServer.h:

* Modules/indexeddb/server/IDBServerOperation.cpp: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClientDelegate.h.
(WebCore::IDBServer::IDBServerOperation::create):
(WebCore::IDBServer::IDBServerOperation::IDBServerOperation):
* Modules/indexeddb/server/IDBServerOperation.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBServer.h.
(WebCore::IDBServer::IDBServerOperation::connection):
(WebCore::IDBServer::IDBServerOperation::requestData):

* Modules/indexeddb/server/MemoryIDBBackingStore.cpp: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClient.cpp.
(WebCore::IDBServer::MemoryIDBBackingStore::create):
(WebCore::IDBServer::MemoryIDBBackingStore::MemoryIDBBackingStore):
(WebCore::IDBServer::MemoryIDBBackingStore::~MemoryIDBBackingStore):
(WebCore::IDBServer::MemoryIDBBackingStore::getOrEstablishDatabaseInfo):
* Modules/indexeddb/server/MemoryIDBBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClient.h.

* Modules/indexeddb/server/UniqueIDBDatabase.cpp: Added.
(WebCore::IDBServer::UniqueIDBDatabase::UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::openDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabase::handleOpenDatabaseOperations):
(WebCore::IDBServer::UniqueIDBDatabase::openBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::didOpenBackingStore):
* Modules/indexeddb/server/UniqueIDBDatabase.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBServer.h.
(WebCore::IDBServer::UniqueIDBDatabase::create):

* Modules/indexeddb/shared/IDBDatabaseInfo.cpp: Copied from Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h.
(WebCore::IDBDatabaseInfo::IDBDatabaseInfo):
(WebCore::IDBDatabaseInfo::isolatedCopy):
* Modules/indexeddb/shared/IDBDatabaseInfo.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h.
(WebCore::IDBDatabaseInfo::IDBDatabaseInfo):

* Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::didDeleteDatabase):
(WebCore::InProcessIDBServer::openDatabase):
(WebCore::InProcessIDBServer::didOpenDatabase):
* Modules/indexeddb/shared/InProcessIDBServer.h:

* WebCore.xcodeproj/project.pbxproj:

* platform/CrossThreadCopier.cpp:
(WebCore::IDBDatabaseInfo>::copy):
(WebCore::IDBDatabaseIdentifier>::copy):
* platform/CrossThreadCopier.h:

LayoutTests:

* storage/indexeddb/modern/opendatabase-request-event-expected.txt: Added.
* storage/indexeddb/modern/opendatabase-request-event.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoExtend JetStream timeout for slow devices.
dewei_zhu@apple.com [Thu, 1 Oct 2015 00:40:12 +0000 (00:40 +0000)]
Extend JetStream timeout for slow devices.

Reviewed by Chris Dumez.

Extend JetStream timeout to 20 minutes.

* Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Thousands of timers fire after switching to JavaScript and Events...
commit-queue@webkit.org [Thu, 1 Oct 2015 00:26:12 +0000 (00:26 +0000)]
Web Inspector: Thousands of timers fire after switching to JavaScript and Events timeline
https://bugs.webkit.org/show_bug.cgi?id=149682

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-09-30
Reviewed by Timothy Hatcher.

Setting the status element of a GeneralTreeElement was triggering a
TreeOutline.onchange event. For TreeOutlines with lots of tree elements
(JavaScript & Events with profile nodes) this could result in thousands
of onchange events that causes lots of unnecessary work and blocks
future timers (like scroll synchronization) from firing.

This change eliminates TreeOutline change events for tree element
changes that are not interesting.

* UserInterface/Views/GeneralTreeElement.js:
(WebInspector.GeneralTreeElement.prototype.set status): Deleted.
* UserInterface/Views/TreeOutline.js:
(WebInspector.TreeElement.prototype.set tooltip): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Reduce `delete` in TreeElements and DataGridNodes
commit-queue@webkit.org [Thu, 1 Oct 2015 00:08:18 +0000 (00:08 +0000)]
Web Inspector: Reduce `delete` in TreeElements and DataGridNodes
https://bugs.webkit.org/show_bug.cgi?id=149680

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-09-30
Reviewed by Timothy Hatcher.

* UserInterface/Views/BreakpointTreeElement.js:
(WebInspector.BreakpointTreeElement):
(WebInspector.BreakpointTreeElement.prototype._removeProbeSet):
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype._editingCommitted.moveToNextCell):
(WebInspector.DataGrid.prototype._editingCommitted):
(WebInspector.DataGrid.prototype._editingCancelled):
(WebInspector.DataGrid.prototype.removeColumn):
(WebInspector.DataGridNode.prototype.refreshIfNeeded):
(WebInspector.DataGridNode.prototype.refresh):
(WebInspector.DataGridNode.prototype.expand):
(WebInspector.DataGridNode.prototype.restorePosition):
(WebInspector.DataGridNode):
* UserInterface/Views/GeneralTreeElement.js:
(WebInspector.GeneralTreeElement.prototype.ondetach):
* UserInterface/Views/ResourceTimelineDataGridNode.js:
(WebInspector.ResourceTimelineDataGridNode.prototype.refresh):
* UserInterface/Views/TreeOutline.js:
(WebInspector.TreeElement.prototype._fireDidChange):
(WebInspector.TreeElement.prototype.expand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCrash when using an SVG font with > 390 glyphs
mmaxfield@apple.com [Thu, 1 Oct 2015 00:04:10 +0000 (00:04 +0000)]
Crash when using an SVG font with > 390 glyphs
https://bugs.webkit.org/show_bug.cgi?id=149677
<rdar://problem/21676402>

Reviewed by Simon Fraser.

Source/WebCore:

The "Charset Index" in OTF are indices into a collection of strings. There are
390 predefined strings in this collection. We were currently assigning each
glyph to one of these strings. However, if there are more glyphs than strings,
we will be using invalid indices.

The values of the strings themselves are not necessary for SVG fonts. Therefore,
the solution is to create a single dummy string, and have all glyphs target it.

Tests: svg/custom/many-glyphs.svg

* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::font):
* svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendCFFTable):

LayoutTests:

* svg/custom/many-glyphs-expected.svg: Added.
* svg/custom/many-glyphs.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRename iOS builders/testers to include version
dbates@webkit.org [Wed, 30 Sep 2015 23:56:51 +0000 (23:56 +0000)]
Rename iOS builders/testers to include version
https://bugs.webkit.org/show_bug.cgi?id=149685

Reviewed by Simon Fraser.

Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
make it clear to a reader the version of iOS these builders/testers are using.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFixed change set order to match reality. Some how the tools messed up the merge...
msaboff@apple.com [Wed, 30 Sep 2015 23:34:23 +0000 (23:34 +0000)]
Fixed change set order to match reality.  Some how the tools messed up the merge of ChangeLog entries.
-This line, and those below, will be ignored--

M    Source/JavaScriptCore/ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRelanding r190289 with the following two fixes:
keith_miller@apple.com [Wed, 30 Sep 2015 23:27:44 +0000 (23:27 +0000)]
Relanding r190289 with the following two fixes:

 1. REGRESSION(r190289): It made Speedometer/Full.html performance test fail
    https://bugs.webkit.org/show_bug.cgi?id=149621

    Reviewed by Saam Barati.

    We need to restore callee saves for both the fast and slow paths before making a
    tail call in the FTL.

    * ftl/FTLJSCallBase.cpp:
    (JSC::FTL::JSCallBase::emit):

 2. [ARM] REGRESSION(r190289): It made 374 tests crash on 32 bit ARM Linux
    https://bugs.webkit.org/show_bug.cgi?id=149619

    Reviewed by Filip Pizlo.

    Need to check for ARMv7_TRADITIONAL and ARMv7 in addition to ARM in "if"
    statement to handle platforms with a link register.

    * llint/LowLevelInterpreter.asm:
    (prepareForTailCall):

Patch by Michael Saboff <msaboff@apple.com> on 2015-09-30

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd iOS criterion for triggering a build
dbates@webkit.org [Wed, 30 Sep 2015 23:03:28 +0000 (23:03 +0000)]
Add iOS criterion for triggering a build
https://bugs.webkit.org/show_bug.cgi?id=149679

Rubber-stamped by Alexey Proskuryakov.

First pass at defining criterion for triggering an iOS build.

* BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):
* BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
(ShouldBuildTest):
(ShouldBuildTest.test_should_build):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSource/JavaScriptCore:
msaboff@apple.com [Wed, 30 Sep 2015 22:28:08 +0000 (22:28 +0000)]
Source/JavaScriptCore:
Relanding r190289 with the following two fixes:

 1. REGRESSION(r190289): It made Speedometer/Full.html performance test fail
    https://bugs.webkit.org/show_bug.cgi?id=149621

    Reviewed by Saam Barati.

    We need to restore callee saves for both the fast and slow paths before making a
    tail call in the FTL.

    * ftl/FTLJSCallBase.cpp:
    (JSC::FTL::JSCallBase::emit):

 2. [ARM] REGRESSION(r190289): It made 374 tests crash on 32 bit ARM Linux
    https://bugs.webkit.org/show_bug.cgi?id=149619

    Reviewed by Filip Pizlo.

    Need to check for ARMv7_TRADITIONAL and ARMv7 in addition to ARM in "if"
    statement to handle platforms with a link register.

    * llint/LowLevelInterpreter.asm:
    (prepareForTailCall):

LayoutTests:
Relanding r190289 after fixes tracked in https://bugs.webkit.org/show_bug.cgi?id=149619
and https://bugs.webkit.org/show_bug.cgi?id=149621

Reviewed by Saam Barati.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Web Inspector: Add GTK+ icon for the Bezier curve visual editor
agomez@igalia.com [Wed, 30 Sep 2015 22:11:25 +0000 (22:11 +0000)]
[GTK] Web Inspector: Add GTK+ icon for the Bezier curve visual editor
https://bugs.webkit.org/show_bug.cgi?id=147681

Reviewed by Joseph Pecoraro.

* UserInterface/Images/gtk/CubicBezier.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] Allow tests to generate user gestures for UI testing
simon.fraser@apple.com [Wed, 30 Sep 2015 21:48:00 +0000 (21:48 +0000)]
[iOS] Allow tests to generate user gestures for UI testing
https://bugs.webkit.org/show_bug.cgi?id=149653

Reviewed by Tim Horton.

Tools:

Expose functionality in UIScriptController to allow for testing single- and double-tap,
and to listen for completion of scrolling and zooming in the WKWebView.

Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
which hides the complexity of creating these events. Event dispatch is asynchronous.
We detect when the last event has been handled by dispatching a vendor-specific event,
which is detected via -_handleHIDEvent: in our UIApplication subclass.

* WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
* WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
single and double taps.
* WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
(UIScriptContext::registerCallback): Used to store the callbacks for zooming.
Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
(UIScriptContext::unregisterCallback):
(UIScriptContext::callbackWithID):
(UIScriptContext::fireCallback):
* WebKitTestRunner/UIScriptContext/UIScriptContext.h:
* WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
(WTR::UIScriptController::willBeginZoomingCallback): Ditto.
(WTR::UIScriptController::setDidEndZoomingCallback):
(WTR::UIScriptController::didEndZoomingCallback):
(WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
(WTR::UIScriptController::doubleTapAtPoint): Ditto.
(WTR::UIScriptController::platformSetWillBeginZoomingCallback):
(WTR::UIScriptController::platformSetDidEndZoomingCallback):
* WebKitTestRunner/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
(-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
(-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
(-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
* WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
* WebKitTestRunner/ios/HIDEventGenerator.m: Added.
(simpleDragCurve):
(calculateNextLocation):
(delayBetweenMove):
(+[HIDEventGenerator sharedHIDEventGenerator]):
(+[HIDEventGenerator nextEventCallbackID]):
(-[HIDEventGenerator init]):
(-[HIDEventGenerator _createIOHIDEventType:]):
(-[HIDEventGenerator _sendHIDEvent:]):
(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
(-[HIDEventGenerator _updateTouchPoints:count:]):
(-[HIDEventGenerator touchDownAtPoints:touchCount:]):
(-[HIDEventGenerator touchDown:touchCount:]):
(-[HIDEventGenerator touchDown:]):
(-[HIDEventGenerator liftUpAtPoints:touchCount:]):
(-[HIDEventGenerator liftUp:touchCount:]):
(-[HIDEventGenerator liftUp:]):
(-[HIDEventGenerator moveToPoints:touchCount:duration:]):
(-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
(-[HIDEventGenerator tap:completionBlock:]):
(-[HIDEventGenerator doubleTap:completionBlock:]):
(-[HIDEventGenerator twoFingerTap:completionBlock:]):
(-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator markerEventReceived:]):
* WebKitTestRunner/ios/IOKitSPI.h: Added.
* WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::globalToContentCoordinates):
(WTR::UIScriptController::singleTapAtPoint):
(WTR::UIScriptController::doubleTapAtPoint):
(WTR::UIScriptController::platformSetWillBeginZoomingCallback):
(WTR::UIScriptController::platformSetDidEndZoomingCallback):
* WebKitTestRunner/ios/mainIOS.mm:
(-[WebKitTestRunnerApp _handleHIDEvent:]):

LayoutTests:

Simple tests for single tap triggering a click, and double-tap zoom.

* TestExpectations:
* fast/events/ios/double-tap-zoom-expected.txt: Added.
* fast/events/ios/double-tap-zoom.html: Added.
* fast/events/ios/single-tap-generates-click-expected.txt: Added.
* fast/events/ios/single-tap-generates-click.html: Added.
* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[ES6] Add TypedArray.prototype functionality.
keith_miller@apple.com [Wed, 30 Sep 2015 21:00:42 +0000 (21:00 +0000)]
[ES6] Add TypedArray.prototype functionality.
https://bugs.webkit.org/show_bug.cgi?id=148035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patch should add most of the functionality for
the prototype properties of TypedArray objects in ES6.
There are a few exceptions to this, which will be added
in upcoming patches:

1) First we do not use the species constructor for some
of the TypedArray prototype functions (namely: map, filter,
slice, and subarray). That will need to be added when
species constructors are finished.

2) TypedArrays still have a length, byteOffset, byteLength,
and buffer are still attached to the TypedArray instance (in
the spec they are on the TypedArray.prototype instance object)
since the JIT currently assumes those properties are fixed.

3) The TypedArray.constructor property is not added yet
as it should point to the TypedArray instance object,
which will be added in a future patch.

* CMakeLists.txt:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* builtins/TypedArray.prototype.js: Added.
(every):
(find):
(findIndex):
(forEach):
(some):
(sort.min):
(sort.merge):
(sort.mergeSort):
(sort):
(reduce):
(reduceRight):
(map):
(filter):
(toLocaleString):
* runtime/ArrayPrototype.cpp:
* runtime/ArrayPrototype.h:
* runtime/CommonIdentifiers.h:
* runtime/JSGenericTypedArrayView.h:
(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValue):
(JSC::JSGenericTypedArrayView::setRangeToValue):
(JSC::JSGenericTypedArrayView::sort):
(JSC::JSGenericTypedArrayView::purifyArray):
(JSC::JSGenericTypedArrayView::sortComparison):
(JSC::JSGenericTypedArrayView::sortFloat):
* runtime/JSGenericTypedArrayViewInlines.h:
* runtime/JSGenericTypedArrayViewPrototypeFunctions.h: Added.
(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncEntries):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncKeys):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoGetterFuncLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteOffset):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncValues):
* runtime/JSGenericTypedArrayViewPrototypeInlines.h:
(JSC::JSGenericTypedArrayViewPrototype<ViewClass>::finishCreation):
(JSC::genericTypedArrayViewProtoFuncSet): Deleted.
(JSC::genericTypedArrayViewProtoFuncSubarray): Deleted.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* runtime/JSObject.h:
* runtime/JSTypedArrayPrototypes.cpp:
* runtime/JSTypedArrayPrototypes.h:
* runtime/JSTypedArrayViewPrototype.cpp: Added.
(JSC::typedArrayViewPrivateFuncLength):
(JSC::typedArrayViewPrivateFuncSort):
(JSC::typedArrayViewProtoFuncSet):
(JSC::typedArrayViewProtoFuncEntries):
(JSC::typedArrayViewProtoFuncCopyWithin):
(JSC::typedArrayViewProtoFuncFill):
(JSC::typedArrayViewProtoFuncLastIndexOf):
(JSC::typedArrayViewProtoFuncIndexOf):
(JSC::typedArrayViewProtoFuncJoin):
(JSC::typedArrayViewProtoFuncKeys):
(JSC::typedArrayViewProtoGetterFuncLength):
(JSC::typedArrayViewProtoGetterFuncByteLength):
(JSC::typedArrayViewProtoGetterFuncByteOffset):
(JSC::typedArrayViewProtoFuncReverse):
(JSC::typedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncSlice):
(JSC::typedArrayViewProtoFuncValues):
(JSC::JSTypedArrayViewPrototype::JSTypedArrayViewPrototype):
(JSC::JSTypedArrayViewPrototype::finishCreation):
(JSC::JSTypedArrayViewPrototype::create):
(JSC::JSTypedArrayViewPrototype::createStructure):
* runtime/JSTypedArrayViewPrototype.h: Copied from Source/JavaScriptCore/runtime/JSTypedArrayPrototypes.cpp.
* tests/stress/resources/standalone-pre.js: Added.
(description):
(debug):
(escapeString):
(testPassed):
(testFailed):
(areNumbersEqual):
(areArraysEqual):
(isMinusZero):
(isTypedArray):
(isResultCorrect):
(stringify):
(shouldBe):
(dfgShouldBe):
(shouldBeType):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldBeUndefined):
(shouldNotThrow):
(shouldThrow):
(dfgCompiled):
(dfgIncrement):
(noInline):
(finishJSTest):
* tests/stress/resources/typedarray-test-helper-functions.js: Added.
(forEachTypedArray):
(isSameFunctionForEachTypedArrayPrototype.eq):
(isSameFunctionForEachTypedArrayPrototype):
(hasSameValues):
(.foo):
(testPrototypeFunctionHelper):
(testPrototypeFunctionOnSigned):
(testPrototypeFunctionOnFloat):
(testPrototypeFunction):
(.tester):
(testPrototypeReceivesArray):
* tests/stress/typedarray-copyWithin.js: Added.
* tests/stress/typedarray-every.js: Added.
(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-fill.js: Added.
* tests/stress/typedarray-filter.js: Added.
(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-find.js: Added.
(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-findIndex.js: Added.
(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-forEach.js: Added.
(.checkCorrect.let.list):
(.checkCorrect):
(createChecker):
(foo):
(changeArray):
(isBigEnoughAndException):
* tests/stress/typedarray-indexOf.js: Added.
(keepEven):
* tests/stress/typedarray-lastIndexOf.js: Added.
* tests/stress/typedarray-map.js: Added.
(even):
(evenAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-reduce.js: Added.
(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-reduceRight.js: Added.
(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-slice.js: Added.
* tests/stress/typedarray-some.js: Added.
(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-sort.js: Added.
(sortBackwards):
(compareException):

LayoutTests:

Fixed tests for new toString behavior on TypedArrays.

* fast/canvas/webgl/type-conversion-test-expected.txt:
* fast/dom/Window/window-postmessage-clone-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190367 268f45cc-cd09-0410-ab3c-d52691b4dbfc