WebKit-https.git
9 years ago2010-12-13 John Knottenbelt <jknotten@chromium.org>
commit-queue@webkit.org [Mon, 13 Dec 2010 15:54:36 +0000 (15:54 +0000)]
2010-12-13  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Fix layout test dom/fast/Geolocation/permission-denied-already-error.html for client-based Geolocation
        https://bugs.webkit.org/show_bug.cgi?id=50920

        * fast/dom/Geolocation/script-tests/permission-denied-already-error.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Mon, 13 Dec 2010 15:53:35 +0000 (15:53 +0000)]
2010-12-13  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Additional support is needed for caret browsing
        https://bugs.webkit.org/show_bug.cgi?id=25526

        New layout test to check the "MoveTo{Beginninng|End}OfDocument"
        commands when caret browsing is enabled.

        * platform/gtk/editing/selection/caret-mode-document-begin-end-expected.txt: Added.
        * platform/gtk/editing/selection/caret-mode-document-begin-end.html: Added.
2010-12-13  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Additional support is needed for caret browsing
        https://bugs.webkit.org/show_bug.cgi?id=25526

        Enable "MoveTo{Beginninng|End}OfDocument" commands when caret
        browsing is enabled.

        This change impacts the GTK-port only as caret browsing is a
        feature only used in that platform so far.

        Test: platform/gtk/editing/selection/caret-mode-document-begin-end.html

        * editing/EditorCommand.cpp:
        (WebCore::createCommandMap): Enable the commads when in caret browsing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 13 Dec 2010 15:45:09 +0000 (15:45 +0000)]
2010-12-13  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Qt build fix.

        * dom/Event.cpp:
        (WebCore::Event::isErrorEvent):
        * dom/Event.h: remove ENABLE(WORKERS) guard since ErrorEvent is now used not
        only in workers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 13 Dec 2010 15:35:42 +0000 (15:35 +0000)]
2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

        Debugger and Resources related notification functions of Inspector.idl were
        marked as such with help of "domain" attribute. The other changes in js files
        are reflecting this change. Some wrappers in WebInspector namespace were dropped,
        the others were moved to DebuggerModel class.

        https://bugs.webkit.org/show_bug.cgi?id=50906

        * inspector/Inspector.idl:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::resetState):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMAgent.prototype.didCommitLoad):
        * inspector/front-end/Database.js:
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        (WebInspector.DebuggerModel.prototype.pausedScript):
        (WebInspector.DebuggerModel.prototype.resumedScript):
        (WebInspector.DebuggerModel.prototype.attachDebuggerWhenShown):
        (WebInspector.DebuggerModel.prototype.debuggerWasEnabled):
        (WebInspector.DebuggerModel.prototype.debuggerWasDisabled):
        (WebInspector.DebuggerModel.prototype.parsedScriptSource):
        (WebInspector.DebuggerModel.prototype.failedToParseScriptSource):
        (WebInspector.DebuggerModel.prototype.didCreateWorker):
        (WebInspector.DebuggerModel.prototype.didDestroyWorker):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel):
        (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
        (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
        * inspector/front-end/ResourceManager.js:
        (WebInspector.ResourceManager):
        (WebInspector.ResourceManager.prototype._unbindResourceURL):
        (WebInspector.ResourceManager.prototype.updateDOMStorage):
        (WebInspector.ResourceManager.prototype.updateApplicationCacheStatus):
        (WebInspector.ResourceManager.prototype.didGetFileSystemPath):
        (WebInspector.ResourceManager.prototype.didGetFileSystemError):
        (WebInspector.ResourceManager.prototype.didGetFileSystemDisabled):
        (WebInspector.ResourceManager.prototype.updateNetworkState):
        (WebInspector.ResourceManager.prototype.addDOMStorage):
        (WebInspector.ResourceManager.prototype.selectDOMStorage):
        (WebInspector.ResourceManager.prototype.addDatabase):
        (WebInspector.ResourceManager.prototype.selectDatabase):
        (WebInspector.ResourceManager.prototype.sqlTransactionSucceeded):
        (WebInspector.ResourceManager.prototype.sqlTransactionFailed):
        * inspector/front-end/WorkersSidebarPane.js:
        (WebInspector.Worker):
        * inspector/front-end/inspector.js:

2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

        Debugger and Resources related notification functions of Inspector.idl were
        marked as such with help of "domain" attribute. The other changes in js files
        are reflecting this change. Some wrappers in WebInspector namespace were dropped,
        the others were moved to DebuggerModel class.

        https://bugs.webkit.org/show_bug.cgi?id=50906

        * src/js/Tests.js:
        (.TestSuite.prototype._waitForScriptPause):
        (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
        (.TestSuite.prototype._waitUntilScriptsAreParsed):

2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

        Debugger and Resources related notification functions of Inspector.idl were
        marked as such with help of "domain" attribute. The other changes in js files
        are reflecting this change. Some wrappers in WebInspector namespace were dropped,
        the others were moved to DebuggerModel class.

        https://bugs.webkit.org/show_bug.cgi?id=50906

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest):
        (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
        (initialize_DebuggerTest.InspectorTest.showScriptSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 13 Dec 2010 15:33:58 +0000 (15:33 +0000)]
2010-12-13  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Qt build fix.

        * dom/ErrorEvent.cpp:
        * dom/ErrorEvent.h: remove ENABLE(WORKERS) guard since ErrorEvent is now used not
        only in workers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 13 Dec 2010 15:16:03 +0000 (15:16 +0000)]
2010-12-13  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
        https://bugs.webkit.org/show_bug.cgi?id=8519

        Uncaught exceptions are propagated to window.onerror hander if one is present.
        The handler is expected to be a function accepting three arguments: error message,
        resource url and line number where the exception occured.

        * fast/events/resources/window-onerror.js: Added.
        (throwException):
        * fast/events/window-onerror1-expected.txt: Added.
        * fast/events/window-onerror1.html: Added.
        * fast/events/window-onerror10-expected.txt: Added.
        * fast/events/window-onerror10.html: Added.
        * fast/events/window-onerror11-expected.txt: Added.
        * fast/events/window-onerror11.html: Added.
        * fast/events/window-onerror2-expected.txt: Added.
        * fast/events/window-onerror2.html: Added.
        * fast/events/window-onerror3-expected.txt: Added.
        * fast/events/window-onerror3.html: Added.
        * fast/events/window-onerror4-expected.txt: Added.
        * fast/events/window-onerror4.html: Added.
        * fast/events/window-onerror5-expected.txt: Added.
        * fast/events/window-onerror5.html: Added.
        * fast/events/window-onerror6-expected.txt: Added.
        * fast/events/window-onerror6.html: Added.
        * fast/events/window-onerror7-expected.txt: Added.
        * fast/events/window-onerror7.html: Added.
        * fast/events/window-onerror8-expected.txt: Added.
        * fast/events/window-onerror8.html: Added.
        * fast/events/window-onerror9-expected.txt: Added.
        * fast/events/window-onerror9.html: Added.
        * fast/workers/worker-script-error-expected.txt:
        * http/tests/security/resources/onerror-iframe.html: Added.
        * http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
        * http/tests/security/window-onerror-exception-in-iframe.html: Added.
        * platform/chromium-win/fast/workers/worker-script-error-expected.txt:
        * platform/chromium/fast/events/window-onerror1-expected.txt: Added.
        * platform/chromium/fast/events/window-onerror10-expected.txt: Added.
        * platform/chromium/fast/events/window-onerror11-expected.txt: Added.
        * platform/chromium/fast/events/window-onerror2-expected.txt: Added.
        * platform/chromium/fast/events/window-onerror3-expected.txt: Added.
        * platform/chromium/fast/events/window-onerror4-expected.txt: Added.
        * platform/chromium/fast/events/window-onerror5-expected.txt: Added.
        * platform/chromium/fast/events/window-onerror6-expected.txt: Added.
        * platform/chromium/fast/events/window-onerror7-expected.txt: Added.
        * platform/chromium/fast/events/window-onerror8-expected.txt: Added.
        * platform/chromium/fast/events/window-onerror9-expected.txt: Added.
        * platform/chromium/http/tests/security/window-onerror-exception-in-iframe-expected.txt: Added.
        * platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
        * platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
        * userscripts/window-onerror-for-isolated-world-1-expected.txt: Added.
        * userscripts/window-onerror-for-isolated-world-1.html: Added.
        * userscripts/window-onerror-for-isolated-world-2-expected.txt: Added.
        * userscripts/window-onerror-for-isolated-world-2.html: Added.
2010-12-13  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
        https://bugs.webkit.org/show_bug.cgi?id=8519

        Uncaught exceptions are propagated to window.onerror hander if one is present.
        The handler is expected to be a function accepting three arguments: error message,
        resource url and line number where the exception occured.

        It was decided to dispatch ErrorEvent to all listeners/handlers no matter if they
        were created in the same isolated world where the exception occured or not.

        Tests: fast/events/window-onerror1.html
               fast/events/window-onerror10.html
               fast/events/window-onerror11.html
               fast/events/window-onerror2.html
               fast/events/window-onerror3.html
               fast/events/window-onerror4.html
               fast/events/window-onerror5.html
               fast/events/window-onerror6.html
               fast/events/window-onerror7.html
               fast/events/window-onerror8.html
               fast/events/window-onerror9.html
               http/tests/security/window-onerror-exception-in-iframe.html
               userscripts/window-onerror-for-isolated-world-1.html
               userscripts/window-onerror-for-isolated-world-2.html

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.order:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::reportException):
        * bindings/js/JSErrorHandler.cpp: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.cpp.
        (WebCore::JSErrorHandler::JSErrorHandler):
        (WebCore::JSErrorHandler::~JSErrorHandler):
        (WebCore::JSErrorHandler::handleEvent):
        * bindings/js/JSErrorHandler.h: Copied from WebCore/bindings/js/JSWorkerContextErrorHandler.h.
        (WebCore::JSErrorHandler::create):
        (WebCore::createJSErrorHandler):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8ConsoleMessage.cpp:
        (WebCore::V8ConsoleMessage::dispatchNow):
        (WebCore::V8ConsoleMessage::handler): the method was changed to use generic WebCore exception
        reporting mechanism which is also used by JSC bindings.
        * bindings/v8/V8ConsoleMessage.h:
        * bindings/v8/V8WindowErrorHandler.cpp: Copied from WebCore/bindings/js/JSWorkerContextErrorHandler.h.
        (WebCore::V8WindowErrorHandler::V8WindowErrorHandler):
        (WebCore::V8WindowErrorHandler::callListenerFunction):
        * bindings/v8/V8WindowErrorHandler.h: Renamed from WebCore/bindings/js/JSWorkerContextErrorHandler.h.
        (WebCore::V8WindowErrorHandler::create):
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::v8MessageHandler):
        * bindings/v8/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::evaluate):
        * dom/Document.cpp:
        (WebCore::Document::errorEventTarget):
        (WebCore::Document::logExceptionToConsole):
        * dom/Document.h:
        * dom/ScriptExecutionContext.cpp:
        (WebCore::ScriptExecutionContext::PendingException::PendingException):
        (WebCore::ScriptExecutionContext::ScriptExecutionContext):
        (WebCore::ScriptExecutionContext::reportException): this method is not virtual anymore to
        ensure that error event dispatching algorithm is the same in WorkerContext and in Document.
        (WebCore::ScriptExecutionContext::dispatchErrorEvent):
        * dom/ScriptExecutionContext.h:
        * workers/DefaultSharedWorkerRepository.cpp:
        (WebCore::postExceptionTask):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::WorkerContext):
        (WebCore::WorkerContext::errorEventTarget):
        (WebCore::WorkerContext::logExceptionToConsole):
        * workers/WorkerContext.h:
        * workers/WorkerMessagingProxy.cpp:
        (WebCore::WorkerExceptionTask::performTask):
2010-12-13  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Adam Barth.

        WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown
        https://bugs.webkit.org/show_bug.cgi?id=8519

        Uncaught exceptions are propagated to window.onerror hander if one is present.
        The handler is expected to be a function accepting three arguments: error message,
        resource url and line number where the exception occured.

        * src/WebWorkerClientImpl.cpp:
        (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
        (WebKit::WebWorkerClientImpl::postExceptionToWorkerObjectTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 13 Dec 2010 15:06:26 +0000 (15:06 +0000)]
2010-12-08  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Joseph Pecoraro.

        Web Inspector: Enable CSS property editing name/value-wise (like Firebug does)
        https://bugs.webkit.org/show_bug.cgi?id=50565

        For CSS property editing, the property name and value have become two fields separated
        by a colon (rather than one field containing the full property text.) A user can tab
        between the name and value fields forward and backward. A colon typed in the name field
        and a semicolon in the value field (unless found inside a string) act as a Tab and focus
        the next editable field (while applying the entire property value.)

        Now a user can tab through all editable styles for an element, even across rule boundaries.

        WebCore:
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.XHRBreakpointsSidebarPane.prototype._startEditingBreakpoint):
        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
        (WebInspector.DataGrid.prototype._startEditing):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._startEditingAttribute):
        (WebInspector.ElementsTreeElement.prototype._startEditingTextNode):
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName):
        (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
        * inspector/front-end/MetricsSidebarPane.js:
        (WebInspector.MetricsSidebarPane.prototype.startEditing):
        * inspector/front-end/ObjectPropertiesSection.js:
        (WebInspector.ObjectPropertyTreeElement.prototype.startEditing):
        * inspector/front-end/Section.js:
        (WebInspector.Section):
        (WebInspector.Section.prototype.get subtitleAsTextForTest):
        (WebInspector.Section.prototype.get nextSibling):
        (WebInspector.Section.prototype.get previousSibling):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._editBreakpointCondition):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertiesSection.prototype.nextEditableSibling):
        (WebInspector.StylePropertiesSection.prototype.previousEditableSibling):
        (WebInspector.StylePropertiesSection.prototype.addNewBlankProperty):
        (WebInspector.StylePropertiesSection.prototype.startEditingSelector):
        (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
        (WebInspector.StylePropertyTreeElement.prototype.):
        (WebInspector.StylePropertyTreeElement.prototype):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._handleDoubleClick):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionTreeElement.prototype.startEditing):
        * inspector/front-end/inspector.css:
        (.child-editing):
        * inspector/front-end/inspector.js:
        (WebInspector.startEditing.defaultFinishHandler):
        (WebInspector.startEditing):
        * inspector/front-end/treeoutline.js:
        (TreeElement.prototype.select):

        LayoutTests:
        * inspector/console-dir.html:
        * inspector/styles-add-blank-property.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
yael.aharon@nokia.com [Mon, 13 Dec 2010 14:25:35 +0000 (14:25 +0000)]
Unreviewed.

Added svn propery eol-style. Patches to this file fail to apply on Windows EWS bot.

* accessibility/AccessibilityAllInOne.cpp: Added property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 W. James MacLean <wjmaclean@chromium.org>
commit-queue@webkit.org [Mon, 13 Dec 2010 14:20:21 +0000 (14:20 +0000)]
2010-12-13  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Csaba Osztrogonác.

        Remove unnecessary pixel results, use platform-independent text results, re Changeset 72802
        https://bugs.webkit.org/show_bug.cgi?id=50233

        Remove redundant, platform-specific test results.

        * platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.txt: Removed.
        * platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.txt: Removed.
        * platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.txt: Removed.
        * platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.txt: Removed.
        * platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.txt: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-1-expected.txt: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-2-expected.txt: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-3-expected.txt: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-4-expected.txt: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-5-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Sheriff Bot <webkit.review.bot@gmail.com>
loislo@chromium.org [Mon, 13 Dec 2010 13:50:25 +0000 (13:50 +0000)]
2010-12-13  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73898.
        http://trac.webkit.org/changeset/73898
        https://bugs.webkit.org/show_bug.cgi?id=50919

        FileSystem and Database API's were broken (Requested by loislo
        on #webkit).

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest):
        (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
        (initialize_DebuggerTest.InspectorTest.showScriptSource):
2010-12-13  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73898.
        http://trac.webkit.org/changeset/73898
        https://bugs.webkit.org/show_bug.cgi?id=50919

        FileSystem and Database API's were broken (Requested by loislo
        on #webkit).

        * inspector/Inspector.idl:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::resetState):
        * inspector/front-end/DOMAgent.js:
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        (WebInspector.DebuggerModel.prototype.debuggerPaused):
        (WebInspector.DebuggerModel.prototype.debuggerResumed):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel):
        (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
        * inspector/front-end/ResourceManager.js:
        (WebInspector.ResourceManager):
        (WebInspector.ResourceManager.prototype._registerNotifyHandlers):
        (WebInspector.ResourceManager.prototype._unbindResourceURL):
        * inspector/front-end/inspector.js:
        (WebInspector.addDatabase):
        (WebInspector.addDOMStorage):
        (WebInspector.updateDOMStorage):
        (WebInspector.updateApplicationCacheStatus):
        (WebInspector.didGetFileSystemPath):
        (WebInspector.didGetFileSystemError):
        (WebInspector.didGetFileSystemDisabled):
        (WebInspector.updateNetworkState):
        (WebInspector.attachDebuggerWhenShown):
        (WebInspector.debuggerWasEnabled):
        (WebInspector.debuggerWasDisabled):
        (WebInspector.profilerWasEnabled):
        (WebInspector.profilerWasDisabled):
        (WebInspector.parsedScriptSource):
        (WebInspector.restoredBreakpoint):
        (WebInspector.failedToParseScriptSource):
        (WebInspector.pausedScript):
        (WebInspector.resumedScript):
        (WebInspector.resetProfilesPanel):
        (WebInspector.didCommitLoad):
        (WebInspector.addProfileHeader):
        (WebInspector.setRecordingProfile):
        (WebInspector.addHeapSnapshotChunk):
        (WebInspector.finishHeapSnapshot):
2010-12-13  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73898.
        http://trac.webkit.org/changeset/73898
        https://bugs.webkit.org/show_bug.cgi?id=50919

        FileSystem and Database API's were broken (Requested by loislo
        on #webkit).

        * src/js/Tests.js:
        (.TestSuite.prototype._waitForScriptPause):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 13 Dec 2010 13:46:16 +0000 (13:46 +0000)]
2010-12-13  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Csaba Osztrogonác.

        Add revlink to BuildBot status
        https://bugs.webkit.org/show_bug.cgi?id=50914

        This adds a hyperlink to trac changeset on the revision numbers.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Mon, 13 Dec 2010 13:34:00 +0000 (13:34 +0000)]
2010-12-13  Anton Muhin  <antonm@chromium.org>

        Reviewed by Pavel Feldman.

        [v8] More CSS wrappers GC work: keep document's style sheets, style sheet and css rule lists' items in proper object groups
        https://bugs.webkit.org/show_bug.cgi?id=50828

        * bindings/v8/DOMData.h:
        (WebCore::DOMData::WrapperMapObjectRemover::visitDOMWrapper):
        (WebCore::DOMData::removeObjectsFromWrapperMap):
        * bindings/v8/DOMDataStore.h:
        (WebCore::ChunkedTable::visit):
        (WebCore::ChunkedTable::visitEntries):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::visit):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):
        * bindings/v8/V8DOMMap.cpp:
        (WebCore::removeAllDOMObjectsInCurrentThread):
        (WebCore::visitDOMNodesInCurrentThread):
        (WebCore::visitDOMObjectsInCurrentThread):
        (WebCore::visitActiveDOMObjectsInCurrentThread):
        (WebCore::visitDOMSVGElementInstancesInCurrentThread):
        * bindings/v8/V8DOMMap.h:
        (WebCore::WeakReferenceMap::visit):
        * bindings/v8/V8GCController.cpp:
        (WebCore::DOMObjectVisitor::visitDOMWrapper):
        (WebCore::EnsureWeakDOMNodeVisitor::visitDOMWrapper):
        (WebCore::GCPrologueVisitor::visitDOMWrapper):
        (WebCore::NodeGrouperVisitor::visitDOMWrapper):
        (WebCore::NodeGrouperVisitor::applyGrouping):
        (WebCore::DOMObjectGrouperVisitor::visitDOMWrapper):
        (WebCore::GCEpilogueVisitor::visitDOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Carlos Garcia Campos <cgarcia@igalia.com>
commit-queue@webkit.org [Mon, 13 Dec 2010 13:27:25 +0000 (13:27 +0000)]
2010-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Do not use GET_PRIVATE macros
        https://bugs.webkit.org/show_bug.cgi?id=50915

        GET_PRIVATE macros are slow and should only be used in the object
        init() method.

        * WebCoreSupport/ContextMenuClientGtk.cpp:
        (WebKit::inputMethodsMenuItem):
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::postProgressFinishedNotification):
        (WebKit::FrameLoaderClient::setTitle):
        (WebKit::FrameLoaderClient::dispatchCreatePage):
        (WebKit::postCommitFrameViewSetup):
        * webkit/webkitdownload.cpp:
        (webkit_download_init):
        * webkit/webkitgeolocationpolicydecision.cpp:
        (webkit_geolocation_policy_decision_init):
        * webkit/webkithittestresult.cpp:
        (webkit_hit_test_result_init):
        * webkit/webkitnetworkrequest.cpp:
        (webkit_network_request_init):
        * webkit/webkitsecurityorigin.cpp:
        (webkit_security_origin_init):
        * webkit/webkitsecurityoriginprivate.h:
        * webkit/webkitviewportattributes.cpp:
        (webkit_viewport_attributes_init):
        * webkit/webkitwebbackforwardlist.cpp:
        (webkit_web_back_forward_list_init):
        * webkit/webkitwebdatabase.cpp:
        (webkit_web_database_init):
        * webkit/webkitwebdatasource.cpp:
        (webkit_web_data_source_init):
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_init):
        (webkit_web_frame_new):
        * webkit/webkitwebframeprivate.h:
        * webkit/webkitwebhistoryitem.cpp:
        (webkit_web_history_item_init):
        * webkit/webkitwebinspector.cpp:
        (webkit_web_inspector_init):
        * webkit/webkitwebnavigationaction.cpp:
        (webkit_web_navigation_action_init):
        * webkit/webkitwebplugin.cpp:
        (webkit_web_plugin_init):
        * webkit/webkitwebplugindatabase.cpp:
        (webkit_web_plugin_database_init):
        * webkit/webkitwebplugindatabaseprivate.h:
        * webkit/webkitwebpluginprivate.h:
        * webkit/webkitwebpolicydecision.cpp:
        (webkit_web_policy_decision_init):
        * webkit/webkitwebresource.cpp:
        (webkit_web_resource_init):
        * webkit/webkitwebresourceprivate.h:
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_init):
        * webkit/webkitwebview.cpp:
        (PopupMenuPositionFunc):
        (webkit_web_view_forward_context_menu_event):
        (webkit_web_view_drag_end):
        (webkit_web_view_drag_data_get):
        (webkit_web_view_query_tooltip):
        (webkit_web_view_init):
        * webkit/webkitwebwindowfeatures.cpp:
        (webkit_web_window_features_init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Mon, 13 Dec 2010 13:16:44 +0000 (13:16 +0000)]
2010-12-13  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][WK2] Fix build if WebKitTools are not available
        https://bugs.webkit.org/show_bug.cgi?id=50242

        * DerivedSources.pro: add new DerivedSources.pro to SUBDIRS.
2010-12-13  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][WK2] Fix build if WebKitTools are not available
        https://bugs.webkit.org/show_bug.cgi?id=50242

        * DerivedSources.pro: Remove dependency to WebKitTools.
        * Scripts/generate-forwarding-headers.pl: Moved from WebKitTools/Scripts/generate-forwarding-headers.pl.
2010-12-13  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][WK2] Fix build if WebKitTools are not available
        https://bugs.webkit.org/show_bug.cgi?id=50242

        * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
        * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
        * MiniBrowser/DerivedSources.pro: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix for r73894.
zherczeg@webkit.org [Mon, 13 Dec 2010 13:13:22 +0000 (13:13 +0000)]
Unreviewed build fix for r73894.

SVGFEImage should also check its hasResult() in its apply().

* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Peter Varga <pvarga@inf.u-szeged.hu>
abecsi@webkit.org [Mon, 13 Dec 2010 12:55:07 +0000 (12:55 +0000)]
2010-12-13  Peter Varga  <pvarga@inf.u-szeged.hu>

        Reviewed by Gavin Barraclough.

        Reduce the size of the RegexStackSpaceForBackTrackInfoParentheses in YARR
        https://bugs.webkit.org/show_bug.cgi?id=49385

        Remove the BackTrackInfoParentheses struct prevBegin and prevEnd members.

        * yarr/RegexInterpreter.cpp:
        (JSC::Yarr::Interpreter::matchParentheses):
        (JSC::Yarr::Interpreter::backtrackParentheses):
        * yarr/RegexPattern.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 13 Dec 2010 12:11:07 +0000 (12:11 +0000)]
Unreviewed.

[Qt] fast/loader/user-stylesheet-fast-path.html fails
https://bugs.webkit.org/show_bug.cgi?id=50911

* platform/qt/Skipped: Add the failing test until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 13 Dec 2010 11:54:38 +0000 (11:54 +0000)]
2010-12-13  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Updated chromium gpu test expectations.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 13 Dec 2010 11:38:53 +0000 (11:38 +0000)]
2010-12-13  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Updated chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 13 Dec 2010 11:21:05 +0000 (11:21 +0000)]
2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

        Debugger and Resources related notification functions of Inspector.idl were
        marked as such with help of "domain" attribute. The other changes in js files
        are reflecting this change. Some wrappers in WebInspector namespace were dropped,
        the others were moved to DebuggerModel class.

        https://bugs.webkit.org/show_bug.cgi?id=50906

        * inspector/Inspector.idl:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::resetState):
        * inspector/front-end/DOMAgent.js:
        (WebInspector.DOMAgent.prototype.didCommitLoad):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel):
        (WebInspector.DebuggerModel.prototype.pausedScript):
        (WebInspector.DebuggerModel.prototype.resumedScript):
        (WebInspector.DebuggerModel.prototype.attachDebuggerWhenShown):
        (WebInspector.DebuggerModel.prototype.debuggerWasEnabled):
        (WebInspector.DebuggerModel.prototype.debuggerWasDisabled):
        (WebInspector.DebuggerModel.prototype.parsedScriptSource):
        (WebInspector.DebuggerModel.prototype.failedToParseScriptSource):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel):
        (WebInspector.ProfilesPanel.prototype.addHeapSnapshots):
        (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):
        (WebInspector.ProfilesPanel.prototype.setRecordingProfile):
        * inspector/front-end/ResourceManager.js:
        (WebInspector.ResourceManager):
        (WebInspector.ResourceManager.prototype._unbindResourceURL):
        (WebInspector.ResourceManager.prototype.updateDOMStorage):
        (WebInspector.ResourceManager.prototype.updateApplicationCacheStatus):
        (WebInspector.ResourceManager.prototype.didGetFileSystemPath):
        (WebInspector.ResourceManager.prototype.didGetFileSystemError):
        (WebInspector.ResourceManager.prototype.didGetFileSystemDisabled):
        (WebInspector.ResourceManager.prototype.updateNetworkState):
        (WebInspector.ResourceManager.prototype.addDatabase):
        (WebInspector.ResourceManager.prototype.addDOMStorage):
        * inspector/front-end/inspector.js:

2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

        Debugger and Resources related notification functions of Inspector.idl were
        marked as such with help of "domain" attribute. The other changes in js files
        are reflecting this change. Some wrappers in WebInspector namespace were dropped,
        the others were moved to DebuggerModel class.

        https://bugs.webkit.org/show_bug.cgi?id=50906

        * src/js/Tests.js:
        (.TestSuite.prototype._waitForScriptPause):

2010-12-13  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions.

        Debugger and Resources related notification functions of Inspector.idl were
        marked as such with help of "domain" attribute. The other changes in js files
        are reflecting this change. Some wrappers in WebInspector namespace were dropped,
        the others were moved to DebuggerModel class.

        https://bugs.webkit.org/show_bug.cgi?id=50906

        * http/tests/inspector/debugger-test2.js:
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
        (initialize_DebuggerTest.InspectorTest.startDebuggerTest):
        (initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
        (initialize_DebuggerTest.InspectorTest.showScriptSource):
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 13 Dec 2010 11:14:30 +0000 (11:14 +0000)]
2010-12-13  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Updated chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 13 Dec 2010 10:59:29 +0000 (10:59 +0000)]
2010-12-13  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Updated chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 13 Dec 2010 10:19:10 +0000 (10:19 +0000)]
2010-12-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        EWS Queues should remove orpahned pyc files before starting
        https://bugs.webkit.org/show_bug.cgi?id=50904

        A previous check added a platform.py which caused
        EWS bots on some platforms to hit an import exception.
        The platform.py file was removed in a subsequent commit, but
        the EWS bots in question stayed stuck.  This change will
        fix those bots once restarted (and prevent this in the future).

        I also went ahead and unified start-queue and start-commit-queue
        since they were nearly identical.  I also added bot_id support
        to both force all EWSes to have bot ids as well as get rid of the one
        remaining reason why I had my own copies of these scripts.
        Hopefully this will be enough to get all the other bot admins
        (ahem, Adam, ahem) to move to using these checked in copies as well.

        * EWSTools/start-commit-queue.sh: Removed.
        * EWSTools/start-queue.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBetter result passing in filter primitives
zherczeg@webkit.org [Mon, 13 Dec 2010 10:15:53 +0000 (10:15 +0000)]
Better result passing in filter primitives
https://bugs.webkit.org/show_bug.cgi?id=49907

Reviewed by Dirk Schulze.

SVG filter primitives can use the output of other filters. The
input and output format of a filter can be a premultiplied or
unmultiplied RGBA array, or an image buffer. All filter
primitive results were converted to image buffers before, which
could be an unecessary (and really costly) operation, if
a filter expects its input in the same format as the output
of the input filter primitive. This overhead is removed by
this patch. All apply() methods are updated according to this
new filter primitive interface.

Filters do not generate their results twice (or more) anymore,
when their apply() called multiple times.

The existing tests cover this feature.

* manual-tests/svg-filter-animation.svg: Added.
* platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::apply):
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::apply):
* platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::apply):
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::apply):
* platform/graphics/filters/FEConvolveMatrix.cpp:
(WebCore::FEConvolveMatrix::apply):
* platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::apply):
* platform/graphics/filters/FEFlood.cpp:
(WebCore::FEFlood::apply):
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::apply):
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::apply):
* platform/graphics/filters/FEMerge.cpp:
(WebCore::FEMerge::apply):
* platform/graphics/filters/FEMerge.h:
* platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::apply):
* platform/graphics/filters/FEOffset.cpp:
(WebCore::FEOffset::apply):
* platform/graphics/filters/FETile.cpp:
(WebCore::FETile::apply):
* platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::apply):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::requestedRegionOfInputImageData):
(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::asUnmultipliedImage):
(WebCore::FilterEffect::asPremultipliedImage):
(WebCore::FilterEffect::copyImageBytes):
(WebCore::FilterEffect::copyUnmultipliedImage):
(WebCore::FilterEffect::copyPremultipliedImage):
(WebCore::FilterEffect::createImageBufferResult):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):
* platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::hasResult):
* platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::apply):
* platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::apply):
* platform/graphics/filters/SourceGraphic.h:
* rendering/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Mon, 13 Dec 2010 10:00:24 +0000 (10:00 +0000)]
2010-12-13  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Move user stylesheet test into platform independent directory
        https://bugs.webkit.org/show_bug.cgi?id=47335

        There is nothing platform specific in the test, so move it out of the mac directory.

        * fast/loader/user-stylesheet-fast-path-expected.txt: Copied from LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt.
        * fast/loader/user-stylesheet-fast-path.html: Copied from LayoutTests/platform/mac/fast/loader/user-stylesheet-fast-path.html.
        * platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt: Removed.
        * platform/mac/fast/loader/user-stylesheet-fast-path.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 13 Dec 2010 09:50:13 +0000 (09:50 +0000)]
Unreviewed.

WebCore:

* WebCore.pro: Remove non-existant loader/Request.h from build system.

WebKit2:

* WebKit2.pro: Remove non-existant Shared/DrawingAreaBase.h from build system.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 13 Dec 2010 09:39:58 +0000 (09:39 +0000)]
2010-12-13  MORITA Hajime  <morrita@google.com>

        Unreviewed expectation update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Mon, 13 Dec 2010 09:11:59 +0000 (09:11 +0000)]
2010-12-13  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Eric Seidel.

        [chromium] Reduce canvas.toDataURL("image/jpeg") run-time cost by 10%
        https://bugs.webkit.org/show_bug.cgi?id=50804

        Follow on from r73173, unroll the SkUnPreMultiply::PMColorToColor() call
        viz., compute the unpremultiplatcion in-place. This reduces the run-time
        cost of jpeg encoding by 10-15% for my image test set.

        No new tests: canvas.toDataURL() is covered by existing tests.

        * platform/image-encoders/skia/JPEGImageEncoder.cpp:
        (WebCore::preMultipliedBGRAtoRGB):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-13 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Mon, 13 Dec 2010 08:56:31 +0000 (08:56 +0000)]
2010-12-13  Helder Correia  <helder@sencha.com>

        Reviewed by Eric Seidel.

        [Qt] StillImage::draw() should use ContextShadow
        https://bugs.webkit.org/show_bug.cgi?id=50849

        The branch that checks for a shadow requirement in StillImage::draw()
        is executed when drawing a canvas onto a canvas with
        ctx1.drawImage(canvas2, x, y). The current implementation supports
        solid shadows only. And if transformations are present, the offset gets
        transformed as well. Thus, ContextShadow must be used instead in order
        to support blur and correct offset transformations.

        * fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Added.
        * fast/canvas/canvas-draw-canvas-on-canvas-shadow.html: Added.
        * fast/canvas/script-tests/canvas-draw-canvas-on-canvas-shadow.js: Added.
2010-12-13  Helder Correia  <helder@sencha.com>

        Reviewed by Eric Seidel.

        [Qt] StillImage::draw() should use ContextShadow
        https://bugs.webkit.org/show_bug.cgi?id=50849

        The branch that checks for a shadow requirement in StillImage::draw()
        is executed when drawing a canvas onto a canvas with
        ctx1.drawImage(canvas2, x, y). The current implementation supports
        solid shadows only. And if transformations are present, the offset gets
        transformed as well. Thus, ContextShadow must be used instead in order
        to support blur and correct offset transformations.

        Test: fast/canvas/canvas-draw-canvas-on-canvas-shadow.html

        * platform/graphics/qt/StillImageQt.cpp:
        (WebCore::StillImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix.
jhoneycutt@apple.com [Mon, 13 Dec 2010 07:18:28 +0000 (07:18 +0000)]
Unreviewed build fix.

* editing/EditingAllInOne.cpp:
Add new file to the all-in-one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix.
jhoneycutt@apple.com [Mon, 13 Dec 2010 06:31:55 +0000 (06:31 +0000)]
Unreviewed build fix.

* WebCore.vcproj/WebCore.vcproj:
Remove accidentally-committed conflict marker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-28 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 13 Dec 2010 06:06:19 +0000 (06:06 +0000)]
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        * editing/spelling/script-tests/spellcheck-paste.js: Added.
        * editing/spelling/spellcheck-paste.html: Added.
        * editing/spelling/spellcheck-paste-expected.txt: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac-leopard/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        - Introduced SpellChecker class to encapsulate asynchronous spell
          checker state: sequence id, requesting text and target node.
          This is also the first step to decompose spell-check related
          code to a separate class.
        - Added EditorClient::isAsynchronousSpellCheckingEnabled()
          to use async spellcheck API on the platform.
          These APIs are touched by SpellChecker.
        - Used SpellChecker to check a pasted test. Text to check is
          collected from the subtree under the editingRoot.
        - Added Setting::m_asynchronousSpellCheckingEnabled to control
          async spell checking.

        Test: editing/spelling/spellcheck-paste.html

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/DocumentMarkerController.cpp:
        (WebCore::DocumentMarkerController::showMarkers):
        (showDocumentMarkers):
        * dom/DocumentMarkerController.h:
        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::setOffsetInLeafNode):
        * dom/PositionIterator.h:
        * editing/Editor.cpp:
        (WebCore::Editor::replaceSelectionWithFragment):
        (WebCore::Editor::Editor):
        (WebCore::findFirstMarkable):
        (WebCore::Editor::selectionStartHasSpellingMarkerFor):
        * editing/Editor.h:
        (WebCore::Editor::spellChecker):
        * editing/SpellChecker.cpp: Added.
        (WebCore::SpellChecker::SpellChecker):
        (WebCore::SpellChecker::~SpellChecker):
        (WebCore::SpellChecker::initRequest):
        (WebCore::SpellChecker::clearRequest):
        (WebCore::SpellChecker::isAsynchronousEnabled):
        (WebCore::SpellChecker::canCheckAsynchronously):
        (WebCore::SpellChecker::isBusy):
        (WebCore::SpellChecker::isValid):
        (WebCore::SpellChecker::isCheckable):
        (WebCore::SpellChecker::requestCheckingFor):
        (WebCore::forwardIterator):
        (WebCore::SpellChecker::didCheck):
        * editing/SpellChecker.h: Added.
        (WebCore::SpellCheckingResult::SpellCheckingResult):
        (WebCore::SpellCheckingResult::type):
        (WebCore::SpellCheckingResult::location):
        (WebCore::SpellCheckingResult::length):
        * loader/EmptyClients.h:
        (WebCore::EmptyEditorClient::requestCheckingOfString):
        * page/EditorClient.h:
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        (WebCore::Settings::setAsynchronousSpellCheckingEnabled):
        (WebCore::Settings::asynchronousSpellCheckingEnabled):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * src/EditorClientImpl.h:
        (WebKit::EditorClientImpl::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebCoreSupport/EditorClientEfl.h:
        (WebCore::EditorClientEfl::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebCoreSupport/EditorClientGtk.h:
        (WebKit::EditorClient::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebCoreSupport/EditorClientHaiku.h:
        (WebCore::EditorClientHaiku::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added asynchronous spell checking API to WebEditorClient using
        -[NSSpellChecker requestCheckingOfString].
        Note that WebEditorSpellCheckResponder is a small class to receive
        requested spell-checking result. Note that this feature is
        disabled at default.

        Also added [WebPreferences setAsynchronousSpellCheckingEnabled:] to
        enable the feature from LayoutTestController.

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (-[WebEditorSpellCheckResponder initWithSender:WebCore::sequence:results:]):
        (-[WebEditorSpellCheckResponder perform]):
        (toCoreSpellingResult):
        (-[WebEditorSpellCheckResponder WTF::WebCore::]):
        (WebEditorClient::requestCheckingOfString):
        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences setAsynchronousSpellCheckingEnabled:]):
        (-[WebPreferences asynchronousSpellCheckingEnabled]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebCoreSupport/EditorClientQt.h:
        (WebCore::EditorClientQt::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebCoreSupport/WebEditorClient.h:
        (WebEditorClient::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebCoreSupport/EditorClientWinCE.h:
        (WebKit::EditorClient::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebKitSupport/EditorClientWx.h:
        (WebCore::EditorClientWx::requestCheckingOfString):
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added a stub implememntation.

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::requestCheckingOfString):
        * WebProcess/WebCoreSupport/WebEditorClient.h:
2010-10-28  MORITA Hajime  <morrita@google.com>

        Reviewed by Ojan Vafai.

        spellcheck does not check pasted text
        https://bugs.webkit.org/show_bug.cgi?id=40092

        Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
        to control the setting.

        * DumpRenderTree/LayoutTestController.cpp:
        (setAsynchronousSpellCheckingEnabledCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::setAsynchronousSpellCheckingEnabled):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setAsynchronousSpellCheckingEnabled):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setAsynchronousSpellCheckingEnabled):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setAsynchronousSpellCheckingEnabled):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setAsynchronousSpellCheckingEnabled):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::setAsynchronousSpellCheckingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Mon, 13 Dec 2010 05:52:40 +0000 (05:52 +0000)]
2010-12-09  Antonio Gomes  <agomes@rim.com>

        Reviewed by Daniel Bates.

        Spatial Navigation: code clean up (part II)
        https://bugs.webkit.org/show_bug.cgi?id=50666

        No new tests needed.

        * page/FocusController.cpp: Removed static declaration of updateFocusCandidateIfNeeded() from
        the top of FocusController.cpp, and added the 'static' keyword where the function is implemented;
        * page/SpatialNavigation.cpp: In FocusCandidate constructor, renamed 'n' to 'node', and added an assert to it;
        (WebCore::FocusCandidate::FocusCandidate):
        (WebCore::virtualRectForAreaElementAndDirection): Added an assert to 'node';
        * page/SpatialNavigation.h:I reordered the declaration of some methods in order to group related ones;
        Removed isScrollableContainerNode() function declaration since it is not used outside SpatialNavigation.cpp;
        And removed the declaration of isNodeDeepDescendantOfDocument() since it does not exist anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Implement WebInspector::localizedStringsURL on Windows
bweinstein@apple.com [Mon, 13 Dec 2010 04:41:20 +0000 (04:41 +0000)]
WebKit2: Implement WebInspector::localizedStringsURL on Windows
https://bugs.webkit.org/show_bug.cgi?id=50896

Reviewed by Tim Hatcher.

Find the localized strings file using CFBundleCopyResourceURL.

* WebProcess/WebPage/win/WebInspectorWin.cpp:
(WebKit::WebInspector::localizedStringsURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate WebKit2 skipped list.
weinig@apple.com [Mon, 13 Dec 2010 00:49:26 +0000 (00:49 +0000)]
Update WebKit2 skipped list.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGive LogTextInput a sensible flag value.
weinig@apple.com [Mon, 13 Dec 2010 00:30:20 +0000 (00:30 +0000)]
Give LogTextInput a sensible flag value.

Reviewed by Anders Carlsson.

* Platform/Logging.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd missing bugzilla URL.
weinig@apple.com [Mon, 13 Dec 2010 00:25:55 +0000 (00:25 +0000)]
Add missing bugzilla URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix failing API test. It turns out that a pop-state event
weinig@apple.com [Mon, 13 Dec 2010 00:14:06 +0000 (00:14 +0000)]
Fix failing API test. It turns out that a pop-state event
is sent before every fragment navigation, so we have to test
for it in addition in PageLoadDidChangeLocationWithinPageForFrame.

Reviewed by Anders Carlsson.

* TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
(TestWebKitAPI::didSameDocumentNavigationForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove incorrect assertion that has been firing in the API tester.
weinig@apple.com [Mon, 13 Dec 2010 00:02:07 +0000 (00:02 +0000)]
Remove incorrect assertion that has been firing in the API tester.

Reviewed by Anders Carlsson.

* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::~WebDatabaseManagerProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable WebKit2 logging by default.
weinig@apple.com [Mon, 13 Dec 2010 00:00:12 +0000 (00:00 +0000)]
Disable WebKit2 logging by default.

Reviewed by Anders Carlsson.

* Platform/Logging.cpp:
(initializeLogChannelsIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Make inspector on Windows show and be usable in WebKit2
bweinstein@apple.com [Sun, 12 Dec 2010 20:15:51 +0000 (20:15 +0000)]
Web Inspector: Make inspector on Windows show and be usable in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50877

Reviewed by Sam Weinig.

Hook up the unimplemented methods in WebInspectorProxyWin to get the web inspector
showing and usable in WebKit2 on Windows.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy): Initialize Windows-specific variables to 0.
* UIProcess/WebInspectorProxy.h:
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::registerInspectorViewWindowClass): Sets up the inspector view class.
(WebKit::WebInspectorProxy::InspectorViewWndProc): Calls through to the WebInspectorProxy's non-static
    WndProc.
(WebKit::WebInspectorProxy::wndProc): Handles WM_SIZE, WM_CLOSE, and WM_GETMINMAXINFO, the rest go to
    ::DefWindowProc.
(WebKit::WebInspectorProxy::onSizeEvent): Resize the WKView that has the inspector page to match the
    outer window that was just resized.
(WebKit::WebInspectorProxy::onMinMaxInfoEvent): Set the minimum size the window can be resized to.
(WebKit::WebInspectorProxy::onCloseEvent): Hide the window, and call WebInspectorProxy::close.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create a WKView and return its page.
(WebKit::WebInspectorProxy::platformOpen): Create an HWND for the inspector, put the inspector's WKView
    inside of it, and show the window.
(WebKit::WebInspectorProxy::platformClose): Destroy the inspector's window (which destroys the child WKView),
    and 0 out instance variables.
(WebKit::WebInspectorProxy::inspectorPageURL): Finds inspector/inspector.html in the WebKit bundle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Crash in WebPage constructor.
kbalazs@webkit.org [Sun, 12 Dec 2010 16:25:50 +0000 (16:25 +0000)]
[Qt][WK2] Crash in WebPage constructor.
https://bugs.webkit.org/show_bug.cgi?id=50892

Reviewed by Andreas Kling.

* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):
Disable runtime enabled features that have no WebKit2 implementation yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-12 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sun, 12 Dec 2010 12:00:49 +0000 (12:00 +0000)]
2010-12-12  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Martin Robinson.

        * webkit/webkitwebplugin.h: add a note about the extension list
        being a NULL-terminated array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-12 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sun, 12 Dec 2010 12:00:36 +0000 (12:00 +0000)]
2010-12-12  Xan Lopez  <xlopez@igalia.com>

        Rubber-stamped by Gustavo Noronha.

        Stop checking for glib >= 2.16, we have dependend on a newer
        version for a long time now.

        * tests/testatk.c: Stop checking for glib >= 2.16.
        * tests/testatkroles.c: ditto.
        * tests/testdomdocument.c: ditto.
        * tests/testdomdomwindow.c: ditto.
        * tests/testdomnode.c: ditto.
        * tests/testglobals.c: ditto.
        * tests/testhttpbackend.c: ditto.
        * tests/testloading.c: ditto.
        * tests/testmimehandling.c: ditto.
        * tests/testnetworkrequest.c: ditto.
        * tests/testnetworkresponse.c: ditto.
        * tests/testwebbackforwardlist.c: ditto.
        * tests/testwebdatasource.c: ditto.
        * tests/testwebframe.c: ditto.
        * tests/testwebhistoryitem.c: ditto.
        * tests/testwebresource.c: ditto.
        * tests/testwebsettings.c: ditto.
        * tests/testwebview.c: ditto.
        * tests/testwindow.c: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-12 Alejandro G. Castro <alex@igalia.com>
commit-queue@webkit.org [Sun, 12 Dec 2010 11:46:01 +0000 (11:46 +0000)]
2010-12-12  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Add new-run-webkit-tests support to gtk
        https://bugs.webkit.org/show_bug.cgi?id=50681

        Adding the basic support to run the new-run-webkit-tests.

        * Scripts/webkitpy/layout_tests/port/gtk.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Sun, 12 Dec 2010 11:30:56 +0000 (11:30 +0000)]
2010-12-12  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        build-webkit --gtk --minimal fails
        https://bugs.webkit.org/show_bug.cgi?id=46267

        No new tests, build fix only.

        * GNUmakefile.am: Include some JS bindings generated headers in
        the build even if their corresponding feature is disabled. They
        are needed to make the DOM bindings build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-12 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Sun, 12 Dec 2010 11:02:41 +0000 (11:02 +0000)]
2010-12-12  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, skipping failing tests in the bots.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-12 Sam Magnuson <smagnuso@gmail.com>
commit-queue@webkit.org [Sun, 12 Dec 2010 11:00:55 +0000 (11:00 +0000)]
2010-12-12  Sam Magnuson  <smagnuso@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] Compile with QT_NO_QUUID_STRING.
        https://bugs.webkit.org/show_bug.cgi?id=49745

        * platform/UUID.cpp:
        (WebCore::createCanonicalUUIDString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-12 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
commit-queue@webkit.org [Sun, 12 Dec 2010 10:58:59 +0000 (10:58 +0000)]
2010-12-12  Ragner Magalhaes  <ragner.magalhaes@openbossa.org>

        Reviewed by Eric Seidel.

        [Qt] Missing style for date pickers on Qt Mobile theme
        https://bugs.webkit.org/show_bug.cgi?id=50628

        * css/themeQtMobile.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMac build fix.
alice.liu@apple.com [Sun, 12 Dec 2010 07:42:55 +0000 (07:42 +0000)]
Mac build fix.

* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):
Resolve string[0] ambiguity by passing 0U.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Sun, 12 Dec 2010 03:42:44 +0000 (03:42 +0000)]
2010-12-11  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Memory leaks for QWebPageClient
        https://bugs.webkit.org/show_bug.cgi?id=50267

        Use OwnPtr to solve this memory leak issue.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::overlay):
        (QGraphicsWebViewPrivate::QWebViewPrivate::pageClient):
        (QGraphicsWebViewPrivate::syncLayers):
        (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
        (QGraphicsWebViewPrivate::_q_scaleChanged):
        (QGraphicsWebViewPrivate::detachCurrentPage):
        * Api/qwebpage_p.h:
        * Api/qwebview.cpp:
        (QWebViewPrivate::detachCurrentPage):
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::platformPageClient):
        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::setInputMethodState):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Sun, 12 Dec 2010 03:24:56 +0000 (03:24 +0000)]
2010-12-10  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        REGRESSION Hang inside Yarr::RegexCodeBlock::execute when visiting
        bugs.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=50816

        First nested parentheses of the second or greater alternative
        where backtracking to the prior parentheses.  Changed the default
        handling of initial parentheses for all alternatives to go back
        to the immediate outer paren.

        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::GenerationState::addParenthesesTail):
        (JSC::Yarr::RegexGenerator::TermGenerationState::TermGenerationState):
        (JSC::Yarr::RegexGenerator::TermGenerationState::isLastTerm):
        (JSC::Yarr::RegexGenerator::TermGenerationState::getTermIndex):
        (JSC::Yarr::RegexGenerator::TermGenerationState::setParenthesesTail):
        (JSC::Yarr::RegexGenerator::TermGenerationState::getParenthesesTail):
        (JSC::Yarr::RegexGenerator::ParenthesesTail::ParenthesesTail):
        (JSC::Yarr::RegexGenerator::ParenthesesTail::processBacktracks):
        (JSC::Yarr::RegexGenerator::ParenthesesTail::generateCode):
        (JSC::Yarr::RegexGenerator::generateParenthesesSingle):
2010-12-10  Michael Saboff  <msaboff@apple.com>

        Reviewed by Gavin Barraclough.

        REGRESSION Hang inside Yarr::RegexCodeBlock::execute when visiting
        bugs.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=50816

        New test to verify proper backtracking of alternative nested parens.

        * fast/regex/parentheses-expected.txt:
        * fast/regex/script-tests/parentheses.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Jan Erik Hanssen <jhanssen@sencha.com>
commit-queue@webkit.org [Sun, 12 Dec 2010 03:21:51 +0000 (03:21 +0000)]
2010-12-11  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] QWebFrame does not support QNetworkRequest::CacheLoadControl
        https://bugs.webkit.org/show_bug.cgi?id=35671

        Make QWebFrame respect the QNetworkRequest::CacheLoadControl attribute
        set on the request, if any.

        * Api/qwebframe.cpp:
        (cacheLoadControlToCachePolicy):
        (QWebFrame::load):
        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 12 Dec 2010 00:35:15 +0000 (00:35 +0000)]
2010-12-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        [V8] Move to DOMWindow::setLocation
        https://bugs.webkit.org/show_bug.cgi?id=50876

        Recently, JavaScriptCore moved to implementing setLocation in WebCore.
        This patch change V8 to use that common code path.  I haven't removed
        the old code path because it's still used for other things (like
        assigning window.location.href), but I'll move the rest over in a
        future patch.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::locationAccessorSetter):
        * bindings/v8/specialization/V8BindingState.cpp:
        (WebCore::::getFirstWindow):
        * bindings/v8/specialization/V8BindingState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 11 Dec 2010 20:55:05 +0000 (20:55 +0000)]
2010-12-11  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Updated chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Mock DeviceOrientation client for DRT
diegohcg@webkit.org [Sat, 11 Dec 2010 18:49:09 +0000 (18:49 +0000)]
[Qt] Mock DeviceOrientation client for DRT
https://bugs.webkit.org/show_bug.cgi?id=47490

Reviewed by Kenneth Rohde Christiansen.

WebCore:

* WebCore.pro:

WebKit/qt:

* WebCoreSupport/DeviceOrientationClientMockQt.cpp: Added.
(WebCore::DeviceOrientationClientMockQt::client):
(WebCore::DeviceOrientationClientMockQt::DeviceOrientationClientMockQt):
(WebCore::DeviceOrientationClientMockQt::~DeviceOrientationClientMockQt):
(WebCore::DeviceOrientationClientMockQt::setController):
(WebCore::DeviceOrientationClientMockQt::startUpdating):
(WebCore::DeviceOrientationClientMockQt::stopUpdating):
(WebCore::DeviceOrientationClientMockQt::lastOrientation):
(WebCore::DeviceOrientationClientMockQt::deviceOrientationControllerDestroyed):
(WebCore::DeviceOrientationClientMockQt::setOrientation):
* WebCoreSupport/DeviceOrientationClientMockQt.h: Added.
* WebCoreSupport/DeviceOrientationClientQt.cpp:
* WebCoreSupport/DeviceOrientationProviderQt.cpp:
(WebCore::DeviceOrientationProviderQt::DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::~DeviceOrientationProviderQt):
(WebCore::DeviceOrientationProviderQt::changeDeviceOrientation):
* WebCoreSupport/DeviceOrientationProviderQt.h:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::activeMockDeviceOrientationClient):
(DumpRenderTreeSupportQt::removeMockDeviceOrientation):
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
* WebCoreSupport/DumpRenderTreeSupportQt.h:

WebKitTools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::~DumpRenderTree):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setMockDeviceOrientation):

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 11 Dec 2010 18:45:35 +0000 (18:45 +0000)]
2010-12-11  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Update chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Joone Hur <joone@kldp.org>
commit-queue@webkit.org [Sat, 11 Dec 2010 18:20:52 +0000 (18:20 +0000)]
2010-12-11  Joone Hur  <joone@kldp.org>

        Reviewed by Alexey Proskuryakov.

        enumeration value ‘ResponseTypeArrayBuffer’ not handled in switch
        https://bugs.webkit.org/show_bug.cgi?id=50871

        Fix the warning which occurs when enumeration value is not handled in switch.

        No new tests, no change in behavior.

        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::response):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Sat, 11 Dec 2010 17:14:48 +0000 (17:14 +0000)]
2010-12-11  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] launcher: disable the Mozilla-style fullscreen API
        https://bugs.webkit.org/show_bug.cgi?id=50874

        Disabling the fullscreen API until its implementation for GTK is
        mature enough. The webview setting for it is already FALSE by
        default.

        * GtkLauncher/main.c:
        (createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 11 Dec 2010 16:25:39 +0000 (16:25 +0000)]
2010-12-11  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add APIs for plugin management
        https://bugs.webkit.org/show_bug.cgi?id=50827

        Add WebKitWebPluginDatabase and WebKitWebPlugin classes for basic
        plugin management at the client level. For now they provide
        "read-only" access to the plugin list.

        * GNUmakefile.am: add new files to the build.
        * tests/testwebplugindatabase.c: Test that the database contains
        the test plugin, which should always be loaded.
        * webkit/webkit.h: add new headers.
        * webkit/webkitdefines.h: add new defines.
        * webkit/webkitwebplugin.cpp: An new class representing a plugin object.
        * webkit/webkitwebplugin.h: ditto.
        * webkit/webkitwebplugindatabase.cpp: A new class that contains the list of active plugins.
        * webkit/webkitwebplugindatabase.h: ditto.
        * webkit/webkitwebplugindatabaseprivate.h: Private header.
        * webkit/webkitwebpluginprivate.h: Private header.
        * webkit/webkitwebview.cpp:
        (webkit_get_web_plugin_database): returns the WebKitWebPluginDatabase for this session.
        * webkit/webkitwebview.h: add method to header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Sat, 11 Dec 2010 15:44:01 +0000 (15:44 +0000)]
2010-12-11  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, skipping failing tests in the bots.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 11 Dec 2010 15:38:51 +0000 (15:38 +0000)]
2010-12-11  Xan Lopez  <xlopez@igalia.com>

        Skip failing http test.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Sat, 11 Dec 2010 13:05:11 +0000 (13:05 +0000)]
2010-12-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Split webkitprivate.{cpp,h} in more manageable chunks
        https://bugs.webkit.org/show_bug.cgi?id=50698

        Split private bits of several objects to their own private
        headers, and to their implementation files.

        * GNUmakefile.am:
        * WebCoreSupport/ChromeClientGtk.cpp:
        * WebCoreSupport/EditorClientGtk.cpp:
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchWillSendRequest):
        * webkit/webkitdownload.cpp:
        (webkit_download_set_response):
        * webkit/webkitdownloadprivate.h: Added.
        * webkit/webkithittestresult.cpp:
        (WebKit::kit):
        * webkit/webkithittestresultprivate.h: Added.
        * webkit/webkitnetworkresponse.cpp:
        (WebKit::core):
        (WebKit::kitNew):
        * webkit/webkitnetworkresponseprivate.h: Added.
        * webkit/webkitprivate.cpp:
        * webkit/webkitprivate.h:
        * webkit/webkitsecurityorigin.cpp:
        (webkit_security_origin_get_web_database):
        (WebKit::core):
        (WebKit::kit):
        * webkit/webkitsecurityoriginprivate.h: Added.
        * webkit/webkitviewportattributes.cpp:
        * webkit/webkitviewportattributesprivate.h: Added.
        * webkit/webkitwebbackforwardlist.cpp:
        * webkit/webkitwebbackforwardlistprivate.h: Added.
        * webkit/webkitwebdatabase.cpp:
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_get_network_response):
        * webkit/webkitwebhistoryitem.cpp:
        * webkit/webkitwebhistoryitemprivate.h: Added.
        * webkit/webkitwebnavigationaction.cpp:
        (WebKit::kit):
        (WebKit::core):
        * webkit/webkitwebnavigationactionprivate.h: Added.
        * webkit/webkitwebpolicydecision.cpp:
        * webkit/webkitwebpolicydecisionprivate.h: Added.
        * webkit/webkitwebresource.cpp:
        * webkit/webkitwebresourceprivate.h: Added.
        * webkit/webkitwebsettings.cpp:
        * webkit/webkitwebsettingsprivate.h: Added.
        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 11 Dec 2010 12:51:12 +0000 (12:51 +0000)]
2010-12-11  Xan Lopez  <xlopez@igalia.com>

        Another crashing inspector test.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sat, 11 Dec 2010 12:48:50 +0000 (12:48 +0000)]
2010-12-11  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Add an overload to makeString for Vector<char>
        https://bugs.webkit.org/show_bug.cgi?id=50123

        Also cleanup StringTypeAdapter.

        * wtf/text/StringConcatenate.h:
2010-12-11  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Darin Adler.

        Add an overload to makeString for Vector<char>
        https://bugs.webkit.org/show_bug.cgi?id=50123

        This also contains a segfault fix for ImageBuffer::toDataURL of the Haiku port.

        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::toDataURL):
        * platform/graphics/gtk/ImageBufferGtk.cpp:
        (WebCore::ImageBuffer::toDataURL):
        * platform/graphics/haiku/ImageBufferHaiku.cpp:
        (WebCore::ImageBuffer::toDataURL):
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::toDataURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSelect menus with short option titles do not paint properly
jhoneycutt@apple.com [Sat, 11 Dec 2010 12:36:14 +0000 (12:36 +0000)]
Select menus with short option titles do not paint properly
https://bugs.webkit.org/show_bug.cgi?id=50860
<rdar://problem/8660807>

The backing stores used for painting the popup menu items were only as
wide as the widest option title, but the popup window that we create is
at least as wide as the <select> element. This adjusts the backing
stores to be at least as wide as the <select>, as well.

Reviewed by Sam Weinig.

* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::paint):
Paint using the width of the backing store.

* WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::show):
Pass the page coordinates of the <select> element to
setUpPlatformData().

* WebProcess/WebCoreSupport/WebPopupMenu.h:
Added new parameter to setUpPlatformData().

* WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
(WebKit::WebPopupMenu::setUpPlatformData):
Ditto.

* WebProcess/WebCoreSupport/qt/WebPopupMenuQt.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
Ditto.

* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
Fixed a typo in a comment. Adjust the backing store size to be at least
as wide as the <select> element, and use that width when painting the
items to the backing store.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 11 Dec 2010 11:37:01 +0000 (11:37 +0000)]
2010-12-11  Xan Lopez  <xlopez@igalia.com>

        inspector/debugger-step-out.html crashing intermittently in the bots
        https://bugs.webkit.org/show_bug.cgi?id=50868

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Sat, 11 Dec 2010 11:26:25 +0000 (11:26 +0000)]
2010-12-11  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, unskip some media tests on GTK that don't fail locally.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Qt buildfix after r73808.
ossy@webkit.org [Sat, 11 Dec 2010 09:49:19 +0000 (09:49 +0000)]
Unreviewed Qt buildfix after r73808.

WebKit2: Need a WebKit2 equivalent of the WebKit1 WebDatabaseManager
https://bugs.webkit.org/show_bug.cgi?id=50606

* DerivedSources.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-11 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sat, 11 Dec 2010 09:10:24 +0000 (09:10 +0000)]
2010-12-11  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r73834.
        http://trac.webkit.org/changeset/73834
        https://bugs.webkit.org/show_bug.cgi?id=50866

        It broke Qt-WebKit2 build, because of missing WK2_DIR variable
        (Requested by Ossy on #webkit).

        * WebKit2.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Mac build fix.
ap@apple.com [Sat, 11 Dec 2010 07:21:02 +0000 (07:21 +0000)]
    Mac build fix.

        * platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
        Resolve string[0] ambiguity by passing 0U.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Sat, 11 Dec 2010 07:14:32 +0000 (07:14 +0000)]
2010-12-10  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Build fix for Symbian: don't compile POSIX memory management implementation
        https://bugs.webkit.org/show_bug.cgi?id=50707

        * wtf/wtf.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows production build fix.
sfalken@apple.com [Sat, 11 Dec 2010 07:03:35 +0000 (07:03 +0000)]
Windows production build fix.

Only the vsprops are indirected through WebKitVSPropsRedirectionDir, not the scripts in WebKitLibraries/win/tools/scripts.

* WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
* WebCore.vcproj/build-generated-files.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 John Knottenbelt <jknotten@chromium.org>
commit-queue@webkit.org [Sat, 11 Dec 2010 06:50:13 +0000 (06:50 +0000)]
2010-12-10  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Eric Seidel.

        Remove WebCore/platform/mac/GeolocationService.{h,mm}
        https://bugs.webkit.org/show_bug.cgi?id=50074

        Remove unused non-client-based geolocation code.

        * platform/mac/GeolocationServiceMac.h: Removed.
        * platform/mac/GeolocationServiceMac.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 11 Dec 2010 06:47:30 +0000 (06:47 +0000)]
2010-12-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue flaky test messages show cryptic version information for mac os x
        https://bugs.webkit.org/show_bug.cgi?id=50864

        Turns out platform.platform() returns kernel version information
        which isn't helpful, and just plain confusing on Mac
        (OS X 10.6.5 uses Darwin Kernel 10.5.0).

        So I've updated PlatformInfo.display_name() to special case
        mac.  I also found a bad use of sys.platform in the process
        and fixed that.  (sys.platform always returns 'darwin' on mac).

        * Scripts/webkitpy/common/system/platforminfo.py:
        * Scripts/webkitpy/common/system/user.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows production build fix.
sfalken@apple.com [Sat, 11 Dec 2010 06:40:56 +0000 (06:40 +0000)]
Windows production build fix.

Don't stop if react-to-vsprops-changes.py exits with an error,
since this will occur in production builds.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Sat, 11 Dec 2010 06:15:17 +0000 (06:15 +0000)]
2010-12-10  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=46573
        <rdar://problem/8479389> REGRESSION: charset="utf-8" (with quotes) doesn't work

        * http/tests/mime/quoted-charset-expected.txt: Added.
        * http/tests/mime/quoted-charset.php: Added.
2010-12-10  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=46573
        <rdar://problem/8479389> REGRESSION: charset="utf-8" (with quotes) doesn't work

        Test: http/tests/mime/quoted-charset.php

        * platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
        * platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit):
        Work around a CFNetwork issue, strip quotes if they are present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 11 Dec 2010 05:34:49 +0000 (05:34 +0000)]
2010-12-10  Eric Seidel  <eric@webkit.org>

        Unreviewed.

        Exception seen while reporting flaky test with commit-queue.
        Just a missing include.

        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Sat, 11 Dec 2010 04:58:58 +0000 (04:58 +0000)]
2010-12-10  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Eric Seidel.

        [Qt][WK2] Make WebKit2 static library compile on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=50861

        * WebKit2.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Sat, 11 Dec 2010 03:25:05 +0000 (03:25 +0000)]
2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
        https://bugs.webkit.org/show_bug.cgi?id=50796

        Also updating the test code to use JSONResultsGeneratorBase and
        to improve test coverage for incremental cases.

        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Vincent Scheib <scheib@chromium.org>
commit-queue@webkit.org [Sat, 11 Dec 2010 03:00:41 +0000 (03:00 +0000)]
2010-12-10  Vincent Scheib  <scheib@chromium.org>

        Reviewed by James Robinson.

        Shader::loadShader() must initialize variable passed to getShaderiv
        https://bugs.webkit.org/show_bug.cgi?id=50842

        Test: fast/canvas/canvas-largedraws.html

        * platform/graphics/gpu/Shader.cpp:
        (WebCore::Shader::loadShader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Vincent Scheib <scheib@chromium.org>
commit-queue@webkit.org [Sat, 11 Dec 2010 02:53:02 +0000 (02:53 +0000)]
2010-12-10  Vincent Scheib  <scheib@chromium.org>

        Reviewed by James Robinson.

        Texture::updateSubRect should pass IntRect by reference
        https://bugs.webkit.org/show_bug.cgi?id=50845

        No test, changing to pass by ref.

        * platform/graphics/gpu/Texture.cpp:
        (WebCore::Texture::updateSubRect):
        * platform/graphics/gpu/Texture.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Sat, 11 Dec 2010 02:43:02 +0000 (02:43 +0000)]
2010-12-10  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium test expectation update.

        Attach more specific bug IDs to Philip canvas test suite failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 11 Dec 2010 02:20:00 +0000 (02:20 +0000)]
2010-12-10  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Move open and showModalDialog implementations from bindings into DOM class DOMWindow
        https://bugs.webkit.org/show_bug.cgi?id=50836

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::open): Removed most of the code and changed to call
        DOMWindow::open.
        (WebCore::DialogHandler::DialogHandler): Added. Object is used to handle the
        arguments and return value in showModalDialog.
        (WebCore::DialogHandler::dialogCreated): Ditto.
        (WebCore::DialogHandler::returnValue): Ditto.
        (WebCore::setUpDialog): Added. Function passed to showModalDialog that just
        casts pointer to DialogHandler can calls dialogCreated.
        (WebCore::JSDOMWindow::showModalDialog): Removed most of the code and changed
        to call DOMWindow::showModalDialog.
        (WebCore::JSDOMWindow::postMessage): Made style match the rest of the file by
        renaming local variables and getting rid of a needless ones.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::parseModalDialogFeatures): Moved body of this function
        to the WindowFeatures class.
        (WebCore::DOMWindow::allowPopUp): Renamed argument from activeFrame to firstFrame,
        because that's the frame we pass in here. Also added an overload so this can be
        called on a window rather than a frame.
        (WebCore::DOMWindow::setLocation): Renamed a couple variables so the names are
        the same as in open and showModalDialog. Factored the JavaScript security check
        into a new function named isInsecureScriptAccess.
        (WebCore::DOMWindow::isInsecureScriptAccess): Here is the new function.
        (WebCore::DOMWindow::createWindow): Added. Contains logic shared by open and
        showModalDialog just as the function named createWindow in JSDOMWindowCustom.cpp
        used to.
        (WebCore::DOMWindow::open): Added. Code from JSDOMWindowCustom without the
        JavaScript language binding part, and with a bit of refactoring to share code
        with the rest of the DOMWindow class.
        (WebCore::DOMWindow::showModalDialog): Ditto.

        * page/DOMWindow.h: Moved conditional parts of the file into separate paragraphs
        in alphabetical order so they are not scattered thorugh the file. Removed redundant
        includes. Added some blank lines for clarity. Added an open function and a
        showModalDialog function. Added private createWindow and isInsecureScriptAccess
        functions.

        * page/WindowFeatures.cpp:
        (WebCore::isWindowFeaturesSeparator): Renamed from isSeparator for clarity.
        (WebCore::WindowFeatures::WindowFeatures): Updated for name change. Used isEmpty
        instead of checking length. Added a new constructor for use when making dialogs,
        with code from the showModalDialog function.
        (WebCore::WindowFeatures::boolFeature): Use DialogFeaturesMap typedef.
        (WebCore::WindowFeatures::floatFeature): Use DialogFeaturesMap typedef.
        Renamed a local variable and tweaked the comments a bit.
        (WebCore::WindowFeatures::parseDialogFeatures): Added. Code moved here from
        DOMWindow::parseDialogFeatures and refactored a bit.

        * page/WindowFeatures.h: Added new constructor, new parseDialogFeatures
        function, DialogFeaturesMap typedef, and made setWindowFeature function private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnsure that we are not getting too many wheel events
weinig@apple.com [Sat, 11 Dec 2010 02:14:22 +0000 (02:14 +0000)]
Ensure that we are not getting too many wheel events
<rdar://problem/7881465>

Reviewed by Anders Carlsson.

Add simple coalescing of wheel events being sent to the WebProcess. This
adds two models, one which drops interim events and one which merges events
together. For now, we are using the simpler dropping model.

* Shared/WebEvent.h:
(WebKit::WebEvent::modifiers):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::coalesceWheelEvents):
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::didReceiveEvent):
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 11 Dec 2010 02:08:07 +0000 (02:08 +0000)]
2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Darin Adler.

        prepare-ChangeLog --help doesn't mention --bug shorthand -b
        https://bugs.webkit.org/show_bug.cgi?id=50835

        * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 11 Dec 2010 02:02:47 +0000 (02:02 +0000)]
2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Darin Adler.

        prepare-ChangeLog --help doesn't mention --bug shorthand -b
        https://bugs.webkit.org/show_bug.cgi?id=50835

        * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAX: refactor AccessibilityRenderObject::doAccessibilityHitTest
cfleizach@apple.com [Sat, 11 Dec 2010 02:00:46 +0000 (02:00 +0000)]
AX: refactor AccessibilityRenderObject::doAccessibilityHitTest
https://bugs.webkit.org/show_bug.cgi?id=50574

Reviewed by Darin Adler.

WebCore:

Refactors accessibility hit testing to allow for a more flexible model when handling elements
with fake sub-elements (like sliders or list boxes).

Renamed doAccessibilityHitTest -> accessibilityHitTest, which is called on the root
accessibility render object. Then subclassers are able to override
elementAccessibilityHitTest to return their own specific elements.

* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::elementAccessibilityHitTest):
* accessibility/AccessibilityListBox.h:
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::accessibilityHitTest):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::elementAccessibilityHitTest):
* accessibility/AccessibilitySlider.h:
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_component_ref_accessible_at_point):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityHitTest:]):

WebKit/chromium:

* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::hitTest):

WebKit/win:

* AccessibleBase.cpp:
(AccessibleBase::accHitTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 W. James MacLean <wjmaclean@chromium.org>
commit-queue@webkit.org [Sat, 11 Dec 2010 01:48:20 +0000 (01:48 +0000)]
2010-12-10  W. James MacLean  <wjmaclean@chromium.org>

        Reviewed by Ojan Vafai.

        Remove unnecessary pixel results, use platform-independent text results, re Changeset 72802
        https://bugs.webkit.org/show_bug.cgi?id=50233

        First part of two-part patch to remove unnecessary pixel tests, and (in part two)
        have a single set of text expectations for all platforms. The standardized text
        expectations are added in this patch.

        * platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
        * platform/chromium-linux/svg/custom/svg-parse-overflow-1-expected.png: Removed.
        * platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
        * platform/chromium-linux/svg/custom/svg-parse-overflow-2-expected.png: Removed.
        * platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
        * platform/chromium-linux/svg/custom/svg-parse-overflow-3-expected.png: Removed.
        * platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
        * platform/chromium-linux/svg/custom/svg-parse-overflow-4-expected.png: Removed.
        * platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
        * platform/chromium-linux/svg/custom/svg-parse-overflow-5-expected.png: Removed.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-1-expected.png: Removed.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-2-expected.png: Removed.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-3-expected.png: Removed.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-4-expected.png: Removed.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
        * platform/chromium-mac/svg/custom/svg-parse-overflow-5-expected.png: Removed.
        * platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
        * platform/chromium-win/svg/custom/svg-parse-overflow-1-expected.png: Removed.
        * platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
        * platform/chromium-win/svg/custom/svg-parse-overflow-2-expected.png: Removed.
        * platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
        * platform/chromium-win/svg/custom/svg-parse-overflow-3-expected.png: Removed.
        * platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
        * platform/chromium-win/svg/custom/svg-parse-overflow-4-expected.png: Removed.
        * platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
        * platform/chromium-win/svg/custom/svg-parse-overflow-5-expected.png: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-1-expected.checksum: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-1-expected.png: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-2-expected.checksum: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-2-expected.png: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-3-expected.checksum: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-3-expected.png: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-4-expected.checksum: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-4-expected.png: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-5-expected.checksum: Removed.
        * platform/mac/svg/custom/svg-parse-overflow-5-expected.png: Removed.
        * svg/custom/svg-parse-overflow-1-expected.txt: Added.
        * svg/custom/svg-parse-overflow-1.html:
        * svg/custom/svg-parse-overflow-2-expected.txt: Added.
        * svg/custom/svg-parse-overflow-2.html:
        * svg/custom/svg-parse-overflow-3-expected.txt: Added.
        * svg/custom/svg-parse-overflow-3.html:
        * svg/custom/svg-parse-overflow-4-expected.txt: Added.
        * svg/custom/svg-parse-overflow-4.html:
        * svg/custom/svg-parse-overflow-5-expected.txt: Added.
        * svg/custom/svg-parse-overflow-5.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 11 Dec 2010 01:35:42 +0000 (01:35 +0000)]
2010-12-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
        https://bugs.webkit.org/show_bug.cgi?id=50853

        I also discovered when doing this that the code was posting
        the comment on the wrong bug, but that's fixed here too.

        * Scripts/webkitpy/common/net/bugzilla/bug.py:
        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Chromium test expectations update.
pkasting@chromium.org [Sat, 11 Dec 2010 01:31:54 +0000 (01:31 +0000)]
Unreviewed Chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Kenneth Russell <kbr@google.com>
kbr@google.com [Sat, 11 Dec 2010 01:25:37 +0000 (01:25 +0000)]
2010-12-10  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Adler.

        Clean up assertion in Extensions3DOpenGL.cpp
        https://bugs.webkit.org/show_bug.cgi?id=50852

        Built Release mode to test. No functionality change.

        * platform/graphics/opengl/Extensions3DOpenGL.cpp:
        (WebCore::Extensions3DOpenGL::ensureEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Cosmin Truta <ctruta@chromium.org>
commit-queue@webkit.org [Sat, 11 Dec 2010 01:23:26 +0000 (01:23 +0000)]
2010-12-10  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Eric Seidel.

        Crash while processing ill-formed <textPath> ouside of <text>
        https://bugs.webkit.org/show_bug.cgi?id=47759

        Ensure that ill-formed text content child elements do not crash.

        * svg/custom/invalid-text-content.svg: Added.
        * svg/custom/invalid-text-content-expected.checksum: Added.
        * svg/custom/invalid-text-content-expected.png: Added.
        * svg/custom/invalid-text-content-expected.txt: Added.
2010-12-10  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Eric Seidel.

        Crash while processing ill-formed <textPath> ouside of <text>
        https://bugs.webkit.org/show_bug.cgi?id=47759

        Renderers within a <text> subtree are created only when their corresponding elements
        satisfy the content model.

        Test: svg/custom/invalid-text-content.svg

        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::childShouldCreateRenderer): Fixed to comply with the content model.
        (WebCore::SVGTRefElement::rendererIsNeeded): Added.
        * svg/SVGTRefElement.h:
        * svg/SVGTSpanElement.cpp:
        (WebCore::SVGTSpanElement::childShouldCreateRenderer): Fixed to comply with the content model.
        (WebCore::SVGTSpanElement::rendererIsNeeded): Added.
        * svg/SVGTSpanElement.h: Changed indentation.
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::childShouldCreateRenderer): Reformatted.
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::childShouldCreateRenderer): Fixed to comply with the content model.
        (WebCore::SVGTextPathElement::rendererIsNeeded): Added.
        * svg/SVGTextPathElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Zhenyao Mo <zmo@google.com>
zmo@google.com [Sat, 11 Dec 2010 01:19:20 +0000 (01:19 +0000)]
2010-12-10  Zhenyao Mo  <zmo@google.com>

        Reviewed by Adam Barth.

        Use enums instead of booleans in ImageSource/ImageDecoder constructors
        https://bugs.webkit.org/show_bug.cgi?id=50818

        * src/WebImageDecoder.cpp:
        (WebKit::WebImageDecoder::init): Use enums instead of boolean in ImageDecoder constructor.
2010-12-10  Zhenyao Mo  <zmo@google.com>

        Reviewed by Adam Barth.

        Use enums instead of booleans in ImageSource/ImageDecoder constructors
        https://bugs.webkit.org/show_bug.cgi?id=50818

        This patch basically defines two enum type in ImageSource: AlphaOption
        and GammaAndColorProfileOption and use them as ImageSource and ImageDecoder
        constructor parameters instead of boolean typs.

        * platform/graphics/ImageSource.cpp:
        (WebCore::ImageSource::ImageSource):
        (WebCore::ImageSource::setData):
        * platform/graphics/ImageSource.h: Define the two enum types.
        * platform/graphics/cg/GraphicsContext3DCG.cpp:
        (WebCore::GraphicsContext3D::getImageData):
        * platform/graphics/cg/ImageSourceCG.cpp:
        (WebCore::ImageSource::ImageSource):
        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoder::create):
        (WebCore::ImageDecoderQt::ImageDecoderQt):
        * platform/graphics/qt/ImageDecoderQt.h:
        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):
        * platform/image-decoders/ImageDecoder.cpp:
        (WebCore::ImageDecoder::create):
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageDecoder::ImageDecoder):
        * platform/image-decoders/bmp/BMPImageDecoder.cpp:
        (WebCore::BMPImageDecoder::BMPImageDecoder):
        * platform/image-decoders/bmp/BMPImageDecoder.h:
        * platform/image-decoders/gif/GIFImageDecoder.cpp:
        (WebCore::GIFImageDecoder::GIFImageDecoder):
        * platform/image-decoders/gif/GIFImageDecoder.h:
        * platform/image-decoders/ico/ICOImageDecoder.cpp:
        (WebCore::ICOImageDecoder::ICOImageDecoder):
        (WebCore::ICOImageDecoder::decodeAtIndex):
        * platform/image-decoders/ico/ICOImageDecoder.h:
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageDecoder::JPEGImageDecoder):
        * platform/image-decoders/jpeg/JPEGImageDecoder.h:
        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::PNGImageDecoder):
        * platform/image-decoders/png/PNGImageDecoder.h:
        * platform/image-decoders/webp/WEBPImageDecoder.cpp:
        (WebCore::WEBPImageDecoder::WEBPImageDecoder):
        * platform/image-decoders/webp/WEBPImageDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Dec 2010 00:30:14 +0000 (00:30 +0000)]
2010-12-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION(r73799): editing/execCommand/4920488.html fails
        https://bugs.webkit.org/show_bug.cgi?id=50854

        The regression was caused by Range::processContents's not extracting
        m_end.container()->firstChild(). Fixed the bug by always adding the first child.

        * dom/Range.cpp:
        (WebCore::Range::processContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 11 Dec 2010 00:12:35 +0000 (00:12 +0000)]
2010-12-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION: Infinite redirect on developer.apple.com
        https://bugs.webkit.org/show_bug.cgi?id=45627

        Tests: fast/loader/form-submit-aborts-parsing.html
               fast/loader/location-change-aborts-parsing.html

        This patch is not pretty, but it fixes the bug.  I stole this approach
        from the old HTML parser (as suggested by Eric Seidel).  The other
        approaches that folks tried for this bug are better, but it's inclear
        how to get them to work correctly.  I've added a large FIXME comment.

        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::pumpTokenizer):
        * html/parser/HTMLTreeBuilder.h:
        (WebCore::HTMLTreeBuilder::isParsingFragment):
2010-12-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION: Infinite redirect on developer.apple.com
        https://bugs.webkit.org/show_bug.cgi?id=45627

        Tests originally by Tony Gentilcore.

        * fast/loader/form-submit-aborts-parsing-expected.txt: Added.
        * fast/loader/form-submit-aborts-parsing.html: Added.
        * fast/loader/location-change-aborts-parsing-expected.txt: Added.
        * fast/loader/location-change-aborts-parsing.html: Added.
        * fast/loader/resources/location-change-aborts-parsing-fail.html: Added.
        * fast/loader/resources/location-change-aborts-parsing-pass.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake WKContextGetStatistics gather global statistics
andersca@apple.com [Fri, 10 Dec 2010 23:49:59 +0000 (23:49 +0000)]
Make WKContextGetStatistics gather global statistics
https://bugs.webkit.org/show_bug.cgi?id=50850

Reviewed by John Sullivan.

WebKit2:

Change WKContextGetStatistics to work on all objects in the process, and
make it more robust by incrementing/decrementing the counts in the constructor
and destructor respectively.

Also, rename WKContextGetStatistics to WKContextGetGlobalStatistics to better match
what it's actually doing.

* UIProcess/API/C/WKContext.cpp:
(WKContextGetStatistics):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:pageNamespaceRef:pageGroupRef:]):
(-[WKView dealloc]):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::statistics):
* UIProcess/WebContext.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::~WebFrameProxy):
* UIProcess/WebPageNamespace.cpp:
* UIProcess/WebPageNamespace.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):
* UIProcess/WebPageProxy.h:

WebKitTools:

Remove the code that gets the statistics and fills in the per context
statistics information for now.

* MiniBrowser/mac/BrowserStatisticsWindowController.m:
(-[BrowserStatisticsWindowController refreshStatistics:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Context menu support on Windows
bweinstein@apple.com [Fri, 10 Dec 2010 23:43:44 +0000 (23:43 +0000)]
WebKit2: Context menu support on Windows
<https://bugs.webkit.org/show_bug.cgi?id=50514>

Reviewed by Darin Adler.

Implment showing of the context menu on Windows for WebKit2, and calling through to
WebPageProxy::contextMenuItemSelected.

* UIProcess/win/WebContextMenuProxyWin.cpp:
(WebKit::WebContextMenuProxyWin::WebContextMenuProxyWin): Initialize the member variables.
(WebKit::WebContextMenuProxyWin::populateMenu): Iterate over the vector of WebContextMenuItemData
    that was passed in, adding the menu items and recursively calling back into this function to populate
    any submenus that are needed. This function also sets up the map from action identifierss to WebContextMenuItemData,
    to use to find the WebContextMenuItemData from a selected menu item.
(WebKit::WebContextMenuProxyWin::showContextMenu): Destroy any menu we have already created, populate the menu
    to show, and show the context menu. Once TrackPopupMenuEx returns, it returns identifier of the selected menu item.
    Look up that identifier in the map we created, and tell the WebPageProxy that a context menu item was selected.
(WebKit::WebContextMenuProxyWin::hideContextMenu): Destroy the HMENU if it is non-null, and clear the identifier map.
* UIProcess/win/WebContextMenuProxyWin.h:
(WebKit::WebContextMenuProxyWin::create): Call through to the constructor, and change the arguments that it takes.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::createContextMenuProxy): Call with the correct arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoQt Build Fix. Unreviewed.
jberlin@webkit.org [Fri, 10 Dec 2010 23:41:10 +0000 (23:41 +0000)]
Qt Build Fix. Unreviewed.

* WebKit2.pro:
Add the Messages.h and MessageReceivers.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWhen we are creating a ContextMenuItem, only call setSubMenu if we have
bweinstein@apple.com [Fri, 10 Dec 2010 23:41:04 +0000 (23:41 +0000)]
When we are creating a ContextMenuItem, only call setSubMenu if we have
a subMenu to set.

Reviewed by Ada Chan.

* platform/ContextMenuItem.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73813 268f45cc-cd09-0410-ab3c-d52691b4dbfc