WebKit-https.git
14 years ago Reviewed by Tim H.
thatcher [Sun, 11 Jun 2006 20:10:35 +0000 (20:10 +0000)]
    Reviewed by Tim H.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8672
          Red outline from web inspector reappears after inspector is closed

        * WebInspector/WebInspector.m:
        (-[NSWindow windowWillClose:]): Added a call to setWebFrame to avoid further
        load progress notifications.
        (-[NSWindow setWebFrame:]): Changed to resign the WebView's hostWindow rather
        than its window for close notifications, to avoid resigning from all windows' close
        notifications (including the inspector window's) when the WebView is in a hidden tab.
        Also changed to prevent highlighting the initial focused node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Sun, 11 Jun 2006 19:49:17 +0000 (19:49 +0000)]
WebCore:

2006-06-11  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
        Move full-frame plugins to WebCore

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        Add PluginDocument

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::redirectDataToPlugin):
        Call the bridge.

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        Add redirectDataToPlugin which is used to redirect incoming data
        to a plugin.

        * bridge/mac/WebCoreViewFactory.h:
        Add pluginSupportsMIMEType which returns whether any plugins support a given MIME type.

        * dom/DOMImplementation.cpp:
        * dom/DOMImplementation.h:
        Get rid of createTextDocument and just create a text document explicitly when needed.

        * dom/Document.h:
        (WebCore::Document::isPluginDocument):
        * loader/PluginDocument.cpp: Added.
        (WebCore::PluginTokenizer::PluginTokenizer):
        (WebCore::PluginTokenizer::wantsRawData):
        (WebCore::PluginTokenizer::write):
        (WebCore::PluginTokenizer::createDocumentStructure):
        (WebCore::PluginTokenizer::writeRawData):
        (WebCore::PluginTokenizer::stopParsing):
        (WebCore::PluginTokenizer::finish):
        (WebCore::PluginTokenizer::isWaitingForScripts):
        (WebCore::PluginDocument::PluginDocument):
        (WebCore::PluginDocument::createTokenizer):
        * loader/PluginDocument.h: Added.
        (WebCore::PluginDocument::isPluginDocument):
        Add PluginDocument.

        * page/Frame.cpp:
        (WebCore::Frame::begin):
        Possibly create a plugin document.

        * page/Frame.h:
        (WebCore::Frame::redirectDataToPlugin):
        Add declaration.

        * platform/PlugInInfoStore.h:
        * platform/mac/PlugInInfoStoreMac.mm:
        (WebCore::PlugInInfoStore::supportsMIMEType):
        Ask WebCoreViewFactory if the MIME type is supported.

WebKit:

2006-06-11  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9390
        Move full-frame plugins to WebCore

        * Plugins/WebBaseNetscapePluginStream.h:
        * Plugins/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream instance]):
        Add instance method which returns the plugin instance.

        * Plugins/WebBasePluginPackage.h:
        Add WebPluginManualLoader protocol

        * Plugins/WebNetscapePluginDocumentView.h: Removed.
        * Plugins/WebNetscapePluginDocumentView.m: Removed.

        * Plugins/WebNetscapePluginEmbeddedView.h:
        * Plugins/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:]):
        (-[WebNetscapePluginEmbeddedView dealloc]):
        (-[WebNetscapePluginEmbeddedView didStart]):
        (-[WebNetscapePluginEmbeddedView pluginView:receivedResponse:]):
        (-[WebNetscapePluginEmbeddedView pluginView:receivedData:]):
        (-[WebNetscapePluginEmbeddedView pluginView:receivedError:]):
        (-[WebNetscapePluginEmbeddedView pluginViewFinishedLoading:]):
        (-[WebNetscapePluginEmbeddedView redeliverStream]):
        Make WebNetscapePluginEmbeddedView support the WebPluginManualLoader protocol. It creates a plugin stream and feeds the
        data manually. Much of this code has been copied from WebNetscapePluginRepresentation.

        * Plugins/WebNetscapePluginRepresentation.h: Removed.
        * Plugins/WebNetscapePluginRepresentation.m: Removed.

        * Plugins/WebPluginController.h:
        * Plugins/WebPluginController.m:
        (-[WebPluginController pluginView:receivedResponse:]):
        (-[WebPluginController pluginView:receivedData:]):
        (-[WebPluginController pluginView:receivedError:]):
        (-[WebPluginController pluginViewFinishedLoading:]):
        Make WebPluginController support the WebPluginManualLoader protocol so it can feed data manually to WebKit plugins.

        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase refresh]):
        Use WebHTMLView and WebHTMLRepresentation when registering/unregistering plug-in MIME types.

        * Plugins/WebPluginDocumentView.h: Removed.
        * Plugins/WebPluginDocumentView.m: Removed.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
        (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
        Add loadManually argument.

        (-[WebFrameBridge redirectDataToPlugin:]):
        Call down to the HTML representation.

        (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
        Pass NO to loadManually.

        (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
        Explicitly check if the MIME type is supported by a plug-in instead of checking the view class.

        * WebCoreSupport/WebViewFactory.m:
        (-[WebViewFactory pluginSupportsMIMEType:]):
        New function which returns whether any plugins support a given MIME type.

        * WebKit.xcodeproj/project.pbxproj:
        Update for removed files.

        * WebView/WebFrame.m:
        (-[WebFrame _reloadForPluginChanges]):
        Remove view type checks.

        (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
        (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
        Remove FIXME comments.

        * WebView/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation _redirectDataToManualLoader:forPluginView:]):
        New function which redirects incoming data to a manual loader.

        (-[WebHTMLRepresentation receivedData:withDataSource:]):
        (-[WebHTMLRepresentation receivedError:withDataSource:]):
        (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
        Optionally redirect incoming data.

        * WebView/WebHTMLRepresentationPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Sun, 11 Jun 2006 04:07:11 +0000 (04:07 +0000)]
LayoutTests:

        Patch by mitzpettel.  Reviewed by hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9334
          Incomplete repaint when changing block from non-positioned to positioned

        * fast/repaint/static-to-positioned-expected.checksum: Added.
        * fast/repaint/static-to-positioned-expected.png: Added.
        * fast/repaint/static-to-positioned-expected.txt: Added.
        * fast/repaint/static-to-positioned.html: Added.

WebCore:

        Patch by mitzpettel.  Reviewed by hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9334
          Incomplete repaint when changing block from non-positioned to positioned

        Test: fast/repaint/static-to-positioned.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle): If changing from static to positioned, repaint
        as static.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Sun, 11 Jun 2006 03:46:22 +0000 (03:46 +0000)]
LayoutTests:

        Reviewed by hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9193
          REGRESSION: setting an opacity on an element with an outline causes the outline to disappear completely

        - test repainting of layer children's outlines that extend beyond the layer

        * fast/layers: Added.
        * fast/layers/opacity-outline-expected.checksum: Added.
        * fast/layers/opacity-outline-expected.png: Added.
        * fast/layers/opacity-outline-expected.txt: Added.
        * fast/layers/opacity-outline.html: Added.
        * fast/repaint/layer-child-outline-expected.checksum: Added.
        * fast/repaint/layer-child-outline-expected.png: Added.
        * fast/repaint/layer-child-outline-expected.txt: Added.
        * fast/repaint/layer-child-outline.html: Added.

WebCore:

        Reviewed by hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9193
          REGRESSION: setting an opacity on an element with an outline causes the outline to disappear completely

        Test: fast/layers/opacity-outline.html

        - fix repainting of layer children's outlines that extend beyond the layer

        Test: fast/repaint/layer-child-outline.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::intersectsDamageRect): Account for outlines.
        (WebCore::RenderLayer::absoluteBoundingBox): Ditto.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::maximalOutlineSize): Changed to return the view's maximal
        outline size rather than 0 for PaintPhaseChildOutlines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-10 Steve Falkenburg <sfalken@apple.com>
sfalken [Sun, 11 Jun 2006 02:34:24 +0000 (02:34 +0000)]
2006-06-10  Steve Falkenburg  <sfalken@apple.com>

        Fix build break

        * platform/cairo/GraphicsContextCairo.cpp:
        * platform/win/TemporaryLinkStubs.cpp:
        (GraphicsContext::scale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren [Sat, 10 Jun 2006 16:09:27 +0000 (16:09 +0000)]
JavaScriptCore:

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8515
        Linux porting compile bug

        Fix by Mike Emmel, Reviewed by Darin.

        * JavaScriptCoreSources.bkl:
        * jscore.bkl:
        * wtf/Platform.h:

WebCore:

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8515
        Linux porting compile bug

        Fix by Mike Emmel, Reviewed by Darin.

        * Projects/gdk/webcore-gdk.bkl:
        * WebCoreSources.bkl:
        * css/maketokenizer:
        * html/HTMLCanvasElement.cpp:
        * html/HTMLImageElement.h:
        * icon/IconDatabase.cpp:
        * make-generated-sources.sh:
        * page/Frame.h:
        * page/FramePrivate.h:
        * platform/Cursor.h:
        * platform/FontData.h:
        (WebCore::FontData::getGlyphIndex):
        * platform/GlyphBuffer.h:
        (WebCore::GlyphBuffer::glyphAt):
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        * platform/GraphicsContext.h:
        * platform/PlatformKeyboardEvent.h:
        * platform/PlatformMouseEvent.h:
        * platform/PlatformWheelEvent.h:
        * platform/ScrollView.h:
        * platform/TransferJob.h:
        (WebCore::TransferJob::getInternal):
        * platform/TransferJobInternal.h:
        (WebCore::TransferJobInternal::TransferJobInternal):
        * platform/Widget.h:
        * platform/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::GraphicsContext):
        (WebCore::GraphicsContext::roundToDevicePixels):
        * webcore-base.bkl:
        * xpath/impl/XPathValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick and Dave Hyatt.
sullivan [Sat, 10 Jun 2006 13:42:45 +0000 (13:42 +0000)]
    Reviewed by Tim Omernick and Dave Hyatt.

        WebKit support for computing but not highlighting rects for text matches.

        * WebView/WebHTMLViewPrivate.h:
        added markedTextMatchesAreHighlighted/setMarkedTextMatchesAreHighlighted and
        rectsForTextMatches, and renamed related methods for clarity/consistency
        * WebView/WebHTMLView.m:
        (-[WebHTMLView markAllMatchesForText:caseSensitive:]):
        renamed, calls similarly-renamed method
        (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
        new method, calls through to bridge
        (-[WebHTMLView markedTextMatchesAreHighlighted]):
        ditto
        (-[WebHTMLView unmarkAllTextMatches]):
        renamed
        (-[WebHTMLView rectsForTextMatches]):
        new method, calls through to bridge

        * WebView/WebViewPrivate.h:
        added rectsForTextMatches, renamed other methods (and added highlight: parameter)
        * WebView/WebView.m:
        (-[WebView markAllMatchesForText:caseSensitive:highlight:]):
        renamed for clarity/consistency, and now has highlight: parameter, which is passed down
        (-[WebView unmarkAllTextMatches]):
        renamed for clarity/consistency, and calls similarly-renamed method lower down. diff got
        confused with the end of this and the end of the next method.
        (-[WebView rectsForTextMatches]):
        new method, calls through to WebHTMLView as related methods currently do

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick and Dave Hyatt.
sullivan [Sat, 10 Jun 2006 13:42:23 +0000 (13:42 +0000)]
    Reviewed by Tim Omernick and Dave Hyatt.

        WebCore support for computing but not highlighting rects for text matches.

        * dom/Document.h:
        added setRenderedRectForMarker() and renderedRectsForMarkers(), and redefined
        MarkerMap to be a hashtable of node -> (pair of vectors), one vector of markers
        and one vector of rects

        * dom/Document.cpp:
        (placeholderRectForMarker()):
        new function, returns a recognizable degenerate rect used until a real rect has been set
        (WebCore::Document::addMarker):
        Reworked for new MarkerMap data structure; now adds parallel placeholder rect
        along with marker
        (WebCore::Document::copyMarkers):
        Reworked for new MarkerMap data structure
        (WebCore::Document::removeMarkers):
        Reworked for new MarkerMap data structure; now removed corresponding rect along
        with marker
        (WebCore::Document::markersForNode):
        Reworked for new MarkerMap data structure
        (WebCore::Document::renderedRectsForMarkers):
        New method, returns an array of all non-placeholder rects for the given marker type
        (WebCore::Document::repaintMarkers):
        Reworked for new MarkerMap data structure
        (WebCore::Document::setRenderedRectForMarker):
        New method, sets the rendered rect for a given marker
        (WebCore::Document::shiftMarkers):
        Reworked for new MarkerMap data structure; resets rendered rects to placeholders.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        removed markedTextMatchesAreHighlighted guard; we always want to call paintTextMatchMarker
        now, but sometimes we will end up only computing the rect, not actually highlighting it.
        (Maybe some names should be improved here?)
        (WebCore::InlineTextBox::paintTextMatchMarker):
        Reorganized to move all the code that actually draws into a block that's guarded by
        markedTextMatchesAreHighlighted. The rest of the code computes where the highlight will
        go, and now we always use that computation in order to call setRenderedRectForMarker.

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge rectsForTextMatches]):
        New method, returns an array of NSValues representing NSRects. Gets them
        from Document::renderedRectsForMarkers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <http://bugzilla.opendarwin.org/show_bug.cgi?id=9384>
sullivan [Sat, 10 Jun 2006 13:38:38 +0000 (13:38 +0000)]
    <bugzilla.opendarwin.org/show_bug.cgi?id=9384>
        WebView's initWithCoder: method does not set useBackForwardList
        correctly

        Reviewed by John Sullivan.

        * WebView/WebView.m:
        (-[WebView initWithCoder:]):
        Make sure that the function variable useBackForwardList is correctly
        set, so that the copy in the _private ivar is set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-10 Mitz Pettel <opendarwin.org@mitzpettel.com>
ap [Sat, 10 Jun 2006 10:24:10 +0000 (10:24 +0000)]
2006-06-10  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed and landed by ap.

        - make DumpRenderTree build

        * DumpRenderTree/DumpRenderTree.m:
        (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): Changed _updateFocusState to _updateActiveState
        (-[WaitUntilDoneDelegate webViewFocus:]): Ditto.
        (-[LayoutTestController setWindowIsKey:]): Ditto.
        (-[LayoutTestController setMainFrameIsFirstResponder:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-10 Anders Carlsson <acarlsson@apple.com>
andersca [Sat, 10 Jun 2006 09:59:44 +0000 (09:59 +0000)]
2006-06-10  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Eric.

        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLElement::put):
        Call WebCore::JSHTMLElement::put so that autogenerated setters will work
        for HTMLElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix -- I think :).
ggaren [Sat, 10 Jun 2006 04:52:43 +0000 (04:52 +0000)]
    Build fix -- I think :).

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/context.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - Build fix after last JSC check-in (oops!)
ggaren [Sat, 10 Jun 2006 04:34:00 +0000 (04:34 +0000)]
    - Build fix after last JSC check-in (oops!)

        * bridge/mac/WebCoreScriptDebugger.mm:
        (-[WebCoreScriptCallFrame scopeChain]):
        (-[WebCoreScriptCallFrame functionName]):
        (-[WebCoreScriptCallFrame evaluateWebScript:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric (yay!).
ggaren [Sat, 10 Jun 2006 03:57:13 +0000 (03:57 +0000)]
    Reviewed by Eric (yay!).

        - Removed Context wrapper for ContextImp, renamed ContextImp to Context,
        split Context into its own file -- Context.cpp -- renamed _var to m_var,
        change ' *' to '* '.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/Context.cpp: Added.
        (KJS::Context::Context):
        (KJS::Context::~Context):
        (KJS::Context::mark):
        * kjs/context.h:
        (KJS::Context::scopeChain):
        (KJS::Context::variableObject):
        (KJS::Context::setVariableObject):
        (KJS::Context::thisValue):
        (KJS::Context::callingContext):
        (KJS::Context::activationObject):
        (KJS::Context::currentBody):
        (KJS::Context::function):
        (KJS::Context::arguments):
        (KJS::Context::pushScope):
        (KJS::Context::seenLabels):
        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction):
        (KJS::FunctionImp::processParameters):
        (KJS::FunctionImp::argumentsGetter):
        (KJS::GlobalFuncImp::callAsFunction):
        * kjs/internal.cpp:
        (KJS::InterpreterImp::evaluate):
        * kjs/internal.h:
        (KJS::InterpreterImp::setContext):
        (KJS::InterpreterImp::context):
        * kjs/interpreter.cpp:
        * kjs/interpreter.h:
        (KJS::ExecState::context):
        (KJS::ExecState::ExecState):
        * kjs/nodes.cpp:
        (currentSourceId):
        (currentSourceURL):
        (ThisNode::evaluate):
        (ResolveNode::evaluate):
        (FunctionCallResolveNode::evaluate):
        (PostfixResolveNode::evaluate):
        (DeleteResolveNode::evaluate):
        (TypeOfResolveNode::evaluate):
        (PrefixResolveNode::evaluate):
        (AssignResolveNode::evaluate):
        (VarDeclNode::evaluate):
        (VarDeclNode::processVarDecls):
        (DoWhileNode::execute):
        (WhileNode::execute):
        (ForNode::execute):
        (ForInNode::execute):
        (ContinueNode::execute):
        (BreakNode::execute):
        (ReturnNode::execute):
        (WithNode::execute):
        (SwitchNode::execute):
        (LabelNode::execute):
        (TryNode::execute):
        (FuncDeclNode::processFuncDecl):
        (FuncExprNode::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@14798 268f45cc-cd09-0410...
justing [Sat, 10 Jun 2006 03:09:09 +0000 (03:09 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix win32 build bustage.
hyatt [Sat, 10 Jun 2006 00:01:07 +0000 (00:01 +0000)]
Fix win32 build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rename updateFocusState to updateActiveState.
hyatt [Fri, 9 Jun 2006 23:37:58 +0000 (23:37 +0000)]
    Rename updateFocusState to updateActiveState.

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _updateActiveState]):
        (-[NSArray viewDidMoveToWindow]):
        (-[NSArray windowDidBecomeKey:]):
        (-[NSArray windowDidResignKey:]):
        (-[NSArray becomeFirstResponder]):
        (-[NSArray resignFirstResponder]):
        (-[WebHTMLView _formControlIsBecomingFirstResponder:]):
        (-[WebHTMLView _formControlIsResigningFirstResponder:]):
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rename m_isFocused on the frame to m_isActive, since it isn't really
hyatt [Fri, 9 Jun 2006 23:26:57 +0000 (23:26 +0000)]
    Rename m_isFocused on the frame to m_isActive, since it isn't really
        about focus but is instead about whether or not the top-level window is
        active.

        Pull code that was incorrectly factored into Mac-only code out of FrameMac
        and back up into Frame.

        Reviewed by andersca

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        * page/Frame.cpp:
        (WebCore::Frame::setFocusNodeIfNeeded):
        (WebCore::Frame::isActive):
        (WebCore::Frame::setIsActive):
        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Win32 build bustage.
hyatt [Fri, 9 Jun 2006 23:07:42 +0000 (23:07 +0000)]
Fix Win32 build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemoves some control characters that snuck in.
thatcher [Fri, 9 Jun 2006 21:25:34 +0000 (21:25 +0000)]
Removes some control characters that snuck in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
hyatt [Fri, 9 Jun 2006 20:20:45 +0000 (20:20 +0000)]
WebCore:

        Rework selection coloring.  Rename displaysWithFocusAttributes
        to isActive.  Move the white-blending code onto the Color API to make
        it more convenient to mutate colors for selection blending.  Eliminate all
        the selection state from the GraphicsContext and move it to the RenderTheme.
        Implement both Win32 and Mac theme selection colors.

        Reviewed by sfalken

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::setIsActive):
        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge drawRect:]):
        (-[WebCoreFrameBridge setIsActive:]):
        (-[WebCoreFrameBridge selectionColor]):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::checkOneSelector):
        * page/Frame.cpp:
        (WebCore::Frame::isActive):
        (WebCore::Frame::setIsActive):
        * page/Frame.h:
        * platform/Color.cpp:
        (WebCore::blend):
        (WebCore::Color::blendWithWhite):
        * platform/Color.h:
        (WebCore::Color::hasAlpha):
        * platform/GraphicsContext.cpp:
        (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
        * platform/GraphicsContext.h:
        * platform/mac/GraphicsContextMac.mm:
        * platform/win/TemporaryLinkStubs.cpp:
        (GraphicsContext::endTransparencyLayer):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paintSelection):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::fillHorizontalSelectionGap):
        (WebCore::RenderBlock::fillVerticalSelectionGap):
        (WebCore::RenderBlock::fillLeftSelectionGap):
        (WebCore::RenderBlock::fillRightSelectionGap):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paint):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderListMarker.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::selectionColor):
        * rendering/RenderObject.h:
        * rendering/RenderReplaced.cpp:
        * rendering/RenderReplaced.h:
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::activeSelectionColor):
        (WebCore::RenderTheme::inactiveSelectionColor):
        (WebCore::RenderTheme::platformActiveSelectionColor):
        (WebCore::RenderTheme::platformInactiveSelectionColor):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::platformActiveSelectionColor):
        (WebCore::RenderThemeMac::platformInactiveSelectionColor):
        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::platformActiveSelectionColor):
        (WebCore::RenderThemeWin::platformInactiveSelectionColor):
        * rendering/RenderThemeWin.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):

WebKit:

        Rename displaysWithFocusAttributes to isActive.

        Reviewed by sfalken

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebHTMLView.m:
        (-[WebHTMLView _updateFocusState]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Fri, 9 Jun 2006 19:14:21 +0000 (19:14 +0000)]
LayoutTests:

        Reviewed by levi

        <rdar://problem/4549980>
        REGRESSION: "Find Again" can get stuck when searching for string with a trailing space

        * editing/execCommand/findString-expected.checksum: Added.
        * editing/execCommand/findString-expected.png: Added.
        * editing/execCommand/findString-expected.txt: Added.
        * editing/execCommand/findString.html: Added.

WebCore:

        Reviewed by levi

        <rdar://problem/4549980>
        REGRESSION: "Find Again" can get stuck when searching for string with a trailing space

        * bridge/mac/FrameMac.h: Moved findString to Frame.
        * bridge/mac/FrameMac.mm: Ditto.
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:]):
        Convert the NSString to a String.
        * editing/JSEditor.cpp: Added execCommand(FindString, ...)
        * editing/Selection.cpp: Added a constructor for Ranges
        (WebCore::Selection::Selection):
        * editing/Selection.h:
        * page/Frame.cpp:
        (WebCore::Frame::findString): Moved from FrameMac.  Compare a selection created
        using the found range with the current selection in case the current selection is
        the found range minus some collapsed whitespace on the edges.
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin, landed by Geoff.
ggaren [Fri, 9 Jun 2006 19:06:06 +0000 (19:06 +0000)]
    Reviewed by Darin, landed by Geoff.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9350
        Use pathcmp() when sorting paths in svn-create-patch

        * Scripts/run-webkit-tests: Fixed splitpath() to use File::Basename subroutines instead of regex.
        * Scripts/svn-create-patch: Copied numericcmp(), pathcmp() and splitpath() from run-webkit-tests.
        Changed sort() functions to use pathcmp().  Added subroutine prototypes.  Added -h command-line
        switch and printUsage() subroutine.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-09 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 9 Jun 2006 18:40:55 +0000 (18:40 +0000)]
2006-06-09  Steve Falkenburg  <sfalken@apple.com>

        Fix build break

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * css/MediaQueryEvaluator.cpp:
        * platform/win/TemporaryLinkStubs.cpp:
        (GraphicsContext::addRoundedRectClip):
        (GraphicsContext::addInnerRoundedRectClip):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt. Tweaked by Maciej. Tweaks reviewed by Beth.
bdakin [Fri, 9 Jun 2006 17:09:08 +0000 (17:09 +0000)]
    Reviewed by Hyatt. Tweaked by Maciej. Tweaks reviewed by Beth.
        Landed by Beth.

        CSS3 Media Queries implementation.
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4127>

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_css.cpp:
        (KJS::DOMMediaList::put):
        (KJS::KJS::DOMMediaListProtoFunc::callAsFunction):
        * bindings/objc/DOMCSS.mm:
        (-[DOMMediaList setMediaText:]):
        (-[DOMMediaList deleteMedium:]):
        (-[DOMMediaList appendMedium:]):
        * css/CSSGrammar.y:
        * css/MediaFeatureNames.cpp: Added.
        (WebCore::MediaFeatureNames::init):
        * css/MediaFeatureNames.h: Added.
        * css/MediaList.cpp:
        (WebCore::MediaList::MediaList):
        (WebCore::MediaList::~MediaList):
        (WebCore::parseMediaDescriptor):
        (WebCore::MediaList::deleteMedium):
        (WebCore::MediaList::mediaText):
        (WebCore::MediaList::setMediaText):
        (WebCore::MediaList::item):
        (WebCore::MediaList::appendMedium):
        (WebCore::MediaList::appendMediaQuery):
        * css/MediaList.h:
        (WebCore::MediaList::MediaList):
        (WebCore::MediaList::length):
        (WebCore::MediaList::mediaQueries):
        * css/MediaQuery.cpp: Added.
        (WebCore::MediaQuery::MediaQuery):
        (WebCore::MediaQuery::~MediaQuery):
        (WebCore::MediaQuery::operator==):
        (WebCore::MediaQuery::cssText):
        * css/MediaQuery.h: Added.
        (WebCore::MediaQuery::):
        (WebCore::MediaQuery::restrictor):
        (WebCore::MediaQuery::expressions):
        (WebCore::MediaQuery::mediaType):
        (WebCore::MediaQuery::append):
        * css/MediaQueryEvaluator.cpp: Added.
        (WebCore::):
        (WebCore::MediaQueryEvaluator):
        (WebCore::MediaQueryEvaluator::~MediaQueryEvaluator):
        (WebCore::MediaQueryEvaluator::mediaTypeMatch):
        (WebCore::applyRestrictor):
        (WebCore::MediaQueryEvaluator::eval):
        (WebCore::parseAspectRatio):
        (WebCore::cmpvalue):
        (WebCore::numberValue):
        (WebCore::colorMediaFeatureEval):
        (WebCore::monochromeMediaFeatureEval):
        (WebCore::device_aspect_ratioMediaFeatureEval):
        (WebCore::gridMediaFeatureEval):
        (WebCore::device_heightMediaFeatureEval):
        (WebCore::device_widthMediaFeatureEval):
        (WebCore::heightMediaFeatureEval):
        (WebCore::widthMediaFeatureEval):
        (WebCore::min_colorMediaFeatureEval):
        (WebCore::max_colorMediaFeatureEval):
        (WebCore::min_monochromeMediaFeatureEval):
        (WebCore::max_monochromeMediaFeatureEval):
        (WebCore::min_device_aspect_ratioMediaFeatureEval):
        (WebCore::max_device_aspect_ratioMediaFeatureEval):
        (WebCore::min_heightMediaFeatureEval):
        (WebCore::max_heightMediaFeatureEval):
        (WebCore::min_widthMediaFeatureEval):
        (WebCore::max_widthMediaFeatureEval):
        (WebCore::min_device_heightMediaFeatureEval):
        (WebCore::max_device_heightMediaFeatureEval):
        (WebCore::min_device_widthMediaFeatureEval):
        (WebCore::max_device_widthMediaFeatureEval):
        (WebCore::createFunctionMap):
        * css/MediaQueryEvaluator.h: Added.
        * css/MediaQueryExp.cpp: Added.
        (WebCore::MediaQueryExp::MediaQueryExp):
        (WebCore::MediaQueryExp::~MediaQueryExp):
        * css/MediaQueryExp.h: Added.
        (WebCore::MediaQueryExp::mediaFeature):
        (WebCore::MediaQueryExp::value):
        (WebCore::MediaQueryExp::operator==):
        * css/StyleSheet.cpp:
        (WebCore::StyleSheet::setMedia):
        * css/cssparser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::~CSSParser):
        (WebCore::CSSParser::setupParser):
        (WebCore::CSSParser::parseMediaQuery):
        (WebCore::CSSParser::createFloatingMediaQueryExp):
        (WebCore::CSSParser::sinkFloatingMediaQueryExp):
        (WebCore::CSSParser::createFloatingMediaQueryExpList):
        (WebCore::CSSParser::sinkFloatingMediaQueryExpList):
        (WebCore::CSSParser::createFloatingMediaQuery):
        (WebCore::CSSParser::sinkFloatingMediaQuery):
        * css/cssparser.h:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::CSSStyleSelector::init):
        (WebCore::CSSStyleSelector::~CSSStyleSelector):
        (WebCore::CSSStyleSelector::loadDefaultStyle):
        (WebCore::CSSStyleSelector::matchUARules):
        (WebCore::CSSStyleSelector::styleForElement):
        (WebCore::CSSStyleSelector::pseudoStyleForElement):
        (WebCore::CSSStyleSelector::updateFont):
        (WebCore::CSSStyleSelector::cacheBorderAndBackground):
        (WebCore::CSSStyleSelector::styleRulesForElement):
        (WebCore::CSSRuleSet::addRulesFromSheet):
        * css/cssstyleselector.h:
        * css/maketokenizer:
        * css/tokenizer.flex:
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createCSSStyleSheet):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        (WebCore::HTMLLinkElement::setStyleSheet):
        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::childrenChanged):
        * ksvg2/svg/SVGDOMImplementation.cpp:
        (SVGDOMImplementation::createCSSStyleSheet):
        * ksvg2/svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::childrenChanged):
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        * platform/Screen.h:
        * platform/mac/ScreenMac.mm:
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoTweaked ChangeLog
justing [Fri, 9 Jun 2006 06:14:29 +0000 (06:14 +0000)]
Tweaked ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Fri, 9 Jun 2006 04:57:51 +0000 (04:57 +0000)]
LayoutTests:

        Reviewed by levi

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
        Implement execCommand(Insert{Un}OrderedList)

        Added:
        * editing/execCommand/create-list-from-range-selection-expected.checksum: Added.
        * editing/execCommand/create-list-from-range-selection-expected.png: Added.
        * editing/execCommand/create-list-from-range-selection-expected.txt: Added.
        * editing/execCommand/create-list-from-range-selection.html: Added.
        * editing/execCommand/insert-list-and-stitch-expected.checksum: Added.
        * editing/execCommand/insert-list-and-stitch-expected.png: Added.
        * editing/execCommand/insert-list-and-stitch-expected.txt: Added.
        * editing/execCommand/insert-list-and-stitch.html: Added.
        * editing/execCommand/insert-list-with-id-expected.checksum: Added.
        * editing/execCommand/insert-list-with-id-expected.png: Added.
        * editing/execCommand/insert-list-with-id-expected.txt: Added.
        * editing/execCommand/insert-list-with-id.html: Added.
        * editing/execCommand/remove-list-from-range-selection-expected.checksum: Added.
        * editing/execCommand/remove-list-from-range-selection-expected.png: Added.
        * editing/execCommand/remove-list-from-range-selection-expected.txt: Added.
        * editing/execCommand/remove-list-from-range-selection.html: Added.
        * editing/execCommand/remove-list-items-expected.checksum: Added.
        * editing/execCommand/remove-list-items-expected.png: Added.
        * editing/execCommand/remove-list-items-expected.txt: Added.
        * editing/execCommand/remove-list-items.html: Added.
        * editing/execCommand/switch-list-type-expected.checksum: Added.
        * editing/execCommand/switch-list-type-expected.png: Added.
        * editing/execCommand/switch-list-type-expected.txt: Added.
        * editing/execCommand/switch-list-type.html: Added.

        Fixes:
        * editing/pasteboard/drag-drop-modifies-page-expected.txt:
        * editing/pasteboard/paste-list-001-expected.txt:
        * editing/selection/drag-to-contenteditable-iframe-expected.checksum:
        * editing/selection/drag-to-contenteditable-iframe-expected.png:
        * editing/selection/drag-to-contenteditable-iframe-expected.txt:
        * editing/style/block-style-005-expected.txt:
        * fast/text/textIteratorNilRenderer-expected.checksum:
        * fast/text/textIteratorNilRenderer-expected.png:
        * fast/text/textIteratorNilRenderer-expected.txt:
        * editing/deleting/delete-line-016-expected.checksum:
        * editing/deleting/delete-line-016-expected.png:
        * editing/deleting/delete-line-016-expected.txt:

WebCore:

        Reviewed by levi

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
        Implement execCommand(Insert{Un}OrderedList)

        * WebCore.xcodeproj/project.pbxproj: Added InsertListCommand.{h,cpp} to the project.
        * dom/Position.cpp:
        (WebCore::hasRenderedNonAnonymousDescendantsWithHeight):
        Added. A block with height is only a candidate if this is false.  This should fix the problems
        getting carets into empty blocks.
        (WebCore::Position::inRenderedContent):
        * editing/AppendNodeCommand.cpp:
        (WebCore::AppendNodeCommand::doApply):
        * editing/CompositeEditCommand.cpp:
        (WebCore::hasARenderedDescendant):
        (WebCore::CompositeEditCommand::prune): A node can have DOM descendants that are rendered, yet
        have no rendered descendants.  Fixed the pruning rule to avoid removing a node like this.
        (WebCore::CompositeEditCommand::mergeIdenticalElements): Put the two elements next to
        each other if they aren't already, as a convenience.
        (WebCore::CompositeEditCommand::moveParagraph): Added code to preserve the current selection.
        (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
        * editing/CompositeEditCommand.h:
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializeStartEnd): Expansion for special elements should
        continue to happen until it is no longer possible.
        (WebCore::DeleteSelectionCommand::handleGeneralDelete): The code to adjust the start node
        wouldn't always avoid removing the start block.
        * editing/InsertListCommand.cpp: Added.
        (WebCore::InsertListCommand::fixOrphanedListChild): Puts a list item that isn't inside a list
        into a list.
        (WebCore::InsertListCommand::InsertListCommand):
        (WebCore::InsertListCommand::modifyRange):
        (WebCore::InsertListCommand::doApply):
        * editing/InsertListCommand.h: Added.
        (WebCore::InsertListCommand::):
        * editing/InsertNodeBeforeCommand.cpp:
        (WebCore::InsertNodeBeforeCommand::doApply):
        * editing/InsertParagraphSeparatorCommand.cpp:
        * editing/JSEditor.cpp:
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::advance): Don't handle a node if the end of the range used to create the
        iterator ends at the start of that node.
        used to create the iterator.
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::next):
        (WebCore::VisiblePosition::previous):
        * editing/VisiblePosition.h:
        Added a parameter to next/previous to prevent them from going outside the current editable region.
        * editing/htmlediting.cpp:
        (WebCore::highestAncestor):
        (WebCore::enclosingList):
        (WebCore::enclosingListChild):
        (WebCore::outermostEnclosingList):
        (WebCore::createListItemElement):
        * editing/htmlediting.h:
        * page/Frame.cpp:
        (WebCore::Frame::selectionListState): Added.
        * page/Frame.h:

WebKit:

        Reviewed by levi

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=4468>
        Implement execCommand(Insert{Un}OrderedList)

        * WebView/WebFrame.m:
        (-[WebFrame _findFrameWithSelection]): Removed an assertion
        that we only have one frame with a selection.
        * WebView/WebView.m:
        (-[WebView selectedFrame]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
thatcher [Fri, 9 Jun 2006 01:06:36 +0000 (01:06 +0000)]
    Reviewed by Darin.

        Include our own copies of the BSD and LGPL licenses.

        * coding/bsd-license.html: Added.
        * coding/lgpl-license.html: Added.
        * nav.inc: link to our copies of the licenses

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
harrison [Thu, 8 Jun 2006 22:10:47 +0000 (22:10 +0000)]
LayoutTests:

        Reviewed by Geoff and John.

        <rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12)

        * fast/dom/setPrimitiveValue-expected.checksum: Added.
        * fast/dom/setPrimitiveValue-expected.png: Added.
        * fast/dom/setPrimitiveValue-expected.txt: Added.
        * fast/dom/setPrimitiveValue.html: Added.

WebCore:

        Reviewed by Geoff and John.

        <rdar://problem/4558879> -[DOMCSSPrimitiveValue setStringValue:] throws an exception (12)

        Problem was the primitive value was getting reset to a generic state before the parameter
        check that relies on that state.

        Test: fast/dom/setPrimitiveValue.html

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::setFloatValue):
        (WebCore::CSSPrimitiveValue::setStringValue):
        Move parameter checks ahead of call to cleanup().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadded tests for Range.isPointInRange and Range.comparePoint
aliceli1 [Thu, 8 Jun 2006 21:38:46 +0000 (21:38 +0000)]
added tests for Range.isPointInRange and Range.comparePoint

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Justin.
aliceli1 [Thu, 8 Jun 2006 21:35:11 +0000 (21:35 +0000)]
    Reviewed by Justin.

        - fixed <rdar://problem/4578115> support Range.isPointInRange
        - fixed <rdar://problem/4578123> support Range.comparePoint

        * dom/Range.cpp:
        (WebCore::Range::isPointInRange):
        added implementation
        (WebCore::Range::comparePoint):
        added implementation
        * dom/Range.h:
        added prototypes
        * dom/Range.idl:
        added bindings

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix.
thatcher [Thu, 8 Jun 2006 21:20:34 +0000 (21:20 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin and John.
thatcher [Thu, 8 Jun 2006 21:05:16 +0000 (21:05 +0000)]
    Reviewed by Darin and John.

        <rdar://problem/3600734> API: please add a way to turn vertical scrollbar
        always on (for Mail, to avoid reflow when typing)

        Adds new methods to lock the scrolling mode on WebDynamicScrollBarsView.
        Locking the scroll mode prevents WebCore from changing it as needed.
        Also adds an SPI on WebView that will lock the "always on" mode
        for each scroller.

        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDynamicScrollBarsView.h:
        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView setAllowsScrolling:]):
        (-[WebDynamicScrollBarsView allowsScrolling]):
        (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
        (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]):
        (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]):
        (-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
        (-[WebDynamicScrollBarsView setScrollingMode:]):
        (-[WebDynamicScrollBarsView setHorizontalScrollingModeLocked:]):
        (-[WebDynamicScrollBarsView setVerticalScrollingModeLocked:]):
        (-[WebDynamicScrollBarsView setScrollingModesLocked:]):
        (-[WebDynamicScrollBarsView horizontalScrollingModeLocked]):
        (-[WebDynamicScrollBarsView verticalScrollingModeLocked]):
        * WebView/WebView.m:
        (-[WebView setAlwaysShowVerticalScroller:]):
        (-[WebView alwaysShowVerticalScroller]):
        (-[WebView setAlwaysShowHorizontalScroller:]):
        (-[WebView alwaysShowHorizontalScroller]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
darin [Thu, 8 Jun 2006 16:43:24 +0000 (16:43 +0000)]
WebCore:

        Reviewed by Justin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8616
          REGRESSION: TinyMCE: Crash on Undo

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:allowShadowContent:]):
        Changed to call nodeInfoAtPoint directly.
        (-[WebCoreFrameBridge _visiblePositionForPoint:]): Changed to call nodeInfoAtPoint directly.
        Also added code to convert coordinates so it works for points that are in nodes in subframes.

        * page/Frame.cpp:
        (WebCore::Frame::setMark): Added assertions to catch if we attempt to set selection
        endpoints in another document.
        (WebCore::Frame::setSelection): Ditto.

WebKit:

        Reviewed by Justin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8616
          REGRESSION: TinyMCE: Crash on Undo

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _topHTMLView]): Added.
        (-[WebHTMLView _isTopHTMLView]): Added.
        (-[WebHTMLView _insideAnotherHTMLView]): Changed to use _topHTMLView.
        (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
        Forward to the top HTML view, so that only the top view ever starts a dragging operation.
        Change dragging code to not assume that the dragged node is in the current view's document.
        Added checks that the node is an element in a couple places and coordinate conversions.
        (-[WebHTMLView _mayStartDragAtEventLocation:]): Forward to the top HTML view.
        (-[NSArray addMouseMovedObserver]): Change to do nothing when the dataSource field is 0,
        since we now use the dataSource field to get to the WebView.
        (-[NSArray removeMouseMovedObserver]): Added a comment.
        (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]):
        Forward to the top HTML view.
        (-[NSArray draggingSourceOperationMaskForLocal:]): Assert that it's the top HTML view.
        (-[NSArray draggedImage:movedTo:]): Ditto.
        (-[NSArray draggedImage:endedAt:operation:]): Ditto.
        (-[NSArray namesOfPromisedFilesDroppedAtDestination:]): Ditto.
        (-[NSArray _canProcessDragWithDraggingInfo:]): Ditto.
        (-[NSArray _isMoveDrag]): Ditto.
        (-[NSArray draggingUpdatedWithDraggingInfo:actionMask:]): Ditto.
        (-[NSArray draggingCancelledWithDraggingInfo:]): Ditto.
        (-[NSArray concludeDragForDraggingInfo:actionMask:]): Ditto. Also added code to work
        with the appropriate bridge when receiving a drag. This fixes the problem where the
        top level frame got a selection intended for the inner frame; the source of the bug.
        (-[NSArray elementAtPoint:allowShadowContent:]): Added code to convert the coordinates
        so this works properly when returning an element from an inner frame.
        (-[NSArray setDataSource:]): Added a call to addMouseMovedObserver, needed now that
        addMouseMovedObserver won't do anything if called when dataSource is nil.
        (-[WebHTMLView _delegateDragSourceActionMask]): Forward to the top HTML view.

        * WebView/WebView.m:
        (-[WebViewPrivate dealloc]): Removed code to release dragCaretBridge since that field
        is now gone.
        (-[WebView moveDragCaretToPoint:]): Always call the main frame's bridge, since the
        drag caret is now a page-level item. Later we'll move it to the page bridge.
        (-[WebView removeDragCaret]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded change log entry that I apparently forgot.
darin [Thu, 8 Jun 2006 16:36:35 +0000 (16:36 +0000)]
Added change log entry that I apparently forgot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Thu, 8 Jun 2006 04:04:38 +0000 (04:04 +0000)]
LayoutTests:

        Reviewed by levi

        * editing/deleting/delete-4038408-fix-expected.txt:
        * editing/input/attributed-substring-from-range-lines-expected.txt:
        * editing/inserting/insert-3654864-fix-expected.txt:
        * editing/inserting/insert-3659587-fix-expected.txt:
        * editing/inserting/insert-3775316-fix-expected.txt:
        * editing/inserting/insert-at-end-01-expected.txt:
        * editing/inserting/insert-at-end-02-expected.txt:
        * editing/inserting/insert-br-001-expected.txt:
        * editing/inserting/insert-br-005-expected.txt:

WebCore:

        Reviewed by levi

        Fixed some comments and removed an unused variable.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::removeBlockPlaceholder):
        Don't remove a br if it isn't at the start of a block, since
        it isn't really a "block placeholder".
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData):
        (WebCore::DeleteSelectionCommand::mergeParagraphs):
        (WebCore::DeleteSelectionCommand::doApply):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
        * editing/htmlediting.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add support for custom highlighting to WebKit.
hyatt [Thu, 8 Jun 2006 01:43:52 +0000 (01:43 +0000)]
    Add support for custom highlighting to WebKit.

        Reviewed by justin

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:]):
        * WebView/WebHTMLView.m:
        (-[WebHTMLView _highlighterForType:]):
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add support for custom highlighting. This is all ifdefed to be Mac-only.
hyatt [Thu, 8 Jun 2006 01:41:55 +0000 (01:41 +0000)]
    Add support for custom highlighting.  This is all ifdefed to be Mac-only.

        Reviewed by justin

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::paintCustomHighlight):
        * bridge/mac/WebCoreFrameBridge.h:
        * platform/mac/ClipboardMac.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintCustomHighlight):
        * rendering/InlineTextBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
adele [Thu, 8 Jun 2006 01:25:48 +0000 (01:25 +0000)]
WebCore:

        Reviewed by Hyatt

        Added support for cross-platform resize property.

        * platform/PlatformMouseEvent.h: Removed isMouseButtonDown, since we
        already cache this info when we handle mouse down and mouse up.
        * platform/mac/MouseEventMac.mm: ditto.
        * platform/win/TemporaryLinkStubs.cpp: ditto.

        * page/Frame.cpp:
        (WebCore::Frame::autoscrollTimerFired): Use d->m_bMousePressed instead of isMouseButtonDown.
        * page/FrameView.cpp:
        (WebCore::FrameView::handleMouseMoveEvent): Passes event to layer resize method.
        (WebCore::FrameView::mousePressed): Added.
        * page/FrameView.h: Added mousePressed.

        * rendering/RenderTheme.h: Removed paintResizeControl.
        Since its not dependent on the theme, the layer can just paint this.
        * rendering/RenderTheme.cpp: ditto.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer): Initializes m_resizeCornerImage.
        (WebCore::RenderLayer::~RenderLayer): Deletes m_resizeCornerImage.
        (WebCore::RenderLayer::resize): Uses passed in event instead of creating a new one.
        (WebCore::RenderLayer::paintResizeControl): Now loads and paints the resize image.
        * rendering/RenderLayer.h: Added m_resizeCornerImage.  Important to have one per-layer for when we allow
        more customization.

        * platform/cairo/ImageCairo.cpp:
        (WebCore::Image::loadResource): Loads image resources.

WebKit:

        Reviewed by Hyatt.

        Added resources for missingImage and textAreaResizeCorner.

        * COM/WebKitDLL.cpp:
        (loadResourceIntoArray): Added. Returns a DeprecatedByteArray with the resource's data.
        * WebKit.vcproj/WebKit.rc: Added missing image and resize pngs as resources.
        * WebKit.vcproj/WebKit.vcproj: Added pngs.
        * WebKit.vcproj/missingImage.png: Added.
        * WebKit.vcproj/resource.h: Added entries for pngs.
        * WebKit.vcproj/textAreaResizeCorner.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add SPI for setting and removing custom highlighters.
hyatt [Thu, 8 Jun 2006 00:18:42 +0000 (00:18 +0000)]
    Add SPI for setting and removing custom highlighters.

        Reviewed by Tim H

        * WebView/WebHTMLView.m:
        (-[WebTextCompleteController dealloc]):
        (-[WebHTMLView _setHighlighter:ofType:]):
        (-[WebHTMLView _removeHighlighterOfType:]):
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add support for a new property for custom highlighting. This patch just
hyatt [Wed, 7 Jun 2006 23:08:40 +0000 (23:08 +0000)]
    Add support for a new property for custom highlighting.  This patch just
        adds support for the parsing of the property.  It doesn't do anything yet.

        Reviewed by beth

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSPropertyNames.in:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/render_style.cpp:
        (WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData):
        (WebCore::StyleCSS3InheritedData::operator==):
        (WebCore::RenderStyle::diff):
        * rendering/render_style.h:
        (WebCore::RenderStyle::highlight):
        (WebCore::RenderStyle::setHighlight):
        (WebCore::RenderStyle::initialHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Removed API directory I prematurely/accidentally added.
ggaren [Wed, 7 Jun 2006 22:59:45 +0000 (22:59 +0000)]
    Removed API directory I prematurely/accidentally added.

        * API: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix suggested by Rob Buis. Reviewed by Darin.
darin [Wed, 7 Jun 2006 16:33:49 +0000 (16:33 +0000)]
    Fix suggested by Rob Buis. Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9341
          REGRESSION: Repro crash caused by style="font:bold"

        Test: fast/css/font-shorthand-weight-only.html

        * css/cssparser.cpp: (WebCore::CSSParser::parseFont): Revert part of the change
        made to fix bug 5564.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Wed, 7 Jun 2006 16:29:33 +0000 (16:29 +0000)]
LayoutTests:

        Reviewed by Hyatt, tweaked by Mitz.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9122
          REGRESSION: Incorrect vertical position for text fields in a "display: table" block

        * fast/table/text-field-baseline-expected.checksum: Added.
        * fast/table/text-field-baseline-expected.png: Added.
        * fast/table/text-field-baseline-expected.txt: Added.
        * fast/table/text-field-baseline.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9122
          REGRESSION: Incorrect vertical position for text fields in a "display: table" block

        Test: fast/table/text-field-baseline.html

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::baselinePosition): Do not descend into replaced objects, just
        use their baseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Wed, 7 Jun 2006 16:26:49 +0000 (16:26 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - pixel test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4334
          REGRESSION: Flickering when css-hover should change opacity on floating elements

        * fast/block/float/nopaint-after-layer-destruction-expected.checksum: Added.
        * fast/block/float/nopaint-after-layer-destruction-expected.png: Added.
        * fast/block/float/nopaint-after-layer-destruction-expected.txt: Added.
        * fast/block/float/nopaint-after-layer-destruction.html: Added.

WebCore:

        Reviewed by Hyatt (concept) and Darin (some coding details).

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4334
          REGRESSION: Flickering when css-hover should change opacity on floating elements

        Pixel test: fast/block/float/nopaint-after-layer-destruction.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::setPaintsFloatingObject): Added. Changes the noPaint flag
        in the block's FloatingObject for the given float and calls setChildNeedsLayout.
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::blockThatPaintsFloat): Added this helper function.
        (WebCore::RenderBox::setStyle): Added. Calls to setPaintsFloatingObject when a float
        gains or loses its layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Wed, 7 Jun 2006 03:14:35 +0000 (03:14 +0000)]
WebKitTools:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9322
        Teach svn-create-patch to sort its output

        * Scripts/svn-create-patch: Clean up perl code.  Sort patch output alphabetically
        by text files first, then by binary files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Wed, 7 Jun 2006 03:13:43 +0000 (03:13 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - repaint test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9121
          REGRESSION: [Incremental Repaint] DHTML movement test failures

        * fast/repaint/containing-block-position-change-expected.checksum: Added.
        * fast/repaint/containing-block-position-change-expected.png: Added.
        * fast/repaint/containing-block-position-change-expected.txt: Added.
        * fast/repaint/containing-block-position-change.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9121
          REGRESSION: [Incremental Repaint] DHTML movement test failures

        Test (repaint): fast/repaint/containing-block-position-change.html

        * manual-tests/containing-block-position-chage.html: Added.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock): Unrelated change: fixed typo from
        the RenderCanvas to RenderView rename.
        (WebCore::RenderBlock::removePositionedObject): Added a return immediately
        after removing the object.
        (WebCore::RenderBlock::removePositionedObjects): Added.
        * rendering/RenderBlock.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle): Added code to remove absolutely positioned
        descendants from the positioned objects list of their current containing block
        when they are going to have a new one as a result of this block's position
        property changing.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::removePositionedObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * fast/repaint/table-extra-bottom-grow.html: Removed unneeded line of code.
darin [Wed, 7 Jun 2006 03:12:53 +0000 (03:12 +0000)]
    * fast/repaint/table-extra-bottom-grow.html: Removed unneeded line of code.

        * fast/repaint/table-extra-bottom-grow-expected.png: Regenerated.
        * fast/repaint/table-extra-bottom-grow-expected.checksum: Regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Wed, 7 Jun 2006 00:09:37 +0000 (00:09 +0000)]
LayoutTests:

        Reviewed by levi

        Added to demonstrate fixes:
        * editing/pasteboard/merge-after-delete-expected.checksum: Added.
        * editing/pasteboard/merge-after-delete-expected.png: Added.
        * editing/pasteboard/merge-after-delete-expected.txt: Added.
        * editing/pasteboard/merge-after-delete.html: Added.
        * editing/inserting/line-break-expected.checksum: Added.
        * editing/inserting/line-break-expected.png: Added.
        * editing/inserting/line-break-expected.txt: Added.
        * editing/inserting/line-break.html: Added.
        * editing/inserting/multiple-lines-selected-expected.checksum: Added.
        * editing/inserting/multiple-lines-selected-expected.png: Added.
        * editing/inserting/multiple-lines-selected-expected.txt: Added.
        * editing/inserting/multiple-lines-selected.html: Added.

        Fixed:
        * editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
        * editing/deleting/delete-3775172-fix-expected.txt:
        * editing/deleting/delete-3928305-fix-expected.txt:
        * editing/deleting/delete-3959464-fix-expected.checksum:
        * editing/deleting/delete-3959464-fix-expected.png:
        * editing/deleting/delete-3959464-fix-expected.txt:
        * editing/deleting/delete-4038408-fix-expected.checksum:
        * editing/deleting/delete-4038408-fix-expected.png:
        * editing/deleting/delete-4038408-fix-expected.txt:
        * editing/deleting/delete-4038408-fix.html:
        * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
        * editing/deleting/delete-block-contents-001-expected.txt:
        * editing/deleting/delete-block-contents-002-expected.txt:
        * editing/deleting/delete-block-contents-003-expected.txt:
        * editing/deleting/delete-br-011-expected.checksum:
        * editing/deleting/delete-br-011-expected.png:
        * editing/deleting/delete-br-011-expected.txt:
        * editing/deleting/delete-image-004-expected.txt:
        * editing/deleting/delete-line-010-expected.txt:
        * editing/deleting/delete-line-015-expected.txt:
        * editing/deleting/delete-select-all-001-expected.checksum:
        * editing/deleting/delete-select-all-001-expected.png:
        * editing/deleting/delete-select-all-001-expected.txt:
        * editing/deleting/delete-select-all-002-expected.txt:
        * editing/deleting/delete-select-all-003-expected.checksum:
        * editing/deleting/delete-select-all-003-expected.png:
        * editing/deleting/delete-select-all-003-expected.txt:
        * editing/execCommand/insertImage-expected.checksum:
        * editing/execCommand/insertImage-expected.png:
        * editing/input/attributed-substring-from-range-lines-expected.txt:
        * editing/input/text-input-controller-expected.txt:
        * editing/inserting/insert-3654864-fix-expected.txt:
        * editing/inserting/insert-3659587-fix-expected.txt:
        * editing/inserting/insert-3775316-fix-expected.txt:
        * editing/inserting/insert-after-delete-001-expected.txt:
        * editing/inserting/insert-at-end-01-expected.txt:
        * editing/inserting/insert-at-end-02-expected.txt:
        * editing/inserting/insert-br-001-expected.txt:
        * editing/inserting/insert-br-005-expected.txt:
        * editing/pasteboard/4076267-3-expected.txt:
        * editing/pasteboard/4076267-expected.txt:
        * editing/pasteboard/drag-drop-modifies-page-expected.txt:
        * editing/pasteboard/paste-4035648-fix-expected.txt:
        * editing/pasteboard/paste-4039777-fix-expected.checksum:
        * editing/pasteboard/paste-4039777-fix-expected.png:
        * editing/pasteboard/paste-4039777-fix-expected.txt:
        * editing/pasteboard/paste-match-style-001-expected.txt:
        * editing/pasteboard/paste-match-style-002-expected.txt:
        * editing/pasteboard/smart-paste-006-expected.txt:
        * editing/pasteboard/smart-paste-007-expected.txt:
        * editing/selection/drag-to-contenteditable-iframe-expected.txt:
        * editing/style/block-style-005-expected.txt:
        * editing/style/typing-style-002-expected.txt:
        * editing/unsupported-content/list-delete-001-expected.checksum:
        * editing/unsupported-content/list-delete-001-expected.png:
        * editing/unsupported-content/list-delete-001-expected.txt:
        * editing/unsupported-content/list-delete-002-expected.checksum:
        * editing/unsupported-content/list-delete-002-expected.png:
        * editing/unsupported-content/list-delete-002-expected.txt:
        * editing/unsupported-content/table-delete-001-expected.checksum:
        * editing/unsupported-content/table-delete-001-expected.png:
        * editing/unsupported-content/table-delete-001-expected.txt:
        * editing/unsupported-content/table-delete-003-expected.checksum:
        * editing/unsupported-content/table-delete-003-expected.png:
        * editing/unsupported-content/table-delete-003-expected.txt:
        * fast/text/attributed-substring-from-range.html:

WebCore:

        Reviewed by levi

        * dom/Node.cpp:
        (WebCore::Node::firstDescendant): Added.
        * dom/Node.h:
        * dom/Range.cpp: Added a constructor that takes in Positions.
        (WebCore::Range::Range):
        * dom/Range.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertNodeAt):
        Let this function insert children into empty containers.
        Calls canHaveChildrenForEditing.
        (WebCore::CompositeEditCommand::appendNode): Assert that the parent canHaveChildrenForEditing.
        (WebCore::CompositeEditCommand::moveParagraph): Tell ReplaceSelectionCommand to select the
        replacement so that moveParagraph's callers have a valid destination after the move.
        * editing/CompositeEditCommand.h: Moved removeFullySelectedNode to DeleteSelectionCommand,
        made deleteTextFromNode virtual so that DeleteSelectionCommand can update it's endingPosition.
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::DeleteSelectionCommand):
        Removed m_startNode, used a local variable.
        (WebCore::DeleteSelectionCommand::initializeStartEnd): Fixed special element expansion.
        (WebCore::DeleteSelectionCommand::initializePositionData): Compute the endingPosition up
        front and keep track of it as nodes and text are removed.
        (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Removed use of m_startNode.
        (WebCore::DeleteSelectionCommand::removeFullySelectedNode): Moved from CompositeEditCommand.
        Update m_endingPosition as we remove nodes.
        (WebCore::DeleteSelectionCommand::deleteTextFromNode):
        Update m_endingPosition as we delete text.
        (WebCore::DeleteSelectionCommand::handleGeneralDelete): Retain the start block.  Cleaned up.
        (WebCore::DeleteSelectionCommand::mergeParagraphs): Recompute m_endingPosition since moveParagraph
        clobbers the old one.
        (WebCore::DeleteSelectionCommand::doApply): Fixed the logic for placeholder insertion after
        deletion. Make the placeholder decision before we do special element expansion.
        * editing/DeleteSelectionCommand.h:
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply): Fixed a bug where an extra br was inserted and cleaned
        up the code.
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply): Deletion of the current selection should do
        a merge (added a testcase).
        * editing/RebalanceWhitespaceCommand.cpp:
        (WebCore::RebalanceWhitespaceCommand::doUnapply): Remove/insert in a way that will trigger a layout.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Ditto.
        Merge even when the incoming fragment has interchange newlines (added a testcase).
        Merge when the selection being pasted into starts at the start of a block because not
        doing so would leave one or more hanging empty blocks.
        (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
        Rebalance whitespace using rebalanceWhitespaceAt because rebalanceWhitespace requires
        a selection, and a selection can't be created until whitespace has been rebalanced.
        * editing/htmlediting.cpp:
        (WebCore::canHaveChildrenForEditing): Added.
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
bdakin [Wed, 7 Jun 2006 00:03:02 +0000 (00:03 +0000)]
    Reviewed by Maciej.

        Fix for <rdar://problem/4570475> Dashboard regions do not scale for
        non-1.0 scale factors.

        No test cases added since this only affects non-1.0 resolution
        scale factors.

        * platform/FloatRect.cpp:
        (WebCore::FloatRect::scale): Added new function that scales a
        rect's origin and size by a given factor.
        * platform/FloatRect.h:
        * platform/IntRect.cpp:
        (WebCore::IntRect::scale): Same as above.
        * platform/IntRect.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::addDashboardRegions): After the bounds and
        clip rects on the Dashboard region have been calculated, get the
        user space scale factor, and if it is not 1.0, scale the rects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
sullivan [Tue, 6 Jun 2006 22:58:33 +0000 (22:58 +0000)]
    Reviewed by Darin Adler.

        - fixed <rdar://problem/4566087> REGRESSION (420+): Crash occurs while completing a find again query at
        http://www.apple.com/ (RenderObject::repaint(bool))

        This wasn't a new problem in the code, but the recent use of DocumentMarkers for find results brought
        it to the surface.

        * dom/Document.h:
        Use a RefPtr<Node> instead of a Node* in MarkerMap, so the node will be retained

        * dom/Document.cpp:
        (WebCore::Document::removeMarkers):
        Add a .get() to compensate for using RefPtr. Also, only repaint if this node actually had a marker
        removed.
        (WebCore::Document::repaintMarkers):
        Add a .get() to compensate for using RefPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Justin.
adele [Tue, 6 Jun 2006 22:28:48 +0000 (22:28 +0000)]
    Reviewed by Justin.

        * COM/WebView.cpp:
        (WebView::keyPress): Added case for VK_RETURN.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Tue, 6 Jun 2006 18:26:12 +0000 (18:26 +0000)]
WebCore:

2006-06-06  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
        clientWidth/clientHeight on document element in strict mode should return visible frame size

        * dom/Element.cpp:
        (WebCore::Element::clientWidth):
        (WebCore::Element::clientHeight):
        If we're the document element, and in strict mode, return the visible size of the frame.

LayoutTests:

2006-06-06  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
        clientWidth/clientHeight on document element in strict mode should return visible frame size

        * fast/dom/client-width-height-expected.txt: Added.
        * fast/dom/client-width-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Tue, 6 Jun 2006 17:55:00 +0000 (17:55 +0000)]
WebCore:

2006-06-06  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by John.

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge containsPlugins]):
        * page/Frame.cpp:
        (WebCore::Frame::containsPlugins):
        * page/Frame.h:
        Add containsPlugins function which returns whether a frame contains plugins
        or not.

WebKit:

2006-06-06  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by John.

        * WebView/WebFrame.m:
        (-[WebFrame _reloadForPluginChanges]):
        Don't traverse the view hierarchy looking for plugin views. Instead, just
        ask the frame whether it contains any plugins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed and landed by Geoff.
ggaren [Tue, 6 Jun 2006 05:59:43 +0000 (05:59 +0000)]
    Reviewed and landed by Geoff.

        - fix a regression in ecma_3/String/regress-104375.js

        * kjs/string_object.cpp:
        (substituteBackreferences): If a 2-digit back reference is out of range,
        parse it as a 1-digit reference (followed by the other digit). This matches
        Firefox's behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-06 Steve Falkenburg <sfalken@apple.com>
sfalken [Tue, 6 Jun 2006 03:52:30 +0000 (03:52 +0000)]
2006-06-06  Steve Falkenburg  <sfalken@apple.com>

        Fix build break

        * platform/win/TemporaryLinkStubs.cpp:
        (GraphicsContext::roundToDevicePixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Tue, 6 Jun 2006 03:13:33 +0000 (03:13 +0000)]
LayoutTests:

        Reviewed by mjs.

        testcases for http://bugzilla.opendarwin.org/show_bug.cgi?id=5564
        'font' shorthand parsing should be more tolerant in quirks mode

        * fast/css/font_property_compatibility-expected.checksum: Added.
        * fast/css/font_property_compatibility-expected.png: Added.
        * fast/css/font_property_compatibility-expected.txt: Added.
        * fast/css/font_property_compatibility.html: Added.
        * fast/css/font_property_normal-expected.checksum: Added.
        * fast/css/font_property_normal-expected.png: Added.
        * fast/css/font_property_normal-expected.txt: Added.
        * fast/css/font_property_normal.html: Added.

WebCore:

        Reviewed by mjs.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=5564
        'font' shorthand parsing should be more tolerant in quirks mode

        When not in strict mode accept font property specifications
        lacking a font family part, like WinIE does.

        * css/cssparser.cpp:
        (WebCore::CSSParser::parseFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
bdakin [Tue, 6 Jun 2006 02:27:00 +0000 (02:27 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/4567520> Pixel cracks in weather widget at
        1.83 scaling

        To prevent pixel cracks at non-integral scaling factors, before we
        call into CG to draw an image, we have to convert the rect to
        device space, round the origin and size to integers in device
        space, and convert back to user space.

        No test cases added since this only affects non-1.0 resolution
        scale factors.

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::JSCanvasRenderingContext2D::drawImage): drawImage() now
        takes FloatRects.
        * html/CanvasPattern.cpp:
        (WebCore::patternCallback): Call roundToDevicePixels()
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage): drawImage() now
        takes FloatRects and call roundToDevicePixels()
        * html/CanvasRenderingContext2D.h: drawImage() now takes
        FloatRects.
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::paint): Call roundToDevicePixels()
        * kcanvas/device/quartz/QuartzSupport.mm:
        (WebCore::debugDumpCGImageToFile): Same as above.
        * platform/GraphicsContext.h:
        * platform/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::roundToDevicePixels): Takes care of
        converting between coordinate spaces and rounding.
        (WebCore::GraphicsContext::drawLineForText):
        * platform/mac/ImageMac.mm: Call roundToDevicePixels()
        (WebCore::Image::draw): Same as above.
        (WebCore::drawPattern): Same as above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Tue, 6 Jun 2006 01:51:02 +0000 (01:51 +0000)]
LayoutTests:

        Reviewed by ggaren.

        - Test results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9310
        Add missing DOM prototypes and other DOM cleanup

        * fast/dom/global-constructors-expected.txt: Fixed test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix for perf regression with single-processor windows machines on ibench.
hyatt [Tue, 6 Jun 2006 00:23:57 +0000 (00:23 +0000)]
Fix for perf regression with single-processor windows machines on ibench.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed By Maciej.
ggaren [Mon, 5 Jun 2006 22:12:48 +0000 (22:12 +0000)]
    Reviewed By Maciej.
        Darin already reviewed this change on the branch. See <rdar://problem/4317701>.

        - Fixed <rdar://problem/4291345> PCRE overflow in Safari JavaScriptCore

        No test case because there's no behavior change.

        * pcre/pcre_compile.c:
        (read_repeat_counts): Check for integer overflow / out of bounds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Mon, 5 Jun 2006 17:15:38 +0000 (17:15 +0000)]
LayoutTests:

        - Merged test-prototypes.html into global-constructors.html
        - Added prototypes.html, which tests for some missing prototypes in DOM objects

        * fast/dom/global-constructors-expected.txt:
        * fast/dom/global-constructors.html:
        * fast/dom/prototypes-expected.txt: Added.
        * fast/dom/prototypes.html: Added.
        * fast/dom/test-prototypes-expected.txt: Removed.
        * fast/dom/test-prototypes.html: Removed.
        * fast/dom/undetectable-document-all-expected.txt: Updated to reflect
        change from "HTMLCollection" to "Collection"

WebCore:

        Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9310
        Add missing DOM prototypes and other DOM cleanup

        - Added the built-in object prototype to DOM objects that were missing it
        so that primitive operations like == work on them.

        - Removed dead EventConstructor class (it's autogenerated now)

        - Changed HTML collections to describe themselves as "[object Collection]",
        to match IE.

        - Made DOMCSSRule constructor private because JSCSSRule is the class
        to use.

        * bindings/js/JSHTMLOptionElementConstructor.cpp:
        (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
        * bindings/js/kjs_css.cpp:
        (KJS::DOMStyleSheet::DOMStyleSheet):
        (KJS::DOMStyleSheetList::DOMStyleSheetList):
        (KJS::DOMCSSRule::DOMCSSRule):
        (KJS::DOMCSSValue::DOMCSSValue):
        (KJS::toJS):
        (KJS::DOMRGBColor::DOMRGBColor):
        (KJS::getDOMRGBColor):
        (KJS::DOMRect::DOMRect):
        * bindings/js/kjs_css.h:
        * bindings/js/kjs_dom.cpp:
        (KJS::DOMNodeList::DOMNodeList):
        (KJS::DOMExceptionConstructor::DOMExceptionConstructor):
        (KJS::DOMExceptionConstructor::getOwnPropertySlot):
        (KJS::):
        (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection):
        * bindings/js/kjs_dom.h:
        (KJS::DOMNamedNodesCollection::classInfo):
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_html.cpp:
        (KJS::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by aliu.
ggaren [Mon, 5 Jun 2006 16:37:59 +0000 (16:37 +0000)]
    Reviewed by aliu.

        - Changed CString length from int to size_t. We sould probably do this
        for UString, too. (Darin, if you're reading this: Maciej said so.)

        * kjs/function.cpp:
        (KJS::encode):
        * kjs/ustring.cpp:
        (KJS::CString::CString):
        (KJS::operator==):
        * kjs/ustring.h:
        (KJS::CString::size):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Mon, 5 Jun 2006 05:20:32 +0000 (05:20 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9031
          REGRESSION: Crash when closing tabs on newegg.com
        - removed a no-longer-needed Win32-specific workaround (not reviewed)

        * bindings/js/kjs_window.cpp: Added include of <wtf/MathExtras.h>.
        (WebCore::floatFeature): Remove WIN32 ifdef around isnan.
        (WebCore::toJS): Add null checks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Mon, 5 Jun 2006 04:15:18 +0000 (04:15 +0000)]
LayoutTests:

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9176
          REGRESSION: repro crash in WebCore::StringImpl::hash() const + 28 (StringImpl.h:67)

        * fast/loader/link-no-URL.html: Added.
        * fast/loader/link-no-URL-expected.txt: Added.

WebCore:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9176
          REGRESSION: repro crash in WebCore::StringImpl::hash() const + 28 (StringImpl.h:67)

        Test: fast/loader/link-no-URL.html

        * loader/Cache.h:
        * loader/Cache.cpp:
        (WebCore::Cache::updateCacheStatus): Removed the URL parameter. Instead get the URL
        from the cached object itself. Callers were passing in the wrong URL. When it was a
        null string, it caused the crash mentioned above. But in other cases it may have
        caused some other minor problems as well. Added an assert to catch cases where the
        URL is null (should never happen).
        (WebCore::Cache::requestImage): Changed call site to not pass URL.
        (WebCore::Cache::requestStyleSheet): Ditto.
        (WebCore::Cache::requestScript): Ditto.
        (WebCore::Cache::requestXSLStyleSheet): Ditto.
        (WebCore::Cache::requestXBLDocument): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
ggaren [Mon, 5 Jun 2006 03:09:22 +0000 (03:09 +0000)]
    Reviewed by Maciej.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9304
        Minor cleanup in JavaScriptCore

        * kjs/value.h: Removed redundant declarations

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
darin [Sun, 4 Jun 2006 23:05:35 +0000 (23:05 +0000)]
    Reviewed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7291
          REGRESSION: delete key does not work in isIndex fields

        * platform/mac/WebCoreTextField.mm:
        (inputElement): Added. Helper function to get the Objective-C wrapper for an
        input element associated with a QTextEdit. Returns nil if the element is not
        an input element. The bug was caused by passing a non-input element to the
        delegate methods.
        (-[KWQTextFieldController controlTextDidBeginEditing:]): Use inputElement
        and don't make the delegate call at all if there is none. This happens only
        with isindex elements; it's not important to have auto-fill work with those.
        (-[KWQTextFieldController controlTextDidEndEditing:]): Ditto.
        (-[KWQTextFieldController controlTextDidChange:]): Ditto.
        (-[KWQTextFieldController control:textShouldEndEditing:]): Ditto.
        (-[KWQTextFieldController control:textView:doCommandBySelector:]): Ditto.
        (-[KWQTextFieldController textView:shouldHandleEvent:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
darin [Sun, 4 Jun 2006 23:03:41 +0000 (23:03 +0000)]
    Reviewed by Anders.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8995
          memory leak in XPath code -- seen in layout tests
        - fixed malloc error on exit due to SVGDOMImplementation destructor
        - attempted to fix the no-XPATH_SUPPORT build by adding an #if
        - changed around includes and header-file formatting in XPath code

        * bindings/scripts/CodeGeneratorJS.pm: Include PlatformString.h when
        generating the bindings for XPathNSResolver.

        * dom/DOMImplementation.h: Added a virtual destructor for the benefit of
        SVGDOMImplementation.
        * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::~DOMImplementation): Added.

        * ksvg2/svg/SVGDOMImplementation.h: Reformatted a bit, removed unneeded declarations.
        * ksvg2/svg/SVGDOMImplementation.cpp:
        (SVGDOMImplementation::~SVGDOMImplementation): Remove commented-out code.
        (SVGDOMImplementation::createDocument): Remove a reference to KDOMView.

        * xpath/XPathExpression.cpp:
        (WebCore::XPathExpression::createExpression): Called release to avoid a tiny bit of
        reference count churn.
        (WebCore::XPathExpression::evaluate): Set exception code explicitly, because the code
        relies on it being 0 when the function succeeds.

        * xpath/XPathResult.cpp:
        (WebCore::InvalidatingEventListener::InvalidatingEventListener): Removed
        unneeded target node data member.
        (WebCore::XPathResult::XPathResult): Updated for enum name changes and
        InvalidatingEventListener name change. Added an assertion.

        * xpath/impl/XPathFunctions.h: Removed the FunctionLibrary class. Changed the parameter
        for createFunction to be a String instead of char*.
        * xpath/impl/XPathFunctions.cpp: Got rid of local implementation of "round", and
        used <wtf/MathExtras.h> instead. Also removed unused Interval::asString. Marked all
        the Interval functions inline.
        (WebCore::XPath::FunSubstring::doEvaluate): Use lround() instead of (long)round().
        (WebCore::XPath::FunLang::doEvaluate): Removed some unneeded temporary String variables.
        Use equalIgnoringCase() instead of calling lower() on two strings.
        (WebCore::XPath::createFunctionMap): Changed how this works so that it's all local to
        this function. Also removed a duplicate entry for the "last" function.
        (WebCore::XPath::createFunction): Changed from a member function to a separate function.
        Also changed so that if the args are not used in the function they are deleted.
        This was one of the sources of the storage leaks.

        * xpath/impl/XPathGrammar.y: Put XPATH_SUPPORT ifdef in. Replaced <num> with values of
        specific types (numop, eqop). Updated for name change from AxisType to Axis. Changed
        tokens that were declared as <str> but weren't actually using the string to be
        declared with no type (PLUS, MINUS, OR, AND, DOTDOT, SLASHSLASH). Replaced use of
        unregisterString, unregisterPredicateVector, and unregisterExpressionVector to
        call delete functions instead that both unregister and delete. Change call sites for
        createFunction to just use the String, removing the deprecatedString().latin1() call
        that is no longer needed. Added a call to unregisterParseNode that was missing in the
        "FilterExpr DescendantOrSelf RelativeLocationPath" production.

        * xpath/impl/XPathParser.h: Changed Token to hold a String, Step::Axis, NumericOp::Opcode,
        and EqTestOp::Opcode. The token ID number tells us which to use. Rearranged to put the private
        part of the Parser class last. Moved a number of private things inside the cpp file.
        * xpath/impl/XPathParser.cpp:
        (WebCore::XPath::charCat): Made this a separate function, instead of a static member.
        (WebCore::XPath::isAxisName): Ditto. Also put the global axis map inside the function,
        allowing use of a map instead of a map pointer.
        (WebCore::XPath::isNodeTypeName): Ditto.
        (WebCore::XPath::Parser::isOperatorContext): Made this const.
        (WebCore::XPath::Parser::makeTokenAndAdvance): Got rid of the "int" version of this.
        By using the actual types, we can safely use overload instead.
        (WebCore::XPath::Parser::lexString): Use substring() instead of deprecatedString().mid().
        (WebCore::XPath::Parser::lexNumber): Ditto.
        (WebCore::XPath::Parser::lexNCName): Changed to return a bool and a String instead of a
        Token. This avoids the hack of using a token value of "ERROR + 1" which I found quite
        confusing and is also a bit more explicit.
        (WebCore::XPath::Parser::lexQName): Ditto.
        (WebCore::XPath::Parser::nextTokenInternal): Changed to adapt to the changes above and
        to remove some unneeded else statements.
        (WebCore::XPath::Parser::lex): Changed the logic that sets up yylval to use the token ID
        to decide what the type is. This matches what the grammar expects, and removes the need
        for the token object to track which part of the value is good and the need to reserve 0
        to have a special meaning.
        (WebCore::XPath::Parser::parseStatement): Added code to delete the predicates and the
        expressions in the predicate and expression vectors. Before, we were only deleting
        the vectors. This was one of the sources of the storage leaks.
        (WebCore::XPath::Parser::deletePredicateVector): Renamed, and changed to delete
        the vector. However this does not delete the predicates in the vector.
        (WebCore::XPath::Parser::deleteExpressionVector): Renamed, and changed to delete
        the vector. However this does not delete the expressions in the vector.
        (WebCore::XPath::Parser::deleteString): Renamed, and changed to delete the string.

        * xpath/impl/XPathPredicate.h:
        * xpath/impl/XPathPredicate.cpp:
        (WebCore::XPath::NumericOp::NumericOp): Changed opcode from an int to an enum, and
        renamed to "opcode" instead of "opCode".
        (WebCore::XPath::NumericOp::doEvaluate): More of the same.
        (WebCore::XPath::EqTestOp::EqTestOp): Ditto.
        (WebCore::XPath::EqTestOp::doEvaluate): Ditto.
        (WebCore::XPath::LogicalOp::LogicalOp): Ditto.
        (WebCore::XPath::LogicalOp::shortCircuitOn): Ditto.
        (WebCore::XPath::Predicate::evaluate): Removed an unneeded "new".

        * xpath/impl/XPathStep.h:
        * xpath/impl/XPathStep.cpp: Renamed AxisType to Axis. Removed unused axisAsString
        function and default constructor.

        * xpath/impl/XPathValue.h: Renamed the type constants to have a Value suffix,
        instead of the underscore suffix used before on NodeVector and String.
        * xpath/impl/XPathValue.cpp: Updated for name change. Added asserts.

        * xpath/impl/XPathVariableReference.cpp: (WebCore::XPath::VariableReference::doEvaluate):
        Use a reference instead of a pointer.

        * xpath/XPathEvaluator.cpp:
        * xpath/XPathEvaluator.h:
        * xpath/XPathExpression.h:
        * xpath/XPathNSResolver.cpp:
        * xpath/XPathNSResolver.h:
        * xpath/XPathNamespace.cpp:
        * xpath/XPathNamespace.h:
        * xpath/XPathResult.h:
        * xpath/impl/XPathExpressionNode.cpp:
        * xpath/impl/XPathExpressionNode.h:
        * xpath/impl/XPathPath.cpp:
        * xpath/impl/XPathPath.h:
        * xpath/impl/XPathUtil.cpp:
        * xpath/impl/XPathUtil.h:
        * xpath/impl/XPathVariableReference.h:
        Reformatted and changed includes around; no substantive changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
darin [Sun, 4 Jun 2006 22:51:57 +0000 (22:51 +0000)]
    Reviewed by Anders.

        - changed deleteAllValues so it can work on "const" collections
          Deleting the values affects the values, not the pointers in the
          collection, so it's legitimate to do it to a const collection,
          and a case of that actually came up in the XPath code.

        * wtf/HashMap.h:
        (WTF::deleteAllPairSeconds): Use const iterators.
        (WTF::deleteAllValues): Take const HashMap reference as a parameter.
        * wtf/HashSet.h:
        (WTF::deleteAllValues): Take const HashSet reference as a parameter,
        and use const iterators.
        * wtf/Vector.h:
        (WTF::deleteAllValues): Take const Vector reference as a parameter.

        - added more functions that are present in <math.h> on some platforms,
          but not on others; moved here from various files in WebCore

        * wtf/MathExtras.h:
        (isinf): Added.
        (isnan): Added.
        (lround): Added.
        (lroundf): Tweaked.
        (round): Added.
        (roundf): Tweaked.
        (signbit): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Sun, 4 Jun 2006 22:41:35 +0000 (22:41 +0000)]
LayoutTests:

        Reviewed by hyatt.

        - tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9213
          Absolutely positioned objects with relatively positioned inline
          containing blocks are rendered incorrectly

        * fast/block/positioning/absolute-in-inline-ltr-2.html: Added.
        * fast/block/positioning/absolute-in-inline-ltr-3.html: Added.
        * fast/block/positioning/absolute-in-inline-ltr.html: Added.
        * fast/block/positioning/absolute-in-inline-rtl-2.html: Added.
        * fast/block/positioning/absolute-in-inline-rtl-3.html: Added.
        * fast/block/positioning/absolute-in-inline-rtl.html: Added.
        * fast/block/positioning/absolute-in-inline-short-ltr.html: Added.
        * fast/block/positioning/absolute-in-inline-short-rtl.html: Added.

WebCore:

        Reviewed by hyatt.

        - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9213
          Absolutely positioned objects with relatively positioned inline
          containing blocks are rendered incorrectly

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::containingBlockWidthForPositioned):
        (WebCore::RenderBox::containingBlockHeightForPositioned):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteHorizontalValues):
        (WebCore::RenderBox::calcAbsoluteVertical):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
        * rendering/RenderBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitSite:
ddkilzer [Sun, 4 Jun 2006 20:37:17 +0000 (20:37 +0000)]
WebKitSite:

        Reviewed by ggaren.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9303
        JavaScript error when loading WebKit blog page

        * blog/wp-content/themes/webkit/sidebar.php: Removed unused JavaScript.  Synced with nav.inc.
        * nav.inc: Removed evil tabs--whitespace change only.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Sun, 4 Jun 2006 18:52:24 +0000 (18:52 +0000)]
WebKitTools:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9299
        Teach svn-create-patch and friends to work with binary files

        * Scripts/svn-apply: Updated to use base64-encoded text for binary files when applying patches.
        * Scripts/svn-create-patch: Updated to include binary file content as base64-encoded text in patches.
        * Scripts/svn-unapply: Updated to recognize binary files when unapplying patches.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
andersca [Sun, 4 Jun 2006 08:08:31 +0000 (08:08 +0000)]
WebCore:

2006-06-04  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
        document.evaluate and createNSResolver miss on namespaced elements

        * xpath/XPathExpression.cpp:
        (WebCore::XPathExpression::createExpression):
        Pass the resolver to the parser.

        * xpath/XPathResult.cpp:
        (WebCore::XPathResult::iterateNext):
        Fix off-by-one error.

        * xpath/impl/XPathExpressionNode.h:
        (WebCore::XPath::EvaluationContext::EvaluationContext):
        Get rid of the resolver in the evaluation context.

        * xpath/impl/XPathGrammar.y:
        Fetch the resolver from the parser. Only return the local name.

        * xpath/impl/XPathParser.cpp:
        (WebCore::XPath::Parser::parseStatement):
        * xpath/impl/XPathParser.h:
        (WebCore::XPath::Parser::resolver):
        Update to hold the resolver.

        * xpath/impl/XPathStep.cpp:
        (WebCore::XPath::Step::Step):
        If the parser has stored a namespace URI, set it.

        (WebCore::XPath::Step::nodeTestMatches):
        Check namespace URIs.

        * xpath/impl/XPathStep.h:
        Add m_namespaceURI.

LayoutTests:

2006-06-04  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
        document.evaluate and createNSResolver miss on namespaced elements

        * fast/xpath: Added.
        * fast/xpath/xpath-namespaces-expected.txt: Added.
        * fast/xpath/xpath-namespaces.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Sun, 4 Jun 2006 04:33:21 +0000 (04:33 +0000)]
LayoutTests:

        Reviewed by Eric.

        Added missing pixel test output:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8848
        TFOOT borders are copied to THEAD and TBODY

        * fast/table/border-collapsing/border-collapsing-head-foot-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Sat, 3 Jun 2006 22:23:52 +0000 (22:23 +0000)]
LayoutTests:

        Reviewed by mjs.  Tweaked and landed by ddkilzer.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
        With java disabled wrong information is displayed.

        * fast/replaced/applet-rendering-java-disabled.html: Added.
        * fast/replaced/applet-rendering-java-disabled-expected.checksum: Added.
        * fast/replaced/applet-rendering-java-disabled-expected.html: Added.
        * fast/replaced/applet-rendering-java-disabled-expected.png: Added.
        * tables/mozilla_expected_failures/bugs/bug8499-expected.checksum: Changed after removing RenderEmptyApplet.
        * tables/mozilla_expected_failures/bugs/bug8499-expected.png: Ditto.
        * tables/mozilla_expected_failures/bugs/bug8499-expected.txt: Ditto.

WebCore:

        Reviewed by mjs.  Tweaked and landed by ddkilzer.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
        With java disabled wrong information is displayed.

        Test: fast/replaced/applet-rendering-java-disabled.html

        Match WinIE, render applet content inline when java is
        disabled.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderEmptyApplet.cpp and RenderEmptyApplet.h.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::createRenderer):
        * rendering/RenderEmptyApplet.cpp: Removed.
        * rendering/RenderEmptyApplet.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
thatcher [Sat, 3 Jun 2006 20:40:14 +0000 (20:40 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9252
          REGRESSION: Very odd roll-over issues (content disappearing)

        * fast/dom/HTMLLinkElement/pending-stylesheet-count.html: Added.
        * fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.txt: Added.
        * fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png: Added.
        * fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.checksum: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9252
          REGRESSION: Very odd roll-over issues (content disappearing)

        Test: fast/dom/HTMLLinkElement/pending-stylesheet-count.html

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::~HTMLLinkElement): If the stylesheet was being
        loaded, call stylesheetLoaded() on the document, to keep the pending stylesheet
        count correct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Sat, 3 Jun 2006 20:38:22 +0000 (20:38 +0000)]
WebKitTools:

        Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9296
        Performance improvement for svn-create-patch

        * Scripts/svn-create-patch: Undef $indexPath after all paths have been fixed for a given patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix Windows build
darin [Sat, 3 Jun 2006 20:03:50 +0000 (20:03 +0000)]
    - fix Windows build

        * platform/Widget.h: Moved scaleFactor function out of Apple-specific
        section of the header into the common part.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
bdakin [Sat, 3 Jun 2006 18:37:07 +0000 (18:37 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/4537274> HiDPI: <canvas> needs to apply a
        scale. <canvas> needs to scale itself along with whatever scale
        factor is set on the window.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::createDrawingContext): Get the scale
        factor and use it to create a larger buffer and to scale the
        CGContext.
        * platform/Widget.h: Provide a new function that returns the user
        space scale factor.
        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::scaleFactor): Get the scale factor from the
        window and return it.
        * platform/win/WidgetWin.cpp:
        (WebCore::Widget::scaleFactor): Just return 1.0f for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKit:
ddkilzer [Sat, 3 Jun 2006 17:59:05 +0000 (17:59 +0000)]
WebKit:

        Reviewed by darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9290
        Teach svn-apply and svn-unapply to patch ChangeLogs cleanly

        * Scripts/svn-apply: Fixed to apply ChangeLog patches without failing.
        * Scripts/svn-unapply: Ditto.  Also simplified reversing a deletion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-03 Steve Falkenburg <sfalken@apple.com>
sfalken [Sat, 3 Jun 2006 07:16:57 +0000 (07:16 +0000)]
2006-06-03  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by hyatt.

        Removed unused code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-03 Steve Falkenburg <sfalken@apple.com>
sfalken [Sat, 3 Jun 2006 07:15:42 +0000 (07:15 +0000)]
2006-06-03  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by hyatt.

        Switch Spinneret to new hosting mechanism

        * Spinneret/Spinneret.sln:
        * Spinneret/Spinneret/Spinneret.cpp:
        (SpinneretWebHost::updateAddressBar):
        (SpinneretWebHost::QueryInterface):
        (SpinneretWebHost::AddRef):
        (SpinneretWebHost::Release):
        (resizeSubViews):
        (_tWinMain):
        (WndProc):
        (MyEditProc):
        (About):
        (loadURL):
        * Spinneret/Spinneret/Spinneret.h:
        (SpinneretWebHost::didStartProvisionalLoadForFrame):
        (SpinneretWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
        (SpinneretWebHost::didFailProvisionalLoadWithError):
        (SpinneretWebHost::didCommitLoadForFrame):
        (SpinneretWebHost::didReceiveTitle):
        (SpinneretWebHost::didReceiveIcon):
        (SpinneretWebHost::didFinishLoadForFrame):
        (SpinneretWebHost::didFailLoadWithError):
        (SpinneretWebHost::didChangeLocationWithinPageForFrame):
        (SpinneretWebHost::willPerformClientRedirectToURL):
        (SpinneretWebHost::didCancelClientRedirectForFrame):
        (SpinneretWebHost::willCloseFrame):
        (SpinneretWebHost::windowScriptObjectAvailable):
        * Spinneret/Spinneret/Spinneret.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-03 Steve Falkenburg <sfalken@apple.com>
sfalken [Sat, 3 Jun 2006 07:13:07 +0000 (07:13 +0000)]
2006-06-03  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by hyatt.

        Add implementation of loadHTMLString for Spinneret

        * COM/WebFrame.cpp:
        (WebFrame::loadHTMLString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-03 Steve Falkenburg <sfalken@apple.com>
sfalken [Sat, 3 Jun 2006 07:10:24 +0000 (07:10 +0000)]
2006-06-03  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by hyatt.

        Don't send empty referrers.  Fixes image load fail on Spinneret default content.

        * platform/win/TransferJobWin.cpp:
        (WebCore::TransferJob::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ddkilzer [Sat, 3 Jun 2006 04:56:56 +0000 (04:56 +0000)]
JavaScriptCore:

        Reviewed by ggaren.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=9234
          Implement $&, $' and $` replacement codes in String.prototype.replace

        Test: fast/js/string-replace-3.html

        * kjs/string_object.cpp:
        (substituteBackreferences): Added support for $& (matched substring),
        $` (everything preceding matched substring), $' (everything following
        matched substring) and 2-digit back references, and cleaned up a little.

LayoutTests:

        Reviewed by ggaren.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9234
          Implement $&, $' and $` replacement codes in String.prototype.replace

        * fast/js/resources/string-replace-3.js: Added.
        * fast/js/string-replace-3-expected.txt: Added.
        * fast/js/string-replace-3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
adele [Sat, 3 Jun 2006 01:41:00 +0000 (01:41 +0000)]
    Reviewed by Darin.

        Windows theme for textareas.  Also made some formatting changes.

        * rendering/RenderThemeWin.cpp:
        (WebCore::RenderThemeWin::supportsFocus):
        (WebCore::RenderThemeWin::getThemeData):
        (WebCore::RenderThemeWin::adjustButtonStyle):
        (WebCore::RenderThemeWin::adjustTextFieldStyle):
        (WebCore::RenderThemeWin::adjustTextAreaStyle):
        (WebCore::RenderThemeWin::paintTextArea):
        * rendering/RenderThemeWin.h:
        (WebCore::RenderThemeWin::supportsHover):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt, checked in by Tim H.
thatcher [Sat, 3 Jun 2006 01:28:25 +0000 (01:28 +0000)]
    Reviewed by Hyatt, checked in by Tim H.

        Explicitly run perl on *.pl files instead of relying
        on Windows shell figuring out which program to run for
        this extention.

        * DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
adele [Sat, 3 Jun 2006 01:16:33 +0000 (01:16 +0000)]
    Reviewed by Darin.

        Set incremental linking to no. This seems to fix a build problem I was seeing
        where dftables couldn't find a dll.

        * JavaScriptCore.vcproj/dftables/dftables.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
thatcher [Sat, 3 Jun 2006 01:15:11 +0000 (01:15 +0000)]
LayoutTests:

        Reviewed by Hyatt, checked in by Tim H.

        For: http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
        Added test case to test opacity layers, in particular, opacities
        with a value of zero.

       * fast/css/ZeroOpacityLayers.html: Added.
       * fast/css/ZeroOpacityLayers-expected.txt: Added.
       * fast/css/ZeroOpacityLayers-expected.png: Added.
       * fast/css/ZeroOpacityLayers-expected.checksum: Added.
       * fast/css/ZeroOpacityLayers2.html: Added.
       * fast/css/ZeroOpacityLayers2-expected.txt: Added.
       * fast/css/ZeroOpacityLayers2-expected.png: Added.
       * fast/css/ZeroOpacityLayers2-expected.checksum: Added.

WebCore:

        Reviewed by Hyatt, checked in by Tim H.

        fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
        Changed RenderLayer to only render layers that are not
        totally transparent.

        * rendering/RenderLayer.cpp
        (RenderLayer::paintLayer):
        Changed function to also check if the layer is totally transparent
        and if it is, don't bother painting it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
thatcher [Sat, 3 Jun 2006 00:52:34 +0000 (00:52 +0000)]
LayoutTests:

        Reviewed by Hyatt, checked in by Tim H.

        Adding testcase for bug 8223.

        * fast/dom/css-inline-style-important-expected.checksum: Added.
        * fast/dom/css-inline-style-important-expected.png: Added.
        * fast/dom/css-inline-style-important-expected.txt: Added.
        * fast/dom/css-inline-style-important.html: Added.

WebCore:

        Reviewed by Hyatt, checked in by Tim H.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8223
        WebKit fails to update style on element via DOM

        Handle !important by detecting it and using a different code
        path from normal priority.

        * bindings/js/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclaration::put):
        * css/CSSStyleDeclaration.cpp:
        (WebCore::CSSStyleDeclaration::setProperty):
        * css/CSSStyleDeclaration.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff, checked in by Maciej.
mjs [Sat, 3 Jun 2006 00:19:02 +0000 (00:19 +0000)]
    Reviewed by Geoff, checked in by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9236
        REGRESSION: focus method does not work on some elements before they are laid out

        * dom/Element.cpp: (WebCore::Element::focus): Do the updateLayout call before
        calling isFocusable, since isFocusable looks at the size of the renderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-02 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 2 Jun 2006 19:35:26 +0000 (19:35 +0000)]
2006-06-02  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by darin.

        Updated build script

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-02 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 2 Jun 2006 19:35:01 +0000 (19:35 +0000)]
2006-06-02  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by darin.

        Updated to latest hosting interface

        * WebFramePrivate.cpp:
        (WebKit::WebFramePrivate::openURL):
        (WebKit::WebFramePrivate::setTitle):
        (WebKit::WebFramePrivate::setStatusText):
        * WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-02 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 2 Jun 2006 19:34:27 +0000 (19:34 +0000)]
2006-06-02  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by darin.

        Platform hookup fixes

        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::urlSelected):
        (WebCore::FrameWin::setTitle):
        (WebCore::FrameWin::setStatusBarText):
        * bridge/win/FrameWin.h:
        * platform/win/TemporaryLinkStubs.cpp:
        (FrameWin::overrideMediaType):
        * platform/win/TransferJobWin.cpp:
        (WebCore::TransferJobWndProc):
        (WebCore::TransferJob::start):
        (WebCore::TransferJob::fileLoadTimer):
        (WebCore::TransferJob::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-06-02 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 2 Jun 2006 19:32:33 +0000 (19:32 +0000)]
2006-06-02  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by darin.

        New hosting for Spinneret to avoid static linking

        * COM: Added.
        * COM/Interfaces: Added.
        * COM/Interfaces/DOMCSS.idl: Added.
        * COM/Interfaces/DOMCore.idl: Added.
        * COM/Interfaces/DOMHTML.idl: Added.
        * COM/Interfaces/DOMRange.idl: Added.
        * COM/Interfaces/IWebArchive.idl: Added.
        * COM/Interfaces/IWebAttributedString.idl: Added.
        * COM/Interfaces/IWebBackForwardList.idl: Added.
        * COM/Interfaces/IWebDataSource.idl: Added.
        * COM/Interfaces/IWebDocument.idl: Added.
        * COM/Interfaces/IWebDownload.idl: Added.
        * COM/Interfaces/IWebEditingDelegate.idl: Added.
        * COM/Interfaces/IWebError.idl: Added.
        * COM/Interfaces/IWebFrame.idl: Added.
        * COM/Interfaces/IWebFrameLoadDelegate.idl: Added.
        * COM/Interfaces/IWebFrameView.idl: Added.
        * COM/Interfaces/IWebHistoryItem.idl: Added.
        * COM/Interfaces/IWebIconDatabase.idl: Added.
        * COM/Interfaces/IWebImage.idl: Added.
        * COM/Interfaces/IWebMutableURLRequest.idl: Added.
        * COM/Interfaces/IWebNotification.idl: Added.
        * COM/Interfaces/IWebPolicyDelegate.idl: Added.
        * COM/Interfaces/IWebPreferences.idl: Added.
        * COM/Interfaces/IWebResource.idl: Added.
        * COM/Interfaces/IWebResourceLoadDelegate.idl: Added.
        * COM/Interfaces/IWebScriptObject.idl: Added.
        * COM/Interfaces/IWebUIDelegate.idl: Added.
        * COM/Interfaces/IWebURLAuthenticationChallenge.idl: Added.
        * COM/Interfaces/IWebURLRequest.idl: Added.
        * COM/Interfaces/IWebURLResponse.idl: Added.
        * COM/Interfaces/IWebUndoManager.idl: Added.
        * COM/Interfaces/IWebView.idl: Added.
        * COM/Interfaces/WebKit.idl: Added.
        * COM/WebBackForwardList.cpp: Added.
        (WebBackForwardList::WebBackForwardList):
        (WebBackForwardList::~WebBackForwardList):
        (WebBackForwardList::createInstance):
        (WebBackForwardList::QueryInterface):
        (WebBackForwardList::AddRef):
        (WebBackForwardList::Release):
        (WebBackForwardList::addItem):
        (WebBackForwardList::goBack):
        (WebBackForwardList::goForward):
        (WebBackForwardList::goToItem):
        (WebBackForwardList::backItem):
        (WebBackForwardList::currentItem):
        (WebBackForwardList::forwardItem):
        (WebBackForwardList::backListWithLimit):
        (WebBackForwardList::forwardListWithLimit):
        (WebBackForwardList::capacity):
        (WebBackForwardList::setCapacity):
        (WebBackForwardList::backListCount):
        (WebBackForwardList::forwardListCount):
        (WebBackForwardList::containsItem):
        (WebBackForwardList::itemAtIndex):
        (WebBackForwardList::setPageCacheSize):
        (WebBackForwardList::pageCacheSize):
        * COM/WebBackForwardList.h: Added.
        * COM/WebDataSource.cpp: Added.
        (WebDataSource::WebDataSource):
        (WebDataSource::~WebDataSource):
        (WebDataSource::createInstance):
        (WebDataSource::QueryInterface):
        (WebDataSource::AddRef):
        (WebDataSource::Release):
        (WebDataSource::initWithRequest):
        (WebDataSource::data):
        (WebDataSource::representation):
        (WebDataSource::webFrame):
        (WebDataSource::initialRequest):
        (WebDataSource::request):
        (WebDataSource::response):
        (WebDataSource::textEncodingName):
        (WebDataSource::isLoading):
        (WebDataSource::pageTitle):
        (WebDataSource::unreachableURL):
        (WebDataSource::webArchive):
        (WebDataSource::mainResource):
        (WebDataSource::subresources):
        (WebDataSource::subresourceForURL):
        (WebDataSource::addSubresource):
        * COM/WebDataSource.h: Added.
        * COM/WebFrame.cpp: Added.
        (WebFrame::WebFramePrivate::WebFramePrivate):
        (WebFrame::WebFramePrivate::~WebFramePrivate):
        (WebFrame::WebFrame):
        (WebFrame::~WebFrame):
        (WebFrame::createInstance):
        (WebFrame::QueryInterface):
        (WebFrame::AddRef):
        (WebFrame::Release):
        (WebFrame::initWithName):
        (WebFrame::name):
        (WebFrame::webView):
        (WebFrame::frameView):
        (WebFrame::DOMDocument):
        (WebFrame::frameElement):
        (WebFrame::loadRequest):
        (WebFrame::loadData):
        (WebFrame::loadHTMLString):
        (WebFrame::loadAlternateHTMLString):
        (WebFrame::loadArchive):
        (WebFrame::dataSource):
        (WebFrame::provisionalDataSource):
        (WebFrame::stopLoading):
        (WebFrame::reload):
        (WebFrame::findFrameNamed):
        (WebFrame::parentFrame):
        (WebFrame::childFrames):
        (WebFrame::paint):
        (WebFrame::impl):
        (WebFrame::loadDataSource):
        (WebFrame::loading):
        (WebFrame::goToItem):
        (WebFrame::loadItem):
        (WebSystemMainMemory):
        (WebFrame::getObjectCacheSize):
        (WebFrame::receivedRedirect):
        (WebFrame::receivedResponse):
        (WebFrame::receivedData):
        (WebFrame::receivedAllData):
        (WebFrame::openURL):
        (WebFrame::submitForm):
        (WebFrame::setTitle):
        (WebFrame::setStatusText):
        * COM/WebFrame.h: Added.
        * COM/WebHistoryItem.cpp: Added.
        (WebHistoryItem::WebHistoryItem):
        (WebHistoryItem::~WebHistoryItem):
        (WebHistoryItem::createInstance):
        (WebHistoryItem::QueryInterface):
        (WebHistoryItem::AddRef):
        (WebHistoryItem::Release):
        (WebHistoryItem::initWithURLString):
        (WebHistoryItem::originalURLString):
        (WebHistoryItem::URLString):
        (WebHistoryItem::title):
        (WebHistoryItem::lastVisitedTimeInterval):
        (WebHistoryItem::setAlternateTitle):
        (WebHistoryItem::alternateTitle):
        (WebHistoryItem::icon):
        * COM/WebHistoryItem.h: Added.
        * COM/WebIconDatabase.cpp: Added.
        (WebIconDatabase::WebIconDatabase):
        (WebIconDatabase::~WebIconDatabase):
        (WebIconDatabase::createInstance):
        (WebIconDatabase::QueryInterface):
        (WebIconDatabase::AddRef):
        (WebIconDatabase::Release):
        (WebIconDatabase::sharedIconDatabase):
        (WebIconDatabase::iconForURL):
        (WebIconDatabase::defaultIconWithSize):
        (WebIconDatabase::retainIconForURL):
        (WebIconDatabase::releaseIconForURL):
        (WebIconDatabase::delayDatabaseCleanup):
        (WebIconDatabase::allowDatabaseCleanup):
        * COM/WebIconDatabase.h: Added.
        * COM/WebKitClassFactory.cpp: Added.
        (WebKitClassFactory::WebKitClassFactory):
        (WebKitClassFactory::~WebKitClassFactory):
        (WebKitClassFactory::QueryInterface):
        (WebKitClassFactory::AddRef):
        (WebKitClassFactory::Release):
        (WebKitClassFactory::CreateInstance):
        (WebKitClassFactory::LockServer):
        * COM/WebKitClassFactory.h: Added.
        * COM/WebKitDLL.cpp: Added.
        (DllMain):
        (DllGetClassObject):
        (DllCanUnloadNow):
        (DllUnregisterServer):
        (DllRegisterServer):
        * COM/WebKitDLL.h: Added.
        * COM/WebMutableURLRequest.cpp: Added.
        (WebMutableURLRequest::WebMutableURLRequest):
        (WebMutableURLRequest::~WebMutableURLRequest):
        (WebMutableURLRequest::createInstance):
        (WebMutableURLRequest::QueryInterface):
        (WebMutableURLRequest::AddRef):
        (WebMutableURLRequest::Release):
        (WebMutableURLRequest::requestWithURL):
        (WebMutableURLRequest::allHTTPHeaderFields):
        (WebMutableURLRequest::cachePolicy):
        (WebMutableURLRequest::HTTPBody):
        (WebMutableURLRequest::HTTPBodyStream):
        (WebMutableURLRequest::HTTPMethod):
        (WebMutableURLRequest::HTTPShouldHandleCookies):
        (WebMutableURLRequest::initWithURL):
        (WebMutableURLRequest::mainDocumentURL):
        (WebMutableURLRequest::timeoutInterval):
        (WebMutableURLRequest::URL):
        (WebMutableURLRequest::valueForHTTPHeaderField):
        (WebMutableURLRequest::addValue):
        (WebMutableURLRequest::setAllHTTPHeaderFields):
        (WebMutableURLRequest::setCachePolicy):
        (WebMutableURLRequest::setHTTPBody):
        (WebMutableURLRequest::setHTTPBodyStream):
        (WebMutableURLRequest::setHTTPMethod):
        (WebMutableURLRequest::setHTTPShouldHandleCookies):
        (WebMutableURLRequest::setMainDocumentURL):
        (WebMutableURLRequest::setTimeoutInterval):
        (WebMutableURLRequest::setURL):
        (WebMutableURLRequest::setValue):
        (WebMutableURLRequest::setFormData):
        (WebMutableURLRequest::formData):
        * COM/WebMutableURLRequest.h: Added.
        * COM/WebView.cpp: Added.
        (WebView::WebView):
        (WebView::~WebView):
        (WebView::createInstance):
        (WebView::mouseMoved):
        (WebView::mouseDown):
        (WebView::mouseUp):
        (WebView::mouseDoubleClick):
        (WebView::keyPress):
        (registerWebView):
        (WebViewWndProc):
        (calculateScrollDelta):
        (scrollMessageForKey):
        (WebView::goToItem):
        (WebView::QueryInterface):
        (WebView::AddRef):
        (WebView::Release):
        (WebView::canShowMIMEType):
        (WebView::canShowMIMETypeAsHTML):
        (WebView::MIMETypesShownAsHTML):
        (WebView::setMIMETypesShownAsHTML):
        (WebView::URLFromPasteboard):
        (WebView::URLTitleFromPasteboard):
        (WebView::initWithFrame):
        (WebView::setUIDelegate):
        (WebView::uiDelegate):
        (WebView::setResourceLoadDelegate):
        (WebView::resourceLoadDelegate):
        (WebView::setDownloadDelegate):
        (WebView::downloadDelegate):
        (WebView::setFrameLoadDelegate):
        (WebView::frameLoadDelegate):
        (WebView::setPolicyDelegate):
        (WebView::policyDelegate):
        (WebView::mainFrame):
        (WebView::backForwardList):
        (WebView::setMaintainsBackForwardList):
        (WebView::goBack):
        (WebView::goForward):
        (WebView::goToBackForwardItem):
        (WebView::setTextSizeMultiplier):
        (WebView::textSizeMultiplier):
        (WebView::setApplicationNameForUserAgent):
        (WebView::applicationNameForUserAgent):
        (WebView::setCustomUserAgent):
        (WebView::customUserAgent):
        (WebView::userAgentForURL):
        (WebView::supportsTextEncoding):
        (WebView::setCustomTextEncodingName):
        (WebView::customTextEncodingName):
        (WebView::setMediaStyle):
        (WebView::mediaStyle):
        (WebView::stringByEvaluatingJavaScriptFromString):
        (WebView::windowScriptObject):
        (WebView::setPreferences):
        (WebView::preferences):
        (WebView::setPreferencesIdentifier):
        (WebView::preferencesIdentifier):
        (WebView::setHostWindow):
        (WebView::hostWindow):
        (WebView::searchFor):
        (WebView::registerViewClass):
        (WebView::takeStringURLFrom):
        (WebView::stopLoading):
        (WebView::reload):
        (WebView::canGoBack):
        (WebView::canGoForward):
        (WebView::canMakeTextLarger):
        (WebView::makeTextLarger):
        (WebView::canMakeTextSmaller):
        (WebView::makeTextSmaller):
        (WebView::computedStyleForElement):
        (WebView::editableDOMRangeForPoint):
        (WebView::setSelectedDOMRange):
        (WebView::selectedDOMRange):
        (WebView::selectionAffinity):
        (WebView::setEditable):
        (WebView::isEditable):
        (WebView::setTypingStyle):
        (WebView::typingStyle):
        (WebView::setSmartInsertDeleteEnabled):
        (WebView::smartInsertDeleteEnabled):
        (WebView::setContinuousSpellCheckingEnabled):
        (WebView::isContinuousSpellCheckingEnabled):
        (WebView::spellCheckerDocumentTag):
        (WebView::undoManager):
        (WebView::setEditingDelegate):
        (WebView::editingDelegate):
        (WebView::styleDeclarationWithText):
        (WebView::replaceSelectionWithNode):
        (WebView::replaceSelectionWithText):
        (WebView::replaceSelectionWithMarkupString):
        (WebView::replaceSelectionWithArchive):
        (WebView::deleteSelection):
        (WebView::applyStyle):
        (WebView::copy):
        (WebView::cut):
        (WebView::paste):
        (WebView::copyFont):
        (WebView::pasteFont):
        (WebView::delete_):
        (WebView::pasteAsPlainText):
        (WebView::pasteAsRichText):
        (WebView::changeFont):
        (WebView::changeAttributes):
        (WebView::changeDocumentBackgroundColor):
        (WebView::changeColor):
        (WebView::alignCenter):
        (WebView::alignJustified):
        (WebView::alignLeft):
        (WebView::alignRight):
        (WebView::checkSpelling):
        (WebView::showGuessPanel):
        (WebView::performFindPanelAction):
        (WebView::startSpeaking):
        (WebView::stopSpeaking):
        (WebView::viewWindow):
        * COM/WebView.h: Added.
        * WebKit.vcproj: Added.
        * WebKit.vcproj/Interfaces.vcproj: Added.
        * WebKit.vcproj/WebKit.def: Added.
        * WebKit.vcproj/WebKit.rc: Added.
        * WebKit.vcproj/WebKit.sln: Added.
        * WebKit.vcproj/WebKit.vcproj: Added.
        * WebKit.vcproj/WebKitGUID.vcproj: Added.
        * WebKit.vcproj/autoversion.h: Added.
        * WebKit.vcproj/resource.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Fri, 2 Jun 2006 17:24:41 +0000 (17:24 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3379
          attr(X) does not work

        * fast/css-generated-content/016-expected.checksum: Added.
        * fast/css-generated-content/016-expected.png: Added.
        * fast/css-generated-content/016-expected.txt: Added.
        * fast/css-generated-content/016.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3379
          attr(X) does not work

        Test: fast/css-generated-content/016.html

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::canShareStyleWithElement): Don't share style
        if the unique bit is set.
        (WebCore::CSSStyleSelector::applyProperty): When applying the "attr" property,
        set the unique bit and add to m_selectorAttrs.

        * rendering/render_style.cpp: Did a lot of reformatting, and this one real change.
        (WebCore::RenderStyle::RenderStyle): Initialize m_unique to false.

        * rendering/render_style.h:
        (WebCore::RenderStyle::unique): Added. Returns value of m_unique.
        (WebCore::RenderStyle::setUnique): Added. Sets m_unique.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
darin [Fri, 2 Jun 2006 16:39:35 +0000 (16:39 +0000)]
    Reviewed by Anders.

        Updated test so that is will once again exercise the fix for
        http://bugzilla.opendarwin.org/show_bug.cgi?id=9009

        * fast/table/empty-section-crash-expected.txt:
        * fast/table/empty-section-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ddkilzer [Fri, 2 Jun 2006 09:50:12 +0000 (09:50 +0000)]
LayoutTests:

        Reviewed by mjs.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
        Finish renaming of RenderCanvas to RenderView

        * editing/selection/7152-1-expected.checksum: Layout changed due to text change in HTML file.
        * editing/selection/7152-1-expected.png: Ditto.
        * editing/selection/7152-1-expected.txt: Ditto.
        * editing/selection/7152-1.html: Changed text in HTML content.
        * editing/selection/7152-2-expected.checksum: Layout changed due to text change in HTML file.
        * editing/selection/7152-2-expected.png: Ditto.
        * editing/selection/7152-2-expected.txt: Ditto.
        * editing/selection/7152-2.html: Changed text in HTML content.
        * *-expected.txt: Replaced "RenderCanvas" with "RenderView" in 3023 more files.

WebCore:

        Reviewed by mjs.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
        Finish renaming of RenderCanvas to RenderView

        * rendering/RenderView.h: Changed renderName from "RenderCanvas" to "RenderView".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * WebCoreSupport/WebImageRendererFactory.m: Fix crash on Safari startup
darin [Fri, 2 Jun 2006 07:29:29 +0000 (07:29 +0000)]
    * WebCoreSupport/WebImageRendererFactory.m: Fix crash on Safari startup
        by include NSObject as a superclass (oops!).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - try to fix Windows build
darin [Fri, 2 Jun 2006 06:59:34 +0000 (06:59 +0000)]
    - try to fix Windows build

        * bridge/win/FrameWin.cpp: Added include of Decoder.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@14682 268f45cc-cd09-0410-ab3c-d52691b4dbfc