WebKit-https.git
11 years ago2009-05-20 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 20 May 2009 11:38:12 +0000 (11:38 +0000)]
2009-05-20  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Eric Seidel.

        Fix GTK debug build.

        The function dumpDisjunction, compiled with debug enabled, uses
        printf, which needs stdio.h to be included.

        * yarr/RegexInterpreter.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 20 May 2009 11:30:05 +0000 (11:30 +0000)]
2009-05-20  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Rubber-stamped by Xan Lopez.

        Remove misplaced extern "C"

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-20 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 20 May 2009 11:16:01 +0000 (11:16 +0000)]
2009-05-20  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [GTK] Expose password field with role of PASSWORD_TEXT
        https://bugs.webkit.org/show_bug.cgi?id=25682

        Check if input type is a password field and return
        ATK_ROLE_PASSWORD_TEXT if it is.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
ariya@webkit.org [Wed, 20 May 2009 10:09:01 +0000 (10:09 +0000)]
2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by George Staikos.

        BUG 25845: [Qt] Fix QtWebKit pkgconfig dependencies
        <https://bugs.webkit.org/show_bug.cgi?id=25845>

        * WebCore.pro: Remove QtDBus; remove QtXml if Qt >= 4.4

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-20 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 20 May 2009 10:08:07 +0000 (10:08 +0000)]
2009-05-20  Eric Seidel  <eric@webkit.org>

        Build fix only, no review.

        Remove dragging subtest from 43890 which used ? char

        ? is a reserved char on Windows. After removing both the ü and now the ? this
        subtest is now useless, so I'm removing it entirely.

        * editing/pasteboard/file-input-files-access-expected.txt:
        * editing/pasteboard/resources/File With Spaces! For Dragging?.gif: Removed.
        * editing/pasteboard/resources/file-input-files-access.js:
        (runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
ariya@webkit.org [Wed, 20 May 2009 09:58:12 +0000 (09:58 +0000)]
2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by George Staikos.

        BUG 25843: [Qt] Remove qt-port build flag
        <https://bugs.webkit.org/show_bug.cgi?id=25843>

        * bridge/testbindings.pro:

        * JavaScriptCore.pro:

        * DumpRenderTree/qt/DumpRenderTree.pro:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-20 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 20 May 2009 09:49:09 +0000 (09:49 +0000)]
2009-05-20  Eric Seidel  <eric@webkit.org>

        Build fix only, no review.

        Fix windows and tiger builds after r43890

        Commit r43890 caused:
        svn: Can't convert string from 'UTF-8' to native encoding:
        svn: LayoutTests/editing/pasteboard/resources/File With Spaces! For Dra?\204?\136gging?.gif
        On both the windows and tiger buildbots.  According to:
        http://svnbook.red-bean.com/en/1.2/svn.advanced.l10n.html
        this is intentional behavior, and due to the fact that the default
        LC_CTYPE for Tiger and Windows makes Subversion think the filesystems
        do not support utf8.

        The fix would be to execute:
        export LC_CTYPE=en_US.UTF-8
        On all affected machines.  But since that's not going to happen,
        I'm removing the utf8 chars from this filename.

        This makes the drag-drop test weaker, but I see no other option.

        * editing/pasteboard/resources/File With Spaces! For Dragging?.gif: Renamed from "LayoutTests/editing/pasteboard/resources/File With Spaces! For Dra\314\210gging?.gif".
        * editing/pasteboard/resources/file-input-files-access.js:
        (moveMouseToCenterOfElement): use the unused argument
        (runTest): fix to use the ansii name

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
ariya@webkit.org [Wed, 20 May 2009 09:02:25 +0000 (09:02 +0000)]
2009-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by George Staikos.

        https://bugs.webkit.org/show_bug.cgi?id=25824

        [Qt] Cleanup - move files exclusive to JAVASCRIPT_DEBUGGER
        and WORKERS under the appropriate build section

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-20 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Wed, 20 May 2009 08:40:46 +0000 (08:40 +0000)]
2009-05-20  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Unreviewed Qt build fix, after r43892.

        * platform/graphics/qt/ImageQt.cpp: included ImageObservser.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-20 Yongjun Zhang <yongjun.zhang@nokia.com>
hausmann@webkit.org [Wed, 20 May 2009 08:22:23 +0000 (08:22 +0000)]
2009-05-20  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Simon Hausmann.

        https://bugs.webkit.org/show_bug.cgi?id=25856
        [Qt] notify an image has been drawn, to help Cache purge alive decoded data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-20 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 20 May 2009 07:32:54 +0000 (07:32 +0000)]
2009-05-20  Darin Adler  <darin@apple.com>

        Removed stray file left after some check-ins earlier today.

        * fast/tokenizer/preload-scanner-entities.html-disabled: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 20 May 2009 07:32:26 +0000 (07:32 +0000)]
2009-05-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Oliver Hunt.

        Remove layoutTestController.addFileToPasteboardOnDrag and add eventSender.beginDragWithFiles
        https://bugs.webkit.org/show_bug.cgi?id=25852

        This allows us to now test multi-file file drags in DumpRenderTree per:
        https://bugs.webkit.org/show_bug.cgi?id=25862

        I removed the existing tests using addFileToPasteboardOnDrag()
        and replaced them with a new test (editing/pasteboard/file-input-files-access)
        which covers several more drag-drop cases.

        I added a DumpRenderTreeFileDraggingSource class to avoid
        the hack of if (!draggingSource) in [DumpRenderTreeDraggingInfo draggingSourceOperationMask]

        New Test: editing/pasteboard/file-input-files-access.html

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/DumpRenderTreeFileDraggingSource.h: Added.
        * DumpRenderTree/DumpRenderTreeFileDraggingSource.m: Added.
        (-[DumpRenderTreeFileDraggingSource draggingSourceOperationMaskForLocal:]):
        * DumpRenderTree/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::staticValues): removed addFileToPasteboardOnDrag support
        (LayoutTestController::staticFunctions): removed addFileToPasteboardOnDrag support
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        (runTest): ASSERT that draggingInfo has been cleared
        * DumpRenderTree/mac/EventSendingController.mm:
        (+[EventSendingController isSelectorExcludedFromWebScript:]): Sorted selectors.
        (+[EventSendingController webScriptNameForSelector:]): Sorted selectors.
        (-[EventSendingController beginDragWithFiles:]):
        (-[EventSendingController mouseMoveToX:Y:]):
        (-[EventSendingController keyDown:withModifiers:]):
        (-[EventSendingController fireKeyboardEventsToElement:]): removed spurious { }
        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]): removed addFileToPasteboardOnDrag support

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-20 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 20 May 2009 07:24:17 +0000 (07:24 +0000)]
2009-05-20  David Levin  <levin@chromium.org>

        Reviewed by NOBODY, layout tests fix.

        https://bugs.webkit.org/show_bug.cgi?id=23727
        This reverts commit r43888.

        Once that change was checked in many of the fast/flexbox0*.html
        tests (and others) started failing.

        * WebCore.pro:
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/CSSPropertyNames.in:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * css/CSSValueKeywords.in:
        * rendering/RenderMarquee.cpp:
        (WebCore::RenderMarquee::updateMarqueePosition):
        (WebCore::RenderMarquee::timerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>
staikos@webkit.org [Wed, 20 May 2009 04:32:59 +0000 (04:32 +0000)]
2009-05-19  Yichao Yin  <yichao.yin@torchmobile.com.cn>

        Reviewed by George Staikos.

        Add WCSS marquee extension support to Webkit
        refer to the specification: WAP-239-WCSS-20011026-a.pdf

        Since WCSS is the companion of XHTML Mobile Profile (XHTML MP),
        this change depends on https://bugs.webkit.org/show_bug.cgi?id=23452

        https://bugs.webkit.org/show_bug.cgi?id=23727

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>
staikos@webkit.org [Wed, 20 May 2009 03:49:40 +0000 (03:49 +0000)]
2009-05-19  Yichao Yin  <yichao.yin@torchmobile.com.cn>

        Reviewed by George Staikos.

        Add tests for WCSS marquee extension support
        https://bugs.webkit.org/show_bug.cgi?id=23727

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 20 May 2009 03:31:55 +0000 (03:31 +0000)]
2009-05-19  Geoffrey Garen  <ggaren@apple.com>

        Windows build fix.

        * interpreter/RegisterFile.cpp:
        (JSC::RegisterFile::releaseExcessCapacity): Copy-paste typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 20 May 2009 03:25:47 +0000 (03:25 +0000)]
2009-05-19  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Fixed <rdar://problem/6885680> CrashTracer: [USER] 1 crash in Install
        Mac OS X at <unknown binary> • 0x9274241c

        (Original patch by Joe Sokol and Ronnie Misra.)

        SunSpider says 1.004x faster.

        * interpreter/RegisterFile.cpp:
        (JSC::RegisterFile::releaseExcessCapacity): Instead of doing complicated
        math that sometimes used to overflow, just release the full range of the
        register file.

        * interpreter/RegisterFile.h:
        (JSC::isPageAligned):
        (JSC::RegisterFile::RegisterFile): Added ASSERTs to verify that it's
        safe to release the full range of the register file.

        (JSC::RegisterFile::shrink): No need to releaseExcessCapacity() if the
        new end is not smaller than the old end. (Also, doing so used to cause
        numeric overflow, unmapping basically the whole process from memory.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 20 May 2009 03:02:17 +0000 (03:02 +0000)]
2009-05-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Roben.

        Make PrettyPatch understand quoted filenames in git diffs.
        https://bugs.webkit.org/show_bug.cgi?id=25881

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>
staikos@webkit.org [Wed, 20 May 2009 02:02:43 +0000 (02:02 +0000)]
2009-05-19  Yichao Yin <yichao.yin@torchmobile.com.cn>

        Reviewed by George Staikos.

        Add XHTMLMP support to Webkit
        Update the configure files for building XHTMLMP-enabled WebKit on different platform
        https://bugs.webkit.org/show_bug.cgi?id=23452

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6888393> REGRESSION: Start Debugging JavaScript crashes browser ...
oliver@apple.com [Wed, 20 May 2009 01:18:05 +0000 (01:18 +0000)]
<rdar://problem/6888393> REGRESSION: Start Debugging JavaScript crashes browser (nightly builds only?)
<https://bugs.webkit.org/show_bug.cgi?id=25717>

RS=Mark Rowe.

Remove JSC_FAST_CALL as it wasn't gaining us anything, and was
resulting in weird bugs in the nightly builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
antti@apple.com [Wed, 20 May 2009 00:44:26 +0000 (00:44 +0000)]
WebCore:

2009-05-19  Antti Koivisto  <antti@apple.com>

        I can't figure out how to make this not timing dependent, making it manual test instead.

        * manual-tests/preload-scanner-entities.html: Added.

LayoutTests:

2009-05-19  Antti Koivisto  <antti@apple.com>

        I can't figure out how to make this not timing dependent, making it manual test instead.

        * fast/tokenizer/preload-scanner-entities-expected.txt: Removed.
        * fast/tokenizer/preload-scanner-entities.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 20 May 2009 00:43:16 +0000 (00:43 +0000)]
2009-05-19  Darin Adler  <darin@apple.com>

        Renamed test failing on many buildbots to disable it.
        Antti can move it back once he gets it working more consistently.

        * fast/tokenizer/preload-scanner-entities.html: Removed.
        * fast/tokenizer/preload-scanner-entities.html-disabled: Copied from fast/tokenizer/preload-scanner-entities.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 19 May 2009 23:41:15 +0000 (23:41 +0000)]
2009-05-19  Brady Eidson  <beidson@apple.com>

        Reviewed by Antti Koivisto.

        <rdar://problem/6886382> REGRESSION (Safari 4PB -> ToT): HTTP cache revalidation broken.

        This was caused in http://trac.webkit.org/changeset/41425, which fixed an image caching bug
        in QuickLooks (rdar://problem/6619630).

        We need to respect the DocumentLoader's request cache policy when deciding the cache policy
        for subresources, but the check (originally removed in r39304 and added back in in the same
        place in r41424) needs to be tweaked and relocated a bit.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::subresourceCachePolicy): Renamed from cachePolicy().  Move checking
          the DocumentLoader's request to a more appropriate place. Add code to handle the recently
          added FIXME regarding POSTs. Add a new FIXME describing a great way to make this code
          cleaner in the future.
        * loader/FrameLoader.h:

        * loader/DocLoader.cpp:
        (WebCore::DocLoader::cachePolicy): Calls the newly renamed subresourceCachePolicy().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25872: aria-labeledby appends all siblings instead of all children to aria name
cfleizach@apple.com [Tue, 19 May 2009 22:31:32 +0000 (22:31 +0000)]
Bug 25872: aria-labeledby appends all siblings instead of all children to aria name
https://bugs.webkit.org/show_bug.cgi?id=25872

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
antti@apple.com [Tue, 19 May 2009 21:57:01 +0000 (21:57 +0000)]
WebCore:

2009-05-19  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin Adler).

        <rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)

        Push characters back in correct order when entity parsing fails after 3 characters.

        Test: fast/tokenizer/preload-scanner-entities.html

        * html/PreloadScanner.cpp:
        (WebCore::PreloadScanner::consumeEntity):

LayoutTests:

2009-05-19  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6902674> REGRESSION: Query parameters are sometimes incorrect in URL (23135)

        * fast/tokenizer/preload-scanner-entities-expected.txt: Added.
        * fast/tokenizer/preload-scanner-entities.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Paul Godavari <paul@chromium.org>
dglazkov@chromium.org [Tue, 19 May 2009 21:13:31 +0000 (21:13 +0000)]
2009-05-19  Paul Godavari  <paul@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix a crash in Mac Chromium when displaying an HTML select element
        with no items.
        https://bugs.webkit.org/show_bug.cgi?id=25874

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::showExternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowxMSW build fixes for DRT.
kevino@webkit.org [Tue, 19 May 2009 20:54:33 +0000 (20:54 +0000)]
wxMSW build fixes for DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRestore mistaken deletion of an entry in ChangeLog
darin@chromium.org [Tue, 19 May 2009 20:53:49 +0000 (20:53 +0000)]
Restore mistaken deletion of an entry in ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Nate Chapin <japhet@google.com>
darin@chromium.org [Tue, 19 May 2009 20:51:45 +0000 (20:51 +0000)]
2009-05-19  Nate Chapin  <japhet@google.com>

        Reviewed by Darin Fisher.

        Upstream V8 bindings for CanvasRenderingContext2D.
        https://bugs.webkit.org/show_bug.cgi?id=25858

        * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp: Moved bindings from v8_custom.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Jessie Berlin <jberlin@apple.com>
mrowe@apple.com [Tue, 19 May 2009 20:46:02 +0000 (20:46 +0000)]
2009-05-19  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Mark Rowe.

        Windows Build Fix.

        * WebCore.vcproj/WebCore.vcproj: Copy accessibility headers from WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a new private API method that will dispatch pending loads that have been schedule...
timothy@apple.com [Tue, 19 May 2009 19:18:36 +0000 (19:18 +0000)]
Add a new private API method that will dispatch pending loads that have been scheduled because of recent DOM additions or style changes.

<rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not loaded because willSendRequest doesn't happen immediately

WebCore:

2009-05-19  Timothy Hatcher  <timothy@apple.com>

        <rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
        loaded because willSendRequest doesn't happen immediately

        Reviewed by Antti Koivisto.

        * WebCore.base.exp: Export Loader::servePendingRequests().

WebKit/mac:

2009-05-19  Timothy Hatcher  <timothy@apple.com>

        Add a new private API method that will dispatch pending loads that have been scheduled
        because of recent DOM additions or style changes.

        <rdar://problem/6889218> REGRESSION: Some iChat transcript resources are not
        loaded because willSendRequest doesn't happen immediately

        Reviewed by Antti Koivisto.

        * WebView/WebView.mm:
        (-[WebView _dispatchPendingLoadRequests]): Call Loader::servePendingRequests().
        * WebView/WebViewPrivate.h: Added _dispatchPendingLoadRequests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 David Levin <levin@chromium.org>
levin@chromium.org [Tue, 19 May 2009 19:08:32 +0000 (19:08 +0000)]
2009-05-19  David Levin  <levin@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 25859: Need to upstream ScriptController.* for v8.
        https://bugs.webkit.org/show_bug.cgi?id=25859

        Fixing the header file (which I accidentally made identical to the cpp file).

        * bindings/v8/ScriptController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdding a Radar URL.
ap@webkit.org [Tue, 19 May 2009 18:54:43 +0000 (18:54 +0000)]
Adding a Radar URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler and Brady Eidson.
ap@webkit.org [Tue, 19 May 2009 18:14:51 +0000 (18:14 +0000)]
    Reviewed by Darin Adler and Brady Eidson.

        REGRESSION (r42446?): UA Profiler in http://stevesouders.com/ua/ stalls

        The problem was that Document::removeAllEventListeners() was called for a wrong document
        when a CachedFrame was destroyed.

        Cannot be tested automatically, because DRT doesn't have a b/f cache.

        * dom/Document.cpp: (WebCore::Document::domWindow): Make sure that this doesn't return an
        unrelated window even if document's m_frame pointer is stale.

        * history/CachedFrame.cpp: (WebCore::CachedFrame::clear): Added a FIXME about strange behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Yichao Yin <yichao.yin@torchmobile.com.cn>
staikos@webkit.org [Tue, 19 May 2009 17:53:57 +0000 (17:53 +0000)]
2009-05-19  Yichao Yin  <yichao.yin@torchmobile.com.cn>

        Reviewed by George Staikos.

        Add the XHTML MP tests but put them in skipped since they are not active
        by default on any platforms.
        https://bugs.webkit.org/show_bug.cgi?id=23452

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Pavel Feldman <pfeldman@chromium.org>
dglazkov@chromium.org [Tue, 19 May 2009 16:58:01 +0000 (16:58 +0000)]
2009-05-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Split InspectorController into InspectorController and InspectorFrontend. Latter encapsulates all frontend interaction and is the only entity allowed to make ScriptFunctionCalls. The further plan is to serialize these script function calls.

        https://bugs.webkit.org/show_bug.cgi?id=25419

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToConsole):
        * inspector/ConsoleMessage.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::~InspectorController):
        (WebCore::InspectorController::inspect):
        (WebCore::InspectorController::focusNode):
        (WebCore::InspectorController::setWindowVisible):
        (WebCore::InspectorController::addConsoleMessage):
        (WebCore::InspectorController::setAttachedWindow):
        (WebCore::InspectorController::inspectedWindowScriptObjectCleared):
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::showPanel):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::resetScriptObjects):
        (WebCore::InspectorController::pruneResources):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::didLoadResourceFromMemoryCache):
        (WebCore::InspectorController::identifierForInitialRequest):
        (WebCore::InspectorController::willSendRequest):
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didReceiveContentLength):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorController::scriptImported):
        (WebCore::InspectorController::didOpenDatabase):
        (WebCore::InspectorController::didUseDOMStorage):
        (WebCore::InspectorController::addScriptProfile):
        (WebCore::InspectorController::toggleRecordButton):
        (WebCore::InspectorController::enableProfiler):
        (WebCore::InspectorController::disableProfiler):
        (WebCore::InspectorController::enableDebugger):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::didParseSource):
        (WebCore::InspectorController::failedToParseSource):
        (WebCore::InspectorController::didPause):
        (WebCore::InspectorController::didContinue):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMStorageResource.cpp:
        (WebCore::InspectorDOMStorageResource::bind):
        * inspector/InspectorDOMStorageResource.h:
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::bind):
        * inspector/InspectorDatabaseResource.h:
        * inspector/InspectorFrontend.cpp: Added.
        (WebCore::callSimpleFunction):
        (WebCore::InspectorFrontend::InspectorFrontend):
        (WebCore::InspectorFrontend::~InspectorFrontend):
        (WebCore::InspectorFrontend::newJSONObject):
        (WebCore::InspectorFrontend::addMessageToConsole):
        (WebCore::InspectorFrontend::addResource):
        (WebCore::InspectorFrontend::updateResource):
        (WebCore::InspectorFrontend::removeResource):
        (WebCore::InspectorFrontend::updateFocusedNode):
        (WebCore::InspectorFrontend::setAttachedWindow):
        (WebCore::InspectorFrontend::inspectedWindowScriptObjectCleared):
        (WebCore::InspectorFrontend::showPanel):
        (WebCore::InspectorFrontend::populateInterface):
        (WebCore::InspectorFrontend::reset):
        (WebCore::InspectorFrontend::debuggerWasEnabled):
        (WebCore::InspectorFrontend::debuggerWasDisabled):
        (WebCore::InspectorFrontend::profilerWasEnabled):
        (WebCore::InspectorFrontend::profilerWasDisabled):
        (WebCore::InspectorFrontend::parsedScriptSource):
        (WebCore::InspectorFrontend::failedToParseScriptSource):
        (WebCore::InspectorFrontend::addProfile):
        (WebCore::InspectorFrontend::setRecordingProfile):
        (WebCore::InspectorFrontend::pausedScript):
        (WebCore::InspectorFrontend::resumedScript):
        (WebCore::InspectorFrontend::addDatabase):
        (WebCore::InspectorFrontend::addDOMStorage):
        * inspector/InspectorFrontend.h: Added.
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::createScriptObject):
        (WebCore::InspectorResource::updateScriptObject):
        (WebCore::InspectorResource::releaseScriptObject):
        * inspector/InspectorResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Pavel Feldman <pfeldman@chromium.org>
dglazkov@chromium.org [Tue, 19 May 2009 16:45:28 +0000 (16:45 +0000)]
2009-05-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Introduce JSONObject that wraps ScriptObject and ScriptState* for further serialization

        https://bugs.webkit.org/show_bug.cgi?id=25419

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToConsole):
        * inspector/InspectorDOMStorageResource.cpp:
        (WebCore::InspectorDOMStorageResource::bind):
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::bind):
        * inspector/InspectorResource.cpp:
        (WebCore::populateHeadersObject):
        (WebCore::InspectorResource::createScriptObject):
        (WebCore::InspectorResource::updateScriptObject):
        * inspector/JSONObject.cpp: Added.
        (WebCore::JSONObject::JSONObject):
        (WebCore::JSONObject::set):
        (WebCore::JSONObject::scriptObject):
        (WebCore::JSONObject::createNew):
        * inspector/JSONObject.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCorrect two changelog entries to show the bug report
staikos@webkit.org [Tue, 19 May 2009 16:36:03 +0000 (16:36 +0000)]
Correct two changelog entries to show the bug report

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Pavel Feldman <pfeldman@chromium.org>
dglazkov@chromium.org [Tue, 19 May 2009 16:08:01 +0000 (16:08 +0000)]
2009-05-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Refactor InpectorController so that it does not instantiate resource/console/database/domresource javascript objects. Move instantiation into the javascript.

        https://bugs.webkit.org/show_bug.cgi?id=25419

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToConsole):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didReceiveContentLength):
        (WebCore::InspectorController::didFinishLoading):
        (WebCore::InspectorController::didFailLoading):
        (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
        (WebCore::InspectorController::scriptImported):
        * inspector/InspectorDOMStorageResource.cpp:
        (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
        (WebCore::InspectorDOMStorageResource::bind):
        (WebCore::InspectorDOMStorageResource::unbind):
        * inspector/InspectorDOMStorageResource.h:
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
        (WebCore::InspectorDatabaseResource::bind):
        (WebCore::InspectorDatabaseResource::unbind):
        * inspector/InspectorDatabaseResource.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::populateHeadersObject):
        (WebCore::InspectorResource::createScriptObject):
        (WebCore::InspectorResource::updateScriptObject):
        (WebCore::InspectorResource::releaseScriptObject):
        * inspector/InspectorResource.h:
        * inspector/front-end/Console.js:
        (WebInspector.ConsoleMessage):
        * inspector/front-end/inspector.js:
        (WebInspector.addResource):
        (WebInspector.updateResource):
        (WebInspector.removeResource):
        (WebInspector.addDatabase):
        (WebInspector.addDOMStorage):
        (WebInspector.reset):
        (WebInspector.addMessageToConsole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
ariya@webkit.org [Tue, 19 May 2009 15:11:45 +0000 (15:11 +0000)]
2009-05-19  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Reviewed by Ariya Hidayat.

        The Qt port has code that disables scrolling optimizations
        when the root contains native windows, such as windowed plugins.

        This code broke when detaching iframes containing windowed
        plugins.

        Each ScrollView now knows how many native windows it and its
        children contain, and when it is detached, that number is
        substracted from its old parents.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 19 May 2009 11:45:51 +0000 (11:45 +0000)]
2009-05-19  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        Do not try to free enchant broker and dictionary if they do not
        exist, those functions aren't NULL-safe.

        * webkit/webkitwebsettings.cpp:
        (free_spell_checking_language):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-19 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 19 May 2009 08:01:22 +0000 (08:01 +0000)]
2009-05-19  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Gavin Barraclough.

        - speed up string comparison, especially for short strings

        ~1% on SunSpider

        * JavaScriptCore.exp:
        * runtime/UString.cpp:
        * runtime/UString.h:
        (JSC::operator==): Inline UString's operator==, since it is called from
        hot places in the runtime. Also, specialize 2-char strings in a similar way to
        1-char, since we're taking the hit of a switch anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 19 May 2009 06:06:22 +0000 (06:06 +0000)]
2009-05-18  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Gavin Barraclough.

        - for polymorphic prototype lookups, increase the number of slots from 4 to 8

        ~4% faster on v8 raytrace benchmark

        * bytecode/Instruction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 19 May 2009 05:39:07 +0000 (05:39 +0000)]
2009-05-18  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver Hunt.

        - tighten up the code for the load_varargs stub

        ~1-2% on v8-raytrace

        * jit/JITStubs.cpp:
        (JSC::JITStubs::cti_op_load_varargs): Hoist some loop invariants that
        the compiler didn't feel like hoisting for us. Remove unneeded exception check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Added cookie test to Skipped list for Windows
ddkilzer@apple.com [Tue, 19 May 2009 05:17:03 +0000 (05:17 +0000)]
    Added cookie test to Skipped list for Windows

        See Bug 25861. <https://bugs.webkit.org/show_bug.cgi?id=25861>

        * platform/win/Skipped: Added
        http/tests/cookies/simple-cookies-expired.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Tiger build fix for r43850
ddkilzer@apple.com [Tue, 19 May 2009 05:02:07 +0000 (05:02 +0000)]
    Tiger build fix for r43850

        * platform/mac/ClipboardMac.mm: Added typedef for NSUinteger
        when building on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Bug 24569: Add some cookies tests
ddkilzer@apple.com [Tue, 19 May 2009 04:52:42 +0000 (04:52 +0000)]
    Bug 24569: Add some cookies tests

        <https://bugs.webkit.org/show_bug.cgi?id=24569>

LayoutTests:

        Reviewed and tweaked by David Kilzer.

        This modification adds a cookie framework to check setting cookies.
        It is a simple modification over the js test framework. It uses some XHRs and custom server-side script
        to set / get / clear cookies.

        It also adds some very basic tests to check that everything works.

        * http/tests/cookies: Added.
        * http/tests/cookies/multiple-cookies-expected.txt: Added.
        * http/tests/cookies/multiple-cookies.html: Added.
        * http/tests/cookies/resources: Added.
        * http/tests/cookies/resources/TEMPLATE.html: Copied from LayoutTests/fast/js/resources/TEMPLATE.html.
        * http/tests/cookies/resources/clearCookies.cgi: Added.
        * http/tests/cookies/resources/cookies-test-post.js: Copied from LayoutTests/fast/js/resources/js-test-post.js.
        * http/tests/cookies/resources/cookies-test-pre.js: Copied from LayoutTests/fast/js/resources/js-test-pre.js.
        (setCookies): Internal method to set a cookie (multiple cookies are not supported).
        (testCookies): Internal method to check if the cookie were set.

        (clearAllCookies): Used to clear all pre-existing cookies for this domain.
        (clearCookies): Used to clear the cookies set with cookiesShouldBe.
        (cookiesShouldBe): Used to set a cookie and check the "Cookie" header sent. It is inspired from shouldBe from the js test framework.

        * http/tests/cookies/resources/cookies-test-style.css: Copied from LayoutTests/fast/js/resources/js-test-style.css.
        * http/tests/cookies/resources/getCookies.cgi: Added.
        * http/tests/cookies/resources/multiple-cookies.js: Added.
        * http/tests/cookies/resources/setCookies.cgi: Added.
        * http/tests/cookies/resources/simple-cookies-expired.js: Added.
        * http/tests/cookies/resources/simple-cookies-max-age.js: Added.
        * http/tests/cookies/simple-cookies-expired-expected.txt: Added.
        * http/tests/cookies/simple-cookies-expired.html: Added.
        * http/tests/cookies/simple-cookies-max-age-expected.txt: Added.
        * http/tests/cookies/simple-cookies-max-age.html: Added.
        * platform/mac-tiger/Skipped: Added
        http/tests/cookies/simple-cookies-max-age.html since CFNetwork
        on Tiger doesn't support expiring cookies with Max-Age=0.

WebKitTools:

        Patch by David Kilzer.

        * Scripts/make-js-test-wrappers: Added regex to skip
        cookies-test-(post|pre).js files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 19 May 2009 04:17:26 +0000 (04:17 +0000)]
2009-05-17  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin Adler.

        ClipboardMac cleanup
        https://bugs.webkit.org/show_bug.cgi?id=25847

        I'm mostly just moving code, however there are 3 changes I made while moving, detailed below.

        No functional changes, so no tests.

        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::clearData):
        (WebCore::absoluteURLsFromPasteboardFilenames):
          Broke out logic for filenames into its own function to make the caller more readable.
        (WebCore::absoluteURLsFromPasteboard):
          Broke out logic from getData into absoluteURLsFromPasteboard. This returns an NSArray
          so that we can use -[NSArray componentsJoinedByString] in the caller (which is
          cleaner than the manual "\n" addition before).
          This also access to the full list of file urls for future callers.
        (WebCore::ClipboardMac::getData):
          unsigned count = (type == "URL") ? 1 : [fileList count]; is now an
          explicit check for "URL", before it was a check for != "text/uri-list" which
          was much more confusing in my opinion.  text/uri-list and URL are the only
          two types which map to NSURLPboardType in cocoaTypeFromMIMEType().
        (WebCore::ClipboardMac::types):
          I removed an extra if (!types) check, right before [types count].  In Obj-C
          messaging nil will return 0 (size of a pointer), so it's safe to message nil
          here and expect it to return 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 19 May 2009 03:40:09 +0000 (03:40 +0000)]
2009-05-18  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Geoff Garen.

        - Improve code generation for access to prototype properties

        ~0.4% speedup on SunSpider.

        Based on a suggestion from Geoff Garen.

        * jit/JIT.h:
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::compileGetDirectOffset):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit/mac:
sfalken@apple.com [Tue, 19 May 2009 03:23:44 +0000 (03:23 +0000)]
WebKit/mac:

2009-05-18  Sam Weinig  <sam@webkit.org>

        <rdar://problem/6899044> Can't see Apple ad on nytimes.com unless I spoof the user agent

        Add user agent hack for pointroll.com.

        Reviewed by Steve Falkenburg.

        * WebView/WebView.mm:
        (-[WebView WebCore::_userAgentForURL:WebCore::]):

WebKit/win:

2009-05-18  Steve Falkenburg  <sfalken@apple.com>

        <rdar://problem/6899044> Can't see Apple ad on nytimes.com unless I spoof the user agent

        Add user agent hack for pointroll.com.

        Reviewed by Sam Weinig.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 David Levin <levin@chromium.org>
levin@chromium.org [Tue, 19 May 2009 00:42:10 +0000 (00:42 +0000)]
2009-05-18  David Levin  <levin@chromium.org>

        Reviewed by Darin Fisher.

        Bug 25859: Need to upstream ScriptController.* for v8.
        https://bugs.webkit.org/show_bug.cgi?id=25859

        * bindings/v8/ScriptController.cpp: Added.
        * bindings/v8/ScriptController.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 19 May 2009 00:27:10 +0000 (00:27 +0000)]
2009-05-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Gavin Barraclough.

        Enable YARR, and disable WREC for GTK+.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>
staikos@webkit.org [Tue, 19 May 2009 00:10:32 +0000 (00:10 +0000)]
2009-05-18  Yichao Yin  <yichao.yin@torchmobile.com.cn>

        Reviewed by George Staikos.

        Change ScriptElement to support XHTMLMP in a better way

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix. Use python-config to get Python linking info on Unix OSes.
kevino@webkit.org [Tue, 19 May 2009 00:00:07 +0000 (00:00 +0000)]
wx build fix. Use python-config to get Python linking info on Unix OSes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix, finish up changes after the accessibility dir split.
kevino@webkit.org [Mon, 18 May 2009 23:51:13 +0000 (23:51 +0000)]
wx build fix, finish up changes after the accessibility dir split.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Yichao Yin <yichao.yin@torchmobile.com.cn>
staikos@webkit.org [Mon, 18 May 2009 23:48:30 +0000 (23:48 +0000)]
2009-05-18  Yichao Yin  <yichao.yin@torchmobile.com.cn>

        Reviewed by George Staikos (and others).

        Add XHTMLMP support to Webkit
        XHTMLMP is a strict subset of XHTML 1.1. It extends XHTML Basic and add enhanced
        functionality. Most of the functionalities have already been implemented by Webkit.

        The changes include:
        1) Adding <noscript> support
        2) Document conformance validation
        3) User Agent conformance validation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix the build.
mrowe@apple.com [Mon, 18 May 2009 22:35:12 +0000 (22:35 +0000)]
Fix the build.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
kov@webkit.org [Mon, 18 May 2009 20:40:14 +0000 (20:40 +0000)]
2009-05-18  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>

        Rubber-stamped by Gustavo Noronha.

        Fixed build for the Qt port by adding the WebCore/accessibility
        directory to the includepath.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
barraclough@apple.com [Mon, 18 May 2009 20:22:52 +0000 (20:22 +0000)]
2009-05-18  Jan Michael Alonzo  <jmalonzo@webkit.org>

         Reviewed by Xan Lopez.

         [Gtk] Various autotools build refactoring and fixes
         https://bugs.webkit.org/show_bug.cgi?id=25286

         Add -no-install and -no-fast-install to programs and tests that we
         don't install. Also remove -O2 since this is already handled at
         configure time.

         * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Mon, 18 May 2009 20:12:59 +0000 (20:12 +0000)]
2009-05-18  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by NOBODY (speculative build fix).

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Gavin Barraclough <barraclough@apple.com>
barraclough@apple.com [Mon, 18 May 2009 19:46:37 +0000 (19:46 +0000)]
2009-05-15  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Darin Adler.

        Refactor JIT code-handle objects.  The representation of generated code is currently
        a bit of a mess.  We have a class JITCode which wraps the pointer to a block of
        generated code, but this object does not reference the executable pool meaning that
        external events (the pool being derefed) could make the pointer become invalid.
        To overcome this both the JIT and Yarr implement further (and similar) objects to
        wrap the code pointer with a RefPtr to the pool.  To add to the mire, as well as the
        CodeBlock containing a handle onto the code the FunctionBodyNode also contains a
        copy of the code pointer which is used almost (but not entirely) uniquely to access
        the JIT code for a function.

        Rationalization of all this:

            * Add a new type 'MacroAssembler::CodeRef' as a handle for a block of JIT generated code.
            * Change the JIT & Yarr to internally handle code using CodeRefs.
            * Move the CodeRef (formerly anow defunct JITCodeRef) from CodeBlock to its owner node.
            * Remove the (now) redundant code pointer from FunctionBodyNode.

        While tidying this up I've made the PatchBuffer return code in new allocations using a CodeRef,
        and have enforced an interface that the PatchBuffer will always be used, and 'finalizeCode()' or
        'finalizeCodeAddendum()' will always be called exactly once on the PatchBuffer to complete code generation.

        This gives us a potentially useful hook ('PatchBuffer::performFinalization()') at the end of generation,
        which may have a number of uses.  It may be helpful should we wish to switch our generation
        model to allow RW/RX exclusive memory, and it may be useful on non-cache-coherent platforms to
        give us an oportunity to cache flush as necessary.

        No performance impact.

        * assembler/AbstractMacroAssembler.h:
        (JSC::AbstractMacroAssembler::ProcessorReturnAddress::relinkCallerToTrampoline):
        (JSC::AbstractMacroAssembler::CodeRef::CodeRef):
        (JSC::AbstractMacroAssembler::CodeRef::trampolineAt):
        (JSC::AbstractMacroAssembler::PatchBuffer::PatchBuffer):
        (JSC::AbstractMacroAssembler::PatchBuffer::~PatchBuffer):
        (JSC::AbstractMacroAssembler::PatchBuffer::link):
        (JSC::AbstractMacroAssembler::PatchBuffer::linkTailRecursive):
        (JSC::AbstractMacroAssembler::PatchBuffer::patch):
        (JSC::AbstractMacroAssembler::PatchBuffer::complete):
        (JSC::AbstractMacroAssembler::PatchBuffer::finalize):
        (JSC::AbstractMacroAssembler::PatchBuffer::entry):
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::CodeBlock):
        (JSC::CodeBlock::reparseForExceptionInfoIfNecessary):
        (JSC::CodeBlock::setJITCode):
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::getBytecodeIndex):
        (JSC::CodeBlock::executablePool):
        * interpreter/CallFrameClosure.h:
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::execute):
        (JSC::Interpreter::prepareForRepeatCall):
        * jit/JIT.cpp:
        (JSC::JIT::privateCompile):
        (JSC::JIT::privateCompileCTIMachineTrampolines):
        (JSC::JIT::linkCall):
        * jit/JIT.h:
        * jit/JITCode.h:
        (JSC::JITCode::JITCode):
        (JSC::JITCode::operator bool):
        (JSC::JITCode::addressForCall):
        (JSC::JITCode::offsetOf):
        (JSC::JITCode::execute):
        (JSC::JITCode::size):
        (JSC::JITCode::executablePool):
        (JSC::JITCode::HostFunction):
        * jit/JITPropertyAccess.cpp:
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdSelfList):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        * jit/JITStubs.cpp:
        (JSC::JITStubs::cti_vm_dontLazyLinkCall):
        (JSC::JITStubs::cti_vm_lazyLinkCall):
        * parser/Nodes.cpp:
        (JSC::ProgramNode::generateJITCode):
        (JSC::EvalNode::generateJITCode):
        (JSC::FunctionBodyNode::FunctionBodyNode):
        (JSC::FunctionBodyNode::createNativeThunk):
        (JSC::FunctionBodyNode::generateJITCode):
        * parser/Nodes.h:
        (JSC::ScopeNode::generatedJITCode):
        (JSC::ScopeNode::getExecutablePool):
        (JSC::ScopeNode::setJITCode):
        (JSC::ProgramNode::jitCode):
        (JSC::EvalNode::jitCode):
        (JSC::FunctionBodyNode::jitCode):
        * runtime/RegExp.cpp:
        (JSC::RegExp::match):
        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::compile):
        (JSC::Yarr::jitCompileRegex):
        (JSC::Yarr::executeRegex):
        * yarr/RegexJIT.h:
        (JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
        (JSC::Yarr::RegexCodeBlock::pcreFallback):
        (JSC::Yarr::RegexCodeBlock::setFallback):
        (JSC::Yarr::RegexCodeBlock::operator bool):
        (JSC::Yarr::RegexCodeBlock::set):
        (JSC::Yarr::RegexCodeBlock::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix, initialize variable that doesn't get set on Windows.
kevino@webkit.org [Mon, 18 May 2009 19:11:17 +0000 (19:11 +0000)]
wx build fix, initialize variable that doesn't get set on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25776: accessibility should have its own folder in WebCore project
cfleizach@apple.com [Mon, 18 May 2009 19:10:24 +0000 (19:10 +0000)]
Bug 25776: accessibility should have its own folder in WebCore project
https://bugs.webkit.org/show_bug.cgi?id=25776

Speculative fix for windows build failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Bug 20652: WebKit doesn't display favicons with MIME type image/vnd.microsoft...
ddkilzer@apple.com [Mon, 18 May 2009 18:59:23 +0000 (18:59 +0000)]
    Bug 20652: WebKit doesn't display favicons with MIME type image/vnd.microsoft.icon

        <https://bugs.webkit.org/show_bug.cgi?id=20652>

        Reviewed by Darin Adler.

WebCore:

        Test: http/tests/misc/favicon-as-image.html

        * inspector/front-end/inspector.js: Added
        image/vnd.microsoft.icon to WebInspector.MIMETypes.
        * platform/MIMETypeRegistry.cpp:
        (WebCore::initializeSupportedImageMIMETypes): Added
        image/vnd.microsoft.icon to list of supported image and image
        resource MIME types.

LayoutTests:

        Updated existing favicon-as-image.html test to display a third
        image having MIME type image/vnd.microsoft.icon.

        * http/tests/misc/favicon-as-image.html: Updated.
        * http/tests/misc/resources/.htaccess: Added.
        * http/tests/misc/resources/favicon-vnd-ms.ico: Copied from LayoutTests/fast/images/resources/favicon.ico.
        * platform/mac/http/tests/misc/favicon-as-image-expected.checksum: Updated.
        * platform/mac/http/tests/misc/favicon-as-image-expected.png: Updated.
        * platform/mac/http/tests/misc/favicon-as-image-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 25776: accessibility should have its own folder in WebCore project
cfleizach@apple.com [Mon, 18 May 2009 18:48:21 +0000 (18:48 +0000)]
Bug 25776: accessibility should have its own folder in WebCore project
https://bugs.webkit.org/show_bug.cgi?id=25776

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 18 May 2009 17:26:06 +0000 (17:26 +0000)]
2009-05-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25854
        [GTK] Should tell servers we only support identity as content encoding

        Let servers know we only support identity as content
        encoding. We will implement this in libsoup.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::startHttp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Mon, 18 May 2009 15:30:10 +0000 (15:30 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/6881160> REGRESSION (r41425): Unable to create battle.net account due to
        CAPTCHA failure.

        The problem was that after loading and displaying a CAPTCHA image, it was loaded from
        the server again due to preloading. So, the server expected the last loaded (invisible)
        CAPTCHA text to be typed and posted back.

        I don't know how to make tests for preloading.

        * loader/DocLoader.cpp: (WebCore::DocLoader::checkForPendingPreloads): There is never a reason
        to preload after loading for real - and if cache policy is CachePolicyReload, that actually
        results in another load from network layer.

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::cachePolicy): It's not good for cachePolicy()
        to lie, but I don't know how to re-do r41425 properly. Added a FIXME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Ariya Hidayat <ariya.hidayat@nokia.com>
ariya@webkit.org [Mon, 18 May 2009 14:13:37 +0000 (14:13 +0000)]
2009-05-18  Ariya Hidayat  <ariya.hidayat@nokia.com>

        Reviewed by Simon Hausmann.

        Done together with Balazs Kelemen  <kelemen.balazs@stud.u-szeged.hu>.

        https://bugs.webkit.org/show_bug.cgi?id=24551

        [Qt] Reuse FontPlatformData for the same FontDescription.
        This effectively prevents growing heap usage for loading every web page.

        * platform/graphics/qt/FontCacheQt.cpp:
        (WebCore::qHash): Necessary for FontPlatformDataCache.
        (WebCore::FontCache::getCachedFontPlatformData): Reuse the instance if
        it exists, otherwise create a new one and insert it in the cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>
ariya@webkit.org [Mon, 18 May 2009 12:11:23 +0000 (12:11 +0000)]
2009-05-18  Zoltan Horvath <horvath.zoltan.6@stud.u-szeged.hu>

        Reviewed by Ariya Hidayat.

        Makes QtLauncher to accept multiple urls in command line and opens these in separate windows.

        * QtLauncher/main.cpp:
        (MainWindow::newWindow):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Balazs Kelemen <kelemen.balazs@stud.u-szeged.hu>
ariya@webkit.org [Mon, 18 May 2009 11:33:23 +0000 (11:33 +0000)]
2009-05-18  Balazs Kelemen  <kelemen.balazs@stud.u-szeged.hu>

        Reviewed by Ariya Hidayat.

        https://bugs.webkit.org/show_bug.cgi?id=24551

        [Qt] Fix the leak in FontFallbackList::fontDataAt() function.
        When creating a new instance of SimpleFontData, put it in the font list
        so that it can deleted later on.

        * platform/graphics/qt/FontFallbackListQt.cpp:
        (WebCore::FontFallbackList::invalidate):
        (WebCore::FontFallbackList::releaseFontData):
        (WebCore::FontFallbackList::fontDataAt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 18 May 2009 11:30:53 +0000 (11:30 +0000)]
2009-05-18  Jan Michael Alonzo  <jmalonzo@webkit.org>

         Reviewed by Xan Lopez.

         [Gtk] Various autotools build refactoring and fixes
         https://bugs.webkit.org/show_bug.cgi?id=25286

         Add support for running unit tests. Also run the tests whenever
         the 'check' target runs.

         * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 18 May 2009 11:30:41 +0000 (11:30 +0000)]
2009-05-18  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [Gtk] Various autotools build refactoring and fixes
        https://bugs.webkit.org/show_bug.cgi?id=25286

        Style fixes

        * GNUmakefile.am:
        * WebCore/GNUmakefile.am

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 18 May 2009 11:30:25 +0000 (11:30 +0000)]
2009-05-18  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [Gtk] Various autotools build refactoring and fixes
        https://bugs.webkit.org/show_bug.cgi?id=25286

        Add -no-install and -no-fast-install to programs and tests that we
        don't install. Also remove -O2 since this is already handled at
        configure time.

        * GNUmakefile.am:
        * JavaScriptCore/GNUmakefile.am:
        * WebKitTools/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Mon, 18 May 2009 11:30:06 +0000 (11:30 +0000)]
2009-05-17  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [Gtk] Various autotools build refactoring and fixes
        https://bugs.webkit.org/show_bug.cgi?id=25286

        Add JavaScriptCore/ to JSC include path only since it's not
        required when building WebCore.

        * GNUmakefile.am:

2009-05-17 Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Xan Lopez.

        [Gtk] Various autotools build refactoring and fixes
        https://bugs.webkit.org/show_bug.cgi?id=25286

        Refactor library cflags

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Julie Parent <jparent@google.com>
eric@webkit.org [Mon, 18 May 2009 11:11:15 +0000 (11:11 +0000)]
2009-05-18  Julie Parent  <jparent@google.com>

        Reviewed by Eric Seidel.

        Skip new tests from r43822 on Gtk
        https://bugs.webkit.org/show_bug.cgi?id=25780

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Julie Parent <jparent@google.com>
eric@webkit.org [Mon, 18 May 2009 10:55:42 +0000 (10:55 +0000)]
2009-05-18  Julie Parent  <jparent@google.com>

        Reviewed by Oliver Hunt.

        Add missing files from r43821
        https://bugs.webkit.org/show_bug.cgi?id=25780

        * editing/pasteboard/get-data-text-plain-drop-expected.txt: Added.
        * editing/pasteboard/get-data-text-plain-drop.html: Added.
        * editing/pasteboard/get-data-text-plain-paste-expected.txt: Added.
        * editing/pasteboard/get-data-text-plain-paste.html: Added.
        * editing/pasteboard/resources/TEMPLATE.html: Copied from LayoutTests/editing/execCommand/resources/TEMPLATE.html.
        * editing/pasteboard/resources/get-data-text-plain-paste.js: Added.
        (handlePaste):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Julie Parent <jparent@google.com>
eric@webkit.org [Mon, 18 May 2009 10:29:14 +0000 (10:29 +0000)]
2009-05-18  Julie Parent  <jparent@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25716

        * Scripts/make-js-test-wrappers: Added exception to avoid overwriting a custom-written test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-18 Julie Parent <jparent@google.com>
eric@webkit.org [Mon, 18 May 2009 10:11:47 +0000 (10:11 +0000)]
2009-05-18  Julie Parent  <jparent@google.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25716

        * Scripts/make-js-test-wrappers: Added exception to avoid overwriting a custom-written test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix
sfalken@apple.com [Mon, 18 May 2009 01:20:08 +0000 (01:20 +0000)]
    Windows build fix

        * JavaScriptCore.vcproj/JavaScriptCore.make:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by David Kilzer.
mitz@apple.com [Mon, 18 May 2009 00:31:45 +0000 (00:31 +0000)]
    Reviewed by David Kilzer.

        - move fast/repaint/repaint.js into the resources subdirectory

        * fast/repaint/repaint.js: Removed.
        * fast/repaint/resources/repaint.js: Copied from fast/repaint/repaint.js.
        * (89 tests changed to load the script from the new location)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed build fix for WML: constr->const
staikos@webkit.org [Sun, 17 May 2009 20:11:47 +0000 (20:11 +0000)]
Unreviewed build fix for WML: constr->const

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 17 May 2009 20:06:05 +0000 (20:06 +0000)]
2009-05-17  Darin Adler  <darin@apple.com>

        Fix done by Simon Fraser (reviewed by me).

        <rdar://problem/6893775> Page with screen-only stylesheet with overflow and height
        transitions has bad layout and overlapping garbled text when printing

        * manual-tests/print-with-height-transition-in-screen-stylesheet.html: Added.

        * page/animation/AnimationController.cpp:
        (WebCore::AnimationController::updateAnimations): Don't run transitions when printing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 17 May 2009 19:12:55 +0000 (19:12 +0000)]
2009-05-17  Darin Adler  <darin@apple.com>

        Reviewed by Simon Fraser.

        <rdar://problem/6870241> REGRESSION: Programmatically selected popup menu item not shown

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setSelectedIndex): Added a call to updateFromElement and
        also a type check on the selected index to avoid a bad cast to HTMLOptionElement.

        * manual-tests/select-option-in-onload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 17 May 2009 18:34:43 +0000 (18:34 +0000)]
2009-05-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        Rename local variables for readability.

        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 17 May 2009 17:50:02 +0000 (17:50 +0000)]
2009-05-17  Darin Adler  <darin@apple.com>

        * platform/gtk/Skipped: Disable another media test that seems to be failing at least
        intermittently.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 17 May 2009 17:47:13 +0000 (17:47 +0000)]
2009-05-17  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Bug 25840: fix some warnings seen on the GTK bot
        https://bugs.webkit.org/show_bug.cgi?id=25840

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::platformScrollbarModes): Initialize results here.
        This is really just to quiet warnings. I think this code is unreachable.
        Someone could put ASSERT_NOT_REACHED() in here too at some point.

        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::startStream): Use proper printf format for int
        here, %d, not %lu. This could cause a real problem when compiled 64-bit,
        so it's good to fix.

        * rendering/RenderTextControl.cpp:
        (WebCore::getNextSoftBreak): Initialize breakOffset to 0 here. This is
        really just to quiet the warning, but still seems like a good idea.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-17 Chris Fleizach <cfleizach@apple.com>
darin@apple.com [Sun, 17 May 2009 16:50:21 +0000 (16:50 +0000)]
2009-05-17  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Darin Adler.

        Bug 25769: Fix accessibility warnings on GTK
        https://bugs.webkit.org/show_bug.cgi?id=25769

        * page/AccessibilityTable.cpp:
        (WebCore::AccessibilityTable::columnCount): Get rid of excess const.
        (WebCore::AccessibilityTable::rowCount): Ditto.
        * page/AccessibilityTable.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sun, 17 May 2009 16:47:09 +0000 (16:47 +0000)]
WebCore:

2009-05-17  Kai Brüning  <kai@granus.net>

        Reviewed by Darin Adler.

        bug 25822: DOM normalize does not remove empty text node between element nodes
        https://bugs.webkit.org/show_bug.cgi?id=25822

        Test: fast/dom/Node/normalize.html

        * dom/Node.cpp:
        (WebCore::Node::normalize): Changed to remove any empty text nodes.

LayoutTests:

2009-05-17  Kai Brüning  <kai@granus.net>

        Reviewed by Darin Adler.

        Test case for bug 25822: DOM normalize does not remove empty text node between element nodes
        https://bugs.webkit.org/show_bug.cgi?id=25822

        The test case strives to test the whole functionality of Node's normalize().

        * fast/dom/Node/normalize-expected.txt: Added.
        * fast/dom/Node/normalize.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-16 Dave Moore <davemoore@google.com>
mrowe@apple.com [Sun, 17 May 2009 03:44:51 +0000 (03:44 +0000)]
2009-05-16  Dave Moore  <davemoore@google.com>

        Reviewed by Darin Adler.

        Allow Strings to be created with one malloc node with no copying
        https://bugs.webkit.org/show_bug.cgi?id=25779

        Add new methods to String and StringImpl, refactoring existing
        methods in StringImpl to use new createUninitialized() method.

        * platform/text/PlatformString.h:
        (WebCore::String::createUninitialized):
        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::createUninitialized):
        (WebCore::StringImpl::create):
        * platform/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
mrowe@apple.com [Sun, 17 May 2009 03:38:38 +0000 (03:38 +0000)]
<rdar://problem/6827041> WebCore should stop throwing away the CGImageSourceRef to
dramatically improve animated GIF decoding performance

Reviewed by Darin Adler.

Recent versions of ImageIO discard previously decoded image frames if the client
application no longer holds references to them, so there's no need to throw away
the decoder unless we're explicitly asked to destroy all of the frames.

This drops peak CPU usage when displaying <http://www.aintitcool.com/files/HoD2.gif>
from over 90% to below 3%.

* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit:
andersca@apple.com [Sat, 16 May 2009 21:51:42 +0000 (21:51 +0000)]
WebKit:

2009-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig and Dan Bernstein.

        Fix <rdar://problem/6889644>.

        * English.lproj/Localizable.strings:

WebKit/mac:

2009-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig and Dan Bernstein.

        Fix <rdar://problem/6889644>

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::spawnPluginHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSet the svn:mime-type property of recently-added PNG files to image/png
mitz@apple.com [Sat, 16 May 2009 20:21:49 +0000 (20:21 +0000)]
Set the svn:mime-type property of recently-added PNG files to image/png

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago - revert an accidental change from r43802.
mitz@apple.com [Sat, 16 May 2009 20:06:21 +0000 (20:06 +0000)]
    - revert an accidental change from r43802.

        * WebInspector/WebInspector.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-16 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 16 May 2009 19:58:13 +0000 (19:58 +0000)]
2009-05-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6895347> Mouse wheeling in the QuickTime plug-in (incorrectly) scrolls the page

        Fix logic. The plug-in returns true if it handled the event.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView sendEvent:isDrawRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sat, 16 May 2009 19:56:49 +0000 (19:56 +0000)]
WebCore:

        Reviewed by Alexey Proskuryakov.

        - fix <rdar://problem/6873305> Two distinct characters are not displayed
          correctly with 2 of the font selections from the stickies widget

        Test: platform/mac/editing/pasteboard/text-precomposed.html

        Ensure that "text/plain" data retrieved from the clipboard is always
        precomposed. This makes Clipboard::getData() and
        Pasteboard::documentFragment() consistent with Pasteboard::plainText()
        and -[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:].

        * platform/mac/ClipboardMac.mm:
        (WebCore::ClipboardMac::getData):
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::documentFragment):

WebKit/mac:

        Reviewed by Alexey Proskuryakov.

        - fix <rdar://problem/6873305> Two distinct characters are not displayed
          correctly with 2 of the font selections from the stickies widget

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _plainTextFromPasteboard:]): Return precomposed text.
        This is consistent with
        -_documentFragmentFromPasteboard:forType:inContext:subresources:.

LayoutTests:

        Reviewed by Alexey Proskuryakov.

        - test for <rdar://problem/6873305> Two distinct characters are not
          displayed correctly with 2 of the font selections from the stickies
          widget

        * platform/mac/editing/pasteboard/text-precomposed-expected.txt: Added.
        * platform/mac/editing/pasteboard/text-precomposed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GTK] Merge r41819 into Gtk to log through the JS console
zecke@webkit.org [Sat, 16 May 2009 09:11:17 +0000 (09:11 +0000)]
[GTK] Merge r41819 into Gtk to log through the JS console

https://bugs.webkit.org/show_bug.cgi?id=25787

Copy over the log routine from the OSX TestNetscapePlugin to
the copy of Gtk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[GTK] Merge r39877 into Gtk+ to pass plugins/npruntime.html
zecke@webkit.org [Sat, 16 May 2009 09:10:57 +0000 (09:10 +0000)]
[GTK] Merge r39877 into Gtk+ to pass plugins/npruntime.html

WebKitTools:
2009-05-11  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Jan Michael Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25787

        Forward port r39877 from main.c of OSX to TestNetscapePlugin
        of Gtk.

        * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_new_instance):

LayoutTests:
2009-05-11  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Jan Michael Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25787

        Enable plugins/npruntime.html

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix.
mrowe@apple.com [Sat, 16 May 2009 07:56:21 +0000 (07:56 +0000)]
Build fix.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForFamily): Declare valueForFamily as static.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-05-15 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 16 May 2009 06:57:56 +0000 (06:57 +0000)]
2009-05-15  Darin Adler  <darin@apple.com>

        Fix some failures from recent changes.

        * platform/gtk/Skipped: Added recently-added test to the "no expected results" section.

        * platform/win/fast/css/getComputedStyle/computed-style-expected.txt: Updated.
        * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
        * svg/css/getComputedStyle-basic-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
darin@apple.com [Sat, 16 May 2009 06:06:29 +0000 (06:06 +0000)]
WebCore:

2009-05-15  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
        only the generic font, if any generic font is in the family list

        Test: fast/css/getComputedStyle/computed-style-font-family.html

        * css/CSSComputedStyleDeclaration.cpp:
        Sorted computedProperties alphabetically. Added CSSPropertyClip and CSSPropertyWordBreak.
        (WebCore::identifierForFamily): Added. Maps internal font family names to identifiers.
        (WebCore::valueForFamily): Added. Creates either an identifier or a string as appropriate.
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Implemented the font-family
        property as specified in the CSS standard. Fixed clip to return "auto" when there is no
        clip set instead of nothing at all. Gave inheritableProperties and numInheritableProperties
        internal linkage since there was no reason for them to have external linkage.

LayoutTests:

2009-05-15  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6883872> REGRESSION (r43243): computed style for font-family is returning
        only the generic font, if any generic font is in the family list

        * fast/css/getComputedStyle/computed-style-font-family-expected.txt: Added.
        * fast/css/getComputedStyle/computed-style-font-family.html: Added.

        * fast/css/getComputedStyle/computed-style.html: Updated array of properties to dump
        that are not visible when iterating the computed style object. Removed pointless
        unused array of unimplemented properties.
        * fast/css/getComputedStyle/computed-style-without-renderer.html: Ditto.

        * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: Updated.
        * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@43797 268f45cc-cd09-0410-ab3c-d52691b4dbfc