WebKit-https.git
9 years ago2010-09-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 8 Sep 2010 08:52:17 +0000 (08:52 +0000)]
2010-09-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        TextDocument should come in from the cold
        https://bugs.webkit.org/show_bug.cgi?id=45334

        Previously, TextDocument reinvented the wheel to parse text.  This
        patch replaces TextDocument's hand-rolled parser with a parser built on
        the HTML parser infrustructure, which gives us that stuff for free.  I
        also disentangled TextDocument from HTMLViewSourceDocument.

        In a future patch, I'll move TextDocument out of the "loader" directory.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::createParser):
        * html/HTMLViewSourceDocument.h:
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::constructTreeFromToken):
        (WebCore::HTMLTreeBuilder::constructTreeFromAtomicToken):
        * html/parser/HTMLTreeBuilder.h:
        * html/parser/HTMLViewSourceParser.cpp:
        (WebCore::HTMLViewSourceParser::forcePlaintext):
        * html/parser/HTMLViewSourceParser.h:
        * html/parser/TextDocumentParser.cpp: Added.
        (WebCore::TextDocumentParser::TextDocumentParser):
        (WebCore::TextDocumentParser::~TextDocumentParser):
        (WebCore::TextDocumentParser::insertFakePreElement):
        * html/parser/TextDocumentParser.h: Added.
        (WebCore::TextDocumentParser::create):
        * loader/TextDocument.cpp:
        * loader/TextDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement MediaPlayerPrivate::platformMedia() for the Qt port
vestbo@webkit.org [Wed, 8 Sep 2010 08:32:11 +0000 (08:32 +0000)]
Implement MediaPlayerPrivate::platformMedia() for the Qt port

Reviewed by Andreas Kling.

https://bugs.webkit.org/show_bug.cgi?id=45264

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAn individual renderer should be assigned to each SVGFE*Element class
zherczeg@webkit.org [Wed, 8 Sep 2010 07:23:17 +0000 (07:23 +0000)]
An individual renderer should be assigned to each SVGFE*Element class
https://bugs.webkit.org/show_bug.cgi?id=43954

Reviewed by Dirk Schulze.

WebCore:

RenderSVGResourceFilterPrimitive renderer is added to
the project, and assigned to each object, which class is
derived from SVGFilterPrimitiveStandardAttributes. The patch
mainly contains build system changes, and it fixes one layout
test in svg/dynamic-updates.

* Android.mk:
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderObject.h:
(WebCore::RenderObject::isSVGResourceFilterPrimitive):
* rendering/RenderSVGResourceFilterPrimitive.cpp: Added.
(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):
* rendering/RenderSVGResourceFilterPrimitive.h: Added.
(WebCore::RenderSVGResourceFilterPrimitive::isSVGResourceFilterPrimitive):
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGContainer):
* svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):
* svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::svgAttributeChanged):
(WebCore::SVGFELightElement::childrenChanged):
* svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::svgAttributeChanged):
* svg/SVGFilterElement.h:
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::createRenderer):
* svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::invalidate):

LayoutTests:

The layout test below is fixed by this patch.

* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.checksum:
* platform/mac/svg/dynamic-updates/SVGFEDiffuseLightingElement-lighting-color-css-prop-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDatasetDOMStringMap does not have the right memory model
weinig@apple.com [Wed, 8 Sep 2010 05:56:00 +0000 (05:56 +0000)]
DatasetDOMStringMap does not have the right memory model
https://bugs.webkit.org/show_bug.cgi?id=45358

Reviewed by Dan Bernstein.

WebCore:

Test: fast/dom/dataset-gc.html

* bindings/js/JSElementCustom.cpp:
(WebCore::JSElement::markChildren):
Mark the dataset if it exists.

* dom/Element.cpp:
(WebCore::Element::optionalDataset):
* dom/Element.h:
Expose a way to get the dataset or null (depending on if anyone thing
has forced its creation yet).

LayoutTests:

Test that the dataset persists gc.

* fast/dom/dataset-gc-expected.txt: Added.
* fast/dom/dataset-gc.html: Added.
* fast/dom/script-tests/dataset-gc.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 8 Sep 2010 05:54:36 +0000 (05:54 +0000)]
2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Ojan Vafai.

        Enable incremental results.json generation for non-layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=45315

        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.

        * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
mrowe@apple.com [Wed, 8 Sep 2010 05:30:56 +0000 (05:30 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 8 Sep 2010 04:58:34 +0000 (04:58 +0000)]
2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>

        Unreviewed, another Qt release build fix attempt.

        * UIProcess/API/cpp/qt/WKURLQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Wed, 8 Sep 2010 04:52:16 +0000 (04:52 +0000)]
2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>

        Unreviewed, attempt to fix Qt release build.

        * UIProcess/API/cpp/qt/WKStringQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Jan E Hanssen <jhanssen@sencha.com>
commit-queue@webkit.org [Wed, 8 Sep 2010 04:02:55 +0000 (04:02 +0000)]
2010-09-07  Jan E Hanssen  <jhanssen@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] Added test case for Path::length()
        https://bugs.webkit.org/show_bug.cgi?id=45331

        Also removed test case for Path::pointAtLength() that is now passing

        * platform/qt/svg/dom/path-pointAtLength-expected.txt: Removed.
        * svg/dom/path-totalLength-expected.txt: Added.
        * svg/dom/path-totalLength.html: Added.
        * svg/dom/script-tests/path-totalLength.js: Added.
        (getTotalLength):
2010-09-07  Jan E Hanssen  <jhanssen@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] Add a separate Path::closeCanvasSubpath() function for canvas paths
        https://bugs.webkit.org/show_bug.cgi?id=45331

        This is needed due to an adverse effect of the fix in 44061 that causes
        certain paths not to be closed. This is not important for canvas paths
        but it is for SVG paths, so splitting up the code in a generic (SVG)
        case and one specialized for canvas.

        Test: svg/dom/path-totalLength.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::closePath):
        * platform/graphics/Path.h:
        (WebCore::Path::closeCanvasSubpath):
        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::closeSubpath):
        (WebCore::Path::closeCanvasSubpath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 8 Sep 2010 03:01:14 +0000 (03:01 +0000)]
2010-09-07  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix

        Missed one test in mac_unittest.py in previous change; for some
        reason the method is listed twice. I will fix both for now, but will
        figure this out in a later, not-time-sensitive patch.

        https://bugs.webkit.org/show_bug.cgi?id=45357

        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Wed, 8 Sep 2010 02:56:45 +0000 (02:56 +0000)]
2010-09-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Tony Chang.

        test-webkitpy: Fix load error of
        webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
        https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short

        * Scripts/webkitpy/layout_tests/port/server_process.py:
          Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
          and we don't use server_process.py on Win32 Python. However
          unittest.py tries to load everything in a module.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 8 Sep 2010 02:23:16 +0000 (02:23 +0000)]
2010-09-07  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Kent Tamura.

        Fix regression introduced in previous change to new-run-webkit-tests
        (bug 45090) to not try to run unittests for the Mac implementation
        of the Port interface if we aren't running on a Mac.

        Also fix the overrides implementation mock in the chromium unittests
        to fix the case where there are overrides checked in that cause
        problems.

        https://bugs.webkit.org/show_bug.cgi?id=45357

        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 8 Sep 2010 01:26:37 +0000 (01:26 +0000)]
2010-09-07  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Kent Tamura.

        Markup.waitUntilDone does not call Markup.noAutoDump without LayoutTestController
        https://bugs.webkit.org/show_bug.cgi?id=45123

        * resources/dump-as-markup.js:
        (Markup.waitUntilDone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 8 Sep 2010 01:15:07 +0000 (01:15 +0000)]
2010-09-07  James Robinson  <jamesr@chromium.org>

        Compile fix attempt for windows.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 8 Sep 2010 01:10:02 +0000 (01:10 +0000)]
2010-09-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Chris Marrin.

        Transform animations always run in software now
        https://bugs.webkit.org/show_bug.cgi?id=45341

        After r66339 we always fell into software animation, because we
        failed to detect transform or opacity properties in the keyframes,
        so would send an empty list of values to the GraphicsLayer.

        Fixed by using CSSProperty values, rather than GraphicsLayer
        values, when detecting the presence of properties in the keyframes.

        Test: manual-tests/transition-accelerated.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::startAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 8 Sep 2010 01:02:49 +0000 (01:02 +0000)]
2010-09-07  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        audio engine: add FFTFrame files
        https://bugs.webkit.org/show_bug.cgi?id=34827

        No new tests since audio API is not yet implemented.

        * platform/audio/FFTFrame.cpp: Added.
        (WebCore::FFTFrame::doPaddedFFT):
        (WebCore::FFTFrame::createInterpolatedFrame):
        (WebCore::FFTFrame::interpolateFrequencyComponents):
        (WebCore::FFTFrame::extractAverageGroupDelay):
        (WebCore::FFTFrame::addConstantGroupDelay):
        (WebCore::FFTFrame::print):
        * platform/audio/FFTFrame.h: Added.
        (WebCore::FFTFrame::fftSize):
        (WebCore::FFTFrame::log2FFTSize):
        (WebCore::FFTFrame::dspSplitComplex):
        * platform/audio/mac/FFTFrameMac.cpp: Added.
        (WebCore::FFTFrame::FFTFrame):
        (WebCore::FFTFrame::~FFTFrame):
        (WebCore::FFTFrame::multiply):
        (WebCore::FFTFrame::doFFT):
        (WebCore::FFTFrame::doInverseFFT):
        (WebCore::FFTFrame::fftSetupForSize):
        (WebCore::FFTFrame::cleanup):
        (WebCore::FFTFrame::realData):
        (WebCore::FFTFrame::imagData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Mihai Parparita <mihaip@chromium.org>
jamesr@google.com [Wed, 8 Sep 2010 00:54:04 +0000 (00:54 +0000)]
2010-09-07  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by James Robinson.

        Fix Windows build after r66936
        https://bugs.webkit.org/show_bug.cgi?id=45348

        Add symbol names that were missing from r66936.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Build fix, no review.
bfulgham@webkit.org [Wed, 8 Sep 2010 00:50:05 +0000 (00:50 +0000)]
WebCore: Build fix, no review.

Provide stubs to allow WebKit.dll to build
for the WinCairo port.

* platform/network/curl/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
* platform/network/curl/ResourceResponse.h:
(WebCore::ResourceResponse::cfURLResponse):

WebKit2: Build correction, no review.

* win/WebKit2.vcproj: Disable two unused files for
the WinCairo target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 8 Sep 2010 00:48:23 +0000 (00:48 +0000)]
2010-09-07  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add AudioArray.h
        https://bugs.webkit.org/show_bug.cgi?id=45204

        No new tests since audio API is not yet implemented.

        * platform/audio/AudioArray.h: Added.
        (WebCore::AudioArray::AudioArray):
        (WebCore::AudioArray::zero):
        (WebCore::AudioArray::zeroRange):
        (WebCore::AudioArray::copyToRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-01 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 8 Sep 2010 00:46:34 +0000 (00:46 +0000)]
2010-09-01  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: still more unit tests

        Clean up and remove unnecessary code. Biggest notable change is
        moving the chromium-specific imagediff code from port/base to
        port/chromium.

        Add more unit tests for run_webkit_tests.py, port/base.py,
        port/factory.py, port/dryrun.py, and
        layout_package/dump_render_tree_thread.py

        This covers almost all of the generic and test code paths except for
        a few error paths involving invalid or port-specific command line
        arguments, and the code path for uploading results files to the
        buildbots.

        https://bugs.webkit.org/show_bug.cgi?id=45090

        * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
        * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
        * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
        * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
        * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
        * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
        * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
        * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/dryrun.py:
        * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
        * Scripts/webkitpy/layout_tests/port/server_process.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Wed, 8 Sep 2010 00:33:15 +0000 (00:33 +0000)]
2010-09-07  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Oliver Hunt.

        pushState and replaceState do not clone RegExp objects correctly
        https://bugs.webkit.org/show_bug.cgi?id=44718

        Move internal representation of JSC::RegExp (which depends on wether
        YARR and YARR_JIT is enabled) into RegExpRepresentation which can live
        in the implementation only. This makes it feasible to use RegExp in
        WebCore without bringing in all of YARR.

        * JavaScriptCore.exp: Export RegExp and RegExpObject functions that are
        needed inside WebCore's JSC bindings.
        * runtime/RegExp.cpp:
        (JSC::RegExpRepresentation::~RegExpRepresentation):
        (JSC::RegExp::RegExp):
        (JSC::RegExp::~RegExp):
        (JSC::RegExp::compile):
        (JSC::RegExp::match):
        * runtime/RegExp.h:
2010-09-07  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Oliver Hunt.

        pushState and replaceState do not clone RegExp objects correctly
        https://bugs.webkit.org/show_bug.cgi?id=44718

        Make RegExp test of pushstate-object-types.html actually test a RegExp
        value with flags.

        Also adds ImageData since it can be serialized as of r54646.

        * fast/loader/stateobjects/pushstate-object-types-expected.txt:
        * fast/loader/stateobjects/pushstate-object-types.html:
2010-09-07  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Oliver Hunt.

        pushState and replaceState do not clone RegExp objects correctly
        https://bugs.webkit.org/show_bug.cgi?id=44718

        Add RegExp support to the JSC implementation of SerializedScriptValue
        (it stores the pattern and flags read from a RegExpObject, and creates
        a new one on deserialization).

        Tests: fast/loader/stateobjects/pushstate-object-types.html

        * ForwardingHeaders/runtime/RegExp.h: Added.
        * ForwardingHeaders/runtime/RegExpObject.h: Added.
        * bindings/js/SerializedScriptValue.cpp:
        (WebCore::CloneSerializer::dumpIfTerminal):
        (WebCore::CloneDeserializer::readTerminal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix clang++ build.
andersca@apple.com [Wed, 8 Sep 2010 00:32:54 +0000 (00:32 +0000)]
Fix clang++ build.

Reviewed by Oliver Hunt.

* Misc/WebLocalizableStrings.h:
Fix a struct/tag mismatch.

* WebView/WebDeviceOrientationProviderMock.mm:
(-[WebDeviceOrientationProviderMock init]):
Remove stray semicolon.

* WebView/WebViewData.h:
Remove unused class forward declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 7 Sep 2010 23:56:28 +0000 (23:56 +0000)]
2010-09-07  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Fix OpenGL error reporting in WebGL layout test utilities
        https://bugs.webkit.org/show_bug.cgi?id=45336

        * fast/canvas/webgl/resources/webgl-test.js:
        (getGLErrorAsString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix clang++ build.
andersca@apple.com [Tue, 7 Sep 2010 23:51:45 +0000 (23:51 +0000)]
Fix clang++ build.

Reviewed by Sam Weinig.

* UIProcess/API/C/WKAPICast.h:
Move all functions into the WebKit namespace.

* UIProcess/API/C/cf/WKStringCF.cpp:
Add using namespace WebKit.

* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
Move all functions into the WebKit namespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 7 Sep 2010 23:43:49 +0000 (23:43 +0000)]
2010-09-07  Tony Chang  <tony@chromium.org>

        Unreviewed, updating chromium linux test expectations.

        * platform/chromium/drt_expectations.txt: Adding back a test removed in r66924 that is still failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 7 Sep 2010 23:37:29 +0000 (23:37 +0000)]
2010-09-07  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        Fix compile errors in DrawingBuffer if USE(ACCELERATED_COMPOSITING) is not set
        https://bugs.webkit.org/show_bug.cgi?id=45324

        Adds appropriate #if guards around code that has to deal directly with the compositor.
        DrawingBuffer can still be used without the compositor as an off-screen rendering
        region.

        To test, compile without USE(ACCELERATED_COMPOSITING).

        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::~DrawingBuffer):
        (WebCore::DrawingBuffer::reset):
        * platform/graphics/gpu/DrawingBuffer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Tue, 7 Sep 2010 23:34:11 +0000 (23:34 +0000)]
2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Darin Adler.

        Provide a way to trigger a <select multiple> onchange event on changes
        https://bugs.webkit.org/show_bug.cgi?id=45192

        Testing the DOMHTMLSelectElement interface for selecting an
        index in a <select> and triggering a "change" event. This also
        tests for allowing multiple selections.

        * platform/mac/fast/objc/dom-html-select-activate-expected.txt: Added.
        * platform/mac/fast/objc/dom-html-select-activate.html: Added.

2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Darin Adler.

        Provide a way to trigger a <select multiple> onchange event on changes
        https://bugs.webkit.org/show_bug.cgi?id=45192

        Adds a selector on ObjCController for testing
        -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
        its different uses.

        * DumpRenderTree/mac/ObjCController.m:
        (+[ObjCController isSelectorExcludedFromWebScript:]):
        (+[ObjCController webScriptNameForSelector:]):
        (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-03 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Tue, 7 Sep 2010 23:33:59 +0000 (23:33 +0000)]
2010-09-03  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Darin Adler.

        Provide a way to trigger a <select multiple> onchange event on changes
        https://bugs.webkit.org/show_bug.cgi?id=45192

        Test: LayoutTests/platform/mac/fast/objc/dom-html-select-activate.html

        This provides a way for a WebKit client using the Obj-C DOM bindings to
        trigger the "change" on a listbox select (<select multiple> or <select>
        with size > 1). This is because when a select is rendered as a listbox
        "change" events are triggered by mouse down events.

        This adds -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]
        to allow for handling multiple selections if the select element is a
        multi-select.

        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:]):
        * bindings/objc/DOMPrivate.h: unified the Category name. Was "FormsAutocomplete" now all are "FormAutocomplete".
        * dom/SelectElement.h:
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setSelectedIndexByUser): listboxs need to be treated specially to fire their "change" event.
        * html/HTMLSelectElement.h:
        * wml/WMLSelectElement.cpp:
        (WebCore::WMLSelectElement::setSelectedIndexByUser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 7 Sep 2010 23:28:25 +0000 (23:28 +0000)]
2010-09-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Minor WKCACFLayerRenderer cleanup
        https://bugs.webkit.org/show_bug.cgi?id=45201

        Call initD3DGeometry() from createRenderer, rather than duplicating the code.

        No behavior changes.

        * platform/graphics/win/WKCACFLayerRenderer.cpp:
        (WebCore::WKCACFLayerRenderer::createRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 7 Sep 2010 23:27:22 +0000 (23:27 +0000)]
2010-09-07  James Robinson  <jamesr@chromium.org>

        Rubber-stamped by Dimitri Glazkov.

        Move myself from the committer to the reviewer list.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 7 Sep 2010 23:26:36 +0000 (23:26 +0000)]
2010-09-07  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] removing tests that pass after switch the bot back to hardy
        https://bugs.webkit.org/show_bug.cgi?id=45327

        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 7 Sep 2010 23:19:22 +0000 (23:19 +0000)]
2010-09-07  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium/DRT] Remove now-passing tests.

        * platform/chromium/drt_expectations.txt: A few more tests now pass, yay!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 7 Sep 2010 23:10:45 +0000 (23:10 +0000)]
2010-09-07  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        turn off php output buffering in multipart tests
        https://bugs.webkit.org/show_bug.cgi?id=45232

        This was causing hanging multipart resources to not output anything.
        On Lucid, the output buffer is enabled by default, but it's not enabled on Hardy.
        http://www.php.net/manual/en/function.ob-end-flush.php

        * http/tests/multipart/resources/multipart-wait-before-boundary.php:
        * http/tests/multipart/resources/multipart.php:
        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Tue, 7 Sep 2010 23:05:44 +0000 (23:05 +0000)]
2010-09-07  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Reset the owner of PlatformLayer's once the GraphicsLayer they are associated with
        gets destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=45329

        Test: Fixes UI test failures downstream for all the Media tests when run on the buildbots (machines without GPUs).

        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::~GraphicsLayerChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 7 Sep 2010 23:03:49 +0000 (23:03 +0000)]
2010-09-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed.

        Add fast/canvas/webgl/gl-teximage.html (failing on chromium mac bot) to chromium/test_expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 7 Sep 2010 22:46:36 +0000 (22:46 +0000)]
2010-09-07  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, trivial expectations update.

        [Chromium/DRT] Remove expectation of crash for
        fast/js/date-preserve-milliseconds.html. It's now passing.

        * platform/chromium/drt_expectations.txt: Remove now-passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 7 Sep 2010 22:42:42 +0000 (22:42 +0000)]
2010-09-07  Adam Barth  <abarth@webkit.org>

        Minor tweaks to the reviewtool UI.

        Rename Cancel to Discard to make it more clear what the button does.
        Also, move the style declaration for the focus ring later in the sheet
        so it works.

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 7 Sep 2010 22:37:58 +0000 (22:37 +0000)]
2010-09-07  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, trivial test move.

        [Chromium/DRT] Correct a mistake made eons ago (probably by me)
        and make the test expectations agnostic to the flavor of Windows.

        * platform/chromium-win-xp/fast/multicol/client-rects-expected.checksum: Removed.
        * platform/chromium-win-xp/fast/multicol/client-rects-expected.png: Removed.
        * platform/chromium-win/fast/multicol/client-rects-expected.checksum: Updated.
        * platform/chromium-win/fast/multicol/client-rects-expected.png: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8381749> -Wcast-align warning emitted when building with clang
andersca@apple.com [Tue, 7 Sep 2010 22:35:25 +0000 (22:35 +0000)]
<rdar://problem/8381749> -Wcast-align warning emitted when building with clang

Reviewed by Darin Adler.

JavaScriptCore:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

* Configurations/Base.xcconfig:

JavaScriptGlue:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

* Configurations/Base.xcconfig:

WebCore:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

* Configurations/Base.xcconfig:

WebKit/mac:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

* Configurations/Base.xcconfig:

WebKit2:

Remove the -Wcast-align-warning since it isn't really useful, and clang is more aggressive about warning than gcc.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 7 Sep 2010 22:21:49 +0000 (22:21 +0000)]
2010-09-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed.

        Remove passing tests from chromium/test_expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 7 Sep 2010 22:21:02 +0000 (22:21 +0000)]
2010-09-07  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Make a public flag for how DRT generates bitmaps on Linux
        https://bugs.webkit.org/show_bug.cgi?id=45133

        This is so it's possible for me to fix
        http://code.google.com/p/chromium/issues/detail?id=21386 .

        * public/WebKit.h: Add areLayoutTestImagesOpaque()
        * src/WebKit.cpp:
        (WebKit::areLayoutTestImagesOpaque):
2010-09-07  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Make a public flag for how DRT generates bitmaps on Linux
        https://bugs.webkit.org/show_bug.cgi?id=45133

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::dumpImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 7 Sep 2010 21:57:48 +0000 (21:57 +0000)]
2010-09-07  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Adler.

        Remove redundant bounds check in originalText(). Add bounds check
        to previousCharacter(). No need of start() > 0 check since m_start
        is unsigned and we already do start() null check inside function.
        https://bugs.webkit.org/show_bug.cgi?id=45303

        Test: fast/text/one-letter-transform-crash.html

        * rendering/RenderTextFragment.cpp:
        (WebCore::RenderTextFragment::originalText):
        (WebCore::RenderTextFragment::previousCharacter):
2010-09-07  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Darin Adler.

        Tests that we dont hit assert i < m_length when trying to read
        previousCharacter for text fragments.
        https://bugs.webkit.org/show_bug.cgi?id=45303

        * fast/text/one-letter-transform-crash-expected.txt: Added.
        * fast/text/one-letter-transform-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 7 Sep 2010 21:53:14 +0000 (21:53 +0000)]
2010-09-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed.

        Remove passing tests from chromium/test_expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 7 Sep 2010 21:50:16 +0000 (21:50 +0000)]
2010-09-07  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Levin.

        Remove flakiness expectation for tests, fixed by r66861.
        https://bugs.webkit.org/show_bug.cgi?id=45311

        * platform/chromium/drt_expectations.txt: Removed tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 7 Sep 2010 21:24:12 +0000 (21:24 +0000)]
2010-09-07  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Regression in JPEG texture uploads on Mac OS X
        https://bugs.webkit.org/show_bug.cgi?id=45316

        Fixed regression introduced in
        https://bugs.webkit.org/show_bug.cgi?id=44566 . Added regression
        test covering this case to gl-teximage.html in Khronos repository
        and synced test with WebKit's version.

        * platform/graphics/cg/GraphicsContext3DCG.cpp:
        (WebCore::GraphicsContext3D::getImageData):
2010-09-07  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Regression in JPEG texture uploads on Mac OS X
        https://bugs.webkit.org/show_bug.cgi?id=45316

        Fixed regression introduced in
        https://bugs.webkit.org/show_bug.cgi?id=44566 . Added regression
        test covering this case to gl-teximage.html in Khronos repository
        and synced test with WebKit's version.

        * fast/canvas/webgl/gl-teximage-expected.txt:
        * fast/canvas/webgl/gl-teximage.html:
        * fast/canvas/webgl/resources/blue-1x1.jpg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother windows fix.
weinig@apple.com [Tue, 7 Sep 2010 21:07:22 +0000 (21:07 +0000)]
Another windows fix.

* UIProcess/win/WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 7 Sep 2010 21:00:04 +0000 (21:00 +0000)]
2010-09-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Implement --check-layout-test-sys-deps
        https://bugs.webkit.org/show_bug.cgi?id=45283

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
        * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
        * DumpRenderTree/chromium/TestShellGtk.cpp:
        (checkLayoutTestSystemDependencies): Add an empty implementation.
        * DumpRenderTree/chromium/TestShellMac.mm:
        (checkLayoutTestSystemDependencies): Add an empty implementation.
        * DumpRenderTree/chromium/TestShellWin.cpp:
        (checkLayoutTestSystemDependencies): Port similar function of test_shell.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry and fix windows.
weinig@apple.com [Tue, 7 Sep 2010 20:59:38 +0000 (20:59 +0000)]
Try and fix windows.

* UIProcess/WebEditCommandProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 7 Sep 2010 20:18:46 +0000 (20:18 +0000)]
2010-09-07  Martin Robinson  <mrobinson@igalia.com>

        Add rendering/ColumnInfo.h to the sources list.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=45317, encapsulate multi-column rectangle...
hyatt@apple.com [Tue, 7 Sep 2010 19:59:27 +0000 (19:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=45317, encapsulate multi-column rectangle information.

Reviewed by Beth Dakin.

* WebCore.xcodeproj/project.pbxproj:
* rendering/ColumnInfo.h: Added.
(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::desiredColumnWidth):
(WebCore::ColumnInfo::setDesiredColumnWidth):
(WebCore::ColumnInfo::desiredColumnCount):
(WebCore::ColumnInfo::setDesiredColumnCount):
(WebCore::ColumnInfo::columnCount):
(WebCore::ColumnInfo::columnRectAt):
(WebCore::ColumnInfo::clearColumns):
(WebCore::ColumnInfo::addColumnRect):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::setDesiredColumnCountAndWidth):
(WebCore::RenderBlock::desiredColumnWidth):
(WebCore::RenderBlock::desiredColumnCount):
(WebCore::RenderBlock::columnInfo):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):
* rendering/RenderBlock.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Tue, 7 Sep 2010 19:56:34 +0000 (19:56 +0000)]
2010-09-07  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Clean up a potential resource leak.
        https://bugs.webkit.org/show_bug.cgi?id=45198

        Several bitmap device context were being created and used,
        and destroyed without returning the context to its original
        state.  This showed up as bitmap leaks in BoundsChecker.

        * FullscreenVideoController.cpp:
        * WebView.cpp:
        (WebView::scrollBackingStore):
        (WebView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix incorrect parameter name.
weinig@apple.com [Tue, 7 Sep 2010 19:41:24 +0000 (19:41 +0000)]
Fix incorrect parameter name.

Reviewed by Darin Adler.

* UIProcess/API/mac/PageClientImpl.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/7794761> Floats inside of multicol fail to hit test
mitz@apple.com [Tue, 7 Sep 2010 19:40:56 +0000 (19:40 +0000)]
<rdar://problem/7794761> Floats inside of multicol fail to hit test
https://bugs.webkit.org/show_bug.cgi?id=44730

Reviewed by Dave Hyatt.

WebCore:

Test: fast/multicol/hit-test-float.html

Factored float hit-testing out of nodeAtPoint so that hitTestColumns could
call it with column-adjusted coordinates.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::hitTestColumns):
* rendering/RenderBlock.h:

LayoutTests:

* fast/multicol/hit-test-float-expected.txt: Added.
* fast/multicol/hit-test-float.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 François Sausset <sausset@gmail.com>
commit-queue@webkit.org [Tue, 7 Sep 2010 19:31:04 +0000 (19:31 +0000)]
2010-09-07  François Sausset  <sausset@gmail.com>

        Reviewed by Beth Dakin.

        Update to test the display attribute on the math element.
        https://bugs.webkit.org/show_bug.cgi?id=44206

        * mathml/presentation/attributes.xhtml:
        * platform/mac/mathml/presentation/attributes-expected.checksum:
        * platform/mac/mathml/presentation/attributes-expected.png:
        * platform/mac/mathml/presentation/attributes-expected.txt:
2010-09-07  François Sausset  <sausset@gmail.com>

        Reviewed by Beth Dakin.

        <math> element should be centered when display attribute set to block.
        https://bugs.webkit.org/show_bug.cgi?id=44206

        Test: mathml/presentation/attributes.xhtml

        * css/mathml.css:
        (math[display="block"]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Jessie Berlin <jberlin@apple.com>
jberlin@webkit.org [Tue, 7 Sep 2010 19:21:33 +0000 (19:21 +0000)]
2010-09-07  Jessie Berlin  <jberlin@apple.com>

        Unreviewed. Mac build fix.

        * MiniBrowser/mac/WebBundle/WebBundleMain.m:
        (didClearWindowObjectForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for Undo/Redo
weinig@apple.com [Tue, 7 Sep 2010 19:18:03 +0000 (19:18 +0000)]
Add support for Undo/Redo
<rdar://problem/7660519>
https://bugs.webkit.org/show_bug.cgi?id=42781

Reviewed by Darin Adler.

Adds platform independent parts of Undo/Redo support and the mac
platform support.

To work around the common assumption made by platforms, that a redo
item will be added synchronously while an undo is in progress, we
ignore the calls from WebCore to add redo items, and instead add add
them after telling WebCore to unapply the EditCommand. We similarly
need to ignore undos, that take place during a redo, and force the
addition ourselves.

* Shared/CoreIPCSupport/WebPageMessageKinds.h:
* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
Add new messages.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(-[WebEditCommandObjC initWithWebEditCommandProxy:WebKit::]):
(-[WebEditCommandObjC WebKit::]):
(-[WebEditorUndoTargetObjC undoEditing:]):
(-[WebEditorUndoTargetObjC redoEditing:]):
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::nameForEditAction):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::registerEditCommand):
(QWKPagePrivate::clearAllEditCommands):
* UIProcess/API/qt/qwkpage_p.h:
* UIProcess/PageClient.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::registerEditCommand):
(WebKit::WebView::clearAllEditCommands):
* UIProcess/win/WebView.h:
Add platform specific hooks for undo/redo.

* UIProcess/WebEditCommandProxy.cpp: Added.
(WebKit::WebEditCommandProxy::WebEditCommandProxy):
(WebKit::WebEditCommandProxy::~WebEditCommandProxy):
(WebKit::WebEditCommandProxy::unapply):
(WebKit::WebEditCommandProxy::reapply):
* UIProcess/WebEditCommandProxy.h: Added.
(WebKit::WebEditCommandProxy::create):
(WebKit::WebEditCommandProxy::commandID):
(WebKit::WebEditCommandProxy::editAction):
(WebKit::WebEditCommandProxy::invalidate):
A proxy for the WebEditCommands in the WebProcess. These are owned
by the platform back/forward list, with a weak reference back to the
WebPageProxy (which holds a weakset of live WebEditCommandProxys).

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::registerEditCommandForUndo):
(WebKit::WebPageProxy::clearAllEditCommands):
(WebKit::WebPageProxy::registerEditCommandForRedo):
(WebKit::WebPageProxy::addEditCommand):
(WebKit::WebPageProxy::removeEditCommand):
(WebKit::WebPageProxy::processDidExit):
* UIProcess/WebPageProxy.h:
Forward messages.

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::registerCommandForUndo):
(WebKit::WebEditorClient::registerCommandForRedo):
(WebKit::WebEditorClient::clearUndoRedoOperations):
Send undo/redo registration and clearing to the UIProcess.

* WebProcess/WebPage/WebEditCommand.cpp: Added.
(WebKit::generateCommandID):
(WebKit::WebEditCommand::WebEditCommand):
* WebProcess/WebPage/WebEditCommand.h: Added.
(WebKit::WebEditCommand::create):
(WebKit::WebEditCommand::command):
(WebKit::WebEditCommand::commandID):
Wrapper for WebCore::EditCommand, with an added unique ID.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::webEditCommand):
(WebKit::WebPage::addWebEditCommand):
(WebKit::WebPage::removeWebEditCommand):
(WebKit::WebPage::unapplyEditCommand):
(WebKit::WebPage::reapplyEditCommand):
(WebKit::WebPage::didRemoveEditCommand):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::isInRedo):
Forward messages.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 7 Sep 2010 18:46:21 +0000 (18:46 +0000)]
2010-09-07  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Chris Marrin.

        Avoid use of CA plugin in compositing tests so that they work on Windows
        https://bugs.webkit.org/show_bug.cgi?id=45312

        Convert tests to use <video> rather than a plugin, so that they have similar
        compositing behavior on Windows.

        * compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
        * compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
        * compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
        * compositing/geometry/limit-layer-bounds-fixed-positioned.html:
        * compositing/geometry/limit-layer-bounds-overflow-repaint.html:
        * compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
        * compositing/geometry/limit-layer-bounds-overflow-root.html:
        * compositing/geometry/limit-layer-bounds-positioned-expected.txt:
        * compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
        * compositing/geometry/limit-layer-bounds-positioned-transition.html:
        * compositing/geometry/limit-layer-bounds-positioned.html:
        * compositing/geometry/limit-layer-bounds-transformed-expected.txt:
        * compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
        * compositing/geometry/limit-layer-bounds-transformed-overflow.html:
        * compositing/geometry/limit-layer-bounds-transformed.html:
        * platform/mac/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 7 Sep 2010 18:29:29 +0000 (18:29 +0000)]
2010-09-07  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Media elements should derive from ActiveDOMObjects
        https://bugs.webkit.org/show_bug.cgi?id=45306
        <rdar://problem/7929062>

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize ActiveDOMObject
        (WebCore::HTMLMediaElement::stop): Call suspend, we want to do the same thing in both cases.
        (WebCore::HTMLMediaElement::suspend): Rename from documentWillBecomeInactive.
        (WebCore::HTMLMediaElement::resume): Rename from documentDidBecomeActive.
        (WebCore::HTMLMediaElement::hasPendingActivity): Return true if the event queue is not empty
        so the element can't be collected before they are sent.
        * html/HTMLMediaElement.h:
        (WebCore::HTMLMediaElement::canSuspend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Jessie Berlin <jberlin@apple.com>
jberlin@webkit.org [Tue, 7 Sep 2010 18:09:31 +0000 (18:09 +0000)]
2010-09-07  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Darin Adler.

        Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
        https://bugs.webkit.org/show_bug.cgi?id=45217

        WebKit2:

        * WebProcess/InjectedBundle/API/c/WKBundlePage.h:

        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
        (WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):

        WebKitTools:

        Make WebKitTestRunner work with this change.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::didClearWindowForFrame):
        Make sure the ScriptWorld here is the normal world, since that is no longer being done in
        WebFrameLoaderClient.
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 7 Sep 2010 18:02:36 +0000 (18:02 +0000)]
2010-09-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed.

        Add fast/text/atsui-spacing-features.html to test_expectations (failing on LINUX).

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 7 Sep 2010 17:38:22 +0000 (17:38 +0000)]
2010-09-07  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r66886.
        http://trac.webkit.org/changeset/66886
        https://bugs.webkit.org/show_bug.cgi?id=45112

        Made

        * platform/chromium/GeolocationServiceChromium.cpp:
        * platform/chromium/GeolocationServiceChromium.h:
2010-09-07  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r66886.
        http://trac.webkit.org/changeset/66886
        https://bugs.webkit.org/show_bug.cgi?id=45112

        Made

        * public/WebGeolocationService.h:
        * src/WebGeolocationServiceBridgeImpl.cpp:
        (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl):
        (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl):
        (WebKit::WebGeolocationServiceBridgeImpl::startUpdating):
        (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):
        (WebKit::WebGeolocationServiceBridgeImpl::suspend):
        (WebKit::WebGeolocationServiceBridgeImpl::resume):
        (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded):
        (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed):
        (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition):
        (WebKit::WebGeolocationServiceBridgeImpl::setLastError):
        (WebKit::WebGeolocationServiceBridgeImpl::getWebViewClient):
        (WebKit::WebGeolocationServiceBridgeImpl::onWebGeolocationServiceDestroyed):
        * src/WebGeolocationServiceMock.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 7 Sep 2010 17:22:18 +0000 (17:22 +0000)]
2010-09-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed.

        Rebaseline WIN LINUX for a few svg/dynamic-updates tests.

        * platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.checksum: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.checksum: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 7 Sep 2010 17:13:14 +0000 (17:13 +0000)]
2010-09-07  Martin Robinson  <mrobinson@igalia.com>

        Small build fix. Remove libWebCoreJS from CLEAN_FILES, as it
        is no longer built.

        * GNUmakefile.am: Remove reference to libWebCoreJS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 7 Sep 2010 17:10:51 +0000 (17:10 +0000)]
2010-09-07  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] [REGRESSION] r66848 caused a crash in testwebview
        https://bugs.webkit.org/show_bug.cgi?id=45298

        No new tests as this fixes a test failure.

        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::setGtkAdjustments): Don't actually attach the
        scrollbar adjustments unless this is a main frame ScrollView. If we do
        Scrollbars will be cast incorrectly to MainFrameScrollbarGtk, causing
        a segfault.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Kristian Monsen <kristianm@google.com>
commit-queue@webkit.org [Tue, 7 Sep 2010 16:44:55 +0000 (16:44 +0000)]
2010-09-07  Kristian Monsen  <kristianm@google.com>

        Reviewed by Steve Block.

        Compile fix for Android.
        https://bugs.webkit.org/show_bug.cgi?id=45292
        Explicitly add needed header for
        STRING_TO_V8PARAMETER_EXCEPTION_BLOCK as they do not get
        included through other headers on Android.

        No new tests, just a compile fix.

        * bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 7 Sep 2010 16:40:53 +0000 (16:40 +0000)]
2010-09-07  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Fix some feature guards
        https://bugs.webkit.org/show_bug.cgi?id=45302

        No new tests as this is just a build change.

        * platform/graphics/gstreamer/DataSourceGStreamer.cpp: Guard with #if ENABLE(VIDEO)
        * platform/graphics/gstreamer/DataSourceGStreamer.h: Ditto.
        * platform/graphics/gstreamer/GOwnPtrGStreamer.cpp: Ditto.
        * platform/graphics/gstreamer/GOwnPtrGStreamer.h: Ditto.
        * platform/graphics/gstreamer/GStreamerGWorld.cpp: Ditto.
        * platform/graphics/gstreamer/GStreamerGWorld.h: Ditto.
        * platform/graphics/gstreamer/ImageGStreamer.h: Ditto.
        * platform/graphics/gstreamer/ImageGStreamerCG.mm: Ditto.
        * platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Ditto.
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Ditto.
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Ditto.
        * platform/graphics/gstreamer/PlatformVideoWindow.h: Ditto.
        * platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp: Ditto.
        * platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: Ditto.
        * platform/graphics/gstreamer/VideoSinkGStreamer.cpp: Ditto.
        * platform/graphics/gstreamer/VideoSinkGStreamer.h: Ditto.
        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: Ditto.
        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.h: Ditto.
        * platform/gtk/GeolocationServiceGtk.cpp: Guard with ENABLE(GEOLOCATION)
        * platform/gtk/GeolocationServiceGtk.h: Ditto.
2010-09-07  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Fix some feature guards
        https://bugs.webkit.org/show_bug.cgi?id=45302

        * webkit/webkitprivate.h: Add ENABLE(VIDEO) guards for video specific members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Jonathan Dixon <joth@chromium.org>
jorlow@chromium.org [Tue, 7 Sep 2010 16:02:55 +0000 (16:02 +0000)]
2010-09-07  Jonathan Dixon  <joth@chromium.org>

        Reviewed by Jeremy Orlow.

        Access to out-of-scope WebGeolocationServiceBridgeImpl
        https://bugs.webkit.org/show_bug.cgi?id=45112

        Add missing virtual destructor to the abstract base class.

        * platform/chromium/GeolocationServiceChromium.cpp:
        (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
        * platform/chromium/GeolocationServiceChromium.h:
2010-09-07  Jonathan Dixon  <joth@chromium.org>

        Reviewed by Jeremy Orlow.

        Access to out-of-scope WebGeolocationServiceBridgeImpl
        https://bugs.webkit.org/show_bug.cgi?id=45112

        Keep the WebGeolocationService pointer for lifetime of the bridge, to
        ensure it can be detached reliably

        * public/WebGeolocationServiceBridge.h:
        (WebKit::WebGeolocationServiceBridge::~WebGeolocationServiceBridge):
        * src/WebGeolocationServiceBridgeImpl.cpp:
        (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl):
        (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl):
        (WebKit::WebGeolocationServiceBridgeImpl::startUpdating):
        (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):
        (WebKit::WebGeolocationServiceBridgeImpl::suspend):
        (WebKit::WebGeolocationServiceBridgeImpl::resume):
        (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 7 Sep 2010 15:55:21 +0000 (15:55 +0000)]
2010-09-07  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] [REGRESSION] r66848 caused a crash in testwebview
        https://bugs.webkit.org/show_bug.cgi?id=45298

        No new tests as this fixes a test failure.

        * platform/gtk/ScrollViewGtk.cpp:
        (WebCore::ScrollView::setGtkAdjustments): Don't actually attach the
        scrollbar adjustments unless this is a main frame ScrollView. If we do
        Scrollbars will be cast incorrectly to MainFrameScrollbarGtk, causing
        a segfault.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Satish Sampath <satish@chromium.org>
satish@chromium.org [Tue, 7 Sep 2010 15:55:12 +0000 (15:55 +0000)]
2010-09-07  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Disable a timing out speech input test for generated clicks.
        https://bugs.webkit.org/show_bug.cgi?id=45297

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Tue, 7 Sep 2010 15:15:58 +0000 (15:15 +0000)]
2010-09-07  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Darin Adler.

        REGRESSION(66741): Undefined pthread macros
        https://bugs.webkit.org/show_bug.cgi?id=45246

        PTHREAD_MUTEX_NORMAL and PTHREAD_MUTEX_DEFAULT (introduced in r60487) are not defined on Linux,
        but used in a statement. Add an additional check to test this.

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::initializeScavenger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Adam Langley <agl@chromium.org>
agl@chromium.org [Tue, 7 Sep 2010 14:53:31 +0000 (14:53 +0000)]
2010-09-07  Adam Langley  <agl@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Fix complex text word spacing on Linux.

        I broke complex text word spacing with r66689. I misnamed a
        variable in the original code |glyphIndex| when it was
        actually indexing code points. That meant that I compared it
        against the wrong limit when working around Harfbuzz issues
        and neatly disabled word spacing.

        https://bugs.webkit.org/show_bug.cgi?id=45191

        Test: fast/text/atsui-spacing-features.html

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::TextRunWalker::setGlyphXPositions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Renata Hodovan <reni@inf.u-szeged.hu>
commit-queue@webkit.org [Tue, 7 Sep 2010 14:07:15 +0000 (14:07 +0000)]
2010-09-07  Renata Hodovan  <reni@inf.u-szeged.hu>

        Reviewed by Dirk Schulze.

        SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change.
        https://bugs.webkit.org/show_bug.cgi?id=42244

        Adding layout tests for fePointLight dynamic changes.
        feSpotLight svgAttributeChanged covered the pointLight case as well so we don't need new C++ code.

        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.png: Added.
        * svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEPointLightElement-dom-x-attr.html: Added.
        * svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEPointLightElement-dom-y-attr.html: Added.
        * svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEPointLightElement-dom-z-attr.html: Added.
        * svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGFEPointLightElement-svgdom-x-prop.html: Added.
        * svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGFEPointLightElement-svgdom-y-prop.html: Added.
        * svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGFEPointLightElement-svgdom-z-prop.html: Added.
        * svg/dynamic-updates/script-tests/SVGFEPointLightElement-dom-x-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEPointLightElement-dom-y-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEPointLightElement-dom-z-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEPointLightElement-svgdom-x-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEPointLightElement-svgdom-y-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEPointLightElement-svgdom-z-prop.js: Added.
        (executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Pavel Podivilov <podivilov@chromium.org>
commit-queue@webkit.org [Tue, 7 Sep 2010 13:44:50 +0000 (13:44 +0000)]
2010-09-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: disable debugger tests on qt
        https://bugs.webkit.org/show_bug.cgi?id=45290

        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Satish Sampath <satish@chromium.org>
satish@chromium.org [Tue, 7 Sep 2010 13:27:54 +0000 (13:27 +0000)]
2010-09-07  Satish Sampath  <satish@chromium.org>

        Reviewed by Steve Block.

        Fix speech button's hit test logic for RTL rendering.
        https://bugs.webkit.org/show_bug.cgi?id=45288

        * fast/speech/input-text-speechbutton.html: Added RTL test case and merged JS code.
        * fast/speech/script-tests/input-text-speechbutton.js: Removed.
2010-09-07  Satish Sampath  <satish@chromium.org>

        Reviewed by Steve Block.

        Fix speech button's hit test logic for RTL rendering.
        https://bugs.webkit.org/show_bug.cgi?id=45288

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::forwardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Satish Sampath <satish@chromium.org>
satish@chromium.org [Tue, 7 Sep 2010 12:47:17 +0000 (12:47 +0000)]
2010-09-07  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Ignore programmatic clicks on speech input button for security reasons.
        https://bugs.webkit.org/show_bug.cgi?id=45181

        * fast/speech/speech-button-ignore-generated-events-expected.txt: Added.
        * fast/speech/speech-button-ignore-generated-events.html: Added.
2010-09-07  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Ignore programmatic clicks on speech input button for security reasons.
        https://bugs.webkit.org/show_bug.cgi?id=45181

        Test: fast/speech/speech-button-ignore-generated-events.html

        * rendering/TextControlInnerElements.cpp:
        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Pavel Podivilov <podivilov@chromium.org>
commit-queue@webkit.org [Tue, 7 Sep 2010 12:28:32 +0000 (12:28 +0000)]
2010-09-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: upstream two debugger tests
        https://bugs.webkit.org/show_bug.cgi?id=45262

        * inspector/debugger-pause-on-breakpoint-expected.txt: Added.
        * inspector/debugger-pause-on-breakpoint.html: Added.
        * inspector/debugger-pause-on-exception-expected.txt: Added.
        * inspector/debugger-pause-on-exception.html: Added.
        * platform/chromium/inspector/debugger-pause-on-exception-expected.txt: Added.
2010-09-07  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: upstream two debugger tests
        https://bugs.webkit.org/show_bug.cgi?id=45262

        * src/js/Tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 7 Sep 2010 12:11:40 +0000 (12:11 +0000)]
2010-09-07  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Provide DeviceOrientation LayoutTests
        https://bugs.webkit.org/show_bug.cgi?id=39590

        Adds several new DeviceOrientation tests. Also fixes some style in existing tests.

        * fast/dom/DeviceOrientation/add-listener-from-callback.html: Added.
        * fast/dom/DeviceOrientation/script-tests/add-listener-from-callback.js: Added.
        * fast/dom/DeviceOrientation/add-listener-from-callback-expected.txt: Added.
        * fast/dom/DeviceOrientation/multiple-frames.html: Added.
        * fast/dom/DeviceOrientation/script-tests/multiple-frames.js: Added.
        * fast/dom/DeviceOrientation/multiple-frames-expected.txt: Added.
        * fast/dom/DeviceOrientation/no-synchronous-events.html: Added.
        * fast/dom/DeviceOrientation/script-tests/no-synchronous-events.js: Added.
        * fast/dom/DeviceOrientation/no-synchronous-events-expected.txt: Added.
        * fast/dom/DeviceOrientation/null-values.html: Added.
        * fast/dom/DeviceOrientation/script-tests/null-values.js: Added.
        * fast/dom/DeviceOrientation/null-values-expected.txt: Added.
        * fast/dom/DeviceOrientation/updates.html: Added.
        * fast/dom/DeviceOrientation/script-tests/updates.js: Added.
        * fast/dom/DeviceOrientation/updates-expected.txt: Added.
        * fast/dom/DeviceOrientation/script-tests/basic-operation.js:
        * fast/dom/DeviceOrientation/script-tests/create-event.js:
        * fast/dom/DeviceOrientation/script-tests/optional-event-properties.js:
        * fast/dom/DeviceOrientation/script-tests/window-property.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Kent Hansen <kent.hansen@nokia.com>
kent.hansen@nokia.com [Tue, 7 Sep 2010 11:14:33 +0000 (11:14 +0000)]
2010-09-07  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] tst_QWebFrame::connectAndDisconnect() fails on WebKit trunk because __qt_sender__ is never set
        https://bugs.webkit.org/show_bug.cgi?id=44697

        When the signal handler is a JS function, __qt_sender__ is stuffed into a temporary
        object that's pushed onto the function's scope before the function is invoked, and
        popped again afterwards.

        We were pushing this new scope object _after_ calling JSFunction::getCallData(),
        and relying on JSC::call() to use the fresh scope chain from the function object.
        However, this is no longer the case; JSC::call() uses the scope chain passed in
        the CallData argument. Hence, we need to set up the scope before the function's
        CallData is queried.

        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtConnectionObject::execute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add platform specific expected results for new passing tests.
ossy@webkit.org [Tue, 7 Sep 2010 10:22:46 +0000 (10:22 +0000)]
[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

* platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.checksum: Added.
* platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.png: Added.
* platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
* platform/qt/fast/forms/placeholder-stripped-expected.checksum: Added.
* platform/qt/fast/forms/placeholder-stripped-expected.png: Added.
* platform/qt/fast/forms/placeholder-stripped-expected.txt: Added.
* platform/qt/fast/gradients/radial-centered-expected.checksum: Added.
* platform/qt/fast/gradients/radial-centered-expected.png: Added.
* platform/qt/fast/gradients/radial-centered-expected.txt: Added.
* platform/qt/fast/multicol/float-paginate-expected.checksum: Added.
* platform/qt/fast/multicol/float-paginate-expected.png: Added.
* platform/qt/fast/multicol/float-paginate-expected.txt: Added.
* platform/qt/fast/multicol/paginate-block-replaced-expected.checksum: Added.
* platform/qt/fast/multicol/paginate-block-replaced-expected.png: Added.
* platform/qt/fast/multicol/paginate-block-replaced-expected.txt: Added.
* platform/qt/fast/repaint/multicol-repaint-expected.checksum: Added.
* platform/qt/fast/repaint/multicol-repaint-expected.png: Added.
* platform/qt/fast/repaint/multicol-repaint-expected.txt: Added.
* platform/qt/fast/repaint/view-background-from-body-1-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-1-expected.checksum.
* platform/qt/fast/repaint/view-background-from-body-1-expected.png: Copied from LayoutTests/platform/qt/svg/custom/use-property-synchronization-crash-expected.png.
* platform/qt/fast/repaint/view-background-from-body-1-expected.txt: Copied from LayoutTests/platform/gtk/fast/repaint/view-background-from-body-1-expected.txt.
* platform/qt/fast/repaint/view-background-from-body-2-expected.checksum: Copied from LayoutTests/platform/mac/fast/repaint/view-background-from-body-2-expected.checksum.
* platform/qt/fast/repaint/view-background-from-body-2-expected.png: Added.
* platform/qt/fast/repaint/view-background-from-body-2-expected.txt: Copied from LayoutTests/platform/gtk/fast/repaint/view-background-from-body-2-expected.txt.
* platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.checksum: Added.
* platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
* platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Added.
* platform/qt/svg/css/composite-shadow-text-expected.checksum: Added.
* platform/qt/svg/css/composite-shadow-text-expected.png: Added.
* platform/qt/svg/css/composite-shadow-text-expected.txt: Added.
* platform/qt/svg/custom/bug45331-expected.checksum: Added.
* platform/qt/svg/custom/bug45331-expected.png: Added.
* platform/qt/svg/custom/bug45331-expected.txt: Added.
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.checksum: Added.
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.png: Added.
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.checksum: Added.
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png: Added.
* platform/qt/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
* platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.checksum: Added.
* platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png: Added.
* platform/qt/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
* platform/qt/svg/custom/marker-empty-path-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/marker-empty-path-expected.checksum.
* platform/qt/svg/custom/marker-empty-path-expected.png: Added.
* platform/qt/svg/custom/marker-empty-path-expected.txt: Added.
* platform/qt/svg/custom/mouse-move-on-svg-container-expected.checksum: Added.
* platform/qt/svg/custom/mouse-move-on-svg-container-expected.png: Added.
* platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.checksum: Added.
* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
* platform/qt/svg/custom/mouse-move-on-svg-root-expected.checksum: Added.
* platform/qt/svg/custom/mouse-move-on-svg-root-expected.png: Added.
* platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.checksum: Added.
* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Added.
* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
* platform/qt/svg/custom/non-scaling-stroke-markers-expected.checksum: Copied from LayoutTests/platform/mac/svg/custom/non-scaling-stroke-markers-expected.checksum.
* platform/qt/svg/custom/non-scaling-stroke-markers-expected.png: Added.
* platform/qt/svg/custom/non-scaling-stroke-markers-expected.txt: Added.
* platform/qt/svg/custom/pattern-incorrect-tiling-expected.checksum: Added.
* platform/qt/svg/custom/pattern-incorrect-tiling-expected.png: Added.
* platform/qt/svg/custom/pattern-incorrect-tiling-expected.txt: Added.
* platform/qt/svg/custom/pattern-no-pixelation-expected.checksum: Added.
* platform/qt/svg/custom/pattern-no-pixelation-expected.png: Added.
* platform/qt/svg/custom/pattern-no-pixelation-expected.txt: Added.
* platform/qt/svg/custom/use-font-face-crash-expected.checksum: Added.
* platform/qt/svg/custom/use-font-face-crash-expected.png: Added.
* platform/qt/svg/custom/use-font-face-crash-expected.txt: Added.
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.checksum: Added.
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
* platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
* platform/qt/transitions/svg-text-shadow-transition-expected.checksum: Added.
* platform/qt/transitions/svg-text-shadow-transition-expected.png: Added.
* platform/qt/transitions/svg-text-shadow-transition-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 7 Sep 2010 10:12:07 +0000 (10:12 +0000)]
2010-09-07  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, build fix.

        webkit-patch command to find the ports covering a specific layout test
        https://bugs.webkit.org/show_bug.cgi?id=42832

        * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
        tests are present when building the expectations. This is needed
        for the unittests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-06 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 7 Sep 2010 09:53:17 +0000 (09:53 +0000)]
2010-09-06  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Adam Barth.

        webkit-patch command to find the ports covering a specific layout test
        https://bugs.webkit.org/show_bug.cgi?id=42832

        To use it: webkit-patch skipped-ports some/layout/test.html

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/factory.py:
        * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
        * Scripts/webkitpy/tool/commands/queries.py:
        * Scripts/webkitpy/tool/commands/queries_unittest.py:
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/mocktool.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 7 Sep 2010 09:20:14 +0000 (09:20 +0000)]
2010-09-07  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        * platform/chromium/drt_expectations.txt: Remove a duplicated entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Arno Renevier <arno@renevier.net>
commit-queue@webkit.org [Tue, 7 Sep 2010 09:12:07 +0000 (09:12 +0000)]
2010-09-07  Arno Renevier  <arno@renevier.net>

        Reviewed by Holger Freyther.

        gitignore *~ files and gtk *.pot files
        https://bugs.webkit.org/show_bug.cgi?id=45129

        * .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Tue, 7 Sep 2010 08:51:13 +0000 (08:51 +0000)]
2010-09-07  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        Add ENABLE(INSPECTOR) guard in InspectorController::inspectorControllerForNode
        https://bugs.webkit.org/show_bug.cgi?id=45272

        Build fix.

        * inspector/InspectorController.h:
        (WebCore::InspectorController::inspectorControllerForNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Build fix.
ukai@chromium.org [Tue, 7 Sep 2010 08:50:43 +0000 (08:50 +0000)]
Unreviewed. Build fix.

Update test expectations for Chromium.

* platform/chromium-linux/svg/custom/use-invalid-pattern-expected.txt: Added.
* platform/chromium-mac/svg/custom/use-invalid-pattern-expected.txt: Added.
* platform/chromium-win/svg/custom/use-invalid-pattern-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 7 Sep 2010 08:38:14 +0000 (08:38 +0000)]
2010-09-07  Kent Tamura  <tkent@chromium.org>

        Reviewed by Ojan Vafai.

        Fix wrong position calculation of fast/forms/listbox-selection.html
        https://bugs.webkit.org/show_bug.cgi?id=45285

        * fast/forms/script-tests/listbox-selection.js:
        (mouseDownOnSelect): Refer window.pageYOffset after sl.focus()
        call because focus() might scroll the page.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 7 Sep 2010 08:35:06 +0000 (08:35 +0000)]
2010-09-07  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        Update DRT/Chromium expectations, and skip meter-percent-size.html
        for platforms without <meter> support.

        * platform/chromium/drt_expectations.txt:
        * platform/gtk/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Joerg Bornemann <joerg.bornemann@nokia.com>
commit-queue@webkit.org [Tue, 7 Sep 2010 08:28:49 +0000 (08:28 +0000)]
2010-09-07  Joerg Bornemann  <joerg.bornemann@nokia.com>

        Reviewed by Ariya Hidayat.

        Fix QtWebKit linker error on Windows CE 6.
        https://bugs.webkit.org/show_bug.cgi?id=43442

        Doesn't affect any tests.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 James Kozianski <koz@chromium.org>
commit-queue@webkit.org [Tue, 7 Sep 2010 08:12:18 +0000 (08:12 +0000)]
2010-09-07  James Kozianski  <koz@chromium.org>

        Reviewed by Kent Tamura.

        Adds tests for percent-based attributes on the <meter> element.

        * fast/dom/HTMLMeterElement/meter-percent-size-expected.txt: Added.
        * fast/dom/HTMLMeterElement/meter-percent-size.html: Added.
2010-09-07  James Kozianski  <koz@chromium.org>

        Reviewed by Kent Tamura.

        Crash rendering <meter/> with percent padding
        https://bugs.webkit.org/show_bug.cgi?id=45081

        Avoids a crash caused by RenderMeter checking its own dimensions to
        determine whether it needs layout. The crash is avoided by removing
        the check and always calling setNeedsLayout(true).

        Test: fast/dom/HTMLMeterElement/meter-percent-size.html

        * rendering/RenderIndicator.cpp:
        (WebCore::RenderIndicator::updateFromElement):
        * rendering/RenderIndicator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-07 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
commit-queue@webkit.org [Tue, 7 Sep 2010 07:30:20 +0000 (07:30 +0000)]
2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>

        Reviewed by Eric Seidel.

        [NRWT] Add temp directory to all running drivers.
        https://bugs.webkit.org/show_bug.cgi?id=45261

        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 7 Sep 2010 04:06:16 +0000 (04:06 +0000)]
2010-09-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        OOB read with svg polyline
        https://bugs.webkit.org/show_bug.cgi?id=45279

        In principle, attributeChanged can do anything.  If we supported more
        DOM mutation events, it could even run JavaScript.  That means we need
        to be prepared for the attribute map to change when running
        attributeChanged.  This patch makes this loop resilient to the
        attribute map changing by storing the list of changed attributes on the
        stack.

        Test: fast/parser/changing-attrbutes-crash.html

        * dom/Element.cpp:
        (WebCore::Element::setAttributeMap):
2010-09-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        OOB read with svg polyline
        https://bugs.webkit.org/show_bug.cgi?id=45279

        Test what happens when SVG changes the attribute map out from under us.

        * fast/parser/changing-attrbutes-crash-expected.txt: Added.
        * fast/parser/changing-attrbutes-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 7 Sep 2010 03:13:06 +0000 (03:13 +0000)]
2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium/DRT] Empty out user stylesheet after each test run.
        https://bugs.webkit.org/show_bug.cgi?id=45282

        This should significantly cut down on the number of the mysterious flaky tests
        whose diffs looked like the page was blown up to a very lage size. This
        was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
        which set the base body font to 100px.

        Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
        the same thread failed.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetWebSettings): Set user stylesheet to an empty URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-06 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 7 Sep 2010 03:05:41 +0000 (03:05 +0000)]
2010-09-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Do not generate pixel results for text/plain resources
        https://bugs.webkit.org/show_bug.cgi?id=45253

        * platform/chromium/drt_expectations.txt: Remove slow-utf8-text.pl failure.
2010-09-06  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Do not generate pixel results for text/plain resources
        https://bugs.webkit.org/show_bug.cgi?id=45253

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-06 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 7 Sep 2010 02:05:42 +0000 (02:05 +0000)]
2010-09-06  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Kent Tamura.

        print out correct error when a DRT thread dies in NRWT
        https://bugs.webkit.org/show_bug.cgi?id=45281

        Not sure why, but with the parens, python 2.6.5 on Linux
        gives an error that raise takes 5 arguments and 0 were given.
        Didn't test other platforms or python versions, but putting it
        all on one line fixes it and correctly prints the exception
        from the DRT thread.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-06 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 7 Sep 2010 00:31:38 +0000 (00:31 +0000)]
2010-09-06  Eric Seidel  <eric@webkit.org>

        Unreviewed, just adding some emails from lists.webkit.org.

        Update committers.py to include emails from lists.webkit.org
        as found by the validate-committer-lists script.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 6 Sep 2010 23:46:52 +0000 (23:46 +0000)]
2010-09-06  Adam Barth  <abarth@webkit.org>

        Small UI tweak to the reviewtool.  Make the Ok/Cancel buttons a bit
        bigger.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix
oliver@apple.com [Mon, 6 Sep 2010 23:44:49 +0000 (23:44 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 6 Sep 2010 23:39:28 +0000 (23:39 +0000)]
2010-09-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [reviewtool] Add a quick animation for opening/closing comment boxes
        https://bugs.webkit.org/show_bug.cgi?id=45278

        The 200ms animation slides in and out the line-by-line comment box.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix
oliver@apple.com [Mon, 6 Sep 2010 23:31:09 +0000 (23:31 +0000)]
Windows build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-09-06 Diego Gonzalez <diegohcg@webkit.org>
diegohcg@webkit.org [Mon, 6 Sep 2010 23:00:57 +0000 (23:00 +0000)]
2010-09-06  Diego Gonzalez  <diegohcg@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Update NetworkAccessManager in Qt FrameNetworkingContext
        https://bugs.webkit.org/show_bug.cgi?id=45231

        Make possible to get the current QNAM when NetwokingContext request it.

        * WebCoreSupport/FrameNetworkingContextQt.cpp:
        (WebCore::FrameNetworkingContextQt::networkAccessManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66853 268f45cc-cd09-0410-ab3c-d52691b4dbfc