WebKit-https.git
5 years agoFix post-mortem nits for r173528 & r173549
cdumez@apple.com [Mon, 15 Sep 2014 05:40:56 +0000 (05:40 +0000)]
Fix post-mortem nits for r173528 & r173549
https://bugs.webkit.org/show_bug.cgi?id=136808

Reviewed by Darin Adler.

Fix post-mortem nits for r173528 & r173549.

No new tests, no behavior change.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::alternativeTextForWebArea):
- Use auto* instead of more specific types.
- Use fastGetAttribute() instead of getAttribute() as this is
  supported for the "title" attribute.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelectionFromNone):
Use auto* instead of more specific types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoIntroduce FONT_DATA_TYPE_CASTS, and use it
gyuyoung.kim@samsung.com [Mon, 15 Sep 2014 04:29:26 +0000 (04:29 +0000)]
Introduce FONT_DATA_TYPE_CASTS, and use it
https://bugs.webkit.org/show_bug.cgi?id=136766

Reviewed by Darin Adler.

As a step to use toFoo, this patch introduces FONT_DATA_TYPE_CASTS macro for toFooFontData().
This will help to detect wrong type cast.

* platform/graphics/FontData.h:
* platform/graphics/FontGlyphs.cpp:
(WebCore::FontGlyphs::releaseFontData):
(WebCore::FontGlyphs::determinePitch):
* platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
* platform/graphics/SegmentedFontData.h:
* platform/graphics/SimpleFontData.h:
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCompositeFontReferenceFontData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGenerate toCSSStyleSheet using STYLE_SHEET_TYPE_CASTS
gyuyoung.kim@samsung.com [Mon, 15 Sep 2014 04:07:32 +0000 (04:07 +0000)]
Generate toCSSStyleSheet using STYLE_SHEET_TYPE_CASTS
https://bugs.webkit.org/show_bug.cgi?id=136774

Reviewed by Darin Adler.

As a step to use toFoo, this patch introduces STYLE_SHEET_TYPE_CASTS for toCSSStyleSheet().
This will help to detect wrong type cast. Additonally this patch helps to remove argument type of RefPtr.

No new tests, no behavior changes.

* bindings/gobject/WebKitDOMPrivate.cpp:
(WebKit::wrap):
* css/CSSStyleSheet.h:
* css/StyleSheet.h:
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::filterEnabledNonemptyCSSStyleSheets):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::parseStyleSheet):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::collectStyleSheets):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGenerate toFooElementData() using ELEMENT_DATA_TYPE_CASTS
gyuyoung.kim@samsung.com [Mon, 15 Sep 2014 03:40:20 +0000 (03:40 +0000)]
Generate toFooElementData() using ELEMENT_DATA_TYPE_CASTS
https://bugs.webkit.org/show_bug.cgi?id=136775

Reviewed by Darin Adler.

As a step to use toFoo, this patch introduces ELEMENT_DATA_TYPE_CASTS for toFooElementData().
This will help to detect wrong type cast. Additonally this patch helps to remove argument type of RefPtr.

No new tests, no behavior changes.

* dom/Element.cpp:
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createUniqueElementData):
* dom/ElementData.cpp:
(WebCore::ElementData::destroy):
* dom/ElementData.h:
(WebCore::ElementData::length):
(WebCore::ElementData::attributeBase):
(WebCore::ElementData::presentationAttributeStyle):
(WebCore::ElementData::attributesIterator):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setupInitialView): Remove static_cast<SVGSVGElement*>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove unnecessary overloads taking a ContainerNode in Element Traversal
cdumez@apple.com [Mon, 15 Sep 2014 02:23:01 +0000 (02:23 +0000)]
Remove unnecessary overloads taking a ContainerNode in Element Traversal
https://bugs.webkit.org/show_bug.cgi?id=136767

Reviewed by Darin Adler.

Remove unnecessary overloads taking a ContainerNode in Element Traversal.
Several of those don't bring any performance improvements as the needed
methods are defined on Node (not ContainerNode).

No new tests, no behavior change.

* dom/ElementTraversal.h:
(WebCore::Traversal<Element>::previous):
NodeTraversal::previous() takes a const Node* in argument so the
ContainerNode overload is not needed.

(WebCore::Traversal<ElementType>::previous):
Unnecessary now that Traversal<Element>::previous() takes a const Node*
in argument.

(WebCore::Traversal<ElementType>::nextSibling):
nextSibling() is defined on Node, not ContainerNode, so the overload
is not needed.

(WebCore::Traversal<ElementType>::previousSibling):
previousSibling() is defined on Node, not ContainerNode, so the overload
is not needed.

(WebCore::Traversal<Element>::previousTemplate): Deleted.
(WebCore::Traversal<ElementType>::previousTemplate): Deleted.
(WebCore::Traversal<ElementType>::nextSiblingTemplate): Deleted.
(WebCore::Traversal<ElementType>::previousSiblingTemplate): Deleted.
No need to have those functions templated anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Attempt to fix the iOS build after <http://trac.webkit.org/changeset/173606>
dbates@webkit.org [Mon, 15 Sep 2014 01:51:56 +0000 (01:51 +0000)]
[iOS] Attempt to fix the iOS build after <trac.webkit.org/changeset/173606>
(https://bugs.webkit.org/show_bug.cgi?id=136789)

Substitute Node::countChildNodes() for Node::childNodeCount() in more places.

Source/WebCore:

Although I updated a comment in WebCore::lastOffsetForEditing() (defined in file
editing/htmlediting.cpp) to refer to Node::countChildNodes(), I'm unclear what the
comment is trying to explain that isn't otherwise explained by the code or the
comments that precede this function. Specifically, I don't understand the use of
the word "preempt" in the comment. We should look to improve the readability of
this comment.

* editing/htmlediting.cpp:
(WebCore::lastOffsetForEditing):
* page/ios/FrameIOS.mm:
(WebCore::Frame::interpretationsForCurrentRoot):

Source/WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame focusedNodeHasContent]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDrop NodeTraversal::nextSkippingChildren() overload taking a ContainerNode
cdumez@apple.com [Sun, 14 Sep 2014 22:19:19 +0000 (22:19 +0000)]
Drop NodeTraversal::nextSkippingChildren() overload taking a ContainerNode
https://bugs.webkit.org/show_bug.cgi?id=136764

Reviewed by Darin Adler.

Drop NodeTraversal::nextSkippingChildren() overload taking a
ContainerNode argument. This one does not bring any performance
improvement because nextSibling() is defined on Node and
nextAncestorSibling() takes a Node in argument.

Also remove the overload in ElementTraversal as it no longer makes
sense after this change.

No new tests, no behavior change.

* dom/ElementTraversal.h:
(WebCore::Traversal<ElementType>::nextSkippingChildren):
(WebCore::Traversal<ElementType>::nextSkippingChildrenTemplate): Deleted.
* dom/NodeTraversal.h:
(WebCore::NodeTraversal::nextSkippingChildren):
(WebCore::NodeTraversal::next):
(WebCore::NodeTraversal::traverseNextSkippingChildrenTemplate): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
cdumez@apple.com [Sun, 14 Sep 2014 21:18:27 +0000 (21:18 +0000)]
Rename Node::childNodeCount() to countChildNodes() and avoid inefficient uses
https://bugs.webkit.org/show_bug.cgi?id=136789

Reviewed by Darin Adler.

Source/WebCore:

Rename Node::childNodeCount() to countChildNodes() to make it clearer
that the method actually computes the result rather than returning a
cached value.

This patch also introduces a new Node::hasOneChild() method that is
used to check if a Node has a single child. This is much more efficient
than calling countChildNodes() == 1.

The patch also leverages Node::hasChildNodes() in a lot of places
instead of calling countChildNodes().

Finally, in a couple of places, we now use childrenOfType() to iterate
over children more efficient than using countChildNodes() and
childNode(index).

No new tests, no behavior change.

* WebCore.exp.in:
* WebCore.order:
Update the name of the exposed symbol for countChildNodes().

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::countChildNodes):
(WebCore::ContainerNode::childNodeCount): Deleted.
Rename childNodeCount() to countChildNodes() to make it obvious it is
computing the result rather than returning a cached value.

* dom/ContainerNode.h:
(WebCore::ContainerNode::hasOneChild):
Introduce an efficient way to check in a ContainerNode has a single
child as "countChildNodes() == 1" calls were frequent and inefficient.

(WebCore::Node::countChildNodes):
(WebCore::Node::childNodeCount): Deleted.
* dom/Node.h:
Rename childNodeCount() to countChildNodes().

* dom/Position.cpp:
(WebCore::Position::parentAnchoredEquivalent):
* dom/Position.h:
(WebCore::lastOffsetInNode):
* dom/Range.cpp:
Mechanical renaming.

(WebCore::lengthOfContentsInNode):
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::shouldApplyInlineStyleToRun):
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
(WebCore::ApplyStyleCommand::applyInlineStyleChange):
Call hasChildNodes() rather than countChildNodes() as it is a lot more
efficient.

* editing/Editor.cpp:
(WebCore::Editor::setTextAsChildOfElement):
(WebCore::Editor::rangeOfString):
(WebCore::Editor::countMatchesForText):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::elementRangeContainingCaretSelection):
Mechanical renaming.

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::insertAsListItems):
Call hasOneChild() instead of countChildNodes() == 1. Also remove
redundant listElement->hasChildNodes() check as hasOneChild() takes
care of this already.

* editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
* editing/VisibleUnits.cpp:
(WebCore::endOfDocument):
* editing/htmlediting.cpp:
(WebCore::lastOffsetForEditing):
Mechanical renaming.

(WebCore::visiblePositionBeforeNode):
(WebCore::visiblePositionAfterNode):
Call hasChildNodes() instead of converting countChildNodes() to a
boolean.

* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::traverseNodesForSerialization):
Call !hasChildNodes() instead of !countChildNodes().

(WebCore::isPlainTextMarkup):
- Drop !node->isElementNode() check as !node->hasTagName(divTag) takes
  care of discarding non-Element Nodes already.
- Cast the Node to an HTMLDivElement as soon as possible to avoid
  calling calling the slower Node APIs in several cases.
- Call hasOneChild() instead of countChildNodes() == 1.

* html/HTMLDivElement.h:
* html/HTMLTagNames.in:
Generate casting helpers as I use them in WebCore::isPlainTextMarkup().

* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::setText):
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::setText):
Call hasOneChild() / hasChildNodes() instead of countChildNodes().

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTimelineContainerElement::setTimeDisplaysHidden):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
Use childrenOfType<Element>() to iterate of child Elements instead of
slower childNodeCount() + childNode(index) + isElementNode(). Also,
childNodeCount() was not even cached before the loop.

* html/track/VTTRegion.cpp:
(WebCore::VTTRegion::displayLastTextTrackCueBox):
Use childrenOfType<Element>() to iterate of child Elements, thus
avoiding calling childNodeCount() + childNode(index).

* page/DOMSelection.cpp:
(WebCore::DOMSelection::extend):
(WebCore::DOMSelection::selectAllChildren):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::caretMaxOffset):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::isSelected):
* rendering/RenderView.cpp:
(WebCore::RenderView::splitSelectionBetweenSubtrees):
Mechanical renaming.

Source/WebKit/mac:

Rename childNodeCount() to countChildNodes().

* WebView/WebHTMLView.mm:
(-[WebHTMLView attributedString]):

Source/WebKit2:

Avoid calling slow Node::countChildNodes().

* WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp:
(WebKit::WebPage::findZoomableAreaForPoint):
Replace call to "node->parentNode()->childNodeCount() != 1" by
"!node->parentNode()->hasOneChild()" which is equivalent but more
efficient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUn-inline Element constructor
cdumez@apple.com [Sat, 13 Sep 2014 23:21:28 +0000 (23:21 +0000)]
Un-inline Element constructor
https://bugs.webkit.org/show_bug.cgi?id=136786

Reviewed by Benjamin Poulain.

Un-inline Element constructor as it is non-trivial and it does not seem
to impact performance based on my testing:
http://dromaeo.com/?id=226865,226869

This reduces the stripped binary size by 8 Kb.

No new tests, no behavior change.

* dom/Element.cpp:
(WebCore::Element::Element):
* dom/Element.h:
(WebCore::Element::Element): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMerge JSGlobalObject::reset() into ::init()
msaboff@apple.com [Sat, 13 Sep 2014 16:26:04 +0000 (16:26 +0000)]
Merge JSGlobalObject::reset() into ::init()
https://bugs.webkit.org/show_bug.cgi?id=136800

Reviewed by Oliver Hunt.

Moved the contents of reset() into init().
Note that the diff shows more changes.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init): Moved body of reset() into init.
(JSC::JSGlobalObject::put):
(JSC::JSGlobalObject::defineOwnProperty):
(JSC::JSGlobalObject::addGlobalVar):
(JSC::JSGlobalObject::addFunction):
(JSC::lastInPrototypeChain):
(JSC::JSGlobalObject::reset): Deleted.
* runtime/JSGlobalObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd JSCallee to program and eval CallFrames
msaboff@apple.com [Sat, 13 Sep 2014 05:21:44 +0000 (05:21 +0000)]
Add JSCallee to program and eval CallFrames
https://bugs.webkit.org/show_bug.cgi?id=136785

Reviewed by Mark Lam.

Populated Callee slot for program and call eval CallFrames with a JSCallee objects.
Made supporting changes including adding a JSCallee structure to global object and adding
JSCallee::create() method.  Added code so that the newly added callee object won't be
returned by Function.caller.  Changed null pointer checks of callee to check the if
the type is JSFunction* or JSCallee*.

* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::functionName):
(JSC::DebuggerCallFrame::type):
* profiler/LegacyProfiler.cpp:
(JSC::LegacyProfiler::createCallIdentifier):
* interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
Changed checks of callee is a JSFunction* or JSCallee* instead of just checking
if it is null or not.

* interpreter/Interpreter.cpp:
(JSC::Interpreter::execute): Create and use JSCallee objects for execute(EvalExecutable, ...)
and execute(ProgramExecutable, ...)

* jit/JITCode.cpp:
(JSC::JITCode::execute): Use jsDynamicCast to cast only JSFunctions.

* runtime/JSCallee.cpp:
(JSC::JSCallee::create): Not used, therefore deleted.

* runtime/JSCallee.h:
(JSC::JSCallee::create): Added.

* runtime/JSFunction.cpp:
(JSC::JSFunction::callerGetter): Added test to return null for JSCallee's that aren't
JSFunction's.  This can only be the case when the JSCallee comes from a program or
call eval CallFrame.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::calleeStructure):
Added new JSCallee structure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBuild fix with REQUEST_AUTOCOMPLETE enabled
jhoneycutt@apple.com [Sat, 13 Sep 2014 02:18:56 +0000 (02:18 +0000)]
Build fix with REQUEST_AUTOCOMPLETE enabled

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::requestAutocomplete):
(WebCore::HTMLFormElement::finishRequestAutocomplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRe-add the request autocomplete feature
jhoneycutt@apple.com [Sat, 13 Sep 2014 01:01:02 +0000 (01:01 +0000)]
Re-add the request autocomplete feature

<https://bugs.webkit.org/show_bug.cgi?id=136730>

This feature was rolled out in r148731 because it was only used by
Chromium. As we consider supporting this feature, roll it back in, but
leave it disabled.

This rolls out r148731 (which removed the feature) with small changes
Source/JavaScriptCore:

needed to make the code build in ToT, to match modern style, to make
the tests run, and to remove unused code.

Reviewed by Andy Estes.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

needed to make the code build in ToT, to match modern style, to make
the tests run, and to remove unused code.

Reviewed by Andy Estes.

Tests: fast/events/constructors/autocomplete-error-event-constructor.html
       fast/forms/form-request-autocomplete.html

* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* dom/AutocompleteErrorEvent.h: Added.
(WebCore::AutocompleteErrorEvent::create):
(WebCore::AutocompleteErrorEvent::reason):
(WebCore::AutocompleteErrorEvent::AutocompleteErrorEvent):
* dom/AutocompleteErrorEvent.idl: Added.
* dom/EventNames.h:
* dom/EventNames.in:
* html/HTMLAttributeNames.in:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore::HTMLFormElement::requestAutocomplete):
(WebCore::HTMLFormElement::finishRequestAutocomplete):
(WebCore::HTMLFormElement::requestAutocompleteTimerFired):
(WebCore::HTMLFormElement::parseAttribute):
* html/HTMLFormElement.h:
* html/HTMLFormElement.idl:
* loader/EmptyClients.h:
* loader/FrameLoaderClient.h:
* page/DOMWindow.idl:

Source/WebKit/mac:

needed to make the code build in ToT, to match modern style, to make
the tests run, and to remove unused code.

Reviewed by Andy Estes.

* Configurations/FeatureDefines.xcconfig:
* WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit2:

needed to make the code build in ToT, to match modern style, to make
the tests run, and to remove unused code.

Reviewed by Andy Estes.

* Configurations/FeatureDefines.xcconfig:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didRequestAutocomplete):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WTF:

needed to make the code build in ToT, to make the tests run, and to
remove unused code.

Reviewed by Andy Estes.

* wtf/FeatureDefines.h:

LayoutTests:

needed to make the code build in ToT, to match modern style, to make
the tests run, and to remove unused code.

Reviewed by Andy Estes.

* fast/events/constructors/autocomplete-error-event-constructor-expected.txt: Added.
* fast/events/constructors/autocomplete-error-event-constructor.html: Added.
* fast/events/event-creation.html:
* fast/forms/form-request-autocomplete-expected.txt: Added.
* fast/forms/form-request-autocomplete.html: Added.
* js/dom/constructor-length.html:
* platform/efl/js/dom/constructor-length-expected.txt:
* platform/gtk/js/dom/constructor-length-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSwiping back from a Twitter image to Twitter flashes to the wrong position
timothy_horton@apple.com [Sat, 13 Sep 2014 00:59:33 +0000 (00:59 +0000)]
Swiping back from a Twitter image to Twitter flashes to the wrong position
https://bugs.webkit.org/show_bug.cgi?id=136798
<rdar://problem/18324338>

Reviewed by Darin Adler and Sam Weinig.

* UIProcess/mac/ViewGestureController.h:
* UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::didFinishLoadForMainFrame):
(WebKit::ViewGestureController::didSameDocumentNavigationForMainFrame):
Add a 250ms repeating timer that we start in didFinishLoadForMainFrame
if we are for some reason still loading, and in didSameDocumentNavigationForMainFrame
unconditionally, to match behavior of the old swipe implementation.

Also, do the active gesture check in both of those places so that we don't
start the timer if we're in the middle of a live swipe or have already torn
down the snapshot (removeSwipeSnapshotAfterRepaint does this as well, so
this isn't really a behavior change).

(WebKit::ViewGestureController::activeLoadMonitoringTimerFired):
Every time the timer fires, check if we're still loading; if not,
tear down the swipe snapshot (after repainting).

(WebKit::ViewGestureController::removeSwipeSnapshotAfterRepaint):
Stop the active load monitoring timer.

* wtf/RunLoop.h:
(WTF::RunLoop::TimerBase::startRepeating):
Add a std::chrono veresion of RunLoop::TimerBase::startRepeating.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: remind about rebaselining generator test results
burg@cs.washington.edu [Sat, 13 Sep 2014 00:35:19 +0000 (00:35 +0000)]
Web Inspector: remind about rebaselining generator test results
https://bugs.webkit.org/show_bug.cgi?id=136759

Reviewed by Joseph Pecoraro.

For now, we can implement this as a watchlist message. Add watchlist
groups and messages for the inspector and web replay generators.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agobuild.webkit.org/dashboard: Overlapping text when status is long
ap@apple.com [Sat, 13 Sep 2014 00:24:53 +0000 (00:24 +0000)]
build.webkit.org/dashboard: Overlapping text when status is long
https://bugs.webkit.org/show_bug.cgi?id=136794

Reviewed by Timothy Hatcher.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line): Replaces height with min-height.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd -webkit-appearance and pseudo element tests for quirks mode
utatane.tea@gmail.com [Sat, 13 Sep 2014 00:09:15 +0000 (00:09 +0000)]
Add -webkit-appearance and pseudo element tests for quirks mode
https://bugs.webkit.org/show_bug.cgi?id=136366

Reviewed by Benjamin Poulain.

* fast/css/appearance-with-pseudo-elements-expected.html:
-webkit-appearance in OSX affects the ::first-letter related style informations (such as font).
So expected.html also requires these styles.
* fast/css/appearance-with-pseudo-elements-in-quirks-mode-expected.html: Added.
* fast/css/appearance-with-pseudo-elements-in-quirks-mode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCanvasRenderingContext2D should update the computed style while setting the font
vivek.vg@samsung.com [Sat, 13 Sep 2014 00:07:10 +0000 (00:07 +0000)]
CanvasRenderingContext2D should update the computed style while setting the font
https://bugs.webkit.org/show_bug.cgi?id=136737

Reviewed by Darin Adler.

Source/WebCore:

Before accessing the computed style for populating 'font' property of CanvasRenderingContext2D
make sure to have an up-to-date computed style avoiding any stale reference.

Test: fast/canvas/canvas-set-font-with-updated-style.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):

LayoutTests:

* fast/canvas/canvas-set-font-with-updated-style-expected.txt: Added.
* fast/canvas/canvas-set-font-with-updated-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCSS JIT: Apply CSS JIT to SelectorQuery with multiple selectors
utatane.tea@gmail.com [Sat, 13 Sep 2014 00:03:33 +0000 (00:03 +0000)]
CSS JIT: Apply CSS JIT to SelectorQuery with multiple selectors
https://bugs.webkit.org/show_bug.cgi?id=135255

Reviewed by Benjamin Poulain.

Source/WebCore:

After dropping SelectorCheckerFastPath, Dromaeo cssquery-jquery test
result becomes significantly worse. 400.26/s to 348.16/s, 13%
performance regression.

Investigated the cause of it and we found that the test results for
querySelector with multiple selectors causes performance regressions.

To solve this, we attempt to JIT compile all selectors in multiple
selectors. And if compiling some selectors is failed, SelectorQuery
fallbacks to the slower implementation.

This change improves the performance. After applying this patch,
cssquery-jquery test result becomes 418.71/s, 4.61% better than the
previous good performance case.

Test: fast/selectors/querySelector-multiple-selectors.html

* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::SelectorDataList):
(WebCore::SelectorDataList::executeCompiledSingleMultiSelectorData):
(WebCore::SelectorDataList::execute):
* dom/SelectorQuery.h:

LayoutTests:

* fast/selectors/querySelector-multiple-selectors-expected.txt: Added.
* fast/selectors/querySelector-multiple-selectors.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFixed a goof in bmalloc Vector sizing
ggaren@apple.com [Fri, 12 Sep 2014 23:47:56 +0000 (23:47 +0000)]
Fixed a goof in bmalloc Vector sizing
https://bugs.webkit.org/show_bug.cgi?id=136795

Reviewed by Gavin Barraclough and Sam Weinig.

We want our minimum vector to be page-sized since the OS will give us
a page no matter what -- but we want that many bytes, and not enough
bytes to store that many elements.

* bmalloc/Vector.h: Math is hard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake Brian Burg a WebKit reviewer.
timothy@apple.com [Fri, 12 Sep 2014 23:37:34 +0000 (23:37 +0000)]
Make Brian Burg a WebKit reviewer.

* Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMultiple EWS or commit bots can pick up processing of the same patch
ap@apple.com [Fri, 12 Sep 2014 23:33:04 +0000 (23:33 +0000)]
Multiple EWS or commit bots can pick up processing of the same patch
https://bugs.webkit.org/show_bug.cgi?id=136793

Reviewed by Ryosuke Niwa.

Change timeout from one hour to two hours. This will let bots finish, and in the
unlikely event of a bot being frozen, will only delay patch processing restart by
one hour.

* QueueStatusServer/app.yaml:
* QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed gardening.
jer.noble@apple.com [Fri, 12 Sep 2014 23:04:57 +0000 (23:04 +0000)]
Unreviewed gardening.

- Unskip some passing tests.
- Move flakey tests into flakey test section.
- Move non-media tests out of the media section.
- Mark WontFix tests as such.

* platform/mac/TestExpectations:
* platform/mac/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
* platform/mac/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Fullscreen] Taking embedded youtube video full screen takes the whole page full...
jer.noble@apple.com [Fri, 12 Sep 2014 23:02:42 +0000 (23:02 +0000)]
[Fullscreen] Taking embedded youtube video full screen takes the whole page full screen
https://bugs.webkit.org/show_bug.cgi?id=136792

Reviewed by Beth Dakin.

Recalculate style after beginning the enter fullscreen animation, but before sending the
"webkitfullscreenchange" event to listeners.

* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImport (some of) the W3C CSSWG flexbox tests
dino@apple.com [Fri, 12 Sep 2014 22:41:09 +0000 (22:41 +0000)]
Import (some of) the W3C CSSWG flexbox tests
https://bugs.webkit.org/show_bug.cgi?id=136787
<rdar://problem/18325725>

Reviewed by Benjamin Poulain.

Take most of the tests from http://test.csswg.org/suites/css3-flexbox/nightly-unstable/html/toc.htm
and import them into LayoutTests.

I had to rearrange some things to follow our testing approach,
and I only included the ref tests. There are a handful of failures,
marked in TestExpectations, and tracked by:
https://bugs.webkit.org/show_bug.cgi?id=136754

* TestExpectations:
* css3/flexbox/csswg/Flexible-order-expected.html: Added.
* css3/flexbox/csswg/Flexible-order.html: Added.
* css3/flexbox/csswg/align-content-001-expected.html: Added.
* css3/flexbox/csswg/align-content-001.html: Added.
* css3/flexbox/csswg/css-box-justify-content-expected.html: Added.
* css3/flexbox/csswg/css-box-justify-content.html: Added.
* css3/flexbox/csswg/css-flexbox-column-expected.html: Added.
* css3/flexbox/csswg/css-flexbox-column.html: Added.
* css3/flexbox/csswg/css-flexbox-height-animation-stretch-expected.html: Added.
* css3/flexbox/csswg/css-flexbox-height-animation-stretch.html: Added.
* css3/flexbox/csswg/css-flexbox-img-expand-evenly-expected.html: Added.
* css3/flexbox/csswg/css-flexbox-img-expand-evenly.html: Added.
* css3/flexbox/csswg/css-flexbox-row-expected.html: Added.
* css3/flexbox/csswg/css-flexbox-row.html: Added.
* css3/flexbox/csswg/css-flexbox-test1-expected.html: Added.
* css3/flexbox/csswg/css-flexbox-test1.html: Added.
* css3/flexbox/csswg/flex-align-items-center-expected.html: Added.
* css3/flexbox/csswg/flex-align-items-center.html: Added.
* css3/flexbox/csswg/flex-box-wrap-expected.html: Added.
* css3/flexbox/csswg/flex-box-wrap.html: Added.
* css3/flexbox/csswg/flex-container-margin-expected.html: Added.
* css3/flexbox/csswg/flex-container-margin.html: Added.
* css3/flexbox/csswg/flex-direction-expected.html: Added.
* css3/flexbox/csswg/flex-direction-modify-expected.html: Added.
* css3/flexbox/csswg/flex-direction-modify.html: Added.
* css3/flexbox/csswg/flex-direction-with-element-insert-expected.html: Added.
* css3/flexbox/csswg/flex-direction-with-element-insert.html: Added.
* css3/flexbox/csswg/flex-direction-with-element-insert.html-expected.html: Added.
* css3/flexbox/csswg/flex-direction.html: Added.
* css3/flexbox/csswg/flex-direction.html-expected.html: Added.
* css3/flexbox/csswg/flex-flexitem-childmargin-expected.html: Added.
* css3/flexbox/csswg/flex-flexitem-childmargin.html: Added.
* css3/flexbox/csswg/flex-flexitem-percentage-prescation-expected.html: Added.
* css3/flexbox/csswg/flex-flexitem-percentage-prescation.html: Added.
* css3/flexbox/csswg/flex-flow-001-expected.html: Added.
* css3/flexbox/csswg/flex-flow-001.html: Added.
* css3/flexbox/csswg/flex-flow-002-expected.html: Added.
* css3/flexbox/csswg/flex-flow-002.html: Added.
* css3/flexbox/csswg/flex-flow-007-expected.html: Added.
* css3/flexbox/csswg/flex-flow-007.html: Added.
* css3/flexbox/csswg/flex-items-flexibility-expected.html: Added.
* css3/flexbox/csswg/flex-items-flexibility.html: Added.
* css3/flexbox/csswg/flex-items-flexibility.html-expected.html: Added.
* css3/flexbox/csswg/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html: Added.
* css3/flexbox/csswg/flex-lines/multi-line-wrap-reverse-column-reverse.html: Added.
* css3/flexbox/csswg/flex-lines/multi-line-wrap-reverse-row-reverse-expected.html: Added.
* css3/flexbox/csswg/flex-lines/multi-line-wrap-reverse-row-reverse.html: Added.
* css3/flexbox/csswg/flex-lines/multi-line-wrap-with-column-reverse-expected.html: Added.
* css3/flexbox/csswg/flex-lines/multi-line-wrap-with-column-reverse.html: Added.
* css3/flexbox/csswg/flex-lines/multi-line-wrap-with-row-reverse-expected.html: Added.
* css3/flexbox/csswg/flex-lines/multi-line-wrap-with-row-reverse.html: Added.
* css3/flexbox/csswg/flex-margin-no-collapse-expected.html: Added.
* css3/flexbox/csswg/flex-margin-no-collapse.html: Added.
* css3/flexbox/csswg/flex-order-expected.html: Added.
* css3/flexbox/csswg/flex-order.html: Added.
* css3/flexbox/csswg/flex-vertical-align-effect-expected.html: Added.
* css3/flexbox/csswg/flex-vertical-align-effect.html: Added.
* css3/flexbox/csswg/flex-vertical-align-effect.html-expected.html: Added.
* css3/flexbox/csswg/flexbox-flex-wrap-flexing-expected.html: Added.
* css3/flexbox/csswg/flexbox-flex-wrap-flexing.html: Added.
* css3/flexbox/csswg/flexbox-flex-wrap-nowrap-expected.html: Added.
* css3/flexbox/csswg/flexbox-flex-wrap-nowrap.html: Added.
* css3/flexbox/csswg/flexbox_absolute-atomic-expected.html: Added.
* css3/flexbox/csswg/flexbox_absolute-atomic.html: Added.
* css3/flexbox/csswg/flexbox_align-content-center-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-content-center.html: Added.
* css3/flexbox/csswg/flexbox_align-content-flexend-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-content-flexend.html: Added.
* css3/flexbox/csswg/flexbox_align-content-flexstart-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-content-flexstart.html: Added.
* css3/flexbox/csswg/flexbox_align-content-spacearound-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-content-spacearound.html: Added.
* css3/flexbox/csswg/flexbox_align-content-spacebetween-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-content-spacebetween.html: Added.
* css3/flexbox/csswg/flexbox_align-content-stretch-2-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-content-stretch-2.html: Added.
* css3/flexbox/csswg/flexbox_align-content-stretch-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-content-stretch.html: Added.
* css3/flexbox/csswg/flexbox_align-items-baseline-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-items-baseline.html: Added.
* css3/flexbox/csswg/flexbox_align-items-center-2-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-items-center-2.html: Added.
* css3/flexbox/csswg/flexbox_align-items-center-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-items-center.html: Added.
* css3/flexbox/csswg/flexbox_align-items-flexend-2-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-items-flexend-2.html: Added.
* css3/flexbox/csswg/flexbox_align-items-flexend-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-items-flexend.html: Added.
* css3/flexbox/csswg/flexbox_align-items-flexstart-2-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-items-flexstart-2.html: Added.
* css3/flexbox/csswg/flexbox_align-items-flexstart-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-items-flexstart.html: Added.
* css3/flexbox/csswg/flexbox_align-items-stretch-2-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-items-stretch-2.html: Added.
* css3/flexbox/csswg/flexbox_align-items-stretch-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-items-stretch.html: Added.
* css3/flexbox/csswg/flexbox_align-self-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-self-auto.html: Added.
* css3/flexbox/csswg/flexbox_align-self-baseline-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-self-baseline.html: Added.
* css3/flexbox/csswg/flexbox_align-self-center-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-self-center.html: Added.
* css3/flexbox/csswg/flexbox_align-self-flexend-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-self-flexend.html: Added.
* css3/flexbox/csswg/flexbox_align-self-flexstart-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-self-flexstart.html: Added.
* css3/flexbox/csswg/flexbox_align-self-stretch-expected.html: Added.
* css3/flexbox/csswg/flexbox_align-self-stretch.html: Added.
* css3/flexbox/csswg/flexbox_box-clear-expected.html: Added.
* css3/flexbox/csswg/flexbox_box-clear.html: Added.
* css3/flexbox/csswg/flexbox_columns-expected.html: Added.
* css3/flexbox/csswg/flexbox_columns-flexitems-2-expected.html: Added.
* css3/flexbox/csswg/flexbox_columns-flexitems-2.html: Added.
* css3/flexbox/csswg/flexbox_columns-flexitems-expected.html: Added.
* css3/flexbox/csswg/flexbox_columns-flexitems.html: Added.
* css3/flexbox/csswg/flexbox_columns.html: Added.
* css3/flexbox/csswg/flexbox_direction-column-expected.html: Added.
* css3/flexbox/csswg/flexbox_direction-column-reverse-expected.html: Added.
* css3/flexbox/csswg/flexbox_direction-column-reverse.html: Added.
* css3/flexbox/csswg/flexbox_direction-column.html: Added.
* css3/flexbox/csswg/flexbox_direction-row-reverse-expected.html: Added.
* css3/flexbox/csswg/flexbox_direction-row-reverse.html: Added.
* css3/flexbox/csswg/flexbox_display-expected.html: Added.
* css3/flexbox/csswg/flexbox_display.html: Added.
* css3/flexbox/csswg/flexbox_empty-expected.html: Added.
* css3/flexbox/csswg/flexbox_fbfc-expected.html: Added.
* css3/flexbox/csswg/flexbox_fbfc.html: Added.
* css3/flexbox/csswg/flexbox_fbfc2-expected.html: Added.
* css3/flexbox/csswg/flexbox_fbfc2.html: Added.
* css3/flexbox/csswg/flexbox_first-line-expected.html: Added.
* css3/flexbox/csswg/flexbox_first-line.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-0-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-0.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-N-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-N-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-N-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-N.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-Npercent-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-Npercent-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-Npercent-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-Npercent.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-auto-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-auto-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-0-auto.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-0-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-0.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-N-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-N-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-N-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-N.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-Npercent-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-Npercent-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-Npercent-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-Npercent.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-auto-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-auto-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-1-auto.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-0-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-0.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-N-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-N-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-N-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-N.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-Npercent-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-Npercent-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-Npercent-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-Npercent.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-auto-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-auto-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-0-N-auto.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-0-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-0.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-N-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-N-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-N-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-N.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-Npercent-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-Npercent-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-Npercent-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-Npercent.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-auto-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-auto-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-0-auto.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-0-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-0.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-N-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-N-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-N-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-N.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-Npercent-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-Npercent-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-Npercent-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-Npercent.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-auto-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-auto-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-1-auto.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-0-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-0.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-N-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-N-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-N-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-N.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-Npercent-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-Npercent-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-Npercent-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-Npercent.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-auto-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-auto-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-1-N-auto.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-0-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-0.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-N-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-N-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-N-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-N.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-Npercent-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-Npercent-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-Npercent-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-Npercent.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-auto-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-auto-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-0-auto.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-0-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-0.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-N-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-N-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-N-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-N.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-Npercent-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-Npercent-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-Npercent-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-Npercent.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-auto-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-auto-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-1-auto.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-0-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-0.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-N-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-N-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-N-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-N.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-Npercent-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-Npercent-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-Npercent-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-Npercent.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-auto-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-auto-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-N-N-auto.html: Added.
* css3/flexbox/csswg/flexbox_flex-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-auto.html: Added.
* css3/flexbox/csswg/flexbox_flex-basis-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-basis-shrink-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-basis-shrink.html: Added.
* css3/flexbox/csswg/flexbox_flex-basis.html: Added.
* css3/flexbox/csswg/flexbox_flex-formatting-interop-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-formatting-interop.html: Added.
* css3/flexbox/csswg/flexbox_flex-initial-2-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-initial-2.html: Added.
* css3/flexbox/csswg/flexbox_flex-initial-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-initial.html: Added.
* css3/flexbox/csswg/flexbox_flex-natural-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-natural-mixed-basis-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-natural-mixed-basis-auto.html: Added.
* css3/flexbox/csswg/flexbox_flex-natural-mixed-basis-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-natural-mixed-basis.html: Added.
* css3/flexbox/csswg/flexbox_flex-natural-variable-auto-basis-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-natural-variable-auto-basis.html: Added.
* css3/flexbox/csswg/flexbox_flex-natural-variable-zero-basis-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-natural-variable-zero-basis.html: Added.
* css3/flexbox/csswg/flexbox_flex-natural.html: Added.
* css3/flexbox/csswg/flexbox_flex-none-expected.html: Added.
* css3/flexbox/csswg/flexbox_flex-none.html: Added.
* css3/flexbox/csswg/flexbox_flex-unitless-basis-expected.html: Added.
* css3/flexbox/csswg/flexbox_flow-column-reverse-wrap-expected.html: Added.
* css3/flexbox/csswg/flexbox_flow-column-reverse-wrap-reverse-expected.html: Added.
* css3/flexbox/csswg/flexbox_flow-column-reverse-wrap-reverse.html: Added.
* css3/flexbox/csswg/flexbox_flow-column-reverse-wrap.html: Added.
* css3/flexbox/csswg/flexbox_flow-column-wrap-expected.html: Added.
* css3/flexbox/csswg/flexbox_flow-column-wrap-reverse-expected.html: Added.
* css3/flexbox/csswg/flexbox_flow-column-wrap-reverse.html: Added.
* css3/flexbox/csswg/flexbox_flow-column-wrap.html: Added.
* css3/flexbox/csswg/flexbox_flow-row-wrap-expected.html: Added.
* css3/flexbox/csswg/flexbox_flow-row-wrap-reverse-expected.html: Added.
* css3/flexbox/csswg/flexbox_flow-row-wrap-reverse.html: Added.
* css3/flexbox/csswg/flexbox_flow-row-wrap.html: Added.
* css3/flexbox/csswg/flexbox_generated-container-expected.html: Added.
* css3/flexbox/csswg/flexbox_generated-container.html: Added.
* css3/flexbox/csswg/flexbox_generated-expected.html: Added.
* css3/flexbox/csswg/flexbox_generated-flex-expected.html: Added.
* css3/flexbox/csswg/flexbox_generated-flex.html: Added.
* css3/flexbox/csswg/flexbox_generated.html: Added.
* css3/flexbox/csswg/flexbox_inline-expected.html: Added.
* css3/flexbox/csswg/flexbox_inline.html: Added.
* css3/flexbox/csswg/flexbox_item-bottom-float-expected.html: Added.
* css3/flexbox/csswg/flexbox_item-bottom-float.html: Added.
* css3/flexbox/csswg/flexbox_item-clear-expected.html: Added.
* css3/flexbox/csswg/flexbox_item-clear.html: Added.
* css3/flexbox/csswg/flexbox_item-float-expected.html: Added.
* css3/flexbox/csswg/flexbox_item-float.html: Added.
* css3/flexbox/csswg/flexbox_item-top-float-expected.html: Added.
* css3/flexbox/csswg/flexbox_item-top-float.html: Added.
* css3/flexbox/csswg/flexbox_item-vertical-align-expected.html: Added.
* css3/flexbox/csswg/flexbox_item-vertical-align.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-center-expected.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-center-overflow-expected.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-center-overflow.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-center.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-flex-end-expected.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-flex-end.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-flex-start-expected.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-flex-start.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-spacearound-expected.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-spacearound-negative-expected.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-spacearound-negative.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-spacearound-only-expected.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-spacearound-only.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-spacearound.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-spacebetween-expected.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-spacebetween-negative-expected.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-spacebetween-negative.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-spacebetween-only-expected.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-spacebetween-only.html: Added.
* css3/flexbox/csswg/flexbox_justifycontent-spacebetween.html: Added.
* css3/flexbox/csswg/flexbox_margin-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_margin-auto-overflow-2-expected.html: Added.
* css3/flexbox/csswg/flexbox_margin-auto-overflow-2.html: Added.
* css3/flexbox/csswg/flexbox_margin-auto-overflow-expected.html: Added.
* css3/flexbox/csswg/flexbox_margin-auto-overflow.html: Added.
* css3/flexbox/csswg/flexbox_margin-auto.html: Added.
* css3/flexbox/csswg/flexbox_margin-collapse-expected.html: Added.
* css3/flexbox/csswg/flexbox_margin-collapse.html: Added.
* css3/flexbox/csswg/flexbox_margin-expected.html: Added.
* css3/flexbox/csswg/flexbox_margin-left-ex-expected.html: Added.
* css3/flexbox/csswg/flexbox_margin-left-ex.html: Added.
* css3/flexbox/csswg/flexbox_margin.html: Added.
* css3/flexbox/csswg/flexbox_min-height-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_min-height-auto.html: Added.
* css3/flexbox/csswg/flexbox_min-width-auto-expected.html: Added.
* css3/flexbox/csswg/flexbox_min-width-auto.html: Added.
* css3/flexbox/csswg/flexbox_object-expected.html: Added.
* css3/flexbox/csswg/flexbox_object.html: Added.
* css3/flexbox/csswg/flexbox_order-abspos-space-around-expected.html: Added.
* css3/flexbox/csswg/flexbox_order-abspos-space-around.html: Added.
* css3/flexbox/csswg/flexbox_order-box-expected.html: Added.
* css3/flexbox/csswg/flexbox_order-box.html: Added.
* css3/flexbox/csswg/flexbox_order-expected.html: Added.
* css3/flexbox/csswg/flexbox_order.html: Added.
* css3/flexbox/csswg/flexbox_rowspan-expected.html: Added.
* css3/flexbox/csswg/flexbox_rowspan.html: Added.
* css3/flexbox/csswg/flexbox_rtl-direction-expected.html: Added.
* css3/flexbox/csswg/flexbox_rtl-direction.html: Added.
* css3/flexbox/csswg/flexbox_rtl-flow-expected.html: Added.
* css3/flexbox/csswg/flexbox_rtl-flow-reverse-expected.html: Added.
* css3/flexbox/csswg/flexbox_rtl-flow-reverse.html: Added.
* css3/flexbox/csswg/flexbox_rtl-flow.html: Added.
* css3/flexbox/csswg/flexbox_rtl-order-expected.html: Added.
* css3/flexbox/csswg/flexbox_rtl-order.html: Added.
* css3/flexbox/csswg/flexbox_stf-table-singleline-expected.html: Added.
* css3/flexbox/csswg/flexbox_stf-table-singleline.html: Added.
* css3/flexbox/csswg/flexbox_visibility-collapse-expected.html: Added.
* css3/flexbox/csswg/flexbox_visibility-collapse-line-wrapping-expected.html: Added.
* css3/flexbox/csswg/flexbox_visibility-collapse-line-wrapping.html: Added.
* css3/flexbox/csswg/flexbox_visibility-collapse.html: Added.
* css3/flexbox/csswg/flexbox_wrap-expected.html: Added.
* css3/flexbox/csswg/flexbox_wrap-long-expected.html: Added.
* css3/flexbox/csswg/flexbox_wrap-long.html: Added.
* css3/flexbox/csswg/flexbox_wrap-reverse-expected.html: Added.
* css3/flexbox/csswg/flexbox_wrap-reverse.html: Added.
* css3/flexbox/csswg/flexbox_wrap.html: Added.
* css3/flexbox/csswg/flexbox_writing_mode_vertical_lays_out_contents_from_top_to_bottom-expected.html: Added.
* css3/flexbox/csswg/flexbox_writing_mode_vertical_lays_out_contents_from_top_to_bottom.html: Added.
* css3/flexbox/csswg/justify-content-001-expected.html: Added.
* css3/flexbox/csswg/justify-content-001.html: Added.
* css3/flexbox/csswg/order/order-with-column-reverse-expected.html: Added.
* css3/flexbox/csswg/order/order-with-column-reverse.html: Added.
* css3/flexbox/csswg/order/order-with-row-reverse-expected.html: Added.
* css3/flexbox/csswg/order/order-with-row-reverse.html: Added.
* css3/flexbox/csswg/ref-filled-green-100px-square-expected.html: Added.
* css3/flexbox/csswg/ref-filled-green-100px-square.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-align-content-center-expected.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-align-content-center.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-align-content-end-expected.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-align-content-end.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-align-content-space-between-expected.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-align-content-space-between.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-align-content-start-expected.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-align-content-start.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-base-expected.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-base.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-direction-column-expected.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-direction-column-reverse-expected.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-direction-column-reverse.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-direction-column.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-direction-row-reverse-expected.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-direction-row-reverse.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-inline-expected.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-inline.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-order-expected.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-order.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-wrap-expected.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-wrap-reverse-expected.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-wrap-reverse.html: Added.
* css3/flexbox/csswg/ttwf-reftest-flex-wrap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r173575.
commit-queue@webkit.org [Fri, 12 Sep 2014 22:20:29 +0000 (22:20 +0000)]
Unreviewed, rolling out r173575.
https://bugs.webkit.org/show_bug.cgi?id=136790

Failing tests (Requested by enrica on #webkit).

Reverted changeset:

"Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
https://bugs.webkit.org/show_bug.cgi?id=136474
http://trac.webkit.org/changeset/173575

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[x86] moveDoubleToInts() does not clobber its source register anymore
julien.brianceau@gmail.com [Fri, 12 Sep 2014 22:00:13 +0000 (22:00 +0000)]
[x86] moveDoubleToInts() does not clobber its source register anymore
https://bugs.webkit.org/show_bug.cgi?id=131690

Reviewed by Oliver Hunt.

* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::moveDoubleToInts):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueRep):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnprefix the flexbox CSS properties
dino@apple.com [Fri, 12 Sep 2014 21:43:00 +0000 (21:43 +0000)]
Unprefix the flexbox CSS properties
https://bugs.webkit.org/show_bug.cgi?id=98420

Unreviewed fix up, that missed the original
commit. Tony Chang made some comments
on the bugzilla.

"justify-self" should not have been unprefixed.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
* css/CSSPropertyNames.in:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. WebGL conformance test gardening.
roger_fong@apple.com [Fri, 12 Sep 2014 21:31:30 +0000 (21:31 +0000)]
Unreviewed. WebGL conformance test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoURTBF after r173574.
ossy@webkit.org [Fri, 12 Sep 2014 21:29:33 +0000 (21:29 +0000)]
URTBF after r173574.

* Source/cmake/WebKitMacros.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix for CLOOP build.
mark.lam@apple.com [Fri, 12 Sep 2014 21:08:04 +0000 (21:08 +0000)]
Unreviewed build fix for CLOOP build.

* runtime/JSCallee.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove PLATFORM(IOS) from WebCore/editing (Part 3).
enrica@apple.com [Fri, 12 Sep 2014 21:07:41 +0000 (21:07 +0000)]
Remove PLATFORM(IOS) from WebCore/editing (Part 3).
https://bugs.webkit.org/show_bug.cgi?id=136474

Reviewed by Benjamin Poulain.

This is the updated version of the patch that was landed in r173340.
I changed the use of IntPoint to FloatPoint since it was causing tests
to fail.
This patch removes the use of PLATFORM(IOS) from TextAffinity.h
and removes the assumption that EAffinity values match NSSelectionAffinity
values. It also removes the includes in TextAffinity.h, creating the need to
include explicitly the files when necessary. It also removes the unnecessary
use of platform specific types, replacing them with WebCore types.

Source/WebCore:

* WebCore.exp.in:
* editing/TextAffinity.h:
(kit): Deleted.
(core): Deleted.
* editing/cocoa/HTMLConverter.mm:
* page/mac/WebCoreFrameView.h:
* platform/ios/ScrollViewIOS.mm:
(WebCore::ScrollView::platformSetScrollPosition):
* platform/ios/wak/WAKScrollView.mm:
(-[WAKScrollView setScrollOrigin:updatePositionAtAll:immediately:]):
(-[WAKScrollView scrollOrigin]):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformSetScrollPosition):

Source/WebKit/mac:

* WebCoreSupport/WebEditorClient.h:
(kit):
(core):
* WebView/WebFrameView.mm:
(-[WebFrameView _scrollToBeginningOfDocument]):
(-[WebFrameView _scrollToEndOfDocument]):

Source/WebKit2:

* WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
* WebProcess/WebPage/WKAccessibilityWebPageObjectIOS.mm:
(-[WKAccessibilityWebPageObject accessibilityHitTest:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Cocoa] Message generation scripts should be installed in WebKit.framework
mitz@apple.com [Fri, 12 Sep 2014 21:05:01 +0000 (21:05 +0000)]
[Cocoa] Message generation scripts should be installed in WebKit.framework
https://bugs.webkit.org/show_bug.cgi?id=136771

Reviewed by Anders Carlsson.

* DerivedSources.make: Updated for rename of Scripts/webkit2 to Scripts/webkit.
* Scripts/generate-message-receiver.py:
(main): Updated for rename from webkit2 to webkit.
* Scripts/generate-messages-header.py:
(main): Ditto.
* Scripts/webkit: Renamed from Source/WebKit2/Scripts/webkit2.
* Scripts/webkit/messages.py: Updated for rename.
* Scripts/webkit/parser.py: Ditto.
* WebKit2.xcodeproj/project.pbxproj: Moved the Copy Message Generation Scripts build phase
from the WebKit2 target to the WebKit target and changed its destination to
WebKit.framework/PrivateHeaders/Scripts/webkit. Removed the Remove Compiled Python Files
build phase, since compiled files no longer get copied.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFlash of page scrolled to wrong origin before restoring scroll position after swiping...
timothy_horton@apple.com [Fri, 12 Sep 2014 20:59:20 +0000 (20:59 +0000)]
Flash of page scrolled to wrong origin before restoring scroll position after swiping back to CNN front page from an article
https://bugs.webkit.org/show_bug.cgi?id=136788
<rdar://problem/18314597>

Reviewed by Sam Weinig.

* UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::didHitRenderTreeSizeThreshold):
(WebKit::ViewGestureController::didFirstVisuallyNonEmptyLayoutForMainFrame):
Always wait until didFinishLoadForMainFrame or didSameDocumentNavigationForMainFrame
before removing the snapshot, because otherwise we don't know if the scroll
position has been restored yet.

We should revisit this at some point, because it should be possible to
determine if the scroll position has been restored appropriately, but for
now it is safest to restore the antique behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnprefix the flexbox CSS properties
dino@apple.com [Fri, 12 Sep 2014 20:46:05 +0000 (20:46 +0000)]
Unprefix the flexbox CSS properties
https://bugs.webkit.org/show_bug.cgi?id=98420

Reviewed by Benjamin Poulain.

Source/WebCore:

Remove the need for a "-webkit-" prefix on flexbox
and related properties. This includes:
- align-content
- align-items
- align-self
- flex-basis
- flex-direction
- flex-wrap
- flex-grow
- flex-shrink
- flex
- flex-flow
- justify
- order

... as well as the display keyword values "flex" and
"inline-flex".

* css/CSSComputedStyleDeclaration.cpp:  Change names.
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp: Ditto.
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFlex):
* css/CSSPrimitiveValueMappings.h: Since we need to still handle the old
keywords for display, this has added two new keywords.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EDisplay): If the older keywords were used in
content, map them to the new value names.
* css/CSSPropertyNames.in: Add aliases for the prefixed properties.
* css/CSSValueKeywords.in: Add "flex" and "inline-flex".
* css/DeprecatedStyleBuilder.cpp: Change names.
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
* css/StyleProperties.cpp: Change names.
(WebCore::StyleProperties::getPropertyValue):
(WebCore::StyleProperties::asText):
* css/StylePropertyShorthand.cpp: Rename shorthand methods to remove the prefix.
(WebCore::flexFlowShorthand):
(WebCore::flexShorthand):
(WebCore::shorthandForProperty):
(WebCore::matchingShorthandsForLonghand):
(WebCore::webkitFlexFlowShorthand): Deleted.
(WebCore::webkitFlexShorthand): Deleted.
* css/StylePropertyShorthand.h:
* css/StyleResolver.cpp:
(WebCore::equivalentBlockDisplay):
(WebCore::StyleResolver::applyProperty):
* page/animation/CSSPropertyAnimation.cpp: Change names.
(WebCore::PropertyWrapperFlex::PropertyWrapperFlex):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor): Handle the two new display values (the same way as
the old values).
* rendering/style/RenderStyleConstants.h: Add constants for the new display values.

LayoutTests:

Now that we return "flex" instead of "-webkit-flex" (and similar
changes) update the tests that rely on this. Other than that,
we're still testing the prefixed content. A followup patch
will add tests for non-prefixed content.

* css3/flexbox/display-flexbox-set-get-expected.txt:
* css3/flexbox/display-flexbox-set-get.html:
* css3/flexbox/flexitem.html:
* fast/css-grid-layout/grid-item-display.html:
* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle/resources/property-names.js:
* fast/css/inherit-initial-shorthand-values-expected.txt:
* fast/css/inherit-initial-shorthand-values.html:
* svg/css/getComputedStyle-basic-expected.txt:
* transitions/flex-transitions-expected.txt:
* transitions/flex-transitions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoASSERTION FAILED: e in WebCore::StyleResolver::adjustRenderStyle
utatane.tea@gmail.com [Fri, 12 Sep 2014 20:33:36 +0000 (20:33 +0000)]
ASSERTION FAILED: e in WebCore::StyleResolver::adjustRenderStyle
https://bugs.webkit.org/show_bug.cgi?id=136366

Reviewed by Benjamin Poulain.

Source/WebCore:

Since element becomes nullptr when resolving styles for pseudo elements,
so don't do `ASSERT(e)` and use pointer for that.

Test: fast/css/appearance-with-pseudo-elements.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderThumb::updateAppearance):
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustSliderTrackStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbStyle):
(WebCore::RenderThemeEfl::adjustSliderThumbSize):
(WebCore::RenderThemeEfl::adjustCheckboxStyle):
(WebCore::RenderThemeEfl::adjustRadioStyle):
(WebCore::RenderThemeEfl::adjustButtonStyle):
(WebCore::RenderThemeEfl::adjustMenuListStyle):
(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
(WebCore::RenderThemeEfl::adjustTextFieldStyle):
(WebCore::RenderThemeEfl::adjustTextAreaStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeEfl::adjustSearchFieldStyle):
(WebCore::RenderThemeEfl::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeEfl::adjustProgressBarStyle):
* platform/efl/RenderThemeEfl.h:
* platform/gtk/RenderThemeGtk.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustCheckboxStyle):
(WebCore::RenderTheme::adjustRadioStyle):
(WebCore::RenderTheme::adjustButtonStyle):
(WebCore::RenderTheme::adjustInnerSpinButtonStyle):
(WebCore::RenderTheme::adjustTextFieldStyle):
(WebCore::RenderTheme::adjustTextAreaStyle):
(WebCore::RenderTheme::adjustMenuListStyle):
(WebCore::RenderTheme::adjustMeterStyle):
(WebCore::RenderTheme::adjustProgressBarStyle):
(WebCore::RenderTheme::adjustMenuListButtonStyle):
(WebCore::RenderTheme::adjustMediaControlStyle):
(WebCore::RenderTheme::adjustSliderTrackStyle):
(WebCore::RenderTheme::adjustSliderThumbStyle):
(WebCore::RenderTheme::adjustSliderThumbSize):
(WebCore::RenderTheme::adjustSearchFieldStyle):
(WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderTheme::adjustSearchFieldDecorationPartStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle):
* rendering/RenderTheme.h:
* rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustButtonStyle):
(WebCore::RenderThemeGtk::adjustMenuListStyle):
(WebCore::RenderThemeGtk::adjustMenuListButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeGtk::adjustSearchFieldStyle):
(WebCore::RenderThemeGtk::adjustSliderTrackStyle):
(WebCore::RenderThemeGtk::adjustSliderThumbStyle):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeGtk::adjustProgressBarStyle):
* rendering/RenderThemeIOS.h:
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustCheckboxStyle):
(WebCore::RenderThemeIOS::adjustRadioStyle):
(WebCore::RenderThemeIOS::adjustMenuListButtonStyle):
(WebCore::RenderThemeIOS::adjustSliderTrackStyle):
(WebCore::RenderThemeIOS::adjustSliderThumbSize):
(WebCore::RenderThemeIOS::adjustSearchFieldStyle):
(WebCore::RenderThemeIOS::adjustButtonStyle):
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustTextFieldStyle):
(WebCore::RenderThemeMac::adjustTextAreaStyle):
(WebCore::RenderThemeMac::adjustProgressBarStyle):
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationPartStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeMac::adjustSliderThumbSize):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::adjustButtonStyle):
(WebCore::RenderThemeSafari::adjustTextFieldStyle):
(WebCore::RenderThemeSafari::adjustTextAreaStyle):
(WebCore::RenderThemeSafari::adjustMenuListStyle):
(WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
(WebCore::RenderThemeSafari::adjustSliderThumbStyle):
(WebCore::RenderThemeSafari::adjustSliderThumbSize):
(WebCore::RenderThemeSafari::adjustSearchFieldStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldDecorationPartStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeSafari::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeSafari::adjustMeterStyle):
* rendering/RenderThemeSafari.h:
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeWin::adjustMenuListStyle):
(WebCore::RenderThemeWin::adjustMenuListButtonStyle):
(WebCore::RenderThemeWin::adjustSliderThumbSize):
(WebCore::RenderThemeWin::adjustSearchFieldStyle):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeWin::adjustSearchFieldDecorationPartStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationPartStyle):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeWin::adjustMeterStyle):
* rendering/RenderThemeWin.h:

LayoutTests:

* fast/css/appearance-with-pseudo-elements-expected.html: Added.
* fast/css/appearance-with-pseudo-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix casing in method name - formatNumberForCustomCSSText
commit-queue@webkit.org [Fri, 12 Sep 2014 20:17:50 +0000 (20:17 +0000)]
Fix casing in method name - formatNumberForCustomCSSText
https://bugs.webkit.org/show_bug.cgi?id=136758

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-09-12
Reviewed by Benjamin Poulain.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText):
(WebCore::CSSPrimitiveValue::customCSSText):
(WebCore::CSSPrimitiveValue::formatNumberForcustomCSSText): Deleted.
* css/CSSPrimitiveValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake all CSSSelector data members private
cdumez@apple.com [Fri, 12 Sep 2014 19:24:12 +0000 (19:24 +0000)]
Make all CSSSelector data members private
https://bugs.webkit.org/show_bug.cgi?id=136784

Reviewed by Benjamin Poulain.

Make all CSSSelector data members private. Previously, some of the data
members such as m_relation / m_match / m_pseudoType were public and
accessed directly from outside the class. The new approach is better
because:
- Those members are bit fields so by using getters, we can hide the
  casts inside the getters. The setters can now also check that the
  bitfield is big enough to actually store the enum value.
- When using those in switch() statements, the compiler now complains
  if we fail to test some of the enum values as the value is now an
  enum, and not merely an unsigned integer.
- Some of these members already has getters (e.g. relation()).
- Better encapsulation.

No new tests, no behavior change.

* css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::parsePagePseudoSelector):
(WebCore::CSSParserSelector::parsePseudoElementSelector):
(WebCore::CSSParserSelector::parsePseudoElementCueFunctionSelector):
(WebCore::CSSParserSelector::parsePseudoClassAndCompatibilityElementSelector):
(WebCore::CSSParserSelector::setPseudoClassValue):
(WebCore::CSSParserSelector::isSimple):
(WebCore::CSSParserSelector::prependTagSelector):
* css/CSSParserValues.h:
(WebCore::CSSParserSelector::setMatch):
(WebCore::CSSParserSelector::setRelation):
(WebCore::CSSParserSelector::isPseudoElementCueFunction):
* css/CSSSelector.cpp:
(WebCore::CSSSelector::createRareData):
(WebCore::CSSSelector::specificityForOneSelector):
(WebCore::CSSSelector::specificityForPage):
(WebCore::CSSSelector::operator==):
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
(WebCore::CSSSelector::setPseudoElementType):
(WebCore::CSSSelector::setPagePseudoType):
(WebCore::CSSSelector::pseudoClassType):
(WebCore::CSSSelector::setPseudoClassType):
(WebCore::CSSSelector::pseudoElementType):
(WebCore::CSSSelector::pagePseudoClassType):
(WebCore::CSSSelector::setRelation):
(WebCore::CSSSelector::match):
(WebCore::CSSSelector::setMatch):
(WebCore::CSSSelector::matchesPseudoElement):
(WebCore::CSSSelector::isUnknownPseudoElement):
(WebCore::CSSSelector::isCustomPseudoElement):
(WebCore::CSSSelector::isSiblingSelector):
(WebCore::CSSSelector::isAttributeSelector):
(WebCore::CSSSelector::setValue):
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
(WebCore::CSSSelector::tagQName):
(WebCore::CSSSelector::value):
* css/CSSSelectorList.cpp:
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
* css/PageRuleCollector.cpp:
(WebCore::checkPageSelectorComponents):
* css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::collectFeaturesFromSelector):
* css/RuleSet.cpp:
(WebCore::isSelectorMatchingHTMLBasedOnRuleHash):
(WebCore::determinePropertyWhitelistType):
(WebCore::RuleSet::addRule):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
(WebCore::anyAttributeMatches):
(WebCore::canMatchHoverOrActiveInQuirksMode):
(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::checkScrollbarPseudoClass):
(WebCore::SelectorChecker::determineLinkMatchType):
* css/SelectorChecker.h:
(WebCore::SelectorChecker::isCommonPseudoClassSelector):
* css/SelectorFilter.cpp:
(WebCore::collectDescendantSelectorIdentifierHashes):
* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::constructFragments):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeValueMatching):
* dom/SelectorQuery.cpp:
(WebCore::isSingleTagNameSelector):
(WebCore::isSingleClassNameSelector):
(WebCore::findIdMatchingType):
(WebCore::SelectorDataList::SelectorDataList):
(WebCore::selectorForIdLookup):
(WebCore::filterRootById):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBuild fix.
mitz@apple.com [Fri, 12 Sep 2014 19:08:45 +0000 (19:08 +0000)]
Build fix.

Reverted r173564.

* DerivedSources.make:
* Scripts/generate-message-receiver.py:
(main):
* Scripts/generate-messages-header.py:
(main):
* Scripts/webkit: Removed.
* Scripts/webkit/LegacyMessageReceiver-expected.cpp: Removed.
* Scripts/webkit/LegacyMessages-expected.h: Removed.
* Scripts/webkit/MessageReceiver-expected.cpp: Removed.
* Scripts/webkit/MessageReceiverSuperclass-expected.cpp: Removed.
* Scripts/webkit/Messages-expected.h: Removed.
* Scripts/webkit/MessagesSuperclass-expected.h: Removed.
* Scripts/webkit/__init__.py: Removed.
* Scripts/webkit/messages.py: Removed.
* Scripts/webkit/messages_unittest.py: Removed.
* Scripts/webkit/model.py: Removed.
* Scripts/webkit/parser.py: Removed.
* Scripts/webkit/test-legacy-messages.in: Removed.
* Scripts/webkit/test-messages.in: Removed.
* Scripts/webkit/test-superclass-messages.in: Removed.
* Scripts/webkit2: Copied from Scripts/webkit2.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove unneeded declarations from JSCallee.h
msaboff@apple.com [Fri, 12 Sep 2014 17:54:05 +0000 (17:54 +0000)]
Remove unneeded declarations from JSCallee.h
https://bugs.webkit.org/show_bug.cgi?id=136783

Reviewed by Mark Lam.

* runtime/JSCallee.h:
(JSCallee::name): Deleted.
(JSCallee::displayName): Deleted.
(JSCallee::calculatedDisplayName): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
aestes@apple.com [Fri, 12 Sep 2014 17:53:54 +0000 (17:53 +0000)]
[WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
https://bugs.webkit.org/show_bug.cgi?id=136768

Reviewed by Tim Horton.

Source/WebKit2:

WKImageCreateFromCGImage can return null, so it only seems fair that WKImageCreateCGImage should tolerate null.

* Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateCGImage):

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago2014-09-12 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 12 Sep 2014 17:45:00 +0000 (17:45 +0000)]
2014-09-12  Geoffrey Garen  <ggaren@apple.com>

        Rolled out r173540.

        It broke the Membuster performance bot, and it's still slightly profligate
        with memory.

            Do the bmalloc.
            https://bugs.webkit.org/show_bug.cgi?id=132629

        * wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Cocoa] Message generation scripts should be installed in WebKit.framework
mitz@apple.com [Fri, 12 Sep 2014 17:30:35 +0000 (17:30 +0000)]
[Cocoa] Message generation scripts should be installed in WebKit.framework
https://bugs.webkit.org/show_bug.cgi?id=136771

Reviewed by Anders Carlsson.

* DerivedSources.make: Updated for rename of Scripts/webkit2 to Scripts/webkit.
* Scripts/generate-message-receiver.py:
(main): Updated for rename from webkit2 to webkit.
* Scripts/generate-messages-header.py:
(main): Ditto.
* Scripts/webkit: Renamed from Source/WebKit2/Scripts/webkit2.
* Scripts/webkit/messages.py: Updated for rename.
* Scripts/webkit/parser.py: Ditto.
* WebKit2.xcodeproj/project.pbxproj: Moved the Copy Message Generation Scripts build phase
from the WebKit2 target to the WebKit target and changed its destination to
WebKit.framework/PrivateHeaders/Scripts/webkit. Removed the Remove Compiled Python Files
build phase, since compiled files no longer get copied.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Use a nicer HTTP authentication dialog
commit-queue@webkit.org [Fri, 12 Sep 2014 15:59:12 +0000 (15:59 +0000)]
[GTK] Use a nicer HTTP authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=136615

Patch by Michael Catanzaro <mcatanzaro@igalia.com> on 2014-09-12
Reviewed by Carlos Garcia Campos.

* UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:
(webkitAuthenticationDialogInitialize): Use a nicer layout.
(packTwoColumnLayoutInBox): Deleted.
(createLabel): Deleted.
(createEntry): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r173441): [GTK] All buttons appear insensitive
carlosgc@webkit.org [Fri, 12 Sep 2014 15:44:42 +0000 (15:44 +0000)]
REGRESSION(r173441): [GTK] All buttons appear insensitive
https://bugs.webkit.org/show_bug.cgi?id=136614

Reviewed by Sergio Villar Senin.

Do not use RenderTheme::isReadOnlyControl() to decide whether to
render non text based forms sensitive or unsensitive, isEnabled()
is enough in those cases.

* rendering/RenderThemeGtk.cpp:
(WebCore::paintToggle):
(WebCore::renderButton):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(r173423): CertificateInfo is never sent to the UI process when using share...
carlosgc@webkit.org [Fri, 12 Sep 2014 15:42:11 +0000 (15:42 +0000)]
REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
https://bugs.webkit.org/show_bug.cgi?id=136669

Reviewed by Antti Koivisto.

Source/WebCore:

Add CertificateInfoPolicy option to ResourceLoaderOptions. It's
set to DoNotIncludeCertificateInfo for all loads except the main
resource load.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Pass
IncludeCertificateInfo to ResourceLoaderOptions.
* loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
Pass DoNotIncludeCertificateInfo to ResourceLoaderOptions().
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::shouldIncludeCertificateInfo): Return
true if IncludeCertificateInfo option was given.
* loader/ResourceLoaderOptions.h:
(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):
(WebCore::ResourceLoaderOptions::certificateInfoPolicy):
(WebCore::ResourceLoaderOptions::setCertificateInfoPolicy):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse): If
IncludeCertificateInfo option is present, call
includeCertificateInfo() on the response.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Pass
DoNotIncludeCertificateInfo to ResourceLoaderOptions().
(WebCore::CachedResourceLoader::defaultCachedResourceOptions): Ditto.
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading): Ditto.
* platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
(WebCore::WebCoreAVCFResourceLoader::startLoading): Ditto.
* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::startLoading): Ditto.
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(CachedResourceStreamingClient::CachedResourceStreamingClient): Ditto.

Source/WebKit2:

* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad): Use
ResourceLoader::shouldIncludeCertificateInfo() to initialize
needsCertificateInfo parameter.

Tools:

* Scripts/run-gtk-tests:
(TestRunner): Unskip SSL test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStrip extraneous AVFoundation and CoreMedia logging
eric.carlson@apple.com [Fri, 12 Sep 2014 13:06:13 +0000 (13:06 +0000)]
Strip extraneous AVFoundation and CoreMedia logging
https://bugs.webkit.org/show_bug.cgi?id=136747

Reviewed by Jer Noble.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.

* Scripts/webkitpy/port/base.py:
(Port.stderr_patterns_to_strip): Base class, empty list

* Scripts/webkitpy/port/driver.py:
(DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.

* Scripts/webkitpy/port/mac.py:
(MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agofast/forms/submit-to-blank-multiple-times.html crashes with JSC_slowPathAllocsBetweenGCs
ap@apple.com [Fri, 12 Sep 2014 05:32:33 +0000 (05:32 +0000)]
fast/forms/submit-to-blank-multiple-times.html crashes with JSC_slowPathAllocsBetweenGCs
https://bugs.webkit.org/show_bug.cgi?id=136716

Reviewed by Darin Adler.

This test used a fake timeout handler, which is not needed, because WRT/WKTR do it for you.
Any time the test took over 2 seconds, we would dump and disable waiting for notifyDone,
but the test would still try to open windows after that.

* fast/forms/submit-to-blank-multiple-times.html:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix attempt on windows port since r173553.
ryuan.choi@gmail.com [Fri, 12 Sep 2014 05:08:39 +0000 (05:08 +0000)]
Unreviewed build fix attempt on windows port since r173553.

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSource/JavaScriptCore:
burg@cs.washington.edu [Fri, 12 Sep 2014 04:53:35 +0000 (04:53 +0000)]
Source/JavaScriptCore:
Web Inspector: disambiguate double and integer primitive types in the protocol
https://bugs.webkit.org/show_bug.cgi?id=136606

Reviewed by Timothy Hatcher.

Right now it's really easy to mix up doubles and integers when serializing or deserializing
values for the inspector protocol. This patch disambiguates setting/getting doubles and integers
so that it is clearer as to which type is intended.

A new InspectorValue::Type is added for Integer types, and the Number type is renamed to Double.
The existing callsites for asNumber/getNumber/setNumber have been fixed.

Address various integration points to make sure the right type tag is assigned to InspectorValues.

* bindings/ScriptValue.cpp:
(Deprecated::jsToInspectorValue): Make an Integer if the JSValue is Int52 or smaller.
* inspector/InjectedScriptManager.cpp:
(Inspector::InjectedScriptManager::injectedScriptForObjectId):
* inspector/InspectorBackendDispatcher.cpp:
(Inspector::InspectorBackendDispatcher::dispatch):
(Inspector::InspectorBackendDispatcher::sendResponse):
(Inspector::InspectorBackendDispatcher::reportProtocolError):
(Inspector::AsMethodBridges::asInteger):
(Inspector::AsMethodBridges::asDouble):
(Inspector::InspectorBackendDispatcher::getInteger):
(Inspector::InspectorBackendDispatcher::getDouble):
(Inspector::AsMethodBridges::asInt): Deleted.
(Inspector::InspectorBackendDispatcher::getInt): Deleted.
* inspector/InspectorBackendDispatcher.h:
* inspector/InspectorProtocolTypes.h: Remove the special case for checking int type tags.
(Inspector::Protocol::ArrayItemHelper<int>::Traits::pushRaw):
(Inspector::Protocol::ArrayItemHelper<double>::Traits::pushRaw):
(Inspector::Protocol::BindingTraits<int>::assertValueHasExpectedType): Deleted.
* inspector/InspectorValues.cpp: Allow integers and doubles to be convertible using asInteger/asDouble.
(Inspector::InspectorValue::asDouble):
(Inspector::InspectorValue::asInteger):
(Inspector::InspectorBasicValue::asDouble):
(Inspector::InspectorBasicValue::asInteger):
(Inspector::InspectorBasicValue::writeJSON):
(Inspector::InspectorValue::asNumber): Deleted.
(Inspector::InspectorBasicValue::asNumber): Deleted.
* inspector/InspectorValues.h:
(Inspector::InspectorObjectBase::setInteger):
(Inspector::InspectorObjectBase::setDouble):
(Inspector::InspectorArrayBase::pushInteger):
(Inspector::InspectorArrayBase::pushDouble):
(Inspector::InspectorObjectBase::setNumber): Deleted.
(Inspector::InspectorArrayBase::pushInt): Deleted.
(Inspector::InspectorArrayBase::pushNumber): Deleted.
* inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::buildObjectForBreakpointCookie):
(Inspector::InspectorDebuggerAgent::breakpointActionsFromProtocol):
(Inspector::parseLocation):
(Inspector::InspectorDebuggerAgent::didParseSource):
* inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
* inspector/scripts/codegen/generator.py: Update emitted code and rebaseline test results.
(Generator.keyed_get_method_for_type):
(Generator.keyed_set_method_for_type):
* inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
* inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
* inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
* inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
* inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
* inspector/scripts/tests/expected/type-declaration-object-type.json-result:
* inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
* replay/EncodedValue.cpp:
(JSC::EncodedValue::convertTo<double>):
(JSC::EncodedValue::convertTo<float>):
(JSC::EncodedValue::convertTo<int32_t>):
(JSC::EncodedValue::convertTo<int64_t>):
(JSC::EncodedValue::convertTo<uint32_t>):
(JSC::EncodedValue::convertTo<uint64_t>):

Source/WebCore:
Web Inspector: disambiguate integral and real number primitive types in the protocol
https://bugs.webkit.org/show_bug.cgi?id=136606

Reviewed by Timothy Hatcher.

Update clients of InspectorValue to disambiguate integer and double primitive types.

No new tests, no behavior changed.

* inspector/InspectorDOMAgent.cpp:
(WebCore::parseColor):
(WebCore::parseQuad):
(WebCore::InspectorDOMAgent::performSearch):
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
* inspector/InspectorIndexedDBAgent.cpp:
* inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForPoint):
(WebCore::buildObjectForRect):
(WebCore::buildObjectForSize):
(WebCore::appendPathCommandAndPoints):
(WebCore::InspectorOverlay::reset):
* inspector/InspectorReplayAgent.cpp:
(WebCore::InspectorReplayAgent::replayToPosition):
* inspector/InspectorStyleSheet.h:
(WebCore::InspectorCSSId::InspectorCSSId):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didWriteHTML):
(WebCore::InspectorTimelineAgent::didCompleteRecordEntry):
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createGenericRecord):
(WebCore::TimelineRecordFactory::createBackgroundRecord):
(WebCore::TimelineRecordFactory::createGCEventData):
(WebCore::TimelineRecordFactory::createFunctionCallData):
(WebCore::TimelineRecordFactory::createProbeSampleData):
(WebCore::TimelineRecordFactory::createGenericTimerData):
(WebCore::TimelineRecordFactory::createTimerInstallData):
(WebCore::TimelineRecordFactory::createXHRReadyStateChangeData):
(WebCore::TimelineRecordFactory::createEvaluateScriptData):
(WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
(WebCore::TimelineRecordFactory::createResourceFinishData):
(WebCore::TimelineRecordFactory::createReceiveResourceData):
(WebCore::TimelineRecordFactory::createLayoutData):
(WebCore::TimelineRecordFactory::createParseHTMLData):
(WebCore::TimelineRecordFactory::createAnimationFrameData):
(WebCore::createQuad):
* inspector/TimelineRecordFactory.h:
(WebCore::TimelineRecordFactory::createWebSocketCreateData):
(WebCore::TimelineRecordFactory::createGenericWebSocketData):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][CoordinatedGraphics] Move CoordinatedGraphicsScene and CoordinatedBackingStore...
ryuan.choi@gmail.com [Fri, 12 Sep 2014 04:19:03 +0000 (04:19 +0000)]
[EFL][CoordinatedGraphics] Move CoordinatedGraphicsScene and CoordinatedBackingStore to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=136770

Reviewed by Gyuyoung Kim.

CoordinatedGraphicsScene and CoordinatedBackingStore is only for UIProcess.
This patch moved them from WebCore to WebKit2/UIProcess/CoordinatedGraphics/.

Source/WebCore:

No new tests, no behavior change.

* PlatformEfl.cmake:

Source/WebKit2:

* PlatformEfl.cmake:
* UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:
* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp.
* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedBackingStore.h.
* UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.cpp: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp.
* UIProcess/CoordinatedGraphics/CoordinatedGraphicsScene.h: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h.
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
* UIProcess/CoordinatedGraphics/WebView.cpp:
* UIProcess/efl/WebViewEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoThe overrideMimeType in XMLHttpRequest should throw the exception.
commit-queue@webkit.org [Fri, 12 Sep 2014 02:27:06 +0000 (02:27 +0000)]
The overrideMimeType in XMLHttpRequest should throw the exception.
https://bugs.webkit.org/show_bug.cgi?id=136699

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-09-11
Reviewed by Darin Adler.

Source/WebCore:

No new tests, modifed test http/tests/xmlhttprequest/exceptions.html.

Set XMLHttpRequest::overrideMimeType to throw an "InvalidStateError" exception, if the state is LOADING or DONE.

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::overrideMimeType):
* xml/XMLHttpRequest.h:
* xml/XMLHttpRequest.idl:

LayoutTests:

Added test to check for "InvalidStateError" exception for overrideMimeType.

* http/tests/xmlhttprequest/exceptions-expected.txt:
* http/tests/xmlhttprequest/exceptions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Occasional ASSERT closing web inspector
commit-queue@webkit.org [Fri, 12 Sep 2014 01:50:24 +0000 (01:50 +0000)]
Web Inspector: Occasional ASSERT closing web inspector
https://bugs.webkit.org/show_bug.cgi?id=136762

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-09-11
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

It is harmless, and indeed possible to have an empty set of listeners
now that each Page gets its own PageDebugServer instead of a shared
global. So we should replace the null checks with isEmpty checks.
Since nobody was ever returning null, convert to references as well.

* inspector/JSGlobalObjectScriptDebugServer.h:
* inspector/ScriptDebugServer.cpp:
(Inspector::ScriptDebugServer::dispatchBreakpointActionLog):
(Inspector::ScriptDebugServer::dispatchBreakpointActionSound):
(Inspector::ScriptDebugServer::dispatchBreakpointActionProbe):
(Inspector::ScriptDebugServer::sourceParsed):
(Inspector::ScriptDebugServer::dispatchFunctionToListeners):
(Inspector::ScriptDebugServer::notifyDoneProcessingDebuggerEvents):
(Inspector::ScriptDebugServer::handlePause):
(Inspector::ScriptDebugServer::needPauseHandling): Deleted.
* inspector/ScriptDebugServer.h:

Source/WebCore:

* bindings/js/WorkerScriptDebugServer.h:
* inspector/PageScriptDebugServer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agolldb_webkit.py:btjs doesn't work with release builds
msaboff@apple.com [Fri, 12 Sep 2014 01:04:05 +0000 (01:04 +0000)]
lldb_webkit.py:btjs doesn't work with release builds
https://bugs.webkit.org/show_bug.cgi?id=136760

Reviewed by Jer Noble.

If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
we can't get a valid result from trying either call.  In that case, we fallback to
just showing the PC.  Also added check for both entry points.  If neither is found,
we issue a warning and output the stack trace without JavaScript annotations.

* lldb/lldb_webkit.py:
(btjs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSimplify DOM tree traversal in FrameSelection::setSelectionFromNone()
cdumez@apple.com [Fri, 12 Sep 2014 00:40:09 +0000 (00:40 +0000)]
Simplify DOM tree traversal in FrameSelection::setSelectionFromNone()
https://bugs.webkit.org/show_bug.cgi?id=136763

Reviewed by Ryosuke Niwa.

We only need to traverse the direct children of the Document element to
find the body. The previous code was potentially traversing descendants.
The new code is consistent with Document::body() except that we only
look for an HTMLBodyElement (and ignore HTMLFrameSetElement).

Also update the code to use tighter typing for clarity.

No new tests, no behavior change.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelectionFromNone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: Size of web view in Safari as reported by AX changes when adding/removing bars...
cfleizach@apple.com [Fri, 12 Sep 2014 00:32:05 +0000 (00:32 +0000)]
AX: Size of web view in Safari as reported by AX changes when adding/removing bars is wrong
https://bugs.webkit.org/show_bug.cgi?id=136756

Reviewed by Beth Dakin.

Source/WebCore:

topContentInset not only seems to push the scroll view's origin down, but it also shrinks its height as well, which
was not accounted for in the original fix.

Modified: platform/mac-wk2/accessibility/content-inset-scrollview-frame.html

* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::elementRect):

LayoutTests:

* platform/mac-wk2/accessibility/content-inset-scrollview-frame-expected.txt:
* platform/mac-wk2/accessibility/content-inset-scrollview-frame.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Fix assert in QuickConsole - main frame execution context path component
commit-queue@webkit.org [Thu, 11 Sep 2014 23:12:53 +0000 (23:12 +0000)]
Web Inspector: Fix assert in QuickConsole - main frame execution context path component
https://bugs.webkit.org/show_bug.cgi?id=136748

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-09-11
Reviewed by Timothy Hatcher.

This can get called for the MainFrame on page navigations.
In such cases we can return a better result from this method.

* UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Windows] Unreviewed build fix.
roger_fong@apple.com [Thu, 11 Sep 2014 22:46:00 +0000 (22:46 +0000)]
[Windows] Unreviewed build fix.
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::checkVaryingsPacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWebKit scrollbars flash in non-dominant spaces when entering Mission Control
bdakin@apple.com [Thu, 11 Sep 2014 22:18:58 +0000 (22:18 +0000)]
WebKit scrollbars flash in non-dominant spaces when entering Mission Control
https://bugs.webkit.org/show_bug.cgi?id=136761
-and corresponding-
rdar://problem/18195616

Reviewed by Tim Horton.

This patch makes our logic about when to call ScrollableArea::contentAreaDidHide/
Show match the logic in AppKit. We only want these notifications when the window
has become both visible and active (or lost both, in the case of hide).

Re-name setIsVisibleInternal() to setIsVisibleAndActiveInternal(), and call it
only when both visibility and active-state have changed.
* page/FocusController.cpp:
(WebCore::FocusController::setViewState):
(WebCore::FocusController::setIsVisibleAndActiveInternal):
(WebCore::FocusController::setIsVisibleInternal): Deleted.
* page/FocusController.h:

FocusController::setViewState() is the only place that needs to call
ScrollableArea::contentAreaDidHide/Show, so remove these callers.
* page/FrameView.cpp:
(WebCore::FrameView::didMoveOnscreen): Deleted.
(WebCore::FrameView::willMoveOffscreen): Deleted.
* page/FrameView.h:
* page/Page.cpp:
(WebCore::Page::setIsVisibleInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove JSScope out of JSFunction into separate JSCallee class
msaboff@apple.com [Thu, 11 Sep 2014 21:52:33 +0000 (21:52 +0000)]
Move JSScope out of JSFunction into separate JSCallee class
https://bugs.webkit.org/show_bug.cgi?id=136725

Reviewed by Oliver Hunt.

Created new JSCallee class that contains a JSScope*.  Changed JSFunction to inherit from
JSCallee.

Source/JavaScriptCore:

* CMakeLists.txt:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
Build changes.  Added JSCallee.cpp and JSCallee.h.

* runtime/JSCallee.cpp: Added.
(JSC::JSCallee::create):
(JSC::JSCallee::destroy):
(JSC::JSCallee::JSCallee):
(JSC::JSCallee::finishCreation):
(JSC::JSCallee::visitChildren):
(JSC::JSCallee::getOwnPropertySlot): Pass through wrapper function.
(JSC::JSCallee::getOwnNonIndexPropertyNames): Pass through wrapper function.
(JSC::JSCallee::put): Pass through wrapper function.
(JSC::JSCallee::deleteProperty): Pass through wrapper function.
(JSC::JSCallee::defineOwnProperty): Pass through wrapper function.

* runtime/JSCallee.h: Added.
(JSC::JSCallee::scope):
(JSC::JSCallee::scopeUnchecked):
(JSC::JSCallee::setScope):
(JSC::JSCallee::createStructure):
(JSC::JSCallee::offsetOfScopeChain):

* runtime/JSFunction.cpp:
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::addNameScopeIfNeeded):
(JSC::JSFunction::visitChildren):
* runtime/JSFunction.h:
(JSC::JSFunction::scope): Deleted.
(JSC::JSFunction::scopeUnchecked): Deleted.
(JSC::JSFunction::setScope): Deleted.
(JSC::JSFunction::offsetOfScopeChain): Deleted.
* runtime/JSFunctionInlines.h:
(JSC::JSFunction::JSFunction):
Changed to reference JSCallee and its methods.

* runtime/JSType.h: Added JSCallee as a TypeEnum.

Source/WebCore:

* ForwardingHeaders/runtime/JSCallee.h: New forwarding header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDo the bmalloc.
ggaren@apple.com [Thu, 11 Sep 2014 21:45:45 +0000 (21:45 +0000)]
Do the bmalloc.
https://bugs.webkit.org/show_bug.cgi?id=132629

Reviewed by Michael Saboff.

64-bit only for now, just to try it out.

* wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix iOS.
roger_fong@apple.com [Thu, 11 Sep 2014 21:18:54 +0000 (21:18 +0000)]
Unreviewed build fix iOS.

* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::checkVaryingsPacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agobmalloc should segregate medium-sized objects by line like it does for small-sized...
ggaren@apple.com [Thu, 11 Sep 2014 20:58:02 +0000 (20:58 +0000)]
bmalloc should segregate medium-sized objects by line like it does for small-sized objects
https://bugs.webkit.org/show_bug.cgi?id=136693

Reviewed by Gavin Barraclough.

4% reduction in heap size on the MallocBench *_memory_warning benchmarks.

No throughput change.

We keep an array of medium allocators, just like our array of small
allocators.

In future, we can simplify the allocation fast path by merging the small
and medium allocator arrays. For now, this is the simplest change that
gets the win.

* bmalloc/Allocator.cpp:
(bmalloc::Allocator::Allocator):
(bmalloc::Allocator::scavenge):
(bmalloc::Allocator::allocateMedium):
* bmalloc/Allocator.h:
* bmalloc/Sizes.h:
(bmalloc::Sizes::mediumSizeClassFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r173530.
commit-queue@webkit.org [Thu, 11 Sep 2014 20:54:35 +0000 (20:54 +0000)]
Unreviewed, rolling out r173530.
https://bugs.webkit.org/show_bug.cgi?id=136757

Unskipped still fail on bots. (Requested by rfong on #webkit).

Reverted changeset:

"Temporary change to determine why some snapshotting tests are
failing only on bots."
http://trac.webkit.org/changeset/173530

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Hide DOM search result highlights when find banner is not showing
commit-queue@webkit.org [Thu, 11 Sep 2014 20:44:38 +0000 (20:44 +0000)]
Web Inspector: Hide DOM search result highlights when find banner is not showing
https://bugs.webkit.org/show_bug.cgi?id=136749

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-09-11
Reviewed by Timothy Hatcher.

Match search highlights in TextEditor by only showing the highlight
when the find banner is showing.

* UserInterface/Views/DOMTreeOutline.css:
(.showing-find-banner .dom-tree-outline .search-result):
(.dom-tree-outline .search-highlight): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agowebkitpy test failures from import-w3c-tests
commit-queue@webkit.org [Thu, 11 Sep 2014 20:38:19 +0000 (20:38 +0000)]
webkitpy test failures from import-w3c-tests
https://bugs.webkit.org/show_bug.cgi?id=136752

Patch by Rebecca Hauck <rhauck@adobe.com> on 2014-09-11
Reviewed by Bem Jones-Bey.

This patch fixes a bug in import-w3c-tests where we were appending
the wrong set of files to the copy_list. This also updates the tests
to clear the failures introduced in the patch for bug 135929.

* Scripts/webkitpy/w3c/test_converter_unittest.py:
(W3CTestConverterTest.test_read_prefixed_property_list):
* Scripts/webkitpy/w3c/test_parser.py:
(TestParser.analyze_test):
(TestParser.support_files):
* Scripts/webkitpy/w3c/test_parser_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r172129): Vine pages load as blank
fpizlo@apple.com [Thu, 11 Sep 2014 20:04:38 +0000 (20:04 +0000)]
REGRESSION (r172129): Vine pages load as blank
https://bugs.webkit.org/show_bug.cgi?id=136655
rdar://problem/18281215

Reviewed by Michael Saboff.

If lastNode is something that is subject to DCE, then removing the Phantom's reference to something
that lastNode references means that the thing being referenced may no longer be kept alive for OSR.
Teach PhantomRemovalPhase that it's only safe to do this if lastNode is a Phantom. That's probably too
conservative, but that's fine since this is mainly just an optimization to make the IR sane to read and
reasonably compact; it's OK if we miss cases here.

* dfg/DFGPhantomRemovalPhase.cpp:
(JSC::DFG::PhantomRemovalPhase::run):
* tests/stress/remove-phantom-after-setlocal.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd site-specific quirk for entering fullscreen on YouTube.com.
jer.noble@apple.com [Thu, 11 Sep 2014 19:57:33 +0000 (19:57 +0000)]
Add site-specific quirk for entering fullscreen on YouTube.com.
https://bugs.webkit.org/show_bug.cgi?id=136742

Reviewed by Eric Carlson.

YouTube only resizes its <video> content when entering fullscreen after receiving the "webkitfullscreenchange"
event, which is fired once the animation to enter fullscreen completes. This leaves the apparent <video> content
too small during the animation, especially at the beginning of the animation. Add a site-specific hack for
YouTube sites which fires the "webkitfullscreenchange" event synchronously with the beginning of the enter
fullscreen animation. This will cause YouTube to resize their <video> content during the period of time where we
disable screen updates, and makes the enter fullscreen animation seamless.

Add a static utility method, hostIsYouTube(), for the various pieces of this site-specific hack, and expand it
to match youtube.co.uk, youtube.fr, etc.

* dom/Document.cpp:
(WebCore::hostIsYouTube): Added.
(WebCore::Document::webkitWillEnterFullScreenForElement): Fire fullscreenchange event if hacks are enabled.
(WebCore::Document::webkitDidEnterFullScreenForElement): Don't fire the event if same.
(WebCore::Document::webkitDidExitFullScreenForElement): Use hostIsYouTube().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMore unreviewed gardening. Rebaseline some ML expected results.
jer.noble@apple.com [Thu, 11 Sep 2014 19:49:02 +0000 (19:49 +0000)]
More unreviewed gardening. Rebaseline some ML expected results.

* platform/mac-mountainlion/media/video-controls-captions-trackmenu-sorted-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Font Loading] Enable CSS Font Loading on Mac
betravis@adobe.com [Thu, 11 Sep 2014 19:37:29 +0000 (19:37 +0000)]
[CSS Font Loading] Enable CSS Font Loading on Mac
https://bugs.webkit.org/show_bug.cgi?id=135473

Reviewed by Antti Koivisto.

Source/JavaScriptCore:

Enable CSS Font Loading in FeatureDefines.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Enable CSS Font Loading in FeatureDefines, and in
RuntimeEnabledFeatures.

Font Loading tests have been toggled back on in the Mac
TestExpectations file.

* Configurations/FeatureDefines.xcconfig:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

Source/WebKit/mac:

Enable CSS Font Loading in FeatureDefines.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Enable CSS Font Loading in FeatureDefines.

* Configurations/FeatureDefines.xcconfig:

LayoutTests:

Enable tests on the Mac platform. As more platforms
are added, this should move from the tests defaulting
to disabled to the tests defaulting to enabled.

* platform/mac/TestExpectations: Mark the Font Loading
tests as enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTemporary change to determine why some snapshotting tests are failing only on bots.
roger_fong@apple.com [Thu, 11 Sep 2014 19:34:17 +0000 (19:34 +0000)]
Temporary change to determine why some snapshotting tests are failing only on bots.
Unskip skipped snapshotting tests and increase the time before we check the plugin state to 10s.
* platform/mac-wk2/TestExpectations:
* plugins/snapshotting/set-plugin-size-to-tiny.html:
* plugins/snapshotting/simple.html:
* plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSome MallocBench refinements
ggaren@apple.com [Thu, 11 Sep 2014 19:33:47 +0000 (19:33 +0000)]
Some MallocBench refinements
https://bugs.webkit.org/show_bug.cgi?id=136750

Reviewed by Sam Weinig.

* MallocBench/MallocBench/Interpreter.cpp:
(Interpreter::run): Allow for null entries in the object list so that
we can test in modes that exclude large or small allocations.

* MallocBench/MallocBench/churn.cpp:
(benchmark_churn):
* MallocBench/MallocBench/flickr.cpp:
(benchmark_flickr):
* MallocBench/MallocBench/fragment.cpp:
(benchmark_fragment_iterate):
* MallocBench/MallocBench/list.cpp:
(benchmark_list_allocate):
* MallocBench/MallocBench/reddit.cpp:
(benchmark_reddit): Updated test runtimes to weight them more equally,
for the sake of arithmetic mean.

* MallocBench/MallocBench/stress.cpp:
(Object::Object):
(allocate):
(deallocate):
(benchmark_stress): Verify the contents of memory as we go. Also,
force scavenging each time through the loop to test the scavenging path.

* MallocBench/MallocBench/theverge.cpp:
(benchmark_theverge):
* MallocBench/MallocBench/tree.cpp:
(benchmark_tree_churn): Re-weighted, as above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse tighter typing for Document::ownerElement() return value
cdumez@apple.com [Thu, 11 Sep 2014 19:26:16 +0000 (19:26 +0000)]
Use tighter typing for Document::ownerElement() return value
https://bugs.webkit.org/show_bug.cgi?id=136746

Reviewed by Ryosuke Niwa.

Use tighter typing for Document::ownerElement() return value at call
sites to increase code readability a bit and allow the compiler to
generate slightly more efficient code in some cases. In particular,
the more efficient HTMLElement::hasTagName(HTMLQualifiedName) is
now called in several cases instead of the one on Node. This bypasses
unnecessary isHTMLElement() checks.

No new tests, no behavior change.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::alternativeTextForWebArea):
* dom/Document.cpp:
(WebCore::Document::updateLayout):
(WebCore::Document::topDocument):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCheck for varying packing restrictions per program instead of per shader.
roger_fong@apple.com [Thu, 11 Sep 2014 19:22:06 +0000 (19:22 +0000)]
Check for varying packing restrictions per program instead of per shader.
https://bugs.webkit.org/show_bug.cgi?id=136585.
<rdar://problem/16308409>.

Reviewed by Dean Jackson.

Covered by webgl/1.0.2/conformance/ogles/GL/build/build_009_to_016.html.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::linkProgram):
Check for varying packing restrictions when linking the program.

* platform/graphics/GraphicsContext3D.h:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::checkVaryingsPacking):
Checks varyings shared by both vertex and fragment shaders and makes sure
they satisfy packing restrictions.

Remove varying packing restrictions checks from ANGLE.
* src/compiler/translator/Compiler.cpp:
(TCompiler::compile):
(TCompiler::enforcePackingRestrictions):
* src/compiler/translator/ShHandle.h:

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed rebaseline of inspector generator test results after r173120.
joepeck@webkit.org [Thu, 11 Sep 2014 19:20:17 +0000 (19:20 +0000)]
Unreviewed rebaseline of inspector generator test results after r173120.

* inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
* inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
* inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
* inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoReviewed by Sam Weinig.
ggaren@apple.com [Thu, 11 Sep 2014 19:12:48 +0000 (19:12 +0000)]
Reviewed by Sam Weinig.

Renamed log => retire for clarity.

* bmalloc/Allocator.cpp:
(bmalloc::Allocator::scavenge):
(bmalloc::Allocator::retire):
(bmalloc::Allocator::allocateMedium):
(bmalloc::Allocator::allocateSlowCase):
(bmalloc::Allocator::log): Deleted.
* bmalloc/Allocator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agobmalloc: eager scavenge leaves behind a bogus allocator
ggaren@apple.com [Thu, 11 Sep 2014 19:05:38 +0000 (19:05 +0000)]
bmalloc: eager scavenge leaves behind a bogus allocator
https://bugs.webkit.org/show_bug.cgi?id=136743

Reviewed by Sam Weinig.

Be sure to clear the allocator after logging it in the eager scavenge
case, so that we don't later try to allocate out of the lines that we
have thrown away.

We didn't need to do this previously because scavenge would only happen
at thread exit time, after which no further allocation from the per-thread
cache would take place.

* bmalloc/Allocator.cpp:
(bmalloc::Allocator::scavenge):
* bmalloc/MediumAllocator.h:
(bmalloc::MediumAllocator::clear):
* bmalloc/SmallAllocator.h:
(bmalloc::SmallAllocator::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSupport rubber-banding in sub-frames
bdakin@apple.com [Thu, 11 Sep 2014 18:48:21 +0000 (18:48 +0000)]
Support rubber-banding in sub-frames
https://bugs.webkit.org/show_bug.cgi?id=136726
-and corresponding-
rdar://problem/10011924

Reviewed by Tim Horton.

Source/WebCore:

Set the appropriate scroll elasticity for all frames! As long as its enabled, sub-
frames want an elasticity of ScrollElasticityAutomatic, which will allow for
latching.
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):

Account for rubber-banding in sub-frames.
(WebCore::FrameView::isScrollableOrRubberbandable):
(WebCore::FrameView::hasScrollableOrRubberbandableAncestor):

This patch also re-names rubberBandingForOverflowScrollEnabled to
rubberBandingForSubScrollableRegionsEnabled
* page/Settings.in:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::overhangAmount):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):

Source/WebKit/mac:

rubberBandingForOverflowScrollEnabled is re-named to
rubberBandingForSubScrollableRegionsEnabled
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

LayoutTests:

* platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-expected.txt:
* platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: DOM Tree search highlights are not appearing
joepeck@webkit.org [Thu, 11 Sep 2014 18:35:36 +0000 (18:35 +0000)]
Web Inspector: DOM Tree search highlights are not appearing
https://bugs.webkit.org/show_bug.cgi?id=136662

Reviewed by Timothy Hatcher.

When performing a search within the DOMTreeContentView all
search results should immediately highlight. When moving
between search results, emphasize the current with a bouncy.
Remember to remove the highlights when the search is changed
or cleared.

* UserInterface/Views/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView.prototype.performSearch.searchResultsReady):
(WebInspector.DOMTreeContentView.prototype.searchCleared):
Shor or hide highlights when searches change.

(WebInspector.DOMTreeContentView.prototype.revealResult):
(WebInspector.DOMTreeContentView.prototype._revealSearchResult):
Emphasize the highlight when moving to a new current result.

(WebInspector.DOMTreeContentView.prototype._showSearchHighlights):
(WebInspector.DOMTreeContentView.prototype._hideSearchHighlights):
On each affected DOMTreeElement show or hide search highlights.

* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight.animationEnded):
(WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
Give a brief bouncy-highlight when told to emphasize the search highlight.

(WebInspector.DOMTreeElement.prototype.updateTitle):
Remove unused and unnecessary style class on each row.

(WebInspector.DOMTreeElement.prototype._highlightSearchResults):
Update the stale code to use new function names and accessors.

* UserInterface/Views/DOMTreeOutline.css:
(.dom-tree-outline .search-highlight):
Styles for the search highlight match search highlights in the sidebar.

* UserInterface/Views/Main.css:
(.bouncy-highlight):
* UserInterface/Views/TextEditor.css:
Move bouncy-highlight to Main.css.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoInitial implementation of SVG to OTF font converter
mmaxfield@apple.com [Thu, 11 Sep 2014 18:29:43 +0000 (18:29 +0000)]
Initial implementation of SVG to OTF font converter
https://bugs.webkit.org/show_bug.cgi?id=136688

Patch by Myles C. Maxfield <mmaxfield@apple.com> <litherum@gmail.com> on 2014-09-11
Reviewed by Darin Adler.

This patch creates a new file and new function which turns an SVG font into an OpenType font.
This function is not very full featured, and as such is never called. However, it works with
fonts that only support simple horizontal basic multilingual plane codepoints. It has only
been tested on OS X, and does not have any automated tests. This patch is only jumping off
point, laying the basic groundwork for a more robust font converter.

The goal of this patch is to eventually allow us to delete the codepath with which we draw
text using SVG fonts. Using a native codepath instead will allow for better performance,
security, and code clarity. In my initial benchmarks, using this converter instead of the
SVG codepath is at least a 100x speed improvement (after running for 4 hours I stepped
away from my machine).

No new tests because the function is not ready to be called (yet!)
Initial implementation of SVG to OTF font converter
https://bugs.webkit.org/show_bug.cgi?id=136688

* WebCore.xcodeproj/project.pbxproj: Add new file.
* svg/SVGPathBuilder.h: Single function. Takes a SVGFontElement and returns a byte
* svg/SVGToOTFFontConversion.cpp: Added.
(WebCore::write32): Write a big-endian Int32.
(WebCore::write16): Write a big-endian Int16.
(WebCore::overwrite32): Overwrite an existing Int32 in a vector (instead of appending)
(WebCore::SVGToOTFFontConverter::GlyphData::GlyphData): Internal class to hold state during
function calls.
(WebCore::roundDownToPowerOfTwo):
(WebCore::SVGToOTFFontConverter::appendCMAPTable): See function name.
(WebCore::SVGToOTFFontConverter::appendHEADTable): Ditto.
(WebCore::clampTo): Used to clamp data types to fit into other data types.
(WebCore::SVGToOTFFontConverter::appendHHEATable): See function name.
(WebCore::SVGToOTFFontConverter::appendHMTXTable): Ditto.
(WebCore::SVGToOTFFontConverter::appendMAXPTable): Ditto.
(WebCore::SVGToOTFFontConverter::appendNAMETable): Ditto.
(WebCore::SVGToOTFFontConverter::appendOS2Table): Ditto.
(WebCore::SVGToOTFFontConverter::appendPOSTTable): Ditto.
(WebCore::isValidStringForCFF): The CFF font format only allows strings with particular
characters in them.
(WebCore::appendCFFValidString): Append a string assuming it's valid to append.
(WebCore::SVGToOTFFontConverter::appendCFFTable): See function name.
(WebCore::SVGToOTFFontConverter::appendVORGTable): Ditto.
(WebCore::writeCFFEncodedNumber): CFF has this wacky encoding scheme for encoding and
decoding numbers.
(WebCore::CFFBuilder::CFFBuilder): Subclass of SVGPathBuilder, which is used for building
CFF CharStrings (which are glyph path representations).
(WebCore::CFFBuilder::updateForConstituentPoint): Invoked for every point in a path, does
things like updates glyph bounding box information.
(WebCore::CFFBuilder::boundingBox): Getter.
(WebCore::transcodeGlyphPaths): SVG path data string -> CFF CharString
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Generate internal state ahead of
time before generating any tables.
(WebCore::isFourByteAligned):
(WebCore::calculateChecksum): OTF files have checksums.
(WebCore::SVGToOTFFontConverter::appendTable): Invoked for each entry in the table of
contents of the OTF font.
(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont): Write out the tables.
(WebCore::convertSVGToOTFFont): Entry point.
* svg/SVGToOTFFontConversion.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EME] REGRESSION(??): test media/encrypted-media/encrypted-media-v2-syntax.html is...
jer.noble@apple.com [Thu, 11 Sep 2014 18:24:17 +0000 (18:24 +0000)]
[EME] REGRESSION(??): test media/encrypted-media/encrypted-media-v2-syntax.html is failing
https://bugs.webkit.org/show_bug.cgi?id=136723

Source/WebCore:

Reviewed by Eric Carlson.

Update a comment to point to the implemented Working Draft 18 Feburary 2014 version of the spec.

* Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::createSession):

LayoutTests:

Update the test to match the implemented Working Draft 18 Feburary 2014 version of the spec.

Reviewed by Eric Carlson.

* media/encrypted-media/encrypted-media-v2-syntax-expected.txt:
* media/encrypted-media/encrypted-media-v2-syntax.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed gardening. Rebaseline tests and remove duplicate entry from TestExpectations.
jer.noble@apple.com [Thu, 11 Sep 2014 18:21:04 +0000 (18:21 +0000)]
Unreviewed gardening. Rebaseline tests and remove duplicate entry from TestExpectations.

* platform/mac/TestExpectations:
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-volume-slider-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMore unreviewed gardening. Rebaseline media/encrypted-media/encrypted-media-can-play...
jer.noble@apple.com [Thu, 11 Sep 2014 18:21:02 +0000 (18:21 +0000)]
More unreviewed gardening. Rebaseline media/encrypted-media/encrypted-media-can-play-type.html

* platform/mac/media/encrypted-media/encrypted-media-can-play-type-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRename activation to be more in line with spec language
oliver@apple.com [Thu, 11 Sep 2014 18:18:14 +0000 (18:18 +0000)]
Rename activation to be more in line with spec language
https://bugs.webkit.org/show_bug.cgi?id=136721

Reviewed by Michael Saboff.

Somewhat bigger than the last one, but still just a rename.

* CMakeLists.txt:
* JavaScriptCore.order:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/BytecodeList.json:
* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
* bytecode/CallVariant.h:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::isCaptured):
(JSC::CodeBlock::nameForRegister):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::setActivationRegister):
(JSC::CodeBlock::activationRegister):
(JSC::CodeBlock::uncheckedActivationRegister):
(JSC::CodeBlock::needsActivation):
* bytecode/Instruction.h:
* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::setActivationRegister):
(JSC::UnlinkedCodeBlock::activationRegister):
(JSC::UnlinkedCodeBlock::hasActivationRegister):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitReturn):
* bytecompiler/BytecodeGenerator.h:
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::scope):
* debugger/DebuggerScope.cpp:
(JSC::DebuggerScope::isFunctionOrEvalScope):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::tryGetActivation):
(JSC::DFG::Graph::tryGetRegisters):
* dfg/DFGGraph.h:
* dfg/DFGNodeType.h:
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::lexicalEnvironment):
(JSC::CallFrame::setActivation):
(JSC::CallFrame::activation): Deleted.
* interpreter/CallFrame.h:
* interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
* interpreter/Register.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_tear_off_lexical_environment):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_create_lexical_environment):
(JSC::JIT::emit_op_tear_off_activation): Deleted.
(JSC::JIT::emit_op_create_activation): Deleted.
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_tear_off_lexical_environment):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_create_lexical_environment):
(JSC::JIT::emit_op_tear_off_activation): Deleted.
(JSC::JIT::emit_op_create_activation): Deleted.
* jit/JITOperations.cpp:
* jit/JITOperations.h:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LLIntSlowPaths.h:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/Arguments.cpp:
(JSC::Arguments::visitChildren):
(JSC::Arguments::tearOff):
(JSC::Arguments::didTearOffActivation):
* runtime/Arguments.h:
(JSC::Arguments::offsetOfActivation):
(JSC::Arguments::argument):
(JSC::Arguments::finishCreation):
* runtime/CommonSlowPaths.cpp:
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::activationStructure):
* runtime/JSLexicalEnvironment.cpp: Renamed from Source/JavaScriptCore/runtime/JSActivation.cpp.
(JSC::JSLexicalEnvironment::visitChildren):
(JSC::JSLexicalEnvironment::symbolTableGet):
(JSC::JSLexicalEnvironment::symbolTablePut):
(JSC::JSLexicalEnvironment::getOwnNonIndexPropertyNames):
(JSC::JSLexicalEnvironment::symbolTablePutWithAttributes):
(JSC::JSLexicalEnvironment::getOwnPropertySlot):
(JSC::JSLexicalEnvironment::put):
(JSC::JSLexicalEnvironment::deleteProperty):
(JSC::JSLexicalEnvironment::toThis):
(JSC::JSLexicalEnvironment::argumentsGetter):
* runtime/JSLexicalEnvironment.h: Renamed from Source/JavaScriptCore/runtime/JSActivation.h.
(JSC::JSLexicalEnvironment::create):
(JSC::JSLexicalEnvironment::createStructure):
(JSC::JSLexicalEnvironment::JSLexicalEnvironment):
(JSC::asActivation):
(JSC::Register::lexicalEnvironment):
(JSC::JSLexicalEnvironment::registersOffset):
(JSC::JSLexicalEnvironment::tearOff):
(JSC::JSLexicalEnvironment::isTornOff):
(JSC::JSLexicalEnvironment::storageOffset):
(JSC::JSLexicalEnvironment::storage):
(JSC::JSLexicalEnvironment::allocationSize):
(JSC::JSLexicalEnvironment::isValidIndex):
(JSC::JSLexicalEnvironment::isValid):
(JSC::JSLexicalEnvironment::registerAt):
* runtime/JSObject.h:
* runtime/JSScope.cpp:
(JSC::abstractAccess):
* runtime/JSScope.h:
(JSC::ResolveOp::ResolveOp):
* runtime/JSSymbolTableObject.cpp:
* runtime/StrictEvalActivation.h:
(JSC::StrictEvalActivation::create):
* runtime/VM.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] Authentication dialog is displayed for cross-origin XHR
commit-queue@webkit.org [Thu, 11 Sep 2014 17:20:18 +0000 (17:20 +0000)]
[WK2] Authentication dialog is displayed for cross-origin XHR
https://bugs.webkit.org/show_bug.cgi?id=131349

Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-09-11
Reviewed by Alexey Proskuryakov.

Source/WebCore:

* WebCore.exp.in: Export of isAllowedToAskUserForCredentials.
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::isAllowedToAskUserForCredentials): Replacing clientCredentialPolicy method. Returns true if credentials can be requested to the user.
(WebCore::ResourceLoader::didReceiveAuthenticationChallenge): Updated to use isAllowedToAskUserForCredentials.
* loader/ResourceLoader.h: Removing clientCredentialPolicy method and adding isAllowedToAskUserForCredentials method.

Source/WebKit2:

Precomputing client credential policy in the Web Process before sending the resource load task to the Network Process.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge): Added an ASSERT to ensure that credential policy is never set to DoNotAskClientForCrossOriginCredentials.
* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad): Precomputing client credential policy to handle the case of cross-origin requests.
* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::willSendRequest): Added a TODO to check whether redirections need a specific handling.

LayoutTests:

* platform/mac-wk2/TestExpectations: Unskipped tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: Children inside a <legend> are not accessible
cfleizach@apple.com [Thu, 11 Sep 2014 16:13:23 +0000 (16:13 +0000)]
AX: Children inside a <legend> are not accessible
https://bugs.webkit.org/show_bug.cgi?id=136735

Reviewed by Mario Sanchez Prada.

Source/WebCore:

The AX children of a <legend> are being hidden currently, which makes it impossible for
VoiceOver to activate control elements inside of a <legend>.
The solution is that legend elements SHOULD be allowed to have children.

Test: accessibility/legend-children-are-visible.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canHaveChildren):

LayoutTests:

* accessibility/legend-children-are-visible-expected.txt: Added.
* accessibility/legend-children-are-visible.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBlink merge: Speculative fix for windows run-webkit-tests hangs
bfulgham@apple.com [Thu, 11 Sep 2014 16:12:02 +0000 (16:12 +0000)]
Blink merge: Speculative fix for windows run-webkit-tests hangs
https://bugs.webkit.org/show_bug.cgi?id=136727

Reviewed by Csaba Osztrogon√°c.

Merged from Blink (patch by Dirk Pranke):
<https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>

* Scripts/webkitpy/common/system/executive.py:
(Executive.kill_process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix FIXME's in JSTrackCustom now that AudioTrack and VideoTrack exist.
b.long@cablelabs.com [Thu, 11 Sep 2014 15:03:42 +0000 (15:03 +0000)]
Fix FIXME's in JSTrackCustom now that AudioTrack and VideoTrack exist.
https://bugs.webkit.org/show_bug.cgi?id=136552

Reviewed by Eric Carlson.

* bindings/js/JSTrackCustom.cpp:
(WebCore::toTrack): Add casts for AudioTrack and VideoTrack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Layout Test http/tests/media/hls/video-controls-live-stream.html is flaky
philn@webkit.org [Thu, 11 Sep 2014 12:20:51 +0000 (12:20 +0000)]
[GTK] Layout Test http/tests/media/hls/video-controls-live-stream.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=134575

Unreviewed, marked the test as slow.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdded myself as a committer.
evab.u-szeged@partner.samsung.com [Thu, 11 Sep 2014 11:24:13 +0000 (11:24 +0000)]
Added myself as a committer.

Unreviewed.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Merge WebKitAuthenticationWidget into WebKitAuthenticationDialog
carlosgc@webkit.org [Thu, 11 Sep 2014 08:59:45 +0000 (08:59 +0000)]
[GTK] Merge WebKitAuthenticationWidget into WebKitAuthenticationDialog
https://bugs.webkit.org/show_bug.cgi?id=136700

Reviewed by Sergio Villar Senin.

Source/WebCore:

Remove WebKitAuthenticationWidget. The only reason why we had this
widget separated in WebCore was to share it between WebKit1 and
WebKit2, but now it's only used by WebKitAuthenticationDialog in WebKit2.

* PlatformGTK.cmake: Remove files from compilation.
* platform/gtk/WebKitAuthenticationWidget.cpp: Removed.
* platform/gtk/WebKitAuthenticationWidget.h: Removed.

Source/WebCore/platform/gtk/po:

* POTFILES.in: Remove WebKitAuthenticationWidget.cpp and add WebKitAuthenticationDialog.cpp.

Source/WebKit2:

Copy WebKitAuthenticationWidget implementation inside
WebKitAuthenticationDialog using a normal GtkBox instead.

* UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:
(okButtonClicked):
(cancelButtonClicked):
(packTwoColumnLayoutInBox):
(createLabel):
(createEntry):
(webkitAuthenticationDialogInitialize): Remove the
CredentialStorageMode parameter since it's now a member.
(webkitAuthenticationDialogNew): Initialize the
CredentialStorageMode member too.
* UIProcess/API/gtk/WebKitAuthenticationDialog.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[JavaScriptCore] Fix FTL on platform EFL.
llango.u-szeged@partner.samsung.com [Thu, 11 Sep 2014 08:52:22 +0000 (08:52 +0000)]
[JavaScriptCore] Fix FTL on platform EFL.
https://bugs.webkit.org/show_bug.cgi?id=133571

Reviewed by Filip Pizlo.

.:

Revert r169181.

* Source/cmake/FindLIBCXXABI.cmake: Removed.
* Source/cmake/OptionsEfl.cmake:

Source/JavaScriptCore:

There are no compact_unwind sections on Linux systems so FTL crashes.
We have to parse eh_frame in FTLUnwindInfo instead of compact_unwind
and get the information for stack unwinding from there.

* CMakeLists.txt: Revert r169181.
* ftl/FTLCompile.cpp:
Change section name literals to use SECTION_NAME macro, because of architecture differencies.
(JSC::FTL::mmAllocateCodeSection):
(JSC::FTL::mmAllocateDataSection):
(JSC::FTL::compile):
* ftl/FTLJITCode.h:
We need the SECTION_NAME macro in FTLCompile and FTLLink, so we define it here.
* ftl/FTLLink.cpp:
(JSC::FTL::link):
* ftl/FTLState.h:
* ftl/FTLState.cpp:
(JSC::FTL::State::State):
* ftl/FTLUnwindInfo.h:
* ftl/FTLUnwindInfo.cpp:
Lift the eh_frame parsing method from LLVM/libcxxabi project and modify it for our purposes.
Parse eh_frame on Linux instead of compact_unwind.
(JSC::FTL::UnwindInfo::parse):

Tools:

* efl/install-dependencies: Revert r169181.
* efl/jhbuild.modules: Clone and build a custom branch.
This branch contains some fix for FTL of platform EFL.
The branch is a fork of llvm r206311.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
commit-queue@webkit.org [Thu, 11 Sep 2014 06:41:06 +0000 (06:41 +0000)]
[EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
https://bugs.webkit.org/show_bug.cgi?id=136698

Patch by Tanay C <tanay.c@samsung.com> on 2014-09-10
Reviewed by Gyuyoung Kim.

* MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
(on_mouse_wheel): Added.
(window_free):
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse ASSERT instead of ASSERT_WITH_SECURITY_IMPLICATION
gyuyoung.kim@samsung.com [Thu, 11 Sep 2014 04:42:38 +0000 (04:42 +0000)]
Use ASSERT instead of ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=136732

Reviewed by Andy Estes.

Since r173458 changed to use static_cast<> with toFoo, ASSERT_WITH_SECURITY_IMPLICATION doesn't
need to be used anymore. ASSERT is enough for it.

* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::addToWorkerDocuments):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::document):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[SVG] Cleanup iterator code in SMILTimeContainer using range-based loop
cavalcantii@gmail.com [Thu, 11 Sep 2014 04:01:53 +0000 (04:01 +0000)]
[SVG] Cleanup iterator code in SMILTimeContainer using range-based loop
https://bugs.webkit.org/show_bug.cgi?id=136720

Reviewed by Filip Pizlo.

No new tests, no change on behavior.

* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Modify the type profiler runtime protocol to transfer some computation...
saambarati1@gmail.com [Thu, 11 Sep 2014 02:37:57 +0000 (02:37 +0000)]
Web Inspector: Modify the type profiler runtime protocol to transfer some computation into the WebInspector
https://bugs.webkit.org/show_bug.cgi?id=136500

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

This patch changes the type profiler protocol to the Web Inspector
by moving the work of calculating computed properties that effect the UI
into the Web Inspector. This makes the Web Inspector have control over the
strings it displays as UI elements representing type information to the user
instead of JavaScriptCore deciding on a convention for these strings.
JavaScriptCore now sends enough information to the Web Inspector so that
it can compute the properties JavaScriptCore used to compute.

* inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
* inspector/protocol/Runtime.json:
* runtime/TypeProfiler.cpp:
(JSC::TypeProfiler::getTypesForVariableAtOffsetForInspector): Deleted.
* runtime/TypeProfiler.h:
* runtime/TypeSet.cpp:
(JSC::TypeSet::inspectorTypeSet):
(JSC::StructureShape::leastCommonAncestor):
(JSC::StructureShape::inspectorRepresentation):
* runtime/TypeSet.h:

Source/WebInspectorUI:

This patch maintains the same UI in the Web Inspector for displaying
type information, but now accounts for the new protocol for type profiling.

The Inspector now has a TypeSet class that wraps the TypeDescription
protocol object and creates a simple interface for asking protocol objects
about their type.

* UserInterface/Controllers/TypeTokenAnnotator.js:
(WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):
* UserInterface/Main.html:
* UserInterface/Models/TypeSet.js: Added.
(WebInspector.TypeSet):
(WebInspector.TypeSet.fromPayload):
(WebInspector.TypeSet.prototype.isContainedIn):
* UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
* UserInterface/Views/TypePropertiesSection.js:
(WebInspector.TypePropertiesSection.prototype.onpopulate):
(WebInspector.TypePropertyTreeElement.prototype.onpopulate):
* UserInterface/Views/TypeTokenView.js:
(WebInspector.TypeTokenView.prototype.update):
(WebInspector.TypeTokenView.prototype._shouldShowPopover):
(WebInspector.TypeTokenView.prototype._displayTypeName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the build.
timothy_horton@apple.com [Thu, 11 Sep 2014 01:47:23 +0000 (01:47 +0000)]
Fix the build.

* platform/network/ResourceHandle.h:
* platform/network/mac/ResourceHandleMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
commit-queue@webkit.org [Thu, 11 Sep 2014 01:25:46 +0000 (01:25 +0000)]
[EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=136284

Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-09-10
Reviewed by Gyuyoung Kim.

* MiniBrowser/efl/main.c:
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDelete class SavedDrawingStateForMask
mmaxfield@apple.com [Thu, 11 Sep 2014 00:50:09 +0000 (00:50 +0000)]
Delete class SavedDrawingStateForMask
https://bugs.webkit.org/show_bug.cgi?id=136498

Patch by Myles C. Maxfield <mmaxfield@apple.com> <litherum@gmail.com> on 2014-09-09
Reviewed by Darin Adler.

This class is left over from when text-decoration-skip: ink used
GraphicsContext masking.

No new tests because there is no behavior change.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
* rendering/InlineTextBox.h:
* rendering/TextPainter.cpp:
(WebCore::TextPainter::TextPainter):
(WebCore::paintTextWithShadows):
(WebCore::TextPainter::paintText):
* rendering/TextPainter.h:
(WebCore::SavedDrawingStateForMask::SavedDrawingStateForMask): Deleted.
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintTextWithShadows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCall setCollectsTimingData only once, and before making any {CF,NS}URLConnections
timothy_horton@apple.com [Thu, 11 Sep 2014 00:47:26 +0000 (00:47 +0000)]
Call setCollectsTimingData only once, and before making any {CF,NS}URLConnections
https://bugs.webkit.org/show_bug.cgi?id=136731
<rdar://problem/18252844>

Reviewed by Simon Fraser.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start):
Move setCollectsTimingData to before createCFURLConnection, so the first connection
has timing data associated with it.

* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
Move setCollectsTimingData to before we create our NSURLConnection, so the first connection
has timing data associated with it.
Use setCollectsTimingData instead of the NSURLConnection SPI directly.

(WebCore::ResourceHandle::setCollectsTimingData):
Only call _setCollectsTimingData once.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173501 268f45cc-cd09-0410-ab3c-d52691b4dbfc