WebKit-https.git
8 years ago[Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
zoltan@webkit.org [Fri, 4 May 2012 12:10:26 +0000 (12:10 +0000)]
[Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=80400

Source/WebCore:

This change modifies the default ImageDecoder for Qt-port from QImageDecoder to WebCore ImageDecoder.
The new behavior is to use QImageDecoder only if WebCoreImageDecoder doesn't support the requested
image type.
The WTF_USE_QT_IMAGE_DECODER macro has been removed, since it is no longer needed.

This change adds build depedency for libpng-dev and libjpeg-dev packages, becuase PNG and JPEG imagedecoders
need not only these libraries, but their headers also. Qmake-config tests for these libraries were
introduced in r110045.

Reviewed by Simon Hausmann.

No new tests needed.

* Target.pri: Move WebCore ImageDecoder files out of guards. Remove ImageFrameQt.cpp from sources.
* WebCore.pri: Move WebCore ImageDecoder include paths out of guards.
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes): Add WebCore supported and Qt supported MIME types.
(WebCore::initializeSupportedImageMIMETypesForEncoding): Use Qt supported MIME types.
* platform/graphics/ImageSource.cpp: Remove unnecessary includes.
* platform/graphics/ImageSource.h: Remove unnecessary typedefs.
(WebCore):
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::filenameExtension): Remove unnecessary semicolon.
(WebCore::ImageDecoderQt::internalHandleCurrentImage): Use QImage and ImageFrame instead of QPixmap.
(WebCore):
(WebCore::ImageFrame::asNewNativeImage): Moved here from removed ImageFrameQt.cpp.
* platform/image-decoders/ImageDecoder.cpp: Reorganize the includes of the header.
(WebCore::ImageDecoder::create): Add platform macro guarded fallback case for QImageDecoder.
* platform/image-decoders/ImageDecoder.h: Remove Qt-specific codes.
(WebCore::ImageFrame::getAddr): Remove Qt-specific case, since it is no longer needed.
(ImageFrame):
* platform/image-decoders/qt/ImageFrameQt.cpp: Removed. Dead code, other code has been moved to
ImageDecoderQt.cpp.

Source/WebKit/blackberry:

Get rid off QT_IMAGE_DECODER flag.

Reviewed by Simon Hausmann.

* WebCoreSupport/AboutDataEnableFeatures.in:

Tools:

Remove WTF_USE_QT_IMAGE_DECODER macro.

Reviewed by Simon Hausmann.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, eval-blocked-in-about-blank-iframe.html: SLOW -> TIMEOUT
caseq@chromium.org [Fri, 4 May 2012 12:00:41 +0000 (12:00 +0000)]
Unreviewed gardening, eval-blocked-in-about-blank-iframe.html: SLOW -> TIMEOUT

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, update expected files.
ossy@webkit.org [Fri, 4 May 2012 10:59:01 +0000 (10:59 +0000)]
[Qt] Unreviewed gardening, update expected files.

* platform/qt/Skipped: Typo fix.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
* platform/qt/fast/block/float/overhanging-tall-block-expected.png:
* platform/qt/fast/block/float/overhanging-tall-block-expected.txt:
* platform/qt/fast/dom/Window/window-properties-device-orientation-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] ietestcenter/css3/flexbox tests fail on 32 bit
ossy@webkit.org [Fri, 4 May 2012 10:46:25 +0000 (10:46 +0000)]
[Qt] ietestcenter/css3/flexbox tests fail on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=85596

Unreviewed gardening, skip new failing tests.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed test expectations update after r116074
noel.gordon@gmail.com [Fri, 4 May 2012 10:37:01 +0000 (10:37 +0000)]
[chromium] Unreviewed test expectations update after r116074

* platform/chromium-mac/fast/images/png-suite/test-expected.png: Added.
* platform/chromium-win/fast/images/png-suite/test-expected.png: Added.
* platform/chromium/fast/images/png-suite/test-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, changed expectations for fast/images/png-suite/test.html from...
caseq@chromium.org [Fri, 4 May 2012 10:21:15 +0000 (10:21 +0000)]
Unreviewed gardening, changed expectations for fast/images/png-suite/test.html from IMAGE to MISSING.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, marking http/tests/security/contentSecurityPolicy/eval-blocked...
caseq@chromium.org [Fri, 4 May 2012 10:08:14 +0000 (10:08 +0000)]
Unreviewed gardening, marking http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html as slow.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116075.
carlosgc@webkit.org [Fri, 4 May 2012 09:39:33 +0000 (09:39 +0000)]
Unreviewed, rolling out r116075.
http://trac.webkit.org/changeset/116075

WebKit2 build was broken while WebKit2 build was disabled in bots,
so nobody noticed it. Disable the WebKit2 build for now to keep
the bots green again until we find the actual commit that
broke the WebKit2 build.

* configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: createRawLocationByURL is too slow if a big number of evals happen.
loislo@chromium.org [Fri, 4 May 2012 09:10:09 +0000 (09:10 +0000)]
Web Inspector: createRawLocationByURL is too slow if a big number of evals happen.
https://bugs.webkit.org/show_bug.cgi?id=85477

It iterates through all the _scripts even they have no url.
We can keep a separate map of scripts with url.

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype._globalObjectCleared):
(WebInspector.DebuggerModel.prototype._resetScriptsMap):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerModel.prototype.createRawLocationByURL):

LayoutTests:

* http/tests/inspector/compiler-script-mapping.html:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/raw-source-code.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] [DRT] fast/table/quote-text-around-iframe.html needs rebaselining
commit-queue@webkit.org [Fri, 4 May 2012 09:07:11 +0000 (09:07 +0000)]
[EFL] [DRT] fast/table/quote-text-around-iframe.html needs rebaselining
https://bugs.webkit.org/show_bug.cgi?id=85487

Unreviewed, EFL rebaseline after r115218.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-04

* platform/efl/fast/table/quote-text-around-iframe-expected.png:
* platform/efl/fast/table/quote-text-around-iframe-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Enable WebKit2 by default in configure.
carlosgc@webkit.org [Fri, 4 May 2012 08:20:40 +0000 (08:20 +0000)]
Unreviewed. Enable WebKit2 by default in configure.

This was removed in r115624 to make sure release 1.9.1 didn't have
WebKit2 enabled by default, because we are using the same library
versions for WebKit1 and WebKit2.

* configure.ac: Enable WebKit2 by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd PNG image pngsuite test
noel.gordon@gmail.com [Fri, 4 May 2012 07:25:15 +0000 (07:25 +0000)]
Add PNG image pngsuite test
https://bugs.webkit.org/show_bug.cgi?id=85567

Reviewed by Eric Seidel.

From http://www.schaik.com/pngsuite, add images from this suite and license
details. Add a layout test. Add platform exceptions (since all ports have a
different broken image).

* fast/images/png-suite/PngSuite.LICENSE: Added.
* fast/images/png-suite/samples/basi0g01.png: Added.
* fast/images/png-suite/samples/basi0g02.png: Added.
* fast/images/png-suite/samples/basi0g04.png: Added.
* fast/images/png-suite/samples/basi0g08.png: Added.
* fast/images/png-suite/samples/basi0g16.png: Added.
* fast/images/png-suite/samples/basi2c08.png: Added.
* fast/images/png-suite/samples/basi2c16.png: Added.
* fast/images/png-suite/samples/basi3p01.png: Added.
* fast/images/png-suite/samples/basi3p02.png: Added.
* fast/images/png-suite/samples/basi3p04.png: Added.
* fast/images/png-suite/samples/basi3p08.png: Added.
* fast/images/png-suite/samples/basi4a08.png: Added.
* fast/images/png-suite/samples/basi4a16.png: Added.
* fast/images/png-suite/samples/basi6a08.png: Added.
* fast/images/png-suite/samples/basi6a16.png: Added.
* fast/images/png-suite/samples/basn0g01.png: Added.
* fast/images/png-suite/samples/basn0g02.png: Added.
* fast/images/png-suite/samples/basn0g04.png: Added.
* fast/images/png-suite/samples/basn0g08.png: Added.
* fast/images/png-suite/samples/basn0g16.png: Added.
* fast/images/png-suite/samples/basn2c08.png: Added.
* fast/images/png-suite/samples/basn2c16.png: Added.
* fast/images/png-suite/samples/basn3p01.png: Added.
* fast/images/png-suite/samples/basn3p02.png: Added.
* fast/images/png-suite/samples/basn3p04.png: Added.
* fast/images/png-suite/samples/basn3p08.png: Added.
* fast/images/png-suite/samples/basn4a08.png: Added.
* fast/images/png-suite/samples/basn4a16.png: Added.
* fast/images/png-suite/samples/basn6a08.png: Added.
* fast/images/png-suite/samples/basn6a16.png: Added.
* fast/images/png-suite/samples/bgai4a08.png: Added.
* fast/images/png-suite/samples/bgai4a16.png: Added.
* fast/images/png-suite/samples/bgan6a08.png: Added.
* fast/images/png-suite/samples/bgan6a16.png: Added.
* fast/images/png-suite/samples/bgbn4a08.png: Added.
* fast/images/png-suite/samples/bggn4a16.png: Added.
* fast/images/png-suite/samples/bgwn6a08.png: Added.
* fast/images/png-suite/samples/bgyn6a16.png: Added.
* fast/images/png-suite/samples/ccwn2c08.png: Added.
* fast/images/png-suite/samples/ccwn3p08.png: Added.
* fast/images/png-suite/samples/cdfn2c08.png: Added.
* fast/images/png-suite/samples/cdhn2c08.png: Added.
* fast/images/png-suite/samples/cdsn2c08.png: Added.
* fast/images/png-suite/samples/cdun2c08.png: Added.
* fast/images/png-suite/samples/ch1n3p04.png: Added.
* fast/images/png-suite/samples/ch2n3p08.png: Added.
* fast/images/png-suite/samples/cm0n0g04.png: Added.
* fast/images/png-suite/samples/cm7n0g04.png: Added.
* fast/images/png-suite/samples/cm9n0g04.png: Added.
* fast/images/png-suite/samples/cs3n2c16.png: Added.
* fast/images/png-suite/samples/cs3n3p08.png: Added.
* fast/images/png-suite/samples/cs5n2c08.png: Added.
* fast/images/png-suite/samples/cs5n3p08.png: Added.
* fast/images/png-suite/samples/cs8n2c08.png: Added.
* fast/images/png-suite/samples/cs8n3p08.png: Added.
* fast/images/png-suite/samples/ct0n0g04.png: Added.
* fast/images/png-suite/samples/ct1n0g04.png: Added.
* fast/images/png-suite/samples/cten0g04.png: Added.
* fast/images/png-suite/samples/ctfn0g04.png: Added.
* fast/images/png-suite/samples/ctgn0g04.png: Added.
* fast/images/png-suite/samples/cthn0g04.png: Added.
* fast/images/png-suite/samples/ctjn0g04.png: Added.
* fast/images/png-suite/samples/ctzn0g04.png: Added.
* fast/images/png-suite/samples/f00n0g08.png: Added.
* fast/images/png-suite/samples/f00n2c08.png: Added.
* fast/images/png-suite/samples/f01n0g08.png: Added.
* fast/images/png-suite/samples/f01n2c08.png: Added.
* fast/images/png-suite/samples/f02n0g08.png: Added.
* fast/images/png-suite/samples/f02n2c08.png: Added.
* fast/images/png-suite/samples/f03n0g08.png: Added.
* fast/images/png-suite/samples/f03n2c08.png: Added.
* fast/images/png-suite/samples/f04n0g08.png: Added.
* fast/images/png-suite/samples/f04n2c08.png: Added.
* fast/images/png-suite/samples/f99n0g04.png: Added.
* fast/images/png-suite/samples/g03n0g16.png: Added.
* fast/images/png-suite/samples/g03n2c08.png: Added.
* fast/images/png-suite/samples/g03n3p04.png: Added.
* fast/images/png-suite/samples/g04n0g16.png: Added.
* fast/images/png-suite/samples/g04n2c08.png: Added.
* fast/images/png-suite/samples/g04n3p04.png: Added.
* fast/images/png-suite/samples/g05n0g16.png: Added.
* fast/images/png-suite/samples/g05n2c08.png: Added.
* fast/images/png-suite/samples/g05n3p04.png: Added.
* fast/images/png-suite/samples/g07n0g16.png: Added.
* fast/images/png-suite/samples/g07n2c08.png: Added.
* fast/images/png-suite/samples/g07n3p04.png: Added.
* fast/images/png-suite/samples/g10n0g16.png: Added.
* fast/images/png-suite/samples/g10n2c08.png: Added.
* fast/images/png-suite/samples/g10n3p04.png: Added.
* fast/images/png-suite/samples/g25n0g16.png: Added.
* fast/images/png-suite/samples/g25n2c08.png: Added.
* fast/images/png-suite/samples/g25n3p04.png: Added.
* fast/images/png-suite/samples/oi1n0g16.png: Added.
* fast/images/png-suite/samples/oi1n2c16.png: Added.
* fast/images/png-suite/samples/oi2n0g16.png: Added.
* fast/images/png-suite/samples/oi2n2c16.png: Added.
* fast/images/png-suite/samples/oi4n0g16.png: Added.
* fast/images/png-suite/samples/oi4n2c16.png: Added.
* fast/images/png-suite/samples/oi9n0g16.png: Added.
* fast/images/png-suite/samples/oi9n2c16.png: Added.
* fast/images/png-suite/samples/pp0n2c16.png: Added.
* fast/images/png-suite/samples/pp0n6a08.png: Added.
* fast/images/png-suite/samples/ps1n0g08.png: Added.
* fast/images/png-suite/samples/ps1n2c16.png: Added.
* fast/images/png-suite/samples/ps2n0g08.png: Added.
* fast/images/png-suite/samples/ps2n2c16.png: Added.
* fast/images/png-suite/samples/s01i3p01.png: Added.
* fast/images/png-suite/samples/s01n3p01.png: Added.
* fast/images/png-suite/samples/s02i3p01.png: Added.
* fast/images/png-suite/samples/s02n3p01.png: Added.
* fast/images/png-suite/samples/s03i3p01.png: Added.
* fast/images/png-suite/samples/s03n3p01.png: Added.
* fast/images/png-suite/samples/s04i3p01.png: Added.
* fast/images/png-suite/samples/s04n3p01.png: Added.
* fast/images/png-suite/samples/s05i3p02.png: Added.
* fast/images/png-suite/samples/s05n3p02.png: Added.
* fast/images/png-suite/samples/s06i3p02.png: Added.
* fast/images/png-suite/samples/s06n3p02.png: Added.
* fast/images/png-suite/samples/s07i3p02.png: Added.
* fast/images/png-suite/samples/s07n3p02.png: Added.
* fast/images/png-suite/samples/s08i3p02.png: Added.
* fast/images/png-suite/samples/s08n3p02.png: Added.
* fast/images/png-suite/samples/s09i3p02.png: Added.
* fast/images/png-suite/samples/s09n3p02.png: Added.
* fast/images/png-suite/samples/s32i3p04.png: Added.
* fast/images/png-suite/samples/s32n3p04.png: Added.
* fast/images/png-suite/samples/s33i3p04.png: Added.
* fast/images/png-suite/samples/s33n3p04.png: Added.
* fast/images/png-suite/samples/s34i3p04.png: Added.
* fast/images/png-suite/samples/s34n3p04.png: Added.
* fast/images/png-suite/samples/s35i3p04.png: Added.
* fast/images/png-suite/samples/s35n3p04.png: Added.
* fast/images/png-suite/samples/s36i3p04.png: Added.
* fast/images/png-suite/samples/s36n3p04.png: Added.
* fast/images/png-suite/samples/s37i3p04.png: Added.
* fast/images/png-suite/samples/s37n3p04.png: Added.
* fast/images/png-suite/samples/s38i3p04.png: Added.
* fast/images/png-suite/samples/s38n3p04.png: Added.
* fast/images/png-suite/samples/s39i3p04.png: Added.
* fast/images/png-suite/samples/s39n3p04.png: Added.
* fast/images/png-suite/samples/s40i3p04.png: Added.
* fast/images/png-suite/samples/s40n3p04.png: Added.
* fast/images/png-suite/samples/tbbn0g04.png: Added.
* fast/images/png-suite/samples/tbbn2c16.png: Added.
* fast/images/png-suite/samples/tbbn3p08.png: Added.
* fast/images/png-suite/samples/tbgn2c16.png: Added.
* fast/images/png-suite/samples/tbgn3p08.png: Added.
* fast/images/png-suite/samples/tbrn2c08.png: Added.
* fast/images/png-suite/samples/tbwn0g16.png: Added.
* fast/images/png-suite/samples/tbwn3p08.png: Added.
* fast/images/png-suite/samples/tbyn3p08.png: Added.
* fast/images/png-suite/samples/tp0n0g08.png: Added.
* fast/images/png-suite/samples/tp0n2c08.png: Added.
* fast/images/png-suite/samples/tp0n3p08.png: Added.
* fast/images/png-suite/samples/tp1n3p08.png: Added.
* fast/images/png-suite/samples/xc1n0g08.png: Added.
* fast/images/png-suite/samples/xc9n2c08.png: Added.
* fast/images/png-suite/samples/xcrn0g04.png: Added.
* fast/images/png-suite/samples/xcsn0g01.png: Added.
* fast/images/png-suite/samples/xd0n2c08.png: Added.
* fast/images/png-suite/samples/xd3n2c08.png: Added.
* fast/images/png-suite/samples/xd9n2c08.png: Added.
* fast/images/png-suite/samples/xdtn0g01.png: Added.
* fast/images/png-suite/samples/xhdn0g08.png: Added.
* fast/images/png-suite/samples/xlfn0g04.png: Added.
* fast/images/png-suite/samples/xs1n0g01.png: Added.
* fast/images/png-suite/samples/xs2n0g01.png: Added.
* fast/images/png-suite/samples/xs4n0g01.png: Added.
* fast/images/png-suite/samples/xs7n0g01.png: Added.
* fast/images/png-suite/samples/z00n2c08.png: Added.
* fast/images/png-suite/samples/z03n2c08.png: Added.
* fast/images/png-suite/samples/z06n2c08.png: Added.
* fast/images/png-suite/samples/z09n2c08.png: Added.
* fast/images/png-suite/test-expected.png: Added.
* fast/images/png-suite/test.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/fast/images/png-suite/test-expected.png: Added.
* platform/qt/test_expectations.txt:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] DRT should obey layoutTestController's addURLToRedirect()
commit-queue@webkit.org [Fri, 4 May 2012 06:59:45 +0000 (06:59 +0000)]
[EFL] DRT should obey layoutTestController's addURLToRedirect()
https://bugs.webkit.org/show_bug.cgi?id=82722

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-03
Reviewed by Maciej Stachowiak.

Tools:

Implement support for layoutTestController's addURLToRedirect()
in EFL's DRT so that it redirects properly when indicated.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWillSendRequest):

LayoutTests:

Unskip http/tests/loading/cross-origin-XHR-willLoadRequest.html now
that EFL's DRT obeys layoutTestController's addURLToRedirect().

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] REGRESSION(r113511): fast/forms/input-autofilled.html fails
isherman@chromium.org [Fri, 4 May 2012 06:47:30 +0000 (06:47 +0000)]
[Qt] REGRESSION(r113511): fast/forms/input-autofilled.html fails
Unskip the failing test now that r113511 has been reverted.
https://bugs.webkit.org/show_bug.cgi?id=83418

Reviewed by Simon Hausmann.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect()
commit-queue@webkit.org [Fri, 4 May 2012 06:24:45 +0000 (06:24 +0000)]
[EFL] DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect()
https://bugs.webkit.org/show_bug.cgi?id=82704

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-03
Reviewed by Antonio Gomes.

Tools:

EFL's DRT needs to obey LayoutTestController's
willSendRequestReturnsNullOnRedirect().

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onWillSendRequest):

LayoutTests:

Update test_expectations.txt now that EFL's DumpRenderTree supports
LayoutTestController's willSendRequestReturnsNullOnRedirect().

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, gardening after r116009 and r116039.
zandobersek@gmail.com [Fri, 4 May 2012 06:05:14 +0000 (06:05 +0000)]
Unreviewed, gardening after r116009 and r116039.

* fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* http/tests/workers/worker-importScriptsOnError-expected.txt:
* platform/gtk/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:
* platform/gtk/fast/block/float/overhanging-tall-block-expected.txt:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAntialias single-edge solid borders
commit-queue@webkit.org [Fri, 4 May 2012 05:52:37 +0000 (05:52 +0000)]
Antialias single-edge solid borders
https://bugs.webkit.org/show_bug.cgi?id=85031

Patch by David Barr <davidbarr@chromium.org> on 2012-05-03
Reviewed by Simon Fraser.

Source/WebCore:

Antialiasing is avoided for adjacent edges due to artifacts at the seam.
There are no such artifacts for single-edge borders so enable antialiasing.

Test: fast/css/border-solid-single-edge-antialias.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):

LayoutTests:

* fast/css/border-solid-single-edge-antialias-expected.png: Added.
* fast/css/border-solid-single-edge-antialias-expected.txt: Added.
* fast/css/border-solid-single-edge-antialias.html: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed, add some other missing baselines.
rakuco@webkit.org [Fri, 4 May 2012 03:55:52 +0000 (03:55 +0000)]
[EFL] Unreviewed, add some other missing baselines.

* platform/efl/fast/html/details-marker-style-actual.txt: Added.
* platform/efl/media/media-can-play-webm-actual.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed, add baseline for r116001.
rakuco@webkit.org [Fri, 4 May 2012 03:52:40 +0000 (03:52 +0000)]
[EFL] Unreviewed, add baseline for r116001.

* platform/efl/svg/as-image/image-respects-pageScaleFactor-actual.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSP: Eval isn't blocked in about:blank subframes
abarth@webkit.org [Fri, 4 May 2012 03:45:06 +0000 (03:45 +0000)]
CSP: Eval isn't blocked in about:blank subframes
https://bugs.webkit.org/show_bug.cgi?id=85553

Reviewed by Eric Seidel.

Source/WebCore:

ContentSecurityPolicy has a back pointer to ScriptExecutionContext.
That means we shouldn't share a single ContentSecurityPolicy object
between multiple ScriptExecutionContexts.  This patch copies the state
from one ScriptExecutionContext to another rather than sharing the
ContentSecurityPolicy object itself.

This resulted in a subtle but w.r.t. blocking eval.  Because we block
eval by setting a bit in the JavaScript engine when enforcing the
policy, that bit wasn't copied along with the rest of the state when we
were sharing the ContentSecurityPolicy object.  Now that we use the
more robust ContentSecurityPolicy::copyStateFrom function, we don't
have that bug.

Test: http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html

* dom/Document.cpp:
(WebCore::Document::initSecurityContext):
(WebCore):
(WebCore::Document::initContentSecurityPolicy):
* dom/Document.h:
(Document):
* dom/SecurityContext.cpp:
(WebCore::SecurityContext::setContentSecurityPolicy):
* dom/SecurityContext.h:
(SecurityContext):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument):
* page/ContentSecurityPolicy.h:
(WebCore::ContentSecurityPolicy::create):

LayoutTests:

* http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html: Added.
    - New test for the eval issue.
* http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
* http/tests/security/contentSecurityPolicy/javascript-url-allowed-expected.txt:
* http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt:
    - Now that we re-parse the CSP policy, we log parse errors to the
      console more times. This isn't ideal and is something we might
      change in the future.
* platform/chromium/http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe-expected.txt: Added.
    - Add a Chromium-specific baseline for this test because the eval
      error is slightly different between V8 and JSC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression(r113769): Crash in AudioNodeOutput::disconnectAllParams.
inferno@chromium.org [Fri, 4 May 2012 03:42:29 +0000 (03:42 +0000)]
Regression(r113769): Crash in AudioNodeOutput::disconnectAllParams.
https://bugs.webkit.org/show_bug.cgi?id=85196

Reviewed by Chris Rogers.

RefPtr the AudioParam hashset in AudioNodeOutput to prevent accessing
destroyed entries.

No new tests. Unable to reproduce it in DRT.

* Modules/webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::disconnectAllParams):
* Modules/webaudio/AudioNodeOutput.h:
(AudioNodeOutput):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogit-add-reviewer: Do not put the bug title and its URL in the same line in the commit...
rakuco@webkit.org [Fri, 4 May 2012 03:25:07 +0000 (03:25 +0000)]
git-add-reviewer: Do not put the bug title and its URL in the same line in the commit message.
https://bugs.webkit.org/show_bug.cgi?id=85570

Reviewed by Adam Roben.

The standard format of commit messages and ChangeLog entries has a
short summary in the first line, followed by the bug URL in
Bugzilla. Passing "%s" in the pretty format line to git-rev-list
merges these two lines into a single one separated by a space
character, which is not what we want.

Since "%s%n%n%b" is in practice "%B" (raw message), use it
instead, as the first two lines do not end up being merged
together.

* Scripts/git-add-reviewer:
(writeCommitMessageToFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate mac test expectations after r115927
commit-queue@webkit.org [Fri, 4 May 2012 02:41:27 +0000 (02:41 +0000)]
Update mac test expectations after r115927
https://bugs.webkit.org/show_bug.cgi?id=85569

Patch by David Barr <davidbarr@chromium.org> on 2012-05-03
Reviewed by Dirk Pranke.

The tests were removed on r115927. Remove them from the mac test expectations.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImprove UI for garden-o-matic examine view when there are fewer than 5 tests.
ojan@chromium.org [Fri, 4 May 2012 01:57:18 +0000 (01:57 +0000)]
Improve UI for garden-o-matic examine view when there are fewer than 5 tests.
https://bugs.webkit.org/show_bug.cgi?id=85566

Reviewed by Adam Barth.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: Recognize FreeBSD as a valid platform.
rakuco@webkit.org [Fri, 4 May 2012 01:53:05 +0000 (01:53 +0000)]
webkitpy: Recognize FreeBSD as a valid platform.
https://bugs.webkit.org/show_bug.cgi?id=81467

Reviewed by Adam Barth.

Add PlatformInfo.is_freebsd() so that trying to use webkit-patch
on FreeBSD does not raise an "unrecognized platform" exception.

Most of this patch contains some unit tests for the mentioned
method, as currently platform-specific code is needed only on
Windows.

* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.__init__):
(PlatformInfo.is_freebsd):
(PlatformInfo._determine_os_name):
* Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.is_freebsd):
* Scripts/webkitpy/common/system/platforminfo_unittest.py:
(fake_platform):
(fake_platform.FakePlatformModule.release):
(TestPlatformInfo.test_real_code):
(TestPlatformInfo.test_os_name_and_wrappers):
(TestPlatformInfo.test_os_version):
(TestPlatformInfo.test_display_name):
(TestPlatformInfo.test_total_bytes_memory):
(TestPlatformInfo.test_free_bytes_memory):
* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory._default_port):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake the table headers white-space:nowrap. This decreases the vertical size,
ojan@chromium.org [Fri, 4 May 2012 01:51:22 +0000 (01:51 +0000)]
Make the table headers white-space:nowrap. This decreases the vertical size,
which makes for more minimal embedding in garden-o-matic.

* TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
(.table-header-content *):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPNGImageDecoder: Clean up rowAvailable() some more
noel.gordon@gmail.com [Fri, 4 May 2012 01:45:21 +0000 (01:45 +0000)]
PNGImageDecoder: Clean up rowAvailable() some more
https://bugs.webkit.org/show_bug.cgi?id=85464

Reviewed by Eric Seidel.

No new tests. Covered by existing tests: fast/images/png-extra-row-crash.html in
particular.

* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::rowAvailable): Use colorChannels consistently. Split
the useful libpng comments in two, then place the early-out code and conditions
inbetween. The png variable is only used in one place so move it there.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHistogram total allocated bytes in the arena in addition to the render tree size
ojan@chromium.org [Fri, 4 May 2012 01:35:36 +0000 (01:35 +0000)]
Histogram total allocated bytes in the arena in addition to the render tree size
https://bugs.webkit.org/show_bug.cgi?id=85537

Reviewed by Eric Seidel.

Source/WebCore:

We only free bytes allocated to a RenderArena when destroying the Document.
Histogram both the render tree size and the total bytes allocated. This
gives a better sense of the overhead of RenderArena as well as giving a more
accurate number for the amount of actual memory used by the render tree.

No new tests. This is not webfacing, so this can't be tested without adding
API to layout test controller, which doesn't seem worth it for this code.

* page/Page.cpp:
(WebCore::Page::renderTreeSize):
(WebCore::Page::setVisibilityState):
* page/Page.h:
(Page):
* platform/Arena.cpp:
(WebCore::ArenaAllocate):
* platform/Arena.h:
(WebCore):
* rendering/RenderArena.cpp:
(WebCore::RenderArena::allocate):
* rendering/RenderArena.h:
(WebCore::RenderArena::totalRenderArenaAllocatedBytes):
(RenderArena):

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::renderTreeSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Add missed member in CrossThreadResourceRequestData
mary.wu@torchmobile.com.cn [Fri, 4 May 2012 01:28:11 +0000 (01:28 +0000)]
[BlackBerry] Add missed member in CrossThreadResourceRequestData
https://bugs.webkit.org/show_bug.cgi?id=85448

Reviewed by Antonio Gomes.

* platform/network/blackberry/ResourceRequest.h:
(CrossThreadResourceRequestData):
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline.
zmo@google.com [Fri, 4 May 2012 01:21:50 +0000 (01:21 +0000)]
Unreviewed, rebaseline.

* platform/chromium-linux/fast/xmlhttprequest: Added.
* platform/chromium-linux/fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Added.
* platform/chromium-mac/fast/xmlhttprequest: Removed.
* platform/chromium-mac/fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Removed.
* platform/chromium-mac/http/tests/workers: Removed.
* platform/chromium-win/fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
* platform/chromium/fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Added.
* platform/chromium/http/tests/workers/worker-importScriptsOnError-expected.txt: Replaced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSplit build-webkit's feature option list off into its own module in preparation for...
eric@webkit.org [Fri, 4 May 2012 01:06:47 +0000 (01:06 +0000)]
Split build-webkit's feature option list off into its own module in preparation for autogeneration
https://bugs.webkit.org/show_bug.cgi?id=85548

Reviewed by Daniel Bates.

My Perl-fu is very weak.  This moves the feature option list off into a separate module
file so that I can easily autogenerate just that file with the fancy new generate-feature-files command.
It's a bit odd to have an array which we return out to build-webkit to modify, but it turns out
not to matter.  Also, build-webkit doesn't actually use any of the variables we're using to
store the results from the option parse, so those end up inaccessible from build-webkit (except by reference)
which is actually cleaner.  Callers can't assume that they would get a new array every time, but someone
with more Perl-fu than I could create something fancier than this if we need in the future.

* Scripts/build-webkit:
* Scripts/webkitperl/FeatureList.pm: Added.
(getFeatureOptionList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression(r114702): Clobbering the caller frame register before we've stored it.
oliver@apple.com [Fri, 4 May 2012 01:05:50 +0000 (01:05 +0000)]
Regression(r114702): Clobbering the caller frame register before we've stored it.
https://bugs.webkit.org/show_bug.cgi?id=85564

Reviewed by Filip Pizlo.

Don't use t0 as a temporary, when we're about to use the value in t0.

* llint/LowLevelInterpreter32_64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agouseWebKitWebInspector should be more robust against missing files
andersca@apple.com [Fri, 4 May 2012 01:00:02 +0000 (01:00 +0000)]
useWebKitWebInspector should be more robust against missing files
https://bugs.webkit.org/show_bug.cgi?id=85563
<rdar://problem/11373948>

Reviewed by Dan Bernstein.

* WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSP shouldn't block about:blank for iframes
abarth@webkit.org [Fri, 4 May 2012 00:53:16 +0000 (00:53 +0000)]
CSP shouldn't block about:blank for iframes
https://bugs.webkit.org/show_bug.cgi?id=85233

Reviewed by Eric Seidel.

Source/WebCore:

As discussed at the W3C WebAppSec face-to-face meeting, there's no
point in blocking about:blank iframes or objects because blocking a
frame or object just results in displaying about:blank anyway.  This
patch just removes the spurious console message and violation report.

Test: http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-default.html

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):

LayoutTests:

Test that about:blank iframes and objects don't generate debug log
messages.

* http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-default-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/frame-src-about-blank-allowed-by-default.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r116040.
zmo@google.com [Fri, 4 May 2012 00:49:35 +0000 (00:49 +0000)]
Unreviewed, rolling out r116040.
http://trac.webkit.org/changeset/116040
https://bugs.webkit.org/show_bug.cgi?id=85559

Broke a few IndexedDB browsertests (Requested by zhenyao on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-03

Source/WebCore:

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::direction):
* Modules/indexeddb/IDBCursor.h:
(IDBCursor):
* Modules/indexeddb/IDBCursor.idl:
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
(WebCore):
* Modules/indexeddb/IDBDatabase.h:
* Modules/indexeddb/IDBDatabase.idl:
* Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
* Modules/indexeddb/IDBIndex.h:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
* Modules/indexeddb/IDBIndex.idl:
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::openCursor):
* Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStore.idl:
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::readyState):
(WebCore::IDBRequest::markEarlyDeath):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::finishCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::stop):
* Modules/indexeddb/IDBRequest.h:
* Modules/indexeddb/IDBRequest.idl:
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::mode):
* Modules/indexeddb/IDBTransaction.h:
(IDBTransaction):
* Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

* http/tests/inspector/indexeddb/indexeddb-test.js:
* storage/indexeddb/basics-expected.txt:
* storage/indexeddb/basics-workers-expected.txt:
* storage/indexeddb/constants-expected.txt:
* storage/indexeddb/create-object-store-options-expected.txt:
* storage/indexeddb/cursor-added-bug-expected.txt:
* storage/indexeddb/cursor-advance-expected.txt:
* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-continue-validity-expected.txt:
* storage/indexeddb/cursor-delete-expected.txt:
* storage/indexeddb/cursor-inconsistency-expected.txt:
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-key-order-expected.txt:
* storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
* storage/indexeddb/cursor-primary-key-order-expected.txt:
* storage/indexeddb/cursor-reverse-bug-expected.txt:
* storage/indexeddb/cursor-skip-deleted-expected.txt:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/data-corruption-expected.txt:
* storage/indexeddb/database-quota-expected.txt:
* storage/indexeddb/delete-range-expected.txt:
* storage/indexeddb/error-causes-abort-by-default-expected.txt:
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/factory-deletedatabase-expected.txt:
* storage/indexeddb/index-count-expected.txt:
* storage/indexeddb/index-multientry-expected.txt:
* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/keypath-edges-expected.txt:
* storage/indexeddb/keypath-intrinsic-properties-expected.txt:
* storage/indexeddb/legacy-constants-expected.txt: Removed.
* storage/indexeddb/legacy-constants.html: Removed.
* storage/indexeddb/mozilla/clear-expected.txt:
* storage/indexeddb/mozilla/create-index-unique-expected.txt:
* storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
* storage/indexeddb/mozilla/cursor-mutation-expected.txt:
* storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
* storage/indexeddb/mozilla/cursors-expected.txt:
* storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
* storage/indexeddb/mozilla/index-prev-no-duplicate.html:
* storage/indexeddb/mozilla/indexes-expected.txt:
* storage/indexeddb/mozilla/odd-result-order-expected.txt:
* storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
* storage/indexeddb/mozilla/readyState-expected.txt:
* storage/indexeddb/mozilla/resources/clear.js:
(clear):
* storage/indexeddb/mozilla/resources/create-index-unique.js:
(createAndVerifyIndex):
* storage/indexeddb/mozilla/resources/create-objectstore-basics.js:
(cleanDatabase):
* storage/indexeddb/mozilla/resources/cursor-mutation-objectstore-only.js:
(checkCursorResultsAndSetupMutatingCursor):
* storage/indexeddb/mozilla/resources/cursor-mutation.js:
(setupMutatingCursor):
* storage/indexeddb/mozilla/resources/cursors.js:
* storage/indexeddb/mozilla/resources/indexes.js:
* storage/indexeddb/mozilla/resources/odd-result-order.js:
(addRecord):
(deleteRecord):
* storage/indexeddb/mozilla/resources/readwrite-transactions.js:
(setVersionComplete):
(postAdd):
(postAdd2):
(postPut):
(postPut2):
(postPut3):
(postPut4):
(postDelete):
(postDelete2):
* storage/indexeddb/mozilla/resources/readyState.js:
(test):
(openSuccess):
(setupObjectStore):
(getRecord):
(finalCheck):
* storage/indexeddb/mozilla/resources/versionchange.js:
(postSetVersion):
(postSetVersion2):
* storage/indexeddb/mozilla/versionchange-expected.txt:
* storage/indexeddb/mutating-cursor-expected.txt:
* storage/indexeddb/noblobs-expected.txt:
* storage/indexeddb/noblobs.html:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/objectstore-count-expected.txt:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/open-during-transaction-expected.txt:
* storage/indexeddb/opencursor-key-expected.txt:
* storage/indexeddb/prefetch-bugfix-108071-expected.txt:
* storage/indexeddb/readonly-expected.txt:
* storage/indexeddb/request-event-propagation-expected.txt:
* storage/indexeddb/resources/basics.js:
(test):
(openCallback):
* storage/indexeddb/resources/constants.js:
(test):
* storage/indexeddb/resources/create-object-store-options.js:
(setVersionComplete):
* storage/indexeddb/resources/cursor-added-bug.js:
(openCursor):
* storage/indexeddb/resources/cursor-advance.js:
(runTest):
(testAdvanceIndexNoDupe):
(testAdvanceIndexPrev):
(testAdvanceIndexPrevNoDupe):
* storage/indexeddb/resources/cursor-continue-validity.js:
(continueTest):
(continueIndexTest):
(testModifyContinueOrder):
* storage/indexeddb/resources/cursor-continue.js:
(ascendingTest):
(descendingTest):
* storage/indexeddb/resources/cursor-delete.js:
(openCursor):
(addObject):
* storage/indexeddb/resources/cursor-inconsistency.js:
(openBasicCursor):
* storage/indexeddb/resources/cursor-index-delete.js:
(openCursor):
(addObject):
* storage/indexeddb/resources/cursor-key-order.js:
* storage/indexeddb/resources/cursor-prev-no-duplicate.js:
(populateStore):
(testFarRangeCursor_closed):
(testFarRangeCursor_open):
(testFarRangeCursor_indexClosed):
(testFarRangeCursor_indexOpen):
(testFarRangeCursor_indexKeyOpen):
(testFarRangeCursor_indexKeyClosed):
(testBoundaryCursor_closed):
(testBoundaryCursor_open):
(testBoundaryCursor_indexClosed):
(testBoundaryCursor_indexOpen):
(testBoundaryCursor_indexKeyClosed):
(testBoundaryCursor_indexKeyOpen):
(testNoDuplicate_closed):
(testNoDuplicate_open):
(testNoDuplicate_indexKeyClosed):
* storage/indexeddb/resources/cursor-primary-key-order.js:
(populateStore):
* storage/indexeddb/resources/cursor-reverse-bug.js:
(populateStore):
(testCursor):
* storage/indexeddb/resources/cursor-skip-deleted.js:
(basicCursorTest):
(reverseCursorTest):
* storage/indexeddb/resources/cursor-update.js:
(openBasicCursor):
* storage/indexeddb/resources/data-corruption.js:
(addData):
(getData):
* storage/indexeddb/resources/database-quota.js:
(checkQuotaEnforcing):
* storage/indexeddb/resources/delete-range.js:
(runTests.nextTest):
(runTests):
* storage/indexeddb/resources/error-causes-abort-by-default.js:
(addData):
(transactionCompleted):
(transactionAborted1):
* storage/indexeddb/resources/exception-in-event-aborts.js:
(startTest):
(transactionAborted1):
(transactionAborted2):
* storage/indexeddb/resources/factory-deletedatabase.js:
(getValue):
* storage/indexeddb/resources/index-count.js:
* storage/indexeddb/resources/index-cursor.js:
(runNextTest):
(testNullKeyRange):
* storage/indexeddb/resources/index-multientry.js:
* storage/indexeddb/resources/index-unique.js:
(setVersionCompleted):
* storage/indexeddb/resources/key-generator.js:
(.):
* storage/indexeddb/resources/key-type-array.js:
* storage/indexeddb/resources/keypath-edges.js:
* storage/indexeddb/resources/keypath-intrinsic-properties.js:
* storage/indexeddb/resources/legacy-constants.js: Removed.
* storage/indexeddb/resources/mutating-cursor.js:
(openForwardCursor):
(openReverseCursor):
* storage/indexeddb/resources/objectstore-autoincrement.js:
(setVersionCompleted):
* storage/indexeddb/resources/objectstore-basics.js:
(addData):
(addAgainFailure):
* storage/indexeddb/resources/objectstore-count.js:
* storage/indexeddb/resources/objectstore-cursor.js:
(runNextTest):
(testNullKeyRange):
* storage/indexeddb/resources/open-cursor.js:
(cursorWithKeySuccess):
(cursorSuccess):
* storage/indexeddb/resources/open-during-transaction.js:
* storage/indexeddb/resources/opencursor-key.js:
* storage/indexeddb/resources/prefetch-bugfix-108071.js:
* storage/indexeddb/resources/request-event-propagation.js:
(startTest):
(transactionAborted):
(transactionAborted2):
* storage/indexeddb/resources/set_version_blocked.js:
(blocked):
* storage/indexeddb/resources/transaction-abort.js:
(startTest):
* storage/indexeddb/resources/transaction-after-close.js:
(runFirstRegularTransaction):
(firstTransactionComplete):
(onSecondOpen):
* storage/indexeddb/resources/transaction-basics.js:
(testInvalidMode):
* storage/indexeddb/resources/transaction-event-propagation.js:
(startTest):
(dbAbortBubbleCallback):
* storage/indexeddb/resources/transaction-rollback.js:
(setVersionComplete):
(abortCallback):
* storage/indexeddb/set_version_blocked-expected.txt:
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/structured-clone.html:
* storage/indexeddb/transaction-abort-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
* storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion.html:
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-event-propagation-expected.txt:
* storage/indexeddb/transaction-rollback-expected.txt:
* storage/indexeddb/tutorial.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: run-webkit-tests failing on Chromium Mac
dpranke@chromium.org [Fri, 4 May 2012 00:42:16 +0000 (00:42 +0000)]
REGRESSION: run-webkit-tests failing on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=85459

Unreviewed, build fix.

Turns out select doesn't throw IOErrors, it has it's own kind of
error :(. Trap that instead.

* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._wait_for_data_and_update_buffers_using_select):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Rewrite FindCairo.cmake.
rakuco@webkit.org [Fri, 4 May 2012 00:39:57 +0000 (00:39 +0000)]
[CMake] Rewrite FindCairo.cmake.
https://bugs.webkit.org/show_bug.cgi?id=84895

Reviewed by Daniel Bates.

The old approach relied on pkg-config for finding Cairo (which
introduced a dependency on pkg-config that could be avoided), used
the LibFindMacros code that we should probably remove in the
future and did not use the FindPackageHandleStandardArguments
module.

Change all that by rewriting the module.
- Use the pkg-config output optionally instead of requiring it
like LibFindMacros did.
- Remove the implicit dependency on FreeType which often found it
the wrong way via pkg-config and without considering
CMAKE_PREFIX_PATH.
- Retrieve the Cairo version by looking at cairo-version.h instead
of relying on pkg-config. It requires some additional code for
checking if the desired version has been found, but that will not
be needed once we start depending on CMake 2.8.3 or later.

The only downside is that FPHSA sets <UPPERCASED_NAME>_FOUND
instead of <Name>_FOUND, and to keep things consistent
Cairo_LIBRARIES and Cairo_INCLUDE_DIRS have become CAIRO_LIBRARIES
and CAIRO_INCLUDE_DIRS.

.:

* Source/cmake/FindCairo.cmake:

Source/WebCore:

No new tests, build system change.

* PlatformEfl.cmake: Use CAIRO_FOO instead of Cairo_FOO.

Source/WebKit:

* PlatformEfl.cmake: Use CAIRO_FOO instead of Cairo_FOO.

Source/WebKit2:

* PlatformEfl.cmake: Use CAIRO_FOO instead of Cairo_FOO.

Tools:

* DumpRenderTree/efl/CMakeLists.txt: Use CAIRO_FOO instead of
Cairo_FOO.
* EWebLauncher/CMakeLists.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFocus ring only appears in top-left tile
andersca@apple.com [Fri, 4 May 2012 00:36:52 +0000 (00:36 +0000)]
Focus ring only appears in top-left tile
https://bugs.webkit.org/show_bug.cgi?id=85556
<rdar://problem/11359656>

Reviewed by Simon Fraser.

It is sufficient to just apply the current CTM to the clip rect and set that as the focus ring clip rect.

* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, test expectations update.
zmo@google.com [Fri, 4 May 2012 00:16:15 +0000 (00:16 +0000)]
Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix modifier and bug sorting on the flakiness dashboard
ojan@chromium.org [Fri, 4 May 2012 00:04:06 +0000 (00:04 +0000)]
Fix modifier and bug sorting on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85554

Reviewed by Dirk Pranke.

The sorting assumes that the column header name matches a field
in the testResults object and uses that field for sorting.
Filter the bugs out of the modifiers list and put them in a bugs field
and only put the non-bug modifiers in the modifiers list.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(populateExpectationsData):
(htmlForSingleTestRow):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix some state resetting when running unittests. HtmlForSingleTestRow
ojan@chromium.org [Thu, 3 May 2012 23:57:48 +0000 (23:57 +0000)]
Fix some state resetting when running unittests. HtmlForSingleTestRow
was flaky.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(htmlForSingleTestRow):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(resetGlobals):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoving remainder of accidental printfs.
mhahnenberg@apple.com [Thu, 3 May 2012 23:55:59 +0000 (23:55 +0000)]
Removing remainder of accidental printfs.

* heap/Heap.cpp:
(JSC::Heap::collect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIf you add printf()s to your garbage collector, the layout tests are gonna have a...
aestes@apple.com [Thu, 3 May 2012 23:51:29 +0000 (23:51 +0000)]
If you add printf()s to your garbage collector, the layout tests are gonna have a bad time.

* runtime/GCActivityCallbackCF.cpp:
(JSC::DefaultGCActivityCallbackPlatformData::timerDidFire):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: Use PlatformInfo wherever possible in the User class.
rakuco@webkit.org [Thu, 3 May 2012 23:45:25 +0000 (23:45 +0000)]
webkitpy: Use PlatformInfo wherever possible in the User class.
https://bugs.webkit.org/show_bug.cgi?id=85549

Reviewed by Dirk Pranke.

Instead of relying on sys.platform to detect whether the current
platform is a Mac, use the PlatformInfo class instead.

* Scripts/webkitpy/common/system/user.py:
(User.__init__):
(User.edit_changelog):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the percent failed column from the flakiness dashboard
ojan@chromium.org [Thu, 3 May 2012 23:41:21 +0000 (23:41 +0000)]
Remove the percent failed column from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85552

Reviewed by Dirk Pranke.

This column isn't useful enough to justify the visual noise.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(processMissingAndExtraExpectations):
(tableHeaders):
(htmlForSingleTestRow):
(sortTests):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Replace numeric constants with strings
commit-queue@webkit.org [Thu, 3 May 2012 23:39:23 +0000 (23:39 +0000)]
IndexedDB: Replace numeric constants with strings
https://bugs.webkit.org/show_bug.cgi?id=84894

Patch by Alec Flett <alecflett@chromium.org> on 2012-05-03
Reviewed by Tony Chang.

Source/WebCore:

Test: storage/indexeddb/legacy-constants.html

Update IDBObjectStore.openCursor, IDBIndex.openCursor,
IDBIndex.openKeyCursor, IDBDatabase.transaction,
IDBCursor.direction, IDBTransaction.mode, and
IDBRequest.readyState to meet the latest spec. All of these APIs
now support string-based values in addition to the
legacy/deprecated enum-based values.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore):
(WebCore::IDBCursor::direction):
(WebCore::IDBCursor::stringToDirection):
(WebCore::IDBCursor::directionToString):
* Modules/indexeddb/IDBCursor.h:
(IDBCursor):
* Modules/indexeddb/IDBCursor.idl:
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
(WebCore):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabase.idl:
* Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore):
(WebCore::IDBIndex::openKeyCursor):
* Modules/indexeddb/IDBIndex.h:
(WebCore::IDBIndex::openCursor):
(IDBIndex):
(WebCore::IDBIndex::openKeyCursor):
* Modules/indexeddb/IDBIndex.idl:
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::openCursor):
(WebCore):
* Modules/indexeddb/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStore.idl:
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::readyState):
(WebCore::IDBRequest::markEarlyDeath):
(WebCore::IDBRequest::resetReadyState):
(WebCore::IDBRequest::abort):
(WebCore::IDBRequest::finishCursor):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::stop):
* Modules/indexeddb/IDBRequest.h:
* Modules/indexeddb/IDBRequest.idl:
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore):
(WebCore::IDBTransaction::mode):
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):
* Modules/indexeddb/IDBTransaction.h:
(IDBTransaction):
* Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

New test for legacy constants (legacy-constants) and update all
other tests to use the new string-based constants.

* storage/indexeddb/basics-expected.txt:
* storage/indexeddb/basics-workers-expected.txt:
* storage/indexeddb/constants-expected.txt:
* storage/indexeddb/create-object-store-options-expected.txt:
* storage/indexeddb/cursor-added-bug-expected.txt:
* storage/indexeddb/cursor-advance-expected.txt:
* storage/indexeddb/cursor-continue-expected.txt:
* storage/indexeddb/cursor-continue-validity-expected.txt:
* storage/indexeddb/cursor-delete-expected.txt:
* storage/indexeddb/cursor-inconsistency-expected.txt:
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-key-order-expected.txt:
* storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
* storage/indexeddb/cursor-primary-key-order-expected.txt:
* storage/indexeddb/cursor-reverse-bug-expected.txt:
* storage/indexeddb/cursor-skip-deleted-expected.txt:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/data-corruption-expected.txt:
* storage/indexeddb/database-quota-expected.txt:
* storage/indexeddb/delete-range-expected.txt:
* storage/indexeddb/error-causes-abort-by-default-expected.txt:
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/factory-deletedatabase-expected.txt:
* storage/indexeddb/index-count-expected.txt:
* storage/indexeddb/index-multientry-expected.txt:
* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/keypath-edges-expected.txt:
* storage/indexeddb/keypath-intrinsic-properties-expected.txt:
* storage/indexeddb/legacy-constants-expected.txt: Added.
* storage/indexeddb/legacy-constants.html: Added.
* storage/indexeddb/mozilla/clear-expected.txt:
* storage/indexeddb/mozilla/create-index-unique-expected.txt:
* storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
* storage/indexeddb/mozilla/cursor-mutation-expected.txt:
* storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
* storage/indexeddb/mozilla/cursors-expected.txt:
* storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
* storage/indexeddb/mozilla/index-prev-no-duplicate.html:
* storage/indexeddb/mozilla/indexes-expected.txt:
* storage/indexeddb/mozilla/odd-result-order-expected.txt:
* storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
* storage/indexeddb/mozilla/readyState-expected.txt:
* storage/indexeddb/mozilla/resources/clear.js:
(clear):
* storage/indexeddb/mozilla/resources/create-index-unique.js:
(createAndVerifyIndex):
* storage/indexeddb/mozilla/resources/create-objectstore-basics.js:
(cleanDatabase):
* storage/indexeddb/mozilla/resources/cursor-mutation-objectstore-only.js:
(checkCursorResultsAndSetupMutatingCursor):
* storage/indexeddb/mozilla/resources/cursor-mutation.js:
(setupMutatingCursor):
* storage/indexeddb/mozilla/resources/cursors.js:
* storage/indexeddb/mozilla/resources/indexes.js:
* storage/indexeddb/mozilla/resources/odd-result-order.js:
(addRecord):
(deleteRecord):
* storage/indexeddb/mozilla/resources/readwrite-transactions.js:
(setVersionComplete):
(postAdd):
(postAdd2):
(postPut):
(postPut2):
(postPut3):
(postPut4):
(postDelete):
(postDelete2):
* storage/indexeddb/mozilla/resources/readyState.js:
(test):
(openSuccess):
(setupObjectStore):
(getRecord):
(finalCheck):
* storage/indexeddb/mozilla/resources/versionchange.js:
(postSetVersion):
(postSetVersion2):
* storage/indexeddb/mozilla/versionchange-expected.txt:
* storage/indexeddb/mutating-cursor-expected.txt:
* storage/indexeddb/noblobs-expected.txt:
* storage/indexeddb/noblobs.html:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/objectstore-count-expected.txt:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/open-during-transaction-expected.txt:
* storage/indexeddb/opencursor-key-expected.txt:
* storage/indexeddb/prefetch-bugfix-108071-expected.txt:
* storage/indexeddb/readonly-expected.txt:
* storage/indexeddb/request-event-propagation-expected.txt:
* storage/indexeddb/resources/basics.js:
(test):
(openCallback):
* storage/indexeddb/resources/constants.js:
(test):
* storage/indexeddb/resources/create-object-store-options.js:
(setVersionComplete):
* storage/indexeddb/resources/cursor-added-bug.js:
(openCursor):
* storage/indexeddb/resources/cursor-advance.js:
(runTest):
(testAdvanceIndexNoDupe):
(testAdvanceIndexPrev):
(testAdvanceIndexPrevNoDupe):
* storage/indexeddb/resources/cursor-continue-validity.js:
(continueTest):
(continueIndexTest):
(testModifyContinueOrder):
* storage/indexeddb/resources/cursor-continue.js:
(ascendingTest):
(descendingTest):
* storage/indexeddb/resources/cursor-delete.js:
(openCursor):
(addObject):
* storage/indexeddb/resources/cursor-inconsistency.js:
(openBasicCursor):
* storage/indexeddb/resources/cursor-index-delete.js:
(openCursor):
(addObject):
* storage/indexeddb/resources/cursor-key-order.js:
* storage/indexeddb/resources/cursor-prev-no-duplicate.js:
(populateStore):
(testFarRangeCursor_closed):
(testFarRangeCursor_open):
(testFarRangeCursor_indexClosed):
(testFarRangeCursor_indexOpen):
(testFarRangeCursor_indexKeyOpen):
(testFarRangeCursor_indexKeyClosed):
(testBoundaryCursor_closed):
(testBoundaryCursor_open):
(testBoundaryCursor_indexClosed):
(testBoundaryCursor_indexOpen):
(testBoundaryCursor_indexKeyClosed):
(testBoundaryCursor_indexKeyOpen):
(testNoDuplicate_closed):
(testNoDuplicate_open):
(testNoDuplicate_indexKeyClosed):
* storage/indexeddb/resources/cursor-primary-key-order.js:
(populateStore):
* storage/indexeddb/resources/cursor-reverse-bug.js:
(populateStore):
(testCursor):
* storage/indexeddb/resources/cursor-skip-deleted.js:
(basicCursorTest):
(reverseCursorTest):
* storage/indexeddb/resources/cursor-update.js:
(openBasicCursor):
* storage/indexeddb/resources/data-corruption.js:
(addData):
(getData):
* storage/indexeddb/resources/database-quota.js:
(checkQuotaEnforcing):
* storage/indexeddb/resources/delete-range.js:
(runTests.nextTest):
(runTests):
* storage/indexeddb/resources/error-causes-abort-by-default.js:
(addData):
(transactionCompleted):
(transactionAborted1):
* storage/indexeddb/resources/exception-in-event-aborts.js:
(startTest):
(transactionAborted1):
(transactionAborted2):
* storage/indexeddb/resources/factory-deletedatabase.js:
(getValue):
* storage/indexeddb/resources/index-count.js:
* storage/indexeddb/resources/index-cursor.js:
(runNextTest):
(testNullKeyRange):
* storage/indexeddb/resources/index-multientry.js:
* storage/indexeddb/resources/index-unique.js:
(setVersionCompleted):
* storage/indexeddb/resources/key-generator.js:
(.):
* storage/indexeddb/resources/key-type-array.js:
* storage/indexeddb/resources/keypath-edges.js:
* storage/indexeddb/resources/keypath-intrinsic-properties.js:
* storage/indexeddb/resources/legacy-constants.js: Added.
(test):
(prepareDatabase.openreq.onsuccess.verreq.onsuccess):
(prepareDatabase.openreq.onsuccess):
(prepareDatabase):
(populateStore):
(checkNext.request.onsuccess):
(checkNext):
(checkNextNoDuplicate.request.onsuccess):
(checkNextNoDuplicate):
(checkPrev.request.onsuccess):
(checkPrev):
(checkPrevNoDuplicate.request.onsuccess):
(checkPrevNoDuplicate):
* storage/indexeddb/resources/mutating-cursor.js:
(openForwardCursor):
(openReverseCursor):
* storage/indexeddb/resources/objectstore-autoincrement.js:
(setVersionCompleted):
* storage/indexeddb/resources/objectstore-basics.js:
(addData):
(addAgainFailure):
* storage/indexeddb/resources/objectstore-count.js:
* storage/indexeddb/resources/objectstore-cursor.js:
(runNextTest):
(testNullKeyRange):
* storage/indexeddb/resources/open-cursor.js:
(cursorWithKeySuccess):
(cursorSuccess):
* storage/indexeddb/resources/open-during-transaction.js:
* storage/indexeddb/resources/opencursor-key.js:
* storage/indexeddb/resources/prefetch-bugfix-108071.js:
* storage/indexeddb/resources/request-event-propagation.js:
(startTest):
(transactionAborted):
(transactionAborted2):
* storage/indexeddb/resources/set_version_blocked.js:
(blocked):
* storage/indexeddb/resources/transaction-abort.js:
(startTest):
* storage/indexeddb/resources/transaction-after-close.js:
(runFirstRegularTransaction):
(firstTransactionComplete):
(onSecondOpen):
* storage/indexeddb/resources/transaction-basics.js:
(testInvalidMode):
* storage/indexeddb/resources/transaction-event-propagation.js:
(startTest):
(dbAbortBubbleCallback):
* storage/indexeddb/resources/transaction-rollback.js:
(setVersionComplete):
(abortCallback):
* storage/indexeddb/set_version_blocked-expected.txt:
* storage/indexeddb/structured-clone-expected.txt:
* storage/indexeddb/structured-clone.html:
* storage/indexeddb/transaction-abort-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion-cross-frame.html:
* storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion.html:
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-event-propagation-expected.txt:
* storage/indexeddb/transaction-rollback-expected.txt:
* storage/indexeddb/tutorial.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd an eventPhase NONE constant
weinig@apple.com [Thu, 3 May 2012 23:24:04 +0000 (23:24 +0000)]
Add an eventPhase NONE constant
https://bugs.webkit.org/show_bug.cgi?id=85397

Reviewed by Anders Carlsson.

Source/WebCore:

Updates existing tests.

* dom/Event.h:
* dom/Event.idl:
Add NONE constant.

LayoutTests:

* fast/dom/constants-expected.txt:
* fast/dom/constants.html:
Test the value of the constant.

* fast/events/event-trace-expected.txt:
* fast/events/event-trace.html:
Ensure that the eventPhase is NONE when first initialized.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHeight overflow when nesting multiple new Flexbox'es.
tony@chromium.org [Thu, 3 May 2012 23:21:44 +0000 (23:21 +0000)]
Height overflow when nesting multiple new Flexbox'es.
https://bugs.webkit.org/show_bug.cgi?id=83572

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/nested-stretch.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeAvailableFreeSpace):

LayoutTests:

* css3/flexbox/nested-stretch-expected.txt: Added.
* css3/flexbox/nested-stretch.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening
tomz@codeaurora.org [Thu, 3 May 2012 23:10:26 +0000 (23:10 +0000)]
Unreviewed gardening

* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago--coverage should not not use the "feature" options system in build-webkit, similarly...
eric@webkit.org [Thu, 3 May 2012 23:09:41 +0000 (23:09 +0000)]
--coverage should not not use the "feature" options system in build-webkit, similarly remove special-casing for WTF_URL
https://bugs.webkit.org/show_bug.cgi?id=85542

Reviewed by Daniel Bates.

Remove these last two odd-men-out, so that we can generate the default feature options
for build-webkit using the new generate-feature-files command.
The Mac build system has some special casing for ENABLE_ defines which gets them
defined as -D on the build command, even though initially they start out as
environment variables ENABLE_FOO = ENABLE_FOO.  The Feature options in build-webkit
depend on this support, but it doesn't work for WTF_USE_ defines like WTF_USE_WTF_URL.
I'm told that WTF_URL is not actively being worked on, so just removing it for now.
It should probably come back to life as an ENABLE_, or build-webkit or the Xcode projects
should be made generically smarter about these USE_WTF defines.
(There is still WTF_USE_TILED_BACKING_STORE in the feature list, but it only seems
used by Qt.  If someone tried build-webkit --tiled-backing-store on Mac today it
would not work!)

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline.
zmo@google.com [Thu, 3 May 2012 22:59:41 +0000 (22:59 +0000)]
Unreviewed, rebaseline.

* platform/chromium-win-vista/fast/css/zoom-body-scroll-expected.txt: Added.
* platform/chromium-win-xp/fast/css/zoom-body-scroll-expected.txt: Added.
* platform/chromium-win/fast/css/zoom-body-scroll-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the last bits of Leopard support from our perl scripts
eric@webkit.org [Thu, 3 May 2012 22:54:55 +0000 (22:54 +0000)]
Remove the last bits of Leopard support from our perl scripts
https://bugs.webkit.org/show_bug.cgi?id=85545

Reviewed by Daniel Bates.

Chromium still supports Leopard (for a little while yet), but AppleMacWebKit dropped
Leopard support several months ago.  Remove the last bits of isLeopard() branching
in our Perl scripts, since no one is using this (Chromium has never used this Perl code).

* Scripts/build-webkit:
* Scripts/old-run-webkit-tests:
(countAndPrintLeaks):
(captureSavedCrashLog):
* Scripts/webkitdirs.pm:
(determineArchitecture):
(argumentsForRunAndDebugMacWebKitApp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdating expectations after r116009.
leviw@chromium.org [Thu, 3 May 2012 22:51:57 +0000 (22:51 +0000)]
Updating expectations after r116009.

* platform/chromium-linux/fast/block/float/overhanging-tall-block-expected.txt: Removed.
* platform/chromium-mac/fast/block/float/overhanging-tall-block-expected.png: Added.
* platform/chromium-mac/fast/block/float/overhanging-tall-block-expected.txt: Added.
* platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
* platform/chromium/fast/block/float/overhanging-tall-block-expected.png: Removed.
* platform/chromium/fast/block/float/overhanging-tall-block-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoASSERT(!m_zOrderListsDirty) is triggering in Safari
jchaffraix@webkit.org [Thu, 3 May 2012 22:50:10 +0000 (22:50 +0000)]
ASSERT(!m_zOrderListsDirty) is triggering in Safari
https://bugs.webkit.org/show_bug.cgi?id=85512

Reviewed by Simon Fraser.

Unfortunately no test as I don't think the 2 cases are testable reliably.

A better fix would be to introduce some iterator that handle updating the
lists for you. For now, just adding the missing updateLayerListsIfNeeded()
calls.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendantLayers):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerHas3DContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBugs in WebFullScreenController
commit-queue@webkit.org [Thu, 3 May 2012 22:48:38 +0000 (22:48 +0000)]
Bugs in WebFullScreenController
https://bugs.webkit.org/show_bug.cgi?id=85388

Patch by Tobias Netzel <tobias.netzel@googlemail.com> on 2012-05-03
Reviewed by Alexey Proskuryakov.

Leopard specific fixes:
NSWindow doesn't respond to isOnActiveSpace so find out first.
Values passed to SetSystemUIMode were swapped.

Source/WebKit/mac:

* WebView/WebFullScreenController.mm:
(-[WebFullScreenController exitFullScreen]):
(-[WebFullScreenController _updateMenuAndDockForFullScreen]):

Source/WebKit2:

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]):
(-[WKFullScreenWindowController _updateMenuAndDockForFullScreen]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix numeric precision issue in SVG animations
pdr@google.com [Thu, 3 May 2012 22:44:50 +0000 (22:44 +0000)]
Fix numeric precision issue in SVG animations
https://bugs.webkit.org/show_bug.cgi?id=85502

Reviewed by Dirk Schulze.

Source/WebCore:

r93938 had a bug where floating point numbers where compared exactly,
exposing a bug when floating point precision was not sufficient. This
change compares against an epsilon value to get around these precision
issues.

Test: svg/animations/animate-end-attribute-numeric-precision.html

* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

LayoutTests:

* svg/animations/animate-end-attribute-numeric-precision-expected.txt: Added.
* svg/animations/animate-end-attribute-numeric-precision.html: Added.
* svg/animations/script-tests/animate-end-attribute-numeric-precision.js: Added.
(sample1):
(sample2):
(executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Don't show the WebKit Linux ASAN bot on the flakiness dashboard.
ojan@chromium.org [Thu, 3 May 2012 22:44:11 +0000 (22:44 +0000)]
[Chromium] Don't show the WebKit Linux ASAN bot on the flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=85551

Reviewed by Dirk Pranke.

It's not uploading results and in the short term we don't plan to have it start.

* TestResultServer/static-dashboards/builders.js:
(isChromiumWebkitTipOfTreeTestRunner):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix coding style issues in IDBLevelDBCoding.cpp
jsbell@chromium.org [Thu, 3 May 2012 22:41:44 +0000 (22:41 +0000)]
Fix coding style issues in IDBLevelDBCoding.cpp
https://bugs.webkit.org/show_bug.cgi?id=85536

Reviewed by Tony Chang.

No tests - just code formatting changes.

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPageCache autorelease should not wait until 3 seconds and 42 pages
fpizlo@apple.com [Thu, 3 May 2012 22:36:51 +0000 (22:36 +0000)]
PageCache autorelease should not wait until 3 seconds and 42 pages
https://bugs.webkit.org/show_bug.cgi?id=85254
<rdar://problem/11349613>

Reviewed by Geoffrey Garen.

No new tests, since there is no change in behavior.

* history/PageCache.cpp:
(WebCore):
(WebCore::PageCache::PageCache):
(WebCore::PageCache::releaseAutoreleasedPagesNowDueToTimer):
* history/PageCache.h:
(PageCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShow the test name in the dashboard if showChrome==false and we're showing multiple...
ojan@chromium.org [Thu, 3 May 2012 22:34:55 +0000 (22:34 +0000)]
Show the test name in the dashboard if showChrome==false and we're showing multiple tests
https://bugs.webkit.org/show_bug.cgi?id=85243

Reviewed by Dirk Pranke.

This happens for cases where a test name matches multiple tests.
In practice, this only happens for virtual test suites (e.g. the canvas tests).

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(htmlForIndividualTestOnAllBuildersWithChrome):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
(testHtmlForIndividualTestOnAllBuildersWithChrome):
(testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
(testHtmlForIndividualTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHeap::reportAbandonedObjectGraph should not hasten an allocation-triggered collection
mhahnenberg@apple.com [Thu, 3 May 2012 22:31:43 +0000 (22:31 +0000)]
Heap::reportAbandonedObjectGraph should not hasten an allocation-triggered collection
https://bugs.webkit.org/show_bug.cgi?id=85543

Reviewed by Filip Pizlo.

Currently reportAbandonedObjectGraph causes the Heap to think it is closer to its
allocation limit for the current cycle, thus hastening an allocation-triggered collection.
In reality, it should just affect the opportunistic GC timer. We should track the bytes
we think have been abandoned and the bytes that have been allocated separately.

* heap/Heap.cpp: Added a new field m_abandonedBytes to Heap to keep track of how much
we think we've abandoned.
(JSC::Heap::Heap):
(JSC::Heap::reportAbandonedObjectGraph):
(JSC):
(JSC::Heap::didAbandon): Added this function for reportAbandonedObjectGraph to call
rather than didAllocate. Works the same as didAllocate, but modifies bytes abandoned rather
than bytes allocated. Also notifies the timer, summing the two values together.
(JSC::Heap::collect):
(JSC::Heap::didAllocate): Now adds the bytes allocated and bytes abandoned when reporting
to GCActivityCallback.
* heap/Heap.h:
(Heap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPort the flakiness dashboard unittests to qunit
ojan@chromium.org [Thu, 3 May 2012 22:29:28 +0000 (22:29 +0000)]
Port the flakiness dashboard unittests to qunit
https://bugs.webkit.org/show_bug.cgi?id=85544

Reviewed by Adam Barth.

* TestResultServer/static-dashboards/dashboard_base.js:
(appendJSONScriptElements):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(resetGlobals):
(runExpectationsTest):
(test):
* TestResultServer/static-dashboards/run-unittests.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline.
zmo@google.com [Thu, 3 May 2012 22:29:28 +0000 (22:29 +0000)]
Unreviewed, rebaseline.

* platform/chromium-mac-leopard/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
* platform/chromium-mac/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
* platform/chromium-win-vista/svg/as-image: Added.
* platform/chromium-win-vista/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
* platform/chromium-win-vista/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
* platform/chromium-win-xp/svg/as-image: Added.
* platform/chromium-win-xp/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
* platform/chromium-win-xp/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
* platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
* platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: Remove check for readline on Mac.
rakuco@webkit.org [Thu, 3 May 2012 22:10:55 +0000 (22:10 +0000)]
webkitpy: Remove check for readline on Mac.
https://bugs.webkit.org/show_bug.cgi?id=85547

Reviewed by Eric Seidel.

Python 2.5 is not supported by the WebKit project anymore, and
Python's readline documentation does not mention the module not
being available in the supported versions.

* Scripts/webkitpy/common/system/user.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[NRWT] Run performance tests with lock
commit-queue@webkit.org [Thu, 3 May 2012 22:09:36 +0000 (22:09 +0000)]
[NRWT] Run performance tests with lock
https://bugs.webkit.org/show_bug.cgi?id=78628

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-03
Reviewed by Tony Chang.

Locking performance tests (like we do for http tests) will force them
to run in serial. This reduces the load of the machine when running perf
tests and minimizes the chances of the tests to fail, specially
timeouts.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.__init__):
(Manager._is_perf_test):
(Manager._test_requires_lock):
* Scripts/webkitpy/layout_tests/port/http_lock.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempt to fix a crash on SL ...
dpranke@chromium.org [Thu, 3 May 2012 22:06:04 +0000 (22:06 +0000)]
Attempt to fix a crash on SL ...

Unreviewed, build fix.

It looks like we may be getting an IOError raised during
select() on chromium mac, and that error isn't being caught.
Pushing it into the try/catch block will hopefully catch this
and allow us to see why the subprocess is crashing.

* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._wait_for_data_and_update_buffers_using_select):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test expectations update for zoom event test due to slight change in round...
eae@chromium.org [Thu, 3 May 2012 21:56:45 +0000 (21:56 +0000)]
Unreviewed test expectations update for zoom event test due to slight change in rounding in hit testing code post the switch to FractionalLayoutUnits.

* fast/events/zoom-dblclick-expected.txt:
* fast/events/zoom-dblclick.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntegrate IETC CSS : flexbox tests
tomz@codeaurora.org [Thu, 3 May 2012 21:49:08 +0000 (21:49 +0000)]
Integrate IETC CSS : flexbox tests
https://bugs.webkit.org/show_bug.cgi?id=85210

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-05-03
Reviewed by Adam Barth.

Added 24 IETC Flexbox tests and reference tests.  Three of these fail and have
new bugs written against them.  Failing tests added to test_expectations.txt
for the various ports.

* ietestcenter/css3/flexbox/flexbox-align-baseline-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-align-baseline-001.htm: Added.
* ietestcenter/css3/flexbox/flexbox-align-center-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-align-center-001.htm: Added.
* ietestcenter/css3/flexbox/flexbox-align-center-002-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-align-center-002.htm: Added.
* ietestcenter/css3/flexbox/flexbox-align-end-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-align-end-001.htm: Added.
* ietestcenter/css3/flexbox/flexbox-align-start-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-align-start-001.htm: Added.
* ietestcenter/css3/flexbox/flexbox-align-stretch-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm: Added.
* ietestcenter/css3/flexbox/flexbox-direction-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-direction-001.htm: Added.
* ietestcenter/css3/flexbox/flexbox-flex-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-flex-001.htm: Added.
* ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-flex-002.htm: Added.
* ietestcenter/css3/flexbox/flexbox-flex-003-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-flex-003.htm: Added.
* ietestcenter/css3/flexbox/flexbox-flex-004-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-flex-004.htm: Added.
* ietestcenter/css3/flexbox/flexbox-flex-005-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-flex-005.htm: Added.
* ietestcenter/css3/flexbox/flexbox-groups-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-groups-001.htm: Added.
* ietestcenter/css3/flexbox/flexbox-groups-002-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-groups-002.htm: Added.
* ietestcenter/css3/flexbox/flexbox-groups-003-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-groups-003.htm: Added.
* ietestcenter/css3/flexbox/flexbox-groups-004-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-groups-004.htm: Added.
* ietestcenter/css3/flexbox/flexbox-layout-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-layout-001.htm: Added.
* ietestcenter/css3/flexbox/flexbox-layout-002-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-layout-002.htm: Added.
* ietestcenter/css3/flexbox/flexbox-layout-003-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-layout-003.htm: Added.
* ietestcenter/css3/flexbox/flexbox-ordinal-group-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm: Added.
* ietestcenter/css3/flexbox/flexbox-pack-center-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-pack-center-001.htm: Added.
* ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-pack-end-001.htm: Added.
* ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-pack-justify-001.htm: Added.
* ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.htm: Added.
* ietestcenter/css3/flexbox/flexbox-pack-start-001.htm: Added.
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix for Mac WK2. Adding a mistakenly removed symbol back to WebCore...
leviw@chromium.org [Thu, 3 May 2012 21:47:59 +0000 (21:47 +0000)]
Unreviewed build fix for Mac WK2. Adding a mistakenly removed symbol back to WebCore.exp.in.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebFrameLoaderClient::dispatchWillSendSubmitEvent() needs to be
jhoneycutt@apple.com [Thu, 3 May 2012 21:47:01 +0000 (21:47 +0000)]
WebFrameLoaderClient::dispatchWillSendSubmitEvent() needs to be
implemented for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=84304

Reviewed by Jessie Berlin.

Source/WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Declare willSendSubmitEvent on WKBundlePageFormClient.

* WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::willSendSubmitEvent):
From the String pair vector, create a map from control name to value.
Call the client's willSendSubmitEvent.

* WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
Declare willSendSubmitEvent.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
Call the injected bundle form client's willSendSubmitEvent.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
Un-stub willSendSubmitEvent.

* Shared/APIClientTraits.cpp:
(WebKit):
Set the interface sizes for WKBundlePageFormClient; version 1 includes
willSendSubmitEvent.

* Shared/APIClientTraits.h:
Declare a specialization for WKBundlePageFormClient.

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Bump the WKBundlePageFormClient version number.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Added new files to project.

* TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
Look for the "DidReceiveWillSendSubmitEvent" message. The message body
will be the dictionary of form control names and values passed to the
injected bundle's willSendSubmitEvent handler; look for the pairs
"textField" -> "text field" and "passwordField" -> "password field".
Check that "hiddenField" is not included.
(TestWebKitAPI::setInjectedBundleClient):
(TestWebKitAPI::TEST):

* TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: Added.
(TestWebKitAPI::willSendSubmitEvent):
Post a message to the TestWebKitAPI process with the dictionary of form
control names and values that we received.
(TestWebKitAPI::WillSendSubmitEventTest::WillSendSubmitEventTest):
(TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
Set up the page's form client.

* TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium test expectations update, mark a column test as failing due to...
eae@chromium.org [Thu, 3 May 2012 21:44:28 +0000 (21:44 +0000)]
Unreviewed chromium test expectations update, mark a column test as failing due to overflow.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix for Qt after 116009. No changes in behavior.
leviw@chromium.org [Thu, 3 May 2012 21:31:50 +0000 (21:31 +0000)]
Unreviewed build fix for Qt after 116009. No changes in behavior.

* rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed test expectations change for chromium, skip subpixel tests until SUBPIXEL_...
eae@chromium.org [Thu, 3 May 2012 21:18:14 +0000 (21:18 +0000)]
Unreviewed test expectations change for chromium, skip subpixel tests until SUBPIXEL_LAYOUT is enabled.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Revise touchpad fling curve to use exponential curve, to improve feel...
wjmaclean@chromium.org [Thu, 3 May 2012 21:17:15 +0000 (21:17 +0000)]
[chromium] Revise touchpad fling curve to use exponential curve, to improve feel and small fling performance.
https://bugs.webkit.org/show_bug.cgi?id=85530

Reviewed by Kenneth Russell.

Source/WebCore:

Existing unit tests updated for new curve.

Modifies TouchpadFLingGestureCurve to use an exponential, rather than polynomial, curve.
This change appears to improve the overall feel of touchpad fling, and substantially
improves small-fling performance.

* platform/TouchpadFlingPlatformGestureCurve.cpp:
(WebCore::TouchpadFlingPlatformGestureCurve::create):
(WebCore):
(WebCore::position):
(WebCore::velocity):
(WebCore::TouchpadFlingPlatformGestureCurve::TouchpadFlingPlatformGestureCurve):

Source/WebKit/chromium:

* tests/PlatformGestureCurveTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Thu, 3 May 2012 21:10:34 +0000 (21:10 +0000)]
[EFL] Unreviewed gardening.

* platform/efl/fast/html/details-position-expected.txt: Added.
* platform/efl/fast/replaced/width100percent-checkbox-expected.txt:
* platform/efl/fast/replaced/width100percent-radio-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[meta] Switch away from integers representing pixels for layout/event handling/rendering
leviw@chromium.org [Thu, 3 May 2012 21:07:32 +0000 (21:07 +0000)]
[meta] Switch away from integers representing pixels for layout/event handling/rendering
https://bugs.webkit.org/show_bug.cgi?id=60318

Source/WebCore:

Patch by Levi Weintraub  <leviw@chromium.org> and Emil A Eklund <eae@chromium.org> on 2012-04-23
Reviewed by Eric Seidel.

Swapping the LayoutUnit backend to FractionalLayoutUnit from int.

FractionalLayoutUnit is a new type that uses an integer to represent a fraction of a pixel.
We're also adding a feature flag -- ENABLE_SUBPIXEL_LAYOUT -- that toggles this fraction
between 1/1 and 1/60. Initially, all platforms will default to subpixel layout being off,
so FractionalLayoutUnits will effectively continue to act as integers.

With ENABLE_SUBPIXEL_LAYOUT turned on, FractionalLayoutUnits accumulate error from sub-pixel
CSS values and applied zooming, and painting uses pixel-snapping to align these values
to pixels. See http://trac.webkit.org/wiki/LayoutUnit for details.

In a number of previous patches, LayoutUnits were plumbed throughout the rendering tree
to prepare for this change. This included a number of functions in LayoutTypes.h and
the IntRect/Point/Size classes that were effectively no-ops while LayoutUnits were
integers. Subsequent patches will remove unnecessary versions of these functions; see
http://webkit.org/b/84616 for tracking these changes.

Tests: fast/sub-pixel/client-width-height-snapping.html
       fast/sub-pixel/layout-boxes-with-zoom.html
       fast/sub-pixel/size-of-box-with-zoom.html

* WebCore.exp.in: Updating function signatures that expose FractionalLayoutUnits.
* WebCore.xcodeproj/project.pbxproj: Adding missing FractionalLayoutPoint.h header.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::zoomAdjustedPixelValue): Using adjustFloatForAbsoluteZoom instead of int
to make use of extra precision before returning the pixel value.
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength): No longer rounds for imprecise conversion
when sub-pixel layout is enabled.
(WebCore::CSSPrimitiveValue::customCssText): Returning integer values for pixels.
* dom/Element.cpp:
(WebCore::adjustForLocalZoom): Using rounding instead of incrementing the value before
adjusting to account for truncation when sub-pixel layout is enabled.
* page/SpatialNavigation.cpp:
(WebCore::distanceDataForNode): Using FractionalLayoutUnit::abs instead of std::abs.
* platform/FractionalLayoutUnit.h: Adding some missing operators and a flag around the
constant denominator to switch it between 1/1 and 1/60 depending on the feature flag.
* platform/Length.h: Changing the default type for value to float, and adding intValue
since this more closely matches usage in a sub-pixel layout world.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::paint): Using minimumIntValueForLength in this platform code
instead of LayoutUnits.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
* rendering/LayoutTypes.h: This file contains the actual switch for changing LayoutUnits
to be FractionalLayoutUnits. Also updating stub methods with their proper implementations.
* rendering/PaintInfo.h:
(WebCore::PaintInfo::infiniteRect): Ensuring the infiniteRect doesn't overflow the
FractionalLayoutUnit bounds.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine): Switch to
FractionalLayoutUnit's abs function instead of std::abs.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Add rounding for
setting the phase of the background geometry before applying modulo from the tile size.
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox): Stop applying flex when
we have less than a pixel to distribute.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundClipRect): Replace PaintInfo::infiniteRect with the
LayoutRect equivalent.
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::rangeIntersectsRect): Using FractionalLayoutUnit::abs
instead of std::abs.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded): Ditto.
* rendering/RenderObject.h:
(WebCore): Removing unnecessary adjustForAbsoluteZoom function.
(WebCore::RenderObject::outlineSize): Outlines remain ints.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleOrColLogicalWidth): Build fix. Using floats because
colWidthSum is a Length which uses floats.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton): Explicit templatization
for max.
* rendering/RenderTreeAsText.cpp: Adding code to minimize test expectation churn. It
may be worth outputting float values in test expectations, but this isn't done with
the inline box tree yet, either.
* rendering/RenderTreeAsText.h:
(WebCore): Adding a FractionalLayoutPoint operator.
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetGeometry): Adding missing pixel snapping, and switching
absoluteContentBox to an IntRect, as this is what boundingBox returns.
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writePositionAndStyle): Adding an enclosingIntRect for consistency with old results.

LayoutTests:

Reviewed by Eric Seidel.

* fast/sub-pixel: Added.
* fast/sub-pixel/client-width-height-snapping-expected.txt: Added.
* fast/sub-pixel/client-width-height-snapping.html: Added.
* fast/sub-pixel/size-of-box-with-zoom-expected.html: Added.
* fast/sub-pixel/size-of-box-with-zoom.html: Added.
* fast/sub-pixel/layout-boxes-with-zoom-expected.html: Added.
* fast/sub-pixel/layout-boxes-with-zoom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove dead code from build-webkit for working around old XCode dependency bug
eric@webkit.org [Thu, 3 May 2012 21:07:17 +0000 (21:07 +0000)]
Remove dead code from build-webkit for working around old XCode dependency bug
https://bugs.webkit.org/show_bug.cgi?id=85535

Reviewed by Adam Barth.

Xcode used to have a bug whereby it didn't notice if you changed the #defines
passed on the command line to xcodebuild.  I wrote code to work around this
while bringing up SVG support 5-6 years ago.  I think we can finally remove this
code from build-webkit, since SVG is the only feature flag to ever use it
(modern in-progress features like MathML don't seem to be using the support)
an I suspect the XCode bug has long been fixed.

* Scripts/build-webkit:
* Scripts/webkitperl/features.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed, remove expectation which was failing.
rakuco@webkit.org [Thu, 3 May 2012 21:01:25 +0000 (21:01 +0000)]
[EFL] Unreviewed, remove expectation which was failing.

The current result matches the base expectation, so remove the
port-specific one.

* platform/efl/fast/css/zoom-body-scroll-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline.
zmo@google.com [Thu, 3 May 2012 20:55:48 +0000 (20:55 +0000)]
Unreviewed, rebaseline.

* platform/chromium-mac/compositing/geometry/foreground-layer-expected.txt: Removed.
* platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/chromium-win/compositing/geometry/ancestor-overflow-change-expected.txt:
* platform/chromium-win/compositing/geometry/foreground-layer-expected.txt: Removed.
* platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/chromium-win/compositing/overflow/clip-descendents-expected.txt:
* platform/chromium/compositing/geometry/foreground-layer-expected.txt: Replaced.
* platform/chromium/compositing/iframes/invisible-nested-iframe-show-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove repaint counter drawing code out into a separate function
andersca@apple.com [Thu, 3 May 2012 20:43:21 +0000 (20:43 +0000)]
Move repaint counter drawing code out into a separate function
https://bugs.webkit.org/show_bug.cgi?id=85539

Reviewed by Simon Fraser.

The majority of code in TileCache::drawLayer deals with drawing the repaint counter. Move this code out
into a separate function to make it more clear what drawLayer does.

* platform/graphics/ca/mac/TileCache.h:
(TileCache):
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::drawLayer):
(WebCore::TileCache::drawRepaintCounter):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, unskipping fixed test.
fpizlo@apple.com [Thu, 3 May 2012 20:42:35 +0000 (20:42 +0000)]
Unreviewed, unskipping fixed test.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCompositing 'requiresOwnBackingStore' logic caused new clip rect assertions
simon.fraser@apple.com [Thu, 3 May 2012 20:32:29 +0000 (20:32 +0000)]
Compositing 'requiresOwnBackingStore' logic caused new clip rect assertions
https://bugs.webkit.org/show_bug.cgi?id=85455

Reviewed by Dean Jackson.

r114283 added logic that allows compositing layers to avoid allocating their own
backing store and to paint into an ancestor instead. However, that caused
assertions in RenderLayer::updateClipRects() about m_clipRectsRoot being
incorrect, because clip rect code assumed that compositing layers
always painted themselves.

Fixed by calling paintsIntoCompositedAncestor() in RenderLayer::clippingRoot(),
so that clip rect computation matches painting.

I wasn't able to easily make a test that reproduces the assertion in DRT.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clippingRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Use correct define in the features.gypi
commit-queue@webkit.org [Thu, 3 May 2012 20:29:44 +0000 (20:29 +0000)]
[Chromium] Use correct define in the features.gypi
https://bugs.webkit.org/show_bug.cgi?id=85520

Patch by Ben Goodger.

Patch by Dimitri Glazkov <dglazkov@chromium.org> on 2012-05-03
Reviewed by Tony Chang.

* features.gypi: Replaced use_aura with a more appropriate chromeos

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(99539): SVG <img> disregards page scale and device scale
timothy_horton@apple.com [Thu, 3 May 2012 20:25:57 +0000 (20:25 +0000)]
REGRESSION(99539): SVG <img> disregards page scale and device scale
https://bugs.webkit.org/show_bug.cgi?id=77237
<rdar://problem/10767413>

Reviewed by Simon Fraser.

Rename SVGImageCache::SizeAndZoom to SVGImageCache::SizeAndScales, as it carries more than just zoom now.

Pass the product of the device and page scales through everything that takes a SVGImageCache::SizeAndScales,
using it to inflate the size of the buffer created in lookupOrCreateBitmapImageForRenderer,
and to inflate the destination rectangle passed to SVGImage::draw, which will cause a transformation
on the context being drawn into.

Invalidate the SVGImageCache entry on device/page scale changes in addition to zoom changes.

This patch does not cause SVGImageCache to take into account scale caused by CSS transforms; that is tracked
separately by https://bugs.webkit.org/show_bug.cgi?id=85335.

Tests: svg/as-image/image-respects-deviceScaleFactor.html
       svg/as-image/image-respects-pageScaleFactor.html

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawSVGToImageBuffer):
* svg/graphics/SVGImage.h:
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeRendererFromCache):
(WebCore::SVGImageCache::setRequestedSizeAndScales):
(WebCore::SVGImageCache::requestedSizeAndScales):
(WebCore::SVGImageCache::redraw):
(WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):
* svg/graphics/SVGImageCache.h:
(WebCore::SVGImageCache::SizeAndScales::SizeAndScales):
(SizeAndScales):
(SVGImageCache):
(WebCore::SVGImageCache::ImageData::ImageData):
(ImageData):

Add tests ensuring that SVG used via <img> respects deviceScaleFactor and pageScaleFactor.

* platform/chromium-linux/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
* platform/chromium-linux/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/qt/Skipped:
* platform/mac/svg/as-image/image-respects-deviceScaleFactor-expected.png: Added.
* platform/mac/svg/as-image/image-respects-deviceScaleFactor-expected.txt: Added.
* platform/mac/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
* platform/mac/svg/as-image/image-respects-pageScaleFactor-expected.txt: Added.
* platform/efl/Skipped:
* svg/as-image/image-respects-deviceScaleFactor.html: Added.
* svg/as-image/image-respects-pageScaleFactor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInjectedBundleControllerMac.mm needs to include config.h
aestes@apple.com [Thu, 3 May 2012 20:04:16 +0000 (20:04 +0000)]
InjectedBundleControllerMac.mm needs to include config.h
https://bugs.webkit.org/show_bug.cgi?id=85531

Reviewed by Andreas Kling.

* TestWebKitAPI/mac/InjectedBundleControllerMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: Use PlatformInfo whenever possible in server_process.py.
rakuco@webkit.org [Thu, 3 May 2012 19:59:19 +0000 (19:59 +0000)]
webkitpy: Use PlatformInfo whenever possible in server_process.py.
https://bugs.webkit.org/show_bug.cgi?id=85516

Reviewed by Eric Seidel.

Eliminate direct access to sys.platform wherever possible by using
PlatformInfo.is_win() instead.

* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess.__init__): Remove the executive parameter as it was
not passed by any caller, obtain a SystemHost from port_obj
instead.
(ServerProcess._log): Style, remove extra empty line.
(ServerProcess._start):
(ServerProcess.stop):
(ServerProcess.kill):
* Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
(TrivialMockPort.__init__): Create a MockSystemHost used by
ServerProcess.
(TestServerProcess.test_broken_pipe): Test different platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoving line in computeViewportAttributes that enforces a minimum scale factor to...
fsamuel@chromium.org [Thu, 3 May 2012 19:41:39 +0000 (19:41 +0000)]
Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
https://bugs.webkit.org/show_bug.cgi?id=70609

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Make Viewport Attributes' layoutSize be a FloatRect to avoid rounding
too early, and the occasional off by one fixed layout dimensions.

* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
* dom/ViewportArguments.h:
(ViewportAttributes):

Source/WebKit/blackberry:

* WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::dumpConfigurationForViewport):

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::dumpConfigurationForViewport):

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::dumpConfigurationForViewport):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::viewportAttributesForSize):
* Api/qwebpage.h:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

* UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::layoutSize):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::viewportConfigurationAsText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Handle generated keys up to 2^53
jsbell@chromium.org [Thu, 3 May 2012 19:33:05 +0000 (19:33 +0000)]
IndexedDB: Handle generated keys up to 2^53
https://bugs.webkit.org/show_bug.cgi?id=85114

Source/WebCore:

The spec defines the behavior for generated keys up to 2^53
(the maximum integer storable as an ECMAScript number) and
the error case when going beyond that. Ensure that we can
handle values up to that point and generate errors beyond.

Reviewed by Tony Chang.

Test: storage/indexeddb/key-generator.html

* Modules/indexeddb/IDBBackingStore.h:
(IDBBackingStore):
* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::nextAutoIncrementNumber):
* Modules/indexeddb/IDBLevelDBBackingStore.h:
(IDBLevelDBBackingStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::putInternal):
(WebCore::IDBObjectStoreBackendImpl::genAutoIncrementKey):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(IDBObjectStoreBackendImpl):

LayoutTests:

Reviewed by Tony Chang.

* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/resources/key-generator.js:
(get defineTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. skip failing test.
fpizlo@apple.com [Thu, 3 May 2012 19:00:45 +0000 (19:00 +0000)]
Unreviewed. skip failing test.

https://bugs.webkit.org/show_bug.cgi?id=85529

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd methods to create WebArrayBuffer/WebArrayBufferView from v8 objects
commit-queue@webkit.org [Thu, 3 May 2012 18:57:52 +0000 (18:57 +0000)]
Add methods to create WebArrayBuffer/WebArrayBufferView from v8 objects
https://bugs.webkit.org/show_bug.cgi?id=84899

Patch by Antony Sargent <asargent@chromium.org> on 2012-05-03
Reviewed by Adam Barth.

* public/WebArrayBuffer.h:
(WebArrayBuffer):
* public/platform/WebArrayBufferView.h:
(v8):
(WebArrayBufferView):
* src/WebArrayBuffer.cpp:
(WebKit):
(WebKit::WebArrayBuffer::createFromV8Value):
* src/WebArrayBufferView.cpp:
(WebKit):
(WebKit::WebArrayBufferView::createFromV8Value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, skipping flaky tests.
fpizlo@apple.com [Thu, 3 May 2012 18:47:24 +0000 (18:47 +0000)]
Unreviewed, skipping flaky tests.

https://bugs.webkit.org/show_bug.cgi?id=85522
https://bugs.webkit.org/show_bug.cgi?id=85523
https://bugs.webkit.org/show_bug.cgi?id=85524
https://bugs.webkit.org/show_bug.cgi?id=85525

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoved dumpAsText() from this ref test, since that apparently confuses the test...
mitz@apple.com [Thu, 3 May 2012 18:18:09 +0000 (18:18 +0000)]
Removed dumpAsText() from this ref test, since that apparently confuses the test tool.

* fast/writing-mode/flipped-blocks-inline-map-local-to-container.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove RenderLayerCompositor::didStartAcceleratedAnimation()
simon.fraser@apple.com [Thu, 3 May 2012 18:15:41 +0000 (18:15 +0000)]
Remove RenderLayerCompositor::didStartAcceleratedAnimation()
https://bugs.webkit.org/show_bug.cgi?id=85514

Reviewed by Antti Koivisto.

Remove RenderLayerCompositor::didStartAcceleratedAnimation(), which is no longer
needed.

Code removal, no new tests.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
* rendering/RenderLayerCompositor.cpp:
* rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r111387): CSSOM representation of 'background-image' values should be...
kling@webkit.org [Thu, 3 May 2012 18:08:08 +0000 (18:08 +0000)]
REGRESSION(r111387): CSSOM representation of 'background-image' values should be CSSPrimitiveValue.
<http://webkit.org/b/85500>

Reviewed by Antti Koivisto.

Source/WebCore:

Use the cloneForCSSOM() mechanism in CSSValue to expose CSSImageValue to bindings as a URI
primitive value. This matches the specced behavior of computed image values, and restores our
previous behavior without having CSSImageValue subclass CSSPrimitiveValue.

Also added a failsafe return after the isCSSOMSafe() assertion in the JSC bindings, since it's
better to expose an incorrect return value than an insecurely shared one, should we have or add
bugs in this code.

* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cloneForCSSOM):
* css/CSSImageValue.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::cloneForCSSOM):

LayoutTests:

Update fast/css/image-value-type.html to reflect that CSSImageValue are now exposed
as primitive values in the CSSOM.

* fast/css/image-value-type-expected.txt:
* fast/css/image-value-type.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in HTMLFormControlElement::m_fieldSetAncestor
keishi@webkit.org [Thu, 3 May 2012 17:54:40 +0000 (17:54 +0000)]
Crash in HTMLFormControlElement::m_fieldSetAncestor
https://bugs.webkit.org/show_bug.cgi?id=85453

Reviewed by Kent Tamura.

Source/WebCore:

Modified tests: fast/forms/datalist/datalist-child-validation.html
                fast/forms/form-control-element-crash.html

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::removedFrom): Only set the invalid ancestor flag.
The element will be detached from the document so there is no need to update the style.
And the validation message will be hidden by the blur event.
(WebCore::HTMLFormControlElement::willValidate): Because of the change to removedFrom,
m_ancestorsValid may be false.

LayoutTests:

* fast/forms/datalist/datalist-child-validation-expected.txt:
* fast/forms/datalist/datalist-child-validation.html: Added tests that check the validation status of removed node.
* fast/forms/form-control-element-crash-expected.txt:
* fast/forms/form-control-element-crash.html: Replaced with a better, easier to understand test case from the cluster-fuzz.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoKeep overlap testing for compositing on pages with 3d transforms when possible
simon.fraser@apple.com [Thu, 3 May 2012 17:50:03 +0000 (17:50 +0000)]
Keep overlap testing for compositing on pages with 3d transforms when possible
https://bugs.webkit.org/show_bug.cgi?id=62487

Source/WebCore:

Reviewed by Antti Koivisto.

Change RenderLayerCompositor to always use overlap testing when possible.

Rather than turn off overlap testing wholesale when encountering a non-affine
transform, or starting an accelerated transform animation, we constrain
the disabling of overlap testing to within overflow:hidden areas when possible.

Tests: compositing/layer-creation/overlap-animation.html
       compositing/layer-creation/overlap-transforms.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setCompositedBounds): Whitespace fix.
* rendering/RenderLayerCompositor.cpp:
(WebCore::CompositingState::CompositingState):
(CompositingState): Add a member boolean to track whether we're testing overlap. Add a copy
constructor.
(WebCore::RenderLayerCompositor::updateCompositingLayers): Initialize the 'testing overlap'
setting based on m_compositingConsultsOverlap (though this will always be true until removed
in a future commit).
(WebCore::RenderLayerCompositor::updateBacking): No longer turn off overlap testing
when we see a non-affine transform.
(WebCore::RenderLayerCompositor::computeCompositingRequirements): No need for the 'struct'
in the arguments.
Consult compositingState.m_testingOverlap to see if we want to test overlap.
Use the new CompositingState copy ctor for childState, but set m_subtreeIsCompositing to false
as before.
If this layer is composited, look to see if need to disable over lap testing based on
the transform or an animation.
Just as we propagate m_subtreeIsCompositing, we have to propagate m_testingOverlap=false
for the rest of the traverse.
If we've just processed a layer which clips compositing descendants, we can go back
to testing for overlap.
(WebCore::RenderLayerCompositor::didStartAcceleratedAnimation): No need to do anything
here now. It will be removed in future.
(WebCore::RenderLayerCompositor::hasNonAffineTransform): No longer check
perspective here, since that doesn't affect whether _this_ layer should disable
overlap testing. Checking for a non-affine transform is sufficient.
(WebCore::RenderLayerCompositor::isRunningAcceleratedTransformAnimation):
New method to check if AnimationController is running a transform animation.
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

LayoutTests:

Reviewed by Antti Koivisto.

Two new tests that check for layer creation outside of an overflow:hidden
stacking context.

Updated results for other tests whose results are affected by the
'compositingConsultsOverlap' flag; their layers are now constrained to
the viewport.

* compositing/geometry/ancestor-overflow-change-expected.txt:
* compositing/geometry/foreground-layer-expected.txt:
* compositing/iframes/invisible-nested-iframe-show-expected.txt:
* compositing/layer-creation/overlap-animation-expected.txt: Added.
* compositing/layer-creation/overlap-animation.html: Added.
* compositing/layer-creation/overlap-transforms-expected.txt: Added.
* compositing/layer-creation/overlap-transforms.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMutex failure when HashTable is memory moved in debug build
commit-queue@webkit.org [Thu, 3 May 2012 17:18:11 +0000 (17:18 +0000)]
Mutex failure when HashTable is memory moved in debug build
https://bugs.webkit.org/show_bug.cgi?id=84970

Patch by Yong Li <yoli@rim.com> on 2012-05-03
Reviewed by Rob Buis.

1. Replace m_mutex with OwnPtr<m_mutex> so HashTable is still
   memory movable in debug build.
2. Assert successes of pthread_mutex_init() and pthread_mutex_destroy().

* wtf/HashTable.h:
(HashTable):
(WTF::::HashTable):
(WTF::::invalidateIterators):
(WTF::addIterator):
(WTF::removeIterator):
* wtf/ThreadingPthreads.cpp:
(WTF::Mutex::Mutex):
(WTF::Mutex::~Mutex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] CSS tests needs gardening
commit-queue@webkit.org [Thu, 3 May 2012 17:10:55 +0000 (17:10 +0000)]
[EFL] CSS tests needs gardening
https://bugs.webkit.org/show_bug.cgi?id=85499

Unreviewed gardening.

Moved CSS tests from Skipped to test_expectations.txt and made the
reference to the appropriated bug. Also updated missing/wrong
baselines.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-03

* platform/efl/Skipped:
* platform/efl/css1/basic/class_as_selector-expected.png:
* platform/efl/css1/basic/comments-expected.png:
* platform/efl/css1/basic/containment-expected.png:
* platform/efl/css1/box_properties/acid_test-expected.png:
* platform/efl/css1/box_properties/border-expected.png:
* platform/efl/css1/cascade/cascade_order-expected.png:
* platform/efl/css1/cascade/important-expected.png:
* platform/efl/css1/classification/display-expected.png:
* platform/efl/css1/classification/list_style-expected.png:
* platform/efl/css1/color_and_background/background-expected.png:
* platform/efl/css1/color_and_background/background_attachment-expected.png:
* platform/efl/css1/conformance/forward_compatible_parsing-expected.png:
* platform/efl/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
* platform/efl/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
* platform/efl/css2.1/20110323/background-intrinsic-001-expected.png: Added.
* platform/efl/css2.1/20110323/background-intrinsic-001-expected.txt: Added.
* platform/efl/css2.1/20110323/background-intrinsic-002-expected.png: Added.
* platform/efl/css2.1/20110323/background-intrinsic-002-expected.txt: Added.
* platform/efl/css2.1/20110323/background-intrinsic-003-expected.png: Added.
* platform/efl/css2.1/20110323/background-intrinsic-003-expected.txt: Added.
* platform/efl/css2.1/20110323/background-intrinsic-004-expected.png: Added.
* platform/efl/css2.1/20110323/background-intrinsic-004-expected.txt: Added.
* platform/efl/css2.1/20110323/background-intrinsic-005-expected.png: Added.
* platform/efl/css2.1/20110323/background-intrinsic-005-expected.txt: Added.
* platform/efl/css2.1/20110323/background-intrinsic-006-expected.png: Added.
* platform/efl/css2.1/20110323/background-intrinsic-006-expected.txt: Added.
* platform/efl/css2.1/20110323/background-intrinsic-007-expected.png: Added.
* platform/efl/css2.1/20110323/background-intrinsic-007-expected.txt: Added.
* platform/efl/css2.1/20110323/background-intrinsic-008-expected.png: Added.
* platform/efl/css2.1/20110323/background-intrinsic-008-expected.txt: Added.
* platform/efl/css2.1/20110323/background-intrinsic-009-expected.png: Added.
* platform/efl/css2.1/20110323/background-intrinsic-009-expected.txt: Added.
* platform/efl/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
* platform/efl/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
* platform/efl/css2.1/20110323/border-spacing-applies-to-015-expected.png: Added.
* platform/efl/css2.1/20110323/border-spacing-applies-to-015-expected.txt: Added.
* platform/efl/css2.1/20110323/dynamic-top-change-001-expected.png: Added.
* platform/efl/css2.1/20110323/dynamic-top-change-001-expected.txt: Added.
* platform/efl/css2.1/20110323/dynamic-top-change-002-expected.png: Added.
* platform/efl/css2.1/20110323/dynamic-top-change-002-expected.txt: Added.
* platform/efl/css2.1/20110323/dynamic-top-change-003-expected.png: Added.
* platform/efl/css2.1/20110323/dynamic-top-change-003-expected.txt: Added.
* platform/efl/css2.1/20110323/dynamic-top-change-004-expected.png: Added.
* platform/efl/css2.1/20110323/dynamic-top-change-004-expected.txt: Added.
* platform/efl/css2.1/20110323/empty-inline-001-expected.png: Added.
* platform/efl/css2.1/20110323/empty-inline-001-expected.txt: Added.
* platform/efl/css2.1/20110323/empty-inline-002-expected.png: Added.
* platform/efl/css2.1/20110323/empty-inline-002-expected.txt: Added.
* platform/efl/css2.1/20110323/empty-inline-003-expected.png: Added.
* platform/efl/css2.1/20110323/empty-inline-003-expected.txt: Added.
* platform/efl/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
* platform/efl/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
* platform/efl/css2.1/20110323/table-caption-001-expected.png: Added.
* platform/efl/css2.1/20110323/table-caption-001-expected.txt: Added.
* platform/efl/css2.1/20110323/table-caption-002-expected.png: Added.
* platform/efl/css2.1/20110323/table-caption-002-expected.txt: Added.
* platform/efl/css2.1/20110323/table-caption-horizontal-alignment-001-expected.png: Added.
* platform/efl/css2.1/20110323/table-caption-horizontal-alignment-001-expected.txt: Added.
* platform/efl/css2.1/20110323/table-caption-margins-001-expected.png: Added.
* platform/efl/css2.1/20110323/table-caption-margins-001-expected.txt: Added.
* platform/efl/css2.1/20110323/table-caption-optional-001-expected.png: Added.
* platform/efl/css2.1/20110323/table-caption-optional-001-expected.txt: Added.
* platform/efl/css2.1/20110323/table-caption-optional-002-expected.png: Added.
* platform/efl/css2.1/20110323/table-caption-optional-002-expected.txt: Added.
* platform/efl/css3/images/cross-fade-background-size-expected.txt: Added.
* platform/efl/css3/images/cross-fade-blending-expected.png: Added.
* platform/efl/css3/images/cross-fade-blending-expected.txt: Added.
* platform/efl/css3/images/cross-fade-invalidation-expected.png: Added.
* platform/efl/css3/images/cross-fade-invalidation-expected.txt: Added.
* platform/efl/css3/images/cross-fade-simple-expected.png: Added.
* platform/efl/css3/images/cross-fade-simple-expected.txt: Added.
* platform/efl/css3/images/cross-fade-sizing-expected.png: Added.
* platform/efl/css3/images/cross-fade-sizing-expected.txt: Added.
* platform/efl/css3/images/cross-fade-tiled-expected.png: Added.
* platform/efl/css3/images/cross-fade-tiled-expected.txt: Added.
* platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.png: Added.
* platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Added.
* platform/efl/fast/css/child-style-can-override-visited-style-expected.png: Added.
* platform/efl/fast/css/child-style-can-override-visited-style-expected.txt: Added.
* platform/efl/fast/css/clip-text-in-scaled-div-expected.png: Added.
* platform/efl/fast/css/clip-text-in-scaled-div-expected.txt: Added.
* platform/efl/fast/css/color-correction-on-background-image-expected.txt: Added.
* platform/efl/fast/css/color-correction-on-backgrounds-expected.txt: Added.
* platform/efl/fast/css/color-correction-on-box-shadow-expected.txt: Added.
* platform/efl/fast/css/color-correction-on-text-shadow-expected.txt: Added.
* platform/efl/fast/css/color-correction-untagged-images-expected.txt: Added.
* platform/efl/fast/css/invalidation-errors-2-expected.txt:
* platform/efl/fast/css/invalidation-errors-expected.txt:
* platform/efl/fast/css/shadow-multiple-expected.png:
* platform/efl/fast/css/text-overflow-input-expected.png: Added.
* platform/efl/fast/css/text-overflow-input-expected.txt: Added.
* platform/efl/fast/css/text-rendering-expected.png: Removed.
* platform/efl/fast/css/text-rendering-expected.txt: Added.
* platform/efl/svg/css/composite-shadow-example-expected.txt: Removed.
* platform/efl/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
* platform/efl/svg/css/group-with-shadow-expected.png: Added.
* platform/efl/svg/css/stars-with-shadow-expected.png: Added.
* platform/efl/test_expectations.txt:
* platform/efl/transforms/svg-vs-css-expected.png:
* platform/efl/transforms/svg-vs-css-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: Style checker broken when committing a PNG
commit-queue@webkit.org [Thu, 3 May 2012 17:07:12 +0000 (17:07 +0000)]
webkitpy: Style checker broken when committing a PNG
https://bugs.webkit.org/show_bug.cgi?id=85504

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-03
Reviewed by Dirk Pranke.

* Scripts/webkitpy/style/checkers/png.py:
(PNGChecker.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoaccessibility/misspelled-attributed-string.html test sometimes throws exceptions
cfleizach@apple.com [Thu, 3 May 2012 17:07:00 +0000 (17:07 +0000)]
accessibility/misspelled-attributed-string.html test sometimes throws exceptions
https://bugs.webkit.org/show_bug.cgi?id=85081

Reviewed by Darin Adler.

Add in more range checking in case we get back ranges from spell checking that are wrong.

* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(AXAttributeStringSetFont):
(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetBlockquoteLevel):
(AXAttributeStringSetHeadingLevel):
(AXAttributeStringSetElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115985 268f45cc-cd09-0410-ab3c-d52691b4dbfc