WebKit-https.git
8 years agoUnreviewed. Adding platform expectations after 105879
leviw@chromium.org [Wed, 25 Jan 2012 17:51:20 +0000 (17:51 +0000)]
Unreviewed. Adding platform expectations after 105879

* platform/chromium-linux-x86/compositing: Added.
* platform/chromium-linux-x86/compositing/overflow: Added.
* platform/chromium-linux-x86/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
* platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
* platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
* platform/chromium-win-vista/compositing: Added.
* platform/chromium-win-vista/compositing/overflow: Added.
* platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
* platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
* platform/chromium-win-xp/compositing: Added.
* platform/chromium-win-xp/compositing/overflow: Added.
* platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
* platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.
* platform/chromium-win/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
* platform/chromium-win/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Adding platform test expectations after r105878.
leviw@chromium.org [Wed, 25 Jan 2012 17:48:24 +0000 (17:48 +0000)]
Unreviewed. Adding platform test expectations after r105878.

* platform/chromium-mac-leopard/svg/stroke: Added.
* platform/chromium-mac-leopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/chromium-mac-leopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/chromium-win-vista/svg/stroke: Added.
* platform/chromium-win-vista/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/chromium-win-vista/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/chromium-win-xp/svg/stroke: Added.
* platform/chromium-win-xp/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/chromium-win-xp/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/chromium-win/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/chromium-win/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline and skip new timing-out media test.
philn@webkit.org [Wed, 25 Jan 2012 17:45:58 +0000 (17:45 +0000)]
Unreviewed, GTK rebaseline and skip new timing-out media test.

* platform/gtk/Skipped:
* platform/gtk/css3/calc/getComputedStyle-margin-percentage-expected.txt: Added.
* platform/gtk/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=65377
commit-queue@webkit.org [Wed, 25 Jan 2012 17:23:48 +0000 (17:23 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=65377
Skip the entire node when it is right to do so, instead of stepping
through every character, so we save CPU time on checking every position
unnecessarily.

Patch by Yong Li <yoli@rim.com> on 2012-01-25
Reviewed by Darin Adler.

Source/WebCore:

Test: perf/selection-skip-hidden-node.html

* dom/Position.cpp:
(WebCore::Position::upstream):
(WebCore::Position::downstream):
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::moveToLeafNodeStart):
(WebCore::PositionIterator::moveToLeafNodeEnd):
* dom/PositionIterator.h:
* editing/htmlediting.cpp:
(WebCore::nextCandidate):
(WebCore::nextVisuallyDistinctCandidate):
(WebCore::previousCandidate):
(WebCore::previousVisuallyDistinctCandidate):

LayoutTests:

* perf/selection-skip-hidden-node-expected.txt: Added.
* perf/selection-skip-hidden-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
commit-queue@webkit.org [Wed, 25 Jan 2012 17:21:33 +0000 (17:21 +0000)]
[WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
https://bugs.webkit.org/show_bug.cgi?id=63458

Patch by Nándor Huszka <huszka.nandor@stud.u-szeged.hu> on 2012-01-25
Reviewed by Adam Roben.

Source/WebKit2:

Implement the setPopupBlockingEnabled method.

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetPrivateBrowsingEnabled):
(WKBundleSetPopupBlockingEnabled):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPopupBlockingEnabled):
* WebProcess/InjectedBundle/InjectedBundle.h:

Tools:

Implement the setPopupBlockingEnabled method.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setPopupBlockingEnabled):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:

LayoutTests:

Unskip tests which do not fail now.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unnecessary member variable from PluginView.
commit-queue@webkit.org [Wed, 25 Jan 2012 17:18:29 +0000 (17:18 +0000)]
Remove unnecessary member variable from PluginView.
https://bugs.webkit.org/show_bug.cgi?id=76909

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2012-01-25
Reviewed by Adam Roben.

No new tests needed.

* plugins/PluginView.cpp:
(WebCore::PluginView::getURLNotify):
(WebCore::PluginView::getURL):
(WebCore::PluginView::PluginView):
(WebCore::PluginView::handlePost):
(WebCore::PluginView::getValueForURL):
(WebCore::PluginView::setValueForURL):
* plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline and skipping 2 new test failures.
philn@webkit.org [Wed, 25 Jan 2012 17:17:30 +0000 (17:17 +0000)]
Unreviewed, GTK rebaseline and skipping 2 new test failures.

* platform/gtk/Skipped:
* platform/gtk/svg/custom/path-moveto-only-rendering-expected.txt:
* platform/gtk/svg/custom/subpaths-moveto-only-rendering-expected.txt:
* platform/gtk/svg/custom/zero-path-square-cap-rendering-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Build fix when using force_static_libs_as_shared
yael.aharon@nokia.com [Wed, 25 Jan 2012 17:09:51 +0000 (17:09 +0000)]
[Qt] Build fix when using force_static_libs_as_shared
https://bugs.webkit.org/show_bug.cgi?id=76832

Reviewed by Simon Hausmann.

Source/WebCore:

Add a dependency on QtWidgets, when compiling against Qt5.

No new tests. This is a build fix.

* Target.pri:

Source/WebKit2:

Add a dependency on QtWidgets.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Gtk] Update expected layout test results after r105686
philn@webkit.org [Wed, 25 Jan 2012 16:19:35 +0000 (16:19 +0000)]
[Gtk] Update expected layout test results after r105686
https://bugs.webkit.org/show_bug.cgi?id=77008

Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-01-25
Reviewed by Philippe Normand.

After r105686, missing image icons are properly loaded and
shown, causing failures because of incorrect expected results.
These changes properly fix the expectations and subsequently
remove failures.

* platform/gtk/editing/execCommand/insertImage-expected.txt:
* platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
* platform/gtk/fast/block/float/015-expected.txt:
* platform/gtk/fast/borders/rtl-border-05-expected.txt:
* platform/gtk/fast/dom/34176-expected.txt:
* platform/gtk/fast/dom/inner-text-expected.txt:
* platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
* platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
* platform/gtk/fast/hidpi/broken-image-icon-hidpi-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2962-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug56201-expected.txt:
* platform/gtk/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClipping of render layer boundaries does not take page scale into account
commit-queue@webkit.org [Wed, 25 Jan 2012 15:50:53 +0000 (15:50 +0000)]
Clipping of render layer boundaries does not take page scale into account
https://bugs.webkit.org/show_bug.cgi?id=76850

Source/WebCore:

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-25
Reviewed by Simon Fraser.

When inserting render layers into the compositor's overlap map, the
layer boundaries are clipped against any potential parent clip rects.
The clip rects are given in CSS coordinates, while the render layer
boundaries are in scaled CSS coordinates, so the result is incorrect.
This patch scales the clip rects before calculating the intersection.

Test: compositing/overflow/overflow-scaled-descendant-overlapping.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):

LayoutTests:

Added new test to make sure render layers inside clipped containers
are correctly tested for overlap with other layers.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-01-25
Reviewed by Simon Fraser.

* compositing/overflow/overflow-scaled-descendant-overlapping.html: Added.
* platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLinecaps wrong for zero length lines
commit-queue@webkit.org [Wed, 25 Jan 2012 15:31:39 +0000 (15:31 +0000)]
Linecaps wrong for zero length lines
https://bugs.webkit.org/show_bug.cgi?id=71820

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-25
Reviewed by Nikolas Zimmermann.

Total reworking of the method used to draw zero-length linecaps for
SVG. This patch works for all zero length sub-paths.

Source/WebCore:

Tests: svg/stroke/zero-length-path-linecap-rendering.svg
       svg/stroke/zero-length-subpaths-linecap-rendering.svg

* rendering/svg/RenderSVGShape.cpp: Significant refactoring to enable
  new implementation and clarify code.
(WebCore::RenderSVGShape::createShape):
(WebCore::RenderSVGShape::strokeContains):
(WebCore::RenderSVGShape::shouldStrokeZeroLengthSubpath):
(WebCore::RenderSVGShape::zeroLengthSubpathRect):
(WebCore::RenderSVGShape::zeroLengthLinecapPath):
(WebCore::RenderSVGShape::nonScalingStrokePath):
(WebCore::RenderSVGShape::setupNonScalingStrokeTransform):
(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::strokePath):
(WebCore::RenderSVGShape::fillAndStrokePath):
(WebCore::RenderSVGShape::updateCachedBoundaries):
(WebCore::RenderSVGShape::processZeroLengthSubpaths):
* rendering/svg/RenderSVGShape.h: Declarations for new methods.
* rendering/svg/SVGSubpathData.h: Class for finding zero length subpaths.
* svg/SVGPathBuilder.h: Fix typos
* svg/SVGPathConsumer.h: Fix typos
* svg/SVGPathSegListBuilder.h: Fix typos
* svg/SVGPathTraversalStateBuilder.h: Fix typos

LayoutTests:

* platform/chromium/test_expectations.txt: Chromium test expectations
pending new expected images and text.
* platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/mac/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Added.
* platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/mac/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Added.
* platform/mac/test_expectations.txt: Chromium test expectations
pending new expected images and text.
* svg/stroke/zero-length-path-linecap-rendering.svg: Added.
* svg/stroke/zero-length-subpaths-linecap-rendering.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: show memory counter graphs in timeline panel
yurys@chromium.org [Wed, 25 Jan 2012 15:10:31 +0000 (15:10 +0000)]
Web Inspector: show memory counter graphs in timeline panel
https://bugs.webkit.org/show_bug.cgi?id=76843

Timeline panel is extended with several graphs depicting total node count,
number of DOM groups and event listeners. This feature is hidden behind
experimental setting.

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/Inspector.json:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::setDomCountersEnabled):
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::didDispatchEvent):
(WebCore::InspectorTimelineAgent::didWriteHTML):
(WebCore::InspectorTimelineAgent::didFireTimer):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
(WebCore::InspectorTimelineAgent::collectDomCounters):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
* inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::create):
* inspector/TimelineRecordFactory.cpp:
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype.setTopPosition):
(WebInspector.MemoryStatistics.prototype.setSidebarWidth):
(WebInspector.MemoryStatistics.prototype._sidebarResized):
(WebInspector.MemoryStatistics.prototype._updateSize):
(WebInspector.MemoryStatistics.prototype._updateSidebarSize):
(WebInspector.MemoryStatistics.prototype._createCounterSidebarElement):
(WebInspector.MemoryStatistics.prototype.addTimlineEvent):
(WebInspector.MemoryStatistics.prototype._draw.getGroupCount):
(WebInspector.MemoryStatistics.prototype._draw.getNodeCount):
(WebInspector.MemoryStatistics.prototype._draw.getListenerCount):
(WebInspector.MemoryStatistics.prototype._draw):
(WebInspector.MemoryStatistics.prototype._calculateVisibleIndexes):
(WebInspector.MemoryStatistics.prototype._onMouseOver):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
(WebInspector.MemoryStatistics.prototype.visible):
(WebInspector.MemoryStatistics.prototype.show):
(WebInspector.MemoryStatistics.prototype.refresh):
(WebInspector.MemoryStatistics.prototype.hide):
(WebInspector.MemoryStatistics.prototype._setVerticalClip):
(WebInspector.MemoryStatistics.prototype._calculateXValues):
(WebInspector.MemoryStatistics.prototype._drawPolyline):
(WebInspector.MemoryStatistics.prototype._drawBottomBound):
(WebInspector.MemoryStatistics.prototype._clear):
(WebInspector.TimelinePanel.prototype._startSplitterDragging):
(WebInspector.TimelinePanel.prototype._splitterDragging):
(WebInspector.TimelinePanel.prototype._endSplitterDragging):
(WebInspector.TimelinePanel.prototype._setSplitterPosition):
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._toggleMemoryStatistics):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype.sidebarResized):
(WebInspector.TimelinePanel.prototype._refresh):
* inspector/front-end/timelinePanel.css:
(#timeline-memory-splitter):
(#memory-counters-graph):
(#memory-graphs-container):
(#memory-graphs-container .split-view-contents):
(.timeline-marker):
(.memory-counter-sidebar-info):
(.memory-counter-sidebar-info.bottom-border-visible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Cleanup testfonts handling
kbalazs@webkit.org [Wed, 25 Jan 2012 15:03:01 +0000 (15:03 +0000)]
[Qt] Cleanup testfonts handling
https://bugs.webkit.org/show_bug.cgi?id=76068

Reviewed by Simon Hausmann.

Factor test font initialization into it's own file  so test
font users can share the implementation by adding the file
to their build.
Use fonts.conf from the test font directory to not require the
current directory to be the WebKit root.
Fix the -use-test-fonts option of QtTestBrowser by initializing
the fonts earlier, before it is too late (namely before calling
show on the main window).

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
(WebKit::initializeTestFonts):
* DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
* DumpRenderTree/qt/fonts.conf: Removed. No need for this since
we will use the one from the test fonts directory.
* DumpRenderTree/qt/main.cpp:
(main): Fix the ifdefs to make it clear that the code to
set up the Dpi has not been ported to Qt5 yet.
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/main.cpp:
(launcherMain):
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts): Remove the code to set up the Dpi
because it does not work with Qt5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] build-webkit --qt requires a git-svn or SVN checkout.
hausmann@webkit.org [Wed, 25 Jan 2012 14:32:47 +0000 (14:32 +0000)]
[Qt] build-webkit --qt requires a git-svn or SVN checkout.

Reviewed by Tor Arne Vestø.

Don't require it by making svnRevisionForDirectory return "unknown"
instead of bailing out with an error.

* Scripts/VCSUtils.pm:
(svnRevisionForDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed single line test fix after r105865.
loislo@chromium.org [Wed, 25 Jan 2012 14:30:27 +0000 (14:30 +0000)]
Unreviewed single line test fix after r105865.

* inspector/profiler/detailed-heapshots-test.js:
(initialize_DetailedHeapshotTest.):
(initialize_DetailedHeapshotTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/76941> Web Inspector: Remove Unused InspectorFrontendHost.search...
commit-queue@webkit.org [Wed, 25 Jan 2012 14:13:44 +0000 (14:13 +0000)]
<webkit.org/b/76941> Web Inspector: Remove Unused InspectorFrontendHost.search Stub

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-01-25
Reviewed by Pavel Feldman.

* inspector/front-end/InspectorFrontendHostStub.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][ARM] Unreviewed gardening.
ossy@webkit.org [Wed, 25 Jan 2012 13:27:26 +0000 (13:27 +0000)]
[Qt][ARM] Unreviewed gardening.

Skip failing tests, update/add platform specific expected files for passing tests.

* platform/qt-arm/Skipped:
* platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt-arm/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
* platform/qt-arm/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
* platform/qt-arm/svg/batik/text/textOnPath3-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed inspector style fix.
vsevik@chromium.org [Wed, 25 Jan 2012 13:20:41 +0000 (13:20 +0000)]
Unreviewed inspector style fix.

* inspector/front-end/tabbedPane.css:
(.tabbed-pane-header-tab-close-button):
(select.tabbed-pane-header-tabs-drop-down-select):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix incorrect behavior in HTMLCollection.prototype.item().
commit-queue@webkit.org [Wed, 25 Jan 2012 13:04:24 +0000 (13:04 +0000)]
Fix incorrect behavior in HTMLCollection.prototype.item().
https://bugs.webkit.org/show_bug.cgi?id=74468

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-25
Reviewed by Adam Barth.

HTMLCollection.prototype.item("someString") was falling back to
.namedItem("someString"), which is wrong per spec. Also align the
handling of various other types of objects passed as the argument with
the spec and the rest of the browsers.

Source/WebCore:

Test: fast/dom/collection-item.html

* bindings/js/JSHTMLCollectionCustom.cpp: Remove custom implementation of item().
* bindings/v8/custom/V8HTMLCollectionCustom.cpp: Ditto.
* html/HTMLCollection.idl: Remove [Custom] in item(), it's not needed.

LayoutTests:

* fast/dom/collection-item-expected.txt: Added.
* fast/dom/collection-item.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agotable border spacing test for CSS3 calc
mikelawther@chromium.org [Wed, 25 Jan 2012 12:39:03 +0000 (12:39 +0000)]
table border spacing test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76226

Reviewed by Julien Chaffraix.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/table-border-spacing-expected.txt: Added.
* css3/calc/table-border-spacing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r105858.
commit-queue@webkit.org [Wed, 25 Jan 2012 12:36:44 +0000 (12:36 +0000)]
Unreviewed, rolling out r105858.
http://trac.webkit.org/changeset/105858
https://bugs.webkit.org/show_bug.cgi?id=77004

It made many tests crash on Qt (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-25

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::pauseAnimation):
(WebCore::GraphicsLayerTextureMapper::removeAnimation):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
* platform/graphics/texmap/TextureMapperAnimation.cpp: Removed.
* platform/graphics/texmap/TextureMapperAnimation.h: Removed.
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
(WebCore::normalizedAnimationValue):
(WebCore):
(WebCore::TextureMapperNode::applyOpacityAnimation):
(WebCore::solveEpsilon):
(WebCore::solveCubicBezierFunction):
(WebCore::solveStepsFunction):
(WebCore::applyTimingFunction):
(WebCore::TextureMapperNode::applyTransformAnimation):
(WebCore::TextureMapperNode::applyAnimationFrame):
(WebCore::TextureMapperNode::applyAnimation):
(WebCore::TextureMapperNode::hasOpacityAnimation):
(WebCore::TextureMapperNode::hasTransformAnimation):
(WebCore::TextureMapperNode::syncAnimations):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):
(WebCore::TextureMapperAnimation::TextureMapperAnimation):
* platform/graphics/texmap/TextureMapperNode.h:
(TextureMapperAnimation):
(WebCore::TextureMapperAnimation::create):
(WebCore):
(TextureMapperNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening, Skipped list cleanup.
ossy@webkit.org [Wed, 25 Jan 2012 12:35:47 +0000 (12:35 +0000)]
Unreviewed gardening, Skipped list cleanup.

* platform/chromium-mac-leopard/http/tests/security/mixedContent/insecure-video-in-main-frame-expected.txt: Removed.
* platform/chromium-mac-leopard/http/tests/security/mixedContent/redirect-http-to-https-video-in-main-frame-expected.txt: Removed.
* platform/mac/Skipped: Remove non-existent files.
* platform/qt/Skipped: Group new skipped tests.
* platform/qt/editing/deleting/delete-line-011-expected.png:
* platform/qt/editing/deleting/delete-line-011-expected.txt:
* platform/qt/editing/pasteboard/paste-4039777-fix-expected.png: Added.
* platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt: Added.
* platform/qt/fast/block/float/floats-and-text-indent-expected.png:
* platform/qt/fast/block/float/floats-and-text-indent-expected.txt:
* platform/qt/fast/block/float/floats-and-text-indent-rl-expected.png:
* platform/qt/fast/block/float/floats-and-text-indent-rl-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/qt/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/text/unicode-variation-selector.html doesn't pass on Lion
bashi@chromium.org [Wed, 25 Jan 2012 12:32:48 +0000 (12:32 +0000)]
fast/text/unicode-variation-selector.html doesn't pass on Lion
https://bugs.webkit.org/show_bug.cgi?id=76041

Source/WebCore:

Reviewed by Dan Bernstein.

Consumes non-BMP marks in advanceByCombiningCharacterSequence() to take into
account Ideographic variation selectors (these are non-BMP marks).

No new tests. fast/text/unicode-variation-selector.html should pass on Lion.

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::advanceByCombiningCharacterSequence): Use Unicode code point
to iterate the loop which consumes marks.

LayoutTests:

Update the UVS test font to be CoreText-friendly. This updated font is provided by Apple.

Reviewed by Dan Bernstein.

* fast/text/resources/gw432047.ttf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: DetailedHeapSnapshot: adjust node name cell format for the retainers...
loislo@chromium.org [Wed, 25 Jan 2012 12:25:42 +0000 (12:25 +0000)]
Web Inspector: DetailedHeapSnapshot: adjust node name cell format for the retainers tree.
https://bugs.webkit.org/show_bug.cgi?id=76989

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotObjectNode.prototype._postfixObjectCell):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotEdgesProvider.prototype._serialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [InspectorIndexedDB] Pass Database, object stores and indexes meta...
vsevik@chromium.org [Wed, 25 Jan 2012 12:01:49 +0000 (12:01 +0000)]
Web Inspector: [InspectorIndexedDB] Pass Database, object stores and indexes meta information to frontend.
https://bugs.webkit.org/show_bug.cgi?id=76711

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
(WebCore::assertDocument):
(WebCore::assertIDBFactory):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
* inspector/InspectorIndexedDBAgent.h:
(InspectorIndexedDBAgent):
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel):
(WebInspector.IndexedDBModel.prototype._frameDetached):
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype._originAddedToFrame):
(WebInspector.IndexedDBModel.prototype._originRemovedFromFrame):
(WebInspector.IndexedDBModel.prototype._originRemoved):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._databaseRemoved):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNamesForFrame):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.Frame):
(WebInspector.IndexedDBModel.Database):
(WebInspector.IndexedDBModel.ObjectStore):
(WebInspector.IndexedDBModel.ObjectStoreIndex):
(WebInspector.IndexedDBRequestManager.prototype._databaseNamesLoaded):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabase.innerCallback):
(WebInspector.IndexedDBRequestManager.prototype.requestDatabase):
(WebInspector.IndexedDBRequestManager.prototype._databaseLoaded):
(WebInspector.IndexedDBRequestManager.prototype._frameDetached):
(WebInspector.IndexedDBRequestManager.prototype._databaseRemoved):
(WebInspector.IndexedDBRequestManager.prototype._reset):
(WebInspector.IndexedDBRequestManager.DatabaseRequest):
(WebInspector.IndexedDBDispatcher.prototype.databaseNamesLoaded):
(WebInspector.IndexedDBDispatcher.prototype.databaseLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: CodeGeneratorInspector.py: add optional runtime validator
yurys@chromium.org [Wed, 25 Jan 2012 11:54:51 +0000 (11:54 +0000)]
Web Inspector: CodeGeneratorInspector.py: add optional runtime validator
https://bugs.webkit.org/show_bug.cgi?id=76676

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-25
Reviewed by Yury Semikhatsky.

Generator algorithm is redone significantly.

* inspector/CodeGeneratorInspector.py:
(RawTypes.BaseType):
(RawTypes.BaseType.request_raw_internal_runtime_cast):
(RawTypes.BaseType.generate_validate_method_impl):
(RawTypes):
(RawTypes.generate_validate_methods):
(RawTypes.String):
(RawTypes.String.generate_validate_method):
(RawTypes.String.get_raw_validator_call_text):
(RawTypes.Int):
(RawTypes.Int.generate_validate_method):
(RawTypes.Int.get_raw_validator_call_text):
(RawTypes.Number):
(RawTypes.Number.generate_validate_method):
(RawTypes.Number.get_raw_validator_call_text):
(RawTypes.Bool):
(RawTypes.Bool.generate_validate_method):
(RawTypes.Bool.get_raw_validator_call_text):
(RawTypes.Object):
(RawTypes.Object.generate_validate_method):
(RawTypes.Object.get_raw_validator_call_text):
(RawTypes.Any):
(RawTypes.Any.generate_validate_method):
(RawTypes.Any.get_raw_validator_call_text):
(RawTypes.Array):
(RawTypes.Array.generate_validate_method):
(RawTypes.Array.get_raw_validator_call_text):
(TypeBindings.create_named_type_declaration.Helper):
(TypeBindings.create_ad_hoc_type_declaration.Helper):
(TypeBindings.create_type_declaration_.EnumBinding):
(TypeBindings.create_type_declaration_.EnumBinding.resolve_inner):
(TypeBindings.create_type_declaration_.EnumBinding.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.EnumBinding.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator):
(TypeBindings.create_type_declaration_.EnumBinding.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.EnumBinding.get_validator_call_text):
(TypeBindings.create_type_declaration_.EnumBinding.get_in_c_type_text):
(TypeBindings.create_type_declaration_.PlainString):
(TypeBindings.create_type_declaration_.PlainString.resolve_inner):
(TypeBindings.create_type_declaration_.PlainString.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.PlainString.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.PlainString.get_validator_call_text):
(TypeBindings.create_type_declaration_.TypedefString):
(TypeBindings.create_type_declaration_.TypedefString.resolve_inner):
(TypeBindings.create_type_declaration_.TypedefString.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefString.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefString.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.TypedefString.get_validator_call_text):
(TypeBindings.create_type_declaration_.TypedefString.get_in_c_type_text):
(TypeBindings.create_type_declaration_.ClassBinding):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.PropertyData):
(TypeBindings.create_type_declaration_.ClassBinding.resolve_inner.ResolveData):
(TypeBindings.create_type_declaration_.ClassBinding.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.ClassBinding.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator):
(TypeBindings.create_type_declaration_.ClassBinding.get_code_generator.CodeGenerator.generate_type_builder):
(get_validator_call_text):
(get_in_c_type_text):
(AdHocTypeContextImpl):
(AdHocTypeContextImpl.__init__):
(AdHocTypeContextImpl.get_type_name_fix):
(AdHocTypeContextImpl.get_type_name_fix.NameFix):
(AdHocTypeContextImpl.get_type_name_fix.NameFix.output_comment):
(AdHocTypeContextImpl.add_type):
(PlainObjectBinding):
(PlainObjectBinding.resolve_inner):
(PlainObjectBinding.request_user_runtime_cast):
(PlainObjectBinding.request_internal_runtime_cast):
(PlainObjectBinding.get_validator_call_text):
(ArrayBinding):
(ArrayBinding.resolve_inner):
(ArrayBinding.resolve_inner.AdHocTypeContext):
(ArrayBinding.resolve_inner.AdHocTypeContext.get_type_name_fix):
(ArrayBinding.resolve_inner.AdHocTypeContext.get_type_name_fix.NameFix):
(ArrayBinding.resolve_inner.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(ArrayBinding.resolve_inner.AdHocTypeContext.add_type):
(ArrayBinding.resolve_inner.ResolveData):
(ArrayBinding.request_user_runtime_cast):
(ArrayBinding.request_internal_runtime_cast):
(ArrayBinding.get_code_generator):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder):
(ArrayBinding.get_validator_call_text):
(ArrayBinding.get_in_c_type_text):
(RawTypeBinding.resolve_inner):
(RawTypeBinding):
(RawTypeBinding.request_user_runtime_cast):
(RawTypeBinding.request_internal_runtime_cast):
(RawTypeBinding.get_validator_call_text):
(TypeData.get_name):
(TypeData):
(TypeData.get_domain_name):
(resolve_param_type):
(NeedRuntimeCastRequest):
(NeedRuntimeCastRequest.__init__):
(NeedRuntimeCastRequest.acknowledge):
(NeedRuntimeCastRequest.is_acknowledged):
(resolve_all_types):
(resolve_all_types.ForwardListener):
(resolve_all_types.ForwardListener.add_type_data):
(resolve_all_types.ResolveContext):
(Generator):
(Generator.go):
(Generator.process_event):
(Generator.process_event.AdHocTypeContext):
(Generator.process_event.AdHocTypeContext.add_type):
(Generator.process_event.EventForwardListener):
(Generator.process_event.EventForwardListener.add_type_data):
(Generator.process_event.EventResolveContext):
(Generator.process_event.EventGenerateContext):
(Generator.process_types.GenerateContext):
(Generator.process_types.create_type_builder_caller.call_type_builder):
(Generator.process_types.generate_forward_callback):
* inspector/InspectorValues.h:
(WebCore::InspectorObject::size):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreview manual revert of r105843.
antonm@chromium.org [Wed, 25 Jan 2012 11:44:55 +0000 (11:44 +0000)]
Unreview manual revert of r105843.

* fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURL):
* page/SecurityOrigin.cpp:
(WebCore::extractInnerURL):
* platform/KURL.h:
(KURL):
* platform/KURLGoogle.cpp:
(WebCore):
(WebCore::KURLGooglePrivate::setUtf8):
(WebCore::KURLGooglePrivate::setAscii):
(WebCore::KURLGooglePrivate::initProtocolIsInHTTPFamily):
(WebCore::KURLGooglePrivate::copyTo):
(WebCore::encodeWithURLEscapeSequences):
* platform/KURLGooglePrivate.h:
(KURLGooglePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] fast/css/text-overflow-input.html rebaseline
noel.gordon@gmail.com [Wed, 25 Jan 2012 11:44:06 +0000 (11:44 +0000)]
[chromium] fast/css/text-overflow-input.html rebaseline
https://bugs.webkit.org/show_bug.cgi?id=76981

Reviewed by Kent Tamura.

Fixed in r105451

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse maximum image dimension definition from libwebp
noel.gordon@gmail.com [Wed, 25 Jan 2012 11:37:22 +0000 (11:37 +0000)]
Use maximum image dimension definition from libwebp
https://bugs.webkit.org/show_bug.cgi?id=76980

Reviewed by Kent Tamura.

No new tests, no change in behavior.

* platform/image-encoders/skia/WEBPImageEncoder.cpp:
(WebCore::encodePixels): s/WEBP_MAX_DIMENSION/WEBPImageEncoder::MaximumImageDimension/
* platform/image-encoders/skia/WEBPImageEncoder.h:
(): Remove local definition of the maximum webp image dimension

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJPEGDecoder should use imageDecoder colorProfile helpers
noel.gordon@gmail.com [Wed, 25 Jan 2012 11:24:24 +0000 (11:24 +0000)]
JPEGDecoder should use imageDecoder colorProfile helpers
https://bugs.webkit.org/show_bug.cgi?id=76968

Reviewed by Adam Barth.

No new tests. Cover by existing tests, in particular:
  fast/images/ycbcr-with-cmyk-color-profile.html
  fast/images/gray-scale-jpeg-with-color-profile.html
  fast/images/cmyk-jpeg-with-color-profile.html
  fast/images/color-jpeg-with-color-profile.html

* platform/image-decoders/jpeg/JPEGImageDecoder.cpp: white-space removals via Xcode.
(WebCore::readColorProfile):  Use ImageDecoder.h color profile helper routines.
(WebCore::JPEGImageReader::JPEGImageReader):
(WebCore::JPEGImageReader::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Texmap] Divide TextureMapperNode.cpp to 3 files.
noam.rosenthal@nokia.com [Wed, 25 Jan 2012 11:09:45 +0000 (11:09 +0000)]
[Texmap] Divide TextureMapperNode.cpp to 3 files.
https://bugs.webkit.org/show_bug.cgi?id=76660

Reviewed by Kenneth Rohde Christiansen.

Split the animation part of TextureMapperNode out to a separate file, called
TextureMapperAnimation.
Provide a clean interface for that class, that allows separating the internals of the scene
painting from the internals of the animation interpolation.

No new tests. Existing animation tests cover this.

* GNUmakefile.list.am: Added new TextureMapper-related files.
* Target.pri: Added new TextureMapper-related files.
* WebCore.gypi: Added new TextureMapper-related files.
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::pauseAnimation):
(WebCore::GraphicsLayerTextureMapper::removeAnimation):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* platform/graphics/texmap/TextureMapperAnimation.cpp: Added.
* platform/graphics/texmap/TextureMapperAnimation.h: Added.
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::syncCompositingStateSelf):
(WebCore::TextureMapperNode::descendantsOrSelfHaveRunningAnimations):
(WebCore::TextureMapperNode::syncAnimations):
(WebCore::TextureMapperNode::syncAnimationsRecursively):
(WebCore::TextureMapperNode::syncCompositingState):
* platform/graphics/texmap/TextureMapperNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTemporarily disable running the unit tests on the Chromium EWS. These
abarth@webkit.org [Wed, 25 Jan 2012 10:18:40 +0000 (10:18 +0000)]
Temporarily disable running the unit tests on the Chromium EWS.  These
tests don't work properly (see
https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
blocking the EWS.

* Scripts/webkitpy/common/config/ports.py:
(ChromiumPort):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate results.html version of PixelZoomer
abarth@webkit.org [Wed, 25 Jan 2012 09:57:51 +0000 (09:57 +0000)]
Update results.html version of PixelZoomer
https://bugs.webkit.org/show_bug.cgi?id=76965

Reviewed by Ojan Vafai.

Tools:

Improve readability as suggested by Ojan.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:

LayoutTests:

Update result.html with changes from PixelZoomer.js.

* fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] FindController should not assume that ports do not want to highlight text matches
sergio@webkit.org [Wed, 25 Jan 2012 08:54:19 +0000 (08:54 +0000)]
[WK2] FindController should not assume that ports do not want to highlight text matches
https://bugs.webkit.org/show_bug.cgi?id=76921

Reviewed by Darin Adler.

FindController must obey the FindOptionsShowHighlight flag instead
of assuming that ports do not want to highlight search matches.

* Shared/API/c/WKFindOptions.h: added kWKFindOptionsShowHighlight.
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toFindOptions): Ditto.
* Shared/WebFindOptions.h: added FindOptionsShowHighlight.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
carlosgc@webkit.org [Wed, 25 Jan 2012 08:37:01 +0000 (08:37 +0000)]
[GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76899

Reviewed by Martin Robinson.

Source/WebKit2:

* UIProcess/API/gtk/WebKitLoaderClient.cpp: Renamed from
Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp.
(didStartProvisionalLoadForFrame): Use clientInfo instead fo
getting the view from the page.
(didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
(didFailProvisionalLoadWithErrorForFrame): Ditto.
(didCommitLoadForFrame): Ditto.
(didFinishLoadForFrame): Ditto.
(didFailLoadWithErrorForFrame): Ditto.
(didSameDocumentNavigationForFrame): Ditto.
(didReceiveTitleForFrame): Ditto.
(didChangeProgress): Ditto.
(didChangeBackForwardList): Ditto.
(attachLoaderClientToView): Pass WebKitWebView as clientInfo to
callbacks.
* UIProcess/API/gtk/WebKitLoaderClient.h: Added.
* UIProcess/API/gtk/WebKitUIClient.cpp:
(createNewPage): Use clientInfo instead fo getting the view from
the page.
(showPage): Ditto.
(closePage): Ditto.
(runJavaScriptAlert): Ditto.
(runJavaScriptConfirm): Ditto.
(runJavaScriptPrompt): Ditto.
(toolbarsAreVisible): Ditto.
(setToolbarsAreVisible): Ditto.
(menuBarIsVisible): Ditto.
(setMenuBarIsVisible): Ditto.
(statusBarIsVisible): Ditto.
(setStatusBarIsVisible): Ditto.
(isResizable): Ditto.
(setIsResizable): Ditto.
(getWindowFrame): Ditto.
(setWindowFrame): Ditto.
(attachUIClientToView): Pass WebKitWebView as clientInfo to
callbacks.
* UIProcess/API/gtk/WebKitUIClient.h: Remove GObject boilerplate.
* UIProcess/API/gtk/WebKitWebLoaderClient.h: Removed.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed): Remove UIClient and LoaderClient
objects and call attachUIClientToView() and attachLoaderClientToView().
* UIProcess/API/gtk/tests/GNUmakefile.am: Rename
WebKitWebLoaderClient to WebKitLoaderClient.
* UIProcess/API/gtk/tests/TestLoaderClient.cpp: Renamed from
Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp.

Tools:

* gtk/generate-gtkdoc:
(get_webkit2_options): WebKitWebLoaderClient has been renamed to
WebKitLoaderClient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnskip now passing tests after r105813.
ossy@webkit.org [Wed, 25 Jan 2012 08:04:14 +0000 (08:04 +0000)]
Unskip now passing tests after r105813.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening. Skip failing tests.
ossy@webkit.org [Wed, 25 Jan 2012 07:58:18 +0000 (07:58 +0000)]
Unreviewed gardening. Skip failing tests.

* platform/qt-wk2/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Add Qt specific expected results after r105769.
ossy@webkit.org [Wed, 25 Jan 2012 07:49:39 +0000 (07:49 +0000)]
[Qt] Unreviewed gardening. Add Qt specific expected results after r105769.

* platform/qt/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
* platform/qt/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix. Trigger Chromium Mac Release (Perf) on new commits.
rniwa@webkit.org [Wed, 25 Jan 2012 07:01:47 +0000 (07:01 +0000)]
Build fix. Trigger Chromium Mac Release (Perf) on new commits.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<style scoped>: Implement registering of <style scoped> with the scoping element
rolandsteiner@chromium.org [Wed, 25 Jan 2012 06:48:26 +0000 (06:48 +0000)]
<style scoped>: Implement registering of <style scoped> with the scoping element
https://bugs.webkit.org/show_bug.cgi?id=67790

.:

windows.internals updates

Reviewed by Dimitri Glazkov.

* Source/autotools/symbols.filter:

Source/WebCore:

Implement registering of a <style> element with its parent element if the 'scoped' attribute is set.
Update the registration whenever the 'scoped' attribute is changed,
or the <style> element eneters or leaves the tree.

Also, extend windows.internals to allow for testing of the registration ref-counting.

Reviewed by Dimitri Glazkov.

Test: fast/css/style-scoped/registering.html

* WebCore.exp.in:
* dom/Element.cpp:
(WebCore::Element::hasScopedHTMLStyleChild):
(WebCore::Element::numberOfScopedHTMLStyleChildren):
(WebCore::Element::registerScopedHTMLStyleChild):
(WebCore::Element::unregisterScopedHTMLStyleChild):
* dom/Element.h:
* dom/ElementRareData.h:
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::registerScopedHTMLStyleChild):
(WebCore::ElementRareData::unregisterScopedHTMLStyleChild):
(WebCore::ElementRareData::hasScopedHTMLStyleChild):
(WebCore::ElementRareData::numberOfScopedHTMLStyleChildren):
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::HTMLStyleElement):
(WebCore::HTMLStyleElement::~HTMLStyleElement):
(WebCore::HTMLStyleElement::parseMappedAttribute):
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
(WebCore::HTMLStyleElement::insertedIntoDocument):
(WebCore::HTMLStyleElement::removedFromDocument):
(WebCore::HTMLStyleElement::willRemove):
* html/HTMLStyleElement.h:
* testing/Internals.cpp:
(WebCore::Internals::numberOfScopedHTMLStyleChildren):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

Add symbols for windows.internals.numberOfScopedHTMLStyleChildren

Reviewed by Dimitri Glazkov.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Tests that registration of <style scoped> with its parent is performed correctly
in various circumstances.

Reviewed by Dimitri Glazkov.

* fast/css/style-scoped/registering-expected.txt: Added.
* fast/css/style-scoped/registering.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit needs public performance tests running on public bots
rniwa@webkit.org [Wed, 25 Jan 2012 06:08:41 +0000 (06:08 +0000)]
WebKit needs public performance tests running on public bots
https://bugs.webkit.org/show_bug.cgi?id=10266

Reviewed by Adam Barth.

Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunAndUploadPerfTests):
(RunAndUploadPerfTests.start):
(UploadPerfTestResults):
(BuildAndPerfTestFactory):
(BuildAndPerfTestFactory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAttempt to fix Mac build after changeset <http://trac.webkit.org/changeset/105843>
dbates@webkit.org [Wed, 25 Jan 2012 05:27:02 +0000 (05:27 +0000)]
Attempt to fix Mac build after changeset <trac.webkit.org/changeset/105843>
(https://bugs.webkit.org/show_bug.cgi?id=75049)

Don't include NotImplemented.h in KURL.h since NotImplemented.h includes Logging.h, which defines
LOG_CHANNEL_PREFIX to be "Log". And this conflicts with the inclusion of WebKitLogging.h in
WebHTMLView.mm (which would have defined LOG_CHANNEL_PREFIX to be "WebKitLog").

* platform/KURL.h:
(WebCore::KURL::innerURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium test fix.
vsevik@chromium.org [Wed, 25 Jan 2012 05:17:25 +0000 (05:17 +0000)]
Unreviewed chromium test fix.

* src/js/Tests.js:
(.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
(.TestSuite.prototype._waitUntilScriptsAreParsed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: [chromium] Ignore m_skipsDraw in TiledLayerChromium::drawsContent()
vangelis@chromium.org [Wed, 25 Jan 2012 03:28:08 +0000 (03:28 +0000)]
Source/WebCore: [chromium] Ignore m_skipsDraw in TiledLayerChromium::drawsContent()
https://bugs.webkit.org/show_bug.cgi?id=76735

This is to add skipped layers to their RenderSurface's layer list so that they
are considered in the next update. Without this change, m_skipsDraw = false sticks
with the layer for the remainder of its lifetime.

Reviewed by James Robinson.

Tests: Unit test (TiledLayerChromiumTest.cpp)

* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::drawsContent):
* platform/graphics/chromium/TiledLayerChromium.h:
(WebCore::TiledLayerChromium::skipsDraw):

Source/WebKit/chromium: Adding a test to verify that m_skipsDraw gets reset between frames for
tiled layers.
https://bugs.webkit.org/show_bug.cgi?id=76735

Reviewed by James Robinson.

* WebKit.gypi:
* tests/FakeCCLayerTreeHostClient.h: Added.
(WebCore::FakeCCLayerTreeHostClient::updateAnimations):
(WebCore::FakeCCLayerTreeHostClient::layout):
(WebCore::FakeCCLayerTreeHostClient::applyScrollAndScale):
(WebCore::FakeCCLayerTreeHostClient::createLayerTreeHostContext3D):
(WebCore::FakeCCLayerTreeHostClient::didRecreateGraphicsContext):
(WebCore::FakeCCLayerTreeHostClient::didCommitAndDrawFrame):
(WebCore::FakeCCLayerTreeHostClient::didCompleteSwapBuffers):
(WebCore::FakeCCLayerTreeHostClient::scheduleComposite):
* tests/LayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerChromium::skipsDraw):
(WTF::FakeTiledLayerChromium::paintContentsIfDirty):
(WTF::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInvalidate r105697, r105766, r105809 and r105805
haraken@chromium.org [Wed, 25 Jan 2012 02:47:06 +0000 (02:47 +0000)]
Invalidate r105697, r105766, r105809 and r105805
https://bugs.webkit.org/show_bug.cgi?id=76970

Reviewed by Adam Barth.

I've been trying to stop rebuilding .h/.cpp files generated by
unchanged IDLs (bug 76836), but the approach was wrong.
This patch invalidates patches committed in r105697, r105766,
r105809 and r105805.

In r105697, r105766, r105809 and r105805, I modified CodeGenerator*.pm
so that they overwrite .h/.cpp files only when the bytes differ.
By this fix, we were able to stop rebuilding .h/.cpp files that are not
changed. However, the fix has made generate-bindings.pl run for almost
all IDLs every time. The reason is as follows:

(0) Assume that there are A.idl, B.idl and C.idl.

(1) Modify A.idl.
(2) First build.
(3) supplemental_dependency.tmp is updated.
(4) generate-bindings.pl runs for A.idl, B.idl and C.idl.
(5) A.h and A.cpp are updated. B.h, B.cpp, C.h and C.cpp are not updated.

(6) Second build.
(7) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl.
(8) B.h, B.cpp, C.h and C.cpp are not updated.

(9) Third build.
(10) Since B.h, B.cpp, C.h and C.cpp are older than supplemental_dependency.tmp, generate-bindings.pl runs for B.idl and C.idl.
(11) B.h, B.cpp, C.h and C.cpp are not updated.
...

We should fix the bug somehow, but how to fix it is not obvious.
For the time being, this patch invalidates r105697, r105766, r105809
and r105805.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(UpdateFile):
* bindings/scripts/CodeGeneratorCPP.pm:
(WriteData):
* bindings/scripts/CodeGeneratorJS.pm:
(WriteData):
* bindings/scripts/CodeGeneratorObjC.pm:
(WriteData):
* bindings/scripts/CodeGeneratorV8.pm:
(WriteData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd full support for filesystem URLs.
ericu@chromium.org [Wed, 25 Jan 2012 02:20:00 +0000 (02:20 +0000)]
Add full support for filesystem URLs.
https://bugs.webkit.org/show_bug.cgi?id=75049

Reviewed by Adam Barth.

No new tests; existing layout tests cover the basic functionality, and
the new functionality won't be there until Chromium adds it.  This patch
merely enables that, without changing behavior.

* fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURL): Add missing escaping of URL path.

* page/SecurityOrigin.cpp:
(WebCore::extractInnerURL): Use innerURL member, if it's populated.

* platform/KURL.h:
(WebCore::KURL::innerURL): Add innerURL member.

* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::KURLGooglePrivate):
(WebCore::KURLGooglePrivate::operator=):
Add copy constructor and operator=, which are now needed since
m_innerURL needs special handling.
(WebCore::KURLGooglePrivate::setUtf8):
(WebCore::KURLGooglePrivate::setAscii):
Add calls to initInnerURL.
(WebCore::KURLGooglePrivate::initInnerURL):
Add method to init/copy m_innerURL.
(WebCore::KURLGooglePrivate::copyTo):
Handle m_innerURL during copies.
(WebCore::encodeWithURLEscapeSequences):
Unescape %2F ['/'] in paths; it's much more readable, and it's safe.

* platform/KURLGooglePrivate.h:
(WebCore::KURLGooglePrivate::innerURL): Add accessor for new m_innerURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInitializing the browser property of the Bugzilla class takes too long
ojan@chromium.org [Wed, 25 Jan 2012 02:13:51 +0000 (02:13 +0000)]
Initializing the browser property of the Bugzilla class takes too long
https://bugs.webkit.org/show_bug.cgi?id=76960

Reviewed by Adam Barth.

Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
on my Mac Pro.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.__init__):
(Bugzilla._get_browser):
(Bugzilla):
(Bugzilla._set_browser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=76855
barraclough@apple.com [Wed, 25 Jan 2012 02:02:50 +0000 (02:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=76855
Implement a JIT-code aware sampling profiler for JSC

Reviewed by Oliver Hunt.

Add support to MetaAllocator.cpp to track all live handles in a map,
allowing lookup based on any address within the allocation.

* wtf/MetaAllocator.cpp:
(WTF::MetaAllocatorTracker::notify):
(WTF::MetaAllocatorTracker::release):
    - Track live handle objects in a map.
(WTF::MetaAllocator::release):
    - Removed support for handles with null m_allocator (no longer used).
    - Notify the tracker of handles being released.
(WTF::MetaAllocatorHandle::~MetaAllocatorHandle):
    - Moved functionality out into MetaAllocator::release.
(WTF::MetaAllocatorHandle::shrink):
    - Removed support for handles with null m_allocator (no longer used).
(WTF::MetaAllocator::MetaAllocator):
    - Initialize m_tracker.
(WTF::MetaAllocator::allocate):
    - Notify the tracker of new allocations.
* wtf/MetaAllocator.h:
(WTF::MetaAllocatorTracker::find):
    - Lookup a MetaAllocatorHandle based on an address inside the allocation.
(WTF::MetaAllocator::trackAllocations):
    - Register a callback object to track allocation state.
* wtf/MetaAllocatorHandle.h:
    - Remove unused createSelfManagedHandle/constructor.
(WTF::MetaAllocatorHandle::key):
    - Added, for use in RedBlackTree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDeath to JavaScriptGlue.
mrowe@apple.com [Wed, 25 Jan 2012 01:44:57 +0000 (01:44 +0000)]
Death to JavaScriptGlue.

Rubber-stamped by Geoffrey Garen.

.:

* Source/JavaScriptGlue: Removed.
* Source/Makefile: Stop building JavaScriptGlue.

Tools:

* BuildSlaveSupport/build-launcher-app:
(copyNightlyLauncher):
* Scripts/build-webkit:
* Scripts/do-file-rename:
* Scripts/do-webcore-rename:
* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build):
* Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
path in conjunction with a cross-platform path.
(ShouldBuildTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMark test as flaky.
abarth@webkit.org [Wed, 25 Jan 2012 01:38:00 +0000 (01:38 +0000)]
Mark test as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and...
haraken@chromium.org [Wed, 25 Jan 2012 01:19:03 +0000 (01:19 +0000)]
webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
https://bugs.webkit.org/show_bug.cgi?id=75836

Reviewed by David Kilzer.

Previously parser_unittests.pl can just test the returned value of
get_function_line_ranges() in prepare-ChangeLog. This patch fixes
parser_unittests.pl so that it also tests the stdout and stderr of
get_function_line_ranges().

This patch adds css_unittests_warning.css, which contains test cases
for warning messages of the CSS parser of prepare-ChangeLog.

* Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
(captureOutput): Captures the stdout and stderr of a given method.
(convertAbsolutepathToWebKitPath): Converts absolute paths in a given
string to relative paths.

* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
(element1):
(element2):
(element3):
(element4):
():
(element5):
(element6):

* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
Just updated the test results, i.e. added stdout and stderr results.
No essential changes in the test results.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: new-run-webkit-httpd is broken
dpranke@chromium.org [Wed, 25 Jan 2012 01:03:34 +0000 (01:03 +0000)]
webkitpy: new-run-webkit-httpd is broken
https://bugs.webkit.org/show_bug.cgi?id=76963

Reviewed by Adam Barth.

r105674 broke new-run-webkit-httpd, since options.chromium
doesn't exist any more. We didn't catch this because we don't
run the integration tests by default anywhere :(.

* Scripts/new-run-webkit-httpd:
(run):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic pixel zoomer should let you look at every pixel of the image
abarth@webkit.org [Wed, 25 Jan 2012 00:56:23 +0000 (00:56 +0000)]
garden-o-matic pixel zoomer should let you look at every pixel of the image
https://bugs.webkit.org/show_bug.cgi?id=76962

Reviewed by Ojan Vafai.

Previously, you couldn't get up to the right and bottom pixels.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClear some bogus executable bits that r105828 set.
mrowe@apple.com [Wed, 25 Jan 2012 00:27:07 +0000 (00:27 +0000)]
Clear some bogus executable bits that r105828 set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd Linux-specific overrides.
abarth@webkit.org [Wed, 25 Jan 2012 00:22:31 +0000 (00:22 +0000)]
Add Linux-specific overrides.

* platform/chromium-linux/fast/css/min-width-with-spanned-cell-expected.png: Added.
* platform/chromium-linux/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebHTMLView should implement typingAttributes methods to work correctly with the...
enrica@apple.com [Tue, 24 Jan 2012 23:58:42 +0000 (23:58 +0000)]
WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
https://bugs.webkit.org/show_bug.cgi?id=76951
<rdar://problem/9325158>

Source/WebKit/mac:

The Inspector bar calls the typingAttributes methods on the clients that support it
to retrieve the set of attributes representing the style at the selection and uses
this information to update the state of the B, I and U buttons.
If this method is not supported, it defaults to the attributes of the previous
character position, reporting an incorrect state.
This occurs only when we have a caret selection.

Reviewed by Alexey Proskuryakov.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _styleForAttributeChange:]): Removed dead code.
(-[WebHTMLView _updateFontPanel]): Removed comment that doesn't apply anymore.
(-[WebHTMLView typingAttributes]): Added.

Tools:

Added test to verify that WebHTMLView supports the typingAttributes method and that it
works as expected.

Reviewed by Alexey Proskuryakov.

* TestWebKitAPI/Tests/mac/InspectorBar.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in updateFirstLetter() from unnecessary anonymous block
commit-queue@webkit.org [Tue, 24 Jan 2012 23:53:27 +0000 (23:53 +0000)]
Crash in updateFirstLetter() from unnecessary anonymous block
https://bugs.webkit.org/show_bug.cgi?id=72675

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-24
Reviewed by David Hyatt.

Source/WebCore:

There was a problem with anonymous blocks not getting removed when
their only block flow siblings are removed if they also have non-block
flow first-letter siblings (i.e. floats). This patch modifies
RenderBlock::removeChild() to look for this situation and strip out
unnecessary anonymous container blocks if it occurs.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::collapseAnonymousBoxChild): Added
* rendering/RenderBlock.h:
(WebCore::RenderBlock::collapseAnonymousBoxChild): Added

LayoutTests:

Adding a test that cause a div to be removed from between a floating
first-letter block and its remaining text. If the anonymous block is
removed as an immediate consequence of the div removal, this shouldn't
crash.

* fast/css-generated-content/float-first-letter-siblings-convert-to-inline-expected.txt: Added
* fast/css-generated-content/float-first-letter-siblings-convert-to-inline.html: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMark these tests as flaky.
abarth@webkit.org [Tue, 24 Jan 2012 23:51:14 +0000 (23:51 +0000)]
Mark these tests as flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] event.dataTransfer.types should not return "Text" or "URL"
dcheng@chromium.org [Tue, 24 Jan 2012 23:48:23 +0000 (23:48 +0000)]
[chromium] event.dataTransfer.types should not return "Text" or "URL"
https://bugs.webkit.org/show_bug.cgi?id=76218

Source/WebCore:

Per the spec, "Text" and "URL" are special values handled for IE compatibility reasons in
dataTransfer.setData() and dataTransfer.getData(). These values should not be exposed
elsewhere.

Reviewed by Tony Chang.

Test: fast/events/dropzone-005.html

* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::types):
(WebCore::ChromiumDataObject::getData):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::containsURL):
(WebCore::DragData::asURL):
(WebCore::DragData::canSmartReplace):

LayoutTests:

Reviewed by Tony Chang.

* editing/pasteboard/dataTransfer-setData-getData-expected.txt:
* fast/events/dropzone-002.html:
* fast/events/dropzone-005-expected.txt: Added.
* fast/events/dropzone-005.html: Modified from LayoutTests/fast/events/dropzone-002.html.
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
* platform/win-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake DataTransferItemList::length() const.
dcheng@chromium.org [Tue, 24 Jan 2012 23:46:49 +0000 (23:46 +0000)]
Make DataTransferItemList::length() const.
https://bugs.webkit.org/show_bug.cgi?id=76946

Just a const-correctness change.

Reviewed by Tony Chang.

No new tests since no functionality changed.

* dom/DataTransferItemList.h:
(DataTransferItemList):
* platform/chromium/DataTransferItemListChromium.cpp:
(WebCore::DataTransferItemListChromium::length):
* platform/chromium/DataTransferItemListChromium.h:
(DataTransferItemListChromium):
* platform/qt/DataTransferItemListQt.cpp:
(WebCore::DataTransferItemListQt::length):
* platform/qt/DataTransferItemListQt.h:
(DataTransferItemListQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate table image baselines after http://trac.webkit.org/changeset/105775.
abarth@webkit.org [Tue, 24 Jan 2012 23:34:39 +0000 (23:34 +0000)]
Update table image baselines after trac.webkit.org/changeset/105775.

* platform/chromium-mac-leopard/fast/table/027-expected.png:
* platform/chromium-mac-snowleopard/fast/css/min-width-with-spanned-cell-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/027-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/027-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.png:
* platform/chromium-mac-snowleopard/fast/table/027-vertical-expected.txt: Added.
* platform/chromium-win/fast/css/min-width-with-spanned-cell-expected.png: Added.
* platform/chromium-win/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
* platform/chromium-win/fast/table/027-expected.png:
* platform/chromium-win/fast/table/027-vertical-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore tweaks after leviw's updating of Mac baselines.
abarth@webkit.org [Tue, 24 Jan 2012 23:30:56 +0000 (23:30 +0000)]
More tweaks after leviw's updating of Mac baselines.

* platform/chromium-linux-x86/fast/multicol: Removed.
* platform/chromium-linux/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/geometry/rtl-composited-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/visibility/visibility-simple-canvas2d-layer-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/visibility/visibility-simple-webgl-layer-expected.png: Added.
* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
* platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r103245): can't scroll left/up using scrollbar controls of overflowing...
tony@chromium.org [Tue, 24 Jan 2012 23:21:09 +0000 (23:21 +0000)]
REGRESSION(r103245): can't scroll left/up using scrollbar controls of overflowing elements
https://bugs.webkit.org/show_bug.cgi?id=76317

Reviewed by Darin Adler.

Source/WebCore:

Test: scrollbars/scroll-rtl-or-bt-layer.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollInfoAfterLayout): Call scrollToOffsetWithoutAnimation since we're always
scrolling to the just computed offset.

LayoutTests:

* platform/win/Skipped:
* scrollbars/scroll-rtl-or-bt-layer-expected.txt: Added.
* scrollbars/scroll-rtl-or-bt-layer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix all of the builds after r105812.
mrowe@apple.com [Tue, 24 Jan 2012 23:14:32 +0000 (23:14 +0000)]
Fix all of the builds after r105812.

* loader/EmptyClients.h: Move the #include in to the correct #if.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse copying collector for out-of-line JSObject property storage
mhahnenberg@apple.com [Tue, 24 Jan 2012 22:54:31 +0000 (22:54 +0000)]
Use copying collector for out-of-line JSObject property storage
https://bugs.webkit.org/show_bug.cgi?id=76665

Reviewed by Geoffrey Garen.

* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren): Changed to use copyAndAppend whenever the property storage is out-of-line.
Also added a temporary variable to avoid warnings from GCC.
(JSC::JSObject::allocatePropertyStorage): Changed to use tryAllocateStorage/tryReallocateStorage as opposed to
operator new. Also added a temporary variable to avoid warnings from GCC.
* runtime/JSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium][V8] DOMWindow::postMessage crashes if window disassociated with frame.
dslomov@google.com [Tue, 24 Jan 2012 22:52:24 +0000 (22:52 +0000)]
[Chromium][V8] DOMWindow::postMessage crashes if window disassociated with frame.
https://bugs.webkit.org/show_bug.cgi?id=76944.

Reviewed by David Levin.

* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::retrieveWindowForCallingContext):
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange reference of revokeObjectURL in worker-apply-blob-url-to-xhr.html to use webki...
levin@chromium.org [Tue, 24 Jan 2012 22:39:21 +0000 (22:39 +0000)]
Change reference of revokeObjectURL in worker-apply-blob-url-to-xhr.html to use webkitURL.
https://bugs.webkit.org/show_bug.cgi?id=76942

Reviewed by Jian Li.

* fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
(onmessage):
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdated bindings test expectations after my last patch.
ggaren@apple.com [Tue, 24 Jan 2012 22:36:56 +0000 (22:36 +0000)]
Updated bindings test expectations after my last patch.

Not reviewed.

* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
* bindings/scripts/test/JS/JSTestOverridingNameGetter.cpp:
(WebCore::jsTestOverridingNameGetterPrototypeFunctionAnotherFunction):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange dispatchIntent API to pure virtual in FrameLoaderClient.
commit-queue@webkit.org [Tue, 24 Jan 2012 22:36:00 +0000 (22:36 +0000)]
Change dispatchIntent API to pure virtual in FrameLoaderClient.

The Windows compiler needs this to deal with the forward declaration
of WebCore::IntentRequest.
https://bugs.webkit.org/show_bug.cgi?id=76940

Patch by Greg Billock <gbillock@google.com> on 2012-01-24
Reviewed by Adam Barth.

* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::dispatchIntent):
* loader/FrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJSValue::toString() should return a JSString* instead of a UString
ggaren@apple.com [Tue, 24 Jan 2012 22:31:41 +0000 (22:31 +0000)]
JSValue::toString() should return a JSString* instead of a UString
https://bugs.webkit.org/show_bug.cgi?id=76861

Source/JavaScriptCore:

Fixed two failing layout tests after my last patch.

Reviewed by Gavin Barraclough.

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort): Call value() after calling toString(), as
in all other cases.

I missed this case because the JSString* type has a valid operator<,
so the compiler didn't complain.

LayoutTests:

Reviewed by Gavin Barraclough.

Added a unit test for something I got wrong while writing this patch.

* fast/js/add-to-primitive-expected.txt: Added.
* fast/js/add-to-primitive.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCodeGeneratorJS.pm should overwrite the output .h/.cpp
haraken@chromium.org [Tue, 24 Jan 2012 22:24:02 +0000 (22:24 +0000)]
CodeGeneratorJS.pm should overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76922

Reviewed by Darin Adler.

This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorJS.pm so that
it overwrites the output .h/.cpp only if the bytes differ.

No tests. No change in behavior.
I manually confirmed that when I add a new attribute to Element.idl,
the time-stamps of unrelated JS*.h and JS*.cpp do not change.

* bindings/scripts/CodeGeneratorJS.pm:
(WriteData): Used UpdateFileIfChanged().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=76928
bdakin@apple.com [Tue, 24 Jan 2012 22:10:32 +0000 (22:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=76928
Accelerated drawing should force compositing mode
-and corresponding-
<rdar://problem/10697417>

Reviewed by Simon Fraser.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCodeGeneratorCPP.pm should overwrite the output .h/.cpp
haraken@chromium.org [Tue, 24 Jan 2012 22:09:45 +0000 (22:09 +0000)]
CodeGeneratorCPP.pm should overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76926

Reviewed by Adam Barth.

This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorCPP.pm so that
it overwrites the output .h/.cpp only if the bytes differ.

No tests. No change in behavior.
Manually confirm that when you add a new attribute to Element.idl,
the time-stamps of unrelated WebDOM*.h and WebDOM*.cpp do not change.

* bindings/scripts/CodeGeneratorCPP.pm:
(WriteData): Used UpdateFileIfChanged().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r105238.
commit-queue@webkit.org [Tue, 24 Jan 2012 22:04:14 +0000 (22:04 +0000)]
Unreviewed, rolling out r105238.
http://trac.webkit.org/changeset/105238
https://bugs.webkit.org/show_bug.cgi?id=76943

Remove the assert text hack as it served its purpose.
(Requested by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-24

* dom/ActiveDOMObject.cpp:
(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Refactoring] In CodeGeneratorGObject.pm, merge
haraken@chromium.org [Tue, 24 Jan 2012 21:43:43 +0000 (21:43 +0000)]
[Refactoring] In CodeGeneratorGObject.pm, merge
GeneratePrivateHeader() into WriteData()
https://bugs.webkit.org/show_bug.cgi?id=76923

Reviewed by Adam Barth.

This patch merges GeneratePrivateHeader() into WriteData(),
so that all code to output .h/.cpp is managed by WriteData(),
just like other CodeGenerator*.pm does.

No tests. No change in behavior.
Confirm that GTK/GObject build passes.

* bindings/scripts/CodeGeneratorGObject.pm:
(Generate):
(WriteData): Copied GeneratePrivateHeader() to here.
Removed $hasLegacyParen, $hasRealParent and $hasParent
since they are not used.
(GenerateInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd expected results for test introduced in http://trac.webkit.org/changeset/105769
abarth@webkit.org [Tue, 24 Jan 2012 21:38:50 +0000 (21:38 +0000)]
Add expected results for test introduced in trac.webkit.org/changeset/105769

* fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
* fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPut a space between the trac link and ellipsis in sheriffbot rollout message so it...
commit-queue@webkit.org [Tue, 24 Jan 2012 21:38:40 +0000 (21:38 +0000)]
Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
https://bugs.webkit.org/show_bug.cgi?id=76884

Patch by James Robinson <jamesr@chromium.org> on 2012-01-24
Reviewed by Adam Barth.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Rollout.execute):
* Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
(SheriffIRCBotTest.test_rollout):
(SheriffIRCBotTest.test_revert):
(SheriffIRCBotTest.test_multi_rollout):
(SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
(SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
(SheriffIRCBotTest.test_rollout_invalidate_reason):
(test_multi_rollout_invalidate_reason):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agodropzone does not normalize type strings
dcheng@chromium.org [Tue, 24 Jan 2012 21:32:39 +0000 (21:32 +0000)]
dropzone does not normalize type strings
https://bugs.webkit.org/show_bug.cgi?id=76925

Source/WebCore:

Per the HTML spec, we are supposed to normalize types during dropzone processing by
lowercasing them.

Reviewed by Tony Chang.

Tests: fast/events/dropzone-002.html

* dom/Clipboard.cpp:
(WebCore::Clipboard::hasDropZoneType):

LayoutTests:

Reviewed by Tony Chang.

* fast/events/dropzone-002.html: Update layout test to check case normalization as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoQt and Gtk results for tests added in r105775
robert@webkit.org [Tue, 24 Jan 2012 21:31:35 +0000 (21:31 +0000)]
Qt and Gtk results for tests added in r105775

Unreviewed.

* platform/gtk/fast/css/min-width-with-spanned-cell-expected.txt: Added.
* platform/gtk/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
* platform/qt/fast/css/min-width-with-spanned-cell-expected.txt: Added.
* platform/qt/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThe cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
haraken@chromium.org [Tue, 24 Jan 2012 21:27:16 +0000 (21:27 +0000)]
The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
https://bugs.webkit.org/show_bug.cgi?id=75531

Reviewed by David Kilzer.

Previously, the cpp parser of prepare-ChangeLog could not detect a change
outside methods. Consider the following cpp file.

    namespace N {
    int a;     // this change does not appear on ChangeLog.
    class C {
        int b;     // this change does not appear on ChangeLog.
        void f()
        {
            int c;     // this change appears on ChangeLog.
        }
        int d;     // this change does not appear on ChangeLog.
    };
    int e;     // this change does not appear on ChangeLog.
    };

The previous prepare-ChangeLog outputs just methods in which a change is found:
    (N::C::f):

This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
and methods in which a change is found:
    (N):
    (N::C):
    (N::C::f):

* Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_cpp): Modified as described above.

* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
(Class104):
(Class105):
(Class106):
(Class106::func32):
(Class106::func33):
(NameSpace3):
(NameSpace4):
(NameSpace5):
(NameSpace6):
(Class107):
(NameSpace5::NameSpace6::Class107::func34):
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoprepare-ChangeLog outputs warnings for top-level { ... } blocks
haraken@chromium.org [Tue, 24 Jan 2012 21:24:32 +0000 (21:24 +0000)]
prepare-ChangeLog outputs warnings for top-level { ... } blocks
https://bugs.webkit.org/show_bug.cgi?id=75943

Reviewed by David Kilzer.

Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
because it does not distinguish '}' at the end of a subroutine
with '}' at the end of a if or for statement.

foo.pl:
    if (1) {
    }
    for (@v) {
    }

output:
    nested functions found at top-level at foo.pl:2
    nested functions found at top-level at foo.pl:4

This patch fixes the bug.

* Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_perl):
* Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
Added test cases. No change in the test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed: removing WebWorker.h again after r105684.
dslomov@google.com [Tue, 24 Jan 2012 21:22:07 +0000 (21:22 +0000)]
Unreviewed: removing WebWorker.h again after r105684.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agor105674 broke check-webkit-style for chromium's test_expectations.
dpranke@chromium.org [Tue, 24 Jan 2012 21:20:47 +0000 (21:20 +0000)]
r105674 broke check-webkit-style for chromium's test_expectations.

Unreviewed, build fix.

We now need to pass in a platform name of 'chromium' if we want
the chromium port; options.chromium is no longer recognized. I
will follow this patch up with a separate patch that has a test,
but this at least fixes the build.

* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_exepectations_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Refactor GTK's accessibilitity code to be more modular
mario@webkit.org [Tue, 24 Jan 2012 21:18:36 +0000 (21:18 +0000)]
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Reviewed by Martin Robinson.

Don't expose functions for the ATK interfaces in header files.

Expose only the initialization function for each interface, and
use the generic functions from ATK interfaces where needed.

* accessibility/gtk/WebKitAccessibleInterfaceAction.cpp:
(webkitAccessibleActionDoAction): Made this function static.
(webkitAccessibleActionGetNActions): Ditto.
(webkitAccessibleActionGetDescription): Ditto.
(webkitAccessibleActionGetKeybinding): Ditto.
(webkitAccessibleActionGetName): Ditto.
(webkitAccessibleActionInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceAction.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceComponent.cpp:
(webkitAccessibleComponentRefAccessibleAtPoint): Made this function static.
(webkitAccessibleComponentGetExtents): Ditto.
(webkitAccessibleComponentGrabFocus): Ditto.
(webkitAccessibleComponentInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceComponent.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceDocument.cpp:
(webkitAccessibleDocumentGetAttributeValue): Made this function static.
(webkitAccessibleDocumentGetAttributes): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.
(webkitAccessibleDocumentInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceDocument.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceEditableText.cpp:
(webkitAccessibleEditableTextSetRunAttributes): Made this function static.
(webkitAccessibleEditableTextSetTextContents): Ditto.
(webkitAccessibleEditableTextInsertText): Ditto.
(webkitAccessibleEditableTextCopyText): Ditto.
(webkitAccessibleEditableTextCutText): Ditto.
(webkitAccessibleEditableTextDeleteText): Ditto.
(webkitAccessibleEditableTextPasteText): Ditto.
(webkitAccessibleEditableTextInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceEditableText.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.cpp:
(webkitAccessibleHyperlinkImplGetHyperlink): Made this function static.
(webkitAccessibleHyperlinkImplInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceHyperlinkImpl.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceHypertext.cpp:
(webkitAccessibleHypertextGetLink): Made this function static.
(webkitAccessibleHypertextGetNLinks): Ditto.
(webkitAccessibleHypertextGetLinkIndex): Ditto.
(webkitAccessibleHypertextInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceHypertext.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceImage.cpp:
(webkitAccessibleImageGetImagePosition): Made this function static.
(webkitAccessibleImageGetImageDescription): Ditto.
(webkitAccessibleImageGetImageSize): Ditto.
(webkitAccessibleImageInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceImage.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceSelection.cpp:
(webkitAccessibleSelectionAddSelection): Made this function static.
(webkitAccessibleSelectionClearSelection): Ditto.
(webkitAccessibleSelectionRefSelection): Ditto.
(webkitAccessibleSelectionGetSelectionCount): Ditto.
(webkitAccessibleSelectionIsChildSelected): Ditto.
(webkitAccessibleSelectionRemoveSelection): Ditto.
(webkitAccessibleSelectionSelectAllSelection): Ditto.
(webkitAccessibleSelectionInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceSelection.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableRefAt): Made this function static.
(webkitAccessibleTableGetIndexAt): Ditto.
(webkitAccessibleTableGetColumnAtIndex): Ditto.
(webkitAccessibleTableGetRowAtIndex): Ditto.
(webkitAccessibleTableGetNColumns): Ditto.
(webkitAccessibleTableGetNRows): Ditto.
(webkitAccessibleTableGetColumnExtentAt): Ditto.
(webkitAccessibleTableGetRowExtentAt): Ditto.
(webkitAccessibleTableGetColumnHeader): Ditto.
(webkitAccessibleTableGetRowHeader): Ditto.
(webkitAccessibleTableGetCaption): Ditto.
(webkitAccessibleTableGetColumnDescription): Ditto.
(webkitAccessibleTableGetRowDescription): Ditto.
(webkitAccessibleTableInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceTable.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(textForRenderer): Made this function static.
(textForObject): Ditto.
(webkitAccessibleTextGetText): Ditto.
(webkitAccessibleTextGetTextAfterOffset): Ditto.
(webkitAccessibleTextGetTextAtOffset): Ditto.
(webkitAccessibleTextGetTextBeforeOffset): Ditto.
(webkitAccessibleTextGetCharacterAtOffset): Ditto.
(webkitAccessibleTextGetCaretOffset): Ditto.
(webkitAccessibleTextGetRunAttributes): Ditto.
(webkitAccessibleTextGetDefaultAttributes): Ditto.
(webkitAccessibleTextGetCharacterExtents): Ditto.
(webkitAccessibleTextGetRangeExtents): Ditto.
(webkitAccessibleTextGetCharacterCount): Ditto.
(webkitAccessibleTextGetOffsetAtPoint): Ditto.
(webkitAccessibleTextGetNSelections): Ditto.
(webkitAccessibleTextGetSelection): Ditto.
(webkitAccessibleTextAddSelection): Ditto.
(webkitAccessibleTextSetSelection): Ditto.
(webkitAccessibleTextRemoveSelection): Ditto.
(webkitAccessibleTextSetCaretOffset): Ditto.
(webkitAccessibleTextInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceText.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleInterfaceValue.cpp:
(webkitAccessibleValueGetCurrentValue): Made this function static.
(webkitAccessibleValueGetMaximumValue): Ditto.
(webkitAccessibleValueGetMinimumValue): Ditto.
(webkitAccessibleValueSetCurrentValue): Ditto.
(webkitAccessibleValueGetMinimumIncrement): Ditto.
(webkitAccessibleValueInterfaceInit): Moved to the bottom.
* accessibility/gtk/WebKitAccessibleInterfaceValue.h: Removed all
functions but the one for initializing the interface from here.

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetName): Replace call to
webkitAccessibleTextGetText with atk_text_get_text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocheck-webkit-style of the chromium test_expectations.txt file takes too long
scheib@chromium.org [Tue, 24 Jan 2012 21:09:28 +0000 (21:09 +0000)]
check-webkit-style of the chromium test_expectations.txt file takes too long
https://bugs.webkit.org/show_bug.cgi?id=76745

Patch by Ojan Vafai <ojan@chromium.org> on 2012-01-20
Reviewed by Dimitri Glazkov.

When in lint mode, have TestExpectations test all configurations instead
of looping over each configuration. This also has the benefit of making
the error output considerably more concise.

Also, got rid of the double-printing of errors when linting through check-webkit-style.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.lint):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations._report_errors):
(TestExpectations._add_expectations):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_error_nonfatal):
(test_error_on_different_platform):
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.check_test_expectations):
(TestExpectationsChecker.check):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_exepectations_path):
(TestExpectationsTestCase.assert_lines_lint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add null check for ContentLayerChromium::m_delegate back to ContentLayerCh...
jamesr@google.com [Tue, 24 Jan 2012 20:51:34 +0000 (20:51 +0000)]
[chromium] Add null check for ContentLayerChromium::m_delegate back to ContentLayerChromium::drawsContent()
https://bugs.webkit.org/show_bug.cgi?id=76887

Reviewed by Dimitri Glazkov.

A ContentLayerChromium's m_delegate pointer is nulled out when its owning GraphicsLayerChromium is destroyed.
It's possible in some circumstances for this to happen during painting. The null check for this pointer was
erroneously removed from the base class TiledLayerChromium in r105460.

No new tests since we don't know how to reproduce this sort of layer mutation during paint (not for lack of
trying!). Fix based on crash reports from the field.

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::drawsContent):
* platform/graphics/chromium/ContentLayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium Mac Lepoard overrides following the Chromium Mac Snow Leopard baselines.
abarth@webkit.org [Tue, 24 Jan 2012 20:42:52 +0000 (20:42 +0000)]
Chromium Mac Lepoard overrides following the Chromium Mac Snow Leopard baselines.

* platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
* platform/chromium-mac-leopard/http/tests/media/video-buffering-repaints-controls-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r102040): Wrong column widths when row has colspan and unwrappable text
robert@webkit.org [Tue, 24 Jan 2012 20:32:37 +0000 (20:32 +0000)]
REGRESSION (r102040): Wrong column widths when row has colspan and unwrappable text
https://bugs.webkit.org/show_bug.cgi?id=74874

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/css/min-width-with-spanned-cell-fixed.html
       fast/css/min-width-with-spanned-cell.html

A cell with unwrappable text must be as wide as the text is long. If it is a colspan in a table whose
columns are all percent and the width of the span cell is wider than the cells it spans in any other
row then it will squeeze those cells beyond the width required to display their contents.

To fix this ensure that the squeezing of cells within a span respects the minimum width determined by
their contents. The squeezing remains for fixed layout tables as per FF and Opera.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):

LayoutTests:

* fast/css/min-width-with-spanned-cell-expected.png: Added.
* fast/css/min-width-with-spanned-cell-expected.txt: Added.
* fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
* fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
* fast/css/min-width-with-spanned-cell-fixed.html: Added.
* fast/css/min-width-with-spanned-cell.html: Added.
* platform/chromium-linux/fast/table/027-expected.png:
   1 px difference - benign
* platform/chromium-linux/fast/table/027-vertical-expected.png:
   This is a progression - previously the image in the last cell was
   extruding from the table in a 800x600 view.
* platform/chromium-win/fast/table/027-expected.txt:
* platform/chromium-win/fast/table/027-vertical-expected.txt:
* platform/mac/test_expectations.txt: Suppress 027* tests for rebaseline.
* platform/win/test_expectations.txt: ditto
   The 2 tests are skipped on gtk and qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: Split the MediaStream track list into audio/video specific ones.
tommyw@google.com [Tue, 24 Jan 2012 20:29:44 +0000 (20:29 +0000)]
MediaStream API: Split the MediaStream track list into audio/video specific ones.
https://bugs.webkit.org/show_bug.cgi?id=76614

Source/WebCore:

The latest draft of the WebRTC standard have split the MediaStream combined track list
into audio/video specific ones.

Reviewed by Darin Fisher.

Tests for the Media Stream API will be provided by the bug 56587, pending enough landed code.

* mediastream/LocalMediaStream.cpp:
(WebCore::LocalMediaStream::create):
(WebCore::LocalMediaStream::LocalMediaStream):
* mediastream/LocalMediaStream.h:
* mediastream/MediaStream.cpp:
(WebCore::processTrackList):
(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
* mediastream/MediaStream.h:
(WebCore::MediaStream::audioTracks):
(WebCore::MediaStream::videoTracks):
* mediastream/MediaStream.idl:
* mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::kind):
(WebCore::MediaStreamTrack::label):
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled):
(WebCore::MediaStreamTrack::component):
* mediastream/MediaStreamTrack.h:
* mediastream/UserMediaClient.h:
* mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::mediaStreamSourcesQueryCompleted):
(WebCore::UserMediaRequest::succeed):
* mediastream/UserMediaRequest.h:
* platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::queryMediaStreamSources):
(WebCore::MediaStreamCenter::didSetMediaStreamTrackEnabled):
* platform/mediastream/MediaStreamCenter.h:
* platform/mediastream/MediaStreamDescriptor.h:
(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::numberOfAudioComponents):
(WebCore::MediaStreamDescriptor::audioComponent):
(WebCore::MediaStreamDescriptor::numberOfVideoComponents):
(WebCore::MediaStreamDescriptor::videoComponent):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

Source/WebKit/chromium:

Reviewed by Darin Fisher.

* public/WebUserMediaClient.h:
(WebKit::WebUserMediaClient::requestUserMedia):
* public/WebUserMediaRequest.h:
* public/platform/WebMediaStreamDescriptor.h:
* src/UserMediaClientImpl.cpp:
(WebKit::UserMediaClientImpl::requestUserMedia):
* src/UserMediaClientImpl.h:
* src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::sources):
(WebKit::WebMediaStreamDescriptor::audioSources):
(WebKit::WebMediaStreamDescriptor::videoSources):
(WebKit::WebMediaStreamDescriptor::initialize):
* src/WebUserMediaRequest.cpp:
(WebKit::WebUserMediaRequest::requestSucceeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r105738.
commit-queue@webkit.org [Tue, 24 Jan 2012 20:27:06 +0000 (20:27 +0000)]
Unreviewed, rolling out r105738.
http://trac.webkit.org/changeset/105738
https://bugs.webkit.org/show_bug.cgi?id=76930

caused fast/css/getComputedStyle/computed-style-border-
image.html to crash (Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-24

* dom/NamedNodeMap.cpp:
* dom/NamedNodeMap.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::createInlineStyleDecl):
(WebCore::StyledElement::destroyInlineStyleDecl):
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::style):
(WebCore::StyledElement::addSubresourceAttributeURLs):
* dom/StyledElement.h:
(WebCore::StyledElement::inlineStyleDecl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r73385): Marquee with behavior="alternate" is not working
commit-queue@webkit.org [Tue, 24 Jan 2012 20:24:11 +0000 (20:24 +0000)]
REGRESSION (r73385): Marquee with behavior="alternate" is not working
https://bugs.webkit.org/show_bug.cgi?id=64230

Patch by Parag Radke <nrqv63@motorola.com> on 2012-01-24
Reviewed by Simon Fraser.

Source/WebCore:

This patch gives correct content width for marquee, which computes
correct start position to scroll marquee.

Test: fast/html/marquee-alternate.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computePreferredLogicalWidths):
We need(style()->marqueeBehavior() != MALTERNATE) check as we always need the marquee's
actual content width to compute the initial/end position in case of 'MALTERNATE'.
So we need to calculate the logical width in Alternate case even if fixed width is specified
as content has to animate between renderBox().right().x() - contentWidth() and
renderBox().left().x() + contentWidth().

* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
Using PreferredLogicalWidth in place of LayoutOverflow for calculating correct content width.

LayoutTests:

Added a test case to check marquee alternate behavior with fixed width.

* fast/html/marquee-alternate-expected.txt: Added.
* fast/html/marquee-alternate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenderInline: Skip caching the computed line height.
kling@webkit.org [Tue, 24 Jan 2012 20:22:00 +0000 (20:22 +0000)]
RenderInline: Skip caching the computed line height.
<http://webkit.org/b/76929>

Reviewed by David Hyatt.

Stop caching the computed line height on RenderInline and make retrieving it from
RenderStyle slightly cheaper, freeing up 4 bytes per RenderInline instance.
This appears to be mostly performance neutral, I don't get more than the occasional
sample hit when instrumenting heavier web pages.

This reduces memory consumption by 228 kB (both 32/64-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::styleDidChange):
(WebCore::RenderInline::lineHeight):
* rendering/RenderInline.h:
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::computedLineHeight):

    Optimize computedLineHeight() to mitigate some of the damage of calling
    it more often.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocheck-webkit-style of the chromium test_expectations.txt file takes too long
ojan@chromium.org [Tue, 24 Jan 2012 20:10:27 +0000 (20:10 +0000)]
check-webkit-style of the chromium test_expectations.txt file takes too long
https://bugs.webkit.org/show_bug.cgi?id=76745

Reviewed by Dimitri Glazkov.

When in lint mode, have TestExpectations test all configurations instead
of looping over each configuration. This also has the benefit of making
the error output considerably more concise.

Also, got rid of the double-printing of errors when linting through check-webkit-style.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.lint):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations._report_errors):
(TestExpectations._add_expectations):
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(test_parse_error_nonfatal):
(test_error_on_different_platform):
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker.check_test_expectations):
(TestExpectationsChecker.check):
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_exepectations_path):
(TestExpectationsTestCase.assert_lines_lint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash when rendering -webkit-column-span.
inferno@chromium.org [Tue, 24 Jan 2012 20:04:52 +0000 (20:04 +0000)]
Crash when rendering -webkit-column-span.
https://bugs.webkit.org/show_bug.cgi?id=73265

Reviewed by David Hyatt.

Source/WebCore:

This patch addresses 2 problems causing crashes in multi-column layout
1. Trying to render -webkit-column-span for :before, :after caused
   re-entrancy in updateBeforeAfterContent while working on splitFlow.
2. Cloning a block which has its :before, :after content not added yet,
   caused issues because cloneBlock will definitely have its :before,
   :after content created when setStyle() is called. So, we would
   overwrite cloneBlock with a wrong childrenInline value.

Tests: fast/multicol/clone-block-children-inline-mismatch-crash.html
       fast/multicol/span/generated-child-split-flow-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):
(WebCore::RenderBlock::columnsBlockForSpanningElement):

LayoutTests:

* fast/multicol/clone-block-children-inline-mismatch-crash-expected.txt: Added.
* fast/multicol/clone-block-children-inline-mismatch-crash.html: Added.
* fast/multicol/span/generated-child-split-flow-crash.html: Added.
* platform/mac-snowleopard/fast/multicol/span: Added.
* platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.png: Added.
* platform/mac-snowleopard/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncorrect positioning of floating pseudo-elements in table captions
robert@webkit.org [Tue, 24 Jan 2012 19:52:10 +0000 (19:52 +0000)]
Incorrect positioning of floating pseudo-elements in table captions
https://bugs.webkit.org/show_bug.cgi?id=76664

Reviewed by Julien Chaffraix.

Source/WebCore:

Tests: fast/table/caption-encloses-overhanging-float-expected.html
       fast/table/caption-encloses-overhanging-float.html

Allow table captions to expand and enclose overhanging floats. When performing
layout on a caption ensure that its logical top is set so that it does not mistakenly
conclude that floats in a previous sibling are intruding into it when they're not.

Mostly diagnosed by Abhishek Arya.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::expandsToEncloseOverhangingFloats): add table captions to the list
 that can enclosed overhanging floats.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layoutCaption): use the best available approximation of the caption's logical
 top offset before laying it out.
(WebCore::RenderTable::layout):
* rendering/RenderTable.h:

LayoutTests:

* fast/table/caption-encloses-overhanging-float-expected.html: Added.
* fast/table/caption-encloses-overhanging-float.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIn CodeGeneratorV8.pm, overwrite the output .h/.cpp
haraken@chromium.org [Tue, 24 Jan 2012 19:40:27 +0000 (19:40 +0000)]
In CodeGeneratorV8.pm, overwrite the output .h/.cpp
only if the bytes differ
https://bugs.webkit.org/show_bug.cgi?id=76920

Reviewed by Darin Adler.

This is one of steps to stop rebuilding .h/.cpp files
generated by unchanged IDLs (bug 76836).
This patch makes a change on CodeGeneratorV8.pm so that
it overwrites the output .h/.cpp only if the bytes differ.

No tests. No change in behavior.
I manually confirmed that when I add a new attribute to Element.idl,
the time-stamps of unrelated V8*.h and V8*.cpp do not change.

* bindings/scripts/CodeGeneratorV8.pm:
(WriteData): Used UpdateFileIfChanged().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSimilar to the change below, this patch creates Chromium Mac specific
abarth@webkit.org [Tue, 24 Jan 2012 19:39:28 +0000 (19:39 +0000)]
Similar to the change below, this patch creates Chromium Mac specific
baselines after the Apple Mac changes in
http://trac.webkit.org/changeset/105753.

* fast/block/positioning/028-expected.txt: Added.
* fast/block/positioning/031-expected.txt: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-tiled-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/positioning/028-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/block/positioning/031-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/height-percent-test-vertical-expected.png: Added.
* platform/chromium-mac-snowleopard/http/tests/media/video-buffering-repaints-controls-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug650-expected.png: Added.
* platform/gtk/fast/block/positioning/028-expected.txt: Removed.
* platform/gtk/fast/block/positioning/031-expected.txt: Removed.
* platform/mac/fast/block/positioning/028-expected.txt: Removed.
* platform/mac/fast/block/positioning/031-expected.txt: Removed.
* platform/qt/fast/block/positioning/028-expected.txt: Removed.
* platform/qt/fast/block/positioning/031-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix for Qt.
alexis.menard@openbossa.org [Tue, 24 Jan 2012 19:26:14 +0000 (19:26 +0000)]
Unreviewed build fix for Qt.

* WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
(WebKit::LayerTreeHostQt::showDebugBorders):
(WebKit::LayerTreeHostQt::showRepaintCounter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Refactoring] Remove finish() from all CodeGenerator*.pm
haraken@chromium.org [Tue, 24 Jan 2012 19:25:00 +0000 (19:25 +0000)]
[Refactoring] Remove finish() from all CodeGenerator*.pm
https://bugs.webkit.org/show_bug.cgi?id=76918

Reviewed by Darin Adler.

Now finish() is empty in all CodeGenerator*.pm. This patch removes them.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(ProcessDocument):
* bindings/scripts/CodeGeneratorCPP.pm:
* bindings/scripts/CodeGeneratorGObject.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agopageCacheSupportsPlugins should default to true on WebKit1
benjamin@webkit.org [Tue, 24 Jan 2012 19:07:34 +0000 (19:07 +0000)]
pageCacheSupportsPlugins should default to true on WebKit1
https://bugs.webkit.org/show_bug.cgi?id=76891

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-24
Reviewed by Joseph Pecoraro.

The default was left out of r102619 by accident.

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105760 268f45cc-cd09-0410-ab3c-d52691b4dbfc