WebKit-https.git
7 years ago[Qt] Fix Qt-Mac build after libxml patch
noam.rosenthal@nokia.com [Thu, 19 Apr 2012 13:11:39 +0000 (13:11 +0000)]
[Qt] Fix Qt-Mac build after libxml patch
https://bugs.webkit.org/show_bug.cgi?id=84313

Use direct include/library paths instead of PKGCONFIG when on Mac.

Reviewed by Simon Hausmann.

No new tests, build fix.

* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: No response body available for cached resource requests with error...
vsevik@chromium.org [Thu, 19 Apr 2012 12:08:39 +0000 (12:08 +0000)]
Web Inspector: No response body available for cached resource requests with error status codes.
https://bugs.webkit.org/show_bug.cgi?id=84265

Source/WebCore:

Reviewed by Pavel Feldman.

InspectorResourceAgent now saves failed subresource request response body in its cache.
Saved data is shown on front-end.

Test: http/tests/inspector/network/network-image-404.html

* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::httpStatusCode):
(WebCore):
* inspector/NetworkResourcesData.h:
(WebCore::NetworkResourcesData::ResourceData::httpStatusCode):
(WebCore::NetworkResourcesData::ResourceData::setHTTPStatusCode):
(ResourceData):
(NetworkResourcesData):
* inspector/front-end/RequestView.js:
(WebInspector.RequestView.hasTextContent):

LayoutTests:

* http/tests/inspector/network/network-image-404-expected.txt: Added.
* http/tests/inspector/network/network-image-404.html: Added.
* http/tests/inspector/network/resources/404.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Gardening. Skip failing reftest after 114574.
kkristof@inf.u-szeged.hu [Thu, 19 Apr 2012 11:55:10 +0000 (11:55 +0000)]
[Qt] Gardening. Skip failing reftest after 114574.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-04-19
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Always use the AnimationFrameRateController for accelerated animations
commit-queue@webkit.org [Thu, 19 Apr 2012 11:44:21 +0000 (11:44 +0000)]
[BlackBerry] Always use the AnimationFrameRateController for accelerated animations
https://bugs.webkit.org/show_bug.cgi?id=84323

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-19
Reviewed by Antonio Gomes.

PR 150750
Regardless of whether there's a WebPageCompositorClient, we want the
AnimationFrameRateController to manage animation frames.
Reviewed internally by Andrew Lo.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
* Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: reuse ParsedUrl in the UISourceCode
pfeldman@chromium.org [Thu, 19 Apr 2012 11:39:50 +0000 (11:39 +0000)]
Web Inspector: reuse ParsedUrl in the UISourceCode
https://bugs.webkit.org/show_bug.cgi?id=84326

Reviewed by Yury Semikhatsky.

Source/WebCore:

Migrated UISourceCode to ParsedURL, moved the displayName logic into its only client:
TabbedEditorContainer.

* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.SourceMapParser.prototype._canonicalizeURL):
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
* inspector/front-end/ResourceUtils.js:
(WebInspector.ParsedURL):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._getOrCreateFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.get parsedURL):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/ui-source-code-display-name.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Build fix after r114575
commit-queue@webkit.org [Thu, 19 Apr 2012 09:08:18 +0000 (09:08 +0000)]
[CMake] Build fix after r114575
https://bugs.webkit.org/show_bug.cgi?id=84322

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-19
Reviewed by Simon Hausmann.

Build fix, adding WTF when linking jsc shell.

* shell/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOptimize for DARWIN in DirectConvolver::process()
commit-queue@webkit.org [Thu, 19 Apr 2012 07:20:36 +0000 (07:20 +0000)]
Optimize for DARWIN in DirectConvolver::process()
https://bugs.webkit.org/show_bug.cgi?id=80256

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-04-19
Reviewed by Chris Rogers.

* platform/audio/DirectConvolver.cpp:
(WebCore::DirectConvolver::process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, add expected.txt for cookies-wrong-domain-rejected-result.php .
toyoshim@chromium.org [Thu, 19 Apr 2012 07:07:22 +0000 (07:07 +0000)]
Unreviewed, add expected.txt for cookies-wrong-domain-rejected-result.php .

* http/tests/security/cookies/cookies-wrong-domain-rejected-result-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CG] ImageBuffer::toDataURL: Remove alpha stuffing loop when encoding to JPEG
noel.gordon@gmail.com [Thu, 19 Apr 2012 06:56:22 +0000 (06:56 +0000)]
[CG] ImageBuffer::toDataURL: Remove alpha stuffing loop when encoding to JPEG
https://bugs.webkit.org/show_bug.cgi?id=84319

Reviewed by Eric Seidel.

No change in behavior. Covered by existing canvas 2d and 3d tests:

  canvas/philip/tests/toDataURL.jpeg.alpha.html
  fast/canvas/webgl/premultiplyalpha-test.html

* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL): Remove the alpha stuffing loop and instead,
make JPEG encoder ignore the alpha channel (kCGImageAlphaNoneSkipLast).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnrevieded, rebaseline svg/as-image/img-preserveAspectRatio-support-1.html
toyoshim@chromium.org [Thu, 19 Apr 2012 06:35:57 +0000 (06:35 +0000)]
Unrevieded, rebaseline svg/as-image/img-preserveAspectRatio-support-1.html

* platform/chromium-mac-leopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnecessary rounding/conversions in RenderBoxModelObject
eae@chromium.org [Thu, 19 Apr 2012 05:40:08 +0000 (05:40 +0000)]
Remove unnecessary rounding/conversions in RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=84288

Reviewed by Eric Seidel.

No new tests, no change in functionality.

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBoxShadow):
Remove unnecessary pixelSnapping logic and casts in paintBoxShadow as
shadow rects are now int based.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Parsed Cookie's m_hasDefaultDomain is not needed.
commit-queue@webkit.org [Thu, 19 Apr 2012 05:21:50 +0000 (05:21 +0000)]
[BlackBerry] Parsed Cookie's m_hasDefaultDomain is not needed.
https://bugs.webkit.org/show_bug.cgi?id=82830

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-18
Reviewed by George Staikos.

Source/WebCore:

RFC 2965
3.2.2
Domain = value
If an explicitly specified value does not start with a dot, the user agent supplies
a leading dot.
3.3.1
Domain  Defaults to the effective request-host.  (Note that because there is no dot
at the beginning of effective request-host, the default Domain can only domain-match
itself.)

The first char can show the difference even though it is from the cookie database.
But m_hasDefaultDomain is set to false if the cookie is from database although the
domain is host as a default value. So m_hasDefaultDomain sometimes is wrong.

In sum,  we shouldn't use m_hasDefaultDomain.

Test: http/tests/security/cookies/cookies-wrong-domain-rejected.php

* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::shouldRejectForSecurityReason):
* platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::parseOneCookie):
* platform/blackberry/ParsedCookie.cpp:
(WebCore::ParsedCookie::ParsedCookie):
* platform/blackberry/ParsedCookie.h:
(ParsedCookie):

LayoutTests:

* http/tests/security/cookies/cookies-wrong-domain-rejected-expected.txt: Added.
* http/tests/security/cookies/cookies-wrong-domain-rejected-result.php: Added.
* http/tests/security/cookies/cookies-wrong-domain-rejected.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Consolidate adjustTextRenderMode copypasta into Skia context
enne@google.com [Thu, 19 Apr 2012 04:51:19 +0000 (04:51 +0000)]
[chromium] Consolidate adjustTextRenderMode copypasta into Skia context
https://bugs.webkit.org/show_bug.cgi?id=83840

Reviewed by James Robinson.

The same logic to decide when to make text use LCD rendering is copy
and pasted in all the different font classes. It seems like this
should live in a single place.

* platform/graphics/harfbuzz/FontHarfBuzz.cpp:
(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):
* platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::drawGlyphs):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::adjustTextRenderMode):
(WebCore):
(WebCore::PlatformContextSkia::couldUseLCDRenderedText):
* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::setupPaintForFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium/mac] Fix build.
thakis@chromium.org [Thu, 19 Apr 2012 04:45:40 +0000 (04:45 +0000)]
[chromium/mac] Fix build.
https://bugs.webkit.org/show_bug.cgi?id=84314

Unreviewed, build fix after http://trac.webkit.org/changeset/114604

* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSplit SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker...
hbono@chromium.org [Thu, 19 Apr 2012 03:51:56 +0000 (03:51 +0000)]
Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
https://bugs.webkit.org/show_bug.cgi?id=83748

Reviewed by Ryosuke Niwa.

Source/WebCore:

The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and  didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)

Test: platform/chromium/editing/spelling/delete-misspelled-word.html

* WebCore.exp.in: Replaced SpellChecker::didCheck with SpellChecker::didCheckSucceeded.
* editing/SpellChecker.cpp:
(WebCore::SpellChecker::didCheckSucceeded): Added.
(WebCore):
(WebCore::SpellChecker::didCheckCanceled): Added.
* editing/SpellChecker.h:
(SpellChecker): Added didCheckSucceeded and didCheckCanceled. Also changed didCheck to a private function.

Source/WebKit/chromium:

This change adds a new API WebTextCheckingCompletion::didCancelCheckingText(),
which encapsulates SpellChecker::didCheckCanceled() and implements it so
Chromium can use it.

* public/WebTextCheckingCompletion.h:
(WebKit::WebTextCheckingCompletion::didCancelCheckingText):
* src/WebTextCheckingCompletionImpl.cpp:
(WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
(WebKit):
(WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
* src/WebTextCheckingCompletionImpl.h:
(WebTextCheckingCompletionImpl):

Source/WebKit/mac:

This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckSucceeded() because didCheck has been split into
didCheckSucceeded(0 and didCheckCanceled().

* WebCoreSupport/WebEditorClient.mm:
(-[WebEditorSpellCheckResponder perform]): Replaced didCheck with didCheckSucceeded.

Tools:

This change replaces a call for SpellChecker::didCheck() with one for
SpellChecker::didCheckCenceled() because didCheck() has been split into
didCheckSucceeded() and didCheckCanceled().

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.

LayoutTests:

The current SpellChecker::didCheck() does not delete existing markers. It causes
a problem that it leaves misspelled markers when a spellchecker client finishes
checking text successfully. This change splits this function to didCheckSucceeded()
and  didCheckCanceled() so the SpellChecker class can delete existing markers
when its client finishes checking text successfully. (We do not have to erase
existing markers when the client needs to cancel a text-check request.)

* platform/chromium/editing/spelling/delete-misspelled-word-expected.txt: Added.
* platform/chromium/editing/spelling/delete-misspelled-word.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Convert WebPluginContainerImpl over to use WebExternalTextureLayer
jamesr@google.com [Thu, 19 Apr 2012 02:48:16 +0000 (02:48 +0000)]
[chromium] Convert WebPluginContainerImpl over to use WebExternalTextureLayer
https://bugs.webkit.org/show_bug.cgi?id=84120

Reviewed by Adrienne Walker.

Source/Platform:

This adds support for IO surface backed WebExternalTextureLayer, used by CoreAnimation plugins on OS X and moves
some functionality used by multiple WebLayer subclasses up to the base class.

* chromium/public/WebContentLayer.h:
(WebContentLayer):
* chromium/public/WebExternalTextureLayer.h:
(WebCore):
(WebExternalTextureLayer):
* chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::unwrap):

Source/WebCore:

This renames PluginLayerChromium -> TextureLayerChromium since it is now used only as the implementation of
WebExternalTextureLayer and cleans it up slightly.

* WebCore.gypi:
* platform/graphics/chromium/TextureLayerChromium.cpp: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.cpp.
(WebCore):
(WebCore::TextureLayerChromium::create):
(WebCore::TextureLayerChromium::TextureLayerChromium):
(WebCore::TextureLayerChromium::createCCLayerImpl):
(WebCore::TextureLayerChromium::drawsContent):
(WebCore::TextureLayerChromium::setTextureId):
(WebCore::TextureLayerChromium::setFlipped):
(WebCore::TextureLayerChromium::setUVRect):
(WebCore::TextureLayerChromium::setIOSurfaceProperties):
(WebCore::TextureLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/TextureLayerChromium.h: Renamed from Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h.
(WebCore):
(TextureLayerChromium):
(WebCore::TextureLayerChromium::flipped):
(WebCore::TextureLayerChromium::uvRect):

Source/WebKit/chromium:

This ports WebPluginContainerImpl over to use WebExternalTextureLayer instead of directly using a *LayerChromium
type for better layering and code sharing. The changes to WebPluginContainerImpl are fairly straightforward.  In
addition to renames I also moved some state tracking into WPCI instead of having it exposed on the interface. I
also removed the WebExternalTextureLayerImpl intermediate class since it wasn't doing anything useful.

* WebKit.gyp:
* WebKit.gypi:
* src/WebContentLayer.cpp:
* src/WebExternalTextureLayer.cpp:
(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::setIOSurfaceProperties):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::flipped):
(WebKit::WebExternalTextureLayer::setUVRect):
(WebKit::WebExternalTextureLayer::uvRect):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
* src/WebExternalTextureLayerImpl.cpp: Removed.
* src/WebExternalTextureLayerImpl.h: Removed.
* src/WebLayer.cpp:
(WebKit::WebLayer::invalidateRect):
(WebKit):
(WebKit::WebLayer::invalidate):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::setBackingTextureId):
(WebKit::WebPluginContainerImpl::setBackingIOSurfaceId):
(WebKit::WebPluginContainerImpl::commitBackingTexture):
(WebKit::WebPluginContainerImpl::setOpaque):
(WebKit::WebPluginContainerImpl::platformLayer):
(WebKit::WebPluginContainerImpl::WebPluginContainerImpl):
* src/WebPluginContainerImpl.h:
(WebCore):
(WebPluginContainerImpl):
* tests/WebExternalTextureLayerImplTest.cpp: Removed.
* tests/WebLayerTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpose attack, release as DynamicsCompressorNode's attributes.
commit-queue@webkit.org [Thu, 19 Apr 2012 02:32:43 +0000 (02:32 +0000)]
Expose attack, release as DynamicsCompressorNode's attributes.
https://bugs.webkit.org/show_bug.cgi?id=81221

Patch by Raymond Toy <rtoy@google.com> on 2012-04-18
Reviewed by Chris Rogers.

Source/WebCore:

* Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
(WebCore::DynamicsCompressorNode::process):
* Modules/webaudio/DynamicsCompressorNode.h:
(WebCore::DynamicsCompressorNode::attack):
(WebCore::DynamicsCompressorNode::releaseTime):
(DynamicsCompressorNode):
* Modules/webaudio/DynamicsCompressorNode.idl: Add attack and
release attributes.
* bindings/scripts/CodeGeneratorObjC.pm:
(SkipAttribute): Skip release()
(GenerateHeader): Call SkipAttribute for getters/setters.
* platform/audio/DynamicsCompressor.h:
(DynamicsCompressor):

LayoutTests:

* webaudio/dynamicscompressor-basic-expected.txt:
* webaudio/dynamicscompressor-basic.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix failure in test-webkitpy after r114583.
dpranke@chromium.org [Thu, 19 Apr 2012 02:02:39 +0000 (02:02 +0000)]
Fix failure in test-webkitpy after r114583.

Unreviewed, build fix.

Updating the call site in r114583 w/o updating the test caused
the test to fail. Somehow I forgot to run the unit tests :(.

* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_crash_log):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Simplify occlusion tracker API by passing layer iterator data
danakj@chromium.org [Thu, 19 Apr 2012 02:01:25 +0000 (02:01 +0000)]
[chromium] Simplify occlusion tracker API by passing layer iterator data
https://bugs.webkit.org/show_bug.cgi?id=84088

Reviewed by Adrienne Walker.

Source/WebCore:

Previously three methods lived in the API and you needed to call the
appropriate method (with different amounts of data) depending on what
the current layer iterator was representing.

This makes usage of the occlusion tracker simpler to read and harder
to mess up, by just passing in the layer iterator at each step of the
iteration process.

Covered by existing tests.

* platform/graphics/chromium/cc/CCLayerIterator.h:
(WebCore):
(CCLayerIteratorPosition):
(CCLayerIterator):
(WebCore::CCLayerIterator::operator const CCLayerIteratorPosition<LayerType>):
* platform/graphics/chromium/cc/CCLayerTilingData.cpp:
(WebCore::CCLayerTilingData::opaqueRegionInLayerRect):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::enterLayer):
(WebCore):
(WebCore::::leaveLayer):
* platform/graphics/chromium/cc/CCOcclusionTracker.h:
(CCOcclusionTrackerBase):

Source/WebKit/chromium:

* tests/CCOcclusionTrackerTest.cpp:
(CCOcclusionTrackerTestMainThreadTypes):
(CCOcclusionTrackerTestImplThreadTypes):
(WebKitTests::CCOcclusionTrackerTest::CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::calcDrawEtc):
(CCOcclusionTrackerTest):
(WebKitTests::CCOcclusionTrackerTest::enterLayer):
(WebKitTests::CCOcclusionTrackerTest::leaveLayer):
(WebKitTests::CCOcclusionTrackerTest::visitLayer):
(WebKitTests::CCOcclusionTrackerTest::enterContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::leaveContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::visitContributingSurface):
(WebKitTests::CCOcclusionTrackerTest::resetLayerIterator):
(WebKitTests::CCOcclusionTrackerTestIdentityTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestTranslatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestChildInRotatedChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestVisitTargetTwoTimes::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceRotatedOffAxis::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithTwoOpaqueChildren::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblings::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOverlappingSurfaceSiblingsWithTwoTransforms::runMyTest):
(WebKitTests::CCOcclusionTrackerTestFilters::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOutsideChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectPartlyOverChild::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestScreenScissorRectOverNothing::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerScissorRectForLayerOffOrigin::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTestOpaqueContentsRegionNonEmpty::runMyTest):
(WebKitTests::CCOcclusionTrackerTest3dTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransform::runMyTest):
(WebKitTests::CCOcclusionTrackerTestPerspectiveTransformBehindCamera::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesToParent::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceOcclusionTranslatesWithClipping::runMyTest):
(WebKitTests::CCOcclusionTrackerTestReplicaOccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceWithReplicaUnoccluded::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceAndReplicaOccludedDifferently::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfClippingSurface::runMyTest):
* tests/CCQuadCullerTest.cpp:
(WebCore):
(WebCore::makeLayer):
(WebCore::appendQuads):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Thu, 19 Apr 2012 01:47:42 +0000 (01:47 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt: Mark new fast/table test as failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add canBeginFrame state to CCSchedulerStateMachine to suppress initializat...
jamesr@google.com [Thu, 19 Apr 2012 01:30:32 +0000 (01:30 +0000)]
[chromium] Add canBeginFrame state to CCSchedulerStateMachine to suppress initialization before our surface is available
https://bugs.webkit.org/show_bug.cgi?id=84301

Reviewed by Adrienne Walker.

Source/WebCore:

If our composited surface isn't ready yet, then the compositor may initialize in a state where the first
makeContextCurrent() fails. This adds a new state to the scheduler that we can use to suppress initialization
until we get notified that the surface is ready. I'll add the plumbing for actually notifying in a follow-up.

Updated CCSchedulerTest / CCSchedulerStateMachineTest unit tests.

* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::setCanBeginFrame):
(WebCore):
* platform/graphics/chromium/cc/CCScheduler.h:
(CCScheduler):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
(WebCore::CCSchedulerStateMachine::CCSchedulerStateMachine):
(WebCore::CCSchedulerStateMachine::nextAction):
* platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
(WebCore::CCSchedulerStateMachine::setCanBeginFrame):
(CCSchedulerStateMachine):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeImplOnImplThread):

Source/WebKit/chromium:

Update unit tests for new canBeginFrame bit.

* tests/CCSchedulerStateMachineTest.cpp:
(WebCore::TEST):
(WebCore):
* tests/CCSchedulerTest.cpp:
(WebKitTests::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSC testing should have complete coverage over typed array types
fpizlo@apple.com [Thu, 19 Apr 2012 01:10:51 +0000 (01:10 +0000)]
JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302

Rubber stamped by Geoff Garen.

Changed calls to shouldBe("...", "...") to be more informative, per Geoff's
suggestion.

* fast/js/dfg-float32array-expected.txt:
* fast/js/dfg-int16array-expected.txt:
* fast/js/dfg-int32array-expected.txt:
* fast/js/dfg-int32array-overflow-values-expected.txt:
* fast/js/dfg-int8array-expected.txt:
* fast/js/dfg-uint16array-expected.txt:
* fast/js/dfg-uint32array-expected.txt:
* fast/js/dfg-uint32array-overflow-values-expected.txt:
* fast/js/dfg-uint8array-expected.txt:
* fast/js/dfg-uint8clampedarray-expected.txt:
* fast/js/script-tests/dfg-float32array.js:
* fast/js/script-tests/dfg-int16array.js:
* fast/js/script-tests/dfg-int32array-overflow-values.js:
* fast/js/script-tests/dfg-int32array.js:
* fast/js/script-tests/dfg-int8array.js:
* fast/js/script-tests/dfg-uint16array.js:
* fast/js/script-tests/dfg-uint32array-overflow-values.js:
* fast/js/script-tests/dfg-uint32array.js:
* fast/js/script-tests/dfg-uint8array.js:
* fast/js/script-tests/dfg-uint8clampedarray.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSC testing should have complete coverage over typed array types
fpizlo@apple.com [Thu, 19 Apr 2012 00:15:29 +0000 (00:15 +0000)]
JSC testing should have complete coverage over typed array types
https://bugs.webkit.org/show_bug.cgi?id=84302

Source/JavaScriptCore:

Reviewed by Geoff Garen.

Added Uint8ClampedArray to the set of typed arrays that are supported by jsc
command-line.

* JSCTypedArrayStubs.h:
(JSC):
* jsc.cpp:
(GlobalObject::finishCreation):

Tools:

Reviewed by Geoff Garen.

Made run-fast-jsc print something and a newline if jsc threw an exception or
otherwise returned with an error code, but did not crash.

* Scripts/run-fast-jsc:

LayoutTests:

Reviewed by Geoff Garen.

Added tests for uint8 and uint16 arrays. Added a test for uint32 arrays that
does not focus entirely on overflow values.

Also added the typed array tests to the repertoire that can be run by
run-fast-jsc.

* fast/js/dfg-int16array-expected.txt:
* fast/js/dfg-int8array-expected.txt:
* fast/js/dfg-uint16array-expected.txt: Added.
* fast/js/dfg-uint16array.html: Added.
* fast/js/dfg-uint32array-expected.txt: Added.
* fast/js/dfg-uint32array.html: Added.
* fast/js/dfg-uint8array-expected.txt: Added.
* fast/js/dfg-uint8array.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-int16array.js:
* fast/js/script-tests/dfg-int8array.js:
* fast/js/script-tests/dfg-uint16array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
* fast/js/script-tests/dfg-uint32array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
* fast/js/script-tests/dfg-uint8array.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] r114021 triggered media flakyness
philn@webkit.org [Thu, 19 Apr 2012 00:11:54 +0000 (00:11 +0000)]
[GTK] r114021 triggered media flakyness
https://bugs.webkit.org/show_bug.cgi?id=83874

Reviewed by Eric Carlson.

Fix-up use of setMediaPlaybackRequiresUserGesture() in two media
tests.

* media/video-load-require-user-gesture.html:
* media/video-play-require-user-gesture.html:
* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Thu, 19 Apr 2012 00:05:34 +0000 (00:05 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt: Unflag some tests now passing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSomehow, there's an errant backslash in my last WTF patch
commit-queue@webkit.org [Thu, 19 Apr 2012 00:04:55 +0000 (00:04 +0000)]
Somehow, there's an errant backslash in my last WTF patch
https://bugs.webkit.org/show_bug.cgi?id=84290

Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-18
Reviewed by Andreas Kling.

* wtf/StdLibExtras.h:
(WTF::roundUpToMultipleOf):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix crash in chromium.py after r114877.
dpranke@chromium.org [Wed, 18 Apr 2012 23:56:47 +0000 (23:56 +0000)]
Fix crash in chromium.py after r114877.

Unreviewed, build fix.

Missed updating one call site for get_crash_log() :(.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.run_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Solid color layers should respect opacity value.
commit-queue@webkit.org [Wed, 18 Apr 2012 23:32:44 +0000 (23:32 +0000)]
[Chromium] Solid color layers should respect opacity value.
https://bugs.webkit.org/show_bug.cgi?id=84197

Patch by David Reveman <reveman@chromium.org> on 2012-04-18
Reviewed by Adrienne Walker.

Source/WebCore:

Fold opacity into shader color for solid color layers.

Test: CCSolidColorLayerImplTest.verifyCorrectOpacityInQuad

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawSolidColorQuad):

Source/WebKit/chromium:

* tests/CCSolidColorLayerImplTest.cpp:
(CCLayerTestCommon::TEST):
(CCLayerTestCommon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] NRWT bails out if more than one X server runs on the machine
philn@webkit.org [Wed, 18 Apr 2012 23:29:33 +0000 (23:29 +0000)]
[GTK] NRWT bails out if more than one X server runs on the machine
https://bugs.webkit.org/show_bug.cgi?id=84276

Reviewed by Dirk Pranke.

Set up GTK driver's Xvfb display number based on Xorg servers
currently running.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkDriver._start):
(GtkDriver._start.x_filter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun-webkit-tests picked up an old crash log
dpranke@chromium.org [Wed, 18 Apr 2012 23:17:38 +0000 (23:17 +0000)]
run-webkit-tests picked up an old crash log
https://bugs.webkit.org/show_bug.cgi?id=84196

Reviewed by Ryosuke Niwa.

Modify the crash log-finding code so that we can
limit our search to logs newer than X - this prevents
us from finding old crash logs for a given process/pid
combination even when the PIDs might've wrapped.

Also fix a bug in filesystem_mock where files_under() would
return paths that didn't exist.

* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs.find_newest_log):
(CrashLogs._find_newest_log_darwin):
* Scripts/webkitpy/common/system/crashlogs_unittest.py:
(CrashLogsTest.test_find_log_darwin):
(CrashLogsTest.test_find_log_darwin.bad_read):
(CrashLogsTest):
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.files_under):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port._get_crash_log):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._get_crash_log):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_get_crash_log):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver.run_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Call prefetchDNS directly
pilgrim@chromium.org [Wed, 18 Apr 2012 23:10:18 +0000 (23:10 +0000)]
[Chromium] Call prefetchDNS directly
https://bugs.webkit.org/show_bug.cgi?id=84262

Reviewed by Kentaro Hara.

Part of a series, see tracking bug 82948.

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/network/chromium/DNSChromium.cpp:
(WebCore::prefetchDNS):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agojsc command line should support typed arrays by default
fpizlo@apple.com [Wed, 18 Apr 2012 23:08:30 +0000 (23:08 +0000)]
jsc command line should support typed arrays by default
https://bugs.webkit.org/show_bug.cgi?id=84298

Rubber stamped by Gavin Barraclough.

* JSCTypedArrayStubs.h:
(JSC):
* jsc.cpp:
(GlobalObject::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(102040): Auto-table layout with percent width doesn't shrink-to-fit conten...
jchaffraix@webkit.org [Wed, 18 Apr 2012 23:07:51 +0000 (23:07 +0000)]
REGRESSION(102040): Auto-table layout with percent width doesn't shrink-to-fit content a cell with colspan
https://bugs.webkit.org/show_bug.cgi?id=84260

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/table/td-width-fifty-percent-regression-expected.html
       fast/table/td-width-fifty-percent-regression.html

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
As we are spreading the cell's min / max logical width, we should be updating them.
This prevents the following logic getting confused and allocating more than needed.

LayoutTests:

* fast/table/td-width-fifty-percent-regression-expected.html: Added.
* fast/table/td-width-fifty-percent-regression.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Wed, 18 Apr 2012 22:49:31 +0000 (22:49 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt: Mark some tests as crashing
in debug builds due to bug 63611.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSVALUE32_64 should be able to perform division on ARM without crashing, and variables
fpizlo@apple.com [Wed, 18 Apr 2012 22:31:54 +0000 (22:31 +0000)]
JSVALUE32_64 should be able to perform division on ARM without crashing, and variables
forced double should not be scrambled when performing OSR entry
https://bugs.webkit.org/show_bug.cgi?id=84272

Reviewed by Geoff Garen.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWin8 builds usually fail due to cygwin rebasing
jschuh@chromium.org [Wed, 18 Apr 2012 22:29:02 +0000 (22:29 +0000)]
Win8 builds usually fail due to cygwin rebasing
https://bugs.webkit.org/show_bug.cgi?id=84274

Reviewed by Dirk Pranke.

Cygwin can fail to spawn children if the DLL is rebased. This happens
frequently enough on Windows 8 that we should retry on failure.

No new tests. No behavior changed.

* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd explicit template instantiation to chromium/PopupListBox.cpp to prepare for sub...
leviw@chromium.org [Wed, 18 Apr 2012 22:03:44 +0000 (22:03 +0000)]
Add explicit template instantiation to chromium/PopupListBox.cpp to prepare for sub-pixel layout
https://bugs.webkit.org/show_bug.cgi?id=84264

Reviewed by Eric Seidel.

Explicitly instantiating integer max and min templates to fix compilation in Chromium. We
intentionally truncated these values in platform code, which matches earlier behavior.
See https://trac.webkit.org/wiki/LayoutUnit for details.

No new tests. No change in behavior.

* platform/chromium/PopupListBox.cpp:
(WebCore::PopupListBox::paintRow):
(WebCore::PopupListBox::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFull Screen mode does not preserve CALayer ordering after exiting.
jer.noble@apple.com [Wed, 18 Apr 2012 21:53:50 +0000 (21:53 +0000)]
Full Screen mode does not preserve CALayer ordering after exiting.
https://bugs.webkit.org/show_bug.cgi?id=83931

Reviewed by Eric Carlson.

When swapping the placeholder and web views, use -[NSView addSubview:positioned:relativeTo:]
instead of -[NSView replaceSubview:with:], as the latter does not preserve the relative order
of the view's backing CALayers.

Source/WebKit/mac:

* WebView/WebFullScreenController.mm:
(-[WebFullScreenController _swapView:with:]):

Source/WebKit2:

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _swapView:with:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrevent potential null pointer dereference in CSSStyleSelector::applyProperty().
macpherson@chromium.org [Wed, 18 Apr 2012 21:51:48 +0000 (21:51 +0000)]
Prevent potential null pointer dereference in CSSStyleSelector::applyProperty().
https://bugs.webkit.org/show_bug.cgi?id=84267

Reviewed by Kentaro Hara.

No new tests / code cleanup found via static analysis.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJavaScriptCore.gypi not current
commit-queue@webkit.org [Wed, 18 Apr 2012 21:45:54 +0000 (21:45 +0000)]
JavaScriptCore.gypi not current
https://bugs.webkit.org/show_bug.cgi?id=84224

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2012-04-18
Reviewed by Eric Seidel.

Updated JavaScriptCore.gypi to contain the latest sources. Removed os-win32 as it wasn't used. Also removed references to ICU files in the gypi file as ICU is most likely specified by the port itself.

Private and public header files were determined by looking at copy-files.cmd within Apple's Visual Studio directory.

* JavaScriptCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium compile of WebDatabase.cpp fails without SQL_DATABASE
commit-queue@webkit.org [Wed, 18 Apr 2012 21:26:35 +0000 (21:26 +0000)]
Chromium compile of WebDatabase.cpp fails without SQL_DATABASE
https://bugs.webkit.org/show_bug.cgi?id=84212

Patch by Myles Maxfield <mmaxfield@google.com> on 2012-04-18
Reviewed by Kentaro Hara.

* src/WebDatabase.cpp:
(WebCore::AbstractDatabase::isSyncDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrevent switch case fallthrough in StylePropertySet::getPropertyValue().
macpherson@chromium.org [Wed, 18 Apr 2012 21:21:35 +0000 (21:21 +0000)]
Prevent switch case fallthrough in StylePropertySet::getPropertyValue().
https://bugs.webkit.org/show_bug.cgi?id=84266

Reviewed by Kentaro Hara.

No new tests / code cleanup found by static analysis.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: support additional test expectations files
dpranke@chromium.org [Wed, 18 Apr 2012 21:04:43 +0000 (21:04 +0000)]
nrwt: support additional test expectations files
https://bugs.webkit.org/show_bug.cgi?id=84222

Reviewed by Ojan Vafai.

This patch adds an --additional-expectations flag that can be
used to point to more files that will override the default set
of expectations. This will allow us to remove the
'google_chrome' ports and eventually help to clean up override
handling in the chromium ports and unify expectations files and
Skipped files; this can also be used to specify overrides for
tests that run differently on a given machine.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.test_expectations_overrides):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.test_expectations_overrides):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_additional_expectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSSValuePool: Make numeric value caches fixed-size arrays.
kling@webkit.org [Wed, 18 Apr 2012 21:01:56 +0000 (21:01 +0000)]
CSSValuePool: Make numeric value caches fixed-size arrays.
<http://webkit.org/b/84268>

Reviewed by Antti Koivisto.

Change the numeric CSSPrimitiveValue caches in CSSValuePool from HashMaps to
fixed-size arrays of RefPtr<CSSPrimitiveValue>s.

This is more space efficient and doesn't incur the cost of a hash lookup every
time a numeric CSSPrimitiveValue is needed. We retain the limit of caching
only values between 0-255 for now.

* css/CSSValuePool.cpp:
(WebCore::CSSValuePool::CSSValuePool):
(WebCore::CSSValuePool::createValue):
* css/CSSValuePool.h:
(CSSValuePool):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Rename overdraw histograms so we can use field trials in histograms.xml
danakj@chromium.org [Wed, 18 Apr 2012 20:53:44 +0000 (20:53 +0000)]
[chromium] Rename overdraw histograms so we can use field trials in histograms.xml
https://bugs.webkit.org/show_bug.cgi?id=83500

Reviewed by James Robinson.

* platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::recordMetricsInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLion Production Test failing with error: "Failed to stop httpd: pid file still exists...
jer.noble@apple.com [Wed, 18 Apr 2012 20:47:54 +0000 (20:47 +0000)]
Lion Production Test failing with error: "Failed to stop httpd: pid file still exists" https://bugs.webkit.org/show_bug.cgi?id=84177

Reviewed by Dirk Pranke.

Try to delete the pid file left by Apache in the case it was killed forcefully.

* Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
(LayoutTestApacheHttpd._stop_running_server):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Solid color shader should use premultiplied alpha.
commit-queue@webkit.org [Wed, 18 Apr 2012 20:34:42 +0000 (20:34 +0000)]
[Chromium] Solid color shader should use premultiplied alpha.
https://bugs.webkit.org/show_bug.cgi?id=84215

Patch by David Reveman <reveman@chromium.org> on 2012-04-18
Reviewed by Adrienne Walker.

For efficiency and consistency, expect premultiplied alpha in
solid color shader.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::FragmentShaderColor::getShaderString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Sandbox violations prevent attaching files to gmail messages
ap@apple.com [Wed, 18 Apr 2012 20:23:10 +0000 (20:23 +0000)]
    [WK2] Sandbox violations prevent attaching files to gmail messages
        https://bugs.webkit.org/show_bug.cgi?id=84263
        <rdar://problem/11248260>

        Reviewed by Oliver Hunt.

        * page/DragActions.h: Removed the newly added upload action. We cannot know if or when an
        upload is going to happen - a drop even listener can always get a reference to a File object,
        and upload it with XMLHttpRequest.

        * page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Removed a separate
        willPerformDragDestinationAction call for upload action - ther is nothing we'd want to only
        do when dropping on a file upload button.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGraphicsContextCG's roundToDevicePixels should round even when there's no transform
leviw@chromium.org [Wed, 18 Apr 2012 20:05:10 +0000 (20:05 +0000)]
GraphicsContextCG's roundToDevicePixels should round even when there's no transform
https://bugs.webkit.org/show_bug.cgi?id=84191

Reviewed by Eric Seidel.

When painting with the identify transform, the roundToDevicePixels function in GraphicsContextCG
does an early return that simply returns the FloatRect that was passed in. This proved to be a
problem in sub-pixel layout, as we wouldn't adjust the paint rect for text underline, and it could
end up being more than one pixel wide. Adding a roundedIntRect method on FloatRect for the simple
short-circuit case.

No new tests. No change in behavior before switching to sub-pixel layout.

* platform/graphics/FloatRect.cpp:
(WebCore::roundedIntRect):
* platform/graphics/FloatRect.h:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean-up WheelEvent Conversion.
commit-queue@webkit.org [Wed, 18 Apr 2012 19:48:34 +0000 (19:48 +0000)]
Clean-up WheelEvent Conversion.
https://bugs.webkit.org/show_bug.cgi?id=84243

Source/WebKit/qt:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

* WebCoreSupport/WebEventConversion.cpp:
(WebCore::WebKitPlatformWheelEvent::applyDelta):

Source/WebKit2:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

* Shared/qt/WebEventFactoryQt.cpp:
(WebKit::WebEventFactory::createWebWheelEvent):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::wheelEvent):

Tools:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

Calculate proper wheel-delta from pixel-delta given.

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::EventSender):
(EventSender::mouseScrollBy):
(EventSender::continuousMouseScrollBy):

LayoutTests:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

* platform/qt/fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Turn on ENABLE_DATALIST for chromium
keishi@webkit.org [Wed, 18 Apr 2012 19:32:16 +0000 (19:32 +0000)]
[chromium] Turn on ENABLE_DATALIST for chromium
https://bugs.webkit.org/show_bug.cgi?id=84118

Reviewed by Kent Tamura.

Source/WebCore:

* html/HTMLDataListElement.cpp: Touched to avoid build issues. No code change.
* html/HTMLDataListElement.h: Ditto.
* html/HTMLInputElement.cpp: Ditto.
* html/HTMLInputElement.h: Ditto.

Source/WebKit/chromium:

* features.gypi: Turn on ENABLE_DATALIST.
* src/WebInputElement.cpp: Touched to avoid build issues. No code change.

LayoutTests:

* platform/chromium/fast/forms/label/labelable-elements-expected.txt: Update expectated result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] WheelEventQt.cpp should be deleted.
commit-queue@webkit.org [Wed, 18 Apr 2012 19:19:56 +0000 (19:19 +0000)]
[Qt] WheelEventQt.cpp should be deleted.
https://bugs.webkit.org/show_bug.cgi?id=84237

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-18
Reviewed by Simon Hausmann.

* platform/qt/WheelEventQt.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Update baselines after font-face support was fixed
commit-queue@webkit.org [Wed, 18 Apr 2012 18:58:08 +0000 (18:58 +0000)]
[EFL][DRT] Update baselines after font-face support was fixed
https://bugs.webkit.org/show_bug.cgi?id=84234

Unreviewed, EFL gardening.

Fixing baselines for css/font-face* tests and tests affected
by working @font-face. A bunch of table/* rebaselines will
follow in a separate batch.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-18

* platform/efl/fast/css/beforeSelectorOnCodeElement-expected.png:
* platform/efl/fast/css/font-face-default-font-expected.png:
* platform/efl/fast/css/font-face-in-media-rule-expected.png:
* platform/efl/fast/css/font-face-multiple-faces-expected.png:
* platform/efl/fast/css/font-face-multiple-faces-expected.txt:
* platform/efl/fast/css/font-face-opentype-expected.png:
* platform/efl/fast/css/font-face-opentype-expected.txt:
* platform/efl/fast/css/font-face-remote-expected.png:
* platform/efl/fast/css/font-face-remote-expected.txt:
* platform/efl/fast/css/font-face-synthetic-bold-italic-expected.png: Added.
* platform/efl/fast/css/font-face-synthetic-bold-italic-expected.txt: Added.
* platform/efl/fast/css/font-face-unicode-range-expected.png:
* platform/efl/fast/css/font-face-unicode-range-expected.txt:
* platform/efl/fast/css/font-face-weight-matching-expected.png: Added.
* platform/efl/fast/css/font-face-weight-matching-expected.txt: Added.
* platform/efl/fast/css/font-face-woff-expected.png:
* platform/efl/fast/css/font-face-woff-expected.txt:
* platform/efl/fast/css/rtl-ordering-expected.txt:
* platform/efl/fast/css/text-security-expected.txt:
* platform/efl/fast/events/updateLayoutForHitTest-expected.png:
* platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.png:
* platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
* platform/efl/fast/writing-mode/broken-ideographic-font-expected.png:
* platform/efl/fast/writing-mode/broken-ideographic-font-expected.txt:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Adding FIXME comment to FractionalLayoutUnit explaining the lack of size_...
eae@chromium.org [Wed, 18 Apr 2012 18:46:57 +0000 (18:46 +0000)]
Unreviewed. Adding FIXME comment to FractionalLayoutUnit explaining the lack of size_t operators.

* platform/FractionalLayoutUnit.h:
(FractionalLayoutUnit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIDB: Pending setVersion call in worker prevents document from opening the db, even...
dgrogan@chromium.org [Wed, 18 Apr 2012 18:40:30 +0000 (18:40 +0000)]
IDB: Pending setVersion call in worker prevents document from opening the db, even after worker termination
https://bugs.webkit.org/show_bug.cgi?id=83952

These two tests fail in DRT most proximately because DRT provides
different instances of IDBFactoryBackend to a document and worker:
https://bugs.webkit.org/show_bug.cgi?id=82776.

One fails in chromium because of a logic error tracked by
http://crbug.com/123418. The plan is to run them both as browser tests
when the logic is fixed, but just one in the meantime.

Also added SKIP for storage/indexeddb/dont-commit-on-blocked.html
since it also can't pass in DRT and just turns the flakiness dashboard
all red.

Reviewed by Ojan Vafai.

* platform/chromium/test_expectations.txt:
* storage/indexeddb/pending-version-change-stuck-expected.txt: Added.
* storage/indexeddb/pending-version-change-stuck-works-with-terminate-expected.txt: Added.
* storage/indexeddb/pending-version-change-stuck-works-with-terminate.html: Added.
* storage/indexeddb/pending-version-change-stuck.html: Added.
* storage/indexeddb/resources/pending-version-change-stuck.js: Added.
(test.request.onsuccess.request.onblocked):
(test.request.onsuccess):
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove m_subclassData from JSArray, move the attribute to subclass as needed
benjamin@webkit.org [Wed, 18 Apr 2012 18:36:59 +0000 (18:36 +0000)]
Remove m_subclassData from JSArray, move the attribute to subclass as needed
https://bugs.webkit.org/show_bug.cgi?id=84249

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-18
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

JSArray's m_subclassData is only used by WebCore's RuntimeArray. This patch moves
the attribute to RuntimeArray to avoid allocating memory for the pointer in the common
case.

This gives ~1% improvement in JSArray creation microbenchmark thanks to fewer allocations
of CopiedSpace.

* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateJSArray):
* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
* runtime/JSArray.h:

Source/WebCore:

* bridge/runtime_array.cpp:
(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::finishCreation):
* bridge/runtime_array.h:
(JSC::RuntimeArray::getLength):
(JSC::RuntimeArray::getConcreteArray):
(RuntimeArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomatchMedia() MediaQueryList not updating
antti@apple.com [Wed, 18 Apr 2012 18:34:42 +0000 (18:34 +0000)]
matchMedia() MediaQueryList not updating
https://bugs.webkit.org/show_bug.cgi?id=75903

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2012-04-18
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/media/media-query-list-08.html

Viewport related MediaQueryList listeners were not triggered and the value
of matches were not updated if the document's style selector were not
affected by viewport changes.

The new method evaluateMediaQueries() is now called by FrameView instead of
styleSelectorChanged() if the style selector is not affected by viewport changes.

* dom/Document.cpp:
(WebCore::Document::evaluateMediaQueries):
(WebCore):
(WebCore::Document::styleSelectorChanged):
* dom/Document.h:
(Document):
* page/FrameView.cpp:
(WebCore::FrameView::layout):

LayoutTests:

Testing MediaQueryLists listeners related to viewport changes.

* fast/media/media-query-list-08-expected.txt: Added.
* fast/media/media-query-list-08.html: Added.

Skipping the new test in Mac and Qt due to an issue in its DumpRenderTree.

* platform/qt/Skipped:
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse explicit casts for size_t to unsigned conversion
eae@chromium.org [Wed, 18 Apr 2012 18:31:35 +0000 (18:31 +0000)]
Use explicit casts for size_t to unsigned conversion
https://bugs.webkit.org/show_bug.cgi?id=83602

Reviewed by Eric Seidel.

No new tests, no change in functinality.

Not all platforms have implicit casts from size_t to unsigned and we
can't add size_t versions of the operators to FractionalLayoutUnit for
all platforms as it would conflict with the unsigned versions of same.

Change support methods to take unsigned instead of size_t and use
explicit casts when multiplying or dividing a FractionalLayoutUnit with
a size_t and the other way around.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForColumns):
* rendering/RenderFlexibleBox.cpp:
(WebCore::initialPackingOffset):
(WebCore::packingSpaceBetweenChildren):
(WebCore::initialLinePackingOffset):
(WebCore::linePackingSpaceBetweenChildren):
(WebCore::RenderFlexibleBox::packFlexLines):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK test_expectations update.
philn@webkit.org [Wed, 18 Apr 2012 18:31:06 +0000 (18:31 +0000)]
Unreviewed, GTK test_expectations update.

* platform/gtk/test_expectations.txt: Skip some failing tests and
mark 3 more frame flattening tests flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Web Inspector: [Chromium] Module's require injects scripts before...
pfeldman@chromium.org [Wed, 18 Apr 2012 18:14:58 +0000 (18:14 +0000)]
Source/WebCore: Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
https://bugs.webkit.org/show_bug.cgi?id=84166

Re-applying r114497.

* bindings/v8/V8IsolatedContext.cpp:
(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
* bindings/v8/V8Proxy.h:
(V8Proxy):

LayoutTests: Unreviewed, rolling out r114506.
http://trac.webkit.org/changeset/114506
https://bugs.webkit.org/show_bug.cgi?id=84254

Seems to be making gtk's DumpRenderTree crash occasionally
(Requested by tomz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, trying to fix QT build.
achicu@adobe.com [Wed, 18 Apr 2012 18:06:14 +0000 (18:06 +0000)]
Unreviewed, trying to fix QT build.

It was using a FilterEffectRenderer::prepare that changed to allocateBackingStoreIfNeeded in 114529.

* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, rebaseline compositing tests after r114283.
enne@google.com [Wed, 18 Apr 2012 18:03:39 +0000 (18:03 +0000)]
[chromium] Unreviewed, rebaseline compositing tests after r114283.
https://bugs.webkit.org/show_bug.cgi?id=84083

* platform/chromium-linux/compositing/overflow/overflow-positioning-expected.png:
* platform/chromium-mac-leopard/compositing/overflow/overflow-positioning-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/overflow/overflow-positioning-expected.png:
* platform/chromium-mac/compositing/overflow/overflow-positioning-expected.png:
* platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt: Added.
* platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
* platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt: Added.
* platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
* platform/chromium-win/compositing/overflow/overflow-positioning-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: extract script navigator overlay logic into the scripts navigator...
pfeldman@chromium.org [Wed, 18 Apr 2012 18:01:53 +0000 (18:01 +0000)]
Web Inspector: extract script navigator overlay logic into the scripts navigator controller.
https://bugs.webkit.org/show_bug.cgi?id=84244

Reviewed by Vsevolod Vlasov.

Overlay logic is well separable from the scripts panel and does not belong there.
Extracting it into a separate class.

* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigatorController.prototype.wasShown):
(WebInspector.ScriptsNavigatorController.prototype._createNavigatorControlButton):
(WebInspector.ScriptsNavigatorController.prototype._escDownWhileNavigatorOverlayOpen):
(WebInspector.ScriptsNavigatorController.prototype._toggleNavigator):
(WebInspector.ScriptsNavigatorController.prototype._hidePinnedNavigator):
(WebInspector.ScriptsNavigatorController.prototype.set _pinNavigator):
(WebInspector.ScriptsNavigatorController.prototype.set showNavigatorOverlay):
(WebInspector.ScriptsNavigatorController.prototype.hideNavigatorOverlay):
(WebInspector.ScriptsNavigatorController.prototype._navigatorOverlayWasShown):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.wasShown):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._scriptSelected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r114506.
tomz@codeaurora.org [Wed, 18 Apr 2012 18:01:17 +0000 (18:01 +0000)]
Unreviewed, rolling out r114506.
http://trac.webkit.org/changeset/114506
https://bugs.webkit.org/show_bug.cgi?id=84254

Seems to be making gtk's DumpRenderTree crash occasionally
(Requested by tomz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18

Source/WebKit/gtk:

* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
* webkit/webkitwebsettingsprivate.h:
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Tools:

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):

LayoutTests:

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r114497.
dimich@chromium.org [Wed, 18 Apr 2012 17:44:46 +0000 (17:44 +0000)]
Unreviewed, rolling out r114497.
http://trac.webkit.org/changeset/114497
https://bugs.webkit.org/show_bug.cgi?id=84253

Broke compile on Win, including stdio did not help (Requested
by dimich on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-18

* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
(WebCore::V8Proxy::setInjectedScriptContextDebugId):
(WebCore):
* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Filters] Drop-shadow and blur can avoid using full source image
achicu@adobe.com [Wed, 18 Apr 2012 17:37:41 +0000 (17:37 +0000)]
[CSS Filters] Drop-shadow and blur can avoid using full source image
https://bugs.webkit.org/show_bug.cgi?id=81263

Reviewed by Dean Jackson.

Instead of using the full bounding box of the RenderLayer we now compute the exact rectangle that is needed to
compute filter inside the dirty rectangle on screen. That's easy to calculate by reversing the filter outsets.
Even if the element is completely offscreen, but its shadow is in the viewport, we can still compute the source
rectangle that needs to be drawn in order to update the shadow correctly.

No new tests, this change doesn't have visible results and the functionality should
already be covered by previous filter tests.

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build): Save the outsets of the filters, so that we can use them in computeSourceImageRectForDirtyRect.
(WebCore::FilterEffectRenderer::updateBackingStoreRect): Only allocate a new source image if the size of the source rectangle changed.
(WebCore::FilterEffectRenderer::allocateBackingStoreIfNeeded): There's no need to call clearIntermediateResults() in this function. We do that after
the filter is computed.
(WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):
(WebCore):
(WebCore::FilterEffectRendererHelper::prepareFilterEffect):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):
* rendering/FilterEffectRenderer.h:
(FilterEffectRendererHelper):
(WebCore::FilterEffectRendererHelper::repaintRect):
(FilterEffectRenderer):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] @font-face support fails on EFL
commit-queue@webkit.org [Wed, 18 Apr 2012 17:16:57 +0000 (17:16 +0000)]
[EFL][DRT] @font-face support fails on EFL
https://bugs.webkit.org/show_bug.cgi?id=83264

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-18
Reviewed by Dimitri Glazkov.

STORE_FONT_CUSTOM_PLATFORM_DATA was not defined for EFL.
Fixing that by removing a long standing FIXME with the intention
to turn the whitelist for this switch into a blacklist.

* loader/cache/CachedFont.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoreplaceUsingStringSearch: delay the creation of the replace string until needed
benjamin@webkit.org [Wed, 18 Apr 2012 17:07:23 +0000 (17:07 +0000)]
replaceUsingStringSearch: delay the creation of the replace string until needed
https://bugs.webkit.org/show_bug.cgi?id=83841

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-18
Reviewed by Geoffrey Garen.

We do not need to obtain the replaceValue until we have a match. By moving the intialization
of replaceValue when needed, we save a few instructions when there is no match.

* runtime/StringPrototype.cpp:
(JSC::replaceUsingRegExpSearch):
(JSC::replaceUsingStringSearch):
(JSC::stringProtoFuncReplace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert ShadowData and DropShadowFilterOperation to use IntPoint
leviw@chromium.org [Wed, 18 Apr 2012 17:05:11 +0000 (17:05 +0000)]
Convert ShadowData and DropShadowFilterOperation to use IntPoint
https://bugs.webkit.org/show_bug.cgi?id=84098

Reviewed by Eric Seidel.

Shadows do not flow with the page, so sub-pixel layout doesn't actually offer any benefit that
couldn't have been attained before that conversion. With that in mind, this patch reverts
drop shadow offsets to integers, but also cleans up the code by switching the x/y location pair
to be an IntPoint.

No new tests. No change in behavior.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* page/animation/AnimationBase.cpp:
(WebCore::blendFunc):
(WebCore::shadowForBlending):
* platform/animation/AnimationUtilities.h:
(WebCore::blend): New blend function that operates on IntPoints.
(WebCore):
* platform/chromium/support/WebFilterOperations.cpp:
(WebKit::WebDropShadowFilterOperation):
* platform/graphics/filters/FilterOperation.cpp:
(WebCore::DropShadowFilterOperation::blend):
* platform/graphics/filters/FilterOperation.h:
(WebCore::DropShadowFilterOperation::clone):
(WebCore::DropShadowFilterOperation::x):
(WebCore::DropShadowFilterOperation::y):
(WebCore::DropShadowFilterOperation::location): Preserved the comment about lengths.
(WebCore::DropShadowFilterOperation::operator==):
(WebCore::DropShadowFilterOperation::DropShadowFilterOperation):
(DropShadowFilterOperation):
* rendering/RenderBoxModelObject.cpp:
(WebCore::areaCastingShadowInHole): Reverted to integers since this operates on the IntRect from
a RoundedRect.
(WebCore::RenderBoxModelObject::paintBoxShadow): Reduced the complexity and unnecessary conversion
between LayoutUnits and integers by using all integers after we calculate the pixel-snapped
RoundedRect that we use for painting.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):
* rendering/style/ShadowData.cpp:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):
(WebCore::calculateShadowExtent):
(WebCore::ShadowData::adjustRectForShadow):
* rendering/style/ShadowData.h:
(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::x):
(WebCore::ShadowData::y):
(WebCore::ShadowData::location):
(ShadowData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add an optional Isolate argument to wrap()
haraken@chromium.org [Wed, 18 Apr 2012 16:53:46 +0000 (16:53 +0000)]
[V8] Add an optional Isolate argument to wrap()
https://bugs.webkit.org/show_bug.cgi?id=84202

Reviewed by Nate Chapin.

The final objective is to pass Isolate around in V8 bindings.
This patch adds an optional Isolate argument to wrap().
After rewriting all wrap() callers so that they pass Isolate
to wrap(), I'll make the Isolate argument non-optional.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
(GenerateHeader):
* bindings/v8/custom/V8DocumentCustom.cpp: Ditto.
(WebCore::toV8):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp: Ditto.
(WebCore::toV8):
* bindings/v8/custom/V8NodeCustom.cpp: Ditto.
(WebCore::toV8Slow):
* bindings/v8/custom/V8SVGDocumentCustom.cpp: Ditto.
(WebCore::toV8):
* dom/make_names.pl: Ditto.
(printWrapperFactoryCppFile):

* bindings/scripts/test/V8/V8Float64Array.h:
Updated run-bindings-tests results.
(V8Float64Array):
(WebCore::V8Float64Array::wrap):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
(WebCore::V8TestActiveDOMObject::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
(WebCore::V8TestCustomNamedGetter::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
(WebCore::V8TestEventConstructor::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
(WebCore::V8TestEventTarget::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
(WebCore::V8TestInterface::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
(WebCore::V8TestMediaQueryListListener::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
(WebCore::V8TestNamedConstructor::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
(WebCore::V8TestNode::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
(WebCore::V8TestObj::wrap):
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):
(WebCore::V8TestSerializedScriptValueInterface::wrap):
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Filters] Do not use clipping rect when calculating the bounds of a layer
achicu@adobe.com [Wed, 18 Apr 2012 16:34:32 +0000 (16:34 +0000)]
[CSS Filters] Do not use clipping rect when calculating the bounds of a layer
https://bugs.webkit.org/show_bug.cgi?id=83960

Reviewed by Simon Fraser.

The local clip rect should not be used when calculating the bounds of a filter area. Otherwise
drop-shadow might not know about the pixels outside the clipping rectangle, even though the actual shadow might
be inside it.

No new tests added in this patch, but this patch fixes two existing tests that fail.
LayoutTests/css3/filters/filter-repaint-shadow-clipped.html
LayoutTests/css3/filters/filter-repaint-shadow-rotated.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateLayerBounds):
* rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFollowup to "Call incrementStatsCounter directly"
pilgrim@chromium.org [Wed, 18 Apr 2012 16:29:20 +0000 (16:29 +0000)]
Followup to "Call incrementStatsCounter directly"
https://bugs.webkit.org/show_bug.cgi?id=83109

Reviewed by Kentaro Hara.

Now that incrementStatsCounter has been moved from
PlatformSupport.h to Platform.h, we need to be able to call it directly
from WebCore/bindings/v8/v8Proxy.h (for the INC_STATS macro). That
means we need a new StatsCounter class in WebCore/platform/ and an
implementation in
WebCore/platform/chromium/StatsCounterChromium.cpp. Other ports
are welcome to implement their own stats counters if they
wish. This pattern was based on the
HistogramSupport/HistogramSupportChromium classes.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::V8DedicatedWorkerContext::postMessageCallback):
(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):
* bindings/v8/custom/V8NotificationCenterCustom.cpp:
(WebCore::V8NotificationCenter::createHTMLNotificationCallback):
(WebCore::V8NotificationCenter::createNotificationCallback):
(WebCore::V8NotificationCenter::requestPermissionCallback):
* bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::importScriptsCallback):
(WebCore::V8WorkerContext::setTimeoutCallback):
(WebCore::V8WorkerContext::setIntervalCallback):
* platform/StatsCounter.cpp: Added.
(WebCore):
(WebCore::StatsCounter::incrementStatsCounter):
* platform/StatsCounter.h: Added.
(WebCore):
(StatsCounter):
* platform/chromium/StatsCounterChromium.cpp: Added.
(WebCore):
(WebCore::StatsCounter::incrementStatsCounter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] REGRESSION: Popup shrinks because of autocomplete
apavlov@chromium.org [Wed, 18 Apr 2012 16:25:40 +0000 (16:25 +0000)]
[Chromium] REGRESSION: Popup shrinks because of autocomplete
https://bugs.webkit.org/show_bug.cgi?id=84139
http://code.google.com/p/chromium/issues/detail?id=123432

Source/WebCore:

Do not update the window rect on the wrong client but instead return the popup widget's
new screen coordinates from the refresh() method.

Reviewed by Kent Tamura.

* platform/chromium/PopupContainer.cpp:
(WebCore::PopupContainer::refresh):
* platform/chromium/PopupContainer.h:
(PopupContainer):

Source/WebKit/chromium:

Do not use the PopupContainer's frameRect() to update the popup client's window rect,
since PopupContainer is always positioned at (0, 0) inside the client's window rect,
and the latter one is positioned relative to the screen origin.

Reviewed by Kent Tamura.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::refreshAutofillPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGC activity timer should be tied to allocation, not collection
mhahnenberg@apple.com [Wed, 18 Apr 2012 16:18:32 +0000 (16:18 +0000)]
GC activity timer should be tied to allocation, not collection
https://bugs.webkit.org/show_bug.cgi?id=83919

Reviewed by Geoffrey Garen.

* API/JSContextRef.cpp: Used the new didAbandonObjectGraph callback to indicate that now that we've
released a global object, we're abandoning a potentially large number of objects that JSC might want
to collect.
* heap/CopiedSpace.cpp:
(JSC::CopiedSpace::tryAllocateSlowCase): Added the call to timer's willAllocate function to indicate
that we've hit a slow path and are allocating now, so schedule the timer.
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::collectAllGarbage): Removed the call to discardAllCompiledCode because it was causing us to
throw away too much code during our benchmarks (especially vp8, which is very large and thus has large
amounts of compiled code).
(JSC::Heap::collect): Added the new call to didCollect at the conclusion of a collection so that we
can cancel the timer if we no longer need to run a collection. Also added a check at the beginning of a
collection to see if we should throw away our compiled code. Currently this is set to happen about once
every minute.
* heap/Heap.h: Added field to keep track of the last time we threw away our compiled code.
* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::allocateSlowCase): Added call to willAllocate on the allocation slow path, just like
in CopiedSpace.
* runtime/GCActivityCallback.cpp: Added default stubs for non-CF platforms.
(JSC::DefaultGCActivityCallback::willAllocate):
(JSC):
(JSC::DefaultGCActivityCallback::didCollect):
(JSC::DefaultGCActivityCallback::didAbandonObjectGraph):
* runtime/GCActivityCallback.h: Added new functions to make JSC's GC timer less arcane. This includes replacing
the operator () with willAllocate() and adding an explicit didCollect() to cancel the timer after a collection
occurs rather than relying on the way the timer is invoked to cancel itself. Also added a callback for
when somebody else (e.g. WebCore or the JSC API) to notify JSC that they have just abandoned an entire graph of
objects and that JSC might want to clean them up.
(JSC::GCActivityCallback::~GCActivityCallback):
(JSC::GCActivityCallback::willAllocate):
(JSC::GCActivityCallback::didCollect):
(JSC::GCActivityCallback::didAbandonObjectGraph):
(JSC::GCActivityCallback::synchronize):
(DefaultGCActivityCallback):
* runtime/GCActivityCallbackCF.cpp: Re-wired all the run loop stuff to implement the aforementioned functions.
We added a flag to check whether the timer was active because the call to CFRunLoopTimerSetNextFireDate actually
turned out to be quite expensive (although Instruments couldn't tell us this).
(DefaultGCActivityCallbackPlatformData):
(JSC):
(JSC::DefaultGCActivityCallbackPlatformData::timerDidFire):
(JSC::DefaultGCActivityCallback::commonConstructor):
(JSC::scheduleTimer):
(JSC::cancelTimer):
(JSC::DefaultGCActivityCallback::willAllocate):
(JSC::DefaultGCActivityCallback::didCollect):
(JSC::DefaultGCActivityCallback::didAbandonObjectGraph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT when a layer with a foreground layer is in 'paint into ancestor' mode
simon.fraser@apple.com [Wed, 18 Apr 2012 16:17:04 +0000 (16:17 +0000)]
ASSERT when a layer with a foreground layer is in 'paint into ancestor' mode
https://bugs.webkit.org/show_bug.cgi?id=84221

Source/WebCore:

Reviewed by Dean Jackson.

When a RenderLayerBacking doesn't require its own backing store, and is
in "paintIntoCompositingAncestor" mode, we would assert when trying to
paint its m_foregroundLayer if it had one (because of a negative z-index child).

The fix is to set the 'drawsContent' state on the m_foregroundLayer
as well as m_graphicsLayer.

Test: compositing/backing/no-backing-foreground-layer.html

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDrawsContent):

LayoutTests:

Reviewed by Dean Jackson.

New testcase.

* compositing/backing/no-backing-foreground-layer-expected.txt: Added.
* compositing/backing/no-backing-foreground-layer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
commit-queue@webkit.org [Wed, 18 Apr 2012 16:14:03 +0000 (16:14 +0000)]
[CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
https://bugs.webkit.org/show_bug.cgi?id=84229

CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
subsequent builds, stopping WebCore from being built ever again.

Instead of trying to emulate a build target using command line options,
just build the existing jsc target directly.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-18
Reviewed by Rob Buis.

.:

* CMakeLists.txt:

Tools:

* Scripts/build-jsc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] r114021 triggered media flakyness
commit-queue@webkit.org [Wed, 18 Apr 2012 15:44:13 +0000 (15:44 +0000)]
[GTK] r114021 triggered media flakyness
https://bugs.webkit.org/show_bug.cgi?id=83874

Patch by Simon Pena <spena@igalia.com> on 2012-04-18
Reviewed by Philippe Normand.

Source/WebKit/gtk:

When the MediaPlaybackRequiresUserGesture setting was added, no gtk
API was implemented to access it.

This adds a property to gtk WebKit WebSettings, and connects it to
WebKit WebView, thus allowing clients to programmatically modify it.

* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):
* webkit/webkitwebsettingsprivate.h:
* webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Tools:

Now that there is gtk API to update the
MediaPlaybackRequiresUserGesture property, set it to false from the
DumpRenderTree tool when resetting defaults to consistent values.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):

LayoutTests:

media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html where enabling
MediaPlaybackRequiresUserGesture when run, so tests running
concurrently would fail -they would pass when run independently.

Since new API is added to ensure DumpRenderTree is able to reset
that setting, having media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html no longer causes
flakiness.

* platform/gtk/test_expectations.txt: Unskip
media/video-load-require-user-gesture.html and
media/video-play-require-user-gesture.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: DataGrid should use explicit root node
yurys@chromium.org [Wed, 18 Apr 2012 14:59:53 +0000 (14:59 +0000)]
Web Inspector: DataGrid should use explicit root node
https://bugs.webkit.org/show_bug.cgi?id=84240

DataGrid now has an explicit root node. All children are added/removed
to that node.

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView.prototype._createDataGrid):
(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
* inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileView):
(WebInspector.CSSSelectorProfileView.prototype.rebuildGridItems):
(WebInspector.CSSSelectorProfileView.prototype.refreshData):
* inspector/front-end/CookieItemsView.js:
(WebInspector.SimpleCookiesTable):
(WebInspector.SimpleCookiesTable.prototype.setCookies):
* inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable):
(WebInspector.CookiesTable.prototype._rebuildTable):
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid):
(WebInspector.DataGrid.createSortableDataGrid.sortDataGrid):
(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype.setRootNode):
(WebInspector.DataGrid.prototype.rootNode):
(WebInspector.DataGrid.prototype.autoSizeColumns):
(WebInspector.DataGrid.prototype._enumerateChildren):
(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
(WebInspector.DataGridNode.prototype.get revealed):
(WebInspector.DataGridNode.prototype.get depth):
(WebInspector.DataGridNode.prototype.appendChild):
(WebInspector.DataGridNode.prototype.insertChild):
(WebInspector.DataGridNode.prototype.removeChild):
(WebInspector.DataGridNode.prototype.removeChildren):
(WebInspector.DataGridNode.prototype.collapse):
(WebInspector.DataGridNode.prototype.expand):
(WebInspector.DataGridNode.prototype.reveal):
(WebInspector.DataGridNode.prototype.revealAndSelect):
(WebInspector.DataGridNode.prototype.traverseNextNode):
(WebInspector.DataGridNode.prototype.traversePreviousNode):
* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.changeNameFilter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype.performSearch):
(WebInspector.HeapSnapshotView.prototype.refreshVisibleData):
* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._createDataGrid):
(WebInspector.IDBDataView.prototype._updateData.callback):
(WebInspector.IDBDataView.prototype._updateData):
(WebInspector.IDBDataView.prototype.clear):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createTable):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.insertChild):
(WebInspector.ProfileDataGridNode.prototype.removeChild):
(WebInspector.ProfileDataGridNode.prototype.removeChildren):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView.prototype.refresh):
* inspector/front-end/treeoutline.js:

LayoutTests:

* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):
* inspector/storage-panel-dom-storage.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test svg/transforms/transform-origin-css-property.xhtml is failing
schenney@chromium.org [Wed, 18 Apr 2012 14:55:39 +0000 (14:55 +0000)]
Layout Test svg/transforms/transform-origin-css-property.xhtml is failing
https://bugs.webkit.org/show_bug.cgi?id=84203

Unreviewed test expectation fix.

The svg/transforms/transform-origin-css-property.xhtml test has a
ref-test for it, so there should not be any image expectations. If the
test if failing, we need to look at why the ref test is not valid, or
why we differ.

The expectations file update here is just some cleanup for
https://bugs.webkit.org/show_bug.cgi?id=84230.

* platform/chromium-mac/svg/transforms/transform-origin-css-property-expected.png: Removed.
* platform/chromium-win/svg/transforms/transform-origin-css-property-expected.png: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd PassThis=* to support the callbacks which requires to pass "this" value.
commit-queue@webkit.org [Wed, 18 Apr 2012 13:55:09 +0000 (13:55 +0000)]
Add PassThis=* to support the callbacks which requires to pass "this" value.
https://bugs.webkit.org/show_bug.cgi?id=84232

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-04-18
Reviewed by Kentaro Hara.

Adding PassThisToCallback=XXX to attributes will be useful for the callbacks which requires to pass "this".
This will help to identify the type(XXX) of "this" value in codegenerator.

Tests: bindings/scripts/test/TestCallback.idl

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementation): Modified codegenerator to support [PassThisToCallback]
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateCallbackImplementation): Ditto.
* bindings/scripts/IDLAttributes.txt: Added PassThisToCallback=*
* bindings/scripts/test/CPP/WebDOMTestCallback.cpp: Modofied results from run-bindings-tests.
(WebDOMTestCallback::callbackWithBoolean):
(WebDOMTestCallback::callbackRequiresThisToPass):
* bindings/scripts/test/CPP/WebDOMTestCallback.h: Ditto.
(WebDOMTestCallback):
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: Ditto.
(webkit_dom_test_callback_callback_with_boolean):
(webkit_dom_test_callback_callback_requires_this_to_pass):
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h: Ditto.
* bindings/scripts/test/JS/JSTestCallback.cpp: Ditto.
(WebCore::JSTestCallback::callbackWithBoolean):
(WebCore):
(WebCore::JSTestCallback::callbackRequiresThisToPass):
* bindings/scripts/test/JS/JSTestCallback.h: Ditto.
(JSTestCallback):
* bindings/scripts/test/ObjC/DOMTestCallback.h: Ditto.
* bindings/scripts/test/ObjC/DOMTestCallback.mm: Ditto.
(-[DOMTestCallback callbackWithBoolean:]):
(-[DOMTestCallback callbackRequiresThisToPass:thisClassParam:]):
* bindings/scripts/test/TestCallback.idl: Added test to verify generated code.
* bindings/scripts/test/V8/V8TestCallback.cpp: Ditto.
(WebCore::V8TestCallback::callbackWithBoolean):
(WebCore):
(WebCore::V8TestCallback::callbackRequiresThisToPass):
* bindings/scripts/test/V8/V8TestCallback.h: Ditto.
(V8TestCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: fixing Chromium win compilation.
pfeldman@chromium.org [Wed, 18 Apr 2012 13:52:49 +0000 (13:52 +0000)]
Not reviewed: fixing Chromium win compilation.

* bindings/v8/V8IsolatedContext.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnecessary variable reassignment in CSSParser::parseImageSet().
macpherson@chromium.org [Wed, 18 Apr 2012 13:02:41 +0000 (13:02 +0000)]
Remove unnecessary variable reassignment in CSSParser::parseImageSet().
https://bugs.webkit.org/show_bug.cgi?id=84204

Reviewed by Kentaro Hara.

Code calls next and then current instead of reusing the result of next.

No new tests / no functionality changed.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseImageSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Disabling Inspector causes build failure on Windows
commit-queue@webkit.org [Wed, 18 Apr 2012 12:26:33 +0000 (12:26 +0000)]
Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-04-18
Reviewed by Pavel Feldman.

The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.

Source/WebKit/win:

* WebCoreSupport/WebInspectorClient.cpp:
* WebInspector.cpp:
* WebNodeHighlight.cpp:
(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):
* WebNodeHighlight.h:
(WebNodeHighlight):
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:
(WebView):

Tools:

* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::showWebInspector):
(WTR::LayoutTestController::closeWebInspector):
(WTR::LayoutTestController::evaluateInWebInspector):
(WTR::LayoutTestController::setJavaScriptProfilingEnabled):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] HTTP GET header has a "Cookie" when refreshing a page after cookies...
commit-queue@webkit.org [Wed, 18 Apr 2012 10:56:38 +0000 (10:56 +0000)]
[BlackBerry] HTTP GET header has a "Cookie" when refreshing a page after cookies have been cleared.
https://bugs.webkit.org/show_bug.cgi?id=84223

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-18
Reviewed by George Staikos.

.:

* ManualTests/blackberry/clear-cookie-refresh-result.php: Added.
* ManualTests/blackberry/clear-cookie-refresh.php: Added.

Source/WebCore:

Webkit uses the old ResourceRequest when refreshing. Its cookies' header isn't removed after clicking
"clear cookies" button. We need to set cookies for this request again.

We must click "clear button" to test, so have to write a manual test case.

Test: ManualTests/blackberry/clear-cookie-refresh.php

* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::initializePlatformRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Chromium] Module's require injects scripts before the debug id is...
pfeldman@chromium.org [Wed, 18 Apr 2012 10:09:56 +0000 (10:09 +0000)]
Web Inspector: [Chromium] Module's require injects scripts before the debug id is set to the context.
https://bugs.webkit.org/show_bug.cgi?id=84166

Reviewed by Yury Semikhatsky.

V8IsolatedContext was getting debug id assigned post-construction. At the same time, it was compiling all
its module scripts within the constructor. As a result, scripts ended up in the main world's list.

* bindings/v8/V8IsolatedContext.cpp:
(WebCore::setInjectedScriptContextDebugId):
(WebCore):
(WebCore::V8IsolatedContext::V8IsolatedContext):
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
* bindings/v8/V8Proxy.h:
(V8Proxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Minibrowser asserts on startup at QtViewportInteractionEngine::ensureConten...
commit-queue@webkit.org [Wed, 18 Apr 2012 10:04:24 +0000 (10:04 +0000)]
[Qt][WK2] Minibrowser asserts on startup at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
https://bugs.webkit.org/show_bug.cgi?id=84172

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-18
Reviewed by Simon Hausmann.

After the viewport computing refactor, ensureContentWithinViewportBoundary() can be called
with resumed page. QtViewportInteractionEngine::ensureContentWithinViewportBoundary()
functionality does not necessarily require the page to be suspended. It's the caller's context
that determines whether the page needs to be suspended, so it's the caller's responsibility
to enforce the ASSERT().
Remove the invalid ASSERT on m_suspendCount at QtViewportInteractionEngine::ensureContentWithinViewportBoundary()

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, update expectations
toyoshim@chromium.org [Wed, 18 Apr 2012 08:53:21 +0000 (08:53 +0000)]
Unreviewed, update expectations
https://bugs.webkit.org/show_bug.cgi?id=84230

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: document.open removes the documentElement, but does not clear the...
pfeldman@chromium.org [Wed, 18 Apr 2012 08:49:28 +0000 (08:49 +0000)]
Web Inspector: document.open removes the documentElement, but does not clear the elements panel.
https://bugs.webkit.org/show_bug.cgi?id=84179

Reviewed by Yury Semikhatsky.

Source/WebCore:

Perform total update upon modifications of the document node.

Test: inspector/elements/delete-from-document.html

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
* inspector/front-end/ElementsTreeOutline.js:

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpElementsTree.print):
(initialize_ElementTest.InspectorTest.dumpElementsTree):
* inspector/elements/delete-from-document-expected.txt: Added.
* inspector/elements/delete-from-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [BlackBerry] Tab awareness for HTML5 concurrent audio
commit-queue@webkit.org [Wed, 18 Apr 2012 08:40:40 +0000 (08:40 +0000)]
Source/WebCore: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Support for concurrent HTML5 audio improvements being made in
the platform library, which need to be aware of tabs and tab
visibility. PR96004.

Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.

Test: media/audio-concurrent-supported.html

* platform/blackberry/PageClientBlackBerry.h:
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::showErrorDialog):
(WebCore::MediaPlayerPrivate::isTabVisible):
(WebCore):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):

Source/WebKit/blackberry: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Support for concurrent HTML5 audio improvements being made in
the platform library, which need to be aware of tabs and tab
visibility. PR96004.

Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.

* Api/WebPageClient.h:
* Api/WebPage_p.h:
(BlackBerry::WebKit::WebPagePrivate::isVisible):

LayoutTests: [BlackBerry] Tab awareness for HTML5 concurrent audio
https://bugs.webkit.org/show_bug.cgi?id=82930
Layout test for concurrent HTML5 audio. This is a simple test
to confirm that multiple audio elements can play at the same time.

Patch by Max Feil <mfeil@rim.com> on 2012-04-18
Reviewed by George Staikos.

* media/audio-concurrent-supported-expected.txt: Added.
* media/audio-concurrent-supported.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skipping test that uses disabled feature SHADOW_DOM
kkristof@inf.u-szeged.hu [Wed, 18 Apr 2012 08:17:11 +0000 (08:17 +0000)]
[Qt] Unreviewed gardening, skipping test that uses disabled feature SHADOW_DOM

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-04-18

* platform/qt/Skipped: fast/dom/shadow/adopt-node-with-shadow-root.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CG] ImageBuffer: check getPremultipliedImageData() error return
noel.gordon@gmail.com [Wed, 18 Apr 2012 08:05:43 +0000 (08:05 +0000)]
[CG] ImageBuffer: check getPremultipliedImageData() error return
https://bugs.webkit.org/show_bug.cgi?id=84022

Reviewed by Eric Seidel.

ImageBuffer::getPremultipliedImageData() can fail. toDataURL() should check for a
failure return, and return "data:," if so.

No new tests. Covered by existing toDataURL tests, in particular:
  canvas/philip/tests/toDataURL.jpeg.alpha.html

* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::toDataURL): Rename |arr| variable to premultipliedData and
return "data:," if premultipliedData is empty. Clean up whitespace and a comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] atk/textChangedNotifications API test fails
mario@webkit.org [Wed, 18 Apr 2012 07:37:32 +0000 (07:37 +0000)]
[GTK] atk/textChangedNotifications API test fails
https://bugs.webkit.org/show_bug.cgi?id=84010

Unreviewed, unskipping test after bug being fixed by r114311.

* Scripts/run-gtk-tests:
(TestRunner): Unskip now passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Viewport metatag doesn't disable double-tap zoom
commit-queue@webkit.org [Wed, 18 Apr 2012 06:39:35 +0000 (06:39 +0000)]
[BlackBerry] Viewport metatag doesn't disable double-tap zoom
https://bugs.webkit.org/show_bug.cgi?id=84199

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-04-17
Reviewed by George Staikos.

Source/WebKit/blackberry:

PR: 148279
When we set "user-scalable=no" in viewport meta-tag and change any
other WebSettings, the WebPage can turn to be scalable.
This is a regression of the change master_32/SHA:fa0f8ee9. In that
change, we used setUserScalable(webSettings->isUserScalable())
in WebPagePrivate::didChangeSettings which was incorrect for non-DRT
case, as webSettings->isUserScalable() would always return true by
default.
Create a new API WebPage::setUserScalable which will be used in
DumpRenderTree.cpp.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setUserScalable):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebPage.h:

Tools:

Revert a part of the change master_32/SHA:fa0f8ee9 and use
WebPage::setUserScalable instead.

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkia OOM error when upscaling small subsets of images by large quantities
commit-queue@webkit.org [Wed, 18 Apr 2012 06:36:30 +0000 (06:36 +0000)]
Skia OOM error when upscaling small subsets of images by large quantities
https://bugs.webkit.org/show_bug.cgi?id=84225

Patch by Rachel Blum <groby@chromium.org> on 2012-04-17
Reviewed by David Levin.

Tested with manual tests.

* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::shouldCacheResampling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rebaseline of svg/W3C-SVG-1.1/masking-intro-01-f.svg .
toyoshim@chromium.org [Wed, 18 Apr 2012 05:54:26 +0000 (05:54 +0000)]
Unreviewed, rebaseline of svg/W3C-SVG-1.1/masking-intro-01-f.svg .

* platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKitTestRunner needs textInputController
jer.noble@apple.com [Wed, 18 Apr 2012 05:47:45 +0000 (05:47 +0000)]
WebKitTestRunner needs textInputController
https://bugs.webkit.org/show_bug.cgi?id=42337

Update wk2 Skipped list to skip new failing test.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] http/tests/navigation/anchor-frames-same-origin.html fails
jer.noble@apple.com [Wed, 18 Apr 2012 05:34:09 +0000 (05:34 +0000)]
[WK2] http/tests/navigation/anchor-frames-same-origin.html fails
https://bugs.webkit.org/show_bug.cgi?id=84227

Update wk2 Skipped list to skip new failing test.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rebaseline of svg/as-background-image/svg-as-background-6.html .
toyoshim@chromium.org [Wed, 18 Apr 2012 05:27:22 +0000 (05:27 +0000)]
Unreviewed, rebaseline of svg/as-background-image/svg-as-background-6.html .

* platform/chromium-linux/svg/as-background-image/svg-as-background-6-expected.png: Added.
* platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-6-expected.png: Added.
* svg/as-background-image/svg-as-background-6-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-6-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShadowRoot shouldn't be adopted by any Document.
morrita@google.com [Wed, 18 Apr 2012 04:52:47 +0000 (04:52 +0000)]
ShadowRoot shouldn't be adopted by any Document.
https://bugs.webkit.org/show_bug.cgi?id=84127

Reviewed by Dimitri Glazkov.

Source/WebCore:

ShadowRoot cannot cannot be removed from its host, which means
ShadowRoot cannot be adopted by any Document directly because the
adoptNode() tries to remove it from its parent but it doesn't make
sense for ShadowRoot.

This change adds a guard to check such a case.

Test: fast/dom/shadow/adopt-node-with-shadow-root.html

* dom/Document.cpp:
(WebCore::Document::adoptNode):

LayoutTests:

* fast/dom/shadow/adopt-node-with-shadow-root-expected.txt: Added.
* fast/dom/shadow/adopt-node-with-shadow-root.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r114406-r114417): media/video-playing-and-pause.html failing on Lion...
jer.noble@apple.com [Wed, 18 Apr 2012 04:40:44 +0000 (04:40 +0000)]
REGRESSION (r114406-r114417): media/video-playing-and-pause.html failing on Lion Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=84226

Remove expected failing results ſtor media/video-playing-and-pause.html.

* platform/mac-wk2/media/video-playing-and-pause-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@114480 268f45cc-cd09-0410-ab3c-d52691b4dbfc