WebKit-https.git
7 years agoAdd WebInspectorUI to the Makefile.
timothy@apple.com [Tue, 11 Jun 2013 19:17:00 +0000 (19:17 +0000)]
Add WebInspectorUI to the Makefile.

Reviewed by Mark Rowe.

* Source/Makefile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate the framework bundle identifier for the Web Inspector.
timothy@apple.com [Tue, 11 Jun 2013 19:16:51 +0000 (19:16 +0000)]
Update the framework bundle identifier for the Web Inspector.

Reviewed by Mark Rowe.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):
(WebInspectorFrontendClient::localizedStringsURL):
(-[WebInspectorWindowController inspectorPagePath]):

Source/WebKit2:

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):
* WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
(WebKit::WebInspector::localizedStringsURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOpen Source the Safari Web Inspector back to WebKit.
timothy@apple.com [Tue, 11 Jun 2013 19:16:26 +0000 (19:16 +0000)]
Open Source the Safari Web Inspector back to WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPositioned Replaced Elements That Aren't RenderReplaced get Incorrect Width
robert@webkit.org [Tue, 11 Jun 2013 19:03:09 +0000 (19:03 +0000)]
Positioned Replaced Elements That Aren't RenderReplaced get Incorrect Width
https://bugs.webkit.org/show_bug.cgi?id=93735

Reviewed by Darin Adler.

Source/WebCore:

Replaced elements that aren't RenderReplaced aren't |isReplaced| and don't have an
intrinsic height or width. This causes them to go down the wrong height and width computation
path in RenderBox when they are absolute positioned.

The notion of |isReplaced| is entwined with the notion of being |isInline| so it isn't really
possible to make them isReplaced without re-wiring a lot of code. So instead use an ad-hoc definition
of isReplacedElement in RenderBox to bring all replaced elements into the height and width calculation.
To make sure we get the right height and width in there, give non-RenderReplaced replaced renderers
the helpers for returning their approximation of intrinsic height and width.

Test: fast/replaced/width-and-height-of-positioned-replaced-elements.html

* rendering/RenderBox.cpp:
(WebCore::isReplacedElement):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::intrinsicSize):
* rendering/RenderButton.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::computeLogicalHeight):
* rendering/RenderListBox.h:
* rendering/RenderMenuList.h:
* rendering/RenderReplaced.h:
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
(WebCore::RenderTextControl::computeLogicalHeight):
* rendering/RenderTextControl.h:

LayoutTests:

* fast/forms/onselect-textfield-expected.txt:
* fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
* fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
* fast/replaced/width-and-height-of-positioned-replaced-elements.html: Added.
* platform/mac-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
* platform/mac/fast/forms/button-positioned-expected.txt:
* platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
* platform/qt/fast/forms/button-positioned-expected.txt:
* platform/qt/fast/forms/input-appearance-preventDefault-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThere are unused variables in ApplyStyleCommand::mergeEndWithNextIfIdentical and...
rniwa@webkit.org [Tue, 11 Jun 2013 18:48:59 +0000 (18:48 +0000)]
There are unused variables in ApplyStyleCommand::mergeEndWithNextIfIdentical and ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds
https://bugs.webkit.org/show_bug.cgi?id=117475

Reviewed by Andreas Kling.

Removed.

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd baselines for test added in r151444
robert@webkit.org [Tue, 11 Jun 2013 18:48:44 +0000 (18:48 +0000)]
Add baselines for test added in r151444

Unreviewed.

* platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
* platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDo not filter cookies requested through the CookieStorageShim.
jer.noble@apple.com [Tue, 11 Jun 2013 18:48:08 +0000 (18:48 +0000)]
Do not filter cookies requested through the CookieStorageShim.
https://bugs.webkit.org/show_bug.cgi?id=117511
<rdar://problem/13603433>

Reviewed by Beth Dakin.

Since the shim function is called when the underlying media engine is
creating an HTTPRequest, use CookieRequestHeaderFieldValue (which does
not filter out HTTP-only cookies) rather than CookiesForDOM (which does).

* Shared/mac/CookieStorageShim.cpp:
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix typo in r151445
robert@webkit.org [Tue, 11 Jun 2013 18:33:36 +0000 (18:33 +0000)]
Fix typo in r151445

Unreviewed build fix.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove redundant calls to ceilToFloat in RenderBlock::computeInlinePreferredLogicalWidths
rniwa@webkit.org [Tue, 11 Jun 2013 18:22:28 +0000 (18:22 +0000)]
Remove redundant calls to ceilToFloat in RenderBlock::computeInlinePreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=117490

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/be336b14325b2938ff6a4fb6191073a6e717a57c.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPainting collapsed borders during scrolling
robert@webkit.org [Tue, 11 Jun 2013 18:11:31 +0000 (18:11 +0000)]
Painting collapsed borders during scrolling
https://bugs.webkit.org/show_bug.cgi?id=85658

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/repaint/table-cell-collapsed-border-scroll.html

WHen painting collapsed borders we need to paint the borders of the row above
the topmost dirtied row so that we compute the correct value for the dirtied row's collapsed border.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):

LayoutTests:

* fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.
* fast/repaint/table-cell-collapsed-border-scroll.html: Added.
* platform/qt/fast/repaint/table-cell-collapsed-border-scroll-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[curl] Custom HTTP method support
ossy@webkit.org [Tue, 11 Jun 2013 16:37:14 +0000 (16:37 +0000)]
[curl] Custom HTTP method support
https://bugs.webkit.org/show_bug.cgi?id=117302

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-11
Reviewed by Kenneth Rohde Christiansen.

No new tests, already covered by existing ones like:
http/tests/xmlhttprequest/workers/methods.html
http/tests/xmlhttprequest/workers/methods-async.html

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::initializeHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Provide MSAA mappings for more WebCore roles.
bfulgham@apple.com [Tue, 11 Jun 2013 15:32:18 +0000 (15:32 +0000)]
[Windows] Provide MSAA mappings for more WebCore roles.
https://bugs.webkit.org/show_bug.cgi?id=117389

Reviewed by Chris Fleizach.

* AccessibleBase.cpp:
(MSAARole): Add additional mappings between WebCore roles and MSAA roles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove leftover wxWebkit code
commit-queue@webkit.org [Tue, 11 Jun 2013 15:14:59 +0000 (15:14 +0000)]
Remove leftover wxWebkit code
https://bugs.webkit.org/show_bug.cgi?id=117471

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-06-11
Reviewed by Andreas Kling.

.:

* Source/cmake/WebKitPackaging.cmake:

Source/WebKit2:

* Scripts/generate-forwarding-headers.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoediting/undo/undo-after-event-edited.html can be flaky
rniwa@webkit.org [Tue, 11 Jun 2013 15:09:18 +0000 (15:09 +0000)]
editing/undo/undo-after-event-edited.html can be flaky
https://bugs.webkit.org/show_bug.cgi?id=117461

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/515de860730b34289df5805b40adb2535a9a8ba1

* editing/undo/undo-after-event-edited.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Remove 'using namespace std'
commit-queue@webkit.org [Tue, 11 Jun 2013 15:06:16 +0000 (15:06 +0000)]
Web Inspector: Remove 'using namespace std'
https://bugs.webkit.org/show_bug.cgi?id=117498

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-06-11
Reviewed by Anders Carlsson.

No new tests, no behavior change.

* inspector/InspectorAgent.cpp: Remove unneeded 'using namespace std'.
* inspector/InspectorFrontendClientLocal.cpp: Use explicit std:: qualifiers instead.
(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowWidth):
* inspector/InspectorFrontendHost.cpp: Remove unneeded 'using namespace std'.
* inspector/InspectorPageAgent.cpp: Remove unneeded 'using namespace std'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Unskipping passing tests. Generate new baseline where...
zarvai@inf.u-szeged.hu [Tue, 11 Jun 2013 14:42:57 +0000 (14:42 +0000)]
[Qt] Unreviewed gardening. Unskipping passing tests. Generate new baseline where needed.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-11

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/fast/images/paletted-png-with-color-profile-expected.png: Added.
* platform/qt-5.0-wk2/fast/images/paletted-png-with-color-profile-expected.txt: Added.
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport latest Web IDL named property getters
ch.dumez@sisa.samsung.com [Tue, 11 Jun 2013 13:04:10 +0000 (13:04 +0000)]
Support latest Web IDL named property getters
https://bugs.webkit.org/show_bug.cgi?id=117403

Reviewed by Kentaro Hara.

Add support for the latest Web IDL named property getters to the JSC
bindings generator:
http://www.w3.org/TR/WebIDL/#idl-named-properties

Drop support for outdated [NamedGetter] IDL extended attribute.

Support for other kinds of named properties will be added in later
patches. This patch only brings named property getters.

This patch is based on Blink r149247 by kojih@chromium.org.

No new tests, no behavior change.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GetSpecialAccessorFunctionForType):
(GetNamedGetterFunction):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/IDLParser.pm:
(applyTypedefs):
(parseSpecialOperation):
(parseSpecials):
(applyMemberList):
* bindings/scripts/test/TestEventTarget.idl:
* css/StyleSheetList.idl:
* dom/DOMNamedFlowCollection.idl:
* dom/DOMStringMap.idl:
* dom/NamedNodeMap.idl:
* dom/NodeList.idl:
* html/HTMLAllCollection.idl:
* html/HTMLCollection.idl:
* html/HTMLFormControlsCollection.idl:
* html/HTMLPropertiesCollection.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:
* storage/Storage.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add fallback for EWK2UnitTestBase if opengl is not available.
commit-queue@webkit.org [Tue, 11 Jun 2013 12:12:31 +0000 (12:12 +0000)]
[EFL][WK2] Add fallback for EWK2UnitTestBase if opengl is not available.
https://bugs.webkit.org/show_bug.cgi?id=117504

Patch by Changhyup Jwa <ch.jwa@samsung.com> on 2013-06-11
Reviewed by Christophe Dumez.

There're many fails on efl webkit2 unit test if opengl is not available.
So, add fallback to non-opengl evas engine.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::SetUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][EFL][GTK]fast/regions/overflow-size-change-with-stacking-context-rtl.html fails...
mihnea@adobe.com [Tue, 11 Jun 2013 08:48:10 +0000 (08:48 +0000)]
[Qt][EFL][GTK]fast/regions/overflow-size-change-with-stacking-context-rtl.html fails after r151202
https://bugs.webkit.org/show_bug.cgi?id=117295

Reviewed by Alexandru Chiculita.

Both test specify margins auto, which means that they can be computed to floats.
I changed the tests so that the margins are computed to integer values, to avoid
possible differences on platforms that enable subpixel layout.

* fast/regions/overflow-size-change-with-stacking-context-rtl-expected.html:
* fast/regions/overflow-size-change-with-stacking-context-rtl.html:
* platform/qt/TestExpectations: Unskip the skipped test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake WTR use its own temporary directory for application cache
ossy@webkit.org [Tue, 11 Jun 2013 08:39:57 +0000 (08:39 +0000)]
Make WTR use its own temporary directory for application cache
https://bugs.webkit.org/show_bug.cgi?id=117143

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

* UIProcess/API/C/WKContext.cpp:
(WKContextSetApplicationCacheDirectory):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::applicationCacheDirectory):
* UIProcess/WebContext.h:
(WebKit::WebContext::setApplicationCacheDirectory):
* UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformDefaultApplicationCacheDirectory):

Tools:

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Fix test_ewk2_context_menu
commit-queue@webkit.org [Tue, 11 Jun 2013 08:35:48 +0000 (08:35 +0000)]
[EFL][WK2] Fix test_ewk2_context_menu
https://bugs.webkit.org/show_bug.cgi?id=116601

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-06-11
Reviewed by Gyuyoung Kim.

test_ewk2_context_menu is always passing, it does not test any context menu feature
as it ends before context menu is called.
One single test was divided into two tests: testing WebKit2 created context menu and
testing menus and items created by application.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::waitUntilTrue): added function introducing internal loop until boolean value is changed to true
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
* UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
(customItemSelected):
(showContextMenu):
(showContextMenuForRemoveAndAppend):
(showContextMenuForSubmenu):
(hideContextMenu):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add ewk_view_navigate API
ryuan.choi@samsung.com [Tue, 11 Jun 2013 08:10:24 +0000 (08:10 +0000)]
[EFL][WK2] Add ewk_view_navigate API
https://bugs.webkit.org/show_bug.cgi?id=117467

Reviewed by Christophe Dumez.

The applications will use this API to navigate history more than one step.

* UIProcess/API/efl/ewk_back_forward_list_item_private.h:
(EwkBackForwardListItem::wkItem): Return WKBackForwardListItemRef for page to navigate.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_navigate_to): Added new API.
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F): Added more test case for navigation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Test editing/execCommand/indent-paragraphs.html times out
commit-queue@webkit.org [Tue, 11 Jun 2013 07:57:49 +0000 (07:57 +0000)]
[BlackBerry] Test editing/execCommand/indent-paragraphs.html times out
https://bugs.webkit.org/show_bug.cgi?id=117235

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-06-11
Reviewed by Rob Buis.

PR 346414.

After r150224 ResourceHandle::start() can fail returning false so
that the ResourceHandle is destroyed and the error not
handled. Handle the errors by scheduling a InvalidURLFailure and
returning true when startJob fails to make sure the ResourceHandle
is not destroyed and the error is handled and notified to the
client.

Fixes timeout in editing/execCommand/indent-paragraphs.html.

* platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove IntRect::pixelSnapped* and its enclosingRect since they are no longer used
rniwa@webkit.org [Tue, 11 Jun 2013 07:34:42 +0000 (07:34 +0000)]
Remove IntRect::pixelSnapped* and its enclosingRect since they are no longer used
https://bugs.webkit.org/show_bug.cgi?id=117494

Reviewed by Darin Adler.

Merge: https://chromium.googlesource.com/chromium/blink/+/9433dc00e882e2808ac1db3c1fd89090896d7b58
       https://chromium.googlesource.com/chromium/blink/+/7beaa73aa099170cb2cad02c12c5e0a448b12c21

* inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
* platform/graphics/IntRect.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::hitTestCulledInline):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAutoclose braces and parentheses at the end of style sheet
sergio@webkit.org [Tue, 11 Jun 2013 07:10:00 +0000 (07:10 +0000)]
Autoclose braces and parentheses at the end of style sheet
https://bugs.webkit.org/show_bug.cgi?id=117414

Reviewed by Andreas Kling.

From Blink r150202 by <serya@chromium.org>

Source/WebCore:

Use closing_parenthesis and closing_brace instead of the literals
'}' and ')'. This allows the parser to treat expressions with
unmatched closing braces/parenthesis as if all of them were
actually closed.

Tests: animations/keyframe-autoclose-brace.html
       css3/autoclose-braces-and-parentheses.html

* css/CSSGrammar.y.in:

LayoutTests:

* animations/keyframe-autoclose-brace-expected.txt: Added.
* animations/keyframe-autoclose-brace.html: Added.
* css3/autoclose-braces-and-parentheses-expected.txt: Added.
* css3/autoclose-braces-and-parentheses.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CoordinatedGraphics] Typos in custom shader support
commit-queue@webkit.org [Tue, 11 Jun 2013 05:47:40 +0000 (05:47 +0000)]
[CoordinatedGraphics] Typos in custom shader support
https://bugs.webkit.org/show_bug.cgi?id=117413

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-06-10
Reviewed by Noam Rosenthal.

Wrong keyframe is passed when assigning filterValue.

Source/WebCore:

* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerAnimationsIfNeeded):

Source/WebKit2:

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotext-transform: capitalize shouldn't upconvert
rniwa@webkit.org [Tue, 11 Jun 2013 05:40:28 +0000 (05:40 +0000)]
text-transform: capitalize shouldn't upconvert
https://bugs.webkit.org/show_bug.cgi?id=117485

Reviewed by Adam Barth.

Avoid the upconversion. Merge https://chromium.googlesource.com/chromium/blink/+/c5a221d6da2443df0639c01c40aac6040908ec79.

* rendering/RenderText.cpp:
(WebCore::makeCapitalized):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDocType strings should be 8 bit wide
rniwa@webkit.org [Tue, 11 Jun 2013 05:37:51 +0000 (05:37 +0000)]
DocType strings should be 8 bit wide
https://bugs.webkit.org/show_bug.cgi?id=117487

Reviewed by Michael Saboff.

Merge https://chromium.googlesource.com/chromium/blink/+/8da02d0ce3965c4e6bf227db856bce930393429a.

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertDoctype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][GTK] Build fix after r151403
ossy@webkit.org [Tue, 11 Jun 2013 04:47:42 +0000 (04:47 +0000)]
[Qt][GTK] Build fix after r151403
https://bugs.webkit.org/show_bug.cgi?id=117452

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-06-10
Reviewed by Csaba Osztrogonác.

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::preferencesDidChange):
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/qt/raw/qrawwebview_p_p.h:
(QRawWebViewPrivate::preferencesDidChange):
* UIProcess/qt/QtPageClient.h:
(WebKit::QtPageClient::preferencesDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse shouldBeType in animations/keyframes-rule.html
rniwa@webkit.org [Tue, 11 Jun 2013 04:16:18 +0000 (04:16 +0000)]
Use shouldBeType in animations/keyframes-rule.html
https://bugs.webkit.org/show_bug.cgi?id=117439

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/7eb727a7d5765eaa1779e00a45ac9f63e2e0047f

* animations/keyframes-rule-expected.txt:
* animations/keyframes-rule.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, EFL gardening. Fix wrong expectation result on 151416.
gyuyoung.kim@samsung.com [Tue, 11 Jun 2013 02:31:34 +0000 (02:31 +0000)]
Unreviewed, EFL gardening. Fix wrong expectation result on 151416.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, EFL gardening. Manage tests which need to implement repaint rect.
gyuyoung.kim@samsung.com [Tue, 11 Jun 2013 01:15:44 +0000 (01:15 +0000)]
Unreviewed, EFL gardening. Manage tests which need to implement repaint rect.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake more functions const
rniwa@webkit.org [Tue, 11 Jun 2013 01:11:21 +0000 (01:11 +0000)]
Make more functions const
https://bugs.webkit.org/show_bug.cgi?id=117455

Reviewed by Benjamin Poulain.

Merge https://chromium.googlesource.com/chromium/blink/+/886866f5034d7f30f8aa607b909313f99db1f3b4.

* editing/VisibleUnits.cpp:
(WebCore::CachedLogicallyOrderedLeafBoxes::boxIndexInLeaves):
* html/canvas/WebGLRenderingContext.cpp:
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::evalDisabledErrorMessage):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shouldIndentText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r151411.
gyuyoung.kim@samsung.com [Tue, 11 Jun 2013 00:47:14 +0000 (00:47 +0000)]
Unreviewed, rolling out r151411.
http://trac.webkit.org/changeset/151411
https://bugs.webkit.org/show_bug.cgi?id=117453

because it is duplicated with Bug 117441 (Requested by
gyuyoung_ on #webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2013-06-10

* UIProcess/efl/WebViewEfl.cpp:
* UIProcess/efl/WebViewEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build error and warning
commit-queue@webkit.org [Tue, 11 Jun 2013 00:46:41 +0000 (00:46 +0000)]
Fix build error and warning
https://bugs.webkit.org/show_bug.cgi?id=117441

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-06-10
Reviewed by Anders Carlsson.

* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::preferencesDidChange): Added.
(WebKit::WebView::createPopupMenuProxy): Remove 'page'.
* UIProcess/CoordinatedGraphics/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=117449
ap@apple.com [Tue, 11 Jun 2013 00:38:55 +0000 (00:38 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=117449
Remove dead code for storing fonts in __DATA section

Reviewed by Dan Bernstein.

* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
Don't copy font resources to __DATA, as we don't have any code that reads them
from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").

* DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
* WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
Removed comments suggesting that we want to restore the old solution.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, EFL Build fix after r151403.
gyuyoung.kim@samsung.com [Tue, 11 Jun 2013 00:27:44 +0000 (00:27 +0000)]
Unreviewed, EFL Build fix after r151403.

Added preferencesDidChange to WebViewEfl.

* UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebViewEfl::preferencesDidChange):
* UIProcess/efl/WebViewEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r151302): Many broken webaudio/ tests on Mac port.
jer.noble@apple.com [Tue, 11 Jun 2013 00:07:07 +0000 (00:07 +0000)]
REGRESSION(r151302): Many broken webaudio/ tests on Mac port.
https://bugs.webkit.org/show_bug.cgi?id=117446

Reviewed by Chris Rogers.

Source/WebCore:

The new "pageConsentRequiredForAudioStart()" restriction was blocking playback event
even when page consent was given. Remvoe the restriction immediately in that case.

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::startRendering):

LayoutTests:

Re-enable the tests on mac-wk2 and add new baselines for codec and audiobuffersource tests.

* platform/mac-wk2/TestExpectations:
* platform/mac-wk2/webaudio/audiobuffersource-loop-points-expected.wav: Added.
* platform/mac-wk2/webaudio/audiobuffersource-playbackrate-expected.wav: Added.
* platform/mac-wk2/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
* platform/mac-wk2/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
* platform/mac-wk2/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in StorageAreaMap::applyChange when clearing local storage in another web process
andersca@apple.com [Mon, 10 Jun 2013 23:43:38 +0000 (23:43 +0000)]
Crash in StorageAreaMap::applyChange when clearing local storage in another web process
https://bugs.webkit.org/show_bug.cgi?id=117440
<rdar://problem/13961548>

Reviewed by Tim Horton.

Add an early return so we won't try to look up a null key in the m_pendingValueChanges map.
Also, fix an assertion - it's fine for m_storageMap to be null in applyChange.

* WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::applyChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange WebKitLibraries/win folder structure around.
roger_fong@apple.com [Mon, 10 Jun 2013 23:16:02 +0000 (23:16 +0000)]
Change WebKitLibraries/win folder structure around.
<rdar://problem/14097829>

Reviewed by Lucas Forschler.

* win/WinTools.make: Copied from win/tools32/WinTools.make.
* win/tools32/WinTools.make: Removed.
* win/tools64: Copied from win/tools32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[JSC] Remove a vestige of wxWidgets support.
rakuco@webkit.org [Mon, 10 Jun 2013 22:28:40 +0000 (22:28 +0000)]
[JSC] Remove a vestige of wxWidgets support.
https://bugs.webkit.org/show_bug.cgi?id=117419

Reviewed by Benjamin Poulain.

* runtime/JSExportMacros.h: Remove a check for BUILDING_WX__ that
seems to have gone unnoticed when the wxWidgets port was removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][CoordinatedGraphics] Add default case to switches to fix strict build
commit-queue@webkit.org [Mon, 10 Jun 2013 22:10:09 +0000 (22:10 +0000)]
[WK2][CoordinatedGraphics] Add default case to switches to fix strict build
https://bugs.webkit.org/show_bug.cgi?id=117416

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-06-10
Reviewed by Noam Rosenthal.

This patch fixes a strict build by asserting on the default case of two
switch statements where gcc was previously complaining of unhandled cases.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r150633): Find on page non-focused text highlight color is bright yellow.
akling@apple.com [Mon, 10 Jun 2013 21:36:51 +0000 (21:36 +0000)]
REGRESSION(r150633): Find on page non-focused text highlight color is bright yellow.
<rdar://problem/14098882>
<http://webkit.org/b/117371>

Reviewed by Anders Carlsson.

There was a mistake in the parameter ordering which still compiled because of
implicit bool/unsigned conversion.
Changed the interface of Page::findMatchesForText() to use enums instead of bools.

No test because the color of the highlighted matches is not available through APIs.

* page/Page.h:
* page/Page.cpp:
(WebCore::Page::findMatchesForText):
(WebCore::Page::markAllMatchesForText):
(WebCore::Page::countFindMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago-[WKView _updateWindowAndViewFrames] should avoid updating the view frame in window...
andersca@apple.com [Mon, 10 Jun 2013 21:32:35 +0000 (21:32 +0000)]
-[WKView _updateWindowAndViewFrames] should avoid updating the view frame in window coordinates if we don't have plugins
https://bugs.webkit.org/show_bug.cgi?id=117420
<rdar://problem/14073034>

Reviewed by Tim Horton.

If plug-ins are disabled there's no need for the web process to know about the view frame in window coordinates so only
send it when plug-ins are enabled. In addition, if accessibility is disabled we don't need to send a message at all.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::preferencesDidChange):
Call through to -[WKView _preferencesDidChange].

* UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowAndViewFrames]):
Don't compute viewFrameInWindowCoordinates or accessibilityPosition unless they're required. If neither are required,
don't even send a message to the web process.

(-[WKView _preferencesDidChange]):
Update _needsViewFrameInWindowCoordinates and call -[WKView _updateWindowAndViewFrames] if needed.

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
Set _needsViewFrameInWindowCoordinates based on whether plug-ins are enabled or not.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::preferencesDidChange):
Call the page client.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
betravis@adobe.com [Mon, 10 Jun 2013 21:23:45 +0000 (21:23 +0000)]
[CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
https://bugs.webkit.org/show_bug.cgi?id=117162

Reviewed by Alexandru Chiculita.

Source/WebCore:

With the split between the CSS Exclusions and CSS Shapes specifications,
some renaming is necessary. In general, this patch removes 'Exclusion' from
any Shapes code, while organizing the rendering shapes code into a 'shapes'
folder.

Renames:
ExclusionShape -> Shape
Exclusion[Rectangle|Polygon] -> [Rectangle|Polygon]Shape
Exclusion -> Shape

Refactoring, no new tests.

* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.pri:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSPrimitiveValue.h:
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyShape::setValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyShape::createHandler):
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
(WebCore::PropertyWrapperShape::PropertyWrapperShape):
(WebCore::CSSPropertyAnimation::ensurePropertyMap):
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
* rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::shapeInsideInfo):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateShapeInsideInfoAfterStyleChange):
(WebCore::shapeInfoRequiresRelayout):
(WebCore::RenderBlock::updateRegionsAndExclusionsBeforeChildLayout):
(WebCore::RenderBlock::computeShapeSize):
(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::computeLogicalLocationForFloat):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::ensureShapeInsideInfo):
(WebCore::RenderBlock::shapeInsideInfo):
(WebCore::RenderBlock::setShapeInsideInfo):
(WebCore::RenderBlock::allowsShapeInsideInfoSharing):
(WebCore::RenderBlock::xPositionForFloatIncludingMargin):
(WebCore::RenderBlock::yPositionForFloatIncludingMargin):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutShapeInsideInfo):
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::constructBidiRunsForLine):
(WebCore::adjustLogicalLineTop):
(WebCore::RenderBlock::updateLineBoundariesForShapes):
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange):
* rendering/RenderBox.h:
(WebCore::RenderBox::shapeOutsideInfo):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintOffset):
* rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
* rendering/shapes/PolygonShape.cpp: Renamed from Source/WebCore/rendering/ExclusionPolygon.cpp.
(WebCore::leftSide):
(WebCore::isReflexVertex):
(WebCore::computeXIntersection):
(WebCore::inwardEdgeNormal):
(WebCore::outwardEdgeNormal):
(WebCore::appendArc):
(WebCore::snapVerticesToLayoutUnitGrid):
(WebCore::computeShapePaddingBounds):
(WebCore::computeShapeMarginBounds):
(WebCore::PolygonShape::shapePaddingBounds):
(WebCore::PolygonShape::shapeMarginBounds):
(WebCore::getVertexIntersectionVertices):
(WebCore::appendIntervalX):
(WebCore::compareEdgeIntersectionX):
(WebCore::computeXIntersections):
(WebCore::computeOverlappingEdgeXProjections):
(WebCore::PolygonShape::getExcludedIntervals):
(WebCore::PolygonShape::getIncludedIntervals):
(WebCore::firstFitRectInPolygon):
(WebCore::aboveOrToTheLeft):
(WebCore::PolygonShape::firstIncludedIntervalLogicalTop):
* rendering/shapes/PolygonShape.h: Renamed from Source/WebCore/rendering/ExclusionPolygon.h.
(WebCore::OffsetPolygonEdge::OffsetPolygonEdge):
(WebCore::OffsetPolygonEdge::edgeIndex):
(WebCore::OffsetPolygonEdge::basis):
(WebCore::PolygonShape::PolygonShape):
* rendering/shapes/RectangleShape.cpp: Renamed from Source/WebCore/rendering/ExclusionRectangle.cpp.
(WebCore::ellipseXIntercept):
(WebCore::ellipseYIntercept):
(WebCore::FloatRoundedRect::paddingBounds):
(WebCore::FloatRoundedRect::marginBounds):
(WebCore::FloatRoundedRect::cornerInterceptForWidth):
(WebCore::RectangleShape::shapePaddingBounds):
(WebCore::RectangleShape::shapeMarginBounds):
(WebCore::RectangleShape::getExcludedIntervals):
(WebCore::RectangleShape::getIncludedIntervals):
(WebCore::RectangleShape::firstIncludedIntervalLogicalTop):
* rendering/shapes/RectangleShape.h: Renamed from Source/WebCore/rendering/ExclusionRectangle.h.
(WebCore::FloatRoundedRect::FloatRoundedRect):
(WebCore::FloatRoundedRect::rx):
(WebCore::FloatRoundedRect::ry):
(WebCore::RectangleShape::RectangleShape):
* rendering/shapes/Shape.cpp: Renamed from Source/WebCore/rendering/ExclusionShape.cpp.
(WebCore::createRectangleShape):
(WebCore::createShapeCircle):
(WebCore::createShapeEllipse):
(WebCore::createPolygonShape):
(WebCore::physicalRectToLogical):
(WebCore::physicalPointToLogical):
(WebCore::physicalSizeToLogical):
(WebCore::Shape::createShape):
* rendering/shapes/Shape.h: Renamed from Source/WebCore/rendering/ExclusionShape.h.
(WebCore::LineSegment::LineSegment):
(WebCore::Shape::~Shape):
(WebCore::Shape::shapeMargin):
(WebCore::Shape::shapePadding):
* rendering/shapes/ShapeInfo.cpp: Renamed from Source/WebCore/rendering/ExclusionShapeInfo.cpp.
(WebCore::::computedShape):
(WebCore::::computeSegmentsForLine):
* rendering/shapes/ShapeInfo.h: Renamed from Source/WebCore/rendering/ExclusionShapeInfo.h.
(WebCore::MappedInfo::ensureInfo):
(WebCore::MappedInfo::removeInfo):
(WebCore::MappedInfo::info):
(WebCore::MappedInfo::infoMap):
(WebCore::ShapeInfo::~ShapeInfo):
(WebCore::ShapeInfo::setShapeSize):
(WebCore::ShapeInfo::clearSegments):
(WebCore::ShapeInfo::shapeLogicalTop):
(WebCore::ShapeInfo::shapeLogicalBottom):
(WebCore::ShapeInfo::shapeLogicalLeft):
(WebCore::ShapeInfo::shapeLogicalRight):
(WebCore::ShapeInfo::shapeLogicalWidth):
(WebCore::ShapeInfo::shapeLogicalHeight):
(WebCore::ShapeInfo::logicalLineTop):
(WebCore::ShapeInfo::logicalLineBottom):
(WebCore::ShapeInfo::shapeContainingBlockHeight):
(WebCore::ShapeInfo::lineOverlapsShapeBounds):
(WebCore::ShapeInfo::lineWithinShapeBounds):
(WebCore::ShapeInfo::dirtyShapeSize):
(WebCore::ShapeInfo::shapeSizeDirty):
(WebCore::ShapeInfo::owner):
(WebCore::ShapeInfo::ShapeInfo):
(WebCore::ShapeInfo::logicalTopOffset):
(WebCore::ShapeInfo::logicalLeftOffset):
* rendering/shapes/ShapeInsideInfo.cpp: Renamed from Source/WebCore/rendering/ExclusionShapeInsideInfo.cpp.
(WebCore::LineSegmentRange::LineSegmentRange):
(WebCore::ShapeInsideInfo::isEnabledFor):
(WebCore::ShapeInsideInfo::adjustLogicalLineTop):
* rendering/shapes/ShapeInsideInfo.h: Renamed from Source/WebCore/rendering/ExclusionShapeInsideInfo.h.
(WebCore::LineSegmentIterator::LineSegmentIterator):
(WebCore::ShapeInsideInfo::createInfo):
(WebCore::ShapeInsideInfo::hasSegments):
(WebCore::ShapeInsideInfo::segments):
(WebCore::ShapeInsideInfo::segmentRanges):
(WebCore::ShapeInsideInfo::currentSegment):
(WebCore::ShapeInsideInfo::setNeedsLayout):
(WebCore::ShapeInsideInfo::needsLayout):
(WebCore::ShapeInsideInfo::ShapeInsideInfo):
* rendering/shapes/ShapeInterval.cpp: Renamed from Source/WebCore/rendering/ExclusionInterval.cpp.
(WebCore::IntervalX1Comparator::operator()):
(WebCore::ShapeInterval::intersect):
(WebCore::sortShapeIntervals):
(WebCore::mergeShapeIntervals):
(WebCore::intersectShapeIntervals):
(WebCore::subtractShapeIntervals):
* rendering/shapes/ShapeInterval.h: Renamed from Source/WebCore/rendering/ExclusionInterval.h.
(WebCore::ShapeInterval::ShapeInterval):
* rendering/shapes/ShapeOutsideInfo.cpp: Renamed from Source/WebCore/rendering/ExclusionShapeOutsideInfo.cpp.
(WebCore::ShapeOutsideInfo::isEnabledFor):
(WebCore::ShapeOutsideInfo::computeSegmentsForLine):
* rendering/shapes/ShapeOutsideInfo.h: Renamed from Source/WebCore/rendering/ExclusionShapeOutsideInfo.h.
(WebCore::ShapeOutsideInfo::shapeLogicalOffset):
(WebCore::ShapeOutsideInfo::leftSegmentShapeBoundingBoxDelta):
(WebCore::ShapeOutsideInfo::rightSegmentShapeBoundingBoxDelta):
(WebCore::ShapeOutsideInfo::createInfo):
(WebCore::ShapeOutsideInfo::ShapeOutsideInfo):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::initialShapeInside):
* rendering/style/RenderStyle.h:
* rendering/style/ShapeValue.h: Renamed from Source/WebCore/rendering/style/ExclusionShapeValue.h.
(WebCore::ShapeValue::createShapeValue):
(WebCore::ShapeValue::createOutsideValue):
(WebCore::ShapeValue::createImageValue):
(WebCore::ShapeValue::type):
(WebCore::ShapeValue::shape):
(WebCore::ShapeValue::image):
(WebCore::ShapeValue::setImage):
(WebCore::ShapeValue::operator==):
(WebCore::ShapeValue::ShapeValue):
* rendering/style/StyleRareNonInheritedData.h:

Source/WebKit:

Adding the WebCore/rendering/shapes directory to the include list.

* CMakeLists.txt:

Source/WebKit2:

Adding the WebCore/rendering/shapes directory to the include list.

* CMakeLists.txt:

Tools:

Adding the WebCore/rendering/shapes directory to the include list.

* DumpRenderTree/efl/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse Cairo implementation of the WidgetBackingStore instead of X11 when running on...
commit-queue@webkit.org [Mon, 10 Jun 2013 19:06:15 +0000 (19:06 +0000)]
Use Cairo implementation of the WidgetBackingStore instead of X11 when running on Wayland
https://bugs.webkit.org/show_bug.cgi?id=116717

Patch by Iago Toral Quiroga <itoral@igalia.com> on 2013-06-10
Reviewed by Martin Robinson.

Source/WebCore:

Refactored WidgetBackingStore to be an abstract base class and make
GtkWidgetBackingStoreX11 and WidgetBackingStoreCairo inherit from it.
GtkWidgetBackingStoreX11 renamed to WidgetBackingStoreGtkX11.

* GNUmakefile.list.am:
* platform/cairo/WidgetBackingStore.h:
(WebCore):
(WidgetBackingStore):
(WebCore::WidgetBackingStore::WidgetBackingStore):
(WebCore::WidgetBackingStore::~WidgetBackingStore):
* platform/cairo/WidgetBackingStoreCairo.cpp:
(WebCore::WidgetBackingStoreCairo::create):
(WebCore):
(WebCore::WidgetBackingStoreCairo::WidgetBackingStoreCairo):
(WebCore::WidgetBackingStoreCairo::~WidgetBackingStoreCairo):
(WebCore::WidgetBackingStoreCairo::cairoSurface):
(WebCore::WidgetBackingStoreCairo::scroll):
* platform/cairo/WidgetBackingStoreCairo.h: Added.
(WebCore):
(WidgetBackingStoreCairo):
* platform/gtk/GtkWidgetBackingStoreX11.cpp:
(WebCore::WidgetBackingStoreGtkX11::create):
(WebCore):
(WebCore::WidgetBackingStoreGtkX11::WidgetBackingStoreGtkX11):
(WebCore::WidgetBackingStoreGtkX11::~WidgetBackingStoreGtkX11):
(WebCore::WidgetBackingStoreGtkX11::cairoSurface):
(WebCore::WidgetBackingStoreGtkX11::scroll):
* platform/gtk/GtkWidgetBackingStoreX11.h: Added.
(WebCore):
(WidgetBackingStoreGtkX11):

Source/WebKit/gtk:

Decide which implementation of WidgetBackingStore to use (X11 or Cairo)
depending on whether we are running on X11 or not. Select Cairo
implementation when not running in X11.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::createBackingStore):
(WebKit):
(WebKit::ChromeClient::widgetSizeChanged):
(WebKit::ChromeClient::attachRootGraphicsLayer):

Source/WebKit2:

Decide which implementation of WidgetBackingStore to use (X11 or Cairo)
depending on whether we are running on X11 or not. Select Cairo
implementation when not running in X11.

* UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit):
(WebKit::createBackingStoreForGTK):
(WebKit::BackingStore::incorporateUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Store ParsedCookies as RefPtrs instead of PassRefPtrs in CookieDatabaseB...
commit-queue@webkit.org [Mon, 10 Jun 2013 17:45:42 +0000 (17:45 +0000)]
[BlackBerry] Store ParsedCookies as RefPtrs instead of PassRefPtrs in CookieDatabaseBackingStore
https://bugs.webkit.org/show_bug.cgi?id=117411

JIRA388672
BRWSR-11465
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-06-10
Reviewed by Rob Buis.

When we queue up ParsedCookie objects for modification, we should be storing them as a refptr instead
of a PassRefPtr.

* platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions] ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoi...
mihnea@adobe.com [Mon, 10 Jun 2013 16:27:42 +0000 (16:27 +0000)]
[CSSRegions] ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result) in RenderGeometryMap::mapToContainer
https://bugs.webkit.org/show_bug.cgi?id=117395

Reviewed by Alexandru Chiculita.

Source/WebCore:

Test: fast/regions/assert-flow-thread-compositing.html

We should not allow RenderNamedFlowThread layers to be composited, rather their collected children should checked
for compositing through their associated RenderRegions.

The assert in RenderGeometryMap::mapToContainer was hit because after https://bugs.webkit.org/show_bug.cgi?id=117270
the render named flow threads are hooked in RenderView layer tree - with the caveat that they are not directly involved
in hit testing/paint which is done through their associated regions.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Bail out if we hit a render named flow thread layer.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Ditto.

LayoutTests:

* fast/regions/assert-flow-thread-compositing-expected.txt: Added.
* fast/regions/assert-flow-thread-compositing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor CALCFUNCTION rules in the CSS grammar
sergio@webkit.org [Mon, 10 Jun 2013 15:26:02 +0000 (15:26 +0000)]
Refactor CALCFUNCTION rules in the CSS grammar
https://bugs.webkit.org/show_bug.cgi?id=117401

Reviewed by Andreas Kling.

From Blink r149862 by <serya@chromium.org>.

Reduce the number of CALCFUNCTION rules by refactoring the closing
parenthesis handling code.

No new tests required as this is a refactoring, no new functionality
added.

* css/CSSGrammar.y.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Rename region-overflow to region-fragment
commit-queue@webkit.org [Mon, 10 Jun 2013 14:19:13 +0000 (14:19 +0000)]
[CSS Regions] Rename region-overflow to region-fragment
https://bugs.webkit.org/show_bug.cgi?id=117397

PerformanceTests:

Renamed -webkit-region-overflow to -webkit-region-fragment according to the new working draft
at http://www.w3.org/TR/2013/WD-css3-regions-20130528/#the-region-fragment-property

Patch by Radu Stavila <stavila@adobe.com> on 2013-06-10
Reviewed by Alexander Pavlov.

* Layout/resources/regions.css:

Source/WebCore:

Renamed -webkit-region-overflow to -webkit-region-fragment and
webkitRegionOverflow to webkitRegionFragment according to the new working draft
at http://www.w3.org/TR/2013/WD-css3-regions-20130528/#the-region-fragment-property

Patch by Radu Stavila <stavila@adobe.com> on 2013-06-10
Reviewed by Alexander Pavlov.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator RegionFragment):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSValueKeywords.in:
* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::hasNextPage):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

Renamed -webkit-region-overflow to -webkit-region-fragment and
webkitRegionOverflow to webkitRegionFragment according to the new working draft
at http://www.w3.org/TR/2013/WD-css3-regions-20130528/#the-region-fragment-property

Patch by Radu Stavila <stavila@adobe.com> on 2013-06-10
Reviewed by Alexander Pavlov.

* fast/regions/autoheight-breakafteralways-maxheight.html:
* fast/regions/autoheight-breakbeforealways.html:
* fast/regions/autoheight-singleregion-breakafteralways-maxheight.html:
* fast/regions/autoheight-singleregion-breakafteralways.html:
* fast/regions/autoheight-singleregion-breakaftermargin.html:
* fast/regions/autoheight-singleregion-breakbeforealways-minheight.html:
* fast/regions/autoheight-singleregion-breakbeforealways.html:
* fast/regions/autoheight-singleregion-multiplebreaks.html:
* fast/regions/css-regions-disabled-expected.txt:
* fast/regions/region-overflow-auto-overflow-hidden.html:
* fast/regions/region-overflow-auto-overflow-visible.html:
* fast/regions/region-overflow-break.html:
* fast/regions/regions-widows-and-orphans.html:
* fast/regions/script-tests/css-regions-disabled.js:
* fast/regions/script-tests/webkit-region-overflow-parsing.js:
* fast/regions/webkit-region-overflow-parsing-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace [ConstructorRaisesException] with [RaisesException]
ch.dumez@sisa.samsung.com [Mon, 10 Jun 2013 11:05:43 +0000 (11:05 +0000)]
Replace [ConstructorRaisesException] with [RaisesException]
https://bugs.webkit.org/show_bug.cgi?id=117400

Reviewed by Kentaro Hara.

Replace [ConstructorRaisesException] with [RaisesException] IDL extended
attribute and drop [ConstructorRaisesException]. It makes little sense
to have 2 extended attributes with the same meaning.

[RaisesException] can now be used on IDL operations to indicate that the
method may throw exceptions or on interfaces to indicate that the
constructor may throw exceptions.

From Blink r148027 by Kentaro Hara <haraken@chromium.org>.

No new tests, no behavior change.

* Modules/encryptedmedia/MediaKeys.idl:
* Modules/mediastream/RTCIceCandidate.idl:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/RTCSessionDescription.idl:
* Modules/webaudio/OfflineAudioContext.idl:
* Modules/websockets/WebSocket.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/TestInterface.idl:
* bindings/scripts/test/TestNamedConstructor.idl:
* css/WebKitCSSMatrix.idl:
* html/HTMLOptionElement.idl:
* page/EventSource.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: refactor statusBarItems getter in front-end.
commit-queue@webkit.org [Mon, 10 Jun 2013 10:09:38 +0000 (10:09 +0000)]
Web Inspector: refactor statusBarItems getter in front-end.
https://bugs.webkit.org/show_bug.cgi?id=110114

Patch by Mátyás Mustoha <mmatyas@inf.u-szeged.hu> on 2013-06-10
Reviewed by Noam Rosenthal.

Source/WebCore:

Refactored "statusBarItems" methods from getters into functions and
moved default implementation from Panel.js to View.js.

Patch created by Andrey Lushnikov.

* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype.statusBarItems):
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView.prototype.statusBarItems):
* inspector/front-end/AuditsPanel.js:
(WebInspector.AuditsPanel.prototype.statusBarItems):
* inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileView.prototype.statusBarItems):
* inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileView.prototype.statusBarItems):
* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype.statusBarItems):
(WebInspector.CanvasProfileType.prototype.statusBarItems):
* inspector/front-end/ConsolePanel.js:
(WebInspector.ConsolePanel.prototype.statusBarItems):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.statusBarItems):
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype.statusBarItems):
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype.statusBarItems):
* inspector/front-end/DatabaseTableView.js:
(WebInspector.DatabaseTableView.prototype.statusBarItems):
* inspector/front-end/Drawer.js:
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.statusBarItems):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel.prototype.statusBarItems):
* inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView.prototype.statusBarItems):
* inspector/front-end/HeapSnapshotView.js:
* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype.statusBarItems):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype.statusBarItems):
(WebInspector.NetworkPanel.prototype.statusBarItems):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.statusBarItems):
(WebInspector.ProfilesPanel.prototype.statusBarItems):
(WebInspector.ProfilesPanel.prototype._updateProfileTypeSpecificUI):
(WebInspector.ProfilesPanel.prototype._showProfile):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.statusBarItems):
(WebInspector.ResourcesPanel.prototype._innerShowView):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.statusBarItems):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.statusBarItems):
* inspector/front-end/View.js:
(WebInspector.View.prototype.statusBarItems):

LayoutTests:

Fix layout test to correspond to refactoring.
Patch created by Andrey Lushnikov.

* inspector/extensions/extensions-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd special tree walking for the single tag or class CSS query selectors
benjamin@webkit.org [Mon, 10 Jun 2013 08:04:04 +0000 (08:04 +0000)]
Add special tree walking for the single tag or class CSS query selectors
https://bugs.webkit.org/show_bug.cgi?id=117388

Reviewed by Ryosuke Niwa.

Queries for a single tag name or a single class name are the most common
input of querySelector.

This patch adds a simplified tree walking in those cases, only checking that particular
case instead of a full selector.

With the change, the balanced query selector benchmarks become 11% faster.

* css/SelectorCheckerFastPath.cpp:
(WebCore::HTMLNames::checkClassValue):
* dom/SelectorQuery.cpp:
(WebCore::isSingleTagNameSelector):
(WebCore::SelectorDataList::executeSingleTagNameSelectorData):
(WebCore::isSingleClassNameSelector):
(WebCore::SelectorDataList::executeSingleClassNameSelectorData):
(WebCore::SelectorDataList::execute):
* dom/SelectorQuery.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CoordinatedGraphics] Typo in argument decoder for CoordinatedGraphicsState
commit-queue@webkit.org [Mon, 10 Jun 2013 06:25:49 +0000 (06:25 +0000)]
[CoordinatedGraphics] Typo in argument decoder for CoordinatedGraphicsState
https://bugs.webkit.org/show_bug.cgi?id=117384

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-06-09
Reviewed by Noam Rosenthal.

For CSS Shaders, it must decode state.customFiltersToRemove instead of
state.updateAtlasesToRemove.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed test correction: Prevent DumpRenderTree crashes
bfulgham@apple.com [Mon, 10 Jun 2013 03:08:19 +0000 (03:08 +0000)]
[Windows] Unreviewed test correction:  Prevent DumpRenderTree crashes
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::role): Prevent crashes when m_element is null. This
happends in some of the 'accessibility' test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout info should never be cleared before delayed scroll information updates.
roger_fong@apple.com [Sun, 9 Jun 2013 21:22:03 +0000 (21:22 +0000)]
Layout info should never be cleared before delayed scroll information updates.
https://bugs.webkit.org/show_bug.cgi?id=116689.

Reviewed by Darin Adler.

Test: fast/flexbox/clear-overflow-before-scroll-update.html

Make sure that clearLayoutOverflow only gets called after layer()->updateScrollInfoAfterLayout().
Also move clearLayoutOverflow to RenderBlock so we can keep all the delayed scroll update logic in RenderBlock.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::finishDelayUpdateScrollInfo): Call clearLayoutOverflow here.
(WebCore::RenderBlock::layout): Only call clearLayoutOverflow here if scrolling isn't being delayed.
(WebCore::RenderBlock::clearLayoutOverflow): Remove clearLayoutOverflow, move into RenderBlock to keep delayed scrolling logic in the same file.
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
* rendering/RenderBox.h:
* rendering/RenderDeprecatedFlexibleBox.cpp: Should call updateScrollInfoAfterLayout, not layer()->updateScrollInfoAfterLayout(), so that it takes delayed scrolling logic into account.
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderGrid.cpp: Ditto
(WebCore::RenderGrid::layoutBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSplit the 3 paths of SelectorDataList::execute() into 3 separate functions
benjamin@webkit.org [Sun, 9 Jun 2013 20:57:49 +0000 (20:57 +0000)]
Split the 3 paths of SelectorDataList::execute() into 3 separate functions
https://bugs.webkit.org/show_bug.cgi?id=117378

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-09
Reviewed by Ryosuke Niwa.

Split those to have several small execute() fucntions instead of a giant one.

* dom/SelectorQuery.cpp:
(WebCore::selectorForIdLookup):
(WebCore::isTreeScopeRoot):
(WebCore::SelectorDataList::executeFastPathForIdSelector):
(WebCore::SelectorDataList::executeSingleSelectorData):
(WebCore::SelectorDataList::executeSingleMultiSelectorData):
(WebCore::SelectorDataList::execute):
* dom/SelectorQuery.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoScrolling with platformWidget and delegateScrolling is incorrectly clamped
benjamin@webkit.org [Sun, 9 Jun 2013 19:52:49 +0000 (19:52 +0000)]
Scrolling with platformWidget and delegateScrolling is incorrectly clamped
https://bugs.webkit.org/show_bug.cgi?id=117369
<rdar://problem/13985064>

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-09
Reviewed by Darin Adler.

The patch http://trac.webkit.org/changeset/142526 clamps the input position
in the ScrollView scroll range. This was done for the path to the ScrollingCoordinator.

The problem with that change is ScrollView::setScrollPosition() can delegate the scrolling
to either a platformWidget, or through delegateScrolling. After r142526, the position is clamped,
and we do not let those external scrolling mechanims handle the out-of-bound scrolling.

This patch fixes the issue by moving the threaded scrolling call to ScrollView,
after the delegate handling code.

* page/FrameView.cpp:
(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::requestScrollPositionUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Coordinated Graphics] Pass the ownership of GraphicsSurface explicitly
commit-queue@webkit.org [Sun, 9 Jun 2013 06:36:47 +0000 (06:36 +0000)]
[Coordinated Graphics] Pass the ownership of GraphicsSurface explicitly
https://bugs.webkit.org/show_bug.cgi?id=117379

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-06-08
Reviewed by Noam Rosenthal.

When creating WebCoordinatedSurface with GraphicsSurface, it is clearer
to pass the ownership of the created GraphicsSurface explicitly.

* Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agobefore/after generated content is not working with HTMLSummaryElement and HTMLDetails...
igor.o@sisa.samsung.com [Sun, 9 Jun 2013 02:43:55 +0000 (02:43 +0000)]
before/after generated content is not working with HTMLSummaryElement and HTMLDetailsElement.
https://bugs.webkit.org/show_bug.cgi?id=117374

Source/WebCore:

Allow before/after pseudo generated content be added in HTMLDetailsElement and HTMLSumamaryElement.

Reviewed by Ryosuke Niwa.

Test: fast/css-generated-content/details-summary-before-after.html

* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::childShouldCreateRenderer):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::childShouldCreateRenderer):

LayoutTests:

Reviewed by Ryosuke Niwa.

* fast/css-generated-content/details-summary-before-after.html: Added.
* platform/mac/fast/css-generated-content/details-summary-before-after-expected.txt: Added.
* platform/mac/fast/css-generated-content/details-summary-before-after-expected.png: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WebGL] Enable webgl-background-color test.
kalyan.kondapally@intel.com [Sat, 8 Jun 2013 23:58:12 +0000 (23:58 +0000)]
[EFL][WebGL] Enable webgl-background-color test.
https://bugs.webkit.org/show_bug.cgi?id=111428

Reviewed by Christophe Dumez.

This patch adds platform specific test expectation files for the
test and enables it for efl port.

* platform/efl/TestExpectations:
* platform/efl/compositing/webgl/webgl-background-color-expected.png: Added.
* platform/efl/compositing/webgl/webgl-background-color-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] TestWebKitAPI fails to link.
commit-queue@webkit.org [Sat, 8 Jun 2013 21:42:07 +0000 (21:42 +0000)]
[WinCairo] TestWebKitAPI fails to link.
https://bugs.webkit.org/show_bug.cgi?id=117345

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-08
Reviewed by Brent Fulgham.

Need to link with WTF.lib.

* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[curl] Allow headers with empty value
commit-queue@webkit.org [Sat, 8 Jun 2013 21:33:40 +0000 (21:33 +0000)]
[curl] Allow headers with empty value
https://bugs.webkit.org/show_bug.cgi?id=117344

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-08
Reviewed by Brent Fulgham.

No new tests, already covered by:
http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
http/tests/xmlhttprequest/post-blob-content-type-sync.html

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::initializeHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[curl] Handling of blob elements is incorrect
commit-queue@webkit.org [Sat, 8 Jun 2013 11:34:25 +0000 (11:34 +0000)]
[curl] Handling of blob elements is incorrect
https://bugs.webkit.org/show_bug.cgi?id=117301

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-08
Reviewed by Kenneth Rohde Christiansen.

No new tests, covered by existing ones:
http/tests/fileapi/xhr-send-form-data-filename-escaping.html
http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::getFormElementsCount): Resolve Blob elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoalesce multiple calls to WebPageProxy::windowAndViewFramesChanged
andersca@apple.com [Sat, 8 Jun 2013 00:11:34 +0000 (00:11 +0000)]
Coalesce multiple calls to WebPageProxy::windowAndViewFramesChanged
https://bugs.webkit.org/show_bug.cgi?id=117364
<rdar://problem/14042099>

Reviewed by Geoffrey Garen.

-[WKView _updateWindowAndViewFrames] can be called many times per run loop iteration so coalesce calls
to WebPageProxy::windowAndViewFrames using dispatch_async.

* UIProcess/API/mac/WKView.mm:
(-[WKView _updateWindowAndViewFrames]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMathML line fraction needs to parse number values
cfleizach@apple.com [Fri, 7 Jun 2013 23:25:48 +0000 (23:25 +0000)]
MathML line fraction needs to parse number values
https://bugs.webkit.org/show_bug.cgi?id=117305

Unreviewed. Rebaseline math fractions test on EFL.

* platform/efl/mathml/presentation/fractions-expected.png:
* platform/efl/mathml/presentation/fractions-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMathML line fraction needs to parse number values
cfleizach@apple.com [Fri, 7 Jun 2013 23:21:50 +0000 (23:21 +0000)]
MathML line fraction needs to parse number values
https://bugs.webkit.org/show_bug.cgi?id=117305

Unreviewed. Rebaseline math fractions test on GTK.

* platform/gtk/mathml/presentation/fractions-expected.png:
* platform/gtk/mathml/presentation/fractions-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Layers inside the RenderFlowThread should be collected by the layer...
achicu@adobe.com [Fri, 7 Jun 2013 22:36:23 +0000 (22:36 +0000)]
[CSS Regions] Layers inside the RenderFlowThread should be collected by the layer of RenderView
https://bugs.webkit.org/show_bug.cgi?id=117270

Reviewed by David Hyatt.

RenderNamedFlowThreads are attached to the RenderView, but they are painted
and hit-tested through their regions. The easiest way to prevent the RenderView
from seeing the RenderNamedFlowThreads as its own children was to avoid collecting
the layers of the RenderNamedFlowThreads as children layers of the RenderView.

However, most of the code is analyzing the layers tree starting from the root,
so having the RenderNamedFlowThread participate in the layer tree is needed
in order to enable compositing for layers inside the flow thread.

This patch makes the RenderNamedFlowThread visible to the RenderView, but
ignores it when iterates the children of the RenderView in paint and hit-test methods.

No new tests, no visible changes.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateLayerBounds):
(WebCore::RenderLayer::collectLayers):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions][CSS Shapes] Incorrect compile flag in LayoutState.h
betravis@adobe.com [Fri, 7 Jun 2013 22:04:59 +0000 (22:04 +0000)]
[CSS Exclusions][CSS Shapes] Incorrect compile flag in LayoutState.h
https://bugs.webkit.org/show_bug.cgi?id=117318

Reviewed by Alexandru Chiculita.

m_exclusionShapeInsideInfo should be guarded by the CSS_SHAPES flag,
not the CSS_EXCLUSIONS flag.

No tests required.

* rendering/LayoutState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of not very helpful test that fails only on some machines because xcrun is...
roger_fong@apple.com [Fri, 7 Jun 2013 21:53:48 +0000 (21:53 +0000)]
Get rid of not very helpful test that fails only on some machines because xcrun is not installed.

Rubberstamped by Ryousuke Niwa.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_build_check):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of outdated raises() from Web IDL
ch.dumez@sisa.samsung.com [Fri, 7 Jun 2013 21:27:17 +0000 (21:27 +0000)]
Get rid of outdated raises() from Web IDL
https://bugs.webkit.org/show_bug.cgi?id=117350

Reviewed by Darin Adler.

Source/WebCore:

Stop using "raises()" in the IDL as this is no longer part of the Web IDL
specification. Web IDL no longer specifies exceptions for operations. Instead
it is now explained in prose.

WebKit still needs to know if the method can throw an exception (but does not
need the exception name) so this patch adds a WebKit specific IDL extended
attribute: [RaisesException]. The naming is consistent with Blink.

This results in more standard and concise IDL. This also simplifies a lot
the code of the IDL parser.

No new tests, no behavior change.

* Modules/battery/BatteryManager.idl:
* Modules/encryptedmedia/MediaKeySession.idl:
* Modules/encryptedmedia/MediaKeys.idl:
* Modules/filesystem/DirectoryEntrySync.idl:
* Modules/filesystem/DirectoryReaderSync.idl:
* Modules/filesystem/EntrySync.idl:
* Modules/filesystem/FileEntrySync.idl:
* Modules/filesystem/FileWriter.idl:
* Modules/filesystem/FileWriterSync.idl:
* Modules/filesystem/WorkerContextFileSystem.idl:
* Modules/indexeddb/IDBCursor.idl:
* Modules/indexeddb/IDBDatabase.idl:
* Modules/indexeddb/IDBFactory.idl:
* Modules/indexeddb/IDBIndex.idl:
* Modules/indexeddb/IDBKeyRange.idl:
* Modules/indexeddb/IDBObjectStore.idl:
* Modules/indexeddb/IDBRequest.idl:
* Modules/indexeddb/IDBTransaction.idl:
* Modules/mediasource/MediaSource.idl:
* Modules/mediasource/SourceBuffer.idl:
* Modules/mediasource/SourceBufferList.idl:
* Modules/mediastream/MediaStream.idl:
* Modules/mediastream/MediaStreamTrack.idl:
* Modules/mediastream/NavigatorMediaStream.idl:
* Modules/mediastream/RTCDTMFSender.idl:
* Modules/mediastream/RTCDataChannel.idl:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/navigatorcontentutils/NavigatorContentUtils.idl:
* Modules/networkinfo/NetworkInfoConnection.idl:
* Modules/notifications/Notification.idl:
* Modules/notifications/NotificationCenter.idl:
* Modules/speech/SpeechRecognition.idl:
* Modules/vibration/NavigatorVibration.idl:
* Modules/webaudio/AudioBuffer.idl:
* Modules/webaudio/AudioContext.idl:
* Modules/webaudio/AudioNode.idl:
* Modules/webdatabase/DOMWindowWebDatabase.idl:
* Modules/webdatabase/DatabaseSync.idl:
* Modules/webdatabase/WorkerContextWebDatabase.idl:
* Modules/websockets/WebSocket.idl:
* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction):
(GenerateFunctions):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(GenerateConstructorDefinition):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/IDLParser.pm:
(parseOperationRest):
* bindings/scripts/test/TestEventTarget.idl:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestSupplemental.idl:
* bindings/scripts/test/TestTypedefs.idl:
* css/CSSHostRule.idl:
* css/CSSMediaRule.idl:
* css/CSSPrimitiveValue.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleSheet.idl:
* css/CSSSupportsRule.idl:
* css/FontLoader.idl:
* css/MediaList.idl:
* css/WebKitCSSMatrix.idl:
* dom/CharacterData.idl:
* dom/DOMImplementation.idl:
* dom/DataTransferItemList.idl:
* dom/Document.idl:
* dom/DocumentFragment.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/EventTarget.idl:
* dom/MessagePort.idl:
* dom/MutationObserver.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeIterator.idl:
* dom/Range.idl:
* dom/ShadowRoot.idl:
* dom/Text.idl:
* dom/WebKitNamedFlow.idl:
* fileapi/FileReader.idl:
* fileapi/FileReaderSync.idl:
* html/DOMTokenList.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLDialogElement.idl:
* html/HTMLElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLFrameElement.idl:
* html/HTMLIFrameElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLSelectElement.idl:
* html/HTMLTableElement.idl:
* html/HTMLTableRowElement.idl:
* html/HTMLTableSectionElement.idl:
* html/HTMLTextAreaElement.idl:
* html/HTMLVideoElement.idl:
* html/MediaController.idl:
* html/TimeRanges.idl:
* html/canvas/CanvasGradient.idl:
* html/canvas/CanvasRenderingContext2D.idl:
* html/canvas/DOMPath.idl:
* html/canvas/DataView.idl:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/WebGLDebugShaders.idl:
* html/canvas/WebGLRenderingContext.idl:
* html/track/AudioTrackList.idl:
* html/track/TextTrack.idl:
* html/track/TextTrackCue.idl:
* html/track/TextTrackList.idl:
* html/track/VideoTrackList.idl:
* loader/appcache/DOMApplicationCache.idl:
* page/Crypto.idl:
* page/DOMSelection.idl:
* page/DOMWindow.idl:
* page/EventSource.idl:
* page/History.idl:
* page/Performance.idl:
* storage/Storage.idl:
* svg/SVGAngle.idl:
* svg/SVGAnimationElement.idl:
* svg/SVGColor.idl:
* svg/SVGDocument.idl:
* svg/SVGLength.idl:
* svg/SVGLengthList.idl:
* svg/SVGLocatable.idl:
* svg/SVGMatrix.idl:
* svg/SVGNumberList.idl:
* svg/SVGPaint.idl:
* svg/SVGPathSegList.idl:
* svg/SVGPointList.idl:
* svg/SVGStringList.idl:
* svg/SVGTextContentElement.idl:
* svg/SVGTransformList.idl:
* testing/InternalSettings.idl:
* testing/Internals.idl:
* workers/AbstractWorker.idl:
* workers/DedicatedWorkerContext.idl:
* workers/Worker.idl:
* workers/WorkerContext.idl:
* xml/XMLHttpRequest.idl:
* xml/XMLHttpRequestUpload.idl:
* xml/XMLSerializer.idl:
* xml/XPathEvaluator.idl:
* xml/XPathExpression.idl:
* xml/XPathResult.idl:

Source/WebKit/win:

Replace raises() by [RaisesException].

* Interfaces/DOMEvents.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r151088): Crash navigating away from non-loaded main resources with non...
beidson@apple.com [Fri, 7 Jun 2013 20:52:40 +0000 (20:52 +0000)]
REGRESSION (r151088): Crash navigating away from non-loaded main resources with non-loaded scripts.
<rdar://problem/14052886> and https://bugs.webkit.org/show_bug.cgi?id=117278

Reviewed by Anders Carlsson.

Source/WebCore:

Test: http/tests/navigation/slow-loading-page-with-slow-script.php

* html/parser/HTMLScriptRunner.cpp:
(WebCore::HTMLScriptRunner::isPendingScriptReady): The script runner might be told about a script
  after it has already been detached (the main resource load has finished/failed/cancelled).
  Don't dereference a null document in that case.

LayoutTests:

* http/tests/navigation/slow-loading-page-with-slow-script-expected.txt: Added.
* http/tests/navigation/slow-loading-page-with-slow-script.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCompile WebCoreTestShimLibrary.cpp on iOS, but exclude the Carbon bits
aestes@apple.com [Fri, 7 Jun 2013 20:33:06 +0000 (20:33 +0000)]
Compile WebCoreTestShimLibrary.cpp on iOS, but exclude the Carbon bits
https://bugs.webkit.org/show_bug.cgi?id=117360

Reviewed by Mark Rowe.

In r150114 we tried to make the WebCoreTestShim target build on iOS by
excluding its only source file from the build. While this allowed the
target to build, it prevented the target's product (WebCoreTestShim.dylib)
from being created. This causes xcodebuild to fail if you ask it to
install the target.

Fix this by building the target's product on iOS. Just use the
preprocessor to exclude the bits that won't build on iOS.

* Configurations/WebCoreTestShim.xcconfig:
* testing/WebCoreTestShimLibrary.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReproducible crash with triple-finger-tap "define word" gesture on a Netflix video
commit-queue@webkit.org [Fri, 7 Jun 2013 20:16:41 +0000 (20:16 +0000)]
Reproducible crash with triple-finger-tap "define word" gesture on a Netflix video
https://bugs.webkit.org/show_bug.cgi?id=117020

Patch by Thomas Deniau <deniau@apple.com> on 2013-06-07
Reviewed by Ryosuke Niwa.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
Don't invoke the Dictionary lookup when we failed to extract the range of the token
surrounding the tapped position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
hugo.lima@openbossa.org [Fri, 7 Jun 2013 20:11:47 +0000 (20:11 +0000)]
[Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=117315

Reviewed by Benjamin Poulain.

Qt doesn't use the default values specified on FeatureList since r44681,
this patch just remove a bit of noise.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Makefile fix. Copy WTF.dll over as well.
roger_fong@apple.com [Fri, 7 Jun 2013 19:07:13 +0000 (19:07 +0000)]
Unreviewed. Makefile fix. Copy WTF.dll over as well.

* WTF.vcxproj/WTF.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r151318.
commit-queue@webkit.org [Fri, 7 Jun 2013 18:20:09 +0000 (18:20 +0000)]
Unreviewed, rolling out r151318.
http://trac.webkit.org/changeset/151318
https://bugs.webkit.org/show_bug.cgi?id=117356

Broke Windows Release Build (Requested by bfulgham on
#webkit).

* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTFCommon.props:
* WTF.vcxproj/WTFCoreFoundation.props: Removed.
* WTF.vcxproj/WTFDebug.props:
* WTF.vcxproj/WTFRelease.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: Lines jump up and down while typing Chinese or Japanese
rniwa@webkit.org [Fri, 7 Jun 2013 17:59:01 +0000 (17:59 +0000)]
REGRESSION: Lines jump up and down while typing Chinese or Japanese
https://bugs.webkit.org/show_bug.cgi?id=115931

Reviewed by Darin Adler.

The bug was caused by Font::width caching the width of text even when the font fallbacks existed when fallbackFonts
argument was null; because of this, a later call to Font::width was returning the width without filling up
fallbackFonts even if it was not null this time.

Fixed the bug by adding a local fallback fonts hash set, and checking the emptiness of this variable in Font::width.
Also added pass fallbackFonts around in various places to make use of the cached font fallbacks.

No new tests. Unfortunately I haven't been able to make a reliable reduction for this bug.

* platform/graphics/Font.cpp:
(WebCore::Font::width):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::measureHyphenWidth):
(WebCore::setLogicalWidthForTextRun):
(WebCore::textWidth):
(WebCore::tryHyphenating):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
* rendering/RenderText.cpp:
(WebCore::maxWordFragmentWidth):
(WebCore::RenderText::computePreferredLogicalWidths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[regression] build failure WebKitFontFamilyNames.h missing
zandobersek@gmail.com [Fri, 7 Jun 2013 17:15:29 +0000 (17:15 +0000)]
[regression] build failure WebKitFontFamilyNames.h missing
https://bugs.webkit.org/show_bug.cgi?id=117178

Reviewed by Sam Weinig.

.:

* GNUmakefile.am: List platform_sources under the BUILT_SOURCES list.

Source/WebCore:

* GNUmakefile.am: Make libPlatform and other sources depend on the generated platform sources. This should prevent
build failures in source code that's depending on the generated platform sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Weird behaviour and no clues to the user when the shared memory file can't...
commit-queue@webkit.org [Fri, 7 Jun 2013 16:37:32 +0000 (16:37 +0000)]
[GTK] Weird behaviour and no clues to the user when the shared memory file can't be opened
https://bugs.webkit.org/show_bug.cgi?id=117063

Patch by Enrique Ocana Gonzalez <eocanha@igalia.com> on 2013-06-07
Reviewed by Anders Carlsson.

Log error message when the shared memory file can't be opened in
Unix platform using a release build

* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMathML line fraction needs to parse number values
cfleizach@apple.com [Fri, 7 Jun 2013 15:57:17 +0000 (15:57 +0000)]
MathML line fraction needs to parse number values
https://bugs.webkit.org/show_bug.cgi?id=117305

Reviewed by Darin Adler.

Source/WebCore:

The line fraction thickness was not handling arbitrary thickness numbers.
The accessibility code was not handling default values for line thickness, so
it made sense to have AX rely on the RenderFraction object to retrive the thickness.

Modified existing tests to cover new behavior.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::mathLineThickness):
* rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::updateFromElement):
* rendering/mathml/RenderMathMLFraction.h:
(WebCore::RenderMathMLFraction::lineThickness):
(WebCore::toRenderMathMLFraction):

LayoutTests:

Math fractions test now encodes for an arbitrary thickness number.
Accessibility test handles the default line thickness.

* mathml/presentation/fractions.xhtml:
* platform/mac/accessibility/mathml-line-fraction-expected.txt:
* platform/mac/accessibility/mathml-line-fraction.html:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[rendering] Use foreground color to render the overtype caret
csaavedra@igalia.com [Fri, 7 Jun 2013 15:36:15 +0000 (15:36 +0000)]
[rendering] Use foreground color to render the overtype caret
https://bugs.webkit.org/show_bug.cgi?id=117347

Reviewed by Darin Adler.

Currently, the overtype caret is rendered using the colors of
a normal selection, which is confusing. This patch enables RenderObject
to differentiate between a normal and a overtype caret selection,
in order to use a different color for the latter.

Also, let RenderView update the selection if this is unchanged
when going from a overtype caret to one character selection and
viceversa.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::selectionBackgroundColor):
* rendering/RenderView.cpp:
(WebCore::RenderView::setSelection):
* rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of outdated getter / setter raises from Web IDL
ch.dumez@sisa.samsung.com [Fri, 7 Jun 2013 15:32:38 +0000 (15:32 +0000)]
Get rid of outdated getter / setter raises from Web IDL
https://bugs.webkit.org/show_bug.cgi?id=117346

Reviewed by Darin Adler.

Stop using "getter / setter raises" in the IDL as this is no longer part of
the Web IDL specification. Web IDL no longer specifies exceptions for
attribute getters or setters. Instead, it is now explained in prose.

WebKit still needs to know if the getter / setter can throw an exception
(but does not need the exception name) so this patch adds 2 WebKit specific
IDL extended attributes: [GetterRaisesException] / [SetterRaisesException].
The naming is consistent with Blink.

This results in more standard and concise IDL. This also simplifies a lot
the code of the IDL parser.

Note that this patch does not remove "raises()" from the IDL methods yet.
This should be replaced by [RaisesException] IDL extended attribute in a
later patch.

No new tests, no behavior change.

* Modules/indexeddb/IDBRequest.idl:
* Modules/mediasource/MediaSource.idl:
* Modules/mediasource/SourceBuffer.idl:
* Modules/mediastream/RTCDataChannel.idl:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/mediastream/RTCSessionDescription.idl:
* Modules/mediastream/RTCStatsResponse.idl:
* Modules/webaudio/AnalyserNode.idl:
* Modules/webaudio/AudioBufferSourceNode.idl:
* Modules/webaudio/AudioNode.idl:
* Modules/webdatabase/SQLResultSet.idl:
* bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperty):
(GenerateFunctions):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/IDLParser.pm:
(parseAttributeRest):
(parseAttributeRestOld):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestTypedefs.idl:
* css/CSSCharsetRule.idl:
* css/CSSRule.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSValue.idl:
* css/MediaList.idl:
* dom/Attr.idl:
* dom/CharacterData.idl:
* dom/Document.idl:
* dom/Node.idl:
* dom/ProcessingInstruction.idl:
* dom/Range.idl:
* dom/ShadowRoot.idl:
* dom/TreeWalker.idl:
* html/HTMLElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLMarqueeElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLMeterElement.idl:
* html/HTMLOptionElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLProgressElement.idl:
* html/HTMLSelectElement.idl:
* html/HTMLTableElement.idl:
* html/HTMLTextAreaElement.idl:
* html/MediaController.idl:
* html/track/TextTrackCue.idl:
* html/track/TextTrackRegion.idl:
* page/DOMWindow.idl:
* storage/Storage.idl:
* svg/SVGAltGlyphElement.idl:
* svg/SVGAngle.idl:
* svg/SVGAnimatedBoolean.idl:
* svg/SVGAnimatedEnumeration.idl:
* svg/SVGAnimatedInteger.idl:
* svg/SVGAnimatedNumber.idl:
* svg/SVGAnimatedString.idl:
* svg/SVGElement.idl:
* svg/SVGGlyphRefElement.idl:
* svg/SVGLangSpace.idl:
* svg/SVGLength.idl:
* svg/SVGPreserveAspectRatio.idl:
* svg/SVGSVGElement.idl:
* svg/SVGScriptElement.idl:
* svg/SVGStyleElement.idl:
* svg/SVGViewSpec.idl:
* xml/XMLHttpRequest.idl:
* xml/XPathResult.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused header includes in Document
kangil.han@samsung.com [Fri, 7 Jun 2013 15:19:01 +0000 (15:19 +0000)]
Remove unused header includes in Document
https://bugs.webkit.org/show_bug.cgi?id=117339

Reviewed by Andreas Kling.

Minor code cleanup.

* dom/Document.cpp:
* dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnnecessary use of Layout types in GraphicsLayer::paintGraphicsLayerContents
allan.jensen@digia.com [Fri, 7 Jun 2013 15:12:03 +0000 (15:12 +0000)]
Unnecessary use of Layout types in GraphicsLayer::paintGraphicsLayerContents
https://bugs.webkit.org/show_bug.cgi?id=117340

Reviewed by Darin Adler.

There is no reason to use Layout types when copying from Int types to Int types.

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::paintGraphicsLayerContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] WTF.dll is linking with CoreFoundation.lib in VS2010.
commit-queue@webkit.org [Fri, 7 Jun 2013 14:43:08 +0000 (14:43 +0000)]
[WinCairo] WTF.dll is linking with CoreFoundation.lib in VS2010.
https://bugs.webkit.org/show_bug.cgi?id=117294

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-07
Reviewed by Darin Adler.

WinCairo build should not use CoreFoundation.

* WTF.vcxproj/WTF.vcxproj: Exclude unneeded file from WinCairo build.
* WTF.vcxproj/WTFCommon.props: Removed CoreFoundation.lib from common props.
* WTF.vcxproj/WTFCoreFoundation.props: Added.
* WTF.vcxproj/WTFDebug.props: Inherit from WTFCoreFoundations.props.
* WTF.vcxproj/WTFRelease.props: Inherit from WTFCoreFoundations.props.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: r149001 made proximity test fail.
kihong.kwon@samsung.com [Fri, 7 Jun 2013 14:40:53 +0000 (14:40 +0000)]
REGRESSION: r149001 made proximity test fail.
https://bugs.webkit.org/show_bug.cgi?id=117343

Reviewed by Christophe Dumez.

Update window-property.html test cases for Device Proximity Event.
The global constructors are no longer enumerable after r149001.

* proximity/window-property-expected.txt:
* proximity/window-property.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][GTK] TextCheckerEnchant uses deprecated enchant_dict_add_to_personal
g.czajkowski@samsung.com [Fri, 7 Jun 2013 13:36:26 +0000 (13:36 +0000)]
[EFL][GTK] TextCheckerEnchant uses deprecated enchant_dict_add_to_personal
https://bugs.webkit.org/show_bug.cgi?id=117335

Reviewed by Christophe Dumez.

enchant_dict_add_to_personal has been deprecated at r22321 in Enchant repository.

No behavior change, no new tests needed.

* platform/text/enchant/TextCheckerEnchant.cpp:
(WebCore::TextCheckerEnchant::learnWord):
Use enchant_dict_add instead of enchant_dict_add_to_personal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skipping failing tests.
zarvai@inf.u-szeged.hu [Fri, 7 Jun 2013 13:09:33 +0000 (13:09 +0000)]
[Qt] Unreviewed gardening. Skipping failing tests.
https://bugs.webkit.org/show_bug.cgi?id=117295
https://bugs.webkit.org/show_bug.cgi?id=117336
https://bugs.webkit.org/show_bug.cgi?id=117338

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-07

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Context menu spellchecking items are not available when "Check Spelling...
g.czajkowski@samsung.com [Fri, 7 Jun 2013 12:26:06 +0000 (12:26 +0000)]
[EFL][WK2] Context menu spellchecking items are not available when "Check Spelling While Typing" is off
https://bugs.webkit.org/show_bug.cgi?id=117190

Reviewed by Christophe Dumez.

Context menu items (suggestions, learn and ignore word) are not available
due to missing dictionary. To get the suggestions for the misspelled word,
the dictionary has to be loaded first.

WebKit loads the default dictionary when check spelling while typing is being enabled.
However, context menu spellchecking items should be present even if this setting is off.

* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
Load the user's default dictionary to ensure context menu spellchecking items.
The dictionary is loaded asynchronously so it shouldn't delay application.

* UIProcess/API/efl/ewk_text_checker.h:
Update doc. Spelling suggestions, learn and ignore word should be available
independently of checking spelling while typing setting.

* UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(onContextMenuShow):
(TEST_F):
Add two unit tests to check whether the default dictionary is loaded and
whether the context menu spelling items are available.

* UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
Not set the default dictionary while enabling the setting, it's already loaded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Implement customContextMenuItemSelected
commit-queue@webkit.org [Fri, 7 Jun 2013 11:20:13 +0000 (11:20 +0000)]
[EFL][WK2] Implement customContextMenuItemSelected
https://bugs.webkit.org/show_bug.cgi?id=117298

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-06-07
Reviewed by Christophe Dumez.

When custom context menu item is selected using ewk API, the feedback is not
sent back to application, as customContextMenuItemSelected was unimplemented in
contextMenuClientEfl.

* UIProcess/API/efl/EwkView.cpp:
(EwkView::customContextMenuItemSelected):
* UIProcess/API/efl/EwkView.h:
* UIProcess/API/efl/ewk_view.h: added custom_item_selected callback.
* UIProcess/efl/ContextMenuClientEfl.cpp:
(customContextMenuItemSelected):
(ContextMenuClientEfl::ContextMenuClientEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFrame flattening: crash when child iframe is removed during beforeload.
commit-queue@webkit.org [Fri, 7 Jun 2013 10:35:24 +0000 (10:35 +0000)]
Frame flattening: crash when child iframe is removed during beforeload.
https://bugs.webkit.org/show_bug.cgi?id=116220

Patch by Zalan Bujtas <zalan@apple.com> on 2013-06-07
Reviewed by Antti Koivisto.

FrameView can get destroyed in updateWidget(). Normally, it is protected by layout()
but with frame flattening on, it can also be called asynchronously through the
post layout timer.

Source/WebCore:

Test: fast/frames/flattening/crash-remove-iframe-during-object-beforeload.html

* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):

LayoutTests:

* fast/frames/flattening/crash-remove-iframe-during-object-beforeload-expected.txt: Added.
* fast/frames/flattening/crash-remove-iframe-during-object-beforeload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] The presence of a flow-from declaration in a CSS rule using :hover...
commit-queue@webkit.org [Fri, 7 Jun 2013 10:07:15 +0000 (10:07 +0000)]
[CSS Regions] The presence of a flow-from declaration in a CSS rule using :hover effectively disables the rule
https://bugs.webkit.org/show_bug.cgi?id=111585

Created tests for changing flow-into and flow-from inside the :hover pseudo-class.
The actual problem was fixed along with https://bugs.webkit.org/show_bug.cgi?id=7555

Patch by Radu Stavila <stavila@adobe.com> on 2013-06-07
Reviewed by Antti Koivisto.

* fast/regions/hover-single-flow-from-none-expected.html: Added.
* fast/regions/hover-single-flow-from-none.html: Added.
* fast/regions/hover-single-flow-from-other-expected.html: Added.
* fast/regions/hover-single-flow-from-other.html: Added.
* fast/regions/hover-single-flow-into-none-expected.html: Added.
* fast/regions/hover-single-flow-into-none.html: Added.
* fast/regions/hover-single-flow-into-other-expected.html: Added.
* fast/regions/hover-single-flow-into-other.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake CachedResource virtual methods overridden in derived classes private
carlosgc@webkit.org [Fri, 7 Jun 2013 08:57:35 +0000 (08:57 +0000)]
Make CachedResource virtual methods overridden in derived classes private
https://bugs.webkit.org/show_bug.cgi?id=117289

Reviewed by Darin Adler.

And mark them as OVERRIDE too. Also mark all CachedResource
derived classes as FINAL.

* inspector/InspectorPageAgent.cpp:
(WebCore::cachedResourcesForFrame):
* loader/cache/CachedCSSStyleSheet.h:
* loader/cache/CachedFont.h:
* loader/cache/CachedImage.h:
* loader/cache/CachedRawResource.h:
* loader/cache/CachedSVGDocument.h:
* loader/cache/CachedScript.h:
* loader/cache/CachedShader.h:
* loader/cache/CachedTextTrack.h:
* loader/cache/CachedXSLStyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions] getBoundingClientRect wrong for inline content nodes
mihnea@adobe.com [Fri, 7 Jun 2013 08:00:25 +0000 (08:00 +0000)]
[CSSRegions] getBoundingClientRect wrong for inline content nodes
https://bugs.webkit.org/show_bug.cgi?id=117290

Reviewed by Alexandru Chiculita.

Source/WebCore:

getBoundingClientRect returned incorrect values for inline content that
was directly flowed inside regions because its mapLocalToContainer was not
properly patched as its RenderBox counterpart. This patch adds mapLocalToContainer
method in RenderFlowThread so that is properly called for all the elements inside the
flow thread.

Also, modified offsetFromContainer so that if the container is the flow thread,
offsetDependsOnPoint is set to true which further sets RenderGeometryMapStep::m_isNonUniform
to true for each step added in pushMappingToContainer methods.

Test: fast/regions/flowed-inline-content-bounding-client-rect.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::pushMappingToContainer):
(WebCore::RenderBox::offsetFromContainer):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::mapLocalToContainer):
* rendering/RenderFlowThread.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::offsetFromContainer):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::offsetFromContainer):

LayoutTests:

Add test for inline content nodes flowed in regions and in regions with transform.

* fast/regions/flowed-inline-content-bounding-client-rect-expected.txt: Added.
* fast/regions/flowed-inline-content-bounding-client-rect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Implement colorpicker for HTML5 input type color on Minibrowser
commit-queue@webkit.org [Fri, 7 Jun 2013 07:51:22 +0000 (07:51 +0000)]
[EFL] Implement colorpicker for HTML5 input type color on Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=115890

Patch by Jungsik Tae <davidtlay88@gmail.com> on 2013-06-07
Reviewed by Christophe Dumez.

When user clicks HTML5 input type color,
color selector window is created on browser object by using elm_colorchooser_add().
It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
The evas_object_color_set() sets a color value returning to browser.

* MiniBrowser/efl/main.c:
(window_free): When we delete parent window, deleting the colorpicker object.
(on_color_changed): Change color of rectangle to show color selected by user.
(on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
(on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
(on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
(on_color_picker_dismiss): Delete colorpicker object.
(on_color_picker_request): Create colorpicker window object.
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMinor code cleanup to remove unused header includes
kangil.han@samsung.com [Fri, 7 Jun 2013 05:27:14 +0000 (05:27 +0000)]
Minor code cleanup to remove unused header includes
https://bugs.webkit.org/show_bug.cgi?id=117283

Reviewed by Andreas Kling.

* loader/cache/CachedResourceClient.h:
* rendering/RenderBlock.cpp:
* rendering/RenderBox.cpp:
* rendering/RenderBoxModelObject.cpp:
* rendering/RenderObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCompletely initialize ChildProcess state on launch
oliver@apple.com [Fri, 7 Jun 2013 01:12:30 +0000 (01:12 +0000)]
Completely initialize ChildProcess state on launch
https://bugs.webkit.org/show_bug.cgi?id=117328

Reviewed by Sam Weinig.

Use setProcessSuppressionEnabledInternal to avoid setProcessSuppressionEnabled
"optimizing" our initialization away.

* Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::platformInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Build configuration fix. WebKitExportGenerator's include path should...
roger_fong@apple.com [Fri, 7 Jun 2013 00:56:36 +0000 (00:56 +0000)]
Unreviewed. Build configuration fix. WebKitExportGenerator's include path should fall back to
$(WebKit_Libraries)\include\WebCore if $(ConfigurationBuildDir)\include\WebCore doesn't exist.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorCommon.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRestrict WebAudio from playing when disallowed by page.
jer.noble@apple.com [Fri, 7 Jun 2013 00:12:31 +0000 (00:12 +0000)]
Restrict WebAudio from playing when disallowed by page.
https://bugs.webkit.org/show_bug.cgi?id=117310

Reviewed by Eric Carlson.

Add a new behavior restriction which would mute WebAudio
when media playback is disallowed by the page.

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::constructCommon): Set the RequirePageConsentForAudioStartRestriction
    restriction for the Mac port
(WebCore::AudioContext::document): Cast the execution context to a document.
(WebCore::AudioContext::lazyInitialize): Call startRendering() instead of
    m_destinationNode->startRendering() directly.
(WebCore::AudioContext::startRendering): If media loading is disabled, add
    a mediaCanStart listener.
(WebCore::AudioContext::mediaCanStart): Remove the RequirePageConsentForAudioStartRestriction.
* Modules/webaudio/AudioContext.h:
(WebCore::AudioContext::pageConsentRequiredForAudioStart): Added; simple wrapper.
* Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::render): Mute output if pageConsentRequiredForAudioStart().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151302 268f45cc-cd09-0410-ab3c-d52691b4dbfc