WebKit-https.git
12 years agoLayoutTests:
darin [Mon, 8 Jan 2007 18:59:56 +0000 (18:59 +0000)]
LayoutTests:

        Reviewed by Beth.

        - http://bugs.webkit.org/show_bug.cgi?id=12142
          render tree dump for test results should include the value of list markers

        * css1/basic/class_as_selector-expected.txt:
        * css1/basic/containment-expected.txt:
        * css1/basic/contextual_selectors-expected.txt:
        * css1/basic/id_as_selector-expected.txt:
        * css1/box_properties/border_bottom-expected.txt:
        * css1/box_properties/border_left-expected.txt:
        * css1/box_properties/border_right_inline-expected.txt:
        * css1/box_properties/border_top-expected.txt:
        * css1/box_properties/clear_float-expected.txt:
        * css1/box_properties/margin-expected.txt:
        * css1/box_properties/margin_bottom-expected.txt:
        * css1/box_properties/margin_left-expected.txt:
        * css1/box_properties/margin_right-expected.txt:
        * css1/box_properties/margin_top-expected.txt:
        * css1/box_properties/padding_left-expected.txt:
        * css1/box_properties/padding_right-expected.txt:
        * css1/cascade/cascade_order-expected.txt:
        * css1/classification/display-expected.txt:
        * css1/classification/list_style-expected.txt:
        * css1/classification/list_style_image-expected.txt:
        * css1/classification/list_style_position-expected.txt:
        * css1/classification/list_style_type-expected.txt:
        * css1/conformance/forward_compatible_parsing-expected.txt:
        * css1/pseudo/anchor-expected.txt:
        * css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
        * css2.1/t0505-c16-descendant-01-e-expected.txt:
        * css2.1/t050803-c14-classes-00-e-expected.txt:
        * css2.1/t0509-c15-ids-01-e-expected.txt:
        * css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
        * css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
        * css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
        * css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
        * css2.1/t1205-c561-list-displ-00-b-expected.txt:
        * css2.1/t1205-c563-list-type-00-b-expected.txt:
        * css2.1/t1205-c563-list-type-01-b-expected.txt:
        * css2.1/t1205-c564-list-img-00-b-g-expected.txt:
        * css2.1/t1205-c565-list-pos-00-b-expected.txt:
        * css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
        * editing/deleting/4866671-expected.txt:
        * editing/deleting/delete-first-list-item-expected.txt:
        * editing/deleting/delete-link-1-expected.txt:
        * editing/deleting/delete-listitem-002-expected.txt:
        * editing/deleting/list-item-1-expected.txt:
        * editing/deleting/merge-into-empty-block-2-expected.txt:
        * editing/execCommand/4641880-1-expected.txt:
        * editing/execCommand/create-list-from-range-selection-expected.txt:
        * editing/execCommand/create-list-with-hr-expected.txt:
        * editing/execCommand/indent-list-item-expected.txt:
        * editing/execCommand/indent-selection-expected.txt:
        * editing/execCommand/insert-list-and-stitch-expected.txt:
        * editing/execCommand/remove-list-from-range-selection-expected.txt:
        * editing/execCommand/remove-list-item-1-expected.txt:
        * editing/execCommand/remove-list-items-expected.txt:
        * editing/execCommand/switch-list-type-expected.txt:
        * editing/inserting/insert-div-022-expected.txt:
        * editing/inserting/insert-div-023-expected.txt:
        * editing/inserting/insert-div-024-expected.txt:
        * editing/pasteboard/4861080-expected.txt:
        * editing/pasteboard/drop-link-expected.txt:
        * editing/pasteboard/innerText-inline-table-expected.txt:
        * editing/pasteboard/input-field-1-expected.txt:
        * editing/pasteboard/merge-end-list-expected.txt:
        * editing/pasteboard/merge-start-list-expected.txt:
        * editing/pasteboard/paste-4039777-fix-expected.txt:
        * editing/pasteboard/paste-list-001-expected.txt:
        * editing/pasteboard/select-element-1-expected.txt:
        * editing/selection/drag-to-contenteditable-iframe-expected.txt:
        * editing/selection/extend-by-word-002-expected.txt:
        * editing/selection/move-by-line-002-expected.txt:
        * editing/selection/select-all-iframe-expected.txt:
        * editing/selection/selectNode-expected.txt:
        * editing/selection/selectNodeContents-expected.txt:
        * editing/unsupported-content/list-delete-001-expected.txt:
        * editing/unsupported-content/list-type-after-expected.txt:
        * editing/unsupported-content/list-type-before-expected.txt:
        * fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
        * fast/block/float/014-expected.txt:
        * fast/css-generated-content/009-expected.txt:
        * fast/css/001-expected.txt:
        * fast/css/continuationCrash-expected.txt:
        * fast/css/css2-system-fonts-expected.txt:
        * fast/css/css3-modsel-22-expected.txt:
        * fast/css/list-outline-expected.txt:
        * fast/doctypes/001-expected.txt:
        * fast/doctypes/002-expected.txt:
        * fast/doctypes/003-expected.txt:
        * fast/doctypes/004-expected.txt:
        * fast/dom/Window/window-onFocus-expected.txt:
        * fast/forms/form-hides-table-expected.txt:
        * fast/forms/plaintext-mode-2-expected.txt:
        * fast/lists/001-expected.txt:
        * fast/lists/002-expected.txt:
        * fast/lists/003-expected.txt:
        * fast/lists/004-expected.txt:
        * fast/lists/005-expected.txt:
        * fast/lists/006-expected.txt:
        * fast/lists/007-expected.txt:
        * fast/lists/008-expected.txt:
        * fast/lists/alpha-list-wrap-expected.txt:
        * fast/lists/decimal-leading-zero-expected.txt:
        * fast/lists/drag-into-marker-expected.txt:
        * fast/lists/dynamic-marker-crash-expected.txt:
        * fast/lists/inlineBoxWrapperNullCheck-expected.txt:
        * fast/lists/li-br-expected.txt:
        * fast/lists/li-style-alpha-huge-value-crash-expected.txt:
        * fast/lists/li-values-expected.txt:
        * fast/lists/markers-in-selection-expected.txt:
        * fast/lists/numeric-markers-outside-list-expected.txt:
        * fast/lists/ol-display-types-expected.txt:
        * fast/lists/olstart-expected.txt:
        * fast/lists/ordered-list-with-no-ol-tag-expected.txt:
        * fast/lists/scrolled-marker-paint-expected.txt:
        * fast/overflow/overflow-rtl-expected.txt:
        * fast/selectors/001-expected.txt:
        * fast/selectors/013-expected.txt:
        * fast/selectors/015-expected.txt:
        * fast/selectors/166-expected.txt:
        * fast/table/018-expected.txt:
        * fast/table/form-with-table-style-expected.txt:
        * fast/text/whitespace/tab-character-basics-expected.txt:
        * fast/tokenizer/004-expected.txt:
        * tables/mozilla/bugs/bug23235-expected.txt:
        * tables/mozilla/bugs/bug30692-expected.txt:
        * tables/mozilla/bugs/bug3191-expected.txt:
        * tables/mozilla/bugs/bug32205-2-expected.txt:
        * tables/mozilla/marvin/backgr_index-expected.txt:
        * tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
        * tables/mozilla/marvin/x_table-expected.txt:
        * tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
        * tables/mozilla/other/wa_table_tr_align-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
        * tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
        * traversal/stay-within-root-expected.txt:

WebCore:

        Reviewed by Beth.

        - http://bugs.webkit.org/show_bug.cgi?id=12142
          render tree dump for test results should include the value of list markers

        * rendering/RenderTreeAsText.cpp:
        (WebCore::getTagName): Changed to use String instead of DeprecatedString.
        (WebCore::quoteAndEscapeNonPrintables): Ditto. Also moved up so it can be used
        in the operator below.
        (WebCore::operator<<): Added clause for RenderListMarker that dumps the value
        of the list marker's text.
        (WebCore::nodePosition): Changed to use String instead of DeprecatedString.
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::TextStreamSeparator::TextStreamSeparator): Changed to use String
        instead of DeprecatedString.
        (WebCore::getTagName): Ditto.
        (WebCore::write): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by ap and the rubber stamp of Maciej.
weinig [Mon, 8 Jan 2007 17:50:01 +0000 (17:50 +0000)]
    Reviewed by ap and the rubber stamp of Maciej.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=12164
        Cleanup Tokenizers

        - Moves Tokenizer class into its own file.
        - Move XMLTokenizer declaration from XMLTokenizer.cpp to XMLTokenizer.h
        - Fixup #includes.

        * WebCore.xcodeproj/project.pbxproj:
        * dom/Document.cpp:
        (WebCore::Document::createTokenizer):
        * dom/Tokenizer.h: Added.
        (WebCore::Tokenizer::Tokenizer):
        (WebCore::Tokenizer::~Tokenizer):
        (WebCore::Tokenizer::stopParsing):
        (WebCore::Tokenizer::processingData):
        (WebCore::Tokenizer::executingScript):
        (WebCore::Tokenizer::wantsRawData):
        (WebCore::Tokenizer::writeRawData):
        (WebCore::Tokenizer::inViewSourceMode):
        (WebCore::Tokenizer::setInViewSourceMode):
        (WebCore::Tokenizer::wellFormed):
        (WebCore::Tokenizer::lineNumber):
        (WebCore::Tokenizer::columnNumber):
        * dom/XMLTokenizer.cpp:
        * dom/XMLTokenizer.h:
        (WebCore::XMLTokenizer::):
        (WebCore::XMLTokenizer::setIsXHTMLDocument):
        (WebCore::XMLTokenizer::isXHTMLDocument):
        (WebCore::XMLTokenizer::wellFormed):
        * html/HTMLElement.cpp:
        * html/HTMLTokenizer.h:
        (WebCore::Token::reset):
        (WebCore::HTMLTokenizer::checkBuffer):
        (WebCore::HTMLTokenizer::checkScriptBuffer):
        (WebCore::HTMLTokenizer::State::State):
        (WebCore::HTMLTokenizer::State::setBit):
        * xml/XSLTProcessor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
weinig [Mon, 8 Jan 2007 15:42:33 +0000 (15:42 +0000)]
LayoutTests:

        Reviewed by Tim H.

        Update results to include -webkit-box-shadow.

        * fast/css/computed-style-expected.txt:

WebCore:

        Reviewed by Tim H.

        Adds -webkit-box-shadow to list of computable styles.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):

WebKit:

        Reviewed by Tim H.

        Adds default value for -webkit-box-shadow and fixes default
        value of -webkit-column-count to be "auto".  Also sorts the
        list of defaults.

        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by bdash.
rwlbuis [Mon, 8 Jan 2007 13:43:10 +0000 (13:43 +0000)]
    Reviewed by bdash.

        Initialize the member vars, fixes testcases
        pointer-events-path.svg and pointer-events-text.svg
        on the PPC build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-01-08 Andrew Wellington <proton@wiretapped.net>
bdash [Mon, 8 Jan 2007 12:36:08 +0000 (12:36 +0000)]
2007-01-08  Andrew Wellington  <proton@wiretapped.net>

        Reviewed by Mark.

        * WebInspector/webInspector/inspector.js: Hide default values of
        -webkit-column styles in WebInspector.
2007-01-08  Andrew Wellington  <proton@wiretapped.net>

        Reviewed by Mark.

        * fast/css/computed-style-expected.txt: Update results to include
        -webkit-column styles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago This patch computes the correct column width and column count. It ensures...
hyatt [Mon, 8 Jan 2007 11:57:36 +0000 (11:57 +0000)]
    This patch computes the correct column width and column count.  It ensures that content lays out constrained
        to the column width in one long strip.  It does not yet balance the long strip into multiple columns.

        Reviewed by Mark

        * rendering/RenderBlock.cpp:
        (WebCore:::RenderFlow):
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::rightOffset):
        (WebCore::RenderBlock::availableWidth):
        (WebCore::RenderBlock::columnGap):
        (WebCore::RenderBlock::calcColumnWidth):
        * rendering/RenderBlock.h:
        * rendering/RenderStyle.h:
        (WebCore::RenderStyle::setColumnWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix column-count so that it supports auto just like column-width does.
hyatt [Mon, 8 Jan 2007 10:30:22 +0000 (10:30 +0000)]
    Fix column-count so that it supports auto just like column-width does.

        Add a new function, availableWidth(), that will be used to return the width available to content placed inside
        a block.  For now it still returns contentWidth(), so no behavioral change has occurred yet.

        Subclass calcWidth() in RenderBlock, but don't change anything yet.  This is where RenderBlock will calc the
        correct column width.

        Reviewed by mark

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::leftRelOffset):
        (WebCore::RenderBlock::rightRelOffset):
        (WebCore::RenderBlock::getClearDelta):
        (WebCore::RenderBlock::availableWidth):
        (WebCore::RenderBlock::calcWidth):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::containingBlockWidth):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::containingBlockWidth):
        (WebCore::RenderObject::paddingTop):
        (WebCore::RenderObject::paddingBottom):
        (WebCore::RenderObject::paddingLeft):
        (WebCore::RenderObject::paddingRight):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::availableWidth):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleMultiColData::StyleMultiColData):
        (WebCore::StyleMultiColData::operator==):
        * rendering/RenderStyle.h:
        (WebCore::RenderStyle::hasAutoColumnCount):
        (WebCore::RenderStyle::setColumnCount):
        (WebCore::RenderStyle::setHasAutoColumnCount):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::calcWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
hyatt [Mon, 8 Jan 2007 08:45:32 +0000 (08:45 +0000)]
LayoutTests:

        Add layout test for inheritance of auto z-index.

        Reviewed by eric

        * fast/layers/zindex-inherit-expected.checksum: Added.
        * fast/layers/zindex-inherit-expected.png: Added.
        * fast/layers/zindex-inherit-expected.txt: Added.
        * fast/layers/zindex-inherit.html: Added.

WebCore:

        Fix z-index:inherit so that it works properly when inheriting from z-index:auto.

        Reviewed by eric

        fast/layers/zindex-inherit.html

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add support for all of the CSS3 multi-column properties in preparation for...
hyatt [Mon, 8 Jan 2007 08:41:23 +0000 (08:41 +0000)]
    Add support for all of the CSS3 multi-column properties in preparation for implementing the
        feature.

        Reviewed by eric

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::):
        * css/CSSPropertyNames.in:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleMultiColData::StyleMultiColData):
        (WebCore::StyleMultiColData::operator==):
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::operator==):
        (WebCore::RenderStyle::RenderStyle):
        (WebCore::RenderStyle::diff):
        * rendering/RenderStyle.h:
        (WebCore::StyleMultiColData::operator!=):
        (WebCore::StyleMultiColData::ruleWidth):
        (WebCore::RenderStyle::columnWidth):
        (WebCore::RenderStyle::hasAutoColumnWidth):
        (WebCore::RenderStyle::columnCount):
        (WebCore::RenderStyle::columnGap):
        (WebCore::RenderStyle::hasAutoColumnGap):
        (WebCore::RenderStyle::columnRuleColor):
        (WebCore::RenderStyle::columnRuleStyle):
        (WebCore::RenderStyle::columnRuleWidth):
        (WebCore::RenderStyle::columnBreakBefore):
        (WebCore::RenderStyle::columnBreakInside):
        (WebCore::RenderStyle::columnBreakAfter):
        (WebCore::RenderStyle::setColumnWidth):
        (WebCore::RenderStyle::setHasAutoColumnWidth):
        (WebCore::RenderStyle::setColumnCount):
        (WebCore::RenderStyle::setColumnGap):
        (WebCore::RenderStyle::setHasAutoColumnGap):
        (WebCore::RenderStyle::setColumnRuleColor):
        (WebCore::RenderStyle::setColumnRuleStyle):
        (WebCore::RenderStyle::setColumnRuleWidth):
        (WebCore::RenderStyle::resetColumnRule):
        (WebCore::RenderStyle::setColumnBreakBefore):
        (WebCore::RenderStyle::setColumnBreakInside):
        (WebCore::RenderStyle::setColumnBreakAfter):
        (WebCore::RenderStyle::initialColumnCount):
        (WebCore::RenderStyle::initialColumnWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric.
rwlbuis [Mon, 8 Jan 2007 06:45:10 +0000 (06:45 +0000)]
    Reviewed by Eric.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10587
        pointer-events is not implemented for RenderSVGImage or RenderSVGText
        Implement pointer-events for raster images and svg text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
ddkilzer [Mon, 8 Jan 2007 05:17:06 +0000 (05:17 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11917
          setlocale() can return null

        * kjs/date_object.cpp:
        (KJS::DateProtoFunc::callAsFunction): Removed dead code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
ddkilzer [Mon, 8 Jan 2007 05:11:18 +0000 (05:11 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12100
          JNI bindings should be available to non-Mac platforms that have JNI

        Change JNI so that it is not wrapped in the PLATFORM(MAC) ifdef, enabling
        other platforms who have JNI to use it.

        * bindings/jni/jni_instance.h:
          Removed unnecessary include of <CoreFoundation/CoreFoundation.h>
        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::setJavaVM):
        * bindings/jni/jni_utility.h:
          Added new method for clients to set the JavaVM
        * bindings/runtime.cpp:
        (KJS::Bindings::Instance::createBindingForLanguageInstance):
          Changed code to utilize new #if HAVE(JNI)
        * kjs/config.h:
          Added new #define for JNI, ie HAVE_JNI

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
ddkilzer [Mon, 8 Jan 2007 05:08:17 +0000 (05:08 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        Fix http://bugs.webkit.org/show_bug.cgi?id=11431
        ARM platform has some byte alignment issues

        Fix for NaN being 4 bytes and it must start on a byte boundary
        for ARM architectures.

        * kjs/fpconst.cpp:
        (KJS::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix a regression where border-radius was not clipping the background when...
hyatt [Mon, 8 Jan 2007 01:16:55 +0000 (01:16 +0000)]
    Fix a regression where border-radius was not clipping the background when border was set to none.
        Fix multi-line inline flow painting to properly apply border-radius to the background only at the
        beginning of the first line and end of the last line.

        Reviewed by eric

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintBackground):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBackground):
        (WebCore::RenderBox::paintBackgroundExtended):
        * rendering/RenderBox.h:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::paintBackgroundExtended):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
hyatt [Sun, 7 Jan 2007 23:31:07 +0000 (23:31 +0000)]
LayoutTests:

        Add support for the CSS3 box-shadow property.

        Reviewed by olliej

        * fast/box-shadow/basic-shadows-expected.checksum: Added.
        * fast/box-shadow/basic-shadows-expected.png: Added.
        * fast/box-shadow/basic-shadows-expected.txt: Added.
        * fast/box-shadow/basic-shadows.html: Added.

WebCore:

        Add support for the CSS3 box-shadow property.

        Reviewed by olliej

        fast/box-shadow/ contains the tests for this feature.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::clipOutRoundedRect):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::clipOutEllipseInRect):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::clipOut):
        (WebCore::GraphicsContext::clipOutEllipseInRect):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paint):
        (WebCore::InlineFlowBox::paintBoxShadow):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        (WebCore::shouldDrawTextDecoration):
        (WebCore::InlineFlowBox::paintTextDecorations):
        * rendering/InlineFlowBox.h:
        * rendering/InlineRunBox.h:
        (WebCore::InlineRunBox::paintBoxDecorations):
        (WebCore::InlineRunBox::paintTextDecorations):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintObject):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::setStyle):
        (WebCore::RenderBox::paintBoxDecorations):
        (WebCore::RenderBox::paintBackgroundExtended):
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintBoxDecorations):
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paint):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint):
        * rendering/RenderImage.h:
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
        (WebCore::RenderObject::paintBoxShadow):
        (WebCore::RenderObject::dump):
        (WebCore::RenderObject::setStyle):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::hasBoxDecorations):
        (WebCore::RenderObject::setHasBoxDecorations):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paint):
        (WebCore::RenderTable::paintBoxDecorations):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::RenderTableCell):
        (WebCore::RenderTableCell::setStyle):
        (WebCore::RenderTableCell::paintBoxDecorations):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by weinig.
rwlbuis [Sun, 7 Jan 2007 18:15:39 +0000 (18:15 +0000)]
    Reviewed by weinig.

        Correct results from previous patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by weinig.
rwlbuis [Sun, 7 Jan 2007 16:47:24 +0000 (16:47 +0000)]
    Reviewed by weinig.

        http://bugs.webkit.org/show_bug.cgi?id=10362
        SVG needs to support SVGError events and some form of "error state"
        Report SVG warnings and errors on (JS) console.
        Expose line and column number getters in Tokenizer in
        order to display them with the error message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Sam.
zimmermann [Sun, 7 Jan 2007 14:00:06 +0000 (14:00 +0000)]
Reviewed by Sam.
Cleanup code & fix InlineBox positioning when text-anchor is used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake it compile and link again. (Qt) Includes implementation of a few stubs
staikos [Sun, 7 Jan 2007 12:47:42 +0000 (12:47 +0000)]
Make it compile and link again. (Qt)  Includes implementation of a few stubs
which should be moved to other locations, as well as a non-Qt-specific change
to make it compile (nil->ResourceResponse()).  Qt port continues to function as
well as before.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Updated pixel results that weren't landed with r17141.
ap [Sun, 7 Jan 2007 12:01:26 +0000 (12:01 +0000)]
    Updated pixel results that weren't landed with r17141.

        * http/tests/incremental/slow-utf8-css-expected.checksum:
        * http/tests/incremental/slow-utf8-css-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-01-07 Mitz Pettel <mitz@webkit.org>
ap [Sun, 7 Jan 2007 11:47:34 +0000 (11:47 +0000)]
2007-01-07  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Mark Rowe.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11133

        Test: fast/forms/listbox-clip.html

        * platform/mac/PlatformScrollBarMac.mm:
        (-[WebCoreScrollBar initWithPlatformScrollbar:]): Get the correct scrollbar
        width/height based on control size.
        * rendering/RenderListBox.cpp:
        Renamed optionsSpacingLeft to optionsSpacingHorizontal since it is applied
        on both sides.
        (WebCore::RenderListBox::calcMinMaxWidth): Account for optionsSpacingHorizontal.
        Not including the spacing before went unnoticed since the scrollbar was lying
        about its width by exactly the same amount.
        (WebCore::RenderListBox::paintObject): Clip out the scrollbar.
        (WebCore::RenderListBox::paintItemForeground): Changed for the rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-01-07 Mitz Pettel <mitz@webkit.org>
ap [Sun, 7 Jan 2007 11:35:05 +0000 (11:35 +0000)]
2007-01-07  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11935
          REGRESSION: Changing the overflow style dynamically does not force repaint

        Test: fast/repaint/erase-overflow.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::setStyle): Added a repaint before changing hasOverflowClip
        to true, to ensure that the current overflow is erased.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
rwlbuis [Sun, 7 Jan 2007 11:26:48 +0000 (11:26 +0000)]
    Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=12106
        Changed URL from WebResourceLoadDelegate's webView:resource:willSendRequest:... is ignored

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Re-apply r17618, which got reverted with CSS suite update.
ap [Sun, 7 Jan 2007 11:26:35 +0000 (11:26 +0000)]
    Re-apply r17618, which got reverted with CSS suite update.

        Reviewed by Sam Weinig.

        Fix a layout test failure that happened with additional fonts installed - replace a fancy
        Unicode character with a plain asterisk.

        * css2.1/t0905-c414-flt-00-d-expected.checksum:
        * css2.1/t0905-c414-flt-00-d-expected.png:
        * css2.1/t0905-c414-flt-00-d-expected.txt:
        * css2.1/t0905-c414-flt-00-d.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap [Sun, 7 Jan 2007 11:14:41 +0000 (11:14 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=10313
        xsl:import doesn't work in stylesheets loaded via XMLHttpRequest

        This is a partial fix that makes a couple more steps towards fixing the problem.

        Test: fast/xsl/transform-xhr-doc.xhtml

        * xml/XSLTProcessor.cpp:
        (WebCore::xsltStylesheetPointer): Pass an URL for the stylesheet. I'm not sure why this constructor even needs it,
        given that it has a Node, but this is a small modifications that makes XSLImportRule try to load from a correct URL.
        (WebCore::XSLTProcessor::transformToString): Fix the crash for real this time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
rwlbuis [Sun, 7 Jan 2007 08:37:24 +0000 (08:37 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12125
        overflow attribute of the symbol element not respected

        Copy the attribute map to the cloned node so the overflow on
        the symbol is respected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Suggested by Mitz.
darin [Sun, 7 Jan 2007 04:29:48 +0000 (04:29 +0000)]
    Suggested by Mitz.

        - disabled 3 tests with results that are too font-dependent to be used as
          part of the test suite; two are tests of Armenian numbering and one is
          a test of some SVG font features which we do not support

        * css2.1/t1202-counter-10-b-expected.checksum: Removed.
        * css2.1/t1202-counter-10-b-expected.png: Removed.
        * css2.1/t1202-counter-10-b-expected.txt: Removed.
        * css2.1/t1202-counter-10-b.html: Removed.
        * css2.1/t1202-counters-10-b-expected.checksum: Removed.
        * css2.1/t1202-counters-10-b-expected.png: Removed.
        * css2.1/t1202-counters-10-b-expected.txt: Removed.
        * css2.1/t1202-counters-10-b.html: Removed.
        * svg/W3C-SVG-1.1/text-fonts-03-t-expected.checksum: Removed.
        * svg/W3C-SVG-1.1/text-fonts-03-t-expected.png: Removed.
        * svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Removed.
        * svg/W3C-SVG-1.1/text-fonts-03-t.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed and significantly tweaked by Darin.
darin [Sun, 7 Jan 2007 04:11:10 +0000 (04:11 +0000)]
    Reviewed and significantly tweaked by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12103
          LEAK: Fix the leaking ImageBuffer buffers on TOT

        * ksvg2/svg/SVGMaskElement.h:
        * ksvg2/svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):
        Changed to return auto_ptr since it returns a newly-created ImageBuffer.

        * ksvg2/svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::buildPattern):
        Changed to use auto_ptr since ImageBuffer::create now returns one.

        * platform/graphics/GraphicsContext.h: Removed the include of ImageBuffer.h,
        which was never needed, and the declaration of createImageBuffer, which is
        now a class member function of ImageBuffer.

        * platform/graphics/ImageBuffer.h: Replaced the constructor with a create
        function. Added a comment about the need to move renderSubtreeToImage
        elsewhere. Added an m_data member to store the data so it can be deleted
        when the object is done, made the m_size member non-platform-specific.
        Added a private constructor for use to create the CG version.

        * platform/graphics/cg/GraphicsContextCG.cpp: Removed
        GraphicsContext::createImageBuffer.

        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::create): Added. Replaces the old
        GraphicsContext::createImageBuffer function.
        (WebCore::ImageBuffer::ImageBuffer): Added m_data and m_context.
        (WebCore::ImageBuffer::~ImageBuffer): Added a fastFree of the data and got
        rid of the unneeded null check before calling CGImageRelease.

        * platform/graphics/svg/SVGPaintServerGradient.h: Removed the include of
        ImageBuffer.h and declared the ImageBuffer class instead.

        * platform/graphics/svg/SVGPaintServerPattern.h: Removed the include of
        ImageBuffer.h and declared the ImageBuffer class instead, and changed setTile
        to take an auto_ptr since it takes ownership of the ImageBuffer.
        * platform/graphics/svg/SVGPaintServerPattern.cpp:
        (WebCore::SVGPaintServerPattern::setTile): Ditto.

        * platform/graphics/svg/SVGResourceMasker.h: Removed the include of
        ImageBuffer.h and declared the ImageBuffer class instead, and changed setMask
        to take an auto_ptr since it takes ownership of the ImageBuffer.
        * platform/graphics/svg/SVGResourceMasker.cpp:
        (WebCore::SVGResourceMasker::setMask): Ditto.

        * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
        (WebCore::SVGPaintServerGradient::setup): Updated to use auto_ptr.

        * platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: Updated includes.

        * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
        (WebCore::SVGResourceMasker::applyMask): Updated to use auto_ptr.

        - other changes

        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::handleStartCondition):
        Remove unused variables.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoThis is still X11-specific.
staikos [Sat, 6 Jan 2007 17:15:58 +0000 (17:15 +0000)]
This is still X11-specific.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
ddkilzer [Sat, 6 Jan 2007 12:06:30 +0000 (12:06 +0000)]
WebCore:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12136
          REGRESSION: Counters-related leaks

        * rendering/RenderCounter.cpp:
        (WebCore::destroyCounterNodeChildren): Delete the child counter nodes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Release build fix.
adele [Sat, 6 Jan 2007 06:24:08 +0000 (06:24 +0000)]
    Release build fix.

        * rendering/RenderListItem.cpp: (WebCore::RenderListItem::explicitValueChanged): Initialize listRenderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
darin [Sat, 6 Jan 2007 01:36:24 +0000 (01:36 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - added a new version of the CSS 2.1 test from the W3C site
        - added counters, list, and other CSS tests for my counter-related check-in

        * css2.1: Updated to the 2006-10-11 version of the test suite.
        I downloaded it from http://www.w3.org/Style/CSS/Test/CSS2.1/20061011/
        added UTF-8 BOMs to the beginning of all the files, and generated expected
        results.

        * fast/css-generated-content/reset-content-to-initial-expected.txt: Updated
        to reflect a bug fix in CSS content property support.

        * fast/css/counters/*: Removed all the existing tests since they are now part
        of the CSS 2.1 test suite.

        * fast/css/counters/counter-text-security-expected.checksum:  Added. New test.
        * fast/css/counters/counter-text-security-expected.png: Ditto.
        * fast/css/counters/counter-text-security-expected.txt: Ditto.
        * fast/css/counters/counter-text-security.html: Ditto.

        * fast/css/counters/counter-text-transform-expected.checksum: Added. New test.
        * fast/css/counters/counter-text-transform-expected.png: Ditto.
        * fast/css/counters/counter-text-transform-expected.txt: Ditto.
        * fast/css/counters/counter-text-transform.html: Ditto.

        * fast/lists/decimal-leading-zero-expected.checksum: Added. New test.
        * fast/lists/decimal-leading-zero-expected.png: Ditto.
        * fast/lists/decimal-leading-zero-expected.txt: Ditto.
        * fast/lists/decimal-leading-zero.html: Ditto.

        * fast/css/text-security-expected.checksum:  Added. New test.
        * fast/css/text-security-expected.png: Ditto.
        * fast/css/text-security-expected.txt: Ditto.
        * fast/css/text-security.html: Ditto.

        * fast/lists/decimal-leading-zero-expected.checksum: Added. New test.
        * fast/lists/decimal-leading-zero-expected.png: Ditto.
        * fast/lists/decimal-leading-zero-expected.txt: Ditto.
        * fast/lists/decimal-leading-zero.html: Ditto.

        * fast/lists/li-values-expected.checksum: Added. New test.
        * fast/lists/li-values-expected.png: Ditto.
        * fast/lists/li-values-expected.txt: Ditto.
        * fast/lists/li-values.html: Ditto.

        * fast/css/import-rule-regression-11590-expected.checksum: Added. Missing
        pixel-test results.
        * fast/css/import-rule-regression-11590-expected.png: Ditto.
        * fast/dom/css-insert-import-rule-expected.checksum: Ditto.
        * fast/dom/css-insert-import-rule-expected.png: Ditto.
        * fast/forms/encoding-test-expected.checksum: Ditto.
        * fast/forms/encoding-test-expected.png: Ditto.
        * fast/frames/frame-src-attribute-expected.checksum: Ditto.
        * fast/frames/frame-src-attribute-expected.png: Ditto.
        * fast/frames/onlyCommentInIFrame-expected.png: Ditto.
        * fast/frames/viewsource-attribute-expected.checksum: Ditto.
        * fast/frames/viewsource-attribute-expected.png: Ditto.
        * fast/loader/start-load-in-unload-expected.checksum: Ditto.
        * fast/loader/start-load-in-unload-expected.png: Ditto.

WebCore:

        Reviewed by Hyatt.

        - eliminated use of DeprecatedString for list item markers
        - eliminated use of DeprecatedValueList for border style collapsing
        - made many members private instead of protected or public

        - reworked counter implementation to fix most of the CSS 2.1 counter tests;
            made CounterNode be a simple non-polymorphic class, moved most counter-
            specific code out of RenderObject into RenderCounter, changed the data
            structure in RenderStyle to be more speed-efficient but less space-
            efficient for nodes with counter styles
        - fixed http://bugs.webkit.org/show_bug.cgi?id=11557

        Tests: css2.1

        - fixed a bug where counter text did not have text transform or text security
          applied to it

        Test: fast/css/counters/counter-text-security.html
        Test: fast/css/counters/counter-text-transform.html

        - improved handling of CSS content property values with data of the wrong
          type; this probably needs a bit more refinement

        Test: fast/css-generated-content/reset-content-to-initial-expected.txt

        - fixed a bug where removing the value attribute from an HTMLLIElement would
          set the list item's value to 0 instead of restoring it to normal

        Test: fast/lists/li-values.html

        - fixed a bug where changing the text security style from one style to another
          would not change the displayed text

        Test: fast/css/text-security.html

        - fixed some problems handling long sequences of counter-related styles;
          still needs more work and some super-large test cases to check if
          recursive algorithms for these that will overflow stack remain

        - added support for list styles decimal-leading-zero, hiragana, hirigana-iroha,
          katakana, katakana-iroha, cjk-ideographic, armenian, and georgian

        Test: fast/lists/decimal-leading-zero.html

        - minor tweaks and bug fixes for other list styles, including range checking

        * WebCore.exp: Updated for RenderListItem change.

        * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): Updated to use
        String instead of DeprecatedString.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Removed
        implementation for counter styles for now. We should probably restore it
        later, but we need to make sure the returned list is separate from the
        original list in the DOM -- modifying the list should not change the element
        it was computed from.

        * css/Counter.h: Removed unneeded empty constructor and destructor.

        * css/cssstyleselector.cpp:
        (WebCore::applyCounterList): Added. Stores counter directives in hash tables
        that should allow us to efficiently implement dynamic counter changes. Full
        support will have to wait for a future check-in.
        (WebCore::CSSStyleSelector::applyProperty): Changed counter properties to
        call applyCounterList. Reformatted the code to parse the content property for
        changes to RenderStyle and to handle the case where some the items in the
        content list don't generate any content.

        * editing/visible_units.cpp:
        * rendering/RenderBox.cpp:
        * rendering/RenderFlexibleBox.cpp:
        * rendering/RenderFlow.cpp:
        * rendering/RenderSlider.cpp:
        Added includes needed because of header changes.

        * html/HTMLLIElement.H: Removed unneeded m_isValued.
        * html/HTMLLIElement.cpp:
        (WebCore::HTMLLIElement::parseMappedAttribute): To match test results seen
        in WinIE, ignore values that are 0 or negative, and use new functions in
        RenderListItem to communicate the lack of a valid value.
        (WebCore::HTMLLIElement::attach): More of the same.

        * rendering/CounterNode.h: Made CounterNode be a non-polymorphic class,
        removing all the subclasses. Merged in CounterResetNode. Removed
        m_total from CounterResetNode, because it isn't needed for any of
        the styles (decimal-leading-zero always uses two digits). Removed
        m_hasSeparator and m_willNeedLayout since they aren't needed any more.
        Renamed m_count to m_countInParent for clarify, and named the list
        links the same as their associated functions. Removed many functions
        as well.
        * rendering/CounterNode.cpp:
        (WebCore::CounterNode::CounterNode): Added new fields.
        (WebCore::CounterNode::computeCountInParent): Added. Used by recount.
        (WebCore::CounterNode::recount): Simplified by removing unused parameter and the
        "get next" idiom. Changed to be iterative instead of recursive so we can handle
        arbitrarily long lists.
        (WebCore::CounterNode::insertAfter): Moved here from CounterResetNode. Updated
        for field name changes. Corrected rule for when to recount.
        (WebCore::CounterNode::removeChild): Moved here from CounterResetNode. Changed
        to only work on nodes without children. Corrected rule for when to recount.
        (WebCore::nextInPreOrderAfterChildren): Added. For debugging only.
        (WebCore::nextInPreOrder): Ditto.
        (WebCore::showTreeAndMark): Ditto.
        (showTree): Ditto.

        * rendering/CounterListItem.h:
        * rendering/CounterResetNode.h:
        * rendering/CounterResetNode.cpp:
        Marked ready to remove. I'll do the remove in a separate patch, since I have
        to update a lot of different make files when I do.

        * rendering/ListMarkerBox.cpp: (WebCore::ListMarkerBox::isText): Changed for the
        change to RenderListMarker.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addChildToFlow): Changed to use functions instead of
        direct field access so the fields can be private and we don't need to be friends.
        (WebCore::RenderBlock::getBaselineOfFirstLineBox): Ditto.
        (WebCore::RenderBlock::getBaselineOfLastLineBox): Ditto.
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::initMaxMarginValues): Ditto.
        (WebCore::RenderBlock::firstRootBox): Ditto.
        (WebCore::RenderBlock::lastRootBox): Ditto.
        * rendering/RenderBox.h:
        (WebCore::RenderBox::setWidth): Ditto.
        (WebCore::RenderBox::setHeight): Ditto.
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::addChild): Ditto.
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::determineStartPosition): Ditto.

        * rendering/RenderContainer.h: Renamed m_first and m_last to m_firstChild
        and m_lastChild. Made them private instead of proected. Removed the
        setFirstChild and setLastChild functions.
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::RenderContainer): Updated for field name change.
        Changed all calls to get at fields directly instead of using functions.
        (WebCore::RenderContainer::destroyLeftoverChildren): Ditto.
        (WebCore::updateListMarkerNumbers): Updated for RenderListItem change.
        (WebCore::RenderContainer::addChild): Changed to get at fields directly
        instead of using functions. Also used release() since RenderText::setText
        now takes PassRefPtr.
        (WebCore::RenderContainer::removeChildNode): Changed to get at fields directly
        instead of using functions.
        (WebCore::RenderContainer::updatePseudoChildForObject): Create the anonymous
        box only if at least one of of the items in the content list actually
        generates content. Since a RenderCounter is a RenderText, don't bother making
        a new style for it -- it just shares the style with its parent. Changed code
        to use RenderImage::setCachedImage() instead of of setContentObject().
        Added a call to setIsAnonymousImage() here, which was the only special thing
        that setContentObject() used to do. Pass a reference to the counter to the
        RenderCounter rather than a pointer. Pass document() as the node instead of
        passing the element to RenderCounter, which makes it anonymous automatically,
        and removed the setIsAnonymous call.
        (WebCore::RenderContainer::appendChildNode): Chagned to get at fields directly
        instead of using functions.
        (WebCore::RenderContainer::insertChildNode): Ditto.
        (WebCore::RenderContainer::layout): Ditto.
        (WebCore::RenderContainer::removeLeftoverAnonymousBoxes): Ditto.
        (WebCore::RenderContainer::positionForCoordinates): Ditto.
        (WebCore::RenderContainer::addLineBoxRects): Ditto.

        * rendering/RenderCounter.h: Removed unneeded layout override, never called on a
        text node. Added override of originalString. Replaced CounterData* with a copy of
        the CounterContent -- it's two atomic strings and an integer so it's efficient
        enough to store all three in the render object, and this eliminates the lifetime
        problems we could have if we used a pointer.
        * rendering/RenderCounter.cpp: Removed duplicate copy of list marker code.
        (WebCore::counterMaps): Moved these maps here from RenderObject.
        (WebCore::previousSiblingOrParent): Added.
        (WebCore::lastDescendant): Added.
        (WebCore::previousInPreOrder): Added.
        (WebCore::planCounter): Added.
        (WebCore::findPlaceForCounter): Added.
        (WebCore::counter): New name of function that was named RenderObject::findCounter.
        Also uses a new algorithm that passes all the CSS 2.1 tests.
        (WebCore::RenderCounter::RenderCounter): Changed to take a Document* instead of a
        Node*, since at the moment counters are always anonymous.
        (WebCore::RenderCounter::originalString): Added. This overrides the originalString
        in the RenderText base class so that any text transforms will use the counter's
        value. This code was previously in calcMinMaxWidth.
        (WebCore::RenderCounter::calcMinMaxWidth): Changed to call setInternalString and
        pass originalString -- this uses the counter's value from the counter tree.
        (WebCore::destroyCounterNodeChildren): Added.
        (WebCore::RenderCounter::destroyCounterNodes): Added. Called as needed from
        RenderObject::destroy for objects that have counter nodes.

        * rendering/RenderFlow.h: Made m_continuation private instead of protected.

        * rendering/RenderImage.h: Removed unneeded includes, and unnecessary element()
        function that casts to HTMLElement*. Made image() protected, and made the two
        calcAspectRatio functions private. Removed setContentObject(). Renamed the
        errorOccured() function to isErrorImage() and made it private.
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::RenderImage): Removed initialization of removed
        m_selectionState field.
        (WebCore::RenderImage::setCachedImage): Rearrange code so it won't try to
        call isErrorImage() on a null image.
        (WebCore::RenderImage::paint): Updated for name change.

        * rendering/RenderListBox.h: Removed unneeded forward declarations.

        * rendering/RenderListItem.h:
        Renamed markerStringValue() to markerText() and made it return a String instead of
        a DeprecatedString. Renamed m_prededfVal to m_explicitValue. Added booleans named
        m_hasExplicitValue and m_isValueUpToDate and marked m_value mutable so it can be
        computed in const member functions.
        (WebCore::RenderListItem::value): Changed to update value on demand at the time
        you ask for it.
        (WebCore::RenderListItem::hasExplicitValue): Added. Use instead of magic -1 value
        to indicate that the item does or does not have an explicit value.
        (WebCore::RenderListItem::explicitValue): Added.
        (WebCore::RenderListItem::setExplicitValue): Added.
        (WebCore::RenderListItem::clearExplicitValue): Added.
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::RenderListItem): Updated to not use magic -1 values.
        (WebCore::RenderListItem::setStyle): Removed call to RenderListMarker::setListItem
        since it's not needed any more, and instead pass the list item to the constructor.
        (WebCore::previousListItem): Made parameter const.
        (WebCore::RenderListItem::calcValue): Restructed the function a bit.
        (WebCore::RenderListItem::updateValueNow): Added. Calls calcValue.
        (WebCore::RenderListItem::updateValue): Added. New name for resetValue(). Unlike
        the old version, this no longer calculates the value until it's asked-for later.
        (WebCore::RenderListItem::markerText): Changed to return String rather than a
        DeprecatedString and to return a null string rather than empty string when there
        is no marker.

        * rendering/RenderListMarker.h: Added listMarkerText function -- common code shared
        with anyone who needs to convert a value into text given a list style.
        Changed constructor to take a RenderListItem and figure out the document from that.
        Added isImage() and isText() functions and removed listImage() function. Changed the
        type of the text() function from DeprecatedString to String. Removed the listItem()
        and seListeItem() functions. Made the getRelativeMarkerRect() function private.
        Renamed m_item to m_text and chagned it from DeprecatedString to String. Renamed
        m_listImage to m_image.
        * rendering/RenderListMarker.cpp:
        (WebCore::toRoman): Added range checking to fix buffer overrun for large or negative
        numbers. Rewrote to use a local UChar array and String rather than prepending to a
        DeprecatedString.
        (WebCore::toAlphabetic): Replaces toLetterString, and is more flexible since it takes
        an alphabet array. Changed to match CSS 3 specification by using decimal numbering for
        0 and negative numbers. Rewrote to use a local UChar array and String rather than
        prepending to a DeprecatedString.
        (WebCore::toHebrewUnder1000): Added. Helper function for Hebrew numbers so we can
        handle numbers up to a million.
        (WebCore::toHebrew): Changed to use toHebrewUnder1000, added a special case for
        zero, negative, and too-large numbers.
        (WebCore::toArmenianUnder10000): Added. Used by toArmenian.
        (WebCore::toArmenian): Added.
        (WebCore::toGeorgian): Added.
        (WebCore::toCJKIdeographic): Added.
        (WebCore::listMarkerText): Added. Moved the code here from calcMinMaxWidth, but added
        support for text for the styles disc, circle, square, decimal-leading-zero, hiragana,
        hirigana-iroha, katakana, katakana-iroha, cjk-ideographic, armenian, and georgian.
        Also changed some of the styles to share the new toAlphabetic function.
        (WebCore::RenderListMarker::RenderListMarker): Updated for name changes and list
        item parameter.
        (WebCore::RenderListMarker::~RenderListMarker): Updated for name changes.
        (WebCore::RenderListMarker::setStyle): Updated for name changes.
        (WebCore::RenderListMarker::isImage): Added. Useful helper that unifies the check
        for no image and the error image.
        (WebCore::RenderListMarker::paint): Updated for name changes to to use isImage()
        and rearranged the code a bit.
        (WebCore::RenderListMarker::imageChanged): Updated for name change
        (WebCore::RenderListMarker::calcMinMaxWidth): Updated for name change, fixed a bug
        where we'd leave the old text around if we were using an image-based marker. Also
        changed the code to use isImage() instead of checking m_listImage.
        (WebCore::RenderListMarker::calcWidth): Changed to use isImage().
        (WebCore::RenderListMarker::lineHeight): Changed to use isImage().
        (WebCore::RenderListMarker::baselinePosition): Changed to use isImage().
        (WebCore::RenderListMarker::getRelativeMarkerRect): Changed to use isImage(),
        restructured the code a little.

        * rendering/RenderObject.h: Removed now-uneeded includes. Removed collectBorders()
        and isFormElement(). Made remove() function and m_hasCounterNodeMap public so
        we could remove friend declarations for RenderListItem and RenderView.
        Moved findCounter() to become a private function inside RenderCounter.cpp.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createObject): Fix bug where a contentData() with
        CONTENT_NONE is treated as image content -- only look at the content property
        if it has exactly one entry which is a CONTENT_OBJECT.
        (WebCore::RenderObject::selectionStartEnd): Add const.
        (WebCore::RenderObject::destroy): Moved counter-specific code to
        RenderCounter::destroyCounterNodes.
        (WebCore::RenderObject::recalcMinMaxWidths): Changed code to set m_recalcMinMax
        near the top of the function -- the old code would potentially reset it after it
        was set by the calcMinMaxWidths functions, and possibly skip a future needed
        recalc. That came up in counter test cases. Removed unneeded boolean check right
        after an assertion.

        * rendering/RenderPart.h: Marked two virtual functions virtual for clarity.

        * rendering/RenderReplaced.h: Made shouldPaint be protected, and made
        m_intrinsicWidth, m_intrinsicHeight, and m_selectionState be private.
        Also marked isSelected() const.
        * rendering/RenderReplaced.cpp: Added newly-needed include.
        (WebCore::RenderReplaced::RenderReplaced): Use constructor syntax.
        (WebCore::RenderReplaced::isSelected): Made const and changed to call the
        selectionStartEnd function in the straightforward way.

        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::absoluteRects): Use functions instead of direct field
        access so the fields can be private.
        (WebCore::RenderSVGText::relativeBBox): Ditto.

        * rendering/RenderStyle.h: Tweaked formatting. Changed names of CSS3 holders
        to say "rare" instead, since it's not all CSS 3. Renamed CounterData to
        CounterContent, since it's used inside ContentData. Changed names of fields in
        ContentData to have m prefix. Moved content and counter fields into the rare
        non-inherited data object. Removed unneeded assignment operator from a class
        that already inherits from Shared which makes it start out noncopyable.
        * rendering/RenderStyle.cpp: Name changes, plus:
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        Updated for added fields (content, counter-reset, counter-increment).
        (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): Ditto.
        (WebCore::StyleRareNonInheritedData::operator==): Reformatted and sorted so it's
        easy to see if any fields are missing.
        (WebCore::operator!=): Added. Compares two CounterContent objects.
        (WebCore::RenderStyle::arenaDelete): Removed code to handle content, which is
        now in the rareNonInheritedData structure.
        (WebCore::RenderStyle::RenderStyle): Ditto.
        (WebCore::RenderStyle::inheritFrom): Ditto.
        (WebCore::RenderStyle::operator==): Ditto.
        (WebCore::RenderStyle::inheritedNotEqual):
        (WebCore::RenderStyle::diff):
        (WebCore::RenderStyle::contentDataEquivalent): Added case for counter,
        which previously would be ignored when determining if content is equivalent.
        (WebCore::RenderStyle::clearContent): Added.
        (WebCore::RenderStyle::setContent): Updated for change in content location.
        (WebCore::ContentData::clear): Changed algorithm so that it's not recursive
        and thus can handle a very long list of ContentData.
        (WebCore::operator==): Added. Compares two CounterDirective objects.
        (WebCore::RenderStyle::counterDirectives): Added.
        (WebCore::RenderStyle::accessCounterDirectives): Added.

        * rendering/RenderTable.h: Made m_currentBorder const to better reflect the
        paint algorithm.
        * rendering/RenderTable.cpp: (WebCore::RenderTable::paint): Changed to use
        Vector instead of DeprecatedValueList for the border styles, and to sort
        rather than inserting in sorted order as we go. Put the code to loop through
        the nodes and collect border styles here instead of in a RenderObject virtual
        function. Also set m_currentBorder to 0 after the loop for greater clarity.

        * rendering/RenderTableCell.h: Added a typedef for a vector of border values.
        Removed the virtual collectBorders and replaced with the non-virtual named
        collectBorderStyles. Also added a static member function named sortBorderStyles.
        * rendering/RenderTableCell.cpp:
        (WebCore::CollapsedBorders::CollapsedBorders): Removed unneeded constructor
        parameter.
        (WebCore::addBorderStyle): Changed to use a vector instead of a
        DeprecatedValueList. Wrote out a loop since Vector doesn't have a contains
        member function. Removed the code to insert the border at a sorted location;
        instead we have a separate call to sort the border styles
        (WebCore::RenderTableCell::collectBorderStyles): Renamed, and changed the
        parameter type.
        (WebCore::compareBorderStylesForQSort): Added.
        (WebCore::RenderTableCell::sortBorderStyles): Added.

        * rendering/RenderText.h: Changed StringImpl parameters in setText functions
        to be PassRefPtr; added a new setInternalString function. Made a bunch of the
        member functions private and made all the data members private instead of
        protected.
        * rendering/RenderText.cpp:
        (WebCore::RenderText::setStyle): Restructure a bit for clarity. Fix case where
        the old style has a different security than the new style. Use release() since
        RenderText::setText now takes PassRefPtr. Always call cacheWidths here.
        (WebCore::RenderText::setTextWithOffset): Changed to take the string as a
        PassRefPtr instead of a raw pointer.
        (WebCore::isInlineFlowOrEmptyText): Added.
        (WebCore::RenderText::setInternalString): Refactored core of setText into a
        separate protected member function that can be used RenderCounter. Changed
        the text security square character to match what's used in list markers.
        Changed the text transform switch statement so that gcc will warn us if we add
        a new value and don't add a case for it.
        (WebCore::RenderText::setText): Refactored most of the function into
        setInternalString. Removed the call to cacheWidths -- that's now done in the
        setStyle function only.

        * rendering/RenderView.h:
        * rendering/RenderView.cpp: (WebCore::RenderView::selectionStartEnd): Now const.

        * rendering/RenderWidget.cpp: Added newly-needed include.
        (WebCore::RenderWidget::setSelectionState): Don't bother setting m_selectionState
        here since RenderReplaced::setSelectionState already does that.

WebKit:

        Reviewed by Hyatt.

        * Misc/WebNSAttributedStringExtras.m:
        (+[NSAttributedString _web_attributedStringFromRange:]):
        Updated to use new list marker text API that is String rather than
        DeprecatedString. Also removed code to do text form of non-text list
        markers since the list marker class now deals with that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
andersca [Sat, 6 Jan 2007 01:13:35 +0000 (01:13 +0000)]
    Reviewed by Darin.

        Fix build.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchCreatePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber stamped by Adam.
andersca [Sat, 6 Jan 2007 00:55:49 +0000 (00:55 +0000)]
    Rubber stamped by Adam.

        Move even more code to .cpp files.

        * WebCore.xcodeproj/project.pbxproj:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createWindow):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::canLoad):
        (WebCore::FrameLoader::initialRequest):
        (WebCore::FrameLoader::receivedData):
        (WebCore::FrameLoader::setRequest):
        (WebCore::FrameLoader::setResponse):
        (WebCore::FrameLoader::willUseArchive):
        (WebCore::FrameLoader::handleUnimplementablePolicy):
        (WebCore::FrameLoader::cannotShowMIMEType):
        (WebCore::FrameLoader::interruptionForPolicyChangeError):
        (WebCore::FrameLoader::checkNavigationPolicy):
        (WebCore::FrameLoader::checkContentPolicy):
        (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
        (WebCore::FrameLoader::reloadAllowingStaleData):
        (WebCore::FrameLoader::reload):
        (WebCore::FrameLoader::finishedLoading):
        (WebCore::FrameLoader::continueAfterWillSubmitForm):
        (WebCore::FrameLoader::submitForm):
        (WebCore::FrameLoader::post):
        (WebCore::FrameLoader::isReloading):
        (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
        (WebCore::FrameLoader::loadResourceSynchronously):
        (WebCore::FrameLoader::startLoadingMainResource):
        (WebCore::FrameLoader::startLoading):
        (WebCore::FrameLoader::cancelMainResourceLoad):
        (WebCore::FrameLoader::identifierForInitialRequest):
        (WebCore::FrameLoader::willSendRequest):
        (WebCore::FrameLoader::didReceiveResponse):
        (WebCore::FrameLoader::didReceiveData):
        (WebCore::FrameLoader::didFailToLoad):
        (WebCore::FrameLoader::originalRequest):
        (WebCore::FrameLoader::receivedMainResourceError):
        (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
        (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
        (WebCore::FrameLoader::opened):
        (WebCore::FrameLoader::dataURLBaseFromRequest):
        (WebCore::FrameLoader::checkNewWindowPolicy):
        (WebCore::FrameLoader::continueAfterNewWindowPolicy):
        (WebCore::FrameLoader::continueAfterNavigationPolicy):
        (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
        (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
        (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
        (WebCore::FrameLoader::sendRemainingDelegateMessages):
        (WebCore::FrameLoader::requestFromDelegate):
        (WebCore::FrameLoader::loadedResourceFromMemoryCache):
        (WebCore::FrameLoader::applyUserAgent):
        (WebCore::PolicyCheck::PolicyCheck):
        (WebCore::PolicyCheck::clear):
        (WebCore::PolicyCheck::set):
        (WebCore::PolicyCheck::call):
        (WebCore::PolicyCheck::clearRequest):
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.h:
        * loader/ResourceLoader.h:
        (WebCore::ResourceLoader::setIdentifier):
        (WebCore::ResourceLoader::identifier):
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
        (WebCore::FrameLoader::referrer):
        (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
        (WebCore::FrameLoader::didCancelAuthenticationChallenge):
        (WebCore::FrameLoader::didChangeTitle):
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::dispatchCreatePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
adele [Fri, 5 Jan 2007 23:03:50 +0000 (23:03 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - repaint tests and updated results for
          http://bugs.webkit.org/show_bug.cgi?id=12079
          Nested tables don't repaint properly when a certain row is added

        * fast/repaint/table-section-overflow-expected.checksum: Added.
        * fast/repaint/table-section-overflow-expected.png: Added.
        * fast/repaint/table-section-overflow-expected.txt: Added.
        * fast/repaint/table-section-overflow.html: Added.
        * fast/repaint/table-section-repaint-expected.checksum: Added.
        * fast/repaint/table-section-repaint-expected.png: Added.
        * fast/repaint/table-section-repaint-expected.txt: Added.
        * fast/repaint/table-section-repaint.html: Added.
        * tables/mozilla/core/misc-expected.txt:
        * tables/mozilla/core/misc-expected.png:
        * tables/mozilla/core/misc-expected.checksum:

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12079
          Nested tables don't repaint properly when a certain row is added

        Tests: fast/repaint/table-section-repaint.html
               fast/repaint/table-section-overflow.html

        Fixed repainting when table sections move during layout.

        Made table cells' overflows propagate to table sections and gave tables
        overflows.

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::layout): Added computation of horizontal and vertical overflows
        based on the caption's and the table sections' overflows.
        Added checks for table sections that change position during layout. When that happens,
        we assume all sections below the first section that moved also moved, and repaint
        everything downwards from there.
        Added calls to repaintDuringLayoutIfMoved() for the caption.
        Changed the way table sections are iterated over and added a FIXME to change it again
        once bug 12124 is fixed.
        (WebCore::RenderTable::paint): Changed to paint overflow.
        (WebCore::RenderTable::outerBorderBottom):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::RenderTableSection):
        (WebCore::RenderTableSection::layoutRows): Added code to compute the section's overflow
        and a flag saying whether any cells in this section overflow.
        (WebCore::RenderTableSection::paint): Changed to paint overflow. If any cell
        in the section has overflow, then all cells are given a chance to paint. This is needed
        because there can be internal overflow, and external overflow can be coming from any
        cell inside.
        * rendering/RenderTableSection.h:
        (WebCore::RenderTableSection::overflowWidth):
        (WebCore::RenderTableSection::overflowLeft):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam.
bdakin [Fri, 5 Jan 2007 22:48:47 +0000 (22:48 +0000)]
    Reviewed by Adam.

        Fix for <rdar://problem/4863434> Wrong contextual menu appears for
        textarea and input elements at http://www.apple.com/feedback/
        ical.html

        No test cases added since context menus are not in DRT.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::handleContextMenuEvent): Call
        EventHandler's hitTestResultAtPoint() instead of just hit testing
        the layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoindependEnt
andersca [Fri, 5 Jan 2007 22:27:53 +0000 (22:27 +0000)]
independEnt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Adam.
andersca [Fri, 5 Jan 2007 22:26:32 +0000 (22:26 +0000)]
    Rubber-stamped by Adam.

        Move a bunch of platform independant code over to DocumentLoader.cpp

        * WebCore.xcodeproj/project.pbxproj:
        * loader/DocumentLoader.cpp:
        (WebCore::canonicalizedTitle):
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::frameLoader):
        (WebCore::DocumentLoader::~DocumentLoader):
        (WebCore::DocumentLoader::setMainResourceData):
        (WebCore::DocumentLoader::mainResourceData):
        (WebCore::DocumentLoader::originalRequest):
        (WebCore::DocumentLoader::originalRequestCopy):
        (WebCore::DocumentLoader::request):
        (WebCore::DocumentLoader::initialRequest):
        (WebCore::DocumentLoader::actualRequest):
        (WebCore::DocumentLoader::URL):
        (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
        (WebCore::DocumentLoader::setRequest):
        (WebCore::DocumentLoader::setMainDocumentError):
        (WebCore::DocumentLoader::clearErrors):
        (WebCore::DocumentLoader::mainReceivedError):
        (WebCore::DocumentLoader::stopLoading):
        (WebCore::DocumentLoader::setupForReplace):
        (WebCore::DocumentLoader::commitIfReady):
        (WebCore::DocumentLoader::finishedLoading):
        (WebCore::DocumentLoader::setCommitted):
        (WebCore::DocumentLoader::isCommitted):
        (WebCore::DocumentLoader::setLoading):
        (WebCore::DocumentLoader::isLoading):
        (WebCore::DocumentLoader::commitLoad):
        (WebCore::DocumentLoader::doesProgressiveLoad):
        (WebCore::DocumentLoader::receivedData):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        (WebCore::DocumentLoader::updateLoading):
        (WebCore::DocumentLoader::setFrame):
        (WebCore::DocumentLoader::attachToFrame):
        (WebCore::DocumentLoader::detachFromFrame):
        (WebCore::DocumentLoader::prepareForLoadStart):
        (WebCore::DocumentLoader::setIsClientRedirect):
        (WebCore::DocumentLoader::isClientRedirect):
        (WebCore::DocumentLoader::setPrimaryLoadComplete):
        (WebCore::DocumentLoader::isLoadingInAPISense):
        (WebCore::DocumentLoader::addResponse):
        (WebCore::DocumentLoader::stopRecordingResponses):
        (WebCore::DocumentLoader::title):
        (WebCore::DocumentLoader::setLastCheckedRequest):
        (WebCore::DocumentLoader::lastCheckedRequest):
        (WebCore::DocumentLoader::triggeringAction):
        (WebCore::DocumentLoader::setTriggeringAction):
        (WebCore::DocumentLoader::responses):
        (WebCore::DocumentLoader::setOverrideEncoding):
        (WebCore::DocumentLoader::overrideEncoding):
        (WebCore::DocumentLoader::setTitle):
        (WebCore::DocumentLoader::urlForHistory):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::committedLoad):
        (WebCore::FrameLoader::setMainDocumentError):
        (WebCore::FrameLoader::mainReceivedCompleteError):
        (WebCore::FrameLoader::mainReceivedError):
        (WebCore::FrameLoader::cancelledError):
        (WebCore::FrameLoader::fileDoesNotExistError):
        (WebCore::FrameLoader::mainResourceData):
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::unreachableURL):
        * loader/mac/FrameLoaderMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed Eric's name
beidson [Fri, 5 Jan 2007 21:18:08 +0000 (21:18 +0000)]
Fixed Eric's name

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric Siedel
beidson [Fri, 5 Jan 2007 21:14:52 +0000 (21:14 +0000)]
    Reviewed by Eric Siedel

        http://bugs.webkit.org/show_bug.cgi?id=12117
        Fixes null deref when opening links from a gmail account

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::updateHistoryForStandardLoad): Null check m_currentHistoryItem
        (WebCore::FrameLoader::updateHistoryForClientRedirect): Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Move some now cross platform functions over to ResourceLoader.cpp in an attem...
andersca [Fri, 5 Jan 2007 21:00:47 +0000 (21:00 +0000)]
    Move some now cross platform functions over to ResourceLoader.cpp in an attempt to fix the non Mac builds.

        * loader/CachedResource.h:
        (WebCore::CachedResource::setAllData):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::resourceData):
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::didFinishLoading):
        * loader/mac/LoaderFunctionsMac.mm:
        * loader/mac/ResourceLoaderMac.mm:
        * platform/SharedBuffer.cpp:
        (WebCore::SharedBuffer::platformDataSize):
        * platform/network/ResourceHandle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLand updated results for float tests.
hyatt [Fri, 5 Jan 2007 20:57:54 +0000 (20:57 +0000)]
Land updated results for float tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Back out fix for 12114. I missed rule #5 in the float positioning part of...
hyatt [Fri, 5 Jan 2007 20:56:58 +0000 (20:56 +0000)]
    Back out fix for 12114.  I missed rule #5 in the float positioning part of the CSS2.1 spec.  Keep all
        the code cleanup though.

        Reviewed by mitz

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionNewFloats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca [Fri, 5 Jan 2007 19:33:24 +0000 (19:33 +0000)]
WebCore:

        Reviewed by Maciej.

        Add a shared buffer class which is backed by either a vector or an NSData object. This object can also
        be held in a custom NSData subclass. Use this in the loader wherever NSData was used.

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/CachedResource.h:
        (WebCore::CachedResource::allData):
        * loader/DocumentLoader.h:
        * loader/FrameLoader.h:
        * loader/ResourceLoader.h:
        * loader/SubresourceLoaderClient.h:
        (WebCore::SubresourceLoaderClient::didFail):
        * loader/loader.cpp:
        (WebCore::Loader::didFinishLoading):
        * loader/loader.h:
        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::setMainResourceData):
        (WebCore::DocumentLoader::mainResourceData):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::mainResourceData):
        * loader/mac/ImageDocumentMac.mm:
        (WebCore::finishImageLoad):
        * loader/mac/LoaderFunctionsMac.mm:
        (WebCore::CheckCacheObjectStatus):
        (WebCore::CachedResource::setAllData):
        * loader/mac/NetscapePlugInStreamLoaderMac.mm:
        (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::addData):
        (WebCore::ResourceLoader::resourceData):
        (WebCore::ResourceLoader::clearResourceData):
        (WebCore::ResourceLoader::didReceiveData):
        (WebCore::ResourceLoader::willStopBufferingData):
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::didReceiveResponse):
        (WebCore::SubresourceLoader::didFinishLoading):
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge getData:andResponse:forURL:]):
        (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
        * platform/KURL.h:
        * platform/SharedBuffer.cpp: Added.
        (WebCore::SharedBuffer::SharedBuffer):
        (WebCore::SharedBuffer::size):
        (WebCore::SharedBuffer::data):
        (WebCore::SharedBuffer::append):
        (WebCore::SharedBuffer::clear):
        (WebCore::SharedBuffer::clearPlatformData):
        (WebCore::SharedBuffer::maybeTransferPlatformData):
        (WebCore::SharedBuffer::hasPlatformData):
        (WebCore::SharedBuffer::platformData):
        * platform/SharedBuffer.h: Added.
        * platform/mac/SharedBufferMac.mm: Added.
        (-[SharedBufferData dealloc]):
        (-[SharedBufferData finalize]):
        (-[SharedBufferData initWithSharedBuffer:WebCore::]):
        (-[SharedBufferData length]):
        (-[SharedBufferData bytes]):
        (WebCore::SharedBuffer::wrapNSData):
        (WebCore::SharedBuffer::SharedBuffer):
        (WebCore::SharedBuffer::createNSData):
        (WebCore::SharedBuffer::hasPlatformData):
        (WebCore::SharedBuffer::platformData):
        (WebCore::SharedBuffer::platformDataSize):
        (WebCore::SharedBuffer::maybeTransferPlatformData):
        (WebCore::SharedBuffer::clearPlatformData):
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::bufferedData):

WebKit:

        Reviewed by Maciej.

        The data returned is now a SharedBuffer so wrap it in an NSData object.

        * WebView/WebDataSource.mm:
        (-[WebDataSource data]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap [Fri, 5 Jan 2007 19:26:50 +0000 (19:26 +0000)]
    Reviewed by Darin.

        Test for http://bugs.webkit.org/show_bug.cgi?id=3420
        XMLHttpRequest does not handle set-cookie headers

        * http/tests/xmlhttprequest/resources/get-set-cookie.cgi:
        Set the cookies unconditionally (previously, the test failed if there
        were other cookies for 127.0.0.1:8000.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam.
andersca [Fri, 5 Jan 2007 19:02:22 +0000 (19:02 +0000)]
    Reviewed by Adam.

        http://bugs.webkit.org/show_bug.cgi?id=12120
        REGRESSION(r18605): Safari snippet editor no longer works

        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::willSendRequest):
        Put back the code change in r18607.

        * platform/mac/KURLMac.mm:
        (WebCore::KURL::KURL):
        Convert nil NSURLs to null KURLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff.
ap [Fri, 5 Jan 2007 16:15:22 +0000 (16:15 +0000)]
    Reviewed by Geoff.

        http://bugs.webkit.org/show_bug.cgi?id=7296
        Disable JavaScript exceptions when dynamically changing CSS properties.

        * bindings/js/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclaration::put): Removed the Dashboard quirk logic.

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setProperty): Don't raise an exception if parsing fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agobe smarter when detecting the display (hopefully fixes
zack [Fri, 5 Jan 2007 13:24:46 +0000 (13:24 +0000)]
be smarter when detecting the display (hopefully fixes
running the layout tests with the buildbot)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
antti [Fri, 5 Jan 2007 09:00:33 +0000 (09:00 +0000)]
LayoutTests:

        Reviewed by hyatt.

        Test for http://bugs.webkit.org/show_bug.cgi?id=12109
        layer visibility incorrect in some cases

        * fast/layers/layer-visibility-sublayer-expected.checksum: Added.
        * fast/layers/layer-visibility-sublayer-expected.png: Added.
        * fast/layers/layer-visibility-sublayer-expected.txt: Added.
        * fast/layers/layer-visibility-sublayer.html: Added.

WebCore:

        Reviewed by hyatt.

        http://bugs.webkit.org/show_bug.cgi?id=12109

        Fix layer visibility in some cases with nested layers.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateVisibilityStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agothe daily checkin to get the Qt build compiling again :)
lars [Fri, 5 Jan 2007 08:43:49 +0000 (08:43 +0000)]
the daily checkin to get the Qt build compiling again :)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
aroben [Fri, 5 Jan 2007 07:44:46 +0000 (07:44 +0000)]
WebCore:

        Reviewed by Geoff, cheered by others.

        Dead code elimination.

        All layout tests pass.

        * page/EventHandler.h:
        * page/mac/EventHandlerMac.mm:
        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:

WebKit:

        Reviewed by Geoff, cheered by others.

        Dead code elimination.

        * WebView/WebHTMLView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Boo on me for undoing Beth's hard work.
aroben [Fri, 5 Jan 2007 07:26:24 +0000 (07:26 +0000)]
    Boo on me for undoing Beth's hard work.

        * WebView/WebHTMLView.m:
        (-[WebHTMLView menuForEvent:]): Undo a mistaken roll out of r18597.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit:
ddkilzer [Fri, 5 Jan 2007 07:21:33 +0000 (07:21 +0000)]
WebKit:

        Reviewed by Brady.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12111
          Uninitialized variable in -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]

        * DefaultDelegates/WebDefaultPolicyDelegate.m: Initialize isDirectory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools:
ddkilzer [Fri, 5 Jan 2007 06:36:50 +0000 (06:36 +0000)]
WebKitTools:

        Reviewed by Mark Rowe.

        Speed up svn-create-patch for copied and moved files.

        * Scripts/svn-create-patch:
        (manufacturePatchForAdditionWithHistory($$)): Use 'svn cat' instead of 'svn cat -rNNNNN'
        so svn pulls original from local disk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
aroben [Fri, 5 Jan 2007 06:18:36 +0000 (06:18 +0000)]
LayoutTests:

        Reviewed by Geoff.

        Added new tests for tabindex and tabbing into/out of subframes.

        * fast/dom/tabindex-clamp-expected.txt: Added.
        * fast/dom/tabindex-clamp.html: Added.
        * fast/events/frame-click-focus-expected.txt: Added.
        * fast/events/frame-click-focus.html: Added.
        * fast/events/frame-tab-focus-expected.txt: Added.
        * fast/events/frame-tab-focus.html: Added.
        * fast/events/resources/frame-tab-focus-child.html: Added.
        * fast/events/resources/frame-tab-focus-empty-child.html: Added.
        * fast/events/resources/frame-tab-focus-empty-middle.html: Added.
        * fast/events/resources/frame-tab-focus-middle.html: Added.
        * fast/events/resources/frame-tab-focus-upper.html: Added.
        * fast/html/tab-order-expected.txt: Added.
        * fast/html/tab-order.html: Added.

        Updated test to match new behavior.

        * fast/forms/focus2-expected.txt: Updated results.
        * fast/forms/focus2.html: Fixed typo, and reduced the number of tab
        events dispatched now that frames containing focusable elements aren't
        themselves in the tab order.

WebCore:

        Reviewed by Geoff.

        Fix: <rdar://4800335> REGRESSION: shift-tabbing from location field
        goes to first field rather than last (businessweek.com)

        Fix: <rdar://4800373> REGRESSION: tabbing from last control focuses
        nothing visible (busniessweek.com)

        Handle tabbing into/out of subframes in WebCore instead of letting
        AppKit do the dirty work. This change also fixes a number of bugs and
        changes some behavior to match other browsers:
          - No frames receive a focus event when the page is first loaded.
          - When a frame is clicked or focused with the keyboard, it receives
            a focus event and all other frames receive a blur event.
          - tabindex values are clamped to the range of a signed short, rather
            than overflowing within an unsigned short.
          - tabindex is respected on frame owner elements, even though HTML4
            says it shouldn't be.
          - Subframes will be focused when tabbing if they don't contain any
            focusable elements within them (it would be nice to only focus the
            frame if it has scrollbars).

        Renamed SelectionDirection to FocusDirection and put it in its own file.

        * page/FocusDirection.h: Added.
        (WebCore::):
        * page/mac/WebCoreFrameBridge.mm: Updated for renames.
        (-[WebCoreFrameBridge nextKeyView]):
        (-[WebCoreFrameBridge previousKeyView]):
        (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]):
        (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):

        Moved advanceFocus from EventHandler to FocusController and added
        support for moving into/out of subframes..

        * page/EventHandler.cpp: Moved advanceFocus to FocusController.
        * page/EventHandler.h: Ditto.
        * page/FocusController.cpp:
        (WebCore::deepFocusableNode): Static helper function to find focusable
        nodes nested within frames.
        (WebCore::FocusController::advanceFocus): Moved from EventHandler and
        rewritten to handle subframes.
        * page/FocusController.h: Added advanceFocus declaration.
        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::defaultEventHandler): Updated for the move
        of advanceFocus to FocusController.
        * html/HTMLFrameOwnerElement.h:
        (WebCore::HTMLFrameOwnerElement::isFrameOwnerElement): New method.
        (WebCore::HTMLFrameOwnerElement::isKeyboardFocusable): New virtual
        implementation used to trick Document::nextFocusableNode so that we
        can focus frames.

        Rewrote/renamed
        Document::nextFocusableNode/Document::previousFocusableNode.

        * dom/Document.cpp:
        (WebCore::nextNodeWithExactTabIndex): New static helper
        function.
        (WebCore::previousNodeWithExactTabIndex): Ditto.
        (WebCore::nextNodeWithGreaterTabIndex): Ditto.
        (WebCore::previousNodeWithLowerTabIndex): Ditto.
        (WebCore::Document::nextFocusableNode): Renamed from nextFocusedNode,
        and rewritten with much simpler logic.
        (WebCore::Document::previousFocusableNode): Ditto.
        * dom/Document.h: Updated declarations for renames.
        * page/mac/EventHandlerMac.mm: Updated for rename of SelectionDirection
        to FocusDirection.
        (WebCore::EventHandler::nextKeyViewInFrame): Updated for renames.
        (WebCore::EventHandler::nextKeyViewInFrameHierarchy): Ditto.
        (WebCore::EventHandler::nextKeyView): Ditto.
        (WebCore::EventHandler::focusDocumentView): Added call to
        setFocusedFrame when focusing the document view.
        (WebCore::EventHandler::passMouseDownEventToWidget): Removed LOG_ERROR
        when a nil NSView is returned from AppKit, as this is a fairly common
        occurrence when a RenderWidget has a border.
        (WebCore::EventHandler::passWheelEventToWidget): Added a nil-check of
        the hit-tested NSView.

        Changed storage of tabIndex to a signed short, and added clamping of
        tabindex attribute values to match Firefox's behavior.

        * dom/Node.h: Use a signed short to store m_tabIndex.
        (WebCore::Node::isFrameOwnerElement): New method.
        (WebCore::Node::tabIndex): Updated for signedness.
        (WebCore::Node::setTabIndex): Ditto.
        * html/HTMLAnchorElement.cpp: Remove implementation of tabIndex() so
        that Node::tabIndex() will be called instead and return the clamped
        value (which matches Firefox's behavior).
        * html/HTMLAnchorElement.h: Ditto.
        * html/HTMLAreaElement.cpp: Ditto.
        * html/HTMLAreaElement.h: Ditto.
        * html/HTMLGenericFormElement.cpp: Ditto.
        * html/HTMLGenericFormElement.h: Ditto.
        * html/HTMLObjectElement.cpp: Ditto.
        * html/HTMLObjectElement.h: Ditto.
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::parseMappedAttribute): Clamp tabIndex to the
        range of a signed short to match Firefox.

        Added two new Chrome methods for transferring focus out of the
        WebView.

        * page/Chrome.cpp:
        (WebCore::Chrome::canTakeFocus):
        (WebCore::Chrome::takeFocus):
        * page/Chrome.h:
        * page/ChromeClient.h:
        * platform/graphics/svg/SVGImageEmptyClients.h: Fixed typo "CromeClient" -> "ChromeClient".
        (WebCore::SVGEmptyChromeClient::~SVGEmptyChromeClient):
        (WebCore::SVGEmptyChromeClient::canTakeFocus):
        (WebCore::SVGEmptyChromeClient::takeFocus):
        * platform/graphics/svg/SVGImage.cpp:
        (WebCore::SVGImage::setData): Fixed typo.

        Miscellaneous:

        * WebCore.exp: Updated/sorted symbols.
        * WebCore.xcodeproj/project.pbxproj: Made FocusController.h Private so
        WebKit can access it.

WebKit:

        Reviewed by Geoff.

        Remove WebKit/AppKit from handling tabbing between subframes.

        * WebCoreSupport/WebChromeClient.h: Added new ChromeClient methods for
        moving focus out of the WebView.
        * WebCoreSupport/WebChromeClient.mm: Ditto.
        (WebChromeClient::canTakeFocus):
        (WebChromeClient::takeFocus):
        * WebCoreSupport/WebFrameBridge.mm:
        (-[WebFrameBridge webView]): Added null-check of m_frame.
        * WebView/WebHTMLView.m: Removed -[WebHTMLView nextValidKeyView].
        (-[WebHTMLView _updateActiveState]): Changed to focus the frame if
        WebCore believes it to be the focused frame.
        (-[WebHTMLView becomeFirstResponder]): Rewrote to call into
        FocusController to place focus correctly within the WebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reverted Anders' change to fix the world
beidson [Fri, 5 Jan 2007 05:58:44 +0000 (05:58 +0000)]
    Reverted Anders' change to fix the world

        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::willSendRequest):
        (WebCore::ResourceLoader::didReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
ddkilzer [Fri, 5 Jan 2007 05:56:31 +0000 (05:56 +0000)]
WebCore:

        Reviewed by Sam Weinig.

        - http://bugs.webkit.org/show_bug.cgi?id=12078
          Clean up RenderTable*

        - Coding style cleanup.
        - Canceled AutoTableLayout and FixedTableLayout being friend classes of
          RenderTable. Instead, added public accessors to RenderTable for what
          the table layout classes need and changed TableLayout::calcMinMaxWidth()
          to take references to the caller's min and max widths.
        - Made RenderTableSection's grid protected and moved code that accessed it
          from RenderTable into RenderTableSection.

        No test possible (no change to functionality).

        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::calcMinMaxWidth):
        (WebCore::AutoTableLayout::layout):
        * rendering/AutoTableLayout.h:
        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray):
        (WebCore::FixedTableLayout::calcMinMaxWidth):
        (WebCore::FixedTableLayout::layout):
        * rendering/FixedTableLayout.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::RenderTable):
        (WebCore::RenderTable::~RenderTable):
        (WebCore::RenderTable::setStyle):
        (WebCore::RenderTable::addChild):
        (WebCore::RenderTable::calcWidth):
        (WebCore::RenderTable::layout):
        (WebCore::RenderTable::setCellWidths):
        (WebCore::RenderTable::paint):
        (WebCore::RenderTable::paintBoxDecorations):
        (WebCore::RenderTable::calcMinMaxWidth):
        (WebCore::RenderTable::splitColumn): Factored out the section work
        to RenderTableSection::splitColumn().
        (WebCore::RenderTable::appendColumn): Factored out the section work
        to RenderTableSection::appendColumn().
        (WebCore::RenderTable::colElement):
        (WebCore::RenderTable::recalcSections):
        (WebCore::RenderTable::removeChildNode):
        (WebCore::RenderTable::calcBorderLeft):
        (WebCore::RenderTable::calcBorderRight):
        (WebCore::RenderTable::outerBorderTop):
        (WebCore::RenderTable::outerBorderBottom):
        (WebCore::RenderTable::outerBorderLeft):
        (WebCore::RenderTable::outerBorderRight):
        (WebCore::RenderTable::sectionAbove):
        (WebCore::RenderTable::sectionBelow):
        (WebCore::RenderTable::cellAbove):
        (WebCore::RenderTable::cellBelow):
        (WebCore::RenderTable::cellBefore):
        (WebCore::RenderTable::getOverflowClipRect):
        (WebCore::RenderTable::dump):
        * rendering/RenderTable.h:
        (WebCore::RenderTable::getColumnPos):
        (WebCore::RenderTable::hBorderSpacing):
        (WebCore::RenderTable::vBorderSpacing):
        (WebCore::RenderTable::getRules):
        (WebCore::RenderTable::cellPadding):
        (WebCore::RenderTable::setCellPadding):
        (WebCore::RenderTable::ColumnStruct::ColumnStruct):
        (WebCore::RenderTable::columns): Added this accessor.
        (WebCore::RenderTable::columnPositions): Added this accessor.
        (WebCore::RenderTable::header):
        (WebCore::RenderTable::footer):
        (WebCore::RenderTable::firstBody):
        (WebCore::RenderTable::numEffCols):
        (WebCore::RenderTable::spanOfEffCol):
        (WebCore::RenderTable::colToEffCol):
        (WebCore::RenderTable::effColToCol):
        (WebCore::RenderTable::bordersPaddingAndSpacing):
        (WebCore::RenderTable::needsSectionRecalc):
        (WebCore::RenderTable::setNeedsSectionRecalc): Renamed setNeedSectionRecalc()
        to this.
        (WebCore::RenderTable::hasSections):
        (WebCore::RenderTable::recalcSectionsIfNeeded):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::RenderTableCell):
        (WebCore::RenderTableCell::destroy):
        (WebCore::RenderTableCell::updateFromElement):
        (WebCore::RenderTableCell::styleOrColWidth):
        (WebCore::RenderTableCell::computeAbsoluteRepaintRect):
        (WebCore::RenderTableCell::absolutePosition):
        (WebCore::RenderTableCell::baselinePosition):
        (WebCore::RenderTableCell::setStyle):
        (WebCore::compareBorders):
        (WebCore::RenderTableCell::collapsedTopBorder):
        (WebCore::RenderTableCell::paint):
        (WebCore::collapsedBorderStyle):
        (WebCore::CollapsedBorder::CollapsedBorder):
        (WebCore::CollapsedBorders::CollapsedBorders):
        (WebCore::CollapsedBorders::addBorder):
        (WebCore::CollapsedBorders::nextBorder):
        (WebCore::RenderTableCell::paintCollapsedBorder):
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):
        (WebCore::RenderTableCell::paintBoxDecorations):
        (WebCore::RenderTableCell::dump):
        * rendering/RenderTableCell.h:
        (WebCore::RenderTableCell::colSpan):
        (WebCore::RenderTableCell::setColSpan):
        (WebCore::RenderTableCell::rowSpan):
        (WebCore::RenderTableCell::setRowSpan):
        (WebCore::RenderTableCell::col):
        (WebCore::RenderTableCell::setCol):
        (WebCore::RenderTableCell::row):
        (WebCore::RenderTableCell::setRow):
        (WebCore::RenderTableCell::section):
        (WebCore::RenderTableCell::table):
        (WebCore::RenderTableCell::yPos):
        (WebCore::RenderTableCell::setCellTopExtra):
        (WebCore::RenderTableCell::setCellBottomExtra):
        (WebCore::RenderTableCell::borderTopExtra):
        (WebCore::RenderTableCell::borderBottomExtra):
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::destroy):
        (WebCore::RenderTableRow::setStyle):
        (WebCore::RenderTableRow::addChild):
        (WebCore::RenderTableRow::layout):
        (WebCore::RenderTableRow::getAbsoluteRepaintRect):
        (WebCore::RenderTableRow::paint):
        * rendering/RenderTableRow.h:
        (WebCore::RenderTableRow::section):
        (WebCore::RenderTableRow::table):
        (WebCore::RenderTableRow::lineHeight):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::RenderTableSection):
        (WebCore::RenderTableSection::destroy):
        (WebCore::RenderTableSection::setStyle):
        (WebCore::RenderTableSection::addChild):
        (WebCore::RenderTableSection::ensureRows):
        (WebCore::RenderTableSection::addCell):
        (WebCore::RenderTableSection::setCellWidths):
        (WebCore::RenderTableSection::calcRowHeight):
        (WebCore::RenderTableSection::layoutRows):
        (WebCore::RenderTableSection::lowestPosition):
        (WebCore::RenderTableSection::rightmostPosition):
        (WebCore::RenderTableSection::leftmostPosition):
        (WebCore::RenderTableSection::calcOuterBorderTop):
        (WebCore::RenderTableSection::calcOuterBorderBottom):
        (WebCore::RenderTableSection::calcOuterBorderLeft):
        (WebCore::RenderTableSection::calcOuterBorderRight):
        (WebCore::RenderTableSection::paint):
        (WebCore::RenderTableSection::recalcCells):
        (WebCore::RenderTableSection::clearGrid):
        (WebCore::RenderTableSection::numColumns):
        (WebCore::RenderTableSection::appendColumn): Added. Moved code from
        RenderTable::appendColumn() into here.
        (WebCore::RenderTableSection::splitColumn): Added. Moved code from
        RenderTable::splitColumn() into here.
        (WebCore::RenderTableSection::removeChildNode):
        (WebCore::RenderTableSection::dump):
        * rendering/RenderTableSection.h:
        (WebCore::RenderTableSection::renderName):
        (WebCore::RenderTableSection::isTableSection):
        (WebCore::RenderTableSection::lineHeight):
        (WebCore::RenderTableSection::table):
        (WebCore::RenderTableSection::cellAt):
        (WebCore::RenderTableSection::numRows):
        (WebCore::RenderTableSection::recalcCellsIfNeeded):
        (WebCore::RenderTableSection::needsCellRecalc):
        (WebCore::RenderTableSection::setNeedsCellRecalc):
        (WebCore::RenderTableSection::getBaseline):
        * rendering/TableLayout.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam.
andersca [Fri, 5 Jan 2007 05:14:20 +0000 (05:14 +0000)]
    Reviewed by Adam.

        http://bugs.webkit.org/show_bug.cgi?id=12120
        REGRESSION(r18605): Safari snippet editor no longer works

        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::willSendRequest):
        Fix logic so applewebdata: URLs no longer cause the underlying URL to be fetched .

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam.
andersca [Fri, 5 Jan 2007 03:34:59 +0000 (03:34 +0000)]
    Reviewed by Adam.

        Move all remaining instances of NSURLRequest over to ResourceRequest (well, pretty much all).

        * loader/MainResourceLoader.h:
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.h:
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::startLoadingMainResource):
        * loader/mac/MainResourceLoaderMac.mm:
        (WebCore::MainResourceLoader::loadNow):
        (WebCore::MainResourceLoader::load):
        (WebCore::MainResourceLoader::setDefersLoading):
        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::load):
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::load):
        (WebCore::SubresourceLoader::create):
        * platform/graphics/svg/SVGImage.cpp:
        (WebCore::SVGImage::setData):
        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::ResourceRequest::doUpdatePlatformRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca [Fri, 5 Jan 2007 02:40:22 +0000 (02:40 +0000)]
WebCore:

        Reviewed by Brady.

        Move more NSURLRequests over to ResourceRequests.

        * loader/DocumentLoader.h:
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.h:
        * loader/ResourceLoader.h:
        (WebCore::ResourceLoader::request):
        * loader/SubresourceLoader.h:
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::willSendRequest):
        (WebCore::FrameLoader::opened):
        (WebCore::FrameLoader::requestFromDelegate):
        (WebCore::FrameLoader::loadedResourceFromMemoryCache):
        (WebCore::FrameLoader::loadResourceSynchronously):
        * loader/mac/MainResourceLoaderMac.mm:
        (WebCore::MainResourceLoader::willSendRequest):
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        (WebCore::MainResourceLoader::loadNow):
        (WebCore::MainResourceLoader::setDefersLoading):
        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::load):
        (WebCore::ResourceLoader::willSendRequest):
        (WebCore::ResourceLoader::didReceiveResponse):
        (WebCore::ResourceLoader::cancelledError):
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::willSendRequest):
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
        * platform/network/ResourceRequest.cpp:
        (WebCore::ResourceRequest::isNull):
        * platform/network/ResourceRequest.h:

WebKit:

        Reviewed by Brady.

        FrameLoaderClient changed yet again.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
        (WebFrameLoaderClient::dispatchWillSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe
beidson [Fri, 5 Jan 2007 02:20:40 +0000 (02:20 +0000)]
    Reviewed by Mark Rowe

        http://bugs.webkit.org/show_bug.cgi?id=12119
        Changing the behavior of HistoryItem::pageCache() this morning also necessitated
        changing the behavior of HistoryItem::hasPageCache()

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::hasPageCache): Add the same pendingRelease check pageCache() has

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-01-04 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 5 Jan 2007 00:36:51 +0000 (00:36 +0000)]
2007-01-04  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Sam Weinig.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12043
          Another assertion failure in WebCore::RenderObject::drawBorder

        Test: fast/borders/border-radius-huge-assert.html

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::addRoundedRectClip): Fixed the check for border radii
        that do not fit in the given width or height to work with radii that sum up to
        more than MAX_INT.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::paintBorder): Ditto.

2007-01-04  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Sam Weinig.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=12043
          Another assertion failure in WebCore::RenderObject::drawBorder

        * fast/borders/border-radius-huge-assert-expected.checksum: Added.
        * fast/borders/border-radius-huge-assert-expected.png: Added.
        * fast/borders/border-radius-huge-assert-expected.txt: Added.
        * fast/borders/border-radius-huge-assert.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
justing [Fri, 5 Jan 2007 00:35:15 +0000 (00:35 +0000)]
LayoutTests:

        Reviewed by john

        <rdar://problem/4861080>
        GMail Editor: Crash when dropping content into certain list items

        * editing/pasteboard/4861080-expected.checksum: Added.
        * editing/pasteboard/4861080-expected.png: Added.
        * editing/pasteboard/4861080-expected.txt: Added.
        * editing/pasteboard/4861080.html: Added.

WebCore:

        Reviewed by john

        <rdar://problem/4861080>
        GMail Editor: Crash when dropping content into certain list items

        A rendering bug (4907469) creates unwanted space at the top of a
        list item when its contents are wrapped in span.  Dropping content
        inside that space causes a crash because positionForCoordinates
        fails there and the code that creates drag carets can't handle it.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge _visiblePositionForPoint:]): Added the
        that's inside click handling for the case where
        positionForCoordinates returns null.  We should also fix
        positionForCoordinates but that's less important: now its only side
        effect is that a no-op drop is performed instead of a snap back
        when you drop the contents of one of these list items its own
        unwanted space.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam.
bdakin [Fri, 5 Jan 2007 00:14:35 +0000 (00:14 +0000)]
    Reviewed by Adam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12118 REGRESSION
        (Context menus): No context menu displayed when clicking outside a
        short document

        No test case added since we do not currently have a way to automate
        context menus.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::handleContextMenuEvent): If the
        hit test does not find a node, use the document node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix table test for bold change. No idea why this changed by a pixel though.
hyatt [Fri, 5 Jan 2007 00:04:21 +0000 (00:04 +0000)]
Fix table test for bold change.  No idea why this changed by a pixel though.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca [Thu, 4 Jan 2007 23:59:46 +0000 (23:59 +0000)]
WebCore:

        Reviewed by Adam.

        Convert NSURLRequest to ResourceRequest in a few places

        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.h:
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::identifierForInitialRequest):
        (WebCore::FrameLoader::willUseArchive):
        * loader/mac/MainResourceLoaderMac.mm:
        (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::download):
        (WebCore::SVGEmptyFrameLoaderClient::willUseArchive):

WebKit:

        Reviewed by Adam.

        FrameLoaderClient changed again.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::download):
        (WebFrameLoaderClient::willUseArchive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam.
bdakin [Thu, 4 Jan 2007 23:22:43 +0000 (23:22 +0000)]
    Reviewed by Adam.

        No need to hit test twice.

        * WebView/WebHTMLView.m:
        (-[WebHTMLView menuForEvent:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNew layout test for bug 12114.
hyatt [Thu, 4 Jan 2007 22:58:43 +0000 (22:58 +0000)]
New layout test for bug 12114.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Bug 12114 fix, make sure left/right floats are allowed to go above
hyatt [Thu, 4 Jan 2007 22:58:12 +0000 (22:58 +0000)]
    Bug 12114 fix, make sure left/right floats are allowed to go above
        other floats of opposite alignment.

        Reviewed by aroben

        fast/block/float/independent-align-positioning.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionNewFloats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Brady.
andersca [Thu, 4 Jan 2007 22:56:24 +0000 (22:56 +0000)]
    Reviewed by Brady.

        http://bugs.webkit.org/show_bug.cgi?id=12116
        REGRESSION: ASSERTION FAILED: URL in +[WebDataProtocol _webIsDataProtocolURL:]

        <rdar://problem/4908910>
        REGRESSION: After switching to Bookmarks view, the browser window is completely empty (no bookmarks are displayed)

        * platform/network/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        Initialize m_isNull

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
bdakin [Thu, 4 Jan 2007 21:47:37 +0000 (21:47 +0000)]
WebCore:
        Reviewed by Adam.

        Turn on WebCore context menus.

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::defaultEventHandler): Turn on WebCore
        menus.
        * page/ContextMenuClient.h: Name change and have the
        former getCustomMenuFromDefaultItems function return the
        PlatformMenuDescription since it feels funny to have the client set
        the new platform description.
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::handleContextMenuEvent): Above
        name change.
        (WebCore::ContextMenuController::contextMenuItemSelected): Use
        local variable.
        * platform/ContextMenu.cpp:
        (WebCore::createAndAppendSpeechSubMenu): Fix silly mistake -- make
        "Stop speaking" actually stop speaking.
        * platform/graphics/svg/SVGImageEmptyClients.h: Name change and
        have the former getCustomMenuFromDefaultItems function return the
        PlatformMenuDescription since it feels funny to have the client set
        the new platform description.
       (WebCore::SVGEmptyContextMenuClient::getCustomMenuFromDefaultItems):

WebKit:
        Reviewed by Adam.

        Turn on WebCore context menus. Delete a bunch of WebKit context
        menu code that is no longer needed.

        * DefaultDelegates/WebDefaultContextMenuDelegate.m: Removed a lot
        of code from this class. This class only still needs to exist for
        PDF context menus, so we only need to deal with the menu items that
        might possibly be added to a PDF context menu.
        (-[WebDefaultUIDelegate
        menuItemWithTag:target:representedObject:]): Same.
        (-[WebDefaultUIDelegate
        webView:contextMenuItemsForElement:defaultMenuItems:]): Same.
        * WebCoreSupport/WebContextMenuClient.h: Name change and have the
        former getCustomMenuFromDefaultItems function return the
        PlatformMenuDescription since it feels funny to have the client set
        the new platform description.
        * WebCoreSupport/WebContextMenuClient.mm: Same.
        (WebContextMenuClient::getCustomMenuFromDefaultItems): Same. Also
        move in some code that used to be in _menuForElement.
        * WebView/WebHTMLView.m: Deleted a bunch of un-used functions
        (-[WebHTMLView menuForEvent:]): Turn on menus, and append the
        Inspect Element item.
        * WebView/WebHTMLViewPrivate.h: Deleted a bunch of un-used
        functions.
        * WebView/WebView.mm:
        (-[WebView _menuForElement:defaultItems:]): Removed a lot of code
        from _menuForElement that now makes more sense elsewhere. Only PDF
        context menus use this function now. Hopefully we can just get rid
        of it soon, too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate for synthetic bold change.
hyatt [Thu, 4 Jan 2007 21:03:36 +0000 (21:03 +0000)]
Update for synthetic bold change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed and landed by Brady
beidson [Thu, 4 Jan 2007 20:52:59 +0000 (20:52 +0000)]
    Reviewed and landed by Brady

        - fix http://bugs.webkit.org/show_bug.cgi?id=12087
          REGRESSION: Reproducible crash going back in Back/Forward history

        Allow a PageCache that is pending release to be resurrected by its
        HistoryItem instead of creating a new PageCache. This avoids the
        the condition of having two PageCaches for the same HistoryItem, one
        current and one pending release but not yet released, which was causing
        this and other bugs before.

        Replaced the vector of PageCaches pending release with a set of
        HistoryItems that are pending release of their PageCache.

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::setHasPageCache): Check for an existing PageCache
        pending release, and if found, resurrect it by canceling the release.
        (WebCore::HistoryItem::pageCache): Return 0 if the PageCache is pending
        release.
        (WebCore::itemsWithPendingPageCacheToRelease): Renamed pendingPageCacheToRelease
        to this. This method now returns a HashSet of HistoryItems that have scheduled
        their PageCaches for release.
        (WebCore::HistoryItem::releasePageCachesOrReschedule): Renamed releasePageCache
        to this.
        (WebCore::HistoryItem::releasePageCache): Added. Actually closes and releases
        the PageCache.
        (WebCore::HistoryItem::releaseAllPendingPageCaches): Rolled closeObjectsInPendingPageCaches
        into this method.
        (WebCore::HistoryItem::scheduleRelease):
        (WebCore::HistoryItem::cancelRelease): Added.
        * history/HistoryItem.h: Removed unused declaration of scheduleReleaseTimer()
        * history/HistoryItemTimer.cpp:
        (WebCore::HistoryItemTimer::HistoryItemTimer):
        (WebCore::HistoryItemTimer::callReleasePageCachesOrReschedule):
        * history/HistoryItemTimer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Just make the synthetic bold offset always be 1.0. This fixes bug
hyatt [Thu, 4 Jan 2007 20:50:09 +0000 (20:50 +0000)]
    Just make the synthetic bold offset always be 1.0.  This fixes bug
        9534, synthetic bold looks doubled.

        Reviewed by olliej

        * platform/mac/FontDataMac.mm:
        (WebCore::FontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca [Thu, 4 Jan 2007 19:25:30 +0000 (19:25 +0000)]
WebCore:

        Reviewed by Brady.

        Convert almost all occurrences of NSURLResponse to ResourceResponse.

        * WebCore.exp:
        * loader/DocumentLoader.h:
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.h:
        * loader/NetscapePlugInStreamLoader.h:
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.h:
        * loader/loader.h:
        * loader/mac/FrameLoaderMac.mm:
        (WebCore::FrameLoader::willSendRequest):
        (WebCore::FrameLoader::didReceiveResponse):
        (WebCore::FrameLoader::opened):
        (WebCore::FrameLoader::sendRemainingDelegateMessages):
        (WebCore::FrameLoader::loadedResourceFromMemoryCache):
        (WebCore::FrameLoader::loadResourceSynchronously):
        * loader/mac/LoaderFunctionsMac.mm:
        (WebCore::CheckCacheObjectStatus):
        * loader/mac/MainResourceLoaderMac.mm:
        (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
        (WebCore::MainResourceLoader::willSendRequest):
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        (WebCore::MainResourceLoader::didReceiveResponse):
        (WebCore::MainResourceLoader::loadNow):
        * loader/mac/NetscapePlugInStreamLoaderMac.mm:
        (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::willSendRequest):
        (WebCore::ResourceLoader::didReceiveResponse):
        (WebCore::ResourceLoader::response):
        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::willSendRequest):
        (WebCore::SubresourceLoader::didReceiveResponse):
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::download):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse):
        (WebCore::SVGEmptyFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
        (WebCore::SVGEmptyFrameLoaderClient::incrementProgress):
        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleClient.h:
        * platform/network/ResourceResponse.cpp:
        (WebCore::ResourceResponse::isHTTP):
        * platform/network/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        (WebCore::ResourceResponse::isNull):
        * platform/network/mac/ResourceResponseMac.mm:
        (WebCore::ResourceResponse::nsURLResponse):
        (WebCore::ResourceResponse::doUpdateResourceResponse):

WebKit:

        Reviewed by Brady.

        Update for WebCore changes.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::download):
        (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
        (WebFrameLoaderClient::dispatchWillSendRequest):
        (WebFrameLoaderClient::dispatchDidReceiveResponse):
        (WebFrameLoaderClient::incrementProgress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
adele [Thu, 4 Jan 2007 19:21:24 +0000 (19:21 +0000)]
LayoutTests:

        Reviewed by Darin.

        Test for <rdar://problem/4887422>
        http://bugs.webkit.org/show_bug.cgi?id=11848
        REGRESSION (SearchField): Search field on developer.apple.com not drawn with top/bottom borders (11848)

        * fast/forms/searchfield-heights-expected.checksum: Added.
        * fast/forms/searchfield-heights-expected.png: Added.
        * fast/forms/searchfield-heights-expected.txt: Added.
        * fast/forms/searchfield-heights.html: Added.

WebCore:

        Reviewed by Darin.

        - Fix for <rdar://problem/4887422>
        http://bugs.webkit.org/show_bug.cgi?id=11848
        REGRESSION (SearchField): Search field on developer.apple.com not drawn with top/bottom borders (11848)

        Test: fast/forms/searchfield-heights.html

        Override the border and the height for search fields that use -webkit-appearance: searchfield.

        * css/html4.css: Use box-sizing: border-box for search fields.  We don't need to have the border-box quirk
          that we use for the other text fields for this control.
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::searchFieldSizes): Added.
        (WebCore::RenderThemeMac::setSearchFieldSize): Added.
        (WebCore::RenderThemeMac::adjustSearchFieldStyle): Override the border and the height of the search field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Kevin McCullough.
kmccullo [Thu, 4 Jan 2007 18:58:51 +0000 (18:58 +0000)]
    Reviewed by Kevin McCullough.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12070
          REGRESSION: KJS::getUTCOffset() caches UTC offset but ignores time zone changes

        * kjs/DateMath.cpp:
        (KJS::getUTCOffset): Don't cache UTC offset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agocompile DumpRenderTree with RPATH. Hopefully this will
lars [Thu, 4 Jan 2007 14:09:16 +0000 (14:09 +0000)]
compile DumpRenderTree with RPATH. Hopefully this will
fix the automatic regression tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd some missing stubs
lars [Thu, 4 Jan 2007 14:08:04 +0000 (14:08 +0000)]
Add some missing stubs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-01-04 Don Gibson <dgibson77@gmail.com>
ap [Thu, 4 Jan 2007 12:49:07 +0000 (12:49 +0000)]
2007-01-04  Don Gibson  <dgibson77@gmail.com>

        Reviewed by Alexey.

        http://bugs.webkit.org/show_bug.cgi?id=11900:
        Windows build bustage

WebCore:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::FrameWin):
        * platform/graphics/BitmapImage.h:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::setPlatformStrokeColor):
        * platform/graphics/Image.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::drawRect):
        (WebCore::adjustLineToPixelBoundaries):
        (WebCore::GraphicsContext::drawLine):
        (WebCore::GraphicsContext::drawEllipse):
        (WebCore::GraphicsContext::strokeArc):
        (WebCore::GraphicsContext::drawConvexPolygon):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::checkForSolidColor):
        (WebCore::BitmapImage::draw):
        (WebCore::BitmapImage::drawTiled):
        * platform/graphics/win/ImageWin.cpp:
        (WebCore::BitmapImage::initPlatformData):
        (WebCore::BitmapImage::invalidatePlatformData):
        (WebCore::Image::loadPlatformResource):
        * platform/win/FontWin.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::userIdleTime):
        (WebCore::BitmapImage::drawTiled):
        (WebCore::BitmapImage::getHBITMAP):
        (WebCore::ContextMenu::~ContextMenu):
        (WebCore::ContextMenu::appendItem):
        (WebCore::ContextMenuItem::ContextMenuItem):
        (WebCore::ContextMenuItem::releasePlatformDescription):
        (WebCore::ContextMenuItem::type):
        (WebCore::ContextMenuItem::setType):
        (WebCore::ContextMenuItem::setAction):
        (WebCore::ContextMenuItem::setTitle):
        (WebCore::ContextMenuItem::setSubMenu):
        (WebCore::ContextMenuItem::setChecked):
        (WebCore::ContextMenuItem::setEnabled):
        (WebCore::DocumentLoader::originalRequest):
        (WebCore::DocumentLoader::request):
        (WebCore::DocumentLoader::unreachableURL):
        (WebCore::DocumentLoader::getResponseRefreshAndModifiedHeaders):
        (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
        (WebCore::DocumentLoader::setCommitted):
        (WebCore::DocumentLoader::isLoading):
        (WebCore::DocumentLoader::prepareForLoadStart):
        (WebCore::DocumentLoader::isClientRedirect):
        (WebCore::DocumentLoader::title):
        (WebCore::DocumentLoader::urlForHistory):
        (WebCore::Editor::markMisspellingsAfterTypingToPosition):
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::referrer):
        (WebCore::FrameLoader::dataURLBaseFromRequest):
        (WebCore::FrameLoader::opened):
        (WebCore::FrameLoader::applyUserAgent):
        (WebCore::GraphicsContext::strokeRect):
        (WebCore::IconDatabase::iconForPageURL):
        (WebCore::IconDatabase::defaultIcon):
        (WebCore::IconDatabase::retainIconForPageURL):
        (WebCore::IconDatabase::releaseIconForPageURL):
        (WebCore::PageCache::close):
        (WebCore::ResourceHandle::willLoadFromCache):
        (WebCore::SearchPopupMenu::saveRecentSearches):
        (WebCore::SearchPopupMenu::loadRecentSearches):
        (WebCore::SearchPopupMenu::SearchPopupMenu):

WebKit:
        * COM/ChromeClientWin.cpp:
        (ChromeClientWin::addMessageToConsole):
        (ChromeClientWin::runBeforeUnloadConfirmPanel):
        * COM/ChromeClientWin.h:
        * COM/ContextMenuClientWin.cpp:
        (ContextMenuClientWin::contextMenuItemSelected):
        * COM/ContextMenuClientWin.h:
        * COM/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::setDocumentViewFromPageCache):
        (WebFrameLoaderClient::forceLayout):
        (WebFrameLoaderClient::forceLayoutForNonHTML):
        (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad):
        (WebFrameLoaderClient::updateGlobalHistoryForReload):
        (WebFrameLoaderClient::shouldGoToHistoryItem):
        (WebFrameLoaderClient::saveScrollPositionAndViewStateToItem):
        (WebFrameLoaderClient::restoreScrollPositionAndViewState):
        (WebFrameLoaderClient::provisionalLoadStarted):
        (WebFrameLoaderClient::saveDocumentViewToPageCache):
        (WebFrameLoaderClient::canCachePage):
        * COM/WebFrameLoaderClient.h:
        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-01-04 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
ap [Thu, 4 Jan 2007 11:38:45 +0000 (11:38 +0000)]
2007-01-04  Lars Naesbye Christensen  <larsnaesbye@stud.ku.dk>

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11295
        Nightly download size is misleading

        * images/download.png: Changed the size to 6 MB.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap [Thu, 4 Jan 2007 11:23:53 +0000 (11:23 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11611
        REGRESSION: No http referer header sent on XMLHttpRequest

        Test: http/tests/xmlhttprequest/referer.html

        * loader/FrameLoader.h: Removed FrameLoader::addExtraFieldsToRequest(NSMutableURLRequest*, bool, bool),
        which is no longer used.
        * loader/mac/FrameLoaderMac.mm: Ditto.
        * WebCore.exp: Do not export this method (WebKit doesn't use it).

        * loader/mac/SubresourceLoaderMac.mm:
        (WebCore::SubresourceLoader::create): Rewrote to create the request with ResourceRequest::nsURLRequest.

        * platform/PlatformString.h:
        (WebCore::operator!): Added. Previously, attempts to use operator! on a String would result
        with an NSString* conversion, which never returns nil. This was causing a problem in SubresourceLoader::create().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agofix the Qt build
lars [Thu, 4 Jan 2007 07:48:49 +0000 (07:48 +0000)]
fix the Qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-01-03 Mitz Pettel <mitz@webkit.org>
bdash [Thu, 4 Jan 2007 06:36:52 +0000 (06:36 +0000)]
2007-01-03  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Mark Rowe.

        - more updated results for http://bugs.webkit.org/show_bug.cgi?id=5164
          Non-integer percentages are incorrectly rounded down in Safari

        * css1/box_properties/acid_test-expected.checksum:
        * css1/box_properties/acid_test-expected.png:
        * css1/box_properties/acid_test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
ddkilzer [Thu, 4 Jan 2007 05:28:35 +0000 (05:28 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test and updated results for http://bugs.webkit.org/show_bug.cgi?id=5164
          Non-integer percentages are incorrectly rounded down in Safari

        * css2.1/t0804-c5507-padn-r-00-c-ag-expected.checksum:
        * css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
        * css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
        * css2.1/t0804-c5509-padn-l-00-b-ag-expected.checksum:
        * css2.1/t0804-c5509-padn-l-00-b-ag-expected.png:
        * css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
        * css2.1/t09-c5526c-display-00-e-expected.checksum:
        * css2.1/t09-c5526c-display-00-e-expected.png:
        * css2.1/t09-c5526c-display-00-e-expected.txt:
        * fast/block/basic/011-expected.checksum:
        * fast/block/basic/011-expected.png:
        * fast/block/basic/011-expected.txt:
        * fast/css/percentage-non-integer-expected.checksum: Added.
        * fast/css/percentage-non-integer-expected.png: Added.
        * fast/css/percentage-non-integer-expected.txt: Added.
        * fast/css/percentage-non-integer.html: Added.
        * tables/mozilla/bugs/bug4385-expected.checksum:
        * tables/mozilla/bugs/bug4385-expected.png:
        * tables/mozilla/bugs/bug4385-expected.txt:
        * tables/mozilla_expected_failures/core/col_span2-expected.checksum:
        * tables/mozilla_expected_failures/core/col_span2-expected.txt:

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=5164
          Non-integer percentages are incorrectly rounded down in Safari

        Test: fast/css/percentage-non-integer.html

        Added floating point constructor and accessors to Length for use with
        Percent lengths only. The raw value of a percent length is the integer
        part of a constant multiple of the original double value. The constant
        is percentScaleFactor, which is currently 128.

        Added assertions that the correct constructors and accessors are used
        depending on the type: the double-based percent(), setValue() and Length()
        for the Percent type, and the integer-based value(), setValue() and Length()
        for all other types.

        calcValue() and calcMinValue() work the same as before, regardless of the
        type.

        Added helpers for testing if the value is 0, positive, negative or undefined
        without having to check the type first.

        Added raw value accessors. These are useful for doing integer math and
        comparisons with scaled percent values or doing Length type-agnostic math.

        Changed the rest of the code to use the appropriate accessors and helpers.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForLength):
        (WebCore::primitiveValueFromLength):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/cssstyleselector.cpp:
        (WebCore::convertToLength):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::mapBackgroundSize):
        (WebCore::CSSStyleSelector::mapBackgroundXPosition):
        (WebCore::CSSStyleSelector::mapBackgroundYPosition):
        * platform/StringImpl.cpp:
        (WebCore::parseLength):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        (WebCore::AutoTableLayout::fullRecalc):
        (WebCore::AutoTableLayout::calcMinMaxWidth):
        (WebCore::AutoTableLayout::calcEffectiveWidth):
        (WebCore::AutoTableLayout::layout):
        (WebCore::AutoTableLayout::calcPercentages):
        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray):
        (WebCore::FixedTableLayout::layout):
        * rendering/Length.h:
        (WebCore::Length::Length):
        (WebCore::Length::value):
        (WebCore::Length::rawValue):
        (WebCore::Length::percent):
        (WebCore::Length::setValue):
        (WebCore::Length::setRawValue):
        (WebCore::Length::calcValue):
        (WebCore::Length::calcMinValue):
        (WebCore::Length::isUndefined):
        (WebCore::Length::isZero):
        (WebCore::Length::isPositive):
        (WebCore::Length::isNegative):
        * rendering/RenderBR.cpp:
        (WebCore::RenderBR::lineHeight):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isSelfCollapsingBlock):
        * rendering/RenderBox.cpp:
        (WebCore::cacluateBackgroundSize):
        (WebCore::RenderBox::calcWidth):
        (WebCore::RenderBox::calcHeight):
        (WebCore::RenderBox::calcReplacedWidth):
        (WebCore::RenderBox::calcReplacedHeight):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteVertical):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::allowedChildFlex):
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::lineHeight):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::calcReplacedWidth):
        (WebCore::RenderImage::calcReplacedHeight):
        * rendering/RenderLayer.cpp:
        (WebCore::Marquee::direction):
        (WebCore::Marquee::start):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::mustRepaintBackgroundOrBorder):
        (WebCore::RenderObject::lineHeight):
        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::layout): Added FIXMEs.
        * rendering/RenderStyle.h:
        (WebCore::LengthBox::nonZero):
        (WebCore::RenderStyle::initialLineHeight):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::calcWidth):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addCell):
        (WebCore::RenderTableSection::layoutRows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
ddkilzer [Thu, 4 Jan 2007 05:23:33 +0000 (05:23 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=11744
          Setting the 'content' property dynamically has no effect

        * fast/css/content-dynamic-expected.checksum: Added.
        * fast/css/content-dynamic-expected.png: Added.
        * fast/css/content-dynamic-expected.txt: Added.
        * fast/css/content-dynamic.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11744
          Setting the 'content' property dynamically has no effect

        Test: fast/css/content-dynamic.html

        * dom/Node.cpp:
        (WebCore::Node::diff): Changed to return 'Detach' if the styles' content
        data are not equivalent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
ddkilzer [Thu, 4 Jan 2007 05:19:10 +0000 (05:19 +0000)]
LayoutTests:

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12082
          REGRESSION (r18333): Crash in RenderFrameSet::layOutAxis()

        * fast/frames/negative-remaining-length-crash-expected.txt: Added.
        * fast/frames/negative-remaining-length-crash.html: Added.

WebCore:

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12082
          REGRESSION (r18333): Crash in RenderFrameSet::layOutAxis()

        Test: fast/frames/negative-remaining-length-crash.html

        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::layOutAxis): Treat negative availableLength
        as zero.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-01-03 Mark Rowe <bdash@webkit.org>
bdash [Thu, 4 Jan 2007 02:17:18 +0000 (02:17 +0000)]
2007-01-03  Mark Rowe  <bdash@webkit.org>

        Reviewed by Anders.

        * Scripts/run-webkit-tests: Launch Safari using the same WebKit build configuration as the layout tests used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Written by Darin over my shoulder; reviewed by me
sullivan [Thu, 4 Jan 2007 02:01:07 +0000 (02:01 +0000)]
    Written by Darin over my shoulder; reviewed by me

        - fixed <rdar://problem/4907437> Find doesn't work if invoked when a form field is focused

        * page/Frame.cpp:
        (WebCore::isInShadowTree):
        new helper function used by findString
        (WebCore::Frame::findString):
        when deciding whether to start from the selection, ignore selections that are in
        a shadow tree (i.e. in a form control)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe
beidson [Thu, 4 Jan 2007 01:21:28 +0000 (01:21 +0000)]
    Reviewed by Mark Rowe

        Fixes http://bugs.webkit.org/show_bug.cgi?id=12089

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::updateHistoryForCommit): Null check the documentLoader

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * WebView/WebPDFView.mm:
sullivan [Thu, 4 Jan 2007 01:20:11 +0000 (01:20 +0000)]
    * WebView/WebPDFView.mm:
        (-[WebPDFView _openWithFinder:]):
        Tiger build fix: use [NSNumber initWithInt:] rather than the new [NSNumber initWithInteger:]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd layout test for inline generated content.
hyatt [Thu, 4 Jan 2007 01:07:46 +0000 (01:07 +0000)]
Add layout test for inline generated content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Relax the display type restriction a little bit for generated content inside
hyatt [Thu, 4 Jan 2007 01:07:33 +0000 (01:07 +0000)]
    Relax the display type restriction a little bit for generated content inside
        inlines.  We still don't allow block display types like we should (since this
        will cause a crash), but we at least handle inline-table and inline-block now.

        Reviewed by beth

        fast/css-generated-content/inline-display-types.html

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::updatePseudoChildForObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
justing [Thu, 4 Jan 2007 01:05:46 +0000 (01:05 +0000)]
LayoutTests:

        Reviewed by john

        * editing/pasteboard/merge-end-blockquote-expected.txt: A
        recent change caused an acceptable change in these expected results.

WebCore:

        Reviewed by john

        <rdar://problem/4663571> Spell checking won't cross boundary of individual To-Do item

        No layout tests because advanceToNextMisspelling isn't yet exposed to automated tests.

        * editing/mac/EditorMac.mm:
        (WebCore::Editor::advanceToNextMisspelling): Confine spell checking to
        the highest editable root, instead of the lowest.  Use firstEditablePosition...
        to look for an editable position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixing silly mistake.
bdakin [Thu, 4 Jan 2007 00:57:38 +0000 (00:57 +0000)]
    Fixing silly mistake.

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::checkOrEnableIfNeeded): Called wrong string
        function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Kevin Decker
sullivan [Thu, 4 Jan 2007 00:55:41 +0000 (00:55 +0000)]
    Reviewed by Kevin Decker

        - fixed <rdar://problem/4145714> WebKit's PDFView's "Open in Preview" puts the
          PDF in /tmp, both group and world-readable

        * WebView/WebPDFView.mm:
        (-[WebPDFView _openWithFinder:]):
        Make the file only readable by the current user

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders
beidson [Thu, 4 Jan 2007 00:53:36 +0000 (00:53 +0000)]
    Reviewed by Anders

        http://bugs.webkit.org/show_bug.cgi?id=12093 - Assertion in certain SVG layout tests
        I can't really think of a cleaner way to fix this then to help these SVG cases avoid
        the ASSERT - hopefully we can clean up the svg-as-image situation as the loader stabilizes
        and we find better ways to handle it...

        * loader/mac/DocumentLoaderMac.mm:
        (WebCore::DocumentLoader::urlForHistory): empty-check the url before passing it to the
        ASSERTing method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adele.
darin [Thu, 4 Jan 2007 00:40:28 +0000 (00:40 +0000)]
    Reviewed by Adele.

        - removed some obsolete source files

        * CMakeLists.txt: Removed obsolete files.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.

        * html/HTMLGenericFormElement.h: Removed reference to RenderFormElement.

        * platform/qt/ComboBoxQt.cpp: Removed.
        * platform/qt/LineEditQt.cpp: Removed.
        * platform/qt/ListBoxQt.cpp: Removed.
        * platform/qt/TextEditQt.cpp: Removed.
        * rendering/RenderFormElement.cpp: Removed.
        * rendering/RenderFormElement.h: Removed.
        * rendering/RenderLabel.cpp: Removed.
        * rendering/RenderLabel.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
darin [Thu, 4 Jan 2007 00:27:25 +0000 (00:27 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for bug where :after content appeared in the wrong order

        * fast/css-generated-content/after-order-expected.checksum: Added.
        * fast/css-generated-content/after-order-expected.png: Added.
        * fast/css-generated-content/after-order-expected.txt: Added.
        * fast/css-generated-content/after-order.html: Added.
        * fast/css-generated-content/resources/greenbox.png: Added.

WebCore:

        Reviewed by Hyatt.

        - fix bug where :after content appears backwards

        Test: fast/css-generated-content/after-order.html

        * rendering/RenderBlock.cpp:
        (WebCore::isAfterContent): Added.
        (WebCore::RenderBlock::addChildToFlow): Use isAfterContent.
        * rendering/RenderInline.cpp:
        (WebCore::isAfterContent): Added.
        (WebCore::RenderInline::addChildToFlow): Use isAfterContent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Implement box-shadow parsing... getting it all into the RenderStyle.
hyatt [Thu, 4 Jan 2007 00:04:06 +0000 (00:04 +0000)]
    Implement box-shadow parsing... getting it all into the RenderStyle.

        Reviewed by beth

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSPropertyNames.in:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData):
        (WebCore::StyleCSS3NonInheritedData::operator==):
        (WebCore::StyleCSS3NonInheritedData::shadowDataEquivalent):
        (WebCore::RenderStyle::diff):
        (WebCore::RenderStyle::setBoxShadow):
        * rendering/RenderStyle.h:
        (WebCore::RenderStyle::boxShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@18557 268f45cc-cd09-0410-ab3c-d52691b4dbfc