WebKit-https.git
6 years agoPotential use-after-free with an event fired at a HTMLMediaElement which is currently...
eric.carlson@apple.com [Fri, 14 Jun 2013 17:18:59 +0000 (17:18 +0000)]
Potential use-after-free with an event fired at a HTMLMediaElement which is currently being deleted
https://bugs.webkit.org/show_bug.cgi?id=117466

Reviewed by Oliver Hunt.

Merge https://chromium.googlesource.com/chromium/blink/+/f4200a0093b3d9376f703961615359ec7fb712b4

If an event is created using as target an HTMLMediaElement which is
currently being deleted it becomes a heap-use-after free situation.

The GenericEventQueue instance is already owned by the HTMLMediaElement,
and there already is an underlying mechanism to set the target of the
event to NULL, if their target is owner of the queue.

In order to avoid creating this reference in the first place, we enqueue
the event with a NULL target to defer the refcount increment until the
timer for dispatching the event happens (which won't happen at all if
garbage collection is already destroying the objects).

Source/WebCore:

Test: media/track/media-element-enqueue-event-crash.html

* dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::enqueueEvent): Don't ASSERT if the event has no target.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement): Close the event queue so it won't try to
    dispatch any pending events.
(WebCore::HTMLMediaElement::scheduleEvent): Don't set the event target, it will happen just
    prior to event dispatch.
(WebCore::HTMLMediaElement::stop): Close the event queue.

LayoutTests:

* media/track/media-element-enqueue-event-crash-expected.txt: Added.
* media/track/media-element-enqueue-event-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClicking on snapshotting plug-ins does not restart them
dino@apple.com [Fri, 14 Jun 2013 17:09:49 +0000 (17:09 +0000)]
Clicking on snapshotting plug-ins does not restart them
https://bugs.webkit.org/show_bug.cgi?id=117620
<rdar://problem/13821729>

Follow-up review comments from Darin Adler, with some
discussion on IRC.

Sprinkle OVERRIDE on virtual functions where needed. Also
make sure that the Event is a MouseEvent before casting to it.

* html/HTMLPlugInElement.h: Move defaultEventHandler back to protected and add OVERRIDE.
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::defaultEventHandler): Check for MouseEvent and
use toMouseEvent().
* html/HTMLPlugInImageElement.h: Sprinkle some OVERRIDEs, and move defaultEventHandler
to private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove front-end from the WebCore Xcode project.
timothy@apple.com [Fri, 14 Jun 2013 16:52:40 +0000 (16:52 +0000)]
Remove front-end from the WebCore Xcode project.
https://bugs.webkit.org/show_bug.cgi?id=117640

Reviewed by Darin Adler.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCSSParser::parseImageSet() doesn't need a parameter.
commit-queue@webkit.org [Fri, 14 Jun 2013 16:36:45 +0000 (16:36 +0000)]
CSSParser::parseImageSet() doesn't need a parameter.
https://bugs.webkit.org/show_bug.cgi?id=117617

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-06-14
Reviewed by Darin Adler.

parseImageSet() can get m_valueList directly.
And minor fixes.

No new tests, no behavior change.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseImageSet):
* css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Dropdown button UX updates.
commit-queue@webkit.org [Fri, 14 Jun 2013 16:25:51 +0000 (16:25 +0000)]
[BlackBerry] Dropdown button UX updates.
https://bugs.webkit.org/show_bug.cgi?id=117642.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-06-14
Reviewed by Rob Buis.

JIRA 388652
Internally Reviewed by Jeff Rogers.

Change arrow assert.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintMenuList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] LayerTiler fails to tile really big layers
anilsson@rim.com [Fri, 14 Jun 2013 15:00:38 +0000 (15:00 +0000)]
[BlackBerry] LayerTiler fails to tile really big layers
https://bugs.webkit.org/show_bug.cgi?id=117211

Reviewed by Carlos Garcia Campos.

PR 273550

Source/WebCore:

The cause for this bug was that LayerTiler computed which tiles are
visible by exhaustively mapping every tile to normalized device
coordinates and checking if it intersected the viewport. If there was a
lot of tiles, it would get stuck in this loop, iterating over all
tiles, for a very long time. Also, the visibility information was
transferred to the WebKit thread using mutexes, which added unnecessary
mutex contention to the mix.

Fixed by doing the reverse calculation, unprojecting the visible part
of the layer to layer coordinate space to find which tiles are visible.
Instead of doing a traditional unprojection of point to line and see
where the line intersects the layer, this patch uses the w-coordinates
of triangle vertices to perform "perspective correct texturing" of the
intersection points in device space, which is equivalent to
unprojection since perspective correct texturing computes a 2D
coordinate in (normalized) layer coordinate space which is easily
scaled up to the layer bounds and get the visible region expressed in
layer coordinate space.

The visible area is approximated by a rectangle, and a set of tiles
needing render are added to the mix, and  we have a swappable data
structure so visbility can be transferred to WebKit thread without
mutexes, but instead using atomic swap.

No new tests, covered by existing tests.

* platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
(CanvasLayerCompositingThreadClient):
(WebCore::CanvasLayerCompositingThreadClient::drawTextures):
* platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
* platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h:
(EGLImageLayerCompositingThreadClient):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
* platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
* platform/graphics/blackberry/LayerCompositingThreadClient.h:
(WebCore):
(LayerCompositingThreadClient):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayersRecursive):
* platform/graphics/blackberry/LayerTile.cpp:
(WebCore::LayerTile::LayerTile):
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):
(WebCore::LayerTile::discardContents):
* platform/graphics/blackberry/LayerTile.h:
(LayerTile):
(WebCore::LayerTile::contentsScale):
(WebCore::LayerTile::setContentsDirty):
* platform/graphics/blackberry/LayerTiler.cpp:
(LayerVisibility):
(WebCore::LayerVisibility::LayerVisibility):
(WebCore::LayerVisibility::visibleRect):
(WebCore::LayerVisibility::setVisibleRect):
(WebCore::LayerVisibility::needsRender):
(WebCore::LayerVisibility::tileNeedsRender):
(WebCore::LayerVisibility::willRenderTile):
(WebCore::LayerVisibility::swapTilesNeedingRender):
(WebCore::LayerVisibility::merge):
(WebCore):
(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::~LayerTiler):
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::swapFrontVisibility):
(WebCore::LayerTiler::setFrontVisibility):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTile):
(WebCore::inflateViewport):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::rectForTile):
* platform/graphics/blackberry/LayerTiler.h:
(WebCore):
(LayerTiler):
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::takeFrontVisibility):
* platform/graphics/blackberry/LayerUtilities.h:
(WebCore):
(WebCore::det):
(WebCore::dot):
(LayerClipEdge):
(WebCore::LayerClipEdge::LayerClipEdge):
(WebCore::LayerClipEdge::isPointInside):
(WebCore::LayerClipEdge::computeIntersection):
(WebCore::intersectPolygonWithRect):
(WebCore::computeBarycentricCoordinates):
(WebCore::manhattanDistanceToViewport):
(UnprojectionVertex):
(WebCore::compareManhattanDistanceToViewport):
(WebCore::unproject):

Source/WebKit/blackberry:

Adapt to changes in LayerCompositingThreadClient interface.

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
* Api/WebOverlay_p.h:
(WebOverlayLayerCompositingThreadClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Compilation problems - hb.h not found
commit-queue@webkit.org [Fri, 14 Jun 2013 14:53:47 +0000 (14:53 +0000)]
[GTK] Compilation problems - hb.h not found
https://bugs.webkit.org/show_bug.cgi?id=117636

Unreviewed GTK+ build fix.

Patch by Andres Gomez <agomez@igalia.com> on 2013-06-14

* GNUmakefile.am: Added freetype cflags for WebKit2 GTK+ Platform
library.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Generate new baseline to some tests and bot greening.
zarvai@inf.u-szeged.hu [Fri, 14 Jun 2013 14:50:06 +0000 (14:50 +0000)]
[Qt] Unreviewed gardening. Generate new baseline to some tests and bot greening.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-14

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/animations/3d/change-transform-in-end-event-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/border-left-right-same-bottom-different-color-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/border-radius-percent-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/border-radius-wide-border-05-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/border-radius-with-box-shadow-01-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/border-radius-with-box-shadow-expected.png: Added.
* platform/qt-5.0-wk2/fast/css-generated-content/details-summary-before-after-expected.png: Added.
* platform/qt-5.0-wk2/fast/css-generated-content/details-summary-before-after-expected.txt: Added.
* platform/qt-5.0-wk2/fast/forms/zoomed-controls-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/unprefixed-generated-gradients-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/unprefixed-linear-angle-gradients-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/unprefixed-list-item-gradient-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/unprefixed-radial-gradients-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/unprefixed-radial-gradients3-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/unprefixed-repeating-end-fill-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/unprefixed-repeating-linear-gradient-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/unprefixed-repeating-radial-gradients-expected.png: Added.
* platform/qt-5.0-wk2/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Added.
* platform/qt-5.0-wk2/svg/custom/marker-orient-auto-expected.png: Added.
* platform/qt-5.0-wk2/svg/custom/marker-orient-auto-expected.txt: Added.
* platform/qt-5.0-wk2/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
* platform/qt-5.0-wk2/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
* platform/qt-5.0-wk2/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
* platform/qt-5.0-wk2/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] clicking caption track glyph should dismiss menu
graouts@apple.com [Fri, 14 Jun 2013 14:43:01 +0000 (14:43 +0000)]
[Mac] clicking caption track glyph should dismiss menu
https://bugs.webkit.org/show_bug.cgi?id=117621

We now correctly capture all click events while the captions track menu
is showing, and ensure that no other control in the media player can be
activated as the track list gets dismissed by clicking anywhere but on
itself.

Reviewed by Eric Carlson.

* html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::showClosedCaptionTrackList):
Make the controls panel non-interactive and track click events in the
capture phase also on the controls container itself such that we can
identify correctly whether a click in the <video> shadow tree is on
the track list or another element (the target could only be resolved
to a shadow tree node if the event is handled within the shadow tree).

(WebCore::MediaControlsApple::hideClosedCaptionTrackList):
Make the controls panel interactive again and remove the new click
event handler on the controls container.

(WebCore::MediaControlsApple::handleClickEvent):
Capture any click event that targets a node anywhere outside of the track
list container and its subtree and hide the track list in this condition.

(WebCore::MediaControlsAppleEventListener::handleEvent):
Call handleClickEvent() on the media controls when a click event is handled.

* html/shadow/MediaControlsApple.h:
New public handleClickEvent() API such that it can be called from
MediaControlsAppleEventListener::handleEvent().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Accelerated compositing layers that intersect the image plane are incorr...
anilsson@rim.com [Fri, 14 Jun 2013 14:04:20 +0000 (14:04 +0000)]
[BlackBerry] Accelerated compositing layers that intersect the image plane are incorrectly transformed
https://bugs.webkit.org/show_bug.cgi?id=117067

Reviewed by Carlos Garcia Campos.

PR 273550

The BlackBerry port used to mathematically project each corner of each
layer bounds rectangle, which gives the wrong results when the layer
intersects the image plane.

For display lists, we still got the correct appearance of the layer
contents, since the display list results in geometry that's transformed
in the vertex shader, on the GPU.

However, the transformed bounds are used for drawing the debug border,
performing visibility calculations on the CPU and drawing of WebGL,
masks/reflections and filters. Using the mathematical projection of
points that lie behind the image plane gives the wrong results.

The most important consequence of this bug was that the wrong area of
the layer would be considered visible, so a tiled layer would not
populate the right tiles (or any tiles at all).

Fixed by implementing something along the lines of the recipe in
section 6.2 of http://www.w3.org/TR/css3-transforms.

No new tests, manually testable by enabling debug border on
https://developer.mozilla.org/en-US/demos/detail/the-box/launch.

* platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::LayerCompositingThread):
(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore):
(WebCore::LayerCompositingThread::textureCoordinates):
(WebCore::LayerCompositingThread::drawTextures):
* platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
(WebCore::LayerCompositingThread::transformedBounds):
(WebCore::LayerCompositingThread::ws):
(WebCore::LayerCompositingThread::centerW):
* platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRenderer::applyActions):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::compareLayerW):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::LayerRenderer::compositeLayersRecursive):
* platform/graphics/blackberry/LayerRenderer.h:
(WebCore):
(LayerRenderer):
* platform/graphics/blackberry/LayerRendererSurface.cpp:
(WebCore::LayerRendererSurface::boundingBox):
(WebCore::LayerRendererSurface::transformedBounds):
* platform/graphics/blackberry/LayerRendererSurface.h:
(WebCore::LayerRendererSurface::setDrawTransform):
(WebCore::LayerRendererSurface::setReplicaDrawTransform):
(LayerRendererSurface):
* platform/graphics/blackberry/LayerUtilities.h: Added.
(WebCore):
(LayerClipPlane):
(WebCore::LayerClipPlane::LayerClipPlane):
(WebCore::LayerClipPlane::isPointInside):
(WebCore::LayerClipPlane::computeIntersection):
(WebCore::intersect):
(WebCore::boundingBox):
(WebCore::multVecMatrix):
(WebCore::toVector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Some more rebaselining after r151205 and r150798.
zarvai@inf.u-szeged.hu [Fri, 14 Jun 2013 12:53:37 +0000 (12:53 +0000)]
[Qt] Unreviewed gardening. Some more rebaselining after r151205 and r150798.

* platform/qt-5.0-wk2/css2.1/20110323/absolute-replaced-height-004-expected.png: Added.
* platform/qt-5.0-wk2/css2.1/20110323/absolute-replaced-height-022-expected.png: Added.
* platform/qt-5.0-wk2/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
* platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-09-d-expected.png: Added.
* platform/qt-5.0-wk2/css3/selectors3/html/css3-modsel-70-expected.png: Added.
* platform/qt-5.0-wk2/css3/selectors3/xhtml/css3-modsel-131b-expected.png: Added.
* platform/qt-5.0-wk2/css3/unicode-bidi-isolate-basic-expected.png:
* platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png:
* platform/qt-5.0-wk2/editing/deleting/smart-delete-004-expected.png:
* platform/qt-5.0-wk2/editing/selection/caret-rtl-2-expected.png:
* platform/qt-5.0-wk2/editing/selection/caret-rtl-2-left-expected.png:
* platform/qt-5.0-wk2/editing/selection/caret-rtl-expected.png:
* platform/qt-5.0-wk2/editing/selection/caret-rtl-right-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/extend-selection-bidi-expected.png:
* platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
* platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
* platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
* platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
* platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-rl/001-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/rtl-border-05-expected.png:
* platform/qt-5.0-wk2/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/qt-5.0-wk2/fast/css/error-in-last-decl-expected.png: Added.
* platform/qt-5.0-wk2/fast/css/font-size-negative-expected.png: Added.
* platform/qt-5.0-wk2/fast/css/namespaces/004-expected.png: Added.
* platform/qt-5.0-wk2/fast/css/table-text-align-strict-expected.png: Added.
* platform/qt-5.0-wk2/fast/dom/34176-expected.png:
* platform/qt-5.0-wk2/fast/dom/inner-text-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.png:
* platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.png:
* platform/qt-5.0-wk2/fast/forms/button-cannot-be-nested-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png:
* platform/qt-5.0-wk2/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/listbox-bidi-align-expected.png:
* platform/qt-5.0-wk2/fast/forms/search-rtl-expected.png:
* platform/qt-5.0-wk2/fast/forms/select-baseline-expected.png:
* platform/qt-5.0-wk2/fast/inline/inline-box-background-expected.png:
* platform/qt-5.0-wk2/fast/inline/inline-box-background-long-image-expected.png:
* platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-x-expected.png:
* platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-y-expected.png:
* platform/qt-5.0-wk2/fast/invalid/014-expected.png: Added.
* platform/qt-5.0-wk2/fast/overflow/childFocusRingClip-expected.png: Added.
* platform/qt-5.0-wk2/fast/overflow/hit-test-overflow-controls-expected.png: Added.
* platform/qt-5.0-wk2/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Added.
* platform/qt-5.0-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
* platform/qt-5.0-wk2/fast/runin/generated-expected.png: Added.
* platform/qt-5.0-wk2/fast/table/multiple-captions-display-expected.png: Added.
* platform/qt-5.0-wk2/fast/table/remove-td-display-none-expected.png: Added.
* platform/qt-5.0-wk2/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
* platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
* platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-16-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-85-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/script-handle-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-defs-01-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-02-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-text-03-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/custom/text-ctm-expected.png: Added.
* platform/qt-5.0-wk2/svg/custom/use-instanceRoot-event-listeners-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/bugs/bug81934-expected.png: Added.
* platform/qt-5.0-wk2/tables/mozilla/marvin/tables_bgcolor_red-expected.png: Added.
* platform/qt-5.0-wk2/tables/mozilla/marvin/tfoot_align_left-expected.png: Added.
* platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_align_right-expected.png: Added.
* platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_class-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed TestExpectation cleanup
commit-queue@webkit.org [Fri, 14 Jun 2013 11:43:19 +0000 (11:43 +0000)]
[Qt] Unreviewed TestExpectation cleanup
https://bugs.webkit.org/show_bug.cgi?id=117626

Unreviewed gardening.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-06-14

* platform/qt-5.0-wk1/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Map rewind and fast forward keys to match GoogleTV
allan.jensen@digia.com [Fri, 14 Jun 2013 11:34:27 +0000 (11:34 +0000)]
[Qt] Map rewind and fast forward keys to match GoogleTV
https://bugs.webkit.org/show_bug.cgi?id=117634

Reviewed by Jocelyn Turcotte.

Set the same keycode for media keys rewind and fast-forward as
GoogleTV does.

* platform/qt/PlatformKeyboardEventQt.cpp:
(WebCore::windowsKeyCodeForKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK build fix.
zandobersek@gmail.com [Fri, 14 Jun 2013 11:26:39 +0000 (11:26 +0000)]
Unreviewed GTK build fix.

* GNUmakefile.am: Add the Freetype CFLAGS to the list of libPlatformGtk's CPPFLAGS. These are required as there are
specific build targets that end up including the HarfBuzz headers which are included in the Freetype CFLAGS variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid unnecessary data copies when loading subresources with DoNotBufferData option
carlosgc@webkit.org [Fri, 14 Jun 2013 10:59:11 +0000 (10:59 +0000)]
Avoid unnecessary data copies when loading subresources with DoNotBufferData option
https://bugs.webkit.org/show_bug.cgi?id=115804

Reviewed by Darin Adler.

When DoNotBufferData option is used to load a resource its data
is always copied before sending it to the CachedResource. Most
of the cached resources ignore the incremental data and wait
until all data has been received to save the ResourceBuffer,
that will be NULL anyway when DoNotBufferData is used.
CachedRawResource notifies its clients about the incremental
data, but it doesn't save the data when DoNotBufferData option
is present. In those cases we are unnecessary copying the data.

CachedResource::data has been split into
CachedResource::addDataBuffer() used for incremental data chunks
when buffering data, CachedResource::addData() used for
incremental data chunks when not buffering and
CachedResource::finishLoading() used to finish the loading. This
way we get rid of the allDataReceived boolean parameter and cached
resources not interested in incremenetal data chunks only have to
implement finishLoading() without having to check if all data have
been received or not.

SubresourceLoader::sendDataToResource was always called after
checking if loading multipart content, and then it was checked
again to decided whether to copy the data or not. It has been
removed in favor of calling directly the resource methods,
finishLoading for multipart content, addDataBuffer for data chunks
when buffering and addData for data chunks when not buffering.

No new functionality, covered by existing tests.

* html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::appendBytes): Update to API changes.
(WebCore::ImageDocumentParser::finish): Ditto.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse): Call
finishLoading() for multipart content.
(WebCore::SubresourceLoader::didReceiveDataOrBuffer): Add data to
the resource using addDataBuffer or addData depending on whether
we are buffering or not.
(WebCore::SubresourceLoader::didFinishLoading): Call
finishLoading() for the cached resource instead of data.
* loader/SubresourceLoader.h:
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::finishLoading):
* loader/cache/CachedCSSStyleSheet.h:
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::finishLoading):
* loader/cache/CachedFont.h:
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::isValidDecodedImageSize): Helper function
to check if the image size is valid.
(WebCore::CachedImage::addIncrementalDataBuffer): Helper function
to add incremental data buffer.
(WebCore::CachedImage::addDataBuffer): Call
addIncrementalDataBuffer().
(WebCore::CachedImage::addData): Create a ResourceBuffer and call
addIncrementalDataBuffer().
(WebCore::CachedImage::finishLoading):
* loader/cache/CachedImage.h:
* loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::calculateIncrementalDataChunk):
Returns a pointer to the data corresponding to the current chunk
and its length.
(WebCore::CachedRawResource::addDataBuffer): Assert to make sure
this is only called when BufferData option is present. Use
calculateIncrementalDataChunk().
(WebCore::CachedRawResource::addData): Assert to make sure this is
only called when DoNotBufferData option is present.
(WebCore::CachedRawResource::finishLoading):
(WebCore::CachedRawResource::notifyClientsDataWasReceived): Helper
private function to notify the clients about data received.
* loader/cache/CachedRawResource.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::addDataBuffer):
(WebCore::CachedResource::addData):
(WebCore::CachedResource::finishLoading):
* loader/cache/CachedResource.h:
* loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::finishLoading):
* loader/cache/CachedSVGDocument.h:
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::finishLoading):
* loader/cache/CachedScript.h:
* loader/cache/CachedShader.cpp:
(WebCore::CachedShader::finishLoading):
* loader/cache/CachedShader.h:
* loader/cache/CachedTextTrack.cpp:
(WebCore::CachedTextTrack::addDataBuffer):
(WebCore::CachedTextTrack::finishLoading):
* loader/cache/CachedTextTrack.h:
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::finishLoading):
* loader/cache/CachedXSLStyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove myself from Qt build system watchlist
vestbo@webkit.org [Fri, 14 Jun 2013 10:03:32 +0000 (10:03 +0000)]
Remove myself from Qt build system watchlist

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Rebaselining after r151205.
zarvai@inf.u-szeged.hu [Fri, 14 Jun 2013 08:26:27 +0000 (08:26 +0000)]
[Qt] Unreviewed gardening. Rebaselining after r151205.

* platform/qt-5.0-wk2/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png: Added.
* platform/qt-5.0-wk2/css3/selectors3/html/css3-modsel-39-expected.png: Added.
* platform/qt-5.0-wk2/editing/execCommand/create-list-with-hr-expected.png: Added.
* platform/qt-5.0-wk2/editing/inserting/4960120-2-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/5057506-expected.png: Added.
* platform/qt-5.0-wk2/fast/invalid/003-expected.png: Added.
* platform/qt-5.0-wk2/fast/selectors/061-expected.png: Added.
* platform/qt-5.0-wk2/fast/table/table-display-types-strict-expected.png: Added.
* platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
* platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-05-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-12-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-14-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/interact-order-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/masking-path-03-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-fill-03-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-fill-05-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-cond-01-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/styling-css-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/styling-pres-01-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-04-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-05-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-deco-01-b-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-fonts-02-t-expected.png: Added.
* platform/qt-5.0-wk2/svg/custom/use-font-face-crash-expected.png:
* platform/qt-5.0-wk2/tables/mozilla/bugs/bug727-expected.png: Added.
* platform/qt-5.0-wk2/tables/mozilla/marvin/tables_border_1-expected.png: Added.
* platform/qt-5.0-wk2/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][WK1] Missing symbols
commit-queue@webkit.org [Fri, 14 Jun 2013 08:20:21 +0000 (08:20 +0000)]
[GTK][WK1] Missing symbols
https://bugs.webkit.org/show_bug.cgi?id=117629

Unreviewed GTK+ build fix.

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-06-14

* Source/autotools/symbols.filter: Added missing symbols needed when
compiling WK1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Fix build when DRAG_SUPPORT is set OFF
commit-queue@webkit.org [Fri, 14 Jun 2013 07:55:59 +0000 (07:55 +0000)]
[EFL] Fix build when DRAG_SUPPORT is set OFF
https://bugs.webkit.org/show_bug.cgi?id=117628

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-06-14
Reviewed by Gyuyoung Kim.

Add guard around Clipboard::declareAndWriteDragImage.

* platform/efl/ClipboardEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSometimes we stick in slow scrolling mode even after leaving a page
simon.fraser@apple.com [Fri, 14 Jun 2013 04:58:11 +0000 (04:58 +0000)]
Sometimes we stick in slow scrolling mode even after leaving a page
https://bugs.webkit.org/show_bug.cgi?id=117622

Reviewed by Sam Weinig.

ScrollingCoordinator, and thus the scrolling state tree, is owned by Page,
and so persists when navigating between cached pages. We do give the ScrollingStateTree
a new ScrollingStateScrollingNode on navigation, however the ScrollingStateScrollingNode
would not have dirty flags set for, say, WheelEventHandlerCount if the document had
no wheel handlers. And because that dirty flag wasn't set, ScrollingTree::commitNewTreeState()
would fail to update m_hasWheelEventHandlers, so we'd remain in slow scrolling.

Fix by having ScrollingStateTree remember if it's been given a new root ScrollingStateScrollingNode,
and making ScrollingTree::commitNewTreeState() to the right thing in that case.

Also fix a couple of issues with the tiled scrolling indicator. First, on cached page
navigation, the indicator color would show the state for the old page, because
ScrollingCoordinatorMac::commitTreeState() checked scrollingTree()->hasWheelEventHandlers()
before the scrolling thread has committed the new scrolling tree.

Second, the color change would animate, so stop that.

Not testable, since tests can only dump the scrolling state tree.

* page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::ScrollingStateTree):
(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::commit):
* page/scrolling/ScrollingStateTree.h:
(WebCore::ScrollingStateTree::hasNewRootStateNode):
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeState):
* platform/graphics/ca/mac/TileController.mm:
(-[WebTiledScrollingIndicatorLayer init]): Turn off borderColor implicit animations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[curl] Merge http response header values
commit-queue@webkit.org [Fri, 14 Jun 2013 04:47:13 +0000 (04:47 +0000)]
[curl] Merge http response header values
https://bugs.webkit.org/show_bug.cgi?id=117342

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-13
Reviewed by Brent Fulgham.

According to the HTTP RFC some HTTP header values should be
merged if multiple entries for the same header exists.

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::isAppendableHeader):
(WebCore::headerCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoShould not call firePaintRelatedMilestones() for "update control tints" paint pass
simon.fraser@apple.com [Fri, 14 Jun 2013 04:32:35 +0000 (04:32 +0000)]
Should not call firePaintRelatedMilestones() for "update control tints" paint pass
https://bugs.webkit.org/show_bug.cgi?id=117624

Reviewed by Sam Weinig.

When window activation changes, we do a fake paint pass that is just used to
invalidate controls that change their appearance in background windows. This fake
paint should not be recorded in the inspector, and it should not cause paint-related
milestones to fire.

* page/FrameView.cpp:
(WebCore::FrameView::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove LiteralIdentifierTable
rniwa@webkit.org [Fri, 14 Jun 2013 03:43:03 +0000 (03:43 +0000)]
Remove LiteralIdentifierTable
https://bugs.webkit.org/show_bug.cgi?id=117613

Reviewed by Geoffrey Garen.

Removed LiteralIdentifierTable since it doesn't seem to have any perf. impact now.

Source/JavaScriptCore:

* runtime/Identifier.cpp:
(JSC::Identifier::add):

Source/WTF:

* wtf/WTFThreadData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Added new baselines for some tests as r151533 on EFL port.
gyuyoung.kim@samsung.com [Fri, 14 Jun 2013 02:55:24 +0000 (02:55 +0000)]
Unreviewed. Added new baselines for some tests as r151533 on EFL port.

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/editing/selection/select-across-readonly-input-1-expected.png: Added.
* platform/efl/editing/selection/select-across-readonly-input-1-expected.txt: Added.
* platform/efl/editing/selection/select-across-readonly-input-2-expected.png: Added.
* platform/efl/editing/selection/select-across-readonly-input-2-expected.txt: Added.
* platform/efl/editing/selection/select-across-readonly-input-3-expected.png: Added.
* platform/efl/editing/selection/select-across-readonly-input-3-expected.txt: Added.
* platform/efl/editing/selection/select-across-readonly-input-4-expected.png: Added.
* platform/efl/editing/selection/select-across-readonly-input-4-expected.txt: Added.
* platform/efl/editing/selection/select-across-readonly-input-5-expected.png: Added.
* platform/efl/editing/selection/select-across-readonly-input-5-expected.txt: Added.
* platform/efl/editing/selection/select-all-002-expected.png: Added.
* platform/efl/editing/selection/select-all-002-expected.txt: Added.
* platform/efl/editing/selection/select-all-003-expected.png: Added.
* platform/efl/editing/selection/select-all-003-expected.txt: Added.
* platform/efl/editing/selection/select-all-004-expected.png: Added.
* platform/efl/editing/selection/select-all-004-expected.txt: Added.
* platform/efl/editing/selection/select-all-005-expected.png: Added.
* platform/efl/editing/selection/select-all-005-expected.txt: Added.
* platform/efl/editing/selection/select-all-006-expected.png: Added.
* platform/efl/editing/selection/select-all-006-expected.txt: Added.
* platform/efl/editing/selection/select-box-expected.png: Added.
* platform/efl/editing/selection/select-box-expected.txt: Added.
* platform/efl/editing/selection/select-element-paragraph-boundary-expected.png: Added.
* platform/efl/editing/selection/select-element-paragraph-boundary-expected.txt: Added.
* platform/efl/editing/selection/select-from-textfield-outwards-expected.png: Added.
* platform/efl/editing/selection/select-from-textfield-outwards-expected.txt: Added.
* platform/efl/editing/selection/selection-actions-expected.png: Added.
* platform/efl/editing/selection/selection-actions-expected.txt: Added.
* platform/efl/editing/selection/selection-button-text-expected.png: Added.
* platform/efl/editing/selection/selection-button-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClicking on snapshotting plug-ins does not restart them
dino@apple.com [Fri, 14 Jun 2013 01:20:44 +0000 (01:20 +0000)]
Clicking on snapshotting plug-ins does not restart them
https://bugs.webkit.org/show_bug.cgi?id=117620
<rdar://problem/13821729>

Reviewed by Simon Fraser.

HTMLPlugInElement has an event handler which would return
immediately if the element was not snapshotted, restarting
or playing. There is a case it missed, which was snapshotting
(WaitingForSnapshot to be precise). If we get a click in this
state then it should immediately restart.

* html/HTMLPlugInElement.h: Move defaultEventHandler to public (we call it from the child class).
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::defaultEventHandler): If there is a click on a snapshotting
plug-in, then call restart.
* html/HTMLPlugInImageElement.h: Virtual defaultEventHandler declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse borderAndPadding[Before,After]() instead of border[Before,After]() + padding...
zoltan@webkit.org [Fri, 14 Jun 2013 00:39:36 +0000 (00:39 +0000)]
Use borderAndPadding[Before,After]() instead of border[Before,After]() + padding[Before,After]()
https://bugs.webkit.org/show_bug.cgi?id=117611

Reviewed by Dirk Schulze.

I added a new function called borderAndPaddingAfter(), since we already had borderAndPaddingBefore(). I changed
every separate additions to the old/new function. This change makes the code shorter and more straightforward.

Behavior hasn't changed, no new tests were needed.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::marginBeforeEstimateForChild):
(WebCore::RenderBlock::layoutBlockChildren):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::relayoutForPagination):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustStartEdgeForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread):
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderAndPaddingStart):
(WebCore::RenderBoxModelObject::borderAndPaddingBefore):
(WebCore::RenderBoxModelObject::borderAndPaddingAfter):
(WebCore::RenderBoxModelObject::borderAndPaddingLogicalHeight):
* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset):
(WebCore::RenderMultiColumnSet::prepareForLayout):
(WebCore::RenderMultiColumnSet::columnRectAt):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeIntrinsicPadding):
(WebCore::RenderTableCell::cellBaselinePosition):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::firstLineBoxBaseline):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineSnapAdjustment):
(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::ascentAndDescentForBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<http://webkit.org/b/117615> Web Inspector: JS PrettyPrinting Should have space betwe...
commit-queue@webkit.org [Thu, 13 Jun 2013 23:54:25 +0000 (23:54 +0000)]
<webkit.org/b/117615> Web Inspector: JS PrettyPrinting Should have space between "do" and "{"

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-06-13
Reviewed by Timothy Hatcher.

* UserInterface/CodeMirrorFormatters.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<http://webkit.org/b/117612> Web Inspector: "Search Resource Content" should cancel...
commit-queue@webkit.org [Thu, 13 Jun 2013 23:33:08 +0000 (23:33 +0000)]
<webkit.org/b/117612> Web Inspector: "Search Resource Content" should cancel when I remove all text search text

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-06-13
Reviewed by Timothy Hatcher.

* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype._searchFieldInput):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove Node::shouldUseInputMethod() to Element.
akling@apple.com [Thu, 13 Jun 2013 22:47:26 +0000 (22:47 +0000)]
Move Node::shouldUseInputMethod() to Element.
<http://webkit.org/b/117603>

Reviewed by Antti Koivisto.

This method is only ever called on Elements, so move it off of Node.

* dom/Element.cpp:
(WebCore::Element::shouldUseInputMethod):
* dom/Element.h:
* dom/Node.cpp:
* dom/Node.h:
* html/HTMLInputElement.h:
* html/HTMLTextAreaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Selection dragged from a region paints its background
mvujovic@adobe.com [Thu, 13 Jun 2013 22:32:50 +0000 (22:32 +0000)]
[CSS Regions] Selection dragged from a region paints its background
https://bugs.webkit.org/show_bug.cgi?id=117607

Reviewed by Alexandru Chiculita.

.:

Add a manual test for the painting of a dragged selection from a region. We don't have an
automated way to test this yet. This test is similar to the other manual selection dragging
tests (e.g. ManualTests/drag-image.html).

* ManualTests/regions/drag-selection-painting.html: Added.

Source/WebCore:

When a RenderFlowThread is in the selection paint phase, tell its layer to paint with the
selection only behavior. This way, only foregrounds and not backgrounds will be painted in
the dragged selection.

Manual test: ManualTests/regions/drag-selection-painting.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes][CSS Regions] Respect bottom positioned shapes and content adjustment...
zoltan@webkit.org [Thu, 13 Jun 2013 21:09:43 +0000 (21:09 +0000)]
[CSS Shapes][CSS Regions] Respect bottom positioned shapes and content adjustment inside shapes
https://bugs.webkit.org/show_bug.cgi?id=117599

Reviewed by David Hyatt.

In r150478 I added support for multiple positioned shape-insides on regions, this patch covers the cases when a shape
is positioned to the bottom of the region or the region contains a shape which forces the content to be adjusted inside
the shape (e.g. we have a triangle shape and the first line needs to be started at the first position where it fits).
I introduced a new helper function to update the current shape and the current line segments in the flow thread cases. With
this new helper function all the logic which calculates the segments for shape-inside on regions is located in one function.

Source/WebCore:

Tests: fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html
       fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment.html
       fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html
       fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment.html

* rendering/RenderBlock.h: Add new helper's declaration
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineLayoutState::LineLayoutState): Add a member to carry adjustment for flow thread cases.
(WebCore::LineLayoutState::adjustedLogicalLineTop): Add new member.
(WebCore::LineLayoutState::setAdjustedLogicalLineTop): Add new setter for the new member.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine): Move flow thread case to its helper function.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread): Added new helper for flow thread cases.
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): Save adjustment for flow thread cases.

LayoutTests:

* fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html: Added.
* fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html: Added.
* fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment-expected.html: Added.
* fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment.html: Added.
* fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html: Added.
* fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html: Added.
* fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment-expected.html: Added.
* fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after rr151563.
ch.dumez@sisa.samsung.com [Thu, 13 Jun 2013 19:03:30 +0000 (19:03 +0000)]
Unreviewed build fix after rr151563.

Export needed symbols for Windows.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd tests to validate CSS Background Blending
commit-queue@webkit.org [Thu, 13 Jun 2013 18:34:17 +0000 (18:34 +0000)]
Add tests to validate CSS Background Blending

This patch set removes the test case of adding bg blend mode through script, as it
is now part of bug#117223

https://bugs.webkit.org/show_bug.cgi?id=117537

Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

* css3/compositing/background-blend-mode-default-value.html: Added.
* css3/compositing/background-blend-mode-different-image-formats.html: Added.
* css3/compositing/background-blend-mode-image-color.html: Added.
* css3/compositing/background-blend-mode-image-image.html: Added.
* css3/compositing/background-blend-mode-single-layer-no-blending.html: Added.
* css3/compositing/resources/ducky.jpg: Added.
* platform/mac/css3/compositing/background-blend-mode-default-value-expected.png: Added.
* platform/mac/css3/compositing/background-blend-mode-default-value-expected.txt: Added.
* platform/mac/css3/compositing/background-blend-mode-different-image-formats-expected.png: Added.
* platform/mac/css3/compositing/background-blend-mode-different-image-formats-expected.txt: Added.
* platform/mac/css3/compositing/background-blend-mode-image-color-expected.png: Added.
* platform/mac/css3/compositing/background-blend-mode-image-color-expected.txt: Added.
* platform/mac/css3/compositing/background-blend-mode-image-image-expected.png: Added.
* platform/mac/css3/compositing/background-blend-mode-image-image-expected.txt: Added.
* platform/mac/css3/compositing/background-blend-mode-single-layer-no-blending-expected.png: Added.
* platform/mac/css3/compositing/background-blend-mode-single-layer-no-blending-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Background Blending] Enable CSS Background blending for layers with SVGs.
commit-queue@webkit.org [Thu, 13 Jun 2013 18:25:10 +0000 (18:25 +0000)]
[CSS Background Blending] Enable CSS Background blending for layers with SVGs.

Source/WebCore:

The change implies adding the blending parameter for SVGImage
https://bugs.webkit.org/show_bug.cgi?id=117588

Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

Tests: css3/compositing/background-blend-mode-image-svg.html
       css3/compositing/background-blend-mode-svg-color.html

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::draw):

LayoutTests:

Adding tests for SVGs over simple background colors and images blending with SVGs.
https://bugs.webkit.org/show_bug.cgi?id=117588

Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

* css3/compositing/background-blend-mode-image-svg-expected.txt: Added.
* css3/compositing/background-blend-mode-image-svg.html: Added.
* css3/compositing/background-blend-mode-svg-color-expected.txt: Added.
* css3/compositing/background-blend-mode-svg-color.html: Added.
* css3/compositing/resources/red-circle.svg: Added.
* platform/mac/css3/compositing/background-blend-mode-image-svg-expected.png: Added.
* platform/mac/css3/compositing/background-blend-mode-svg-color-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdating the -webkit-background-blend-mode property dynamically does not trigger...
commit-queue@webkit.org [Thu, 13 Jun 2013 18:24:21 +0000 (18:24 +0000)]
Updating the -webkit-background-blend-mode property dynamically does not trigger a redraw of the element.

Source/WebCore:

Adding krit's fix: actual blending values should be compared, not the sets.
https://bugs.webkit.org/show_bug.cgi?id=117223

Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-image-color-dynamic.html

* rendering/style/FillLayer.cpp:
(WebCore::FillLayer::operator==):

LayoutTests:

Adding test that sets background blend modes from script, after the page is loaded.
https://bugs.webkit.org/show_bug.cgi?id=117223

Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

* fast/repaint/background-blend-mode-image-color-dynamic-expected.html: Added.
* fast/repaint/background-blend-mode-image-color-dynamic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHeaders and footers should be pinned to the left edge of the window when scrolling
bdakin@apple.com [Thu, 13 Jun 2013 18:22:23 +0000 (18:22 +0000)]
Headers and footers should be pinned to the left edge of the window when scrolling
horizontally, even when zoomed
https://bugs.webkit.org/show_bug.cgi?id=117562
-and corresponding-
<rdar://problem/14006745>

Reviewed by Sam Weinig.

We really want to use the width value from scrollOffsetForFixedPosition() for the
banner with a scaled factor of 1. So if there is a different scale factor, re-
compute this value specifically for the banners.
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSupport byte and octet types in bindings generators
ch.dumez@sisa.samsung.com [Thu, 13 Jun 2013 18:13:25 +0000 (18:13 +0000)]
Support byte and octet types in bindings generators
https://bugs.webkit.org/show_bug.cgi?id=117547

Reviewed by Kentaro Hara.

Source/WebCore:

Add support for byte and octet IDL types to the bindings
generator:
http://dev.w3.org/2006/webapi/WebIDL/#idl-byte
http://dev.w3.org/2006/webapi/WebIDL/#idl-octet

No new tests, covered by existing layout tests and by new
bindings tests.

No new tests, covered by bindings tests and:
fast/js/webidl-type-mapping.html

* WebCore.exp.in: Export new symbols for mac port.
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h: Add toInt8() / toUInt8()
methods to convert from JSValue to int8_t / uint8_t as
specified by Web IDL.

* bindings/js/JSDataViewCustom.cpp: Remove custom code for
getInt8, getUInt8, setInt8, setUInt8 now that byte and octet
types are supported by the bindings generator.

* bindings/scripts/CodeGeneratorCPP.pm:
* bindings/scripts/CodeGeneratorGObject.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/TestObj.idl: Add tests for byte and octet types.
* html/canvas/DataView.idl: Remove [Custom] extended attribute for
getInt8, getUInt8, setInt8, setUInt8 and use newly supported byte / octet
types.

LayoutTests:

Update fast/js/webidl-type-mapping.html to cover byte and octet
Web IDL types with and without [EnforceRange].

* fast/js/webidl-type-mapping-expected.txt:
* fast/js/webidl-type-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRevert r150339 since it causes a hang while paused in the Web Inspector in other...
timothy@apple.com [Thu, 13 Jun 2013 18:06:33 +0000 (18:06 +0000)]
Revert r150339 since it causes a hang while paused in the Web Inspector in other apps.

https://bugs.webkit.org/show_bug.cgi?id=117596

Reviewed by Joseph Pecoraro.

* platform/mac/EventLoopMac.mm:
(WebCore::EventLoop::cycle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Correct FeatureDefines.h Default for ENABLE_VIEW_MODE_CSS_MEDIA
bfulgham@apple.com [Thu, 13 Jun 2013 17:48:20 +0000 (17:48 +0000)]
[WinCairo] Correct FeatureDefines.h Default for ENABLE_VIEW_MODE_CSS_MEDIA
https://bugs.webkit.org/show_bug.cgi?id=114396

Reviewed by Dean Jackson.

* wtf/FeatureDefines.h: The WinCairo port does not (currently) support Media elements,
so make sure we do not enable this feature by default for that port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed gardening. Remove dangling 'strings' folder from solution.
bfulgham@apple.com [Thu, 13 Jun 2013 17:44:03 +0000 (17:44 +0000)]
[Windows] Unreviewed gardening.  Remove dangling 'strings' folder from solution.

* WebCore.vcxproj/WebCore.vcxproj.filters: Get rid of 'strings' that was orphaned by
recent file reorganization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed gardening.
bfulgham@apple.com [Thu, 13 Jun 2013 17:33:31 +0000 (17:33 +0000)]
[Windows] Unreviewed gardening.

* WTF.vcxproj/WTF.vcxproj: Add FeatureDefines.h to visible files.
* WTF.vcxproj/WTF.vcxproj.filters: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid unwanted thread hops in ScriptProcessorNode when 'onaudioprocess' listener...
commit-queue@webkit.org [Thu, 13 Jun 2013 17:03:17 +0000 (17:03 +0000)]
Avoid unwanted thread hops in ScriptProcessorNode when 'onaudioprocess' listener is not set.
https://bugs.webkit.org/show_bug.cgi?id=117578.

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-06-13
Reviewed by Darin Adler.

ScriptProcessorNode process operation continues to dispatch AudioProcessingEvent
even though 'onaudioprocess' listener is not set. This results in unwanted thread hops.
Code is optimized to dispatch AudioProcessingEvent only if the listener is set.

No new tests, already covered by existing tests.

* Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):
(WebCore::ScriptProcessorNode::setOnaudioprocess):
* Modules/webaudio/ScriptProcessorNode.h:
(WebCore::ScriptProcessorNode::onaudioprocess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Revise WebKit project to show generated export definition file.
bfulgham@apple.com [Thu, 13 Jun 2013 17:02:36 +0000 (17:02 +0000)]
[Windows] Revise WebKit project to show generated export definition file.
https://bugs.webkit.org/show_bug.cgi?id=109629

Reviewed by Mark Rowe.

* WebKit.vcxproj/WebKit/WebKit.vcxproj: Add generated file.
* WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOptimize String::fromUTF8 for ASCII
gyuyoung.kim@samsung.com [Thu, 13 Jun 2013 16:56:06 +0000 (16:56 +0000)]
Optimize String::fromUTF8 for ASCII
https://bugs.webkit.org/show_bug.cgi?id=117586

Reviewed by Brent Fulgham.

From Blink r152243 by <abarth@chromium.org>

Current String::fromUTF8() implementation converts 8 bit ASCII character into 16 bit.
Instead of always trying to convert into a 16 bit buffer, we can add a call to charactersAreAllASCII.
In the common case when characters are ASCII, we directly copy it into an 8 bit string buffer.

* wtf/text/WTFString.cpp:
(WTF::String::fromUTF8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] -webkit-background-clip: text; does not clip the background in regions
mvujovic@adobe.com [Thu, 13 Jun 2013 16:50:40 +0000 (16:50 +0000)]
[CSS Regions] -webkit-background-clip: text; does not clip the background in regions
https://bugs.webkit.org/show_bug.cgi?id=117566

Reviewed by Alexandru Chiculita.

Source/WebCore:

This patch enables -webkit-background-clip: text; on regions.

Test: fast/regions/webkit-background-clip-text.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
    Force black text if we're in the text clip paint phase. This makes sure the text's alpha
    channel does not affect the final opacity of the background clipping result. Rather,
    the text's alpha channel affects the amount of blending between the text color
    and the background.
* rendering/RenderRegion.cpp:
(WebCore::shouldPaintRegionContentsInPhase):
    Factor out a function to check if we should paint the region contents in a particular
    phase. Add "PaintPhaseTextClip" so that we draw the contents in the text clipping phase.
(WebCore::RenderRegion::paintObject):
    Call shouldPaintRegionContentsInPhase instead of doing the phase checks directly in this
    function. Move, update, and clarify the surrounding comments.

LayoutTests:

* fast/regions/webkit-background-clip-text-expected.html: Added.
* fast/regions/webkit-background-clip-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Regions auto-height and absolute positioning bug
commit-queue@webkit.org [Thu, 13 Jun 2013 16:49:20 +0000 (16:49 +0000)]
[CSS Regions] Regions auto-height and absolute positioning bug
https://bugs.webkit.org/show_bug.cgi?id=111092

Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-06-13
Reviewed by David Hyatt.

During last layout that should update the auto-height regions new auto-height region height
is calculated correctly based on the text content, but it requires extra step
to reposition the render block after new logical height is set (correct logical height becomes
available only during last layout).

Tests: fast/regions/autoheight-abspos-bottom-align.html

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::updateLogicalHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] [WK2] Found missing symbol when running some tests
commit-queue@webkit.org [Thu, 13 Jun 2013 16:47:59 +0000 (16:47 +0000)]
[GTK] [WK2] Found missing symbol when running some tests
https://bugs.webkit.org/show_bug.cgi?id=117598

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-13
Reviewed by Martin Robinson.

* Source/autotools/symbols.filter: Added missing
_ZN7WebCore28notImplementedLoggingChannelEv.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Unreviewed build correction.
bfulgham@apple.com [Thu, 13 Jun 2013 16:20:35 +0000 (16:20 +0000)]
[WinCairo] Unreviewed build correction.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add
missing symbols needed by TestWebKitAPI on WinCairo build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Unreviewed build correction.
bfulgham@apple.com [Thu, 13 Jun 2013 16:18:21 +0000 (16:18 +0000)]
[WinCairo] Unreviewed build correction.

* WebCore.vcxproj/WebCoreCairo.props: Use proper WebKit_Libraries
environment variable, rather than older WebKitLibraries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid duplicate isInt32() / isUInt32() checks in JSDOMBindings
ch.dumez@sisa.samsung.com [Thu, 13 Jun 2013 16:12:51 +0000 (16:12 +0000)]
Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings
https://bugs.webkit.org/show_bug.cgi?id=117593

Reviewed by Geoffrey Garen.

Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings by
calling asInt32() / asUInt32() instead of toInt32() / toUInt32()
when we already know the value is a int32 / uint32.

No new tests, no behavior change.

* bindings/js/JSDOMBinding.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSetting overflow:hidden on position:absolute does not repaint hidden content
commit-queue@webkit.org [Thu, 13 Jun 2013 15:37:10 +0000 (15:37 +0000)]
Setting overflow:hidden on position:absolute does not repaint hidden content
https://bugs.webkit.org/show_bug.cgi?id=116994

Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-06-13
Reviewed by Simon Fraser.

Source/WebCore:

Since a container which has overflow clip of RenderBox which has self painting layer doesn't have a rect of the RenderBox as visual overflow,
the container should not clip request repainting rect of the RenderBox.

Test: fast/repaint/change-overflow-and-display-of-relative.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint):
* rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::shouldUseClipForRepaint): If this has self painting layer, we should not clip for repaint.
* rendering/RenderLayerModelObject.h:

LayoutTests:

* fast/repaint/change-overflow-and-display-of-relative-expected.txt: Added.
* fast/repaint/change-overflow-and-display-of-relative.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Background Blending] Gradients don't blend with any of the layers behind.
commit-queue@webkit.org [Thu, 13 Jun 2013 15:05:14 +0000 (15:05 +0000)]
[CSS Background Blending] Gradients don't blend with any of the layers behind.
First, allow the layers behind opaque gradients to be drawn, then add the blending filters
when working with gradients.

Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id=117532

Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

Tests: css3/compositing/background-blend-mode-gradient-color.html
       css3/compositing/background-blend-mode-gradient-gradient.html
       css3/compositing/background-blend-mode-gradient-image.html
       css3/compositing/background-blend-mode-multiple-background-layers.html

* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::draw):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):

LayoutTests:

https://bugs.webkit.org/show_bug.cgi?id=117532
Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

* css3/compositing/background-blend-mode-gradient-color-expected.txt: Added.
* css3/compositing/background-blend-mode-gradient-color.html: Added.
* css3/compositing/background-blend-mode-gradient-gradient-expected.txt: Added.
* css3/compositing/background-blend-mode-gradient-gradient.html: Added.
* css3/compositing/background-blend-mode-gradient-image-expected.txt: Added.
* css3/compositing/background-blend-mode-gradient-image.html: Added.
* css3/compositing/background-blend-mode-multiple-background-layers-expected.txt: Added.
* css3/compositing/background-blend-mode-multiple-background-layers.html: Added.
* platform/mac/css3/compositing/background-blend-mode-gradient-color-expected.png: Added.
* platform/mac/css3/compositing/background-blend-mode-gradient-gradient-expected.png: Added.
* platform/mac/css3/compositing/background-blend-mode-gradient-image-expected.png: Added.
* platform/mac/css3/compositing/background-blend-mode-multiple-background-layers-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][Mac] Disable QTKit video on OS X.
michael.bruning@digia.com [Thu, 13 Jun 2013 14:42:29 +0000 (14:42 +0000)]
[Qt][Mac] Disable QTKit video on OS X.
https://bugs.webkit.org/show_bug.cgi?id=117591

Reviewed by Tor Arne Vestbø.

Source/WebCore:

Deployment of the same Qt binaries to different
Mac OS X version makes it impossible to link against
the correct WebKitSystemInterface version at build time.

No new tests, no behavioural change.

* WebCore.pri:

Tools:

Deployment of Qt binaries to different Mac OS X
platform version makes it impossible to link against
the correct version of the WebKitSystemInterface library,
so we need to disable QTKit for media elements.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoColumn balancing support in the region based multicol implementation
commit-queue@webkit.org [Thu, 13 Jun 2013 14:11:02 +0000 (14:11 +0000)]
Column balancing support in the region based multicol implementation
https://bugs.webkit.org/show_bug.cgi?id=116033

Source/WebCore:

Start by setting the column height to the flow thread's height divided
by the number of columns. Then stretch the column height until
contents fits without creating overflowing columns, or until the
maximum allowed column height is reached, whichever comes first. This
may require several layout iterations (but normally only a
couple). For each time we stretch, stretch by the least amount
required to make a difference to which box goes where.

Also make sure that the columns get tall enough to honor orphans
and widows settings.

This change takes some tiny steps in preparing for multiple column
set support. There is also some minor cleanup and bugfixing; see
details below.

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-13
Reviewed by David Hyatt.

Tests: fast/multicol/newmulticol/balance-images.html
       fast/multicol/newmulticol/balance-maxheight1.html
       fast/multicol/newmulticol/balance-maxheight2.html
       fast/multicol/newmulticol/balance1.html
       fast/multicol/newmulticol/balance2.html
       fast/multicol/newmulticol/balance3.html
       fast/multicol/newmulticol/balance4.html
       fast/multicol/newmulticol/balance5.html
       fast/multicol/newmulticol/balance6.html
       fast/multicol/newmulticol/balance7.html
       fast/multicol/newmulticol/balance8.html
       fast/multicol/newmulticol/balance9.html
       fast/multicol/newmulticol/cell-shrinkback.html
       fast/multicol/newmulticol/columns-shorthand-parsing.html
       fast/multicol/newmulticol/orphans-and-widows-balance.html
       fast/multicol/newmulticol/single-line.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::setPageBreak):
(WebCore):
(WebCore::RenderBlock::updateMinimumPageHeight):
(WebCore::calculateMinimumPageHeight):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::adjustBlockChildForPagination): If no lines
cross the boundaries, we need to report where blocks cross
instead, so that the column balancer knows how much to stretch
columns if necessary.
* rendering/RenderBlock.h:
* rendering/RenderFlowThread.h:
* rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
(WebCore::RenderMultiColumnBlock::relayoutForPagination):
(WebCore::RenderMultiColumnBlock::layoutSpecialExcludedChild):
* rendering/RenderMultiColumnBlock.h:
(WebCore::RenderMultiColumnBlock::columnHeightAvailable):
(WebCore::RenderMultiColumnBlock::requiresBalancing):
(RenderMultiColumnBlock):
* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::autoGenerateRegionsToBlockOffset):
(WebCore::RenderMultiColumnFlowThread::setPageBreak):
(WebCore):
(WebCore::RenderMultiColumnFlowThread::updateMinimumPageHeight):
* rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
* rendering/RenderMultiColumnSet.cpp: Get rid of
RenderMultiColumnSet::updateLogicalHeight() override. Make
RenderMultiColumnSet behave more like normal blocks, by having
computeLogicalHeight() calculate logical top in addition to
height, just like any other block.
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset): This
method will become more meaningful once we add support for
multiple column sets.
(WebCore):
(WebCore::RenderMultiColumnSet::pageLogicalTopForOffset):
(WebCore::RenderMultiColumnSet::setAndConstrainColumnHeight):
(WebCore::RenderMultiColumnSet::calculateBalancedHeight):
(WebCore::RenderMultiColumnSet::recordSpaceShortage):
(WebCore::RenderMultiColumnSet::updateLogicalWidth):
(WebCore::RenderMultiColumnSet::prepareForLayout):
(WebCore::RenderMultiColumnSet::computeLogicalHeight):
(WebCore::RenderMultiColumnSet::columnCount):
(WebCore::RenderMultiColumnSet::columnIndexAtOffset):
repaintFlowThreadContent() could end up in an infinite loop
because columnIndexAtOffset() could return UINT_MAX
(subtracting 1 from unsigned 0, which columnCount() could return),
which an unsigned integer obviously can never become larger
than. Also always call columnIndexAtOffset() if we want to get the
column index for some offset, rather than doing it on our own
sometimes. To make this work also during layout, we cannot just
return the last column created so far if we're past it, since
adding new columns is exactly what we want to do at this point.
* rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):

LayoutTests:

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-13
Reviewed by David Hyatt.

* fast/multicol/newmulticol/balance-images-expected.txt: Added.
* fast/multicol/newmulticol/balance-images.html: Added.
* fast/multicol/newmulticol/balance-maxheight1-expected.txt: Added.
* fast/multicol/newmulticol/balance-maxheight1.html: Added.
* fast/multicol/newmulticol/balance-maxheight2-expected.txt: Added.
* fast/multicol/newmulticol/balance-maxheight2.html: Added.
* fast/multicol/newmulticol/balance1-expected.txt: Added.
* fast/multicol/newmulticol/balance1.html: Added.
* fast/multicol/newmulticol/balance2-expected.txt: Added.
* fast/multicol/newmulticol/balance2.html: Added.
* fast/multicol/newmulticol/balance3-expected.txt: Added.
* fast/multicol/newmulticol/balance3.html: Added.
* fast/multicol/newmulticol/balance4-expected.txt: Added.
* fast/multicol/newmulticol/balance4.html: Added.
* fast/multicol/newmulticol/balance5-expected.txt: Added.
* fast/multicol/newmulticol/balance5.html: Added.
* fast/multicol/newmulticol/balance6-expected.txt: Added.
* fast/multicol/newmulticol/balance6.html: Added.
* fast/multicol/newmulticol/balance7-expected.txt: Added.
* fast/multicol/newmulticol/balance7.html: Added.
* fast/multicol/newmulticol/balance8-expected.txt: Added.
* fast/multicol/newmulticol/balance8.html: Added.
* fast/multicol/newmulticol/balance9-expected.txt: Added.
* fast/multicol/newmulticol/balance9.html: Added.
* fast/multicol/newmulticol/cell-shrinkback-expected.html: Added.
* fast/multicol/newmulticol/cell-shrinkback.html: Added.
* fast/multicol/newmulticol/columns-shorthand-parsing-expected.html: Added.
* fast/multicol/newmulticol/columns-shorthand-parsing.html: Added.
* fast/multicol/newmulticol/orphans-and-widows-balance-expected.txt: Added.
* fast/multicol/newmulticol/orphans-and-widows-balance.html: Added.
* fast/multicol/newmulticol/single-line-expected.html: Added.
* fast/multicol/newmulticol/single-line.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Unskipping passing test and move to the right place.
zarvai@inf.u-szeged.hu [Thu, 13 Jun 2013 12:53:02 +0000 (12:53 +0000)]
[Qt] Unreviewed gardening. Unskipping passing test and move to the right place.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-13

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ARM] Unreviewed gardening, skip one more test to paint the bot green.
ossy@webkit.org [Thu, 13 Jun 2013 09:45:41 +0000 (09:45 +0000)]
[ARM] Unreviewed gardening, skip one more test to paint the bot green.

* platform/qt-arm/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 13 Jun 2013 09:17:23 +0000 (09:17 +0000)]
Unreviewed GTK gardening.
Adding failure expectations for most of the current failures.

* platform/gtk-wk1/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
commit-queue@webkit.org [Thu, 13 Jun 2013 08:23:58 +0000 (08:23 +0000)]
[EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
https://bugs.webkit.org/show_bug.cgi?id=116610

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-06-13
Reviewed by Noam Rosenthal.

Source/WebKit2:

WebKit2 EFL uses fixed layout - because of this ScrollView::contentsToWindow, does
not take scroll into account, as it is meant to be handled by UI application.
When popup and context menu are created, after calling contentsToWindow their position
are not adjusted to page scroll.
Added two functions to EwkView and WKView, converting contents position to user viewport
coordinates, to adjust popup and context menu positions.

* UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
(WKViewContentsToUserViewport):
* UIProcess/API/C/CoordinatedGraphics/WKView.h:
* UIProcess/API/efl/EwkView.cpp:
(EwkView::showContextMenu):
(EwkView::requestPopupMenu):
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::contentsToUserViewport):
* UIProcess/CoordinatedGraphics/WebView.h:

Tools:

Remove unnecessary code adjusting context menu position to webview position.
Now position is calculcated in EwkView.

* MiniBrowser/efl/main.c:
(on_context_menu_show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Refactor ewk_view_scroll to remove internal structure.
ryuan.choi@samsung.com [Thu, 13 Jun 2013 07:52:16 +0000 (07:52 +0000)]
[EFL] Refactor ewk_view_scroll to remove internal structure.
https://bugs.webkit.org/show_bug.cgi?id=115713

Reviewed by Gyuyoung Kim.

After removed c-ism from WebKit/Efl, There is no reason to keep internal
structures like Ewk_Scroll_Request.
This patch refactored ewk_view_scroll to use WTF instead of Ewk_Scroll_Request
and scrolls of SmartData.

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::scroll):
* ewk/ewk_view.cpp: Removed functions to manage Ewk_Scroll_Request.
(_Ewk_View_Private_Data):
(_ewk_view_scrolls_flush):
(_ewk_view_priv_del):
(_ewk_view_smart_calculate):
(ewk_view_scroll_offsets_get):
(ewk_view_scroll_rects_get):
(ewk_view_scroll):
* ewk/ewk_view.h: Removed Ewk_Scroll_Request which is private structure.
* ewk/ewk_view_private.h:
(WebCore):
* ewk/ewk_view_single.cpp:
(_ewk_view_single_scroll_process_single):
(_ewk_view_single_smart_scrolls_process):
* ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_smart_scrolls_process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoVersioning.
lforschler@apple.com [Thu, 13 Jun 2013 07:15:34 +0000 (07:15 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ARM] Unreviewed gardening, skip one more test to paint the bot green.
ossy@webkit.org [Thu, 13 Jun 2013 06:10:26 +0000 (06:10 +0000)]
[ARM] Unreviewed gardening, skip one more test to paint the bot green.

* platform/qt-arm/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Unreviewed build correction.
bfulgham@apple.com [Thu, 13 Jun 2013 05:58:53 +0000 (05:58 +0000)]
[WinCairo] Unreviewed build correction.

* win/tools32/vsprops/WinCairo.props: Switch from using the
  $WebKitLibraries environment variable to the newer
  $WebKit_Libraries.
* win/tools32/vsprops/debug_wincairo.props: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
roger_fong@apple.com [Thu, 13 Jun 2013 01:48:44 +0000 (01:48 +0000)]
Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.

* Scripts/webkitpy/common/config/ews.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate webkit.org build instructions for Apple Windows port.
roger_fong@apple.com [Thu, 13 Jun 2013 01:15:58 +0000 (01:15 +0000)]
Update webkit.org build instructions for Apple Windows port.
https://bugs.webkit.org/show_bug.cgi?id=117563.

Reviewed by Brent Fulgham.

* building/build.html:
* building/debug.html:
* building/launch-debugger-vs2005.png: Removed.
* building/launch-debugger-vs2010.png: Copied from webkit.org/building/launch-debugger-vs2005.png.
* building/set-as-startup-project-vs2005.png: Removed.
* building/set-as-startup-project-vs2010.png: Copied from webkit.org/building/set-as-startup-project-vs2005.png.
* building/set-debugging-properties-vs2005.png: Removed.
* building/set-debugging-properties-vs2010.png: Copied from webkit.org/building/set-debugging-properties-vs2005.png.
* building/tools.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. EFL Gardening. Needs to add new baseline for some tests, which are passin...
gyuyoung.kim@samsung.com [Thu, 13 Jun 2013 01:13:46 +0000 (01:13 +0000)]
Unreviewed. EFL Gardening. Needs to add new baseline for some tests, which are passing on EFL bots.

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/editing/selection/3690703-2-expected.png: Added.
* platform/efl/editing/selection/3690703-2-expected.txt: Added.
* platform/efl/editing/selection/3690703-expected.png: Added.
* platform/efl/editing/selection/3690703-expected.txt: Added.
* platform/efl/editing/selection/3690719-expected.png: Added.
* platform/efl/editing/selection/3690719-expected.txt: Added.
* platform/efl/editing/selection/4397952-expected.png: Added.
* platform/efl/editing/selection/4397952-expected.txt: Added.
* platform/efl/editing/selection/4895428-3-expected.png: Added.
* platform/efl/editing/selection/4895428-3-expected.txt: Added.
* platform/efl/editing/selection/4975120-expected.png: Added.
* platform/efl/editing/selection/4975120-expected.txt: Added.
* platform/efl/editing/selection/5007143-2-expected.png: Added.
* platform/efl/editing/selection/5007143-2-expected.txt: Added.
* platform/efl/editing/selection/5007143-expected.png: Added.
* platform/efl/editing/selection/5007143-expected.txt: Added.
* platform/efl/editing/selection/5057506-expected.png: Added.
* platform/efl/editing/selection/5057506-expected.txt: Added.
* platform/efl/editing/selection/5195166-1-expected.txt: Added.
* platform/efl/editing/selection/7152-2-expected.png: Added.
* platform/efl/editing/selection/7152-2-expected.txt: Added.
* platform/efl/editing/selection/caret-before-select-expected.png: Added.
* platform/efl/editing/selection/caret-before-select-expected.txt: Added.
* platform/efl/editing/selection/caret-ltr-right-expected.png: Added.
* platform/efl/editing/selection/caret-ltr-right-expected.txt: Added.
* platform/efl/editing/selection/caret-rtl-2-left-expected.png: Added.
* platform/efl/editing/selection/caret-rtl-2-left-expected.txt: Added.
* platform/efl/editing/selection/caret-rtl-right-expected.png: Added.
* platform/efl/editing/selection/caret-rtl-right-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove irrelevant blog from Planet WebKit.
bfulgham@apple.com [Thu, 13 Jun 2013 01:00:43 +0000 (01:00 +0000)]
Remove irrelevant blog from Planet WebKit.
https://bugs.webkit.org/show_bug.cgi?id=117572

Reviewed by Mark Rowe.

* config.ini: Remove Chromium blog from planet.webkit.org

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Activate supported C++11 Features for VS2010
bfulgham@apple.com [Thu, 13 Jun 2013 00:59:48 +0000 (00:59 +0000)]
[Windows] Activate supported C++11 Features for VS2010
https://bugs.webkit.org/show_bug.cgi?id=117569

Reviewed by Anders Carlsson.

* wtf/Compiler.h: Turn on rvalue references and static_assert
when compiling with VS2010 (or newer)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the notion of inactive plug-ins
andersca@apple.com [Thu, 13 Jun 2013 00:34:45 +0000 (00:34 +0000)]
Remove the notion of inactive plug-ins
https://bugs.webkit.org/show_bug.cgi?id=117570
<rdar://problem/13484213>

Reviewed by Tim Horton.

Source/WebCore:

Remove RenderEmbeddedObject::PluginInactive and the replacement text.

* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
* platform/LocalizedStrings.h:
* rendering/RenderEmbeddedObject.cpp:
(WebCore::unavailablePluginReplacementText):
* rendering/RenderEmbeddedObject.h:

Source/WebKit/mac:

Remove code that deals with inactive plug-ins.

* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):

Source/WebKit2:

Remove code that deals with inactive plug-ins. We still keep around the kWKPluginLoadPolicyInactive API enum for now.

* Shared/Plugins/PluginModuleInfo.h:
* UIProcess/API/C/WKAPICast.h:
(WebKit::toWKPluginLoadPolicy):
(WebKit::toPluginModuleLoadPolicy):
* UIProcess/Plugins/PluginInfoStore.cpp:
* UIProcess/Plugins/PluginInfoStore.h:
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::shouldUsePlugin):
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Implement Accessibility2 APIs in Windows.
bfulgham@apple.com [Thu, 13 Jun 2013 00:05:23 +0000 (00:05 +0000)]
[Windows] Implement Accessibility2 APIs in Windows.
https://bugs.webkit.org/show_bug.cgi?id=117561

Reviewed by Anders Carlsson.

Source/WebKit:

* WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Add new IAccessible2 IDL files.
* WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters: Ditto.
* WebKit.vcxproj/Interfaces/InterfacesCommon.props: Reference new Accessible2 folder.
* WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Build IAccessible2 symbols.
* WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters: Ditto.

Source/WebKit/win:

* AccessibleBase.cpp: Add stubs for IAccessible2 interface, replace attributeValue
method with get_attribute from IAccessible2 API.
* AccessibleBase.h: Ditto.
* AccessibleDocument.cpp: Revise signatures for IAccessible2.
* AccessibleDocument.h: Ditto.
* AccessibleImage.cpp: Revise signatures for IAccessible2.
* AccessibleImage.h: Ditto.
* Interfaces/Accessible2: Added.
* Interfaces/Accessible2/Accessible2.idl: Added.
* Interfaces/Accessible2/Accessible2_2.idl: Added.
* Interfaces/Accessible2/AccessibleApplication.idl: Added.
* Interfaces/Accessible2/AccessibleRelation.idl: Added.
* Interfaces/Accessible2/AccessibleStates.idl: Added.
* Interfaces/Accessible2/IA2CommonTypes.idl: Added.
* Interfaces/AccessibleComparable.idl:
* Interfaces/WebKit.idl: Reference IAccessible2 types.
* WebFrame.cpp:
(WebFrame::accessible): Pass window handle to IAccessible types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Change default Traditional Chinese serif font on 10.9
dino@apple.com [Wed, 12 Jun 2013 23:55:59 +0000 (23:55 +0000)]
[Mac] Change default Traditional Chinese serif font on 10.9
https://bugs.webkit.org/show_bug.cgi?id=117568

Reviewed by Alexey Proskuryakov.

Change default font on newer versions of OS X.

* page/mac/SettingsMac.mm:
(WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti TC'
on 10.9 and above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Explicit include glib.h to avoid compilation errors if libsoup isn't used.
hugo.lima@openbossa.org [Wed, 12 Jun 2013 23:53:03 +0000 (23:53 +0000)]
[GTK] Explicit include glib.h to avoid compilation errors if libsoup isn't used.
https://bugs.webkit.org/show_bug.cgi?id=117564

Reviewed by Martin Robinson.

* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Change default Simplified Chinese serif font on 10.9
dino@apple.com [Wed, 12 Jun 2013 23:48:27 +0000 (23:48 +0000)]
[Mac] Change default Simplified Chinese serif font on 10.9
https://bugs.webkit.org/show_bug.cgi?id=117567

Reviewed by Alexey Proskuryakov.

Change default font on newer versions of OS X.

* page/mac/SettingsMac.mm:
(WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti SC'
instead of 'STSong' on newer systems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix crashes due to failed ImageBuffer allocation
gyuyoung.kim@samsung.com [Wed, 12 Jun 2013 23:30:12 +0000 (23:30 +0000)]
Fix crashes due to failed ImageBuffer allocation
https://bugs.webkit.org/show_bug.cgi?id=117541

Reviewed by Andreas Kling.

From Blink r152268 by <pdr@chromium.org>

A crash can happen due to a failed ImageBuffer allocation in
SVGImage::drawPatternForContainer(). Added a check for that failed allocation.

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
commit-queue@webkit.org [Wed, 12 Jun 2013 21:39:42 +0000 (21:39 +0000)]
[atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=115647

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-12
Reviewed by Martin Robinson.

Source/WebCore:

Override the get_object_locale() method of WebkitAccessibleWrapperAtk's internal
AtkObject, to include custom implementations for AtkDocument and AtkText objects,
taking the logic as-is from AtkDocument::get_document_locale() and DumpRenderTree's
AccessibilityUIElementAtk::language(), respectively.

Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
method.

No new functionality, no new tests.

* accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:
(webkitAccessibleDocumentInterfaceInit): Chains implementation of
AtkDocument::get_document_locale() to AtkObject::get_object_locale().
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetObjectLocale): Add implementation of locale resolution for
objects of type AtkDocument and AtkText.
(webkitAccessibleClassInit): Override AtkObject::get_object_locale() method.

Tools:

Locale resolution is moved to WebKitAccessibleWrapperAtk using
AtkObject::get_object_locale() API. Now, implementation of
AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
be leveraged to get_object_locale() of AtkObject.

Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
method.

No new functionality, no new tests.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::language): Leverage locale resolution to
AtkObject::get_object_locale().
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::language): Leverage locale resolution to
AtkObject::get_object_locale().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove last bits of GYP from build-webkit and update-webkit scripts
hugo.lima@openbossa.org [Wed, 12 Jun 2013 20:46:18 +0000 (20:46 +0000)]
Remove last bits of GYP from build-webkit and update-webkit scripts
https://bugs.webkit.org/show_bug.cgi?id=117557

Reviewed by Ryosuke Niwa.

* Scripts/build-webkit:
* Scripts/update-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Move more build targets for source code that's free of layer violations into...
zandobersek@gmail.com [Wed, 12 Jun 2013 20:18:16 +0000 (20:18 +0000)]
[GTK] Move more build targets for source code that's free of layer violations into libPlatform
https://bugs.webkit.org/show_bug.cgi?id=115936

Reviewed by Martin Robinson.

Source/Platform:

* GNUmakefile.am: Add additional Source/WebCore/platform subdirectories to the list of the directories
that are specific to the platform layer but still located in WebCore. Add Enchant and Freetype dependencies'
CFLAGS to the list of libPlatform CPPFLAGS. Add GStreamer dependency's CFLAGS to the list of libPlatformGtk
CPPFLAGS.

Source/WebCore:

No new tests - no new functionality.

* GNUmakefile.list.am: Move more build targets under the platform_sources and platformgtk_sources listing.
These build targets represent source files that are already free of platform layer violations and are as such
ready to be pushed down from the WebCore layer into the Platform layer.

Source/WebKit2:

* GNUmakefile.am: Add GStreamer dependency's CFLAGS to the list of libPlatformGtk2 CPPFLAGS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove forgotten unused Tools/Script/make-gypi script
hugo.lima@openbossa.org [Wed, 12 Jun 2013 20:07:39 +0000 (20:07 +0000)]
Remove forgotten unused Tools/Script/make-gypi script
https://bugs.webkit.org/show_bug.cgi?id=117558

Reviewed by Ryosuke Niwa.

This script isn't used since the GYP removal from WebKit.

* Scripts/make-gypi: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago"Open Video in New Window" doesn't make sense in fullscreen
commit-queue@webkit.org [Wed, 12 Jun 2013 19:58:29 +0000 (19:58 +0000)]
"Open Video in New Window" doesn't make sense in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=117556

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12
Reviewed by Beth Dakin.

Source/WebCore:

No new tests needed.

* WebCore.exp.in: Added WebKit2 hook for mediaIsInFullscreen() method.

Source/WebKit2:

Adds method mediaIsInFullscreen() that checks if a media element is in
fullscreen mode, which is needed to decide when to display the
"Open Video in New Window" context menu item.

* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultMediaIsInFullscreen): Added.
Hooks into new InjectedBundleHitTestResult::mediaIsInFullscreen() method.
* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
* WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::mediaIsInFullscreen): Added.
Checks if media element is in fullscreen.
* WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAccessibility code assumes an area element's parent is a map element
rniwa@webkit.org [Wed, 12 Jun 2013 19:52:04 +0000 (19:52 +0000)]
Accessibility code assumes an area element's parent is a map element
https://bugs.webkit.org/show_bug.cgi?id=117496

Reviewed by Chris Fleizach.

Source/WebCore:

We can't make such an assumption. Scripts can insert any element between area and map elements.

Merge https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f.

Test: accessibility/image-map-with-indirect-area-crash.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):

LayoutTests:

Add a regression test from https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f.

* accessibility/image-map-with-indirect-area-crash-expected.txt: Added.
* accessibility/image-map-with-indirect-area-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Whitespace between inlines with nowrap and a shrink-to-fit parent...
robert@webkit.org [Wed, 12 Jun 2013 19:20:33 +0000 (19:20 +0000)]
Source/WebCore: Whitespace between inlines with nowrap and a shrink-to-fit parent gets a line-break when it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=117370

Reviewed by David Hyatt.

Test: fast/text/whitespace/inline-whitespace-wrapping-8.html

A no-wrap inline shouldn't include trailing space when deciding whether it fits on a line.
Likewise when we finish iterating through the objects on a line we should clear our linebreak
if the only thing that prevents us fitting on the line is our collapsed trailing whitespace.

Removing the trailing space from this measurement means we need to watch out for potential
breaks between no-wrap inlines, in particular if we leave a no-wrap inline ignoring spaces
and enter an autowrap inline then we need to mark the beginning of the autowrap inline
as a potential linebreak. The test fast/text/whitespace/inline-whitespace-wrapping-5.html
is an example of such a case.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
(WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
(WebCore::LineWidth::setTrailingWhitespaceWidth):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests: Whitespace between inlines with nowrap and a shrink-to-fit parent line-break incorrectly
https://bugs.webkit.org/show_bug.cgi?id=117370

Reviewed by David Hyatt.

* fast/text/whitespace/inline-whitespace-wrapping-8-expected.html: Added.
* fast/text/whitespace/inline-whitespace-wrapping-8.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] rectangle and inset-rectangle do not properly handle rx and ry
commit-queue@webkit.org [Wed, 12 Jun 2013 18:59:58 +0000 (18:59 +0000)]
[CSS Shapes] rectangle and inset-rectangle do not properly handle rx and ry
https://bugs.webkit.org/show_bug.cgi?id=116745

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-06-12
Reviewed by Dirk Schulze.

Source/WebCore:

If ry is not supplied, it now defaults to the rx value. Also, if rx
and ry are not supplied, they default to 0px. This also has the effect
that the computed style for any rectangle or inset-rectangle now
contains all six parameters.

If rx > width/2 then it is clamped to width/2, and if ry > height/2,
then it is clamped to height/2. This happens at layout time because
given mixed units and relative units, that is the only time this
determination can be made.

Tests: fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius.html
       fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html

* css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape): Remove checks for undefined, since rx
    and ry cannot be undefined in BasicShapes anymore.
(WebCore::basicShapeForValue): If radii are undefined in CSS, set
    default values in the BasicShape, per the spec.
* rendering/ExclusionShape.cpp:
(WebCore::ensureRadiiDoNotOverlap): Utility method to ensure radii
    don't overlap.
(WebCore::ExclusionShape::createExclusionShape): Remove defaulting to
    zero, clamp radii per the spec.
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeRectangle::path): Remove defaulting.
(WebCore::BasicShapeRectangle::blend): Ditto.
(WebCore::BasicShapeInsetRectangle::path): Ditto.
(WebCore::BasicShapeInsetRectangle::blend): Ditto.
* rendering/style/BasicShapes.h:
(WebCore::BasicShapeRectangle::BasicShapeRectangle): Remove defaulting
    to undefined for radii.
(WebCore::BasicShapeRectangle::setCornerRadiusX): Add assert to
    prevent undefined.
       (WebCore::BasicShapeRectangle::setCornerRadiusY): Add assert to
    prevent undefined.
(WebCore::BasicShapeInsetRectangle::BasicShapeInsetRectangle): Ditto.
(WebCore::BasicShapeInsetRectangle::setCornerRadiusX): Add assert to
    prevent undefined.
       (WebCore::BasicShapeInsetRectangle::setCornerRadiusY): Add assert to
    prevent undefined.

LayoutTests:

Update tests to check for the rx and ry conditions.

* fast/exclusions/parsing/parsing-shape-inside-expected.txt: New results.
* fast/exclusions/parsing/parsing-shape-outside-expected.txt: New results.
* fast/exclusions/parsing/script-tests/parsing-shape-inside.js: Update
    to reflect that the computed value now always has rx and ry.
* fast/exclusions/parsing/script-tests/parsing-shape-outside.js: Ditto.
* fast/exclusions/parsing/script-tests/parsing-test-utils.js: Ditto.
* fast/exclusions/resources/rounded-rectangle.js:
(genLeftRightRoundedRectFloatShapeOutsideRefTest): Factor out left and
    right into separate methods so that they can be used in tests that
    only have left floats or only right floats.
(genLeftRoundedRectFloatShapeOutsideRefTest): Ditto.
(genRightRoundedRectFloatShapeOutsideRefTest): Ditto.
* fast/exclusions/shape-inside/shape-inside-animation-expected.txt: New results.
* fast/exclusions/shape-inside/shape-inside-animation.html: Change to
    reflect new computed style value.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius-expected.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html: Added.
    Note that the expected test here uses shape-inside, because we
    really are just testing that the behavior is the same as a
    shape-inside with rx and ry set to 50%, and it turned out to be
    very hard to construct an expected result that didn't use
    shape-inside and wasn't off by a pixel.
* css3/masking/clip-path-animation.html: Update expected value.
* css3/masking/clip-path-animation-expected.txt: New results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Support Title UI Element Accessibility Attribute
bfulgham@apple.com [Wed, 12 Jun 2013 18:57:51 +0000 (18:57 +0000)]
[Windows] Support Title UI Element Accessibility Attribute
https://bugs.webkit.org/show_bug.cgi?id=117530

Reviewed by Anders Carlsson.

Source/WebCore:

Fixes: accessibility/list-item-role.html
       accessibility/hidden-legend.html

* accessibility/win/AccessibilityObjectWrapperWin.cpp:
(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue): Extend to support access
for the Title UI Element object.
* accessibility/win/AccessibilityObjectWrapperWin.h: Revise interface to use Variant output,
which is more in keeping with the Mac's 'id' method signature.

Source/WebKit/win:

* AccessibleBase.cpp:
(AccessibleBase::attributeValue): Extend to handle Title UI Element.
* AccessibleBase.h: Revise signature to use a variant argument.
* Interfaces/AccessibleComparable.idl:  Revise interface to use variant

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd new Web Inspector images for a blog post.
timothy@apple.com [Wed, 12 Jun 2013 18:53:47 +0000 (18:53 +0000)]
Add new Web Inspector images for a blog post.

* blog-files/new-inspector/activity-viewer.png: Added.
* blog-files/new-inspector/codemirror.png: Added.
* blog-files/new-inspector/console.png: Added.
* blog-files/new-inspector/hero-labeled.png: Added.
* blog-files/new-inspector/hero.png: Added.
* blog-files/new-inspector/layer-borders.png: Added.
* blog-files/new-inspector/layers.png: Added.
* blog-files/new-inspector/navigation-bar.png: Added.
* blog-files/new-inspector/open-sign.png: Added.
* blog-files/new-inspector/reasons.png: Added.
* blog-files/new-inspector/save.png: Added.
* blog-files/new-inspector/source-map.png: Added.
* blog-files/new-inspector/styles.png: Added.
* blog-files/new-inspector/toolbar-context-menu.png: Added.
* blog-files/new-inspector/toolbar-docked.png: Added.
* blog-files/new-inspector/toolbar.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Use RefPtr for HTMLInputElement inside CredentialTransformData
leoyang@rim.com [Wed, 12 Jun 2013 18:41:30 +0000 (18:41 +0000)]
[BlackBerry] Use RefPtr for HTMLInputElement inside CredentialTransformData
https://bugs.webkit.org/show_bug.cgi?id=117553

Reviewed by Carlos Garcia Campos.

In CredentialTransformData we should use RefPtr for
m_userNameElement, m_passwordElement and m_oldPasswordElement
because otherwise the elements could go away when the form
elements get destroyed.

Also add *const* for the parameter of CredentialTransformData::findPasswordFormFields().

No functionalities changed no new tests.

* WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields):
(WebCore::CredentialTransformData::locateSpecificPasswords):
* WebCoreSupport/CredentialTransformData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shaders] Animations and transitions should use validated custom programs
commit-queue@webkit.org [Wed, 12 Jun 2013 18:28:24 +0000 (18:28 +0000)]
[CSS Shaders] Animations and transitions should use validated custom programs
https://bugs.webkit.org/show_bug.cgi?id=117550

Run filters used for animations and transitions through RenderLayer::computeFilterOperations
in order to validate custom filter operations.

Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-12
Reviewed by Alexandru Chiculita.

No new tests as no platform can run custom filters with accelerated animations yet.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAllow for toggling fullscreen on <video> elements
commit-queue@webkit.org [Wed, 12 Jun 2013 17:33:31 +0000 (17:33 +0000)]
Allow for toggling fullscreen on <video> elements
https://bugs.webkit.org/show_bug.cgi?id=117220

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12
Reviewed by Dean Jackson.

Source/WebCore:

This patch adds the ability for fullscreen
context menu item on <video> elements to switch between "Enter Fullscreen"
and "Exit Fullscreen" and behave appropriately.

No new tests. media/context-menu-action.html,
which has been disabled by bug 116651, is used to test context menus.

* English.lproj/Localizable.strings: Add "Exit Fullscreen" string.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::toggleFullscreenState): Added to appropriately enter/exit fullscreen.
* html/HTMLMediaElement.h:
* page/ContextMenuController.cpp:
* platform/ContextMenuItem.h:
* platform/LocalizedStrings.cpp:
* platform/LocalizedStrings.h:
Updated to rename variables more appropriately to reflect the toggle-ability of video fullscreen.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::mediaIsInFullscreen): Added to check if an element
was a media element in fullscreen.
(WebCore::HitTestResult::toggleMediaFullscreenState): Added to hook into
HTMLMediaElement::toggleFullscreenState.
* rendering/HitTestResult.h:

Source/WebKit2:

* Shared/API/c/WKContextMenuItemTypes.h:
* Shared/API/c/WKSharedAPICast.h:
Added variables to support the toggle-ability of the fullscreen
video context menu item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ARM] Unreviewed gardening, unskip now passing tests and try to paint the bot green.
ossy@webkit.org [Wed, 12 Jun 2013 17:32:33 +0000 (17:32 +0000)]
[ARM] Unreviewed gardening, unskip now passing tests and try to paint the bot green.

* platform/qt-arm/TestExpectations:
* platform/qt-arm/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
* platform/qt-arm/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Removed.
* platform/qt-arm/svg/batik/text/textOnPath3-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkipping {}, () and [] blocks while error recovering in CSS
sergio@webkit.org [Wed, 12 Jun 2013 17:23:31 +0000 (17:23 +0000)]
Skipping {}, () and [] blocks while error recovering in CSS
https://bugs.webkit.org/show_bug.cgi?id=116071

Reviewed by Darin Adler.

From Blink r150201 and r150755 by <serya@chromium.org>

Source/WebCore:

Test: fast/css/parsing-expr-error-recovery.html

The CSS parser should properly recover from invalid {}, () and []
blocks skipping them instead of discarding the whole declaration
as invalid. This merge is actually made of two different changes
from Blink, the original one that fixes the bug and another one
which refactors a bit the code making it more legible.

* css/CSSGrammar.y.in:

LayoutTests:

* fast/css/parsing-expr-error-recovery-expected.txt: Added.
* fast/css/parsing-expr-error-recovery.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJSExport header documentation substitutes "semicolon" for "colon"
commit-queue@webkit.org [Wed, 12 Jun 2013 17:22:57 +0000 (17:22 +0000)]
JSExport header documentation substitutes "semicolon" for "colon"
https://bugs.webkit.org/show_bug.cgi?id=117552

Patch by Conrad Shultz <conrad_shultz@apple.com> on 2013-06-12
Reviewed by Mark Hahnenberg.

* API/JSExport.h:
Fix a couple typos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Invalidate the ProcessLauncher when the process is terminated before it has...
carlosgc@webkit.org [Wed, 12 Jun 2013 17:17:42 +0000 (17:17 +0000)]
[GTK] Invalidate the ProcessLauncher when the process is terminated before it has finished launching
https://bugs.webkit.org/show_bug.cgi?id=117412

Reviewed by Anders Carlsson.

* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::terminateProcess): If process is still
launching just invalidate the launcher. Reset the process
identifier after killing the process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Remove dead WebDOM code
commit-queue@webkit.org [Wed, 12 Jun 2013 17:11:41 +0000 (17:11 +0000)]
[BlackBerry] Remove dead WebDOM code
https://bugs.webkit.org/show_bug.cgi?id=113370

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-06-12
Reviewed by Anders Carlsson.

BlackBerry PR 347565
Internally reviewed by Charles Wei.

.:

* Source/cmake/OptionsBlackBerry.cmake:

Source/WebCore:

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

* Api/WebPage.cpp:
* Api/WebPage.h:
* WebCoreSupport/AboutDataEnableFeatures.in:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[css exclusions] fast/css/variables/var-inside-shape.html is failing
sergio@webkit.org [Wed, 12 Jun 2013 17:01:00 +0000 (17:01 +0000)]
[css exclusions] fast/css/variables/var-inside-shape.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116059

Reviewed by Alexandru Chiculita.

Some shapes were incorrectly defined, there was a "rectange"
instead of a "rectangle" and also the number of parameters and
their types was wrong. Apart from that, both the CSS exclusions
and CSS variables settings were not enabled at runtime.

Some extra text was also added to the divs in order to verify that
the CSS exclusions are working properly.

* fast/css/variables/var-inside-shape-expected.html:
* fast/css/variables/var-inside-shape.html:
* platform/efl/TestExpectations: Removed var-inside-shape.html.
* platform/gtk/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agowindow.find() case-insensitive search doesn't match diacritical marks
dbates@webkit.org [Wed, 12 Jun 2013 16:46:15 +0000 (16:46 +0000)]
window.find() case-insensitive search doesn't match diacritical marks
https://bugs.webkit.org/show_bug.cgi?id=117353
<rdar://problem/8535227>

Patch by Daniel Bates <dabates@apple.com> on 2013-06-12
Reviewed by Darin Adler.

Source/WebCore:

Currently, a case-insensitive window.find() search will return true for a word w
(e.g. café) with diacritical characters when w appears on the page without
diacritical marks (e.g. cafe). This leads to bad results, especially when
searching for a non-English word (e.g. qué) where the presence of an accented
character(s) may change the meaning of the word. Instead window.find() should
return false when case-insensitively matching a word with diacritical marks to
the same word without diacritical marks.

Test: fast/text/find-diacritical-mark.html

* editing/TextIterator.cpp:
(WebCore::SearchBuffer::SearchBuffer):

LayoutTests:

Added test to use window.find() to find a search string in text, where either
the search string or text (or both) contain diacritical characters.

Additionally, updated tests LayoutTests/fast/text/find-soft-hyphen.html
and LayoutTests/editing/execCommand/findString-diacriticals.html based on the
new behavior of window.find(). Moved function testFind() from LayoutTests/fast/text/script-tests/find-backwards.js
to its own file, LayoutTests/fast/text/resources/test-find.js, so that this function can
be used by both tests LayoutTests/fast/text/find-{backwards, diacritical-mark}.html.

* LayoutTests/editing/execCommand/findString-diacriticals.html: Update test based on the new
behavior of window.find().
* fast/text/find-backwards.html: Include external JavaScript file test-find.js.
* fast/text/find-case-folding-expected.txt: Rebase result; expected failure.
* fast/text/find-case-folding.html: Add comment to see bug #117548 with regards to expected failure.
* fast/text/find-diacritical-mark-expected.txt: Added.
* fast/text/find-diacritical-mark.html: Copied from LayoutTests/fast/text/find-backwards.html.
* fast/text/find-soft-hyphen-expected.txt: Rebase result.
* fast/text/resources/test-find.js: Added.
(testFind):
* fast/text/script-tests/find-backwards.js: Moved function testFind() from here to
file fast/text/resources/test-find.js and modified it to take an additional argument to
toggle search case sensitivity.
* fast/text/script-tests/find-diacritical-mark.js: Added.
* fast/text/script-tests/find-soft-hyphen.js: Update test based on the new behavior of window.find().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Smarter algorithm to determine the backingstore rect
commit-queue@webkit.org [Wed, 12 Jun 2013 16:06:52 +0000 (16:06 +0000)]
[BlackBerry] Smarter algorithm to determine the backingstore rect
https://bugs.webkit.org/show_bug.cgi?id=117451

JIRA115644
https://jira.bbqnx.net/browse/BRWSR-7028

Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-06-12
Reviewed by Rob Buis.

So far, the backingstore tile geometry allocation was
pretty straightforward: We would start off from the
current viewport and append all available tiles into
the current scrolling direction from there.

This will usually work well enough, but has the downside
of discarding all the tiles in the opposite direction.
Also, tiles very close to the viewport will often get
discarded even if the user only scrolls very slowly.

This patch completely revamps the algorithm for
determining where the backingstore should be positioned.

The general idea is that we construct a "desired rect"
based on the viewport and inflate it into all four
directions according to the current scroll momentum.
This rectangle will be similarly large as a backingstore
tile geometry rectangle might be, by using the
approximate number of pixels that are available in the
given number of tiles.

The proportions for extending the rectangle from the
viewport are influenced by different factors, including
scroll momentum, viewport ratio, available space in the
overall contents rectangle, and natural bias for the
"down" direction.

In practice, this results in a backingstore that is
roughly evenly distributed around the viewport when no
movement is happening, and will gradually narrow down
and extend into the scroll direction at a higher momentum.

The final tile geometry is constructed by trying fit
the tiles into the desired rect in a way that maximizes
the area of its intersection. There are a few parameters
that can be tweaked, the ones in this patch seem to
handle most cases well enough to minimize checkerboarding.

As an additional bonus, a rectangle-based tiling strategy
can more easily be adopted for accelerated compositing,
which currently operates on a simpler algorithm that also
inflates the viewport but does not take scrolling into
account.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::expandedContentsSize):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::nonOverscrolled):
(BlackBerry::WebKit::BackingStorePrivate::enclosingTileRect):
(BlackBerry::WebKit::BackingStorePrivate::desiredBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::mergeDesiredBackingStoreRect):
(BlackBerry::WebKit::BackingStorePrivate::largestTileRectForDesiredRect):
(BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
* Api/BackingStore_p.h:
(BackingStorePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][CSS Regions] fast/regions/overflow-size-change-with-stacking-context.html fails
commit-queue@webkit.org [Wed, 12 Jun 2013 15:48:21 +0000 (15:48 +0000)]
[Qt][CSS Regions] fast/regions/overflow-size-change-with-stacking-context.html fails
https://bugs.webkit.org/show_bug.cgi?id=97199

Unreviewed, Qt Gardening.

Unskip test that is now passing on the bots.

Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-06-12

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSupport latest Web IDL indexed property getters
ch.dumez@sisa.samsung.com [Wed, 12 Jun 2013 14:41:19 +0000 (14:41 +0000)]
Support latest Web IDL indexed property getters
https://bugs.webkit.org/show_bug.cgi?id=117507

Reviewed by Kentaro Hara.

Support latest Web IDL indexed property getters:
http://www.w3.org/TR/WebIDL/#dfn-support-indexed-properties

Drop support for outdated [IndexedGetter] and [NumericIndexedGetter]
IDL extended attributes. Since the new getter format specifies the
return type, the bindings generator is now smart enough to know if
the indexed getter is numeric or not on its own.

Based on Blink r149564 by <kojih@chromium.org>.

No new tests, no behavior change.

* Modules/filesystem/EntryArray.idl:
* Modules/filesystem/EntryArraySync.idl:
* Modules/gamepad/GamepadList.idl:
* Modules/mediasource/SourceBufferList.idl:
* Modules/speech/SpeechGrammarList.idl:
* Modules/speech/SpeechRecognitionResult.idl:
* Modules/speech/SpeechRecognitionResultList.idl:
* bindings/scripts/CodeGenerator.pm:
(IsNumericType):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GetIndexedGetterFunction):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/TestEventTarget.idl:
* bindings/scripts/test/TestTypedArray.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSValueList.idl:
* css/MediaList.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSFilterValue.idl:
* css/WebKitCSSKeyframesRule.idl:
* css/WebKitCSSTransformValue.idl:
* dom/ClientRectList.idl:
* dom/DOMNamedFlowCollection.idl:
* dom/DOMStringList.idl:
* dom/DataTransferItemList.idl:
* dom/NamedNodeMap.idl:
* dom/NodeList.idl:
* dom/PropertyNodeList.idl:
* dom/TouchList.idl:
* fileapi/FileList.idl:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.idl:
* html/HTMLAllCollection.idl:
* html/HTMLCollection.idl:
* html/HTMLFormControlsCollection.idl:
* html/HTMLFormElement.idl:
* html/HTMLPropertiesCollection.idl:
* html/HTMLSelectElement.idl:
* html/RadioNodeList.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* html/track/AudioTrackList.idl:
* html/track/TextTrackCueList.idl:
* html/track/TextTrackList.idl:
* html/track/TextTrackRegionList.idl:
* html/track/VideoTrackList.idl:
* page/PerformanceEntryList.idl:
* page/SpeechInputResultList.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Coordinated Graphics] Remove unused headers in CoordinatedLayerTreeHostProxy
commit-queue@webkit.org [Wed, 12 Jun 2013 14:37:28 +0000 (14:37 +0000)]
[Coordinated Graphics] Remove unused headers in CoordinatedLayerTreeHostProxy
https://bugs.webkit.org/show_bug.cgi?id=117539

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-06-12
Reviewed by Noam Rosenthal.

* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening. Unskipping passing tests.
kseo@webkit.org [Wed, 12 Jun 2013 13:50:30 +0000 (13:50 +0000)]
Unreviewed gardening. Unskipping passing tests.

* platform/gtk-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] MiniBrowser to automatically download "non-showable" documents when left click...
commit-queue@webkit.org [Wed, 12 Jun 2013 13:39:19 +0000 (13:39 +0000)]
[GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
https://bugs.webkit.org/show_bug.cgi?id=117533

Patch by Andres Gomez <agomez@igalia.com> on 2013-06-12
Reviewed by Carlos Garcia Campos.

MiniBrowser now starts automatically the download of the documents
that cannot be shown just by WebKit itself on link left clicking.

* MiniBrowser/gtk/BrowserWindow.c:
(webViewDecidePolicy): handled the
WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename [CallWith] to [ConstructorCallWith] for IDL interfaces
ch.dumez@sisa.samsung.com [Wed, 12 Jun 2013 12:25:41 +0000 (12:25 +0000)]
Rename [CallWith] to [ConstructorCallWith] for IDL interfaces
https://bugs.webkit.org/show_bug.cgi?id=117531

Reviewed by Kentaro Hara.

Rename [CallWith] to [ConstructorCallWith] for IDL interfaces as the
meaning is slightly different when [CallWith] is used for IDL operations
or attributes. This improves IDL readability a bit and makes it more
directly understandable.

Also removed [ConstructorCallWith] statements from interfaces with custom
constructors or no constructor, as this does not have any effect.

No new tests, no behavior change.

* Modules/filesystem/FileWriter.idl:
* Modules/mediasource/MediaSource.idl:
* Modules/mediasource/SourceBufferList.idl:
* Modules/mediastream/MediaStream.idl:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/notifications/Notification.idl:
* Modules/speech/SpeechRecognition.idl:
* Modules/speech/SpeechSynthesisUtterance.idl:
* Modules/webaudio/OfflineAudioContext.idl:
* Modules/websockets/WebSocket.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/TestInterface.idl:
* dom/MessageChannel.idl:
* fileapi/FileReader.idl:
* html/MediaController.idl:
* html/track/TextTrackCue.idl:
* page/EventSource.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:
* xml/XMLHttpRequest.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151495 268f45cc-cd09-0410-ab3c-d52691b4dbfc