WebKit-https.git
12 years agoFixes a regression where the Image and Font preview views do not
timothy@apple.com [Wed, 28 May 2008 02:45:01 +0000 (02:45 +0000)]
Fixes a regression where the Image and Font preview views do not
size correctly.

<rdar://problem/5966723> REGRESSION (r33991): Image and font previews
are shrunken and can't be made larger (19281)

Reviewed by Adam Roben.

* page/inspector/FontView.js: Adjust the font size based only on the
container width minus padding.
* page/inspector/inspector.css: Updated styles for the image and
font views.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
andersca@apple.com [Wed, 28 May 2008 00:44:40 +0000 (00:44 +0000)]
JavaScriptCore:

2008-05-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff and Maciej.

        <rdar://problem/5806428>
        https://bugs.webkit.org/show_bug.cgi?id=17925
        Crash in KJS::JSObject::put after setting this.__proto__

        Set slotIsWriteable to false for __proto__, we want setting __proto__ to go through JSObject::put instead.

        * kjs/object.h:
        (KJS::JSObject::getOwnPropertySlotForWrite):

LayoutTests:

2008-05-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff and Maciej.

        <rdar://problem/5806428>
        https://bugs.webkit.org/show_bug.cgi?id=17925
        Crash in KJS::JSObject::put after setting this.__proto__

        * fast/js/resources/this-non-object-proto.js: Added.
        * fast/js/this-non-object-proto-expected.txt: Added.
        * fast/js/this-non-object-proto.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix typo in comment.
ddkilzer@apple.com [Tue, 27 May 2008 23:38:36 +0000 (23:38 +0000)]
Fix typo in comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Bug 19276: XHR resources are classified as "Other" until Inspector is...
aroben@apple.com [Tue, 27 May 2008 23:33:08 +0000 (23:33 +0000)]
    Fix Bug 19276: XHR resources are classified as "Other" until Inspector is closed and reopened

        <https://bugs.webkit.org/show_bug.cgi?id=19276>
        <rdar://problem/5965742>

        Reviewed by Tim Hatcher.

        * page/InspectorController.cpp:
        (WebCore::InspectorController::updateScriptResourceResponse): Moved
        code that updates the resource's type from here...
        (WebCore::InspectorController::updateScriptResourceType): ...to here.
        (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
        Call updateScriptResourceType now that we know this resource was
        retrieved via an XHR.
        * page/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out r34156, which was accidentally checked in
aroben@apple.com [Tue, 27 May 2008 23:25:09 +0000 (23:25 +0000)]
Roll out r34156, which was accidentally checked in

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoadd printInstruction
aroben@apple.com [Tue, 27 May 2008 23:22:52 +0000 (23:22 +0000)]
add printInstruction

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoves a redundant call to InspectorController::stopDebugging().
timothy@apple.com [Tue, 27 May 2008 21:50:02 +0000 (21:50 +0000)]
Removes a redundant call to InspectorController::stopDebugging().

Rubber-stamped by Adam Roben.

* page/InspectorController.cpp:
(WebCore::InspectorController::showWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes a bug where unplugging the monitor from a video card and
timothy@apple.com [Tue, 27 May 2008 20:44:16 +0000 (20:44 +0000)]
Fixes a bug where unplugging the monitor from a video card and
moving it to another video card would no longer show OpenGL plugins
until you relaunched Safari.

<rdar://problem/5790983> Add AllowOfflineDisplays pixel format
attribute to OpenGL contexts

Reviewed by Kevin Decker.

* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added
AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds.
(-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-27 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Tue, 27 May 2008 18:46:57 +0000 (18:46 +0000)]
2008-05-27  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        - Added and updated some manual test for the profiler.

        * manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html:
        * manual-tests/inspector/profiler-test-apply.html:
        * manual-tests/inspector/profiler-test-call.html:
        * manual-tests/inspector/profiler-test-deep-recursion.html: Added.
        * manual-tests/inspector/profiler-test-simple-event-call.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Update the sample app after wxWebFrame->wxWebBrowserShell rename.
kevino@webkit.org [Tue, 27 May 2008 17:49:31 +0000 (17:49 +0000)]
wx build fix. Update the sample app after wxWebFrame->wxWebBrowserShell rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Accidently left a couple fixes out of the previous commit.
kevino@webkit.org [Tue, 27 May 2008 16:29:07 +0000 (16:29 +0000)]
wx build fix. Accidently left a couple fixes out of the previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fixes after introduction of SquirrelFish and other updates.
kevino@webkit.org [Tue, 27 May 2008 16:12:45 +0000 (16:12 +0000)]
wx build fixes after introduction of SquirrelFish and other updates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-27 Darin Adler <darin@apple.com>
darin@apple.com [Tue, 27 May 2008 14:43:36 +0000 (14:43 +0000)]
2008-05-27  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        - https://bugs.webkit.org/show_bug.cgi?id=19180
          speed up SunSpider by optimizing immediate number cases

        Add immediate number cases for the &, |, and ^ operators.
        Makes standalone SunSpider 1.010x faster.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute): Add areBothImmediateNumbers special cases
        for the &, |, and ^ operators.

        * kjs/JSImmediate.h:
        (KJS::JSImmediate::xorImmediateNumbers): Added.
        (KJS::JSImmediate::orImmediateNumbers): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-27 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Tue, 27 May 2008 10:31:02 +0000 (10:31 +0000)]
2008-05-27  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Fix linking error (missing gdi32 and user32 libraries).

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-27 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Tue, 27 May 2008 09:49:36 +0000 (09:49 +0000)]
2008-05-27  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Fix web inspector does not returns its state properly after its window is minimized.

        As hinted by Holger, InspectorClientView::hideEvent is not needed.
        This fixes bug https://bugs.webkit.org/show_bug.cgi?id=18967

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-27 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Tue, 27 May 2008 09:02:16 +0000 (09:02 +0000)]
2008-05-27  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Update the WebKit.qrc so that Web Inspector is functional again.

        * page/inspector/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-26 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Tue, 27 May 2008 05:04:48 +0000 (05:04 +0000)]
2008-05-26  Stephanie Lewis  <slewis@apple.com>

        Windows build fix.

        * kjs/testkjs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-26 Alp Toker <alp@nuanti.com>
alp@webkit.org [Tue, 27 May 2008 02:48:14 +0000 (02:48 +0000)]
2008-05-26  Alp Toker  <alp@nuanti.com>

        Reviewed by Anders.

        http://bugs.webkit.org/show_bug.cgi?id=16495
        [GTK] Accessibility support with ATK/AT-SPI

        Implement basic action, text and editable text accessibility.

        Provide utility functions to simplify const string return and casting
        and add some more stubs.

        It's now possible to navigate and manipulate forms and text using
        assistive technologies.

        * page/gtk/AccessibilityObjectWrapperAtk.cpp:
        (returnString):
        (core):
        * platform/gtk/LocalizedStringsGtk.cpp:
        (WebCore::AXButtonActionVerb):
        (WebCore::AXRadioButtonActionVerb):
        (WebCore::AXTextFieldActionVerb):
        (WebCore::AXCheckedCheckBoxActionVerb):
        (WebCore::AXUncheckedCheckBoxActionVerb):
        (WebCore::AXLinkActionVerb):
        (WebCore::imageTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
mjs@apple.com [Tue, 27 May 2008 02:10:23 +0000 (02:10 +0000)]
JavaScriptCore:

2008-05-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders.

        - make addStaticGlobals protected instead of private so subclasses can use it

        * JavaScriptCore.exp:
        * kjs/JSGlobalObject.h:

WebCore:

2008-05-25  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders.

        - bind the window's "document" and "window" properties to static slots
        1.7% speedup on Acid3 test 26

        Only the "document" part matters for Acid3, but since I was doing
        this anyway, "window" also seemed like a good one to optimize.

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::JSDOMWindowBase): Allocate variable
        slots for document and window; but just put null in the document
        slot for now.
        (WebCore::JSDOMWindowBase::updateDocument): Fill in the document
        slot.
        (WebCore::JSDOMWindowBase::~JSDOMWindowBase): Make our shell stop
        tracking us.
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowShell.cpp:
        (WebCore::JSDOMWindowShell::JSDOMWindowShell): Allocate HashSet
        for our still-not-dead inner windows.
        (WebCore::JSDOMWindowShell::updateDocument): Update all our
        inner windows ever (to make sure the update to the document
        property shows up everywhere).
        * bindings/js/JSDOMWindowShell.h:
        (WebCore::JSDOMWindowShell::setWindow): Update our hash.
        (WebCore::JSDOMWindowShell::clearFormerWindow): Ditto.
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::toJS): Don't set self as a property map property of
        the window, this is no longer necessary.
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::initScript): Update document for the
        newly created window.
        * bindings/js/kjs_proxy.h:
        * page/Frame.cpp:
        (WebCore::Frame::setDocument): If the document is not null,
        update our window.

LayoutTests:

2008-05-26  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders.

        - update test result for document/window being allocated to var slots

        * http/tests/security/cross-frame-access-put-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-26 James Ren <jamesjren@gmail.com>
collinj@webkit.org [Mon, 26 May 2008 23:49:08 +0000 (23:49 +0000)]
2008-05-26  James Ren  <jamesjren@gmail.com>

        Reviewed by Sam Weinig, landed by Collin Jackson.

        http://bugs.webkit.org/show_bug.cgi?id=19163

        Modified some http/security layout tests to allow them to run in Firefox.

        * http/tests/security/aboutBlank/xss-DENIED-set-opener.html:
        * http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html:
        * http/tests/security/resources/localhost-accesssor.html:
          Added a workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=434912

        * http/tests/security/resources/cross-frame-access.js:
          Changed shouldBe to also gracefully handle exceptions

        * http/tests/security/resources/foreign-domain-iframe-for-selection-test.html:
          Added feature detection for setBaseAndExtent and selectAllChildren

        * http/tests/security/cross-frame-access-enumeration-expected.txt:
        * http/tests/security/cross-frame-access-enumeration.html:
          Fixed typo (missing '.html')

        * http/tests/security/cross-frame-access-call-expected.txt:
        * http/tests/security/cross-frame-access-call.html:
        * http/tests/security/cross-frame-access-first-time.html:
        * http/tests/security/cross-frame-access-put.html:
        * http/tests/security/cross-frame-access-selection.html:
          Caught exceptions that Firefox throws, to allow the test to run to completion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 26 May 2008 21:13:03 +0000 (21:13 +0000)]
2008-05-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        This patch does two things:

        * It adds a toJSNewlyCreated function for creating JS wrappers for nodes where we know
        that the node doesn't have a wrapper. This avoids a hash lookup.

        * It adds toJSNewlyCreated methods for JSElement and JSText.

        All in all this is a 4.3% speedup on Acid 3 test 26.

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSElementCustom.cpp:
        (WebCore::toJSNewlyCreated):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::createWrapper):
        (WebCore::toJSNewlyCreated):
        (WebCore::toJS):
        * bindings/js/JSTextCustom.cpp: Added.
        (WebCore::toJSNewlyCreated):
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Document.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed date of ChangeLog entry.
darin@apple.com [Mon, 26 May 2008 20:53:32 +0000 (20:53 +0000)]
Fixed date of ChangeLog entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 26 May 2008 20:41:08 +0000 (20:41 +0000)]
2008-05-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Inline the getOwnPropertySlot for JSNode, JSEventTargetNode, JSElement,
        and JSDocument for a 1-2% speedup on Acide 3 test 26.

        * bindings/js/JSEventTargetNode.cpp:
        * bindings/js/JSEventTargetNode.h:
        (WebCore::JSEventTargetNode::getOwnPropertySlot):
        (WebCore::JSEventTargetNode::getValueProperty):
        (WebCore::JSEventTargetNode::put):
        (WebCore::JSEventTargetNode::putValueProperty):
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Document.idl:
        * dom/Element.idl:
        * dom/Node.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-25 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 26 May 2008 20:07:40 +0000 (20:07 +0000)]
2008-05-25  Darin Adler  <darin@apple.com>

        Reviewed by Maciej.

        - https://bugs.webkit.org/show_bug.cgi?id=19239

        Removed code that would only useful if if there was any way to create an Entity
        node or if we populated EntityReference nodes. It's likely that we'll remove
        these node types entirely in some future version of WebKit, depending in part
        on what happens with these in HTML 5.

        1.8% speedup of Acid3 test 26.

        The only read-only nodes we ever create are EntityReference nodes.
        These are only created by explicit calls to the Document.createEntityReference
        function. Since the created nodes are read-only, there can be no children of
        these nodes, so no other types of nodes can be read-only despite the rule that
        makes descendants of Entity and EntityReference nodes read-only.

        * bindings/objc/DOM.mm: Removed unneeded include.

        * dom/Attr.cpp:
        (WebCore::Attr::setValue): Removed unnecessary isReadOnlyNode check.
        (WebCore::Attr::setNodeValue): Ditto.
        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setData): Removed unnecessary isReadOnlyNode check.
        (WebCore::CharacterData::substringData): Don't initialize the ec variable before
        calling checkCharDataOperation, since that function already does it.
        (WebCore::CharacterData::appendData): Removed unnecessary isReadOnlyNode check.
        (WebCore::CharacterData::insertData): Don't initialize ec.
        (WebCore::CharacterData::deleteData): Ditto.
        (WebCore::CharacterData::replaceData): Ditto.
        (WebCore::CharacterData::setNodeValue): Removed now-misleading comment.
        (WebCore::CharacterData::checkCharDataOperation): Removed unnecessary
        isReadOnlyNode check.
        * dom/CharacterData.h: Made checkCharDataOperation private and non-virtual
        since it's never used or defined in any other class.

        * dom/Element.cpp:
        (WebCore::Element::setAttribute): Removed unneeded isReadOnlyNode check.

        * dom/Entity.cpp: Removed the entire contents of this file.

        * dom/Entity.h: Replaced the class with a stub -- just enough to keep the
        public bindings (JavaScript and Objective-C compiling), but the class is
        abstract and can't be instantianted.

        * dom/EntityReference.cpp: Removed unused constructor.
        (WebCore::EntityReference::cloneNode): Removed unneeded code and comments
        to clone nonexistent child nodes.
        * dom/EntityReference.h: Removed unused constructor and unnecessary override
        of childTypeAllowed, since no children are allowed at all.

        * dom/NamedAttrMap.cpp:
        (WebCore::NamedAttrMap::setNamedItem): Removed unneeded isReadOnlyNode check.
        (WebCore::NamedAttrMap::removeNamedItem): Ditto.
        * dom/NamedAttrMap.h: Removed isReadOnlyNode function.

        * dom/Node.cpp: Removed the old isReadOnlyNode function. It made lots of
        virtual nodeType function calls.
        * dom/Node.h:
        (WebCore::Node::isReadOnlyNode): Replaced the old virtual isReadOnlyNode
        function with a new simple non-virtual one.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::setData): Removed unneeded isReadOnlyNode
        check.

        * dom/Text.cpp:
        (WebCore::Text::splitText): Removed unneeded isReadOnlyNode check.
        (WebCore::Text::replaceWholeText): Removed unnecessary isReadOnlyNode assertion.
        There is no reason for this function to go out of its way to mention the
        read-only node issue when none of the other DOM mutation functions do.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 26 May 2008 19:38:14 +0000 (19:38 +0000)]
2008-05-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam.

        Cleanup SecurityOrigin::canAccess.  Removed comment referring to an
        old version of the code.  Removed some useless code.

        * platform/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::canAccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoChangeLog fixup: 'prevent subtle errors' is a little more reassuring than 'lead to...
ggaren@apple.com [Mon, 26 May 2008 18:57:17 +0000 (18:57 +0000)]
ChangeLog fixup: 'prevent subtle errors' is a little more reassuring than 'lead to subtle errors'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-26 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 26 May 2008 18:50:55 +0000 (18:50 +0000)]
2008-05-26  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Fixed <rdar://problem/5960859> After an eval of a non-string or a syntax
        error, all profile stack frames are incorrect

        SunSpider reports a .3% speedup, possibly because eval of a string is a
        little more efficient now.

        * VM/Machine.cpp:
        (KJS::callEval): Make sure to call didExecute when returning early. I
        simplified this function to remove one early return, making the job
        of adding special code to early returns easier.

        (KJS::Machine::execute): Use the new function ExecState when notifying
        the profiler. (This doesn't change behavior now, but it  might lead to
        subtle errors in the future.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-26 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 26 May 2008 18:43:19 +0000 (18:43 +0000)]
2008-05-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam.

        Add a name to the source frame.

        * fast/frames/viewsource-empty-attribute-value-expected.txt:
        * fast/frames/viewsource-empty-attribute-value.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-26 Gwenole Beauchesne <gbeauchesne@splitted-desktop.org>
jmalonzo@webkit.org [Mon, 26 May 2008 12:45:15 +0000 (12:45 +0000)]
2008-05-26  Gwenole Beauchesne  <gbeauchesne@splitted-desktop.org>

        Reviewed by Alp Toker.

        * platform/gtk/LocalizedStringsGtk.cpp:
        (WebCore::contextMenuItemTagSelectAll): Fix GTK+ version check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
hausmann@webkit.org [Mon, 26 May 2008 12:29:11 +0000 (12:29 +0000)]
JavaScriptCore:

2008-05-23  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Fixed toLower and toUpper implementations to allow being called
        with a null result pointer and resultLength, to determine the
        number of characters needed for the case conversion.

LayoutTests:

008-05-23  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Added a comment to the skipping of fast/css/case-transform.html that
        mentions the reason of failure being a Qt bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-26 Tor Arne Vestbø <tavestbo@trolltech.com>
hausmann@webkit.org [Mon, 26 May 2008 11:39:42 +0000 (11:39 +0000)]
2008-05-26  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Update QtWebkit layout-tests in accordance with bug 18976

        https://bugs.webkit.org/show_bug.cgi?id=18976

        The test fast/xsl/xslt-text.xml is on our skipped list due to
        missing XSLT support in Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseN...
mrowe@apple.com [Mon, 26 May 2008 02:29:58 +0000 (02:29 +0000)]
<rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined

Follow-up for r33052.  _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins
need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit.

Reviewed by Darin Adler.

* WebView/WebFrame.mm:
(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
* WebView/WebFrameInternal.h:
* WebView/WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/3582905> elements on separate pages need to be distinct
cfleizach@apple.com [Sun, 25 May 2008 23:55:41 +0000 (23:55 +0000)]
<rdar://problem/3582905> elements on separate pages need to be distinct

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-25 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 25 May 2008 23:23:25 +0000 (23:23 +0000)]
2008-05-25  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin.

        - don't repaint nodes that are removed before layout
        4.3% speedup on Acid3 test 26

        Mitz points out the new flag can also be used to optimize other
        cases of needless repaint such as
        <https://bugs.webkit.org/show_bug.cgi?id=15129>.

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::removeChildNode): If the child has never had a layout,
        don't bother to repaint it, since there's nothing to dirty.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::RenderObject): Initialize m_everHadLayout to false.
        (WebCore::RenderObject::setNeedsLayout): Set m_everHadLayout to true if we
        are being marked as not needing layout.
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Sun, 25 May 2008 20:13:52 +0000 (20:13 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19086
          <rdar://problem/5962254> REGRESSION (r28519-r28535): Caret doesn't paint past the right edge of a block

        Test: fast/repaint/caret-outside-block.html

        * editing/SelectionController.cpp:
        (WebCore::repaintRectForCaret): Restored this function which was removed
        in r28523, but changed it to inflate only the width.
        (WebCore::SelectionController::caretRepaintRect): Changed back to use
        repaintRectForCaret().
        (WebCore::SelectionController::recomputeCaretRect): Ditto.

LayoutTests:

        Reviewed by Darin Adler.

        - pixel test for https://bugs.webkit.org/show_bug.cgi?id=19086
          <rdar://problem/5962254> REGRESSION (r28519-r28535): Caret doesn't paint past the right edge of a block

        * fast/repaint/caret-outside-block.html: Added.
        * platform/mac/fast/repaint/caret-outside-block-expected.checksum: Added.
        * platform/mac/fast/repaint/caret-outside-block-expected.png: Added.
        * platform/mac/fast/repaint/caret-outside-block-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-25 Marco Barisione <marco.barisione@collabora.co.uk>
alp@webkit.org [Sun, 25 May 2008 14:36:53 +0000 (14:36 +0000)]
2008-05-25  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18940
        [CURL] Allow \n as line terminator for headers

        The line terminator for message-header fields should be CRLF. However,
        it is recommended to recognise as a line terminator also a single LF.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::headerCallback): Allow headers to be terminated by "\n" and
        not just by "\r\n".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-25 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 25 May 2008 14:14:19 +0000 (14:14 +0000)]
2008-05-25  Alp Toker  <alp@nuanti.com>

        Reviewed by Niko.

        Drop WebView focus when the widget is focused out.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Alexey.
rwlbuis@webkit.org [Sun, 25 May 2008 11:30:05 +0000 (11:30 +0000)]
    Reviewed by Alexey.

        Fix the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-25 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 25 May 2008 11:15:15 +0000 (11:15 +0000)]
2008-05-25  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=19142
        [Gtk] Remove build options --svg-experimental and --cross-document-messaging

        * configure.ac
        * WebCore/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago RS=Oliver
rwlbuis@webkit.org [Sun, 25 May 2008 10:41:23 +0000 (10:41 +0000)]
    RS=Oliver

        Fix SVG test results for tiger buildbot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-25 Sriram Neelakandan <sriram.neelakandan@gmail.com>
alp@webkit.org [Sun, 25 May 2008 09:55:28 +0000 (09:55 +0000)]
2008-05-25  Sriram Neelakandan  <sriram.neelakandan@gmail.com>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18935
        [Gtk] Plugin Load crashes with NP_FULL mode

        Fix crash due to uninitialized variable.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::FrameLoaderClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix leopard results following changes to SVG path dumping.
oliver@apple.com [Sun, 25 May 2008 07:46:25 +0000 (07:46 +0000)]
Fix leopard results following changes to SVG path dumping.

RS=Alexey

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixing a typo in the previous commit made as a last minute change.
ap@webkit.org [Sun, 25 May 2008 07:35:57 +0000 (07:35 +0000)]
    Fixing a typo in the previous commit made as a last minute change.

        * kjs/regexp_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Sun, 25 May 2008 07:15:42 +0000 (07:15 +0000)]
    Reviewed by Darin.

        Changed regular expression matching result array to be lazily filled, because many callers
        only care about it being non-null.

        2% improvement on Acid3 test 26.

        * kjs/array_instance.cpp: Added a void* member to ArrayStorage for ArrayInstance subclasses
        to use.
        * kjs/array_instance.h:
        (KJS::ArrayInstance::lazyCreationData):
        (KJS::ArrayInstance::setLazyCreationData):
        Added methods to access it from subclasses.

        * kjs/regexp_object.cpp:
        (KJS::RegExpMatchesArray::RegExpMatchesArray):
        (KJS::RegExpMatchesArray::getOwnPropertySlot):
        (KJS::RegExpMatchesArray::put):
        (KJS::RegExpMatchesArray::deleteProperty):
        (KJS::RegExpMatchesArray::getPropertyNames):
        (KJS::RegExpMatchesArray::fillArrayInstanceIfNeeded):
        (KJS::RegExpMatchesArray::~RegExpMatchesArray):
        (KJS::RegExpObjectImp::arrayOfMatches):
        RegExpMatchesArray is a subclass of ArrayInstance that isn't filled until
        accessed for the first time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric.
rwlbuis@webkit.org [Sun, 25 May 2008 07:11:04 +0000 (07:11 +0000)]
    Reviewed by Eric.

        https://bugs.webkit.org/show_bug.cgi?id=18927
        Unify path data debug output

        Implement unified path data output for Mac svg tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-24 Andreia Gaita <shana@isninja.com>
alp@webkit.org [Sun, 25 May 2008 05:25:11 +0000 (05:25 +0000)]
2008-05-24  Andreia Gaita  <shana@isninja.com>

        Reviewed by Alp Toker.

        cygwin-downloader.py fixes.

        Remove two non-working mirrors. Add a check for missing dependency
        packages to avoid bailing out on an inconsistent Cygwin package list.

        * CygwinDownloader/cygwin-downloader.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes a huge leak with the Inspector where it was protecting
timothy@apple.com [Sun, 25 May 2008 04:47:46 +0000 (04:47 +0000)]
Fixes a huge leak with the Inspector where it was protecting
a large object that was not being unprotected.

<rdar://problem/5961999> Inspector protects a large JavaScript
object and never unprotects it (large leak)

Reviewed by Darin Adler.

* page/InspectorController.cpp:
(WebCore::InspectorController::inspectedPageDestroyed): Call close()
and removed a call to stopDebugging() and moved it to close().
(WebCore::InspectorController::close): Add stopDebugging() and
stopUserInitiatedProfiling(). Removed an ASSERT and added an
if statement before calling JSValueUnprotect. We don't always have
a m_scriptContext and m_scriptObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIgnore generated bytecode.html file.
darin@apple.com [Sun, 25 May 2008 04:24:00 +0000 (04:24 +0000)]
Ignore generated bytecode.html file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-24 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 25 May 2008 04:19:22 +0000 (04:19 +0000)]
2008-05-24  Alp Toker  <alp@nuanti.com>

        GTK+/Win32 build fixes. Link against Windows ICU without using
        icu-config since it's not available on that platform.

        Link against Ws2_32 when the curl http backend is chosen since we
        use select() directly.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-24 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 25 May 2008 03:45:50 +0000 (03:45 +0000)]
2008-05-24  Alp Toker  <alp@nuanti.com>

        Win32/gcc3 build fix in Pango font backend. UChar needs to be
        explicitly cast to gunichar2.

        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::utf16_to_utf8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-24 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 25 May 2008 01:58:00 +0000 (01:58 +0000)]
2008-05-24  Alp Toker  <alp@nuanti.com>

        Win32/gcc build fix. Remove MSVC assumption.

        * wtf/TCSpinLock.h:
        (TCMalloc_SlowLock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-24 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 25 May 2008 01:51:07 +0000 (01:51 +0000)]
2008-05-24  Alp Toker  <alp@nuanti.com>

        https://bugs.webkit.org/show_bug.cgi?id=18825
        webkitgtk fails to build from source: "Database Tracker" has not been declared

        GTK+ fix for building without database support.
        exceededDatabaseQuota() still needs to be present, just a no-op.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::exceededDatabaseQuota):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes a crash where a new Inspector would get an old
timothy@apple.com [Sun, 25 May 2008 01:01:35 +0000 (01:01 +0000)]
Fixes a crash where a new Inspector would get an old
JSInspectedObjectWrapper for a user agent CSSStyleDeclaration.
Since these style objects shared between pages, the wrapper cache
would have a wrapper for the object still. But the wrapper was
for a previous global object and with a disconnected frame. This
fixes the wrapper cache so wrappers are remembered per global object
and the object they are wrapping.

<rdar://problem/5958567> repro crash in WebCore::Frame::keepAlive()
opening inspector window after closing it

Reviewed by Darin Adler.

* bindings/js/JSInspectedObjectWrapper.cpp:
(WebCore::wrappers): Return a GlobalObjectWrapperMap reference.
(WebCore::JSInspectedObjectWrapper::wrap): Find the WrapperMap
by the dynamicGlobalObject then find the wrapper for unwrappedObject.
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper): Changes
how the wrapper is added to the wrapper cache.
(WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper): Changes
how the wrapper is removed from the wrapper cache.
* bindings/js/JSQuarantinedObjectWrapper.h:
(WebCore::JSQuarantinedObjectWrapper:unwrappedGlobalObject): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
ap@webkit.org [Sat, 24 May 2008 21:12:12 +0000 (21:12 +0000)]
    Reviewed by Maciej.

        Optimize Node::textContent() to avoid O(n^2) string appending behavior.

        1.6% speedup at Acid3 test 26.

        * WebCore.xcodeproj/project.pbxproj:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCoreSources.bkl:
        * WebCore.vcproj/WebCore.vcproj:
        * platform/text/StringBuilder.cpp: Added.
        (WebCore::StringBuilder::append):
        (WebCore::StringBuilder::toString):
        * platform/text/StringBuilder.h: Added.
        (WebCore::StringBuilder::StringBuilder):
        (WebCore::StringBuilder::isNull):
        Added a simple class to efficiently build a string by appending. Potentially, it can be
        extended to be more like java.lang.StringBuilder, but we don't need that much flexibility now.

        * dom/Node.cpp:
        (WebCore::Node::appendTextContent):
        (WebCore::Node::textContent):
        * dom/Node.h:
        Changed to use StringBuilder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-24 Julien Chaffraix <jchaffraix@webkit.org>
jchaffraix@webkit.org [Sat, 24 May 2008 13:26:11 +0000 (13:26 +0000)]
2008-05-24  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Eric.

        Bug 9191: JS*ElementWrapperFactory should be autogenerated
        https://bugs.webkit.org/show_bug.cgi?id=9191

        This is a first pass for generation of JS*ElementWrapperFactory, in the long term we should move the make_names.pl
        intelligence to the *.in files.

        - Add a new parameter to make_names.pl --wrapperFactory which works like --wrapper but generates the
        JS*ElementWrapperFactory files.

        - Removed JS*ElementWrapperFactory files in WebCore/bindings/js, replaced by the generated ones.

        - Updated the build systems to account for the previous changes.

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSHTMLElementWrapperFactory.cpp: Removed.
        * bindings/js/JSHTMLElementWrapperFactory.h: Removed.
        * bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
        * bindings/js/JSSVGElementWrapperFactory.h: Removed.
        * dom/make_names.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed ChangeLog.
ap@webkit.org [Sat, 24 May 2008 12:48:37 +0000 (12:48 +0000)]
Fixed ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped, tweaked and landed by Alexey.
ap@webkit.org [Sat, 24 May 2008 12:43:02 +0000 (12:43 +0000)]
    Rubber-stamped, tweaked and landed by Alexey.

        Build fix for gcc 4.3. Added missing standard includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes a bug where a timer would keep firing after the Inspector
timothy@apple.com [Sat, 24 May 2008 06:34:40 +0000 (06:34 +0000)]
Fixes a bug where a timer would keep firing after the Inspector
was closed. It turns out this timer wasn't needed anymore now
that we can add an event listener to the inspected page and have
it get called in the Inspector's context.

https://bugs.webkit.org/show_bug.cgi?id=18577

Reviewed by Mark Rowe.

* page/inspector/ElementsPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 Anthony Ricaud <rik24d@gmail.com>
pewtermoose@webkit.org [Sat, 24 May 2008 03:52:09 +0000 (03:52 +0000)]
2008-05-23  Anthony Ricaud  <rik24d@gmail.com>

        Changes the largerResourcesButton tooltip to toggle.

        https://bugs.webkit.org/show_bug.cgi?id=19210

        Reviewed by Tim Hatcher.

        * WebCore/English.lproj/localizedStrings.js: New string and clean an
        double string "Dock to main window."
        * WebCore/page/inspector/ResourcesPanel.js: Toggle the tooltip and
        change the default tooltip

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
mrowe@apple.com [Sat, 24 May 2008 02:47:26 +0000 (02:47 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-24 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 24 May 2008 01:33:26 +0000 (01:33 +0000)]
2008-05-24  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Darin Adler.

        Remove useQmake usage. QMake build doesn't support Gtk port
        anymore.

        Also fix 2 occurences of "Web Kit". Should be WebKit.

        * Scripts/build-webkit:
        * Scripts/run-javascriptcore-tests:
        * Scripts/run-launcher:
        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCheck Paste, instead of checking Copy twice.
justin.garcia@apple.com [Sat, 24 May 2008 00:56:46 +0000 (00:56 +0000)]
Check Paste, instead of checking Copy twice.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justin.garcia@apple.com [Sat, 24 May 2008 00:29:00 +0000 (00:29 +0000)]
WebCore:

2008-05-23  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <rdar://problem/5939887> REGRESSION: With no selection, copy does not fire oncopy handler (affects CIFilterBrowser widget)

        Execute cut, copy and paste if they are invoked explicitly, via execCommand or -[WebView copy:], even
        if they are disabled.  This will fire oncopy, oncut and onpaste, but won't perform any other work, like
        writing to the pasteboard during cut/copy or deleting the selection during cut/paste.  This matches FF3,
        which actually goes further and fires oncopy on any Command-C.

        * editing/EditorCommand.cpp:
        (WebCore::CommandEntry::):
        (WebCore::Editor::Command::execute):

LayoutTests:

2008-05-23  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin.

        <rdar://problem/5939887> REGRESSION: With no selection, copy does not fire oncopy handler (affects CIFilterBrowser widget)

        * editing/execCommand/5939887-expected.txt: Added.
        * editing/execCommand/5939887.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdds a percentage toggle button the profile view status bar that
timothy@apple.com [Fri, 23 May 2008 23:51:47 +0000 (23:51 +0000)]
Adds a percentage toggle button the profile view status bar that
changes the time columns between absolute and percents.

https://bugs.webkit.org/show_bug.cgi?id=19224

Reviewed by Kevin McCullough.

* English.lproj/localizedStrings.js: New strings.
* page/inspector/Images/percentButtons.png: Added.
* page/inspector/ProfileView.js: Make the button and add it to the
status bar. Make clicking toggle the showAsPercent* properties.
* page/inspector/inspector.css: New styles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 23 May 2008 23:44:40 +0000 (23:44 +0000)]
2008-05-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        <rdar://problem/5959886> REGRESSION: Assertion failure in JSImmediate::toString when loading GMail (19217)

        Change List to store a JSValue*** pointer + an offset instead of a JSValue** pointer to protect against the case where
        a register file changes while a list object points to its buffer.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):
        * kjs/JSActivation.cpp:
        (KJS::JSActivation::createArgumentsObject):
        * kjs/list.cpp:
        (KJS::List::getSlice):
        * kjs/list.h:
        (KJS::List::List):
        (KJS::List::at):
        (KJS::List::append):
        (KJS::List::begin):
        (KJS::List::end):
        (KJS::List::buffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 William Siegrist <wsiegrist@apple.com>
mrowe@apple.com [Fri, 23 May 2008 23:41:29 +0000 (23:41 +0000)]
2008-05-23  William Siegrist  <wsiegrist@apple.com>

        Reviewed by Mark Rowe

        Rename duplicated "notice" id to "terms".

        * css/main.css:
        * nav.inc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 23 May 2008 23:37:32 +0000 (23:37 +0000)]
2008-05-23  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        LayoutTests that send an OPTIONS request don't work on Tiger or Window due
        to a bug in Apache 1.3

        * platform/mac-tiger/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 23 May 2008 23:07:19 +0000 (23:07 +0000)]
2008-05-23  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Sam.

        <rdar://problem/5960012> JSProfiler: Stack overflow if recursion is
        too deep.
        -Use a simple depth limit to restrict too deep of recursion.

        * profiler/Profile.cpp:
        (KJS::Profile::willExecute):
        (KJS::Profile::didExecute):
        * profiler/Profile.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoved terrible lie from ChangeLog.
ggaren@apple.com [Fri, 23 May 2008 21:30:05 +0000 (21:30 +0000)]
Removed terrible lie from ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 23 May 2008 21:28:31 +0000 (21:28 +0000)]
2008-05-23  Geoffrey Garen  <ggaren@apple.com>

        Rolling back in r34085, with performance resolved.

        Apparently, passing the eval function to callEval gave GCC a hernia.

        Reviewed by Darin Adler, Kevin McCullough, and Oliver Hunt.

        Fixed <rdar://problem/5959447> Crashes and incorrect reporting in the
        JavaScript profiler

        * VM/Machine.cpp:
        (KJS::callEval): Made this profiler hooks slightly faster by passing in
        the eval function.

        (KJS::Machine::unwindCallFrame): Fixed incorrect reporting / a crash
        when unwinding from inside eval and/or program code: detect the
        difference, and do the right thing. Also, be sure to notify the profiler
        *before* deref'ing the scope chain, since the profiler uses the scope chain.

        (KJS::Machine::execute): Fixed incorrect reporting / crash when calling
        a JS function re-entrently: Machine::execute(FunctionBodyNode*...)
        should not invoke the didExecute hook, because op_ret already does that.
        Also, use the new function's ExecState when calling out to the profiler.
        (Not important now, but could have become a subtle bug later.)

        (KJS::Machine::privateExecute): Fixed a hard to reproduce crash when
        profiling JS functions: notify the profiler *before* deref'ing the scope
        chain, since the profiler uses the scope chain.

        * kjs/object.cpp:
        (KJS::JSObject::call): Removed these hooks, because they are now unnecessary.

        * profiler/Profile.cpp: Added a comment to explain a subtlety that only
        Kevin and I understood previously. (Now, the whole world can understand!)

        * profiler/Profiler.cpp:
        (KJS::shouldExcludeFunction): Don't exclude .call and .apply. That was
        a hack to fix bugs that no longer exist.

        Finally, sped things up a little bit by changing the "Is the profiler
        running?" check into an ASSERT, since we only call into the profiler
        when it's running:

        (KJS::Profiler::willExecute):
        (KJS::Profiler::didExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
ggaren@apple.com [Fri, 23 May 2008 20:49:39 +0000 (20:49 +0000)]
JavaScriptCore:

2008-05-23  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        - fixed <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com

        SunSpider reports no change.

        This is a reworking of r34073, which I rolled out because it caused
        lots of crashes.

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::CodeGenerator): Use removeDirect to nix old
        properties whose names collide with new functions. (Don't use putWithAttributes
        because that tries to write to the register file, which hasn't grown to
        fit this program yet.)

LayoutTests:

2008-05-23  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver.

        - test case <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com

        * fast/js/function-redefinition-expected.txt: Added.
        * fast/js/function-redefinition.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 Darin Adler <darin@apple.com>
mrowe@apple.com [Fri, 23 May 2008 19:42:26 +0000 (19:42 +0000)]
2008-05-23  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        As allocateNumber is used via jsNumberCell outside of JavaScriptCore,
        we need to provide a non-inlined version of it to avoid creating a
        weak external symbol.

        * JavaScriptCore.exp:
        * kjs/AllInOneFile.cpp:
        * kjs/collector.cpp:
        (KJS::Collector::allocate):
        (KJS::Collector::allocateNumber):
        * kjs/collector.h:
        (KJS::Collector::allocate):
        (KJS::Collector::inlineAllocateNumber):
        * kjs/value.h:
        (KJS::NumberImp::operator new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
ggaren@apple.com [Fri, 23 May 2008 19:34:20 +0000 (19:34 +0000)]
JavaScriptCore:

2008-05-23  Geoffrey Garen  <ggaren@apple.com>

        Rolled out r34073 because it caused lots of layout test crashes.

LayoutTests:

2008-05-23  Geoffrey Garen  <ggaren@apple.com>

        Rolled out r34073 because it caused lots of layout test crashes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 23 May 2008 19:12:31 +0000 (19:12 +0000)]
2008-05-23  Geoffrey Garen  <ggaren@apple.com>

        Rolled out r34085 because it measured as a 7.6% performance regression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 23 May 2008 17:50:51 +0000 (17:50 +0000)]
2008-05-23  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler, Kevin McCullough, and Oliver Hunt.

        Fixed <rdar://problem/5959447> Crashes and incorrect reporting in the
        JavaScript profiler

        * VM/Machine.cpp:
        (KJS::callEval): Made this profiler hooks slightly faster by passing in
        the eval function.

        (KJS::Machine::unwindCallFrame): Fixed incorrect reporting / a crash
        when unwinding from inside eval and/or program code: detect the
        difference, and do the right thing. Also, be sure to notify the profiler
        *before* deref'ing the scope chain, since the profiler uses the scope chain.

        (KJS::Machine::execute): Fixed incorrect reporting / crash when calling
        a JS function re-entrently: Machine::execute(FunctionBodyNode*...)
        should not invoke the didExecute hook, because op_ret already does that.
        Also, use the new function's ExecState when calling out to the profiler.
        (Not important now, but could have become a subtle bug later.)

        (KJS::Machine::privateExecute): Fixed a hard to reproduce crash when
        profiling JS functions: notify the profiler *before* deref'ing the scope
        chain, since the profiler uses the scope chain.

        * kjs/object.cpp:
        (KJS::JSObject::call): Removed these hooks, because they are now unnecessary.

        * profiler/Profile.cpp: Added a comment to explain a subtlety that only
        Kevin and I understood previously. (Now, the whole world can understand!)

        * profiler/Profiler.cpp:
        (KJS::shouldExcludeFunction): Don't exclude .call and .apply. That was
        a hack to fix bugs that no longer exist.

        Finally, sped things up a little bit by changing the "Is the profiler
        running?" check into an ASSERT, since we only call into the profiler
        when it's running:

        (KJS::Profiler::willExecute):
        (KJS::Profiler::didExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 Alp Toker <alp@nuanti.com>
alp@webkit.org [Fri, 23 May 2008 17:48:41 +0000 (17:48 +0000)]
2008-05-23  Alp Toker  <alp@nuanti.com>

        GTK+ fixes for building without database support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes a bug where excluding nodes from the profile could
timothy@apple.com [Fri, 23 May 2008 17:41:40 +0000 (17:41 +0000)]
Fixes a bug where excluding nodes from the profile could
show an empty parent node.

<rdar://problem/5959573> Excluding nodes from the profile could show
an empty parent node

Reviewed by Kevin McCullough.

* page/inspector/ProfileView.js: Only say we have children if
all of our children nodes are visible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 23 May 2008 17:19:15 +0000 (17:19 +0000)]
2008-05-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add IconFetcher to project.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes a bug where the Web Insepctor would jump back to
timothy@apple.com [Fri, 23 May 2008 17:15:08 +0000 (17:15 +0000)]
Fixes a bug where the Web Insepctor would jump back to
Elements each time it is opened instead of staying at the
last selected panel.

<rdar://problem/5959475> Inspector jumps to the Elements panel
each time it is opened, instead of staying at the previous panel

Reviewed by Adam Roben.

* page/InspectorController.cpp:
(WebCore::InspectorController::setWindowVisible): Reset
m_showAfterVisible to CurrentPanel, so the next time setWindowVisible
is called it will use CurrentPanel unless showPanel was called again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Fri, 23 May 2008 17:03:57 +0000 (17:03 +0000)]
    Windows build fix

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add the
        profiler directory to the include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5933759> REGRESSION: Frames don't appear as AX children of the top...
cfleizach@apple.com [Fri, 23 May 2008 16:54:53 +0000 (16:54 +0000)]
<rdar://problem/5933759> REGRESSION: Frames don't appear as AX children of the top level web area

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 23 May 2008 16:38:45 +0000 (16:38 +0000)]
2008-05-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam.

        Add IWebIconFetcher interface and implementation.

        * Interfaces/IWebFramePrivate.idl:
        * Interfaces/IWebIconFetcher.idl: Added.
        * Interfaces/WebKit.idl:
        * WebFrame.cpp:
        * WebFrame.h:
        * WebIconFetcher.cpp: Added.
        * WebIconFetcher.h: Added.
        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-21 Siraj Razick <siraj.razick@collabora.co.uk>
hausmann@webkit.org [Fri, 23 May 2008 15:23:21 +0000 (15:23 +0000)]
2008-05-21  Siraj Razick  <siraj.razick@collabora.co.uk>

        Reviewed by Simon.

        Add <param name="classid"/> support for application/x-qt-object plugins

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 23 May 2008 14:24:38 +0000 (14:24 +0000)]
2008-05-23  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        For Qt port, support painting to native Windows HDC.

        * platform/graphics/GraphicsContext.h:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::getWindowsContext):
        (WebCore::GraphicsContext::releaseWindowsContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSQUIRRELFISH: JavaScript error messages are missing informative text
oliver@apple.com [Fri, 23 May 2008 14:23:23 +0000 (14:23 +0000)]
SQUIRRELFISH: JavaScript error messages are missing informative text

Reviewed by Anders

Partial fix.
Tidy up error messages, makes a couple of them provide slightly more info.
Inexplicably leads to a 1% SunSpider Progression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix call stack reported by profiler when entering event handlers.
oliver@apple.com [Fri, 23 May 2008 11:37:32 +0000 (11:37 +0000)]
Fix call stack reported by profiler when entering event handlers.

Reviewed by Tim H

JSObject::call was arbitrarily notifying the profiler when it was
called, even if it was JS code, which notifies the profile on entry
in any case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
mjs@apple.com [Fri, 23 May 2008 10:43:08 +0000 (10:43 +0000)]
JavaScriptCore:

2008-05-23  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver.

        - fixed <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::CodeGenerator): Delete any existing
        properties before creating the function (this should really be
        done at execution time not codegen time).

LayoutTests:

2008-05-23  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Oliver.

        - test case <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com

        * fast/js/function-redefinition-expected.txt: Added.
        * fast/js/function-redefinition.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes a bug where the Inspector could have 0ms timers firing
timothy@apple.com [Fri, 23 May 2008 10:12:33 +0000 (10:12 +0000)]
Fixes a bug where the Inspector could have 0ms timers firing
even after it is closed.

https://bugs.webkit.org/show_bug.cgi?id=18577

Reviewed by Oliver Hunt.

* page/inspector/DatabasesPanel.js: Removes setTimeouts that call
the same function with a 0ms delay. These we not doing any good anyway,
so they weren't needed and just caused problems.
* page/inspector/ElementsPanel.js: Ditto.
* page/inspector/ProfilesPanel.js: Ditto.
* page/inspector/ResourcesPanel.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago+2008-05-16 Alp Toker <alp@nuanti.com>
alp@webkit.org [Fri, 23 May 2008 09:54:05 +0000 (09:54 +0000)]
+2008-05-16  Alp Toker  <alp@nuanti.com>

        Build fix for gcc 3. Default constructor required in ExecState,
        used by OldInterpreterExecState.

        * kjs/ExecState.h:
        (KJS::ExecState::ExecState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake the Inspector correctly populate the profiles when
timothy@apple.com [Fri, 23 May 2008 09:41:52 +0000 (09:41 +0000)]
Make the Inspector correctly populate the profiles when
closed and re-opened.

Reviewed by Adam Roben.

* page/InspectorController.cpp:
(WebCore::InspectorController::populateScriptObjects): Call populateInterface
in inspector.js.
* page/inspector/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.populateInterface): If visible,
call _populateProfiles. Else just set this._shouldPopulateProfiles to true.
(WebInspector.ProfilesPanel.prototype.reset): Don't call _populateProfiles.
Just set this._shouldPopulateProfiles to true.
(WebInspector.ProfilesPanel.prototype._populateProfiles): Delete
this._shouldPopulateProfiles.
* page/inspector/inspector.js:
(WebInspector.populateInterface): Added. Call populateInterface on all the
panels if they implement it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <rdar://problem/5954997> global-recursion-on-full-stack.html crashes under guardm...
mrowe@apple.com [Fri, 23 May 2008 09:38:30 +0000 (09:38 +0000)]
Fix <rdar://problem/5954997> global-recursion-on-full-stack.html crashes under guardmalloc.

Growing the register file with uncheckedGrow from within Machine::execute is not safe as the
register file may be too close to its maximum size to grow successfully.  By using grow,
checking the result and throwing a stack overflow error we can avoid crashing.

Reviewed by Oliver Hunt.

* VM/Machine.cpp:
(KJS::Machine::execute):
* VM/RegisterFile.h: Remove the now-unused uncheckedGrow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 23 May 2008 09:32:06 +0000 (09:32 +0000)]
2008-05-23  Kevin McCullough  <kmccullough@apple.com>

        RS = Adam.

        Editorial changes

        * manual-tests/inspector/profiler-test-apply.html:
        * manual-tests/inspector/profiler-test-document-dot-write.html:
        * manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html:
        * manual-tests/inspector/profiler-test-one-execution-context.html:
        * manual-tests/inspector/profiler-test-two-execution-contexts.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove JAVASCRIPT_PROFILER define
oliver@apple.com [Fri, 23 May 2008 09:07:06 +0000 (09:07 +0000)]
Remove JAVASCRIPT_PROFILER define

RS=Kevin McCullough

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes the bug where the profile was not added when finished.
timothy@apple.com [Fri, 23 May 2008 09:01:42 +0000 (09:01 +0000)]
Fixes the bug where the profile was not added when finished.

<rdar://problem/5958851> Stop Profiling from the Develop menu does
not add the Profile to the Inspector

Reviewed by Adam Roben.

* page/InspectorController.cpp:
(WebCore::InspectorController::stopUserInitiatedProfiling): Call
addProfile with the result of stopProfiling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5951561> Turn on JavaScript Profiler
oliver@apple.com [Fri, 23 May 2008 08:56:21 +0000 (08:56 +0000)]
<rdar://problem/5951561> Turn on JavaScript Profiler

Reviewed by Kevin McCullough

Flipped the switch on the profiler, rearranged how we
signal the the profiler is active so that calls aren't
needed in the general case.

Also fixed the entry point for Machine::execute(FunctionBodyNode..)
to correctly indicate function exit.

Results in a 0.7-1.0% regression in SunSpider :-(

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTweak the Web Insector toolbar look to be smaller when attached to
timothy@apple.com [Fri, 23 May 2008 08:35:29 +0000 (08:35 +0000)]
Tweak the Web Insector toolbar look to be smaller when attached to
the inspected page.

Reviewed by Adam Roben.

* page/inspector/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix attaching and detaching the Web Inspector. This change removes
timothy@apple.com [Fri, 23 May 2008 08:03:56 +0000 (08:03 +0000)]
Fix attaching and detaching the Web Inspector. This change removes
the clunky animation that never looked right and was causing issues
where the inspected WebView would get into a no useable state.

<rdar://problem/5958812> Attaching and Detaching the Web Inspector
can cause the inspected WebVIew to be unusable

Reviewed by Adam Roben.

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController close]): Removes animation code.
Sets the frame directly and does a displayIfNeeded to prevent
showing the Inspector in the page and in the Inspector window.
(-[WebInspectorWindowController showWindow:]): Removes animation code.
Sets the frame directly.
(-[WebInspectorWindowController attach]): Simplified.
(-[WebInspectorWindowController detach]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Qt build by adding profiler/ to the include path and providing
hausmann@webkit.org [Fri, 23 May 2008 07:58:09 +0000 (07:58 +0000)]
Fix the Qt build by adding profiler/ to the include path and providing
an empty stub for AXObjectCache::handleAriaRoleChanged to build without
accessibility.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-23 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Fri, 23 May 2008 07:05:44 +0000 (07:05 +0000)]
2008-05-23  Alice Liu  <alice.liu@apple.com>

        Reviewed by Mark Rowe.

        Remove call to function whose body was commented out. Returning the
        children for a menu button by the normal calculation works just as well.

        * page/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::addChildren):
        * page/AccessibilityRenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-05-22 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 23 May 2008 06:57:44 +0000 (06:57 +0000)]
2008-05-22  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Adam.

        Fix a bug in the profiler where time in the current function is given to
        (idle).

        * profiler/Profile.cpp:
        (KJS::Profile::didExecute): Set the start time and then call didExecute
        to calculate the time spent in this function.
        * profiler/ProfileNode.cpp: Remove confusing calculations that are no
        longer necessary.
        (KJS::ProfileNode::insertNode):
        * profiler/ProfileNode.h: Expose access to the start time to allow the
        simpler time calculations above.
        (KJS::ProfileNode::startTime):
        (KJS::ProfileNode::setStartTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34060 268f45cc-cd09-0410-ab3c-d52691b4dbfc