WebKit-https.git
7 years agowebkitpy: clean up options for specifying multiple platforms at once
dpranke@chromium.org [Mon, 5 Nov 2012 19:24:39 +0000 (19:24 +0000)]
webkitpy: clean up options for specifying multiple platforms at once
https://bugs.webkit.org/show_bug.cgi?id=101140

Reviewed by Ojan Vafai.

This patch reworks how we display the help strings for --platform
options and how we filter out platforms matching a glob. This will
be useful as I add patches to ensure that all the webkit-patch
commands are using --platform consistently to filter ports.

There should be no functional changes resulting from this patch.

* Scripts/webkitpy/layout_tests/port/factory.py:
(platform_options):
(PortFactory.all_port_names):
(PortFactory.get_from_builder_name):
* Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.__init__):
(PrintBaselines.__init__):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(RebaselineJson.__init__):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineExpectations.setUp):
(TestRebaselineExpectations.test_rebaseline_expectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe layout test runner shouldn't wait for data if stdout/stderr have been closed
peter@chromium.org [Mon, 5 Nov 2012 19:21:39 +0000 (19:21 +0000)]
The layout test runner shouldn't wait for data if stdout/stderr have been closed
https://bugs.webkit.org/show_bug.cgi?id=101233

Reviewed by Dirk Pranke.

Trying to read the file descriptor for the stdout or stderr pipes when DumpRenderTree
has crashed during a Chromium Android layout test-run, which uses FIFOs for
communication, causes the File.fileno() method to raise a ValueError. Return early
if either of the pipes has already been closed.

* Scripts/webkitpy/layout_tests/port/server_process.py:
(ServerProcess._wait_for_data_and_update_buffers_using_select):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkit-patch rebaseline is broken
dpranke@chromium.org [Mon, 5 Nov 2012 19:17:13 +0000 (19:17 +0000)]
webkit-patch rebaseline is broken
https://bugs.webkit.org/show_bug.cgi?id=101235

Reviewed by Ojan Vafai.

It didn't get updated to handle the change in parsing --suffixes
properly, and the unit test didn't get updated either, masking the
problem.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(Rebaseline._tests_to_update):
(Rebaseline.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaseline.test_rebaseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agolint-webkitpy doesn't autoinstall pylint properly.
dpranke@chromium.org [Mon, 5 Nov 2012 19:12:18 +0000 (19:12 +0000)]
lint-webkitpy doesn't autoinstall pylint properly.
https://bugs.webkit.org/show_bug.cgi?id=101106

Reviewed by Ojan Vafai.

Re-land r133381 with fix; ironically, lint-webkitpy would've
complained about the problem. Also modify pylintrc and clean up
any other lint errors in the modified files.

* Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._set_up_target_dir):
(AutoInstaller):
(AutoInstaller._make_package):
(AutoInstaller._create_scratch_directory):
(AutoInstaller._install):
(AutoInstaller.install):
* Scripts/webkitpy/pylintrc:
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
(AutoinstallImportHook):
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install_webpagereplay):
(AutoinstallImportHook._install):
* Scripts/webkitpy/thirdparty/__init___unittest.py:
(ThirdpartyTest.test_import_hook.MockImportHook.__init__):
(ThirdpartyTest.test_import_hook):
(ThirdpartyTest.test_imports):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpose hit test related methods in public chromium port
commit-queue@webkit.org [Mon, 5 Nov 2012 19:10:39 +0000 (19:10 +0000)]
Expose hit test related methods in public chromium port
https://bugs.webkit.org/show_bug.cgi?id=101204

Patch by Bo Liu <boliu@chromium.org> on 2012-11-05
Reviewed by Adam Barth.

The methods are needed in implementating hit test related methods in the
Android WebView API.

The specific methods are:
[Web]HitTestResult::urlElement
[Web]HitTestResult::absoluteImageURL
[Web]HitTestResult::absoluteLinkURL
[Web]HitTestResult::isContentEditable
WebViewImpl::hitTestResultAt

* public/WebHitTestResult.h:
(WebKit):
(WebHitTestResult):
* public/WebView.h:
(WebKit):
(WebView):
* src/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::urlElement):
(WebKit):
(WebKit::WebHitTestResult::absoluteImageURL):
(WebKit::WebHitTestResult::absoluteLinkURL):
(WebKit::WebHitTestResult::isContentEditable):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::hitTestResultAt):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BLACKBERRY] Update touch code to reflect touch refactor
commit-queue@webkit.org [Mon, 5 Nov 2012 19:09:55 +0000 (19:09 +0000)]
[BLACKBERRY] Update touch code to reflect touch refactor
https://bugs.webkit.org/show_bug.cgi?id=101227

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-05
Reviewed by Rob Buis.

PR #2706785
Reviewed Internally by: Mike Lattanzio

Source/WebCore:

* platform/blackberry/PlatformTouchEventBlackBerry.cpp:
(WebCore::touchEventType):
(WebCore::PlatformTouchEvent::PlatformTouchEvent):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Mark css3/filters/custom/custom-filter-animation.html
senorblanco@chromium.org [Mon, 5 Nov 2012 19:08:26 +0000 (19:08 +0000)]
[chromium] Mark css3/filters/custom/custom-filter-animation.html
as timing out intermittently.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents
alokp@chromium.org [Mon, 5 Nov 2012 18:56:05 +0000 (18:56 +0000)]
[chromium] Pass canPaintLCDText to WebContentLayerClient::paintContents
https://bugs.webkit.org/show_bug.cgi?id=99083

Reviewed by Stephen White.

Use LCD text setting passed to WebContentLayerClient::paintContents instead of turning it off for all composited layers.

Source/Platform:

* chromium/public/WebContentLayerClient.h:
(WebContentLayerClient):
(WebKit::WebContentLayerClient::paintContents):

Source/WebCore:

No new tests needed. This patch does not change anything functionally.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::paint):
* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:
(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h:
(OpaqueRectTrackingContentLayerDelegate):

Source/WebKit/chromium:

* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::paintContents):
* src/LinkHighlight.h:
(LinkHighlight):
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setOpaque):
(WebKit::NonCompositedContentHost::paintContents):
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
(WebCore::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Build fix after http://trac.webkit.org/changeset/133488.
senorblanco@chromium.org [Mon, 5 Nov 2012 18:51:19 +0000 (18:51 +0000)]
[chromium] Build fix after trac.webkit.org/changeset/133488.
Removed a deleted file.  Unreviewed.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] toV8(impl) should return null if impl is 0
haraken@chromium.org [Mon, 5 Nov 2012 18:41:13 +0000 (18:41 +0000)]
[V8] toV8(impl) should return null if impl is 0
https://bugs.webkit.org/show_bug.cgi?id=101206

Reviewed by Adam Barth.

toV8(impl) should return null if impl is 0. However,
V8HTMLCollection::toV8() does not have the null check.
All other toV8()s return null.

No tests. I think there will be no call path that hits the change.

* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
alokp@chromium.org [Mon, 5 Nov 2012 18:18:10 +0000 (18:18 +0000)]
Unreviewed. Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement SimpleFontData::platformBoundsForGlyph on skia
dbarton@mathscribe.com [Mon, 5 Nov 2012 18:17:57 +0000 (18:17 +0000)]
Implement SimpleFontData::platformBoundsForGlyph on skia
https://bugs.webkit.org/show_bug.cgi?id=101115

Reviewed by Eric Seidel.

Source/WebCore:

The implementation is similar to SimpleFontData::platformWidthForGlyph on skia.

Tested by: fast/block/lineboxcontain/*glyphs*, mathml/presentation/*

* platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph): Implemented.

LayoutTests:

Some lineboxcontain/etc. tests will need rebaselining.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReduce the verbosity of referring to QNaN in JavaScriptCore
fpizlo@apple.com [Mon, 5 Nov 2012 18:15:23 +0000 (18:15 +0000)]
Reduce the verbosity of referring to QNaN in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=101174

Reviewed by Geoffrey Garen.

Introduces a #define QNaN in JSValue.h, and replaces all previous uses of
std::numeric_limits<double>::quiet_NaN() with QNaN.

* API/JSValueRef.cpp:
(JSValueMakeNumber):
(JSValueToNumber):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitFloatTypedArrayGetByVal):
* runtime/CachedTranscendentalFunction.h:
(JSC::CachedTranscendentalFunction::initialize):
* runtime/DateConstructor.cpp:
(JSC::constructDate):
* runtime/DateInstanceCache.h:
(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):
* runtime/ExceptionHelpers.cpp:
(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):
* runtime/JSCell.h:
(JSC::JSValue::getPrimitiveNumber):
* runtime/JSDateMath.cpp:
(JSC::parseDateFromNullTerminatedCharacters):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::resetDateCache):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::toDouble):
(JSC::jsToNumber):
(JSC::parseFloat):
* runtime/JSValue.cpp:
(JSC::JSValue::toNumberSlowCase):
* runtime/JSValue.h:
(JSC):
* runtime/JSValueInlineMethods.h:
(JSC::jsNaN):
* runtime/MathObject.cpp:
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDecouple Attr logic from ElementAttributeData.
kling@webkit.org [Mon, 5 Nov 2012 18:06:23 +0000 (18:06 +0000)]
Decouple Attr logic from ElementAttributeData.
<http://webkit.org/b/101126>

Reviewed by Antti Koivisto.

Move all logic dealing with Attr DOM nodes from ElementAttributeData to Element.
This makes more sense since an Attr is tied to a single Element, but an ElementAttributeData
can be shared by any number of Elements at a given time.

Also updated naming convention from just "Attr" to "Attr node" in the code I was touching.
"Attr" is way too generic, and has been historically confused with WebCore::Attribute a lot.

* dom/Element.h:
* dom/ElementAttributeData.h:
* dom/Element.cpp:
(WebCore::attrNodeListMap):
(WebCore::attrNodeListForElement):
(WebCore::ensureAttrNodeListForElement):
(WebCore::removeAttrNodeListForElement):
(WebCore::findAttrNodeInList):
(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
(WebCore::Element::detachAttrNodeFromElementWithValue):
(WebCore::Element::detachAllAttrNodesFromElement):
(WebCore::Element::cloneAttributesFromElement):

    Move everything Attr-related into Element.cpp while simplifying some loops and remove
    conditions that are no longer needed as they used to depend on having an attributeData().

* dom/Node.h:
(WebCore::Node::hasSyntheticAttrChildNodes):
(WebCore::Node::setHasSyntheticAttrChildNodes):

    Renamed the hasAttrList() node flag to hasSyntheticAttrChildNodes().

* dom/Attr.cpp:
(WebCore::Attr::detachFromElementWithValue):

    Remove awkward indirection and let the call site deal with removing the Attr node from
    the Element's list of Attr nodes.

* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::clearAttributes):

    Remove now-unused Element* argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, unskip a now passing test.
ossy@webkit.org [Mon, 5 Nov 2012 18:01:23 +0000 (18:01 +0000)]
[Qt] Unreviewed gardening, unskip a now passing test.

* platform/qt-5.0-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Polygon edges should span colinear vertices
commit-queue@webkit.org [Mon, 5 Nov 2012 17:53:01 +0000 (17:53 +0000)]
[CSS Exclusions] Polygon edges should span colinear vertices
https://bugs.webkit.org/show_bug.cgi?id=99343

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-05
Reviewed by Dirk Schulze.

Source/WebCore:

ExclusionPolygonEdges now span coincident and collinear vertices. Currently
pairs of vertices are only considered coincident if their coordinates are exactly
equal. Similarly, a vertex is only considered collinear with an edge if the area
of the triangle defined by the three vertices is exactly zero.  In the future it
may be useful to relax the comparison with zero.

Tests: fast/exclusions/shape-inside/shape-inside-coincident-vertices.html
       fast/exclusions/shape-inside/shape-inside-collinear-vertices.html

* rendering/ExclusionPolygon.cpp:
(WebCore::determinant): Used to measure collinearity.
(WebCore):
(WebCore::areCollinearPoints): True if three FloatPoint arguments are collinear per the test outlined above.
(WebCore::areCoincidentPoints): True if the two FloatPoint arguments are equal.
(WebCore::nextVertexIndex): The next vertex index in clockwise or counterclockwise order.
(WebCore::ExclusionPolygon::findNextEdgeVertexIndex): Return the index of the next non-coincident, non-collinear vertex.
(WebCore::ExclusionPolygon::ExclusionPolygon): Skip coincident and collinear vertices when building the list of edges.
* rendering/ExclusionPolygon.h: Added private findNextEdgeVertexIndex() declaration.

LayoutTests:

Verify that exclusion polygonal shape-inside layout is unaffected by coincident
or collinear vertices.

* fast/exclusions/shape-inside/shape-inside-coincident-vertices-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-coincident-vertices.html: Added.
* fast/exclusions/shape-inside/shape-inside-collinear-vertices-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-collinear-vertices.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Use POSIX implementation of SharedBuffer::createWithContentsOfFile()
commit-queue@webkit.org [Mon, 5 Nov 2012 17:33:27 +0000 (17:33 +0000)]
[EFL] Use POSIX implementation of SharedBuffer::createWithContentsOfFile()
https://bugs.webkit.org/show_bug.cgi?id=101228

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Get rid of EFL-specific implementation of SharedBuffer::createWithContentsOfFile()
and reuse the POSIX one since it is pretty much the same.

No new tests, no behavior change.

* PlatformEfl.cmake:
* platform/efl/SharedBufferEfl.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, unskip now passing tests.
ossy@webkit.org [Mon, 5 Nov 2012 17:25:15 +0000 (17:25 +0000)]
[Qt] Unreviewed gardening, unskip now passing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Mark inspector-protocol/debugger-pause-dedicated-worker.html
senorblanco@chromium.org [Mon, 5 Nov 2012 17:22:04 +0000 (17:22 +0000)]
[chromium] Mark inspector-protocol/debugger-pause-dedicated-worker.html
as also crashy, and give it a bug ID.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a comment about a return value of IDBKey::toV8()
haraken@chromium.org [Mon, 5 Nov 2012 16:32:07 +0000 (16:32 +0000)]
Add a comment about a return value of IDBKey::toV8()
https://bugs.webkit.org/show_bug.cgi?id=101212

Reviewed by Adam Barth.

Although all other toV8(impl) return null when impl is 0,
IDBKey::toV8(impl) is expected to return undefined when impl is 0.
This patch adds a comment about it.

No tests.

* bindings/js/JSIDBKeyCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Cairo] Make Cairo honor image orientation
dominik.rottsches@intel.com [Mon, 5 Nov 2012 16:23:48 +0000 (16:23 +0000)]
[Cairo] Make Cairo honor image orientation
https://bugs.webkit.org/show_bug.cgi?id=101207

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Implement transformed image drawing in BitmapImageCairo, similar
as it was done for Skia in bug 100179, r132384.
The image drawing code needs to transform the graphics context
depending on exif orientation in order for this to work.

No new tests, covered by fast/images/exif-* which are passing now.

* platform/graphics/BitmapImage.h: Enable draw function which respects image orientation for Cairo.
* platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::draw): Apply ImageOrientation's transformFromDefault() transformation to context.
(WebCore):

LayoutTests:

Unskip and rebaseline exif orientation tests for EFL.

* platform/efl-wk1/TestExpectations: Tests not passing here yet, since DRT needs a setShouldRespectImageOrientation setting.
* platform/efl/TestExpectations: Unskipping three exif orientation tests.
* platform/efl/fast/images/exif-orientation-css-expected.png: Added.
* platform/efl/fast/images/exif-orientation-css-expected.txt: Added.
* platform/efl/fast/images/exif-orientation-expected.png: Added.
* platform/efl/fast/images/exif-orientation-expected.txt: Added.
* platform/efl/fast/images/exif-orientation-image-document-expected.png: Added.
* platform/efl/fast/images/exif-orientation-image-document-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Dispose() and Clear() should be always coupled for safety
haraken@chromium.org [Mon, 5 Nov 2012 16:14:27 +0000 (16:14 +0000)]
[V8] Dispose() and Clear() should be always coupled for safety
https://bugs.webkit.org/show_bug.cgi?id=101191

Reviewed by Adam Barth.

Clear() is not mandatory. However, to avoid misusing already
disposed wrappers, Clear() should be always called just
after Dispose().

No tests. No change in behavior.

* bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperHashMap::defaultWeakCallback):
* bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::IntrusiveDOMWrapperMap::weakCallback):
* bindings/v8/NPV8Object.cpp:
(WebCore::freeV8NPObject):
* bindings/v8/ScheduledAction.cpp:
(WebCore::ScheduledAction::~ScheduledAction):
* bindings/v8/V8NPObject.cpp:
(WebCore::V8NPTemplateMap::dispose):
(WebCore::weakNPObjectCallback):
(WebCore::forgetV8ObjectForNPObject):
* bindings/v8/V8PerContextData.cpp:
(WebCore::V8PerContextData::dispose):
* bindings/v8/V8ValueCache.cpp:
(WebCore::cachedStringCallback):
(WebCore::IntegerCache::~IntegerCache):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::WeakReferenceCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Web Inspector: Add InspectorInstrumentaiton calls for timeline compositing.
kpiascik@rim.com [Mon, 5 Nov 2012 15:42:42 +0000 (15:42 +0000)]
[BlackBerry] Web Inspector: Add InspectorInstrumentaiton calls for timeline compositing.
https://bugs.webkit.org/show_bug.cgi?id=101213
RIM PR 178131

Reviewed by Rob Buis.

Internally Reviewed by Arvid Nilsson.

Added compositing events to the timeline for BlackBerry.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::willComposite):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::didComposite):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Layout of the first shape-inside line can be incorrect
commit-queue@webkit.org [Mon, 5 Nov 2012 15:25:12 +0000 (15:25 +0000)]
[CSS Exclusions] Layout of the first shape-inside line can be incorrect
https://bugs.webkit.org/show_bug.cgi?id=100996

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-05
Reviewed by Dirk Schulze.

Source/WebCore:

Made the conversion from floating point top/bottom logical shape bounds coordinates
LayoutUnits explicit and corrected the case where the top value was truncated.  A
float logicalTop value is converted to LayoutUnit with fromFloatCeil() to ensure
that the LayoutUnit value is within the shape.

Test: fast/exclusions/shape-inside/shape-inside-shape-logical-top.html

* rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::shapeLogicalTop): Redefined this method in terms of shapeLogicalBoundsY,Max().
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBottom):  Ditto.
(WebCore::ExclusionShapeInsideInfo::lineOverlapsShapeBounds):  Ditto.
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBoundsY): Explicit conversion from floating point shape coordinates to LayoutUnits.
(WebCore::ExclusionShapeInsideInfo::shapeLogicalBoundsMaxY): Ditto.

LayoutTests:

Verify that the first line of shape-inside content is laid out correctly
when the top of the shape's bounds has a non-integral value.

* fast/exclusions/shape-inside/shape-inside-shape-logical-top-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-shape-logical-top.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Mark a flaky test. Unreviewed.
senorblanco@chromium.org [Mon, 5 Nov 2012 15:17:52 +0000 (15:17 +0000)]
[chromium] Mark a flaky test.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add a now-failing test, remove a now-passing test. Unreviewed.
senorblanco@chromium.org [Mon, 5 Nov 2012 15:08:07 +0000 (15:08 +0000)]
[chromium] Add a now-failing test, remove a now-passing test.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProtect against resource deletion during iteration in MemoryCache::pruneDeadResources...
antti@apple.com [Mon, 5 Nov 2012 15:02:29 +0000 (15:02 +0000)]
Protect against resource deletion during iteration in MemoryCache::pruneDeadResourcesToSize
https://bugs.webkit.org/show_bug.cgi?id=101211

Reviewed by Andreas Kling.

Some crashes have been seen under MemoryCache::pruneDeadResourcesToSize. A possible cause is that
destroyDecodedData() call ends up evicting the resource pointed by 'previous' pointer during iteration
and deleting the object. This looks in principle possible via stylesheets and SVG images.

Speculative fix, no repro, no obvious way to construct a test.

* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneDeadResourcesToSize):

    Use CachedResourceHandle to protect the 'previous' pointer during iteration. Check if the
    resource has been kicked out from the cache during destroyDecodedData() and stop iterating
    if has (as it may die when CachedResourceHandle releases it).
    The 'current' pointer is not protected as the resource it points to is allowed to die.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Disable registerProtocolHandler on Android
commit-queue@webkit.org [Mon, 5 Nov 2012 14:27:53 +0000 (14:27 +0000)]
[Chromium] Disable registerProtocolHandler on Android
https://bugs.webkit.org/show_bug.cgi?id=101199

Patch by Miguel Garcia <miguelg@chromium.org> on 2012-11-05
Reviewed by Julien Chaffraix.

Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
actually wired up internally. Disable the feature to avoid breaking feature detection
until we can implement it properly.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS
commit-queue@webkit.org [Mon, 5 Nov 2012 14:22:33 +0000 (14:22 +0000)]
[EFL][WK2] Allow using ACCELERATED_COMPOSITING without COORDINATED_GRAPHICS
https://bugs.webkit.org/show_bug.cgi?id=100674

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Make a distinction between calling ewk_view_base_add and ewk_view_smart_add.
Calling ewk_view_base_add creates a desktop style view, that does not support
fixed layout size, while calling ewk_view_smart_add does support fixed layout size.
As a result, WebKitTestRunner and the inspector window do not support
fixed layout size, while MiniBrowser does. This change allows many DumpAsText
layout tests to pass without modification, when AC is enabled.

* PlatformEfl.cmake:
* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::transformFromScene):
(EwkViewImpl::informLoadCommitted):
(EwkViewImpl::enterAcceleratedCompositingMode):
(EwkViewImpl::informContentsSizeChange):
* UIProcess/API/efl/EwkViewImpl.h:
(WebKit):
(EwkViewImpl):
(EwkViewImpl::pageClient):
(EwkViewImpl::setScaleFactor):
(EwkViewImpl::scaleFactor):
(EwkViewImpl::setScrollPosition):
(EwkViewImpl::scrollPosition):
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_calculate):
(createEwkView):
(ewk_view_base_add):
* UIProcess/efl/PageClientBase.cpp: Copied from Source/WebKit2/UIProcess/efl/PageClientImpl.cpp.
(WebKit::PageClientBase::PageClientBase):
(WebKit::PageClientBase::~PageClientBase):
(WebKit::PageClientBase::viewImpl):
(WebKit::PageClientBase::createDrawingAreaProxy):
(WebKit::PageClientBase::setViewNeedsDisplay):
(WebKit::PageClientBase::displayView):
(WebKit::PageClientBase::scrollView):
(WebKit::PageClientBase::viewSize):
(WebKit::PageClientBase::isViewWindowActive):
(WebKit::PageClientBase::isViewFocused):
(WebKit::PageClientBase::isViewVisible):
(WebKit::PageClientBase::isViewInWindow):
(WebKit::PageClientBase::processDidCrash):
(WebKit::PageClientBase::didRelaunchProcess):
(WebKit::PageClientBase::pageClosed):
(WebKit::PageClientBase::toolTipChanged):
(WebKit::PageClientBase::setCursor):
(WebKit::PageClientBase::setCursorHiddenUntilMouseMoves):
(WebKit::PageClientBase::registerEditCommand):
(WebKit::PageClientBase::clearAllEditCommands):
(WebKit::PageClientBase::canUndoRedo):
(WebKit::PageClientBase::executeUndoRedo):
(WebKit::PageClientBase::convertToDeviceSpace):
(WebKit::PageClientBase::convertToUserSpace):
(WebKit::PageClientBase::screenToWindow):
(WebKit::PageClientBase::windowToScreen):
(WebKit::PageClientBase::doneWithKeyEvent):
(WebKit::PageClientBase::doneWithTouchEvent):
(WebKit::PageClientBase::createPopupMenuProxy):
(WebKit::PageClientBase::createContextMenuProxy):
(WebKit::PageClientBase::createColorChooserProxy):
(WebKit::PageClientBase::setFindIndicator):
(WebKit::PageClientBase::enterAcceleratedCompositingMode):
(WebKit::PageClientBase::exitAcceleratedCompositingMode):
(WebKit::PageClientBase::updateAcceleratedCompositingMode):
(WebKit::PageClientBase::didChangeScrollbarsForMainFrame):
(WebKit::PageClientBase::didCommitLoadForMainFrame):
(WebKit::PageClientBase::didFinishLoadingDataForCustomRepresentation):
(WebKit::PageClientBase::customRepresentationZoomFactor):
(WebKit::PageClientBase::setCustomRepresentationZoomFactor):
(WebKit::PageClientBase::flashBackingStoreUpdates):
(WebKit::PageClientBase::findStringInCustomRepresentation):
(WebKit::PageClientBase::countStringMatchesInCustomRepresentation):
(WebKit::PageClientBase::updateTextInputState):
(WebKit::PageClientBase::handleDownloadRequest):
* UIProcess/efl/PageClientBase.h: Copied from Source/WebKit2/UIProcess/efl/PageClientImpl.h.
(PageClientBase):
* UIProcess/efl/PageClientDefaultImpl.cpp: Added.
(WebKit):
(WebKit::PageClientDefaultImpl::PageClientDefaultImpl):
(WebKit::PageClientDefaultImpl::didCommitLoad):
(WebKit::PageClientDefaultImpl::updateViewportSize):
(WebKit::PageClientDefaultImpl::didChangeViewportProperties):
(WebKit::PageClientDefaultImpl::didChangeContentsSize):
(WebKit::PageClientDefaultImpl::pageDidRequestScroll):
(WebKit::PageClientDefaultImpl::didRenderFrame):
(WebKit::PageClientDefaultImpl::pageTransitionViewportReady):
* UIProcess/efl/PageClientDefaultImpl.h: Added.
(WebKit):
(PageClientDefaultImpl):
(WebKit::PageClientDefaultImpl::create):
(WebKit::PageClientDefaultImpl::~PageClientDefaultImpl):
* UIProcess/efl/PageClientImpl.cpp: Removed.
* UIProcess/efl/PageClientImpl.h: Removed.
* UIProcess/efl/PageClientLegacyImpl.cpp: Added.
(WebKit):
(WebKit::PageClientLegacyImpl::PageClientLegacyImpl):
(WebKit::PageClientLegacyImpl::didCommitLoad):
(WebKit::PageClientLegacyImpl::updateViewportSize):
(WebKit::PageClientLegacyImpl::didChangeViewportProperties):
(WebKit::PageClientLegacyImpl::didChangeContentsSize):
(WebKit::PageClientLegacyImpl::pageDidRequestScroll):
(WebKit::PageClientLegacyImpl::didRenderFrame):
(WebKit::PageClientLegacyImpl::pageTransitionViewportReady):
* UIProcess/efl/PageClientLegacyImpl.h: Added.
(WebKit):
(PageClientLegacyImpl):
(WebKit::PageClientLegacyImpl::create):
(WebKit::PageClientLegacyImpl::~PageClientLegacyImpl):
* UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::updateViewportSize):
(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setContentsScale):
* UIProcess/efl/PageViewportControllerClientEfl.h:
* UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::viewWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Fix jscompiler cast syntax
commit-queue@webkit.org [Mon, 5 Nov 2012 14:15:14 +0000 (14:15 +0000)]
Web Inspector: Fix jscompiler cast syntax
https://bugs.webkit.org/show_bug.cgi?id=101066

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-05
Reviewed by Pavel Feldman.

Casts should be in the form of "/** @type {TypeName} */ (expr)" instead of "/** @type {TypeName} */ expr".

* inspector/InjectedScriptCanvasModuleSource.js:
(.):
* inspector/InjectedScriptSource.js:
(.):
* inspector/front-end/ApplicationCacheModel.js:
(WebInspector.ApplicationCacheModel.prototype._frameNavigated):
(WebInspector.ApplicationCacheModel.prototype._frameDetached):
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype._onRequestStarted):
(WebInspector.AuditLauncherView.prototype._onRequestFinished):
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype._uiSourceCodeFormatted):
(WebInspector.BreakpointManager.prototype._uiSourceCodeRemoved):
(WebInspector.BreakpointManager.prototype._breakpointResolved):
(WebInspector.BreakpointManager.Breakpoint.prototype._locationUpdated):
(WebInspector.BreakpointManager.Storage):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):
* inspector/front-end/CSSNamedFlowCollectionsView.js:
(WebInspector.CSSNamedFlowCollectionsView.prototype._documentUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._namedFlowCreated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._regionLayoutUpdated):
(WebInspector.CSSNamedFlowCollectionsView.prototype._selectedNodeChanged):
* inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSProfileHeader.prototype.createView):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.LiveLocation.prototype.uiLocation):
(WebInspector.CSSStyleDeclaration.parseComputedStylePayload):
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.loadSourceMapForScript):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._frameAdded):
(WebInspector.ConsoleView.prototype._frameRemoved):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMDocument):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.didSetBreakpoint):
(WebInspector.DebuggerModel.prototype.setBreakpointByURL):
(WebInspector.DebuggerModel.prototype.):
(WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
(WebInspector.DebuggerModel.CallFrame.prototype.get location):
* inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping.prototype._parsedScriptSource):
* inspector/front-end/DirectoryContentView.js:
(WebInspector.DirectoryContentView.prototype._sort):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._updateBreadcrumbIfNeeded):
* inspector/front-end/ElementsPanelDescriptor.js:
(WebInspector.ElementsPanelDescriptor.prototype.appendApplicableItems):
* inspector/front-end/ElementsTreeOutline.js:
(.get node):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddRequestHeaders):
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
(WebInspector.ExtensionServer.prototype._notifyResourceAdded):
(WebInspector.ExtensionServer.prototype._notifyUISourceCodeContentCommitted):
(WebInspector.ExtensionServer.prototype._notifyRequestFinished):
* inspector/front-end/FileContentView.js:
(WebInspector.FileContentView.prototype._metadataReceived):
(WebInspector.FileContentView.FileContentProvider.prototype.requestContent):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._frameAdded):
(WebInspector.FileSystemModel.prototype._frameNavigated):
(WebInspector.FileSystemModel.prototype._frameDetached):
* inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemView.EntryTreeElement.prototype.onselect):
(WebInspector.FileSystemView.EntryTreeElement.prototype.refresh):
* inspector/front-end/HandlerRegistry.js:
(WebInspector.HandlerRegistry.prototype._appendHrefItems):
* inspector/front-end/HeapSnapshotLoader.js:
(WebInspector.HeapSnapshotLoader.prototype.write):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._changeBase):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._snapshotReceived):
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.prototype._frameNavigated):
(WebInspector.IndexedDBModel.prototype._frameDetached):
* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype._keyColumnHeaderFragment):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageAdded):
(WebInspector.JavaScriptSourceFrame.prototype._consoleMessageRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._handleGutterClick):
(WebInspector.JavaScriptSourceFrame.prototype._continueToLine):
* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype.show):
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._uiSourceCodeTitleChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyCommitted):
(WebInspector.NavigatorView.prototype._uiSourceCodeFormattedChanged):
* inspector/front-end/NetworkLog.js:
(WebInspector.NetworkLog.prototype._onRequestStarted):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.prototype._cacheDisabledSettingChanged):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._onRequestUpdated):
(WebInspector.NetworkLogView.prototype._mainFrameNavigated):
(WebInspector.NetworkPanel.prototype.reveal):
(WebInspector.NetworkPanel.prototype.appendApplicableItems):
* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider.prototype._parsedScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
* inspector/front-end/ObjectPopoverHelper.js:
(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
* inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleMessageAdded):
(WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
* inspector/front-end/ProfilesPanel.js:
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._workingCopyChanged):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onRequestFinished):
(WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype._databaseAdded):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBAdded):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBRemoved):
(WebInspector.IndexedDBTreeElement.prototype._indexedDBLoaded):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemAdded):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemRemoved):
(WebInspector.FileSystemListTreeElement.prototype._fileSystemTreeElementByName):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traverseNext):
(WebInspector.SearchResultsTreeElementsTraverser.prototype._traversePrevious):
* inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView.prototype._uiSourceCodeRemoved):
* inspector/front-end/SASSSourceMapping.js:
(rawLocationToUILocation):
* inspector/front-end/ScopeChainSidebarPane.js:
(WebInspector.ScopeChainSidebarPane.prototype.update):
* inspector/front-end/Script.js:
(WebInspector.Script.Location.prototype.uiLocation):
* inspector/front-end/ScriptFormatter.js:
(WebInspector.ScriptFormatter.prototype.get _worker):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._editorSelected):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
(WebInspector.ScriptsPanel.prototype.canSearchAndReplace):
(WebInspector.ScriptsPanel.prototype.replaceSelectionWith):
(WebInspector.ScriptsPanel.prototype.replaceAllWith):
(WebInspector.ScriptsPanel.prototype._toggleBreakpoint):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
* inspector/front-end/ScriptsPanelDescriptor.js:
(WebInspector.ScriptsPanelDescriptor.prototype.appendApplicableItems):
* inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._scrollChanged):
(WebInspector.TabbedEditorContainer.prototype._selectionChanged):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._tabSelected):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeTitleChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyCommitted):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeFormattedChanged):
* inspector/front-end/TimelineModel.js:
(WebInspector.TimelineModelLoader.prototype.write):
* inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):
* inspector/front-end/Workspace.js:
(WebInspector.WorkspaceController.prototype._frameAdded):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix broken comment in WK2 TestExpectations
pierre.rossi@gmail.com [Mon, 5 Nov 2012 14:09:28 +0000 (14:09 +0000)]
[Qt] Fix broken comment in WK2 TestExpectations

Unreviewed fix, just an obviously missing '#' character.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/events/popup-allowed-from-gesture-initiated-event.html is flaky
commit-queue@webkit.org [Mon, 5 Nov 2012 14:08:00 +0000 (14:08 +0000)]
fast/events/popup-allowed-from-gesture-initiated-event.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101208

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Close the new popup between each test to make sure the new window
does not mask the buttons and therefore prevent them from being
clicked. This addresses flakiness for this test.

* fast/events/popup-allowed-from-gesture-initiated-event.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: render message bubbles in CodeMirror experiment.
pfeldman@chromium.org [Mon, 5 Nov 2012 13:43:11 +0000 (13:43 +0000)]
Web Inspector: render message bubbles in CodeMirror experiment.
https://bugs.webkit.org/show_bug.cgi?id=101164

Reviewed by Vsevolod Vlasov.

It sounds like addLineWidget just makes it happen.

* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.addDecoration):
(WebInspector.CodeMirrorTextEditor.prototype.get if):
(WebInspector.CodeMirrorTextEditor.prototype.removeDecoration):
(WebInspector.CodeMirrorTextEditor.prototype._change):
* inspector/front-end/DefaultTextEditor.js:
(.preventDefaultOnMouseUp):
* inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper):
* inspector/front-end/cm/cmdevtools.css:
(.CodeMirror .webkit-html-message-bubble):
(.CodeMirror .webkit-html-message-bubble img):
(.CodeMirror .webkit-html-warning-message):
(.CodeMirror .webkit-html-error-message):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 5 Nov 2012 13:05:57 +0000 (13:05 +0000)]
Unreviewed GTK gardening.

A followup to r133453, adding a baseline for http/tests/inspector/console-websocket-error.html.

* platform/gtk/http/tests/inspector: Added.
* platform/gtk/http/tests/inspector/console-websocket-error-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoValidate CSS Device Adaptation properties and resolve shorthands
commit-queue@webkit.org [Mon, 5 Nov 2012 12:47:46 +0000 (12:47 +0000)]
Validate CSS Device Adaptation properties and resolve shorthands
https://bugs.webkit.org/show_bug.cgi?id=95962

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-05
Reviewed by Alexis Menard.

Source/WebCore:

Add the missing keywords and properties for the viewport at-rule.
Note that we have to mark that we are inside a viewport scope because
some properties are not validated as they would be inside a style
rule. As an example, the semantics of CSSPropertyWidth are completely
different: on a viewport rule, it stands for a shorthand for the
minimum and maximum width.

Test: css3/device-adapt/viewport-properties-validation.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore):
(WebCore::CSSParser::parseViewportProperty):
(WebCore::CSSParser::parseViewportShorthand):
* css/CSSParser.h:
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSValueKeywords.in:

LayoutTests:

Added a test for CSS Device Adaptation property parsing validation.

* css3/device-adapt/viewport-properties-validation-expected.txt: Added.
* css3/device-adapt/viewport-properties-validation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Make Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data Ewk_Objects
commit-queue@webkit.org [Mon, 5 Nov 2012 12:39:05 +0000 (12:39 +0000)]
[EFL][WK2] Make Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data  Ewk_Objects
https://bugs.webkit.org/show_bug.cgi?id=101205

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-05
Reviewed by Gyuyoung Kim.

Ewk_Url_Request, Ewk_Url_Response, Ewk_Navigation_Data are using common Ewk_Object interface now.

* UIProcess/API/efl/EwkViewImpl.h:
* UIProcess/API/efl/ewk_download_job.cpp:
(Ewk_Download_Job::request):
(Ewk_Download_Job::response):
(Ewk_Download_Job::setResponse):
* UIProcess/API/efl/ewk_download_job_private.h:
(Ewk_Download_Job):
* UIProcess/API/efl/ewk_navigation_data.cpp:
(EwkNavigationData::EwkNavigationData):
(EwkNavigationData::originalRequest):
(EwkNavigationData::title):
(EwkNavigationData::url):
(ewk_navigation_data_title_get):
(ewk_navigation_data_original_request_get):
(ewk_navigation_data_url_get):
* UIProcess/API/efl/ewk_navigation_data.h:
* UIProcess/API/efl/ewk_navigation_data_private.h:
(EwkNavigationData):
(EwkNavigationData::create):
* UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
(Ewk_Navigation_Policy_Decision::Ewk_Navigation_Policy_Decision):
(Ewk_Navigation_Policy_Decision::request):
* UIProcess/API/efl/ewk_navigation_policy_decision_private.h:
(Ewk_Navigation_Policy_Decision::create):
(Ewk_Navigation_Policy_Decision):
* UIProcess/API/efl/ewk_url_request.cpp:
(EwkUrlRequest::EwkUrlRequest):
(EwkUrlRequest::url):
(EwkUrlRequest::firstParty):
(EwkUrlRequest::httpMethod):
(ewk_url_request_url_get):
(ewk_request_cookies_first_party_get):
(ewk_url_request_http_method_get):
* UIProcess/API/efl/ewk_url_request.h:
* UIProcess/API/efl/ewk_url_request_private.h:
(EwkUrlRequest):
(EwkUrlRequest::create):
* UIProcess/API/efl/ewk_url_response.cpp:
(EwkUrlResponse::EwkUrlResponse):
(EwkUrlResponse::httpStatusCode):
(EwkUrlResponse::url):
(EwkUrlResponse::mimeType):
(EwkUrlResponse::contentLength):
(ewk_url_response_url_get):
(ewk_url_response_status_code_get):
(ewk_url_response_mime_type_get):
(ewk_url_response_content_length_get):
* UIProcess/API/efl/ewk_url_response.h:
* UIProcess/API/efl/ewk_url_response_private.h:
(EwkUrlResponse):
(EwkUrlResponse::create):
* UIProcess/efl/ContextHistoryClientEfl.cpp:
(WebKit::ContextHistoryClientEfl::didNavigateWithNavigationData):
* UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::didReceiveResponse):
* UIProcess/efl/ResourceLoadClientEfl.cpp:
(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
(WebKit::ResourceLoadClientEfl::didSendRequestForResource):
(WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Mon, 5 Nov 2012 12:23:21 +0000 (12:23 +0000)]
[EFL] Unreviewed gardening.

Remove a few tests which depend on setIsolatedWorldSecurityOrigin
since they are already skipped in efl/TestExpectations.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] EWK2UnitTestBase.ewk_auth_request_cancel API test is failing after r133389
commit-queue@webkit.org [Mon, 5 Nov 2012 12:14:59 +0000 (12:14 +0000)]
[EFL][WK2] EWK2UnitTestBase.ewk_auth_request_cancel API test is failing after r133389
https://bugs.webkit.org/show_bug.cgi?id=101203

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Attempt for continue without credential when the client cancels
authentication (or does not handle the authentication request)
instead of cancelling the load. We now get a 402 error when
when cancelling the authentication, which is the behavior we
want (and the behavior we used to have before r133389).

* UIProcess/API/efl/ewk_auth_request.cpp:
(Ewk_Auth_Request::~Ewk_Auth_Request):
(Ewk_Auth_Request::continueWithoutCredential):
(ewk_auth_request_cancel):
* UIProcess/API/efl/ewk_auth_request_private.h:
(Ewk_Auth_Request):
* UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] fast/forms/week-multiple-fields does not exist and should be removed from TestE...
commit-queue@webkit.org [Mon, 5 Nov 2012 11:50:33 +0000 (11:50 +0000)]
[EFL] fast/forms/week-multiple-fields does not exist and should be removed from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=101202

Unreviewed EFL gardening.

Remove fast/forms/week-multiple-fields from TestExpections since it does
not exist and makes the style script complain.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 5 Nov 2012 11:43:37 +0000 (11:43 +0000)]
Unreviewed GTK gardening.

Clean up the inspector-related test expectations. Instead of marking
many tests as skipped, proper failure expectations are put in place.
The tests are still being skipped as their current behavior on the
buildbots is unknown.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Fix build warning in EWebLauncher/main.c
commit-queue@webkit.org [Mon, 5 Nov 2012 10:57:16 +0000 (10:57 +0000)]
[EFL] Fix build warning in EWebLauncher/main.c
https://bugs.webkit.org/show_bug.cgi?id=101197

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-05
Reviewed by Kentaro Hara.

Because the strp of _Ecore_Getopt_Value is char** (Ecore_Getopt.h),
The parameter of ECORE_GETOPT_VALUE_STR should be char*

* EWebLauncher/main.c:
(_User_Arguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r133286, r133385, and r133394.
commit-queue@webkit.org [Mon, 5 Nov 2012 10:47:35 +0000 (10:47 +0000)]
Unreviewed, rolling out r133286, r133385, and r133394.
http://trac.webkit.org/changeset/133286
http://trac.webkit.org/changeset/133385
http://trac.webkit.org/changeset/133394
https://bugs.webkit.org/show_bug.cgi?id=101198

Broke image placement on some web sites. (Requested by kling
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-05

* css/StyleResolver.cpp:
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::canShareStyleWithElement):
* dom/Attr.cpp:
(WebCore::Attr::detachFromElementWithValue):
* dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
(WebCore::Element::cloneAttributesFromElement):
* dom/Element.h:
(Element):
(WebCore::Element::updateInvalidAttributes):
* dom/ElementAttributeData.cpp:
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore):
(WebCore::attrListMap):
(WebCore::attrListForElement):
(WebCore::ensureAttrListForElement):
(WebCore::removeAttrListForElement):
(WebCore::findAttrInList):
(WebCore::ElementAttributeData::attrIfExists):
(WebCore::ElementAttributeData::ensureAttr):
(WebCore::ElementAttributeData::setAttr):
(WebCore::ElementAttributeData::removeAttr):
(WebCore::ElementAttributeData::detachAttrObjectsFromElement):
(WebCore::ElementAttributeData::reportMemoryUsage):
(WebCore::ElementAttributeData::cloneDataFrom):
(WebCore::ElementAttributeData::clearAttributes):
(WebCore::ElementAttributeData::getAttributeNode):
* dom/ElementAttributeData.h:
(WebCore):
(WebCore::ElementAttributeData::attributeStyle):
(WebCore::ElementAttributeData::setAttributeStyle):
(ElementAttributeData):
(WebCore::ElementAttributeData::ElementAttributeData):
* dom/Node.h:
(WebCore):
(WebCore::Node::hasAttrList):
(WebCore::Node::attributeStyleDirty):
(WebCore::Node::setAttributeStyleDirty):
(WebCore::Node::clearAttributeStyleDirty):
(Node):
(WebCore::Node::setHasAttrList):
(WebCore::Node::clearHasAttrList):
(WebCore::Node::isStyleAttributeValid):
(WebCore::Node::setIsStyleAttributeValid):
(WebCore::Node::clearIsStyleAttributeValid):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::updateAttributeStyle):
* dom/StyledElement.h:
(StyledElement):
(WebCore::StyledElement::invalidateStyleAttribute):
(WebCore::StyledElement::attributeStyle):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add --window-size command line option to EFL MiniBrowser
commit-queue@webkit.org [Mon, 5 Nov 2012 10:34:02 +0000 (10:34 +0000)]
[EFL][WK2] Add --window-size command line option to EFL MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=100942

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Added window-size (-s) command line option to EFL MiniBrowser.

* MiniBrowser/efl/main.c:
(window_create):
(parse_window_size):
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
kkristof@inf.u-szeged.hu [Mon, 5 Nov 2012 10:25:34 +0000 (10:25 +0000)]
[Qt] Unreviewed gardening.

Skip fast/dom/shadow/shadowroot-type.html because SHADOW_DOM is disabled.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Trivial unreviewed: Add missing module dependencies for builds in Qt CI system.
hausmann@webkit.org [Mon, 5 Nov 2012 10:12:27 +0000 (10:12 +0000)]
[Qt] Trivial unreviewed: Add missing module dependencies for builds in Qt CI system.

These fields aren't used by anyone except some perl scripts in the Qt CI builds.

* Source/sync.profile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed trivial Qt build fix.
hausmann@webkit.org [Mon, 5 Nov 2012 10:12:12 +0000 (10:12 +0000)]
Unreviewed trivial Qt build fix.

Surround imports from QtGui by QT_{BEGIN,END}_NAMESPACE to fix namespaced
builds.

* platform/graphics/qt/GraphicsContextQt.cpp:
* platform/graphics/qt/ImageQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 5 Nov 2012 09:53:53 +0000 (09:53 +0000)]
Unreviewed GTK gardening.

Rebaselining MathML tests after r132264 and r133221 and updating
pixel baselines with outdated hash.

* platform/gtk/TestExpectations:
* platform/gtk/mathml/presentation/attributes-expected.png:
* platform/gtk/mathml/presentation/fenced-expected.png:
* platform/gtk/mathml/presentation/fenced-expected.txt:
* platform/gtk/mathml/presentation/mo-expected.png:
* platform/gtk/mathml/presentation/mo-expected.txt:
* platform/gtk/mathml/presentation/mo-stretch-expected.png:
* platform/gtk/mathml/presentation/mo-stretch-expected.txt:
* platform/gtk/mathml/presentation/mroot-pref-width-expected.png:
* platform/gtk/mathml/presentation/over-expected.png:
* platform/gtk/mathml/presentation/over-expected.txt:
* platform/gtk/mathml/presentation/roots-expected.png:
* platform/gtk/mathml/presentation/row-alignment-expected.png:
* platform/gtk/mathml/presentation/row-alignment-expected.txt:
* platform/gtk/mathml/presentation/row-expected.png:
* platform/gtk/mathml/presentation/row-expected.txt:
* platform/gtk/mathml/presentation/style-expected.png:
* platform/gtk/mathml/presentation/subsup-expected.png:
* platform/gtk/mathml/presentation/subsup-expected.txt:
* platform/gtk/mathml/presentation/tables-expected.png:
* platform/gtk/mathml/presentation/tables-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Skip compositing/repaint/invalidations-on-composited-layers.html
dominik.rottsches@intel.com [Mon, 5 Nov 2012 09:33:50 +0000 (09:33 +0000)]
[EFL] Skip compositing/repaint/invalidations-on-composited-layers.html
https://bugs.webkit.org/show_bug.cgi?id=101181

Unreviewed EFL gardening.

Mark compositing/repaint/invalidations-on-composited-layers.html as
expected to fail since accelerated compositing is disabled by default
on EFL port.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 5 Nov 2012 09:23:05 +0000 (09:23 +0000)]
Unreviewed GTK gardening.

Skipping ENABLE_SUBPIXEL- and ENABLE_INPUT_TYPE_*-related testing
directories. These features are not enabled yet and most of the
tests fail.

Removing failure expectation for fast/files/workers/worker-apply-blob-url-to-xhr.html,
the issue was fixed in r132973.

Moving the skip entry for css3/device-adapt to the proper section.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow] ShadowRoot type is not set correctly.
shinyak@chromium.org [Mon, 5 Nov 2012 09:05:05 +0000 (09:05 +0000)]
[Shadow] ShadowRoot type is not set correctly.
https://bugs.webkit.org/show_bug.cgi?id=101188

Reviewed by Hajime Morita.

Source/WebCore:

ShadowRoot type is not set correctly in Release build. We have had to remove #ifndef block.

Test: fast/dom/shadow/shadowroot-type.html

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
* testing/Internals.cpp:
(WebCore::Internals::shadowRootType):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

* fast/dom/shadow/shadowroot-type-expected.txt: Added.
* fast/dom/shadow/shadowroot-type.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] The icon database path should be set by the client
commit-queue@webkit.org [Mon, 5 Nov 2012 08:55:40 +0000 (08:55 +0000)]
[EFL][WK2] The icon database path should be set by the client
https://bugs.webkit.org/show_bug.cgi?id=101182

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

No longer set the favicon database path in database instance getter.
Instead, a new ewk_context_favicon_database_directory_set() API
function was added to let the client set the icon database path.
This is needed because the icon database path can only be set once
and setting it unconditionally in the getter prevents the client
from setting it.

This will also avoid crashes in WebKitTestRunner since WKTR was
setting the path once and ewk_context was attempting to override it.

Note that the favicon database functionality is disabled until the
client sets its path.

* UIProcess/API/efl/ewk_context.cpp:
(Ewk_Context::ensureFaviconDatabase):
(Ewk_Context::setFaviconDatabaseDirectoryPath):
(Ewk_Context::faviconDatabase):
(ewk_context_favicon_database_directory_set):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/ewk_context_private.h:
(Ewk_Context):
* UIProcess/API/efl/ewk_favicon_database.cpp:
(Ewk_Favicon_Database::Ewk_Favicon_Database):
(Ewk_Favicon_Database::~Ewk_Favicon_Database):
(Ewk_Favicon_Database::iconURLForPageURL):
(Ewk_Favicon_Database::iconForPageURL):
(Ewk_Favicon_Database::getIconSurfaceSynchronously):
* UIProcess/API/efl/ewk_favicon_database_private.h:
(WebKit):
(Ewk_Favicon_Database::create):
(Ewk_Favicon_Database):
* UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
(TEST_F):

Tools:

Enable favicon database functionality in MiniBrowser since
it is used and it is no longer enabled by default.

* MiniBrowser/efl/main.c:
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBaseChooserOnlyDateAndTimeInputType should implement DateTimeChooserClient
tkent@chromium.org [Mon, 5 Nov 2012 08:22:02 +0000 (08:22 +0000)]
BaseChooserOnlyDateAndTimeInputType should implement DateTimeChooserClient
https://bugs.webkit.org/show_bug.cgi?id=101038

Reviewed by Hajime Morita.

Add DateTimeChooserClient behavior to BaseChooserOnlyDateAndTimeInputType.
It means that date/time input elements without
ENABLE_INPUT_MULTIPLE_FIELDS_UI can open date/time choosers by
DOMActivate event.

This patch doesn't change behavior yet because Chromimum-Android port
intercepts user events and doesn't deliver them to date/time input
elements. <http://crbug.com/159381>

* html/BaseChooserOnlyDateAndTimeInputType.cpp:
Add DateTimeChooserClient behavior. The code is similar to
PickerIndicatorElement.
(WebCore::BaseChooserOnlyDateAndTimeInputType::~BaseChooserOnlyDateAndTimeInputType):
Closes DateTimeChooser.
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
Open DateTimeChooser if
 - The element is not disabled,
 - The element is not read-only,
 - The element has a renderer,
 - This event is created by a user gesture, and
 - The element has no DateTimeChooser.
(WebCore::BaseChooserOnlyDateAndTimeInputType::detach):
Closes DateTimeChooser.
(WebCore::BaseChooserOnlyDateAndTimeInputType::didChooseValue):
Set a string value coming from a chooser to the input element.
(WebCore::BaseChooserOnlyDateAndTimeInputType::didEndChooser):
Clear m_dateTimeChooser when the chooser was closed.
(WebCore::BaseChooserOnlyDateAndTimeInputType::closeDateTimeChooser):
Requests to close the chooser.
* html/BaseChooserOnlyDateAndTimeInputType.h:
(BaseChooserOnlyDateAndTimeInputType):
 - Implement DateTimeChooserClient
 - Add closeDateTimeChooser helper function.
 - Add detach override.
 - Add m_dateTimeChooser.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):
Added. The code is moved from PickerIndicatorElement.cpp in order to
share it with BaseChooserOnlyDateAndTimeInputType.
* html/HTMLInputElement.h:
(HTMLInputElement): Declare setupDateTimeChooserParameters.
* html/shadow/PickerIndicatorElement.cpp:
(WebCore::PickerIndicatorElement::openPopup):
Move some code to HTMLInputElement::setupDateTimeChooserParameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-11-04 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 5 Nov 2012 08:04:04 +0000 (08:04 +0000)]
2012-11-04  Kent Tamura  <tkent@chromium.org>

        Move *-multiple-fields-appearance-*.html from fast/forms/*-multiple-fields/ to fast/forms/*/
        https://bugs.webkit.org/show_bug.cgi?id=101186

        Rubber-stamped by Kentaro Hara.

        The fast/forms/{date,month,time,week}-multiple-fields/
        {date,month,time,week}-multiple-fields-appearance-*.html tests don't
        depend on the multiple-fields UI, and should work for non
        multiple-fields configuration too. They should be moved to
        fast/forms/{date,month,time,week}/.

        * fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.txt: Removed.
        * fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic.html: Removed.
        * fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.txt: Removed.
        * fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n.html: Removed.
        * fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
        * fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html: Removed.
        * fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
        * fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html: Removed.
        * fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.txt: Removed.
        * fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html: Removed.
        * fast/forms/date/date-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.txt.
        * fast/forms/date/date-appearance-basic.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic.html.
        * fast/forms/date/date-appearance-l10n-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.txt.
        * fast/forms/date/date-appearance-l10n.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n.html.
        * fast/forms/date/date-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.txt.
        * fast/forms/date/date-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes.html.
        * fast/forms/date/date-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.txt.
        * fast/forms/date/date-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements.html.
        * fast/forms/date/date-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.txt.
        * fast/forms/date/date-appearance-style.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style.html.
        * fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.txt: Removed.
        * fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html: Removed.
        * fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.txt: Removed.
        * fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n.html: Removed.
        * fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
        * fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html: Removed.
        * fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
        * fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html: Removed.
        * fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.txt: Removed.
        * fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html: Removed.
        * fast/forms/month/month-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.txt.
        * fast/forms/month/month-appearance-basic.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic.html.
        * fast/forms/month/month-appearance-l10n-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.txt.
        * fast/forms/month/month-appearance-l10n.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n.html.
        * fast/forms/month/month-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.txt.
        * fast/forms/month/month-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes.html.
        * fast/forms/month/month-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.txt.
        * fast/forms/month/month-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements.html.
        * fast/forms/month/month-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.txt.
        * fast/forms/month/month-appearance-style.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style.html.
        * fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
        * fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Removed.
        * fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
        * fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html: Removed.
        * fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
        * fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html: Removed.
        * fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
        * fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: Removed.
        * fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
        * fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html: Removed.
        * fast/forms/time/time-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt.
        * fast/forms/time/time-appearance-basic.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html.
        * fast/forms/time/time-appearance-disabled-readonly-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt.
        * fast/forms/time/time-appearance-disabled-readonly.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html.
        * fast/forms/time/time-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt.
        * fast/forms/time/time-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html.
        * fast/forms/time/time-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt.
        * fast/forms/time/time-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html.
        * fast/forms/time/time-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt.
        * fast/forms/time/time-appearance-style.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html.
        * fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt: Removed.
        * fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html: Removed.
        * fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
        * fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html: Removed.
        * fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
        * fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html: Removed.
        * fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.txt: Removed.
        * fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html: Removed.
        * fast/forms/week/week-appearance-basic-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.txt.
        * fast/forms/week/week-appearance-basic.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic.html.
        * fast/forms/week/week-appearance-pseudo-classes-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.txt.
        * fast/forms/week/week-appearance-pseudo-classes.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes.html.
        * fast/forms/week/week-appearance-pseudo-elements-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.txt.
        * fast/forms/week/week-appearance-pseudo-elements.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements.html.
        * fast/forms/week/week-appearance-style-expected.txt: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.txt.
        * fast/forms/week/week-appearance-style.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style.html.
        * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
        * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
        * platform/chromium-linux/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-linux/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
        * platform/chromium-linux/fast/forms/month: Added.
        * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
        * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
        * platform/chromium-linux/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-linux/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
        * platform/chromium-linux/fast/forms/time: Added.
        * platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
        * platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-linux/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
        * platform/chromium-linux/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-linux/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
        * platform/chromium-linux/fast/forms/week: Added.
        * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-linux/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-linux/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
        * platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
        * platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-mac-lion/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
        * platform/chromium-mac-lion/fast/forms/month: Added.
        * platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
        * platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-mac-lion/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
        * platform/chromium-mac-lion/fast/forms/time: Added.
        * platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-mac-lion/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
        * platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-mac-lion/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
        * platform/chromium-mac-lion/fast/forms/week: Added.
        * platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-mac-lion/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/month: Added.
        * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/time: Added.
        * platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/week: Added.
        * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
        * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
        * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
        * platform/chromium-mac/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-mac/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
        * platform/chromium-mac/fast/forms/month: Added.
        * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
        * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
        * platform/chromium-mac/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-mac/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
        * platform/chromium-mac/fast/forms/time: Added.
        * platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
        * platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-mac/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
        * platform/chromium-mac/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-mac/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
        * platform/chromium-mac/fast/forms/week: Added.
        * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-mac/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-mac/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
        * platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
        * platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
        * platform/chromium-win-xp/fast/forms/month: Added.
        * platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
        * platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-win-xp/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
        * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png: Removed.
        * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-win/fast/forms/date/date-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-l10n-expected.png.
        * platform/chromium-win/fast/forms/date/date-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-win/fast/forms/date/date-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png.
        * platform/chromium-win/fast/forms/month: Added.
        * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png: Removed.
        * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-l10n-expected.png.
        * platform/chromium-win/fast/forms/month/month-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-win/fast/forms/month/month-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png.
        * platform/chromium-win/fast/forms/time: Added.
        * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
        * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-win/fast/forms/time/time-appearance-disabled-readonly-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png.
        * platform/chromium-win/fast/forms/time/time-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-win/fast/forms/time/time-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png.
        * platform/chromium-win/fast/forms/week: Added.
        * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png: Removed.
        * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png: Removed.
        * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png: Removed.
        * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png: Removed.
        * platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png.
        * platform/chromium-win/fast/forms/week/week-appearance-pseudo-classes-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png.
        * platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png.
        * platform/chromium-win/fast/forms/week/week-appearance-style-expected.png: Copied from LayoutTests/platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png.
        * platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the collapsing border code to handle mixed directionality at the row level
jchaffraix@webkit.org [Mon, 5 Nov 2012 07:55:28 +0000 (07:55 +0000)]
Fix the collapsing border code to handle mixed directionality at the row level
https://bugs.webkit.org/show_bug.cgi?id=101060

Reviewed by Ojan Vafai.

Source/WebCore:

After bug 87900, we support mixed directionality at the row-group level. For coherency
- as the underlying code didn't support it - we were artificially ignoring 'direction'
below the row-group. This change relaxes the restriction and patches the collapsing
borders code to query the right style and border.

Tests: fast/table/border-collapsing/table-ltr-rows-mixed-direction.html
       fast/table/border-collapsing/table-rtl-row-mixed-direction.html

* rendering/RenderTable.cpp:
(WebCore::RenderTable::tableStartBorderAdjoiningCell):
(WebCore::RenderTable::tableEndBorderAdjoiningCell):
Changed to query the row's direction.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::hasStartBorderAdjoiningTable):
(WebCore::RenderTableCell::hasEndBorderAdjoiningTable):
Added 2 helper functions. They determine if a specific cell's border
adjoins the table. This code is required as the last cell's end border
can be resolved against the start border.

(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
Updated these functions now that being the start / end column doesn't mean
that we have to resolve against the row / row-group / table's border.

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::styleForCellFlow):
Updated to return the row's style.

* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::borderAdjoiningStartCell):
(WebCore::RenderTableRow::borderAdjoiningEndCell):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::borderAdjoiningStartCell):
(WebCore::RenderTableSection::borderAdjoiningEndCell):
Updated these functions to work with mixed directionality.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::setLogicalPositionForCell):
Changed this function to use the section's direction. This is wrong and should be changed
once we properly fix the collapsing border code.

(WebCore::RenderTableSection::logicalRectForWritingModeAndDirection):
Added a FIXME.

* rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::width):
This is a bug in our implementation: we used to return a non-zero width for inexistant borders (per CSS 2.1,
'border-style: off | hidden' should have a 0 width). This is covered by our existing tests (among others by
fast/table/border-collapsing/last-cell-left-border-hidden-table-ltr-section-rtl.html).

LayoutTests:

* fast/table/border-collapsing/table-ltr-rows-mixed-direction-expected.html: Added.
* fast/table/border-collapsing/table-ltr-rows-mixed-direction.html: Added.
* fast/table/border-collapsing/table-rtl-row-mixed-direction-expected.html: Added.
* fast/table/border-collapsing/table-rtl-row-mixed-direction.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] do not blow up the capturing log
commit-queue@webkit.org [Mon, 5 Nov 2012 07:52:52 +0000 (07:52 +0000)]
Web Inspector: [Canvas] do not blow up the capturing log
https://bugs.webkit.org/show_bug.cgi?id=100752

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-04
Reviewed by Pavel Feldman.

Source/WebCore:

Clear obsolete calls in the canvas 2D capturing log in runtime.
Now we store in the log only minimum number of calls that are necessary to replay a
canvas 2D context. To achieve that we find in runtime those calls in the log that no
longer contribute to the final context state and remove them.
These are the rules according which we find and remove such calls:
- all PATH methods between a clip() call and beginPath() call can be removed
- all MATRIX methods before a restore() or setTransform() call but after any PATH or corresponding save() method
- all consecutive save() + restore() calls

Tests: inspector/profiler/canvas2d/canvas2d-api-changes.html
       inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html

* inspector/InjectedScriptCanvasModuleSource.js:
(.):

LayoutTests:

Added test for track Canvas 2D API changes, as well as basics for the capturing.

* inspector/profiler/canvas-profiler-test.js: Renamed from LayoutTests/inspector/profiler/webgl/webgl-profiler-test.js.
(initialize_CanvasWebGLProfilerTest.InspectorTest.enableCanvasAgent):
(initialize_CanvasWebGLProfilerTest):
(createWebGLContext):
(createCanvas2DContext):
* inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt: Added.
* inspector/profiler/canvas2d/canvas2d-api-changes.html: Added.
* inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics-expected.txt: Added.
* inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html: Added.
* inspector/profiler/webgl/webgl-profiler-get-error.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
kkristof@inf.u-szeged.hu [Mon, 5 Nov 2012 07:49:08 +0000 (07:49 +0000)]
[Qt] Unreviewed gardening.

Skip a new failing test introduced in r133428, because SHADOW_DOM is disabled.
Unskip a test that does not exist already.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-11-04

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 5 Nov 2012 07:30:44 +0000 (07:30 +0000)]
Unreviewed GTK gardening.

Adding failure expectations for accessibility/svg-remote-element,
fast/images/exif-orientation-image-document.html and
svg/animations/mozilla/animateMotion-mpath-targetChange-1.svg.
Rebaselining fast/images/repaint-subrect-grid.html, the new baseline
matches the one Mac port uses.

* platform/gtk/TestExpectations:
* platform/gtk/fast/images/repaint-subrect-grid-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow] ShadowRoot should have a method to return ShadowRootType.
shinyak@chromium.org [Mon, 5 Nov 2012 07:29:58 +0000 (07:29 +0000)]
[Shadow] ShadowRoot should have a method to return ShadowRootType.
https://bugs.webkit.org/show_bug.cgi?id=101178

Reviewed by Hajime Morita.

When we style PseudoCustomElement, we have to know ShadowRootType.
We would like to expose a method to get ShadowRootType also in Release mode.

This is a preparation patch for Bug 101170.

* dom/ShadowRoot.h:
(ShadowRoot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroduce Month class to calendar picker
keishi@webkit.org [Mon, 5 Nov 2012 07:13:27 +0000 (07:13 +0000)]
Introduce Month class to calendar picker
https://bugs.webkit.org/show_bug.cgi?id=101024

Reviewed by Kent Tamura.

Source/WebCore:

Month class needs to be introduced to implement a month picker. This
patch just introduces the Month class into the calendar picker without
changing the current behavior.

No new tests. Covered by existing calendar-picker-*.html tests.

* Resources/pagepopups/calendarPicker.js:
(Month.prototype.toLocaleString): Returns a localized month string.
(Month): Takes a Month object, number representing the month, or year and month numbers.
(Month.parse): Returns a new Month from an ISO month string.
(Month.createFromDate): Returns a new Month containing the given datetime.
(Month.prototype.equals): Returns true if the given month is the same.
(Month.prototype.previous): Returns the previous month.
(Month.prototype.next): Returns the next month.
(Month.prototype.startDate): Returns a datetime that is the start of this month. The value is inclusive.
(Month.prototype.endDate): Returns a datetime that is the end of this month. The value is exclusive.
(Month.prototype.valueOf): Returns a number representing the month.
(Month.prototype.toString): Returns an ISO month string.
(YearMonthController): Use Month object.
(YearMonthController.prototype.attachTo): Year 275760 ends in September so use the year before to measure the label width.
(YearMonthController.prototype.setMonth): Take a month object.
(YearMonthController.prototype._redraw): Use ISO month string for element.dataset.value.
(YearMonthController.prototype._handleYearMonthChange):
(YearMonthController.prototype.moveRelatively):
(DaysTable): Use Month object.
(DaysTable.prototype._renderMonth): Take a month object. Testing for isNaN is moved up to fix a bug when showing September, 275760.
(DaysTable.prototype._navigateToMonth): Take a month object.
(DaysTable.prototype._navigateToMonthWithAnimation): Take a month object.
(DaysTable.prototype.navigateToMonthAndKeepSelectionPosition): Take a month object.
(DaysTable.prototype.selectDate):
(DaysTable.prototype._maybeSetPreviousMonth): Use Month object to calculate the previous month.
(DaysTable.prototype._maybeSetNextMonth): Use Month object to calculate the next month.

LayoutTests:

* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html: Adjust the expectation because we changed the month string format.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove obsolete tests for date/time input types
tkent@chromium.org [Mon, 5 Nov 2012 06:17:04 +0000 (06:17 +0000)]
Remove obsolete tests for date/time input types
https://bugs.webkit.org/show_bug.cgi?id=98783

Reviewed by Kentaro Hara.

*-input-visible-string.html and *-stepup-stepdown-from-renderer.html are
unnecessary and should be removed because they depend on textfield
behavior, and the date/time input types no longer have textfield
behavior on any platforms.

* fast/forms/datetime/datetime-input-visible-string-expected.txt: Removed.
* fast/forms/datetime/datetime-input-visible-string.html: Removed.
* fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/datetimelocal/datetimelocal-input-visible-string-expected.txt: Removed.
* fast/forms/datetimelocal/datetimelocal-input-visible-string.html: Removed.
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/month/month-input-visible-string-expected.txt: Removed.
* fast/forms/month/month-input-visible-string.html: Removed.
* fast/forms/month/month-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/month/month-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/time/time-input-visible-string-expected.txt: Removed.
* fast/forms/time/time-input-visible-string.html: Removed.
* fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/time/time-stepup-stepdown-from-renderer.html: Removed.
* fast/forms/week/week-input-visible-string-expected.txt: Removed.
* fast/forms/week/week-input-visible-string.html: Removed.
* fast/forms/week/week-stepup-stepdown-from-renderer-expected.txt: Removed.
* fast/forms/week/week-stepup-stepdown-from-renderer.html: Removed.
* platform/chromium-android/fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Removed.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/datetime/datetime-input-visible-string-expected.txt: Removed.
* platform/chromium/fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Removed.
* platform/chromium/fast/forms/datetimelocal/datetimelocal-input-visible-string-expected.txt: Removed.
* platform/chromium/fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: Removed.
* platform/chromium/fast/forms/month/month-input-visible-string-expected.txt: Removed.
* platform/chromium/fast/forms/month/month-stepup-stepdown-from-renderer-expected.txt: Removed.
* platform/chromium/fast/forms/time/time-input-visible-string-expected.txt: Removed.
* platform/chromium/fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Removed.
* platform/chromium/fast/forms/week/week-input-visible-string-expected.txt: Removed.
* platform/chromium/fast/forms/week/week-stepup-stepdown-from-renderer-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Use _LIBRARIES instead of _LIBRARY
commit-queue@webkit.org [Mon, 5 Nov 2012 05:33:55 +0000 (05:33 +0000)]
[EFL] Use _LIBRARIES instead of _LIBRARY
https://bugs.webkit.org/show_bug.cgi?id=101042

Patch by Halton Huo <halton.huo@intel.com> on 2012-11-04
Reviewed by Gyuyoung Kim.

In CMake Find files, _LIBRARY is intended for internal use, should
use _LIBRARIES instead.

Source/WebCore:

* PlatformEfl.cmake: s/_LIBRARY}/_LIBRARIES}

Source/WebKit:

* PlatformEfl.cmake: s/_LIBRARY}/_LIBRARIES}

Source/WebKit2:

* PlatformEfl.cmake: s/_LIBRARY}/_LIBRARIES}

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Skip a fast/images/repaint-subrect-grid.html test case after r133322
commit-queue@webkit.org [Mon, 5 Nov 2012 05:22:35 +0000 (05:22 +0000)]
[EFL][DRT] Skip a fast/images/repaint-subrect-grid.html test case after r133322
https://bugs.webkit.org/show_bug.cgi?id=101175

Unreviewed gardening.

fast/images/repaint-subrect-grid.html is failing on WK1 debug bot.

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-04

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBaseline JIT should use structure watchpoints whenever possible
fpizlo@apple.com [Mon, 5 Nov 2012 03:13:26 +0000 (03:13 +0000)]
Baseline JIT should use structure watchpoints whenever possible
https://bugs.webkit.org/show_bug.cgi?id=101146

Reviewed by Sam Weinig.

No speed-up yet except on toy programs. I think that it will start to show
speed-ups with https://bugs.webkit.org/show_bug.cgi?id=101147, which this is
a step towards.

* jit/JIT.h:
(JIT):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
(JSC::JIT::addStructureTransitionCheck):
(JSC):
(JSC::JIT::testPrototype):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShadow DOM should be able to be disabled per context.
morrita@google.com [Mon, 5 Nov 2012 03:09:45 +0000 (03:09 +0000)]
Shadow DOM should be able to be disabled per context.
https://bugs.webkit.org/show_bug.cgi?id=101173

Reviewed by Dimitri Glazkov.

Source/WebCore:

This change pulls back relevant bits from r131549. Note that if
the the port enables runtime Shadow DOM flag, this can cause slow
down on some Chromium page cycler test cases (which r131549
attempted to fix).

This change is temporal and the flags should be switched back from
ContextFeatures to RuntimeEnabledFeatures once it gains sufficent
stability.

* dom/ContextFeatures.cpp:
(WebCore::ContextFeatures::shadowDOMEnabled):
(WebCore):
* dom/ContextFeatures.h:
* dom/Position.cpp:
(WebCore::Position::Position):
(WebCore::Position::findParent):
* dom/TreeScope.cpp:
(WebCore::TreeScope::getSelection):
* html/HTMLTagNames.in:
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::contentTagName):
* page/DOMWindow.idl:

Source/WebKit/chromium:

* src/ContextFeaturesClientImpl.cpp:
(WebKit::ContextFeaturesClientImpl::askIfIsEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow] Implement custom pseudo-elements styling
shinyak@chromium.org [Mon, 5 Nov 2012 03:04:57 +0000 (03:04 +0000)]
[Shadow] Implement custom pseudo-elements styling
https://bugs.webkit.org/show_bug.cgi?id=100812

Reviewed by Hajime Morita.

Source/WebCore:

Instead of using ElementRareData::m_shadowPseudoId, we use 'pseudo' attribute.

Later we would like to remove Element::shadowPseudoId and Element::setShadowPseudoId
and use pseudo()/setPseudo() instead (Bug 101171).

Test: fast/dom/shadow/styling-pseudo-attribute.html

* dom/Element.cpp:
(WebCore::Element::shadowPseudoId):
(WebCore::Element::setShadowPseudoId):
* dom/ElementRareData.cpp:
(WebCore::ElementRareData::reportMemoryUsage):
* dom/ElementRareData.h:
(ElementRareData):

LayoutTests:

* fast/dom/shadow/styling-pseudo-attribute-expected.html: Added.
* fast/dom/shadow/styling-pseudo-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBaseChooserOnlyDateAndTimeInputType should have BaseClickableWithKeyInputType behavior
tkent@chromium.org [Sun, 4 Nov 2012 23:16:13 +0000 (23:16 +0000)]
BaseChooserOnlyDateAndTimeInputType should have BaseClickableWithKeyInputType behavior
https://bugs.webkit.org/show_bug.cgi?id=101039

Reviewed by Hajime Morita.

Add BaseClickableWithKeyInputType behavior to
BaseChooserOnlyDateAndTimeInputType. It means date/time input types
without ENABLE_INPUT_MULTIPLE_FIELDS_UI receive DOMActivate events by
pressing space or enter key. They're going to open a date/time chooser
by DOMActive event.

Because BaseChooserOnlyDateAndTimeInputType inherits from
BaseDateAndTimeInputType, it can't inherit
BaseClickableWithKeyInputType. So, this patch adds static helper
functions to BaseClickableWithKeyInputType, and
BaseChooserOnlyDateAndTimeInputType uses them.

This patch doesn't change behavior yet because Chromimum-Android port
intercepts user events and doesn't deliver them to date/time input
elements.

* html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent):
Add an empty implementation with a FIXME comment.
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeydownEvent):
Add BaseClickableWithKeyInputType behavior by a helper function.
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeypressEvent): Ditto.
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleKeyupEvent): Ditto.
(WebCore::BaseChooserOnlyDateAndTimeInputType::accessKeyAction): Ditto.
* html/BaseChooserOnlyDateAndTimeInputType.h:
(BaseChooserOnlyDateAndTimeInputType): Add function declarations.
* html/BaseClickableWithKeyInputType.cpp:
Add static helper functions, and existing member functions use them.
* html/BaseClickableWithKeyInputType.h:
(BaseClickableWithKeyInputType): Add declarations of the helper functions.
* html/InputType.h:
(InputType): Make dispatchSimulatedClickIfActive public because it is
called from a helper function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r133416.
commit-queue@webkit.org [Sun, 4 Nov 2012 22:30:25 +0000 (22:30 +0000)]
Unreviewed, rolling out r133416.
http://trac.webkit.org/changeset/133416
https://bugs.webkit.org/show_bug.cgi?id=101169

Broke world selection by right click (Requested by rniwa on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-04

Source/WebCore:

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
(WebCore::EventHandler::sendContextMenuEvent):

LayoutTests:

* fast/events/touch/gesture/disabled-input-text-selection-expected.txt: Removed.
* fast/events/touch/gesture/disabled-input-text-selection.html: Removed.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpose security origin to BundleFrame
jonlee@apple.com [Sun, 4 Nov 2012 22:26:02 +0000 (22:26 +0000)]
Expose security origin to BundleFrame
https://bugs.webkit.org/show_bug.cgi?id=101139
<rdar://problem/12629900>

Reviewed by Darin Adler.

Create a WebSecurityOrigin instance, sharing the security origin instance
that comes directly from the frame's document. We can do this because the
WK2 API only retrieves information about the origin, and because those
results are returned as copies. The security origin holds no references
that could lead to a retain cycle, avoiding the possibility that the
injected bundle accidentally keeps something alive.

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedAPI): Create copied API for WebCore::SecurityOrigin
instances.
* Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::create): Add a new create() function that
takes a PassRefPtr to a WebCore SecurityOrigin instance.
(WebKit::WebSecurityOrigin::createFromString): Refactor to use new create()
function.
(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier): Refactor to
use new create() function.
(WebKit::WebSecurityOrigin::create): Refactor to use new create()
function.
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopySecurityOrigin): Add function to retrieve the security
origin as a WK2 API object.
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMissing ASCIILiteral in a place of accessibility
gyuyoung.kim@samsung.com [Sun, 4 Nov 2012 17:27:45 +0000 (17:27 +0000)]
Missing ASCIILiteral in a place of accessibility
https://bugs.webkit.org/show_bug.cgi?id=101160

Reviewed by Darin Adler.

ASCIILiteral usage is being missed in a spot of accessibliity.

* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaTimeDisplay::accessibilityDescription):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unify transforms in WK2
kenneth@webkit.org [Sun, 4 Nov 2012 16:02:29 +0000 (16:02 +0000)]
[EFL] Unify transforms in WK2
https://bugs.webkit.org/show_bug.cgi?id=101051

Reviewed by Simon Hausmann.

Move our transforms into EwkViewImpl and use them
everywhere needed.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::smartData):
(EwkViewImpl::transformFromScene):
(EwkViewImpl::transformToScene):
(EwkViewImpl::transformToScreen):
(EwkViewImpl::displayTimerFired):
* UIProcess/API/efl/EwkViewImpl.h:
(WebCore):
(EwkViewImpl):
(EwkViewImpl::pageViewportControllerClient):
(EwkViewImpl::pageViewportController):
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(ewk_view_feed_touch_event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add a now-failing test. Unreviewed.
senorblanco@chromium.org [Sun, 4 Nov 2012 14:57:52 +0000 (14:57 +0000)]
[chromium] Add a now-failing test.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] setPlatformStrategies always asserts after r132744
kbalazs@webkit.org [Sun, 4 Nov 2012 14:07:02 +0000 (14:07 +0000)]
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838

Reviewed by Simon Hausmann.

Reland with build fixes.

Source/WebCore:

The problem here is that we use QWebSettings::clearMemoryCaches, a WebKit1 API
from the injected bundle, which calls initializeWebCoreQt and it sets the platform
strategies to the one for WebKit1. We should stop using WebKit1 API's from WebKit2
code. In order to keep the behavior, this patch adds exported helpers to WebCore
that can be used from DumpRenderTree and WebKitTestRunner. This is the same idea
as WebCoreTestSupport but these helpers are specific to Qt. Technically we could
add it to the WebKit1 API for the time being, but my goal was to move in the direction
of removing the WebKit1 dependency from WebKitTestRunner. We only build the file
in non production mode.

Basically covered by all tests.

* Target.pri:
* WebCore.pri: We need to link against fontconfig (only in non-production mode) since
initializeTestFonts uses it.
* platform/qt/QtTestSupport.cpp: Added. I choose GPL license because code from qwebsettings.cpp
is also under that.
(WebKit):
(WebKit::QtTestSupport::clearMemoryCaches): This is basically a copy of QWebSettings::clearMemoryCaches
without calling initializeWebCoreQt.
(WebKit::QtTestSupport::initializeTestFonts): I moved this code here as well now that we have to expose
symbols from WebCore anyway. The advantage is that now we don't have to build it twice and we don't need
additional files to forward it from the directory of DumpRenderTree for WebKitTestRunner.
I added a call to FontCace::invalidate in the case when the font set has been changed so that it will do
the job even if we would stop clearing all caches between tests. Also moved the call to
QFontDatabase::removeAllApplicationFonts from callers to here.
* platform/qt/QtTestSupport.h:
(WebKit):
(QtTestSupport):

Tools:

Turned test runners to use the new QtTestSupport.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
* MiniBrowser/qt/MiniBrowser.pro:
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize):  Removed the comment from here
because it was just lying, apparently two times. First, it is not incorrect
to reinitialize our font set and clear font caches, it is what the tests
expect. Second, the use of QRawFont has nothing to do with the font cache.
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoColor-profile property triggers assert
fmalita@chromium.org [Sun, 4 Nov 2012 13:26:58 +0000 (13:26 +0000)]
Color-profile property triggers assert
https://bugs.webkit.org/show_bug.cgi?id=101080

Reviewed by Dirk Schulze.

Source/WebCore:

CSSPropertyColorProfile is not handled in StyleResolver::applySVGProperty(), triggering the
unimplemented property assert. Adding a stub entry to avoid that.

Test: svg/css/color-profile-crash.html

* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):

LayoutTests:

* svg/css/color-profile-crash-expected.txt: Added.
* svg/css/color-profile-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed weekend gardening, skip failing tests, update expected files.
ossy@webkit.org [Sun, 4 Nov 2012 12:30:46 +0000 (12:30 +0000)]
[Qt][WK2] Unreviewed weekend gardening, skip failing tests, update expected files.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Updated after r133019.
* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Updated after r133019.
* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Updated after r133019.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed weekend gardening, skip one more failing test.
ossy@webkit.org [Sun, 4 Nov 2012 10:55:33 +0000 (10:55 +0000)]
[Qt] Unreviewed weekend gardening, skip one more failing test.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed weekend gardening, skip new failing tests.
ossy@webkit.org [Sun, 4 Nov 2012 10:31:25 +0000 (10:31 +0000)]
[Qt] Unreviewed weekend gardening, skip new failing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnable to copy text on disabled input fields on long press gesture
kaustubh@motorola.com [Sun, 4 Nov 2012 09:20:13 +0000 (09:20 +0000)]
Unable to copy text on disabled input fields on long press gesture
https://bugs.webkit.org/show_bug.cgi?id=99698

Reviewed by Ryosuke Niwa.

Text from disabled input/text should be allowed to select. Replaced isContentEditable()
with canStartSelection()

Source/WebCore:

Test: fast/events/touch/gesture/disabled-input-text-selection.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureLongPress):

LayoutTests:

* fast/events/touch/gesture/disabled-input-text-selection-expected.txt: Added.
* fast/events/touch/gesture/disabled-input-text-selection.html: Added.
* platform/chromium/TestExpectations: Not Valid for chromium desktop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] udis86_itab.c is always regenerated
ossy@webkit.org [Sun, 4 Nov 2012 08:07:41 +0000 (08:07 +0000)]
[Qt] udis86_itab.c is always regenerated
https://bugs.webkit.org/show_bug.cgi?id=100756

Reviewed by Simon Hausmann.

* DerivedSources.pri: Generate sources to the generated directory.
* disassembler/udis86/differences.txt:
* disassembler/udis86/itab.py: Add --outputDir option.
(UdItabGenerator.__init__):
(genItabH):
(genItabC):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r133381.
ossy@webkit.org [Sun, 4 Nov 2012 08:03:03 +0000 (08:03 +0000)]
Unreviewed, rolling out r133381.
http://trac.webkit.org/changeset/133381
https://bugs.webkit.org/show_bug.cgi?id=101161

It made webkit-patch useless (Requested by Ossy_weekend on

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-04

* Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._create_scratch_directory):
(AutoInstaller._install):
(AutoInstaller.install):
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook.__init__):
(AutoinstallImportHook._install_pylint):
(AutoinstallImportHook._install_coverage):
(AutoinstallImportHook._install_eliza):
(AutoinstallImportHook._install):
* Scripts/webkitpy/thirdparty/__init___unittest.py:
(ThirdpartyTest.test_import_hook.MockImportHook.__init__):
(ThirdpartyTest.test_import_hook):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove some no-longer-flaky tests. Unreviewed.
senorblanco@chromium.org [Sun, 4 Nov 2012 07:43:52 +0000 (07:43 +0000)]
[chromium] Remove some no-longer-flaky tests.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove some a no-longer-flaky test. Unreviewed.
senorblanco@chromium.org [Sun, 4 Nov 2012 01:06:56 +0000 (01:06 +0000)]
[chromium] Remove some a no-longer-flaky test.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r133403, r133404, and r133409.
kbalazs@webkit.org [Sun, 4 Nov 2012 00:57:14 +0000 (00:57 +0000)]
Unreviewed, rolling out r133403, r133404, and r133409.
http://trac.webkit.org/changeset/133403
http://trac.webkit.org/changeset/133404
http://trac.webkit.org/changeset/133409
https://bugs.webkit.org/show_bug.cgi?id=101158

"Broke tests" (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-03

Source/WebCore:

* Target.pri:
* WebCore.pri:
* platform/qt/QtTestSupport.h: Removed.

Tools:

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
(WebKit):
(WebKit::initializeTestFonts):
* DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
(WebKit):
* MiniBrowser/qt/MiniBrowser.pro:
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize):
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of USE(CFURLSTORAGESESSIONS)
ap@apple.com [Sun, 4 Nov 2012 00:35:30 +0000 (00:35 +0000)]
Get rid of USE(CFURLSTORAGESESSIONS)
https://bugs.webkit.org/show_bug.cgi?id=101131

Reviewed by Sam Weinig.

Source/WebCore:

This is always enabled on CFNetwork based platforms.

* WebCore.exp.in:
* page/Settings.cpp:
(WebCore::Settings::setPrivateBrowsingEnabled):
* platform/mac/CookieJar.mm:
(WebCore::cookies):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
* platform/network/ResourceHandle.h:
(ResourceHandle):
* platform/network/cf/CookieStorageCFNet.cpp:
(WebCore):
(WebCore::currentCFHTTPCookieStorage):
* platform/network/cf/CookieStorageCFNet.h:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
(WebCore::makeFinalRequest):
(WebCore::ResourceHandle::willSendRequest):
(WebCore):
* platform/network/cf/ResourceRequest.h:
(ResourceRequest):
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore):
* platform/network/mac/CookieStorageMac.mm:
(WebCore::setCookieStoragePrivateBrowsingEnabled):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::shouldRelaxThirdPartyCookiePolicy):
(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::willSendRequest):
(WebCore):
* platform/network/mac/ResourceRequestMac.mm:
(WebCore):
(WebCore::ResourceRequest::setStorageSession):

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataUseFeatures.in: Not sure what this list is about, but
CFURLSTORAGESESSIONS probably doesn't need to stay here.

Source/WebKit/mac:

* WebView/WebPreferences.mm:
(+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
(+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
* WebView/WebView.mm:
(-[WebView _cachedResponseForURL:]):

Source/WebKit2:

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/Cookies/mac/WebCookieManagerMac.mm:
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::switchNetworkLoaderToNewTestingSession):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::cachedResponseForURL):
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::cachedResponseForURL):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformClearResourceCaches):

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] setPlatformStrategies always asserts after r132744
kbalazs@webkit.org [Sun, 4 Nov 2012 00:14:20 +0000 (00:14 +0000)]
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838

2nd unreviewed buildfix.

* MiniBrowser/qt/MiniBrowserApplication.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove some now-passing tests. Unreviewed.
senorblanco@chromium.org [Sun, 4 Nov 2012 00:09:12 +0000 (00:09 +0000)]
[chromium] Remove some now-passing tests.  Unreviewed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] setPlatformStrategies always asserts after r132744
kbalazs@webkit.org [Sat, 3 Nov 2012 23:47:28 +0000 (23:47 +0000)]
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838

Unreviewed buildfix.

* WebKitTestRunner/Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] setPlatformStrategies always asserts after r132744
kbalazs@webkit.org [Sat, 3 Nov 2012 22:52:04 +0000 (22:52 +0000)]
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838

Reviewed by Simon Hausmann.

Reland with build fix.

Source/WebCore:

The problem here is that we use QWebSettings::clearMemoryCaches, a WebKit1 API
from the injected bundle, which calls initializeWebCoreQt and it sets the platform
strategies to the one for WebKit1. We should stop using WebKit1 API's from WebKit2
code. In order to keep the behavior, this patch adds exported helpers to WebCore
that can be used from DumpRenderTree and WebKitTestRunner. This is the same idea
as WebCoreTestSupport but these helpers are specific to Qt. Technically we could
add it to the WebKit1 API for the time being, but my goal was to move in the direction
of removing the WebKit1 dependency from WebKitTestRunner. We only build the file
in non production mode.

Basically covered by all tests.

* Target.pri:
* WebCore.pri: We need to link against fontconfig (only in non-production mode) since
initializeTestFonts uses it.
* platform/qt/QtTestSupport.cpp: Added. I choose GPL license because code from qwebsettings.cpp
is also under that.
(WebKit):
(WebKit::QtTestSupport::clearMemoryCaches): This is basically a copy of QWebSettings::clearMemoryCaches
without calling initializeWebCoreQt.
(WebKit::QtTestSupport::initializeTestFonts): I moved this code here as well now that we have to expose
symbols from WebCore anyway. The advantage is that now we don't have to build it twice and we don't need
additional files to forward it from the directory of DumpRenderTree for WebKitTestRunner.
I added a call to FontCace::invalidate in the case when the font set has been changed so that it will do
the job even if we would stop clearing all caches between tests. Also moved the call to
QFontDatabase::removeAllApplicationFonts from callers to here.
* platform/qt/QtTestSupport.h:
(WebKit):
(QtTestSupport):

Tools:

Turned test runners to use the new QtTestSupport.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
* MiniBrowser/qt/MiniBrowser.pro:
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize):  Removed the comment from here
because it was just lying, apparently two times. First, it is not incorrect
to reinitialize our font set and clear font caches, it is what the tests
expect. Second, the use of QRawFont has nothing to do with the font cache.
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] New baselines for no-longer-flaky tests. Unreviewed.
senorblanco@chromium.org [Sat, 3 Nov 2012 22:36:29 +0000 (22:36 +0000)]
[chromium] New baselines for no-longer-flaky tests.  Unreviewed.

* platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-mac-lion/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac-lion/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/chromium-mac-lion/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium/TestExpectations:
* platform/efl-wk1/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png.
* platform/efl-wk1/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Sat, 3 Nov 2012 22:27:24 +0000 (22:27 +0000)]
[chromium] Unreviewed gardening.

* platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r133397.
kbalazs@webkit.org [Sat, 3 Nov 2012 21:42:48 +0000 (21:42 +0000)]
Unreviewed, rolling out r133397.
http://trac.webkit.org/changeset/133397
https://bugs.webkit.org/show_bug.cgi?id=101155

"Broke Qt. No way to force the damn bots to do a clean build.
I'm giving up." (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-03

Source/WebCore:

* Target.pri:
* WebCore.pri:
* platform/qt/QtTestSupport.h: Removed.

Tools:

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
(WebKit):
(WebKit::initializeTestFonts):
* DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
(WebKit):
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize):
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeculative fix to eliminate flakiness in
senorblanco@chromium.org [Sat, 3 Nov 2012 20:52:17 +0000 (20:52 +0000)]
Speculative fix to eliminate flakiness in
css3/filters/blur-filter-page-scroll-self.html
https://bugs.webkit.org/show_bug.cgi?id=91620.
Suspicion is that a prior test is setting
window.internals.settings.setEnableCompositingForFixedPosition(true),
causing this test to be intermittely run on the GPU, giving different
pixel results depending on test order.

Reviewed by Jochen Eisinger.

Covered by css3/filters/blur-filter-page-scroll-self.html

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
(Backup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r132858): Crash below -[DOMElement setClassName:] when called with a...
mrowe@apple.com [Sat, 3 Nov 2012 20:48:08 +0000 (20:48 +0000)]
REGRESSION (r132858): Crash below -[DOMElement setClassName:] when called with a nil string

Reviewed by Anders Carlsson.

The changes in r132858 introduced an overload of AtomicString::add for CFStrings. However, the overload
that was introduced is not null safe.

* platform/text/cf/AtomicStringCF.cpp:
(WTF::AtomicString::add): Handle a null string by returning a null StringImpl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] setPlatformStrategies always asserts after r132744
kbalazs@webkit.org [Sat, 3 Nov 2012 20:36:05 +0000 (20:36 +0000)]
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838

Reviewed by Simon Hausmann.

Source/WebCore:

The problem here is that we use QWebSettings::clearMemoryCaches, a WebKit1 API
from the injected bundle, which calls initializeWebCoreQt and it sets the platform
strategies to the one for WebKit1. We should stop using WebKit1 API's from WebKit2
code. In order to keep the behavior, this patch adds exported helpers to WebCore
that can be used from DumpRenderTree and WebKitTestRunner. This is the same idea
as WebCoreTestSupport but these helpers are specific to Qt. Technically we could
add it to the WebKit1 API for the time being, but my goal was to move in the direction
of removing the WebKit1 dependency from WebKitTestRunner. We only build the file
in non production mode.

Basically covered by all tests.

* Target.pri:
* WebCore.pri: We need to link against fontconfig (only in non-production mode) since
initializeTestFonts uses it.
* platform/qt/QtTestSupport.cpp: Added. I choose GPL license because code from qwebsettings.cpp
is also under that.
(WebKit):
(WebKit::QtTestSupport::clearMemoryCaches): This is basically a copy of QWebSettings::clearMemoryCaches
without calling initializeWebCoreQt.
(WebKit::QtTestSupport::initializeTestFonts): I moved this code here as well now that we have to expose
symbols from WebCore anyway. The advantage is that now we don't have to build it twice and we don't need
additional files to forward it from the directory of DumpRenderTree for WebKitTestRunner.
I added a call to FontCace::invalidate in the case when the font set has been changed so that it will do
the job even if we would stop clearing all caches between tests. Also moved the call to
QFontDatabase::removeAllApplicationFonts from callers to here.
* platform/qt/QtTestSupport.h:
(WebKit):
(QtTestSupport):

Tools:

Turned test runners to use the new QtTestSupport.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize): Removed the comment from here
because it was just lying, apparently two times. First, it is not incorrect
to reinitialize our font set and clear font caches, it is what the tests
expect. Second, the use of QRawFont has nothing to do with the font cache.
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement HTMLFormElement#requestAutocomplete and associated events
commit-queue@webkit.org [Sat, 3 Nov 2012 16:08:40 +0000 (16:08 +0000)]
Implement HTMLFormElement#requestAutocomplete and associated events
https://bugs.webkit.org/show_bug.cgi?id=100557

Patch by Dan Beam <dbeam@chromium.org> on 2012-11-03
Reviewed by Adam Barth.

Source/WebCore:

Implements an initial version of the proposal for interactive autocomplete outlined in this email:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037711.html

The goal of this patch is to allow web authors to call formElement.requestAutocomplete(); after subscribing for
autocomplete/autocompleteerror events on formElement. If the form's [autocomplete] attribute is "off" an
error will be dispatched. Otherwise, a request will be issued to the FrameLoaderClient.  At the moment, the
implementation in Chrome (https://codereview.chromium.org/11270018/) will simply dispatch an error until the
UI on Chrome's side is built. Both autocomplete and autocompleteerror events will be dispatched asynchronously
after a small delay to behave consistently in all situations and implementations.

Currently this is behind the feature flag REQUEST_AUTOCOMPLETE, which is disabled.

Test: fast/forms/form-request-autocomplete.html

* dom/EventNames.h:
(WebCore):

Added autocomplete and autocompleteerror events. The autocomplete event is dispatched after a user adds more
information to a form using the future UI. This is not currently dispatched in any implementation (including Chrome)
but will be in the future. The autocompleteerror event is dispatched when the form has [autocomplete="off"] on the
node being asked for an interactive autocomplete. The user agent may also dispatch this event if it doesn't implement
this API but has turned on the feature flag, can't currently show an autocomplete UI (e.g. running headlessly or in
an HTML notification, security concerns, or any other reason it desires).

* html/HTMLAttributeNames.in:

Added onautocomplete and onautocompleteerror attributes so they can be parsed when creating form elements and used
as event listeners. For example:

  <form onautocomplete="/* when autocomplete succeeds */" autocompleteerror="/* when autocomplete fails */">

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore):

Added m_requestAutocompleteTimer (a timer that's used to dispatch events asynchronously) to the initializer list that
triggers requestAutocompleteTimerFired when it times out.

(WebCore::HTMLFormElement::requestAutocomplete):

Called when HTMLFormElement#requestAutocomplete is called from JS (also see HTMLFormElement.idl) and decides whether
to dispatch an error and exit early (in the case where autocomplete="off") or pass the request on to the
FrameLoaderClient.

(WebCore::HTMLFormElement::finishRequestAutocomplete):

Called when the request for an interactive autocomplete is finished with either a success or error result. This
causes an event to queue and fired after a 0 second delay. Events are owned by HTMLFormElement and reference the
target element (this) until fired.

(WebCore::HTMLFormElement::requestAutocompleteTimerFired):

Called when the event timer runs out to pump the queue of current events. Events are released on dispatch.

(WebCore::HTMLFormElement::parseAttribute):

Encountering onautocomplete or onautocompleteerror attributes while parsing HTMLFormElements now adds event listeners
for autocomplete an autocompleteerror events (respectively) to dispatch the value of the attribute as a script.

* html/HTMLFormElement.h:
(HTMLFormElement):

Added various methods and data members as required by the implementation.

* html/HTMLFormElement.idl:

Added the method requestAutocomplete and associated DOM event handler attributes (onautocomplete/onautocompleteerror)
to HTMLFormElement's public DOM API (unprefixed, as per Ian Hickson's advice). All are require the Conditional
REQUEST_AUTOCOMPLETE to be enabled to be activated.

* loader/EmptyClients.cpp:
(WebCore):
(WebCore::EmptyFrameLoaderClient::didRequestAutocomplete):

Added noop implementation for FrameLoader::didRequestAutocomplete.

* loader/EmptyClients.h:
(EmptyFrameLoaderClient):

Added FrameLoader::didRequestAutocomplete to EmptyFrameLoaderClient interface.

* loader/FrameLoaderClient.h:
(FrameLoaderClient):

Added noop implementation to FrameLoaderClient interface (which is implemented chromium's FrameLoaderLoaderImpl.cpp).

Source/WebKit/chromium:

Implements an initial version of the proposal for interactive autocomplete outlined in this email:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037711.html

The goal of this patch is to allow web authors to call formElement.requestAutocomplete(); after subscribing for
autocomplete/autocompleteerror events on formElement. If the form's [autocomplete] attribute is "off" an
error will be dispatched. Otherwise, a request will be issued to the FrameLoaderClient.  At the moment, the
implementation in Chrome (https://codereview.chromium.org/11270018/) will simply dispatch an error until the
UI on Chrome's side is built. Both autocomplete and autocompleteerror events will be dispatched asynchronously
after a small delay to behave consistently in all situations and implementations.

Currently this is behind the feature flag REQUEST_AUTOCOMPLETE, which is disabled.

Test: fast/forms/form-request-autocomplete.html

* public/WebAutofillClient.h:
(WebKit):
(WebAutofillClient):
(WebKit::WebAutofillClient::didRequestAutocomplete):

Added WebAutofillClient::didRequestAutocomplete to chrome's public WebKit interface.

* public/WebFormElement.h:

Added an enum that matches HTMLFormElement::AutocompleteResult (and added compile time assert) and a public method
(WebFormElement::finishRequestAutocomplete) to WebFormElement's public interface.

* src/AssertMatchingEnums.cpp:

Added a compile time assert to guarantee the HTMLFormElement::AutocompleteResult enum matches the
WebFormElement::AutocompleteResult enum.

* src/FrameLoaderClientImpl.cpp:
(WebKit):
(WebKit::FrameLoaderClientImpl::didRequestAutocomplete):

Implemented the added FrameLoaderClient::didRequestAutocomplete, which simply passes through to the
WebAutofillClient.

* src/FrameLoaderClientImpl.h:
(FrameLoaderClientImpl):

Implementing FrameLoaderClient::didRequestAutocomplete.

* src/WebFormElement.cpp:
(WebKit::WebFormElement::finishRequestAutocomplete):
(WebKit):

Added WebFormElement::finishRequestAutocomplete to allow chromium's renderer a public API to call to finish the
autocomplete request on a WebFormElement.

LayoutTests:

Adds tests for an initial implementation of the proposal for interactive autocomplete outlined in this email:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037711.html

The goal of this patch is to allow web authors to call formElement.requestAutocomplete(); after subscribing
for autocomplete/autocompleteerror events on formElement. If the form's [autocomplete] attribute is "off" an
error will be dispatched. Otherwise, a request will be issued to the FrameLoaderClient. At the moment, the
implementation in Chrome (https://codereview.chromium.org/11270018/) will simply dispatch an error until the
UI on Chrome's side is built. Both autocomplete and autocompleteerror events will be dispatched asynchronously
after a small delay to behave consistently in all situations and implementations.

Currently the implementation is behind the feature flag REQUEST_AUTOCOMPLETE, which is disabled, so the test
is expected to fail. This test verifies that currently no client implements this method on HTMLFormElement
(HTMLFormElement#requestAutocomplete) and returns. When the chrome-side lands I'll add a success case in
LayoutTests/platform/chromium/fast/forms/ with the expected successful results.

* fast/forms/form-request-autocomplete-expected.txt: Added.
* fast/forms/form-request-autocomplete.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: %d, %i, and %f log formatters have same result
pfeldman@chromium.org [Sat, 3 Nov 2012 15:32:41 +0000 (15:32 +0000)]
Web Inspector: %d, %i, and %f log formatters have same result
https://bugs.webkit.org/show_bug.cgi?id=101148

Reviewed by Alexander Pavlov.

Source/WebCore:

Added separate formatters for %f, %i, %d and %s.

Test: inspector/console/console-message-format.html

* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype.stringFormatter):
(WebInspector.ConsoleMessageImpl.prototype.floatFormatter):
(WebInspector.ConsoleMessageImpl.prototype.integerFormatter):

LayoutTests:

* inspector/console/console-format-expected.txt:
* inspector/console/console-format.html:
* inspector/console/console-message-format-expected.txt: Added.
* inspector/console/console-message-format.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDecouple Attr logic from ElementAttributeData.
kling@webkit.org [Sat, 3 Nov 2012 11:55:58 +0000 (11:55 +0000)]
Decouple Attr logic from ElementAttributeData.
<http://webkit.org/b/101126>

Reviewed by Antti Koivisto.

Move all logic dealing with Attr DOM nodes from ElementAttributeData to Element.
This makes more sense since an Attr is tied to a single Element, but an ElementAttributeData
can be shared by any number of Elements at a given time.

Also updated naming convention from just "Attr" to "Attr node" in the code I was touching.
"Attr" is way too generic, and has been historically confused with WebCore::Attribute a lot.

* dom/Element.h:
* dom/ElementAttributeData.h:
* dom/Element.cpp:
(WebCore::attrNodeListMap):
(WebCore::attrNodeListForElement):
(WebCore::ensureAttrNodeListForElement):
(WebCore::removeAttrNodeListForElement):
(WebCore::findAttrNodeInList):
(WebCore::Element::~Element):
(WebCore::Element::detachAttribute):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::normalizeAttributes):
(WebCore::Element::attrIfExists):
(WebCore::Element::ensureAttr):
(WebCore::Element::detachAttrNodeFromElementWithValue):
(WebCore::Element::detachAllAttrNodesFromElement):
(WebCore::Element::cloneAttributesFromElement):

    Move everything Attr-related into Element.cpp while simplifying some loops and remove
    conditions that are no longer needed as they used to depend on having an attributeData().

* dom/Node.h:
(WebCore::Node::hasSyntheticAttrChildNodes):
(WebCore::Node::setHasSyntheticAttrChildNodes):

    Renamed the hasAttrList() node flag to hasSyntheticAttrChildNodes().

* dom/Attr.cpp:
(WebCore::Attr::detachFromElementWithValue):

    Remove awkward indirection and let the call site deal with removing the Attr node from
    the Element's list of Attr nodes.

* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::clearAttributes):

    Remove now-unused Element* argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r132014-r132047): Webkit Inspector Window docking broken
pfeldman@chromium.org [Sat, 3 Nov 2012 11:36:03 +0000 (11:36 +0000)]
REGRESSION (r132014-r132047): Webkit Inspector Window docking broken
https://bugs.webkit.org/show_bug.cgi?id=101125

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Added "bottom" as default docked state.

* inspector/front-end/DockController.js:
(WebInspector.DockController):

Source/WebKit2:

Migrated from ?docked= to ?dockSide= format.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Shadow] ShadowRoot should be able to know the existence of <content>
shinyak@chromium.org [Sat, 3 Nov 2012 06:40:16 +0000 (06:40 +0000)]
[Shadow] ShadowRoot should be able to know the existence of <content>
https://bugs.webkit.org/show_bug.cgi?id=100921

Reviewed by Dimitri Glazkov.

Source/WebCore:

When <content> is inserted into or removed from a shadow subtree, ShadowRoot counts the number of <content>.
It provides O(1) method to check the existence of <content>.

This is necessary when we implement a fast checking path for distribution invalidation when an element attribute
is changed. Larger context is explained in Bug 100451.

Test: fast/dom/shadow/has-content-elements.html

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::hasInsertionPoint): Since we track both <content> and <shadow>, we don't need to traverse
all the descendants of ShadowRoot anymore.
* dom/ShadowRoot.h:
(WebCore::ShadowRoot::registerContentElement):
(WebCore::ShadowRoot::unregisterContentElement):
(WebCore::ShadowRoot::hasContentElement):
(ShadowRoot):
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::insertedInto): When <content> is inserted into ShadowDOM subtree,
we notify it to the ShadowRoot. Note that only active <content> element is counted.
(WebCore):
(WebCore::HTMLContentElement::removedFrom):
* html/shadow/HTMLContentElement.h:
(HTMLContentElement):
* testing/Internals.cpp:
(WebCore::Internals::hasContentElement):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

* fast/dom/shadow/has-content-elements-expected.txt: Added.
* fast/dom/shadow/has-content-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agosCurrentPaintTimeStamp is not initialized when FrameView::paintContents returns in...
commit-queue@webkit.org [Sat, 3 Nov 2012 06:29:26 +0000 (06:29 +0000)]
sCurrentPaintTimeStamp is not initialized when FrameView::paintContents returns in the middle
https://bugs.webkit.org/show_bug.cgi?id=99990

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-02
Reviewed by Darin Adler.

Move initialization code for sCurrentPaintTimeStamp to the below of early returns,
because it was not reset after early return.

* page/FrameView.cpp:
(WebCore::FrameView::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build warning in PluginView.cpp on release build
commit-queue@webkit.org [Sat, 3 Nov 2012 06:26:10 +0000 (06:26 +0000)]
Fix build warning in PluginView.cpp on release build
https://bugs.webkit.org/show_bug.cgi?id=101049

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-02
Reviewed by Kentaro Hara.

The protocol, host, port parameters are not used when LOG_DISABLED
Use UNUSED_PARAM macro for removing -Wunused-parameter warning

* plugins/PluginView.cpp:
(WebCore::PluginView::getAuthenticationInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133390 268f45cc-cd09-0410-ab3c-d52691b4dbfc