WebKit-https.git
8 years agoUpdate Windows expected results after r76115.
bweinstein@apple.com [Wed, 19 Jan 2011 18:34:14 +0000 (18:34 +0000)]
Update Windows expected results after r76115.

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 19 Jan 2011 18:29:15 +0000 (18:29 +0000)]
2011-01-18  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] simplify complex text code, fixing a handful of layout tests
        https://bugs.webkit.org/show_bug.cgi?id=52661

        * platform/chromium/test_expectations.txt: Mark 11 tests as expected to pass.
2011-01-18  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] simplify complex text code, fixing a handful of layout tests
        https://bugs.webkit.org/show_bug.cgi?id=52661

        Change ComplexTextControllerLinux to lay out RTL text to the left from
        the starting point.  (Previously it always went to the right.)  This allows
        us to map pixel offsets more directly into offsets within the text runs,
        simplifying a few of the text-fiddling functions (they no longer need to
        track the current position, as ComplexTextController now does it).

        * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
        (WebCore::ComplexTextController::ComplexTextController):
        (WebCore::ComplexTextController::reset):
        (WebCore::ComplexTextController::setGlyphXPositions):
        * platform/graphics/chromium/ComplexTextControllerLinux.h:
        (WebCore::ComplexTextController::offsetX):
        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::glyphIndexForXPositionInScriptRun):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 19 Jan 2011 18:27:55 +0000 (18:27 +0000)]
2011-01-19  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move methods from InjectedScript domain into DOM,
        Runtime and Debugger domains. Introduce InspectorRuntimeAgent.
        https://bugs.webkit.org/show_bug.cgi?id=52717

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::evaluateOnCallFrame):
        (WebCore::InjectedScript::getCompletions):
        (WebCore::InjectedScript::getCompletionsOnCallFrame):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::injectedScriptForMainWorld):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptSource.js:
        (.):
        ():
        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::releaseFrontendLifetimeAgents):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::resolveNode):
        (WebCore::InspectorDOMAgent::getNodeProperties):
        (WebCore::InspectorDOMAgent::getNodePrototypes):
        (WebCore::InspectorDOMAgent::injectedScriptForNodeId):
        * inspector/InspectorDOMAgent.h:
        (WebCore::EventListenerInfo::EventListenerInfo):
        (WebCore::InspectorDOMAgent::DOMListener::~DOMListener):
        (WebCore::InspectorDOMAgent::create):
        (WebCore::InspectorDOMAgent::cast):
        (WebCore::InspectorDOMAgent::documents):
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
        (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
        (WebCore::InspectorDebuggerAgent::injectedScriptForCallFrameId):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorRuntimeAgent.cpp: Added.
        (WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
        (WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
        (WebCore::InspectorRuntimeAgent::evaluate):
        (WebCore::InspectorRuntimeAgent::getCompletions):
        (WebCore::InspectorRuntimeAgent::getProperties):
        (WebCore::InspectorRuntimeAgent::setPropertyValue):
        (WebCore::InspectorRuntimeAgent::pushNodeToFrontend):
        (WebCore::InspectorRuntimeAgent::injectedScriptForObjectId):
        * inspector/InspectorRuntimeAgent.h: Copied from Source/WebCore/inspector/InjectedScript.h.
        (WebCore::InspectorRuntimeAgent::create):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.completions):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 19 Jan 2011 18:18:00 +0000 (18:18 +0000)]
2011-01-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Pass WebPageCreationParameters to DrawingArea::create
        https://bugs.webkit.org/show_bug.cgi?id=52726

        * WebProcess/WebPage/DrawingArea.cpp:
        (WebKit::DrawingArea::create):
        * WebProcess/WebPage/DrawingArea.h:
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::create):
        (WebKit::DrawingAreaImpl::DrawingAreaImpl):
        * WebProcess/WebPage/DrawingAreaImpl.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage):
        (WebKit::WebPage::changeAcceleratedCompositingMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 19 Jan 2011 18:14:29 +0000 (18:14 +0000)]
2011-01-19  Tony Chang  <tony@chromium.org>

        Reviewed by Mihai Parparita.

        [chromium] [linux] if check-sys-deps fails, output the failure reason
        https://bugs.webkit.org/show_bug.cgi?id=52671

        * Scripts/webkitpy/common/system/executive_mock.py: Add support for
            error handler functions.
        * Scripts/webkitpy/layout_tests/port/chromium.py:
            output the error text from --check-sys-deps
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Wed, 19 Jan 2011 17:58:15 +0000 (17:58 +0000)]
2011-01-19  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/8882994> Regression: Simple nested backtrack hangs
        https://bugs.webkit.org/show_bug.cgi?id=52675

        The changeset (r76076) for https://bugs.webkit.org/show_bug.cgi?id=52540
        broke simple backtracking in some cases.  Reworked that change to
        link both jumps and labels.

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::BacktrackDestination::hasBacktrackToLabel):
        (JSC::Yarr::YarrGenerator::TermGenerationState::propagateBacktrackingFrom):
        (JSC::Yarr::YarrGenerator::generateParenthesesSingle):
2011-01-19  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/8882994> Regression: Simple nested backtrack hangs
        https://bugs.webkit.org/show_bug.cgi?id=52675

        New tests to support change.

        * fast/regex/parentheses-expected.txt:
        * fast/regex/script-tests/parentheses.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 19 Jan 2011 17:57:36 +0000 (17:57 +0000)]
2011-01-18  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add UglifyJS parser and formatter files
        https://bugs.webkit.org/show_bug.cgi?id=51702

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/ScriptFormatter.js:
        (WebInspector.ScriptFormatter.positionToLocation):
        (WebInspector.ScriptFormatter.prototype.format.messageHandler):
        (WebInspector.ScriptFormatter.prototype.format):
        (WebInspector.ScriptFormatter.prototype._buildMapping):
        (WebInspector.ScriptFormatter.prototype._convertPosition):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.formatSource.didFormat):
        (WebInspector.SourceFrame.prototype.formatSource):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/parse-js.js: Added. UglifyJS parser.
        * inspector/front-end/process.js: Added. UglifyJS formatter.
        * inspector/front-end/scriptFormatterWorker.js: Added. Worker script that wraps UglifyJS code.
        (onmessage):
        (beautify):
        (loadModule):
        (require):
        * inspector/front-end/utilities.js:
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Wed, 19 Jan 2011 17:48:14 +0000 (17:48 +0000)]
Unreviewed.

Add Qt specific expected result for a new test introduced in r76074.
Compared to Mac png files and Mac expected files.

* platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.checksum: Added.
* platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.png: Added.
* platform/qt/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Joone Hur <joone.hur@collabora.co.uk>
commit-queue@webkit.org [Wed, 19 Jan 2011 17:47:54 +0000 (17:47 +0000)]
2011-01-19  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Andreas Kling.

        [GTK] No need to invalidate empty areas in ChromeClient::invalidateContentsAndWindow
        https://bugs.webkit.org/show_bug.cgi?id=52702

        Don't call gdk_window_invalidate_rect if an updated rectangle is empty.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::invalidateContentsAndWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Wed, 19 Jan 2011 17:01:12 +0000 (17:01 +0000)]
2011-01-19  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [JSC] scripts have incorrect starting line (always 1).
        https://bugs.webkit.org/show_bug.cgi?id=52721

        * inspector/debugger-scripts-expected.txt: Added.
        * inspector/debugger-scripts.html: Added.
2011-01-19  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [JSC] scripts have incorrect starting line (always 1).
        https://bugs.webkit.org/show_bug.cgi?id=52721

        * debugger/Debugger.cpp:
        (JSC::Debugger::recompileAllJSFunctions):
        * debugger/Debugger.h:
        * parser/Parser.h:
        (JSC::Parser::parse):
        * parser/SourceCode.h:
        (JSC::SourceCode::SourceCode):
        * parser/SourceProvider.h:
        (JSC::SourceProvider::startPosition):
2011-01-19  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [JSC] scripts have incorrect starting line (always 1).
        https://bugs.webkit.org/show_bug.cgi?id=52721

        Test: inspector/debugger-scripts.html

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::dispatchDidParseSource):
        (WebCore::ScriptDebugServer::dispatchFailedToParseSource):
        (WebCore::ScriptDebugServer::sourceParsed):
        * bindings/js/ScriptDebugServer.h:
        * bindings/js/ScriptSourceCode.h:
        (WebCore::ScriptSourceCode::ScriptSourceCode):
        * bindings/js/StringSourceProvider.h:
        (WebCore::StringSourceProvider::create):
        (WebCore::StringSourceProvider::startPosition):
        (WebCore::StringSourceProvider::StringSourceProvider):
2011-01-19  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [JSC] scripts have incorrect starting line (always 1).
        https://bugs.webkit.org/show_bug.cgi?id=52721

        * WebView/WebScriptDebugger.h:
        * WebView/WebScriptDebugger.mm:
        (toNSString):
        (WebScriptDebugger::sourceParsed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Satish Sampath <satish@chromium.org>
satish@chromium.org [Wed, 19 Jan 2011 16:41:41 +0000 (16:41 +0000)]
2011-01-19  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Send origin/url as part of speech input requests to the embedder.
        https://bugs.webkit.org/show_bug.cgi?id=52718

        * page/SpeechInput.cpp:
        (WebCore::SpeechInput::startRecognition): Pass up additional origin parameter.
        * page/SpeechInput.h:
        * page/SpeechInputClient.h:
        * platform/mock/SpeechInputClientMock.cpp:
        (WebCore::SpeechInputClientMock::startRecognition): Updated prototype.
        * platform/mock/SpeechInputClientMock.h:
        * rendering/TextControlInnerElements.cpp:
        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Pass the frame origin to speech input request.
2011-01-19  Satish Sampath  <satish@chromium.org>

        Reviewed by Jeremy Orlow.

        Send origin/url as part of speech input requests to the embedder.
        https://bugs.webkit.org/show_bug.cgi?id=52718

        * public/WebSpeechInputController.h:
        (WebKit::WebSpeechInputController::startRecognition): Updated prototype.
        * src/SpeechInputClientImpl.cpp:
        (WebKit::SpeechInputClientImpl::startRecognition): Pass up additional origin parameter.
        * src/SpeechInputClientImpl.h:
        * src/WebSpeechInputControllerMockImpl.cpp: Updated code to pass additional parameter.
        (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
        * src/WebSpeechInputControllerMockImpl.h: Added new variant of startRecognition method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 19 Jan 2011 16:27:31 +0000 (16:27 +0000)]
2011-01-19  Jeremy Orlow  <jorlow@chromium.org>

        This test changed slightly, so rebaseline it.  The offsets seem off
        but they have been for as long as the files have been upstream so it's
        likely a known issue.

        * platform/chromium-win/fast/events/offsetX-offsetY-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Wed, 19 Jan 2011 16:24:05 +0000 (16:24 +0000)]
2011-01-19  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Support auto-increment keys
        https://bugs.webkit.org/show_bug.cgi?id=52576

        Add layout test for auto increment keys.
        Update previous test not to consider auto increment an error.

        * storage/indexeddb/create-object-store-options-expected.txt:
        * storage/indexeddb/create-object-store-options.html:
        * storage/indexeddb/objectstore-autoincrement-expected.txt: Added.
        * storage/indexeddb/objectstore-autoincrement.html: Added.
2011-01-19  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Support auto-increment keys
        https://bugs.webkit.org/show_bug.cgi?id=52576

        Add support for auto-increment keys.

        Test: storage/indexeddb/objectstore-autoincrement.html

        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::createObjectStore):
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::genAutoIncrementKey):
        (WebCore::IDBObjectStoreBackendImpl::putInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Wed, 19 Jan 2011 14:42:12 +0000 (14:42 +0000)]
Unreviewed.

Update Qt specific expected files after r76115.

* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Wed, 19 Jan 2011 14:39:43 +0000 (14:39 +0000)]
2011-01-19  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Simon Fraser.

        Update Test Now that Bug is Fixed
        https://bugs.webkit.org/show_bug.cgi?id=52677

        * fast/events/offsetX-offsetY-expected.txt: one more PASS line.
        * fast/events/offsetX-offsetY.html: uncomment and update hit-test location.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 19 Jan 2011 14:32:55 +0000 (14:32 +0000)]
2011-01-19  Jeremy Orlow  <jorlow@chromium.org>

        Move pixel test results to the proper place.

        * platform/mac/svg/custom/use-inherit-style-expected.checksum: Renamed from LayoutTests/svg/custom/use-inherit-style-expected.checksum.
        * platform/mac/svg/custom/use-inherit-style-expected.png: Renamed from LayoutTests/svg/custom/use-inherit-style-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Remove unnecessary "../Source" from paths
ossy@webkit.org [Wed, 19 Jan 2011 14:31:20 +0000 (14:31 +0000)]
[Qt] Remove unnecessary "../Source" from paths
after moving source files into Source is finished.

Reviewed by Laszlo Gombos and Tor Arne Vestbø.

Source/JavaScriptCore:

* JavaScriptCore.pri:

Source/WebCore:

* WebCore.pri:
* WebCore.pro:

Source/WebKit/qt:

* Api/DerivedSources.pro:

Source/WebKit2:

* DerivedSources.pro:
* WebKit2.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Benjamin Kalman <kalman@chromium.org>
commit-queue@webkit.org [Wed, 19 Jan 2011 14:27:40 +0000 (14:27 +0000)]
2011-01-19  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Darin Adler.

        Don't return void from void function String::split
        https://bugs.webkit.org/show_bug.cgi?id=52684

        * wtf/text/WTFString.cpp:
        (WTF::String::split):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
commit-queue@webkit.org [Wed, 19 Jan 2011 14:15:39 +0000 (14:15 +0000)]
2011-01-19  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>

        Reviewed by Andreas Kling.

        Enable usage of Google ld if it exist but is not on by default.

        [Qt] Enable the google ld if it exist but is not on by default
        https://bugs.webkit.org/show_bug.cgi?id=52625

        * common.pri: flip the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Aparna Nandyal <aparna.nand@wipro.com>
commit-queue@webkit.org [Wed, 19 Jan 2011 14:01:13 +0000 (14:01 +0000)]
2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>

        Reviewed by Andreas Kling.

        [Qt] QtTestBrowser crashes when closing if Facebook is opened
        https://bugs.webkit.org/show_bug.cgi?id=52554

        QtNetworkAccessManager is created in a thread and set as
        member variable in QWebPage. When the thread is destroyed
        the object is still used. So fix will set the object to
        NULL once the thread is destroyed.

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::~LauncherWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 19 Jan 2011 13:55:35 +0000 (13:55 +0000)]
2011-01-19  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: fixed flaky inspector test.

        * http/tests/inspector/extensions-resources-redirect.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert "2011-01-18 Mikhail Naganov <mnaganov@chromium.org>"
mnaganov@chromium.org [Wed, 19 Jan 2011 13:27:54 +0000 (13:27 +0000)]
Revert "2011-01-18  Mikhail Naganov  <mnaganov@chromium.org>"

Revert r76114 -- added test fails on Chromium canaries.

This reverts commit 89065aef21411b68af89a8fa7ff41dfe14c54a6a.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 19 Jan 2011 13:24:59 +0000 (13:24 +0000)]
2011-01-19  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Employ TextPrompt for CSS property name/value autocompletion
        https://bugs.webkit.org/show_bug.cgi?id=52212

        WebInspector.CSSKeywordCompletions contains a hand-written list of accepted CSS property value keywords
        for each property. WebInspector.TextPrompt is used to suggest both the name and value keywords while
        editing styles, in place of the old custom suggestion code.

        WebCore:
        * inspector/front-end/CSSCompletions.js:
        (WebInspector.CSSCompletions.prototype.startsWith): Fix array-out-of-bounds error.
        * inspector/front-end/CSSKeywordCompletions.js: Added.
        (WebInspector.CSSKeywordCompletions.forProperty):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.updateTitle):
        (WebInspector.StylePropertyTreeElement.prototype):
        ():
        * inspector/front-end/TextPrompt.js:
        (WebInspector.TextPrompt):
        (WebInspector.TextPrompt.prototype.removeFromElement):
        (WebInspector.TextPrompt.prototype._onKeyDown):
        (WebInspector.TextPrompt.prototype.tabKeyPressed):
        (WebInspector.TextPrompt.prototype.upKeyPressed):
        (WebInspector.TextPrompt.prototype.downKeyPressed):
        (WebInspector.TextPrompt.prototype._moveBackInHistory):
        (WebInspector.TextPrompt.prototype._moveForwardInHistory):
        * inspector/front-end/inspector.css:
        (.auto-complete-text, .editing .auto-complete-text):
        * inspector/front-end/inspector.html:

        LayoutTests:
        * inspector/styles-add-blank-property.html: Follow the altered event handling.
        * inspector/styles-url-linkify.html: Eliminate flakiness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Dai Mikurube <dmikurube@google.com>
commit-queue@webkit.org [Wed, 19 Jan 2011 12:56:25 +0000 (12:56 +0000)]
2011-01-19  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Implement onformchange and onforminput event handlers
        https://bugs.webkit.org/show_bug.cgi?id=26141

        * fast/dom/Window/window-properties-expected.txt: Added form events.
        * fast/dom/Window/window-property-descriptors-expected.txt: Added form events.
        * fast/forms/formchange-event-expected.txt: Added.
        * fast/forms/formchange-event.html: Added to test formchange events.
        * fast/forms/forminput-event-expected.txt: Added.
        * fast/forms/forminput-event.html: Added to test forminput events.
        * fast/forms/script-tests/formchange-event.js: Added.
        (sendKey):
        (sendText):
        * fast/forms/script-tests/forminput-event.js: Added.
        (sendKey):
        (sendText):
2011-01-19  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Implement onformchange and onforminput event handlers
        https://bugs.webkit.org/show_bug.cgi?id=26141

        Tests: fast/forms/formchange-event.html
               fast/forms/forminput-event.html

        * bindings/scripts/CodeGeneratorGObject.pm: Added event names.
        * dom/Document.h: Added event definitions.
        * dom/Document.idl: Added event definitions.
        * dom/Element.h: Added event definitions.
        * dom/Element.idl: Added event definitions.
        * dom/Event.cpp:
        (WebCore::Event::fromUserGesture): Added a condition for a formchange event in handling user gestures.
        * dom/EventNames.h: Added event definitions.
        * dom/InputElement.cpp:
        (WebCore::InputElement::setValueFromRenderer): Replaced a direct dispatchEvent() call into dispatchInputEvents(), a virtual function which broadcasts forminput events for HTML elements.
        * dom/Node.cpp:
        (WebCore::Node::dispatchInputEvents): Defined basic dispatchInputEvents() described above.
        (WebCore::Node::dispatchChangeEvents): Defined basic dispatchChangeEvents() described above.
        (WebCore::Node::defaultEventHandler): Replaced a direct dispatchEvent() call into dispatchInputEvents().
        * dom/Node.h:
        * html/FormAssociatedElement.h: Added isResettable() to check the element is resettable or not.
        * html/HTMLAttributeNames.in: Added event names.
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::parseMappedAttribute): Added event handling.
        (WebCore::HTMLElement::shadowAncestorOwnerForm): Added to get an ancestor <form> element from a shadow element.
        (WebCore::HTMLElement::dispatchChangeEvents): Defined dispatchChangeEvents() for HTML elements described above.
        (WebCore::HTMLElement::dispatchInputEvents): Defined dispatchInputEvents() for HTML elements described above.
        * html/HTMLElement.h:
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent): Added calling dispatchFormChange() to broadcast formchange events.
        (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent): Defined newly to dispatch an input event with broadcasting forminput events.
        * html/HTMLFormControlElement.h: Added isResettable().
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::broadcastFormEvent): Added to broadcast forminput or formchange events.
        (WebCore::HTMLFormElement::dispatchFormInput): Defined newly to broadcast forminput events.
        (WebCore::HTMLFormElement::dispatchFormChange): Defined newly to broadcast formchange events.
        * html/HTMLFormElement.h:
        * html/HTMLFormElement.idl: Added dispatchFormInput() and dispatchFormChange() DOM API definitions.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::stepUpFromRenderer): Replaced a direct dispatchEvent() call into dispatchInputEvents().
        * html/HTMLInputElement.h: Added isResettable().
        * html/HTMLKeygenElement.h: Added isResettable().
        * html/HTMLObjectElement.h: Added isResettable().
        * html/HTMLOutputElement.h: Added isResettable().
        * html/HTMLSelectElement.h: Added isResettable().
        * html/HTMLTextAreaElement.h: Added isResettable().
        * page/DOMWindow.h: Added event definitions.
        * page/DOMWindow.idl: Added event definitions.
        * rendering/TextControlInnerElements.cpp:
        (WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Replaced a direct dispatchEvent() call into dispatchInputEvents().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Wed, 19 Jan 2011 12:42:36 +0000 (12:42 +0000)]
2011-01-18  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Add layout test for the CPU profiler.

        This test replaces DevToolsSanityTest.TestProfilerTab from
        Chromium's interactive_ui_tests.

        https://bugs.webkit.org/show_bug.cgi?id=52634

        * inspector/cpu-profiler-profiling-expected.txt: Added.
        * inspector/cpu-profiler-profiling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert accidental r76110..76112
mnaganov@chromium.org [Wed, 19 Jan 2011 12:35:19 +0000 (12:35 +0000)]
Revert accidental r76110..76112

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoworks in chromium
mnaganov@chromium.org [Wed, 19 Jan 2011 12:24:03 +0000 (12:24 +0000)]
works in chromium

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoworks in safari
mnaganov@chromium.org [Wed, 19 Jan 2011 12:23:42 +0000 (12:23 +0000)]
works in safari

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoadded test
mnaganov@chromium.org [Wed, 19 Jan 2011 12:23:21 +0000 (12:23 +0000)]
added test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 19 Jan 2011 11:37:34 +0000 (11:37 +0000)]
2011-01-19  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] delete pending callback from callback map before invoking it
        https://bugs.webkit.org/show_bug.cgi?id=52707

        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI.ExtensionServerClient.prototype._onCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 19 Jan 2011 10:34:24 +0000 (10:34 +0000)]
2011-01-19  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: updating Chromium devtools sanity tests for downstream use.

        * src/js/Tests.js:
        (.TestSuite.prototype._checkExecutionLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Levi Weintraub <leviw@google.com>
commit-queue@webkit.org [Wed, 19 Jan 2011 09:32:09 +0000 (09:32 +0000)]
2011-01-19  Levi Weintraub  <leviw@google.com>

        Reviewed by Ryosuke Niwa.

        Replaced rangeCompliantEquivalent with Position::parentAnchoredEquivalent
        and simplified the logic a bit. Unfortunately, Tables and some legacy
        editing positions still need to be handled specifically.

        remove rangeCompliantEquivalent and replace it with Position methods
        https://bugs.webkit.org/show_bug.cgi?id=25057

        No new tests as this is a refactor that doesn't change behavior.

        * WebCore.exp.in:
        * dom/Document.cpp:
        (WebCore::Document::caretRangeFromPoint):
        * dom/Position.cpp:
        (WebCore::Position::parentAnchoredEquivalent):
        * dom/Position.h:
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyBlockStyle):
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertNodeAt):
        (WebCore::CompositeEditCommand::moveParagraphs):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData):
        (WebCore::DeleteSelectionCommand::mergeParagraphs):
        * editing/Editor.cpp:
        (WebCore::Editor::textDirectionForSelection):
        (WebCore::Editor::advanceToNextMisspelling):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::shouldUseBreakElement):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::handleStyleSpansBeforeInsertion):
        * editing/VisiblePosition.cpp:
        (WebCore::makeRange):
        (WebCore::setStart):
        (WebCore::setEnd):
        * editing/VisibleSelection.cpp:
        (WebCore::VisibleSelection::firstRange):
        (WebCore::VisibleSelection::toNormalizedRange):
        (WebCore::makeSearchRange):
        * editing/htmlediting.cpp:
        (WebCore::indexForVisiblePosition):
        * editing/htmlediting.h:
        * editing/visible_units.cpp:
        (WebCore::previousBoundary):
        (WebCore::nextBoundary):
        * page/DOMSelection.cpp:
        (WebCore::anchorPosition):
        (WebCore::focusPosition):
        (WebCore::basePosition):
        (WebCore::extentPosition):
2011-01-19  Levi Weintraub  <leviw@google.com>

        Reviewed by Ryosuke Niwa.

        Updating to use Position::parentAnchoredEquivalent instead of
        the old htmlediting rangeCompliantEquivalent.

        remove rangeCompliantEquivalent and replace it with Position methods
        https://bugs.webkit.org/show_bug.cgi?id=25057

        * WebView/WebFrame.mm:
        (-[WebFrame _smartDeleteRangeForProposedRange:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Peter Rybin <peter.rybin@gmail.com>
yurys@chromium.org [Wed, 19 Jan 2011 09:17:36 +0000 (09:17 +0000)]
2011-01-19  Peter Rybin  <peter.rybin@gmail.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: script column offset is incorrect
        https://bugs.webkit.org/show_bug.cgi?id=52580

        Column is updated in 3 places, 2 less probable places contained error.
        Fixed now.

        * platform/text/SegmentedString.cpp:
        (WebCore::SegmentedString::advanceSlowCase):
        * platform/text/SegmentedString.h:
        (WebCore::SegmentedString::advancePastNewline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 19 Jan 2011 09:00:58 +0000 (09:00 +0000)]
2011-01-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make InjectedScriptAccess API a part of Web Inspector protocol.
        https://bugs.webkit.org/show_bug.cgi?id=52652

        Calls served by the InjectedScript should be first class protocol
        citizens, not dispatched via single protocol message.

        * http/tests/inspector/extensions-test.js:
        (initialize_ExtensionsTest.InspectorTest.runExtensionTests):
        * http/tests/inspector/inspector-test2.js:
        (initialize_InspectorTest.InspectorTest.evaluateInPage):
        * http/tests/inspector/resource-har-conversion.html:
        * inspector/console-command-clear.html:
        * inspector/console-dir-global.html:
2011-01-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make InjectedScriptAccess API a part of Web Inspector protocol.
        https://bugs.webkit.org/show_bug.cgi?id=52652

        Calls served by the InjectedScript should be first class protocol
        citizens, not dispatched via single protocol message.

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::evaluate):
        (WebCore::InjectedScript::evaluateInCallFrame):
        (WebCore::InjectedScript::evaluateOnSelf):
        (WebCore::InjectedScript::getCompletions):
        (WebCore::InjectedScript::getProperties):
        (WebCore::InjectedScript::pushNodeToFrontend):
        (WebCore::InjectedScript::resolveNode):
        (WebCore::InjectedScript::getNodeProperties):
        (WebCore::InjectedScript::getNodePrototypes):
        (WebCore::InjectedScript::setPropertyValue):
        (WebCore::InjectedScript::makeCall):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::evaluate):
        (WebCore::InjectedScriptHost::evaluateInCallFrame):
        (WebCore::InjectedScriptHost::evaluateOnSelf):
        (WebCore::InjectedScriptHost::getCompletions):
        (WebCore::InjectedScriptHost::getProperties):
        (WebCore::InjectedScriptHost::pushNodeToFrontend):
        (WebCore::InjectedScriptHost::resolveNode):
        (WebCore::InjectedScriptHost::getNodeProperties):
        (WebCore::InjectedScriptHost::getNodePrototypes):
        (WebCore::InjectedScriptHost::setPropertyValue):
        (WebCore::InjectedScriptHost::injectedScriptForObjectId):
        (WebCore::InjectedScriptHost::injectedScriptForNodeId):
        (WebCore::InjectedScriptHost::injectedScriptForMainWorld):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptSource.js:
        (.):
        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        * inspector/InspectorController.h:
        * inspector/InspectorValues.cpp:
        (WebCore::InspectorObject::getNumber):
        * inspector/InspectorValues.h:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.evaluateInTargetWindow):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.completions):
        (WebInspector.ConsoleView.prototype.doEvalInWindow):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
        * inspector/front-end/ExtensionPanel.js:
        (WebInspector.ExtensionWatchSidebarPane.prototype.setExpression):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
        * inspector/front-end/InjectedScriptAccess.js: Removed.
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.callback):
        (WebInspector.PropertiesSidebarPane.prototype.update):
        * inspector/front-end/RemoteObject.js:
        (WebInspector.RemoteObject.resolveNode):
        (WebInspector.RemoteObject.prototype.getProperties):
        (WebInspector.RemoteObject.prototype.setPropertyValue):
        (WebInspector.RemoteObject.prototype.pushNodeToFrontend):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.doEvalInCallFrame):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
2011-01-18  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: make InjectedScriptAccess API a part of Web Inspector protocol.
        https://bugs.webkit.org/show_bug.cgi?id=52652

        Calls served by the InjectedScript should be first class protocol
        citizens, not dispatched via single protocol message.

        * src/js/Tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Wed, 19 Jan 2011 07:40:35 +0000 (07:40 +0000)]
2011-01-18  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        [v8] Minor cleanup: make 2nd argument of removeIfPresnt accept only a value type stored in the DOM map
        https://bugs.webkit.org/show_bug.cgi?id=51683

        Covered by the existing tests.

        * bindings/v8/DOMDataStore.cpp:
        (WebCore::DOMDataStore::weakNodeCallback):
        (WebCore::DOMDataStore::IntrusiveDOMWrapperMap::removeIfPresent):
        * bindings/v8/DOMDataStore.h:
        * bindings/v8/V8DOMMap.h:
        (WebCore::WeakReferenceMap::removeIfPresent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde...
mjs@apple.com [Wed, 19 Jan 2011 07:12:44 +0000 (07:12 +0000)]
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h

Rubber stamped by Csaba Osztrogonac

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 19 Jan 2011 06:09:27 +0000 (06:09 +0000)]
2011-01-18  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r76084.
        http://trac.webkit.org/changeset/76084
        https://bugs.webkit.org/show_bug.cgi?id=52654

        Crashes on the bots

        * fast/dom/Window/open-window-empty-url-expected.txt: Removed.
        * fast/dom/Window/open-window-empty-url.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 19 Jan 2011 05:15:10 +0000 (05:15 +0000)]
2011-01-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: add a --build-directory command line argument

        Official Google Chrome builds use a non-standard build directory
        location. This patch adds a --build-directory argument that
        allows that location to be specified on the command line. Only
        Chromium-based builds will use this flag for now, but anyone can
        in the future.

        There are no unit tests for this since it's difficult to test
        until mock filesystems are fully supported in the code. This was
        tested by hand for now.

        https://bugs.webkit.org/show_bug.cgi?id=52694

        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 19 Jan 2011 04:33:12 +0000 (04:33 +0000)]
2011-01-18  Kenneth Russell  <kbr@google.com>

        Unreviewed, rolling out r76078.
        http://trac.webkit.org/changeset/76078
        https://bugs.webkit.org/show_bug.cgi?id=52668

        Caused crashes of fast/canvas/webgl/constants.html,
        fast/canvas/webgl/gl-enum-tests.html, and possibly other layout
        test crashes in Release mode. WebGL crashes were observed with
        "run-webkit-tests fast/canvas/webgl". It was necessary to run
        multiple tests to provoke the crash.

        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::markGlobals):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::markChildren):
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::markChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdded a reviewer line for the last checkin
morrita@google.com [Wed, 19 Jan 2011 04:18:53 +0000 (04:18 +0000)]
Added a reviewer line for the last checkin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 19 Jan 2011 04:11:18 +0000 (04:11 +0000)]
2011-01-18 MORITA Hajime  <morrita@google.com>

        Refactoring: EventHandler::handleTextInputEvent should accept an enum instead of bools.
        https://bugs.webkit.org/show_bug.cgi?id=52608

        No new tests. no behavioral change.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/TextEvent.cpp:
        (WebCore::TextEvent::create):
        (WebCore::TextEvent::createForDrop):
        (WebCore::TextEvent::TextEvent):
        * dom/TextEvent.h:
        (WebCore::TextEvent::isLineBreak):
        (WebCore::TextEvent::isBackTab):
        (WebCore::TextEvent::isPaste):
        (WebCore::TextEvent::isDrop):
        * dom/TextEventInputType.h: Added. Extracted from TextEvent::TextInputType.
        * editing/EditorCommand.cpp:
        (WebCore::executeInsertBacktab):
        (WebCore::executeInsertLineBreak):
        (WebCore::executeInsertNewline):
        (WebCore::executeInsertTab):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleTextInputEvent):
        * page/EventHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 19 Jan 2011 04:08:12 +0000 (04:08 +0000)]
2011-01-18  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        Skip (and in a few cases fix) tests for WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=52698

        * editing/pasteboard/copy-null-characters.html: Make this test fail in a more
        obvious way when it fails.
        * fast/events/scroll-event-does-not-bubble.html: Make this test properly
        handle the fact that scroll events are async. The job was half-done before.
        * platform/mac-wk2/Skipped: Skip!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed. Bot fix.
mjs@apple.com [Wed, 19 Jan 2011 03:56:10 +0000 (03:56 +0000)]
Not reviewed. Bot fix.

Remove an inadvertently committed debugging print.

* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::notifyDone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 19 Jan 2011 03:55:04 +0000 (03:55 +0000)]
2011-01-18  Kenneth Russell  <kbr@google.com>

        Unreviewed, Leopard build fix. Remove flex/bison targets for GLSL
        grammar because the generated sources are already checked in.

        * ANGLE.xcodeproj/project.pbxproj:
        * src/build_angle.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNot reviewed.
mjs@apple.com [Wed, 19 Jan 2011 03:30:46 +0000 (03:30 +0000)]
Not reviewed.

Revert inadvertantly committed test changes.

* editing/pasteboard/copy-null-characters.html:
* fast/events/scroll-event-does-not-bubble.html:
* platform/mac-wk2/Skipped:
* transitions/remove-transition-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 19 Jan 2011 03:23:41 +0000 (03:23 +0000)]
2011-01-18  Kenneth Russell  <kbr@google.com>

        Unreviewed, release build fix. Explicitly cast away const.

        * src/compiler/preprocessor/scanner.c:
        (ScanFromString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 19 Jan 2011 03:16:35 +0000 (03:16 +0000)]
2011-01-18  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner should track loading more like DumpRenderTree
        https://bugs.webkit.org/show_bug.cgi?id=52692

        Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
        This makes some tests that call notifyDone multiple times pass.

        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::InjectedBundle):
        (WTR::InjectedBundle::done):
        * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
        (WTR::InjectedBundle::topLoadingFrame):
        (WTR::InjectedBundle::setTopLoadingFrame):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::InjectedBundlePage):
        (WTR::InjectedBundlePage::stopLoading):
        (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
        (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
        (WTR::InjectedBundlePage::didFinishLoadForFrame):
        (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::notifyDone):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::didReceiveMessageFromInjectedBundle):
2011-01-18  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner should track loading more like DumpRenderTree
        https://bugs.webkit.org/show_bug.cgi?id=52692

        Relax the message check in didSaveFrameToPageCache a bit more, since
        layout tests were still hitting the old one.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::isDisconnectedFrame):
        (WebKit::WebPageProxy::didSaveFrameToPageCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Ben Vanik <ben.vanik@gmail.com>
kbr@google.com [Wed, 19 Jan 2011 03:00:39 +0000 (03:00 +0000)]
2011-01-18  Ben Vanik  <ben.vanik@gmail.com>

        Reviewed by Kenneth Russell.

        Updating ANGLE in WebKit to r533.
        https://bugs.webkit.org/show_bug.cgi?id=47194

        * platform/graphics/ANGLEWebKitBridge.cpp:
        (WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
        (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge):
        (WebCore::ANGLEWebKitBridge::validateShaderSource):
        Update to new ANGLE API for shader validation.
        * platform/graphics/ANGLEWebKitBridge.h:
        (WebCore::ANGLEWebKitBridge::setResources):
        Renaming types to new names.
        * platform/graphics/mac/GraphicsContext3DMac.mm:
        (WebCore::GraphicsContext3D::GraphicsContext3D):
        Initialize ANGLEResources with ANGLE init call to prevent uninitialized variables.
2011-01-18  Ben Vanik  <ben.vanik@gmail.com>

        Reviewed by Kenneth Russell.

        Updating ANGLE in WebKit to r533.
        https://bugs.webkit.org/show_bug.cgi?id=47194

        * ANGLE.xcodeproj/project.pbxproj:
        * include/GLSLANG/ShaderLang.h:
        * src/common/debug.cpp:
        (gl::trace):
        * src/common/debug.h:
        * src/compiler/CodeGenGLSL.cpp:
        (ConstructCompiler):
        * src/compiler/CodeGenHLSL.cpp:
        (ConstructCompiler):
        * src/compiler/Common.h:
        (EncodeSourceLoc):
        (DecodeSourceLoc):
        * src/compiler/Compiler.cpp: Added.
        (TShHandleBase::TShHandleBase):
        (TShHandleBase::~TShHandleBase):
        (TCompiler::TCompiler):
        (TCompiler::~TCompiler):
        (TCompiler::Init):
        (TCompiler::compile):
        (TCompiler::InitBuiltInSymbolTable):
        (TCompiler::clearResults):
        (TCompiler::validateLimitations):
        (TCompiler::collectAttribsUniforms):
        * src/compiler/ExtensionBehavior.h: Added.
        * src/compiler/InfoSink.cpp:
        (TInfoSinkBase::location):
        * src/compiler/InfoSink.h:
        (TInfoSinkBase::size):
        * src/compiler/Initialize.cpp:
        (BuiltInFunctionsCommon):
        (BuiltInFunctionsVertex):
        (BuiltInFunctionsFragment):
        (StandardUniforms):
        (DefaultPrecisionVertex):
        (DefaultPrecisionFragment):
        (BuiltInConstants):
        (TBuiltIns::initialize):
        (IdentifyBuiltIns):
        (InitExtensionBehavior):
        * src/compiler/Initialize.h:
        * src/compiler/IntermTraverse.cpp:
        (TIntermLoop::traverse):
        * src/compiler/Intermediate.cpp:
        (getOperatorString):
        (TIntermediate::addBinaryMath):
        (TIntermediate::addLoop):
        (TIntermediate::postProcess):
        (TIntermBinary::promote):
        * src/compiler/OutputGLSL.cpp:
        (TOutputGLSL::visitUnary):
        (TOutputGLSL::visitLoop):
        * src/compiler/OutputHLSL.cpp:
        (sh::OutputHLSL::OutputHLSL):
        (sh::OutputHLSL::header):
        (sh::OutputHLSL::visitBinary):
        (sh::OutputHLSL::visitUnary):
        (sh::OutputHLSL::visitAggregate):
        (sh::OutputHLSL::visitLoop):
        (sh::OutputHLSL::handleExcessiveLoop):
        (sh::OutputHLSL::argumentString):
        * src/compiler/OutputHLSL.h:
        * src/compiler/ParseHelper.cpp:
        (ReportInfo):
        (DefineExtensionMacros):
        (TParseContext::error):
        (TParseContext::warning):
        (TParseContext::reservedErrorCheck):
        (TParseContext::constructorErrorCheck):
        (TParseContext::arrayQualifierErrorCheck):
        (TParseContext::extensionErrorCheck):
        (TParseContext::areAllChildConst):
        (PaParseStrings):
        * src/compiler/ParseHelper.h:
        (TParseContext::TParseContext):
        * src/compiler/PoolAlloc.cpp:
        (InitializeGlobalPools):
        (FreeGlobalPools):
        (SetGlobalPoolAllocator):
        (TPoolAllocator::TPoolAllocator):
        (TPoolAllocator::~TPoolAllocator):
        (TAllocation::checkAllocList):
        * src/compiler/PoolAlloc.h:
        * src/compiler/SearchSymbol.cpp: Added.
        (sh::SearchSymbol::SearchSymbol):
        (sh::SearchSymbol::traverse):
        (sh::SearchSymbol::visitSymbol):
        (sh::SearchSymbol::foundMatch):
        * src/compiler/SearchSymbol.h: Added.
        * src/compiler/ShHandle.h:
        (TCompiler::getAsCompiler):
        (TCompiler::getInfoSink):
        (TCompiler::getAttribs):
        (TCompiler::getUniforms):
        (TCompiler::getShaderType):
        (TCompiler::getShaderSpec):
        * src/compiler/ShaderLang.cpp:
        (getVariableMaxLength):
        (getVariableInfo):
        (ShInitBuiltInResources):
        (ShConstructCompiler):
        (ShCompile):
        (ShGetInfo):
        (ShGetInfoLog):
        (ShGetObjectCode):
        (ShGetActiveAttrib):
        (ShGetActiveUniform):
        * src/compiler/SymbolTable.cpp:
        (TSymbolTableLevel::relateToExtension):
        * src/compiler/SymbolTable.h:
        (TVariable::shareConstPointer):
        (TFunction::relateToExtension):
        (TFunction::getExtension):
        (TFunction::getParamCount):
        (TFunction::getParam):
        (TSymbolTable::getGlobalLevel):
        (TSymbolTable::relateToOperator):
        (TSymbolTable::relateToExtension):
        * src/compiler/TranslatorGLSL.cpp:
        (writeVersion):
        (TranslatorGLSL::TranslatorGLSL):
        (TranslatorGLSL::translate):
        * src/compiler/TranslatorGLSL.h:
        * src/compiler/TranslatorHLSL.cpp:
        (TranslatorHLSL::TranslatorHLSL):
        (TranslatorHLSL::translate):
        * src/compiler/TranslatorHLSL.h:
        * src/compiler/Types.h:
        (TType::TType):
        * src/compiler/UnfoldSelect.cpp:
        (sh::UnfoldSelect::visitSelection):
        * src/compiler/UnfoldSelect.h:
        * src/compiler/ValidateLimitations.cpp: Added.
        (ValidateLimitations::ValidateLimitations):
        (ValidateLimitations::visitSymbol):
        (ValidateLimitations::visitConstantUnion):
        (ValidateLimitations::visitBinary):
        (ValidateLimitations::visitUnary):
        (ValidateLimitations::visitSelection):
        (ValidateLimitations::visitAggregate):
        (ValidateLimitations::visitLoop):
        (ValidateLimitations::visitBranch):
        (ValidateLimitations::error):
        (ValidateLimitations::withinLoopBody):
        (ValidateLimitations::isLoopIndex):
        (ValidateLimitations::validateLoopType):
        (ValidateLimitations::validateForLoopHeader):
        (ValidateLimitations::validateForLoopInit):
        (ValidateLimitations::validateForLoopCond):
        (ValidateLimitations::validateForLoopExpr):
        (ValidateLimitations::validateFunctionCall):
        (ValidateLimitations::validateOperation):
        (ValidateLimitations::isConstExpr):
        (ValidateLimitations::isConstIndexExpr):
        (ValidateLimitations::validateIndexing):
        * src/compiler/ValidateLimitations.h: Added.
        (ValidateLimitations::numErrors):
        * src/compiler/VariableInfo.cpp: Added.
        (arrayBrackets):
        (getVariableDataType):
        (getVariableInfo):
        (getBuiltInVariableInfo):
        (getUserDefinedVariableInfo):
        (CollectAttribsUniforms::CollectAttribsUniforms):
        (CollectAttribsUniforms::visitSymbol):
        (CollectAttribsUniforms::visitConstantUnion):
        (CollectAttribsUniforms::visitBinary):
        (CollectAttribsUniforms::visitUnary):
        (CollectAttribsUniforms::visitSelection):
        (CollectAttribsUniforms::visitAggregate):
        (CollectAttribsUniforms::visitLoop):
        (CollectAttribsUniforms::visitBranch):
        * src/compiler/VariableInfo.h: Added.
        * src/compiler/VersionGLSL.cpp: Added.
        (TVersionGLSL::TVersionGLSL):
        (TVersionGLSL::visitSymbol):
        (TVersionGLSL::visitConstantUnion):
        (TVersionGLSL::visitBinary):
        (TVersionGLSL::visitUnary):
        (TVersionGLSL::visitSelection):
        (TVersionGLSL::visitAggregate):
        (TVersionGLSL::visitLoop):
        (TVersionGLSL::visitBranch):
        (TVersionGLSL::updateVersion):
        * src/compiler/VersionGLSL.h: Added.
        (TVersionGLSL::getVersion):
        * src/compiler/generate_glslang_lexer.sh: Added.
        * src/compiler/generate_glslang_parser.sh: Added.
        * src/compiler/glslang.h: Added.
        * src/compiler/glslang.l:
        * src/compiler/glslang.y:
        * src/compiler/glslang_lex.cpp: Added.
        (yy_get_next_buffer):
        (yy_get_previous_state):
        (yy_try_NUL_trans):
        (input):
        (yyrestart):
        (yy_switch_to_buffer):
        (yy_load_buffer_state):
        (yy_create_buffer):
        (yy_delete_buffer):
        (yy_init_buffer):
        (yy_flush_buffer):
        (yypush_buffer_state):
        (yypop_buffer_state):
        (yyensure_buffer_stack):
        (yy_scan_buffer):
        (yy_scan_string):
        (yy_scan_bytes):
        (yy_push_state):
        (yy_pop_state):
        (yy_top_state):
        (yy_fatal_error):
        (yyget_extra):
        (yyget_lineno):
        (yyget_column):
        (yyget_in):
        (yyget_out):
        (yyget_leng):
        (yyget_text):
        (yyset_extra):
        (yyset_lineno):
        (yyset_column):
        (yyset_in):
        (yyset_out):
        (yyget_debug):
        (yyset_debug):
        (yyget_lval):
        (yyset_lval):
        (yylex_init):
        (yylex_init_extra):
        (yy_init_globals):
        (yylex_destroy):
        (yy_flex_strncpy):
        (yy_flex_strlen):
        (yyalloc):
        (yyrealloc):
        (yyfree):
        (string_input):
        (check_type):
        (reserved_word):
        (yyerror):
        (glslang_initialize):
        (glslang_finalize):
        (glslang_scan):
        * src/compiler/glslang_tab.cpp: Added.
        (yytnamerr):
        (yysyntax_error):
        (glslang_parse):
        * src/compiler/glslang_tab.h: Added.
        * src/compiler/intermOut.cpp:
        (TOutputTraverser::TOutputTraverser):
        (OutputTreeText):
        (TOutputTraverser::visitSymbol):
        (TOutputTraverser::visitBinary):
        (TOutputTraverser::visitUnary):
        (TOutputTraverser::visitAggregate):
        (TOutputTraverser::visitSelection):
        (TOutputTraverser::visitConstantUnion):
        (TOutputTraverser::visitLoop):
        (TOutputTraverser::visitBranch):
        (TIntermediate::outputTree):
        * src/compiler/intermediate.h:
        (TIntermLoop::TIntermLoop):
        (TIntermLoop::getType):
        (TIntermLoop::getInit):
        (TIntermLoop::getCondition):
        (TIntermLoop::getExpression):
        (TIntermLoop::getBody):
        * src/compiler/localintermediate.h:
        * src/compiler/osinclude.h:
        (OS_GetTLSValue):
        * src/compiler/ossource_nspr.cpp: Added.
        (OS_AllocTLSIndex):
        (OS_SetTLSValue):
        (OS_FreeTLSIndex):
        * src/compiler/preprocessor/compile.h:
        * src/compiler/preprocessor/cpp.c:
        (CPPdefine):
        (CPPelse):
        (CPPif):
        (CPPifdef):
        (CPPerror):
        (CPPextension):
        (readCPPline):
        * src/compiler/preprocessor/preprocess.h:
        * src/compiler/preprocessor/scanner.c:
        (str_getch):
        (str_ungetch):
        (ScanFromString):
        (lFloatConst):
        (byte_scan):
        (yylex_CPP):
        (check_EOF):
        * src/compiler/preprocessor/scanner.h:
        * src/compiler/preprocessor/tokens.c:
        (RecordToken):
        (ReadToken):
        * src/compiler/tools: Removed.
        * src/compiler/unistd.h: Removed.
        * src/compiler/util.cpp: Added.
        (atof_dot):
        * src/compiler/util.h: Added.
        * src/libEGL/Config.cpp:
        (egl::Config::set):
        * src/libEGL/Display.cpp:
        (egl::Display::Display):
        (egl::Display::initialize):
        (egl::Display::terminate):
        (egl::Display::createDevice):
        (egl::Display::resetDevice):
        (egl::Display::createContext):
        (egl::Display::destroyContext):
        (egl::Display::getMinSwapInterval):
        (egl::Display::getMaxSwapInterval):
        (egl::Display::getDevice):
        (egl::Display::getFloatTextureSupport):
        (egl::Display::getHalfFloatTextureSupport):
        (egl::Display::getLuminanceTextureSupport):
        (egl::Display::getLuminanceAlphaTextureSupport):
        (egl::Display::getBufferPool):
        (egl::Display::getEventQuerySupport):
        (egl::Display::getDefaultPresentParameters):
        * src/libEGL/Display.h:
        * src/libEGL/Surface.cpp:
        (egl::Surface::Surface):
        (egl::Surface::~Surface):
        (egl::Surface::release):
        (egl::Surface::resetSwapChain):
        (egl::Surface::writeRecordableFlipState):
        (egl::Surface::restoreState):
        (egl::SurfaceWindowProc):
        (egl::Surface::subclassWindow):
        (egl::Surface::unsubclassWindow):
        (egl::Surface::checkForOutOfDateSwapChain):
        (egl::Surface::convertInterval):
        (egl::Surface::swap):
        (egl::Surface::getRenderTarget):
        (egl::Surface::setSwapInterval):
        * src/libEGL/Surface.h:
        * src/libEGL/libEGL.cpp:
        * src/libGLESv2/Blit.cpp:
        (gl::Blit::copySurfaceToTexture):
        (gl::Blit::setCommonBlitState):
        * src/libGLESv2/Buffer.cpp:
        (gl::Buffer::Buffer):
        (gl::Buffer::~Buffer):
        (gl::Buffer::bufferData):
        (gl::Buffer::bufferSubData):
        (gl::Buffer::getVertexBuffer):
        (gl::Buffer::getIndexBuffer):
        (gl::Buffer::invalidateStaticData):
        * src/libGLESv2/Buffer.h:
        * src/libGLESv2/Context.cpp:
        (gl::Context::Context):
        (gl::Context::~Context):
        (gl::Context::makeCurrent):
        (gl::Context::markAllStateDirty):
        (gl::Context::setFragmentShaderDerivativeHint):
        (gl::Context::setEnableVertexAttribArray):
        (gl::Context::getVertexAttribState):
        (gl::Context::getVertexAttributes):
        (gl::Context::createFence):
        (gl::Context::deleteFence):
        (gl::Context::bindTexture2D):
        (gl::Context::bindTextureCubeMap):
        (gl::Context::getFence):
        (gl::Context::getTexture2D):
        (gl::Context::getTextureCubeMap):
        (gl::Context::getSamplerTexture):
        (gl::Context::getBooleanv):
        (gl::Context::getIntegerv):
        (gl::Context::getQueryParameterInfo):
        (gl::Context::applyRenderTarget):
        (gl::Context::applyState):
        (gl::Context::lookupAttributeMapping):
        (gl::Context::applyVertexBuffer):
        (gl::Context::applyIndexBuffer):
        (gl::Context::readPixels):
        (gl::Context::clear):
        (gl::Context::drawArrays):
        (gl::Context::drawElements):
        (gl::Context::finish):
        (gl::Context::drawClosingLine):
        (gl::Context::getMaximumVaryingVectors):
        (gl::Context::getMaximumFragmentUniformVectors):
        (gl::Context::supportsEventQueries):
        (gl::Context::supportsFloatTextures):
        (gl::Context::supportsFloatLinearFilter):
        (gl::Context::supportsFloatRenderableTextures):
        (gl::Context::supportsHalfFloatTextures):
        (gl::Context::supportsHalfFloatLinearFilter):
        (gl::Context::supportsHalfFloatRenderableTextures):
        (gl::Context::getMaximumRenderbufferDimension):
        (gl::Context::getMaximumTextureDimension):
        (gl::Context::getMaximumCubeTextureDimension):
        (gl::Context::getMaximumTextureLevel):
        (gl::Context::supportsLuminanceTextures):
        (gl::Context::supportsLuminanceAlphaTextures):
        (gl::Context::supports32bitIndices):
        (gl::Context::getIncompleteTexture):
        (gl::Context::setVertexAttrib):
        (gl::Context::initExtensionString):
        (gl::Context::blitFramebuffer):
        * src/libGLESv2/Context.h:
        (gl::VertexAttribute::VertexAttribute):
        (gl::VertexAttribute::typeSize):
        (gl::VertexAttribute::stride):
        * src/libGLESv2/Fence.cpp: Added.
        (gl::Fence::Fence):
        (gl::Fence::~Fence):
        (gl::Fence::isFence):
        (gl::Fence::setFence):
        (gl::Fence::testFence):
        (gl::Fence::finishFence):
        (gl::Fence::getFenceiv):
        * src/libGLESv2/Fence.h: Added.
        * src/libGLESv2/Framebuffer.cpp:
        (gl::Framebuffer::completeness):
        (gl::DefaultFramebuffer::DefaultFramebuffer):
        (gl::DefaultFramebuffer::completeness):
        * src/libGLESv2/Program.cpp:
        (gl::Program::Program):
        (gl::Program::getSamplerMapping):
        (gl::Program::getUniformLocation):
        (gl::Program::setUniform1iv):
        (gl::Program::applyUniforms):
        (gl::Program::packVaryings):
        (gl::Program::linkVaryings):
        (gl::Program::link):
        (gl::Program::defineUniform):
        (gl::Program::createUniform):
        (gl::Program::applyUniform1iv):
        (gl::Program::resetInfoLog):
        (gl::Program::unlink):
        (gl::Program::getActiveAttribute):
        (gl::Program::getActiveUniform):
        (gl::Program::getDxDepthRangeLocation):
        * src/libGLESv2/Program.h:
        * src/libGLESv2/RefCountObject.cpp:
        (gl::RefCountObject::~RefCountObject):
        * src/libGLESv2/Renderbuffer.cpp:
        (gl::RenderbufferStorage::RenderbufferStorage):
        (gl::RenderbufferStorage::isFloatingPoint):
        (gl::Colorbuffer::Colorbuffer):
        (gl::DepthStencilbuffer::DepthStencilbuffer):
        * src/libGLESv2/Renderbuffer.h:
        * src/libGLESv2/Shader.cpp:
        (gl::Shader::Shader):
        (gl::Shader::parseVaryings):
        (gl::Shader::compileToHLSL):
        (gl::VertexShader::parseAttributes):
        * src/libGLESv2/Texture.cpp:
        (gl::Texture::Texture):
        (gl::Texture::isFloatingPoint):
        (gl::Texture::isRenderableFormat):
        (gl::Texture::selectFormat):
        (gl::Texture::loadImageData):
        (gl::Texture::loadAlphaFloatImageData):
        (gl::Texture::loadAlphaHalfFloatImageData):
        (gl::Texture::loadLuminanceImageData):
        (gl::Texture::loadLuminanceFloatImageData):
        (gl::Texture::loadLuminanceHalfFloatImageData):
        (gl::Texture::loadLuminanceAlphaImageData):
        (gl::Texture::loadLuminanceAlphaFloatImageData):
        (gl::Texture::loadLuminanceAlphaHalfFloatImageData):
        (gl::Texture::loadRGBFloatImageData):
        (gl::Texture::loadRGBHalfFloatImageData):
        (gl::Texture::loadRGBAFloatImageData):
        (gl::Texture::loadRGBAHalfFloatImageData):
        (gl::Texture::createSurface):
        (gl::Texture::setImage):
        (gl::Texture::setCompressedImage):
        (gl::Texture::subImage):
        (gl::Texture::subImageCompressed):
        (gl::Texture::copyNonRenderable):
        (gl::Texture::getD3DFormat):
        (gl::Texture::isRenderable):
        (gl::Texture2D::Texture2D):
        (gl::Texture2D::~Texture2D):
        (gl::Texture2D::redefineTexture):
        (gl::Texture2D::setImage):
        (gl::Texture2D::setCompressedImage):
        (gl::Texture2D::copyImage):
        (gl::Texture2D::copySubImage):
        (gl::Texture2D::isComplete):
        (gl::Texture2D::createTexture):
        (gl::Texture2D::convertToRenderTarget):
        (gl::Texture2D::generateMipmaps):
        (gl::Texture2D::getColorbuffer):
        (gl::Texture2D::getRenderTarget):
        (gl::TextureCubeMap::TextureCubeMap):
        (gl::TextureCubeMap::~TextureCubeMap):
        (gl::TextureCubeMap::subImage):
        (gl::TextureCubeMap::subImageCompressed):
        (gl::TextureCubeMap::isComplete):
        (gl::TextureCubeMap::createTexture):
        (gl::TextureCubeMap::convertToRenderTarget):
        (gl::TextureCubeMap::redefineTexture):
        (gl::TextureCubeMap::copyImage):
        (gl::TextureCubeMap::copySubImage):
        (gl::TextureCubeMap::generateMipmaps):
        (gl::TextureCubeMap::getColorbuffer):
        (gl::TextureCubeMap::getRenderTarget):
        (gl::Texture::TextureColorbufferProxy::TextureColorbufferProxy):
        (gl::Texture::TextureColorbufferProxy::isFloatingPoint):
        * src/libGLESv2/Texture.h:
        * src/libGLESv2/geometry/IndexDataManager.cpp:
        (gl::IndexDataManager::IndexDataManager):
        (gl::IndexDataManager::~IndexDataManager):
        (gl::convertIndices):
        (gl::computeRange):
        (gl::IndexDataManager::prepareIndexData):
        (gl::IndexDataManager::indexSize):
        (gl::IndexDataManager::typeSize):
        (gl::IndexBuffer::IndexBuffer):
        (gl::IndexBuffer::~IndexBuffer):
        (gl::IndexBuffer::getBuffer):
        (gl::IndexBuffer::unmap):
        (gl::StreamingIndexBuffer::StreamingIndexBuffer):
        (gl::StreamingIndexBuffer::~StreamingIndexBuffer):
        (gl::StreamingIndexBuffer::map):
        (gl::StreamingIndexBuffer::reserveSpace):
        (gl::StaticIndexBuffer::StaticIndexBuffer):
        (gl::StaticIndexBuffer::~StaticIndexBuffer):
        (gl::StaticIndexBuffer::map):
        (gl::StaticIndexBuffer::reserveSpace):
        (gl::StaticIndexBuffer::lookupType):
        (gl::StaticIndexBuffer::lookupRange):
        (gl::StaticIndexBuffer::addRange):
        * src/libGLESv2/geometry/IndexDataManager.h:
        (gl::IndexBuffer::size):
        * src/libGLESv2/geometry/VertexDataManager.cpp:
        (gl::VertexDataManager::VertexDataManager):
        (gl::VertexDataManager::~VertexDataManager):
        (gl::VertexDataManager::writeAttributeData):
        (gl::VertexDataManager::prepareVertexData):
        (gl::VertexDataManager::spaceRequired):
        (gl::VertexDataManager::checkVertexCaps):
        (gl::VertexDataManager::typeIndex):
        (gl::VertexDataManager::setupAttributes):
        (gl::VertexBuffer::VertexBuffer):
        (gl::VertexBuffer::~VertexBuffer):
        (gl::VertexBuffer::unmap):
        (gl::VertexBuffer::getBuffer):
        (gl::ConstantVertexBuffer::ConstantVertexBuffer):
        (gl::ConstantVertexBuffer::~ConstantVertexBuffer):
        (gl::ArrayVertexBuffer::ArrayVertexBuffer):
        (gl::ArrayVertexBuffer::~ArrayVertexBuffer):
        (gl::ArrayVertexBuffer::addRequiredSpace):
        (gl::ArrayVertexBuffer::addRequiredSpaceFor):
        (gl::StreamingVertexBuffer::StreamingVertexBuffer):
        (gl::StreamingVertexBuffer::~StreamingVertexBuffer):
        (gl::StreamingVertexBuffer::map):
        (gl::StreamingVertexBuffer::reserveRequiredSpace):
        (gl::StaticVertexBuffer::StaticVertexBuffer):
        (gl::StaticVertexBuffer::~StaticVertexBuffer):
        (gl::StaticVertexBuffer::map):
        (gl::StaticVertexBuffer::reserveRequiredSpace):
        (gl::StaticVertexBuffer::lookupAttribute):
        (gl::VertexDataManager::formatConverter):
        * src/libGLESv2/geometry/VertexDataManager.h:
        (gl::ArrayVertexBuffer::size):
        (gl::VertexDataManager::dirtyCurrentValue):
        * src/libGLESv2/geometry/backend.cpp: Removed.
        * src/libGLESv2/geometry/backend.h: Removed.
        * src/libGLESv2/geometry/dx9.cpp: Removed.
        * src/libGLESv2/geometry/dx9.h: Removed.
        * src/libGLESv2/libGLESv2.cpp:
        * src/libGLESv2/libGLESv2.def:
        * src/libGLESv2/libGLESv2.vcproj:
        * src/libGLESv2/utilities.cpp:
        (gl::UniformComponentCount):
        (gl::UniformComponentType):
        (gl::ComputePixelSize):
        (gl::CheckTextureFormatType):
        (gl::IsColorRenderable):
        (gl::IsDepthRenderable):
        (gl::IsStencilRenderable):
        (es2dx::GetAlphaSize):
        (es2dx::GetRedSize):
        (es2dx::GetGreenSize):
        (es2dx::GetBlueSize):
        (es2dx::GetDepthSize):
        (es2dx::ConvertPrimitiveType):
        (dx2es::ConvertBackBufferFormat):
        (dx2es::ConvertDepthStencilFormat):
        * src/libGLESv2/utilities.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 19 Jan 2011 02:37:59 +0000 (02:37 +0000)]
2011-01-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        [jsfunfuzz] Assertion asking activation for arguments when arguments is overridden
        https://bugs.webkit.org/show_bug.cgi?id=52690

        Add a few more tests.

        * fast/js/function-dot-arguments-expected.txt:
        * fast/js/script-tests/function-dot-arguments.js:
        (overwroteArgumentsInDynamicScope1):
        (overwroteArgumentsInDynamicScope2):
        (overwroteArgumentsInDynamicScope3):
2011-01-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        [jsfunfuzz] Assertion asking activation for arguments when arguments is overridden
        https://bugs.webkit.org/show_bug.cgi?id=52690

        Clean up code to retrieve arguments from activation and function objects.
        Remove the incorrect assertion from JSActivation's argumentsGetter.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::retrieveArguments):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::argumentsGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/8860833> and https://bugs.webkit.org/show_bug.cgi?id=52599
beidson@apple.com [Wed, 19 Jan 2011 01:46:50 +0000 (01:46 +0000)]
<rdar://problem/8860833> and https://bugs.webkit.org/show_bug.cgi?id=52599
UIProcess crash in WebPageProxy::reattachToWebProcess when web process crashes with a new tab/window.

Reviewed by Darin Adler.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcessWithItem): Null check item *both* places it is used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Not reviewed, adding pixel expectations for new test.
dimich@chromium.org [Wed, 19 Jan 2011 01:44:35 +0000 (01:44 +0000)]
[Chromium] Not reviewed, adding pixel expectations for new test.

* platform/chromium-mac/fast/css/background-clip-values-expected.checksum: Added.
* platform/chromium-mac/fast/css/background-clip-values-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/8752200> and https://bugs.webkit.org/show_bug.cgi?id=52664
beidson@apple.com [Wed, 19 Jan 2011 01:37:05 +0000 (01:37 +0000)]
<rdar://problem/8752200> and https://bugs.webkit.org/show_bug.cgi?id=52664
Need WebKit2 API to asynchronously get the resource data for a URL

Reviewed by Maciej Stachowiak.

Rename WKFrameGetMainResourceDataFunction to WKFrameGetResourceDataFunction, and add
new API to get a resource by URL:
* UIProcess/API/C/WKFrame.cpp:
(WKFrameGetMainResourceData):
(WKFrameGetResourceData):
(callGetResourceDataBlockAndDispose):
(WKFrameGetMainResourceData_b):
(WKFrameGetResourceData_b):
* UIProcess/API/C/WKFrame.h:

Implement the new API in the UIProcess side:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::getResourceData):
* UIProcess/WebFrameProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getResourceDataFromFrame):
* UIProcess/WebPageProxy.h:

Have the WebProcess get the data and call back to the UIProcess:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getResourceDataFromFrame):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 19 Jan 2011 01:30:56 +0000 (01:30 +0000)]
2011-01-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Make PageClientImpl::scrollView do hardware blitting
        https://bugs.webkit.org/show_bug.cgi?id=52689

        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::scrollView):
        Clip the scroll rect and scroll the view.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
        Scroll before painting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 19 Jan 2011 01:16:00 +0000 (01:16 +0000)]
2011-01-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Artifacts when scrolling with new drawing area
        https://bugs.webkit.org/show_bug.cgi?id=52682

        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::scroll):
        When scrolling, we want the intersection of the scroll rect and clip rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a test that calling window.open with an empty URL does not trigger an assertion or
jberlin@webkit.org [Wed, 19 Jan 2011 01:13:16 +0000 (01:13 +0000)]
Add a test that calling window.open with an empty URL does not trigger an assertion or
cause a crash.
https://bugs.webkit.org/show_bug.cgi?id=52654

Reviewed by Adam Roben.

* fast/dom/Window/open-window-empty-url-expected.txt: Added.
* fast/dom/Window/open-window-empty-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 MORITA Hajime <morrita@google.com>
morrita@google.com [Wed, 19 Jan 2011 01:10:58 +0000 (01:10 +0000)]
2011-01-18  MORITA Hajime  <morrita@google.com>

        Reviewed by Simon Fraser.

        Refactoring: Extract RoundedIntRect class
        https://bugs.webkit.org/show_bug.cgi?id=51664

        RoundedIntRect is a pair of rect and four IntSize objects which represent
        corner radii of the rectangle. IntSize is grouped into RoundedIntRect::Radii.
        Now RenderStyle::getRoundedBorderFor() and RenderStyle::getRoundedInnerBorderWithBorderWidths()
        return RoundedIntRect and GraphicsContext::addRoundedRectClip(), GraphicsContext::fillRoundedRect()
        and other functions accept RoundedIntRect as an argument.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::addRoundedRectClip):
        (WebCore::GraphicsContext::clipOutRoundedRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/RoundedIntRect.cpp: Added.
        (WebCore::RoundedIntRect::Radii::isZero):
        (WebCore::RoundedIntRect::Radii::scale):
        (WebCore::RoundedIntRect::Radii::expand):
        (WebCore::RoundedIntRect::Radii::includeLogicalEdges):
        (WebCore::RoundedIntRect::Radii::excludeLogicalEdges):
        (WebCore::RoundedIntRect::RoundedIntRect):
        (WebCore::RoundedIntRect::includeLogicalEdges):
        (WebCore::RoundedIntRect::excludeLogicalEdges):
        * platform/graphics/RoundedIntRect.h: Added.
        (WebCore::RoundedIntRect::Radii::Radii):
        (WebCore::RoundedIntRect::Radii::setTopLeft):
        (WebCore::RoundedIntRect::Radii::setTopRight):
        (WebCore::RoundedIntRect::Radii::setBottomLeft):
        (WebCore::RoundedIntRect::Radii::setBottomRight):
        (WebCore::RoundedIntRect::Radii::topLeft):
        (WebCore::RoundedIntRect::Radii::topRight):
        (WebCore::RoundedIntRect::Radii::bottomLeft):
        (WebCore::RoundedIntRect::Radii::bottomRight):
        (WebCore::RoundedIntRect::Radii::expand):
        (WebCore::RoundedIntRect::Radii::shrink):
        (WebCore::RoundedIntRect::rect):
        (WebCore::RoundedIntRect::radii):
        (WebCore::RoundedIntRect::isRounded):
        (WebCore::RoundedIntRect::isEmpty):
        (WebCore::RoundedIntRect::setRect):
        (WebCore::RoundedIntRect::setRadii):
        (WebCore::RoundedIntRect::move):
        (WebCore::RoundedIntRect::inflate):
        (WebCore::RoundedIntRect::inflateWithRadii):
        (WebCore::RoundedIntRect::expandRadii):
        (WebCore::RoundedIntRect::shrinkRadii):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::pushContentsClip):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::paintBorder):
        (WebCore::RenderBoxModelObject::clipBorderSidePolygon):
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::drawBoxSideFromPath):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMenuListButtonGradients):
        (WebCore::RenderThemeMac::paintSliderTrack):
        * rendering/RenderThemeSafari.cpp:
        (WebCore::RenderThemeSafari::paintMenuListButtonGradients):
        (WebCore::RenderThemeSafari::paintSliderTrack):
        * rendering/RenderThemeWinCE.cpp:
        (WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        * rendering/style/BorderData.h:
        * rendering/style/RenderStyle.cpp:
        (WebCore::calcRadiiFor):
        (WebCore::calcConstraintScaleFor):
        (WebCore::RenderStyle::getRoundedBorderFor):
        (WebCore::RenderStyle::getRoundedInnerBorderWithBorderWidths):
        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::setBorderRadius):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 19 Jan 2011 00:30:17 +0000 (00:30 +0000)]
2011-01-18  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        make file expansion use the file at the svn revision the diff was created at
        https://bugs.webkit.org/show_bug.cgi?id=52650

        This only works for patches created with SVN for now since the git
        diff does not include SVN revision numbers in it.

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 19 Jan 2011 00:15:34 +0000 (00:15 +0000)]
2011-01-18  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] NRWT looking for DRT binary in the wrong path on Mac
        https://bugs.webkit.org/show_bug.cgi?id=52678

        Update path now that WebKit is inside Source.

        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 19 Jan 2011 00:15:22 +0000 (00:15 +0000)]
2011-01-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Use a CGLayer for the backing store when possible
        https://bugs.webkit.org/show_bug.cgi?id=52679

        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::paint):
        If there is a layer, paint it into the given context.

        (WebKit::BackingStore::backingStoreContext):
        If we can get the containing window graphics context, use it to create a
        CGLayer that we'll use for the backing store.

        (WebKit::BackingStore::scroll):
        Paint the layer into itself.

        * UIProcess/mac/WebPageProxyMac.mm:
        (WebKit::WebPageProxy::containingWindowGraphicsContext):
        Call the page client.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Robert Hogan <robert@webkit.org>
robert@webkit.org [Tue, 18 Jan 2011 23:49:42 +0000 (23:49 +0000)]
2011-01-18  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] http/tests/incremental/slow-utf8-text.pl fails
        https://bugs.webkit.org/show_bug.cgi?id=44282

        * platform/qt/Skipped:
2011-01-18  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] http/tests/incremental/slow-utf8-text.pl fails
        https://bugs.webkit.org/show_bug.cgi?id=44282

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::responseMimeType):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-01-18  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] http/tests/incremental/slow-utf8-text.pl fails
        https://bugs.webkit.org/show_bug.cgi?id=44282

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 18 Jan 2011 23:45:34 +0000 (23:45 +0000)]
2011-01-18  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Removed RegisterFile::markGlobals because it was obtuse, and it
        unnecessarily relied on conservative marking.
        https://bugs.webkit.org/show_bug.cgi?id=52668

        * interpreter/RegisterFile.h: Removed markGlobals.

        * runtime/JSActivation.cpp:
        (JSC::JSActivation::markChildren): Added a comment explaning why some
        JSActivations don't always mark their registers arrays.

        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::markChildren): Instead of calling markGlobals, mark
        the registers array directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 18 Jan 2011 23:40:46 +0000 (23:40 +0000)]
2011-01-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Pass the web page proxy to BackingStore::create
        https://bugs.webkit.org/show_bug.cgi?id=52673

        * UIProcess/BackingStore.cpp:
        (WebKit::BackingStore::create):
        Add WebPageProxy parameter.

        (WebKit::BackingStore::BackingStore):
        Add WebPageProxy parameter.

        * UIProcess/BackingStore.h:
        Add WebPageProxy member variable.

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
        Pass the web page proxy when creating the backing store.

        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::backingStoreContext):
        Set the default blend mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Tue, 18 Jan 2011 23:31:30 +0000 (23:31 +0000)]
2011-01-18  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540)
        https://bugs.webkit.org/show_bug.cgi?id=52540
        https://bugs.webkit.org/show_bug.cgi?id=52662

        Directly use backtrack label with parentheses nested under a
        non-capturing parentheses.  Also linked current parentheses
        tail code object for possible parens nested within a non-capturing
        parentheses.

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::BacktrackDestination::linkBacktrackToLabel):
        (JSC::Yarr::YarrGenerator::generateParenthesesSingle):
2011-01-18  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/8875432> Regression: Some text-only e-mails cause hang beneath RegExp::match (52540)
        https://bugs.webkit.org/show_bug.cgi?id=52540
        https://bugs.webkit.org/show_bug.cgi?id=52662

        New tests to check for proper linking of parentheses nested under
        a non-capturing parentheses.

        * fast/regex/parentheses-expected.txt:
        * fast/regex/script-tests/parentheses.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Victoria Kirst <vrk@chromium.org>
commit-queue@webkit.org [Tue, 18 Jan 2011 23:27:08 +0000 (23:27 +0000)]
2011-01-18  Victoria Kirst  <vrk@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Adding support for YV16 video frame formats.
        https://bugs.webkit.org/show_bug.cgi?id=52345

        * platform/graphics/chromium/VideoLayerChromium.cpp:
        (WebCore::VideoLayerChromium::determineTextureFormat):
        (WebCore::VideoLayerChromium::draw):
2011-01-18  Victoria Kirst  <vrk@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Adding support for YV16 video frame formats.
        https://bugs.webkit.org/show_bug.cgi?id=52345

        * src/VideoFrameChromiumImpl.cpp:
        (WebKit::VideoFrameChromiumImpl::requiredTextureSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/8479998> REGRESSION (r67660): broken button layout at devforums.apple.com
hyatt@apple.com [Tue, 18 Jan 2011 23:24:28 +0000 (23:24 +0000)]
<rdar://problem/8479998> REGRESSION (r67660): broken button layout at devforums.apple.com

Reviewed by Dan Bernstein.

Exclude floating objects from shrinking to avoid floats.  They should never do this.  Timing-related bugs could
occur as a result of this mistake, and the change to rewrite pagination to defer layout of floats until they
got encountered on the correct line exposed this issue.

Source/WebCore:

Added /fast/block/float/float-overflow-hidden-containing-block-width.html.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::shrinkToAvoidFloats):

LayoutTests:

Added /fast/block/float/float-overflow-hidden-containing-block-width.html.
* fast/block/float/float-overflow-hidden-containing-block-width.html: Added.
* platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.checksum: Added.
* platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.png: Added.
* platform/mac/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 18 Jan 2011 23:21:03 +0000 (23:21 +0000)]
2011-01-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        Fix a small race condition that could cause the unit tests for
        new-run-webkit-tests to fail in a multithreaded environment.
        There was a small window in the code where one thread would
        check to see if a thread had raised an exception, do something,
        and then check to see if the thread was alive. If the other
        thread raised an exception and exited in between these two
        steps, the exception would be lost. Flipping the order of the
        two checks fixes the race, since we will now always check for an
        exception on the thread before exiting.

        https://bugs.webkit.org/show_bug.cgi?id=51579

        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 18 Jan 2011 23:08:18 +0000 (23:08 +0000)]
2011-01-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Factor code to create the backing store bitmap context out into a new function
        https://bugs.webkit.org/show_bug.cgi?id=52670

        * UIProcess/BackingStore.h:
        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::backingStoreContext):
        Create the backing store context.

        (WebKit::BackingStore::incorporateUpdate):
        Call backingStoreContext.

        (WebKit::BackingStore::scroll):
        Assert that the context is not null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 18 Jan 2011 22:59:09 +0000 (22:59 +0000)]
2011-01-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue dies when test archiving fails
        https://bugs.webkit.org/show_bug.cgi?id=52617

        I looked at the machine and it had 10 archives already
        thus find_unused_name was returning None.  I've upped
        the limit to 100 (per bug) and tested the case where
        find_unused_name returns None (making archive return None).

        * Scripts/webkitpy/common/system/workspace.py:
        * Scripts/webkitpy/common/system/workspace_unittest.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Not reviewed, updated expectations for tests
dimich@chromium.org [Tue, 18 Jan 2011 22:56:56 +0000 (22:56 +0000)]
[Chromium] Not reviewed, updated expectations for tests
affected by http://trac.webkit.org/changeset/76047

* platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.checksum:
* platform/chromium-mac/fast/backgrounds/size/backgroundSize22-expected.png:
* platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/backgroundSize22-expected.png:
* platform/chromium-win/fast/css/background-clip-values-expected.checksum: Added.
* platform/chromium-win/fast/css/background-clip-values-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 18 Jan 2011 22:55:42 +0000 (22:55 +0000)]
2011-01-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Add PageClientImpl::containingWindowGraphicsContext
        https://bugs.webkit.org/show_bug.cgi?id=52666

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::containingWindowGraphicsContext):
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 18 Jan 2011 22:53:41 +0000 (22:53 +0000)]
2011-01-18  Daniel Bates  <dbates@rim.com>

        Reviewed by Gavin Barraclough.

        Only use moving memory model assumption in ExecutableAllocator::intializePageSize() for Symbian OS
        https://bugs.webkit.org/show_bug.cgi?id=52517

        Patch by David Tapuska

        Currently, we compile code with respect to the Symbian-specific moving memory model
        assumption for all ARMv5 or lower architectures. Instead, we should only compile
        such code when building for Symbian OS on those architectures because this model
        is Symbian-specific.

        * jit/ExecutableAllocator.cpp:
        (JSC::ExecutableAllocator::intializePageSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 18 Jan 2011 22:45:33 +0000 (22:45 +0000)]
2011-01-18  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Make CheckedInt<long> and CheckedInt<unsigned long> work
        https://bugs.webkit.org/show_bug.cgi?id=52401

        * html/canvas/CheckedInt.h:
        (WebCore::CheckedInt::CheckedInt): Merge with the patch provided by Benoit Jacob.
        * html/canvas/WebGLBuffer.cpp:
        (WebCore::WebGLBuffer::associateBufferDataImpl): Use CheckedInt<long> instead of CheckedInt<int>.
        (WebCore::WebGLBuffer::associateBufferSubDataImpl): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Damian Kaleta <dkaleta@apple.com>
commit-queue@webkit.org [Tue, 18 Jan 2011 22:30:25 +0000 (22:30 +0000)]
2011-01-18  Damian Kaleta  <dkaleta@apple.com>

        Reviewed by Sam Weinig.

        WK2 methods WKPageScaleWebView and WKPageGetViewScaleFactor need to have consistent names
        https://bugs.webkit.org/show_bug.cgi?id=52647

        * UIProcess/API/C/WKPage.cpp:
        (WKPageSetScaleFactor):
        (WKPageGetScaleFactor):
        * UIProcess/API/C/WKPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 18 Jan 2011 22:22:21 +0000 (22:22 +0000)]
2011-01-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Ask the web page proxy to scroll the view when needed
        https://bugs.webkit.org/show_bug.cgi?id=52665

        * UIProcess/DrawingAreaProxyImpl.cpp:
        (WebKit::DrawingAreaProxyImpl::incorporateUpdate):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::scrollView):
        * UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build.
andersca@apple.com [Tue, 18 Jan 2011 22:18:29 +0000 (22:18 +0000)]
Fix build.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::scrollView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 18 Jan 2011 22:11:48 +0000 (22:11 +0000)]
2011-01-18  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Must strip comments from WebGL shaders before enforcing character set
        https://bugs.webkit.org/show_bug.cgi?id=52390

        Strip comments from incoming shaders, preserving line numbers,
        before validating that they conform to the ESSL character set.
        Revert changes from http://trac.webkit.org/changeset/75735 which
        allowed invalid characters to be passed to certain APIs.

        Tested with WebGL layout tests, conformance test suite and several
        WebGL demos in both Safari and Chromium.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::StripComments::StripComments::process):
        (WebCore::WebGLRenderingContext::shaderSource):
2011-01-18  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Must strip comments from WebGL shaders before enforcing character set
        https://bugs.webkit.org/show_bug.cgi?id=52390

        Incorporated non-ASCII GLSL conformance tests from Khronos
        repository. Updated and synchronized invalid-passed-params.html
        with Khronos repository, undoing changes from
        http://trac.webkit.org/changeset/75735 .

        * fast/canvas/webgl/glsl-conformance-expected.txt:
        * fast/canvas/webgl/invalid-passed-params-expected.txt:
        * fast/canvas/webgl/invalid-passed-params.html:
        * fast/canvas/webgl/shaders/00_shaders.txt:
        * fast/canvas/webgl/shaders/misc: Added.
        * fast/canvas/webgl/shaders/misc/00_shaders.txt: Added.
        * fast/canvas/webgl/shaders/misc/non-ascii-comments.vert: Added.
        * fast/canvas/webgl/shaders/misc/non-ascii.vert: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 18 Jan 2011 22:08:15 +0000 (22:08 +0000)]
2011-01-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add PageClient::scrollView
        https://bugs.webkit.org/show_bug.cgi?id=52663

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::scrollView):
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::scrollView):
        * UIProcess/API/qt/qwkpage_p.h:
        * UIProcess/PageClient.h:
        * UIProcess/win/WebView.cpp:
        (WebKit::PageClientImpl::scrollView):
        * UIProcess/win/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename scrollDelta to scrollOffset everywhere.
andersca@apple.com [Tue, 18 Jan 2011 21:55:21 +0000 (21:55 +0000)]
Rename scrollDelta to scrollOffset everywhere.

Reviewed by Sam Weinig.

* Shared/UpdateInfo.cpp:
(WebKit::UpdateInfo::encode):
(WebKit::UpdateInfo::decode):
* Shared/UpdateInfo.h:
* UIProcess/BackingStore.h:
* UIProcess/mac/BackingStoreMac.mm:
(WebKit::BackingStore::incorporateUpdate):
(WebKit::BackingStore::scroll):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::scroll):
(WebKit::WebChromeClient::delegatedScrollRequested):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::scroll):
* WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::display):
* WebProcess/WebPage/DrawingAreaImpl.h:
* WebProcess/WebPage/LayerBackedDrawingArea.cpp:
(WebKit::LayerBackedDrawingArea::scroll):
* WebProcess/WebPage/LayerBackedDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Dimitry Andric <dim@freebsd.org>
commit-queue@webkit.org [Tue, 18 Jan 2011 21:46:14 +0000 (21:46 +0000)]
2011-01-18  Dimitry Andric  <dim@freebsd.org>

        Reviewed by Andreas Kling.

        Fix linking JavaScriptCore on FreeBSD/amd64
        https://bugs.webkit.org/show_bug.cgi?id=52591

        Linking of JavaScriptCore on FreeBSD/amd64 fails, for the same reason as
        in bug 28422: cti_vm_throw needs a "@plt" suffix, otherwise the linker
        complains about the relocation type.

        * jit/JITStubs.cpp: use @plt suffix on x86_64 platforms, for both Linux
        and FreeBSD.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 18 Jan 2011 21:43:15 +0000 (21:43 +0000)]
2011-01-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        Update rebaseline-chromium-webkit-tests unit tests to use a mock
        filesystem. Also fix a couple of "with" statements missed by
        r76050.

        https://bugs.webkit.org/show_bug.cgi?id=52487

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Tue, 18 Jan 2011 21:37:19 +0000 (21:37 +0000)]
2011-01-18  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Add LayoutTests for new compositing layer logic
        https://bugs.webkit.org/show_bug.cgi?id=52657

        Add 4 tests checking that the layer tree is properly constructed with nested
        layers. The first test is a simple static test of a layer with a 3D transform
        with a non-layered parent. It is a pixel test and is just looking for a correct
        image. The second test is similar but has a 4 deep hierarchy of <div> element where
        only the innermost layer has a 3D transform. It is also a pixel test.
        The other 2 tests are the same except that they add and then remove the innermost
        layer's transform. It makes sure the layer tree is correct before and after
        these changes.

        * compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
        * compositing/geometry/layer-due-to-layer-children-deep-switch.html: Added.
        * compositing/geometry/layer-due-to-layer-children-deep.html: Added.
        * compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
        * compositing/geometry/layer-due-to-layer-children-switch.html: Added.
        * compositing/geometry/layer-due-to-layer-children.html: Added.
        * platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.checksum: Added.
        * platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added.
        * platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added.
        * platform/mac/compositing/geometry/layer-due-to-layer-children-expected.checksum: Added.
        * platform/mac/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
        * platform/mac/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 18 Jan 2011 21:33:34 +0000 (21:33 +0000)]
2011-01-18  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Stop instantiating legacy editing positions in DeleteSelectionCommand, IndentOudentCommand,
        InsertLineBreakCommand, InsertListCOmmand.cpp, InsertParagraphSeparatorCommand, and htmlediting.cpp
        https://bugs.webkit.org/show_bug.cgi?id=52644

        This is a cleanup to stop instantiating legacy editing positions in the following tests.
        firstDeepEditingPositionForNode and lastDeepEditingPositionForNode in htmlediting.h are not updated
        because doing so requires significant code changes. They are tracked on the bug 52642.

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializeStartEnd):
        (WebCore::updatePositionForNodeRemoval):
        (WebCore::DeleteSelectionCommand::removeNode):
        (WebCore::updatePositionForTextRemoval):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::outdentParagraph):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApplyForSingleParagraph):
        (WebCore::InsertListCommand::unlistifyParagraph):
        (WebCore::InsertListCommand::listifyParagraph):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/htmlediting.cpp:
        (WebCore::enclosingBlock):
        (WebCore::enclosingList):
        (WebCore::enclosingListChild):
        (WebCore::indexForVisiblePosition):
        (WebCore::isNodeVisiblyContainedWithin):
        (WebCore::avoidIntersectionWithNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 18 Jan 2011 21:29:30 +0000 (21:29 +0000)]
2011-01-18  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Ojan Vafai.

        [Chromium] Update Sputnik test expectations
        https://bugs.webkit.org/show_bug.cgi?id=52656

        Mark Sputnik tests as WONTFIX, so that they don't artificially inflate
        our failing test count.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Tue, 18 Jan 2011 21:28:55 +0000 (21:28 +0000)]
2011-01-18  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Build fixes for gtk3 build
        https://bugs.webkit.org/show_bug.cgi?id=52648

        * DumpRenderTree/gtk/EventSender.cpp:
        (beginDragWithFilesCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 18 Jan 2011 21:28:40 +0000 (21:28 +0000)]
2011-01-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Get and paint each individual rect in -[WKView drawRect:]
        https://bugs.webkit.org/show_bug.cgi?id=52660

        * UIProcess/API/mac/WKView.mm:
        (-[WKView drawRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Benjamin Kalman <kalman@chromium.org>
commit-queue@webkit.org [Tue, 18 Jan 2011 21:24:04 +0000 (21:24 +0000)]
2011-01-18  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ryosuke Niwa.

        Tweak style in visible_units.cpp and TextIterator.cpp in preparation for another patch
        https://bugs.webkit.org/show_bug.cgi?id=52610

        This is a purely aesthetic change.

        * editing/TextIterator.cpp:
        (WebCore::SimplifiedBackwardsTextIterator::advance):
        * editing/visible_units.cpp:
        (WebCore::previousBoundary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 18 Jan 2011 21:22:07 +0000 (21:22 +0000)]
2011-01-18  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed. Update .gitignore to reflect that WebKit is now in Source.

        * .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Not reviewed, test expectations update.
dimich@chromium.org [Tue, 18 Jan 2011 21:17:21 +0000 (21:17 +0000)]
[Chromium] Not reviewed, test expectations update.
Added exclusion for new test fast/canvas/canvas-fillPath-alpha-shadow.html

* platform/chromium-gpu/test_expectations.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 18 Jan 2011 21:10:33 +0000 (21:10 +0000)]
2011-01-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        Update rebaseline-chromium-webkit-tests to use filesystem objects
        instead of direct references to os.path, shutil, tempfile, etc.

        This patch doesn't change anything, but will allow subsequent
        patches to change the unit tests to no longer use the real
        filesystem.

        This patch adds a bunch more methods to the filesystem object as
        well.

        https://bugs.webkit.org/show_bug.cgi?id=52482

        * Scripts/webkitpy/common/system/filesystem.py:
        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 18 Jan 2011 21:09:29 +0000 (21:09 +0000)]
2011-01-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Antti Koivisto.

        [jsfunfuzz] Assertion in codegen for array of NaN constants
        https://bugs.webkit.org/show_bug.cgi?id=52643

        Add a testcase to ensure we handle a large number of NaN literals
        in (0/0 is folded to NaN automatically during parsing).

        * fast/js/codegen-temporaries-expected.txt:
        * fast/js/script-tests/codegen-temporaries.js:
2011-01-18  Oliver Hunt  <oliver@apple.com>

        Reviewed by Antti Koivisto.

        [jsfunfuzz] Assertion in codegen for array of NaN constants
        https://bugs.webkit.org/show_bug.cgi?id=52643

        Don't cache NaN literals in the code generator, as NaN doesn't compare
        as equal to itself it causes problems when rehashing the number cache.

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::emitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Tue, 18 Jan 2011 21:02:31 +0000 (21:02 +0000)]
2011-01-18  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor
        https://bugs.webkit.org/show_bug.cgi?id=42236

        * platform/chromium/ChromiumBridge.h:
        * platform/chromium/WidgetChromium.cpp:
        (WebCore::Widget::setCursor):
2011-01-18  Adam Klein  <adamk@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor
        https://bugs.webkit.org/show_bug.cgi?id=42236

        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::setCursor):
        * src/ChromeClientImpl.h:
        * src/ChromiumBridge.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Krithigassree Sambamurthy <krithigassree.sambamurthy@nokia.com>
commit-queue@webkit.org [Tue, 18 Jan 2011 20:37:44 +0000 (20:37 +0000)]
2011-01-18  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>

        Reviewed by Simon Fraser.

        Support background-clip: content-box
        https://bugs.webkit.org/show_bug.cgi?id=48771

        Addded content-box as a valid background-clip value.

        * WebCore/css/CSSParser.cpp:
        (WebCore::parseBackgroundClip):
2011-01-18  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>

        Reviewed by Simon Fraser.

        Support background-clip: content-box
        https://bugs.webkit.org/show_bug.cgi?id=48771

        Added test cases to check the various valid background-clip values.

        * fast/css/background-clip-text-expected.txt:
        * fast/css/background-clip-values-expected.checksum: Added.
        * fast/css/background-clip-values-expected.txt: Added.
        * fast/css/background-clip-values.html: Added.
        * fast/css/script-tests/background-clip-text.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 18 Jan 2011 20:34:39 +0000 (20:34 +0000)]
2011-01-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Assertion when loading two URLs in quick succession
        https://bugs.webkit.org/show_bug.cgi?id=52649
        <rdar://problem/8764645>

        If beginLoad is called twice without didStartProvisionalLoad being called in between,
        m_pendingProvisionalSandboxExtension would be non-null and an assert would fire.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::SandboxExtensionTracker::beginLoad):
        Instead of asserting that m_pendingProvisionalSandboxExtension is null, invalidate it
        if it is not null, since that's valid.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 18 Jan 2011 20:32:22 +0000 (20:32 +0000)]
2011-01-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests shouldn't crash when you try to run a
        directory containing only skipped files.

        https://bugs.webkit.org/show_bug.cgi?id=52478

        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION: A problem with Voiceover and finding links
cfleizach@apple.com [Tue, 18 Jan 2011 20:27:48 +0000 (20:27 +0000)]
REGRESSION: A problem with Voiceover and finding links
https://bugs.webkit.org/show_bug.cgi?id=52324

Reviewed by Darin Adler.

Source/WebCore:

Fallout from recent change to make WebCore return its own scroll view.
   1) There were two scroll views in the hierarchy, one which no needed to be ignored.
   2) Hit tests for sub frames needed to be offset.
   3) The check for whether an attachment is ignored must happen earlier than using
      the helpText to determine if an element should be ignored.

Test: platform/mac/accessibility/iframe-with-title-correct-hierarchy.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper scrollViewParent]):

Source/WebKit/mac:

* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView accessibilityIsIgnored]):

LayoutTests:

* platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt: Added.
* platform/mac/accessibility/iframe-with-title-correct-hierarchy.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 18 Jan 2011 20:09:09 +0000 (20:09 +0000)]
2011-01-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement NPN_PopUpContextMenu
        https://bugs.webkit.org/show_bug.cgi?id=52646
        <rdar://problem/8735616>

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_PopUpContextMenu):
        Call NetscapePlugin::popUpContextMenu.

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::NetscapePlugin):
        Initialize m_currentMouseEvent.

        * WebProcess/Plugins/Netscape/NetscapePlugin.h:
        Add m_currentMouseEvent.

        * WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
        (WebKit::NetscapePlugin::popUpContextMenu):
        Convert the coordinates from the current mouse event to screen coordinates and call
        WKPopupContextMenu.

        (WebKit::NetscapePlugin::platformHandleMouseEvent):
        Update m_currentMouseEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd WKPopupContextMenu.
andersca@apple.com [Tue, 18 Jan 2011 19:56:25 +0000 (19:56 +0000)]
Add WKPopupContextMenu.

Reviewed by Darin Adler.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCall alternate CFHTTPCookie functions if available
aroben@apple.com [Tue, 18 Jan 2011 19:15:03 +0000 (19:15 +0000)]
Call alternate CFHTTPCookie functions if available

Fixes <http://webkit.org/b/52637> <rdar://problem/8878984>.

Reviewed by Darin Adler.

* platform/network/cf/CookieJarCFNet.cpp: Added soft-linking macros to
pull in the alternate CFHTTPCookie functions.

(WebCore::cookieDomain):
(WebCore::cookieExpirationTime):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):
Added these wrappers around the CFHTTPCookie functions. We call the
alternate functions if they exist, otherwise fall back to the current
functions.

(WebCore::filterCookies):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
Changed to use the wrapper functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit2: Do not assert that the provisional and committed URLs cannot be empty/null
jberlin@webkit.org [Tue, 18 Jan 2011 19:06:58 +0000 (19:06 +0000)]
WebKit2: Do not assert that the provisional and committed URLs cannot be empty/null
https://bugs.webkit.org/show_bug.cgi?id=52641

Reviewed by Darin Adler.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFinishLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-18 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 18 Jan 2011 19:06:10 +0000 (19:06 +0000)]
2011-01-18  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Filenames are converted to URLs during edit drags
        https://bugs.webkit.org/show_bug.cgi?id=52096

        * platform/gtk/Skipped: Unskip passing test. Fix a misspelled
        drag and drop test on the list as well.
2011-01-18  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Filenames are converted to URLs during edit drags
        https://bugs.webkit.org/show_bug.cgi?id=52096

        * platform/gtk/DragDataGtk.cpp: Only advertise and deliver filenames as URLs if the
        conversion policy allows it.
        (WebCore::DragData::containsURL): Ditto.
        (WebCore::DragData::asURL): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76039 268f45cc-cd09-0410-ab3c-d52691b4dbfc