WebKit-https.git
9 years ago2010-12-06 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 9 Dec 2010 18:31:52 +0000 (18:31 +0000)]
2010-12-06  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        * configure.ac: new configure flag to disable the new Javascript
        Fullscreen API build. It is enabled by default.

WebCore:

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        * GNUmakefile.am: enable the Javascript Fullscreen API feature if
        it's been requested at configure time.

WebKit/gtk:

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        Fullscreen API support. It is controlled at runtime using a new
        setting called enable-fullscreen, set to FALSE by default.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::supportsFullScreenForElement):
        (WebKit::ChromeClient::enterFullScreenForElement):
        (WebKit::ChromeClient::exitFullScreenForElement):
        * WebCoreSupport/ChromeClientGtk.h:
        * webkit/webkitwebsettings.cpp:
        (webkit_web_settings_class_init):
        (webkit_web_settings_set_property):
        (webkit_web_settings_get_property):
        (webkit_web_settings_copy):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_update_settings):

WebKitTools:

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        Enable the Javascript Fullscreen support in the GtkLauncher. Also
        make DRT update the Chrome when the WebView settings have been
        reset to consistent values.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):
        * GtkLauncher/main.c:
        (create_window):
        * Scripts/build-webkit:

LayoutTests:

        Reviewed by Martin Robinson.

        [GTK] Support the Mozilla-style Fullscreen Javascript API
        https://bugs.webkit.org/show_bug.cgi?id=50572

        * platform/gtk/Skipped: Unskip now passing fullscreen tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 9 Dec 2010 18:27:13 +0000 (18:27 +0000)]
2010-12-09  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        Addressed the "FIXME" issues in array sort for toString() methods that
        mutate the array in either size or contents.  The change is to mark
        the temporary array contents so that they are not garbage collected
        and to make sure the array is large enough to hold the contents
        of the sorted temporary vector.
        https://bugs.webkit.org/show_bug.cgi?id=50718

        * runtime/Collector.cpp:
        (JSC::Heap::addTempSortVector):
        (JSC::Heap::removeTempSortVector):
        (JSC::Heap::markTempSortVectors):
        (JSC::Heap::markRoots):
        * runtime/Collector.h:
        * runtime/JSArray.cpp:
        (JSC::JSArray::sort):
        * runtime/JSValue.h:
2010-12-09  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoffrey Garen.

        New test to verify that arrays sort per the standard even it
        there is an override for toString() that modifies the array.
        https://bugs.webkit.org/show_bug.cgi?id=50718

        * fast/js/array-sort-modifying-tostring-expected.txt: Added.
        * fast/js/array-sort-modifying-tostring.html: Added.
        * fast/js/script-tests/array-sort-modifying-tostring.js: Added.
        (do_gc):
        (Item):
        (toString_Mutate):
        (test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Yong Li <yoli@rim.com>
commit-queue@webkit.org [Thu, 9 Dec 2010 18:26:54 +0000 (18:26 +0000)]
2010-12-09  Yong Li  <yoli@rim.com>

        Reviewed by Darin Adler.

        Check the return value of ImageBuffer::create()
        to avoid crash when ImageBuffer::create() fails.
        https://bugs.webkit.org/show_bug.cgi?id=50631

        No new test because it relies on the platform implementation
        of ImageBuffer. It is hard to make ImageBuffer::create() fail
        in most ports.

        * platform/graphics/GeneratedImage.cpp:
        (WebCore::GeneratedImage::drawPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 9 Dec 2010 18:07:52 +0000 (18:07 +0000)]
2010-12-09  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Implement "Use Selection for Find" in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=50737
        <rdar://problem/8564881>

        Implement a TakeFindStringFromSelection editor command. This is
        used solely to implement the "Use Selection for Find" menu command
        on Mac, and is not made available to script. On WebKit2, it is
        very convenient to reuse the editing machinery since this command
        is very similar to Copy.

        * editing/Editor.h:
        * editing/EditorCommand.cpp:
        (WebCore::executeTakeFindStringFromSelection): Call to a mac-only Editor function.
        (WebCore::enabledTakeFindStringFromSelection): Check using Editor::canCopyExcludingStandaloneImage
        (WebCore::createCommandMap): Add "TakeFindStringFromSelection" command.
        * editing/mac/EditorMac.mm:
        (WebCore::Editor::canCopyExcludingStandaloneImages): Helper function; we can't use Editor::canCopy
        since it would make no sense to enable "Use Selection for Find" when viewing a standalone image
        document.
        (WebCore::Editor::takeFindStringFromSelection): Implement by copying the selected text
        to the special Find pasteboard.
2010-12-09  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Implement "Use Selection for Find" in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=50737
        <rdar://problem/8564881>

        * UIProcess/API/mac/WKView.mm: Add support for the takeFindStringFromSelection:
        selector as a command.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Thu, 9 Dec 2010 17:51:07 +0000 (17:51 +0000)]
2010-12-09  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        As part of r73559, I added the referenceNode check to validate whether the root
        node of the iterator matches the node which is getting moved to other document.
        referenceNode is initialized to root, however can get moved using previousNode
        and nextNode methods, so it is required to use root directly.
        https://bugs.webkit.org/show_bug.cgi?id=50764

        Test: fast/dom/node-iterator-reference-node-moved-crash.html

        * dom/Document.cpp:
        (WebCore::Document::moveNodeIteratorsToNewDocument): change referenceNode to root.
2010-12-09  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Tests that we do not crash when we move the referenceNode using node iterator
        methods previousNode and nextNode.
        https://bugs.webkit.org/show_bug.cgi?id=50764

        * fast/dom/node-iterator-reference-node-moved-crash-expected.txt: Added.
        * fast/dom/node-iterator-reference-node-moved-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 9 Dec 2010 17:23:00 +0000 (17:23 +0000)]
2010-12-08  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Provide a generic way to store shadowParent on a Node.
        https://bugs.webkit.org/show_bug.cgi?id=50184

        This patch makes TreeShared::m_parent act as either parentNode() or
        shadowHost() for Node. The distinction is controlled by IsShadowRootFlag.

        Refactoring, so no new tests. See performance result testing in bug.

        * dom/Element.cpp:
        (WebCore::Element::recalcStyle): Changed to use parentOrHostNode().
        * dom/Node.cpp:
        (WebCore::Node::shadowHost): Added.
        (WebCore::Node::setShadowHost): Added.
        (WebCore::Node::isContentEditable): Changed to use parentOrHostNode().
        (WebCore::Node::isContentRichlyEditable): Ditto.
        (WebCore::Node::nextRenderer): Ditto.
        (WebCore::Node::virtualComputedStyle): Ditto.
        (WebCore::Node::canStartSelection): Ditto.
        (WebCore::Node::shadowTreeRootNode): Changed to use parentNodeGuaranteedHostFree().
        (WebCore::Node::getEventAncestors): Ditto.
        (WebCore::Node::defaultEventHandler): Changed to use parentOrHostNode().
        * dom/Node.h: Added an extra flag and adjusted bit counts.
        (WebCore::Node::isShadowNode): Made non-virtual, switched to use flag.
        (WebCore::Node::parentNode): Made to recognize flag.
        (WebCore::Node::parentOrHostNode): Changed to use straight parent() and made const.
        (WebCore::Node::parentNodeGuaranteedHostFree): Added.
        (WebCore::Node::shadowParentNode): Made non-virtual and const.
        * editing/TextIterator.cpp:
        (WebCore::depthCrossingShadowBoundaries): Changed to use parentOrHostNode();
        (WebCore::nextInPreOrderCrossingShadowBoundaries): Ditto.
        (WebCore::previousInPostOrderCrossingShadowBoundaries):  Ditto.
        (WebCore::setUpFullyClippedStack): Ditto.
        (WebCore::TextIterator::advance): Ditto.
        (WebCore::SimplifiedBackwardsTextIterator::advance): Ditto.
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::anchorNode): Changed to use parentNodeGuaranteedHostFree().
        (WebCore::DOMSelection::focusNode): Ditto.
        (WebCore::DOMSelection::baseNode): Ditto.
        (WebCore::DOMSelection::extentNode): Ditto.
        (WebCore::DOMSelection::getRangeAt): Ditto.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlShadowRootElement::MediaControlShadowRootElement):
            Changed to setShadowHost().
        (WebCore::MediaControlShadowRootElement::updateStyle): Changed to use shadowHost().
        (WebCore::MediaControlShadowRootElement::detach): Added an override to
            explicitly set shadowHost to 0. Otherwise, the element will leak.
        * rendering/MediaControlElements.h: Added detach def, removed members that are
            no longer needed.
        * rendering/RenderSVGShadowTreeRootContainer.cpp:
        (WebCore::RenderSVGShadowTreeRootContainer::~RenderSVGShadowTreeRootContainer):
            Added explicit clearing of shadowHost to avoid leaking and crashes,
            because SVG shadow DOM can be dynamically attached/detached, producing
            stale nodes in over/out event handling.
        * rendering/RenderSlider.cpp:
        (WebCore::SliderThumbElement::defaultEventHandler): Changed to use shadowHost().
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
            Added explicit clearing of shadowHost and explicit destruction to
            avoid out-of-order removal of children.
        * rendering/RenderTreeAsText.cpp:
        (WebCore::nodePosition): Simplified code.
        * rendering/SVGShadowTreeElements.cpp:
        (WebCore::SVGShadowTreeRootElement::SVGShadowTreeRootElement): Added
            setting of shadowHost.
        (WebCore::SVGShadowTreeRootElement::attachElement): Changed to use shadowHost().
        (WebCore::SVGShadowTreeRootElement::clearShadowHost): Added.
        * rendering/SVGShadowTreeElements.h: Added def, removed members that are
             no longer needed.
        * rendering/ShadowElement.cpp:
        (WebCore::ShadowBlockElement::initAsPart): Changed to use shadowHost().
        * rendering/ShadowElement.h: Removed members that are no longer needed.
        (WebCore::ShadowElement::ShadowElement): Added setting of shadowHost.
        (WebCore::ShadowElement::detach): Added.
        * rendering/TextControlInnerElements.cpp:
        (WebCore::TextControlInnerElement::TextControlInnerElement): Added setting
            of shadowHost.
        (WebCore::TextControlInnerElement::attachInnerElement): Changed to use
            isShadowNode().
        (WebCore::TextControlInnerElement::detach): Added.
        * rendering/TextControlInnerElements.h: Removed members that are no
            longer needed.
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::ownerSVGElement): Simplified code.
        (WebCore::SVGElement::viewportElement): Ditto.
        * svg/SVGLocatable.cpp:
        (WebCore::SVGLocatable::computeCTM): Ditto.
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::title): Ditto.
        * svg/SVGUseElement.cpp:
        (WebCore::ShadowTreeUpdateBlocker::while): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 9 Dec 2010 17:18:29 +0000 (17:18 +0000)]
2010-12-09  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        Changed setting of backtrack labels to not overwrite a prior
        label.  Where losing prior labe which then reverted back to
        next character label.
        https://bugs.webkit.org/show_bug.cgi?id=50579

        * yarr/RegexJIT.cpp:
        (JSC::Yarr::RegexGenerator::BacktrackDestination::setBacktrackToLabel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Thu, 9 Dec 2010 17:18:13 +0000 (17:18 +0000)]
2010-12-09  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Update layout tests to use floating-point values for keys.

        * storage/indexeddb/keyrange-expected.txt:
        * storage/indexeddb/keyrange.html:
        Make sure creating the keys works.
        * storage/indexeddb/objectstore-cursor-expected.txt:
        * storage/indexeddb/objectstore-cursor.html:
        Make sure retrieving the keys from the DB objectstore works.
2010-12-09  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Use floating point to represent numeric keys,
        add version meta data to the SQLite db,
        and migrate object stores that use integers.

        * bindings/v8/IDBBindingUtilities.cpp:
        (WebCore::createIDBKeyFromValue):
        * bindings/v8/custom/V8IDBKeyCustom.cpp:
        (WebCore::toV8):
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::createTables):
        (WebCore::migrateDatabase):
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBKey.cpp:
        (WebCore::IDBKey::IDBKey):
        (WebCore::IDBKey::fromQuery):
        (WebCore::IDBKey::bind):
        (WebCore::IDBKey::bindWithNulls):
        * storage/IDBKey.h:
        (WebCore::IDBKey::create):
        (WebCore::IDBKey::number):
2010-12-09  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        IndexedDB: Numeric keys are floats.
        https://bugs.webkit.org/show_bug.cgi?id=50674

        Represent numeric keys as floating point values.

        * public/WebIDBKey.h:
        (WebKit::WebIDBKey::WebIDBKey):
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::assign):
        (WebKit::WebIDBKey::number):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-28 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 9 Dec 2010 17:14:47 +0000 (17:14 +0000)]
2010-06-28  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        Bug 41238 - RegExp performance slow on Dromaeo benchmark

        Other javascript engines appear to cache prior results of regular
        expression operations.

        Suggest adding some sort of caching mechanism to regular expression
        processing.

        Added a single entry cache of match() results to RegExp class.

        Also added performance improvements to UString == operator.
        First check the impls for equality.  Then get the length of
        each of the non-null impls.  Next check the sizes for equality.
        Then check the data for the case of different impls that point
        to the same data (most likely due to substrings from the beginning of
        another string).  Lastly we check the underlying data for equality.

        Refactored Vector<>::operator=() method into a separate copy() method
        that it calls.  The copy() method is explicitly used for deep copying.

        * runtime/RegExp.cpp:
        (JSC::RegExp::RegExp):
        (JSC::RegExp::match):
        * runtime/RegExp.h:
        * runtime/UString.h:
        (JSC::operator==):
        * wtf/Vector.h:
        (WTF::::operator):
        (WTF::::copy):

2010-12-09  Michael Saboff  <msaboff@apple.com>

        Reviewed by Darin Adler.

        Added test to verify proper operation of backtrack labels.
        https://bugs.webkit.org/show_bug.cgi?id=50579

        * fast/regex/parentheses-expected.txt:
        * fast/regex/script-tests/parentheses.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
beidson@apple.com [Thu, 9 Dec 2010 16:55:19 +0000 (16:55 +0000)]
<rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
WebKit2 Authentication Support

Reviewed by Maciej Stachowiak.

WebCore:

* WebCore.exp.in:

WebKit2:

Implement authentication-related coders:
* Shared/WebCoreArgumentCoders.h:

Allow the ResourceResponse coders to handle null responses:
* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::encodeResourceResponse):
(CoreIPC::decodeResourceResponse):

Add new API and Impl casts for ProtectionSpace and Credential enums:
* UIProcess/API/C/WKAPICast.h:
(WebKit::toAPI):
(WebKit::toCredentialPersistence):

Move the DecisionListener to be accessed off the challenge itself, and fill in other
necessary API:
* UIProcess/API/C/WKAuthenticationChallenge.cpp:
(WKAuthenticationChallengeGetDecisionListener):
(WKAuthenticationChallengeGetProtectionSpace):
(WKAuthenticationChallengeGetProposedCredential):
(WKAuthenticationChallengeGetPreviousFailureCount):
* UIProcess/API/C/WKAuthenticationChallenge.h:
* UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::~AuthenticationChallengeProxy):
(WebKit::AuthenticationChallengeProxy::proposedCredential):
(WebKit::AuthenticationChallengeProxy::protectionSpace):
* UIProcess/Authentication/AuthenticationChallengeProxy.h:
(WebKit::AuthenticationChallengeProxy::previousFailureCount):

Fill in some credential API:
* UIProcess/API/C/WKCredential.cpp:
(WKCredentialCreate):
(WKCredentialCopyUser):
* UIProcess/API/C/WKCredential.h:
* UIProcess/API/C/WKCredentialTypes.h: Added.
* UIProcess/Authentication/WebCredential.cpp:
(WebKit::WebCredential::WebCredential):
(WebKit::WebCredential::user):
* UIProcess/Authentication/WebCredential.h:
(WebKit::WebCredential::create):

Fill in some protection space API:
* UIProcess/API/C/WKProtectionSpace.cpp:
(WKProtectionSpaceCopyHost):
(WKProtectionSpaceGetPort):
(WKProtectionSpaceCopyRealm):
(WKProtectionSpaceGetIsProxy):
(WKProtectionSpaceGetServerType):
(WKProtectionSpaceGetReceivesCredentialSecurely):
(WKProtectionSpaceGetAuthenticationScheme):
* UIProcess/API/C/WKProtectionSpace.h:
* UIProcess/API/C/WKProtectionSpaceTypes.h: Added.
* UIProcess/Authentication/WebProtectionSpace.cpp:
(WebKit::WebProtectionSpace::WebProtectionSpace):
(WebKit::WebProtectionSpace::host):
(WebKit::WebProtectionSpace::port):
(WebKit::WebProtectionSpace::realm):
(WebKit::WebProtectionSpace::isProxy):
(WebKit::WebProtectionSpace::serverType):
(WebKit::WebProtectionSpace::receivesCredentialSecurely):
(WebKit::WebProtectionSpace::authenticationScheme):
* UIProcess/Authentication/WebProtectionSpace.h:

Change the authentication challenge callback to reflect the new ownership of
the DecisionListener:
* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didReceiveAuthenticationChallengeInFrame):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveAuthenticationChallenge):

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Peter Beverloo <peter@lvp-media.com>
commit-queue@webkit.org [Thu, 9 Dec 2010 16:40:53 +0000 (16:40 +0000)]
2010-12-09  Peter Beverloo  <peter@lvp-media.com>

        Reviewed by Maciej Stachowiak.

        Default CSS definitions for the figure and figcaption elements.

        * fast/html/figcaption-element-expected.txt: Added.
        * fast/html/figcaption-element.html: Added.
        * fast/html/figure-element-expected.txt: Added.
        * fast/html/figure-element.html: Added.
        * fast/html/script-tests/figcaption-element.js: Added.
        * fast/html/script-tests/figure-element.js: Added.
2010-12-09  Peter Beverloo  <peter@lvp-media.com>

        Reviewed by Maciej Stachowiak.

        Default CSS definitions for the figure and figcaption elements.

        Tests: fast/html/figcaption-element.html
               fast/html/figure-element.html

        * css/html.css:
        (figure): The default figure-style equals a blockquote
        (figcaption): A non-sectioning block-level element

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Thu, 9 Dec 2010 16:22:26 +0000 (16:22 +0000)]
2010-12-09  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Antonio Gomes.

        Spatial Navigation: more tests.
        https://bugs.webkit.org/show_bug.cgi?id=50728

        * fast/spatial-navigation/snav-hidden-focusable-element-expected.txt: Added.
        * fast/spatial-navigation/snav-hidden-focusable-element.html: Added.
        * fast/spatial-navigation/snav-hidden-iframe-expected.txt: Added.
        * fast/spatial-navigation/snav-hidden-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Koan-Sin Tan <koansin.tan@gmail.com>
andreas.kling@nokia.com [Thu, 9 Dec 2010 16:06:27 +0000 (16:06 +0000)]
2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>

        Reviewed by Tor Arne Vestbø

        [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
        https://bugs.webkit.org/show_bug.cgi?id=50742

        check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Alex Bredariol Grilo <abgrilo@profusion.mobi>
commit-queue@webkit.org [Thu, 9 Dec 2010 16:06:23 +0000 (16:06 +0000)]
2010-12-09  Alex Bredariol Grilo  <abgrilo@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Fix scroll operation in WebKit-EFL
        https://bugs.webkit.org/show_bug.cgi?id=50752

        Add the _ewk_view_scroll_add call in WebKit-EFL scroll function. This
        call was wrongly removed in previous commit and performs the scroll
        operation on the page.

        * ewk/ewk_view.cpp:
        (ewk_view_scroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Thu, 9 Dec 2010 16:00:17 +0000 (16:00 +0000)]
Unreviewed.

Add Qt specific expected results for tests introduced in r73548.
Compared to Mac png files and Mac expected files.

* platform/qt/editing/selection/caret-ltr-2-expected.checksum: Added.
* platform/qt/editing/selection/caret-ltr-2-expected.png: Added.
* platform/qt/editing/selection/caret-ltr-2-expected.txt: Added.
* platform/qt/editing/selection/caret-ltr-2-left-expected.checksum: Added.
* platform/qt/editing/selection/caret-ltr-2-left-expected.png: Added.
* platform/qt/editing/selection/caret-ltr-2-left-expected.txt: Added.
* platform/qt/editing/selection/caret-ltr-expected.checksum: Added.
* platform/qt/editing/selection/caret-ltr-expected.png: Added.
* platform/qt/editing/selection/caret-ltr-expected.txt: Added.
* platform/qt/editing/selection/caret-ltr-right-expected.checksum: Added.
* platform/qt/editing/selection/caret-ltr-right-expected.png: Added.
* platform/qt/editing/selection/caret-ltr-right-expected.txt: Added.
* platform/qt/editing/selection/caret-rtl-2-left-expected.checksum: Added.
* platform/qt/editing/selection/caret-rtl-2-left-expected.png: Added.
* platform/qt/editing/selection/caret-rtl-2-left-expected.txt: Added.
* platform/qt/editing/selection/caret-rtl-right-expected.checksum: Added.
* platform/qt/editing/selection/caret-rtl-right-expected.png: Added.
* platform/qt/editing/selection/caret-rtl-right-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Joone Hur <joone@kldp.org>
commit-queue@webkit.org [Thu, 9 Dec 2010 14:56:33 +0000 (14:56 +0000)]
2010-12-09  Joone Hur  <joone@kldp.org>

        Reviewed by Martin Robinson.

        [GTK] Support for viewport meta tag
        https://bugs.webkit.org/show_bug.cgi?id=45443

        Included viewport test cases for WebKitGtk

        * platform/gtk/Skipped: Unskip fast/viewport except viewport-45.html.
2010-12-09  Joone Hur  <joone@kldp.org>

        Reviewed by Martin Robinson.

        [GTK] Support for viewport meta tag
        https://bugs.webkit.org/show_bug.cgi?id=45443

        This patch adds a new gobject to offer the viewport properties to user agents.
        It is WebKitViewportAttributes that contains the viewport size, initial scale with limits,
        and information about whether a user is able to scale the contents in the viewport.

        This feature was introduced by Safari on the iPhone. For more information on
        the viewport properties, refer to the Safari reference library at
        http://developer.apple.com/safari/library/documentation/appleapplications/reference/safarihtmlref/articles/metatags.html

        * GNUmakefile.am: Added webkitviewportattributes.h webkitviewportattributes.cpp.
        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::dispatchViewportDataDidChange): Added this callback to know whether the viewport arguments is available.
        * WebCoreSupport/ChromeClientGtk.h:
        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::dumpConfigurationForViewport): Added this function to compute the viewport attributes with the given availableWidth and availableHeight.
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::postCommitFrameViewSetup): Invalidate the viewport attributes.
        * webkit/webkit.h:
        * webkit/webkitdefines.h:
        * webkit/webkitprivate.h: Added webkitViewportAttributesRecompute as a private function.
        * webkit/webkitviewportattributes.cpp: Added.
        (webkit_viewport_attributes_class_init):
        (webkit_viewport_attributes_init):
        (webkit_viewport_attributes_get_property):
        (webkit_viewport_attributes_set_property):
        (webkitViewportAttributesRecompute): Recompute the optimal viewport attributes and emit the viewport-attributes-changed signal.
        (webkit_viewport_attributes_recompute): a public API for calling webkitViewportAttributesRecompute.
        * webkit/webkitviewportattributes.h: Added.
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_property): Added PROP_VIEWPORT_ATTRIBUTES.
        (webkit_web_view_dispose): Deallocate the WebKitViewportAttributes instance.
        (webkit_web_view_class_init): Added the viewport-attributes-recompute-requested and viewport-attributes-changed signals.
        (webkit_web_view_init): Set the WebKitViewportAttributes instance.
        (webkit_web_view_get_viewport_attributes): Added a getter to obtain the WebKitViewportAttributes instance held by the given WebKitWebView.
        * webkit/webkitwebview.h:
        * webkit/webkitwebviewprivate.h: Added WebKitViewportAttributes as a private variable.
2010-12-09  Joone Hur  <joone@kldp.org>

         Reviewed by Martin Robinson.

         [GTK] Support for viewport meta tag
         https://bugs.webkit.org/show_bug.cgi?id=45443

         Add support for testing the viewport properties for WebKitGtk.

         * DumpRenderTree/LayoutTestController.cpp:
         (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
         (LayoutTestController::staticFunctions):
         * DumpRenderTree/LayoutTestController.h:
         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
         (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
         (LayoutTestController::dumpConfigurationForViewport): Ditto.
         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
         (LayoutTestController::dumpConfigurationForViewport): Ditto.
         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
         (LayoutTestController::dumpConfigurationForViewport): Ditto.
         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
         (LayoutTestController::dumpConfigurationForViewport): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 9 Dec 2010 13:34:22 +0000 (13:34 +0000)]
2010-12-09  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Console records for failed XHRs should contain call stack and request method
        https://bugs.webkit.org/show_bug.cgi?id=50390

        The expectations needed update ue to log format changes.

        * http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt:
        * http/tests/inspector/console-resource-errors-expected.txt:
        * http/tests/inspector/console-xhr-logging-expected.txt:
        * platform/chromium/http/tests/inspector/console-resource-errors-expected.txt: Added.
        * platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt: Copied from LayoutTests/http/tests/inspector/console-xhr-logging-expected.txt.
2010-12-09  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Console records for failed XHRs should contain call stack and request method
        https://bugs.webkit.org/show_bug.cgi?id=50390

        When inspector front-end is open we capture call stack at the place where request is sent and
        pass the stack along with other request data. There is a new type of console messages which
        is NetworkErrorMessageType, all messages of that type will have requestId field initialized
        with the corresponding network request identifier so that later on when we need to display
        that message in the front-end we could pull request data from the Network panel using
        this identifier. If there are no data for given requestId message formatting falls back to
        the old implementation which lacks such things as call stack, request method and exact
        source location.

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::ConsoleMessage::addToFrontend):
        (WebCore::ConsoleMessage::isEqual):
        * inspector/ConsoleMessage.h:
        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didReceiveResponse):
        (WebCore::InspectorController::didFailLoading):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::identifierForInitialRequest):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.updateMessageRepeatCount):
        (WebInspector.ConsoleMessage):
        (WebInspector.ConsoleMessage.prototype._formatMessage):
        (WebInspector.ConsoleMessage.prototype.toMessageElement):
        (WebInspector.ConsoleMessage.prototype.toString):
        (WebInspector.ConsoleMessage.prototype.isEqual):
        * inspector/front-end/ResourceManager.js:
        (WebInspector.ResourceManager.prototype.identifierForInitialRequest):
        * inspector/front-end/inspector.js:
        (WebInspector.addConsoleMessage):
        * page/Console.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Dai Mikurube <dmikurube@google.com>
commit-queue@webkit.org [Thu, 9 Dec 2010 13:07:15 +0000 (13:07 +0000)]
2010-12-09  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Implement "required" attribute for select tags
        https://bugs.webkit.org/show_bug.cgi?id=50380

        Added tests for require attributes, valueMissing and vadility check for select elements.

        * fast/forms/ValidityState-valueMissing-001-expected.txt:
        * fast/forms/ValidityState-valueMissing-001.html:
        * fast/forms/ValidityState-valueMissing-002-expected.txt:
        * fast/forms/ValidityState-valueMissing-002.html:
        * fast/forms/ValidityState-valueMissing-003-expected.txt:
        * fast/forms/ValidityState-valueMissing-003.html:
        * fast/forms/checkValidity-002-expected.txt:
        * fast/forms/checkValidity-002.html:
        * fast/forms/required-attribute-001-expected.txt:
        * fast/forms/required-attribute-001.html:
        * fast/forms/required-attribute-002-expected.txt:
        * fast/forms/required-attribute-002.html:
        * fast/forms/resources/select-live-pseudo-selectors.js: Added.
        (makeInvalid):
        (appendOption):
        (backgroundOf):
        * fast/forms/script-tests/validationMessage.js:
        * fast/forms/select-live-pseudo-selectors-expected.txt: Added.
        * fast/forms/select-live-pseudo-selectors.html: Added.
        * fast/forms/validationMessage-expected.txt:
        * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html: Added.
        * platform/mac/fast/objc/dom-html-select-live-pseudo-selectors-expected.txt: Added.
2010-12-09  Dai Mikurube  <dmikurube@google.com>

        Reviewed by Kent Tamura.

        Implement "required" attribute for select tags
        https://bugs.webkit.org/show_bug.cgi?id=50380

        Test: fast/forms/select-live-pseudo-selectors.html
              platform/mac/fast/objc/dom-html-select-live-pseudo-selectors.html

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::updateValidity): Added. It's a pure virtual function which is prepared so that HTMLSelectElement::updateValidity() calls HTMLSelectElement::setNeedsValidityCheck().
        (WebCore::SelectElement::parseMultipleAttribute): Added calling updateValidity().
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::deselectItems): Added calling setNeedsValidityCheck() to enable validity check after changing. No tests for this change since this function is not exposed to JavaScript or any web interface.
        (WebCore::HTMLSelectElement::setSelectedIndex): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::setSelectedIndexByUser): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::valueMissing): Added valueMissing() to check if selecting an invalid or placeholder label option when a valid required attribute is specified.
        (WebCore::HTMLSelectElement::listBoxSelectItem): Added calling setNeedsValidityCheck(). No tests for this change since it is not called yet. Look at the bug 36177 and the changeset 56180.
        (WebCore::HTMLSelectElement::add): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::remove): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::restoreFormControlState): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::parseMappedAttribute): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::selectAll): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::reset): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::updateListBoxSelection): Added calling setNeedsValidityCheck(). Skipped adding tests for this change as too complicated..
        (WebCore::HTMLSelectElement::setLength): Added calling setNeedsValidityCheck().
        (WebCore::HTMLSelectElement::isRequiredFormControl): Check if required or not.
        (WebCore::HTMLSelectElement::hasPlaceholderLabelOption): Added.
        (WebCore::HTMLSelectElement::updateValidity): Added. It calls setNeedsValidityCheck().
        * html/HTMLSelectElement.h:
        (WebCore::HTMLSelectElement::isOptionalFormControl): Check if not required.
        * html/HTMLSelectElement.idl: Added a required attribute to select elements..
        * html/ValidityState.cpp:
        (WebCore::ValidityState::valueMissing): Added valueMissing check for select elements into the global checker, ValidityState::valueMissing().
        * wml/WMLSelectElement.h:
        (WebCore::WMLSelectElement::updateValidity): Added. It does nothing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-07 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 9 Dec 2010 12:29:55 +0000 (12:29 +0000)]
2010-12-07  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        IndexedDB returns the wrong exceptions
        https://bugs.webkit.org/show_bug.cgi?id=50632

        * storage/indexeddb/constants-expected.txt:
        * storage/indexeddb/constants.html:
        * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
        * storage/indexeddb/objectstore-removeobjectstore.html:
2010-12-07  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        IndexedDB returns the wrong exceptions
        https://bugs.webkit.org/show_bug.cgi?id=50632

        IndexedDB exceptions need to have an offset so they can
        be distinguished from DOM exceptions.  We also need to
        add strings for the various exceptions.  Lastly, make
        IDBDatabaseException use the common exception base class.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::setDOMException):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::setDOMException):
        * dom/ExceptionCode.cpp:
        (WebCore::getExceptionCodeDescription):
        * dom/ExceptionCode.h:
        * storage/IDBDatabaseError.h:
        (WebCore::IDBDatabaseError::code):
        * storage/IDBDatabaseException.h:
        (WebCore::IDBDatabaseException::create):
        (WebCore::IDBDatabaseException::ErrorCodeToExceptionCode):
        (WebCore::IDBDatabaseException::IDBDatabaseException):
        * storage/IDBDatabaseException.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 9 Dec 2010 12:09:59 +0000 (12:09 +0000)]
2010-12-09  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Fix 'make install' woes with some versions of automake.

        * GNUmakefile.am: use $(top_builddir) instead of $(builddir),
        since we actually want a valid path for the file regardless of the
        place from where the script is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Thu, 9 Dec 2010 11:18:48 +0000 (11:18 +0000)]
2010-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Build fix for GTK+3. Use functions added for GTK+ 2.24 to get the
        GDK window size.

        * plugins/gtk/gtk2xtbin.c:
        (gtk_xtbin_realize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Thu, 9 Dec 2010 11:12:48 +0000 (11:12 +0000)]
2010-12-09  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        Use BUILDING_WEBKIT like other ports
        https://bugs.webkit.org/show_bug.cgi?id=50713

        * WebCore.pro: Change BUILD_WEBKIT to BUILDING_WEBKIT
2010-12-09  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        Use BUILDING_WEBKIT like other ports
        https://bugs.webkit.org/show_bug.cgi?id=50713

        * Api/qwebkitglobal.h: change BUILD_WEBKIT to BUILDING_WEBKIT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 9 Dec 2010 11:12:33 +0000 (11:12 +0000)]
2010-12-09  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Rebaselined Chromium expectations.
        Reverts r73518 and r73522.

        * platform/chromium-linux/fast/forms/placeholder-position-expected.checksum: Added.
        * platform/chromium-linux/fast/forms/placeholder-position-expected.png: Added.
        * platform/chromium-mac/fast/forms/placeholder-position-expected.checksum: Added.
        * platform/chromium-mac/fast/forms/placeholder-position-expected.png: Added.
        * platform/chromium-win/fast/forms/placeholder-position-expected.checksum: Added.
        * platform/chromium-win/fast/forms/placeholder-position-expected.png: Added.
        * platform/chromium-win/fast/forms/placeholder-position-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 9 Dec 2010 11:07:56 +0000 (11:07 +0000)]
2010-12-09  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] configure: error out if video is enabled and gstreamer pkg-config check fails
        https://bugs.webkit.org/show_bug.cgi?id=50741

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Add Qt specific expected results for tests introduced in r73529.
ossy@webkit.org [Thu, 9 Dec 2010 10:41:42 +0000 (10:41 +0000)]
Unreviewed. Add Qt specific expected results for tests introduced in r73529.

* platform/qt/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
* platform/qt/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 9 Dec 2010 10:03:08 +0000 (10:03 +0000)]
2010-12-09  Martin Robinson  <mrobinson@igalia.com>

        Update GTK+ baselines after r73561.

        * platform/gtk/fast/css/input-search-padding-expected.txt:
        * platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
        * platform/gtk/fast/forms/box-shadow-override-expected.txt:
        * platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
        * platform/gtk/fast/forms/input-appearance-height-expected.txt:
        * platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
        * platform/gtk/fast/forms/placeholder-set-value-expected.txt:
        * platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
        * platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
        * platform/gtk/fast/forms/search-rtl-expected.txt:
        * platform/gtk/fast/forms/search-styled-expected.txt:
        * platform/gtk/fast/forms/search-transformed-expected.txt:
        * platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
        * platform/gtk/fast/forms/search-zoomed-expected.txt:
        * platform/gtk/fast/forms/searchfield-heights-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 9 Dec 2010 09:37:14 +0000 (09:37 +0000)]
2010-12-09  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, update test baselines as asked by MORITA Hajime.

        [GTK] r73488 broke fast/dom/HTMLProgressElement/progress-element.html
        https://bugs.webkit.org/show_bug.cgi?id=50687

        * platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-09 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Thu, 9 Dec 2010 08:09:45 +0000 (08:09 +0000)]
2010-12-09  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed.

        Chromium rebaselines for r73488.

        * platform/chromium-mac/fast/dom/HTMLProgressElement/progress-element-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
        * platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
        * platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 9 Dec 2010 06:43:36 +0000 (06:43 +0000)]
2010-12-08  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Updated Chromium expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPermit Character Class Escape in CharacterRange in Character Class.
barraclough@apple.com [Thu, 9 Dec 2010 05:40:29 +0000 (05:40 +0000)]
Permit Character Class Escape in CharacterRange in Character Class.
https://bugs.webkit.org/show_bug.cgi?id=50483
https://bugs.webkit.org/show_bug.cgi?id=50538
https://bugs.webkit.org/show_bug.cgi?id=50654
https://bugs.webkit.org/show_bug.cgi?id=50646

Reviewed by Sam Weinig.

We recently tightened up our spec conformance in generating syntax
error in these cases, however testing in the wild has shown this
to be problematic. This reverts the previous change in allowing
class escapes (e.g. \d) in ranges in character classes ([]), but
does retain some closer conformance to the spec in only allowing
ranges that would be permitted per the grammar rules in the spec
(e.g. in /[\d-a-z]/ "a-z" cannot be considered as a range).

JavaScriptCore:

* yarr/RegexParser.h:
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomPatternCharacter):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomBuiltInCharacterClass):
(JSC::Yarr::Parser::parse):

LayoutTests:

* fast/js/regexp-ranges-and-escaped-hyphens-expected.txt:
* fast/js/script-tests/regexp-ranges-and-escaped-hyphens.js:
* fast/regex/invalid-range-in-class-expected.txt:
* fast/regex/pcre-test-1-expected.txt:
* fast/regex/script-tests/invalid-range-in-class.js:
* fast/regex/script-tests/pcre-test-1.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Thu, 9 Dec 2010 05:03:01 +0000 (05:03 +0000)]
2010-12-08  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed.

        Update Chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix crash-on-launch seen on Windows builder.
ggaren@apple.com [Thu, 9 Dec 2010 04:32:59 +0000 (04:32 +0000)]
Try to fix crash-on-launch seen on Windows builder.

Reviewed by Sam Weinig.

* wtf/OSAllocatorWin.cpp:
(WTF::OSAllocator::release): Disabled an ASSERT, because it checks for
a bug that hasn't been fixed yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix typo: Diplaying -> Displaying
weinig@apple.com [Thu, 9 Dec 2010 04:30:29 +0000 (04:30 +0000)]
Fix typo: Diplaying -> Displaying

Reviewed by Geoffrey "Error" Garen.

* UIProcess/API/C/WKFrame.cpp:
(WKFrameIsDisplayingStandaloneImageDocument):
(WKFrameIsDisplayingMarkupDocument):
* UIProcess/API/C/WKFrame.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canProvideSource):
(WebKit::WebFrameProxy::isDisplayingStandaloneImageDocument):
(WebKit::WebFrameProxy::isDisplayingMarkupDocument):
* UIProcess/WebFrameProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 William Siegrist <wsiegrist@apple.com>
wsiegrist@apple.com [Thu, 9 Dec 2010 04:22:21 +0000 (04:22 +0000)]
2010-12-08  William Siegrist <wsiegrist@apple.com>

        Reviewed by Eric Seidel.

        Migrate buildbot.py from xmlrpc to json.
        https://bugs.webkit.org/show_bug.cgi?id=50647

        * Scripts/webkitpy/common/net/buildbot.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Erik Arvidsson <arv@chromium.org>
arv@chromium.org [Thu, 9 Dec 2010 03:55:39 +0000 (03:55 +0000)]
2010-12-08  Erik Arvidsson  <arv@chromium.org>

        Reviewed by Darin Adler.

        Replace getAttribute().isNull() with fastHasAttribute()
        https://bugs.webkit.org/show_bug.cgi?id=50719

        Covered by existing tests.

        * dom/SelectElement.cpp:
        (WebCore::SelectElement::reset):
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::rendererIsNeeded):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::itemAfter):
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::formNoValidate):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::noValidate):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::defaultChecked):
        (WebCore::HTMLInputElement::multiple):
        (WebCore::HTMLInputElement::webkitdirectory):
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::defaultSelected):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::asyncAttributeValue):
        (WebCore::HTMLScriptElement::deferAttributeValue):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::allowsMultipleFiles):
        (WebCore::RenderFileUploadControl::allowsDirectoryUpload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 9 Dec 2010 03:37:39 +0000 (03:37 +0000)]
2010-12-08  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Yet another Chromium rebaselines for r73548.

        * platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Removed.
        * platform/chromium-mac-leopard/editing/selection/caret-rtl-2-expected.png: Removed.
        * platform/chromium-mac/fast/text/international/khmer-selection-expected.checksum: Added.
        * platform/chromium-mac/fast/text/international/khmer-selection-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
commit-queue@webkit.org [Thu, 9 Dec 2010 03:33:39 +0000 (03:33 +0000)]
2010-12-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>

        Reviewed by Martin Robinson.

        Full page size flash plugins do not show in all situations
        https://bugs.webkit.org/show_bug.cgi?id=47742

        This patch moves the plugin widget size allocation after the
        NPP_SetWindow is called with the effect that the resize of Flash
        content no longer result in grey flash. This seems logical since the
        widget tree cannot be fully constructed before the plugin receives
        the new container window.

        Test: manual-tests/plugins/gtk-windowed-grey-glitch.html

        * plugins/gtk/PluginViewGtk.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix regression from xji's wheel scroll patch. The vertical case is looking at the...
hyatt@apple.com [Thu, 9 Dec 2010 03:29:45 +0000 (03:29 +0000)]
Fix regression from xji's wheel scroll patch.  The vertical case is looking at the horizontal
maximum position and not the vertical position.

Reviewed by Simon Fraser.

* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Andy Estes <aestes@apple.com>
aestes@apple.com [Thu, 9 Dec 2010 03:13:08 +0000 (03:13 +0000)]
2010-12-08  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        Enable pre-HTML5 parser quirks for Apple Mail.app
        https://bugs.webkit.org/show_bug.cgi?id=50727

        * WebView/WebView.mm:
        (-[WebView _needsPreHTML5ParserQuirks]): Return true if the embedding
        application is Mail.app.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Qi Zhang <qi.2.zhang@nokia.com>
commit-queue@webkit.org [Thu, 9 Dec 2010 03:10:51 +0000 (03:10 +0000)]
2010-12-08  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Support OrientationChange event
        https://bugs.webkit.org/show_bug.cgi?id=50685

        Get OrientationChange event from qtmobility then send to webkit.

        * Api/qwebframe.cpp:
        (QWebFrame::orientationChanged):
        (QWebFrame::QWebFrame):
        * Api/qwebframe.h:
        * Api/qwebframe_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed a way to get a WKBundleFrameRef from JS HTMLIFrameElement
weinig@apple.com [Thu, 9 Dec 2010 02:25:19 +0000 (02:25 +0000)]
Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=50726

Reviewed by Darin Adler.

* WebCore.xcodeproj/project.pbxproj: Expose HTMLIFrameElement.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WebKit2 Preference for TabsToLinks behavior.
weinig@apple.com [Thu, 9 Dec 2010 02:20:02 +0000 (02:20 +0000)]
Add WebKit2 Preference for TabsToLinks behavior.
<rdar://problem/8664263>

Reviewed by Gavin Barraclough.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetTabsToLinks):
(WKPreferencesGetTabsToLinks):
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::tabsToLinks):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::tabsToLinks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Thu, 9 Dec 2010 02:15:09 +0000 (02:15 +0000)]
2010-12-08  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        WebTouchEvent::isTouchEventType() does not take into account the type TouchCancel
        https://bugs.webkit.org/show_bug.cgi?id=50680

        Add the missing type check to WebTouchEvent::isTouchEventType().

        * Shared/WebTouchEvent.cpp:
        (WebKit::WebTouchEvent::isTouchEventType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix Windows build.
ggaren@apple.com [Thu, 9 Dec 2010 02:03:00 +0000 (02:03 +0000)]
Try to fix Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed a way to get a WKBundleFrameRef from JS HTMLIFrameElement
weinig@apple.com [Thu, 9 Dec 2010 02:02:13 +0000 (02:02 +0000)]
Need a way to get a WKBundleFrameRef from JS HTMLIFrameElement
https://bugs.webkit.org/show_bug.cgi?id=50726

Reviewed by Darin Adler.

Adds WKBundleNodeHandleCopyDocumentFrame, WKBundleNodeHandleCopyHTMLFrameElementContentFrame
and WKBundleNodeHandleCopyHTMLIFrameElementContentFrame, to handle the document, <frame>
and <iframe> cases.

* WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleCopyDocumentFrame):
(WKBundleNodeHandleCopyHTMLFrameElementContentFrame):
(WKBundleNodeHandleCopyHTMLIFrameElementContentFrame):
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::copyDocumentFrame):
(WebKit::InjectedBundleNodeHandle::copyHTMLFrameElementContentFrame):
(WebKit::InjectedBundleNodeHandle::copyHTMLIFrameElementContentFrame):
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 9 Dec 2010 01:54:49 +0000 (01:54 +0000)]
2010-12-08  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Add getter and setters for acceleratesRendering flag on layers
        https://bugs.webkit.org/show_bug.cgi?id=50717

        * platform/graphics/GraphicsLayer.cpp:
        * platform/graphics/ca/GraphicsLayerCA.cpp:
        * platform/graphics/ca/mac/PlatformCALayerMac.mm:
        Plumbed through acceleratedRendering flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix Windows build.
ggaren@apple.com [Thu, 9 Dec 2010 01:50:40 +0000 (01:50 +0000)]
Try to fix Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def
file to remove a symbol -- the next build failure will say which symbol
to add back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 9 Dec 2010 01:45:22 +0000 (01:45 +0000)]
2010-12-08  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        Update expectations for r73566.

        * platform/gtk/editing/selection/find-yensign-and-backslash-expected.txt:
        * platform/qt/editing/selection/find-yensign-and-backslash-expected.txt: Removed.
        * platform/win/editing/selection/find-yensign-and-backslash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix Windows build.
ggaren@apple.com [Thu, 9 Dec 2010 01:42:24 +0000 (01:42 +0000)]
Try to fix Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Updated .def file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNeed a WebKit2 way to test whether a frame is displaying a standalone image
weinig@apple.com [Thu, 9 Dec 2010 01:41:57 +0000 (01:41 +0000)]
Need a WebKit2 way to test whether a frame is displaying a standalone image
<rdar://problem/8443059>
WebKit2: Need a way to test whether a page or frame is showing HTML content
<rdar://problem/8642563>

Reviewed by Gavin Barraclough.

Add WKFrameIsDiplayingStandaloneImageDocument and WKFrameIsDiplayingMarkupDocument.

* UIProcess/API/C/WKFrame.cpp:
(WKFrameIsDiplayingStandaloneImageDocument):
(WKFrameIsDiplayingMarkupDocument):
* UIProcess/API/C/WKFrame.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canProvideSource): This now just calls isDiplayingMarkupDocument.
(WebKit::WebFrameProxy::isDiplayingStandaloneImageDocument):
(WebKit::WebFrameProxy::isDiplayingMarkupDocument):
* UIProcess/WebFrameProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 9 Dec 2010 01:38:56 +0000 (01:38 +0000)]
2010-12-07  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        WebGLUniformLocation objects must be invalidated during linkProgram
        https://bugs.webkit.org/show_bug.cgi?id=37118

        * html/canvas/WebGLProgram.cpp:
        (WebCore::WebGLProgram::WebGLProgram): Initialize link count to 0.
        (WebCore::WebGLProgram::cacheActiveAttribLocations): Don't check link status through gl call; use the cached status instead.
        * html/canvas/WebGLProgram.h:
        (WebCore::WebGLProgram::getLinkCount): Get link count.
        (WebCore::WebGLProgram::increaseLinkCount): Increase link count by 1.
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getUniform): Fix a bug where wrong error is generated.
        (WebCore::WebGLRenderingContext::linkProgram): call increaseLinkCount after linkProgram.
        * html/canvas/WebGLUniformLocation.cpp:
        (WebCore::WebGLUniformLocation::WebGLUniformLocation): Set program's link count upon creation.
        (WebCore::WebGLUniformLocation::program): Return null if count doesn't match the program's.
        (WebCore::WebGLUniformLocation::location): Return -1 if count doesn't match the program's.
        * html/canvas/WebGLUniformLocation.h:
2010-12-07  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        WebGLUniformLocation objects must be invalidated during linkProgram
        https://bugs.webkit.org/show_bug.cgi?id=37118

        * fast/canvas/webgl/uniform-location-expected.txt:
        * fast/canvas/webgl/uniform-location.html: Check that after linkProgram, all previous uniform locations become invalid.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=50725
adele@apple.com [Thu, 9 Dec 2010 01:36:04 +0000 (01:36 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=50725
<rdar://problem/8694972> REGRESSION (r72052): "Search" placeholder in MobileMe mail is positioned too high

Reviewed by Darin Adler.

Test: fast/forms/placeholder-position.html

Since we center the inner text element for single line text controls,
we should ask the subclass to give us the y offset instead of trying to calculate it in the RenderTextControl class.

* rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder):
* rendering/RenderTextControl.h:
* rendering/RenderTextControlMultiLine.cpp: (WebCore::RenderTextControlMultiLine::textBlockInsetTop):
* rendering/RenderTextControlMultiLine.h:
* rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::textBlockInsetTop):
* rendering/RenderTextControlSingleLine.h:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=50725
<rdar://problem/8694972> REGRESSION (r72052): "Search" placeholder in MobileMe mail is positioned too high

Reviewed by Darin Adler.

* fast/forms/placeholder-position.html: Added.
* platform/mac/fast/forms/placeholder-position-expected.checksum: Added.
* platform/mac/fast/forms/placeholder-position-expected.png: Added.
* platform/mac/fast/forms/placeholder-position-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix GTK Linux build.
ggaren@apple.com [Thu, 9 Dec 2010 01:35:13 +0000 (01:35 +0000)]
Try to fix GTK Linux build.

* jit/ExecutableAllocator.cpp:
(JSC::ExecutablePool::systemAlloc):
* runtime/AlignedMemoryAllocator.h:
(JSC::::AlignedMemoryAllocator): Updated for Usage enum moving to OSAllocator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMigrated OS-specific allocation code from PageReservation and PageAllocation to OSAll...
ggaren@apple.com [Thu, 9 Dec 2010 01:30:18 +0000 (01:30 +0000)]
Migrated OS-specific allocation code from PageReservation and PageAllocation to OSAllocator
https://bugs.webkit.org/show_bug.cgi?id=50653

Reviewed by Sam Weinig.

* JavaScriptCore.exp: Updated for new function signature.

* interpreter/RegisterFile.h:
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator): Removed checkAllocatedOkay.
OSAllocator is now the central location for verifying that allocation succeeds.
This allowed me to remove some complicating cross-platform cruft.

* runtime/AlignedMemoryAllocator.h:
(JSC::::allocate): Updated for code motion.

* wtf/OSAllocator.h: Added Usage, writable, and executable parameters, to
support VM features required by clients of PageAllocation and PageReservation.

* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit): Moved PageAllocation support for randomizing
executable memory here.

* wtf/OSAllocatorSymbian.cpp:
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit): Updated for new function signatures.

* wtf/OSAllocatorWin.cpp:
(WTF::protection):
(WTF::OSAllocator::reserve):
(WTF::OSAllocator::reserveAndCommit):
(WTF::OSAllocator::commit):
(WTF::OSAllocator::release): Updated for new function signatures. Moved
some protection-related and WINCE-related code from PageAllocation here.

* wtf/PageAllocation.cpp: Nixed cross-platform lastError abstraction, since
it was only used by checkAllocatedOkay, which is now gone.

* wtf/PageAllocation.h:
(WTF::PageAllocation::allocate):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::deallocate):
(WTF::PageAllocation::isPowerOfTwo):
(WTF::PageAllocation::systemAllocateAligned): Removed system* functions,
and replaced calls to them with calls to OSAllocator.

* wtf/PageReservation.h:
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::reserve):
(WTF::PageReservation::deallocate):
(WTF::PageReservation::PageReservation): Ditto. Added m_writable and
m_executable because these flags are now required when committing memory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebFrameProxy::canShowMIMEType should return true for PDF MIME types in the main...
andersca@apple.com [Thu, 9 Dec 2010 01:09:03 +0000 (01:09 +0000)]
WebFrameProxy::canShowMIMEType should return true for PDF MIME types in the main frame
https://bugs.webkit.org/show_bug.cgi?id=50724

Reviewed by Darin Adler.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::pdfAndPostScriptMIMETypes):
* UIProcess/WebContext.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canShowMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Chris Rogers <crogers@google.com>
crogers@google.com [Thu, 9 Dec 2010 01:03:51 +0000 (01:03 +0000)]
2010-12-08  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add web audio files to mac port Xcode projects
        https://bugs.webkit.org/show_bug.cgi?id=50721

        * JavaScriptCore.xcodeproj/project.pbxproj:
2010-12-08  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add web audio files to mac port Xcode projects
        https://bugs.webkit.org/show_bug.cgi?id=50721

        No new tests since audio API is not yet implemented.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::webkitAudioContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebMenuTarget implemented in both WebKit and WebKit2
bweinstein@apple.com [Thu, 9 Dec 2010 01:03:06 +0000 (01:03 +0000)]
WebMenuTarget implemented in both WebKit and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50665
<rdar://problem/8742640>

Reviewed by Brady Eidson.

Rename WebMenuTarget to WKMenuTarget to prevent this warning and stay consistent with
other WebKit2 namings.

* UIProcess/mac/WebContextMenuProxyMac.mm:
(+[WKMenuTarget sharedMenuTarget]):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::showContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoYensign hack should work with Shift_JIS and ISO-2022-JP encodings.
tkent@chromium.org [Thu, 9 Dec 2010 00:54:23 +0000 (00:54 +0000)]
Yensign hack should work with Shift_JIS and ISO-2022-JP encodings.
https://bugs.webkit.org/show_bug.cgi?id=49714

Reviewed by Alexey Proskuryakov.

WebCore:

IE chooses a font which shows a yensign for 0x5c code point for a page
encoded in x-mac-japanese, ISO-2022-JP, EUC-JP, Shift_JIS, Shift_JIS_X0213-2000,
x-sjis, and Windows-31J.
We have emulated this behavior by replacing 0x5c with 0xa5 for EUC-JP and
Shift_JIS_X0213-2000. This change adds other encodings above.

Also, we move the HashSet initialization for isJapanese() and
backslashAsCurrencySymbol() to TextEncodingRegistry.cpp because of
ease of making them multi-thread safe.

* platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::isJapanese): Just calls isJapaneseEncoding().
(WebCore::TextEncoding::backslashAsCurrencySymbol): Uses shouldShowBackslashAsCurrencySymbolIn().
* platform/text/TextEncodingRegistry.cpp:
(WebCore::addEncodingName): Moved from TextEncoding.cpp, and stop using atomicCanonicalTextEncodingName().
(WebCore::buildQuirksSets): Added. Initializes HashSets for isJapaneseEncoding() and shouldShowBackslashAsCurrencySymbolIn().
(WebCore::isJapaneseEncoding):
(WebCore::shouldShowBackslashAsCurrencySymbolIn):
(WebCore::extendTextCodecMaps): Add a call to buildQuirksSets().
* platform/text/TextEncodingRegistry.h:

LayoutTests:

Use Shift_JIS instead of Shift_JIS_X0213-2000 because Shift_JIS_X0213-2000
encoding is available only on Mac.
Add a test for ISO-2022-JP.

* editing/selection/find-yensign-and-backslash-expected.txt:
* editing/selection/find-yensign-and-backslash.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove canShowMIMEType to Frame
andersca@apple.com [Thu, 9 Dec 2010 00:47:38 +0000 (00:47 +0000)]
Move canShowMIMEType to Frame
https://bugs.webkit.org/show_bug.cgi?id=50723

Reviewed by Sam Weinig.

* UIProcess/API/C/WKFrame.cpp:
(WKFrameCanShowMIMEType):
* UIProcess/API/C/WKFrame.h:
* UIProcess/API/C/WKPage.cpp:
* UIProcess/API/C/WKPage.h:
* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canShowMIMEType):
* UIProcess/WebFrameProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Andy Estes <aestes@apple.com>
aestes@apple.com [Thu, 9 Dec 2010 00:37:34 +0000 (00:37 +0000)]
2010-12-08  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        Reflected unsigned attributes should be in the range [0, 2^31).
        https://bugs.webkit.org/show_bug.cgi?id=50472

        HTML5 says that unsigned reflected attributes should be in the range
        [0, 2^31). When a value isn't in this range, a default value (or 0)
        should be returned instead. Update the JS bindings code generator to
        ensure 0 is returned when a content attribute value falls outside of
        this range.

        Tests: bindings/scripts/test/TestObj.idl
               fast/html/marquee-element.html

        * bindings/scripts/CodeGeneratorJS.pm: Return the maximum of 0 and the
        content attribute as a 32-bit signed int when converting a native value
        to an unsigned JS value.
        * bindings/scripts/test/TestObj.idl: Add a reflected unsigned attribute
        to test code generation.
        * bindings/scripts/test/CPP/WebDOMTestObj.cpp: Update test results.
        * bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
        * bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
        * bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestObj.h: Ditto.
        * bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
        * bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
        * bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
2010-12-08  Andy Estes  <aestes@apple.com>

        Reviewed by Darin Adler.

        Reflected unsigned attributes should be in the range [0, 2^31).
        https://bugs.webkit.org/show_bug.cgi?id=50472

        * fast/html/marquee-element.html: Give hspace and vspace negative values
        and test what their corresponding IDL attributes reflect.
        * fast/html/marquee-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 9 Dec 2010 00:13:04 +0000 (00:13 +0000)]
2010-12-08  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        make starting the websocket server more reliable on windows
        https://bugs.webkit.org/show_bug.cgi?id=50712

        * Scripts/webkitpy/common/system/filesystem.py:
        (remove): Substitute method for os.remove to retry on error on Windows
        * Scripts/webkitpy/common/system/filesystem_unittest.py:
        * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 8 Dec 2010 23:58:51 +0000 (23:58 +0000)]
2010-12-08  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaseline for r73548.

        * platform/chromium-linux/fast/text/international/khmer-selection-expected.checksum:
        * platform/chromium-linux/fast/text/international/khmer-selection-expected.png:
        * platform/chromium-linux/fast/text/international/khmer-selection-expected.txt:
        * platform/chromium-win-xp/fast/text/international/khmer-selection-expected.checksum: Removed.
        * platform/chromium-win-xp/fast/text/international/khmer-selection-expected.png: Removed.
        * platform/chromium-win-xp/fast/text/international/khmer-selection-expected.txt: Removed.
        * platform/chromium-win/fast/text/international/khmer-selection-expected.checksum:
        * platform/chromium-win/fast/text/international/khmer-selection-expected.png:
        * platform/chromium-win/fast/text/international/khmer-selection-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Carlos Garcia Campos <cgarcia@igalia.com>
commit-queue@webkit.org [Wed, 8 Dec 2010 23:50:25 +0000 (23:50 +0000)]
2010-12-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Use gtk_icon_set_render_icon() to render icons in RenderThemeGtk
        https://bugs.webkit.org/show_bug.cgi?id=50623

        We don't need to cache the icons since the will be cached by GTK+,
        and they will be rendered using the state and text direction.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::paintStockIcon):
        (WebCore::getMediaButtonIconSize):
        (WebCore::RenderThemeGtk::initMediaColors):
        (WebCore::RenderThemeGtk::initMediaButtons):
        (WebCore::RenderThemeGtk::RenderThemeGtk):
        (WebCore::RenderThemeGtk::~RenderThemeGtk):
        (WebCore::RenderThemeGtk::gtkIconState):
        (WebCore::RenderThemeGtk::adjustSearchFieldResultsDecorationStyle):
        (WebCore::centerRectVerticallyInParentInputElement):
        (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration):
        (WebCore::RenderThemeGtk::adjustSearchFieldCancelButtonStyle):
        (WebCore::RenderThemeGtk::paintSearchFieldCancelButton):
        (WebCore::RenderThemeGtk::platformColorsDidChange):
        (WebCore::RenderThemeGtk::paintMediaButton):
        (WebCore::RenderThemeGtk::paintMediaFullscreenButton):
        (WebCore::RenderThemeGtk::paintMediaMuteButton):
        (WebCore::RenderThemeGtk::paintMediaPlayButton):
        (WebCore::RenderThemeGtk::paintMediaSeekBackButton):
        (WebCore::RenderThemeGtk::paintMediaSeekForwardButton):
        * platform/gtk/RenderThemeGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open...
bweinstein@apple.com [Wed, 8 Dec 2010 23:33:49 +0000 (23:33 +0000)]
REGRESSION: r73429-r73490: Some Contextual menu items non-functional, such as Open Link in New Tab
https://bugs.webkit.org/show_bug.cgi?id=50683

Reviewed by John Sullivan.

If our context menu item already has an action, don't overwrite the action with the context menu
forwarder.

* WebView/WebHTMLView.mm:
(setMenuItemTarget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 8 Dec 2010 23:31:04 +0000 (23:31 +0000)]
2010-12-08  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Detach node iterator and move to new document when node gets moved.
        https://bugs.webkit.org/show_bug.cgi?id=50697

        Test: fast/dom/node-iterator-document-moved-crash.html

        * dom/Document.cpp: Method that takes a node and new document as argument.
        It detaches the node iterators belonging to the current document and attaches
        them to the new document.
        (WebCore::Document::moveNodeIteratorsToNewDocument):
        * dom/Document.h: Function definition.
        * dom/Node.cpp: When node is moved to another document, call the function to move
        the iterators appropriately.
        (WebCore::Node::setDocument):
2010-12-08  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dimitri Glazkov.

        Tests that we do not crash when node iterator gets moved across documents.
        https://bugs.webkit.org/show_bug.cgi?id=50697

        * fast/dom/node-iterator-document-moved-crash-expected.txt: Added.
        * fast/dom/node-iterator-document-moved-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 8 Dec 2010 23:27:47 +0000 (23:27 +0000)]
2010-12-08  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaseline for r73548.

        * platform/chromium-linux/editing/selection/caret-ltr-2-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-2-expected.png: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-2-left-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-2-left-expected.png: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-expected.png: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-right-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-ltr-right-expected.png: Added.
        * platform/chromium-linux/editing/selection/caret-rtl-2-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-rtl-2-expected.png: Added.
        * platform/chromium-linux/editing/selection/caret-rtl-2-left-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-rtl-2-left-expected.png: Added.
        * platform/chromium-linux/editing/selection/caret-rtl-expected.checksum:
        * platform/chromium-linux/editing/selection/caret-rtl-expected.png:
        * platform/chromium-linux/editing/selection/caret-rtl-right-expected.checksum: Added.
        * platform/chromium-linux/editing/selection/caret-rtl-right-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-2-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-ltr-right-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-expected.checksum:
        * platform/chromium-mac/editing/selection/caret-rtl-expected.png:
        * platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-ltr-2-expected.checksum: Added.
        * platform/chromium-win/editing/selection/caret-ltr-2-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-ltr-2-expected.txt: Added.
        * platform/chromium-win/editing/selection/caret-ltr-2-left-expected.checksum: Added.
        * platform/chromium-win/editing/selection/caret-ltr-2-left-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-ltr-2-left-expected.txt: Added.
        * platform/chromium-win/editing/selection/caret-ltr-expected.checksum: Added.
        * platform/chromium-win/editing/selection/caret-ltr-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-ltr-expected.txt: Added.
        * platform/chromium-win/editing/selection/caret-ltr-right-expected.checksum: Added.
        * platform/chromium-win/editing/selection/caret-ltr-right-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-ltr-right-expected.txt: Added.
        * platform/chromium-win/editing/selection/caret-rtl-2-expected.checksum:
        * platform/chromium-win/editing/selection/caret-rtl-2-expected.png:
        * platform/chromium-win/editing/selection/caret-rtl-2-expected.txt:
        * platform/chromium-win/editing/selection/caret-rtl-2-left-expected.checksum: Added.
        * platform/chromium-win/editing/selection/caret-rtl-2-left-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-rtl-2-left-expected.txt: Added.
        * platform/chromium-win/editing/selection/caret-rtl-expected.checksum:
        * platform/chromium-win/editing/selection/caret-rtl-expected.png:
        * platform/chromium-win/editing/selection/caret-rtl-expected.txt:
        * platform/chromium-win/editing/selection/caret-rtl-right-expected.checksum: Added.
        * platform/chromium-win/editing/selection/caret-rtl-right-expected.png: Added.
        * platform/chromium-win/editing/selection/caret-rtl-right-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 8 Dec 2010 23:24:24 +0000 (23:24 +0000)]
2010-12-08  Martin Robinson  <mrobinson@igalia.com>

        Replace some GTK+ test results after r73548.

        * platform/gtk/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
        * platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 8 Dec 2010 22:48:01 +0000 (22:48 +0000)]
2010-12-08  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Removed old expected results for caret-rtl.html and caret-rtl-2.html on Mac Leopard.

        * platform/mac-leopard/editing/selection/caret-rtl-2-expected.checksum: Removed.
        * platform/mac-leopard/editing/selection/caret-rtl-2-expected.png: Removed.
        * platform/mac-leopard/editing/selection/caret-rtl-expected.checksum: Removed.
        * platform/mac-leopard/editing/selection/caret-rtl-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Chromium test expectations update.
pkasting@chromium.org [Wed, 8 Dec 2010 22:35:13 +0000 (22:35 +0000)]
Unreviewed Chromium test expectations update.

Mark some Mac tests as timing out after r73518 and r73522.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed the change log entry for r73548.
rniwa@webkit.org [Wed, 8 Dec 2010 22:34:49 +0000 (22:34 +0000)]
Fixed the change log entry for r73548.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove an unused variable.
andersca@apple.com [Wed, 8 Dec 2010 22:25:01 +0000 (22:25 +0000)]
Remove an unused variable.

* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView setScrollOrigin:updatePosition:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows test results after r73538
aroben@apple.com [Wed, 8 Dec 2010 22:19:36 +0000 (22:19 +0000)]
Update Windows test results after r73538

We don't need Windows-specific results for this test anymore.

* platform/win-xp/svg/custom/clip-path-referencing-use-expected.checksum: Removed.
* platform/win-xp/svg/custom/clip-path-referencing-use-expected.png: Removed.
* platform/win-xp/svg/custom/clip-path-referencing-use-expected.txt: Removed.
* platform/win/svg/custom/clip-path-referencing-use-expected.checksum: Removed.
* platform/win/svg/custom/clip-path-referencing-use-expected.png: Removed.
* platform/win/svg/custom/clip-path-referencing-use-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 8 Dec 2010 22:09:44 +0000 (22:09 +0000)]
2010-12-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Build fix. Take webView{Enter,Exit}Fullscreen back out of the
        WebKit namespace, and remove a function signature that got in by
        mistake because of a bad merge.

        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        (WebKit::core):
        (WebKit::kit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 8 Dec 2010 21:58:16 +0000 (21:58 +0000)]
2010-12-08  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Text is blurry on a large composited layer with an odd center x/y coordinate
        https://bugs.webkit.org/show_bug.cgi?id=50702

        Tests that text rendered on a large layer is crisp even when the layer's center point
        has an odd x and/or y coordinate.

        * compositing/text-on-large-layer.html: Added.
        * platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.checksum: Added.
        * platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.png: Added.
        * platform/chromium-gpu-linux/compositing/text-on-large-layer-expected.txt: Added.
        * platform/chromium-gpu/test_expectations.txt:
        * platform/mac/compositing/text-on-large-layer-expected.checksum: Added.
        * platform/mac/compositing/text-on-large-layer-expected.png: Added.
        * platform/mac/compositing/text-on-large-layer-expected.txt: Added.
2010-12-08  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Text is blurry on a large composited layer with an odd center x/y coordinate
        https://bugs.webkit.org/show_bug.cgi?id=50702

        Compute the center of a large layer using floats instead of ints to avoid roundoff errors.

        Test: compositing/text-on-large-layer.html

        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 8 Dec 2010 21:55:54 +0000 (21:55 +0000)]
2010-12-08  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Dan Bernstein.

        REGRESSION: LayoutTests/editing/selection/caret-rtl-2.html fails
        https://bugs.webkit.org/show_bug.cgi?id=33503

        The bug was caused by Font::offsetForPosition's not taking into account the containing block's text direction.
        When RTL text appears in a LTR block, the offset at the beginning of RTL text is on the left of RTL text,
        adn the offset at the end of RTL text is on the right of RTL text. For example, if we had RTL text CBA,
        then the correspondance between letters and offsets in logical order are: A -> 0, B -> 1, and C -> 2.

        Case 1. CBA appears in a RTL block:
          In this case, clicking on the visual left of CBA puts the caret naturally at Position("CBA", 2).
          Clicking on the visual right of CBA puts the caret at Position("CBA", 0) as expected.
        Case 2. CBA appears in a LTR block:
          Because the containing block flows from left to right, by covention, Position("CBA", 2") coresponds
          to the visual right of CBA, and Position("CBA", 0) corresponds to the visual left of CBA.
          Therefore, clicking on the visual left of CBA should put the caret at Positoin("CBA", 0),
          and clicking on the visual right should put it at Position("CBA", 2).

        The bug was caused by WebKit's not considering case 2. The same bug also existe for LTR text in a RTL block.
        Fixed the bug by taking care of the case 2 in InlineTextBox::offsetForPosition.

        Tests: editing/selection/caret-ltr-2-left.html
               editing/selection/caret-ltr-2.html
               editing/selection/caret-ltr-right.html
               editing/selection/caret-ltr.html
               editing/selection/caret-rtl-2-left.html
               editing/selection/caret-rtl-right.html

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::offsetForPosition):
2010-12-08  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Dan Bernstein.

        REGRESSION: LayoutTests/editing/selection/caret-rtl-2.html fails
        https://bugs.webkit.org/show_bug.cgi?id=33503

        Added tests to ensure WebKit places the caret at a right place for LTR text in a LTR block,
        LTR text in a RTL block, RTL text in a RTL block, and RTL text in a LTR block.

        Because we need to verify both rendering of the caret and (node, offset) pair of the caret,
        these tests cannot be combined or done without pixel results.

        * editing/selection/caret-ltr-2-left.html: Added.
        * editing/selection/caret-ltr-2.html: Added.
        * editing/selection/caret-ltr-right.html: Added.
        * editing/selection/caret-ltr.html: Added.
        * editing/selection/caret-rtl-2-left.html: Added.
        * editing/selection/caret-rtl-2.html:
        * editing/selection/caret-rtl-right.html: Added.
        * editing/selection/caret-rtl.html:
        * editing/selection/resources/caret-edge-shared.js: Added.
        (runTest):
        (verify):
        (log):
        * platform/mac/editing/selection/caret-ltr-2-expected.checksum: Added.
        * platform/mac/editing/selection/caret-ltr-2-expected.png: Added.
        * platform/mac/editing/selection/caret-ltr-2-expected.txt: Added.
        * platform/mac/editing/selection/caret-ltr-2-left-expected.checksum: Added.
        * platform/mac/editing/selection/caret-ltr-2-left-expected.png: Added.
        * platform/mac/editing/selection/caret-ltr-2-left-expected.txt: Added.
        * platform/mac/editing/selection/caret-ltr-expected.checksum: Added.
        * platform/mac/editing/selection/caret-ltr-expected.png: Added.
        * platform/mac/editing/selection/caret-ltr-expected.txt: Added.
        * platform/mac/editing/selection/caret-ltr-right-expected.checksum: Added.
        * platform/mac/editing/selection/caret-ltr-right-expected.png: Added.
        * platform/mac/editing/selection/caret-ltr-right-expected.txt: Added.
        * platform/mac/editing/selection/caret-rtl-2-expected.checksum:
        * platform/mac/editing/selection/caret-rtl-2-expected.png:
        * platform/mac/editing/selection/caret-rtl-2-expected.txt:
        * platform/mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
        * platform/mac/editing/selection/caret-rtl-2-left-expected.png: Added.
        * platform/mac/editing/selection/caret-rtl-2-left-expected.txt: Added.
        * platform/mac/editing/selection/caret-rtl-expected.checksum:
        * platform/mac/editing/selection/caret-rtl-expected.png:
        * platform/mac/editing/selection/caret-rtl-expected.txt:
        * platform/mac/editing/selection/caret-rtl-right-expected.checksum: Added.
        * platform/mac/editing/selection/caret-rtl-right-expected.png: Added.
        * platform/mac/editing/selection/caret-rtl-right-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Touch a file that's sporadically giving 207 Multi-Status error on svn update...
ap@apple.com [Wed, 8 Dec 2010 21:48:51 +0000 (21:48 +0000)]
    Touch a file that's sporadically giving 207 Multi-Status error on svn update, hoping that
        it will magically fix it.

        * fast/xpath/4XPath/Core/test.js: Removed properties svn:mime-type and svn:eol-style, added
        a newline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename WKPreferencesGetFTPDirectoryTemplatePath to WKPreferencesCopyFTPDirectoryTempl...
weinig@apple.com [Wed, 8 Dec 2010 21:48:09 +0000 (21:48 +0000)]
Rename WKPreferencesGetFTPDirectoryTemplatePath to WKPreferencesCopyFTPDirectoryTemplatePath
since it copies the value.

Reviewed by Oliver Hunt.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCopyFTPDirectoryTemplatePath):
* UIProcess/API/C/WKPreferencesPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Wed, 8 Dec 2010 21:44:38 +0000 (21:44 +0000)]
2010-12-08  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Marking the active global object re-enters through markConservatively
        https://bugs.webkit.org/show_bug.cgi?id=50711

        draining of the MarkStack is not allowed to be re-entrant, we got away
        with this simply due to the logic in MarkStack::drain implicitly handling
        changes that could be triggered by the re-entry.

        Just to be safe this patch removes the re-entry through markConservatively
        so we don't accidentally introduce such an issue in future.  I've also
        added an assertion to catch such errors.

        * runtime/Collector.cpp:
        (JSC::Heap::markConservatively):
        (JSC::Heap::markCurrentThreadConservativelyInternal):
        (JSC::Heap::markOtherThreadConservatively):
        * runtime/JSArray.h:
        (JSC::MarkStack::drain):
        * runtime/MarkStack.h:
        (JSC::MarkStack::MarkStack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed Chromium test expectations update.
pkasting@chromium.org [Wed, 8 Dec 2010 21:41:06 +0000 (21:41 +0000)]
Unreviewed Chromium test expectations update.

Mark some tests as passing or slow, and update the comment on the
compositing tests to indicate more accurately why we skip them in the
main test run.

* platform/chromium-gpu/test_expectations.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix some clang++ warnings (one of which was an actual bug)
andersca@apple.com [Wed, 8 Dec 2010 21:29:06 +0000 (21:29 +0000)]
Fix some clang++ warnings (one of which was an actual bug)
https://bugs.webkit.org/show_bug.cgi?id=50700

Reviewed by Darin Adler.

* page/mac/DragControllerMac.mm:
(WebCore::DragController::dragOperation):
Add parentheses to silent a clang warning.

* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
Fix || vs && precedence bug uncovered by clang.

* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshape):
Use an early return to avoid a warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Can't open ftp directory
weinig@apple.com [Wed, 8 Dec 2010 21:27:46 +0000 (21:27 +0000)]
WebKit2: Can't open ftp directory
<rdar://problem/8489321>

Reviewed by Brady Eidson.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetForceFTPDirectoryListings):
(WKPreferencesGetForceFTPDirectoryListings):
(WKPreferencesSetFTPDirectoryTemplatePath):
(WKPreferencesGetFTPDirectoryTemplatePath):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Pipe through the FTP directory listing preferences.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 8 Dec 2010 20:43:50 +0000 (20:43 +0000)]
2010-12-08  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectations update.
        fast/dom/HTMLMeterElement/meter-element.html has been rebaselined for Windows.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 8 Dec 2010 20:43:43 +0000 (20:43 +0000)]
2010-12-08  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
        https://bugs.webkit.org/show_bug.cgi?id=49388

        Added copy constructors and casting operators to go between
        TransformationMatrix and CATransform3D. Also added a copy
        constructor to go from CGAffineTransform to TransformationMatrix.
        Used these new methods to clean up platform CA code. This will
        make it easier to port to Windows.

        I also fixed a couple of build issues found when trying out a
        Windows build.

        This is a resubmission of changesets r73477 and r73483 with a
        fix for the SL build. The failure was because TransformationMatrix
        included QuartzCore/CATransform3D.h which brought in some system
        libraries, including Quickdraw, which has a definition for
        'Cursor' which clashed with WebCore's 'Cursor' class. So I had
        to qualify its use in WebChromeClient.cpp in WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Wed, 8 Dec 2010 20:29:03 +0000 (20:29 +0000)]
2010-12-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Split webkitprivate.{cpp,h} in more manageable chunks
        https://bugs.webkit.org/show_bug.cgi?id=50698

        Split private bits of WebKitWebView to its own private header, and
        to its implementation file. Take the opportunity to fix includes
        sorting to comply with the style guide.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::enterFullscreenForNode):
        (WebKit::ChromeClient::exitFullscreenForNode):
        * WebCoreSupport/ContextMenuClientGtk.cpp:
        * WebCoreSupport/DragClientGtk.cpp:
        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        * WebCoreSupport/EditorClientGtk.cpp:
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        * WebCoreSupport/InspectorClientGtk.cpp:
        * WebCoreSupport/PasteboardHelperGtk.cpp:
        * webkit/webkitprivate.cpp:
        (webkit_init):
        * webkit/webkitprivate.h:
        * webkit/webkitwebbackforwardlist.cpp:
        * webkit/webkitwebdatasource.cpp:
        * webkit/webkitwebframe.cpp:
        * webkit/webkitwebview.cpp:
        (WebKit::core):
        (WebKit::kit):
        (WebKit::webViewEnterFullscreen):
        (WebKit::webViewExitFullscreen):
        * webkit/webkitwebviewprivate.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip svg/custom/clip-path-referencing-use2.svg, not svg/custom/clip-path-referencing...
aroben@apple.com [Wed, 8 Dec 2010 20:25:31 +0000 (20:25 +0000)]
Skip svg/custom/clip-path-referencing-use2.svg, not svg/custom/clip-path-referencing-use.svg

The former is the real problem. The latter was just the victim!

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 8 Dec 2010 20:18:57 +0000 (20:18 +0000)]
2010-12-08  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectations update.
        fast/text/decomposed-after-stacked-diacritics.html crashes on Chromium Linux.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 8 Dec 2010 19:59:56 +0000 (19:59 +0000)]
2010-12-08  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaseline for r73531.

        * platform/chromium-linux/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/rtl-static-positioning-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
        * platform/chromium-linux/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
        * platform/chromium-linux/fast/block/positioning/table-cell-static-position-expected.png: Added.
        * platform/chromium-mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
        * platform/chromium-mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
        * platform/chromium-mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
        * platform/chromium-mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
        * platform/chromium-mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
        * platform/chromium-mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/rtl-static-positioning-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
        * platform/chromium-win/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
        * platform/chromium-win/fast/block/positioning/table-cell-static-position-expected.png: Added.
        * platform/chromium-win/fast/block/positioning/table-cell-static-position-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLayering Violation in ContextMenu - member variable of type HitTestResult
bweinstein@apple.com [Wed, 8 Dec 2010 19:26:05 +0000 (19:26 +0000)]
Layering Violation in ContextMenu - member variable of type HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=50586

Reviewed by John Sullivan.

WebCore:

ContextMenu had a layering violation by having a member variable of type HitTestResult, because
classes in WebCore/platform can't know about classes in WebCore.

This patch moves the HitTestResult and all functions that use it out of ContextMenu into ContextMenuController.
All of the functions that dealt with populating the ContextMenu are now in ContextMenuController, and this
allowed us to delete the ContextMenu file, putting all of the cross-platform code that used to be it
in ContextMenuController, and the rest of the code is in the platform-specific files.

No change in behavior, no new tests.

* Android.mk: Removed ContextMenu.cpp.
* CMakeLists.txt: Ditto.
* GNUmakefile.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::ContextMenuController): Initialized m_hitTestResult to an empty HitTestResult.
(WebCore::ContextMenuController::handleContextMenuEvent): Call populate on the ContextMenuController instead
    of the ContextMenu.
(WebCore::ContextMenuController::createContextMenu): Fix some indination, and store the HitTestResult in a member
    variable.
(WebCore::ContextMenuController::showContextMenu): Call addInspectElementItem on the ContextMenuController.
(WebCore::ContextMenuController::contextMenuItemSelected): Use m_hitTestResult whenever we need a HitTestResult.
(WebCore::ContextMenuController::appendItem): Validates the item for its state, and then appends it to the parent menu.
    This allowed us to move checkOrEnableIfNeeded from ContextMenu.

These functions were all moved from ContextMenu, and changed slightly to fit in ContextMenuController.
All calls to ContextMenu::appendItem were changed to ContextMenuController::appendItem, which takes care
of validating the menu.
(WebCore::separatorItem): Moved from ContextMenu.
(WebCore::ContextMenuController::createAndAppendFontSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSpeechSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendWritingDirectionSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendTextDirectionSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendSubstitutionsSubMenu): Ditto.
(WebCore::ContextMenuController::createAndAppendTransformationsSubMenu): Ditto.
(WebCore::selectionContainsPossibleWord): Ditto.
(WebCore::ContextMenuController::populate): Ditto.
(WebCore::ContextMenuController::addInspectElementItem): Ditto.
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Ditto.

* page/ContextMenuController.h:
(WebCore::ContextMenuController::hitTestResult): Returns the HitTestResult of the current ContextMenu.

* platform/ContextMenu.cpp: Removed.
* platform/ContextMenu.h:
* platform/efl/ContextMenuEfl.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
* platform/gtk/ContextMenuGtk.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Ditto.
* platform/haiku/ContextMenuHaiku.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Ditto.
(WebCore::ContextMenu::insertItem): Ditto.
* platform/mac/ContextMenuMac.mm:
(-[WebCoreMenuTarget validateMenuItem:]): Calls checkOrEnableIfNeeded on the controller instead of
    the context menu.
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::appendItem): Removed the call to checkOrEnableIfNeeded.
(WebCore::ContextMenu::insertItem): Ditto.
* platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(WebCore::ContextMenu::insertItem): Removed the call to checkOrEnableIfNeeded.
* platform/wx/ContextMenuWx.cpp:
(WebCore::ContextMenu::ContextMenu): Removed m_hitTestResult from the constructor.
(ContextMenu::appendItem): Ditto.

WebKit/chromium:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

* src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspelledWord):
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

WebKit/gtk:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

* WebCoreSupport/ContextMenuClientGtk.cpp:
(WebKit::ContextMenuClient::getCustomMenuFromDefaultItems):

WebKit/mac:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

* WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::getCustomMenuFromDefaultItems):
(WebContextMenuClient::contextMenuItemSelected):
* WebView/WebHTMLView.mm:
(-[WebMenuTarget validateMenuItem:]):

WebKit/qt:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

* Api/qwebpage.cpp:
(QWebPagePrivate::createContextMenu):
(QWebPage::updatePositionDependentActions):

WebKit/win:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the
    ContextMenuController (from the page).
(WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController.
* WebView.cpp:
(WebView::handleContextMenuEvent): Ditto.

WebKit2:

Update users of ContextMenu and ContextMenuController to match where the new functions
are located.

* Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::WebContextMenuItemData): Remove the call to checkOrEnableItem, that call will be made when
    the ContextMenuItem is added to the ContextMenu through the ContextMenuController.
* WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 8 Dec 2010 19:17:18 +0000 (19:17 +0000)]
2010-12-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by John Sullivan.

        [GTK] Layering violation in ContextMenuGtk.cpp
        https://bugs.webkit.org/show_bug.cgi?id=50676

        ContextMenuGtk accesses the page's ContextMenuController, which is a layering
        violation. This was fixed for Mac with change r73469. We make a similar fix here
        by moving the "activated" signal connection to the WebKit layer.

        * platform/gtk/ContextMenuGtk.cpp:
        (WebCore::ContextMenu::appendItem): Remove access of ContextMenuController. This
        is a layering violation.
2010-12-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by John Sullivan.

        [GTK] Layering violation in ContextMenuGtk.cpp
        https://bugs.webkit.org/show_bug.cgi?id=50676

        ContextMenuGtk accesses the page's ContextMenuController, which is a layering
        violation. This was fixed for Mac with change r73469. We make a similar fix here
        by moving the "activated" signal connection to the WebKit layer.

        * webkit/webkitwebview.cpp:
        (popupMenuItemActivated): Have ContextMenuController handle this signal.
        (webkit_web_view_forward_context_menu_event): For all items in the untouched
        context menu, connect their "activated" signal to the new popupMenuItemActivated
        handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2: Implement WebChromeClient::exceededDatabaseQuota
jberlin@webkit.org [Wed, 8 Dec 2010 19:06:42 +0000 (19:06 +0000)]
WebKit2: Implement WebChromeClient::exceededDatabaseQuota
https://bugs.webkit.org/show_bug.cgi?id=50656

Reviewed by Adam Roben.

WebCore:

* WebCore.exp.in:
Export the symbol for SecurityOrigin::databaseIdentifier.

WebKit2:

The exceededDatabaseQuota call from the WebProcess to the UIProcess needs to be synchronous
because the new quota is checked directly after exceededDatabaseQuota returns in order to
determine if the new Database can be created.

Pass all of the details from the WebProcess to the UIProcess in order to inform the
decision in the UIProcess about the new quota. In WebKit1, these details were
fetched through an additional call to the API detailsForDatabase (which is infeasible in
WebKit2 since exceededDatabaseQuota is a synchronous call).

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add a version that takes 7 parameters.

* UIProcess/API/C/WKPage.h:

* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
Indicate that exceededDatabaseQuota is not implemented.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::exceededDatabaseQuota):
Call the UIClient's exceededDatabaseQuota
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::exceededDatabaseQuota):
If the client does not implement exceededDatabaseQuota, return a the current quota.
* UIProcess/WebUIClient.h:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::exceededDatabaseQuota):
Send a synchronous message to the UIProcess to ask for the new quota for the origin for the
given frame.

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController awakeFromNib]):
Indicate that exceededDatabaseQuota is not implemented.
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
Ditto.
* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
Ditto.
(WTR::TestController::initialize):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Wed, 8 Dec 2010 19:02:23 +0000 (19:02 +0000)]
2010-12-08  Csaba Osztrogonác  <ossy@webkit.org>

        Unreviewed, rolling out r73521.
        http://trac.webkit.org/changeset/73521
        https://bugs.webkit.org/show_bug.cgi?id=50640

        It broke 90 layout tests

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::printErrorMessageForFrame):
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setLocation):
        * page/DOMWindow.cpp:
        * page/DOMWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=50576
hyatt@apple.com [Wed, 8 Dec 2010 18:31:33 +0000 (18:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=50576

Reviewed by Anders Carlsson.

REGRESSION in position of autocomplete popup on RTL page.

RTL static position computation did not subtract out the width of the enclosing box if the
immediate parent was a RenderInline.  This bug was exposed by properly changing the RenderView
to be RTL when the document was RTL.

Added three new tests in fast/block/positioning.

WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth):

LayoutTests:

* fast/block/positioning/rtl-static-positioning-inline-block.html: Added.
* fast/block/positioning/rtl-static-positioning.html: Added.
* fast/block/positioning/table-cell-static-position.html: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
* platform/mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
* platform/mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
* platform/mac/fast/block/positioning/table-cell-static-position-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 8 Dec 2010 18:14:11 +0000 (18:14 +0000)]
2010-12-08  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Fix backward mouse wheeling not working when scroll position is below 0.
        https://bugs.webkit.org/show_bug.cgi?id=50370

        Tests: fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html
               fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::wheelEvent):
2010-12-08  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Hyatt.

        Fix backward mouse wheeling not working when scroll position is below 0.
        https://bugs.webkit.org/show_bug.cgi?id=50370

        * fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
        * fast/dom/horizontal-scrollbar-in-rtl.html:
        * fast/dom/vertical-scrollbar-in-rtl-expected.txt:
        * fast/dom/vertical-scrollbar-in-rtl.html:
        * fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
        * fast/events/wheelevent-in-horizontal-scrollbar-in-rtl.html: Added.
        * fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
        * fast/events/wheelevent-in-vertical-scrollbar-in-rtl.html: Added.
        * platform/chromium/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
        * platform/chromium/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
        * platform/chromium/fast/events/wheelevent-in-horizontal-scrollbar-in-rtl-expected.txt: Added.
        * platform/chromium/fast/events/wheelevent-in-vertical-scrollbar-in-rtl-expected.txt: Added.
        * platform/gtk/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
        * platform/qt/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
        * platform/qt/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
        * platform/win/Skipped:
        * platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
        * platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, cleaning up test expectations after r7349.
antonm@chromium.org [Wed, 8 Dec 2010 18:01:13 +0000 (18:01 +0000)]
Unreviewed, cleaning up test expectations after r7349.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Wed, 8 Dec 2010 17:47:49 +0000 (17:47 +0000)]
2010-12-08  Antonio Gomes  <agomes@rim.com>

        Reviewed by Martin Robinson.

        [Gtk] Populate DumpRenderTreeSupportGtk (part III)
        https://bugs.webkit.org/show_bug.cgi?id=48429

        WebKit/gtk:

        Adjusted some call sites of previously internal API declared
        webkitprivate.h that have moved to DumpRenderTreeSupportGtk.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::gcCollectJavascriptObjects):
        (DumpRenderTreeSupportGtk::gcCollectJavascriptObjectsOnAlternateThread):
        (DumpRenderTreeSupportGtk::gcCountJavascriptObjects):
        (DumpRenderTreeSupportGtk::layoutFrame):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:

        WebKitTools:

        Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
        * webkit_gc_collect_javascript_objects;
        * webkit_gc_collect_javascript_objects_on_alternate_thread;
        * webkit_gc_count_javascript_objects;
        * webkit_web_frame_layout.

        These were all only used by GTK+ DRT.

        * DumpRenderTree/gtk/EventSender.cpp:
        (dispatchEvent):
        * DumpRenderTree/gtk/GCControllerGtk.cpp:
        (GCController::collect):
        (GCController::collectOnAlternateThread):
        (GCController::getJSObjectCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 8 Dec 2010 17:37:32 +0000 (17:37 +0000)]
2010-12-08  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Fix pauseAnimation API to work with shorthand properties
        https://bugs.webkit.org/show_bug.cgi?id=50639

        The pause API is always called with a long-hand property, but that
        property may be animating via a shorthand. Detect this, and pause
        such shorthand animations.

        * page/animation/AnimationBase.cpp:
        (WebCore::ShorthandPropertyWrapper::propertyWrappers): Expose the vector
        of wrappers used by a shorthand wrapper.

        (WebCore::gatherEnclosingShorthandProperties): Utility function that walks
        through the shorthand wrappers, keeping track of which can affect the given
        property.
        (WebCore::AnimationBase::animatableShorthandsAffectingProperty): Return a set
        of shorthand properties that can affect the given property.

        * page/animation/AnimationBase.h: New method.
        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::pauseTransitionAtTime): If we don't find the
        property itself, check whether it's being animated via shorthands.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8740920> Gestures: Frame::scalePage() broken by r73885
hyatt@apple.com [Wed, 8 Dec 2010 16:55:08 +0000 (16:55 +0000)]
<rdar://problem/8740920> Gestures: Frame::scalePage() broken by r73885

Reviewed by Beth Dakin.

Make sure the transform applied to the RenderView for page scaling is incorporated into the
docTop/Bottom/Left/Right accessors.

* rendering/RenderView.cpp:
(WebCore::RenderView::docTop):
(WebCore::RenderView::docBottom):
(WebCore::RenderView::docLeft):
(WebCore::RenderView::docRight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 8 Dec 2010 16:54:10 +0000 (16:54 +0000)]
2010-12-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Protocol cleanup task. Remove WebInspector wrappers
        for TimelineAgent functions.

        https://bugs.webkit.org/show_bug.cgi?id=50690

        * inspector/Inspector.idl:
        * inspector/front-end/TimelineAgent.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype.timelineProfilerWasStarted):
        (WebInspector.TimelinePanel.prototype.timelineProfilerWasStopped):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Wed, 8 Dec 2010 16:49:34 +0000 (16:49 +0000)]
2010-12-08  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] media/fullscreen* failing on 64-bits Debug
        https://bugs.webkit.org/show_bug.cgi?id=50394

        Avoid emiting durationchanged in the case where the previous
        duration was 0 because that case is already handled by the
        HTMLMediaElement.

        Test: media/media-fullscreen*.html

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::durationChanged):

LayoutTests:

        Reviewed by Gustavo Noronha Silva.

        [GTK] media/fullscreen* failing on 64-bits Debug
        https://bugs.webkit.org/show_bug.cgi?id=50394

        * platform/gtk/Skipped: Unskip now passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-08 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 8 Dec 2010 16:22:18 +0000 (16:22 +0000)]
2010-12-08  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Remove WIN prefix for inspector's tests expectations.
        DumpRenderTree related patch.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73522 268f45cc-cd09-0410-ab3c-d52691b4dbfc