WebKit-https.git
9 years ago2011-02-07 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 8 Feb 2011 12:57:37 +0000 (12:57 +0000)]
2011-02-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
        https://bugs.webkit.org/show_bug.cgi?id=53914

        * http/tests/inspector/inspector-test2.js:
        (initialize_InspectorTest.InspectorTest.reloadPage):
        * inspector/audits-panel-functional.html:
2011-02-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: ignore cache upon reload via Ctrl(Cmd)+Shift+R.
        https://bugs.webkit.org/show_bug.cgi?id=53914

        * inspector/Inspector.idl:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::reloadPage):
        * inspector/InspectorAgent.h:
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel.prototype._reloadResources):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onReload):
        * inspector/front-end/inspector.js:
        (WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 8 Feb 2011 12:45:32 +0000 (12:45 +0000)]
2011-02-08  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping test timing out on GTK 32-bit debug bot.

        fast/loader/onload-willSendRequest-null-for-frame.html times out in GTK 32-bit debug bot
        https://bugs.webkit.org/show_bug.cgi?id=53992

        * platform/gtk/Skipped: Skipped test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 8 Feb 2011 11:26:39 +0000 (11:26 +0000)]
2011-02-08  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping flaky test on GTK debug bots.

        fast/frames/sandboxed-iframe-storage.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=53991

        * platform/gtk/Skipped: Skipped test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip over sibling selectors when collecting descendant selector hashes
antti@apple.com [Tue, 8 Feb 2011 10:52:13 +0000 (10:52 +0000)]
Skip over sibling selectors when collecting descendant selector hashes
https://bugs.webkit.org/show_bug.cgi?id=53987

Reviewed by Cameron Zwarich.

Skip instead of bailing out. This will allow optimizing some sibling selector cases.

* css/CSSStyleSelector.cpp:
(WebCore::RuleData::RuleData):
(WebCore::RuleData::collectIdentifierHashes):
(WebCore::RuleData::collectDescendantSelectorIdentifierHashes):
* css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 8 Feb 2011 10:50:40 +0000 (10:50 +0000)]
2011-02-08  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping flaky test on GTK debug bots.

        svg/custom/use-multiple-on-nested-disallowed-font.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=53989

        * platform/gtk/Skipped: Skipped test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Tue, 8 Feb 2011 10:20:51 +0000 (10:20 +0000)]
2011-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DRT's TextInputController is unimplemented on GTK
        https://bugs.webkit.org/show_bug.cgi?id=52997

        * platform/gtk/Skipped: Unskip several tests that pass now that we
        have TextInputController.
2011-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DRT's TextInputController is unimplemented on GTK
        https://bugs.webkit.org/show_bug.cgi?id=52997

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setComposition):
        (DumpRenderTreeSupportGtk::confirmComposition):
        (DumpRenderTreeSupportGtk::firstRectForCharacterRange):
        (DumpRenderTreeSupportGtk::selectedRange): New methods needed by
        TextInputController.
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DRT's TextInputController is unimplemented on GTK
        https://bugs.webkit.org/show_bug.cgi?id=52997

        Initial implementation of TextInputController for GTK port.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewWindowObjectCleared):
        * DumpRenderTree/gtk/TextInputController.cpp: Added.
        (setMarkedTextCallback):
        (insertTextCallback):
        (unmarkTextCallback):
        (firstRectForCharacterRangeCallback):
        (selectedRangeCallback):
        (getClass):
        (makeTextInputController):
        * DumpRenderTree/gtk/TextInputController.h: Added.
        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLLVM Compiler build fix.
mitz@apple.com [Tue, 8 Feb 2011 09:18:20 +0000 (09:18 +0000)]
LLVM Compiler build fix.

Reviewed by Maciej Stachowiak.

* runtime/WriteBarrier.h:
(JSC::WriteBarrier::WriteBarrier):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-08 Sheriff Bot <webkit.review.bot@gmail.com>
mjs@apple.com [Tue, 8 Feb 2011 08:49:37 +0000 (08:49 +0000)]
2011-02-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77866.
        http://trac.webkit.org/changeset/77866
        https://bugs.webkit.org/show_bug.cgi?id=53981

        caused all WebKit2 inspector tests to crash (Requested by
        othermaciej on #webkit).

        * UIProcess/WebInspectorProxy.cpp:
        (WebKit::WebInspectorProxy::didClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Cris Neckar <cdn@chromium.org>
commit-queue@webkit.org [Tue, 8 Feb 2011 07:44:48 +0000 (07:44 +0000)]
2011-02-07  Cris Neckar  <cdn@chromium.org>

        Reviewed by Jian Li.

        Test for null deref in DOMURL
        https://bugs.webkit.org/show_bug.cgi?id=53811

        * fast/files/domurl-script-execution-context-crash-expected.txt: Added.
        * fast/files/domurl-script-execution-context-crash.html: Added.
2011-02-07  Cris Neckar  <cdn@chromium.org>

        Reviewed by Jian Li.

        Fix null deref in DOMURL
        https://bugs.webkit.org/show_bug.cgi?id=53811

        Test: fast/files/domurl-script-execution-context-crash.html

        * html/DOMURL.cpp:
        (WebCore::DOMURL::DOMURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 8 Feb 2011 07:30:29 +0000 (07:30 +0000)]
2011-02-07  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        clean up python imports
        https://bugs.webkit.org/show_bug.cgi?id=53966

        Convert "import A.B.C.D as D" to "from A.B.C import D" and
        make some imports absolute as required by PEP-8

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/net/irc/ircbot.py:
        * Scripts/webkitpy/common/system/logutils.py:
        * Scripts/webkitpy/common/system/logutils_unittest.py:
        * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
        * Scripts/webkitpy/tool/bot/irc_command.py:
        * Scripts/webkitpy/tool/bot/sheriffircbot.py:
        * Scripts/webkitpy/tool/commands/download.py:
        * Scripts/webkitpy/tool/commands/prettydiff.py:
        * Scripts/webkitpy/tool/commands/queries.py:
        * Scripts/webkitpy/tool/commands/roll.py:
        * Scripts/webkitpy/tool/commands/stepsequence.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/main.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 James Robinson <jamesr@chromium.org>
commit-queue@webkit.org [Tue, 8 Feb 2011 07:29:37 +0000 (07:29 +0000)]
2011-02-07  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Teach do-webcore-rename about the WebKit move to Source/
        https://bugs.webkit.org/show_bug.cgi?id=53967

        * Scripts/do-webcore-rename:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Tue, 8 Feb 2011 07:24:31 +0000 (07:24 +0000)]
Unreviewed.

[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912

* platform/qt/Skipped: http/tests/websocket/tests/websocket-protocol-ignored.html added until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the 32-bit build.
mrowe@apple.com [Tue, 8 Feb 2011 07:13:35 +0000 (07:13 +0000)]
Fix the 32-bit build.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar): Remove some extraneous characters.
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Kenji Imasaki <imasaki@chromium.org>
commit-queue@webkit.org [Tue, 8 Feb 2011 07:07:24 +0000 (07:07 +0000)]
2011-02-07  Kenji Imasaki  <imasaki@chromium.org>

        Reviewed by David Levin.

        [Chromium] Remove non-Flaky media layout tests and update bugs that
        are associated with media layout tests
        https://bugs.webkit.org/show_bug.cgi?id=53948

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 8 Feb 2011 07:07:22 +0000 (07:07 +0000)]
2011-02-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Add resource load client for injected bundle and move willSendRequest there
        https://bugs.webkit.org/show_bug.cgi?id=53972

        * GNUmakefile.am:
        * WebKit2.pro:
        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
        (WKBundlePageSetPageLoaderClient):
        (WKBundlePageSetResourceLoadClient):
        * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
        * WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp: Added.
        (WebKit::InjectedBundlePageResourceLoadClient::didInitiateLoadForResource):
        (WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame):
        (WebKit::InjectedBundlePageResourceLoadClient::didReceiveResponseForResource):
        (WebKit::InjectedBundlePageResourceLoadClient::didReceiveContentLengthForResource):
        (WebKit::InjectedBundlePageResourceLoadClient::didFinishLoadForResource):
        (WebKit::InjectedBundlePageResourceLoadClient::didFailLoadForResource):
        * WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h: Added.
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::assignIdentifierToInitialRequest):
        (WebKit::WebFrameLoaderClient::dispatchWillSendRequest):
        (WebKit::WebFrameLoaderClient::dispatchDidReceiveResponse):
        (WebKit::WebFrameLoaderClient::dispatchDidReceiveContentLength):
        (WebKit::WebFrameLoaderClient::dispatchDidFinishLoading):
        (WebKit::WebFrameLoaderClient::dispatchDidFailLoading):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::initializeInjectedBundleResourceLoadClient):
        * WebProcess/WebPage/WebPage.h:
        (WebKit::WebPage::injectedBundleResourceLoadClient):
        * win/WebKit2.vcproj:
2011-02-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Add resource load client for injected bundle and move willSendRequest there
        https://bugs.webkit.org/show_bug.cgi?id=53972

        * MiniBrowser/mac/WebBundle/WebBundleMain.m:
        (didCreatePage):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::InjectedBundlePage):
        (WTR::InjectedBundlePage::didInitiateLoadForResource):
        (WTR::InjectedBundlePage::didReceiveResponseForResource):
        (WTR::InjectedBundlePage::didReceiveContentLengthForResource):
        (WTR::InjectedBundlePage::didFinishLoadForResource):
        (WTR::InjectedBundlePage::didFailLoadForResource):
        (WTR::InjectedBundlePage::willSendRequestForFrame):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Xiyuan Xia <xiyuan@chromium.org>
commit-queue@webkit.org [Tue, 8 Feb 2011 07:07:05 +0000 (07:07 +0000)]
2011-02-07  Xiyuan Xia  <xiyuan@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Select popup box does not align with select button when appearance is not "menulist".
        https://bugs.webkit.org/show_bug.cgi?id=53942

        Added manual test select_webkit_appearance_off_popup_alignment.html.

        * manual-tests/select_webkit_appearance_off_popup_alignment.html: Added.
        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Aparna Nandyal <aparna.nand@wipro.com>
commit-queue@webkit.org [Tue, 8 Feb 2011 06:59:04 +0000 (06:59 +0000)]
2011-02-07  Aparna Nandyal  <aparna.nand@wipro.com>

        Reviewed by Andreas Kling.

        [Qt] - Context menu needs "Copy" as well when the selected text is a link.
        https://bugs.webkit.org/show_bug.cgi?id=40983

        Added copy option for Qt platform if selection is a link.
        Added a test in tst_qwebpage.cpp.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::populate):
2011-02-07  Aparna Nandyal  <aparna.nand@wipro.com>

        Reviewed by Andreas Kling.

        [Qt] - Context menu needs "Copy" as well when the selected text is a link.
        https://bugs.webkit.org/show_bug.cgi?id=40983

        Added a test case to create a context sensitive menu.
        A check is made if it has Copy menu item when user
        selects a link and opens context menu.

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::contextMenuCopy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Mike Reed <reed@google.com>
commit-queue@webkit.org [Tue, 8 Feb 2011 06:48:06 +0000 (06:48 +0000)]
2011-02-07  Mike Reed  <reed@google.com>

        Reviewed by Kenneth Russell.

        Add compile-time flag ENABLE(SKIA_GPU) to use Skia's gpu backend
        when drawing <canvas>. Disabled by default.

        No new tests. existing canvas layouttests apply

        * platform/graphics/chromium/DrawingBufferChromium.cpp:
        (WebCore::DrawingBuffer::publishToPlatformLayer):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::GetGlobalGrContext):
        (WebCore::PlatformContextSkia::isPrinting):
        (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
        (WebCore::PlatformContextSkia::syncSoftwareCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Tue, 8 Feb 2011 06:45:50 +0000 (06:45 +0000)]
2011-02-07  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Darin Fisher.

        Removing unused code from PopupMenuChromium.
        https://bugs.webkit.org/show_bug.cgi?id=53866

       * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::layout):
        (WebCore::PopupMenuChromium::show):
        * platform/chromium/PopupMenuChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 8 Feb 2011 06:39:20 +0000 (06:39 +0000)]
2011-02-07  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        bring back diff context lines into the review tool
        https://bugs.webkit.org/show_bug.cgi?id=53974

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Kenichi Ishibashi <bashi@google.com>
commit-queue@webkit.org [Tue, 8 Feb 2011 06:30:56 +0000 (06:30 +0000)]
2011-02-07  Kenichi Ishibashi  <bashi@google.com>

        Reviewed by Andreas Kling.

        HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
        https://bugs.webkit.org/show_bug.cgi?id=53791

        Test that a live list is updated after the child of an HTMLOutputElement was removed.

        * fast/dom/HTMLOutputElement/htmloutputelement-children-removed-expected.txt: Added.
        * fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html: Added.
2011-02-07  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Andreas Kling.

        HTMLOutputElement::childrenChanged() should call its base class childrenChanged()
        https://bugs.webkit.org/show_bug.cgi?id=53791

        Calls HTMLFormControlElement::childrenChanged() in HTMLOutputElement::childrenChanged().

        Test: fast/dom/HTMLOutputElement/htmloutputelement-children-removed.html

        * html/HTMLOutputElement.cpp:
        (WebCore::HTMLOutputElement::childrenChanged): Calls super class's
        childrenChanged().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Benjamin Poulain <ikipou@gmail.com>
commit-queue@webkit.org [Tue, 8 Feb 2011 06:27:14 +0000 (06:27 +0000)]
2011-02-07  Benjamin Poulain  <ikipou@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] cookiesEnabled could create the cookieJar on the wrong thread.
        https://bugs.webkit.org/show_bug.cgi?id=52289

        Use the QtNAMThreadSafeProxy to make sure the cookie jar is created
        in the same thread as the QNetworkAccessManager.

        * platform/network/qt/QtNAMThreadSafeProxy.cpp:
        (WebCore::QtNAMThreadSafeProxy::QtNAMThreadSafeProxy):
        (WebCore::QtNAMThreadSafeProxy::hasCookieJar):
        * platform/network/qt/QtNAMThreadSafeProxy.h:
        * platform/qt/CookieJarQt.cpp:
        (WebCore::cookiesEnabled):
2011-02-07  Benjamin Poulain  <ikipou@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] cookiesEnabled could create the cookieJar on the wrong thread.
        https://bugs.webkit.org/show_bug.cgi?id=52289

        Test if the cookie jar is created in the right thread when accessed from
        the navigator object.

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::navigatorCookieEnabledForNetworkAccessManagerOnDifferentThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Alexey Marinichev <amarinichev@chromium.org>
commit-queue@webkit.org [Tue, 8 Feb 2011 06:25:20 +0000 (06:25 +0000)]
2011-02-07  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by Kenneth Russell.

        Hook up WebGraphicsContext3D::setContextLostCallback.
        https://bugs.webkit.org/show_bug.cgi?id=53722

        Test: fast/canvas/webgl/context-lost.html, comment out the line with
        extension.loseContext() and kill the GPU process "Lose context"
        message shows up.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContextLostCallback::WebGLRenderingContextLostCallback):
        (WebCore::WebGLRenderingContextLostCallback::onContextLost):
        (WebCore::WebGLRenderingContextLostCallback::~WebGLRenderingContextLostCallback):
        (WebCore::WebGLRenderingContext::initializeNewContext):
        (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
        * platform/graphics/GraphicsContext3D.h:
        (WebCore::GraphicsContext3D::ContextLostCallback::~ContextLostCallback):
        * platform/graphics/mac/GraphicsContext3DMac.mm:
        (WebCore::GraphicsContext3D::setContextLostCallback): stub
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::setContextLostCallback): stub
2011-02-07  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by Kenneth Russell.

        Hook up WebGraphicsContext3D::setContextLostCallback.
        https://bugs.webkit.org/show_bug.cgi?id=53722

        Test: fast/canvas/webgl/context-lost.html, comment out the line with
        extension.loseContext() and kill the GPU process "Lose context"
        message shows up.

        * public/WebGraphicsContext3D.h:
        (WebKit::WebGraphicsContext3D::WebGraphicsContextLostCallback::~WebGraphicsContextLostCallback):
        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContextLostCallbackAdapter::~GraphicsContextLostCallbackAdapter):
        (WebCore::GraphicsContextLostCallbackAdapter::GraphicsContextLostCallbackAdapter):
        (WebCore::GraphicsContextLostCallbackAdapter::onContextLost):
        (WebCore::GraphicsContextLostCallbackAdapter::create):
        (WebCore::GraphicsContext3DInternal::setContextLostCallback):
        * src/GraphicsContext3DInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the 32-bit build.
mrowe@apple.com [Tue, 8 Feb 2011 06:24:14 +0000 (06:24 +0000)]
Fix the 32-bit build.

* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Add some casts
to prevent warnings about mixing signed and unsigned comparisons.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 8 Feb 2011 06:11:32 +0000 (06:11 +0000)]
2011-02-07  Adam Barth  <abarth@webkit.org>

        Add Leopard Debug back to the core builders.

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Ami Fischman <fischman@google.com>
commit-queue@webkit.org [Tue, 8 Feb 2011 06:08:29 +0000 (06:08 +0000)]
2011-02-07  Ami Fischman  <fischman@google.com>

        Reviewed by Eric Seidel.

        Re-baseline media/video-zoom.html for http://crbug.com/70252 aka
        https://bugs.webkit.org/show_bug.cgi?id=53737 to account for (very)
        slightly different scrollbar shading.
        This test isn't flaky on LINUX or MAC according to
        http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showAllRuns=true&master=ChromiumWebkit&tests=media%2Fvideo-zoom.html
        so take it out of test_expectations.txt; it passes 100% on LINUX and
        fails 100% on MAC, and should pass 100% on MAC with this new
        baseline.

        * platform/chromium-mac/media/video-zoom-expected.checksum:
        * platform/chromium-mac/media/video-zoom-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Tue, 8 Feb 2011 06:05:15 +0000 (06:05 +0000)]
2011-02-07  Adam Klein  <adamk@chromium.org>

        Reviewed by Jian Li.

        [chromium] Remove deprecated method WebNotification::dir
        https://bugs.webkit.org/show_bug.cgi?id=53735

        * public/WebNotification.h:
        * src/WebNotification.cpp:
2011-02-07  Adam Klein  <adamk@chromium.org>

        Reviewed by Jian Li.

        [chromium] Remove deprecated method WebNotification::dir
        https://bugs.webkit.org/show_bug.cgi?id=53735

        * DumpRenderTree/chromium/NotificationPresenter.cpp:
        (NotificationPresenter::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 8 Feb 2011 06:02:17 +0000 (06:02 +0000)]
2011-02-07  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Eric Seidel.

        Add missing PaintInfo include in RenderThemeWin.cpp
        https://bugs.webkit.org/show_bug.cgi?id=53885

        * rendering/RenderThemeWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 8 Feb 2011 05:39:55 +0000 (05:39 +0000)]
2011-02-07  James Robinson  <jamesr@chromium.org>

        Move sputnik expectations to match test movement.

        * platform/gtk/fast/js/sputnik: Removed.
        * platform/gtk/fast/js/sputnik/Unicode: Removed.
        * platform/gtk/fast/js/sputnik/Unicode/Unicode_510: Removed.
        * platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
        * platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
        * platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
        * platform/gtk/sputnik: Copied from LayoutTests/platform/gtk/fast/js/sputnik.
        * platform/mac-leopard/fast/js/sputnik: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A3.2-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.16_A1-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S15.5.4.18_A1-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T1-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T2-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T1-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.2_T2-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A2.3-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T1-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T2-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T7-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T8-expected.txt: Removed.
        * platform/mac-leopard/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.2_T9-expected.txt: Removed.
        * platform/mac-leopard/sputnik: Copied from LayoutTests/platform/mac-leopard/fast/js/sputnik.
        * platform/win/fast/js/sputnik: Removed.
        * platform/win/fast/js/sputnik/Conformance: Removed.
        * platform/win/fast/js/sputnik/Conformance/11_Expressions: Removed.
        * platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators: Removed.
        * platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent: Removed.
        * platform/win/fast/js/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent/S11.5.3_A4_T6-expected.txt: Removed.
        * platform/win/fast/js/sputnik/Unicode: Removed.
        * platform/win/fast/js/sputnik/Unicode/Unicode_510: Removed.
        * platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.1-expected.txt: Removed.
        * platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Removed.
        * platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Removed.
        * platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Removed.
        * platform/win/sputnik: Copied from LayoutTests/platform/win/fast/js/sputnik.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Ami Fischman <fischman@google.com>
commit-queue@webkit.org [Tue, 8 Feb 2011 05:37:02 +0000 (05:37 +0000)]
2011-02-07  Ami Fischman  <fischman@google.com>

        Reviewed by Eric Carlson.

        Removed two of the three almost-duplicate test expectations
        between {media,platform/chromium-{mac,win}} by excluding file
        extensions from the emitted output.
        Removed outdated test_expectation for deleted test.
        http://crbug.com/28993

        * media/controls-right-click-on-timebar-expected.txt:
        * media/controls-right-click-on-timebar.html:
        * media/media-file.js:
        (stripExtension):
        * media/media-startTime-expected.txt:
        * media/media-startTime.html:
        * media/video-append-source-expected.txt:
        * media/video-append-source.html:
        * media/video-canvas-source-expected.txt:
        * media/video-canvas-source.html:
        * media/video-dom-src-expected.txt:
        * media/video-dom-src.html:
        * media/video-load-networkState-expected.txt:
        * media/video-load-networkState.html:
        * media/video-played-reset-expected.txt:
        * media/video-played-reset.html:
        * media/video-seek-past-end-paused-expected.txt:
        * media/video-seek-past-end-paused.html:
        * media/video-seek-past-end-playing-expected.txt:
        * media/video-seek-past-end-playing.html:
        * media/video-source-expected.txt:
        * media/video-source-type-expected.txt:
        * media/video-source-type-params-expected.txt:
        * media/video-source-type-params.html:
        * media/video-source-type.html:
        * media/video-source.html:
        * media/video-src-change-expected.txt:
        * media/video-src-change.html:
        * media/video-src-expected.txt:
        * media/video-src-remove-expected.txt:
        * media/video-src-remove.html:
        * media/video-src-set-expected.txt:
        * media/video-src-set.html:
        * media/video-src-source-expected.txt:
        * media/video-src-source.html:
        * media/video-src.html:
        * media/video-test.js:
        (enableFullTestDetailsPrinting):
        (test):
        (testExpected):
        (waitForEvent._eventCallback):
        (waitForEvent):
        (waitForEventAndTest._eventCallback):
        (waitForEventAndTest):
        (testException):
        (endTest):
        * platform/chromium-mac/media/controls-right-click-on-timebar-expected.txt: Removed.
        * platform/chromium-mac/media/media-startTime-expected.txt: Removed.
        * platform/chromium-mac/media/video-append-source-expected.txt: Removed.
        * platform/chromium-mac/media/video-canvas-source-expected.txt: Removed.
        * platform/chromium-mac/media/video-dom-src-expected.txt: Removed.
        * platform/chromium-mac/media/video-load-networkState-expected.txt: Removed.
        * platform/chromium-mac/media/video-played-reset-expected.txt: Removed.
        * platform/chromium-mac/media/video-seek-past-end-paused-expected.txt: Removed.
        * platform/chromium-mac/media/video-seek-past-end-playing-expected.txt: Removed.
        * platform/chromium-mac/media/video-source-add-src-expected.txt: Removed.
        * platform/chromium-mac/media/video-source-error-expected.txt: Removed.
        * platform/chromium-mac/media/video-source-expected.txt: Removed.
        * platform/chromium-mac/media/video-source-type-expected.txt: Removed.
        * platform/chromium-mac/media/video-source-type-params-expected.txt: Removed.
        * platform/chromium-mac/media/video-src-change-expected.txt: Removed.
        * platform/chromium-mac/media/video-src-expected.txt: Removed.
        * platform/chromium-mac/media/video-src-remove-expected.txt: Removed.
        * platform/chromium-mac/media/video-src-set-expected.txt: Removed.
        * platform/chromium-mac/media/video-src-source-expected.txt: Removed.
        * platform/chromium-win/media/controls-right-click-on-timebar-expected.txt: Removed.
        * platform/chromium-win/media/media-startTime-expected.txt: Removed.
        * platform/chromium-win/media/video-append-source-expected.txt: Removed.
        * platform/chromium-win/media/video-canvas-source-expected.txt: Removed.
        * platform/chromium-win/media/video-dom-src-expected.txt: Removed.
        * platform/chromium-win/media/video-load-networkState-expected.txt: Removed.
        * platform/chromium-win/media/video-played-reset-expected.txt: Removed.
        * platform/chromium-win/media/video-seek-past-end-paused-expected.txt: Removed.
        * platform/chromium-win/media/video-seek-past-end-playing-expected.txt: Removed.
        * platform/chromium-win/media/video-source-add-src-expected.txt: Removed.
        * platform/chromium-win/media/video-source-error-expected.txt: Removed.
        * platform/chromium-win/media/video-source-expected.txt: Removed.
        * platform/chromium-win/media/video-source-type-expected.txt: Removed.
        * platform/chromium-win/media/video-source-type-params-expected.txt: Removed.
        * platform/chromium-win/media/video-src-change-expected.txt: Removed.
        * platform/chromium-win/media/video-src-expected.txt: Removed.
        * platform/chromium-win/media/video-src-remove-expected.txt: Removed.
        * platform/chromium-win/media/video-src-set-expected.txt: Removed.
        * platform/chromium-win/media/video-src-source-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Qi Zhang <qi.2.zhang@nokia.com>
commit-queue@webkit.org [Tue, 8 Feb 2011 05:37:00 +0000 (05:37 +0000)]
2011-02-07  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
        https://bugs.webkit.org/show_bug.cgi?id=52974

        Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        (WebCore::ContextMenuController::populate):
        (WebCore::ContextMenuController::checkOrEnableIfNeeded):
        * platform/ContextMenuItem.h:
        * platform/LocalizationStrategy.h:
        * platform/LocalizedStrings.cpp:
        (WebCore::contextMenuItemTagCopyImageUrlToClipboard):
        * platform/LocalizedStrings.h:
2011-02-07  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
        https://bugs.webkit.org/show_bug.cgi?id=52974

        Add QWebPage::CopyImageUrlToClipboard into QWebPage::WebAction.

        * Api/qwebpage.cpp:
        (webActionForContextMenuAction):
        (QWebPage::triggerAction):
        (QWebPage::action):
        * Api/qwebpage.h:
        * WebCoreSupport/WebPlatformStrategies.cpp:
        (WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
        * WebCoreSupport/WebPlatformStrategies.h:
2011-02-07  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] enum QWebPage::WebAction doesn't have value QWebPage::CopyImageUrl
        https://bugs.webkit.org/show_bug.cgi?id=52974

        Add ContextMenuItemTagCopyImageUrlToClipboard into standard action but Qt platform specific.

        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
        (WebKit::WebPlatformStrategies::contextMenuItemTagCopyImageUrlToClipboard):
        * WebProcess/WebCoreSupport/WebPlatformStrategies.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Kenichi Ishibashi <bashi@chromium.org>
tkent@chromium.org [Tue, 8 Feb 2011 05:28:19 +0000 (05:28 +0000)]
2011-02-07  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
        https://bugs.webkit.org/show_bug.cgi?id=53970

        Adds HTMLObjectElement::virtualForm() to make HTMLObjectElement::form()
        return the right value.

        Test: fast/dom/HTMLObjectElement/form/nested-form-element.html

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::virtualForm): Added.
        * html/HTMLObjectElement.h: Added virtualForm().

2011-02-07  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        HTMLFormElement::formElementIndex() returns a bad index into a vector of form associated elements
        https://bugs.webkit.org/show_bug.cgi?id=53970

        Adds a test that ensures WebKit parses successfully a page that
        contains object elements which are in nested and defective form
        elements.

        * fast/dom/HTMLObjectElement/form/nested-form-element-expected.txt: Added.
        * fast/dom/HTMLObjectElement/form/nested-form-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 8 Feb 2011 04:39:03 +0000 (04:39 +0000)]
2011-02-07  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove Leopard Debug as a core builder
        https://bugs.webkit.org/show_bug.cgi?id=53971

        The Leopard Debug builder has been failing to compile for several days.
        My understanding is that folks are working on fixing the build, but for
        the time being we should probably remove it from the list of core
        builders so that the core waterfall can be green.  We can certainly add
        it back once the build is fixed.

        Also, I've removed the Tiger builders because those no longer appear to
        be attached to the buildbot master.

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-01 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 8 Feb 2011 04:29:50 +0000 (04:29 +0000)]
2011-02-01  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Roben.

        include svn revisions in git diffs for the code review tool to use
        https://bugs.webkit.org/show_bug.cgi?id=53569

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
2011-02-01  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Roben.

        include svn revisions in git diffs for the code review tool to use
        https://bugs.webkit.org/show_bug.cgi?id=53569

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 8 Feb 2011 04:27:37 +0000 (04:27 +0000)]
2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Leopard build fix.

        * WebCore.xcodeproj/project.pbxproj: let XCode have developmentRegion.
        * platform/mac/DragImageMac.mm:
        (WebCore::webkit_CGCeiling): Cast the return value of ceil to CGFloat.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 8 Feb 2011 04:21:27 +0000 (04:21 +0000)]
2011-02-07  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed attempt to fix a flaky test.
        https://bugs.webkit.org/show_bug.cgi?id=51757

        * fast/css/font-face-download-error.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 04:07:15 +0000 (04:07 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 James Robinson <jamesr@chromium.org>
jamesr@google.com [Tue, 8 Feb 2011 03:55:13 +0000 (03:55 +0000)]
2011-02-07  James Robinson  <jamesr@chromium.org>

        Reviewed by Dan Bernstein.

        Move the sputnik test suite out of fast/js/
        https://bugs.webkit.org/show_bug.cgi?id=53954

        The sputnik suite shouldn't go in fast/js/ because it is not fast and
        it is an imported test suite.  This moves it to LayoutTests/sputnik
        and updates references in skipped lists / expectations.

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac-tiger/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixing the change log entry.
rniwa@webkit.org [Tue, 8 Feb 2011 03:37:50 +0000 (03:37 +0000)]
Fixing the change log entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Geoffrey Garen <ggaren@apple.com>
rniwa@webkit.org [Tue, 8 Feb 2011 03:34:41 +0000 (03:34 +0000)]
2011-02-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Removed some dead code from Heap
        https://bugs.webkit.org/show_bug.cgi?id=53969

        SunSpider reports no change.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::shrink):
        (JSC::MarkedSpace::sweep):
        * runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and
        renamed shrinkBlocks to shrink, making it unconditionally shrink as
        much as possible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Fixing a build break on Mac caused by http://trac.webkit.org/changese...
enrica@apple.com [Tue, 8 Feb 2011 03:13:31 +0000 (03:13 +0000)]
Source/WebCore: Fixing a build break on Mac caused by trac.webkit.org/changeset/77874

Reviewed by Sam Weinig.

When moving code from WebKit to WebCore we needed to move some additional
functions previously in NSStringExtras.

* WebCore.xcodeproj/project.pbxproj:
* platform/mac/DragImageMac.mm:
(WebCore::fontFromNSFont):
(WebCore::canUseFastRenderer):
(WebCore::widthWithFont):
(WebCore::webkit_CGCeiling):
(WebCore::drawAtPoint):
(WebCore::drawDoubledAtPoint):
(WebCore::createDragImageForLink):

Source/WebKit2: Fixing a build break on Mac caused by http://trac.webkit.org/changeset/77874

Reviewed by Sam Weinig.

Removed unused static function.

* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 8 Feb 2011 03:08:59 +0000 (03:08 +0000)]
2011-02-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Removed some dead code from Heap
        https://bugs.webkit.org/show_bug.cgi?id=53969

        SunSpider reports no change.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::shrink):
        (JSC::MarkedSpace::sweep):
        * runtime/MarkedSpace.h: Removed resizeBlocks and growBlocks, and
        renamed shrinkBlocks to shrink, making it unconditionally shrink as
        much as possible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8969888>
andersca@apple.com [Tue, 8 Feb 2011 02:21:37 +0000 (02:21 +0000)]
<rdar://problem/8969888>
The WebProcess should set LSFileQuarantineEnabled to true

Reviewed by Sam Weinig.

* WebProcess/Info.plist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 02:13:24 +0000 (02:13 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Lucas Forschler <lforschler@apple.com>
lforschler@apple.com [Tue, 8 Feb 2011 02:04:37 +0000 (02:04 +0000)]
2011-02-07  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Geoff Garen.

        Tr #2, Fix the Leopard 32bit debug build.

        No new tests required.

        * WebCore.xcodeproj/project.pbxproj:
        * accessibility/AccessibilityAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Tue, 8 Feb 2011 01:58:19 +0000 (01:58 +0000)]
2011-02-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Simplified the marked space's mark invariant
        https://bugs.webkit.org/show_bug.cgi?id=53968

        SunSpider reports no change.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::allocate): Mark objects when allocating them. This
        means that, at all times other than the mark phase, an object is live
        if and only if it is marked.

        (JSC::MarkedSpace::containsSlowCase): Use the new mark invariant to
        simplify testing whether an object is live.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for <rdar://problem/8946961> Fix repaint problems
bdakin@apple.com [Tue, 8 Feb 2011 01:53:58 +0000 (01:53 +0000)]
Fix for <rdar://problem/8946961> Fix repaint problems
with WKScrollbarPainter scrollers while resizing the window

Reviewed by Sam Weinig.

Remove setPainterForPainterController() and
removePainterFromPainterController() since they aren't
used anymore.
* platform/mac/ScrollAnimatorMac.h:

Return early if they alpha hasn't changed.
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
(-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):

If we're in a live resize, restore alpha to 1.
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 8 Feb 2011 01:47:41 +0000 (01:47 +0000)]
2011-02-03  MORITA Hajime  <morrita@google.com>

        Reviewed by Darin Fisher.

        [Chromium] Should implement EditorClientImpl::requestCheckingOfString()
        https://bugs.webkit.org/show_bug.cgi?id=51013

        Unskipped passed test.

        * platform/chromium/test_expectations.txt:
2011-02-03  MORITA Hajime  <morrita@google.com>

        Reviewed by Darin Fisher.

        [Chromium] Should implement EditorClientImpl::requestCheckingOfString()
        https://bugs.webkit.org/show_bug.cgi?id=51013

        - Added WebTextCheckingCompletion to receive the checked result asynchronously.
        - Added WebViewClient::requestCheckingOfText() and related classes.
        - Implemented EditorClientImpl::requestCheckingOfString().

        * WebKit.gyp:
        * public/WebSettings.h:
        * public/WebTextCheckingCompletion.h: Added.
        (WebKit::WebTextCheckingCompletion::~WebTextCheckingCompletion):
        * public/WebTextCheckingResult.h: Added.
        (WebKit::WebTextCheckingResult::error):
        (WebKit::WebTextCheckingResult::position):
        (WebKit::WebTextCheckingResult::length):
        (WebKit::WebTextCheckingResult::WebTextCheckingResult):
        * public/WebViewClient.h:
        (WebKit::WebViewClient::requestCheckingOfText): Gave an implementation
        * src/AssertMatchingEnums.cpp:
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::requestCheckingOfString):
        * src/EditorClientImpl.h:
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setAsynchronousSpellCheckingEnabled):
        * src/WebSettingsImpl.h:
        * src/WebTextCheckingCompletionImpl.cpp: Added.
        (WebKit::toCoreResults):
        (WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
        * src/WebTextCheckingCompletionImpl.h: Added.
        (WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
2011-02-03  MORITA Hajime  <morrita@google.com>

        Reviewed by Darin Fisher.

        [Chromium] Should implement EditorClientImpl::requestCheckingOfString()
        https://bugs.webkit.org/show_bug.cgi?id=51013

        Gave DRT implementation for requestTextCheck().

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented.
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (invokeFinishLastTextCheck): Added.
        (WebViewHost::requestTextCheck): Added.
        (WebViewHost::finishLastTextCheck): Added.
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 8 Feb 2011 01:44:49 +0000 (01:44 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Crash in web process after the connection had been closed
        https://bugs.webkit.org/show_bug.cgi?id=51115
        <rdar://problem/8964255>

        Remove didCloseOnConnectionWorkQueue from Connection::Client and add
        Connection::setDidCloseOnConnectionWorkQueueCallback which takes a static
        function, eliminating the race condition in connectionDidClose where m_client could be
        nulled out in the client thread right before we try to dereference it.

        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::Connection):
        Initialize m_didCloseOnConnectionWorkQueueCallback.

        (CoreIPC::Connection::setDidCloseOnConnectionWorkQueueCallback):
        Update m_didCloseOnConnectionWorkQueueCallback.

        (CoreIPC::Connection::connectionDidClose):
        Call m_didCloseOnConnectionWorkQueueCallback.

        * Platform/WorkQueue.h:
        Make WorkQueue noncopyable.

        * PluginProcess/PluginProcess.cpp:
        (WebKit::PluginProcess::initializeConnection):
        Call setDidCloseOnConnectionWorkQueueCallback.

        * Shared/ChildProcess.cpp:
        (WebKit::ChildProcess::didCloseOnConnectionWorkQueue):
        * Shared/ChildProcess.h:
        didCloseOnConnectionWorkQueue is now a static member function.

        * WebProcess/WebProcess.cpp:
        (WebKit::WebProcess::initialize):
        Call setDidCloseOnConnectionWorkQueueCallback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Tue, 8 Feb 2011 01:39:06 +0000 (01:39 +0000)]
2011-02-07  Martin Robinson  <mrobinson@igalia.com>

        Classify tests failing in the fast directory on GTK+. Add results for
        tests that just need platform expectations.

        * platform/gtk/Skipped: Update the skipped list.
        * platform/gtk/fast/backgrounds/background-clip-text-expected.checksum: Added.
        * platform/gtk/fast/backgrounds/background-clip-text-expected.png: Added.
        * platform/gtk/fast/backgrounds/background-clip-text-expected.txt: Added.
        * platform/gtk/fast/canvas/canvas-zoom-expected.txt: Added.
        * platform/gtk/fast/css/css1_forward_compatible_parsing-expected.checksum: Added.
        * platform/gtk/fast/css/css1_forward_compatible_parsing-expected.png: Added.
        * platform/gtk/fast/css/css1_forward_compatible_parsing-expected.txt: Added.
        * platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
        * platform/gtk/fast/css/invalid-percentage-property-expected.checksum: Added.
        * platform/gtk/fast/css/invalid-percentage-property-expected.png: Added.
        * platform/gtk/fast/css/invalid-percentage-property-expected.txt: Added.
        * platform/gtk/fast/css/text-align-expected.checksum: Added.
        * platform/gtk/fast/css/text-align-expected.png: Added.
        * platform/gtk/fast/css/text-align-expected.txt: Added.
        * platform/gtk/fast/dom/Element/getBoundingClientRect-expected.txt: Added.
        * platform/gtk/fast/dom/Range/getBoundingClientRect-expected.txt: Added.
        * platform/gtk/fast/dom/Range/getClientRects-expected.txt: Added.
        * platform/gtk/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
        * platform/gtk/fast/dom/null-document-location-put-crash-expected.txt: Added.
        * platform/gtk/fast/dom/tabindex-clamp-expected.txt: Added.
        * platform/gtk/fast/events/js-keyboard-event-creation-expected.txt: Added.
        * platform/gtk/fast/events/offsetX-offsetY-expected.txt: Added.
        * platform/gtk/fast/events/pointer-events-2-expected.checksum: Added.
        * platform/gtk/fast/events/pointer-events-2-expected.png: Added.
        * platform/gtk/fast/events/pointer-events-2-expected.txt: Added.
        * platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.checksum: Added.
        * platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.png: Added.
        * platform/gtk/fast/fast-mobile-scrolling/fixed-position-element-expected.txt: Added.
        * platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.checksum: Added.
        * platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png: Added.
        * platform/gtk/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.txt: Added.
        * platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.checksum: Added.
        * platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.png: Added.
        * platform/gtk/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
        * platform/gtk/fast/html/tab-order-expected.txt: Added.
        * platform/gtk/fast/replaced/table-percent-height-expected.txt: Added.
        * platform/gtk/fast/selectors/lang-inheritance-expected.checksum: Added.
        * platform/gtk/fast/selectors/lang-inheritance-expected.png: Added.
        * platform/gtk/fast/selectors/lang-inheritance-expected.txt: Added.
        * platform/gtk/fast/selectors/lang-inheritance2-expected.checksum: Added.
        * platform/gtk/fast/selectors/lang-inheritance2-expected.png: Added.
        * platform/gtk/fast/selectors/lang-inheritance2-expected.txt: Added.
        * platform/gtk/fast/selectors/lang-vs-xml-lang-expected.checksum: Added.
        * platform/gtk/fast/selectors/lang-vs-xml-lang-expected.png: Added.
        * platform/gtk/fast/selectors/lang-vs-xml-lang-expected.txt: Added.
        * platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.checksum: Added.
        * platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.png: Added.
        * platform/gtk/fast/selectors/lang-vs-xml-lang-xhtml-expected.txt: Added.
        * platform/gtk/fast/text/international/danda-space-expected.checksum: Added.
        * platform/gtk/fast/text/international/danda-space-expected.png: Added.
        * platform/gtk/fast/text/international/danda-space-expected.txt: Added.
        * platform/gtk/fast/text/international/thai-baht-space-expected.checksum: Added.
        * platform/gtk/fast/text/international/thai-baht-space-expected.png: Added.
        * platform/gtk/fast/text/international/thai-baht-space-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 01:38:15 +0000 (01:38 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=53950
bdakin@apple.com [Tue, 8 Feb 2011 01:35:42 +0000 (01:35 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=53950
USE_WK_SCROLLBAR_PAINTER in ScrollbarThemeMac should be in
Platform.h instead

Reviewed by Eric Seidel.

../JavaScriptCore:

* wtf/Platform.h:

../WebCore:

Use hot new USE(WK_SCROLLBAR_PAINTER) from Platform.h rather
than the silly, old in-file #define.

* platform/mac/ScrollbarThemeMac.mm:
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed Adam Roben and Darin Adler.
enrica@apple.com [Tue, 8 Feb 2011 01:34:24 +0000 (01:34 +0000)]
Reviewed Adam Roben and Darin Adler.

Source/WebCore:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>

* loader/EmptyClients.h: Removed createDragImageFromLink.
* page/DragClient.h: Ditto.
* page/DragController.cpp:
(WebCore::DragController::startDrag): changed call to createDragImageFromLink.
* platform/DragImage.h:
* platform/mac/DragImageMac.mm:
(WebCore::createDragImageForLink): Moved from DragClient.
* platform/win/ClipboardUtilitiesWin.cpp: Added a series of functions
to de-serialize the drag data from the map into an IDataObject.
(WebCore::getWebLocData):
(WebCore::texthtmlFormat):
(WebCore::createGlobalData):
(WebCore::getFullCFHTML):
(WebCore::urlWFormat):
(WebCore::urlFormat):
(WebCore::filenameWFormat):
(WebCore::filenameFormat):
(WebCore::htmlFormat):
(WebCore::smartPasteFormat):
(WebCore::getURL):
(WebCore::getPlainText):
(WebCore::getTextHTML):
(WebCore::ClipboardDataItem::ClipboardDataItem):
(WebCore::getStringData):
(WebCore::getUtf8Data):
(WebCore::getCFData):
(WebCore::setUCharData):
(WebCore::setCharData):
(WebCore::setCFData):
(WebCore::getClipboardMap):
(WebCore::getClipboardData):
(WebCore::setClipboardData):
* platform/win/ClipboardUtilitiesWin.h:
* platform/win/DragImageWin.cpp: Moved createDragImageForLink from DragClient
to a platform specific file in WebCore. It makes a lot more sense here, since
the drag image is always created in WebCore for all the other content types
except for links.
(WebCore::dragLabelFont):
(WebCore::createDragImageForLink):
* platform/win/WCDataObject.cpp: Added new way to
construct a WCDataObject from a DragDataMap.
(WebCore::WCDataObject::createInstance):
(WebCore::WCDataObject::clearData):
* platform/win/WCDataObject.h:

Source/WebKit/chromium:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

* src/DragClientImpl.cpp:
* src/DragClientImpl.h:

Source/WebKit/efl:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

* WebCoreSupport/DragClientEfl.cpp:
* WebCoreSupport/DragClientEfl.h:

Source/WebKit/gtk:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

* WebCoreSupport/DragClientGtk.cpp:
* WebCoreSupport/DragClientGtk.h:

Source/WebKit/haiku:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

* WebCoreSupport/DragClientHaiku.cpp:
* WebCoreSupport/DragClientHaiku.h:

Source/WebKit/mac:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

* WebCoreSupport/WebDragClient.h:
* WebCoreSupport/WebDragClient.mm:
(WebDragClient::startDrag):

Source/WebKit/qt:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

* WebCoreSupport/DragClientQt.cpp:
* WebCoreSupport/DragClientQt.h:

Source/WebKit/win:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

* WebCoreSupport/WebDragClient.cpp:
(WebDragClient::startDrag):
* WebCoreSupport/WebDragClient.h:

Source/WebKit/wince:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

* WebCoreSupport/DragClientWinCE.cpp:
* WebCoreSupport/DragClientWinCE.h:

Source/WebKit/wx:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775

Removed createDragImageForLink from DragClient.

* WebKitSupport/DragClientWx.cpp:
* WebKitSupport/DragClientWx.h:

Source/WebKit2:

WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
<rdar://problem/8514409>

This patch contains the remaining work to support
a WebKit window as drag source on Windows.
I've added the code to generate the image for dragging a link as
well as the steps necessary to package the HBITMAP into a SharedMemory
object and send it over to the UI process where DoDragDrop is performed.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::startDragDrop):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::startDrag): Made startDrag for
platforms other than Windows and Mac.
* WebProcess/WebCoreSupport/WebDragClient.h:
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag):
* WebProcess/WebCoreSupport/win/WebDragClientWin.cpp: Added.
(WebKit::draggingSourceOperationMaskToDragCursors):
(WebKit::WebDragClient::startDrag):
* WebProcess/WebCoreSupport/win/WebDragSource.cpp: Added.
This object implements the IDropSource interface.
(WebDragSource::createInstance):
(WebDragSource::WebDragSource):
(WebDragSource::QueryInterface):
(WebDragSource::AddRef):
(WebDragSource::Release):
(WebDragSource::QueryContinueDrag):
(WebDragSource::GiveFeedback):
* WebProcess/WebCoreSupport/win/WebDragSource.h: Added.
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 01:32:43 +0000 (01:32 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Joone Hur <joone.hur@collabora.co.uk>
joone.hur@collabora.co.uk [Tue, 8 Feb 2011 01:23:29 +0000 (01:23 +0000)]
2011-02-07  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [Gtk] Implement layoutTestController.findString
        https://bugs.webkit.org/show_bug.cgi?id=50237

        Unskip editing/text-iterator/findString.html.

        * platform/gtk/Skipped: Unskip findString test.
2011-02-07  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [Gtk] Implement layoutTestController.findString
        https://bugs.webkit.org/show_bug.cgi?id=50237

        * GNUmakefile.am: Add AssertMatchingEnums.cpp.
        * WebCoreSupport/AssertMatchingEnums.cpp: Add this file to assert that various
        WebKit API enum values continue matching WebCore defined enum values.
        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::findString):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-02-07  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [Gtk] Implement layoutTestController.findString
        https://bugs.webkit.org/show_bug.cgi?id=50237

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::findString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 8 Feb 2011 01:02:02 +0000 (01:02 +0000)]
2011-02-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77848.
        http://trac.webkit.org/changeset/77848
        https://bugs.webkit.org/show_bug.cgi?id=53963

        caused 6 test failures (Requested by othermaciej on #webkit).

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 8 Feb 2011 01:00:35 +0000 (01:00 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        UI process crashes if web process crashes while web inspector is focused
        https://bugs.webkit.org/show_bug.cgi?id=53965
        <rdar://problem/8961633>

        Make sure to close the web inspector web page proxy before calling platformClose, since
        platformClose can cause the web page proxy to try to send messages (such as SetActive)
        to the web process while it's in a bad state.

        * UIProcess/WebInspectorProxy.cpp:
        (WebKit::WebInspectorProxy::didClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-04 Kenneth Russell <kbr@google.com>
kbr@google.com [Tue, 8 Feb 2011 00:57:44 +0000 (00:57 +0000)]
2011-02-04  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Add shaders for GPU accelerated path rendering
        https://bugs.webkit.org/show_bug.cgi?id=45520

        Refactored SolidFillShader and TexShader to call new
        generateVertex() and generateFragment() methods on base Shader
        class, and added support for the Loop/Blinn shaders. Refactored
        Loop/Blinn shader classes to derive from Shader.

        Tested these changes with several of the IE9 Testdrive demos with
        accelerated 2D canvas enabled, as well as a full layout test run
        with --platform chromium-gpu.

        * platform/graphics/gpu/LoopBlinnShader.cpp: Added.
        (WebCore::LoopBlinnShader::LoopBlinnShader):
        (WebCore::LoopBlinnShader::use):
        * platform/graphics/gpu/LoopBlinnShader.h: Added.
        * platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: Added.
        (WebCore::LoopBlinnSolidFillShader::create):
        (WebCore::LoopBlinnSolidFillShader::LoopBlinnSolidFillShader):
        (WebCore::LoopBlinnSolidFillShader::use):
        * platform/graphics/gpu/LoopBlinnSolidFillShader.h: Added.
        * platform/graphics/gpu/Shader.cpp:
        (WebCore::Shader::affineTo4x4):
        (WebCore::Shader::loadShader):
        (WebCore::Shader::loadProgram):
        (WebCore::Shader::generateVertex):
        (WebCore::Shader::generateFragment):
        * platform/graphics/gpu/Shader.h:
        * platform/graphics/gpu/SolidFillShader.cpp:
        (WebCore::SolidFillShader::create):
        * platform/graphics/gpu/TexShader.cpp:
        (WebCore::TexShader::TexShader):
        (WebCore::TexShader::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 8 Feb 2011 00:51:58 +0000 (00:51 +0000)]
2011-02-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        Skip a newly added test that uses unimplemented DRT functionality
        https://bugs.webkit.org/show_bug.cgi?id=53938

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 00:30:21 +0000 (00:30 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, rebaseline.

        * platform/chromium-linux/fast/html/keygen-expected.checksum:
* platform/chromium-linux/fast/html/keygen-expected.png:
        * platform/chromium-linux/fast/html/keygen-expected.txt: Added.
        * platform/chromium-win/fast/html/keygen-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 8 Feb 2011 00:29:23 +0000 (00:29 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Find bouncy is missing content on pages with framesets
        https://bugs.webkit.org/show_bug.cgi?id=53958
        <rdar://problem/8904447>

        Fix paint rect computation; FrameView::paint expects the paint rect to be in the
        parent widget's coordinate system.

        * WebProcess/WebPage/FindController.cpp:
        (WebKit::FindController::updateFindIndicator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8960434> and https://bugs.webkit.org/show_bug.cgi?id=53957
beidson@apple.com [Tue, 8 Feb 2011 00:22:47 +0000 (00:22 +0000)]
<rdar://problem/8960434> and https://bugs.webkit.org/show_bug.cgi?id=53957
Crash after incorrectly restoring bogus session state.

Reviewed by Anders Carlsson.

In some cases we're writing an invalid session state for a back/forward list where the current entry is 0
but the number of entries is also 0.
In such cases the current entry should be "NoCurrentEntryIndex."

When we later read this state in, we set ourselves up to crash later.

Amusingly an ASSERT caught this, but we should've rejected it before the ASSERT fired.

* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation): Fail the restore if the "current index past the end
  of the list" case occurs, and speculatively bail out of the case where we have no current index but do have a list.
  Also remove the unhelpful ASSERT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 00:22:13 +0000 (00:22 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 00:11:15 +0000 (00:11 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8946023> REGRESSION (r76674): SVG + BiDi text broken (text-intro...
mitz@apple.com [Tue, 8 Feb 2011 00:07:31 +0000 (00:07 +0000)]
<rdar://problem/8946023> REGRESSION (r76674): SVG + BiDi text broken (text-intro-05-t.svg)
https://bugs.webkit.org/show_bug.cgi?id=53480

Reviewed by Oliver Hunt.

* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): m_indexEnd should be an
offset into m_characters, not into the run’s characters.
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Tue, 8 Feb 2011 00:01:28 +0000 (00:01 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd bundle API to get the background color of a frame
weinig@apple.com [Mon, 7 Feb 2011 23:46:18 +0000 (23:46 +0000)]
Add bundle API to get the background color of a frame
<rdar://problem/8962670>
https://bugs.webkit.org/show_bug.cgi?id=53952

Reviewed by Anders Carlsson.

../WebCore:

* WebCore.exp.in: Add export.

../WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetBodyBackgroundColor):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
Add API function.

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::getDocumentBackgroundColor):
* WebProcess/WebPage/WebFrame.h:
Call down into the document to get either the body's, or if there is no body,
the root element's, background color.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 7 Feb 2011 23:45:58 +0000 (23:45 +0000)]
Unreviewed.

[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912

* platform/qt/Skipped: http/tests/websocket/tests/websocket-pending-activity.html added until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Mon, 7 Feb 2011 23:41:37 +0000 (23:41 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, rebaseline.

        * platform/chromium-mac/fast/url/path-expected.txt:
* platform/chromium-win/fast/url/path-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 7 Feb 2011 23:37:23 +0000 (23:37 +0000)]
2011-02-07  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Assertion failure in ~JSGlobalObject when loading apple.com HTML5
        transitions demo page
        https://bugs.webkit.org/show_bug.cgi?id=53853

        This was a long-standing bookkeeping bug uncovered by some heap refactoring.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::createImageBuffer):
        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::notifyFinished):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::dropProtection): Take the JSLock before
        reporting extra cost to the JavaScriptCore heap, since all use of
        JavaScriptCore is supposed to be guarded by JSLock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIntermittent crash in fast/files/read-blob-async.html on the GTK+ debug
jianli@chromium.org [Mon, 7 Feb 2011 23:28:35 +0000 (23:28 +0000)]
Intermittent crash in fast/files/read-blob-async.html on the GTK+ debug
bots
https://bugs.webkit.org/show_bug.cgi?id=53104

Reviewed by David Levin.

Source/WebCore:

Covered by the existing tests.

* fileapi/FileStreamProxy.cpp:
(WebCore::FileStreamProxy::startOnFileThread):
* platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::createResourceHandle):
* platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::BlobResourceHandle):
(WebCore::BlobResourceHandle::cancel):
(WebCore::delayedStartBlobResourceHandle):
(WebCore::BlobResourceHandle::start): Keep BlobResourceHandle alive
till the delay function is called.
(WebCore::BlobResourceHandle::doStart):
(WebCore::doNotifyFinish):
(WebCore::BlobResourceHandle::notifyFinish): Notify the client via the
standalone function to prevent the handle from being disposed immediately
by the client which will make the calls in the stack that're still bound
to the handle suffer.
* platform/network/BlobResourceHandle.h:
* platform/network/ResourceHandle.h: Change cancel() to virtual so that
BlobResourceHandle::cancel will be called when we abort a FileReader.

LayoutTests:

* platform/gtk/Skipped: Enable the flakey test that has been fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 7 Feb 2011 23:27:27 +0000 (23:27 +0000)]
2011-02-07  Adam Barth  <abarth@webkit.org>

        Remove wrong platform-specific expectation.

        * platform/win/plugins/plugin-document-back-forward-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 7 Feb 2011 23:09:22 +0000 (23:09 +0000)]
2011-02-07  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r77845.
        http://trac.webkit.org/changeset/77845
        https://bugs.webkit.org/show_bug.cgi?id=53946

        build failure (Requested by lforschler_ on #webkit).

        * WebCore.xcodeproj/project.pbxproj:
        * accessibility/AccessibilityAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=53939
darin@apple.com [Mon, 7 Feb 2011 23:05:53 +0000 (23:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=53939
fast/css/text-overflow-ellipsis.html failure after r77818/77819

* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerExtendedEncodingNames):
Add back the "utf8" synonym for "UTF-8".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove an unnecessary extra computeLogicalWidth() from line layout.
hyatt@apple.com [Mon, 7 Feb 2011 22:58:53 +0000 (22:58 +0000)]
Remove an unnecessary extra computeLogicalWidth() from line layout.

Reviewed by Dan Bernstein.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix typo. vectical -> vertical.
weinig@apple.com [Mon, 7 Feb 2011 22:34:38 +0000 (22:34 +0000)]
Fix typo. vectical -> vertical.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInform the UIProcess when main frame scrollbars change
weinig@apple.com [Mon, 7 Feb 2011 22:32:14 +0000 (22:32 +0000)]
Inform the UIProcess when main frame scrollbars change
<rdar://problem/8967496>
https://bugs.webkit.org/show_bug.cgi?id=53941

Reviewed by Anders Carlsson.

* UIProcess/API/C/WKPage.cpp:
(WKPageHasHorizontalScrollbar):
(WKPageHasVerticalScrollbar):
* UIProcess/API/C/WKPage.h:
Add API to query whether the main frame has scrollbars.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::hasHorizontalScrollbar):
(WebKit::WebPageProxy::hasVerticalScrollbar):
Store/update main frame scrollbar state.

* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::contentsSizeChanged):
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::WebChromeClient):
Post message when main frame scrollbar state changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Lucas Forschler <lforschler@apple.com>
lforschler@apple.com [Mon, 7 Feb 2011 22:28:45 +0000 (22:28 +0000)]
2011-02-07  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Geoffrey Garen.

        Fix Leopard Intel Debug Build.
        <rdar://problem/8953606> REGRESSION: Can't link WebCore on 32-bit Leopard (53681)
        This could potentially break windows, since I had to change #include <filename> to #include "filename"

        * WebCore.xcodeproj/project.pbxproj:
        * accessibility/AccessibilityAllInOne.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Mon, 7 Feb 2011 21:54:50 +0000 (21:54 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
weinig@apple.com [Mon, 7 Feb 2011 21:48:28 +0000 (21:48 +0000)]
Fix build.

* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 7 Feb 2011 21:42:08 +0000 (21:42 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Some content is not covered by Find-on-page overlay
        https://bugs.webkit.org/show_bug.cgi?id=53937
        <rdar://problem/8711353>

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::didInstallPageOverlay):
        Call LayerTreeHost::didInstallPageOverlay.

        (WebKit::DrawingAreaImpl::didUninstallPageOverlay):
        Call LayerTreeHost::didUninstallPageOverlay.

        (WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
        Call LayerTreeHost::setPageOverlayNeedsDisplay.

        * WebProcess/WebPage/FindController.cpp:
        (WebKit::FindController::drawRect):
        Remove a bogus assertion.

        * WebProcess/WebPage/LayerTreeHost.h:
        Add new pure virtual member functions.

        * WebProcess/WebPage/PageOverlay.cpp:
        (WebKit::PageOverlay::setNeedsDisplay):
        Call DrawingArea::setPageOverlayNeedsDisplay.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::installPageOverlay):
        Make sure to call PageOverlay::setNeedsDisplay after the page overlay has been installed.

        * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
        (WebKit::LayerTreeHostMac::LayerTreeHostMac):
        Create the page overlay layer if needed.

        (WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
        Invalidate the page overlay layer as well.

        (WebKit::LayerTreeHostMac::sizeDidChange):
        Resize the page overlay layer.

        (WebKit::LayerTreeHostMac::didInstallPageOverlay):
        Create the page overlay layer.

        (WebKit::LayerTreeHostMac::didUninstallPageOverlay):
        Destroy the page overlay layer.

        (WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
        Call setNeedsDisplay on the page overlay layer.

        (WebKit::LayerTreeHostMac::paintContents):
        Handle painting the page overlay layer.

        (WebKit::LayerTreeHostMac::flushPendingLayerChanges):
        Flush the page overlay layer changes as well.

        (WebKit::LayerTreeHostMac::createPageOverlayLayer):
        Create a layer and add it as a sublayer of the root layer.

        (WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
        Destroy the page overlay layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd mechanism to inform the ScrollAnimator when Scrollbars are added
weinig@apple.com [Mon, 7 Feb 2011 21:29:12 +0000 (21:29 +0000)]
Add mechanism to inform the ScrollAnimator when Scrollbars are added
and removed.

Reviewed by Beth Dakin.

* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::didAddVerticalScrollbar):
(WebCore::ScrollAnimator::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimator::didAddHorizontalScrollbar):
(WebCore::ScrollAnimator::willRemoveHorizontalScrollbar):
Make virtual to allow platform specific overrides.

* platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
Call new ScrollableArea functions.

* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::didAddVerticalScrollbar):
(WebCore::ScrollableArea::willRemoveVerticalScrollbar):
(WebCore::ScrollableArea::didAddHorizontalScrollbar):
(WebCore::ScrollableArea::willRemoveHorizontalScrollbar):
* platform/ScrollableArea.h:
Pipe to ScrollAnimator.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::painterForScrollbar):
Move painter delegate registration to the new didAdd/willRemove functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Zhenyao Mo <zmo@google.com>
zmo@google.com [Mon, 7 Feb 2011 21:25:56 +0000 (21:25 +0000)]
2011-02-07  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake it possible to use DrawingAreaProxyImpl on Windows
aroben@apple.com [Mon, 7 Feb 2011 21:19:54 +0000 (21:19 +0000)]
Make it possible to use DrawingAreaProxyImpl on Windows

It can be optionally turned on by setting the WEBKIT2_USE_NEW_DRAWING_AREA environment
variable. Turning it on by default is covered by <http://webkit.org/b/53805>.

Fixes <http://webkit.org/b/53879>.

Reviewed by Anders Carlsson.

* UIProcess/BackingStore.h: Add an m_bitmap member on Windows.

* UIProcess/win/BackingStoreWin.cpp:
(WebKit::BitmapDC::operator HDC):
(WebKit::BitmapDC::BitmapDC):
(WebKit::BitmapDC::~BitmapDC):
Added this helper class, which uses RAII to select a bitmap into a new memory DC.
(WebKit::BackingStore::paint): Wrap our bitmap in a BitmapDC and use ::BitBlt to copy the
specified rect into the destination DC.
(WebKit::createBitmap): New helper function, just creates a DIB section with the specified
size.
(WebKit::BackingStore::incorporateUpdate): Ported from BackingStoreMac.mm. It seems like
this code could be shared at some point.
(WebKit::BackingStore::scroll): Wrap our bitmap in a BitmapDC and use ::ScrollDC to scroll
the specified rect.

* UIProcess/win/WebView.cpp:
(WebKit::useNewDrawingArea): Added. Returns true if the WEBKIT2_USE_NEW_DRAWING_AREA
environment variable is set.
(WebKit::drawPageBackground): New helper function. Code came from onPaintEvent.
(WebKit::WebView::onPaintEvent): Ported from -[WKView drawRect:].
(WebKit::WebView::createDrawingAreaProxy): Create a DrawingAreaProxyImpl if we're using the
new drawing area.

(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
(WebKit::WebView::pageDidEnterAcceleratedCompositing):
(WebKit::WebView::pageDidLeaveAcceleratedCompositing):
Added some assertions to make sure these are only called when expected. We don't expect
enter/exitAcceleratedCompositingMode to be called at all right now, because accelerated
compositing is turned off in WebKit2 on Windows.

(WebKit::WebView::switchToDrawingAreaTypeIfNecessary): Ditto, and added a case for the
DrawingAreaInfo::Impl constant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStart compiling DrawingArea[Proxy]Impl and dependencies on Windows
aroben@apple.com [Mon, 7 Feb 2011 21:19:20 +0000 (21:19 +0000)]
Start compiling DrawingArea[Proxy]Impl and dependencies on Windows

Fixes <http://webkit.org/b/53875> WebKit2 on Windows should build DrawingArea[Proxy]Impl

Reviewed by Sam Weinig and Darin Adler.

* Platform/Region.cpp:
(WebKit::Region::Shape::shapeOperation): Initialize variable to avoid a bogus "potentially
uninitialized variable" warning.

* UIProcess/BackingStore.cpp: Removed #error for non-Mac platforms.

* UIProcess/BackingStore.h: Added a PlatformGraphicsContext typedef for Windows.

* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxyImpl.cpp:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
Allow Windows to compile the new drawing area code.

* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create): Allow creating a DrawingAreaImpl on Windows, too.

* WebProcess/WebPage/DrawingArea.h:
* WebProcess/WebPage/DrawingAreaImpl.cpp:
* WebProcess/WebPage/LayerTreeHost.cpp:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):
Allow Windows to compile the new drawing area code.

* Shared/win/LayerTreeContextWin.cpp: Added.
* UIProcess/win/BackingStoreWin.cpp: Added.
Stubbed out these files.

* win/WebKit2.vcproj: Added new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 7 Feb 2011 20:57:42 +0000 (20:57 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Rename some drawing area related member functions
        https://bugs.webkit.org/show_bug.cgi?id=53935

        * WebProcess/WebPage/DrawingArea.h:
        (WebKit::DrawingArea::setPageOverlayNeedsDisplay):
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::setNeedsDisplay):
        (WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
        * WebProcess/WebPage/DrawingAreaImpl.h:
        * WebProcess/WebPage/LayerTreeHost.h:
        * WebProcess/WebPage/mac/LayerTreeHostMac.h:
        * WebProcess/WebPage/mac/LayerTreeHostMac.mm:
        (WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
        (WebKit::LayerTreeHostMac::scrollNonCompositedContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Mon, 7 Feb 2011 20:49:31 +0000 (20:49 +0000)]
2011-02-07  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        We should disable spatial navigation explicitly during the initialization
        of DumpRenderTree.
        https://bugs.webkit.org/show_bug.cgi?id=53928

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 7 Feb 2011 20:43:05 +0000 (20:43 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Missing text match markers with accelerated content
        https://bugs.webkit.org/show_bug.cgi?id=53934

        When doing the fake paint that recomputes the text match rects, we need to
        flatten compositing layers, otherwise the rects won't be updated until the next paint call.

        (This worked by accident in WebKit1 because Safari calls -[NSWindow displayIfNeeded] on the containing
        window before asking for the text match rects).

        * editing/Editor.cpp:
        (WebCore::Editor::countMatchesForText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r77740): CSSStyleSelector accessing deleted memory for svg/dom/use-transfo...
antti@apple.com [Mon, 7 Feb 2011 20:08:47 +0000 (20:08 +0000)]
REGRESSION(r77740): CSSStyleSelector accessing deleted memory for svg/dom/use-transform.svg
https://bugs.webkit.org/show_bug.cgi?id=53900

Reviewed by Andreas Kling.

Ignore link elements in shadow trees.

* dom/Element.cpp:
(WebCore::StyleSelectorParentPusher::StyleSelectorParentPusher):
(WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):

    Some asserts to catch cases like this.

(WebCore::Element::attach):
(WebCore::Element::recalcStyle):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::insertedIntoDocument):
(WebCore::HTMLLinkElement::removedFromDocument):
* html/HTMLLinkElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Mon, 7 Feb 2011 19:18:00 +0000 (19:18 +0000)]
2011-02-07  Dimitri Glazkov  <dglazkov@chromium.org>

        Mark test as flaky per dashboard.
        https://bugs.webkit.org/show_bug.cgi?id=53824

        * platform/chromium/test_expectations.txt: Marked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTurn UTF-8 decoder off for now so we can look into failing tests
darin@apple.com [Mon, 7 Feb 2011 18:46:01 +0000 (18:46 +0000)]
Turn UTF-8 decoder off for now so we can look into failing tests
without leaving the tree red.

* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::registerBaseEncodingNames): Reverting
earlier change so this can handle UTF-8.
(WebCore::TextCodecICU::registerBaseCodecs): Ditto.
(WebCore::TextCodecICU::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecICU::registerExtendedCodecs): Ditto.
* platform/text/TextCodecICU.h: Ditto.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::buildBaseTextCodecMaps): Ditto.
(WebCore::extendTextCodecMaps): Ditto.
* platform/text/brew/TextCodecBrew.cpp:
(WebCore::TextCodecBrew::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerBaseCodecs): Ditto.
(WebCore::TextCodecBrew::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecBrew::registerExtendedCodecs): Ditto.
* platform/text/brew/TextCodecBrew.h: Ditto.
* platform/text/gtk/TextCodecGtk.cpp:
(WebCore::TextCodecGtk::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecGtk::registerBaseCodecs): Ditto.
* platform/text/wince/TextCodecWinCE.cpp:
(WebCore::TextCodecWinCE::registerBaseEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerBaseCodecs): Ditto.
(WebCore::TextCodecWinCE::registerExtendedEncodingNames): Ditto.
(WebCore::TextCodecWinCE::registerExtendedCodecs): Ditto.
* platform/text/wince/TextCodecWinCE.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse the right calling convention when calling WebKitMain
aroben@apple.com [Mon, 7 Feb 2011 18:45:32 +0000 (18:45 +0000)]
Use the right calling convention when calling WebKitMain

Fixes <http://webkit.org/b/53923> REGRESSION (r77678): Crash on quit in web process in
wWinMain

Reviewed by Steve Falkenburg.

* win/MainWin.cpp:
(wWinMain): Use __cdecl instead of WINAPI (__stdcall) when calling WebKitMain, since that is
how that function is declared.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 7 Feb 2011 18:39:24 +0000 (18:39 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        The drawing area should be in charge of drawing the page overlay
        https://bugs.webkit.org/show_bug.cgi?id=53927

        * WebProcess/WebPage/DrawingArea.h:
        (WebKit::DrawingArea::didInstallPageOverlay):
        (WebKit::DrawingArea::didUninstallPageOverlay):
        (WebKit::DrawingArea::setOverlayNeedsDisplay):
        Add empty stubs.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::didInstallPageOverlay):
        Add empty function. This will eventually ask the layer tree host to
        create a GraphicsLayer for the page overlay.

        (WebKit::DrawingAreaImpl::didUninstallPageOverlay):
        Tell the page that it needs to be repainted.

        (WebKit::DrawingAreaImpl::setOverlayNeedsDisplay):
        Just call setNeedsDisplay for now.

        (WebKit::DrawingAreaImpl::display):
        Paint the page overlay too.

        * WebProcess/WebPage/DrawingAreaImpl.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::drawRect):
        Only call drawPageOverlay if we have an old drawing area.

        (WebKit::WebPage::drawPageOverlay):
        Draw the page overlay. Code moved here from WebPage::drawRect.

        (WebKit::WebPage::installPageOverlay):
        Call DrawingArea::installPageOverlay.

        (WebKit::WebPage::uninstallPageOverlay):
        Call DrawingArea::uninstallPageOverlay.

        * WebProcess/WebPage/WebPage.h:
        (WebKit::WebPage::hasPageOverlay):
        Add getter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't exclude overlay scrollers from the page overlay bounds
andersca@apple.com [Mon, 7 Feb 2011 18:31:33 +0000 (18:31 +0000)]
Don't exclude overlay scrollers from the page overlay bounds
https://bugs.webkit.org/show_bug.cgi?id=53924

Reviewed by Maciej Stachowiak.

Export ScrollbarTheme::nativeTheme.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 7 Feb 2011 18:26:54 +0000 (18:26 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add WebPage::bounds and use it
        https://bugs.webkit.org/show_bug.cgi?id=53926

        * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
        (WebKit::ChunkedUpdateDrawingArea::resumePainting):
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::resumePainting):
        (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
        * WebProcess/WebPage/WebPage.h:
        (WebKit::WebPage::bounds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 7 Feb 2011 18:21:37 +0000 (18:21 +0000)]
2011-02-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Maciej Stachowiak.

        Don't exclude overlay scrollers from the page overlay bounds
        https://bugs.webkit.org/show_bug.cgi?id=53924

        Don't subtract the scrollbars from the page overlay bounds if
        overlay scrollers are enabled.

        * WebProcess/WebPage/PageOverlay.cpp:
        (WebKit::PageOverlay::bounds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-07 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 7 Feb 2011 18:18:04 +0000 (18:18 +0000)]
2011-02-07  Martin Robinson  <mrobinson@igalia.com>

        Unskip a passing accessibility test and organize the rest of the tests missing
        results as failing.

        * platform/gtk/Skipped: Unskip passing test and organize remaining failures.
        * platform/gtk/accessibility/aria-describedby-on-input-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd built-in decoder for UTF-8 for improved performance
darin@apple.com [Mon, 7 Feb 2011 18:02:55 +0000 (18:02 +0000)]
Add built-in decoder for UTF-8 for improved performance
https://bugs.webkit.org/show_bug.cgi?id=53898

Reviewed by Antti Koivisto.

* wtf/unicode/UnicodeMacrosFromICU.h: Added U8_MAX_LENGTH and
U8_APPEND_UNSAFE. Also fixed header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed.
mjs@apple.com [Mon, 7 Feb 2011 17:57:36 +0000 (17:57 +0000)]
Not reviewed.

Fix WebKitTestRunner build on the SL bot.

* WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy
of ICU headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Zhenyao Mo <zmo@google.com>
zmo@google.com [Mon, 7 Feb 2011 17:29:36 +0000 (17:29 +0000)]
2011-02-03  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Crash in glDrawArrays with NaCl crystal model
        https://bugs.webkit.org/show_bug.cgi?id=52831

        * html/canvas/WebGLRenderingContext.cpp: Allocate large enough buffer for atttrib0 if it's enabled and not used.
        (WebCore::WebGLRenderingContext::initVertexAttrib0):
        (WebCore::WebGLRenderingContext::simulateVertexAttrib0):
        * html/canvas/WebGLRenderingContext.h:
2011-02-03  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Crash in glDrawArrays with NaCl crystal model
        https://bugs.webkit.org/show_bug.cgi?id=52831

        * fast/canvas/webgl/gl-vertex-attrib-zero-issues-expected.txt: Added.
        * fast/canvas/webgl/gl-vertex-attrib-zero-issues.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@77821 268f45cc-cd09-0410-ab3c-d52691b4dbfc