WebKit-https.git
9 years ago2010-07-22 John Gregg <johnnyg@google.com>
johnnyg@google.com [Thu, 22 Jul 2010 21:26:55 +0000 (21:26 +0000)]
2010-07-22  John Gregg  <johnnyg@google.com>

        Reviewed by Kent Tamura.

        [chromium] fast/forms/input-file-directory-upload.html fails on win after r63454
        https://bugs.webkit.org/show_bug.cgi?id=42768

        Normalize path separators for the script API by convering \'s to /'s.

        Covered by input-file-directory-upload.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setFileListFromRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse ::MessageBox instead of ::DebugBreak to make the web process wait for a debugger
aroben@apple.com [Thu, 22 Jul 2010 21:25:32 +0000 (21:25 +0000)]
Use ::MessageBox instead of ::DebugBreak to make the web process wait for a debugger

While ::DebugBreak can make it easier to attach a debugger (because it
brings up the Just-in-Time debugger window), using ::MessageBox has
two advantages:
  1) It explains to the user what's going on, so it's harder to
     mistake this debugging aid for a bug.
  2) It allows you to debug the UI process and the web process using
     the same debugger, if desired.

Special thanks to John Sullivan for help with the text that's shown in
the alert.

Fixes <http://webkit.org/b/42848> WebKit2's wait-for-debugger
debugging aid should explain to the user what's happening

Reviewed by John Sullivan and Anders Carlsson.

* WebProcess/WebKitMain.cpp:
(WebKitMain): Use a ::MessageBox instead of a ::DebugBreak to wait for
the debugger. The alert explains to the user what's going on.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake WorkQueue aware of potential errors with ::WaitForMultipleObjects
aroben@apple.com [Thu, 22 Jul 2010 21:25:13 +0000 (21:25 +0000)]
Make WorkQueue aware of potential errors with ::WaitForMultipleObjects

Fixes <http://webkit.org/b/42846> WorkQueue should detect
::WaitForMultipleObject failures

Reviewed by Anders Carlsson.

* Platform/win/WorkQueueWin.cpp:
(WorkQueue::workQueueThreadBody): Added some assertions about the
various things that can fail with ::WaitForMultipleObjects,
specifically:
  - Passing too many objects
  - Timeouts (which shouldn't happen since we pass a timeout interval
    of INFINITE)
  - Abandoned mutexes (which shouldn't happen since we don't wait on
    any mutexes currently)
  - Miscellaneous failures

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRubberstamped by Simon Fraser.
dimich@chromium.org [Thu, 22 Jul 2010 21:06:00 +0000 (21:06 +0000)]
Rubberstamped by Simon Fraser.

* platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::PlatformStrategies): Add initialization of m_localizationStrategy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Make db.changeVersion()'s third parameter optional, as required by the spec.
dumi@chromium.org [Thu, 22 Jul 2010 20:56:49 +0000 (20:56 +0000)]
WebCore: Make db.changeVersion()'s third parameter optional, as required by the spec.
https://bugs.webkit.org/show_bug.cgi?id=42787

Reviewed by Ojan Vafai.

* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
* bindings/js/JSDatabaseSyncCustom.cpp:
(WebCore::JSDatabaseSync::changeVersion):
* bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
* bindings/v8/custom/V8DatabaseSyncCustom.cpp:
(WebCore::V8DatabaseSync::changeVersionCallback):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
* storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::execute):

LayoutTests: Simplify some tests, and make sure db.changeVersion()'s third parameter is optional.
https://bugs.webkit.org/show_bug.cgi?id=42787

Reviewed by Ojan Vafai.

* fast/workers/storage/resources/change-version-sync-1.js:
* fast/workers/storage/resources/change-version-sync-2.js:
* storage/change-version.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Thu, 22 Jul 2010 20:43:06 +0000 (20:43 +0000)]
2010-07-22  Stephen White  <senorblanco@chromium.org>

        Unreviewed; test expectations fix.

        * platform/chromium/test_expectations.txt:
        Updated expectations to match reality on the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-20 Jessie Berlin <jberlin@apple.com>
jberlin@webkit.org [Thu, 22 Jul 2010 20:33:08 +0000 (20:33 +0000)]
2010-07-20  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Darin Adler.

        Code Generator: Allow negative and string constants.
        Also add tests for hexadecimal numbers.

        * bindings/scripts/CodeGeneratorJS.pm:
        If it is a string, do not try to cast it to an int.

        * bindings/scripts/IDLStructure.pm:
        Add a regex just for constant values that allows strings, hexadecimal numbers, and integral numbers.

        * bindings/scripts/test/CPP/WebDOMTestObj.h:
        Update the tests.

        * bindings/scripts/test/JS/JSTestObj.cpp:
        Ditto.

        * bindings/scripts/test/JS/JSTestObj.h:
        Ditto.

        * bindings/scripts/test/ObjC/DOMTestObj.h:
        Ditto.

        * bindings/scripts/test/TestObj.idl:
        Add tests for negative numbers, strings, and hexadecimal numbers.

        * bindings/scripts/test/V8/V8TestObj.cpp:
        Update the tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 22 Jul 2010 20:17:38 +0000 (20:17 +0000)]
2010-07-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Composited layers don't scroll in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=42771

        More prep work: make a single scrollPositionChanged() bottleneck method, and use it to
        send the scroll event, repaint fixed elements, and update compositing layers.

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
        (WebCore::FrameView::scrollPositionChanged):
        (WebCore::FrameView::repaintFixedElementsAfterScrolling):
        (WebCore::FrameView::valueChanged):
        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::valueChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 22 Jul 2010 20:00:39 +0000 (20:00 +0000)]
2010-07-22  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
        https://bugs.webkit.org/show_bug.cgi?id=42325

        * platform/mac-wk2/Skipped: Removed a duplicate and sorted lists of tests.
        Added some tests to the pasteboard list. Removed the tests from the
        dumpChildFramesAsText list that now pass, and moved others to other lists.
2010-07-22  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
        https://bugs.webkit.org/show_bug.cgi?id=42325

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        Added dumpChildFramesAsText.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::dumpFrameText): Added.
        (WTR::dumpDescendantFramesText): Added.
        (WTR::InjectedBundlePage::dumpAllFramesText): Added.
        (WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function
        instead of the shouldDumpAsText function, and added a case for AllFramesText.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with
        m_whatToDump.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added
        dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive,
        and shouldDumpSourceAsWebArchive. Added whatToDump.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 22 Jul 2010 18:39:31 +0000 (18:39 +0000)]
2010-07-22  Darin Fisher  <darin@chromium.org>

        Reviewed by David Levin.

        [Chromium] Propagate return value of EventHandler::handleMouseWheelEvent
        to caller of WebViewImpl::handleInputEvent.

        https://bugs.webkit.org/show_bug.cgi?id=42835

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::mouseWheel):
        (WebKit::WebViewImpl::handleInputEvent):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPatch for https://bugs.webkit.org/show_bug.cgi?id=42836
weinig@apple.com [Thu, 22 Jul 2010 18:18:26 +0000 (18:18 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=42836
Add localized strings stubs for WebKit2.

Reviewed by Anders Carlsson.

WebCore:

- Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory
  for localized strings.

Gets us below 200 tests failing in WebKitTestRunner.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* page/mac/WebCoreViewFactory.h:
* platform/LocalizationStrategy.h: Added.
(WebCore::LocalizationStrategy::~LocalizationStrategy):
* platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::pluginStrategy):
(WebCore::PlatformStrategies::localizationStrategy):
(WebCore::PlatformStrategies::PlatformStrategies):
(WebCore::PlatformStrategies::~PlatformStrategies):
* platform/mac/LocalizedStringsMac.mm:

WebKit/mac:

- Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory
  for localized strings.

Gets us below 200 tests failing in WebKitTestRunner.

* WebCoreSupport/WebContextMenuClient.mm:
(fixMenusReceivedFromOldClients): Use LocalizedStrings rather than the factory.
* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
* WebCoreSupport/WebViewFactory.mm:

WebKit2:

Gets us below 200 tests failing in WebKitTestRunner.

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed trivial build fix.
abecsi@webkit.org [Thu, 22 Jul 2010 18:08:17 +0000 (18:08 +0000)]
Unreviewed trivial build fix.

[Qt] Mend remaining issues to fix the WebKit2 build.

* Shared/qt/UpdateChunk.h: add missing function
(WebKit::UpdateChunk::isEmpty):
* UIProcess/API/qt/qwkpage_p.h: Add stub implementation
(QWKPagePrivate::pageDidEnterAcceleratedCompositing):
(QWKPagePrivate::pageDidLeaveAcceleratedCompositing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Thu, 22 Jul 2010 18:01:32 +0000 (18:01 +0000)]
2010-07-22  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Implement WebContext::applicationCacheDirectory() for the Qt port of WebKit2.
        https://bugs.webkit.org/show_bug.cgi?id=42830

        No new tests needed.

        * WebCore.pri: add ApplicationCacheStorage.h to wk2 headers
        * WebCore.pro: add WebContextQt.cpp to sources
2010-07-22  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] Implement WebContext::applicationCacheDirectory() for the Qt port of WebKit2.
        https://bugs.webkit.org/show_bug.cgi?id=42830

        * UIProcess/qt/WebContextQt.cpp: Added.
        (WebKit::WebContext::applicationCacheDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Joone Hur <joone.hur@samsung.com>
commit-queue@webkit.org [Thu, 22 Jul 2010 17:48:36 +0000 (17:48 +0000)]
2010-07-22  Joone Hur  <joone.hur@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] add support for logging
        https://bugs.webkit.org/show_bug.cgi?id=40807

        Enable to turn log channels on for EFL port

        * platform/efl/LoggingEfl.cpp:
        (WebCore::InitializeLoggingChannelsIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Thu, 22 Jul 2010 17:04:12 +0000 (17:04 +0000)]
Unreviewed.

[Qt] Add platform specific expected results for tests introduced in r62200.

* platform/qt/fast/borders/border-radius-circle-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-circle-expected.txt.
* platform/qt/fast/borders/border-radius-groove-01-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-groove-01-expected.txt.
* platform/qt/fast/borders/border-radius-groove-02-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-groove-02-expected.txt.
* platform/qt/fast/borders/border-radius-groove-03-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-groove-03-expected.txt.
* platform/qt/fast/borders/border-radius-wide-border-01-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-01-expected.txt.
* platform/qt/fast/borders/border-radius-wide-border-02-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-02-expected.txt.
* platform/qt/fast/borders/border-radius-wide-border-03-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-03-expected.txt.
* platform/qt/fast/borders/border-radius-wide-border-04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-04-expected.txt.
* platform/qt/fast/borders/borderRadiusDashed04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDashed04-expected.txt.
* platform/qt/fast/borders/borderRadiusDashed05-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDashed05-expected.txt.
* platform/qt/fast/borders/borderRadiusDashed06-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDashed06-expected.txt.
* platform/qt/fast/borders/borderRadiusDotted04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDotted04-expected.txt.
* platform/qt/fast/borders/borderRadiusDotted05-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDotted05-expected.txt.
* platform/qt/fast/borders/borderRadiusDotted06-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDotted06-expected.txt.
* platform/qt/fast/borders/borderRadiusDouble04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble04-expected.txt.
* platform/qt/fast/borders/borderRadiusDouble05-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble05-expected.txt.
* platform/qt/fast/borders/borderRadiusDouble06-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble06-expected.txt.
* platform/qt/fast/borders/borderRadiusDouble07-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble07-expected.txt.
* platform/qt/fast/borders/borderRadiusDouble08-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble08-expected.txt.
* platform/qt/fast/borders/borderRadiusDouble09-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble09-expected.txt.
* platform/qt/fast/borders/different-color-borders-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/different-color-borders-expected.txt and updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Jamey Hicks <jamey.hicks@nokia.com>
commit-queue@webkit.org [Thu, 22 Jul 2010 17:02:14 +0000 (17:02 +0000)]
2010-07-22  Jamey Hicks  <jamey.hicks@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable binding of QObjects to JavaScript environment for inspector frontend

        This patch enables QObjects to be bound to global variables in the
        javascript environment of the inspector frontend. This is useful
        for writing alternate inspector frontends in javascript which need
        additional native functionality. It's a lighter-weight alternative
        than using an NPAPI plugin.

        The code which instantiates QWebInspector uses this by setting the
        dynamic property "q_inspectorJavaScriptWindowObjects" on the
        QWebInspector. The value of this property should be a
        QMap<QString,QVariant> mapping global variable name to QObject.

        I have used this to add support for eclipse/chrome remote
        debugging in QtTestBrowser.

        https://bugs.webkit.org/show_bug.cgi?id=41995

        * WebCoreSupport/InspectorClientQt.cpp:
        (WebCore::InspectorClientWebPage::InspectorClientWebPage):
        (WebCore::InspectorClientWebPage::javaScriptWindowObjectCleared):
        (WebCore::InspectorClientQt::openInspectorFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Ureviewed build fix.
abecsi@webkit.org [Thu, 22 Jul 2010 17:00:12 +0000 (17:00 +0000)]
WebCore: Ureviewed build fix.

Patch by Balazs Kelemen <kb@inf.u-szeged.hu> on 2010-07-22
[Qt] Fix WebKit2 build

https://bugs.webkit.org/show_bug.cgi?id=42638

* WebCore.pri:
* WebCore.pro:

WebKit2: Unreviewed build fix.

Patch by Balazs Kelemen <kb@inf.u-szeged.hu> on 2010-07-22
[Qt] Fix WebKit2 build

https://bugs.webkit.org/show_bug.cgi?id=42638

* UIProcess/API/qt/qwkpage_p.h:
(QWKPagePrivate::setCursor): Added empty implementation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 22 Jul 2010 16:42:43 +0000 (16:42 +0000)]
2010-07-22  Darin Fisher  <darin@chromium.org>

        Reviewed by Kent Tamura.

        https://bugs.webkit.org/show_bug.cgi?id=42808
        Pass context menu events through WebInputEvent to WebPlugin::handleInputEvent.

        The DOM treats a context menu event as a type of mouse event.  We therefore
        do the same here, and reuse the WebMouseEvent subclass.  This makes sense
        since a context menu event has (x,y)-coordinates.

        * public/WebInputEvent.h:
        (WebKit::WebInputEvent::):
        (WebKit::WebInputEvent::isMouseEventType):
        * src/WebInputEventConversion.cpp:
        (WebKit::WebMouseEventBuilder::WebMouseEventBuilder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Andrey Kosyakov <caseq@chromium.org>
commit-queue@webkit.org [Thu, 22 Jul 2010 16:39:38 +0000 (16:39 +0000)]
2010-07-22  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Stop granting universal access to inspector front-end page.
        https://bugs.webkit.org/show_bug.cgi?id=42817

        * inspector/InspectorFrontendClientLocal.cpp:
        (WebCore::InspectorFrontendClientLocal::windowObjectCleared):
2010-07-22  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Stop granting universal access to inspector front-end page.
        https://bugs.webkit.org/show_bug.cgi?id=42817

        * src/WebDevToolsFrontendImpl.cpp:
        (WebKit::WebDevToolsFrontendImpl::frontendLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 22 Jul 2010 16:03:21 +0000 (16:03 +0000)]
2010-07-22  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Fix inspector console tests crashes.

        * bindings/v8/ScriptValue.cpp:
        (WebCore::v8ToInspectorValue):
        (WebCore::ScriptValue::toInspectorValue): enter v8 context before calling GetPropertyNames

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
leandro@webkit.org [Thu, 22 Jul 2010 15:19:56 +0000 (15:19 +0000)]
2010-07-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed build fix.

        [EFL] Build break for SVN r63881
        https://bugs.webkit.org/show_bug.cgi?id=42813

        * CMakeLists.txt: Add platform/SchemeRegistry.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Balazs Kelemen <kb@inf.u-szeged.hu>
commit-queue@webkit.org [Thu, 22 Jul 2010 15:03:51 +0000 (15:03 +0000)]
2010-07-22  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Antonio Gomes.

        Lazy cursor creation should be guarded by #if USE(LAZY_NATIVE_CURSOR) in WebKit2

        https://bugs.webkit.org/show_bug.cgi?id=42622

        * Shared/WebCoreArgumentCoders.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveMessage):
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::setCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Hayato Ito <hayato@chromium.org>
commit-queue@webkit.org [Thu, 22 Jul 2010 14:43:09 +0000 (14:43 +0000)]
2010-07-22  Hayato Ito  <hayato@chromium.org>

        Reviewed by Darin Adler.

        Refactor CSSSelector's destructor and make it inline.

        https://bugs.webkit.org/show_bug.cgi?id=42726

        Refactor with no behavior change, thus no new tests.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelectorBag::~CSSSelectorBag): Make sure the bag is empty.
        (WebCore::CSSSelectorBag::add): Renamed from append().
        (WebCore::CSSSelector::releaseOwnedSelectorsToBag):
        (WebCore::CSSSelector::deleteReachableSelectors):
        * css/CSSSelector.h:
        (WebCore::CSSSelector::~CSSSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 22 Jul 2010 14:33:54 +0000 (14:33 +0000)]
2010-07-22  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: should be possible to convert console message arguments to InspectorValues
        https://bugs.webkit.org/show_bug.cgi?id=42457

        Now it is possible to convert simple JavaScript objects to
        InspectorValues.

        * bindings/js/ScriptValue.cpp:
        (WebCore::jsToInspectorValue):
        (WebCore::ScriptValue::toInspectorValue):
        * bindings/js/ScriptValue.h:
        * bindings/v8/ScriptValue.cpp:
        (WebCore::v8ToInspectorValue):
        (WebCore::ScriptValue::toInspectorValue):
        * bindings/v8/ScriptValue.h:
        * inspector/ConsoleMessage.cpp: console notifications are pushed to RemoteInspectorFrontend instead of InspectorFrontend.
        (WebCore::ConsoleMessage::CallFrame::buildInspectorObject):
        (WebCore::ConsoleMessage::addToFrontend):
        (WebCore::ConsoleMessage::updateRepeatCountInConsole):
        * inspector/ConsoleMessage.h:
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::wrapForConsole): return InspectorValue instead of SerializedScriptValue
        * inspector/InjectedScript.h:
        * inspector/Inspector.idl:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::clearConsoleMessages): send response directly from the backend
        (WebCore::InspectorBackend::remoteFrontend):
        * inspector/InspectorBackend.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addConsoleMessage):
        (WebCore::InspectorController::clearConsoleMessages): don't send notification to the front end,
        it will be send either from InspectorBackend.cpp if it was a user request or reset message will
        be send to the front end if the messages are cleared due to page navigation.
        (WebCore::InspectorController::populateScriptObjects):
        * inspector/front-end/ConsoleView.js:
        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Thu, 22 Jul 2010 14:26:45 +0000 (14:26 +0000)]
Unreviewed.

[Qt] REGRESSION(63862): animations/play-state.html fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=42821

* platform/qt/Skipped: animations/play-state.html skipped until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 22 Jul 2010 14:23:27 +0000 (14:23 +0000)]
2010-07-22  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Modifying settings actually modifies defaultValues
        https://bugs.webkit.org/show_bug.cgi?id=42816

        Avoid using live modifiable objects as property default values.

        * inspector/front-end/Settings.js:
        (WebInspector.Settings):
        (WebInspector.Settings.prototype.reset):
        (WebInspector.Settings.prototype._load):
        (WebInspector.Settings.prototype.installSetting):
        (WebInspector.Settings.prototype._get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Ben Murdoch <benm@google.com>
benm@google.com [Thu, 22 Jul 2010 14:07:18 +0000 (14:07 +0000)]
2010-07-22  Ben Murdoch  <benm@google.com>

        Reviewed by Simon Fraser.

        Touch events do not affect the :active CSS state
        https://bugs.webkit.org/show_bug.cgi?id=39493

        Clean the code up by using a typedef based on comments
        post landing of the original patch.

        No change in functionality so no new tests.

        * rendering/HitTestRequest.h: Typedef the HitTestRequestType to unsigned.
        * WebCore.exp.in: Update export signature.
        * WebCore.order: Ditto.
        * page/EventHandler.cpp: use the new typedef.
        * page/EventHandler.h: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Library versioning.
hausmann@webkit.org [Thu, 22 Jul 2010 13:36:13 +0000 (13:36 +0000)]
[Qt] Library versioning.

2.1 is branched, trunk will become 2.2.

* Api/qwebkitglobal.h:
* qt_webkit_version.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 22 Jul 2010 13:26:22 +0000 (13:26 +0000)]
2010-07-22  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Rename method for CSS rule source range retrieval and fix return object format
        https://bugs.webkit.org/show_bug.cgi?id=42379

        WebCore:
        * inspector/Inspector.idl:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::getRuleRanges):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorCSSStore.cpp:
        (WebCore::InspectorCSSStore::getRuleRanges):
        * inspector/InspectorCSSStore.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::getRuleRanges):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/DOMAgent.js:

        WebKit/chromium:
        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl):

        LayoutTests:
        * inspector/styles-source-offsets.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix
aroben@apple.com [Thu, 22 Jul 2010 13:01:14 +0000 (13:01 +0000)]
Windows build fix

Inspired by r63881.

* MiniBrowser/MiniBrowser.vcproj:
* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
Removed pre- and post-build events so they will be inherited from the
vsprops files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 22 Jul 2010 12:52:35 +0000 (12:52 +0000)]
2010-07-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chromium Dev Tools: Separators are missing in the context menu.

        https://bugs.webkit.org/show_bug.cgi?id=42761

        * bindings/js/JSInspectorFrontendHostCustom.cpp:
        (WebCore::JSInspectorFrontendHost::showContextMenu):
        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
        (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
        * platform/ContextMenuItem.h:
        (WebCore::):
2010-07-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Chromium Dev Tools: Separators are missing in the context menu.

        https://bugs.webkit.org/show_bug.cgi?id=42761

        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::populateCustomMenuItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes...
zherczeg@webkit.org [Thu, 22 Jul 2010 12:41:58 +0000 (12:41 +0000)]
SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
https://bugs.webkit.org/show_bug.cgi?id=42244

Reviewed by Nikolas Zimmermann.

WebCore:

Implementing svgAttributeChanged and childrenChanged for the base class of all filters,
called SVGFilterPrimitiveStandardAttributes.

Tests: svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr.html
       svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr.html
       svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr.html
       svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr.html
       svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr.html
       svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop.html
       svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.html
       svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop.html
       svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop.html
       svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop.html

* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
* svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::invalidateFilter):

LayoutTests:

* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop.html: Added.
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-height-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-result-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-width-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-x-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-y-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop.js: Added.
(executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Kent Hansen <kent.hansen@nokia.com>
kent.hansen@nokia.com [Thu, 22 Jul 2010 12:08:50 +0000 (12:08 +0000)]
2010-07-22  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Kent Tamura.

        Error properties of the Global Object are missing the DontEnum attribute
        https://bugs.webkit.org/show_bug.cgi?id=28771

        Add the attributes to become spec compliant.

        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::reset):

2010-07-22  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Kent Tamura.

        Error properties of the Global Object are missing the DontEnum attribute
        https://bugs.webkit.org/show_bug.cgi?id=28771

        Update expected results for tests that now pass.

        * fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.1_T3-expected.txt:
        * fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.2_T3-expected.txt:
        * fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.3_T3-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix. Unreviewed.
jhoneycutt@apple.com [Thu, 22 Jul 2010 09:36:42 +0000 (09:36 +0000)]
Build fix. Unreviewed.

* win/WebKit2WebProcess.vcproj:
Remove the pre- and post-build events, so that they will use the value
inherited from the vsprops.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Kent Hansen <kent.hansen@nokia.com>
kent.hansen@nokia.com [Thu, 22 Jul 2010 08:52:40 +0000 (08:52 +0000)]
2010-07-22  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Sam Weinig.

        Improve coverage of fast/dom/prototype-inheritance test
        https://bugs.webkit.org/show_bug.cgi?id=42354

        Use Object.getOwnPropertyNames rather than for..in to enumerate
        the window object's properties, so that non-enumerable (ECMA)
        properties are covered as well.

        * fast/dom/prototype-inheritance-expected.txt:
        * fast/dom/script-tests/prototype-inheritance.js:
        (propertiesOnObject):
        * platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt:
        * platform/chromium-win/fast/dom/prototype-inheritance-expected.txt:
        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:
        * platform/gtk/fast/dom/prototype-inheritance-expected.txt:
        * platform/qt/fast/dom/prototype-inheritance-expected.txt:
        * platform/win/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 22 Jul 2010 08:20:47 +0000 (08:20 +0000)]
2010-07-22  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Small refactoring for input value sanitization
        https://bugs.webkit.org/show_bug.cgi?id=42807

        Rename some functions to clarify their roles.

        * dom/InputElement.cpp:
        (WebCore::replaceEOLAndLimitLength):
          Renamed from sanitizeUserInputValue().
        (WebCore::InputElement::sanitizeValueForTextField):
          Renamed from sanitizeValue(), and call replaceEOLAndLimitLength()
          instead of sanitizeUserInputValue().
        (WebCore::InputElement::sanitizeUserInputValue):
          Just call replaceEOLAndLimitLength().
        (WebCore::InputElement::updateValueIfNeeded):
          Use non-static sanitizeValue() for consistency.
        * dom/InputElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType):
          Revert the change of r63876. It is not needed because of the
          updateValueIfNeeded() change.
        (WebCore::HTMLInputElement::sanitizeValue):
          Apply the sanitizeValue() renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-22 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 22 Jul 2010 07:40:52 +0000 (07:40 +0000)]
2010-07-22  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Darin Fisher.

        webkitPerformance.timing.responseEnd should not include document parse time
        https://bugs.webkit.org/show_bug.cgi?id=42797

        No new tests because timing based test would be flaky.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedLoading): finishedLoading() is called by the platform at the right time, but didReceiveData() synchronously invokes parsing without returning to the event loop prior to this. So by the time the didFinishLoading() method is executed, parsing is finished. The solution is to move this time to didReceiveData() prior to parsing.
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::didReceiveData): Update the time each time didReceiveData() is called.
        (WebCore::MainResourceLoader::didFinishLoading): When finished, and after parsing, set responseEnd appropriately.
        * loader/MainResourceLoader.h:
        * page/Timing.cpp:
        (WebCore::Timing::resourceLoadTimeRelativeToAbsolute): Now that responseEnd is set correctly, it can be much shorter for very fast loads (like local files). This exposed the fact that this skew check was not tight enough. We need to make sure that the whole range of values from the ResourceLoadTiming API fit within fetchStart-responseEnd, not just that requestTime fits in this range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 22 Jul 2010 06:52:51 +0000 (06:52 +0000)]
2010-07-21  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
        https://bugs.webkit.org/show_bug.cgi?id=42548

        * platform/mac-wk2/Skipped: Moved some tests into the correct section
        now that dumpChildFrameScrollPositions is no longer the reason they
        fail. Removed now-passing test. Resorted some of the tests.
2010-07-21  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
        https://bugs.webkit.org/show_bug.cgi?id=42548

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.
        (WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.
        Changed to a file-internal function instead of a member function.
        (WTR::dumpDescendantFrameScrollPositions): Added.
        (WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.
        (WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when
        appropriate. Also streamlined all the WKStringToUTF8 call sites.
        (WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.
        (WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
        (WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
        (WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
        (WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::LayoutTestController): Initialize
        m_shouldDumpAllFrameScrollPositions.
        (WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from
        shouldDumpFrameScrollPositions.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a
        bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,
        and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
2010-07-21  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
        https://bugs.webkit.org/show_bug.cgi?id=42548

        Added WKBundleFrameCopyName.

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameCopyName): Added.
        * WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.

        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::name): Added.
        * WebProcess/WebPage/WebFrame.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 22 Jul 2010 03:08:59 +0000 (03:08 +0000)]
2010-07-21  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Assertion failure by changing the type of an input element with a
        non-number value to 'range'.
        https://bugs.webkit.org/show_bug.cgi?id=42643

        * fast/forms/input-value-sanitization-expected.txt: Added.
        * fast/forms/input-value-sanitization.html: Added.
        * fast/forms/script-tests/input-value-sanitization.js: Added.
2010-07-21  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Assertion failure by changing the type of an input element with a
        non-number value to 'range'.
        https://bugs.webkit.org/show_bug.cgi?id=42643

        Test: fast/forms/input-value-sanitization.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType):
        Update the value by HTMLInputElement::sanitizeValue() in a case that
        storesValueSeparateFromAttribute() state is not changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 22 Jul 2010 02:12:15 +0000 (02:12 +0000)]
2010-07-21  Justin Schuh  <jschuh@chromium.org>

        Unreviewed. Build fix.

        Added platform test to account for qt's xml parser

        * platform/qt/svg/custom/use-invalid-html-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 22 Jul 2010 01:54:42 +0000 (01:54 +0000)]
2010-07-21  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Copy the test plugin into DumpRenderTree.app/
        https://bugs.webkit.org/show_bug.cgi?id=42733

        This was dropped in plugin copy refactoring.

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agodumpAsMarkup test conversion: create-list-from-range-selection.html and insert-list...
rniwa@webkit.org [Thu, 22 Jul 2010 01:27:51 +0000 (01:27 +0000)]
dumpAsMarkup test conversion: create-list-from-range-selection.html and insert-list-empty-div.html
https://bugs.webkit.org/show_bug.cgi?id=42608

Reviewed by Ojan Vafai.

Converted the tests and removed the platform specific expected results.

* editing/execCommand/create-list-from-range-selection-expected.txt: Added.
* editing/execCommand/create-list-from-range-selection.html: Use dumpAsMarkup
* editing/execCommand/insert-list-empty-div-expected.txt: Added.
* editing/execCommand/insert-list-empty-div.html: Use dumpAsMarkup
* platform/chromium-linux/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
* platform/chromium-linux/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
* platform/chromium-linux/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
* platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
* platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
* platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
* platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
* platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.png: Removed.
* platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
* platform/gtk/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
* platform/mac/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
* platform/mac/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
* platform/mac/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
* platform/mac/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
* platform/mac/editing/execCommand/insert-list-empty-div-expected.png: Removed.
* platform/mac/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
* platform/qt/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
* platform/qt/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
* resources/dump-as-markup.js: Added setNodeToDump.
(Markup.setNodeToDump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 22 Jul 2010 01:10:34 +0000 (01:10 +0000)]
2010-07-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        incorrect tabindex parsing
        https://bugs.webkit.org/show_bug.cgi?id=21076

        Add a test showing that our parsing of unquoted attributes in
        self-closing tags complies with the spec.

        * html5lib/resources/webkit02.dat: Added.
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
        * html5lib/runner.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 22 Jul 2010 01:08:36 +0000 (01:08 +0000)]
2010-07-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Let's pass the doctype01.dat tests again, please
        https://bugs.webkit.org/show_bug.cgi?id=42794

        The upstream results check the publicId and the systemId, so we need to
        make dom2string smarter and print them.

        * html5lib/resources/dom2string.js:
        (dom2string):
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 22 Jul 2010 01:04:59 +0000 (01:04 +0000)]
2010-07-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement spec changes for basefont and bgsound
        https://bugs.webkit.org/show_bug.cgi?id=42792

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTagForInBody):
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::processStartTagForInHead):
2010-07-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement spec changes for basefont and bgsound
        https://bugs.webkit.org/show_bug.cgi?id=42792

        * html5lib/runner-expected-html5.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 22 Jul 2010 01:03:17 +0000 (01:03 +0000)]
2010-07-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Update a list of tags to match changes in the HTML5 spec
        https://bugs.webkit.org/show_bug.cgi?id=42791

        We need to atomize these strings at some point.

        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTagForInBody):
2010-07-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Update a list of tags to match changes in the HTML5 spec
        https://bugs.webkit.org/show_bug.cgi?id=42791

        Testing makes perfect.

        * html5lib/runner-expected-html5.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 22 Jul 2010 01:00:46 +0000 (01:00 +0000)]
2010-07-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTMLTreeBuilder needs to update to match new spec behavior for <button>
        https://bugs.webkit.org/show_bug.cgi?id=42233

        The spec has some typos in this area, but this is my best guess for
        what Ian means.  I've filed bugs against the spec for each typo.

        * html/HTMLElementStack.cpp:
        (WebCore::HTMLNames::isScopeMarker):
        (WebCore::HTMLNames::isButtonScopeMarker):
        (WebCore::HTMLElementStack::inButtonScope):
        * html/HTMLElementStack.h:
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
        (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
        (WebCore::HTMLTreeBuilder::processStartTagForInBody):
        (WebCore::HTMLTreeBuilder::processEndTagForInBody):
        * html/HTMLTreeBuilder.h:
2010-07-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        HTMLTreeBuilder needs to update to match new spec behavior for <button>
        https://bugs.webkit.org/show_bug.cgi?id=42233

        Test progression.  There's one regression mixed in here.  I'll
        investigate in the next patch.

        * html5lib/runner-expected-html5.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 22 Jul 2010 00:58:54 +0000 (00:58 +0000)]
2010-07-21  Justin Schuh  <jschuh@chromium.org>

        Unreviewed. Build fix.

        Removed comment element for test added with:
        http://trac.webkit.org/changeset/63865

        * svg/custom/use-invalid-html-expected.txt:
        * svg/custom/use-invalid-html.xhtml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 22 Jul 2010 00:46:26 +0000 (00:46 +0000)]
2010-07-21  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs to support dumping of scroll position
        https://bugs.webkit.org/show_bug.cgi?id=42514

        * platform/mac-wk2/Skipped: Removed now-passing tests from
        skipped list and moved one miscategorized test.
2010-07-21  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs to support dumping of scroll position
        https://bugs.webkit.org/show_bug.cgi?id=42514

        * MiniBrowser/mac/WebBundle/WebBundleMain.m:
        (_didClearWindowForFrame): Use JSGlobalContextRef instead of JSContextRef.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::_didClearWindowForFrame): Use JSGlobalContextRef
        instead of JSContextRef.
        (WTR::InjectedBundlePage::dump): Call dumpFrameScrollPosition when appropriate.
        (WTR::numericWindowProperty): Added. Helper for dumpFrameScrollPosition.
        (WTR::InjectedBundlePage::dumpFrameScrollPosition): Added.
        (WTR::InjectedBundlePage::didClearWindowForFrame): Use JSGlobalContextRef
        instead of JSContextRef.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Removed names from
        arguments that simply repeat the argument type. Added dumpFrameScrollPosition.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::shouldDumpDOMAsWebArchive): Added. Currently
        returns false.
        (WTR::LayoutTestController::shouldDumpSourceAsWebArchive): Added. Currently
        returns false.
        (WTR::LayoutTestController::shouldDumpFrameScrollPositions): Added. Matches
        the logic in DumpRenderTree.

        * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for above changes.

        * WebKitTestRunner/WebKitTestRunner.xcodeproj: Added property svn:ignore.
2010-07-21  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner needs to support dumping of scroll position
        https://bugs.webkit.org/show_bug.cgi?id=42514

        Added WKBundleFrameGetJavaScriptContext function.

        * WebKit2.xcodeproj: Added property svn:ignore.

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameGetJavaScriptContext): Added.
        * WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.

        * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
        (WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
        * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
        Use JSGlobalContextRef instead of JSContextRef and context instead of ct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Thu, 22 Jul 2010 00:36:38 +0000 (00:36 +0000)]
2010-07-21  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Oliver Hunt.

        Prevent DeleteButtonController enable state from changing when not editing
        https://bugs.webkit.org/show_bug.cgi?id=42659

        Test: svg/custom/use-invalid-html.xhtml

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::cloneChildNodes):
2010-07-21  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Oliver Hunt.

        Prevent DeleteButtonController enable state from changing when not editing
        https://bugs.webkit.org/show_bug.cgi?id=42659

        * svg/custom/use-invalid-html-expected.txt: Added.
        * svg/custom/use-invalid-html.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=42605 New border-
bdakin@apple.com [Wed, 21 Jul 2010 23:53:11 +0000 (23:53 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=42605 New border-
radius path-based drawing code has some issues with corner-joins

Reviewed by Dan Bernstein.

GraphicsContext::clipConvexPolygon() now takes a boolean parameter
indicating whether or not the clip should be antialiased.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
* platform/graphics/haiku/GraphicsContextHaiku.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
* platform/graphics/wince/GraphicsContextWince.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::clipConvexPolygon):

Compute 4 booleans determining if each edge is a "matching" edge of
not. Send the two appropriate values to clipBorderSidePolygon() so
we can decide there whether or not to antialias the clip based on
matchy-ness.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder):

If both edges are matching, don't antialias. If neither edge
matches, never antialias. If one edge matches and one does not,
apply two clips to get the appropriate antialiasing in each corner.
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
* rendering/RenderBoxModelObject.h:

LayoutTests: Some of these layout tests are updated results from the fix for
https://bugs.webkit.org/show_bug.cgi?id=42605 New border-
radius path-based drawing code has some issues with corner-joins.
The others have been in need of an update since
https://bugs.webkit.org/show_bug.cgi?id=9197 , but since the
differences were only detectable visually and with a pixel-text
tolerance of 0 (not the default), they slipped under the rug until
now.

Reviewed by Dan Bernstein.

New test:
* fast/borders/different-color-borders.html: Added.
* platform/mac/fast/borders/border-radius-circle-expected.checksum:
* platform/mac/fast/borders/border-radius-circle-expected.png:

* platform/mac/fast/borders/border-radius-constraints-expected.checksum:
* platform/mac/fast/borders/border-radius-constraints-expected.png:
* platform/mac/fast/borders/border-radius-groove-01-expected.checksum:
* platform/mac/fast/borders/border-radius-groove-01-expected.png:
* platform/mac/fast/borders/border-radius-groove-02-expected.checksum:
* platform/mac/fast/borders/border-radius-groove-02-expected.png:
* platform/mac/fast/borders/border-radius-groove-03-expected.checksum:
* platform/mac/fast/borders/border-radius-groove-03-expected.png:
* platform/mac/fast/borders/border-radius-huge-assert-expected.checksum:
* platform/mac/fast/borders/border-radius-huge-assert-expected.png:
* platform/mac/fast/borders/border-radius-wide-border-02-expected.checksum:
* platform/mac/fast/borders/border-radius-wide-border-02-expected.png:
* platform/mac/fast/borders/border-radius-wide-border-03-expected.checksum:
* platform/mac/fast/borders/border-radius-wide-border-03-expected.png:
* platform/mac/fast/borders/border-radius-wide-border-04-expected.checksum:
* platform/mac/fast/borders/border-radius-wide-border-04-expected.png:
* platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum:
* platform/mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
* platform/mac/fast/borders/borderRadiusArcs01-expected.checksum:
* platform/mac/fast/borders/borderRadiusArcs01-expected.png:
* platform/mac/fast/borders/borderRadiusDashed01-expected.checksum:
* platform/mac/fast/borders/borderRadiusDashed01-expected.png:
* platform/mac/fast/borders/borderRadiusDashed02-expected.checksum:
* platform/mac/fast/borders/borderRadiusDashed02-expected.png:
* platform/mac/fast/borders/borderRadiusDashed03-expected.checksum:
* platform/mac/fast/borders/borderRadiusDashed03-expected.png:
* platform/mac/fast/borders/borderRadiusDashed04-expected.checksum:
* platform/mac/fast/borders/borderRadiusDashed04-expected.png:
* platform/mac/fast/borders/borderRadiusDotted02-expected.checksum:
* platform/mac/fast/borders/borderRadiusDotted02-expected.png:
* platform/mac/fast/borders/borderRadiusDotted03-expected.checksum:
* platform/mac/fast/borders/borderRadiusDotted03-expected.png:
* platform/mac/fast/borders/borderRadiusDotted04-expected.checksum:
* platform/mac/fast/borders/borderRadiusDotted04-expected.png:
* platform/mac/fast/borders/borderRadiusDotted06-expected.checksum:
* platform/mac/fast/borders/borderRadiusDotted06-expected.png:
* platform/mac/fast/borders/borderRadiusDouble01-expected.checksum:
* platform/mac/fast/borders/borderRadiusDouble01-expected.png:
* platform/mac/fast/borders/borderRadiusDouble02-expected.checksum:
* platform/mac/fast/borders/borderRadiusDouble02-expected.png:
* platform/mac/fast/borders/borderRadiusDouble03-expected.checksum:
* platform/mac/fast/borders/borderRadiusDouble03-expected.png:
* platform/mac/fast/borders/borderRadiusDouble05-expected.checksum:
* platform/mac/fast/borders/borderRadiusDouble05-expected.png:
* platform/mac/fast/borders/borderRadiusDouble06-expected.checksum:
* platform/mac/fast/borders/borderRadiusDouble06-expected.png:
* platform/mac/fast/borders/borderRadiusDouble08-expected.checksum:
* platform/mac/fast/borders/borderRadiusDouble08-expected.png:
* platform/mac/fast/borders/borderRadiusGroove01-expected.checksum:
* platform/mac/fast/borders/borderRadiusGroove01-expected.png:
* platform/mac/fast/borders/borderRadiusGroove02-expected.checksum:
* platform/mac/fast/borders/borderRadiusGroove02-expected.png:
* platform/mac/fast/borders/borderRadiusInset01-expected.checksum:
* platform/mac/fast/borders/borderRadiusInset01-expected.png:
* platform/mac/fast/borders/borderRadiusInvalidColor-expected.checksum:
* platform/mac/fast/borders/borderRadiusInvalidColor-expected.png:
* platform/mac/fast/borders/borderRadiusOutset01-expected.checksum:
* platform/mac/fast/borders/borderRadiusOutset01-expected.png:
* platform/mac/fast/borders/borderRadiusRidge01-expected.checksum:
* platform/mac/fast/borders/borderRadiusRidge01-expected.png:
* platform/mac/fast/borders/borderRadiusSolid01-expected.checksum:
* platform/mac/fast/borders/borderRadiusSolid01-expected.png:
* platform/mac/fast/borders/borderRadiusSolid02-expected.checksum:
* platform/mac/fast/borders/borderRadiusSolid02-expected.png:
* platform/mac/fast/borders/borderRadiusSolid03-expected.checksum:
* platform/mac/fast/borders/borderRadiusSolid03-expected.png:
* platform/mac/fast/borders/borderRadiusSolid04-expected.checksum:
* platform/mac/fast/borders/borderRadiusSolid04-expected.png:
* platform/mac/fast/borders/different-color-borders-expected.checksum: Added.
* platform/mac/fast/borders/different-color-borders-expected.png: Added.
* platform/mac/fast/borders/different-color-borders-expected.txt: Added.
* platform/mac/fast/borders/fieldsetBorderRadius-expected.checksum:
* platform/mac/fast/borders/fieldsetBorderRadius-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 21 Jul 2010 23:19:55 +0000 (23:19 +0000)]
2010-07-21  Brady Eidson  <beidson@apple.com>

        Reviewed by Geoffrey Garen.

        Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
        https://bugs.webkit.org/show_bug.cgi?id=42783

        * src/WebSecurityPolicy.cpp:
        (WebKit::WebSecurityPolicy::registerURLSchemeAsLocal):
        (WebKit::WebSecurityPolicy::registerURLSchemeAsNoAccess):
        (WebKit::WebSecurityPolicy::registerURLSchemeAsSecure):
2010-07-21  Brady Eidson  <beidson@apple.com>

        Reviewed by Geoffrey Garen.

        Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
        https://bugs.webkit.org/show_bug.cgi?id=42783

        * Api/qwebpage.cpp:
        (QWebPage::acceptNavigationRequest):
        * Api/qwebsecurityorigin.cpp:
        (QWebSecurityOrigin::addLocalScheme):
        (QWebSecurityOrigin::removeLocalScheme):
        (QWebSecurityOrigin::localSchemes):
2010-07-21  Brady Eidson  <beidson@apple.com>

        Reviewed by Geoffrey Garen.

        Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
        https://bugs.webkit.org/show_bug.cgi?id=42783

        * WebView.cpp:
        (WebView::registerURLSchemeAsLocal):
        (WebView::registerURLSchemeAsSecure):
2010-07-21  Brady Eidson  <beidson@apple.com>

        Reviewed by Geoffrey Garen.

        Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
        https://bugs.webkit.org/show_bug.cgi?id=42783

        * WebView/WebView.mm:
        (+[WebView _registerURLSchemeAsSecure:]):
        (+[WebView registerURLSchemeAsLocal:]):
2010-07-21  Brady Eidson  <beidson@apple.com>

        Reviewed by Geoffrey Garen.

        Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
        https://bugs.webkit.org/show_bug.cgi?id=42783

        No new tests. (No change in behavior)

        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::isMixedContent):
        (WebCore::FrameLoader::loadFrameRequest):

        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::SecurityOrigin):
        (WebCore::SecurityOrigin::canLoad):
        (WebCore::SecurityOrigin::isLocal):
        * page/SecurityOrigin.h:

        * platform/SchemeRegistry.cpp: Added.
        (WebCore::localSchemes):
        (WebCore::secureSchemes):
        (WebCore::schemesWithUniqueOrigins):
        (WebCore::SchemeRegistry::registerURLSchemeAsLocal):
        (WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal):
        (WebCore::SchemeRegistry::localURLSchemes):
        (WebCore::SchemeRegistry::shouldTreatURLAsLocal):
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsLocal):
        (WebCore::SchemeRegistry::registerURLSchemeAsNoAccess):
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsNoAccess):
        (WebCore::SchemeRegistry::registerURLSchemeAsSecure):
        (WebCore::SchemeRegistry::shouldTreatURLSchemeAsSecure):
        * platform/SchemeRegistry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 21 Jul 2010 23:16:19 +0000 (23:16 +0000)]
2010-07-21  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Assertion failure in AnimationBase::updateStateMachine() coming out of paused state
        https://bugs.webkit.org/show_bug.cgi?id=37993

        Added logic to properly handle pausing and resuming when in the
        AnimationStateStartWaitStyleAvailable state. This was causing an
        assert when going out of the pause state because the paused flag
        was not set.

        The fix is a straightforward implementation, going into a new
        AnimationStatePausedWaitStyleAvailable state and setting the paused
        flag (actually setting the m_pauseTime variable to something other
        than -1). Also added handling of the new state, both when the
        "style available" callback comes in while in this state and when
        unpausing while in this state.

        For now a LayoutTest is not possible since there's no way to go in
        and out of the pause state. I've opened https://bugs.webkit.org/show_bug.cgi?id=42790
        to track this.

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::updateStateMachine):
        * page/animation/AnimationBase.h:
        (WebCore::AnimationBase::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Peter Beverloo <peter@lvp-media.com>
commit-queue@webkit.org [Wed, 21 Jul 2010 22:59:20 +0000 (22:59 +0000)]
2010-07-21  Peter Beverloo  <peter@lvp-media.com>

        Reviewed by Darin Adler.

        Updated six more layout tests from -khtml to -webkit
        https://bugs.webkit.org/show_bug.cgi?id=42788

        This is a follow up to r63854 and r63857

        * css3/khtml-background-size-0x0-bmp.html:
        * editing/deleting/delete-3959464-fix.html:
        * editing/deleting/delete-and-undo.html:
        * editing/deleting/delete-at-paragraph-boundaries-001.html:
        * editing/deleting/delete-at-paragraph-boundaries-002.html:
        * editing/deleting/delete-at-paragraph-boundaries-003.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 21 Jul 2010 22:46:47 +0000 (22:46 +0000)]
2010-07-21  Adam Barth  <abarth@webkit.org>

        Skip html5lib/runner.html on these platforms because the
        <keygen> element creates a different DOM.  I need to
        investigate why they're getting a different DOM, but I don't
        have time to do that right now.

        * platform/gtk/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Bo Liu <boliu@chromium.org>
scherkus@chromium.org [Wed, 21 Jul 2010 22:12:16 +0000 (22:12 +0000)]
2010-07-21  Bo Liu  <boliu@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Add chromium WebMediaPlayer to PlatformMedia
        https://bugs.webkit.org/show_bug.cgi?id=41295

        * platform/graphics/MediaPlayer.h:
        (WebCore::PlatformMedia::):

2010-07-21  Bo Liu  <boliu@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Add chromium WebMediaPlayer to PlatformMedia
        https://bugs.webkit.org/show_bug.cgi?id=41295

        * WebKit.gyp:
        * public/WebMediaElement.h: Added.
        * src/WebMediaElement.cpp: Added.
        (WebKit::WebMediaElement::player):
        (WebKit::WebMediaElement::WebMediaElement):
        (WebKit::WebMediaElement::operator=):
        (WebKit::WebMediaElement::operator PassRefPtr<HTMLMediaElement>):
        * src/WebMediaPlayerClientImpl.cpp:
        (WebKit::WebMediaPlayerClientImpl::fromMediaElement):
        (WebKit::WebMediaPlayerClientImpl::mediaPlayer):
        (WebKit::WebMediaPlayerClientImpl::platformLayer):
        (WebKit::WebMediaPlayerClientImpl::platformMedia):
        * src/WebMediaPlayerClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 21 Jul 2010 21:41:28 +0000 (21:41 +0000)]
2010-07-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Pull HTML5lib test suite from upstream
        https://bugs.webkit.org/show_bug.cgi?id=42776

        Grab a bunch of new tests from html5lib upstream.  Also, upstream
        tweaked some of our tests, so I've updated our tests to match the
        upstream tweaks.

        * html5lib/resources/adoption01.dat:
        * html5lib/resources/doctype01.dat:
        * html5lib/resources/scripted/adoption01.dat: Added.
        * html5lib/resources/scripted/webkit01.dat: Added.
        * html5lib/resources/tests1.dat:
        * html5lib/resources/tests17.dat: Added.
        * html5lib/resources/tests18.dat: Added.
        * html5lib/resources/tests19.dat: Added.
        * html5lib/resources/tests2.dat:
        * html5lib/resources/tests20.dat: Added.
        * html5lib/resources/tricky01.dat:
        * html5lib/resources/webkit01.dat:
        * html5lib/runner-expected-html5.txt:
        * html5lib/runner-expected.txt:
        * html5lib/runner.html:
        * html5lib/webkit-resumer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 21 Jul 2010 21:16:37 +0000 (21:16 +0000)]
2010-07-21  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        convert more layout tests from -khtml to -webkit
        https://bugs.webkit.org/show_bug.cgi?id=42786

        This is a follow up to r63854.

        * fast/backgrounds/size/backgroundSize02.html:
        * fast/backgrounds/size/backgroundSize03.html:
        * fast/backgrounds/size/backgroundSize04.html:
        * fast/backgrounds/size/backgroundSize05.html:
        * fast/backgrounds/size/backgroundSize06.html:
        * fast/backgrounds/size/backgroundSize07.html:
        * fast/backgrounds/size/backgroundSize08.html:
        * fast/backgrounds/size/backgroundSize09.html:
        * fast/backgrounds/size/backgroundSize10.html:
        * fast/backgrounds/size/backgroundSize11.html:
        * fast/backgrounds/size/backgroundSize12.html:
        * fast/backgrounds/size/backgroundSize13.html:
        * fast/backgrounds/size/backgroundSize14.html:
        * fast/backgrounds/size/backgroundSize15.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 21 Jul 2010 21:07:11 +0000 (21:07 +0000)]
2010-07-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        Composited layers don't scroll in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=42771

        Prep work: FrameView::scrollPositionChanged() sounds like a generic "did scroll" bottleneck,
        but this is deceiving. It's only every called on one platform (Mac) when the NSScrollView gets
        scrolled, so rename it to FrameView::scrollPositionChangedViaPlatformWidget().

        * WebCore.exp.in:
        * page/FrameView.cpp:
        (WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
        * page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHandle broken pipes in more places in CoreIPC
aroben@apple.com [Wed, 21 Jul 2010 20:54:30 +0000 (20:54 +0000)]
Handle broken pipes in more places in CoreIPC

Fixes <http://webkit.org/b/42784> Assertion failure in
Connection::readEventHandler when WebKitTestRunner exits

Reviewed by Anders Carlsson.

* Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::readEventHandler): Check for a broken pipe
whenever we call ::PeekNamedPipe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Peter Beverloo <peter@lvp-media.com>
commit-queue@webkit.org [Wed, 21 Jul 2010 20:39:15 +0000 (20:39 +0000)]
2010-07-21  Peter Beverloo  <peter@lvp-media.com>

        Reviewed by Eric Carlson.

        Removed support for the -khtml CSS vendor prefix and limit the
        -apple prefix to two properties (dashboard-region and line-clamp).

        Listed properties in these updated have been changed to -webkit.

        * fast/block/positioning/height-change.html: -apple-box
        * fast/block/positioning/resources/window-height-change-frame-flex.html: -apple-box
        * fast/borders/border-image-omit-right-slice.html: -khtml-border-image
        * fast/css/apple-prefix.html: -khtml-box-orient
        * fast/css/legacy-opacity-styles-expected.txt: -*-opacity
        * fast/css/legacy-opacity-styles.html: -*-opacity
        * fast/css/limited-vendor-prefix-behavior-expected.txt: Added.
        * fast/css/limited-vendor-prefix-behavior.html: Added.
        * fast/flexbox/001.html: -khtml-box-flex
        * fast/flexbox/002.html: -khtml-box, -khtml-box-align, -khtml-box-orient
        * fast/flexbox/003.html: -khtml-box, -khtml-box-align, -khtml-box-orient
        * fast/flexbox/004.html: -khtml-box
        * fast/flexbox/005.html: -khtml-box
        * fast/flexbox/006.html: -khtml-box
        * fast/flexbox/007.html: -khtml-box
        * fast/flexbox/008.html: -khtml-box
        * fast/flexbox/009.html: -khtml-box
        * fast/flexbox/010.html: -khtml-box
        * fast/flexbox/011.html: -khtml-box, -khtml-box-flex
        * fast/flexbox/012.html: -khtml-box, -khtml-box-orient, -khtml-box-align
        * fast/flexbox/013.html: -khtml-box, -khtml-box-flex
        * fast/flexbox/014.html: -khtml-box, -khtml-box-orient, -khtml-box-flex
        * fast/flexbox/015.html: -khtml-box, -khtml-box-flex, -khtml-box-flex
        * fast/flexbox/016.html: -khtml-box-flex, -khtml-box, -khtml-box-orient
        * fast/flexbox/017.html: -khtml-box, -khtml-box-orient, -webkit-box-pack, -khtml-box-direction
        * fast/flexbox/018.html: -khtml-box, -khtml-box-orient, -khtml-box-pack
        * fast/flexbox/019.html: -khtml-box, -khtml-box-pack, -khtml-box-orient
        * fast/flexbox/020.html: -khtml-box, -khtml-box-flex-group, -khtml-box-flex
        * fast/flexbox/021.html: -khtml-box, -khtml-box-flex
        * fast/flexbox/022.html: -khtml-box, -khtml-box-flex
        * fast/flexbox/023.html: -khtml-box
        * fast/flexbox/024.html: -khtml-box, -khtml-box-orient
        * fast/flexbox/025.html: -khtml-box, -khtml-box-flex
        * fast/flexbox/026.html: -khtml-box, -khtml-box-flex
        * fast/flexbox/child-flexing.html: -khtml-box, -khtml-box-align, -khtml-box-orient
        * fast/repaint/flexible-box-overflow-horizontal.html: -khtml-box, -khtml-box-align, -khtml-box-orient
        * fast/repaint/flexible-box-overflow.html: -khtml-box, -khtml-box-align, -khtml-box-orient
2010-07-21  Peter Beverloo  <peter@lvp-media.com>

        Reviewed by Eric Carlson.

        Removed support for the -khtml CSS vendor prefix and limit the
        -apple prefix to two properties (dashboard-region and line-clamp).

        Test: fast/css/limited-vendor-prefix-behavior.html

        * css/CSSParser.cpp:
        (WebCore::cssPropertyID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.
kevino@webkit.org [Wed, 21 Jul 2010 20:30:59 +0000 (20:30 +0000)]
[wx] Build fix, adding the WebCore/bindings/generic dir to the list of build dirs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTeach CoreIPC how to handle messages that are larger than the pipe's buffer
aroben@apple.com [Wed, 21 Jul 2010 20:25:05 +0000 (20:25 +0000)]
Teach CoreIPC how to handle messages that are larger than the pipe's buffer

::GetOverlappedResult and ::ReadFile can fail with ERROR_MORE_DATA
when there is more data available on the pipe than was requested in
the read operation. In those cases, the appropriate response is to
perform another read operation to read the extra data. We now do this.

Also, MSDN says that, because we are doing asynchronous read
operations, we should not pass a pointer to ::ReadFile to find out how
many bytes were read. Instead we should always call
::GetOverlappedResult to find this out. I've changed
Connection::readEventHandler to have a single loop that calls
::GetOverlappedResult and ::ReadFile in alternation, rather than
sometimes calling ::ReadFile multiple times in a row, to satisfy this
requirement.

In order to simplify the logic in this function, I've made us request
only a single byte from the pipe when there are no messages already in
the pipe. (Previously we were requesting 4096 bytes in this case.)
This allows us not to have to consider the case where the received
message is smaller than our read buffer. If we decide that this has a
negative impact on performance, we can of course change it. I've
mitigated this somewhat by using ::PeekNamedMessage to find out the
size of the next message in the pipe (if any), so that we can read it
all in one read operation.

Fixes <http://webkit.org/b/42710> <rdar://problem/8197571> Assertion
in Connection::readEventHandler when launching WebKitTestRunner

Reviewed by Anders Carlsson.

* Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::readEventHandler): Put the call to
::GetOverlappedResult in the same loop as ::ReadFile so that we will
call them alternately. If ::GetOverlappedResult fails with
ERROR_MORE_DATA, use ::PeekNamedPipe to determine the size of the rest
of the message, then read it from the pipe. After dispatching the
message, use ::PeekNamedPipe to find out the size of the next message
in the pipe so we can read it all in one operation. If there's no
message in the pipe, we'll request just a single byte of the next
message that becomes available, and Windows will tell us when the rest
of the message is ready. If ::ReadFile fails with ERROR_MORE_DATA it
means there is data available now even though we didn't think there
was any. We go back to the top of the loop in this case and call
::GetOverlappedResult again to retrieve the available data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 21 Jul 2010 20:23:37 +0000 (20:23 +0000)]
2010-07-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Fix the last tree HTML5 tree builder crashes
        https://bugs.webkit.org/show_bug.cgi?id=42773

        This patch changes the internal representation of a bookmark to handle
        the case where one of the adjecent entries in the list of active
        formatting elements is actually a marker.

        After this patch, the bookmarking mechanism isn't as general, but it
        works for the cases we need in the adoption agency.

        Also, after this patch, there aren't any more known crashers in the
        HTML5 tree builder.  :)

        * html/HTMLFormattingElementList.cpp:
        (WebCore::HTMLFormattingElementList::bookmarkFor):
        (WebCore::HTMLFormattingElementList::swapTo):
        * html/HTMLFormattingElementList.h:
        (WebCore::HTMLFormattingElementList::Bookmark::Bookmark):
        (WebCore::HTMLFormattingElementList::Bookmark::moveToAfter):
        (WebCore::HTMLFormattingElementList::Bookmark::hasBeenMoved):
        (WebCore::HTMLFormattingElementList::Bookmark::mark):
        (WebCore::HTMLFormattingElementList::first):
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPatch for https://bugs.webkit.org/show_bug.cgi?id=42539
weinig@apple.com [Wed, 21 Jul 2010 20:10:22 +0000 (20:10 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=42539
WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages

Reviewed by Anders Carlsson.

WebKit2:

- Convert injected bundle UIClient functions to will-style, at least until we establish
  more concrete use cases for them past the TestRunner.

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::willAddMessageToConsole):
(WebKit::InjectedBundlePageUIClient::willSetStatusbarText):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptAlert):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptConfirm):
(WebKit::InjectedBundlePageUIClient::willRunJavaScriptPrompt):
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::addMessageToConsole):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::setStatusbarText):

WebKitTools:

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::_willAddMessageToConsole):
(WTR::InjectedBundlePage::_willSetStatusbarText):
(WTR::InjectedBundlePage::_willRunJavaScriptAlert):
(WTR::InjectedBundlePage::_willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::_willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

LayoutTests:

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Wed, 21 Jul 2010 19:38:41 +0000 (19:38 +0000)]
2010-07-21  Tony Gentilcore  <tonyg@chromium.org>

        Unreviewed build fix.

        Disable overzealous ASSERT
        https://bugs.webkit.org/show_bug.cgi?id=42775

        No new tests because no changed functionality.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 21 Jul 2010 19:27:29 +0000 (19:27 +0000)]
2010-07-21  Simon Fraser  <simon.fraser@apple.com>

        Windows build fix.

        Need to supply implementations of PageClient::pageDidEnterAcceleratedCompositing()
        and pageDidLeaveAcceleratedCompositing() for WebView on Windows.

        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::pageDidEnterAcceleratedCompositing):
        (WebKit::WebView::pageDidLeaveAcceleratedCompositing):
        * UIProcess/win/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Yael Aharon <yael.aharon@nokia.com>
yael.aharon@nokia.com [Wed, 21 Jul 2010 18:38:12 +0000 (18:38 +0000)]
2010-07-21  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Darin Adler.

        Crash in Notification::disconnectFrame() triggered by Frame::lifeSupportTimerFired()
        https://bugs.webkit.org/show_bug.cgi?id=42534

        Call NotificationsCenter::disconnectFrame() when the frame is disconnected from the page.
        Calling it from the destructor of Frame is too late and sometimes causes access violation.
        I was not able to reproduce this crash, so did not add new tests.
        This patch is based on the error reported in
        http://code.google.com/p/chromium/issues/detail?id=49323.

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::pageDestroyed):
        * page/DOMWindow.h:
        * page/Frame.cpp:
        (WebCore::Frame::pageDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't assert when clicking on a plug-in in WebKit2
andersca@apple.com [Wed, 21 Jul 2010 18:16:02 +0000 (18:16 +0000)]
Don't assert when clicking on a plug-in in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42762

Reviewed by Sam Weinig.

WebCore:

Remove a now invalid assert and return false instead.

* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):

WebKit2:

Add stub for PluginView::handleEvent.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::handleEvent):
* WebProcess/Plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Wed, 21 Jul 2010 18:14:12 +0000 (18:14 +0000)]
2010-07-21  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        [v8] Revert r60670 as it introduced a regression: in some cases named children couldn't be retrieved.
        https://bugs.webkit.org/show_bug.cgi?id=42766

        See http://code.google.com/p/chromium/issues/detail?id=48804 for more details.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::namedItemAdded):
        (WebCore::ScriptController::namedItemRemoved):
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::updateDocumentWrapperCache):
        * bindings/v8/V8DOMWindowShell.h:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):
        * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
        (WebCore::V8HTMLDocument::namedPropertyDeleter):
        (WebCore::V8HTMLDocument::namedPropertyGetter):
        (WebCore::V8HTMLDocument::indexedPropertyGetter):
        (WebCore::V8HTMLDocument::allAccessorSetter):
        (WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 21 Jul 2010 17:53:50 +0000 (17:53 +0000)]
2010-07-21  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Update plug-in proxy backed <video> and <audio> elements.
        https://bugs.webkit.org/show_bug.cgi?id=42770
        <rdar://problem/7963467>

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::attributeChanged): Only call m_player->setControls when
        the 'controls' attribute changes.
        (WebCore::HTMLMediaElement::createRenderer):
        (WebCore::HTMLMediaElement::attach): If we have a proxy widget, call the WebFrameLoaderClient's
        'hide' and 'show' methods for the media proxy plug-in to make sure we remove and re-add the
        plug-in's view to the global list of plugin views.
        (WebCore::HTMLMediaElement::createMediaPlayerProxy): Bail if m_proxyWidget is non-NULL

        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::hideMediaPlayerProxyPlugin): Empty stub method.
        (WebCore::EmptyFrameLoaderClient::showMediaPlayerProxyPlugin): Ditto.

        * loader/FrameLoader.cpp:
        * loader/FrameLoaderClient.h:
        * loader/SubframeLoader.cpp:
        (WebCore::FrameLoader::loadMediaPlayerProxyPlugin): Always set m_containsPlugIns in loadMediaPlayerProxyPlugin(),
         even when we don't have a renderer.
        (WebCore::FrameLoader::hideMediaPlayerProxyPlugin): New, call hideMediaPlayerProxyPlugin.
        (WebCore::FrameLoader::showMediaPlayerProxyPlugin): New, call showMediaPlayerProxyPlugin.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::NullMediaPlayerPrivate::setControls):
        (WebCore::MediaPlayer::setControls): New, pass through to media engine.
        (WebCore::MediaPlayer::enterFullscreen): Ditto.
        (WebCore::MediaPlayer::exitFullscreen): Ditto.
        * platform/graphics/MediaPlayer.h:
        * platform/graphics/MediaPlayerPrivate.h:
        (WebCore::MediaPlayerPrivateInterface::setControls):
        (WebCore::MediaPlayerPrivateInterface::enterFullscreen):
        (WebCore::MediaPlayerPrivateInterface::exitFullscreen):

2010-07-21  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Simon Fraser.

        Update plug-in proxy backed <video> and <audio> elements.
        https://bugs.webkit.org/show_bug.cgi?id=42770
        <rdar://problem/7963467>

        * Plugins/WebPluginController.h:
        * Plugins/WebPluginController.mm:
        (-[WebPluginController dealloc]): Release _viewsNotInDocument.
        (-[WebPluginController stopAllPlugins]): Stop plug-ins not in the document.
        (-[WebPluginController pluginViewCreated:]): New, add a View (plug-in) to _viewsNotInDocument.
        (+[WebPluginController pluginViewHidden:]): New, remove the view (plug-in) from pluginViews.
        (-[WebPluginController addPlugin:]): Remove the new plug-in from _viewsNotInDocument.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createPlugin): Remove PLUGIN_PROXY_FOR_VIDEO code, the media
        player proxy plug-in should never be allocated by this method.
        (WebFrameLoaderClient::createMediaPlayerProxyPlugin): New, allocate a media player proxy.

        * WebView/WebView.mm:
        (-[WebView _videoProxyPluginForMIMEType:]): New. Identical to _pluginForMIMEType except it doesn't
        consider the arePlugInsEnabled preference.
        * WebView/WebViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 21 Jul 2010 17:51:25 +0000 (17:51 +0000)]
2010-07-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        Get accelerated compositing working with webkit2
        https://bugs.webkit.org/show_bug.cgi?id=41084

        Hook up dynamic DrawingArea switching, so that when the WebProcess hits a page
        that requires accelerated compositing, we switch to the LayerBackedDrawingArea.

        * Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
        (DrawingAreaProxyMessage::):
        * Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
        (WebPageProxyMessage::):
        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::pageDidEnterAcceleratedCompositing):
        (WebKit::PageClientImpl::pageDidLeaveAcceleratedCompositing):
        * UIProcess/API/mac/WKView.mm:
        (-[WKView _startAcceleratedCompositing:]):
        (-[WKView _switchToDrawingAreaTypeIfNecessary:DrawingAreaProxy::]):
        (-[WKView _pageDidEnterAcceleratedCompositing]):
        (-[WKView _pageDidLeaveAcceleratedCompositing]):
        * UIProcess/API/mac/WKViewInternal.h:
        * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
        (WebKit::ChunkedUpdateDrawingAreaProxy::didReceiveSyncMessage):
        * UIProcess/ChunkedUpdateDrawingAreaProxy.h:
        * UIProcess/DrawingAreaProxy.h:
        (WebKit::DrawingAreaProxy::):
        (WebKit::DrawingAreaProxy::type):
        * UIProcess/LayerBackedDrawingAreaProxy.cpp:
        (WebKit::LayerBackedDrawingAreaProxy::didSetSize):
        (WebKit::LayerBackedDrawingAreaProxy::didReceiveMessage):
        (WebKit::LayerBackedDrawingAreaProxy::didReceiveSyncMessage):
        * UIProcess/LayerBackedDrawingAreaProxy.h:
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::setDrawingArea):
        (WebKit::WebPageProxy::didReceiveSyncMessage):
        (WebKit::WebPageProxy::didEnterAcceleratedCompositing):
        (WebKit::WebPageProxy::didLeaveAcceleratedCompositing):
        * UIProcess/WebPageProxy.h:
        * UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
        (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::attachRootGraphicsLayer):
        * WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
        (WebKit::ChunkedUpdateDrawingArea::attachCompositingContext):
        (WebKit::ChunkedUpdateDrawingArea::setRootCompositingLayer):
        * WebProcess/WebPage/DrawingArea.cpp:
        (WebKit::DrawingArea::create):
        * WebProcess/WebPage/DrawingArea.h:
        (WebKit::DrawingArea::):
        (WebKit::DrawingArea::type):
        * WebProcess/WebPage/LayerBackedDrawingArea.cpp:
        (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea):
        (WebKit::LayerBackedDrawingArea::setNeedsDisplay):
        (WebKit::LayerBackedDrawingArea::setSize):
        (WebKit::LayerBackedDrawingArea::didUpdate):
        (WebKit::LayerBackedDrawingArea::setRootCompositingLayer):
        * WebProcess/WebPage/LayerBackedDrawingArea.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::changeAcceleratedCompositingMode):
        (WebKit::WebPage::enterAcceleratedCompositingMode):
        (WebKit::WebPage::exitAcceleratedCompositingMode):
        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm:
        (WebKit::LayerBackedDrawingArea::platformInit):
        (WebKit::LayerBackedDrawingArea::attachCompositingContext):
        (WebKit::LayerBackedDrawingArea::detachCompositingContext):
        (WebKit::LayerBackedDrawingArea::setRootCompositingLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 21 Jul 2010 17:46:09 +0000 (17:46 +0000)]
2010-07-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Make more members of CSSStyleSelector private.
        https://bugs.webkit.org/show_bug.cgi?id=42757

        No change in behavior, so no new tests.

        * css/CSSStyleSelector.h: Made a publicly-unused methods private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Finnur Thorarinsson <finnur.webkit@gmail.com>
commit-queue@webkit.org [Wed, 21 Jul 2010 17:44:36 +0000 (17:44 +0000)]
2010-07-21  Finnur Thorarinsson  <finnur.webkit@gmail.com>

        Reviewed by Dimitri Glazkov.

        Avoid crashing during find-in-page when |view| is NULL.
        https://bugs.webkit.org/show_bug.cgi?id=42760

        There are no layout tests because we don't have a repro case
        to work with, so this is a speculative fix based on crash dump
        diagnosis. See bug for details.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::shouldScopeMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 21 Jul 2010 17:36:30 +0000 (17:36 +0000)]
2010-07-21  Tony Chang  <tony@chromium.org>

        Not reviewed, updating chromium test expectations.

        Remove expectations for tests that were moved to platform/mac in r63616.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 21 Jul 2010 17:32:20 +0000 (17:32 +0000)]
2010-07-21  Tony Chang  <tony@chromium.org>

        Not reviewed, updating chromiumg test expectations.

        * platform/chromium/test_expectations.txt: Marking remember-bad-password.html and
            401-logout.php as failing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 21 Jul 2010 17:30:53 +0000 (17:30 +0000)]
2010-07-21  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Adler.

        Add a diagram explaining how a DOM element is attached to the site.
        https://bugs.webkit.org/show_bug.cgi?id=42763

        * coding/dom-element-attach.html: Added.
        * coding/images/dom-element-attach-large.png: Added.
        * coding/images/dom-element-attach-small.png: Added.
        * coding/images/dom-element-attach.graffle: Added.
        * coding/technical-articles.html: Added a link to the page with the diragram.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 21 Jul 2010 17:26:19 +0000 (17:26 +0000)]
2010-07-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: consider jQuery object to be of array nature.

        https://bugs.webkit.org/show_bug.cgi?id=42758

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago https://bugs.webkit.org/show_bug.cgi?id=42717
ap@apple.com [Wed, 21 Jul 2010 17:20:30 +0000 (17:20 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=42717
        <rdar://problem/7062824> A wrong password entered for site or proxy auth remains in WebCore
        credential storage, and is sent with subsequent requests

WebCore:
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Don't use that direct a
        copy/paste, oops!

LayoutTests:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        Skip the new tests, they don't pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 21 Jul 2010 16:55:56 +0000 (16:55 +0000)]
2010-07-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        When GraphicsLayer::contentsOrientation() is CompositingCoordinatesBottomUp, need to flip repaint rects
        https://bugs.webkit.org/show_bug.cgi?id=42662

        If the contentsOrientation() on a GraphicsLayer is CompositingCoordinatesBottomUp, then we
        need to flip the rects passed to setNeedsDisplayInRect:.

        Avoid writing this code twice by making a bare function to share code
        between WebLayer and WebTiledLayer. Convert the existing +drawContents:ofLayer:intoContext:
        class method into a bare function, because the Obj-C calling overhead doesn't buy us anything.

        Take out an assertion in GraphicsLayerCA::updateContentsTransform() that is not
        correct.

        No new tests because no layers use bottom-up contents at present.

        * platform/graphics/mac/GraphicsLayerCA.mm:
        (WebCore::GraphicsLayerCA::updateContentsTransform):
        * platform/graphics/mac/WebLayer.h:
        * platform/graphics/mac/WebLayer.mm:
        (drawLayerContents):
        (setLayerNeedsDisplayInRect):
        (-[WebLayer setNeedsDisplayInRect:]):
        (-[WebLayer drawInContext:]):
        * platform/graphics/mac/WebTiledLayer.mm:
        (-[WebTiledLayer setNeedsDisplayInRect:]):
        (-[WebTiledLayer drawInContext:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Wed, 21 Jul 2010 16:42:07 +0000 (16:42 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=42717
        <rdar://problem/7062824> A wrong password entered for site or proxy auth remains in WebCore
        credential storage, and is sent with subsequent requests

        Tests: http/tests/security/401-logout/401-logout.php
               http/tests/xmlhttprequest/remember-bad-password.html

        * platform/network/CredentialStorage.cpp: (WebCore::CredentialStorage::remove):
        * platform/network/CredentialStorage.h:
        Added a way to remove stored credentials for a given protection space.

        * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        * platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
        Remove stored credentials if they didn't work the first time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScriptCore: WebKit on Windows should build optionally with an unversioned ICU DLL
sfalken@apple.com [Wed, 21 Jul 2010 16:39:59 +0000 (16:39 +0000)]
JavaScriptCore: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211743> JavaScriptCore needs to link against unversioned ICU

Reviewed by Adam Roben.

Dynamically create a new header, ICUVersion.h, as part of build-generated-files.sh.
Header contains a preprocessor define (U_DISABLE_RENAMING) indicating to ICU whether the ICU API
should be namespaced with the current ICU version number. Proper value is determined
by checking for the presence of libicuuc.lib, the unversioned copy of ICU.

To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.

Since the versioned and unversioned ICU have different filenames (libicuuc.lib vs icuuc.lib)
we copy the ICU lib to an intermediate location under obj with a common name. This
allows us to link properly with either without adding a new build configuration.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.
* JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Generate ICUVersion.h
* JavaScriptCore.vcproj/WTF/WTFCommon.vsprops: Add forced include of ICUVersion.h.
* JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.
* JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.

WebCore: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211767> WebKit needs to link against unversioned ICU

Reviewed by Adam Roben.

To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.

* WebCore.vcproj/WebCore.vcproj:
Add forced include of ICUVersion.h.
* WebCore.vcproj/WebCoreCommon.vsprops: Add forced include of ICUVersion.h.

WebKit/win: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211767> WebKit needs to link against unversioned ICU

Reviewed by Adam Roben.

To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.

* WebKit.vcproj/WebKit.vcproj: Add forced include of ICUVersion.h.

WebKit2: WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211767> WebKit needs to link against unversioned ICU

Reviewed by Adam Roben.

To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.

Since the versioned and unversioned ICU have different filenames (libicuuc.lib vs icuuc.lib)
we copy the ICU lib to an intermediate location under obj with a common name. This
allows us to link properly with either without adding a new build configuration.

* win/WebKit2Common.vsprops:
Copy ICU libs into a common location with a common name.
Add additional library search path to pick up icu lib.
Change ICU library filename specified to linker.
Add forced include of ICUVersion.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix
aroben@apple.com [Wed, 21 Jul 2010 16:31:15 +0000 (16:31 +0000)]
Windows build fix

* Shared/win/UpdateChunk.h:
(WebKit::UpdateChunk::isEmpty): Added to match the Mac definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLand file I forgot to add.
andersca@apple.com [Wed, 21 Jul 2010 16:04:28 +0000 (16:04 +0000)]
Land file I forgot to add.

* WebProcess/com.apple.WebProcess.sb: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove WebKit2WebProcess's settings to a vsprops file
aroben@apple.com [Wed, 21 Jul 2010 16:01:51 +0000 (16:01 +0000)]
Move WebKit2WebProcess's settings to a vsprops file

Fixes <http://webkit.org/b/42751> WebKit2WebProcess should use vsprops
files

Reviewed by Darin Adler.

* win/WebKit2WebProcess.vcproj: Moved settings from here...
* win/WebKit2WebProcessCommon.vsprops: ...to here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGive InjectedBundle our standard set of configurations (minus the *_Cairo variants)
aroben@apple.com [Wed, 21 Jul 2010 16:01:33 +0000 (16:01 +0000)]
Give InjectedBundle our standard set of configurations (minus the *_Cairo variants)

InjectedBundle's Debug_All configuration was the same as is Debug
configuration, and it was missing a Debug_Internal configuration.

Fixes <http://webkit.org/b/42749> InjectedBundle's build
configurations are screwy

Reviewed by Darin Adler.

WebKit/win:

Update WebKit.sln for InjectedBundle's Debug_Internal configuration

* WebKit.vcproj/WebKit.sln: Build the Debug_Internal variant of
InjectedBundle when we're using the Debug_Internal solution
configuration.

WebKitTools:

* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: Added
debug_internal.vsprops and debug_all.vsprops to the Debug_All
configuration. Added a Debug_Internal configuration.

* WebKitTestRunner/WebKitTestRunner.sln: Build the Debug_Internal
variant of InjectedBundle when we're using the Debug_Internal solution
configuration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove InjectedBundle's settings to a vsprops file
aroben@apple.com [Wed, 21 Jul 2010 16:01:14 +0000 (16:01 +0000)]
Move InjectedBundle's settings to a vsprops file

This will make it easier to change settings for all configurations,
and to add new configurations.

Fixes <http://webkit.org/b/42748> InjectedBundle should use vsprops
files

Reviewed by Darin Adler.

* WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added.
Moved settings here...
* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj: ...from
here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd MiniBrowser to WebKit.sln
aroben@apple.com [Wed, 21 Jul 2010 16:00:51 +0000 (16:00 +0000)]
Add MiniBrowser to WebKit.sln

It is the last project to build.

Fixes <http://webkit.org/b/42747> build-webkit should build
MiniBrowser

Reviewed by Darin Adler.

* WebKit.vcproj/WebKit.sln: Added MiniBrowser, and made it depend on
WebKitTestRunner.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGive MiniBrowser our standard set of configurations (minus the *_Cairo variants)
aroben@apple.com [Wed, 21 Jul 2010 15:53:46 +0000 (15:53 +0000)]
Give MiniBrowser our standard set of configurations (minus the *_Cairo variants)

MiniBrowser already had a configuration called "Release", but it was
using mostly the same settings as Debug. And its Debug configuration
was using the settings that Debug_Internal should be using.

Fixes <http://webkit.org/b/42746> MiniBrowser's build configurations
are screwy

Reviewed by Darin Adler.

* MiniBrowser/MiniBrowser.vcproj: Removed debug_internal.vsprops from
the Debug configuration. Remove debug.vsprops and
debug_internal.vsprops from the Release configuration and replace them
with release.vsprops. Added Debug_Internal and Debug_All
configurations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReviewed and tweaked by Anders Carlsson and Sam Weinig.
andersca@apple.com [Wed, 21 Jul 2010 15:53:31 +0000 (15:53 +0000)]
Reviewed and tweaked by Anders Carlsson and Sam Weinig.

Patch by Ivan Krstić <ike@apple.com> on 2010-07-20
Put WebProcess in a sandbox. All of the following changes are
Mac-only.
<rdar://problem/7865269>

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
Send Sandbox extension for injected bundle to WebProcess.

* WebKit2.xcodeproj/project.pbxproj:
Add Sandbox profile to Resources for WebProcess.

* WebProcess/InjectedBundle/InjectedBundle.h:
New function InjectedBundle::setSandboxToken.

* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
(WebKit::InjectedBundle::load):
Consume Sandbox token for the bundle if present.

(WebKit::InjectedBundle::setSandboxToken):
Set Sandbox token for the bundle.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::loadInjectedBundle):
Extra function parameter for Sandbox token.

(WebKit::WebProcess::didReceiveMessage):
Pass Sandbox token to loadInjectedBundle().

* WebProcess/WebProcess.h:
Extra function parameter for Sandbox token in loadInjectedBundle().

* WebProcess/com.apple.WebProcess.sb: Added.
Sandbox profile for WebProcess.

* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
Initialize Sandbox, exit on failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove MiniBrowser's settings to a vsprops file
aroben@apple.com [Wed, 21 Jul 2010 15:53:29 +0000 (15:53 +0000)]
Move MiniBrowser's settings to a vsprops file

This will make it easier to change settings for all configurations,
and to add new configurations.

MiniBrowser should use vsprops files
https://bugs.webkit.org/show_bug.cgi?id=42745

Reviewed by Darin Adler.

* MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added. Moved
settings here...
* MiniBrowser/MiniBrowser.vcproj: ...from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix compiler warnings when building MiniBrowser
aroben@apple.com [Wed, 21 Jul 2010 15:53:08 +0000 (15:53 +0000)]
Fix compiler warnings when building MiniBrowser

Also cleaned up the .vcproj a bit.

Fixes <http://webkit.org/b/42743>.

Reviewed by Darin Adler.

* MiniBrowser/MiniBrowser.vcproj: Removed all settings that are
already defined in .vsprops files. This also fixes a warning about
/EDITANDCONTINUE being incompatible with /SAFESEH.

* MiniBrowser/win/MiniBrowser.rc: Replaced afxres.h with winresrc.h so
that we stop getting warnings about ID_FILE_OPEN and ID_FILE_CLOSE
being redefined. (I think this will also get us closer to building
with VC++ Express.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Wed, 21 Jul 2010 15:51:18 +0000 (15:51 +0000)]
2010-07-21  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Serialization to JSON in InspectorValue works incorrect
        if comma is assigned as decimal separator. Windows with Russian locale.
        https://bugs.webkit.org/show_bug.cgi?id=42755

        * inspector/InspectorValues.cpp:
        (WebCore::InspectorBasicValue::writeJSON):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHandle WKView visibility changes
andersca@apple.com [Wed, 21 Jul 2010 15:43:08 +0000 (15:43 +0000)]
Handle WKView visibility changes
<rdar://problem/7891077>

Reviewed by Dan Bernstein.

* Shared/mac/UpdateChunk.h:
(WebKit::UpdateChunk::isEmpty):
Add convenience getter.

* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
Reorder the calls to _updateActiveState and _updateVisibility based on whether the view is moved to
a window or away from a window.

* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::ChunkedUpdateDrawingAreaProxy):
Initialize m_forceRepaintWhenResumingPainting to false.

(WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible):
Pass the m_forceRepaintWhenResumingPainting along to the DrawingAreaMessage::ResumePainting message.

(WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize):
Don't try to paint empty update chunks.

(WebKit::ChunkedUpdateDrawingAreaProxy::update):
Don't paint the update chunk if we're not visible. Instead, make sure that the entire page is being redrawn
when its shown again.

* UIProcess/ChunkedUpdateDrawingAreaProxy.h:
* WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
(WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea):
(WebKit::ChunkedUpdateDrawingArea::display):
(WebKit::ChunkedUpdateDrawingArea::suspendPainting):
Rename m_shouldPaint to m_isPaintingSuspended and invert its logic.

(WebKit::ChunkedUpdateDrawingArea::scheduleDisplay):
Don't schedule a display timer if the dirty rect is empty.

(WebKit::ChunkedUpdateDrawingArea::setSize):
If painting is suspended, just send back an empty update chunk in the DidSetSize message.

(WebKit::ChunkedUpdateDrawingArea::resumePainting):
If forceRepaint is true, repaint the entire drawing area.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 21 Jul 2010 15:14:07 +0000 (15:14 +0000)]
2010-07-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        CSS rotation transform can cause elements with certain styles to vanish during rotation.
        https://bugs.webkit.org/show_bug.cgi?id=42579

        Remove some untested, broken code that, as far as I can tell, could never get hit.
        Use the correct rect for the PaintInfo so that zero-sized elements with overflow:hidden
        but a border paint correctly.

        Test: compositing/overflow/zero-size-overflow.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::paintIntoLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
commit-queue@webkit.org [Wed, 21 Jul 2010 15:12:27 +0000 (15:12 +0000)]
2010-07-21  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Laszlo Gombos.

        [QT] Leak and few more fixes to qt port of geolocation
        https://bugs.webkit.org/show_bug.cgi?id=42753

        Fixes memory leak and default values set to attributes.

        Memory leak fix no new test case added.

        * platform/qt/GeolocationServiceQt.cpp: Added.
        (WebCore::GeolocationServiceQt::~GeolocationServiceQt):
        (WebCore::GeolocationServiceQt::positionUpdated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Wed, 21 Jul 2010 15:10:07 +0000 (15:10 +0000)]
Unreviewed.

[Qt] DRT sideeffect revealed by r63657
https://bugs.webkit.org/show_bug.cgi?id=42578

* platform/qt/Skipped: Unskip tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Kristian Amlie <kristian.amlie@nokia.com>
commit-queue@webkit.org [Wed, 21 Jul 2010 13:56:01 +0000 (13:56 +0000)]
2010-07-21  Kristian Amlie <kristian.amlie@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Added automatic sqlite extraction for Symbian to QtWebKit.

        Also added sqlite detection in case sqlite is not present in the SDK.
        This is possible if WebKit is compiled standalone.

        The inclusion part is a consequence of commit c578c6c1d6d in the Qt
        repository. It will not work on Qt versions < 4.7.1, but that is ok,
        since the only build system it will affect is marked as experimental
        in the whole 4.7 series.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Wed, 21 Jul 2010 13:48:37 +0000 (13:48 +0000)]
2010-07-21  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Gustavo Noronha Silva.

        Creating ChangeLog for the EFL port.

        * efl/ChangeLog: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 21 Jul 2010 12:53:21 +0000 (12:53 +0000)]
2010-07-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Associate elements with the active form
        https://bugs.webkit.org/show_bug.cgi?id=42728

        This patch fixes fast/forms/formmove3.html.  The test still doesn't
        pass due to some render tree differences, but it works as intended now.

        To fix this test, I needed to deviate from the spec slight.  Minefield
        seems to have the same deviation:
          - http://www.w3.org/Bugs/Public/show_bug.cgi?id=10216

        * html/HTMLConstructionSite.cpp:
        (WebCore::HTMLConstructionSite::takeForm):
        (WebCore::HTMLConstructionSite::setForm):
        (WebCore::HTMLConstructionSite::createHTMLElement):
        * html/HTMLConstructionSite.h:
        (WebCore::HTMLConstructionSite::form):
        * html/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTagForInBody):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63815 268f45cc-cd09-0410-ab3c-d52691b4dbfc