WebKit-https.git
17 years agoFix the css1 failure, since we now pass the test.
hyatt [Thu, 25 Sep 2003 22:42:00 +0000 (22:42 +0000)]
Fix the css1 failure, since we now pass the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed 3433802. Written by Ed. Carbon WebView doesn't detach native view when removed.
rjw [Thu, 25 Sep 2003 22:31:00 +0000 (22:31 +0000)]
Fixed 3433802.  Written by Ed.  Carbon WebView doesn't detach native view when removed.

        Reviewed by Richard.

        * Carbon.subproj/HIWebView.m:
        (OwningWindowChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed 3433488. Written by Ed. WebKit doesn't sync window visibility when new webvi...
rjw [Thu, 25 Sep 2003 22:26:47 +0000 (22:26 +0000)]
Fixed 3433488.  Written by Ed.  WebKit doesn't sync window visibility when new webview added to visible window.

        Reviewed by Richard.

        * Carbon.subproj/CarbonWindowAdapter.m:
        (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed 3434854. Written by Ed. Correctly handle window modality in carbon.
rjw [Thu, 25 Sep 2003 22:15:00 +0000 (22:15 +0000)]
Fixed 3434854.  Written by Ed.  Correctly handle window modality in carbon.

        Reviewed by Richard.

        * Carbon.subproj/CarbonWindowAdapter.m:
        (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):

2003-09-25  Maciej Stachowiak  <mjs@apple.com>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoTools:
mjs [Thu, 25 Sep 2003 21:09:03 +0000 (21:09 +0000)]
Tools:

        Reviewed by Darin.

        * Scripts/SourceTools.pm: Don't try to install Foundation on the
system any more. The new build setup takes care of it.
        * Scripts/embed-into-alex: Removed.
        * Scripts/embed-into-webkit: Added.

JavaScriptCore:

        Reviewed by Darin.

        * JavaScriptCore.pbproj/project.pbxproj: Don't hack install name. Instead
of embedding into Safari, embed into WebKit as sub-umbrella.
        * Makefile.am: Don't forget to rebuild if the user removes
JavaScript.framework from symroots manually.

WebCore:

        Reviewed by Darin.

        * WebCore.pbproj/project.pbxproj: Don't hack install name. Instead
of embedding into Safari, embed into WebKit as sub-umbrella.

WebKit:

        Reviewed by Darin.

Updated setup for engineering builds. Don't embed the framework
into Safari or hack the install name. However, do copy WebCore and
JavaScriptCore into the proper sub-umbrella locations.

        * WebKit.pbproj/project.pbxproj:
        * embed-frameworks.sh: Added.

WebBrowser:

        Reviewed by Darin.

Changed things around for the engineering Safari build. Instead of
building frameworks embedded, set DYLD_FRAMEWORK_PATH via the
Info.plist (for engineering builds only). This also removes the
need to install engineering builds of Foundation on the system.

        * WebBrowser.pbproj/project.pbxproj:
        * add-environment.sh: Added.
        * embed-frameworks.sh: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoThe tree is open for Safari-108!
vicki [Thu, 25 Sep 2003 20:43:54 +0000 (20:43 +0000)]
The tree is open for Safari-108!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoSafari-107 stamp.
vicki [Thu, 25 Sep 2003 20:40:57 +0000 (20:40 +0000)]
Safari-107 stamp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - rolled out change to fix 3390850 because it caused a performance regression
darin [Thu, 25 Sep 2003 19:59:23 +0000 (19:59 +0000)]
    - rolled out change to fix 3390850 because it caused a performance regression

        * khtml/misc/decoder.cpp: (Decoder::decode): Rolled out change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin
kocienda [Thu, 25 Sep 2003 17:06:27 +0000 (17:06 +0000)]
    Reviewed by Darin

        Fix for this bug:

        <rdar://problem/3341222>: WebView doesn't follow AppKit default nextKeyView pattern

        * WebCoreSupport.subproj/WebBridge.h: Added a variable to guard against recursion
        in -[WebBridge inNextKeyViewOutsideWebFrameViews].
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge inNextKeyViewOutsideWebFrameViews]): Accessor for recursion guard.
        (-[WebBridge nextKeyViewOutsideWebFrameViews]): Do not ask webView for its
        next key view, but rather, ask it for the next key view of the last view in
        its key view loop. This is what will get us to the next view outside of the
        webView.
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView nextKeyView]): Ask AppKit, rather than khtml, for the next key
        key view if -[WebBridge inNextKeyViewOutsideWebFrameViews] returns YES. Doing
        so gives us the correct answer as calculated by AppKit, and makes HTML views
        behave like other views. This check also heads off an infinite recursion
        through -[WebBridge nextKeyViewOutsideWebFrameViews].

Also did some cleanup of some code that was marked for removal "some day".
That "some day" is today.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John.
darin [Thu, 25 Sep 2003 17:00:02 +0000 (17:00 +0000)]
    Reviewed by John.

        - fixed 3176853 -- can't attach files that have no extensions with Yahoo mail (bad Content-Type headers)

        * WebCoreSupport.subproj/WebBridge.m: (-[WebBridge MIMETypeForPath:]):
        Return @"application/octet-stream" rather than nil or empty string when the type is not known.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave
kocienda [Thu, 25 Sep 2003 16:51:11 +0000 (16:51 +0000)]
    Reviewed by Dave

Name change: TextRun is now InlineTextBox. Some related names
have been changed as well. There should be no change in
behavior as a result of this patch.

        * khtml/khtml_part.cpp:
        (KHTMLPart::selectedText):
        (firstRunAt):
        (lastRunAt):
        (startAndEndLineNodesIncludingNode):
        * khtml/rendering/bidi.cpp:
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::paintLineBoxDecorations):
        * khtml/rendering/render_line.cpp:
        (InlineFlowBox::placeBoxesHorizontally):
        (InlineFlowBox::placeBoxesVertically):
        * khtml/rendering/render_line.h:
        * khtml/rendering/render_text.cpp:
        (InlineTextBox::detach):
        (throw):
        (InlineTextBox::operator delete):
        (InlineTextBox::paintSelection):
        (InlineTextBox::paintDecoration):
        (InlineTextBox::checkSelectionPoint):
        (InlineTextBoxArray::InlineTextBoxArray):
        (InlineTextBoxArray::compareItems):
        (InlineTextBoxArray::findFirstMatching):
        (RenderText::deleteRuns):
        (RenderText::findNextInlineTextBox):
        (RenderText::nodeAtPoint):
        (RenderText::checkSelectionPointIgnoringContinuations):
        (RenderText::cursorPos):
        (RenderText::posOfChar):
        (RenderText::paintObject):
        (RenderText::createInlineBox):
        (RenderText::position):
        (RenderText::width):
        * khtml/rendering/render_text.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::attributedString):
        * kwq/KWQRenderTreeDebug.cpp:
        (writeTextRun):
        (write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Added a new layout test.
darin [Thu, 25 Sep 2003 14:50:17 +0000 (14:50 +0000)]
    Added a new layout test.

        * layout-tests/fast/forms/form-element-geometry-expected.txt: Added.
        * layout-tests/fast/forms/form-element-geometry.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago * layout-tests/fast/table/003-expected.txt: Updated for textarea width change.
darin [Thu, 25 Sep 2003 06:36:18 +0000 (06:36 +0000)]
    * layout-tests/fast/table/003-expected.txt: Updated for textarea width change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdded marker now that the change was reviewed by Maciej.
darin [Thu, 25 Sep 2003 04:34:22 +0000 (04:34 +0000)]
Added marker now that the change was reviewed by Maciej.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago * WebView.subproj/WebHTMLView.m:
darin [Thu, 25 Sep 2003 04:28:55 +0000 (04:28 +0000)]
    * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
        Added one more call to _stopAutoscrollTimer for when drags begin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago*** empty log message ***
hyatt [Thu, 25 Sep 2003 00:47:40 +0000 (00:47 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdding clipping tests.
hyatt [Thu, 25 Sep 2003 00:44:44 +0000 (00:44 +0000)]
Adding clipping tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3429646, <img src="blah"<img src="foo"> should show up as two images.
hyatt [Thu, 25 Sep 2003 00:37:35 +0000 (00:37 +0000)]
Fix for 3429646, <img src="blah"<img src="foo"> should show up as two images.

        Reviewed by darin

        * khtml/html/htmlparser.cpp:
        (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks):
        * khtml/html/htmltokenizer.cpp:
        (HTMLTokenizer::parseTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
darin [Thu, 25 Sep 2003 00:09:14 +0000 (00:09 +0000)]
    Reviewed by Dave.

        - fixed a recent regression, and ...
        - fixed 3386544 -- ARCH: <object>s don't support transclusion like <iframe>s do

        * khtml/khtml_part.cpp: (KHTMLPart::childFrame): Added back a cast I should
        not have removed to fix the function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3430612, crash on about:blank in updateHoverActiveState. Just missing
hyatt [Thu, 25 Sep 2003 00:00:28 +0000 (00:00 +0000)]
Fix for 3430612, crash on about:blank in updateHoverActiveState.  Just missing
a null-check.  Also remove a hover optimization that was bogus.

        Reviewed by darin

        * khtml/rendering/render_layer.cpp:
        (RenderLayer::updateHoverActiveState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
rjw [Wed, 24 Sep 2003 23:05:26 +0000 (23:05 +0000)]
WebKit:

Fixed 3420736.  Clear renderer caches when get an ATS font changed notification.  This fix may be moot depending on progress toward fixing 2695906.  Also 3428451 needs to should be resolved.

Also added code to get and log entry point for the function used to get a Java class from plugins.  That class is used for LiveConnect support.

        Reviewed by John.

        * Misc.subproj/WebKitLogging.h:
        * Misc.subproj/WebKitLogging.m:
        * Plugins.subproj/WebNetscapePluginPackage.h:
        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage load]):
        * Plugins.subproj/npapi.h:
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (FillStyleWithAttributes):
        * WebCoreSupport.subproj/WebTextRendererFactory.m:
        (-[WebTextRendererFactory clearCaches]):
        (fontsChanged):
        (+[WebTextRendererFactory createSharedFactory]):
        (-[WebTextRendererFactory fontWithFamily:traits:size:]):
        (-[WebTextRendererFactory cachedFontFromFamily:traits:size:]):

WebCore:
Fixed 3420736.  Clear renderer caches when get an ATS font changed notification.  This fix may be moot depending on progress toward fixing 2695906.

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (+[WebCoreBridge updateAllViews]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - a new test for JavaScript date parsing
darin [Wed, 24 Sep 2003 16:37:31 +0000 (16:37 +0000)]
    - a new test for JavaScript date parsing

        * layout-tests/fast/js/date-parse-test-expected.txt: Added.
        * layout-tests/fast/js/date-parse-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
darin [Wed, 24 Sep 2003 16:37:10 +0000 (16:37 +0000)]
    Reviewed by Ken.

        - fixed 3421107 -- some dates that other browsers can parse can't be parsed by KJS's Date.parse()

        * kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Added code to be more strict about month names,
        to allow a time zone after date even if the date omits the time, and to understand AM and PM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
darin [Wed, 24 Sep 2003 15:55:20 +0000 (15:55 +0000)]
    Reviewed by Ken.

        - fixed ownerElement for documents in HTML objects (helpful for some work Dave is doing)

        * khtml/khtml_part.h: Change name of frame function to childFrame for clarity.
        * khtml/khtml_part.cpp:
        (KHTMLPart::slotChildStarted): Call the frame function by its new name, childFrame.
        (KHTMLPart::slotChildCompleted): Ditto.
        (KHTMLPart::slotChildURLRequest): Ditto.
        (KHTMLPart::childFrame): Change name from frame to childFrame for clarity, and make it work
        for parts inside HTML objects, not just normal frames and iframes. The change in behavior is
        the actual fix. Note that for the three callers above, it's an error to call this when the
        result would be 0, so there's no harm in doing the extra search of HTML objects in those cases.

        * khtml/xml/dom_docimpl.cpp: (DocumentImpl::ownerElement): Call the frame function by its new
        name, childFrame. This is the caller that will benefit most from the change in behavior.

        * kwq/KWQKHTMLPart.h: Remove childFrameForPart function, which is superseded by the
        childFrame function now.
        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrameHierarchy): Use childFrame instead
        of childFrameForPart.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
darin [Wed, 24 Sep 2003 04:52:35 +0000 (04:52 +0000)]
    Reviewed by Ken.

        - fixed 3390850 -- Shift_JIS in meta tag ignored because <img> tag in JavaScript comes first (vintagecomp.com)

        * khtml/misc/decoder.cpp: (Decoder::decode): Don't let tags inside a script make us think we're in the body.
        Later we can enhance this even more.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoUpdate bug number to 3127833 -- autoscroll only works when mouse is moving.
darin [Tue, 23 Sep 2003 23:45:25 +0000 (23:45 +0000)]
Update bug number to 3127833 -- autoscroll only works when mouse is moving.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John and Richard.
darin [Tue, 23 Sep 2003 23:19:58 +0000 (23:19 +0000)]
    Reviewed by John and Richard.

        - fixed 3367377 -- autoscroll only works when mouse is moving

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView viewDidMoveToWindow]): Stop the auto-scroll timer. This covers
        the case where a view is removed from the view hierarchy while the mouse is down.
        (-[WebHTMLView mouseDown:]): Start the auto-scroll timer.
        (-[WebHTMLView mouseUp:]): Stop the auto-scroll timer.
        * WebView.subproj/WebHTMLViewPrivate.h: Add an auto-scroll timer, and methods
        to start and stop it.
        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _startAutoscrollTimer]): Create and schedule a timer. It uses the
        same 1/10 second interval that NSTextView uses for its scrolling timer.
        (-[WebHTMLView _stopAutoscrollTimer]): Invalidate and release the timer.
        (-[WebHTMLView _autoscroll]): Check for a mouse up event in the queue; if one is
        there, then no autoscrlling. But if not, then create a fake mouse dragged event
        and dispatch it; that will lead to autoscrolling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
darin [Tue, 23 Sep 2003 14:47:30 +0000 (14:47 +0000)]
    Reviewed by Ken.

        - fixed 3292723 -- onBlur() getting called twice on <input type=text>

        * khtml/rendering/render_replaced.cpp: (RenderWidget::eventFilter):
        Call setFocusNode(0) instead of explicitly sending a blur event, otherwise
        setFocusNode will send a second blur event later.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoFix minor coding style issue in this test; something was being
darin [Tue, 23 Sep 2003 06:34:09 +0000 (06:34 +0000)]
Fix minor coding style issue in this test; something was being
computed twice.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoFix check-in snafu.
darin [Tue, 23 Sep 2003 06:28:48 +0000 (06:28 +0000)]
Fix check-in snafu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
darin [Tue, 23 Sep 2003 06:11:38 +0000 (06:11 +0000)]
    Reviewed by Dave.

        - worked around 3429631 -- window stops getting mouse moved events after first tooltip appears

        * WebView.subproj/WebHTMLViewPrivate.m: (-[NSToolTipPanel setAcceptsMouseMovedEvents:]):
        Do nothing, preventing the real setAcceptsMouseMovedEvents: (in class NSWindow) from being called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
darin [Tue, 23 Sep 2003 06:09:45 +0000 (06:09 +0000)]
    Reviewed by Dave.

        - worked around 3429631 -- window stops getting mouse moved events after first tooltip appears

        * WebView.subproj/WebHTMLViewPrivate.m: (-[NSToolTipPanel setAcceptsMouseMovedEvents:]):
        Do nothing, preventing the real setAcceptsMouseMovedEvents: (in class NSWindow) from being called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - fixed 3391837 -- we list ISO-8859-8-E as visual ordering for Hebrew; it...
darin [Tue, 23 Sep 2003 04:03:16 +0000 (04:03 +0000)]
    - fixed 3391837 -- we list ISO-8859-8-E as visual ordering for Hebrew; it's "explicit ordering", not supported

        * kwq/mac-encodings.txt: Removed ISO-8859-8-E.
        * kwq/KWQCharsetData.c: Regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago * kwq/KWQTextEdit.mm: (QTextEdit::sizeWithColumnsAndRows): Made it compile.
darin [Mon, 22 Sep 2003 23:29:42 +0000 (23:29 +0000)]
    * kwq/KWQTextEdit.mm: (QTextEdit::sizeWithColumnsAndRows): Made it compile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
darin [Mon, 22 Sep 2003 22:09:01 +0000 (22:09 +0000)]
    Reviewed by Maciej.

        - fixed 3306041 -- Airborne tracking number field too narrow, tracking doesn't work (textare col property)

        * khtml/rendering/render_form.cpp: (RenderTextArea::calcMinMaxWidth): Call the QTextEdit
        to ask it what size, rather than trying to compute it. This is the same thing we do with
        other widgets, I just hadn't done textarea yet.

        * kwq/KWQTextEdit.h: Added sizeWithColumnsAndRows function.
        * kwq/KWQTextEdit.mm: (QTextEdit::sizeWithColumnsAndRows): Added. Calls through to the
        KWQTextArea object.

        * kwq/KWQTextArea.h: Added sizeWithColumns:rows: method.
        * kwq/KWQTextArea.mm:
        (-[KWQTextArea _createTextView]): Make consistent with other callers of the size mapping methods
        by using [self class] instead of NSScrollView, and getting hasHorizontalScroller and
        hasVerticalScroller from the view.
        (-[KWQTextArea setFrame:]): Make consistent with other callers of the size mapping methods
        by using [self class] instead of NSScrollView.
        (-[KWQTextArea sizeWithColumns:rows:]): Added. Starts by computing the width and height of the
        columns specified, using a canonical width of a "0" character. Then converts that to a container
        size by adding line fragment padding. Then converts that into the text view size by adding the
        text container inset. Then converts that into the scroll view size by calling frameSizeForContentSize:.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agotop level:
darin [Mon, 22 Sep 2003 18:16:08 +0000 (18:16 +0000)]
top level:

        * configure.in: Add "OptimizedWithSymbols" build style.

JavaScriptCore:

        * JavaScriptCore.pbproj/project.pbxproj: Rename Mixed build style to OptimizedWithSymbols.

WebCore:

        * WebCore.pbproj/project.pbxproj: Rename Mixed build style to OptimizedWithSymbols.

WebKit:

        * WebKit.pbproj/project.pbxproj: Rename Mixed build style to OptimizedWithSymbols.

WebBrowser:

        * WebBrowser.pbproj/project.pbxproj: Rename Mixed build style to OptimizedWithSymbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoTweaked some old ChangeLog entries to get rid of "Reviewed by NOBODY".
darin [Mon, 22 Sep 2003 15:22:40 +0000 (15:22 +0000)]
Tweaked some old ChangeLog entries to get rid of "Reviewed by NOBODY".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
darin [Mon, 22 Sep 2003 15:21:34 +0000 (15:21 +0000)]
    Reviewed by Ken.

        - research determined we were using nothing defined in config.h, so I got rid of it

        * Makefile.am: Removed rules to generate config.h.
        * config.h: Removed.

        * WebCore.pbproj/project.pbxproj: Removed define of HAVE_CONFIG_H.

        * WebCorePrefix.h: Removed include of <config.h>.

        * ForwardingHeaders/config.h: Emptied this file out. Can't remove this because there are
        some includes of <config.h> without HAVE_CONFIG_H wrappers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
darin [Mon, 22 Sep 2003 15:21:10 +0000 (15:21 +0000)]
    Reviewed by Ken.

        * kjs/config.h: Added HAVE_SYS_PARAM_H, since KJS does look for this header, and we do
        indeed have it. Just something I noticed in passing while cleaning up configure.in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago * WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView removeTrackingRect...
darin [Mon, 22 Sep 2003 02:27:26 +0000 (02:27 +0000)]
    * WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView removeTrackingRect:]): Remove bogus assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
darin [Mon, 22 Sep 2003 00:33:22 +0000 (00:33 +0000)]
WebCore:

        Reviewed by Dave.

        - fixed 3106411 -- show title attribute for page elements in tooltip on mouseover (important for PeopleSoft)

        * kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Set the value of a new element dictionary
        key, WebCoreElementTitleKey. This gives the title for an element, walking up the DOM tree as necessary
        to find it. It's used for tool tips at the WebKit level.
        * kwq/WebCoreBridge.h: Added WebCoreElementTitleKey and WebCorePageCacheStateKey.

        * WebCore.exp: Added all the constants from WebCoreBridge.h; these should be exported even though they
        are not being used at the moment because the "WebCore and WebKit use the same constant keys" hack we
        are doing at the WebKit level means we can just use the WebKit keys on the WebKit side.
        * WebCore-combined.exp: Regenerated.

WebKit:

        Reviewed by Dave.

        - fixed 3106411 -- show title attribute for page elements in tooltip on mouseover (important for PeopleSoft)

        * WebView.subproj/WebHTMLViewPrivate.h: Added fields needed for tool tip implementation.
        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLViewPrivate dealloc]): Release the tool tip string.
        (-[WebHTMLView addTrackingRect:owner:userData:assumeInside:]): Override the default NSView
        tracking rectangle implementation so we can trick the tool tip manager into trusting us about
        when you leave and enter the rectangle for each element.
        (-[WebHTMLView removeTrackingRect:]): The other half of the above stuff.
        (-[WebHTMLView _sendToolTipMouseExited]): Added. Makes an event just good enough to fool the tool tip
        manager, and send it on.
        (-[WebHTMLView _sendToolTipMouseEntered]): Ditto.
        (-[WebHTMLView _setToolTip:]): Added. Manages the new and old tool tips in a way that fools the tool
        tip manager into working even though we don't know the rectangles of the tool tips beforehand. The
        advantage of using AppKit tool tips is that they have all sorts of nice little features, like wrapping
        to a nice rectangular shape and fading out when you move away.
        (-[WebHTMLView view:stringForToolTip:point:userData:]): This is how the tool tip manager gets the actual
        tool tip text.
        (-[WebHTMLView _updateMouseoverWithEvent:]): Call _setToolTip method, using the value passed along with the
        WebCoreElementTitleKey in the dictionary.

        - unrelated code cleanup

        * WebView.subproj/WebFramePrivate.h: Don't define WebCorePageCacheStateKey here; instead use
        a definition exported from WebCore.
        * WebView.subproj/WebFramePrivate.m: Ditto.
        * English.lproj/StringsNotToBeLocalized.txt: Update for above changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
darin [Sun, 21 Sep 2003 04:00:16 +0000 (04:00 +0000)]
    Reviewed by Dave.

        - fixed 3419380 -- JavaScript Date.getTimezoneOffset is off by one hour (during daylight savings)

        * kjs/date_object.cpp: (DateProtoFuncImp::call): The daylight savings correction
        in here was incorrect. Perhaps I should have corrected it for the non-BSD case too,
        but I'm not sure the issue is the same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
darin [Sun, 21 Sep 2003 03:59:03 +0000 (03:59 +0000)]
    Reviewed by Dave.

        - fixed 3328481 -- selection in select element list box does not scroll into view when set programatically

        * kwq/KWQListBox.mm: (QListBox::setSelected): Scroll newly-selected item into view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
darin [Sun, 21 Sep 2003 03:55:04 +0000 (03:55 +0000)]
    Reviewed by Dave.

        - fixed 3429384 -- REGRESSION (89-90): nil-deref in KHTMLPart::write() (cheshiremotorcyclesalvage.com)

        * khtml/khtml_part.cpp: (KHTMLPart::write): Add a nil check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
darin [Sun, 21 Sep 2003 03:53:06 +0000 (03:53 +0000)]
    Reviewed by Dave.

        - more fixes for the W3C DOM tests

        * khtml/dom/dom_doc.cpp: (Document::createAttributeNS): Check that the attribute name
        is valid and throw INVALID_CHARACTER_ERR if not.

        * khtml/dom/dom_element.cpp:
        (Element::removeAttributeNode): Get the attribute name properly. The old code would always
        get a 0, so this function would always fail.
        (Element::setAttributeNS): Check that the attribute name is valid and throw
        INVALID_CHARACTER_ERR if not.
        (Element::setAttributeNodeNS): Remove redundant exception checks that are also done by
        setNamedItem in the implementation. I had to change the implementation of one, so I decided
        it was better not to have any duplication.

        * khtml/xml/dom_docimpl.h: Added isValidName function.
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::createHTMLElement): Check that the attribute name is valid and throw
        INVALID_CHARACTER_ERR if not.
        (DocumentImpl::isValidName): Added. Used to check for valid names.

        * khtml/xml/dom_elementimpl.cpp:
        (NamedAttrMapImpl::setNamedItem): Don't do the document check until after checking for
        the "replace self" case. Otherwise we raise a spurious "in use" exception.
        (NamedAttrMapImpl::addAttribute): Point the new attribute at the element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
mjs [Sat, 20 Sep 2003 01:22:05 +0000 (01:22 +0000)]
WebCore:

        Reviewed by Darin.

Roll out old fix for 3410980 and do a new better fix.

        * khtml/html/html_documentimpl.cpp:
        (HTMLDocumentImpl::close):
        * khtml/khtml_part.h:
        * kwq/KWQKHTMLPart.mm:
        * kwq/WebCoreBridge.h:

WebKit:

        Reviewed by Darin.

Roll out old fix for 3410980.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge goBackOrForward:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
darin [Fri, 19 Sep 2003 23:55:42 +0000 (23:55 +0000)]
    Reviewed by Dave.

        - update layout tests for Dave's change

        * layout-tests/apple-only/base/www.excite.com/index-expected.txt:
        * layout-tests/fast/block/positioning/051-expected.txt:
        * layout-tests/fast/overflow/003-expected.txt:

        - fixed 3426272 -- sites that use text-shadow cause leaks (QPainter::setShadow)

        * kwq/KWQPainter.mm: (QPainter::setShadow): Release the color space and color.

        - fixed some errors that caused failures in the W3C DOM suite

        * khtml/ecma/kjs_binding.cpp:
        (DOMObject::get): Put "code" in the error object.
        (DOMObject::put): Put "code" in the error object.
        (DOMFunction::get): Put "code" in the error object.

        * khtml/ecma/kjs_dom.cpp: (DOMCharacterDataProtoFunc::tryCall):
        Add checks for negative count values. Not clear whether this change is
        really great, but it helps us pass W3C DOM tests and clearly won't affect
        normal pages in any bad way.

        * khtml/xml/dom_elementimpl.cpp:
        (AttrImpl::AttrImpl): Set m_specified to true. Since we never set up the
        attributes from the DTD anyway, this is fine for now. If we ever go crazy
        and implement that, then the bit field is sitting here waiting for us.
        (NamedAttrMapImpl::removeNamedItem): The comment from KHTML says they
        don't raise the not found exception because "the DOM 2 spec doesn't say
        you should". But the DOM Level 1 specification clearly does, and the W3C
        DOM Level 1 Core test requires it, so I'm putting it in.

        * khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): Typo; this was
        returning the wrong error code in the "wrong document" case.

        * khtml/xml/dom_stringimpl.cpp:
        (DOMStringImpl::remove): Fix overflow case.
        (DOMStringImpl::substring): Fix overflow case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoFix build error.
hyatt [Fri, 19 Sep 2003 23:28:28 +0000 (23:28 +0000)]
Fix build error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3401409, fix negative z-index. This code actually substantially
hyatt [Fri, 19 Sep 2003 22:54:38 +0000 (22:54 +0000)]
Fix for 3401409, fix negative z-index.  This code actually substantially
reworks layers to be more efficient in both painting and event handling.
It also fixes bugs with clipping as well as with negative z-indices.

        Reviewed by kocienda

        * khtml/css/cssstyleselector.cpp:
        * khtml/rendering/render_block.cpp:
        * khtml/rendering/render_block.h:
        * khtml/rendering/render_box.cpp:
        (RenderBox::setStyle):
        (RenderBox::repaintRectangle):
        * khtml/rendering/render_box.h:
        * khtml/rendering/render_frames.cpp:
        (RenderFrameSet::nodeAtPoint):
        * khtml/rendering/render_frames.h:
        * khtml/rendering/render_image.cpp:
        (RenderImage::nodeAtPoint):
        * khtml/rendering/render_image.h:
        * khtml/rendering/render_inline.cpp:
        (RenderInline::nodeAtPoint):
        * khtml/rendering/render_inline.h:
        * khtml/rendering/render_layer.cpp:
        (RenderLayer::RenderLayer):
        (RenderLayer::~RenderLayer):
        (RenderLayer::updateLayerPosition):
        (RenderLayer::stackingContext):
        (RenderLayer::enclosingPositionedAncestor):
        (RenderLayer::transparentAncestor):
        (RenderLayer::addChild):
        (RenderLayer::removeChild):
        (RenderLayer::convertToLayerCoords):
        (RenderLayer::checkScrollbarsAfterLayout):
        (RenderLayer::paintScrollbars):
        (RenderLayer::paint):
        (setClip):
        (restoreClip):
        (RenderLayer::paintLayer):
        (RenderLayer::nodeAtPoint):
        (RenderLayer::nodeAtPointForLayer):
        (RenderLayer::calculateClipRects):
        (RenderLayer::calculateRects):
        (RenderLayer::intersectsDamageRect):
        (RenderLayer::containsPoint):
        (hoverAncestor):
        (commonAncestor):
        (RenderLayer::updateHoverActiveState):
        (sortByZOrder):
        (RenderLayer::dirtyZOrderLists):
        (RenderLayer::updateZOrderLists):
        (RenderLayer::collectLayers):
        * khtml/rendering/render_layer.h:
        * khtml/rendering/render_object.cpp:
        (RenderObject::setStyle):
        (RenderObject::document):
        (RenderObject::renderArena):
        (RenderObject::nodeAtPoint):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_text.cpp:
        (RenderText::nodeAtPoint):
        * khtml/rendering/render_text.h:
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::DocumentImpl):
        (DocumentImpl::~DocumentImpl):
        (DocumentImpl::recalcStyleSelector):
        (DocumentImpl::setHoverNode):
        * khtml/xml/dom_docimpl.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::paint):
        (KWQKHTMLPart::paintSelectionOnly):
        (KWQKHTMLPart::adjustPageHeight):
        * kwq/KWQRect.h:
        * kwq/KWQRenderTreeDebug.cpp:
        (write):
        (writeLayers):
        (externalRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
darin [Fri, 19 Sep 2003 22:16:10 +0000 (22:16 +0000)]
    Reviewed by Dave.

        * layout-tests: Updated for my mini-controls change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
darin [Fri, 19 Sep 2003 21:46:47 +0000 (21:46 +0000)]
WebCore:

        Reviewed by Dave.

        - do the prep work for the mini controls feature; Dave will finish this

        * khtml/rendering/render_form.cpp: (RenderFormElement::updateFromElement):
        Tell the widget about the font size. Our widgets use the font size to
        decide whether to use Aqua normal, small, or mini.

        * kwq/KWQButton.h: Add setFont.
        * kwq/KWQButton.mm:
        (QButton::setFont): Set control size based on font.
        (KWQNSControlSizeForFont): Determine control size given a font. Dave is going
        to tweak this later.

        * kwq/KWQCheckBox.h: Add dimensions function for metrics for each control size.
        * kwq/KWQCheckBox.mm:
        (QCheckBox::sizeHint): Use dimensions.
        (QCheckBox::frameGeometry): Use dimensions.
        (QCheckBox::setFrameGeometry): Use dimensions.
        (QCheckBox::baselinePosition): Use dimensions.
        (QCheckBox::dimensions): Added. Has newly tweaked values for all dimensions for
        all three control sizes.

        * kwq/KWQComboBox.h: Add setFont and dimensions.
        * kwq/KWQComboBox.mm:
        (QComboBox::sizeHint): Use dimensions.
        (QComboBox::frameGeometry): Use dimensions.
        (QComboBox::setFrameGeometry): Use dimensions.
        (QComboBox::baselinePosition): Use dimensions.
        (QComboBox::setFont): Use dimensions.
        (QComboBox::dimensions): Added. Has newly tweaked values for all dimensions for
        all three control sizes.

        * kwq/KWQFileButton.mm: (KWQFileButton::baselinePosition): Change to adapt to
        flipped version of file button NSControl.

        * kwq/KWQPushButton.h: Add dimensions function for metrics for each control size.
        * kwq/KWQPushButton.mm:
        (QPushButton::sizeHint): Use dimensions.
        (QPushButton::frameGeometry): Use dimensions.
        (QPushButton::setFrameGeometry): Use dimensions.
        (QPushButton::baselinePosition): Use dimensions.
        (QPushButton::dimensions): Added. Has newly tweaked values for all dimensions for
        all three control sizes.

        * kwq/KWQRadioButton.h: Add dimensions function for metrics for each control size.
        * kwq/KWQRadioButton.mm:
        (QRadioButton::sizeHint): Use dimensions.
        (QRadioButton::frameGeometry): Use dimensions.
        (QRadioButton::setFrameGeometry): Use dimensions.
        (QRadioButton::baselinePosition): Use dimensions.
        (QRadioButton::dimensions): Added. Has newly tweaked values for all dimensions for
        all three control sizes.

WebKit:

        Reviewed by Dave.

        - do the prep work for the mini controls feature; Dave will finish this

        * WebCoreSupport.subproj/WebFileButton.m:
        (-[WebFileButton isFlipped]): Make this flipped, easier to understand coordinates that way.
        (-[WebFileButton drawRect:]): Update for flipped-ness.
        (-[WebFileButton visualFrame]): Update for flipped-ness.
        (-[WebFileButton setVisualFrame:]): Update for flipped-ness.
        (-[WebFileButton baseline]): Update for flipped-ness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
mjs [Fri, 19 Sep 2003 20:46:17 +0000 (20:46 +0000)]
WebCore:

        Reviewed by Darin.

- fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes

        * khtml/html/html_documentimpl.cpp:
        (HTMLDocumentImpl::close): Remove redundant check removed.
        * khtml/khtml_part.h:
        * kwq/KWQKHTMLPart.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::scheduleHistoryNavigation): Only call the base class
method to actually schedule when it's possible to go back or forward
that number of steps.
        * kwq/WebCoreBridge.h:

WebKit:

        Reviewed by Darin.

- fixed 3410980 - FileMaker: going forward with an empty forward list makes a frame come out blank sometimes

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge backOrForwardItemWithDistance:]): Factored out from goBackOrForward.
        (-[WebBridge canGoBackOrForward:]): Use the new method.
        (-[WebBridge goBackOrForward:]): Likewise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
darin [Thu, 18 Sep 2003 21:56:56 +0000 (21:56 +0000)]
    Reviewed by Maciej.

        * kjs/date_object.cpp: Removed our CF-based implementations of gmtime, localtime,
        mktime, timegm, and time, since they no longer have the slow "hit the filesystem
        every time" behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
sullivan [Thu, 18 Sep 2003 15:26:08 +0000 (15:26 +0000)]
WebCore:

- WebCore part of fix for 3157018 -- Would like option to
not print backgrounds

        Reviewed by Darin

        * kwq/KWQKHTMLSettings.h:
add _shouldPrintBackgrounds field and accessors

        * kwq/WebCoreSettings.h:
add shouldPrintBackgrounds field and accessors
        * kwq/WebCoreSettings.mm:
        (-[WebCoreSettings setShouldPrintBackgrounds:]):
new method, passes value to KHTMLSettings
        (-[WebCoreSettings shouldPrintBackgrounds]):
new method

        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge styleSheetForPrinting]):
new method, returns a style sheet that has backgrounds
turned off if preference is set that way.
        (-[WebCoreBridge reapplyStylesForDeviceType:]):
if printing, set the printStyleSheet to the one we
created based on the preferences. (KHTML has always
had support for a special printStyleSheet, but it was
only being used in !APPLE_CHANGES code.)

        * khtml/rendering/render_style.h:
add shouldCorrectTextColor boolean field and accessors

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::recalcStyle):
tell style to correct text colors if backgrounds aren't being printed

        * khtml/rendering/render_text.cpp:
        (TextRun::paintSelection):
added comment
        (simpleDifferenceBetweenColors):
new function, computes a quick measure of difference
between colors
        (correctedTextColor):
if text and background colors are too similar, returns
lightened or darkened text color
        (RenderText::paintObject):
if style says to correct text colors, call correctedTextColor

WebKit:

- WebKit part of fix for 3157018 -- Would like option to
not print backgrounds

        Reviewed by Darin

        * WebView.subproj/WebPreferences.h:
new accessor methods for new shouldPrintBackgrounds preference
        * WebView.subproj/WebPreferences.m:
        (+[WebPreferences initialize]):
set initial value for WebKitShouldPrintBackgroundsPreferenceKey
to NO
        (-[WebPreferences shouldPrintBackgrounds]):
new method, read NSUserDefaults value
        (-[WebPreferences setShouldPrintBackgrounds:]):
new method, write NSUserDefault value

        * WebView.subproj/WebViewPrivate.m:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):
tell WebCore about value of shouldPrintBackgrounds

        * English.lproj/StringsNotToBeLocalized.txt:
Updated for these and other recent changes

WebBrowser:

- WebBrowser part of fix for 3157018 -- Would like option to
not print backgrounds

        Reviewed by Darin

* English.lproj/PrintingAccessoryView.nib:
new nib file, contains view holding single "Print
Backgrounds" checkbox

        * PrintingAccessoryViewController.h: Added.
        * PrintingAccessoryViewController.m: Added.
        (-[PrintingAccessoryViewController init]):
load the nib file with self as owner
        (+[PrintingAccessoryViewController sharedController]):
returns shared instance used by BrowserDocument
        (-[PrintingAccessoryViewController togglePrintBackgrounds:]):
toggle the WebKit preference (which in turn updates the
WebCore setting)
        (-[PrintingAccessoryViewController accessoryView]):
returns the view from the nib that will be displayed in the
print panel, after updating the checkbox state

        * BrowserDocument.m:
        (-[BrowserDocument printWebFrameView:showingPrintPanel:]):
Set up print panel's accessory view

        * Preferences.subproj/AppearancePreferences.m:
removed unused method I stumbled across

        * WebBrowser.pbproj/project.pbxproj:
updated for new files

        * English.lproj/StringsNotToBeLocalized.txt:
Updated for these changes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
darin [Thu, 18 Sep 2003 00:08:53 +0000 (00:08 +0000)]
    Reviewed by Maciej.

        * Plugins.subproj/WebBasePluginPackage.m:
        (-[WebBasePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): Pass the
        "no UI" flag, so we don't prompt the user when we're trying to load plug-ins.
        Also use OSStatus rather than OSErr so we don't miss error codes that just
        happen to have zeroes in the low 16 bits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John.
darin [Thu, 18 Sep 2003 00:05:40 +0000 (00:05 +0000)]
    Reviewed by John.

        * WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton setFilename:]):
        Don't call -[NSWorkspace iconForFile:] on a path that does not start with a '/'.
        This can happen if JavaScript or the web page sets the path explicitly, and
        adding this check avoids an unpleasant warning on the console.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
darin [Wed, 17 Sep 2003 21:51:07 +0000 (21:51 +0000)]
    Reviewed by Ken.

        - fixed 3423404 -- REGRESSION: Japanese page appears blank due to unexpected kTECPartialCharErr

        * kwq/KWQTextCodec.mm: (KWQTextDecoder::convertOneChunkUsingTEC): In the case where we're already
        going from the small buffer back to the large one, treat kTECPartialCharErr the same as noErr.
        Otherwise we'll get confused and drop the contents of the big buffer.
        (KWQTextDecoder::convert): Improve the debugging code a bit (still turned off).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agomarkers for WebKit-106, and updated release notes for Safari-100
vicki [Wed, 17 Sep 2003 00:25:11 +0000 (00:25 +0000)]
markers for WebKit-106, and updated release notes for Safari-100

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Backed out fix to 3412062 to resolve 3424197.
rjw [Tue, 16 Sep 2003 22:59:52 +0000 (22:59 +0000)]
Backed out fix to 3412062 to resolve 3424197.

Many sites use a technique of posting forms the same URL to generate content server side.  The fix to 3412062 broke those sites.

        Reviewed by Darin.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoupdated Release Notes for the never-ending Safari-100; markers for WebKit/WebCore-105
vicki [Tue, 16 Sep 2003 00:20:29 +0000 (00:20 +0000)]
updated Release Notes for the never-ending Safari-100; markers for WebKit/WebCore-105

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin and Don.
darin [Mon, 15 Sep 2003 22:32:44 +0000 (22:32 +0000)]
    Reviewed by Darin and Don.

        - fixed 3419957 -- REGRESSION: lines drawn across multiple columns at washingtonpost.com

        * khtml/rendering/render_box.cpp: (RenderBox::calcWidth): Always use the width of the line
        rather than the width of the containing block for "flow around floats" blocks (<hr>).
        This undoes half of the change made to fix bug 3384609.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken and Don.
darin [Mon, 15 Sep 2003 17:23:47 +0000 (17:23 +0000)]
    Reviewed by Ken and Don.

        - fixed 3417604 -- REGRESSION: dragging scroll thumb causes textarea contents to vanish

        * kwq/KWQTextArea.mm: (-[KWQTextArea initWithFrame:]): Deallocated cached graphics state for
        the text view as well as for the clip view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agomarker for WebCore-104
vicki [Mon, 15 Sep 2003 15:44:13 +0000 (15:44 +0000)]
marker for WebCore-104

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agomarker for WebKit-104
vicki [Mon, 15 Sep 2003 04:58:09 +0000 (04:58 +0000)]
marker for WebKit-104

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
darin [Sat, 13 Sep 2003 19:44:25 +0000 (19:44 +0000)]
    Reviewed by Maciej.

        - fixed 3420547 -- REGRESSION: repro crash in khtml::RenderBlock::findNextLineBreak (wisdomtips.com)

        * khtml/rendering/render_block.cpp: (RenderBlock::addChildToFlow): Exclude BR elements when looking for
        an element to process first-letter style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago * layout-tests/fast/frames/empty-frame-src-expected.txt: Updated test results...
darin [Sat, 13 Sep 2003 15:38:02 +0000 (15:38 +0000)]
    * layout-tests/fast/frames/empty-frame-src-expected.txt: Updated test results that changed
        due to the change in our handling of frame borders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
rjw [Sat, 13 Sep 2003 02:11:34 +0000 (02:11 +0000)]
WebKit:
Fixed 3420097.  If redirects are cancelled during a pending load don't reset the quickRedirect flag.

        Reviewed by Darin.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge reportClientRedirectCancelled:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]):
        (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
        (-[WebFrame _clientRedirectCancelled:]):

WebCore:
Fixed 3420097.  Pass flag up to WebKit indicating that redirects are being cancelled during a pending load.

        Reviewed by Darin.

        * khtml/khtml_part.cpp:
        (KHTMLPart::cancelRedirection):
        * khtml/khtml_part.h:
        * khtml/khtmlpart_p.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::provisionalLoadStarted):
        (KWQKHTMLPart::redirectionTimerStartedOrStopped):
        * kwq/WebCoreBridge.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agorelease markers for WebKit-103 and WebCore-103; updated release notes to include...
vicki [Sat, 13 Sep 2003 00:42:47 +0000 (00:42 +0000)]
release markers for WebKit-103 and WebCore-103; updated release notes to include -103 fixes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin.
mjs [Fri, 12 Sep 2003 23:41:54 +0000 (23:41 +0000)]
    Reviewed by Darin.

        * khtml/css/html4.css: Use the same hardcoded default size for
OBJECT and EMBED tags as for IFRAME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed 3412062. Don't allow pages with the same URL as the current URL to enter...
rjw [Fri, 12 Sep 2003 23:17:46 +0000 (23:17 +0000)]
Fixed 3412062.  Don't allow pages with the same URL as the current URL to enter b/f or history.

        Reviewed by Maciej.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin.
mjs [Fri, 12 Sep 2003 22:55:47 +0000 (22:55 +0000)]
    Reviewed by Darin.

- fixed 3413463 - QuickTime plug-in content doesn't load in Safari (NPP_Write not called)

        * Plugins.subproj/npapi.h: Fix erroneous function pointer
declarations that led to an int16/int32 mismatch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
darin [Fri, 12 Sep 2003 22:53:11 +0000 (22:53 +0000)]
    Reviewed by Ken.

        - fixed 3403223 -- <input type=file> with initial value causes exception, bad results afterwards, when submitted

        * kwq/KWQFile.mm: (QFile::QFile): Don't pass an empty string to fileSystemRepresentation,
        because that will cause an exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed: <rdar://problem/3420112>: Reproducible Safari crash in in -[WebBaseNetscapePl...
cblu [Fri, 12 Sep 2003 22:48:49 +0000 (22:48 +0000)]
Fixed: <rdar://problem/3420112>: Reproducible Safari crash in in -[WebBaseNetscapePluginView sendEvent:]

        Reviewed by darin.

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView sendEvent:]): temporarily retain self in case the plug-in view is released while sending an event.
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:targetFrame:]): don't deliver the return value of the JS evaluation if stringByEvaluatingJavaScriptFromString caused the plug-in to stop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit is open for business.
mjs [Fri, 12 Sep 2003 03:47:27 +0000 (03:47 +0000)]
WebKit is open for business.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore is open for business.
mjs [Fri, 12 Sep 2003 03:46:46 +0000 (03:46 +0000)]
WebCore is open for business.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoEr, I meant WebKit-102. Looks like there was no release marker for 101.
mjs [Fri, 12 Sep 2003 03:27:02 +0000 (03:27 +0000)]
Er, I meant WebKit-102. Looks like there was no release marker for 101.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit-101
mjs [Fri, 12 Sep 2003 03:23:18 +0000 (03:23 +0000)]
WebKit-101

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore-101
mjs [Fri, 12 Sep 2003 03:22:58 +0000 (03:22 +0000)]
WebCore-101

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
mjs [Fri, 12 Sep 2003 00:58:27 +0000 (00:58 +0000)]
    Reviewed by Ken.

- fixed 3417486 - after logging off from secure Etrade website, going back returns you to secure page

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _loadItem:withLoadType:]): Don't request stale data
for https pages, as this could be a security risk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
rjw [Fri, 12 Sep 2003 00:19:43 +0000 (00:19 +0000)]
WebKit:
Fixed 3406671.  Added a private method for Mail to get selection
rect.

        Reviewed by Darin Adler.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView updateTextBackgroundColor]):
        * WebView.subproj/WebHTMLViewPrivate.h:
        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _handleMouseDragged:]):
        (-[WebHTMLView _pluginController]):
        (-[WebHTMLView _selectionRect]):

WebCore:
Fixed 3406671.  Added a private method for Mail to get selection
rect.

Fixed 3417688.  Don't allow https page into page cache.

        Reviewed by Darin.

        * kwq/KWQFrame.h:
        * kwq/KWQFrame.mm:
        (QFrame::setFrameStyle):
        (QFrame::frameWidth):
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::canCachePage):
        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge selectionRect]):
        (-[WebCoreBridge visibleSelectionRect]):
        (-[WebCoreBridge selectionImage]):
        (-[WebCoreBridge adjustViewSize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed 3231031. Use the normal methodology for displaying each frame of a GIF. ...
rjw [Thu, 11 Sep 2003 00:12:25 +0000 (00:12 +0000)]
Fixed 3231031.  Use the normal methodology for displaying each frame of a GIF.  That is,
just call setNeedsDisplayInRect, rather than drawing directly.  Drawing directly violates
layering/clipping.

        Reviewed by Dave Hyatt.

        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer nextFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago*** empty log message ***
vicki [Wed, 10 Sep 2003 00:10:42 +0000 (00:10 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago*** empty log message ***
vicki [Tue, 9 Sep 2003 23:55:03 +0000 (23:55 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
rjw [Tue, 9 Sep 2003 22:42:56 +0000 (22:42 +0000)]
WebKit:
Fixed 3414988.  Don't store absolute path to home directory.
Reviewed by Chris Blumenberg.

Fixed 3414319.  Send correct WebView back as parameter to webViewShow:
Review by Darin.

Fixed 3095029.  Draw a frame's border in WebFrameView, instead of WebHTMLView, and correctly inset the frame's scrollview to account for the border.  Mostly written by Darin.
        Reviewed by Darin (and Richard).

        * Misc.subproj/WebIconDatabase.m:
        (-[WebIconDatabase _createFileDatabase]):
Store @"~/Library/Icon" instead of absolute path, and always try to tilde expand stored path.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge setHasBorder:]):
        * WebView.subproj/WebFrameView.m:
        (-[WebFrameView drawRect:]):
        (-[WebFrameView setFrameSize:]):
        * WebView.subproj/WebFrameViewPrivate.h:
        * WebView.subproj/WebFrameViewPrivate.m:
        (-[WebFrameView _isMainFrame]):
        (-[WebFrameView _tile]):
        (-[WebFrameView _drawBorder]):
        (-[WebFrameView _shouldDrawBorder]):
        (-[WebFrameView _setHasBorder:]):
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView drawRect:]):
Changes to correct draw border in WebFrameView instead of WebHTMLView.

        * WebView.subproj/WebViewPrivate.m:
        (-[WebView _openNewWindowWithRequest:]):
Send correct parameter (returned from webView:createWebViewWithRequest:), rather than self, to webViewShow:.

WebCore:
Fix for 3095029.  Written by Darin.
        Reviewed by Richard.

        * kwq/KWQFrame.h:
        * kwq/KWQFrame.mm:
        (QFrame::setFrameStyle):
Doesn't need to be virtual.
        (QFrame::frameWidth):
Tweaks.

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge adjustViewSize]):
Remove frameBorderStyle, no longer needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed: <rdar://problem/3412380>: REGRESSION (85-98): www.minoltan.com is decoded...
cblu [Tue, 9 Sep 2003 21:28:26 +0000 (21:28 +0000)]
Fixed: <rdar://problem/3412380>: REGRESSION (85-98): minoltan.com is decoded incorrectly on Japanese system

The default encoding that Safari uses is latin1 regardless of the current system encoding. This is how it's always been. The problem is that the UI is displaying shift JIS for the default text encoding instead of latin1. This is happening because WebKit is using "latin1" instead of "ISO-8859-1" for the default text encoding name. "ISO-8859-1" is the IANA character set name for latin1 and this is what the  WebKitDefaultTextEncodingNamePreferenceKey preference expects. This ends up confusing Safari, so Safari just ends up displaying the first item in the pop-up menu which is shift JIS.

        Reviewed by rjw.

        * WebView.subproj/WebPreferences.m:
        (+[WebPreferences initialize]): The WebKitDefaultTextEncodingNamePreferenceKey should be "ISO-8859-1" not "latin1" since "ISO-8859-1" is the IANA character set name for latin1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Chris.
darin [Tue, 9 Sep 2003 20:24:45 +0000 (20:24 +0000)]
    Reviewed by Chris.

        - fixed 3373654 -- REGRESSION: Yahoo chat applet reloads over and over due to "baseURL" param name conflict

        After some research by the Java team, we discovered that there was no need to
        pass in baseURL at all This patch gets rid of that by only passingindividual specified
        arguments, rather than passing all the arguments, as applet parameters.

        * khtml/rendering/render_applet.cpp: (RenderApplet::processArguments): Remove the
        call to KJavaApplet::processArguments, because we only want the individual arguments.
        * kwq/KWQKJavaAppletWidget.h: Implement setAppletClass, setAppletName, setArchives, and
        setCodeBase. Remove processArguments.
        * kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::setParameter): Lowercase all the
        parameters as we put them in the dictionary, since this is the semantics required by Java.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agotree is open for Safari-100!
vicki [Mon, 8 Sep 2003 23:33:24 +0000 (23:33 +0000)]
tree is open for Safari-100!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoSafari-99 stamp
vicki [Mon, 8 Sep 2003 23:14:16 +0000 (23:14 +0000)]
Safari-99 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Chris.
darin [Mon, 8 Sep 2003 18:45:28 +0000 (18:45 +0000)]
    Reviewed by Chris.

        - fixed 3412726 -- some HTML messages in Mail lose a line at page breaks when printed (multipart/alternative)

        * WebView.subproj/WebHTMLView.m: (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
        Go into printing mode when asked to adjust page height, if not already in it.
        We already have code in drawRect that does this when actually printing, but it's
        also important to lay out the same way when deciding where to break pages, otherwise
        the difference between printer and screen fonts can lead to page breaks that split a line
        of text across two pages, and that can lead to missing lines of text as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
darin [Sun, 7 Sep 2003 23:06:28 +0000 (23:06 +0000)]
    Reviewed by Maciej.

        - fixed 3411827 -- REGRESSION: text drawing after text-shadow does not respect smoothing style (asahi.com)

        * kwq/KWQPainter.mm: (QPainter::clearShadow): Call CGContextSetShadowWithColor with a color of NULL,
        which actually clears the shadow, rather than CGContextSetShadow, which sets a black shadow (even
        if it is zero pixels in size).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
darin [Sun, 7 Sep 2003 22:38:33 +0000 (22:38 +0000)]
    Reviewed by Maciej.

        - fixed 3410939 -- disabling Geneva and Helvetica (by removing them, or by using Font Book) makes Safari crash

        * WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fallbackFontWithTraits:size:]):
        Fall back on Lucida Grande (plain, not bothering with traits) if Helvetica is not present.

        * English.lproj/StringsNotToBeLocalized.txt: Update for this and other recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
darin [Sun, 7 Sep 2003 19:16:37 +0000 (19:16 +0000)]
    Reviewed by Ken.

        - fixed 3406660 -- screen fonts are not being used for substitute fonts (Japanese text, Roman font)

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer substituteFontForString:families:]): Get a printer or screen font,
        based on the renderer's mode. The old code didn't do anything explicit.
        (-[WebTextRenderer _setupFont]): Remove ignored parameter for clarity.
        (-[WebTextRenderer initWithFont:usingPrinterFont:]): Fixed code paths that would not
        explicitly get a printer or screen font, and code paths that would get data from the
        original "before mapping to printer or screen font" NSFont object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agotree is open for Safari-99!
vicki [Fri, 5 Sep 2003 23:27:27 +0000 (23:27 +0000)]
tree is open for Safari-99!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoSafari-98 stamp
vicki [Fri, 5 Sep 2003 23:12:10 +0000 (23:12 +0000)]
Safari-98 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
kocienda [Fri, 5 Sep 2003 20:00:35 +0000 (20:00 +0000)]
WebCore:

        Reviewed by Darin

Fix for this bug:

<rdar://problem/3226083>: REGRESSION (Panther): white box
overlaying select lists at nvidia.com drivers page

        * kwq/KWQListBox.mm:
        (QListBox::QListBox): Re-add releaseGState fix that Darin
added, but then removed. It turns out that we do need
this workaround in place to get proper drawing.

Fix for this bug:

<rdar://problem/3310943>: REGRESSION (Panther): textareas
in forms sometimes draw blank (bugreporter)

        * kwq/KWQTextArea.mm:
        (-[KWQTextArea initWithFrame:]): Same fix as above.

WebKit:

        Reviewed by Darin

Incorporate releaseGState fix that Darin developed for
textareas and list boxes in WebCore. It turns out that
we this workaround in WebClipView as well to get proper
drawing of subframes.

In addition, removed some tests that which performed
runtime checks for code in AppKit. AppKit will have
the checked-for code in all versions that will be used
with the version of WebKit.

        * WebView.subproj/WebClipView.m:
        (-[WebClipView initWithFrame:])
        (-[WebClipView resetAdditionalClip])
        (-[WebClipView setAdditionalClip:])

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoRemoved stray conflict marker.
sullivan [Fri, 5 Sep 2003 17:46:26 +0000 (17:46 +0000)]
Removed stray conflict marker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - fixed 3409011 -- the graphics views palette does not open
sullivan [Fri, 5 Sep 2003 17:23:41 +0000 (17:23 +0000)]
- fixed 3409011 -- the graphics views palette does not open

        Reviewed by Maciej

        * WebView.subproj/WebPreferences.m:
        (+[WebPreferences _removeReferenceForIdentifier:]):
special-case nil, which is a magic initial identifier already
special-cased in the other mutator

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin.
mjs [Fri, 5 Sep 2003 08:34:22 +0000 (08:34 +0000)]
    Reviewed by Darin.

- fixed - REGRESSION (85-92): Javascript on page isn't triggered by typed characters (onKeyUp)

(This actually also requires an AppKit fix to be a full fix.)

        * kwq/KWQListBox.mm:
        (-[KWQTableView keyDown:]): Added. Send event through DOM.
        (-[KWQTableView keyUp:]): Likewise.
        (-[KWQTableView becomeFirstResponder]): Added. Report focus change
to DOM.
* kwq/KWQTextArea.mm:
        (-[KWQTextAreaTextView keyUp:]): Added. Send event through DOM.
        * kwq/KWQTextField.mm:
        (-[KWQTextField textView:shouldHandleEvent:]): Pass NSKeyUp events too
(not going to work until we get an AppKit fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin.
mjs [Fri, 5 Sep 2003 08:12:33 +0000 (08:12 +0000)]
    Reviewed by Darin.

- fixed 3406140 - REGRESSION (7B52-7B55): time spent in NSFont makes Safari 50% slower in Five Apps test

        * WebCoreSupport.subproj/WebTextRendererFactory.m:
        (-[WebTextRendererFactory fontWithFamily:traits:size:]): Make font
using the font name we found, not the one we were looking
for. Since the compare is case-insensitive, it makes a
difference. Also, don't make the font twice.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed: <rdar://problem/3316704>: Shockwave: getnetText steam is not functioning...
cblu [Fri, 5 Sep 2003 06:07:45 +0000 (06:07 +0000)]
Fixed: <rdar://problem/3316704>: Shockwave: getnetText steam is not functioning correctly

        Reviewed by mjs.

        * Plugins.subproj/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream startStreamWithURL:expectedContentLength:lastModifiedDate:MIMEType:]): if the content length is unknown, use 0 instead of -1

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4941 268f45cc-cd09-0410-ab3c-d52691b4dbfc