WebKit-https.git
9 years ago2011-01-06 Julie Parent <jparent@chromium.org>
jparent@chromium.org [Thu, 6 Jan 2011 18:42:44 +0000 (18:42 +0000)]
2011-01-06  Julie Parent  <jparent@chromium.org>

        Reviewed by Tony Chang.

        Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
        https://bugs.webkit.org/show_bug.cgi?id=51217

        * TestResultServer/model/jsonresults.py:
        Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
        Adds missing documentation.
        * TestResultServer/model/jsonresults_unittest.py:
        Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
        Update test_merge to take a number of builds to truncate at.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-06 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 6 Jan 2011 18:21:27 +0000 (18:21 +0000)]
2011-01-06  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Enable blob support by default
        https://bugs.webkit.org/show_bug.cgi?id=51994

        * configure.ac: Enable Blob support by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-06 Andrei Popescu <andreip@google.com>
andreip@google.com [Thu, 6 Jan 2011 18:19:29 +0000 (18:19 +0000)]
2011-01-06  Andrei Popescu  <andreip@google.com>

        Unreviewed, build fix.

        [Chromium] Add elliptical gradient support to GradientSkia
        https://bugs.webkit.org/show_bug.cgi?id=51841

        Marks fast/gradients/css3-radial-gradients3.html as expected to fail.
        Also marks
        canvas/philip/tests/2d.shadow.gradient.alpha.html
        canvas/philip/tests/2d.shadow.gradient.basic.html
        canvas/philip/tests/2d.shadow.gradient.transparent.2.html
        as passing on Chromium-mac as a result of r75139.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-06 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 6 Jan 2011 18:16:05 +0000 (18:16 +0000)]
2011-01-06  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed Windows build fix for r75161.

        * platform/graphics/cg/GraphicsContextCG.cpp: Missing include added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-06 Andrei Popescu <andreip@google.com>
andreip@google.com [Thu, 6 Jan 2011 17:57:50 +0000 (17:57 +0000)]
2011-01-06  Andrei Popescu  <andreip@google.com>

        Unreviewed, rolling out r75152.

        [Chromium] fast/gradients/css3-radial-gradients3.html needs Chromium-specific results
        https://bugs.webkit.org/show_bug.cgi?id=51988

        Rolling out since, on closer inspection, the expectations are wrong and the corresponding test really fails.

        * platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.checksum: Removed.
        * platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.png: Removed.
        * platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.checksum: Removed.
        * platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-06 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 6 Jan 2011 17:36:49 +0000 (17:36 +0000)]
2011-01-06  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r75139.

        Try to remove include after adding forward-declaration in r75145.

        * platform/graphics/Gradient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=51811
reni@webkit.org [Thu, 6 Jan 2011 16:50:45 +0000 (16:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=51811
Merge m_height and m_width members of ImageData into the new m_size member.

Patch by Renata Hodovan <reni@webkit.org> on 2011-01-06
Reviewed by Andreas Kling.

Image (BitmapImage, ImageSource) types in WebKit use IntSize to store their
width and height argument, except ImageData. This patch refactors ImageData
to follow the style of other Image types in WebKit.
Using of PassRefPtrs other than argument passing is not allowed in WebKit anymore.
This patch also refactors the PassRefPtr usages of ImageData.

It's just a refactoring, so we don't need any new tests.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::readTerminal):
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::ZigZag::Reader::readImageData):
* html/ImageData.cpp:
(WebCore::ImageData::create):
(WebCore::ImageData::ImageData):
* html/ImageData.h:
(WebCore::ImageData::size):
(WebCore::ImageData::width):
(WebCore::ImageData::height):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::createEmptyImageData):
(WebCore::CanvasRenderingContext2D::createImageData):
(WebCore::CanvasRenderingContext2D::getImageData):
* html/canvas/CanvasRenderingContext2D.h:
* platform/graphics/haiku/ImageBufferHaiku.cpp:
(WebCore::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: document.querySelector(':nth-child(foo)') should throw a syntax error
yael.aharon@nokia.com [Thu, 6 Jan 2011 16:46:36 +0000 (16:46 +0000)]
WebCore: document.querySelector(':nth-child(foo)') should throw a syntax error
https://bugs.webkit.org/show_bug.cgi?id=51231

Reviewed by Darin Adler.

Also fixes
CSSNthSelector parsing code is illegible and buggy (allows "n3" as a valid selector)
https://bugs.webkit.org/show_bug.cgi?id=21815

Add a check in the parser that other than an+b, only "odd" or "even" would be allowed
as parameters to nth selector.

Tests: fast/css/css3-nth-tokens-script.html
       fast/css/css3-nth-tokens-style.html

* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::isValidNthToken):
* css/CSSParser.h:

LayoutTests: document.querySelector(':nth-child(foo)') should throw a syntax error
https://bugs.webkit.org/show_bug.cgi?id=51231
CSSNthSelector parsing code is illegible and buggy (allows "n3" as a valid selector)
https://bugs.webkit.org/show_bug.cgi?id=21815

Reviewed by Darin Adler.

* fast/css/css3-nth-tokens-script-expected.txt: Added.
* fast/css/css3-nth-tokens-script.html: Added.
* fast/css/css3-nth-tokens-style-expected.txt: Added.
* fast/css/css3-nth-tokens-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-06 Jan Erik Hanssen <jhanssen@sencha.com>
commit-queue@webkit.org [Thu, 6 Jan 2011 16:31:47 +0000 (16:31 +0000)]
2011-01-06  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] crash in QNetworkReplyHandler::sendResponseIfNeeded()
        https://bugs.webkit.org/show_bug.cgi?id=51453

        Check if m_reply is NULL before accessing.

        * manual-tests/load-deferrer-resume-crash.html: Added.
        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::setLoadMode):
        (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRedo the half-done rename from the last check-in.
darin@apple.com [Thu, 6 Jan 2011 16:24:42 +0000 (16:24 +0000)]
Redo the half-done rename from the last check-in.
Sorry for the broken build last night.

* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::removeItem): Renamed.
* WebProcess/WebPage/WebBackForwardListProxy.h: Updated
for new name.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didRemoveBackForwardItem): Updated to
use the new name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-06 Andrei Popescu <andreip@google.com>
andreip@google.com [Thu, 6 Jan 2011 16:16:17 +0000 (16:16 +0000)]
2011-01-06  Andrei Popescu  <andreip@google.com>

        Unreviewed, build fix.

        [Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=51989

        Updating the test expectations for the chromium-gpu platform.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-06 Andrei Popescu <andreip@google.com>
andreip@google.com [Thu, 6 Jan 2011 15:31:26 +0000 (15:31 +0000)]
2011-01-06  Andrei Popescu  <andreip@google.com>

        Unreviewed, build fix.

        [Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=51989

        Added suppressions for
        svg/batik/text/textEffect.svg
        svg/batik/text/textEffect3.svg
        svg/css/composite-shadow-text.svg
        svg/custom/js-late-gradient-and-object-creation.svg
        svg/custom/js-late-gradient-creation.svg
        svg/text/selection-background-color.xhtml
        svg/text/selection-styles.xhtml
        svg/text/text-gradient-positioning.svg

        These tests are all failing as a result of the same change: r75153.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-06 Andrei Popescu <andreip@google.com>
andreip@google.com [Thu, 6 Jan 2011 14:32:15 +0000 (14:32 +0000)]
2011-01-06  Andrei Popescu  <andreip@google.com>

        Unreviewed, build fix.

        [Chromium] canvas/canvas-fillRect-gradient-shadow.html fails on Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=51989

        Updating Chromium expectations until we find a fix.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-06 Andrei Popescu <andreip@google.com>
andreip@google.com [Thu, 6 Jan 2011 14:13:29 +0000 (14:13 +0000)]
2011-01-06  Andrei Popescu  <andreip@google.com>

        Unreviewed, build fix.

        [Chromium] fast/gradients/css3-radial-gradients3.html needs Chromium-specific results
        https://bugs.webkit.org/show_bug.cgi?id=51988

        * platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.checksum: Added.
        * platform/chromium-mac/fast/gradients/css3-radial-gradients3-expected.png: Added.
        * platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.checksum: Added.
        * platform/chromium-win/fast/gradients/css3-radial-gradients3-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-06 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Thu, 6 Jan 2011 14:04:42 +0000 (14:04 +0000)]
2011-01-06  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][V8] Fix the build when DEVICE_ORIENTATION is enabled.

        No new tests needed.

        * WebCore.pro: remove duplications and globally add RuntimeEnabledFeatures.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Thu, 6 Jan 2011 12:48:54 +0000 (12:48 +0000)]
Unreviewed.

[Qt] Web Timing related bugs
https://bugs.webkit.org/show_bug.cgi?id=51245

* platform/qt/Skipped: Add new tests.
 - http/tests/misc/webtiming-origins.html
 - http/tests/misc/webtiming-slow-load.php

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-06 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 6 Jan 2011 11:31:08 +0000 (11:31 +0000)]
2011-01-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        The EWS should log outside of the working directory
        https://bugs.webkit.org/show_bug.cgi?id=51986

        This patch prepare us for using git clean -x -d -f in the EWS wrapper
        script, which will actually clean the working copy back to a pristine
        state instead of leaving untracked directories and ignored files.

        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-06 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Thu, 6 Jan 2011 10:49:49 +0000 (10:49 +0000)]
2011-01-06  Helder Correia  <helder@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][GTK] Use GraphicsContext::hasShadow() in port-specific code
        https://bugs.webkit.org/show_bug.cgi?id=51985

        r75139 introduced GraphicsContext::hasShadow(). This can now simplify
        and unify some code in the Qt and GTK ports.

        No new tests necessary for this refactoring.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build for Darin's previous change w/ the obvious renaming.
mjs@apple.com [Thu, 6 Jan 2011 08:41:49 +0000 (08:41 +0000)]
Fix build for Darin's previous change w/ the obvious renaming.

Rubber stamped by Dan Bernstein.

* WebProcess/WebPage/WebBackForwardListProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didRemoveBackForwardItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-12-29 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Thu, 6 Jan 2011 07:43:20 +0000 (07:43 +0000)]
2010-12-29  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add a WebAutoFillClient interface that moves some functions from WebViewClient
        https://bugs.webkit.org/show_bug.cgi?id=51710

        * WebKit.gyp:
        * public/WebAutoFillClient.h: Added.
        (WebKit::WebAutoFillClient::didAcceptAutoFillSuggestion):
        (WebKit::WebAutoFillClient::didSelectAutoFillSuggestion):
        (WebKit::WebAutoFillClient::didClearAutoFillSelection):
        (WebKit::WebAutoFillClient::removeAutocompleteSugestion):
        (WebKit::WebAutoFillClient::didAcceptAutocompleteSuggestion):
        (WebKit::WebAutoFillClient::textFieldDidBeginEditing):
        (WebKit::WebAutoFillClient::textFieldDidEndEditing):
        (WebKit::WebAutoFillClient::textFieldDidChange):
        (WebKit::WebAutoFillClient::textFieldDidReceiveKeyDown):
        (WebKit::WebAutoFillClient::~WebAutoFillClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Chromium Mac build.
darin@apple.com [Thu, 6 Jan 2011 07:16:02 +0000 (07:16 +0000)]
Fix Chromium Mac build.

* platform/graphics/Gradient.h: Forward-declare CGContextRef.
This might even make it possible to remove the include of
<CoreGraphics/CoreGraphics.h> for PLATFORM(WIN), but I did not
do that at this time because I don't want to break the Windows
build when fixing the Chromium build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 6 Jan 2011 07:12:19 +0000 (07:12 +0000)]
2011-01-05  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        Back/Forward entries in WebKit2 leak
        https://bugs.webkit.org/show_bug.cgi?id=51983

        Besides fixing the leak, this also fixes a problem where
        all history items were sent over to the UI process, but
        we wanted to send only back/forward items.

        * UIProcess/WebBackForwardList.cpp:
        (WebKit::WebBackForwardList::pageClosed): Added.
        Tells the web process about all the back/forward
        items being removed.
        (WebKit::WebBackForwardList::addItem): Ditto.
        Also removed a redundant call to didChangeBackForwardList.
        (WebKit::WebBackForwardList::clear): Ditto.

        * UIProcess/WebBackForwardList.h: Added pageClosed.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::close): Added a call to pageClosed.
        (WebKit::WebPageProxy::backForwardRemovedItem): Added.
        Sends a message to the web page in the web process.

        * UIProcess/WebPageProxy.h: Added backForwardRemovedItem.

        * WebProcess/WebPage/WebBackForwardListProxy.cpp:
        (WebKit::updateBackForwardItem): Added an itemID argument,
        since callers will now be getting it and we don't want to
        get it twice. Removed the code to generate an ID. Also
        removed some local variables to make the code a little
        tighter and clearer.
        (WebKit::WK2NotifyHistoryItemChanged): Only call
        updateBackForwardItem for items that already have IDs.
        We don't want to send cross-process messages for every
        history item; just the ones that are top level back/forward
        items.
        (WebKit::WebBackForwardListProxy::removeItem):
        Added. For use when the UI process tells us to remove it.
        (WebKit::WebBackForwardListProxy::addItem): Added code to
        assign an ID and put this item into the maps. This is called
        exactly once on each back/forward item.

        * WebProcess/WebPage/WebBackForwardListProxy.h: Added
        removeItem.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::didRemoveBackForwardItem): Added.

        * WebProcess/WebPage/WebPage.h: Added didRemoveBackForwardItem.

        * WebProcess/WebPage/WebPage.messages.in: Added
        DidRemoveBackForwardItem message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix.
sfalken@apple.com [Thu, 6 Jan 2011 07:11:22 +0000 (07:11 +0000)]
Windows build fix.
Back out attempted change to built-product-archive.

* BuildSlaveSupport/built-product-archive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix.
sfalken@apple.com [Thu, 6 Jan 2011 07:00:26 +0000 (07:00 +0000)]
Windows build fix.
Include configuration name when unpacking a build archive.

Needed, since we split Windows build results into configuration-specific directories
under WebKitOutputDir.

* BuildSlaveSupport/built-product-archive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix.
sfalken@apple.com [Thu, 6 Jan 2011 06:20:35 +0000 (06:20 +0000)]
Windows build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: Revert change to additional library search path needed to find ICU.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Xianzhu Wang <wangxianzhu@google.com>
commit-queue@webkit.org [Thu, 6 Jan 2011 06:15:21 +0000 (06:15 +0000)]
2011-01-05  Xianzhu Wang  <wangxianzhu@google.com>

        Reviewed by David Levin.

        Implement RemoteFontStream's skip behavior (in FontCustomPlatformData.cpp)
        https://bugs.webkit.org/show_bug.cgi?id=51736

        No new tests. This change has potential effect on @font-face CSS feature
        on ports using Skia. Tested on Chromium that this change won't break
        fast/css/font-face-remote.html. This change can make the test pass on
        other ports using Skia.

        * platform/graphics/skia/FontCustomPlatformData.cpp:
        (WebCore::RemoteFontStream::read):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Thu, 6 Jan 2011 06:11:02 +0000 (06:11 +0000)]
2011-01-05  Helder Correia  <helder@sencha.com>

        Reviewed by Simon Fraser.

        Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
        https://bugs.webkit.org/show_bug.cgi?id=51869

        GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
        The shadow is being drawn, but getting clipped to the rect being filled.
        The solution is to draw the gradient into a CGLayer (when a shadow is
        required), then render the layer to the GraphicsContext.

        This patch also fixes:
        canvas/philip/tests/2d.shadow.gradient.alpha.html
        canvas/philip/tests/2d.shadow.gradient.basic.html
        canvas/philip/tests/2d.shadow.gradient.transparent.2.html

        New test to ensure that shadows are drawn when fillStyle is a gradient,
        possibly with some transparency and blur, and specifically using
        fillRect.

        * fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
        * fast/canvas/canvas-fillRect-gradient-shadow.html: Added.
        * fast/canvas/script-tests/canvas-fillRect-gradient-shadow.js: Added.
2011-01-05  Helder Correia  <helder@sencha.com>

        Reviewed by Simon Fraser.

        Shadows are not drawn when filling a rect with a gradient fillStyle on Mac and Chromium-Mac
        https://bugs.webkit.org/show_bug.cgi?id=51869

        GraphicsContext::fillRect(const FloatRect&) is clipping to the rect.
        The shadow is being drawn, but getting clipped to the rect being filled.
        The solution is to draw the gradient into a CGLayer (when a shadow is
        required), then render the layer to the GraphicsContext.

        This patch also fixes:
        canvas/philip/tests/2d.shadow.gradient.alpha.html
        canvas/philip/tests/2d.shadow.gradient.basic.html
        canvas/philip/tests/2d.shadow.gradient.transparent.2.html

        Test: fast/canvas/canvas-fillRect-gradient-shadow.html

        * platform/graphics/Gradient.h:
        * platform/graphics/cg/GradientCG.cpp:
        (WebCore::Gradient::paint):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Thu, 6 Jan 2011 06:02:13 +0000 (06:02 +0000)]
2011-01-05  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Debug and Release builds on Windows clobber each other
        https://bugs.webkit.org/show_bug.cgi?id=49185

        Changes the structure of WebKitBuild build products directory so we
        completely separate each build configuration into independent directories.

        Although we previously had per-configuration directories for obj, this change adds
        per-configuration directories for bin, lib, obj, and include. Each configuration's
        build products are stored within a directory inside of WebKitBuild.

        Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
        defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

        * win/tools/vsprops/common.vsprops:
2011-01-05  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Debug and Release builds on Windows clobber each other
        https://bugs.webkit.org/show_bug.cgi?id=49185

        Changes the structure of WebKitBuild build products directory so we
        completely separate each build configuration into independent directories.

        Although we previously had per-configuration directories for obj, this change adds
        per-configuration directories for bin, lib, obj, and include. Each configuration's
        build products are stored within a directory inside of WebKitBuild.

        Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
        defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

        * WebKit.vcproj/InterfacesCommon.vsprops:
        * WebKit.vcproj/InterfacesPostBuild.cmd:
        * WebKit.vcproj/InterfacesPreBuild.cmd:
        * WebKit.vcproj/WebKit.make:
        * WebKit.vcproj/WebKitGUID.vcproj:
        * WebKit.vcproj/WebKitGUIDCommon.vsprops:
        * WebKit.vcproj/WebKitGUIDPostBuild.cmd:
        * WebKit.vcproj/WebKitGUIDPreBuild.cmd:
        * WebKit.vcproj/WebKitLibCommon.vsprops:
        * WebKit.vcproj/WebKitLibPostBuild.cmd:
        * WebKit.vcproj/WebKitLibPreBuild.cmd:
2011-01-05  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Debug and Release builds on Windows clobber each other
        https://bugs.webkit.org/show_bug.cgi?id=49185

        Changes the structure of WebKitBuild build products directory so we
        completely separate each build configuration into independent directories.

        Although we previously had per-configuration directories for obj, this change adds
        per-configuration directories for bin, lib, obj, and include. Each configuration's
        build products are stored within a directory inside of WebKitBuild.

        Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
        defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

        * WebCore.vcproj/QTMovieWinCommon.vsprops:
        * WebCore.vcproj/QTMovieWinPostBuild.cmd:
        * WebCore.vcproj/QTMovieWinPreBuild.cmd:
        * WebCore.vcproj/WebCore.make:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/WebCoreCommon.vsprops:
        * WebCore.vcproj/WebCoreGeneratedCairo.vsprops:
        * WebCore.vcproj/WebCoreGeneratedCommon.vsprops:
        * WebCore.vcproj/WebCoreMediaQT.vsprops:
        * WebCore.vcproj/WebCorePostBuild.cmd:
        * WebCore.vcproj/WebCorePreBuild.cmd:
        * WebCore.vcproj/copyForwardingHeaders.cmd:
        * WebCore.vcproj/copyInspectorFiles.cmd:
2011-01-05  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Debug and Release builds on Windows clobber each other
        https://bugs.webkit.org/show_bug.cgi?id=49185

        Changes the structure of WebKitBuild build products directory so we
        completely separate each build configuration into independent directories.

        Although we previously had per-configuration directories for obj, this change adds
        per-configuration directories for bin, lib, obj, and include. Each configuration's
        build products are stored within a directory inside of WebKitBuild.

        Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
        defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

        For PGO, $(ConfigurationBuildDir) points to the same directory (Release_PGO) to allow
        for proper operation of the instrumentation/optimization scripts.

        * JavaScriptCore.vcproj/JavaScriptCore.make:
        * JavaScriptCore.vcproj/JavaScriptCore.sln:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGeneratedCommon.vsprops:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePGOOptimize.vsprops: Added.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePostBuild.cmd:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCorePreBuild.cmd:
        * JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
        * JavaScriptCore.vcproj/JavaScriptCore/react-to-vsprops-changes.py:
        * JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.vcproj/WTF/WTFCommon.vsprops:
        * JavaScriptCore.vcproj/WTF/WTFPostBuild.cmd:
        * JavaScriptCore.vcproj/WTF/WTFPreBuild.cmd:
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:
        * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
        * JavaScriptCore.vcproj/jsc/jscPostBuild.cmd:
        * JavaScriptCore.vcproj/jsc/jscPreBuild.cmd:
        * JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
        * JavaScriptCore.vcproj/testapi/testapiPostBuild.cmd:
        * JavaScriptCore.vcproj/testapi/testapiPreBuild.cmd:
2011-01-05  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Debug and Release builds on Windows clobber each other
        https://bugs.webkit.org/show_bug.cgi?id=49185

        Changes the structure of WebKitBuild build products directory so we
        completely separate each build configuration into independent directories.

        Although we previously had per-configuration directories for obj, this change adds
        per-configuration directories for bin, lib, obj, and include. Each configuration's
        build products are stored within a directory inside of WebKitBuild.

        Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
        defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
        * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
        * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
        * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
        * DumpRenderTree/win/ImageDiffCommon.vsprops:
        * DumpRenderTree/win/ImageDiffPostBuild.cmd:
        * DumpRenderTree/win/ImageDiffPreBuild.cmd:
        * FindSafari/FindSafari.vcproj:
        * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
        * MiniBrowser/MiniBrowserPostBuild.cmd:
        * MiniBrowser/MiniBrowserPreBuild.cmd:
        * Scripts/webkitdirs.pm:
        * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
        * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
        * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
        * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
        * TestWebKitAPI/win/copy-resources.cmd:
        * WebKitAPITest/WebKitAPITestCommon.vsprops:
        * WebKitAPITest/WebKitAPITestPostBuild.cmd:
        * WebKitAPITest/WebKitAPITestPreBuild.cmd:
        * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
        * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
        * WebKitTestRunner/win/InjectedBundle.vcproj:
        * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
        * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
        * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
        * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
        * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
        * WinLauncher/WinLauncherCommon.vsprops:
        * WinLauncher/WinLauncherPostBuild.cmd:
        * WinLauncher/WinLauncherPreBuild.cmd:
2011-01-05  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Debug and Release builds on Windows clobber each other
        https://bugs.webkit.org/show_bug.cgi?id=49185

        Changes the structure of WebKitBuild build products directory so we
        completely separate each build configuration into independent directories.

        Although we previously had per-configuration directories for obj, this change adds
        per-configuration directories for bin, lib, obj, and include. Each configuration's
        build products are stored within a directory inside of WebKitBuild.

        Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
        defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

        * win/WebKit2.make:
        * win/WebKit2.vcproj:
        * win/WebKit2Common.vsprops:
        * win/WebKit2Generated.make:
        * win/WebKit2GeneratedCommon.vsprops:
        * win/WebKit2WebProcessPostBuild.cmd:
        * win/WebKit2WebProcessPreBuild.cmd:
        * win/WebKitPostBuild.cmd:
        * win/WebKitPreBuild.cmd:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 6 Jan 2011 05:44:38 +0000 (05:44 +0000)]
2011-01-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Ariya Hidayat.

        Directly composited SVG images fail to render
        https://bugs.webkit.org/show_bug.cgi?id=51975

        There was already code, added in r67900, to detect whether an image
        may be directly composited, by checking to see if it's a bitmap image.

        However, CachedImage::image() returns the nullImage() if m_image is null,
        which is a BitmapImage, confusing this test.

        Test: compositing/images/direct-svg-image.html

        * loader/cache/CachedImage.cpp: Remove nullImage(), since Image has
        exactly the same method.
        (WebCore::CachedImage::image): Use Image::nullImage().
        * loader/cache/CachedImage.h:
        (WebCore::CachedImage::hasImage): New method to ask whether the m_image is
        non-null.
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use hasImage()
        so that we don't test the nullImage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 6 Jan 2011 05:28:11 +0000 (05:28 +0000)]
2011-01-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Fix percentage values in radius of radial gradients
        https://bugs.webkit.org/show_bug.cgi?id=51979

        Handle percentage values for the ending size of radial gradients.

        Test: fast/gradients/css3-radial-gradients3.html

        * css/CSSGradientValue.cpp:
        (WebCore::CSSRadialGradientValue::resolveRadius): Add parameter for height or width, which is
        non-null if percentage values are allowed, and compute percentage values when we see them.
        (WebCore::CSSRadialGradientValue::createGradient): Pass height or width down to say that
        percentages are OK when resolving end radii.
        * css/CSSGradientValue.h: New parameter for resolveRadius.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Alexey Proskuryakov <ap@apple.com>
ap@apple.com [Thu, 6 Jan 2011 05:16:00 +0000 (05:16 +0000)]
2011-01-05  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=51973
        Make main frame PDF printing work

        * UIProcess/API/mac/PDFViewController.h:
        * UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::makePrintOperation):
        Ask PDFDocument to create an NSPrintOperation.

        * UIProcess/API/mac/WKView.h:
        * UIProcess/API/mac/WKView.mm:
        (-[WKView printOperationWithPrintInfo:forFrame:]): Create a new NSPrintOperation, either
        from scratch or from a PDF view.
        (-[WKView canPrintHeadersAndFooters]): Report if the view can be re-paginated to add headers
        and footers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Jan Erik Hanssen <jhanssen@sencha.com>
commit-queue@webkit.org [Thu, 6 Jan 2011 04:56:05 +0000 (04:56 +0000)]
2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Ariya Hidayat.

        [Qt] TestNetscapePlugin doesn't link on OS X
        https://bugs.webkit.org/show_bug.cgi?id=51948

        Only add a dependency on libX11 on X11 systems

        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 6 Jan 2011 04:36:51 +0000 (04:36 +0000)]
2011-01-05  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        change the way we do comment highlighting in the code review tool
        https://bugs.webkit.org/show_bug.cgi?id=51971

        Store a space-separated list of base line IDs on each line that has
        comments associated with that line. This allows for overlapping comments,
        but more importantly, makes adding side-by-side diff support easier.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Jeff Miller <jeffm@apple.com>
commit-queue@webkit.org [Thu, 6 Jan 2011 04:09:23 +0000 (04:09 +0000)]
2011-01-05  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
        https://bugs.webkit.org/show_bug.cgi?id=51970

        * Scripts/webkitpy/style/checker.py:
        Add -readability/naming for WebKit2 C API directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 6 Jan 2011 03:19:45 +0000 (03:19 +0000)]
2011-01-05  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        minor code cleanup for code review tool
        https://bugs.webkit.org/show_bug.cgi?id=51962

        Consolidates some queries to using shared functions.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 6 Jan 2011 02:50:16 +0000 (02:50 +0000)]
2011-01-05  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        assorted cleanups to prepare for side-by-side diffing
        https://bugs.webkit.org/show_bug.cgi?id=51961

        Mostly, use selector queries instead of assuming comments are next siblings.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Thu, 6 Jan 2011 02:41:13 +0000 (02:41 +0000)]
2011-01-05  James Simonsen  <simonjam@chromium.org>

        Reviewed by Adam Barth.

        [Web Timing] Zero out some values on cross-origin redirects
        https://bugs.webkit.org/show_bug.cgi?id=49294

        * fast/dom/script-tests/webtiming.js:
        (checkTimingBeforeLoad): Remove unload. Its behavior depends on prior navigation and is tested separately.
        (checkTimingWhileDeferred): Ditto.
        (checkWebTimingOnDOMContentLoaded): Ditto.
        (checkWebTimingWhileAsync): Ditto.
        (checkWebTimingOnLoad): Ditto.
        (checkWebTimingAfterLoad): Ditto.
        * fast/dom/webtiming-expected.txt:
        * http/tests/misc/resources/webtiming-cross-origin-and-back-redirect1.php: Added.
        * http/tests/misc/resources/webtiming-cross-origin-and-back-redirect2.php: Added.
        * http/tests/misc/resources/webtiming-cross-origin-and-back1.html: Added.
        * http/tests/misc/resources/webtiming-cross-origin-and-back2.html: Added.
        * http/tests/misc/resources/webtiming-cross-origin-redirect.html: Added.
        * http/tests/misc/resources/webtiming-cross-origin-redirect.php: Added.
        * http/tests/misc/resources/webtiming-no-origin.html: Added.
        * http/tests/misc/webtiming-origins-expected.txt: Added.
        * http/tests/misc/webtiming-origins.html: Added.
        * platform/gtk/Skipped: Skip new web timing test.
        * platform/mac/Skipped: Ditto.
        * platform/win/Skipped: Ditto.
2011-01-05  James Simonsen  <simonjam@chromium.org>

        Reviewed by Adam Barth.

        [Web Timing] Zero out some values on cross-origin redirects
        https://bugs.webkit.org/show_bug.cgi?id=49294

        Tests: http/tests/misc/webtiming-cross-origin-redirect.php
               http/tests/misc/webtiming-origins.html

        * loader/DocumentLoadTiming.h:
        (WebCore::DocumentLoadTiming::DocumentLoadTiming): Add flags for cross-origin redirects and same-origin navigation.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::~FrameLoader):
        (WebCore::FrameLoader::stopLoading): Don't overwrite previous unload times.
        (WebCore::FrameLoader::completed):
        (WebCore::FrameLoader::loadWithDocumentLoader): Remember previous URL to see if navigation is same-origin.
        (WebCore::FrameLoader::commitProvisionalLoad): Set flag if navigation is same-origin.
        * loader/FrameLoader.h:
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::willSendRequest): Set flag on cross-origin redirects.
        * page/PerformanceNavigation.cpp:
        (WebCore::PerformanceNavigation::redirectCount): Clear if cross-origin redirect flag is set.
        * page/PerformanceTiming.cpp:
        (WebCore::PerformanceTiming::redirectStart): Ditto.
        (WebCore::PerformanceTiming::redirectEnd): Ditto.
        (WebCore::PerformanceTiming::unloadEventStart): Clear if cross-origin navigation is set.
        (WebCore::PerformanceTiming::unloadEventEnd): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8750248>
andersca@apple.com [Thu, 6 Jan 2011 02:39:45 +0000 (02:39 +0000)]
<rdar://problem/8750248>
Need a way to create a new DownloadProxy from an arbitrary resource request

Reviewed by Sam Weinig.

<rdar://problem/8750465>
Need a way to start a download in WKDownload

<rdar://problem/8752204>
WK2 Context Menus - "Save linked file" support

* Shared/ContextMenuState.h: Added.
Add a ContextMenuState struct which contains state for context menus.

* UIProcess/API/C/WKContext.cpp:
(WKContextDownloadURLRequest):
Call WebContext::download.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::download):
Send a DownloadRequest message to the web process.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showContextMenu):
Set the active context menu state.

(WebKit::WebPageProxy::contextMenuItemSelected):
Handle ContextMenuItemTagDownloadImageToDisk and ContextMenuItemTagDownloadLinkToDisk by calling
WebContext::Download, passing the respective URLs.

* UIProcess/WebPageProxy.messages.in:
ShowContextMenu now takes state as well.

* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::downloadURL):
Assert that this is never reached; downloads are handled in the UI process.

* WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::show):
Pass the context menu state along when sending the ShowContextMenu message.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::downloadRequest):
Call the shared DownloadManager.

* WebProcess/WebProcess.messages.in:
Add DownloadRequest message.

* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add ContextMenuState.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 6 Jan 2011 02:33:23 +0000 (02:33 +0000)]
2011-01-05  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        fix message container selector for code review tool
        https://bugs.webkit.org/show_bug.cgi?id=51959

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Thu, 6 Jan 2011 02:16:55 +0000 (02:16 +0000)]
2011-01-05  Helder Correia  <helder@sencha.com>

        Reviewed by Ariya Hidayat.

        [Qt] Default focus ring is too wide
        https://bugs.webkit.org/show_bug.cgi?id=51854

        This is an intermediate step to solve this bug. Use QPalette::Highlight
        instead of default half-transparent black as the focus ring color.

        * platform/qt/editing/selection/caret-and-focus-ring-expected.checksum: Added.
        * platform/qt/editing/selection/caret-and-focus-ring-expected.png: Added.
        * platform/qt/editing/selection/caret-and-focus-ring-expected.txt: Added.
        * platform/qt/fast/css/focus-ring-outline-color-expected.checksum:
        * platform/qt/fast/css/focus-ring-outline-color-expected.png:
        * platform/qt/fast/css/focus-ring-outline-offset-expected.checksum:
        * platform/qt/fast/css/focus-ring-outline-offset-expected.png:
        * platform/qt/fast/css/focus-ring-outline-width-expected.checksum:
        * platform/qt/fast/css/focus-ring-outline-width-expected.png:
2011-01-05  Helder Correia  <helder@sencha.com>

        Reviewed by Ariya Hidayat.

        [Qt] Default focus ring is too wide
        https://bugs.webkit.org/show_bug.cgi?id=51854

        This is an intermediate step to solve this bug. Use QPalette::Highlight
        instead of default half-transparent black as the focus ring color.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::drawFocusRingForPath):
        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::platformFocusRingColor):
        * platform/qt/RenderThemeQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 6 Jan 2011 02:15:05 +0000 (02:15 +0000)]
2011-01-05  Eric Seidel  <eric@webkit.org>

        Unreviewed, just fixing one more log error from my previous python patch.

        Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
        https://bugs.webkit.org/show_bug.cgi?id=51802

        webkit-patch failure-reason was logging about parsing errors
        due to my misunderstanding of how BeautifulSoup.findAll worked.

        Fixed, and added a unit test.

        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Thu, 6 Jan 2011 02:04:34 +0000 (02:04 +0000)]
2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
        https://bugs.webkit.org/show_bug.cgi?id=51951

        Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
        to create new window from WebKit.

        * MiniBrowser/qt/BrowserWindow.cpp:
        (newPageFunction):
        (BrowserWindow::BrowserWindow):
        (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
        (BrowserWindow::newWindow):
        (BrowserWindow::updateUserAgentList):
        (BrowserWindow::showUserAgentDialog):
        * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
        define the type of the backing store used for new windows.
        * MiniBrowser/qt/main.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 6 Jan 2011 01:38:03 +0000 (01:38 +0000)]
2011-01-05  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix.

        [Qt] [Symbian] Fix building NPAPI support

        NPEvent is mapped to QAction on Symbian. QAction has no
        default constructor, so toNP() fails to build. Add a case for
        Symbian behind the OS(SYMBIAN) guard.

        * WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
        (WebKit::toNP):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Jeff Miller <jeffm@apple.com>
commit-queue@webkit.org [Thu, 6 Jan 2011 01:28:16 +0000 (01:28 +0000)]
2011-01-05  Jeff Miller  <jeffm@apple.com>

        Reviewed by Dan Bernstein.

        Copy WKImageCG.h to include\WebKit2 in build output
        https://bugs.webkit.org/show_bug.cgi?id=51944

        * win/WebKit2Generated.make:
        Add xcopy command to copy WKImageCG.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPart of <rdar://problem/8261624> and https://bugs.webkit.org/show_bug.cgi?id=47355
beidson@apple.com [Thu, 6 Jan 2011 01:26:16 +0000 (01:26 +0000)]
Part of <rdar://problem/8261624> and https://bugs.webkit.org/show_bug.cgi?id=47355
Change WebKit2 session restoring to restore the full back/forward list

Reviewed by Sam Weinig.

Add a new message to tell the WebProcess to restore a session state:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreSession):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Add the new message, AND fix the intentional misspellings.

Also, Sam sucks.

Change WebProcess back/forward list item ids to be odd (UIProcess's will be even):
* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::generateHistoryItemID):

Provide accessors to the entries in the list to pass to the WebProcess:
* UIProcess/WebBackForwardList.h:
(WebKit::WebBackForwardList::entries):
(WebKit::WebBackForwardList::currentIndex):

Add decoding of the saved back/forward list itmes (we already encode them):
* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::generateWebBackForwardItemID):
(WebKit::WebBackForwardList::restoreFromCFDictionaryRepresentation):

Instead of loading the current URL, pass the entire last back to the WebProcess:
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::restoreFromSessionStateData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Thu, 6 Jan 2011 01:22:46 +0000 (01:22 +0000)]
2011-01-05  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] requestStart and responseStart should be available even if the document is still loading
        https://bugs.webkit.org/show_bug.cgi?id=51368

        * http/tests/misc/webtiming-slow-load-expected.txt: Added.
        * http/tests/misc/webtiming-slow-load.php: Added.
2011-01-05  James Simonsen  <simonjam@chromium.org>

        Reviewed by Darin Fisher.

        [Web Timing] requestStart and responseStart should be available even if the document is still loading
        https://bugs.webkit.org/show_bug.cgi?id=51368

        Test: http/tests/misc/webtiming-slow-load.php

        * page/PerformanceTiming.cpp:
        (WebCore::getPossiblySkewedTimeInKnownRange): Handle case where response is not yet complete.
        (WebCore::PerformanceTiming::resourceLoadTimeRelativeToAbsolute): Use full upper bound.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QML WebView does not transfer focus to underlying QGraphicsWebView
girish@forwardbias.in [Thu, 6 Jan 2011 00:41:48 +0000 (00:41 +0000)]
[Qt] QML WebView does not transfer focus to underlying QGraphicsWebView

QML WebView creates QGraphicsWebView as it's child. The WebView is not
setup as a focus proxy of the QGraphicsWebView. Thus, even though the
WebView gets focus, the QGraphicsWebView does not get focus.
In QML, focus proxies or "focus scopes" are created using FocusScope.
This change makes WebView a FocusScope and sets the focus on the
QGraphicsWebView.

Reviewed by Simon Hausmann.
Acked by Aaron Kennedy <aaron.kennedy@nokia.com>

https://bugs.webkit.org/show_bug.cgi?id=51094

* declarative/qdeclarativewebview.cpp:
(QDeclarativeWebView::init):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Chris Rogers <crogers@google.com>
crogers@google.com [Thu, 6 Jan 2011 00:37:10 +0000 (00:37 +0000)]
2011-01-05  Chris Rogers  <crogers@google.com>

        Reviewed by Darin Fisher.

        Add WebKitClient::createAudioDevice() for Chromium port of web audio API
        https://bugs.webkit.org/show_bug.cgi?id=51424

        * WebKit.gyp:
        * public/WebAudioDevice.h: Added.
        (WebKit::WebAudioDevice::RenderCallback::~RenderCallback):
        (WebKit::WebAudioDevice::~WebAudioDevice):
        * public/WebKitClient.h:
        (WebKit::WebKitClient::createAudioDevice):
        * src/AudioDestinationChromium.cpp: Added.
        (WebCore::AudioDestination::create):
        (WebCore::AudioDestinationChromium::AudioDestinationChromium):
        (WebCore::AudioDestinationChromium::~AudioDestinationChromium):
        (WebCore::AudioDestinationChromium::start):
        (WebCore::AudioDestinationChromium::stop):
        (WebCore::AudioDestination::hardwareSampleRate):
        (WebCore::AudioDestinationChromium::render):
        * src/AudioDestinationChromium.h: Added.
        (WebCore::AudioDestinationChromium::isPlaying):
        (WebCore::AudioDestinationChromium::sampleRate):
2011-01-05  Chris Rogers  <crogers@google.com>

        Reviewed by Darin Fisher.

        Add WebKitClient::createAudioDevice() for Chromium port of web audio API
        https://bugs.webkit.org/show_bug.cgi?id=51424

        No new tests since audio API is not yet implemented.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=51953
beidson@apple.com [Thu, 6 Jan 2011 00:32:53 +0000 (00:32 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=51953
Add a "SessionState" object for IPC messaging.

Reviewed by Darin Adler.

This object includes all data necessary to restore a session state;
For now, this is just the back/forward list to restore.

* Shared/SessionState.cpp: Added.
(WebKit::SessionState::SessionState):
(WebKit::SessionState::encode):
(WebKit::SessionState::decode):
* Shared/SessionState.h: Added.
(WebKit::SessionState::list):
(WebKit::SessionState::currentIndex):

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 6 Jan 2011 00:28:45 +0000 (00:28 +0000)]
2011-01-05  Kent Tamura  <tkent@chromium.org>

        Unreviewed, test expectation update.

        Rebaseline of renderer-destruction-by-invalidateSelection-crash.html

        * platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
        * platform/chromium-linux/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
        * platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Added.
        * platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
        * platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
        * platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry again.
andersca@apple.com [Thu, 6 Jan 2011 00:17:18 +0000 (00:17 +0000)]
Try again.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 6 Jan 2011 00:10:21 +0000 (00:10 +0000)]
2011-01-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Ojan Vafai.

        commit-queue should report failure type when reporting flaky tests
        https://bugs.webkit.org/show_bug.cgi?id=51900

        This patch was a ridiculous amount of plumbing.  In the end I like
        the NRWT-style TestResult class even less.  But now we're passing
        a list of TestResult objects from the queue to the FlakyTestReporter.
        Thus the FlakyTestReporter can more easily report what type of failure
        occurred.

        In the process, I found that I was not alone in finding TestResult
        cumbersome to use.  A bunch of code was trying to create a TestResult
        object with default values.  However since the constructor didn't make
        this easy, some places were getting it wrong (including the TestResult unit test)!
        I've fixed the TestResult constructor to have default values for non-essential
        arguments.

        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 5 Jan 2011 23:57:02 +0000 (23:57 +0000)]
2011-01-05  Eric Seidel  <eric@webkit.org>

        Unreviewed.

        Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
        https://bugs.webkit.org/show_bug.cgi?id=51802

        Add another unit test to cover a previously missing import.

        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttempt to fix Leopard build.
andersca@apple.com [Wed, 5 Jan 2011 23:48:47 +0000 (23:48 +0000)]
Attempt to fix Leopard build.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Jenn Braithwaite <jennb@chromium.org>
commit-queue@webkit.org [Wed, 5 Jan 2011 23:38:35 +0000 (23:38 +0000)]
2011-01-05  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Adam Barth.

        fast/encoding/parser-tests.html is slow on debug builds
        https://bugs.webkit.org/show_bug.cgi?id=51721

        Break up parser tests to run 10 tests per batch.

        * fast/encoding/parser-tests-10-expected.txt: Added.
        * fast/encoding/parser-tests-10.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-100-expected.txt: Added.
        * fast/encoding/parser-tests-100.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-110-expected.txt: Added.
        * fast/encoding/parser-tests-110.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-120-expected.txt: Added.
        * fast/encoding/parser-tests-120.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-20-expected.txt: Added.
        * fast/encoding/parser-tests-20.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-30-expected.txt: Added.
        * fast/encoding/parser-tests-30.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-40-expected.txt: Added.
        * fast/encoding/parser-tests-40.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-50-expected.txt: Added.
        * fast/encoding/parser-tests-50.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-60-expected.txt: Added.
        * fast/encoding/parser-tests-60.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-70-expected.txt: Added.
        * fast/encoding/parser-tests-70.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-80-expected.txt: Added.
        * fast/encoding/parser-tests-80.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-90-expected.txt: Added.
        * fast/encoding/parser-tests-90.html: Copied from LayoutTests/fast/encoding/parser-tests.html.
        * fast/encoding/parser-tests-expected.txt:
        * fast/encoding/parser-tests.html:
        * fast/encoding/resources/parser-tests.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 5 Jan 2011 23:31:17 +0000 (23:31 +0000)]
2011-01-05  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by David Levin.

        Add mihaip@chromium.org as a reviewer
        https://bugs.webkit.org/show_bug.cgi?id=51966

        Add myself as a reviewer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Wed, 5 Jan 2011 23:18:05 +0000 (23:18 +0000)]
2011-01-05  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        [Chromium] storage/indexeddb/objectstore-basics.html is flaky after r74266
        https://bugs.webkit.org/show_bug.cgi?id=51731

        Fix the layout test by using a known-good date value rather than
        new Date(), which sometimes causes the test to fail.

        (The underlying reason for failing to store certain Date values
        should of course be fixed too, but that will come in a later patch.)

        * platform/chromium/test_expectations.txt:
        * storage/indexeddb/objectstore-basics-expected.txt:
        * storage/indexeddb/objectstore-basics.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 5 Jan 2011 23:17:29 +0000 (23:17 +0000)]
2011-01-05  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] refactor complex text on Linux
        https://bugs.webkit.org/show_bug.cgi?id=51956

        Pull out TextRunWalker from FontLinux.cpp.  Put it in its own file.
        Rename it to ComplexTextController, to match platform/graphics/mac
        more closely.

        No tests because the change is just renaming a class.

        * WebCore.gyp/WebCore.gyp:
        * platform/graphics/chromium/ComplexTextControllerLinux.cpp: Added.
        (WebCore::ComplexTextController::ComplexTextController):
        (WebCore::ComplexTextController::~ComplexTextController):
        (WebCore::ComplexTextController::isWordBreak):
        (WebCore::ComplexTextController::determineWordBreakSpacing):
        (WebCore::ComplexTextController::setPadding):
        (WebCore::ComplexTextController::reset):
        (WebCore::ComplexTextController::setBackwardsIteration):
        (WebCore::ComplexTextController::nextScriptRun):
        (WebCore::ComplexTextController::widthOfFullRun):
        (WebCore::ComplexTextController::setupFontForScriptRun):
        (WebCore::ComplexTextController::allocHarfbuzzFont):
        (WebCore::ComplexTextController::deleteGlyphArrays):
        (WebCore::ComplexTextController::createGlyphArrays):
        (WebCore::ComplexTextController::resetGlyphArrays):
        (WebCore::ComplexTextController::shapeGlyphs):
        (WebCore::ComplexTextController::setGlyphXPositions):
        (WebCore::ComplexTextController::normalizeSpacesAndMirrorChars):
        (WebCore::ComplexTextController::getNormalizedTextRun):
        * platform/graphics/chromium/ComplexTextControllerLinux.h: Added.
        (WebCore::ComplexTextController::setWordSpacingAdjustment):
        (WebCore::ComplexTextController::setLetterSpacingAdjustment):
        (WebCore::ComplexTextController::letterSpacing):
        (WebCore::ComplexTextController::setXOffsetToZero):
        (WebCore::ComplexTextController::rtl):
        (WebCore::ComplexTextController::glyphs):
        (WebCore::ComplexTextController::length):
        (WebCore::ComplexTextController::xPositions):
        (WebCore::ComplexTextController::advances):
        (WebCore::ComplexTextController::width):
        (WebCore::ComplexTextController::logClusters):
        (WebCore::ComplexTextController::numCodePoints):
        (WebCore::ComplexTextController::fontPlatformDataForScriptRun):
        (WebCore::ComplexTextController::isCodepointSpace):
        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::glyphIndexForXPositionInScriptRun):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Wed, 5 Jan 2011 22:46:32 +0000 (22:46 +0000)]
2011-01-05  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix.

        Include unistd.h for _exit() for non-Windows builds.

        Build break noticed on QtWebkit Symbian builds.

        * Shared/ChildProcess.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 5 Jan 2011 22:20:41 +0000 (22:20 +0000)]
2011-01-05  David Levin  <levin@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] WEBKIT_API and styling fixes for the chromium api.
        https://bugs.webkit.org/show_bug.cgi?id=51863

        Removed some incorrect uses of WEBKIT_API.
        Fixed some abbreviations by making them whole words.

        * public/WebAnimationController.h: Removed WEBKIT_API from virtual functions.
        * public/WebFormElement.h: Removed WEBKIT_API from inline functions
        and fixed some abbreviations.
        (WebKit::WebFormElement::WebFormElement):
        (WebKit::WebFormElement::operator=):
        (WebKit::WebFormElement::assign):
        * public/WebIDBDatabaseError.h: Ditto.
        (WebKit::WebIDBDatabaseError::WebIDBDatabaseError):
        (WebKit::WebIDBDatabaseError::operator=):
        * public/WebInputElement.h: Ditto.
        (WebKit::WebInputElement::WebInputElement):
        (WebKit::WebInputElement::operator=):
        (WebKit::WebInputElement::assign):
        * public/WebLabelElement.h: Ditto.
        (WebKit::WebLabelElement::WebLabelElement):
        (WebKit::WebLabelElement::operator=):
        (WebKit::WebLabelElement::assign):
        * public/WebOptionElement.h: Ditto.
        (WebKit::WebOptionElement::WebOptionElement):
        (WebKit::WebOptionElement::operator=):
        (WebKit::WebOptionElement::assign):
        * public/WebSelectElement.h: Ditto (and minor spacing cleanup).
        (WebKit::WebSelectElement::WebSelectElement):
        (WebKit::WebSelectElement::operator=):
        (WebKit::WebSelectElement::assign):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 5 Jan 2011 22:00:15 +0000 (22:00 +0000)]
2011-01-05  Stephen White  <senorblanco@chromium.org>

        Unreviewed; test expectations update..

        Fix the expectations for the hyphenation tests on chromium-win.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 5 Jan 2011 21:56:21 +0000 (21:56 +0000)]
2011-01-05  Stephen White  <senorblanco@chromium.org>

        Unreviewed; test expectations fix.

        * platform/chromium/test_expectations.txt:
        Add expectations for new tests introduced by r75097.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Pratik Solanki <psolanki@apple.com>
psolanki@apple.com [Wed, 5 Jan 2011 21:55:45 +0000 (21:55 +0000)]
2011-01-05  Pratik Solanki  <psolanki@apple.com>

        Reviewed by Darin Adler.

        Merge cf and mac header files with same name
        https://bugs.webkit.org/show_bug.cgi?id=51916

        Since most of the code in the header files is identical, we can merge them and have #if
        USE(CFNETWORK) to separate out the network specific parts.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/network/cf/AuthenticationChallenge.h:
        (WebCore::AuthenticationChallenge::sender):
        (WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge):
        * platform/network/cf/ResourceError.h:
        (WebCore::ResourceError::ResourceError):
        * platform/network/cf/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest):
        * platform/network/cf/ResourceResponse.h:
        (WebCore::ResourceResponse::ResourceResponse):
        * platform/network/mac/AuthenticationChallenge.h: Removed.
        * platform/network/mac/ResourceError.h: Removed.
        * platform/network/mac/ResourceRequest.h: Removed.
        * platform/network/mac/ResourceResponse.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement word transformation
andersca@apple.com [Wed, 5 Jan 2011 21:48:50 +0000 (21:48 +0000)]
Implement word transformation
https://bugs.webkit.org/show_bug.cgi?id=51943

Reviewed by Adele Peterson.

Export Editor functions needed by WebKit2.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Wed, 5 Jan 2011 21:45:41 +0000 (21:45 +0000)]
2011-01-05  James Simonsen  <simonjam@chromium.org>

        Unreviewed. Adding myself to the list of committers.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=51949
beidson@apple.com [Wed, 5 Jan 2011 21:45:04 +0000 (21:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=51949
Make WebBackForwardListItem shared, and add encoders and decoders

Reviewed by Darin Adler.

* Shared/WebBackForwardListItem.cpp: Copied from UIProcess/WebBackForwardListItem.cpp.
(WebKit::WebBackForwardListItem::encode):
(WebKit::WebBackForwardListItem::decode):
* Shared/WebBackForwardListItem.h: Copied from UIProcess/WebBackForwardListItem.h.
* UIProcess/WebBackForwardListItem.cpp: Removed.
* UIProcess/WebBackForwardListItem.h: Removed.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 5 Jan 2011 21:34:28 +0000 (21:34 +0000)]
2011-01-05  Eric Seidel  <eric@webkit.org>

        Unreviewed.

        Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
        https://bugs.webkit.org/show_bug.cgi?id=51802

        Fix two exceptions seen on the bots after my original commit.

        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 5 Jan 2011 21:22:04 +0000 (21:22 +0000)]
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adele Peterson.

        Implement word transformation
        https://bugs.webkit.org/show_bug.cgi?id=51943

        Export Editor functions needed by WebKit2.

        * WebCore.exp.in:
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Handle smart insert/delete
        https://bugs.webkit.org/show_bug.cgi?id=51946

        * Shared/WebPageCreationParameters.cpp:
        (WebKit::WebPageCreationParameters::encode):
        (WebKit::WebPageCreationParameters::decode):
        * Shared/WebPageCreationParameters.h:
        Add isSmartInsertDelete enabled.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]):
        Handle toggleSmartInsertDelete:.

        (-[WKView toggleSmartInsertDelete:]):
        Toggle the smart insert/delete state.

        * UIProcess/TextChecker.h:
        Add isSmartInsertDeleteEnabled and setSmartInsertDeleteEnabled.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy):
        Initialize m_isSmartInsertDeleteEnabled.

        (WebKit::WebPageProxy::contextMenuItemSelected):
        Handle ContextMenuItemTagSmartCopyPaste.

        (WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
        Update the state and send a SetSmartInsertDeleteEnabled message.

        (WebKit::WebPageProxy::creationParameters):
        Initialize isSmartInsertDeleteEnabled.

        * UIProcess/WebPageProxy.h:
        (WebKit::WebPageProxy::isSmartInsertDeleteEnabled):
        Return m_isSmartInsertDeleteEnabled.

        * UIProcess/mac/TextCheckerMac.mm:
        (WebKit::TextChecker::isSmartInsertDeleteEnabled):
        (WebKit::TextChecker::setSmartInsertDeleteEnabled):
        Store and fetch the smart insert delete state.

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::smartInsertDeleteEnabled):
        Call WebPage::isSmartInsertDeleteEnabled.

        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
        (WebKit::WebEditorClient::toggleSmartInsertDelete):
        Assert that this is never called.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage):
        Initialize m_isSmartInsertDeleteEnabled

        * WebProcess/WebPage/WebPage.h:
        (WebKit::WebPage::isSmartInsertDeleteEnabled):
        (WebKit::WebPage::setSmartInsertDeleteEnabled):
        Add getter and setter.

        * WebProcess/WebPage/WebPage.messages.in:
        Add SetSmartInsertDeleteEnabled message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 5 Jan 2011 21:06:55 +0000 (21:06 +0000)]
2011-01-05  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Implement repeating CSS3 gradients
        https://bugs.webkit.org/show_bug.cgi?id=51843

        Add support for repeating gradients, via the new gradient functions
        -webkit-repeating-linear-gradient and -webkit-repeating-radial-gradient.

        Tests: fast/gradients/css3-repeating-linear-gradients.html
               fast/gradients/css3-repeating-radial-gradients.html

        * css/CSSGradientValue.h:
        (WebCore::CSSGradientValue::isRepeating): Accessor for whethe the gradient repeats.
        (WebCore::CSSGradientValue::CSSGradientValue): Pass CSSGradientRepeat in.
        (WebCore::CSSLinearGradientValue::create): Pass CSSGradientRepeat.
        (WebCore::CSSLinearGradientValue::CSSLinearGradientValue): Ditto
        (WebCore::CSSRadialGradientValue::create): Ditto.
        (WebCore::CSSRadialGradientValue::CSSRadialGradientValue): Ditto.

        * css/CSSGradientValue.cpp:
        (WebCore::CSSGradientValue::addStops): Pass maxLengthForRepeat, which
        is used for repeating radial gradients. Add code to repeat the stops,
        adding stops before the start, and after the end until the 0-N range is
        covered, where N is large enough to ensure the box is covered. Fix an issue
        with repeating gradients where if both stops were < 0, it would fail to clamp
        them to 0.

        (WebCore::CSSLinearGradientValue::cssText): Output strings for repeating gradients.
        (WebCore::CSSLinearGradientValue::createGradient): maxExtent for linear gradients is 1,
        because they are guaranteed to fill the box already.
        (WebCore::CSSRadialGradientValue::cssText): Output strings for repeating gradients.
        (WebCore::CSSRadialGradientValue::createGradient): Compute the distance to the furthest
        corner in order to inform addStops() how much additional extent is required.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseDeprecatedGradient): Old gradients never repeat.
        (WebCore::CSSParser::parseLinearGradient): Pass down CSSGradientRepeat.
        (WebCore::CSSParser::parseRadialGradient): Ditto.
        (WebCore::CSSParser::isGeneratedImageValue): Add repeating gradient functions.
        (WebCore::CSSParser::parseGeneratedImage): Ditto.
        * css/CSSParser.h: Pass CSSGradientRepeat to gradient functions.
        * platform/graphics/cg/GradientCG.cpp: Remove unused #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 5 Jan 2011 20:50:07 +0000 (20:50 +0000)]
2011-01-05  Stephen White  <senorblanco@chromium.org>

        Unreviewed; test expectations fix.

        * platform/chromium/test_expectations.txt:
        Add a few failing tests to chromium's test expectations file.
        * platform/chromium-gpu/test_expectations.txt:
        Mark the shadow-offset tests as crashing on win debug (GPU).  Remove
        a duplicate MAC expectation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 5 Jan 2011 20:33:48 +0000 (20:33 +0000)]
2011-01-05  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Ariya Hidayat.

        ContextShadow::blurLayerImage() not endian-safe
        https://bugs.webkit.org/show_bug.cgi?id=51822

        Correct the channel map in ContextShadow to reflect the different
        ordering of pixels on processors with different endianness.

        No new tests. This is covered by the existing shadow tests. It was
        not discovered, because all of the bots using ContextShadow are
        little-endian.

        * platform/graphics/ContextShadow.cpp:
        (WebCore::ContextShadow::blurLayerImage): Initialize the channel mapping
        based on machine endianness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Windows build.
andersca@apple.com [Wed, 5 Jan 2011 20:26:50 +0000 (20:26 +0000)]
Fix Windows build.

* WebProcess/WebPage/WebPage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 5 Jan 2011 20:19:04 +0000 (20:19 +0000)]
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adele Peterson.

        Implement word transformation
        https://bugs.webkit.org/show_bug.cgi?id=51943

        Export Editor functions needed by WebKit2.

        * WebCore.exp.in:
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adele Peterson.

        Implement word transformation
        https://bugs.webkit.org/show_bug.cgi?id=51943

        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]):
        Handle the word transformation selectors.

        (-[WKView uppercaseWord:]):
        (-[WKView lowercaseWord:]):
        (-[WKView capitalizeWord:]):
        Call down to the WebPageProxy.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::uppercaseWord):
        (WebKit::WebPageProxy::lowercaseWord):
        (WebKit::WebPageProxy::capitalizeWord):
        Send messages to the WebPage.

        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
        (WebKit::changeWordCase):
        Add helper function.

        (WebKit::WebEditorClient::uppercaseWord):
        (WebKit::WebEditorClient::lowercaseWord):
        (WebKit::WebEditorClient::capitalizeWord):
        Call helper function.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::changeSpellingToWord):
        Call replaceSelectionWithText.

        (WebKit::WebPage::uppercaseWord):
        (WebKit::WebPage::lowercaseWord):
        (WebKit::WebPage::capitalizeWord):
        Call the editor functions.

        (WebKit::WebPage::replaceSelectionWithText):
        New helper function that replaces the selected string with another string.

        * WebProcess/WebPage/WebPage.messages.in:
        Add new messages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 5 Jan 2011 20:03:01 +0000 (20:03 +0000)]
2011-01-05  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Nate Chapin.

        [Chromium] Crash when drawing PDF plug-in scrollbars
        https://bugs.webkit.org/show_bug.cgi?id=51942

        Pepper plug-in scrollbars don't have a parent, guard against that before
        seeing if the parent is a FrameView.

        Not testable via layout tests, verified fix by hand.

        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::ScrollbarThemeChromiumMac::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Anders Carlsson.
ap@apple.com [Wed, 5 Jan 2011 19:48:43 +0000 (19:48 +0000)]
    Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=51935
        Add WebKit2 API for largest frame

        * UIProcess/API/C/WKPage.cpp:
        (WKPageGetFrameSetLargestFrame):
        * UIProcess/API/C/WKPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 5 Jan 2011 19:45:46 +0000 (19:45 +0000)]
2011-01-05  Stephen White  <senorblanco@chromium.org>

        Unreviewed; test expectations fix.

        Update chromium GPU test_expectations.txt file to match the
        layout of the CPU results more closely.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 5 Jan 2011 19:44:22 +0000 (19:44 +0000)]
2011-01-05  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders Carlsson.

        Remove entries from WebKit2 skipped list that no longer exist
        https://bugs.webkit.org/show_bug.cgi?id=51936

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 5 Jan 2011 19:41:03 +0000 (19:41 +0000)]
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        More work on spelling
        https://bugs.webkit.org/show_bug.cgi?id=51939

        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]):
        Handle changeSpelling: as well.

        (-[WKView showGuessPanel:]):
        Show or hide the guess panel.

        (-[WKView checkSpelling:]):
        Pass false to advanceToNextMisspelling.

        (-[WKView changeSpelling:]):
        Call changeSpellingToWord.

        * UIProcess/TextChecker.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::WebPageProxy):
        Initialize m_pendingLearnOrIgnoreWordMessageCount.

        (WebKit::WebPageProxy::contextMenuItemSelected):
        Handle smart toggles directly in the UI process, keep track of whether
        we're asked to learn or ignore a word.

        (WebKit::WebPageProxy::advanceToNextMisspelling):
        Pass the boolean through.

        (WebKit::WebPageProxy::changeSpellingToWord):
        Send a ChangeSpellingToWord message.

        (WebKit::WebPageProxy::learnWord):
        (WebKit::WebPageProxy::ignoreWord):
        Check that we do have a pending learn or ignore word message. Call through to
        the text checker.

        (WebKit::WebPageProxy::processDidCrash):
        Reset the m_pendingLearnOrIgnoreWordMessageCount variable.

        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        Add new messages.

        * UIProcess/mac/TextCheckerMac.mm:
        (WebKit::TextChecker::learnWord):
        (WebKit::TextChecker::ignoreWord):
        Implement in terms of NSSpellChecker.

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::ignoreWordInSpellDocument):
        (WebKit::WebEditorClient::learnWord):
        Send IgnoreWord and LearnWord messages.

        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
        (WebKit::WebEditorClient::toggleAutomaticQuoteSubstitution):
        (WebKit::WebEditorClient::toggleAutomaticLinkDetection):
        (WebKit::WebEditorClient::toggleAutomaticDashSubstitution):
        (WebKit::WebEditorClient::toggleAutomaticTextReplacement):
        Add assertions.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::advanceToNextMisspelling):
        Pass the bool along to the Editor.

        (WebKit::WebPage::changeSpellingToWord):
        Replace the selected text.

        * WebProcess/WebPage/WebPage.messages.in:
        Add new ChangeSpellingToWord message and add a boolean to AdvanceToNextMisspelling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix.
bfulgham@webkit.org [Wed, 5 Jan 2011 19:23:24 +0000 (19:23 +0000)]
Unreviewed build fix.

* wtf/Encoder.h: Add <stdint.h> include for systems that
do not natively know about uint8_t, etc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 5 Jan 2011 19:09:53 +0000 (19:09 +0000)]
2011-01-05  Abhishek Arya  <inferno@chromium.org>

        Unreviewed.

        Update FIXME comment to sound better. Also initialize the block to fix compile.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLand failing Windows results after r75031. Fixing the tests is being tracked by
bweinstein@apple.com [Wed, 5 Jan 2011 19:03:04 +0000 (19:03 +0000)]
Land failing Windows results after r75031. Fixing the tests is being tracked by
https://bugs.webkit.org/show_bug.cgi?id=51912.

* platform/win/accessibility/document-role-expected.txt:
* platform/win/accessibility/selection-and-focus-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 5 Jan 2011 18:58:06 +0000 (18:58 +0000)]
2011-01-05  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Do not merge anonymous blocks when one of them is the one getting removed.
        https://bugs.webkit.org/show_bug.cgi?id=51919

        Test: fast/block/merge-anonymous-block-remove-child-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):
2011-01-05  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we do not crash when trying to merge two anonymous blocks,
        one of which is getting removed.
        https://bugs.webkit.org/show_bug.cgi?id=51919

        * fast/block/merge-anonymous-block-remove-child-crash-expected.txt: Added.
        * fast/block/merge-anonymous-block-remove-child-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 5 Jan 2011 18:48:57 +0000 (18:48 +0000)]
2011-01-05  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha.

        Build fix for GTK+ 3.x. Remove the call to gtk_range_set_update_policy.
        GTK+ 3.x has removed this method and the default in GTK+ 2.x is continuous,
        so this call is unnecessary.

        * WebCoreSupport/FullscreenVideoController.cpp:
        (FullscreenVideoController::createHud): Remove call to gtk_range_set_update_policy().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 5 Jan 2011 18:32:50 +0000 (18:32 +0000)]
2011-01-05  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        ApplyStyleCommand::applyRelativeFontStyleChange should take EditingStyle*
        https://bugs.webkit.org/show_bug.cgi?id=50641

        Modified applyRelativeFontStyleChange to take EditingStyle instead of CSSMutableStyleDeclaration.
        Also extracted the logic to obtain the font size delta from ApplyStyleCommand to EditingStyle.
        The font size delta is now stored as a member variable of EditingStyle as supposed to a property
        in CSSMutableStyleDeclration as soon as EditingStyle is instantiated.

        No new tests are added since this is a refactoring.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::doApply): Calls applyRelativeFontStyleChange.
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Takes EditingStyle.
        * editing/ApplyStyleCommand.h:
        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::EditingStyle): Initializes m_fontSizeDelta.
        (WebCore::EditingStyle::init): Ditto.
        (WebCore::EditingStyle::extractFontSizeDelta): Extracted from applyRelativeFontStyleChange.
        (WebCore::EditingStyle::isEmpty): Takes care of m_fontSizeDelta.
        (WebCore::EditingStyle::setStyle): Calls extractFontSizeDelta.
        (WebCore::EditingStyle::overrideWithStyle): Ditto.
        (WebCore::EditingStyle::clear): Initializes m_fontSizeDelta.
        (WebCore::EditingStyle::copy): Calls extractFontSizeDelta.
        * editing/EditingStyle.h:
        (WebCore::EditingStyle::fontSizeDelta): Added.
        (WebCore::EditingStyle::hasFontSizeDelta): Added.
        * editing/Editor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 5 Jan 2011 18:28:29 +0000 (18:28 +0000)]
2011-01-05  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Keep track of active text substitution preferences
        https://bugs.webkit.org/show_bug.cgi?id=51931

        * Shared/TextCheckerState.h:
        * UIProcess/API/mac/WKView.mm:
        (-[WKView validateUserInterfaceItem:]):
        Handle new selectors, mostly copied from WebKit1 code.

        (-[WKView orderFrontSubstitutionsPanel:]):
        Open the substitution panel.

        (-[WKView isAutomaticQuoteSubstitutionEnabled]):
        (-[WKView setAutomaticQuoteSubstitutionEnabled:]):
        (-[WKView toggleAutomaticQuoteSubstitution:]):
        (-[WKView isAutomaticDashSubstitutionEnabled]):
        (-[WKView setAutomaticDashSubstitutionEnabled:]):
        (-[WKView toggleAutomaticDashSubstitution:]):
        (-[WKView isAutomaticLinkDetectionEnabled]):
        (-[WKView setAutomaticLinkDetectionEnabled:]):
        (-[WKView toggleAutomaticLinkDetection:]):
        (-[WKView isAutomaticTextReplacementEnabled]):
        (-[WKView setAutomaticTextReplacementEnabled:]):
        (-[WKView toggleAutomaticTextReplacement:]):
        Call the text checker, and update the state in the web process if needed.

        * UIProcess/TextChecker.h:
        Add new flags.

        * UIProcess/mac/TextCheckerMac.mm:
        (WebKit::initializeState):
        Initialize flags from user defaults.

        (WebKit::TextChecker::setAutomaticQuoteSubstitutionEnabled):
        (WebKit::TextChecker::setAutomaticDashSubstitutionEnabled):
        (WebKit::TextChecker::setAutomaticLinkDetectionEnabled):
        (WebKit::TextChecker::setAutomaticTextReplacementEnabled):
        Update and save the flags.

        * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
        (WebKit::WebEditorClient::isAutomaticQuoteSubstitutionEnabled):
        (WebKit::WebEditorClient::isAutomaticLinkDetectionEnabled):
        (WebKit::WebEditorClient::isAutomaticDashSubstitutionEnabled):
        (WebKit::WebEditorClient::isAutomaticTextReplacementEnabled):
        Get the text checker state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Wed, 5 Jan 2011 18:16:37 +0000 (18:16 +0000)]
2011-01-05  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Sync qwebkitplatformplugin.h in the plugin example
        https://bugs.webkit.org/show_bug.cgi?id=51882

        Make examples/platformplugin/qwebkitplatformplugin.h exactly the same
        as the one in the Api folder.

        * examples/platformplugin/qwebkitplatformplugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8799835> hyphenate-character: auto should fall back to hyphen-minus...
mitz@apple.com [Wed, 5 Jan 2011 18:03:09 +0000 (18:03 +0000)]
<rdar://problem/8799835> hyphenate-character: auto should fall back to hyphen-minus if the primary font lacks a hyphen glyph
https://bugs.webkit.org/show_bug.cgi?id=51915

Reviewed by Darin Adler.

WebCore:

This changes the results of existing tests in fast/text.

* platform/graphics/Font.h:
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::primaryFontHasGlyphForCharacter): Added.
* rendering/style/RenderStyle.cpp:
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::primaryFontHasGlyphForCharacter): Added a stub.
(WebCore::RenderStyle::hyphenString): For hyphenate-character: auto, return a
hyphen only if the primary font has a hyphen glyph, and otherwise return a
hyphen-minus.

LayoutTests:

* platform/mac/fast/text/basic/014-expected.checksum:
* platform/mac/fast/text/basic/014-expected.png:
* platform/mac/fast/text/basic/014-expected.txt:
* platform/mac/fast/text/capitalize-boundaries-expected.checksum:
* platform/mac/fast/text/capitalize-boundaries-expected.png:
* platform/mac/fast/text/capitalize-boundaries-expected.txt:
* platform/mac/fast/text/midword-break-after-breakable-char-expected.checksum:
* platform/mac/fast/text/midword-break-after-breakable-char-expected.png:
* platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Wed, 5 Jan 2011 17:55:09 +0000 (17:55 +0000)]
2011-01-05  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] [Symbian] Make CONFIG-=def_files the default configuration for trunk builds
        https://bugs.webkit.org/show_bug.cgi?id=51888

        Overrule Qt's default from qconfig.pri for non-production builds so
        that CONFIG(def_files) evaluates to false and QtWebKit trunk builds succeed.

        No new tests as there is no new functionality.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCleaned up com.apple.WebProcess.sb
mitz@apple.com [Wed, 5 Jan 2011 17:50:20 +0000 (17:50 +0000)]
Cleaned up com.apple.WebProcess.sb

Rubber-stamped by Darin Adler.

* WebProcess/com.apple.WebProcess.sb: Moved the closing parentheses of multi-line blocks to
their own lines. Changed to use WebKit-standard 4-space indentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Kundu Suchismita <suchi.kundu@nokia.com>
commit-queue@webkit.org [Wed, 5 Jan 2011 17:37:33 +0000 (17:37 +0000)]
2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>

        Reviewed by Andreas Kling.

        [Qt]Add local storage settings to QtTestBrowser command line arguments
        https://bugs.webkit.org/show_bug.cgi?id=51750

        * QtTestBrowser/main.cpp:
        (LauncherApplication::handleUserOptions):
         Local storage settings can be enable form command line arguments for
         QtTestBrowser.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 5 Jan 2011 17:33:44 +0000 (17:33 +0000)]
2011-01-05  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74778.
        http://trac.webkit.org/changeset/74778
        https://bugs.webkit.org/show_bug.cgi?id=51930

        Android and QtWebKit-V8 uses V8DOMWindowShell::setContext.
        (Requested by bbandix on #webkit).

        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::V8DOMWindowShell::setContext):
        * bindings/v8/V8DOMWindowShell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGTK: AX: DRT needs to use correct root object method.
cfleizach@apple.com [Wed, 5 Jan 2011 17:31:07 +0000 (17:31 +0000)]
GTK: AX: DRT needs to use correct root object method.
https://bugs.webkit.org/show_bug.cgi?id=51911

Reviewed by Martin Robinson.

Tools:

* DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
(AccessibilityController::rootElement):

WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getRootAccessibleElement):
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Wed, 5 Jan 2011 17:27:03 +0000 (17:27 +0000)]
2011-01-05  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Animated GIF images does not animate 10x as expected by default.
        https://bugs.webkit.org/show_bug.cgi?id=36818

        Add a test animated GIF which should be displayed 2 times and stop.

        * manual-tests/animated-gif-looping.html:
        * manual-tests/resources/animated-2x.gif: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Wed, 5 Jan 2011 17:23:39 +0000 (17:23 +0000)]
2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Fork code of ScrollbarThemeGtk that will differ for GTK+ 3
        https://bugs.webkit.org/show_bug.cgi?id=51923

        Split out pieces of ScrollbarThemeGtk into ScrollbarThemeGtk2 and
        ScrollbarThemeGtk3 that will differ between GTK+ 2 and GTK+ 3.

        No new tests. This should not change functionality.

        * GNUmakefile.am: Add ScrollbarThemeGtk2.cpp and ScrollbarThemeGtk3.cpp
        * platform/gtk/ScrollbarThemeGtk.cpp:
        (WebCore::ScrollbarThemeGtk::updateScrollbarsFrameThickness):
        * platform/gtk/ScrollbarThemeGtk.h:
        * platform/gtk/ScrollbarThemeGtk2.cpp: Added.
        (WebCore::ScrollbarThemeGtk::updateThemeProperties):
        (WebCore::ScrollbarThemeGtk::paintTrackBackground):
        (WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
        (WebCore::ScrollbarThemeGtk::paintThumb):
        (WebCore::ScrollbarThemeGtk::paintButton):
        * platform/gtk/ScrollbarThemeGtk3.cpp: Added.
        (WebCore::ScrollbarThemeGtk::updateThemeProperties):
        (WebCore::ScrollbarThemeGtk::paintTrackBackground):
        (WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
        (WebCore::ScrollbarThemeGtk::paintThumb):
        (WebCore::ScrollbarThemeGtk::paintButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 5 Jan 2011 16:55:13 +0000 (16:55 +0000)]
2011-01-05  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Fix the usage of SOURCE_GROUP
        https://bugs.webkit.org/show_bug.cgi?id=51739

        * Source/cmake/WebKitMacros.cmake:
2011-01-05  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Fix the usage of SOURCE_GROUP
        https://bugs.webkit.org/show_bug.cgi?id=51739

        * CMakeLists.txt:
2011-01-05  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [CMake] Fix the usage of SOURCE_GROUP
        https://bugs.webkit.org/show_bug.cgi?id=51739

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Wed, 5 Jan 2011 16:37:10 +0000 (16:37 +0000)]
2011-01-05  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][V8] Fix the build after recent changes.

        * pcre/pcre.pri: Correct the path after Source was introduced.
2011-01-05  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogonác.

        [Qt][V8] Fix the build after recent changes.

        No new tests needed.

        * WebCore.pro: Add missing files, and remove obsolete ones.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Wed, 5 Jan 2011 16:28:30 +0000 (16:28 +0000)]
2011-01-05  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Andreas Kling.

        [WINCE] Remove CMake warning
        https://bugs.webkit.org/show_bug.cgi?id=51921

        * Source/cmake/WebKitHelpers.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Yong Li <yoli@rim.com>
commit-queue@webkit.org [Wed, 5 Jan 2011 15:51:37 +0000 (15:51 +0000)]
2011-01-05  Yong Li  <yoli@rim.com>

        Reviewed by Adam Barth.

        Suspend HTMLParserScheduler when page load is deferred to
        avoid potential JS re-entrancy. Otherwise, when JS execution is triggered
        from an external script or by events, and is blocked by a modal dialog,
        WebKit can parse more HTML source and also start another JS execution.

        https://bugs.webkit.org/show_bug.cgi?id=48077

        Test case: WebCore/manual-tests/bugzilla-48077.html.

        * dom/DocumentParser.cpp:
        (WebCore::DocumentParser::suspendScheduledTasks):
        (WebCore::DocumentParser::resumeScheduledTasks):
        * dom/DocumentParser.h:
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::suspendScheduledTasks):
        (WebCore::HTMLDocumentParser::resumeScheduledTasks):
        * html/parser/HTMLParserScheduler.cpp:
        (WebCore::HTMLParserScheduler::HTMLParserScheduler):
        (WebCore::HTMLParserScheduler::suspend):
        (WebCore::HTMLParserScheduler::resume):
        * html/parser/HTMLParserScheduler.h:
        (WebCore::HTMLParserScheduler::isScheduledForResume):
        * page/PageGroupLoadDeferrer.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GStreamer] MediaPlayerPrivateGStreamer::totalBytes() does not work reliably
hausmann@webkit.org [Wed, 5 Jan 2011 15:48:50 +0000 (15:48 +0000)]
[GStreamer] MediaPlayerPrivateGStreamer::totalBytes() does not work reliably
https://bugs.webkit.org/show_bug.cgi?id=51926

Reviewed by Kenneth Rohde Christiansen, Gustavo Noronha Silva

Work around potential upstream bug: Querying a GstBin for the duration,
will forward the query to all sink children. Our WebKitWebSrc however
is a bin with only source children, therefore the query fails. Until
this is changed upstream, this patch works around it as follows,
based on suggestion by Philippe Normand and Sebastian Dröge:

When the initial query fails, attempt the same query on all source
pads and take the maximum length reported.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::totalBytes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-01-05 Hans Wennborg <hans@chromium.org>
hans@chromium.org [Wed, 5 Jan 2011 15:24:21 +0000 (15:24 +0000)]
2011-01-05  Hans Wennborg  <hans@chromium.org>

        Reviewed by David Levin.

        [Chromium] WebIDBKey clean-up
        https://bugs.webkit.org/show_bug.cgi?id=51925

        Remove constructors that are no longer used since the
        Chromium side has been updated.

        * public/WebIDBKey.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75064 268f45cc-cd09-0410-ab3c-d52691b4dbfc