WebKit-https.git
3 years agoUnprefix -webkit-font-feature-settings
mmaxfield@apple.com [Mon, 5 Oct 2015 17:27:16 +0000 (17:27 +0000)]
Unprefix -webkit-font-feature-settings
https://bugs.webkit.org/show_bug.cgi?id=149722

Reviewed by Sam Weinig.

Source/WebCore:

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFontFeatureSettings):
* css/CSSPropertyNames.in:
* css/CSSValueKeywords.in:
* css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyInitialFontFeatureSettings):
(WebCore::StyleBuilderCustom::applyInheritFontFeatureSettings):
(WebCore::StyleBuilderCustom::applyInitialWebkitFontFeatureSettings): Deleted.
(WebCore::StyleBuilderCustom::applyInheritWebkitFontFeatureSettings): Deleted.

Source/WebInspectorUI:

* UserInterface/Models/CSSKeywordCompletions.js:

LayoutTests:

* css3/font-feature-settings-parsing.html:
* css3/font-feature-settings-preinstalled-fonts.html:
* css3/font-feature-settings-rendering-2.html:
* css3/font-feature-settings-rendering.html:
* fast/css/inherited-properties-rare-text-expected.txt:
* fast/css/inherited-properties-rare-text.html:
* fast/text/shaping/shaping-script-order.html:
* fast/text/shaping/shaping-selection-rect.html:
* fonts/unicode-character-font-crash.html:
* scrollbars/scrollbar-scrollbarparts-repaint-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoJSC::SlotVisitor should not be a hot mess
ggaren@apple.com [Mon, 5 Oct 2015 17:22:20 +0000 (17:22 +0000)]
JSC::SlotVisitor should not be a hot mess
https://bugs.webkit.org/show_bug.cgi?id=149798

Reviewed by Andreas Kling.

I had to debug JSC::SlotVisitor the other day. It was hard to follow.
Let's make it easy to follow.

* heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::resetVisitors):
(JSC::Heap::objectCount):
(JSC::Heap::addToRememberedSet):
(JSC::Heap::collectAndSweep):
* heap/Heap.h: Deleted the string hash-consing code. It
was dead code.

Since no benchmark noticed the commit that broke this feature, perhaps
it's not worth having.

Either way, the best thing to do with dead code is to delete it.
It's still there in svn if we ever want to pick it up again.

* heap/HeapRootVisitor.h:
(JSC::HeapRootVisitor::visit):
(JSC::HeapRootVisitor::visitor): Removed the private append functions
for unsafe pointers and switched HeapRootVisitor over to the public
specially named functions for unsafe pointers.

In future, we should either remove the public specially named functions
or remove HeapRootVisitor, since they serve the same purpose. At least
for now we don't have pairs of functions on SlotVisitor that do the
exact same thing.

* heap/SlotVisitor.cpp:
(JSC::validate): Moved this static function to the top of the file.

(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset): More hash cons removal.

(JSC::SlotVisitor::append):

(JSC::SlotVisitor::setMarkedAndAppendToMarkStack):
(JSC::SlotVisitor::appendToMarkStack): Renamed these functions to
distinguish them from the up-front helper functions that just do type
conversions. These are the functions that actually do stuff.

Moved these functions out of line to make it easier to set breakpoints,
and to enable code changes for debugging, like printf and synchronous
marking, without recompiling the world.

setMarkedAndAppendToMarkStack is roughly 258 bytes long (not including
function prologue and epilogue), so inlining it was probably not a
great idea in the first place.

(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared): Removed some stack probing code.
It was also dead.

(JSC::SlotVisitor::addOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRootTriState):
(JSC::SlotVisitor::opaqueRootCount):
(JSC::SlotVisitor::mergeOpaqueRootsIfNecessary):
(JSC::SlotVisitor::mergeOpaqueRootsIfProfitable):
(JSC::SlotVisitor::donate):
(JSC::SlotVisitor::donateAndDrain):
(JSC::SlotVisitor::copyLater):
(JSC::SlotVisitor::mergeOpaqueRoots):
(JSC::SlotVisitor::harvestWeakReferences):
(JSC::SlotVisitor::finalizeUnconditionalFinalizers):
(JSC::SlotVisitor::dump): Moved more code out-of-line. These code paths
are not hot and/or not small, so we need more evidence before we inline
them. The SlotVisitor headers are included everywhere, so we should
make them include less.

Removed "internal" from all function names because it wasn't applied in
any consistent way that would mean anything.

(JSC::JSString::tryHashConsLock): Deleted.
(JSC::JSString::releaseHashConsLock): Deleted.
(JSC::JSString::shouldTryHashCons): Deleted.
(JSC::SlotVisitor::internalAppend): Deleted.
(JSC::SlotVisitor::validate): Deleted.

* heap/SlotVisitor.h:
(JSC::SlotVisitor::resetChildCount): Deleted.
(JSC::SlotVisitor::childCount): Deleted.
(JSC::SlotVisitor::incrementChildCount): Deleted. Removed this child
count thing. It was dead code.

* heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::appendUnbarrieredPointer):
(JSC::SlotVisitor::appendUnbarrieredReadOnlyPointer):
(JSC::SlotVisitor::appendUnbarrieredValue):
(JSC::SlotVisitor::appendUnbarrieredReadOnlyValue): Some renaming and un-inlining.

(JSC::SlotVisitor::appendUnbarrieredWeak): Don't null check our input.
The one true place where null checking happens is our out-of-line
code. All inline functions do only type conversions.

(JSC::SlotVisitor::append):
(JSC::SlotVisitor::appendValues):
(JSC::SlotVisitor::addWeakReferenceHarvester):
(JSC::SlotVisitor::addUnconditionalFinalizer):
(JSC::SlotVisitor::reportExtraMemoryVisited): Some renaming and un-inlining.

(JSC::SlotVisitor::internalAppend): Deleted.
(JSC::SlotVisitor::unconditionallyAppend): Deleted.
(JSC::SlotVisitor::addOpaqueRoot): Deleted.
(JSC::SlotVisitor::containsOpaqueRoot): Deleted.
(JSC::SlotVisitor::containsOpaqueRootTriState): Deleted.
(JSC::SlotVisitor::opaqueRootCount): Deleted.
(JSC::SlotVisitor::mergeOpaqueRootsIfNecessary): Deleted.
(JSC::SlotVisitor::mergeOpaqueRootsIfProfitable): Deleted.
(JSC::SlotVisitor::donate): Deleted.
(JSC::SlotVisitor::donateAndDrain): Deleted.
(JSC::SlotVisitor::copyLater): Deleted.

* runtime/JSString.h:
(JSC::JSString::finishCreation):
(JSC::JSString::setIs8Bit):
(JSC::JSString::isHashConsSingleton): Deleted.
(JSC::JSString::clearHashConsSingleton): Deleted.
(JSC::JSString::setHashConsSingleton): Deleted. More hash cons removal.

* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:
(JSC::VM::currentThreadIsHoldingAPILock):
(JSC::VM::apiLock):
(JSC::VM::haveEnoughNewStringsToHashCons): Deleted.
(JSC::VM::resetNewStringsSinceLastHashCons): Deleted. More hash cons removal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GStreamer] Replace uses of std::bind() with lambdas
zandobersek@gmail.com [Mon, 5 Oct 2015 17:18:26 +0000 (17:18 +0000)]
[GStreamer] Replace uses of std::bind() with lambdas
https://bugs.webkit.org/show_bug.cgi?id=149802

Reviewed by Carlos Garcia Campos.

Instead of std::bind(), use C++ lambdas to create std::function<>
wrappers in GStreamer-related class implementations.

Ref-counted classes are protected by capturing a RefPtr object.
GstObject-derived objects are protected by capturing a GRefPtr object.
Necessary specializations for WebKitVideoSink and WebKitWebSrc are added.

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus):
* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
(WTF::refGPtr<WebKitVideoSink>):
(WTF::derefGPtr<WebKitVideoSink>):
(WTF::refGPtr<WebKitWebSrc>):
(WTF::derefGPtr<WebKitWebSrc>):
* platform/graphics/gstreamer/GRefPtrGStreamer.h:
* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::streamChanged):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::activeChanged):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRender):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcChangeState):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoInline cache repatching should be throttled if it happens a lot
fpizlo@apple.com [Mon, 5 Oct 2015 17:05:24 +0000 (17:05 +0000)]
Inline cache repatching should be throttled if it happens a lot
https://bugs.webkit.org/show_bug.cgi?id=149796
rdar://problem/22674436

Reviewed by Saam Barati.

Source/JavaScriptCore:

We noticed a slight PLT regression from http://trac.webkit.org/changeset/189586. It's because
some pages do things that our inline caches mishandle, in the sense that some ICs end up
repatching themselves very frequently. The cost of repatching outweighs the speed-up on those
pages. There are probably super smart things we could do to tune the IC heuristics to make the
ICs do the right thing on those pages. But more fundamentally, we should ensure that our ICs
back off from continuous repatching if they repatch a lot. That's what this change does.

With this change, StructureStubInfo counts the number of repatchings. If that exceeds a
threshold, we put the IC into a cool-down mode, where some number of future repatch events do
nothing but decrement the cool-down counter. The duration of cool-down increases exponentially
every time we have to do it.

This change also outlines a lot of code. The fact that StructureStubInfo had a lot of inline
methods was starting to get on my nerves. Now it only has inline methods for things that need
to be inlined. Also, I changed StructureStubInfo to be a class rather than a struct. Maybe
with enough such incremental changes, eventually StructureStubInfo will actually behave like a
proper class.

This has no effect on JSC benchmarks. It progresses one of the pages that was hit by the
regression by 15%. It's hard to see if this totally fixes the entire PLT regression since the
geomean regression was very close to noise.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printPutByIdCacheStatus):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::checkIfOptimizationThresholdReached):
* bytecode/CodeBlock.h:
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback):
(JSC::GetByIdStatus::computeFor):
* bytecode/PolymorphicAccess.cpp:
(JSC::PolymorphicAccess::regenerate):
* bytecode/PolymorphicAccess.h:
* bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeForStubInfo):
* bytecode/StructureStubClearingWatchpoint.h:
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::StructureStubInfo):
(JSC::StructureStubInfo::~StructureStubInfo):
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::initStub):
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::addAccessCase):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::considerCaching):
(JSC::StructureStubInfo::willRepatch):
(JSC::StructureStubInfo::willCoolDown):
(JSC::getStructureStubInfoCodeOrigin):
(JSC::StructureStubInfo::StructureStubInfo): Deleted.
(JSC::StructureStubInfo::initGetByIdSelf): Deleted.
(JSC::StructureStubInfo::initPutByIdReplace): Deleted.
(JSC::StructureStubInfo::initStub): Deleted.
(JSC::StructureStubInfo::seenOnce): Deleted.
(JSC::StructureStubInfo::setSeen): Deleted.
* jit/JIT.h:
* jit/JITOperations.cpp:
* jit/Repatch.cpp:
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryRepatchIn):
* runtime/Options.h:

Source/WTF:

Add some helpers for saturated math.

* wtf/MathExtras.h:
(WTF::incrementWithSaturation):
(WTF::leftShiftWithSaturation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove CancelResourceLoader message
antti@apple.com [Mon, 5 Oct 2015 15:12:27 +0000 (15:12 +0000)]
Remove CancelResourceLoader message
https://bugs.webkit.org/show_bug.cgi?id=149801

Reviewed by Andreas Kling.

It has no clients.

* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::messageSenderDestinationID):
(WebKit::WebResourceLoader::detachFromCoreLoader):
(WebKit::WebResourceLoader::cancelResourceLoader): Deleted.
* WebProcess/Network/WebResourceLoader.h:
* WebProcess/Network/WebResourceLoader.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove unused HistoryItem::parent
akling@apple.com [Mon, 5 Oct 2015 14:38:50 +0000 (14:38 +0000)]
Remove unused HistoryItem::parent
<https://webkit.org/b/149803>

Reviewed by Anders Carlsson.

Source/WebCore:

Remove the effectively-unused "parent" field from HistoryItem.
This also allows us to get rid of a HistoryItem constructor.

* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem): Deleted.
(WebCore::HistoryItem::reset): Deleted.
(WebCore::HistoryItem::parent): Deleted.
(WebCore::HistoryItem::setParent): Deleted.
* history/HistoryItem.h:
(WebCore::HistoryItem::create): Deleted.
* loader/HistoryController.cpp:
(WebCore::HistoryController::initializeItem): Deleted.

Source/WebKit/mac:

Remove the only (unused) client of HistoryItem's with-parent constructor.

* History/WebHistoryItem.mm:
(-[WebHistoryItem initWithURL:target:parent:title:]): Deleted.
* History/WebHistoryItemInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoGLContext should control ownership of context-related objects
zandobersek@gmail.com [Mon, 5 Oct 2015 07:13:50 +0000 (07:13 +0000)]
GLContext should control ownership of context-related objects
https://bugs.webkit.org/show_bug.cgi?id=149794

Reviewed by Martin Robinson.

Creation of GLContext objects can depend on various platform-specific
objects like native window representations. Since these objects are
used solely for the GLContext purposes, it would make sense to allow
GLContext to provide an extensible way to impose ownership on these
objects and control their lifetime.

GLContext::Data is declared with a defaulted virtual destructor.
Users of these implementations can declare classes that derive from
GLContext::Data and store context-related objects in instances of the
derived class, and ensure that these objects are properly cleaned up
when GLContext destroys the Data object.

The GLContext::Data object is managed through a protected
std::unique_ptr<> member in the GLContext class. For now the member
is only set in GLContextEGL::createWindowContext() and is destroyed
during the GLContext destruction.

The local OffscreenContextData class in
PlatformDisplayWayland::createSharingGLContext() derives from
GLContext::Data and is used to store the wl_surface and
EGLNativeWindowType (aka wl_egl_window) objects for offscreen
GLContexts under the Wayland platform that are used for the sharing
context and WebGL, effectively avoiding the leak that would further
propagate problems into the compositor and the graphics library.
(Such offscreen contexts are actually mimicked via a 1x1px
wl_egl_window object that acts as a dummy base for the related
wl_surface object).

* platform/graphics/GLContext.h:
* platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::createWindowContext):
* platform/graphics/egl/GLContextEGL.h:
* platform/graphics/wayland/PlatformDisplayWayland.cpp:
(WebCore::PlatformDisplayWayland::createSharingGLContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMake gdk.h inclusion in FontPlatformDataFreeType.cpp properly GTK-specific
zandobersek@gmail.com [Mon, 5 Oct 2015 07:04:44 +0000 (07:04 +0000)]
Make gdk.h inclusion in FontPlatformDataFreeType.cpp properly GTK-specific
https://bugs.webkit.org/show_bug.cgi?id=149793

Reviewed by Carlos Garcia Campos.

* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
Instead of including <gdk/gdk.h> header for all platforms but EFL, only
include it for the GTK platform, since no other platform depends on the
GDK library.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
zandobersek@gmail.com [Mon, 5 Oct 2015 05:55:37 +0000 (05:55 +0000)]
[GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
https://bugs.webkit.org/show_bug.cgi?id=149792

Reviewed by Martin Robinson.

* WebKitTestRunner/PlatformGTK.cmake: Don't list build targets
for WebKitTestRunner multiple times.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoCodeBlock.h shouldn't be included from everywhere
fpizlo@apple.com [Sun, 4 Oct 2015 23:25:44 +0000 (23:25 +0000)]
CodeBlock.h shouldn't be included from everywhere
https://bugs.webkit.org/show_bug.cgi?id=149785

Reviewed by Andreas Kling.

* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp:
* dfg/DFGAdaptiveStructureWatchpoint.cpp:
* interpreter/CallFrame.cpp:
(JSC::CallFrame::callSiteBitsAreBytecodeOffset):
(JSC::CallFrame::callSiteBitsAreCodeOriginIndex):
(JSC::CallFrame::callSiteAsRawBits):
(JSC::CallFrame::callSiteIndex):
(JSC::CallFrame::hasActivation):
(JSC::CallFrame::uncheckedActivation):
(JSC::CallFrame::stack):
* interpreter/CallFrameInlines.h: Removed.
* interpreter/Interpreter.cpp:
* interpreter/StackVisitor.cpp:
* runtime/DirectArguments.cpp:
* runtime/ErrorInstance.cpp:
* runtime/JSArray.cpp:
* runtime/JSCInlines.h:
* runtime/LiteralParser.cpp:
* runtime/NullSetterFunction.cpp:
* tools/JSDollarVMPrototype.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
dbates@webkit.org [Sun, 4 Oct 2015 22:30:17 +0000 (22:30 +0000)]
Fix the Apple Internal iOS build after <trac.webkit.org/changeset/190515>
(https://bugs.webkit.org/show_bug.cgi?id=149753)

For now, support calling build-layouttestrelay without --ios-simulator so long
as we are building on a Mac.

* Scripts/build-layouttestrelay:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix a typo in ChangeLog.
ap@apple.com [Sun, 4 Oct 2015 20:49:17 +0000 (20:49 +0000)]
Fix a typo in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMark tests as flay for
ap@apple.com [Sun, 4 Oct 2015 20:47:01 +0000 (20:47 +0000)]
Mark tests as flay for
https://bugs.webkit.org/show_bug.cgi?id=148890

http/tests/contentfiltering/load-substitute-data-from-appcache.html and
http/tests/appcache/decide-navigation-policy-after-delay.html crash
in DocumentLoader::dataReceived sometimes

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Wrong column numbers in error object views
nvasilyev@apple.com [Sun, 4 Oct 2015 18:33:21 +0000 (18:33 +0000)]
Web Inspector: Wrong column numbers in error object views
https://bugs.webkit.org/show_bug.cgi?id=149795

Source/WebInspectorUI:

Convert columnNumber and lineNumber properties from strings to numbers
to prevent accidental string concatenations.

Reviewed by Timothy Hatcher.

* UserInterface/Models/StackTrace.js:
(WebInspector.StackTrace._parseStackTrace):

LayoutTests:

Reviewed by Timothy Hatcher.

* inspector/debugger/js-stacktrace-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSupport Trac 1.0.x XML timeline link format
ap@apple.com [Sun, 4 Oct 2015 17:49:08 +0000 (17:49 +0000)]
Support Trac 1.0.x XML timeline link format
https://bugs.webkit.org/show_bug.cgi?id=149786

Reviewed by Lucas Forschler.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._convertCommitInfoElementToObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix some errors on bot watcher's dashboard
ap@apple.com [Sun, 4 Oct 2015 17:01:01 +0000 (17:01 +0000)]
Fix some errors on bot watcher's dashboard
https://bugs.webkit.org/show_bug.cgi?id=149789

Reviewed by Lucas Forschler.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
tests step, in which case layoutTestResults.tooManyFailures would raise an exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoBot watcher's dashboard builders should turn yellow when svn fails
ap@apple.com [Sun, 4 Oct 2015 16:57:08 +0000 (16:57 +0000)]
Bot watcher's dashboard builders should turn yellow when svn fails
https://bugs.webkit.org/show_bug.cgi?id=149791

Reviewed by Lucas Forschler.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
(BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
(BuildbotBuilderQueueView.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago"Plug-in is blocked" message doesn't draw correctly
commit-queue@webkit.org [Sun, 4 Oct 2015 02:38:19 +0000 (02:38 +0000)]
"Plug-in is blocked" message doesn't draw correctly
https://bugs.webkit.org/show_bug.cgi?id=149741
<rdar://problem/22920949>

Patch by Conrad Shultz and Ricky Mondello.

Patch by Ricky Mondello <rmondello@apple.com> on 2015-10-03
Reviewed by Anders Carlsson.

Source/WebCore:

No new tests are added.

Add PluginData API to check whether a MIME type is supported, regardless of plug-in visibility.

* plugins/PluginData.cpp:
(WebCore::PluginData::getWebVisibleMimesAndPluginIndices): Adopt getMimesAndPluginIndiciesForPlugins.
(WebCore::PluginData::getMimesAndPluginIndices): Added.
(WebCore::PluginData::getMimesAndPluginIndiciesForPlugins): Essentially factored out of
    getWebVisibleMimesAndPluginIndices.
(WebCore::PluginData::supportsMimeType): Added. Somewhat similar to preexisting supportsWebVisibleMimeType.
* plugins/PluginData.h: Declare supportsMimeType.

Source/WebKit2:

If a WebKit client sets plug-in X to not be visible to the web, that doesn't mean we shouldn't consult
that plug-in when determining what kind of object type an object is. Properly classifying a non-web-visible
Netscape plug-in as such allows its bounds to properly measured, allowing it to be drawn properly.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType): Use PluginData's supportsMimeType, rather than its
    supportsWebVisibleMimeType, when determining the ObjectContentType for a MIME type on a url.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling out r190522.
commit-queue@webkit.org [Sun, 4 Oct 2015 01:45:21 +0000 (01:45 +0000)]
Unreviewed, rolling out r190522.
https://bugs.webkit.org/show_bug.cgi?id=149787

Caused a lot of leaks (Requested by ap on #webkit).

Reverted changeset:

"Unreviewed, rolling back in r190450"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190522

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agofast/events/overflow-scroll-fake-mouse-move.html is flaky
ap@apple.com [Sun, 4 Oct 2015 00:43:03 +0000 (00:43 +0000)]
fast/events/overflow-scroll-fake-mouse-move.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=138697

Reviewed by Brent Fulgham.

* fast/events/overflow-scroll-fake-mouse-move.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMake the test added in r190530 not time out on the ports that don't enable shadow...
rniwa@webkit.org [Sat, 3 Oct 2015 10:13:40 +0000 (10:13 +0000)]
Make the test added in r190530 not time out on the ports that don't enable shadow DOM.

Call waitUntilDone after calling attachShadow so that an exception thrown by calling attachShadow
will prevent waitUntilDone from getting called on those ports.

* fast/shadow-dom/insert-child-to-assigned-node.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
dbates@webkit.org [Sat, 3 Oct 2015 05:04:48 +0000 (05:04 +0000)]
Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
https://bugs.webkit.org/show_bug.cgi?id=149769

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.ios-simulator-9 img.logo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Add breakpoint option to ignore n times before stopping
mattbaker@apple.com [Sat, 3 Oct 2015 03:18:19 +0000 (03:18 +0000)]
Web Inspector: Add breakpoint option to ignore n times before stopping
https://bugs.webkit.org/show_bug.cgi?id=147664

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

* debugger/Breakpoint.h:
(JSC::Breakpoint::Breakpoint):
Added ignoreCount and hitCount fields. Cleaned up initializers.

* debugger/Debugger.cpp:
(JSC::Debugger::hasBreakpoint):
If a breakpoint matches the current text position, increment breakpoint hit count and
compare with ignore count before testing the breakpoint condition.

* inspector/ScriptBreakpoint.h:
(Inspector::ScriptBreakpoint::ScriptBreakpoint):
Added ignoreCount field. Cleaned up initializers.

* inspector/ScriptDebugServer.cpp:
(Inspector::ScriptDebugServer::setBreakpoint):
Added ignoreCount field.

* inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::buildObjectForBreakpointCookie):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::didParseSource):
Plumbing for ignoreCount property.

* inspector/protocol/Debugger.json:
Added optional ignoreCount property to BreakpointOptions object.

Source/WebInspectorUI:

* Localizations/en.lproj/localizedStrings.js:
New strings for breakpoint popover labels.

* UserInterface/Controllers/BreakpointPopoverController.js:
(WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
Add ignoreCount UI to popover, if backend support exists. UI based on same
feature in Xcode's breakpoint editing dialog.
(WebInspector.BreakpointPopoverController.prototype._popoverIgnoreInputChanged):
User input sanity checks on numeric input.

* UserInterface/Controllers/DebuggerManager.js:
Listen for changes to breakpoint ignoreCount property.

* UserInterface/Models/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.get ignoreCount):
(WebInspector.Breakpoint.prototype.set ignoreCount):
New property for ignoreCount.
(WebInspector.Breakpoint.prototype.get options):
Added ignoreCount to options object.
(WebInspector.Breakpoint.prototype.get info):
Added ignoreCount to info object.

* UserInterface/Views/BreakpointPopoverController.css:
(#edit-breakpoint-popover-ignore):
New styles for breakpoint popover.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd shared code for a new a graphics benchmark
commit-queue@webkit.org [Sat, 3 Oct 2015 03:10:13 +0000 (03:10 +0000)]
Add shared code for a new a graphics benchmark
https://bugs.webkit.org/show_bug.cgi?id=149691

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-02
Reviewed by Ryosuke Niwa.

This set of classes will be shared and used by the tests and the runner
of a new graphics benchmark.

* Animometer/resources: Added.
* Animometer/resources/algorithm.js: Added.
(Array.prototype.swap): Swaps two elements in an array.
(Heap): Binary Min/Max Heap object
(Heap.prototype._parentIndex): Given the child node index, it returns the parent index.
(Heap.prototype._leftIndex): Given the parent node index, it returns the left node index.
(Heap.prototype._rightIndex): Given the parent node index, it returns the right node index.
(Heap.prototype._childIndex): Given the parent node index, it returns the child index that may violate the heap property.
(Heap.prototype.init): Initializes the heap state.
(Heap.prototype.top): Returns the value stored at the top of the heap.
(Heap.prototype.push): Pushes a new node at the top of the heap.
(Heap.prototype.pop): Extracts the top node of the heap.
(Heap.prototype._bubble): Fixes the heap property by moving upward.
(Heap.prototype._sink): Fixes the heap property by moving downward.
(Heap.prototype.str): Prints the nodes of the heap to a string.
(Heap.prototype.values): Returns the last "size" heap elements values.

(Algorithm.createMinHeap): Creates a size-bounded min-heap object.
(Algorithm.createMaxHeap): Creates a size-bounded max-heap object.

* Animometer/resources/extensions.js: Added.
(Point): Point object but can be used as size also.
(Point.pointOnCircle): Given, the radius of the circle and the angle of the point, it returns a point object.
(Point.pointOnEllipse): Given, the radiuses of the ellipse and the angle of the point, it returns a point object.
(Point.prototype.get width): Should be called when the point is used as size.
(Point.prototype.get height): Should be called when the point is used as size.
(Point.prototype.get center): Should be called when the point is used as size.
(Point.prototype.add): Returns a new point = this + other.
(Point.prototype.subtract): Returns a new point = this - other.
(Point.prototype.multiply): Returns a new point = this * other.
(Point.prototype.move): Moves the point in a given direction, velocity, time period.

(Insets): Represents borders of a container.
(Insets.prototype.get width): Returns left + right.
(Insets.prototype.get height): Returns top + bottom.

(SimplePromise):
(SimplePromise.prototype.then):
(SimplePromise.prototype.resolve):
Moved from Animometer/runner/resources/benchmark-runner.js since tests also need it.

(Options): Benchmark running options as they are set by the user.

(ProgressBar): Manages a progress bar element. The progress bar is divided into equal length ranges.
(ProgressBar.prototype._progressToPercent): Converts the progress into a percentage.
(ProgressBar.prototype.incRange): Moves to the next range (a range is the running time of a single test).
(ProgressBar.prototype.setPos): Draws the current progress in the current range.

(RecordTable): Shows the results of running a benchmark in a tabular form.
(RecordTable.prototype.clear): Clears the results table.
(RecordTable.prototype._showTitles): Shows the header titles and appends the sub-titles to a queue.
(RecordTable.prototype._showHeader): Shows the table header titles.
(RecordTable.prototype._showEmpty): Shows an empty table cell.
(RecordTable.prototype._showValue): Shows a number value in the results table.
(RecordTable.prototype._showSamples): Shows a button for the sampled data graph.
(RecordTable.prototype._showTest): Shows the results of a single test.
(RecordTable.prototype._showSuite): Shows the results of a single suite.
(RecordTable.prototype.showRecord): Shows a single iteration for a single test.
(RecordTable.prototype.showIterations): Shows the results of all the suites of the iterations.

* Animometer/resources/sampler.js: Added.
(Statistics.sampleMean): Returns the sample mean.
(Statistics.unbiasedSampleStandardDeviation): Returns the unbiased sample variance (i.e. with Bessel's correction)
(Statistics.geometricMean): Returns the geometric mean.

(Experiment): Represents a sampling experiment.
(Experiment.prototype._init): Called when the object is created and when startSampling() is called.
(Experiment.prototype.startSampling): Called after warmup period. Restarts collecting sampled data points.
(Experiment.prototype.sample): Add a new data point.
(Experiment.prototype.mean): Returns the sample mean for the current sampled data points.
(Experiment.prototype.standardDeviation): Returns the sample standard deviation for the current sampled data points.
(Experiment.prototype.percentage): Returns the percentage of the standard deviation divided to the mean.
(Experiment.prototype.confidenceIntervalDelta): Calculates the confidence delta for the current sampled data given a confidence level.
(Experiment.prototype.concern): Returns the average of the worst given percentage from the sampled data.
(Experiment.prototype.score): Returns a score for the sampled data. It is the geometric mean of sampleMean and concern.

(Sampler): Represents a compound experiment. It manages sampling multiple data points at the same time offset.
(Sampler.prototype.startSampling): Called after warming up period. Restarts collecting sampled data points.
(Sampler.prototype.sample): Add a new data vector at a given time offset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Cleanup DebuggerManager, reduce `delete` and use Maps instead of objects
mattbaker@apple.com [Sat, 3 Oct 2015 02:28:22 +0000 (02:28 +0000)]
Web Inspector: Cleanup DebuggerManager, reduce `delete` and use Maps instead of objects
https://bugs.webkit.org/show_bug.cgi?id=149760

Reviewed by Joseph Pecoraro.

Replaced objects used as hashmaps with Map.

* UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.breakpointsForSourceCode):
(WebInspector.DebuggerManager.prototype.breakpointForIdentifier):
(WebInspector.DebuggerManager.prototype.scriptForIdentifier):
(WebInspector.DebuggerManager.prototype.scriptsForURL):
(WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):
(WebInspector.DebuggerManager.prototype.removeBreakpoint):
(WebInspector.DebuggerManager.prototype.breakpointResolved):
(WebInspector.DebuggerManager.prototype.reset):
(WebInspector.DebuggerManager.prototype.scriptDidParse):
(WebInspector.DebuggerManager.prototype._sourceCodeLocationFromPayload):
(WebInspector.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerManager.prototype._setBreakpoint):
(WebInspector.DebuggerManager.prototype._removeBreakpoint.didRemoveBreakpoint):
(WebInspector.DebuggerManager.prototype._removeBreakpoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoREGRESSION(r190370): Speedometer spits out an extra console message
rniwa@webkit.org [Sat, 3 Oct 2015 00:50:37 +0000 (00:50 +0000)]
REGRESSION(r190370): Speedometer spits out an extra console message
https://bugs.webkit.org/show_bug.cgi?id=149720

Unreviewed. Temporarily ignore the console error message.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest._filter_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoNew baselines for some compositing tests.
simon.fraser@apple.com [Sat, 3 Oct 2015 00:37:49 +0000 (00:37 +0000)]
New baselines for some compositing tests.

* platform/ios-simulator/compositing/layer-creation/overlap-animation-clipping-expected.txt: Added.
* platform/ios-simulator/compositing/layer-creation/overlap-animation-container-expected.txt: Added.
* platform/ios-simulator/compositing/repaint/become-overlay-composited-layer-expected.txt:
* platform/ios-simulator/compositing/visible-rect/animated-from-none-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoInserting a child to a slot assigned node doesn't trigger repaint
antti@apple.com [Fri, 2 Oct 2015 23:32:30 +0000 (23:32 +0000)]
Inserting a child to a slot assigned node doesn't trigger repaint
https://bugs.webkit.org/show_bug.cgi?id=149739

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/shadow-dom/insert-child-to-assigned-node.html

* dom/Node.cpp:
(WebCore::Node::derefEventTarget):
(WebCore::traverseStyleParent):
(WebCore::traverseFirstStyleParent):
(WebCore::Node::updateAncestorsForStyleRecalc):

    Traverse in style parent order.

LayoutTests:

* fast/shadow-dom/insert-child-to-assigned-node-expected.html: Added.
* fast/shadow-dom/insert-child-to-assigned-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWe should not add InferredTypeTables to old Structures
fpizlo@apple.com [Fri, 2 Oct 2015 23:09:33 +0000 (23:09 +0000)]
We should not add InferredTypeTables to old Structures
https://bugs.webkit.org/show_bug.cgi?id=149767
rdar://problem/22825526

Patch by Filip Pizlo <fpizlo@apple.com> and Mark Lam <mark.lam@apple.com> on 2015-10-02
Reviewed by Saam Barati.

Our property type inference has an optimization where the absence of an InferredTypeTable is
taken to mean that all properties are TOP. This is great because most Structures come into
existence through reflective stores, and we don't want to waste time inferring types for
those.

But our code was not obeying this rule properly. If we were doing a transition, we would
assume that this meant that we were creating a new structure, and so we would give it an
InferredTypeTable if we were doing a non-reflective store (i.e. context = PutById). But that
same structure could already have been in use prior to us giving it an InferredTypeTable. At
that point bad things will start to happen because the objects created before we created the
table, and the inline caches compiled before then, will have types that disagree with the new
objects and inline caches despite them sharing the same structure and property names.

* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
* runtime/Structure.h:
* tests/stress/add-inferred-type-table-to-existing-structure.js: Added.
(foo):
(bar):
(baz):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Copying inline style text puts "undefined" in the pasteboard
commit-queue@webkit.org [Fri, 2 Oct 2015 22:33:00 +0000 (22:33 +0000)]
Web Inspector: Copying inline style text puts "undefined" in the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=149155

Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2015-10-02
Reviewed by Brian Burg.

Source/WebInspectorUI:

CSSStyleDeclarations for inline styles do not have a owner CSSRule, which means
that they do not have a selector or media list. CSS strings must have a selector
and, for inline styles without an owner rule and selector, this was a problem.

* UserInterface/Models/CSSStyleDeclaration.js:
(WebInspector.CSSStyleDeclaration.prototype.get mediaList):
(WebInspector.CSSStyleDeclaration.prototype.get selectorText):
(WebInspector.CSSStyleDeclaration.prototype.generateCSSRuleString):
Added getters for the list of media queries and selector text with fallbacks
for CSSStyleDeclarations that do not have an owner CSSRule (inline styles).

* UserInterface/Test.html:
Added CSSMedia include for new inspector/css/generate-css-rule-string.html test.

* UserInterface/Views/VisualStyleSelectorTreeItem.js:
(WebInspector.VisualStyleSelectorTreeItem.prototype._handleContextMenuEvent):
Removed parameter that no longer exists.

LayoutTests:

Added test for generating CSS rule strings with default formatting.

* inspector/css/generate-css-rule-string.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling out r190520, some tests assert / crash.
joepeck@webkit.org [Fri, 2 Oct 2015 22:24:07 +0000 (22:24 +0000)]
Unreviewed, rolling out r190520, some tests assert / crash.

Source/JavaScriptCore:

* CMakeLists.txt:
* DerivedSources.make:
* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/Heap.cpp:
(JSC::Heap::willStartCollection): Deleted.
(JSC::Heap::didFinishCollection): Deleted.
* heap/Heap.h:
(JSC::Heap::addObserver): Deleted.
(JSC::Heap::removeObserver): Deleted.
* heap/HeapObserver.h: Removed.
* heap/MarkedSpace.h:
* inspector/InspectorEnvironment.h:
* inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::vm): Deleted.
* inspector/JSGlobalObjectInspectorController.h:
* inspector/agents/InspectorHeapAgent.cpp: Removed.
* inspector/agents/InspectorHeapAgent.h: Removed.
* inspector/protocol/Heap.json: Removed.

Source/WebCore:

* ForwardingHeaders/heap/HeapObserver.h: Removed.
* ForwardingHeaders/inspector/agents/InspectorHeapAgent.h: Removed.
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController): Deleted.
(WebCore::InspectorController::vm): Deleted.
* inspector/InspectorController.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::vm): Deleted.
* inspector/WorkerInspectorController.h:

Source/WebInspectorUI:

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Main.js:
(WebInspector.loaded): Deleted.
* UserInterface/Base/Utilities.js:
(value): Deleted.
* UserInterface/Controllers/HeapManager.js: Removed.
* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager): Deleted.
(WebInspector.TimelineManager.prototype._garbageCollected): Deleted.
* UserInterface/Images/TimelineRecordGarbageCollection.svg: Removed.
* UserInterface/Main.html:
* UserInterface/Models/GarbageCollection.js: Removed.
* UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.EventType.displayName):
(WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection): Deleted.
* UserInterface/Protocol/HeapObserver.js: Removed.
* UserInterface/Test.html:
* UserInterface/Test/Test.js:
(WebInspector.loaded): Deleted.
* UserInterface/Views/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
(WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent): Deleted.
(WebInspector.ScriptTimelineDataGridNode): Deleted.
* UserInterface/Views/ScriptTimelineOverviewGraph.js:
(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
* UserInterface/Views/ScriptTimelineView.js:
(WebInspector.ScriptTimelineView.prototype._processPendingRecords):
* UserInterface/Views/SourceCodeTimelineTreeElement.js:
(WebInspector.SourceCodeTimelineTreeElement):
* UserInterface/Views/TimelineIcons.css:
(.garbage-collection-profile-record .icon): Deleted.
* UserInterface/Views/TimelineRecordBar.css:
(.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment): Deleted.
* UserInterface/Views/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar.createCombinedBars):
* UserInterface/Views/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement):

LayoutTests:

* inspector/heap/garbageCollected-expected.txt: Removed.
* inspector/heap/garbageCollected.html: Removed.
* inspector/heap/gc-expected.txt: Removed.
* inspector/heap/gc.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd the test runner for a new a graphics benchmark
commit-queue@webkit.org [Fri, 2 Oct 2015 22:15:22 +0000 (22:15 +0000)]
Add the test runner for a new a graphics benchmark
https://bugs.webkit.org/show_bug.cgi?id=149683

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-02
Reviewed by Ryosuke Niwa.

The test runner collects the selected test suites and the running options
from its home page. It loops through all the tests, runs them and collects
their running results. At the end, it shows summary results and a final
score. It can also show a chart for a test sampled data.

* Animometer: Added.
* Animometer/runner: Added.
* Animometer/runner/resources: Added.

* Animometer/runner/animometer.html: Added.
* Animometer/runner/resources/animometer.css: Added.
The benchmark runner page and css.

* Animometer/runner/resources/animometer.js: Added.
(window.benchmarkRunnerClient.willAddTestFrame): Called after the test <iframe> is created.
(window.benchmarkRunnerClient.didRunTest): Called after running a test is finished.
(window.benchmarkRunnerClient.willStartFirstIteration): Called at the beginning before running any test.
(window.benchmarkRunnerClient.didRunSuites): Called after running all tests of a suite.
(window.benchmarkRunnerClient.didFinishLastIteration): Called after running the last test.

(showSection): Shows a section in the animometer.html page.
(startTest): Called when the "Start Test" button is clicked.
(showResults): Called after finishing all the tests.
(showGraph): Called when "Click..." button in the "Samples" column of the results table is clicked

* Animometer/runner/resources/benchmark-runner.js: Copied from PerformanceTests/Speedometer/resources/benchmark-runner.js.
(BenchmarkRunnerState): Tracks the current running <suite, test>
(BenchmarkRunnerState.prototype.currentSuite): Returns the current running suite.
(BenchmarkRunnerState.prototype.currentTest): Returns the current running test.
(BenchmarkRunnerState.prototype.isFirstTest): Returns true if we are running the first test in the current suite.
(BenchmarkRunnerState.prototype.next): Advances to the next test.
(BenchmarkRunnerState.prototype.prepareCurrentTest): Creates a new <iframe> and waits for it to load a test.

(BenchmarkRunner): Manages running the tests and communicating with the benchmarkRunnerClient.
(BenchmarkRunner.prototype.waitForElement): Waits for an element to be created.
(BenchmarkRunner.prototype._appendFrame): Creates a new <iframe> element.
(BenchmarkRunner.prototype._removeFrame): Removed the current <iframe> element.
(BenchmarkRunner.prototype._runTestAndRecordResults): Runs the current test and saves its results.
(BenchmarkRunner.prototype.step): Either runs the current test if there is or start a new iteration.
(BenchmarkRunner.prototype.runAllSteps): Loops to run all the tests and move to the next iteration.
(this._runNextIteration): Starts a new iteration or show the results.
(BenchmarkRunner.prototype.runMultipleIterations): Loops to run all the iterations and show the results
(BenchmarkRunner.prototype._finalize): Finalizes the current iteration and starts a new one.

(SimplePromise): Deleted.
(SimplePromise.prototype.then): Deleted.
(SimplePromise.prototype.resolve): Deleted.
(BenchmarkTestStep): Deleted.
(Fibonacci): Deleted.
SimplePromise was moved t Animometer/resources/extensions.js because it is used by the runner and the tests.

(BenchmarkRunner.prototype._waitAndWarmUp): Deleted.
(BenchmarkRunner.prototype._runTest): Deleted.
(BenchmarkState.prototype.currentSuite): Deleted.
(BenchmarkState.prototype.currentTest): Deleted.
(BenchmarkState.prototype.next): Deleted.
(BenchmarkState.prototype.isFirstTest): Deleted.
(BenchmarkState.prototype.prepareCurrentSuite): Deleted.
BenchmarkState was renamed to BenchmarkRunnerState to not be confused with the tests BenchmarkState.

* Animometer/runner/resources/d3.min.js: Copied from Websites/perf.webkit.org/public/v2/js/d3/d3.min.js.
Needed for drawing charts for the sampled scores and frame rates.

* Animometer/runner/resources/graph.js: Added.
(graph): Draws a chart for a test sampled data. It shows two y-axes: one for the animated items and the second for FPS.

* Skipped: Skip the Animometer benchmark for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoProvide "--no-ninja" option to avoid using Ninja
bfulgham@apple.com [Fri, 2 Oct 2015 21:44:10 +0000 (21:44 +0000)]
Provide "--no-ninja" option to avoid using Ninja
https://bugs.webkit.org/show_bug.cgi?id=149757

Reviewed by Alex Christensen.

Add a new command line argument understood by webkitdirs.pm so
that we can conditionally avoid using Ninja. This is an
'opt-out' argument, so no existing Ninja users should be affected.

* Scripts/webkitdirs.pm:
(canUseNinja): Check for option and block ninja if present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFlakiness dashboard should support OS X El Capitan
commit-queue@webkit.org [Fri, 2 Oct 2015 21:38:57 +0000 (21:38 +0000)]
Flakiness dashboard should support OS X El Capitan
https://bugs.webkit.org/show_bug.cgi?id=149648

Patch by Aakash Jain <aakash_jain@apple.com> on 2015-10-02
Reviewed by Alexey Proskuryakov.

* TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling back in r190450
ggaren@apple.com [Fri, 2 Oct 2015 21:16:20 +0000 (21:16 +0000)]
Unreviewed, rolling back in r190450
https://bugs.webkit.org/show_bug.cgi?id=149727

The cause of the crash was a CodeBlock, after surviving a call to
deleteAllCode by virtue of being in the remembered set, trying to mark
its inlined CodeBlocks via pointers from its inlined executables.
Since deleteAllCode clears those pointers, the CodeBlock would ASSERT.
(Any other choice to retain a CodeBlock after deleteAllCode -- for
example, conservative marking -- could trigger the same bug.)

The fix is for InlineCallFrame to point directly to its inlined CodeBlock
instead of pointing indirectly via an executable. This guarantees that
CodeBlocks are GC safe regardless of whether we've called deleteAllCode.

Restored changesets:

"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190450

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Option-Click on a property name in the Computed view should jump to...
commit-queue@webkit.org [Fri, 2 Oct 2015 21:11:47 +0000 (21:11 +0000)]
Web Inspector: Option-Click on a property name in the Computed view should jump to resource view
https://bugs.webkit.org/show_bug.cgi?id=149521

Patch by Devin Rousso <dcrousso+webkit@gmail.com> on 2015-10-02
Reviewed by Timothy Hatcher.

* UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype.effectivePropertyForName):
Now tries to search for a non-canonical property before falling back to
the canonical version.

* UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
If the user option-clicks the goto arrow, it shows the source for the
property instead.

* UserInterface/Views/ComputedStyleDetailsPanel.js:
(WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty.delegateShowProperty):
(WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty):
Attempts to show the source of the given property. Will fallback to
highlighting the property in the rules panel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Include Garbage Collection Event in Timeline
commit-queue@webkit.org [Fri, 2 Oct 2015 20:40:47 +0000 (20:40 +0000)]
Web Inspector: Include Garbage Collection Event in Timeline
https://bugs.webkit.org/show_bug.cgi?id=142510

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-02
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* CMakeLists.txt:
* DerivedSources.make:
* JavaScriptCore.xcodeproj/project.pbxproj:

* heap/HeapObserver.h:
* heap/Heap.cpp:
(JSC::Heap::willStartCollection):
(JSC::Heap::didFinishCollection):
* heap/Heap.h:
(JSC::Heap::addObserver):
(JSC::Heap::removeObserver):
Allow observers on heap to add hooks for starting / ending garbage collection.

* inspector/InspectorEnvironment.h:
* inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::vm):
* inspector/JSGlobalObjectInspectorController.h:
Access the VM through the InspectorEnvironment as it won't change.

* inspector/agents/InspectorHeapAgent.cpp: Added.
(Inspector::InspectorHeapAgent::InspectorHeapAgent):
(Inspector::InspectorHeapAgent::~InspectorHeapAgent):
(Inspector::InspectorHeapAgent::didCreateFrontendAndBackend):
(Inspector::InspectorHeapAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorHeapAgent::enable):
(Inspector::InspectorHeapAgent::disable):
(Inspector::InspectorHeapAgent::gc):
(Inspector::protocolTypeForHeapOperation):
(Inspector::InspectorHeapAgent::willGarbageCollect):
(Inspector::InspectorHeapAgent::didGarbageCollect):
* inspector/agents/InspectorHeapAgent.h: Added.
* inspector/protocol/Heap.json: Added.
New domain and agent to handle tasks related to the JavaScriptCore heap.

Source/WebCore:

Tests: inspector/heap/garbageCollected.html
       inspector/heap/gc.html

* ForwardingHeaders/heap/HeapObserver.h: Added.
* ForwardingHeaders/inspector/agents/InspectorHeapAgent.h: Added.
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
Forwarding headers.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::vm):
* inspector/InspectorController.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::vm):
* inspector/WorkerInspectorController.h:
Implement InspectorEnvironment::vm and create a Heap agent for the
Page inspector controller.

Source/WebInspectorUI:

* UserInterface/Base/Utilities.js:
(Array.prototype.parition):
Helper to partition an Array into two arrays.

* UserInterface/Main.html:
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Main.js:
(WebInspector.loaded):
* UserInterface/Test.html:
* UserInterface/Test/Test.js:
(WebInspector.loaded):
* UserInterface/Protocol/HeapObserver.js:
(WebInspector.HeapObserver.prototype.garbageCollected):
(WebInspector.HeapObserver):
Create the new observer and manager.

* UserInterface/Models/GarbageCollection.js:
(WebInspector.GarbageCollection):
(WebInspector.GarbageCollection.fromPayload):
(WebInspector.GarbageCollection.prototype.get type):
(WebInspector.GarbageCollection.prototype.get startTime):
(WebInspector.GarbageCollection.prototype.get endTime):
(WebInspector.GarbageCollection.prototype.get duration):
Model object for Heap.GarbageCollection.

* UserInterface/Controllers/HeapManager.js:
(WebInspector.HeapManager):
(WebInspector.HeapManager.prototype.garbageCollected):
Dispatch events with.

* UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype._garbageCollected):
Include new GC Timeline Events as Script events.

* UserInterface/Views/ScriptTimelineOverviewGraph.js:
(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
For the Script overview, make two sets of bars, one for Scripts and one for GCs.
The GCs bar will be on top of the the Scripts bar. This is particularly useful
since a GC can happen during script execution.

* UserInterface/Views/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
(WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
(WebInspector.ScriptTimelineDataGridNode):
Give a NaN call count to top level Script DataGridNodes.
In the UI, display the empty placeholder for NaN call counts.

* UserInterface/Images/TimelineRecordGarbageCollection.svg: Added.
* UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
(WebInspector.ScriptTimelineRecord.EventType.displayName):
* UserInterface/Views/ScriptTimelineView.js:
(WebInspector.ScriptTimelineView.prototype._processPendingRecords):
* UserInterface/Views/SourceCodeTimelineTreeElement.js:
(WebInspector.SourceCodeTimelineTreeElement):
* UserInterface/Views/TimelineIcons.css:
(.garbage-collection-profile-record .icon):
* UserInterface/Views/TimelineRecordBar.css:
(.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment):
UI for GC events.

* UserInterface/Views/TimelineRecordBar.js:
(WebInspector.TimelineRecordBar.createCombinedBars):
Simplify by storing start time into a variable.

* UserInterface/Views/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement):
Icon for GC events.

LayoutTests:

* inspector/heap/garbageCollected-expected.txt: Added.
* inspector/heap/garbageCollected.html: Added.
* inspector/heap/gc-expected.txt: Added.
* inspector/heap/gc.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
dbates@webkit.org [Fri, 2 Oct 2015 20:38:34 +0000 (20:38 +0000)]
Fix run-webkit-tests --ios-simulator after <trac.webkit.org/changeset/190515>
(https://bugs.webkit.org/show_bug.cgi?id=149753)

For now, pass --ios-simulator.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort._build_relay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoTest gardening.
simon.fraser@apple.com [Fri, 2 Oct 2015 20:37:28 +0000 (20:37 +0000)]
Test gardening.

* TestExpectations:
* platform/gtk/TestExpectations:
* platform/ios-simulator/TestExpectations:
* platform/mac-wk1/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove a "nullable" that breaks the iOS 8 build.
simon.fraser@apple.com [Fri, 2 Oct 2015 20:18:21 +0000 (20:18 +0000)]
Remove a "nullable" that breaks the iOS 8 build.

* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[MSE] Browser crashes when appending invalid data to MSE source buffer
jer.noble@apple.com [Fri, 2 Oct 2015 19:51:21 +0000 (19:51 +0000)]
[MSE] Browser crashes when appending invalid data to MSE source buffer
https://bugs.webkit.org/show_bug.cgi?id=149689

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-source/media-source-stpp-crash.html

Bail out early (as specced) after disconnecting the SourceBuffer from its MediaSource.

* Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):

LayoutTests:

* media/content/stpp.mp4: Added.
* media/media-source/media-source-stpp-crash-expected.txt: Added.
* media/media-source/media-source-stpp-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoLayoutTestRelay is not built and archived when building for iOS Simulator
dbates@webkit.org [Fri, 2 Oct 2015 19:43:09 +0000 (19:43 +0000)]
LayoutTestRelay is not built and archived when building for iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=149753

Reviewed by Alexey Proskuryakov and Andy Estes.

Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
product archive when building for iOS Simulator, respectively.

* BuildSlaveSupport/built-product-archive:
(main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
differentiate between iOS device and iOS Simulator platforms.
(webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
from determineWebKitBuildDirectories() into this function so that it can be used by both
determineWebKitBuildDirectories() and archiveBuiltProduct().
(determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
webkitBuildDirectoryForConfigurationAndPlatform().
(createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
for the limitation that ditto(1) can only accept a single directory to archive on its command line.
(archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
* Scripts/build-layouttestrelay:
    - Remove unnecessary include of Perl module POSIX.
    - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
* Scripts/build-webkit:
    - Invoke script build-layouttestrelay when building for iOS Simulator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoASSERTION FAILED: param >= 0 in AnimationBase::updateStateMachine()
simon.fraser@apple.com [Fri, 2 Oct 2015 19:36:32 +0000 (19:36 +0000)]
ASSERTION FAILED: param >= 0 in AnimationBase::updateStateMachine()
https://bugs.webkit.org/show_bug.cgi?id=149737
rdar://problem/19017465

Reviewed by Dean Jackson.

CoreAnimation can give us an animation beginTime that is slightly into the future,
which results in 'param' here being < 0, so relax the assertion slightly.

Fixes lots of assertions running iOS WK2 layout tests.

* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[WinCairo] Fix linker warnings.
peavo@outlook.com [Fri, 2 Oct 2015 18:33:49 +0000 (18:33 +0000)]
[WinCairo] Fix linker warnings.
https://bugs.webkit.org/show_bug.cgi?id=149754

Reviewed by Alex Christensen.

Avoid compiling these files twice, they are already included in
RenderingAllInOne.cpp.

* PlatformWinCairo.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoText selection is inaccurate in Wikipedia pages when starting navigation from wikiped...
enrica@apple.com [Fri, 2 Oct 2015 18:29:03 +0000 (18:29 +0000)]
Text selection is inaccurate in Wikipedia pages when starting navigation from wikipedia.org.
https://bugs.webkit.org/show_bug.cgi?id=149756
rdar://problem/22332409

Reviewed by Tim Horton.

When loading a new document into the same WebPage object, we need
to clear the assisted node, since there is no guarantee that the
node will be blurred. The bug is caused by the use of a stale
assisted node to constrain the point where the gesture occurs.
A fix for this problem was landed in http://trac.webkit.org/changeset/179885
where the cleanup was added when FrameLoaderClient::detach2 was called.
This method doesn't seem to be called any longer for the main frame,
so the correct solution is to add the cleanup to didCommitLoad in WebPage.
I've also added some checks to webSelectionsRects and selectedTextRange to avoid
the use of postLayoutData when the selection is none.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView webSelectionRects]):
(-[WKContentView selectedTextRange]):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::detachedFromParent2): Removed call to resetAssistedNodeForFrame.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad): Added call to resetAssistedNodeForFrame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Win] Unreviewed test fix.
bfulgham@apple.com [Fri, 2 Oct 2015 17:58:21 +0000 (17:58 +0000)]
[Win] Unreviewed test fix.

You cannot run 'run-webkit-tests' from the command line because it does not know
to append the binary subdirectory (bin32/bin64). We don't see this on our builders
because they explicitly set use the 'root' argument to provide the full path to
the test binaries.

* Scripts/webkitpy/port/win.py:
(WinPort._build_path): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSource/WebCore:
achristensen@apple.com [Fri, 2 Oct 2015 17:46:25 +0000 (17:46 +0000)]
Source/WebCore:
Reloading without content blockers doesn't apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

Test: http/tests/contentextensions/disable-blocker.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
* loader/DocumentLoader.h:
(WebCore::DocumentLoader::userContentExtensionsEnabled):
(WebCore::DocumentLoader::setUserContentExtensionsEnabled):
Store and use the state of whether content blockers are enabled or not on the DocumentLoader
so that it stays constant for a document's entire life.  This state comes from the Page when
making the DocumentLoader in WebKit2.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequestInternal):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::open):
* page/UserContentController.cpp:
(WebCore::UserContentController::removeAllUserContentExtensions):
(WebCore::UserContentController::processContentExtensionRulesForLoad):
(WebCore::UserContentController::actionsForResourceLoad):
* page/UserContentController.h:

Source/WebKit2:
Reloading without content blockers doesn't apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createDocumentLoader):
Copy the state of whether content extensions are disabled from the Page to the DocumentLoader
when making a DocumentLoader.

Tools:
Reloading without content blockers doesn't apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaResetStateToConsistentValues):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformConfigureViewForTest):
Test what happens when you disable content blockers from the SPI.

LayoutTests:
Reloading without content blockers doesn’t apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

* http/tests/contentextensions/disable-blocker-expected.txt: Added.
* http/tests/contentextensions/disable-blocker.html: Added.
* http/tests/contentextensions/disable-blocker.html.json: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Fix indentation of console message parameters
nvasilyev@apple.com [Fri, 2 Oct 2015 15:13:32 +0000 (15:13 +0000)]
Web Inspector: Fix indentation of console message parameters
https://bugs.webkit.org/show_bug.cgi?id=149740

Reviewed by Darin Adler.

* UserInterface/Views/ConsoleMessageView.css:
(.console-message .console-message-stack-trace-container > li):
(.console-message .console-message-extra-parameters-container > li::before):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agopopstate is fired at the wrong time on load
commit-queue@webkit.org [Fri, 2 Oct 2015 15:13:05 +0000 (15:13 +0000)]
popstate is fired at the wrong time on load
https://bugs.webkit.org/show_bug.cgi?id=94265

Patch by Antoine Quint <graouts@apple.com> on 2015-10-02
Reviewed by Darin Adler.

Source/WebCore:

Don't fire popstate event on initial document load

According to the specification [1], a popstate event should only be fired
when the document has a "last entry" and the entry being navigated to isn't
it.  A document is created without a "last entry" and gets one just after
this check when it is first navigated to, so a popstate should be fired any
time a document is navigated to except for the first time after it has been
created.

Patch adapted from work by jl@opera.com on Blink [2].

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#traverse-the-history (step 12-14 in particular)
[2] https://src.chromium.org/viewvc/blink?revision=165221&view=revision

* dom/Document.cpp:
(WebCore::Document::implicitClose):

Source/WebKit2:

Ensure we have a valid page before trying to get to its drawingArea as this could lead
to a crash as observed with fast/loader/stateobjects/pushstate-object-types.html.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::restoreViewState):

LayoutTests:

Updating tests that relied on a "popstate" event being fired at page load.

* fast/history/same-document-iframes-changing-fragment-expected.txt:
* fast/history/same-document-iframes-changing-pushstate-expected.txt:
* fast/loader/javascript-url-iframe-remove-on-navigate.html:
* fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
* fast/loader/stateobjects/document-destroyed-navigate-back.html:
* fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html:
* fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html:
* fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html:
* fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html:
* fast/loader/stateobjects/popstate-fires-on-history-traversal-expected.txt:
* fast/loader/stateobjects/popstate-fires-on-history-traversal.html:
* fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt:
* fast/loader/stateobjects/popstate-fires-with-page-cache.html:
* fast/loader/stateobjects/pushstate-object-types.html:
* fast/loader/stateobjects/pushstate-then-replacestate.html:
* fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
* fast/loader/stateobjects/replacestate-then-pushstate.html:
* fast/loader/stateobjects/resources/popstate-fires-with-page-cache-1.html:
* fast/loader/stateobjects/resources/popstate-fires-with-page-cache-2.html:
* fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html:
* http/tests/history/popstate-fires-with-pending-requests.html:
* http/tests/navigation/redirect-on-back-updates-history-item-expected.txt:
* http/tests/navigation/redirect-on-reload-updates-history-item-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Web Inspector: Add GTK+ icons for new plus icons in the style sidebar
agomez@igalia.com [Fri, 2 Oct 2015 14:08:18 +0000 (14:08 +0000)]
[GTK] Web Inspector: Add GTK+ icons for new plus icons in the style sidebar
https://bugs.webkit.org/show_bug.cgi?id=149227

Reviewed by Carlos Garcia Campos.

* UserInterface/Images/gtk/NewTabPlus.svg: Updated.
* UserInterface/Images/gtk/Plus13.svg: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.
* UserInterface/Images/gtk/Plus15.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[CSS Grid Layout] Support for Content Alignment in grid layout
jfernandez@igalia.com [Fri, 2 Oct 2015 12:14:49 +0000 (12:14 +0000)]
[CSS Grid Layout] Support for Content Alignment in grid layout
https://bugs.webkit.org/show_bug.cgi?id=145520

Reviewed by Darin Adler.

Source/WebCore:

According to CSS Box Alignment specification, Content Distribution
alignment controls alignment of the box's content within the box. The
alignment container is the grid container's content box. The alignment
subjects are the grid tracks.

This patch implements Grid Layout support for Content Distribution
alignment along both block/column and inline/row axis, which are handled
by align-content and justify-content properties respectively.

This patch provides support for overflow handling, similar to what
Self Alignment provides with grid items, and both <content-position>
and <content-distribution> values.

Baseline Alignment is still missing because it requires some additional
behavior to be supported on grids before considering its implementation.

Tests: css3/overwrite-content-alignment.html
       css3/overwrite-self-alignment.html
       fast/css-grid-layout/grid-align-content-distribution-vertical-lr.html
       fast/css-grid-layout/grid-align-content-distribution-vertical-rl.html
       fast/css-grid-layout/grid-align-content-distribution.html
       fast/css-grid-layout/grid-align-content-vertical-lr.html
       fast/css-grid-layout/grid-align-content-vertical-rl.html
       fast/css-grid-layout/grid-align-content.html
       fast/css-grid-layout/grid-content-alignment-overflow.html
       fast/css-grid-layout/grid-content-alignment-with-different-sized-tracks.html
       fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr.html
       fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl.html
       fast/css-grid-layout/grid-content-alignment-with-span.html
       fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html
       fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html
       fast/css-grid-layout/grid-justify-content-distribution.html
       fast/css-grid-layout/grid-justify-content-vertical-lr.html
       fast/css-grid-layout/grid-justify-content-vertical-rl.html
       fast/css-grid-layout/grid-justify-content.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
(WebCore::RenderFlexibleBox::alignFlexLines):
* rendering/RenderGrid.cpp:
(WebCore::ContentAlignmentData::ContentAlignmentData):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::resolveContentDistributionFallback):
(WebCore::offsetToStartEdge):
(WebCore::offsetToEndEdge):
(WebCore::contentDistributionOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionColumnOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionRowOffset):
(WebCore::RenderGrid::findChildLogicalPosition):
(WebCore::RenderGrid::computePreferredLogicalWidths): Deleted.
(WebCore::RenderGrid::autoPlacementMajorAxisDirection): Deleted.
(WebCore::RenderGrid::autoPlacementMinorAxisDirection): Deleted.
(WebCore::RenderGrid::cachedGridCoordinate): Deleted.
(WebCore::RenderGrid::rowPositionForChild): Deleted.
* rendering/RenderGrid.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::resolvedAlignContentPosition):
(WebCore::RenderStyle::resolvedAlignContentDistribution):
(WebCore::RenderStyle::resolvedJustifyContentPosition):
(WebCore::RenderStyle::resolvedJustifyContentDistribution):
* rendering/style/RenderStyle.h:

LayoutTests:

Content Distribution alignment controls alignment of the box's
content within the box. The alignment container is the grid
container's content box. The alignment subjects are the grid
tracks.

In addition to the tests to verify the new functionality, I've
added some tests to check out that the new complex values are
overwritten properly.

I had to modify the grid-item-margin-auto-columns-rows-horizontal-rtl
test because when using RTL direction the whole grid must flow form
right to left, not only its items, so I rebaselined text expectations
to adapt it to the new behavior.

* css3/overwrite-content-alignment-expected.txt: Added.
* css3/overwrite-content-alignment.html: Added.
* css3/overwrite-self-alignment-expected.txt: Added.
* css3/overwrite-self-alignment.html: Added.
* fast/css-grid-layout/grid-align-content-distribution-expected.txt: Added.
* fast/css-grid-layout/grid-align-content-distribution-vertical-lr-expected.txt: Added.
* fast/css-grid-layout/grid-align-content-distribution-vertical-lr.html: Added.
* fast/css-grid-layout/grid-align-content-distribution-vertical-rl-expected.txt: Added.
* fast/css-grid-layout/grid-align-content-distribution-vertical-rl.html: Added.
* fast/css-grid-layout/grid-align-content-distribution.html: Added.
* fast/css-grid-layout/grid-align-content-expected.txt: Added.
* fast/css-grid-layout/grid-align-content-vertical-lr-expected.txt: Added.
* fast/css-grid-layout/grid-align-content-vertical-lr.html: Added.
* fast/css-grid-layout/grid-align-content-vertical-rl-expected.txt: Added.
* fast/css-grid-layout/grid-align-content-vertical-rl.html: Added.
* fast/css-grid-layout/grid-align-content.html: Added.
* fast/css-grid-layout/grid-content-alignment-overflow-expected.txt: Added.
* fast/css-grid-layout/grid-content-alignment-overflow.html: Added.
* fast/css-grid-layout/grid-content-alignment-with-different-sized-tracks.html: Added.
* fast/css-grid-layout/grid-content-alignment-with-different-sized-tracks-expected.txt: Added.
* fast/css-grid-layout/grid-content-alignment-with-span-expected.txt: Added.
* fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr-expected.txt: Added.
* fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr.html: Added.
* fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl-expected.txt: Added.
* fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl.html: Added.
* fast/css-grid-layout/grid-content-alignment-with-span.html: Added.
* fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-rtl-expected.html:
* fast/css-grid-layout/grid-justify-content-distribution-expected.txt: Added.
* fast/css-grid-layout/grid-justify-content-distribution-vertical-lr-expected.txt: Added.
* fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html: Added.
* fast/css-grid-layout/grid-justify-content-distribution-vertical-rl-expected.txt: Added.
* fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html: Added.
* fast/css-grid-layout/grid-justify-content-distribution.html: Added.
* fast/css-grid-layout/grid-justify-content-expected.txt: Added.
* fast/css-grid-layout/grid-justify-content-vertical-lr-expected.txt: Added.
* fast/css-grid-layout/grid-justify-content-vertical-lr.html: Added.
* fast/css-grid-layout/grid-justify-content-vertical-rl-expected.txt: Added.
* fast/css-grid-layout/grid-justify-content-vertical-rl.html: Added.
* fast/css-grid-layout/grid-justify-content.html: Added.
* fast/css-grid-layout/resources/grid.css:
(.firstRowThirdColumn):
(.firstRowFourthColumn):
(.secondRowThirdColumn):
(.secondRowFourthColumn):
(.thirdRowFirstColumn):
(.thirdRowSecondColumn):
(.fourthRowFirstColumn):
(.fourthRowSecondColumn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAttempted build fix.
dino@apple.com [Fri, 2 Oct 2015 11:07:40 +0000 (11:07 +0000)]
Attempted build fix.

* DerivedSources.make:
* page/make_settings.pl:
(printGetterAndSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoExpose WEBGL_debug_renderer_info
dino@apple.com [Fri, 2 Oct 2015 10:53:53 +0000 (10:53 +0000)]
Expose WEBGL_debug_renderer_info
https://bugs.webkit.org/show_bug.cgi?id=149735
<rdar://problem/18343500>

Reviewed by Simon Fraser.

Source/WebCore:

Enable the extension that allows content to query
for the GPUs vendor and details.

Now that we're enabling this, there was no need for
the internal setting that identified privileged situations.
However, since this meant that WEBGL_debug_shaders was
also exposed, I explicitly disable it since it is
not yet conformant.

Test: fast/canvas/webgl/webgl-debug-renderer-info.html
as well as the general conformance suite.

* html/canvas/WebGL2RenderingContext.cpp: No need to guard around allowPrivilegedExtensions().
(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
* html/canvas/WebGLRenderingContext.cpp: Ditto.
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::allowPrivilegedExtensions): Deleted.
* html/canvas/WebGLRenderingContextBase.h:
* page/Settings.in: Remove privilegedWebGLExtensions.
* platform/graphics/opengl/Extensions3DOpenGL.cpp: Forbid the translated shader
extension while it is still buggy.
(WebCore::Extensions3DOpenGL::supportsExtension):

LayoutTests:

Modify a test from the 1.0.2 conformance suite to make sure
we're actually enabling and passing the info.

* fast/canvas/webgl/webgl-debug-renderer-info-expected.txt: Added.
* fast/canvas/webgl/webgl-debug-renderer-info.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix the #if guard in PointerLockController.cpp
ossy@webkit.org [Fri, 2 Oct 2015 05:44:59 +0000 (05:44 +0000)]
Fix the #if guard in PointerLockController.cpp
https://bugs.webkit.org/show_bug.cgi?id=149705

Reviewed by Gyuyoung Kim.

* page/PointerLockController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago2015-10-01 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 2 Oct 2015 04:48:24 +0000 (04:48 +0000)]
2015-10-01  Geoffrey Garen  <ggaren@apple.com>

        Unreviewed, rolling out r190450
        https://bugs.webkit.org/show_bug.cgi?id=148560

        Crashes seen on el cap wk1 bots.

        Reverted changesets:

        "CodeBlock should be a GC object"
        https://bugs.webkit.org/show_bug.cgi?id=149727
        http://trac.webkit.org/changeset/190450

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::inferredName):
        (JSC::CodeBlock::dumpAssumingJITType):
        (JSC::CodeBlock::CodeBlock):
        (JSC::CodeBlock::~CodeBlock):
        (JSC::CodeBlock::setNumParameters):
        (JSC::CodeBlock::specialOSREntryBlockOrNull):
        (JSC::CodeBlock::visitStrongly):
        (JSC::CodeBlock::visitAggregate):
        (JSC::CodeBlock::shouldVisitStrongly):
        (JSC::CodeBlock::isKnownToBeLiveDuringGC):
        (JSC::CodeBlock::shouldJettisonDueToWeakReference):
        (JSC::CodeBlock::shouldJettisonDueToOldAge):
        (JSC::CodeBlock::determineLiveness):
        (JSC::CodeBlock::visitWeakReferences):
        (JSC::CodeBlock::finalizeLLIntInlineCaches):
        (JSC::CodeBlock::finalizeBaselineJITInlineCaches):
        (JSC::CodeBlock::finalizeUnconditionally):
        (JSC::CodeBlock::visitOSRExitTargets):
        (JSC::CodeBlock::unlinkIncomingCalls):
        (JSC::CodeBlock::linkIncomingCall):
        (JSC::CodeBlock::newReplacement):
        (JSC::ProgramCodeBlock::replacement):
        (JSC::ModuleProgramCodeBlock::replacement):
        (JSC::EvalCodeBlock::replacement):
        (JSC::FunctionCodeBlock::replacement):
        (JSC::ProgramCodeBlock::capabilityLevelInternal):
        (JSC::ModuleProgramCodeBlock::capabilityLevelInternal):
        (JSC::EvalCodeBlock::capabilityLevelInternal):
        (JSC::FunctionCodeBlock::capabilityLevelInternal):
        (JSC::WebAssemblyCodeBlock::replacement):
        (JSC::WebAssemblyCodeBlock::capabilityLevelInternal):
        (JSC::CodeBlock::jettison):
        (JSC::CodeBlock::capabilityLevel):
        (JSC::FunctionCodeBlock::destroy): Deleted.
        (JSC::WebAssemblyCodeBlock::destroy): Deleted.
        (JSC::ProgramCodeBlock::destroy): Deleted.
        (JSC::ModuleProgramCodeBlock::destroy): Deleted.
        (JSC::EvalCodeBlock::destroy): Deleted.
        (JSC::CodeBlock::finishCreation): Deleted.
        (JSC::CodeBlock::setAlternative): Deleted.
        (JSC::CodeBlock::visitWeakly): Deleted.
        (JSC::CodeBlock::visitChildren): Deleted.
        (JSC::timeToLive): Deleted.
        (JSC::CodeBlock::WeakReferenceHarvester::visitWeakReferences): Deleted.
        (JSC::CodeBlock::UnconditionalFinalizer::finalizeUnconditionally): Deleted.
        (JSC::CodeBlock::replacement): Deleted.
        (JSC::CodeBlock::computeCapabilityLevel): Deleted.
        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::unlinkedCodeBlock):
        (JSC::CodeBlock::addressOfNumParameters):
        (JSC::CodeBlock::offsetOfNumParameters):
        (JSC::CodeBlock::alternative):
        (JSC::CodeBlock::setAlternative):
        (JSC::CodeBlock::forEachRelatedCodeBlock):
        (JSC::CodeBlock::specializationKind):
        (JSC::CodeBlock::instructionCount):
        (JSC::CodeBlock::setJITCode):
        (JSC::CodeBlock::hasBaselineJITProfiling):
        (JSC::CodeBlock::capabilityLevelState):
        (JSC::CodeBlock::addConstant):
        (JSC::CodeBlock::appendExceptionHandler):
        (JSC::CodeBlock::setConstantRegisters):
        (JSC::CodeBlock::replaceConstant):
        (JSC::GlobalCodeBlock::GlobalCodeBlock):
        (JSC::ProgramCodeBlock::ProgramCodeBlock):
        (JSC::ModuleProgramCodeBlock::ModuleProgramCodeBlock):
        (JSC::EvalCodeBlock::EvalCodeBlock):
        (JSC::EvalCodeBlock::variable):
        (JSC::EvalCodeBlock::numVariables):
        (JSC::EvalCodeBlock::unlinkedEvalCodeBlock):
        (JSC::FunctionCodeBlock::FunctionCodeBlock):
        (JSC::WebAssemblyCodeBlock::WebAssemblyCodeBlock):
        (JSC::ExecState::uncheckedR):
        (JSC::CodeBlock::clearMarks):
        (JSC::CodeBlockSet::mark):
        (JSC::ScriptExecutable::forEachCodeBlock):
        (JSC::ProgramCodeBlock::create): Deleted.
        (JSC::ProgramCodeBlock::createStructure): Deleted.
        (JSC::ModuleProgramCodeBlock::create): Deleted.
        (JSC::ModuleProgramCodeBlock::createStructure): Deleted.
        (JSC::EvalCodeBlock::create): Deleted.
        (JSC::EvalCodeBlock::createStructure): Deleted.
        (JSC::FunctionCodeBlock::create): Deleted.
        (JSC::FunctionCodeBlock::createStructure): Deleted.
        (JSC::WebAssemblyCodeBlock::create): Deleted.
        (JSC::WebAssemblyCodeBlock::createStructure): Deleted.
        (JSC::CodeBlock::clearVisitWeaklyHasBeenCalled): Deleted.
        * bytecode/DeferredCompilationCallback.cpp:
        (JSC::DeferredCompilationCallback::DeferredCompilationCallback):
        (JSC::DeferredCompilationCallback::~DeferredCompilationCallback):
        (JSC::DeferredCompilationCallback::compilationDidComplete):
        * bytecode/DeferredCompilationCallback.h:
        * bytecode/EvalCodeCache.h:
        (JSC::EvalCodeCache::tryGet):
        (JSC::EvalCodeCache::getSlow):
        * bytecode/PolymorphicAccess.cpp:
        (JSC::AccessCase::generate):
        (JSC::PolymorphicAccess::regenerate):
        * bytecode/StructureStubInfo.cpp:
        (JSC::StructureStubInfo::addAccessCase):
        * dfg/DFGByteCodeParser.cpp:
        (JSC::DFG::ByteCodeParser::parse):
        * dfg/DFGDesiredTransitions.cpp:
        (JSC::DFG::DesiredTransition::reallyAdd):
        * dfg/DFGDesiredWeakReferences.cpp:
        (JSC::DFG::DesiredWeakReferences::reallyAdd):
        * dfg/DFGDriver.cpp:
        (JSC::DFG::compile):
        * dfg/DFGGraph.cpp:
        (JSC::DFG::Graph::Graph):
        * dfg/DFGJITCode.h:
        (JSC::DFG::JITCode::osrEntryBlock): Deleted.
        (JSC::DFG::JITCode::setOSREntryBlock): Deleted.
        (JSC::DFG::JITCode::clearOSREntryBlock): Deleted.
        * dfg/DFGJITFinalizer.cpp:
        (JSC::DFG::JITFinalizer::finalize):
        (JSC::DFG::JITFinalizer::finalizeFunction):
        (JSC::DFG::JITFinalizer::finalizeCommon):
        * dfg/DFGOSRExitCompilerCommon.cpp:
        (JSC::DFG::adjustAndJumpToTarget):
        * dfg/DFGOperations.cpp:
        * dfg/DFGPlan.cpp:
        (JSC::DFG::Plan::Plan):
        (JSC::DFG::Plan::reallyAdd):
        (JSC::DFG::Plan::notifyReady):
        (JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
        (JSC::DFG::Plan::finalizeAndNotifyCallback):
        (JSC::DFG::Plan::key):
        (JSC::DFG::Plan::clearCodeBlockMarks):
        (JSC::DFG::Plan::checkLivenessAndVisitChildren):
        (JSC::DFG::Plan::rememberCodeBlocks): Deleted.
        * dfg/DFGPlan.h:
        * dfg/DFGToFTLDeferredCompilationCallback.cpp:
        (JSC::DFG::ToFTLDeferredCompilationCallback::ToFTLDeferredCompilationCallback):
        (JSC::DFG::ToFTLDeferredCompilationCallback::~ToFTLDeferredCompilationCallback):
        (JSC::DFG::ToFTLDeferredCompilationCallback::create):
        (JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
        (JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):
        * dfg/DFGToFTLDeferredCompilationCallback.h:
        * dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
        (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::ToFTLForOSREntryDeferredCompilationCallback):
        (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::~ToFTLForOSREntryDeferredCompilationCallback):
        (JSC::DFG::Ref<ToFTLForOSREntryDeferredCompilationCallback>ToFTLForOSREntryDeferredCompilationCallback::create):
        (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
        (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):
        * dfg/DFGToFTLForOSREntryDeferredCompilationCallback.h:
        * dfg/DFGWorklist.cpp:
        (JSC::DFG::Worklist::completeAllPlansForVM):
        (JSC::DFG::Worklist::clearCodeBlockMarks):
        (JSC::DFG::completeAllPlansForVM):
        (JSC::DFG::clearCodeBlockMarks):
        (JSC::DFG::Worklist::rememberCodeBlocks): Deleted.
        (JSC::DFG::rememberCodeBlocks): Deleted.
        * dfg/DFGWorklist.h:
        (JSC::DFG::worklistForIndexOrNull):
        * ftl/FTLJITFinalizer.cpp:
        (JSC::FTL::JITFinalizer::finalizeFunction):
        * heap/CodeBlockSet.cpp:
        (JSC::CodeBlockSet::~CodeBlockSet):
        (JSC::CodeBlockSet::add):
        (JSC::CodeBlockSet::clearMarksForFullCollection):
        (JSC::CodeBlockSet::clearMarksForEdenCollection):
        (JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced):
        (JSC::CodeBlockSet::remove):
        (JSC::CodeBlockSet::traceMarked):
        (JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
        (JSC::CodeBlockSet::dump):
        * heap/CodeBlockSet.h:
        * heap/Heap.cpp:
        (JSC::Heap::markRoots):
        (JSC::Heap::clearLivenessData):
        (JSC::Heap::traceCodeBlocksAndJITStubRoutines):
        (JSC::Heap::deleteAllCodeBlocks):
        (JSC::Heap::deleteAllUnlinkedCodeBlocks):
        (JSC::Heap::clearUnmarkedExecutables):
        (JSC::Heap::willStartCollection):
        * interpreter/Interpreter.cpp:
        (JSC::eval):
        * jit/GCAwareJITStubRoutine.h:
        * jit/JITCode.h:
        (JSC::JITCode::isJIT):
        (JSC::JITCode::timeToLive):
        (JSC::JITCode::isLowerTier):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_enter):
        * jit/JITOperations.cpp:
        * jit/JITToDFGDeferredCompilationCallback.cpp:
        (JSC::JITToDFGDeferredCompilationCallback::create):
        (JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
        (JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):
        * jit/JITToDFGDeferredCompilationCallback.h:
        * jit/Repatch.cpp:
        (JSC::tryCacheGetByID):
        (JSC::tryCachePutByID):
        (JSC::tryRepatchIn):
        (JSC::linkFor):
        (JSC::linkPolymorphicCall):
        * llint/LLIntSlowPaths.cpp:
        (JSC::LLInt::LLINT_SLOW_PATH_DECL):
        (JSC::LLInt::setUpCall):
        * runtime/CommonSlowPaths.cpp:
        (JSC::SLOW_PATH_DECL):
        * runtime/CommonSlowPaths.h:
        (JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
        (JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):
        * runtime/Executable.cpp:
        (JSC::ExecutableBase::clearCode):
        (JSC::ScriptExecutable::installCode):
        (JSC::ScriptExecutable::newCodeBlockFor):
        (JSC::ScriptExecutable::newReplacementCodeBlockFor):
        (JSC::ScriptExecutable::prepareForExecutionImpl):
        (JSC::EvalExecutable::visitChildren):
        (JSC::EvalExecutable::clearCode):
        (JSC::ProgramExecutable::checkSyntax):
        (JSC::ProgramExecutable::visitChildren):
        (JSC::ProgramExecutable::clearCode):
        (JSC::ModuleProgramExecutable::visitChildren):
        (JSC::ModuleProgramExecutable::clearCode):
        (JSC::FunctionExecutable::baselineCodeBlockFor):
        (JSC::FunctionExecutable::visitChildren):
        (JSC::FunctionExecutable::clearCode):
        (JSC::FunctionExecutable::fromGlobalCode):
        (JSC::WebAssemblyExecutable::visitChildren):
        (JSC::WebAssemblyExecutable::clearCode):
        (JSC::WebAssemblyExecutable::prepareForExecution):
        * runtime/Executable.h:
        (JSC::ExecutableBase::generatedJITCodeForCall):
        (JSC::ScriptExecutable::prepareForExecution):
        (JSC::ExecutableBase::clearCodeVirtual):
        * runtime/VM.cpp:
        (JSC::VM::VM):
        * runtime/VM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Win] Unreviewed build fix for run-api-tests
bfulgham@apple.com [Fri, 2 Oct 2015 04:35:27 +0000 (04:35 +0000)]
[Win] Unreviewed build fix for run-api-tests

* Scripts/run-api-tests:
(testToolPaths): Windows run needs to specify the binary path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoConvert focused-input-should-assist-on-touch.html into an automated test
wenson_hsieh@apple.com [Fri, 2 Oct 2015 04:27:32 +0000 (04:27 +0000)]
Convert focused-input-should-assist-on-touch.html into an automated test
https://bugs.webkit.org/show_bug.cgi?id=149724

Reviewed by Simon Fraser.

.:

Remove a manual test that can now be rewritten as an automated test.

* ManualTests/ios/focused-input-should-assist-on-touch.html: Removed.

LayoutTests:

Tests that an input that focuses itself on touch and then prevents default is
able to trigger node assistance, even when it is already focused before the
user gesture.

* fast/events/ios/focused-input-should-assist-on-touch-expected.txt: Added.
* fast/events/ios/focused-input-should-assist-on-touch.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoCodeBlock should be a GC object
ggaren@apple.com [Fri, 2 Oct 2015 03:45:53 +0000 (03:45 +0000)]
CodeBlock should be a GC object
https://bugs.webkit.org/show_bug.cgi?id=149727

Reviewed by Filip Pizlo.

We want CodeBlock to be a GC object:

(1) Sane write barriers. Because CodeBlock wasn't a GC object, we couldn't
execute a write barrier on it. This caused us to do weird things that
were hard to reason about, like executing a barrier on a related executable
(even though the executable might stop pointing to the CodeBlock before
the next GC), or pretending that an object had written to itself. Now,
when we write to a CodeBlock, we barrier the CodeBlock, and that's that.

(2) Simpler marking and destruction logic. There's no need to have a
custom remembered set or a destruction fixpoint if we just obey normal
GC rules.

* bytecode/CodeBlock.cpp:
(JSC::FunctionCodeBlock::destroy):
(JSC::WebAssemblyCodeBlock::destroy):
(JSC::ProgramCodeBlock::destroy):
(JSC::ModuleProgramCodeBlock::destroy):
(JSC::EvalCodeBlock::destroy): Add ClassInfo and destroy functions
because our GC object model requires them.

Note that we do not set the needsDestruction flag. Since CodeBlock needs
eager destruction, it runs its destructors through CodeBlockSet,
and not through normal object sweeping.

(JSC::CodeBlock::finishCreation): Factor out finishCreation from the
constructor because our GC object model requires it. Change write
barriers to note the CodeBlock as the owner.

(JSC::CodeBlock::~CodeBlock): Refactor to use the shared
unlinkIncomingCalls() function instead of rolling a copy by hand.

(JSC::CodeBlock::visitWeakly): New helper function for owner executables
to do weak marking that might jettison a CodeBlock. Our new GC logic
says that a CodeBlock pointer is a strong reference by default, and
clients need to opt in if they want to allow a CodeBlock to jettison.
This is easier to get right because it means that only those
specific owners that want jettison behavior need to worry about it,
while all other pointers are valid by default.

(JSC::CodeBlock::visitChildren): The default visit function keeps
everything alive.

(JSC::CodeBlock::shouldVisitStrongly):
(JSC::CodeBlock::isKnownToBeLiveDuringGC): No need to keep special state
anymore. If we're marked, we're live -- just like any other object.

(JSC::timeToLive): Move this code into CodeBlock.cpp so you can mess
with it without recompiling, and also because it's really a CodeBlock
policy.

(JSC::CodeBlock::WeakReferenceHarvester::visitWeakReferences):
(JSC::CodeBlock::UnconditionalFinalizer::finalizeUnconditionally): Use
internal objects for virtual callbacks because GC objects can't have
vtables.

(JSC::CodeBlock::unlinkIncomingCalls): Remove a fast path check that does
not exist in the copy of this code in ~CodeBlock because it is not
actually an optimization.

(JSC::CodeBlock::replacement):
(JSC::CodeBlock::computeCapabilityLevel): Make these functions generic
instead of virtual because GC objects can't have vtables.

(JSC::CodeBlock::visitStrongly): Deleted.
(JSC::CodeBlock::visitAggregate): Deleted.
(JSC::CodeBlock::visitWeakReferences): Deleted.
(JSC::CodeBlock::finalizeUnconditionally): Deleted.
(JSC::ProgramCodeBlock::replacement): Deleted.
(JSC::ModuleProgramCodeBlock::replacement): Deleted.
(JSC::EvalCodeBlock::replacement): Deleted.
(JSC::FunctionCodeBlock::replacement): Deleted.
(JSC::ProgramCodeBlock::capabilityLevelInternal): Deleted.
(JSC::ModuleProgramCodeBlock::capabilityLevelInternal): Deleted.
(JSC::EvalCodeBlock::capabilityLevelInternal): Deleted.
(JSC::FunctionCodeBlock::capabilityLevelInternal): Deleted.
(JSC::WebAssemblyCodeBlock::replacement): Deleted.
(JSC::WebAssemblyCodeBlock::capabilityLevelInternal): Deleted.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::unlinkedCodeBlock):
(JSC::CodeBlock::addressOfNumParameters):
(JSC::CodeBlock::offsetOfNumParameters):
(JSC::CodeBlock::alternative):
(JSC::CodeBlock::forEachRelatedCodeBlock):
(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::hasBaselineJITProfiling):
(JSC::CodeBlock::capabilityLevelState):
(JSC::CodeBlock::addConstant):
(JSC::CodeBlock::appendExceptionHandler):
(JSC::CodeBlock::setConstantRegisters):
(JSC::CodeBlock::replaceConstant):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::create):
(JSC::ProgramCodeBlock::createStructure):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::ModuleProgramCodeBlock::create):
(JSC::ModuleProgramCodeBlock::createStructure):
(JSC::ModuleProgramCodeBlock::ModuleProgramCodeBlock):
(JSC::EvalCodeBlock::create):
(JSC::EvalCodeBlock::createStructure):
(JSC::EvalCodeBlock::variable):
(JSC::EvalCodeBlock::numVariables):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::EvalCodeBlock::unlinkedEvalCodeBlock):
(JSC::FunctionCodeBlock::create):
(JSC::FunctionCodeBlock::createStructure):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::WebAssemblyCodeBlock::create):
(JSC::WebAssemblyCodeBlock::createStructure):
(JSC::WebAssemblyCodeBlock::WebAssemblyCodeBlock):
(JSC::ExecState::uncheckedR):
(JSC::CodeBlock::clearVisitWeaklyHasBeenCalled):
(JSC::CodeBlockSet::mark):
(JSC::ScriptExecutable::forEachCodeBlock):
(JSC::CodeBlock::setAlternative): Deleted.
(JSC::CodeBlock::clearMarks): Deleted. Lots of mechanical changes to
match the logic changes above.

* bytecode/DeferredCompilationCallback.cpp:
(JSC::DeferredCompilationCallback::DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::~DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::compilationDidComplete):
* bytecode/DeferredCompilationCallback.h: Provide a profiledDFGCodeBlock
to all compilation callbacks instead of requiring the callback to
store the profiledDFGCodeBlock. This is how the rest of compilation
around the callback works anyway, and it is easier to do things this
way than to think about how a non-GC malloc'd object should keep its
CodeBlock alive.

* bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):
* bytecode/PolymorphicAccess.cpp:
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerate):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::addAccessCase): Change the owner for write
barrier purposes to CodeBlock.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGDesiredTransitions.cpp:
(JSC::DFG::DesiredTransition::reallyAdd):
* dfg/DFGDesiredWeakReferences.cpp:
(JSC::DFG::DesiredWeakReferences::reallyAdd):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph): Ditto.

* dfg/DFGJITCode.h:
(JSC::DFG::JITCode::osrEntryBlock):
(JSC::DFG::JITCode::setOSREntryBlock):
(JSC::DFG::JITCode::clearOSREntryBlock): Use helper functions for
accessing osrEntryBlock to help with write barrier stuff.

* dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):
(JSC::DFG::JITFinalizer::finalizeCommon):
* dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::adjustAndJumpToTarget): Use CodeBlock as owner instead of
executable.

* dfg/DFGOperations.cpp:
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::reallyAdd):
(JSC::DFG::Plan::notifyReady):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::finalizeAndNotifyCallback):
(JSC::DFG::Plan::key):
(JSC::DFG::Plan::rememberCodeBlocks):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
(JSC::DFG::Plan::clearCodeBlockMarks): Deleted.
* dfg/DFGPlan.h: Use normal GC write barrier concepts to model the fact
that the compiler writes to CodeBlocks.

* dfg/DFGToFTLDeferredCompilationCallback.cpp:
(JSC::DFG::ToFTLDeferredCompilationCallback::ToFTLDeferredCompilationCallback):
(JSC::DFG::ToFTLDeferredCompilationCallback::~ToFTLDeferredCompilationCallback):
(JSC::DFG::ToFTLDeferredCompilationCallback::create):
(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):
* dfg/DFGToFTLDeferredCompilationCallback.h:
* dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::ToFTLForOSREntryDeferredCompilationCallback):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::~ToFTLForOSREntryDeferredCompilationCallback):
(JSC::DFG::Ref<ToFTLForOSREntryDeferredCompilationCallback>ToFTLForOSREntryDeferredCompilationCallback::create):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):
* dfg/DFGToFTLForOSREntryDeferredCompilationCallback.h: We always have
a profiledDFGCodeBlock passed to use -- see above.

* dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::completeAllPlansForVM):
(JSC::DFG::Worklist::rememberCodeBlocks):
(JSC::DFG::completeAllPlansForVM):
(JSC::DFG::rememberCodeBlocks):
(JSC::DFG::Worklist::clearCodeBlockMarks): Deleted.
(JSC::DFG::clearCodeBlockMarks): Deleted.
* dfg/DFGWorklist.h:
(JSC::DFG::worklistForIndexOrNull): Renamed to use remembered set terminology.

* ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):

* heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::~CodeBlockSet):
(JSC::CodeBlockSet::add):
(JSC::CodeBlockSet::clearMarksForFullCollection):
(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced): No need for a fixpoint
anymore since the GC can tell us if we are live.

(JSC::CodeBlockSet::remove):
(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
(JSC::CodeBlockSet::dump):
(JSC::CodeBlockSet::clearMarksForEdenCollection): Deleted. No need for
this logic anymore since the GC will clear our mark bit.

(JSC::CodeBlockSet::traceMarked): Deleted. No need for this marking
fixpoint anymore either.

* heap/CodeBlockSet.h:

* heap/Heap.cpp:
(JSC::Heap::markRoots): Moved some of this logic around to make the
algorithm clearer.

(JSC::Heap::deleteAllCodeBlocks): Deleting CodeBlocks can only clear
pointers immediately; they won't fully delete until the next GC and sweep.

* interpreter/Interpreter.cpp:
(JSC::eval):
* jit/GCAwareJITStubRoutine.h: CodeBlock is owner now.

* jit/JITCode.h:
(JSC::JITCode::isJIT):
(JSC::JITCode::isLowerTier):
(JSC::JITCode::timeToLive): Deleted.

* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_enter): CodeBlock is owner now.

* jit/JITOperations.cpp:
* jit/JITToDFGDeferredCompilationCallback.cpp:
(JSC::JITToDFGDeferredCompilationCallback::create):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):
* jit/JITToDFGDeferredCompilationCallback.h:

* jit/Repatch.cpp:
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryRepatchIn):
(JSC::linkFor):
(JSC::linkPolymorphicCall):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::setUpCall):
* runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal): CodeBlock is owner now.

* runtime/Executable.cpp:
(JSC::ExecutableBase::clearCode): Provide a generic clearCode() so that
it can be used on any Executable. This fixes a very subtle bug where
deleteAllCode() does not remove CodeBlocks from non-function executables
that have been saved in stack traces.

(JSC::ScriptExecutable::installCode): WriteBarrier requires special
handling for pointers that may be null.

(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::newReplacementCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl): Update for interface
changes.

(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::ModuleProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
(JSC::WebAssemblyExecutable::visitChildren): Visit weakly because we want
to participate in jettisoning.

(JSC::WebAssemblyExecutable::prepareForExecution):
(JSC::EvalExecutable::clearCode): Deleted.
(JSC::ProgramExecutable::clearCode): Deleted.
(JSC::ModuleProgramExecutable::clearCode): Deleted.
(JSC::FunctionExecutable::clearCode): Deleted.
(JSC::WebAssemblyExecutable::clearCode): Deleted.

* runtime/Executable.h:
(JSC::ExecutableBase::generatedJITCodeForCall):
(JSC::ScriptExecutable::prepareForExecution):
(JSC::ExecutableBase::clearCodeVirtual): Deleted.

* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h: Provide structures because our GC requires it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRollout r190446 for the moment. It broke the build.
dino@apple.com [Fri, 2 Oct 2015 02:15:11 +0000 (02:15 +0000)]
Rollout r190446 for the moment. It broke the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Simplify filterableData processing
commit-queue@webkit.org [Fri, 2 Oct 2015 01:53:45 +0000 (01:53 +0000)]
Web Inspector: Simplify filterableData processing
https://bugs.webkit.org/show_bug.cgi?id=149730

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-01
Reviewed by Timothy Hatcher.

* UserInterface/Views/BreakpointTreeElement.js:
(WebInspector.BreakpointTreeElement.prototype.get filterableData):
* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.matchTextFilter):
* UserInterface/Views/ResourceTreeElement.js:
(WebInspector.ResourceTreeElement.prototype.get filterableData):
* UserInterface/Views/ScriptTimelineView.js:
(WebInspector.ScriptTimelineView.prototype.matchTreeElementAgainstCustomFilters): Deleted.
* UserInterface/Views/SearchResultTreeElement.js:
(WebInspector.SearchResultTreeElement.prototype.get filterableData):
(WebInspector.SearchResultTreeElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, fix build warning after r190434
ljaehun.lim@samsung.com [Fri, 2 Oct 2015 01:29:52 +0000 (01:29 +0000)]
Unreviewed, fix build warning after r190434

Fix error: variable ‘interruption’ set but not used [-Werror=unused-but-set-variable]

* testing/Internals.cpp:
(WebCore::Internals::beginMediaSessionInterruption):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoExpose WEBGL_debug_renderer_info
dino@apple.com [Fri, 2 Oct 2015 01:09:42 +0000 (01:09 +0000)]
Expose WEBGL_debug_renderer_info
https://bugs.webkit.org/show_bug.cgi?id=149735
<rdar://problem/18343500>

Reviewed by Simon Fraser.

Source/WebCore:

Enable the extension that allows content to query
for the GPUs vendor and details.

Now that we're enabling this, there was no need for
the internal setting that identified privileged situations.
However, since this meant that WEBGL_debug_shaders was
also exposed, I explicitly disable it since it is
not yet conformant.

Test: fast/canvas/webgl/webgl-debug-renderer-info.html
as well as the general conformance suite.

* html/canvas/WebGL2RenderingContext.cpp: No need to guard around allowPrivilegedExtensions().
(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
* html/canvas/WebGLRenderingContext.cpp: Ditto.
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
* html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::allowPrivilegedExtensions): Deleted.
* html/canvas/WebGLRenderingContextBase.h:
* page/Settings.in: Remove privilegedWebGLExtensions.
* platform/graphics/opengl/Extensions3DOpenGL.cpp: Forbid the translated shader
extension while it is still buggy.
(WebCore::Extensions3DOpenGL::supportsExtension):

LayoutTests:

Modify a test from the 1.0.2 conformance suite to make sure
we're actually enabling and passing the info.

* fast/canvas/webgl/webgl-debug-renderer-info-expected.txt: Added.
* fast/canvas/webgl/webgl-debug-renderer-info.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRebaselining fast/text/mark-matches-overflow-clip.html for Win
commit-queue@webkit.org [Fri, 2 Oct 2015 00:21:28 +0000 (00:21 +0000)]
Rebaselining fast/text/mark-matches-overflow-clip.html for Win
https://webkit.org/b/149728

Unreviewed test gardening.

Patch by Ryan Haddad <ryanhaddad@apple.com> on 2015-10-01

* platform/win/fast/text/mark-matches-overflow-clip-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago.:
bfulgham@apple.com [Fri, 2 Oct 2015 00:09:42 +0000 (00:09 +0000)]
.:
[Win] Unreviewed CMake build fix.

* Source/cmake/OptionsWin.cmake: Clean up options setttings,
and make sure exception handling is turned off.

Tools:
Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

Following r190424 we can now rely on webkit-build-directory to return the path to
the correct configuration-specific build directory on Windows.

Patch by Daniel Bates <dabates@apple.com> on 2015-10-01

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAnother attempt to fix the Windows builders after <https://trac.webkit.org/changeset...
dbates@webkit.org [Fri, 2 Oct 2015 00:03:58 +0000 (00:03 +0000)]
Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

Following r190424 we can now rely on webkit-build-directory to return the path to
the correct configuration-specific build directory on Windows.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed test fix after r190434.
bfulgham@apple.com [Thu, 1 Oct 2015 23:43:06 +0000 (23:43 +0000)]
Unreviewed test fix after r190434.

One test was not updated to pass the new required interruption type
argument to 'internals.beginMediaSessionInterruption'.

* webaudio/audiocontext-state-interrupted-expected.txt:
* webaudio/audiocontext-state-interrupted.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Do not immediately create all ProfileNodeTreeElements when showing...
commit-queue@webkit.org [Thu, 1 Oct 2015 23:34:09 +0000 (23:34 +0000)]
Web Inspector: Do not immediately create all ProfileNodeTreeElements when showing JavaScript and Events timeline
https://bugs.webkit.org/show_bug.cgi?id=149726

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-10-01
Reviewed by Timothy Hatcher.

* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.shouldFilterPopulate):
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
We were populating during filtering if there were any custom filters.
However the TimelineSidebarPanel has custom filters (based on time and type)
but those don't need to trigger population. Delay population until it
would actually be needed (like a text search).

* UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.shouldFilterPopulate):
Do not populate on filter via this custom filters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: REGRESSION (r189567): Toolbar collapses when inspector at minimum...
mattbaker@apple.com [Thu, 1 Oct 2015 23:33:06 +0000 (23:33 +0000)]
Web Inspector: REGRESSION (r189567): Toolbar collapses when inspector at minimum height with console open
https://bugs.webkit.org/show_bug.cgi?id=149725

Reviewed by Timothy Hatcher.

CSS Flexible Box Layout Module Level 1 introduces a new `auto` initial value for the min-{width|height}
of flex box items, breaking some areas of the inspector UI. This is fixed by setting a min-height of
zero for the #main <div>.

* UserInterface/Views/Main.css:
(#main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove unnecessary SpecialFastCaseProfiles.
mark.lam@apple.com [Thu, 1 Oct 2015 23:21:39 +0000 (23:21 +0000)]
Remove unnecessary SpecialFastCaseProfiles.
https://bugs.webkit.org/show_bug.cgi?id=149729

Reviewed by Saam Barati.

The current baseline code creates special fast case profiles records for
bytecodes that don't need them.  This was done to keep the DFG from crashing when
it searches for such a profile and don't find one.  Instead, we will fix the code
to check for the existence of the profile before dereferencing it to get a count.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::numberOfArrayProfiles):
(JSC::CodeBlock::arrayProfiles):
(JSC::CodeBlock::addArrayProfile):
(JSC::CodeBlock::likelyToTakeSpecialFastCase): Deleted.  Not used.
(JSC::CodeBlock::likelyToTakeAnySlowCase): Deleted.   Not used.
* jit/JITArithmetic.cpp:

(JSC::JIT::compileBinaryArithOp):
- Only op_mul needs the profile.  So, only allocate it in the op_mul case.

(JSC::JIT::emit_op_mul):
- These op_mul cases create the profile but never increments its counter.
  Hence, we can get rid of these.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[iOS] AirPlay should not stop when the screen locks
bfulgham@apple.com [Thu, 1 Oct 2015 22:32:56 +0000 (22:32 +0000)]
[iOS] AirPlay should not stop when the screen locks
https://bugs.webkit.org/show_bug.cgi?id=148315
<rdar://problem/22770703>

Patch by Eric Carlson <eric.carlson@apple.com> on 2015-10-01
Reviewed by Jer Noble.

Source/WebCore:

Tested by media/video-interruption-with-resume-allowing-play.html
          media/video-interruption-with-resume-not-allowing-play.html

* Modules/webaudio/AudioContext.h: overrideBackgroundPlaybackRestriction ->
  shouldOverrideBackgroundPlaybackRestriction.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::suspendPlayback): Fix a typo in the logging.
(WebCore::HTMLMediaElement::mayResumePlayback): Ditto.
(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction): Renamed from
  overrideBackgroundPlaybackRestriction.
(WebCore::HTMLMediaElement::overrideBackgroundPlaybackRestriction): Deleted.
* html/HTMLMediaElement.h:

* platform/audio/PlatformMediaSession.cpp:
(WebCore::stateName):
(WebCore::interruptionName): New, log the name of the interruption.
(WebCore::PlatformMediaSession::beginInterruption): Log the interruption type. Don't
  increment the interruption counter if we are going to ignore it. Incorporate logic
  from doInterruption.
(WebCore::PlatformMediaSession::doInterruption): Deleted.
(WebCore::PlatformMediaSession::shouldDoInterruption): Deleted.
(WebCore::PlatformMediaSession::forceInterruption): Deleted.

* platform/audio/PlatformMediaSession.h: Add SuspendedUnderLock interruption type.
* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground): Deleted.
* platform/audio/PlatformMediaSessionManager.h:

* platform/audio/ios/MediaSessionManagerIOS.h:
* platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::applicationDidEnterBackground): Call beginInterruption
  when appropriate.

LayoutTests:

* media/video-interruption-with-resume-allowing-play.html:
* media/video-interruption-with-resume-not-allowing-play.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSlot elements should support fallback contents
rniwa@webkit.org [Thu, 1 Oct 2015 20:36:34 +0000 (20:36 +0000)]
Slot elements should support fallback contents
https://bugs.webkit.org/show_bug.cgi?id=149701

Reviewed by Antti Koivisto.

Source/WebCore:

Following discussions on Github discussions [1] [2], we're adding the default rule of `display: contents`
on slot elements and making slot elements render its children when there are no assigned nodes [3].

Make these changes by attaching renderers on direct-children of slot elements when there are no assigned
nodes during render tree construction. Note `display: contents` will be aded in webkit.org/b/149439.

[1] https://github.com/w3c/webcomponents/issues/317
[2] https://github.com/w3c/webcomponents/issues/308
[3] https://github.com/w3c/webcomponents/issues/308#issuecomment-143655347

Tests: fast/shadow-dom/css-scoping-shadow-slot-fallback.html
       fast/shadow-dom/shadow-layout-after-slot-fallback-changes.html

* style/StyleResolveTree.cpp:
(WebCore::Style::attachSlotAssignees):
(WebCore::Style::detachSlotAssignees):
(WebCore::Style::resolveSlotAssignees):

LayoutTests:

Added tests for fallback contents in slot elements. One of them could be safely submitted to CSS WG,
and the other one is a style recalc test.

* fast/shadow-dom/css-scoping-shadow-slot-fallback-expected.html: Added.
* fast/shadow-dom/css-scoping-shadow-slot-fallback.html: Added.
* fast/shadow-dom/shadow-layout-after-slot-fallback-changes-expected.html: Added.
* fast/shadow-dom/shadow-layout-after-slot-fallback-changes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[ES6] Add TypedArray.prototype functionality.
keith_miller@apple.com [Thu, 1 Oct 2015 20:20:10 +0000 (20:20 +0000)]
[ES6] Add TypedArray.prototype functionality.
https://bugs.webkit.org/show_bug.cgi?id=148035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patch should add most of the functionality for
the prototype properties of TypedArray objects in ES6.
There are a few exceptions to this, which will be added
in upcoming patches:

1) First we do not use the species constructor for some
of the TypedArray prototype functions (namely: map, filter,
slice, and subarray). That will need to be added when
species constructors are finished.

2) TypedArrays still have a length, byteOffset, byteLength,
and buffer are still attached to the TypedArray instance (in
the spec they are on the TypedArray.prototype instance object)
since the JIT currently assumes those properties are fixed.

3) The TypedArray.constructor property is not added yet
as it should point to the TypedArray instance object,
which will be added in a future patch.

* CMakeLists.txt:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* builtins/TypedArray.prototype.js: Added.
(every):
(find):
(findIndex):
(forEach):
(some):
(sort.min):
(sort.merge):
(sort.mergeSort):
(sort):
(reduce):
(reduceRight):
(map):
(filter):
(toLocaleString):
* runtime/ArrayPrototype.cpp:
* runtime/ArrayPrototype.h:
* runtime/CommonIdentifiers.h:
* runtime/JSGenericTypedArrayView.h:
(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValue):
(JSC::JSGenericTypedArrayView::setRangeToValue):
(JSC::JSGenericTypedArrayView::sort):
(JSC::JSGenericTypedArrayView::purifyArray):
(JSC::JSGenericTypedArrayView::sortComparison):
(JSC::JSGenericTypedArrayView::sortFloat):
* runtime/JSGenericTypedArrayViewInlines.h:
* runtime/JSGenericTypedArrayViewPrototypeFunctions.h: Added.
(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncEntries):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncKeys):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoGetterFuncLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteOffset):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncValues):
* runtime/JSGenericTypedArrayViewPrototypeInlines.h:
(JSC::JSGenericTypedArrayViewPrototype<ViewClass>::finishCreation):
(JSC::genericTypedArrayViewProtoFuncSet): Deleted.
(JSC::genericTypedArrayViewProtoFuncSubarray): Deleted.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* runtime/JSObject.h:
* runtime/JSTypedArrayPrototypes.cpp:
* runtime/JSTypedArrayPrototypes.h:
* runtime/JSTypedArrayViewPrototype.cpp: Added.
(JSC::typedArrayViewPrivateFuncLength):
(JSC::typedArrayViewPrivateFuncSort):
(JSC::typedArrayViewProtoFuncSet):
(JSC::typedArrayViewProtoFuncEntries):
(JSC::typedArrayViewProtoFuncCopyWithin):
(JSC::typedArrayViewProtoFuncFill):
(JSC::typedArrayViewProtoFuncLastIndexOf):
(JSC::typedArrayViewProtoFuncIndexOf):
(JSC::typedArrayViewProtoFuncJoin):
(JSC::typedArrayViewProtoFuncKeys):
(JSC::typedArrayViewProtoGetterFuncLength):
(JSC::typedArrayViewProtoGetterFuncByteLength):
(JSC::typedArrayViewProtoGetterFuncByteOffset):
(JSC::typedArrayViewProtoFuncReverse):
(JSC::typedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncSlice):
(JSC::typedArrayViewProtoFuncValues):
(JSC::JSTypedArrayViewPrototype::JSTypedArrayViewPrototype):
(JSC::JSTypedArrayViewPrototype::finishCreation):
(JSC::JSTypedArrayViewPrototype::create):
(JSC::JSTypedArrayViewPrototype::createStructure):
* runtime/JSTypedArrayViewPrototype.h: Copied from Source/JavaScriptCore/runtime/JSTypedArrayPrototypes.cpp.
* tests/es6.yaml:
* tests/stress/resources/standalone-pre.js: Added.
(description):
(debug):
(escapeString):
(testPassed):
(testFailed):
(areNumbersEqual):
(areArraysEqual):
(isMinusZero):
(isTypedArray):
(isResultCorrect):
(stringify):
(shouldBe):
(dfgShouldBe):
(shouldBeType):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldBeUndefined):
(shouldNotThrow):
(shouldThrow):
(dfgCompiled):
(dfgIncrement):
(noInline):
(finishJSTest):
* tests/stress/resources/typedarray-test-helper-functions.js: Added.
(forEachTypedArray):
(isSameFunctionForEachTypedArrayPrototype.eq):
(isSameFunctionForEachTypedArrayPrototype):
(hasSameValues):
(foo):
(testPrototypeFunctionHelper):
(testPrototypeFunctionOnSigned):
(testPrototypeFunctionOnFloat):
(testPrototypeFunction):
(tester):
(testPrototypeReceivesArray):
* tests/stress/typedarray-copyWithin.js: Added.
* tests/stress/typedarray-every.js: Added.
(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-fill.js: Added.
* tests/stress/typedarray-filter.js: Added.
(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-find.js: Added.
(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-findIndex.js: Added.
(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-forEach.js: Added.
(checkCorrect.let.list):
(checkCorrect):
(createChecker):
(foo):
(changeArray):
(isBigEnoughAndException):
* tests/stress/typedarray-indexOf.js: Added.
(keepEven):
* tests/stress/typedarray-lastIndexOf.js: Added.
* tests/stress/typedarray-map.js: Added.
(even):
(evenAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-reduce.js: Added.
(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-reduceRight.js: Added.
(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-slice.js: Added.
* tests/stress/typedarray-some.js: Added.
(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):
* tests/stress/typedarray-sort.js: Added.
(sortBackwards):
(compareException):

LayoutTests:

Fixed tests for new toString behavior on TypedArrays.

* fast/canvas/webgl/type-conversion-test-expected.txt:
* fast/dom/Window/window-postmessage-clone-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Win] Fix TestWebKitAPI build under CMake.
bfulgham@apple.com [Thu, 1 Oct 2015 20:18:10 +0000 (20:18 +0000)]
[Win] Fix TestWebKitAPI build under CMake.

Reviewed by Alex Christensen.

* TestWebKitAPI/PlatformWin.cmake: Add missing link command
for Psapi.lib.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Clip string previews
nvasilyev@apple.com [Thu, 1 Oct 2015 19:54:15 +0000 (19:54 +0000)]
Web Inspector: Clip string previews
https://bugs.webkit.org/show_bug.cgi?id=149708

Only show first 140 characters in strings previews.

Reviewed by Joseph Pecoraro.

* UserInterface/Base/Utilities.js:
(String.prototype.truncate): Added.
A smart trancate function that doesn't split words.

* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._shouldConsiderObjectLossless):
* UserInterface/Views/FormattedValue.js:
(WebInspector.FormattedValue.createElementForTypesAndValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Win] Another CMake build fix
bfulgham@apple.com [Thu, 1 Oct 2015 19:50:10 +0000 (19:50 +0000)]
[Win] Another CMake build fix

* PlatformWin.cmake: Add missing Psapi.lib to link list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Win] Fix behavior of webkit-build-directory script
bfulgham@apple.com [Thu, 1 Oct 2015 19:38:49 +0000 (19:38 +0000)]
[Win] Fix behavior of webkit-build-directory script
https://bugs.webkit.org/show_bug.cgi?id=149718

Reviewed by Alex Christensen.

* Scripts/webkitdirs.pm:
(determineConfigurationProductDir): Do not include the binary
sub-directory in the configuration product directory output.
(jscProductDir): Append correct binary path for Windows build.
(setPathForRunningWebKitApp): Include properly binary subdirectories.
(runSafari): Update for revised productDir behavior.
(runMiniBrowser): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoLatch does not clear when a scroll snap animation is triggered
bfulgham@apple.com [Thu, 1 Oct 2015 19:31:22 +0000 (19:31 +0000)]
Latch does not clear when a scroll snap animation is triggered
https://bugs.webkit.org/show_bug.cgi?id=149681
<rdar://problem/22733922>

Reviewed by Simon Fraser.

Source/WebCore:

Test: tiled-drawing/scrolling/latched-div-with-scroll-snap.html

The scroll snap animation logic bypasses some of the normal clean-up code used
for wheel event handling. When this happens, the scroll latching state is not
cleared. In some cases this "stale" latch state is used when starting a new
gesture in the same frame. This causes the wrong page element to receive the
mouse wheel events, and hilarity ensues.

* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformNotifyIfEndGesture): Clear latched state when
ending the gesture.

LayoutTests:

Add a new test that confirms latched state is cleared when scroll snap animations
are triggered.

* tiled-drawing/scrolling/latched-div-with-scroll-snap-expected.txt: Added.
* tiled-drawing/scrolling/latched-div-with-scroll-snap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove some tests that now pass.
simon.fraser@apple.com [Thu, 1 Oct 2015 19:12:51 +0000 (19:12 +0000)]
Remove some tests that now pass.

* TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Win] Unreviewed CMake build fixes.
bfulgham@apple.com [Thu, 1 Oct 2015 18:47:58 +0000 (18:47 +0000)]
[Win] Unreviewed CMake build fixes.

Source/WebCore:

* CMakeLists.txt: Match original Windows build flags for WebCoreTest.
* PlatformAppleWin.cmake: Use the same build defines as the
original Windows build.

Source/WebKit:

* CMakeLists.txt: Set the same build definitions as the original
project file.
* PlatformWin.cmake: Remove some soft-linked files from the static
link commands. Set build flags to match original project files.

Source/WTF:

* wtf/CMakeLists.txt: Correct build flags to match
the original project files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd iOS touch event test
simon.fraser@apple.com [Thu, 1 Oct 2015 18:26:42 +0000 (18:26 +0000)]
Add iOS touch event test
https://bugs.webkit.org/show_bug.cgi?id=149688

Reviewed by Ryosuke Niwa.

Basic touch event test that synthesizes touches in the UI process.

* TestExpectations:
* fast/events/touch/ios/touch-event-expected.txt: Added.
* fast/events/touch/ios/touch-event.html: Added.
* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoStop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
ap@apple.com [Thu, 1 Oct 2015 18:14:19 +0000 (18:14 +0000)]
Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
use iOS SDK, like with all the others.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoNetwork cache: Subresource referer header wrong after cached redirect
antti@apple.com [Thu, 1 Oct 2015 18:09:07 +0000 (18:09 +0000)]
Network cache: Subresource referer header wrong after cached redirect
https://bugs.webkit.org/show_bug.cgi?id=149709
rdar://problem/22917174

Reviewed by Chris Dumez.

Source/WebKit2:

If a main resource is loaded from a cache entry that involved redirects the document
will end up setting the Referer-headers of the subresources to the request URL not the redirected URL

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):

    If a cache entry involved a redirect synthesize a minimal willSendRequest message so that WebCore side
    runs through the same code paths as when receiving a redirect from network.

LayoutTests:

* http/tests/cache/redirect-referer-expected.html: Added.
* http/tests/cache/redirect-referer.html: Added.
* http/tests/cache/resources/load-and-check-referer.php: Added.
* http/tests/cache/resources/permanent-redirect.php: Added.
* http/tests/cache/resources/redirect-referer-iframe.html: Added.
* http/tests/cache/resources/redirect-referer-iframe-expected.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoaccessibility/mac/aria-expanded-notifications.html is flaky
mmaxfield@apple.com [Thu, 1 Oct 2015 17:45:59 +0000 (17:45 +0000)]
accessibility/mac/aria-expanded-notifications.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=149510

Reviewed by Chris Fleizach.

The problem is triggered by our resumable parser. AXLoadComplete gets called
synchronously from DocumentLoader::finishedLoading(). This means that the order of
the AXLoadComplete message isn't FIFO.

If the parser yielded previously, the AXLoadComplete will be handled after some AX
messages had been handled.

If the parser hadn't yielded, the AXLoadComplete will be the first message
processed (no matter what had been queued up before it).

Because making the AXLoadComplete message asynchonous is not desirable, the
solution is to relax the test to handle various orderings.

* accessibility/mac/aria-expanded-notifications-expected.txt:
* accessibility/mac/aria-expanded-notifications.html:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Adjust font size of Developer Tools using Command,+ or Command,-
bburg@apple.com [Thu, 1 Oct 2015 17:42:21 +0000 (17:42 +0000)]
Web Inspector: Adjust font size of Developer Tools using Command,+ or Command,-
https://bugs.webkit.org/show_bug.cgi?id=149590

Patch by João Oliveira <hello@jxs.pt> on 2015-09-30
Reviewed by Joseph Pecoraro.

Patch by João Oliveira and Brian Burg.

Source/WebCore:

Expose the frontend page's zoom factor so we can implement relative zoom.

* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::zoomFactor): Added.
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
* page/Frame.h:
(WebCore::Frame::pageZoomFactor):

Source/WebInspectorUI:

* UserInterface/Base/Main.js:
(WebInspector.contentLoaded): Add global keyboard shortcuts for zoom in and zoom out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAttempt to fix the iOS 9 Simulator testers
dbates@webkit.org [Thu, 1 Oct 2015 17:38:21 +0000 (17:38 +0000)]
Attempt to fix the iOS 9 Simulator testers

Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
LayoutTestRelay when building for iOS Simulator.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoIntroduce SymbolUse optimization into CompareEq and CompareStrictEq
utatane.tea@gmail.com [Thu, 1 Oct 2015 17:20:44 +0000 (17:20 +0000)]
Introduce SymbolUse optimization into CompareEq and CompareStrictEq
https://bugs.webkit.org/show_bug.cgi?id=149616

Reviewed by Saam Barati.

Since ES6 Symbols are used as an enum value[1] (And WebKit inspector do so for Esprima's type of nodes),
optimizing equality comparison for symbols makes much sense.

This patch leverages SymbolUse for CompareEq and CompareStrictEq.
Optimizations for both DFG and FTL are implemented.

[1]: http://www.2ality.com/2014/12/es6-symbols.html

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateSymbol):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::extractStringImplFromBinarySymbols):
(JSC::DFG::SpeculativeJIT::compileSymbolEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleSymbolEquality):
* dfg/DFGSpeculativeJIT.h:
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCompareStrictEq):
* tests/stress/symbol-equality.js: Added.
(shouldBe):
(equal):
(strictEqual):
(list.forEach.result.set 1):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Websites with invalid auth header keep loading forever
carlosgc@webkit.org [Thu, 1 Oct 2015 17:18:28 +0000 (17:18 +0000)]
[GTK] Websites with invalid auth header keep loading forever
https://bugs.webkit.org/show_bug.cgi?id=149710

Reviewed by Martin Robinson.

Source/WebCore:

We don't correctly handle a null realm from the server when
retrieving and storing credentials from libsecret. First
secret_attributes_build() fails because we pass a null domain, and
we pass null attributes to secret_service_search() that returns
early on a g_return macro and the callback is never called so the
load doesn't continue after the auth challenge.

* platform/network/gtk/CredentialBackingStore.cpp:
(WebCore::createAttributeHashTableFromChallenge):
(WebCore::CredentialBackingStore::credentialForChallenge):
(WebCore::CredentialBackingStore::storeCredentialsForChallenge):

Source/WebKit2:

Do not show the remember credentials checkbutton in the auth
dialog if the realm is empty.

* UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:
(webkitAuthenticationDialogInitialize):

Tools:

Add test case to check that we can authenticate sites with an
empty realm.

* TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
(testWebViewAuthenticationEmptyRealm):
(serverCallback):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Mac] Make run-api-tests work with System Integrity Protection
ap@apple.com [Thu, 1 Oct 2015 17:16:40 +0000 (17:16 +0000)]
[Mac] Make run-api-tests work with System Integrity Protection
https://bugs.webkit.org/show_bug.cgi?id=149711
rdar://problem/22928202

Reviewed by Dan Bernstein.

* Scripts/run-api-tests:
(runTest):
(archCommandLineArgumentsForRestrictedEnvironmentVariables):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAttempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
dbates@webkit.org [Thu, 1 Oct 2015 17:10:30 +0000 (17:10 +0000)]
Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
For now, use the path to the top-level WebKit build directory instead of using the configuration-
specific build directory.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMove <a ping> tests from LayoutTests/http/tests/navigation to LayoutTests/http/tests...
dbates@webkit.org [Thu, 1 Oct 2015 16:43:34 +0000 (16:43 +0000)]
Move <a ping> tests from LayoutTests/http/tests/navigation to LayoutTests/http/tests/navigation/ping-attribute
https://bugs.webkit.org/show_bug.cgi?id=148828

Reviewed by Alexey Proskuryakov.

Towards adding <area ping> tests (bug #79438), we should move the existing <a ping> tests from
LayoutTests/http/tests/navigation to LayoutTests/http/tests/navigation/ping-attribute and rename
them so as to make it clear from their name that they test the ping attribute on a HTML a element.

* http/tests/navigation/ping-attribute/anchor-cookie-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-cookie-expected.txt.
* http/tests/navigation/ping-attribute/anchor-cookie.html: Renamed from LayoutTests/http/tests/navigation/ping-cookie.html.
* http/tests/navigation/ping-attribute/anchor-cross-origin-expected.txt: Added.
* http/tests/navigation/ping-attribute/anchor-cross-origin-from-https-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin-from-https-expected.txt.
* http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin-from-https.html.
* http/tests/navigation/ping-attribute/anchor-cross-origin.html: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin.html.
* http/tests/navigation/ping-attribute/anchor-same-origin-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-same-origin-expected.txt.
* http/tests/navigation/ping-attribute/anchor-same-origin.html: Renamed from LayoutTests/http/tests/navigation/ping-same-origin.html.
* http/tests/navigation/ping-attribute/resources/check-ping.php: Added.
* http/tests/navigation/ping-attribute/resources/delete-ping.php: Added.
* http/tests/navigation/ping-attribute/resources/ping-file-path.php: Added.
* http/tests/navigation/ping-attribute/resources/save-Ping.php: Added.
* http/tests/navigation/ping-cross-origin-expected.txt: Removed.
* platform/ios-simulator-wk2/TestExpectations: Updated as needed for the above file renames.
* platform/win/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
ossy@webkit.org [Thu, 1 Oct 2015 15:39:03 +0000 (15:39 +0000)]
[EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
https://bugs.webkit.org/show_bug.cgi?id=145837

Reviewed by Philippe Normand.

* efl/jhbuild.modules:
* efl/patches/openwebrtc-clang-warning-fix.patch: Added.
* efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed. Fix the iOS build after r190407.
wenson_hsieh@apple.com [Thu, 1 Oct 2015 15:18:03 +0000 (15:18 +0000)]
Unreviewed. Fix the iOS build after r190407.

* WebKitTestRunner/ios/IOKitSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoImplement keyboard event sending for iOS in WebKitTestRunner
wenson_hsieh@apple.com [Thu, 1 Oct 2015 14:28:38 +0000 (14:28 +0000)]
Implement keyboard event sending for iOS in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=149676

Reviewed by Simon Fraser.

Tools:

Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
allows us to run code when the keyboard is shown or hidden.

* WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
* WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::setDidShowKeyboardCallback):
(WTR::UIScriptController::didShowKeyboardCallback):
(WTR::UIScriptController::setDidHideKeyboardCallback):
(WTR::UIScriptController::didHideKeyboardCallback):
(WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
(WTR::UIScriptController::platformSetDidShowKeyboardCallback):
(WTR::UIScriptController::platformSetDidHideKeyboardCallback):
* WebKitTestRunner/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
* WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
        the notifications that the keyboard has been raised or lowered.
(-[TestRunnerWKWebView _keyboardDidShow:]):
(-[TestRunnerWKWebView _keyboardDidHide:]):
* WebKitTestRunner/ios/HIDEventGenerator.h:
* WebKitTestRunner/ios/HIDEventGenerator.m:
(-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
(shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
(hidUsageCodeForCharacter): Ditto.
(-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
        a keyDown event in WebKit.
* WebKitTestRunner/ios/IOKitSPI.h:
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:

LayoutTests:

Adds a new basic test for the oninput event listener when typing in a text field.

* fast/events/ios/input-value-after-oninput-expected.txt: Added.
* fast/events/ios/input-value-after-oninput.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling out r190399.
carlosgc@webkit.org [Thu, 1 Oct 2015 13:38:46 +0000 (13:38 +0000)]
Unreviewed, rolling out r190399.

Tests are still failing even after r190362

Reverted changeset:

"Unreviewed. Unskip GTK+ user media unit tests after r190362."
http://trac.webkit.org/changeset/190399

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Web Inspector: Add GTK+ icons for the numerical input and slider based Visual...
agomez@igalia.com [Thu, 1 Oct 2015 13:38:41 +0000 (13:38 +0000)]
[GTK] Web Inspector: Add GTK+ icons for the numerical input and slider based Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147847

Reviewed by Carlos Garcia Campos.

* UserInterface/Images/gtk/VisualStylePropertyLinked.svg: Added.
* UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Web Inspector: Add GTK+ icons for the different types of non-numerical Visual...
agomez@igalia.com [Thu, 1 Oct 2015 13:36:00 +0000 (13:36 +0000)]
[GTK] Web Inspector: Add GTK+ icons for the different types of non-numerical Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147846

Reviewed by Carlos Garcia Campos.

* UserInterface/Images/gtk/AUTHORS: Updated.
* UserInterface/Images/gtk/ClearBoth.svg: Added.
* UserInterface/Images/gtk/ClearLeft.svg: Added.
* UserInterface/Images/gtk/ClearRight.svg: Added.
* UserInterface/Images/gtk/CubicBezier.svg: Updated.
* UserInterface/Images/gtk/FloatLeft.svg: Added.
* UserInterface/Images/gtk/FloatRight.svg: Added.
* UserInterface/Images/gtk/FontStyleItalic.svg: Added.
* UserInterface/Images/gtk/FontStyleNormal.svg: Added.
* UserInterface/Images/gtk/FontVariantSmallCaps.svg: Added.
* UserInterface/Images/gtk/TextAlignCenter.svg: Added.
* UserInterface/Images/gtk/TextAlignJustify.svg: Added.
* UserInterface/Images/gtk/TextAlignLeft.svg: Added.
* UserInterface/Images/gtk/TextAlignRight.svg: Added.
* UserInterface/Images/gtk/TextDecorationLineThrough.svg: Added.
* UserInterface/Images/gtk/TextDecorationOverline.svg: Added.
* UserInterface/Images/gtk/TextDecorationUnderline.svg: Added.
* UserInterface/Images/gtk/TextTransformCapitalize.svg: Added.
* UserInterface/Images/gtk/TextTransformLowercase.svg: Added.
* UserInterface/Images/gtk/TextTransformUppercase.svg: Added.
* UserInterface/Images/gtk/VisualStyleNone.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRefactor binding generator to factor JS DOM class m_impl handling
youenn.fablet@crf.canon.fr [Thu, 1 Oct 2015 13:07:55 +0000 (13:07 +0000)]
Refactor binding generator to factor JS DOM class m_impl handling
https://bugs.webkit.org/show_bug.cgi?id=149660

Reviewed by Darin Adler.

Added JSDOMWrapperWithImplementation template class to move m_impl out of the binding generator.
Updated custom bindings to use impl() instead of m_impl directly.
Updated binding generator accordingly.

Covered by existing tests and binding tests.

* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):
* bindings/js/JSDOMWrapper.h:
(WebCore::JSDOMWrapperWithImplementation::impl):
(WebCore::JSDOMWrapperWithImplementation::~JSDOMWrapperWithImplementation):
(WebCore::JSDOMWrapperWithImplementation::JSDOMWrapperWithImplementation):
(WebCore::JSDOMWrapperWithImplementation::releaseImpl):
* bindings/js/JSGeolocationCustom.cpp:
(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):
* bindings/js/JSSQLResultSetRowListCustom.cpp:
(WebCore::JSSQLResultSetRowList::item):
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
* bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):
* bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):
* bindings/scripts/CodeGeneratorJS.pm:
(GetParentClassName):
(GetImplClassName):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObject::JSTestActiveDOMObject):
(WebCore::JSTestActiveDOMObject::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::JSTestActiveDOMObject::~JSTestActiveDOMObject):
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor): Deleted.
* bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::~JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(WebCore::JSTestCustomNamedGetter::~JSTestCustomNamedGetter):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::jsTestEventConstructorAttr1): Deleted.
* bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::JSTestEventConstructor::~JSTestEventConstructor):
(WebCore::JSTestEventConstructor::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::JSTestEventTarget):
(WebCore::JSTestEventTarget::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTarget::~JSTestEventTarget):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestException::JSTestException):
(WebCore::JSTestException::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestException.h:
(WebCore::JSTestException::~JSTestException):
* bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachable::JSTestGenerateIsReachable):
(WebCore::jsTestGenerateIsReachableConstructor): Deleted.
* bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
(WebCore::JSTestGenerateIsReachable::~JSTestGenerateIsReachable):
(WebCore::JSTestGenerateIsReachable::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterface::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::jsTestJSBuiltinConstructorConstructor): Deleted.
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:
(WebCore::JSTestJSBuiltinConstructor::~JSTestJSBuiltinConstructor):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::jsTestMediaQueryListListenerConstructor): Deleted.
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::~JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListener::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::jsTestNamedConstructorConstructor): Deleted.
* bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::JSTestNamedConstructor::~JSTestNamedConstructor):
(WebCore::JSTestNamedConstructor::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministic::JSTestNondeterministic):
(WebCore::jsTestNondeterministicNondeterministicReadonlyAttr): Deleted.
* bindings/scripts/test/JS/JSTestNondeterministic.h:
(WebCore::JSTestNondeterministic::~JSTestNondeterministic):
(WebCore::JSTestNondeterministic::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObj::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::~JSTestObj):
* bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):
(WebCore::jsTestOverloadedConstructorsConstructor): Deleted.
* bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::JSTestOverloadedConstructors::~JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins):
(WebCore::JSTestOverrideBuiltins::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
(WebCore::JSTestOverrideBuiltins::~JSTestOverrideBuiltins):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfaceValue): Deleted.
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::~JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterface::finishCreation): Deleted.
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefs::JSTestTypedefs):
(WebCore::JSTestTypedefs::getOwnPropertySlot): Deleted.
* bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::JSTestTypedefs::~JSTestTypedefs):
* bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattribute::JSattribute):
(WebCore::jsattributeReadonly): Deleted.
* bindings/scripts/test/JS/JSattribute.h:
(WebCore::JSattribute::~JSattribute):
(WebCore::JSattribute::finishCreation): Deleted.
* bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonly::JSreadonly):
(WebCore::jsreadonlyConstructor): Deleted.
* bindings/scripts/test/JS/JSreadonly.h:
(WebCore::JSreadonly::~JSreadonly):
(WebCore::JSreadonly::finishCreation): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix the ARM build after r190192
ossy@webkit.org [Thu, 1 Oct 2015 12:35:38 +0000 (12:35 +0000)]
Fix the ARM build after r190192
https://bugs.webkit.org/show_bug.cgi?id=149620

Reviewed by Darin Adler.

* platform/graphics/FontFeatureSettings.h:
(WebCore::fontFeatureTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Streams API] Add support for private WebCore JS builtins functions
youenn.fablet@crf.canon.fr [Thu, 1 Oct 2015 12:30:43 +0000 (12:30 +0000)]
[Streams API] Add support for private WebCore JS builtins functions
https://bugs.webkit.org/show_bug.cgi?id=149518

Reviewed by Darin Adler.

Source/JavaScriptCore:

Adding API to add private identifiers on the fly.
This is used to support private JS Builtin functions/private JS Builtin names in WebCore.

* builtins/BuiltinNames.h:
(JSC::BuiltinNames::appendExternalName):
* runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::appendExternalName):
* runtime/CommonIdentifiers.h:

Source/WebCore:

Using ReadableStream tee method as a testbed to add support for private WebCore JS builtins functions.
Private functions are hooked to JSDOMWindowBase, as it is the one connected to WebCoreClientData.
WebCoreClientData is responsible to export the private function symbols to the VM.

Updated generate-js-builtins script to generate a class that can create and own all JS functions.
This class is used by JSDOMWindowBase to create the JS builtin functions.
It is also used to manage the GC of these objects.

Covered by rebased tests.

* CMakeLists.txt: Adding ReadableStreamInternals builtin files.
* DerivedSources.cpp: Ditto.
* DerivedSources.make: Ditto.
* Modules/streams/ReadableStream.idl: Adding tee declaration as builtin
* Modules/streams/ReadableStream.js:
(tee): Calling @teeReadableStream
* Modules/streams/ReadableStreamInternals.js: Barebone @teeReadableStream implementation.
(teeReadableStream):
* WebCore.vcxproj/WebCore.vcxproj: Adding ReadableStreamInternals builtin files.
* WebCore.xcodeproj/project.pbxproj: Adding ReadableStreamInternals builtin files.
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase): Creating ReadableStreamInternalsBuiltinFunctions object.
(WebCore::JSDOMWindowBase::finishCreation): Creating builtin functions through ReadableStreamInternalsBuiltinFunctions and registering them to the JS engine.
(WebCore::JSDOMWindowBase::visitChildren): Ensuring GC does not collect private builtin functions through ReadableStreamInternalsBuiltinFunctions object
* bindings/js/JSDOMWindowBase.h:
* bindings/js/WebCoreJSClientData.h:
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Exporting private names of ReadableStreamInternalsBuiltins
(WebCore::WebCoreJSClientData::readableStreamBuiltins):
(WebCore::WebCoreJSClientData::readableStreamInternalsBuiltins):
* generate-js-builtins: Adding support for ReadableStreamInternalsBuiltinFunctions and exportNames.

LayoutTests:

Rebasing tests now that tee is appearing in the IDL, although not yet conformant in its implementation.

* streams/reference-implementation/readable-stream-expected.txt:
* streams/reference-implementation/readable-stream-tee-expected.txt:
* streams/reference-implementation/readable-stream-templated-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[jhbuild] switch to new upstream usrsctp library
ossy@webkit.org [Thu, 1 Oct 2015 10:52:37 +0000 (10:52 +0000)]
[jhbuild] switch to new upstream usrsctp library
https://bugs.webkit.org/show_bug.cgi?id=149494

Reviewed by Philippe Normand.

* efl/jhbuild.modules:
* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190400 268f45cc-cd09-0410-ab3c-d52691b4dbfc