WebKit-https.git
8 years agoUnzip initialization lists and constructors in JSCell hierarchy (6/7)
mhahnenberg@apple.com [Wed, 14 Sep 2011 18:55:25 +0000 (18:55 +0000)]
Unzip initialization lists and constructors in JSCell hierarchy (6/7)
https://bugs.webkit.org/show_bug.cgi?id=67692

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::JSCallbackFunction):
* API/JSCallbackFunction.h:
(JSC::JSCallbackFunction::create):
* jsc.cpp:
(GlobalObject::create):
(GlobalObject::GlobalObject):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::ArrayConstructor):
* runtime/ArrayConstructor.h:
(JSC::ArrayConstructor::create):
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::BooleanConstructor):
* runtime/BooleanConstructor.h:
(JSC::BooleanConstructor::create):
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::BooleanPrototype):
* runtime/BooleanPrototype.h:
(JSC::BooleanPrototype::create):
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::DateConstructor):
* runtime/DateConstructor.h:
(JSC::DateConstructor::create):
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::DatePrototype):
* runtime/DatePrototype.h:
(JSC::DatePrototype::create):
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::ErrorConstructor):
* runtime/ErrorConstructor.h:
(JSC::ErrorConstructor::create):
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::FunctionConstructor):
* runtime/FunctionConstructor.h:
(JSC::FunctionConstructor::create):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):
* runtime/FunctionPrototype.h:
(JSC::FunctionPrototype::create):
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::NativeErrorConstructor):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::create):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::finishCreation):
* runtime/NativeErrorPrototype.h:
(JSC::NativeErrorPrototype::create):
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::NumberConstructor):
* runtime/NumberConstructor.h:
(JSC::NumberConstructor::create):
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::NumberPrototype):
* runtime/NumberPrototype.h:
(JSC::NumberPrototype::create):
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::ObjectConstructor):
* runtime/ObjectConstructor.h:
(JSC::ObjectConstructor::create):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::RegExpConstructor):
* runtime/RegExpConstructor.h:
(JSC::RegExpConstructor::create):
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::RegExpPrototype):
* runtime/RegExpPrototype.h:
(JSC::RegExpPrototype::create):
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::StringConstructor):
* runtime/StringConstructor.h:
(JSC::StringConstructor::create):
* runtime/StringObjectThatMasqueradesAsUndefined.h:
(JSC::StringObjectThatMasqueradesAsUndefined::create):
(JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::StringPrototype):
* runtime/StringPrototype.h:
(JSC::StringPrototype::create):

Source/JavaScriptGlue:

Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* JSRun.cpp:
(JSGlueGlobalObject::JSGlueGlobalObject):
* JSRun.h:
(JSGlueGlobalObject::create):

Source/WebCore:

No new tests.

Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* WebCore.exp.in:
* bindings/js/JSDOMBinding.h:
(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
(WebCore::DOMConstructorWithDocument::finishCreation):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSWorkerContextBase.cpp:
(WebCore::JSWorkerContextBase::JSWorkerContextBase):
(WebCore::JSWorkerContextBase::finishCreation):
* bindings/js/JSWorkerContextBase.h:
* bindings/scripts/CodeGeneratorJS.pm:

Added a finishCreation declaration and Moved the finishCreation call into the
create method for all classes except for subclasses of JSWorkerContextBase and
JSDOMWindowBase because those classes are on the next level, and it's easier
to do all of these classes in one fell swoop rather than level by level.
(GenerateHeader):
Added the implementation of the finishCreation method for the classes described above.
(GenerateImplementation):
Also added the finishCreation calls to the autogenerated DOM constructor classes.
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
(WebCore::JSTestInterfaceConstructor::finishCreation):
(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterface::finishCreation):
* bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterface::create):
(WebCore::JSTestInterfacePrototype::create):
(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListener::finishCreation):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::create):
(WebCore::JSTestMediaQueryListListenerPrototype::create):
(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::JSTestObjConstructor):
(WebCore::JSTestObjConstructor::finishCreation):
(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObj::finishCreation):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::create):
(WebCore::JSTestObjPrototype::create):
(WebCore::JSTestObjPrototype::JSTestObjPrototype):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterface::finishCreation):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::create):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::create):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
* bridge/c/CRuntimeObject.cpp:
(JSC::Bindings::CRuntimeObject::CRuntimeObject):
* bridge/c/CRuntimeObject.h:
(JSC::Bindings::CRuntimeObject::create):
* bridge/c/c_instance.cpp:
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
(JSC::Bindings::CRuntimeMethod::finishCreation):
* bridge/jni/jsc/JavaInstanceJSC.cpp:
(JavaRuntimeMethod::JavaRuntimeMethod):
(JavaRuntimeMethod::finishCreation):
* bridge/jni/jsc/JavaRuntimeObject.cpp:
(JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
* bridge/jni/jsc/JavaRuntimeObject.h:
(JSC::Bindings::JavaRuntimeObject::create):
* bridge/objc/ObjCRuntimeObject.h:
(JSC::Bindings::ObjCRuntimeObject::create):
* bridge/objc/ObjCRuntimeObject.mm:
(JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
* bridge/objc/objc_instance.mm:
(ObjCRuntimeMethod::ObjCRuntimeMethod):
(ObjCRuntimeMethod::finishCreation):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::create):
(JSC::Bindings::QtRuntimeObject::QtRuntimeObject):
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::QtPixmapRuntimeObject::create):
(JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeMetaMethod::finishCreation):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::finishCreation):
* bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMetaMethod::create):
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::RuntimeMethod):
* bridge/runtime_method.h:
(JSC::RuntimeMethod::create):

Source/WebKit/mac:

Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
(WebKit::ProxyRuntimeMethod::finishCreation):

Source/WebKit2:

Completed the sixth level of the refactoring to add finishCreation()
methods to all classes within the JSCell hierarchy with non-trivial
constructor bodies.

This primarily consists of pushing the calls to finishCreation() down
into the constructors of the subclasses of the fifth level of the hierarchy
as well as pulling the finishCreation() calls out into the class's corresponding
create() method if it has one.  Doing both simultaneously allows us to
maintain the invariant that the finishCreation() method chain is called exactly
once during the creation of an object, since calling it any other number of
times (0, 2, or more) will cause an assertion failure.

* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::JSNPMethod):
* WebProcess/Plugins/Netscape/JSNPMethod.h:
(WebKit::JSNPMethod::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove ENABLE_SVG_USE as <use> is required by HTML5
eric@webkit.org [Wed, 14 Sep 2011 18:49:16 +0000 (18:49 +0000)]
Remove ENABLE_SVG_USE as <use> is required by HTML5
https://bugs.webkit.org/show_bug.cgi?id=68019

Reviewed by Ryosuke Niwa.

.:

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* features.pri:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/build-webkit:
* waf/build/settings.py:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed; new baselines (Skia on Mac)
caryclark@google.com [Wed, 14 Sep 2011 18:47:34 +0000 (18:47 +0000)]
Unreviewed; new baselines (Skia on Mac)
Updated reference images (missed this one on the prior land)

       * platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed; new baselines (Skia on Mac)
caryclark@google.com [Wed, 14 Sep 2011 18:46:19 +0000 (18:46 +0000)]
Unreviewed; new baselines (Skia on Mac)
Updated reference images.

       * platform/chromium-mac/fast/writing-mode/broken-ideographic-font-expected.png: Removed.
       * platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaPlayerPrivateAVFoundationObjC's "periodic time observer" is unnecessary
eric.carlson@apple.com [Wed, 14 Sep 2011 18:41:32 +0000 (18:41 +0000)]
MediaPlayerPrivateAVFoundationObjC's "periodic time observer" is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=68056

MediaPlayerPrivateAVFoundationObjC creates a "periodic time observer" not because it wants
periodic callbacks, but because a time observer also fires whenever a seek completes. This is
no longer necessary because it now uses but AVPlayerItem's
-seekToTime:toleranceBefore:toleranceAfter:completionHandler to seek, so seek completions are
always notified.

Reviewed by Darin Adler.

No new tests, code removed is tested by existing tests.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=68054
bdakin@apple.com [Wed, 14 Sep 2011 18:35:49 +0000 (18:35 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68054
Return an image scale factor as well as an Image* from CachedImage::brokenImage()

Reviewed by Darin Adler.

CachedImage::brokenImage() now returns a pair<Image*, float> where the float
represents the image's scale factor. This is important because currently, the
broken image will either be only 1x or 2x, but a deviceScaleFactor could
theoretically be something different (1.5, 3, etc). So it is not safe to assume
that the image's scale factor is equivalent to the deviceScaleFactor, and
hardcoding 2 for now is lame.
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::brokenImage):
(WebCore::CachedImage::image):
* loader/cache/CachedImage.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):
(WebCore::RenderImage::paintReplaced):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agovideo-error-abort.html shouldn't be in Mac skipped list
eric.carlson@apple.com [Wed, 14 Sep 2011 18:27:23 +0000 (18:27 +0000)]
video-error-abort.html shouldn't be in Mac skipped list
https://bugs.webkit.org/show_bug.cgi?id=68053
<rdar://problem/6710625> Test media/video-error-abort.html doesn't work

Reviewed by Darin Adler.

* platform/mac/Skipped: Remove http/tests/media/video-error-abort.html from the mac
    skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Unreviewed gardening.
senorblanco@chromium.org [Wed, 14 Sep 2011 18:05:00 +0000 (18:05 +0000)]
[chromium] Unreviewed gardening.

Removing fast/canvas/setWidthResetAfterForcedRender.html from
test_expectations, since it has been passing on the Mesa bots
(last failure was at r94962).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Move contents texture manager from LayerRendererChromium to CCLayerTreeHost
jamesr@google.com [Wed, 14 Sep 2011 18:02:27 +0000 (18:02 +0000)]
[chromium] Move contents texture manager from LayerRendererChromium to CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=67440

Reviewed by Kenneth Russell.

This moves the contents TextureManager over to the CCLayerTreeHost, where it belongs, and adds in a commit path
to make sure that textures are deleted even if the page is not visible.  This move also removed the need for
LayerRendererChromium's CCLayerTreeHost pointer, so I removed that as well.  That meant moving the
layerTreeAsText() logic over to the CCLayerImpl side, which is where it really belonged anyway.

Covered by existing compositing/ tests and
platform/chromium/compositor/lost-compositor-context-with-rendersurface.html

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::releaseRenderSurfaceTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::setContentsTextureMemoryUseBytes):
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):
(WebCore::TextureManager::lowLimitBytes):
* platform/graphics/chromium/TextureManager.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deleteContentsTextures):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::contentsTextureManager):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setVisible):
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsCommit):
(WebCore::CCThreadProxy::setNeedsCommitOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=68040
hyatt@apple.com [Wed, 14 Sep 2011 17:58:11 +0000 (17:58 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68040

Make sure border image sub-properties can be specified in any order.

Reviewed by Beth Dakin.

Source/WebCore:

New tests in fast/borders.

* css/CSSParser.cpp:
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::canAdvance):
(WebCore::BorderImageParseContext::setCanAdvance):
(WebCore::BorderImageParseContext::allowCommit):
(WebCore::BorderImageParseContext::allowImage):
(WebCore::BorderImageParseContext::allowImageSlice):
(WebCore::BorderImageParseContext::allowSlash):
(WebCore::BorderImageParseContext::requireWidth):
(WebCore::BorderImageParseContext::requireOutset):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):
* css/CSSParserValues.h:
(WebCore::CSSParserValueList::previous):

LayoutTests:

* fast/borders/border-image-scrambled.html: Added.
* platform/mac/fast/borders/border-image-scrambled-expected.png: Added.
* platform/mac/fast/borders/border-image-scrambled-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove Jan Erik Hanssen (added in my r95078) from the list for now
rniwa@webkit.org [Wed, 14 Sep 2011 17:16:38 +0000 (17:16 +0000)]
Remove Jan Erik Hanssen (added in my r95078) from the list for now
since I can't confirm acceptable his committership.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoquery SystemParametersInfo for GDI font smoothing settings
reed@google.com [Wed, 14 Sep 2011 17:04:12 +0000 (17:04 +0000)]
query SystemParametersInfo for GDI font smoothing settings
https://bugs.webkit.org/show_bug.cgi?id=68080

Reviewed by Stephen White.

No new tests. fixes antialiasing issues based on User settings

* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::getDefaultGDITextFlags):
(WebCore::setupPaintForFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=68050
hyatt@apple.com [Wed, 14 Sep 2011 16:45:23 +0000 (16:45 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68050

Regressions in some layout tests from making border/mask/reflection nine-piece-image
parsing match the spec, which allows any of the pieces to be omitted and to also be
specifiable in any order.

When the higher level code suddenly allowed the image slices to be omitted, the fixup
for legacy compatibility for reflections and masks in the parseBorderImageSlice function
no longer happened because that function no longer got called.

The fix is to properly set the defaults to include the "fill" keyword, so the fixup is
applied to the NinePieceImages you create before you ever map anything in from the rules.

This also has the side effect of fixing -webkit-max-box-image-slice to actually dump as
"0 fill" instead of just "0", which is the correct initial value for this property.

Reviewed by Adam Roben.

Source/WebCore:

* css/CSSParser.cpp:
(WebCore::CSSParser::parseBorderImageSlice):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
* rendering/style/StyleReflection.h:
(WebCore::StyleReflection::StyleReflection):

LayoutTests:

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. timeline-animation-frame.html was marked as TEXT.
loislo@chromium.org [Wed, 14 Sep 2011 16:27:27 +0000 (16:27 +0000)]
Unreviewed. timeline-animation-frame.html was marked as TEXT.

* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. timeline-animation-frame.html was marked as TIMEOUT.
loislo@chromium.org [Wed, 14 Sep 2011 15:54:08 +0000 (15:54 +0000)]
Unreviewed. timeline-animation-frame.html was marked as TIMEOUT.

* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-13 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 14 Sep 2011 15:09:56 +0000 (15:09 +0000)]
2011-09-13  Pavel Feldman  <pfeldman@google.com>

        Web Inspector: InspectorInstrumentation::frameDestroyed is called after m_page has been reset.
        https://bugs.webkit.org/show_bug.cgi?id=67997

        We should not instrument frameDestroyed event from within Frame's destructor
        since frame's m_page pointer is likely to be 0 by that time and appropriate
        instrumenting agent won't be found. As a result, stale frame with its id
        end up in the inspector.

        This change wipes out frame binding from the inspector upon detach rather
        than destroy.

        Reviewed by Tony Gentilcore.

        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::frameDetachedImpl):
        * inspector/InspectorInstrumentation.h:
        * inspector/InspectorPageAgent.cpp:
        (WebCore::InspectorPageAgent::frameDetached):
        * inspector/InspectorPageAgent.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::detachFromParent):
        * page/Frame.cpp:
        (WebCore::Frame::~Frame):
        (WebCore::Frame::detachFromPage):
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-14 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 14 Sep 2011 14:59:46 +0000 (14:59 +0000)]
2011-09-14  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: rolling out r95089.

        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::frameDestroyedImpl):
        (WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::frameWindowDiscarded):
        (WebCore::InspectorInstrumentation::domContentLoadedEventFired):
        (WebCore::InspectorInstrumentation::loadEventFired):
        (WebCore::InspectorInstrumentation::didCommitLoad):
        (WebCore::InspectorInstrumentation::frameDestroyed):
        * inspector/InspectorPageAgent.cpp:
        (WebCore::InspectorPageAgent::frameDetached):
        (WebCore::InspectorPageAgent::frameDestroyed):
        * inspector/InspectorPageAgent.h:
        * page/Frame.cpp:
        (WebCore::Frame::~Frame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.
loislo@chromium.org [Wed, 14 Sep 2011 14:34:32 +0000 (14:34 +0000)]
Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=67986

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/timeline/timeline-animation-frame.html

* English.lproj/localizedStrings.js:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::callFunction):
(WebCore::V8Proxy::callFunctionWithoutFrame):
(WebCore::V8Proxy::instrumentedCallFunction):
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8CustomVoidCallback.cpp:
(WebCore::invokeCallback):
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::cancelCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl):
(WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl):
(WebCore::InspectorInstrumentation::didFireAnimationFrameEventImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willCallFunction):
(WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallback):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameCallback):
(WebCore::InspectorInstrumentation::willFireAnimationFrameEvent):
(WebCore::InspectorInstrumentation::didFireAnimationFrameEvent):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
(WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
(WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):
* inspector/InspectorTimelineAgent.h:
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createAnimationFrameCallbackData):
* inspector/TimelineRecordFactory.h:
* inspector/front-end/TimelineAgent.js:
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.get _recordStyles):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

LayoutTests:

* inspector/timeline/timeline-animation-frame-expected.txt: Added.
* inspector/timeline/timeline-animation-frame.html: Added.
* inspector/timeline/timeline-enum-stability-expected.txt:
* platform/chromium/inspector/timeline/timeline-enum-stability-expected.txt:
* inspector/timeline/timeline-test.js:
(initialize_Timeline.InspectorTest.performActions.step2):
(initialize_Timeline.InspectorTest.performActions):
(initialize_Timeline.InspectorTest.performActionsAndPrint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHashTraits.h should include template specialization for WTF::String
steveblock@google.com [Wed, 14 Sep 2011 14:20:45 +0000 (14:20 +0000)]
HashTraits.h should include template specialization for WTF::String
https://bugs.webkit.org/show_bug.cgi?id=67851

Ensure that the template specialization for HashTraits<String> is always
picked up. (Previously it was possible to include HashSet and String but
not the correct HashTraits, so you would get an inefficient template
instantiation.)

Patch by Iain Merrick <husky@google.com> on 2011-09-14
Reviewed by Darin Adler.

* wtf/HashTraits.h:
* wtf/text/StringHash.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: InspectorInstrumentation::frameDestroyed is called after m_page has...
pfeldman@chromium.org [Wed, 14 Sep 2011 14:14:37 +0000 (14:14 +0000)]
Web Inspector: InspectorInstrumentation::frameDestroyed is called after m_page has been reset.
https://bugs.webkit.org/show_bug.cgi?id=67997

We should not instrument frameDestroyed event from within Frame's destructor
since frame's m_page pointer is likely to be 0 by that time and appropriate
instrumenting agent won't be found. As a result, stale frame with its id
end up in the inspector.

This change wipes out frame binding from the inspector upon detach rather
than destroy + adds an assertion into the inspector agents lookup with 0 page.

Reviewed by Tony Gentilcore.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::frameDetachedImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::frameWindowDiscarded):
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
(WebCore::InspectorInstrumentation::frameDetached):
(WebCore::InspectorInstrumentation::didCommitLoad):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::frameDetached):
* inspector/InspectorPageAgent.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::detachFromParent):
* page/Frame.cpp:
(WebCore::Frame::~Frame):
(WebCore::Frame::detachFromPage):
(WebCore::Frame::transferChildFrameToNewDocument):
* page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Add NULL checks to ewk_window_features_new_from_core and ewk_view_window_create.
commit-queue@webkit.org [Wed, 14 Sep 2011 13:52:30 +0000 (13:52 +0000)]
[EFL] Add NULL checks to ewk_window_features_new_from_core and ewk_view_window_create.
https://bugs.webkit.org/show_bug.cgi?id=64932

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-09-14
Reviewed by Eric Seidel.

It prevents the crash while allocating memory for the new window.

* ewk/ewk_view.cpp:
(ewk_view_window_create):
* ewk/ewk_window_features.cpp:
(ewk_window_features_new_from_core):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update chromium test expectations.
ukai@chromium.org [Wed, 14 Sep 2011 13:41:42 +0000 (13:41 +0000)]
Unreviewed, update chromium test expectations.

* platform/chromium/test_expectations.txt: fix lint-test-files error

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agopage-transition-event-constructor-expected.txt is missing
haraken@google.com [Wed, 14 Sep 2011 10:06:29 +0000 (10:06 +0000)]
page-transition-event-constructor-expected.txt is missing
https://bugs.webkit.org/show_bug.cgi?id=68069

Reviewed by Hajime Morita.

* fast/events/constructors/page-transition-event-constructor-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
jochen@chromium.org [Wed, 14 Sep 2011 09:48:59 +0000 (09:48 +0000)]
[chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=68066

Reviewed by Adam Barth.

* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r95080.
commit-queue@webkit.org [Wed, 14 Sep 2011 09:41:41 +0000 (09:41 +0000)]
Unreviewed, rolling out r95080.
http://trac.webkit.org/changeset/95080
https://bugs.webkit.org/show_bug.cgi?id=68070

It caused some 2d.composite.uncovered tests fail (Requested by
rgabor on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-14

Source/WebCore:

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

LayoutTests:

* fast/canvas/canvas-large-fills-expected.txt: Removed.
* fast/canvas/canvas-large-fills.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [v8] building call frame info for location-less internal script functi...
pfeldman@chromium.org [Wed, 14 Sep 2011 09:29:31 +0000 (09:29 +0000)]
Web Inspector: [v8] building call frame info for location-less internal script function crashes.
https://bugs.webkit.org/show_bug.cgi?id=67991

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/debugger-pause-in-internal.html

* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::currentCallFrame):

LayoutTests:

* inspector/debugger/debugger-pause-in-internal-expected.txt: Added.
* inspector/debugger/debugger-pause-in-internal.html: Added.
* inspector/debugger/debugger-pause-on-exception-crash-expected.txt: Added.
* platform/chromium/inspector/debugger/debugger-pause-in-internal-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update chromium test expecations.
ukai@chromium.org [Wed, 14 Sep 2011 08:31:41 +0000 (08:31 +0000)]
Unreviewed, update chromium test expecations.

* platform/chromium/test_expectations.txt:
  - remove failure by r95058, which was reverted by r95077.
  - add failures by r95070

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed, update test expectations for
rgabor@webkit.org [Wed, 14 Sep 2011 08:25:20 +0000 (08:25 +0000)]
[Qt] Unreviewed, update test expectations for
svg/custom/dynamic-svg-document-creation.svg after r95030

* platform/qt/svg/custom/dynamic-svg-document-creation-expected.png:
* platform/qt/svg/custom/dynamic-svg-document-creation-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLarge canvas fills should not crash or create unnecessarily large image buffers
commit-queue@webkit.org [Wed, 14 Sep 2011 08:10:05 +0000 (08:10 +0000)]
Large canvas fills should not crash or create unnecessarily large image buffers
https://bugs.webkit.org/show_bug.cgi?id=67988

Source/WebCore:

When using source-in, destination-in, source-out, or destination-atop a temporary
buffer is created. This buffer only needs to be big enough to cover the intersection
of the path and the canvas.

This change also adds some null checks for failures to create contexts or buffers.

Patch by Ben Wells <benwells@chromium.org> on 2011-09-14
Reviewed by Stephen White.

Test: fast/canvas/canvas-large-fills.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

LayoutTests:

Patch by Ben Wells <benwells@chromium.org> on 2011-09-14
Reviewed by Stephen White.

* fast/canvas/canvas-large-fills-expected.txt: Added.
* fast/canvas/canvas-large-fills.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement a PageTransitionEvent constructor for JSC
haraken@google.com [Wed, 14 Sep 2011 07:40:25 +0000 (07:40 +0000)]
Implement a PageTransitionEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68048

Reviewed by Sam Weinig.

Source/WebCore:

The spec for the PageTransitionEvent constructor is here:
http://www.whatwg.org/specs/web-apps/current-work/#pagetransitionevent

Test: fast/events/constructors/page-transition-event-constructor.html

* bindings/generic/EventConstructors.h: Added a definition for the PageTransitionEvent constructor.
* bindings/js/JSEventConstructors.cpp: Added #includes for PageTransitionEvent.
* dom/PageTransitionEvent.cpp:
(WebCore::PageTransitionEventInit::PageTransitionEventInit):
(WebCore::PageTransitionEvent::PageTransitionEvent):
(WebCore::PageTransitionEvent::initPageTransitionEvent):
* dom/PageTransitionEvent.h: Added a definition for PageTransitionEventInit.
(WebCore::PageTransitionEvent::create):
(WebCore::PageTransitionEvent::isPageTransitionEvent):
(WebCore::PageTransitionEvent::persisted):
* dom/PageTransitionEvent.idl: Makes PageTransitionEvent constructible.

LayoutTests:

page-transition-event-constructor.html checks the behavior of the PageTransitionEvent constructor.

* fast/dom/constructed-objects-prototypes-expected.txt: Added PageTransitionEvent.
* fast/events/constructors/page-transition-event-constructor-expected.txt: Added.
* fast/events/constructors/page-transition-event-constructor.html: Added.
* platform/chromium/test_expectations.txt: Skipped page-transition-event-constructor.html, since V8 does not yet have the PageTransitionEvent constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocommitters.py is missing some contributors
rniwa@webkit.org [Wed, 14 Sep 2011 06:58:10 +0000 (06:58 +0000)]
committers.py is missing some contributors
https://bugs.webkit.org/show_bug.cgi?id=68059

Reviewed by Adam Barth.

Add David Barr, Jan Erik Hanssen, and Kim Grönholm.

Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r95058.
ossy@webkit.org [Wed, 14 Sep 2011 06:46:28 +0000 (06:46 +0000)]
Unreviewed, rolling out r95058.
http://trac.webkit.org/changeset/95058
https://bugs.webkit.org/show_bug.cgi?id=68058

It made css3/calc/regression-62276.html crash (Requested by
Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-13

Source/WebCore:

* css/CSSParser.cpp:
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::allowBreak):
(WebCore::BorderImageParseContext::allowWidth):
(WebCore::BorderImageParseContext::allowOutset):
(WebCore::BorderImageParseContext::allowRepeat):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):
* css/CSSParserValues.h:

LayoutTests:

* fast/borders/border-image-scrambled.html: Removed.
* platform/mac/fast/borders/border-image-scrambled-expected.png: Removed.
* platform/mac/fast/borders/border-image-scrambled-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix webkit python test after r95061.
rniwa@webkit.org [Wed, 14 Sep 2011 06:32:53 +0000 (06:32 +0000)]
Fix webkit python test after r95061.

* Scripts/webkitpy/tool/bot/irc_command_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd wangxianzhu@chromium.org as a contributor.
jnd@chromium.org [Wed, 14 Sep 2011 04:37:36 +0000 (04:37 +0000)]
Add wangxianzhu@chromium.org as a contributor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in RenderScrollbarPart::imageChanged.
inferno@chromium.org [Wed, 14 Sep 2011 04:19:45 +0000 (04:19 +0000)]
Crash in RenderScrollbarPart::imageChanged.
https://bugs.webkit.org/show_bug.cgi?id=68009

Reviewed by Simon Fraser.

Source/WebCore:

When a custom scrollbar is removed from its FrameView, its destruction
can be delayed because of RefPtr maintained in EventHandler class
(m_lastScrollbarUnderMouse). Upon removal, we delete all the scrollbar
parts so that they don't link back to scrollbar. However, because of the
delay, we can have a call to updateScrollbarPart which recreates it.
When scrollbar is getting destroyed, we just check to see if there are
remaining scrollbar parts and if yes, we destroy them.

Test: scrollbars/scrollbar-part-created-with-no-parent-crash.html

* rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::~RenderScrollbar):

LayoutTests:

* scrollbars/scrollbar-part-created-with-no-parent-crash-expected.txt: Added.
* scrollbars/scrollbar-part-created-with-no-parent-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update chromium test expectations.
ukai@chromium.org [Wed, 14 Sep 2011 03:36:09 +0000 (03:36 +0000)]
Unreviewed, update chromium test expectations.

* platform/chromium/test_expectations.txt: failures on GPU starting from r95058

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update chromium test expectations.
ukai@chromium.org [Wed, 14 Sep 2011 02:45:26 +0000 (02:45 +0000)]
Unreviewed, update chromium test expectations.

* platform/chromium/test_expectations.txt: failures starting from r95058

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized...
adamk@chromium.org [Wed, 14 Sep 2011 02:09:25 +0000 (02:09 +0000)]
Fix cssText property of counter-valued CSSPrimitiveValue and avoid uninitialized read
https://bugs.webkit.org/show_bug.cgi?id=68021

Reviewed by Tony Chang.

Source/WebCore:

Reported by valgrind in http://crbug.com/60653.

Besides fixing the uninitialized read, add support for outputting the
list separator for counters() calls and the list-style name.

Test: fast/css/counters/counter-cssText.html

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cssText):

LayoutTests:

* fast/css/counters/counter-cssText-expected.txt: Added.
* fast/css/counters/counter-cssText.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebFont followed tiny monospace text displays weird
bashi@chromium.org [Wed, 14 Sep 2011 01:58:25 +0000 (01:58 +0000)]
WebFont followed tiny monospace text displays weird
https://bugs.webkit.org/show_bug.cgi?id=67996

Reviewed by Darin Adler.

Source/WebCore:

Always call wkSetCGFontRenderingMode() in Font::drawGlyphs() so that the rendering mode is set correctly.

Test: platform/mac/fast/text/webfont-after-tiny-monospace-text.html

* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):

LayoutTests:

This test ensures that webfont followed tiny monospace text is displayed correctly.

* platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.png: Added.
* platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.txt: Added.
* platform/mac/fast/text/webfont-after-tiny-monospace-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic has unfriendly error messages when the local server is not available
abarth@webkit.org [Wed, 14 Sep 2011 01:24:36 +0000 (01:24 +0000)]
garden-o-matic has unfriendly error messages when the local server is not available
https://bugs.webkit.org/show_bug.cgi?id=68042

Reviewed by Dimitri Glazkov.

This patch moves us from using alert to showing the error inline in the
progress dialog.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFailureGrid in garden-o-matic should link to the builder's waterfall page
abarth@webkit.org [Wed, 14 Sep 2011 01:23:14 +0000 (01:23 +0000)]
FailureGrid in garden-o-matic should link to the builder's waterfall page
https://bugs.webkit.org/show_bug.cgi?id=68036

Reviewed by Dimitri Glazkov.

One of the users in the user study thought the configurations names in
the failure grid would link to the underlying bots.  That makes sense,
so this patch adds the behavior.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic should be able to mark failures as expected
abarth@webkit.org [Wed, 14 Sep 2011 01:21:52 +0000 (01:21 +0000)]
garden-o-matic should be able to mark failures as expected
https://bugs.webkit.org/show_bug.cgi?id=68027

Reviewed by Dimitri Glazkov.

All the back-end infrastructure exists for this operation.  This patch
just adds some UI to the front-end and wires that UI up to the back
end.  This exact UI will likely need some more polish, but this should
be a reasonable first cut.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogarden-o-matic should tell you about the progress of your rebaseline
abarth@webkit.org [Wed, 14 Sep 2011 01:20:29 +0000 (01:20 +0000)]
garden-o-matic should tell you about the progress of your rebaseline
https://bugs.webkit.org/show_bug.cgi?id=67967

Reviewed by Dimitri Glazkov.

This patch adds ui.MessageBox, which is a light wrapper around jQuery
UI's dialog widget.  We then use ui.MessageBox to show status messages
about in-progress rebaselines.  As each baseline is downloaded, the
MessageBox updates.  This UI replaces our temporary "alert"-based UI.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix XSS auditor bypass when inline handlers contain comments.
commit-queue@webkit.org [Wed, 14 Sep 2011 01:19:04 +0000 (01:19 +0000)]
Fix XSS auditor bypass when inline handlers contain comments.
https://bugs.webkit.org/show_bug.cgi?id=27895

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-13
Reviewed by Adam Barth.

Source/WebCore:

Tests: http/tests/security/xssAuditor/property-escape-comment.html
       http/tests/security/xssAuditor/property-escape-entity.html
       http/tests/security/xssAuditor/property-escape-quote.html

* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::snippetForAttribute):

LayoutTests:

* http/tests/security/xssAuditor/malformed-HTML-expected.txt:
* http/tests/security/xssAuditor/open-attribute-body-expected.txt:
* http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
* http/tests/security/xssAuditor/property-escape-comment-expected.txt: Added.
* http/tests/security/xssAuditor/property-escape-comment.html: Added.
* http/tests/security/xssAuditor/property-escape-entity-expected.txt: Added.
* http/tests/security/xssAuditor/property-escape-entity.html: Added.
* http/tests/security/xssAuditor/property-escape-quote-expected.txt: Added.
* http/tests/security/xssAuditor/property-escape-quote.html: Added.
* http/tests/security/xssAuditor/resources/echo-property.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate chromium-mac test expectations
ukai@chromium.org [Wed, 14 Sep 2011 01:13:59 +0000 (01:13 +0000)]
Update chromium-mac test expectations
https://bugs.webkit.org/show_bug.cgi?id=67917

Reviewed by Darin Adler.

* platform/chromium-cg-mac-leopard/svg/custom/simple-text-double-shadow-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement a HashChangeEvent constructor for V8
haraken@google.com [Wed, 14 Sep 2011 01:05:27 +0000 (01:05 +0000)]
Implement a HashChangeEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=67969

Reviewed by Nate Chapin.

Source/WebCore:

Test: fast/events/constructors/hash-change-event-constructor.html

* bindings/v8/custom/V8EventConstructors.cpp: Added the HashChangeEvent constructor.
* dom/HashChangeEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled hash-change-event-constructor.html, since now V8 has a HashChangeEvent constructor.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
commit-queue@webkit.org [Wed, 14 Sep 2011 01:03:47 +0000 (01:03 +0000)]
GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
https://bugs.webkit.org/show_bug.cgi?id=68024

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-09-13
Reviewed by Gustavo Noronha Silva.

Using g_list_count() and g_list_nth_data() together on a loop is
inneficient since they're both O(n). Iterate over lists in a saner
way.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(dumpHistoryItem): Reduce the scope for the 'kids' variable, and
iterate on it using g_list_next(). Free the list after done with it.
(dumpBackForwardListForWebView): Instead of appending (which is
expensive in GLists) history items and then iterating from the tail
of the itemsToPrint list, prepend items and walk forwards as usual.
(dumpBackForwardListForAllWebViews): Walk the list in a saner way,
remove the (unneeded) viewList variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd Eric's IRC nick.
rniwa@webkit.org [Wed, 14 Sep 2011 01:00:12 +0000 (01:00 +0000)]
Add Eric's IRC nick.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should
fpizlo@apple.com [Wed, 14 Sep 2011 00:37:01 +0000 (00:37 +0000)]
SpeculativeJIT::shouldSpeculateInteger(NodeIndex, NodeIndex) should
return false if either node can be double
https://bugs.webkit.org/show_bug.cgi?id=67985

Reviewed by Geoffrey Garen.

This is a 17% speed-up on 3d-cube.

This required allowing us to check if a constant is double but not
integer, and making the shouldSpeculateInteger() check test for
any hints of doubly-ness in its operands. This also required
changing some terminology: previously "isDouble" often meant
"isDouble or isInt32".  Now "isDouble" means exactly what the name
suggests, and "isNumber" means "isDouble or isInt32".

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::toNumber):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGenerationInfo.h:
(JSC::DFG::isJSFormat):
(JSC::DFG::isJSInteger):
(JSC::DFG::isJSDouble):
(JSC::DFG::isJSCell):
(JSC::DFG::isJSBoolean):
(JSC::DFG::GenerationInfo::isJSFormat):
(JSC::DFG::GenerationInfo::isJSInteger):
(JSC::DFG::GenerationInfo::isJSDouble):
(JSC::DFG::GenerationInfo::isJSCell):
(JSC::DFG::GenerationInfo::isJSBoolean):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::isNumberConstant):
(JSC::DFG::Graph::valueOfNumberConstant):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::fillInteger):
(JSC::DFG::JITCodeGenerator::fillDouble):
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::isKnownInteger):
(JSC::DFG::JITCodeGenerator::isKnownNumeric):
(JSC::DFG::JITCodeGenerator::isKnownCell):
(JSC::DFG::JITCodeGenerator::isKnownNotInteger):
(JSC::DFG::JITCodeGenerator::isKnownBoolean):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::silentFillFPR):
(JSC::DFG::JITCodeGenerator::isNumberConstant):
(JSC::DFG::JITCodeGenerator::valueOfNumberConstant):
(JSC::DFG::JITCodeGenerator::initConstantInfo):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::fillNumericToDouble):
(JSC::DFG::JITCompiler::fillToJS):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isNumberConstant):
(JSC::DFG::JITCompiler::valueOfNumberConstant):
* dfg/DFGNode.h:
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::isNumberConstant):
(JSC::DFG::Node::valueOfNumberConstant):
(JSC::DFG::Node::hasNumberResult):
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::knownConstantArithOp):
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateDouble):
(JSC::DFG::SpeculativeJIT::shouldNotSpeculateInteger):
(JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Fix crash when an iframe element is removed during a transition to
commit-queue@webkit.org [Wed, 14 Sep 2011 00:29:11 +0000 (00:29 +0000)]
Source/WebCore: Fix crash when an iframe element is removed during a transition to
fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=67960

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-13
Reviewed by Adam Barth.

Test: fullscreen/full-screen-remove-ancestor-during-transition.html

* dom/Document.cpp:
(WebCore::Document::~Document):
Clear the list of elements to which we need to send a fullscreenchange
event.

LayoutTests: Removing an iframe from the document during a transition to fullscreen
should not crash.
https://bugs.webkit.org/show_bug.cgi?id=67960

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-13
Reviewed by Adam Barth.

* fullscreen/full-screen-remove-ancestor-during-transition-expected.txt: Added.
* fullscreen/full-screen-remove-ancestor-during-transition.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=68040
hyatt@apple.com [Wed, 14 Sep 2011 00:17:09 +0000 (00:17 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68040

Make sure border image sub-properties can be specified in any order.

Reviewed by Beth Dakin.

Source/WebCore:

New tests in fast/borders.

* css/CSSParser.cpp:
(WebCore::BorderImageParseContext::BorderImageParseContext):
(WebCore::BorderImageParseContext::canAdvance):
(WebCore::BorderImageParseContext::setCanAdvance):
(WebCore::BorderImageParseContext::allowCommit):
(WebCore::BorderImageParseContext::allowImage):
(WebCore::BorderImageParseContext::allowImageSlice):
(WebCore::BorderImageParseContext::allowSlash):
(WebCore::BorderImageParseContext::requireWidth):
(WebCore::BorderImageParseContext::requireOutset):
(WebCore::BorderImageParseContext::commitImage):
(WebCore::BorderImageParseContext::commitImageSlice):
(WebCore::BorderImageParseContext::commitSlash):
(WebCore::BorderImageParseContext::commitBorderWidth):
(WebCore::BorderImageParseContext::commitBorderOutset):
(WebCore::BorderImageParseContext::commitRepeat):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseBorderImageRepeat):
(WebCore::CSSParser::parseBorderImageSlice):
(WebCore::CSSParser::parseBorderImageQuad):
* css/CSSParserValues.h:
(WebCore::CSSParserValueList::previous):

LayoutTests:

* fast/borders/border-image-scrambled.html: Added.
* platform/mac/fast/borders/border-image-scrambled-expected.png: Added.
* platform/mac/fast/borders/border-image-scrambled-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebCore::Cursor::ensurePlatformCursor() should always set a valid platform cursor...
jeffm@apple.com [Wed, 14 Sep 2011 00:05:13 +0000 (00:05 +0000)]
WebCore::Cursor::ensurePlatformCursor() should always set a valid platform cursor on Windows
https://bugs.webkit.org/show_bug.cgi?id=68043

Make sure we set a valid platform cursor in the Cursor::NoDrop case, and add a default
clause that uses the arrow cursor in case another cursor type is added in the future
and we forget to update ensurePlatformCursor().

Reviewed by Anders Carlsson.

* platform/win/CursorWin.cpp:
(WebCore::Cursor::ensurePlatformCursor): Always set a valid platform cursor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMSAA: WebKit reports the document state as disabled
jhoneycutt@apple.com [Tue, 13 Sep 2011 23:32:36 +0000 (23:32 +0000)]
MSAA: WebKit reports the document state as disabled
https://bugs.webkit.org/show_bug.cgi?id=67974
<rdar://problem/10095898>

Reviewed by Brian Weinstein.

Source/WebCore:

Test: platform/win/accessibility/document-enabled-state.html

* accessibility/AccessibilityScrollView.h:
(WebCore::AccessibilityScrollView::isEnabled):
This object backs the AccessibleDocument on Windows - always return
true for its enabled state.

LayoutTests:

* platform/win/accessibility/document-enabled-state-expected.txt: Added.
* platform/win/accessibility/document-enabled-state.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix state of stop/reload actions in QWebPage
commit-queue@webkit.org [Tue, 13 Sep 2011 23:10:21 +0000 (23:10 +0000)]
[Qt] Fix state of stop/reload actions in QWebPage
https://bugs.webkit.org/show_bug.cgi?id=65977

FrameLoader does ask its DocumentLoader to stop loading subresources before
setting the state to FrameStateCommittedPage. But it does
not check if the the DocumentLoader actually stopped loading before
it changes the state.
Therefore a subresourceLoader can still be active, when we receive the
call to dispatchDidFinishLoad(). This leads to an inconsistent behavior
of the stop/reload actions in QWebPage.
This changeset fixes the inconsistent state by updating the action states
also when frameLoadCompleted() is called.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-09-13
Reviewed by Chang Shu.

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::frameLoadCompleted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Fixes several bugs when adding CounterNodes to a tree which can cause...
cdn@chromium.org [Tue, 13 Sep 2011 22:49:15 +0000 (22:49 +0000)]
Source/WebCore: Fixes several bugs when adding CounterNodes to a tree which can cause asymetrical relationships.
https://bugs.webkit.org/show_bug.cgi?id=65996

Reviewed by Eric Seidel.

Test: fast/css/counters/counter-reparent-table-children-crash.html

* rendering/CounterNode.cpp:
(WebCore::CounterNode::insertAfter):
* rendering/RenderCounter.cpp:
(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):

LayoutTests: Test for crash when reparenting table elements with associated counters outside the table.
https://bugs.webkit.org/show_bug.cgi?id=65996

Reviewed by Eric Seidel.

* fast/css/counters/counter-reparent-table-children-crash-expected.txt: Added.
* fast/css/counters/counter-reparent-table-children-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding a comment I forgot to add before.
bdakin@apple.com [Tue, 13 Sep 2011 22:41:36 +0000 (22:41 +0000)]
Adding a comment I forgot to add before.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove identifier filter from CSSStyleSelector to SelectorChecker
antti@apple.com [Tue, 13 Sep 2011 22:38:42 +0000 (22:38 +0000)]
Move identifier filter from CSSStyleSelector to SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=68025

Reviewed by Sam Weinig.

This is a more logical place for this code. It also makes CSSStyleSelector slightly less bloated.
It will make it possible to use fastRejectSelector for querySelectorAll in the future.

* css/CSSStyleSelector.cpp:
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::matchRulesForList):
(WebCore::RuleData::RuleData):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::pushParent):
(WebCore::CSSStyleSelector::popParent):
* css/SelectorChecker.cpp:
(WebCore::collectElementIdentifierHashes):
(WebCore::SelectorChecker::pushParentStackFrame):
(WebCore::SelectorChecker::popParentStackFrame):
(WebCore::SelectorChecker::pushParent):
(WebCore::SelectorChecker::popParent):
(WebCore::collectDescendantSelectorIdentifierHashes):
(WebCore::SelectorChecker::collectIdentifierHashes):
* css/SelectorChecker.h:
(WebCore::SelectorChecker::parentStackIsConsistent):
(WebCore::SelectorChecker::ParentStackFrame::ParentStackFrame):
(WebCore::SelectorChecker::fastRejectSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRestoring a ChangeLog entry that I accidentally trampled.
bdakin@apple.com [Tue, 13 Sep 2011 22:33:30 +0000 (22:33 +0000)]
Restoring a ChangeLog entry that I accidentally trampled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFor compatibility, execCommand should support deprecated 'useCSS' alias for 'styleWit...
commit-queue@webkit.org [Tue, 13 Sep 2011 22:31:24 +0000 (22:31 +0000)]
For compatibility, execCommand should support deprecated 'useCSS' alias for 'styleWithCSS'
https://bugs.webkit.org/show_bug.cgi?id=36683

Patch by Kiyoto Tamura <owenestea@gmail.com> on 2011-09-13
Reviewed by Ryosuke Niwa.

Source/WebCore:

In addition to supporting the deprecated 'useCSS', 'styleWithCSS' now accepts any argument other than
the boolean false or the case-insensitive string "false". This is per
http://aryeh.name/spec/editing/editing.html#the-stylewithcss-command

Tests: editing/execCommand/style-with-css.html
       editing/execCommand/use-css.html

* editing/EditorCommand.cpp:
(WebCore::executeStyleWithCSS):
(WebCore::executeUseCSS):
(WebCore::createCommandMap):

LayoutTests:

Testing useCSS, the command previously unsupported by WebKit. Also, we are testing
styleWithCSS accepts anything that is not the boolean false or the string "false" as true.
Furthermore, we test that queryCommandValue/State('useCSS') return boolean false and
queryCommandValue/State('useStyleWithCSS') returns booleans (as opposed to 'true'/'false'
strings)

* editing/execCommand/style-with-css-expected.txt: Added.
* editing/execCommand/style-with-css.html: Added.
* editing/execCommand/use-css-expected.txt: Added.
* editing/execCommand/use-css.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable C++ exceptions when building with clang
andersca@apple.com [Tue, 13 Sep 2011 22:28:53 +0000 (22:28 +0000)]
Disable C++ exceptions when building with clang
https://bugs.webkit.org/show_bug.cgi?id=68031
<rdar://problem/9556880>

Reviewed by Mark Rowe.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:

Source/JavaScriptGlue:

* Configurations/Base.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:

Tools:

* MiniBrowser/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=67885
bdakin@apple.com [Tue, 13 Sep 2011 22:17:09 +0000 (22:17 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67885
Outline for the high-resolution broken image icon draws at 2x
-and corresponding-
<rdar://problem/10104637>

Reviewed by Dan Bernstein.

Scaled the image size to account for the deviceScaleFactor.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageSizeForError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (64275): Shape pattern-image fill turns black
timothy_horton@apple.com [Tue, 13 Sep 2011 21:54:02 +0000 (21:54 +0000)]
REGRESSION (64275): Shape pattern-image fill turns black
https://bugs.webkit.org/show_bug.cgi?id=51061
<rdar://problem/8504705>

Reviewed by Simon Fraser.

Source/WebCore:

When destroying a resource, register clients who are losing their
resource as having pending resources, so they can be resolved in the case a
resource with that id is re-registered.

Test: svg/custom/pending-resource-after-removal.xhtml

* rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::resourceDestroyed):
* svg/SVGStyledElement.h:
(WebCore::toSVGStyledElement): Added.

LayoutTests:

Add a test ensuring that replacing a SVG pattern without changing
the id causes the clients to be updated properly.

* svg/custom/pending-resource-after-removal-expected.png: Added.
* svg/custom/pending-resource-after-removal-expected.txt: Added.
* svg/custom/pending-resource-after-removal.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] fix flakiness dashboard for chromium interactive tests
ojan@chromium.org [Tue, 13 Sep 2011 21:50:01 +0000 (21:50 +0000)]
[chromium] fix flakiness dashboard for chromium interactive tests
https://bugs.webkit.org/show_bug.cgi?id=68029

Reviewed by Tony Chang.

* TestResultServer/static-dashboards/flakiness_dashboard.html:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] The checked state of WebPopupMenuItem isn't initialized
abarth@webkit.org [Tue, 13 Sep 2011 21:43:13 +0000 (21:43 +0000)]
[Chromium] The checked state of WebPopupMenuItem isn't initialized
https://bugs.webkit.org/show_bug.cgi?id=67889

Reviewed by Darin Fisher.

It seems we're failing to initialize the checked state of
WebPopupMenuItems, potentially because Android is the first platform to
use popup menus for <select> elements.

* src/ExternalPopupMenu.cpp:
(WebKit::ExternalPopupMenu::getPopupMenuInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd Alice and Aryeh to the list of contributors.
rniwa@webkit.org [Tue, 13 Sep 2011 21:08:54 +0000 (21:08 +0000)]
Add Alice and Aryeh to the list of contributors.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed; new baselines (Skia on Mac)
caryclark@google.com [Tue, 13 Sep 2011 20:59:38 +0000 (20:59 +0000)]
Unreviewed; new baselines (Skia on Mac)
Updated reference images.

* platform/chromium-gpu-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
* platform/chromium-gpu-mac/compositing/overflow/overflow-positioning-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosheriffbot whois should also tell us email addresses
rniwa@webkit.org [Tue, 13 Sep 2011 20:51:29 +0000 (20:51 +0000)]
sheriffbot whois should also tell us email addresses
https://bugs.webkit.org/show_bug.cgi?id=67975

Reviewed by Eric Seidel and David Levin.

Taught sheriffbot how to tell us contributor's email addresses.

* Scripts/webkitpy/tool/bot/irc_command.py:
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed; new baselines (Skia on Mac)
caryclark@google.com [Tue, 13 Sep 2011 20:35:17 +0000 (20:35 +0000)]
Unreviewed; new baselines (Skia on Mac)
Updated reference images, text.

* platform/chromium-mac/http/tests/eventsource/existent-eventsource-status-error-iframe-crash-expected.txt: Removed.
* platform/chromium-mac/platform/chromium/fast/repaint: Added.
* platform/chromium-mac/platform/chromium/fast/repaint/fixed-layout-360x240-expected.png: Added.
* platform/chromium-mac/fast/lists/list-marker-before-content-table-expected.png: Added.
* platform/chromium-mac/fast/runin/runin-generated-before-content-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added.
* platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png: Added.
* platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
eric@webkit.org [Tue, 13 Sep 2011 20:19:35 +0000 (20:19 +0000)]
Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
https://bugs.webkit.org/show_bug.cgi?id=68018

Reviewed by Ryosuke Niwa.

.:

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* Source/cmakeconfig.h.cmake:
* configure.ac:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.exp.in:
* dom/DOMImplementation.cpp:
(WebCore::isSVG10Feature):
(WebCore::isSVG11Feature):
* dom/Text.cpp:
(WebCore::Text::createRenderer):
* features.pri:
* page/DOMWindow.idl:
* rendering/svg/RenderSVGForeignObject.cpp:
* rendering/svg/RenderSVGForeignObject.h:
* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
* svg/SVGForeignObjectElement.cpp:
* svg/SVGForeignObjectElement.h:
* svg/SVGForeignObjectElement.idl:
* svg/SVGLocatable.cpp:
(WebCore::isViewportElement):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::isOutermostSVG):
* svg/SVGUseElement.cpp:
(WebCore::isDisallowedElement):
(WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):
* svg/svgtags.in:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/build-webkit:
* waf/build/settings.py:

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
commit-queue@webkit.org [Tue, 13 Sep 2011 19:26:44 +0000 (19:26 +0000)]
[WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
https://bugs.webkit.org/show_bug.cgi?id=57515

Source/WebKit2:

The code change in WebKit2 allows key events being sent to WebProcess from UIProcess synchronously.

Patch by Chang Shu <cshu@webkit.org> on 2011-09-13
Reviewed by Darin Adler.

* UIProcess/API/C/WKPage.cpp:
(WKPageSetShouldSendKeyboardEventSynchronously):
* UIProcess/API/C/WKPagePrivate.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleKeyboardEvent):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::setShouldSendKeyboardEventSynchronously):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::keyEventSyncForTesting):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Tools:

The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
TestController synchronously. The latter then sends simulated event to WebKit2 module,
which is synchronous, too.

Patch by Chang Shu <cshu@webkit.org> on 2011-09-13
Reviewed by Darin Adler.

* WebKitTestRunner/EventSenderProxy.h: Added.
(WTR::EventSenderProxy::EventSenderProxy):
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::keyDown):
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
* WebKitTestRunner/PlatformWebView.h:
(WTR::PlatformWebView::platformWindow):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/mac/EventSenderProxy.mm: Added.
(WTR::buildModifierFlags):
(WTR::EventSenderProxy::keyDown):

LayoutTests:

Unskip passed tests for Mac.

Patch by Chang Shu <cshu@webkit.org> on 2011-09-13
Reviewed by Darin Adler.

* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:
* platform/win-wk2/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<http://webkit.org/b/67983> CRASH under WebCore::ArchiveResourceCollection::addAllRes...
joepeck@webkit.org [Tue, 13 Sep 2011 19:24:52 +0000 (19:24 +0000)]
<webkit.org/b/67983> CRASH under WebCore::ArchiveResourceCollection::addAllResources loading WebArchive

Reviewed by Darin Adler.

Source/WebCore:

Null mimetypes are okay for subresources, but as previously discovered
in bug 41082 they were required for main resources. Here we ensure
that they are required for main resources, but we allow null mimetypes
for subresources.

To fix a crash for bad input we never add a null ArchiveResource to the
Archive's subresource collection. It is useless and causes crashes whenever
someone iterates the Archive's subresource collection.

Test: webarchive/loading/test-loading-archive-subresource-null-mimetype.html

* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createResource):
Allow a null mimetype, just type check from the dictionary.

(WebCore::LegacyWebArchive::extract):
Require a mimetype for the main resource. Do not add null
subresources to the subresource list.

LayoutTests:

Test a WebArchive that has been constructed to have a null
mimetype for a subresource.

* webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt: Added.
* webarchive/loading/test-loading-archive-subresource-null-mimetype.html: Added.
* webarchive/loading/resources/subresource-null-mimetype.webarchive: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-09-13 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Tue, 13 Sep 2011 19:18:27 +0000 (19:18 +0000)]
2011-09-13  James Simonsen  <simonjam@chromium.org>

        [Chromium] Ref protect element in FrameLoaderClientImpl::createPlugin
        https://bugs.webkit.org/show_bug.cgi?id=68014

        Reviewed by Nate Chapin.

        Test: plugins/destroy-during-npp-new.htm under valgrind

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Tue, 13 Sep 2011 18:33:51 +0000 (18:33 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-13

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove javascript_engine from WebCore.gyp
mihaip@chromium.org [Tue, 13 Sep 2011 18:25:26 +0000 (18:25 +0000)]
[Chromium] Remove javascript_engine from WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=68001

Reviewed by Tony Chang.

Remove javascript_engine GYP variable (similar to the removal done on
the Chromium side with http://crrev.com/100692)

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Do not always return the cached frame name.
commit-queue@webkit.org [Tue, 13 Sep 2011 17:54:15 +0000 (17:54 +0000)]
[EFL] Do not always return the cached frame name.
https://bugs.webkit.org/show_bug.cgi?id=66856

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-13
Reviewed by Antonio Gomes.

When a frame has its parent changed (via adoptNode and appendChild,
for example), the frame name will change, so we need to account for
that case and change the cached name when needed.

This should make fast/frames/iframe-reparenting-unique-name.html pass.

* ewk/ewk_frame.cpp:
(ewk_frame_name_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate chromium test expectation since fast/borders/border-image-omit-right-slice...
rniwa@webkit.org [Tue, 13 Sep 2011 17:46:41 +0000 (17:46 +0000)]
Update chromium test expectation since fast/borders/border-image-omit-right-slice.html no longer hits an assertion.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS3 Backgrounds and Borders] Add unprefixed border-image shorthand.
rniwa@webkit.org [Tue, 13 Sep 2011 17:31:54 +0000 (17:31 +0000)]
[CSS3 Backgrounds and Borders] Add unprefixed border-image shorthand.
https://bugs.webkit.org/show_bug.cgi?id=67970

Reviewed by David Hyatt.

Also update CSSStyleSelector.cpp to support border-image to suppress assertion in
fast/borders/border-image-omit-right-slice.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::mapNinePieceImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPatch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-13
commit-queue@webkit.org [Tue, 13 Sep 2011 16:44:15 +0000 (16:44 +0000)]
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-13
Reviewed by Darin Adler.

Source/WebCore:

Webkit wraps between hyphen-minus and numeric characters
https://bugs.webkit.org/show_bug.cgi?id=20677

Disallow wrapping between a hyphen-minus and a digit if the hyphen-minus
is not directly after a digit or a letter.

Test: fast/text/line-breaks-after-hyphen-before-number.html

* rendering/break_lines.cpp:
(WebCore::asciiLineBreakTable): Disabled line-breaking after '-' and before '.', '0'-'9'. Note: the change for '0'-'9' doesn't really matter because the case is handled hard-coded in shouldBreakAfter().
(WebCore::shouldBreakAfter): Changed line-breaking behavior after '-'.
(WebCore::nextBreakablePosition): Passes lastLastCh to shouldBreakAfter.

LayoutTests:

Webkit wraps between hyphen-minus and numeric characters
https://bugs.webkit.org/show_bug.cgi?id=20677

Disallow wrapping between a hyphen-minus and a digit if the hyphen-minus
is not directly after a digit or a letter.

* fast/text/line-breaks-after-hyphen-before-number-expected.txt: Added.
* fast/text/line-breaks-after-hyphen-before-number.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoplatform/graphics/gtk/FontGtk.cpp was renamed to platform/graphics/pango/FontPango...
commit-queue@webkit.org [Tue, 13 Sep 2011 16:23:49 +0000 (16:23 +0000)]
platform/graphics/gtk/FontGtk.cpp was renamed to platform/graphics/pango/FontPango.cpp . Reflect this change in WebCore.gypi to fix a Chromium build breakage.
https://bugs.webkit.org/show_bug.cgi?id=68000

Patch by Erik Wright <erikwright@chromium.org> on 2011-09-13
Reviewed by Tony Gentilcore.

No change in functionality, thus no new tests.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoObject.getPrototypeOf should use JSValue::get()
weinig@apple.com [Tue, 13 Sep 2011 16:01:38 +0000 (16:01 +0000)]
Object.getPrototypeOf should use JSValue::get()
https://bugs.webkit.org/show_bug.cgi?id=67973

Reviewed by Darin Adler.

Source/JavaScriptCore:

* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorGetPrototypeOf):
Pipe through JSValue::get() to allow overrides.

LayoutTests:

* http/tests/security/cross-frame-access-object-getPrototypeOf-expected.txt: Added.
* http/tests/security/cross-frame-access-object-getPrototypeOf.html: Added.
* http/tests/security/resources/cross-frame-iframe-for-object-getPrototypeOf-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Profiler: Fix overlapping data in function names column.
mnaganov@chromium.org [Tue, 13 Sep 2011 15:32:51 +0000 (15:32 +0000)]
Web Inspector: Profiler: Fix overlapping data in function names column.
https://bugs.webkit.org/show_bug.cgi?id=67896

Reviewed by Pavel Feldman.

* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.createCell):
* inspector/front-end/dataGrid.css:
(.data-grid table.data):
(.data-grid td):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r95025.
commit-queue@webkit.org [Tue, 13 Sep 2011 15:20:04 +0000 (15:20 +0000)]
Unreviewed, rolling out r95025.
http://trac.webkit.org/changeset/95025
https://bugs.webkit.org/show_bug.cgi?id=68005

Test failed on Snow Leopard bots. (Requested by yutak_home on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-13

* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
* websockets/ThreadableWebSocketChannelClientWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThreadableWebSocketChannelClientWrapper shouldn't have a String in it.
yutak@chromium.org [Tue, 13 Sep 2011 13:25:18 +0000 (13:25 +0000)]
ThreadableWebSocketChannelClientWrapper shouldn't have a String in it.
https://bugs.webkit.org/show_bug.cgi?id=67908

Reviewed by David Levin.

Replace a String member variable in ThreadableWebSocketChannelClientWrapper with Vector<UChar>.

No change in functionality, thus no new tests. WebSocket worker tests
(tests under http/tests/websocket/tests/{hixie76,hybi}/workers/) should keep passing.

* websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):
Create a String from Vector<UChar>.
(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
Copy the content of the given String into Vector.
* websockets/ThreadableWebSocketChannelClientWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update chromium test expectations
ukai@chromium.org [Tue, 13 Sep 2011 13:00:33 +0000 (13:00 +0000)]
Unreviewed, update chromium test expectations

* platform/chromium/test_expectations.txt: fast/borders/border-image-omit-right-slice.html fails on release

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, build fix.
ukai@chromium.org [Tue, 13 Sep 2011 10:39:32 +0000 (10:39 +0000)]
Unreviewed, build fix.

CSSPropertyBorderImage was added in r94989, but not yet added in
WebCore::CSSStyleSelector::applyProperty

CSSStyleSelector.cpp:2481: warning: enumeration value 'CSSPropertyBorderImage' not handled in switch

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoeventSender.keyDown is unimplemented (WKTR)
reni@webkit.org [Tue, 13 Sep 2011 08:26:44 +0000 (08:26 +0000)]
eventSender.keyDown is unimplemented (WKTR)
https://bugs.webkit.org/show_bug.cgi?id=57515

Unreviewed gardening.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] fast/js/parseInt.html does not fail any more.
commit-queue@webkit.org [Tue, 13 Sep 2011 06:57:40 +0000 (06:57 +0000)]
[chromium] fast/js/parseInt.html does not fail any more.
https://bugs.webkit.org/show_bug.cgi?id=65366

parseInt bug was fixed in v8 version 3.6.0.

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-12
Reviewed by Eric Seidel.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Roll DEPS again.
ukai@chromium.org [Tue, 13 Sep 2011 06:18:12 +0000 (06:18 +0000)]
Unreviewed. Roll DEPS again.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r95015.
commit-queue@webkit.org [Tue, 13 Sep 2011 06:14:03 +0000 (06:14 +0000)]
Unreviewed, rolling out r95015.
http://trac.webkit.org/changeset/95015
https://bugs.webkit.org/show_bug.cgi?id=67987

compiled failed on Chromium Win bot (Requested by ukai on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-12

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a test that ensures that the accessibility tree
commit-queue@webkit.org [Tue, 13 Sep 2011 06:10:56 +0000 (06:10 +0000)]
Add a test that ensures that the accessibility tree
does not contain duplicate child nodes.
https://bugs.webkit.org/show_bug.cgi?id=58930

This test failed when the bug was originally filed, but was
fixed in: https://bugs.webkit.org/show_bug.cgi?id=61805
so no code changes are accompanying this new layout test.

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-12
Reviewed by Chris Fleizach.

* accessibility/duplicate-child-nodes-expected.txt: Added.
* accessibility/duplicate-child-nodes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrashes in WebCore::InsertListCommand::unlistifyParagraph.
commit-queue@webkit.org [Tue, 13 Sep 2011 05:57:30 +0000 (05:57 +0000)]
Crashes in WebCore::InsertListCommand::unlistifyParagraph.
https://bugs.webkit.org/show_bug.cgi?id=67918

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-12
Reviewed by Ryosuke Niwa.

Source/WebCore:

execCommand("InsertUnorderedList") was crashing if the parent node of the target is
a kind of list element and it is not contenteditable.
This patch checks the parent node is contenteditable.

Test: editing/execCommand/insert-list-in-noneditable-list-parent.html

* editing/htmlediting.cpp:
(WebCore::enclosingListChild): Checks the parent node is contenteditable.

LayoutTests:

Added tests.

* editing/execCommand/insert-list-in-noneditable-list-parent-expected.txt: Added.
* editing/execCommand/insert-list-in-noneditable-list-parent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJavaScriptCore does not have baseline->speculative OSR
fpizlo@apple.com [Tue, 13 Sep 2011 05:35:53 +0000 (05:35 +0000)]
JavaScriptCore does not have baseline->speculative OSR
https://bugs.webkit.org/show_bug.cgi?id=67920

Reviewed by Oliver Hunt.

This adds the ability to on-stack-replace (OSR) from code that is
running hot in the old JIT to code compiled by the new JIT.  This
ensures that long-running loops benefit from DFG optimization.
It also ensures that if code experiences a speculation failure
in DFG code, it has an opportunity to reenter the DFG once every
1,000 loop iterations or so.

This results in a 2.88x speed-up on Kraken/imaging-desaturate,
and is a pure win on the main three benchmark suites (SunSpider,
V8, Kraken), when tiered compilation is enabled.

* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
* bytecode/CodeBlock.h:
* bytecode/Opcode.h:
* bytecode/PredictedType.h: Added.
(JSC::isCellPrediction):
(JSC::isArrayPrediction):
(JSC::isInt32Prediction):
(JSC::isDoublePrediction):
(JSC::isNumberPrediction):
(JSC::isBooleanPrediction):
(JSC::isStrongPrediction):
(JSC::predictionToString):
(JSC::mergePredictions):
(JSC::mergePrediction):
(JSC::makePrediction):
* bytecode/PredictionTracker.h: Added.
(JSC::operandIsArgument):
(JSC::PredictionSlot::PredictionSlot):
(JSC::PredictionTracker::PredictionTracker):
(JSC::PredictionTracker::initializeSimilarTo):
(JSC::PredictionTracker::copyLocalsFrom):
(JSC::PredictionTracker::numberOfArguments):
(JSC::PredictionTracker::numberOfVariables):
(JSC::PredictionTracker::argumentIndexForOperand):
(JSC::PredictionTracker::predictArgument):
(JSC::PredictionTracker::predict):
(JSC::PredictionTracker::predictGlobalVar):
(JSC::PredictionTracker::getArgumentPrediction):
(JSC::PredictionTracker::getPrediction):
(JSC::PredictionTracker::getGlobalVarPrediction):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoopHint):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileBody):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
* dfg/DFGNode.h:
* dfg/DFGOSREntry.cpp: Added.
(JSC::DFG::predictionIsValid):
(JSC::DFG::prepareOSREntry):
* dfg/DFGOSREntry.h: Added.
(JSC::DFG::prepareOSREntry):
* dfg/DFGPredictionTracker.h: Removed.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::mergeUse):
(JSC::DFG::Propagator::mergePrediction):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/CompactJITCodeMap.h:
(JSC::CompactJITCodeMap::numberOfEntries):
(JSC::CompactJITCodeMap::decode):
(JSC::CompactJITCodeMap::Decoder::Decoder):
(JSC::CompactJITCodeMap::Decoder::numberOfEntriesRemaining):
(JSC::CompactJITCodeMap::Decoder::read):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::emitTimeoutCheck):
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
(JSC::JIT::emit_op_loop_hint):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Tue, 13 Sep 2011 04:50:18 +0000 (04:50 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-12

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r94975.
commit-queue@webkit.org [Tue, 13 Sep 2011 04:44:38 +0000 (04:44 +0000)]
Unreviewed, rolling out r94975.
http://trac.webkit.org/changeset/94975
https://bugs.webkit.org/show_bug.cgi?id=67984

crash in PrerenderBrowserTest.PrerenderHTML5VideoJs (Requested
by ukai on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-12

Source/WebCore:

* platform/graphics/chromium/CanvasLayerChromium.h:
(WebCore::CanvasLayerChromium::layerTypeAsString):
* platform/graphics/chromium/ContentLayerChromium.h:
(WebCore::ContentLayerChromium::layerTypeAsString):
* platform/graphics/chromium/ImageLayerChromium.h:
(WebCore::ImageLayerChromium::layerTypeAsString):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::layerTreeAsText):
(WebCore::writeIndent):
(WebCore::LayerChromium::dumpLayer):
(WebCore::LayerChromium::dumpLayerProperties):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::layerTypeAsString):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::textureMemoryReclaimLimit):
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::close):
(WebCore::LayerRendererChromium::releaseTextures):
(WebCore::LayerRendererChromium::drawLayers):
(WebCore::LayerRendererChromium::drawLayersInternal):
(WebCore::LayerRendererChromium::getOffscreenLayerTexture):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::layerTreeAsText):
(WebCore::LayerRendererChromium::dumpRenderSurfaces):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::owner):
(WebCore::LayerRendererChromium::rootLayer):
(WebCore::LayerRendererChromium::rootLayerImpl):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::contentsTextureManager):
* platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
* platform/graphics/chromium/PluginLayerChromium.h:
(WebCore::PluginLayerChromium::layerTypeAsString):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::name):
(WebCore::writeIndent):
(WebCore::RenderSurfaceChromium::dumpSurface):
* platform/graphics/chromium/RenderSurfaceChromium.h:
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::deleteEvictedTextures):
(WebCore::TextureManager::removeTexture):
(WebCore::TextureManager::allocateTexture):
(WebCore::TextureManager::requestTexture):
* platform/graphics/chromium/TextureManager.h:
(WebCore::TextureManager::setAssociatedContextDebugOnly):
(WebCore::TextureManager::associatedContextDebugOnly):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::writeIndent):
(WebCore::TiledLayerChromium::dumpLayerProperties):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/VideoLayerChromium.h:
(WebCore::VideoLayerChromium::layerTypeAsString):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebCore::WebGLLayerChromium::layerTypeAsString):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
* platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
(WebCore::CCLayerTreeHost::~CCLayerTreeHost):
(WebCore::CCLayerTreeHost::commitTo):
(WebCore::CCLayerTreeHost::didRecreateGraphicsContext):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::contentsTextureManager):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::setVisible):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
* platform/graphics/chromium/cc/CCPluginLayerImpl.h:
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::contentsTextureManager):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeLayerRenderer):
(WebCore::CCThreadProxy::contentsTextureManager):
(WebCore::CCThreadProxy::initializeLayerRendererOnCCThread):
(WebCore::CCThreadProxy::layerTreeHostClosedOnCCThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::dumpLayerProperties):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:

LayoutTests:

* platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.png: Removed.
* platform/chromium/compositing/lost-compositor-context-with-rendersurface-expected.txt: Removed.
* platform/chromium/compositing/lost-compositor-context-with-rendersurface.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPossible ASSERT(!storageTracker) in Lazily Initialized StorageTracker
joepeck@webkit.org [Tue, 13 Sep 2011 04:41:42 +0000 (04:41 +0000)]
Possible ASSERT(!storageTracker) in Lazily Initialized StorageTracker
https://bugs.webkit.org/show_bug.cgi?id=67957

Reviewed by Darin Adler.

The storageTracker singleton may already have been created
through StorageTracker::tracker before initializeTracker
gets called. Update the ASSERT in this case to check that
there is no client for the tracker.

No test, this depends on how the port initializes the tracker.

* storage/StorageTracker.cpp:
(WebCore::StorageTracker::initializeTracker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
levin@chromium.org [Tue, 13 Sep 2011 04:15:59 +0000 (04:15 +0000)]
[chromium] Remove AllowCrossThreadAccess for WorkerFileWriterCallbacksBridge.
https://bugs.webkit.org/show_bug.cgi?id=67943

Reviewed by Adam Barth.

* src/WorkerFileWriterCallbacksBridge.cpp: Removed AllowCrossThreadAccess
allowing the automatic ref counting to work. This was previous needed when
the ref counting wasn't working but that was fixed in r94986. Note that the
design was to have ref counting since the methods take PassRefPtr and the
class is ThreadSafeRefCounted. (Ideally we have noticed this flaw when
adding in AllowCrossThreadAccess.)
(WebKit::WorkerFileWriterCallbacksBridge::postWriteToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postTruncateToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::postAbortToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::didWrite):
(WebKit::WorkerFileWriterCallbacksBridge::didFail):
(WebKit::WorkerFileWriterCallbacksBridge::didTruncate):
(WebKit::WorkerFileWriterCallbacksBridge::postInitToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerFileWriterCallbacksBridge::dispatchTaskToWorkerThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't allow setting __proto__ to be a getter or setter
weinig@apple.com [Tue, 13 Sep 2011 04:01:59 +0000 (04:01 +0000)]
Don't allow setting __proto__ to be a getter or setter
https://bugs.webkit.org/show_bug.cgi?id=67982

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

* runtime/JSObject.cpp:
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
Disallow setting a getter or setter on __proto__.

LayoutTests:

* fast/js/prototypes-expected.txt:
* fast/js/script-tests/prototypes.js:
Add test that we disallow setting a getter or setter on __proto__.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix out-of-bounds access in Gradient::sortStopsIfNecessary
adamk@chromium.org [Tue, 13 Sep 2011 03:55:41 +0000 (03:55 +0000)]
Fix out-of-bounds access in Gradient::sortStopsIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=67958

Reviewed by Darin Adler.

Reported by Valgrind in http://crbug.com/77049.

The errant code was added as an optimization in r67804.
This patch reverts that one, as all parties agree that the optimization
doesn't seem worthwhile, and there clearly aren't any tests covering
the special case.

No new tests, as existing tests should cover the remaining call to
|std::stable_sort|.

* platform/graphics/Gradient.cpp:
(WebCore::Gradient::sortStopsIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSetting document.title doesn't affect contents of title tag of XHTML documents
commit-queue@webkit.org [Tue, 13 Sep 2011 03:50:01 +0000 (03:50 +0000)]
Setting document.title doesn't affect contents of title tag of XHTML documents
https://bugs.webkit.org/show_bug.cgi?id=57537

Patch by Jacky Jiang <zhajiang@rim.com> on 2011-09-12
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Update the contents of the <title> tag of XHTML documents when setting
document.title.

Test: fast/dom/title-content-set-innerText-get.xhtml

* dom/Document.cpp:
(WebCore::Document::setTitle):

LayoutTests:

* fast/dom/title-content-set-innerText-get-expected.txt: Added.
* fast/dom/title-content-set-innerText-get.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd GTK & Win expectations for two recently added
commit-queue@webkit.org [Tue, 13 Sep 2011 03:44:39 +0000 (03:44 +0000)]
Add GTK & Win expectations for two recently added
accessibility layout tests.
https://bugs.webkit.org/show_bug.cgi?id=67948

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-12
Reviewed by Chris Fleizach.

* platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
* platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Added.
* platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
* platform/win/accessibility/div-within-anchors-causes-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95008 268f45cc-cd09-0410-ab3c-d52691b4dbfc