WebKit-https.git
8 years agoAdd more Web Audio layout tests
crogers@google.com [Tue, 9 Aug 2011 20:26:15 +0000 (20:26 +0000)]
Add more Web Audio layout tests
https://bugs.webkit.org/show_bug.cgi?id=65786

Reviewed by Kenneth Russell.

* webaudio/audiobuffersource-expected.wav: Added.
* webaudio/audiobuffersource-playbackrate-expected.wav: Added.
* webaudio/audiobuffersource-playbackrate.html: Added.
* webaudio/audiobuffersource.html: Added.
* webaudio/mixing-expected.wav: Added.
* webaudio/mixing.html: Added.
* webaudio/resources/hyper-reality: Added.
* webaudio/resources/hyper-reality/br-jam-loop.wav: Added.
* webaudio/resources/hyper-reality/laughter.wav: Added.
* webaudio/sample-accurate-scheduling-expected.txt: Added.
* webaudio/sample-accurate-scheduling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore Lion skipped list goodness.
andersca@apple.com [Tue, 9 Aug 2011 20:18:05 +0000 (20:18 +0000)]
More Lion skipped list goodness.

* platform/mac-lion/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpgrade jquery in TestFailures
abarth@webkit.org [Tue, 9 Aug 2011 19:58:47 +0000 (19:58 +0000)]
Upgrade jquery in TestFailures
https://bugs.webkit.org/show_bug.cgi?id=65935

Reviewed by Dimitri Glazkov.

Upgrade to a newer version of jQuery with better support for CORS and CSP.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Enable rubber banding when scrolling.
commit-queue@webkit.org [Tue, 9 Aug 2011 19:42:26 +0000 (19:42 +0000)]
[Chromium] Enable rubber banding when scrolling.

https://bugs.webkit.org/show_bug.cgi?id=65707

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-09
Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests since this is just syncing changes to chromium platform.

* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):

Source/WebKit/chromium:

* features.gypi:
* public/WebInputEvent.h:
(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
(WebKit::WebGestureEvent::WebGestureEvent):
* public/mac/WebInputEventFactory.h:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebInputEventConversion.h:
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::GestureEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::handleInputEvent):
* src/WebViewImpl.h:
* src/mac/WebInputEventFactory.mm:
(WebKit::gestureEventTypeForEvent):
(WebKit::phaseForNSEventPhase):
(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: XHRs end up in the resources panel.
vsevik@chromium.org [Tue, 9 Aug 2011 19:29:21 +0000 (19:29 +0000)]
Web Inspector: XHRs end up in the resources panel.
https://bugs.webkit.org/show_bug.cgi?id=60321

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-tree/resource-tree-no-xhrs.html

* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):

LayoutTests:

* http/tests/inspector/console-xhr-logging-expected.txt:
* http/tests/inspector/resource-tree/resource-tree-no-xhrs-expected.txt: Added.
* http/tests/inspector/resource-tree/resource-tree-no-xhrs.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd testing for --force-compositing-mode to windows.internal
enne@google.com [Tue, 9 Aug 2011 19:27:24 +0000 (19:27 +0000)]
Add testing for --force-compositing-mode to windows.internal
https://bugs.webkit.org/show_bug.cgi?id=65777

Reviewed by Adam Barth.

.:

Add exports for Document::settings().

* Source/autotools/symbols.filter:

Source/WebCore:

Test: platform/chromium/compositing/force-compositing-mode/force-composite-empty.html

Move initial initialization to settings caching function so that RLC
picks up changes to the force compositing mode flag.

* WebCore.exp.in:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
* testing/Internals.cpp:
(WebCore::Internals::setForceCompositingMode):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

Add exports for Document::settings().

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Add empty page to test that the root gets a graphics layer.

* platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt: Added.
* platform/chromium/compositing/force-compositing-mode/force-composite-empty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixing 65868 REGRESSION(r92610) caused by 65668 - Optimize floating elements lookup
hyatt@apple.com [Tue, 9 Aug 2011 19:13:45 +0000 (19:13 +0000)]
Fixing 65868 REGRESSION(r92610) caused by 65668 - Optimize floating elements lookup
https://bugs.webkit.org/show_bug.cgi?id=65871

PerformanceTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-09
Reviewed by Dave Hyatt.

* Layout/floats.html: Added the nested divs, so that we can test the propagation impact of the floats tree.

Source/WebCore:

Added an interval tree in the FloatingObjects structure. Also added new mechanisms to make
sure the tree is updated correctly when a float is repositioned.

Changed the PODIntervalTree to support giving a search adapter that can be implemented by the
client. I'm not adding a different bug for that because PODIntervalTree is not used anywhere else
and would be hard to test that the change is not breaking anything.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-09
Reviewed by Dave Hyatt.

No new tests, just a refactor on the floating objects data structure.

* WebCore.xcodeproj/project.pbxproj:
* platform/PODIntervalTree.h:
(WebCore::PODIntervalSearchAdapter::PODIntervalSearchAdapter):
(WebCore::PODIntervalSearchAdapter::lowValue):
(WebCore::PODIntervalSearchAdapter::highValue):
(WebCore::PODIntervalSearchAdapter::collectIfNeeded):
(WebCore::PODIntervalTree::PODIntervalTree):
(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::allOverlapsWithAdapter):
(WebCore::PODIntervalTree::searchForOverlapsFrom):
* platform/PODRedBlackTree.h:
(WebCore::PODRedBlackTree::PODRedBlackTree):
(WebCore::PODRedBlackTree::clear):
(WebCore::PODRedBlackTree::isInitialized):
(WebCore::PODRedBlackTree::initIfNeeded):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::::collectIfNeeded):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addPositionedFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::RenderBlock::FloatingObjects::addPlacedObject):
(WebCore::RenderBlock::FloatingObjects::removePlacedObject):
(WebCore::RenderBlock::FloatingObjects::add):
(WebCore::RenderBlock::FloatingObjects::remove):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTree):
(WebCore::::string):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
(WebCore::RenderBlock::FloatingObject::isInPlacedTree):
(WebCore::RenderBlock::FloatingObject::setIsInPlacedTree):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::setHorizontalWritingMode):
(WebCore::RenderBlock::FloatingObjects::set):
(WebCore::RenderBlock::FloatingObjects::placedFloatsTree):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTreeIfNeeded):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Repeated copy and paste result in nested font elements
rniwa@webkit.org [Tue, 9 Aug 2011 19:10:32 +0000 (19:10 +0000)]
Source/WebCore: Repeated copy and paste result in nested font elements
https://bugs.webkit.org/show_bug.cgi?id=65824

Reviewed by Tony Chang.

Modified isInlineNodeWithStyle to match font element. Also made the function match strictly with those nodes that
ApplyStyleCommand may add to avoid removing non-styling elements. And fixed a regression from r81887 that
ReplaceSelectionCommand may remove non-editing styles such as border in the attempt to avoid nesting styling elements.

This patch paves the way to fix the bug 34564.

Tests: editing/pasteboard/paste-text-with-style-2.html
       editing/pasteboard/paste-text-with-style-3.html
       editing/pasteboard/paste-text-with-style-4.html

* editing/EditingStyle.cpp:
(WebCore::HTMLElementEquivalent::matches): Takes const Element* instead of Element*.
(WebCore::HTMLAttributeEquivalent::matches): Ditto.
(WebCore::htmlElementEquivalents): Extracted from conflictsWithImplicitStyleOfElement.
(WebCore::EditingStyle::conflictsWithImplicitStyleOfElement): Calls htmlElementEquivalents.
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent): Added; determines whether an element is style span
or a styling element (e.g. b, i, font) possibly with editing style.
* editing/EditingStyle.h:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::isInlineNodeWithStyle): Calls EditingStyle::elementIsStyledSpanOrHTMLEquivalent.
(WebCore::ReplaceSelectionCommand::doApply): More aggressively avoid nesting styling elements.
* editing/htmlediting.cpp:
(WebCore::highestEnclosingNodeOfType):
* editing/htmlediting.h:

LayoutTests: Repeated copy and paste result in nested style elements such as b and font
https://bugs.webkit.org/show_bug.cgi?id=65824

Reviewed by Tony Chang.

Added tests to ensure WebKit does not nest styling elements and does not remove elements with non-editing styles.
Also rebaselined several tests.

Because WebKit serializes all editing inheritable styles on copy, we should be able to remove all inline styles
at the insertion point on paste. And this patch removes inline style elements such as font and b more aggressively.
WebKit erroneously bolded the last words in paste-after-inline-style-element.html and paste-with-redundant-style.html
before this change set but this is no longer the case.

* editing/pasteboard/5065605-expected.txt: Lost wrapping font and span elements.
* editing/pasteboard/merge-end-1-expected.txt: Span is split but visually identical.
* editing/pasteboard/merge-end-2-expected.txt: Ditto.
* editing/pasteboard/paste-after-inline-style-element-expected.txt: No longer bolds "line 2" erroneously.
* editing/pasteboard/paste-text-011-expected.txt: Lost wrapping font, b, and span elements.
* editing/pasteboard/paste-text-with-style-2-expected.txt: Added.
* editing/pasteboard/paste-text-with-style-2.html: Added.
* editing/pasteboard/paste-text-with-style-3-expected.txt: Added.
* editing/pasteboard/paste-text-with-style-3.html: Added.
* editing/pasteboard/paste-text-with-style-4-expected.txt: Added.
* editing/pasteboard/paste-text-with-style-4.html: Added.
* editing/pasteboard/paste-with-redundant-style-expected.txt: Lost wrapping b.
* editing/pasteboard/paste-with-redundant-style.html: Updated comments per rebaseline.
* platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=65778
dslomov@google.com [Tue, 9 Aug 2011 19:01:05 +0000 (19:01 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates.

Reviewed by Dmitry Titov.

Covered by existing tests.

* bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate):
(WebCore::V8BindingPerIsolateData::hiddenPropertyName):
(WebCore::V8BindingPerIsolateData::globalHandleMap):
(WebCore::AllowAllocation::AllowAllocation):Moving to V8Binding.h from V8Utilities.h to resolve header dependency.
(WebCore::AllowAllocation::~AllowAllocation):
(WebCore::AllowAllocation::current):
(WebCore::SafeAllocation::newInstance):
* bindings/v8/V8GCController.cpp:
(WebCore::currentGlobalHandleMap):
(WebCore::enumerateGlobalHandles):
(WebCore::V8GCController::registerGlobalHandle):
(WebCore::V8GCController::unregisterGlobalHandle):
* bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::V8HiddenPropertyName::createString):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore::V8HiddenPropertyName::V8HiddenPropertyName):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8NPObject.cpp:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::checkNewLegal):
* bindings/v8/V8Utilities.h:
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initIsolate):
* bindings/v8/WorkerContextExecutionProxy.h:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::scheduleExecutionTermination):

Source/WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates

Reviewed by Dmitry Titov.

* src/BoundObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJavaString is not needed by V8
steveblock@google.com [Tue, 9 Aug 2011 18:36:47 +0000 (18:36 +0000)]
JavaString is not needed by V8
https://bugs.webkit.org/show_bug.cgi?id=65909

Removes the JavaString wrapper class, moves the JSC implementation
to JavaStringJSC.h and removes the V8 implementation.

Reviewed by Alexey Proskuryakov.

No new tests, refactoring only.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bridge/jni/JavaString.h: Removed.
* bridge/jni/jni_jsobject.mm:
* bridge/jni/jsc/JavaFieldJSC.h:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
* bridge/jni/jsc/JavaMethodJSC.h:
* bridge/jni/jsc/JavaStringJSC.h:
(JSC::Bindings::JavaString::JavaString):
(JSC::Bindings::JavaString::~JavaString):
(JSC::Bindings::JavaString::init):
* bridge/jni/v8/JavaStringV8.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Regression(83075): Fix updateAlwaysCreateLineBoxes on information
inferno@chromium.org [Tue, 9 Aug 2011 18:18:36 +0000 (18:18 +0000)]
Source/WebCore: Regression(83075): Fix updateAlwaysCreateLineBoxes on information
about full layout which is needed when dirtying lineboxes.
https://bugs.webkit.org/show_bug.cgi?id=65924

Reviewed by Dave Hyatt.

Test: fast/inline/update-always-create-line-boxes-full-layout-crash.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
* rendering/RenderInline.h:

LayoutTests: Tests that we do not crash when trying to dirty line boxes on
a RenderInline needing full relayout.
https://bugs.webkit.org/show_bug.cgi?id=65924

Reviewed by Dave Hyatt.

* fast/inline/update-always-create-line-boxes-full-layout-crash-expected.txt: Added.
* fast/inline/update-always-create-line-boxes-full-layout-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-09 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 9 Aug 2011 18:05:30 +0000 (18:05 +0000)]
2011-08-09  Nate Chapin  <japhet@chromium.org>

        Remove receivedCancellation() from SubresourceLoaderClient.

        http://bugs.webkit.org/show_bug.cgi?id=65330

        Reviewed by Alexey Proskuryakov.

        No new tests, no change in functionality intended.

        * loader/DocumentThreadableLoader.cpp:
        * loader/DocumentThreadableLoader.h:
        * loader/SubresourceLoader.cpp:
        * loader/SubresourceLoader.h:
        * loader/SubresourceLoaderClient.h:
        * loader/ThreadableLoaderClient.h:
        * loader/WorkerThreadableLoader.cpp:
        * loader/WorkerThreadableLoader.h:
        * notifications/Notification.cpp:
        * notifications/Notification.h:  Remove receivedCancellation() since it's
           identical to didFail(), which is always called immediately after.
        * workers/WorkerScriptLoader.cpp:
        * workers/WorkerScriptLoader.h: Remove receivedCancellation() since it's
           identical to didFail(), which is always called immediately after.
        * xml/XMLHttpRequest.cpp:
        * xml/XMLHttpRequest.h: Remove receivedCancellation().  All it does is
           set m_response, which is cleared in didFail() before it can be used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-09 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 9 Aug 2011 17:08:28 +0000 (17:08 +0000)]
2011-08-09  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: rebaselining inspector test.

        * inspector/debugger/scripts-panel-expected.txt:
        * inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJava Bridge leaks local references
steveblock@google.com [Tue, 9 Aug 2011 17:00:03 +0000 (17:00 +0000)]
Java Bridge leaks local references
https://bugs.webkit.org/show_bug.cgi?id=64320

Reviewed by Alexey Proskuryakov.

No new tests as this is just an optimization.

* bridge/jni/jsc/JavaFieldJSC.cpp:
(JavaField::JavaField):
* bridge/jni/jsc/JavaMethodJSC.cpp:
(JavaMethod::JavaMethod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: files from different domains are mixed in the file selector in Scripts...
pfeldman@chromium.org [Tue, 9 Aug 2011 16:09:00 +0000 (16:09 +0000)]
Web Inspector: files from different domains are mixed in the file selector in Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=65601

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):
(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):
(WebInspector.ScriptsPanel.prototype.reset):
* inspector/front-end/inspector.css:
(select.status-bar-item):

LayoutTests:

* inspector/debugger/scripts-panel-expected.txt:
* platform/chromium/inspector/debugger/scripts-sorting-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-09 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 9 Aug 2011 15:22:16 +0000 (15:22 +0000)]
2011-08-09  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: fix inspector tests

        * inspector/styles/show-user-agent-styles.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r92683.
commit-queue@webkit.org [Tue, 9 Aug 2011 15:01:45 +0000 (15:01 +0000)]
Unreviewed, rolling out r92683.
http://trac.webkit.org/changeset/92683
https://bugs.webkit.org/show_bug.cgi?id=65921

 "Breaks Qt --minimal build. Revert pending update of the Qt
minimal configuration" (Requested by simathur on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-09

.:

* Source/WebKit.pri:

Source/WebKit/qt:

* Api/qwebsettings.cpp:
(QWebSettings::enablePersistentStorage):

Tools:

* QtTestBrowser/cookiejar.cpp:
(TestBrowserCookieJar::TestBrowserCookieJar):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):
* QtTestBrowser/webpage.cpp:
(WebPage::openUrlInDefaultBrowser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Fix warning caused by undefined static api.
commit-queue@webkit.org [Tue, 9 Aug 2011 14:55:56 +0000 (14:55 +0000)]
[EFL] Fix warning caused by undefined static api.
https://bugs.webkit.org/show_bug.cgi?id=65301

Both _ewk_tiled_backing_store_item_request_add and _ewk_tiled_backing_store_item_request_del
are declared, but their bodies are not defined and they are not referenced anywhere.
Therefore, I remove both two API's declaration in order to resolve warning message caused by them.

Patch by KwangHyuk Kim <hyuki.kim@samsung.com> on 2011-08-09
Reviewed by Kenneth Rohde Christiansen.

* ewk/ewk_tiled_backing_store.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Redirect didFindZoomableArea thru to the view
kenneth@webkit.org [Tue, 9 Aug 2011 14:28:38 +0000 (14:28 +0000)]
[Qt] Redirect didFindZoomableArea thru to the view
https://bugs.webkit.org/show_bug.cgi?id=65913

Reviewed by Andreas Kling.

* UIProcess/API/qt/qdesktopwebview.cpp:
(QDesktopWebViewPrivate::didFindZoomableArea):
* UIProcess/API/qt/qdesktopwebview_p.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::didFindZoomableArea):
* UIProcess/qt/QtWebPageProxy.h:
* UIProcess/qt/TouchViewInterface.cpp:
(WebKit::TouchViewInterface::didFindZoomableArea):
* UIProcess/qt/TouchViewInterface.h:
* UIProcess/qt/ViewInterface.h:
* UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::timerEvent):
* UIProcess/qt/qdesktopwebpageproxy.h:
* UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::setContentsScale):
* UIProcess/qt/qtouchwebpageproxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
siddharth.mathur@nokia.com [Tue, 9 Aug 2011 14:24:36 +0000 (14:24 +0000)]
[Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
https://bugs.webkit.org/show_bug.cgi?id=65880

Reviewed by Andreas Kling.

.:

QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
check for their feature flags. Assume that any reasonable Qt build provides them.

* Source/WebKit.pri:

Source/WebKit/qt:

QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
check for their feature flags. Assume that any reasonable Qt build provides them.

* Api/qwebsettings.cpp:
(QWebSettings::enablePersistentStorage):

Tools:

QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
check for their feature flags. Assume that any reasonable Qt build provides them.
* QtTestBrowser/cookiejar.cpp:
(TestBrowserCookieJar::TestBrowserCookieJar):
* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::createChrome):
(LauncherWindow::setDiskCache):
* QtTestBrowser/main.cpp:
(LauncherApplication::handleUserOptions):
* QtTestBrowser/webpage.cpp:
(WebPage::openUrlInDefaultBrowser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: provide a way to hide user agent styles
pfeldman@chromium.org [Tue, 9 Aug 2011 14:24:15 +0000 (14:24 +0000)]
Web Inspector: provide a way to hide user agent styles
https://bugs.webkit.org/show_bug.cgi?id=37766

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/styles/show-user-agent-styles.html

* English.lproj/localizedStrings.js:
* inspector/front-end/Settings.js:
(WebInspector.Settings):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules.get continue):
(WebInspector.StylesSidebarPane.prototype._rebuildStyleRules):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane):
(WebInspector.StylesSidebarPane.prototype._showUserAgentStylesSettingChanged):

LayoutTests:

* inspector/styles/show-user-agent-styles-expected.txt: Added.
* inspector/styles/show-user-agent-styles.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoJavaMethodJobject is no longer needed by V8
steveblock@google.com [Tue, 9 Aug 2011 14:18:53 +0000 (14:18 +0000)]
JavaMethodJobject is no longer needed by V8
https://bugs.webkit.org/show_bug.cgi?id=65910

Reviewed by Tony Gentilcore.

Removes the JavaMethod interface and moves the JavaMethodJobject
implementation to bridge/jni/jsc/JavaMethodJSC.[cpp|h].

No new tests, refactoring only.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* bridge/jni/JavaMethod.h: Removed.
* bridge/jni/jsc/JavaClassJSC.cpp:
(JavaClass::JavaClass):
* bridge/jni/jsc/JavaFieldJSC.h:
* bridge/jni/jsc/JavaInstanceJSC.cpp:
* bridge/jni/jsc/JavaMethodJSC.cpp: Renamed from Source/WebCore/bridge/jni/JavaMethodJobject.cpp.
(JavaMethod::JavaMethod):
(JavaMethod::~JavaMethod):
(appendClassName):
(JavaMethod::signature):
* bridge/jni/jsc/JavaMethodJSC.h: Renamed from Source/WebCore/bridge/jni/JavaMethodJobject.h.
(JSC::Bindings::JavaMethod::name):
(JSC::Bindings::JavaMethod::returnTypeClassName):
(JSC::Bindings::JavaMethod::parameterAt):
(JSC::Bindings::JavaMethod::returnType):
(JSC::Bindings::JavaMethod::isStatic):
(JSC::Bindings::JavaMethod::numParameters):
* bridge/jni/v8/JavaNPObjectV8.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Vastly improve the algorithm for finding a zoomable area when doing double-tap
kenneth@webkit.org [Tue, 9 Aug 2011 14:10:57 +0000 (14:10 +0000)]
[Qt] Vastly improve the algorithm for finding a zoomable area when doing double-tap
https://bugs.webkit.org/show_bug.cgi?id=65907

Reviewed by Andreas Kling.

This is upstreaming of the algorithm we are currently using on the N9 browser
and this also fixes a bug with not considering the frame positions when finding
a zoomable area.

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFindZoomableArea):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/qdesktopwebpageproxy.cpp:
(QDesktopWebPageProxy::didFindZoomableArea):
* UIProcess/qt/qdesktopwebpageproxy.h:
* UIProcess/qt/qtouchwebpageproxy.cpp:
(QTouchWebPageProxy::didFindZoomableArea):
* UIProcess/qt/qtouchwebpageproxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findZoomableAreaForPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] remove temporary #define from WebURLRequest.h
jochen@chromium.org [Tue, 9 Aug 2011 13:32:29 +0000 (13:32 +0000)]
[chromium] remove temporary #define from WebURLRequest.h
https://bugs.webkit.org/show_bug.cgi?id=65813

Reviewed by Darin Fisher.

* public/WebURLRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: assertion failure in InspectorDOMStorageResource::bind when opening...
caseq@chromium.org [Tue, 9 Aug 2011 13:24:21 +0000 (13:24 +0000)]
Web Inspector: assertion failure in InspectorDOMStorageResource::bind when opening inspector
https://bugs.webkit.org/show_bug.cgi?id=65912

Reviewed by Pavel Feldman.

* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: get rid of InspectorInstrumentation::inspectorAgents() map
yurys@chromium.org [Tue, 9 Aug 2011 13:03:20 +0000 (13:03 +0000)]
Web Inspector: get rid of InspectorInstrumentation::inspectorAgents() map
https://bugs.webkit.org/show_bug.cgi?id=54678

Added two functions for retrieving InstrumentingAgents from Page and WorkerContext.

Reviewed by Pavel Feldman.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
* inspector/InspectorController.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::instrumentingAgentsForPage):
* inspector/InspectorInstrumentation.h:
* inspector/InstrumentingAgents.cpp: Copied from Source/WebCore/inspector/WorkerInspectorController.h.
(WebCore::instrumentationForPage):
(WebCore::instrumentationForWorkerContext):
* inspector/InstrumentingAgents.h:
* inspector/WorkerInspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: REGRESSION (r92672): http/tests/inspector/resource-main-cookies.php...
vsevik@chromium.org [Tue, 9 Aug 2011 12:26:28 +0000 (12:26 +0000)]
Web Inspector: REGRESSION (r92672): http/tests/inspector/resource-main-cookies.php failing on Qt Linux Release
https://bugs.webkit.org/show_bug.cgi?id=65911

Unreviewed. Skipped test failing on qt.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
jochen@chromium.org [Tue, 9 Aug 2011 12:17:06 +0000 (12:17 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Add "Refresh" to context menu of resources panel cookies view.
vsevik@chromium.org [Tue, 9 Aug 2011 10:39:27 +0000 (10:39 +0000)]
Web Inspector: Add "Refresh" to context menu of resources panel cookies view.
https://bugs.webkit.org/show_bug.cgi?id=65854

Reviewed by Pavel Feldman.

* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView):
(WebInspector.CookieItemsView.prototype._updateWithCookies):
(WebInspector.CookieItemsView.prototype._refreshButtonClicked):
(WebInspector.CookieItemsView.prototype._contextMenu):
* inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.get refreshCallback):
(WebInspector.DataGrid.prototype.set refreshCallback):
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
* inspector/front-end/ResourceCookiesView.js:
(WebInspector.ResourceCookiesView.prototype._buildCookiesTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-09 Andrei Popescu <andreip@google.com>
andreip@google.com [Tue, 9 Aug 2011 10:34:54 +0000 (10:34 +0000)]
2011-08-09  Andrei Popescu  <andreip@google.com>

        [Chromium] Update test expectations for fast/writing-mode/japanese-rl-text-with-broken-font.html

        Unreviewed gardening.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Resources panel does not show main resource cookies.
vsevik@chromium.org [Tue, 9 Aug 2011 10:33:54 +0000 (10:33 +0000)]
Web Inspector: Resources panel does not show main resource cookies.
https://bugs.webkit.org/show_bug.cgi?id=65770

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/resource-main-cookies.php

* inspector/InspectorPageAgent.cpp:
(WebCore::allResourcesURLsForFrame):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):

LayoutTests:

* http/tests/inspector/resource-main-cookies-expected.txt: Added.
* http/tests/inspector/resource-main-cookies.php: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r92670.
commit-queue@webkit.org [Tue, 9 Aug 2011 10:26:02 +0000 (10:26 +0000)]
Unreviewed, rolling out r92670.
http://trac.webkit.org/changeset/92670
https://bugs.webkit.org/show_bug.cgi?id=65905

It broke 3 inspector tests (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-09

Source/WebCore:

* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::getProperties):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.update):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.getOwnProperties):
(WebInspector.RemoteObject.prototype.getAllProperties):
(WebInspector.RemoteObject.prototype._getProperties.remoteObjectBinder):
(WebInspector.RemoteObject.prototype._getProperties):
(WebInspector.RemoteObjectProperty):
* inspector/front-end/inspector.css:
(.section .properties .value.dimmed):

LayoutTests:

* inspector/protocol/runtime-agent-expected.txt:
* inspector/runtime/runtime-getProperties-expected.txt:
* inspector/runtime/runtime-getProperties.html:
* platform/chromium/inspector/runtime/runtime-getProperties-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: there should be a way to tell what properties are non-enumerable when...
pfeldman@chromium.org [Tue, 9 Aug 2011 09:05:16 +0000 (09:05 +0000)]
Web Inspector: there should be a way to tell what properties are non-enumerable when expanding objects.
https://bugs.webkit.org/show_bug.cgi?id=65518

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::getProperties):
* inspector/InjectedScript.h:
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::getProperties):
* inspector/InspectorRuntimeAgent.h:
* inspector/front-end/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):
(WebInspector.ObjectPropertyTreeElement.prototype.update):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.getOwnProperties):
(WebInspector.RemoteObject.prototype.getAllProperties):
(WebInspector.RemoteObjectProperty):
* inspector/front-end/inspector.css:
(.section .properties .dimmed):

LayoutTests:

* inspector/protocol/runtime-agent-expected.txt:
* inspector/runtime/runtime-getProperties-expected.txt:
* inspector/runtime/runtime-getProperties.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
abarth@webkit.org [Tue, 9 Aug 2011 08:38:45 +0000 (08:38 +0000)]
BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=65891

Reviewed by Eric Seidel.

The problem was that platform/chromium contained a bogus expectation
file that needed to be removed, but by the time we got around to
removing it, we'd already moved the correct baseline into its place.
After this patch, we copy the gold results into memory before
reshuffling things on disk (and we delete bad things before adding good
things).

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-09 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 9 Aug 2011 08:34:02 +0000 (08:34 +0000)]
2011-08-09  Nikolas Zimmermann  <nzimmermann@rim.com>

        svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
        https://bugs.webkit.org/show_bug.cgi?id=63186

        Not reviewed. More gtk/win gardening.

        * platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Rebaseline, same result on both gtk 32 bit debug/release and 64bit.
        * platform/win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Taken from Win7 bot, WinXP still seems to have a problem.
        * platform/win/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
        * platform/win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAccidentally added build number as revision number in r92666.
reni@webkit.org [Tue, 9 Aug 2011 08:27:45 +0000 (08:27 +0000)]
Accidentally added build number as revision number in r92666.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt]REGRESSION(r22030): It made one test failed.
reni@webkit.org [Tue, 9 Aug 2011 07:49:14 +0000 (07:49 +0000)]
[Qt]REGRESSION(r22030): It made one test failed.

Unreviewed gardening.

* platform/qt-4.8/Skipped: Skip the failed test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoForgot to add the ChangeLog for r92545. Fixed.
zimmermann@webkit.org [Tue, 9 Aug 2011 07:14:24 +0000 (07:14 +0000)]
Forgot to add the ChangeLog for r92545. Fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Update baseline files for r92585.
tkent@chromium.org [Tue, 9 Aug 2011 04:08:08 +0000 (04:08 +0000)]
[Chromium] Update baseline files for r92585.

* platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] input-number-size.html is expected to fail because of no spin-button.
tkent@chromium.org [Tue, 9 Aug 2011 03:58:41 +0000 (03:58 +0000)]
[Windows] input-number-size.html is expected to fail because of no spin-button.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Grouping spin-button related tests.
tkent@chromium.org [Tue, 9 Aug 2011 03:55:54 +0000 (03:55 +0000)]
[Qt] Grouping spin-button related tests.
https://bugs.webkit.org/show_bug.cgi?id=65896

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium Windows bots can't figure out what SVN revision they're running
abarth@webkit.org [Tue, 9 Aug 2011 01:26:30 +0000 (01:26 +0000)]
Chromium Windows bots can't figure out what SVN revision they're running
https://bugs.webkit.org/show_bug.cgi?id=65893

Reviewed by Eric Seidel.

The comment in _engage_awesome_windows_hacks explains why we're making
this change.  It's ugly and rediculous, but this approach seems better
than using shell=True when calling popen.

* Scripts/webkitpy/common/checkout/scm/svn.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemoves V8's JavaInstanceJobject, JavaClassJobject and JavaFieldJobject.
steveblock@google.com [Tue, 9 Aug 2011 00:55:30 +0000 (00:55 +0000)]
Removes V8's JavaInstanceJobject, JavaClassJobject and JavaFieldJobject.
https://bugs.webkit.org/show_bug.cgi?id=57859

Reviewed by Alexey Proskuryakov.

This effectively reverts the changes made in Bugs 55383, 57533 and
55766. These classes were only used by Android. In the future, Android
will use the Chromium WebKit API to implement the Java bridge.

Towards this goal, this patch ...
- Simplfies the JavaInstance, JavaClass and JavaField interfaces for V8.
  These interfaces will be implemented in Chromium's WebKit layer.
- Adds a JavaMethod interface for V8
- Removes the jvalue <-> JavaValue conversion functions for V8, which are
  now superfluous
- Removes the calls to JavaInstance::begin()/end() for V8, which are now
  superfluous

Will be covered by existing tests once the Chromium WebKit layer is complete.

* WebCore.gypi:
* bridge/jni/v8/JNIUtilityPrivate.cpp:
* bridge/jni/v8/JNIUtilityPrivate.h:
* bridge/jni/v8/JavaClassJobjectV8.cpp: Removed.
* bridge/jni/v8/JavaFieldJobjectV8.cpp: Removed.
* bridge/jni/v8/JavaFieldJobjectV8.h: Removed.
* bridge/jni/v8/JavaFieldV8.h:
* bridge/jni/v8/JavaInstanceJobjectV8.cpp: Removed.
* bridge/jni/v8/JavaInstanceJobjectV8.h: Removed.
* bridge/jni/v8/JavaInstanceV8.h:
* bridge/jni/v8/JavaMethodV8.h:
(JSC::Bindings::JavaMethod::~JavaMethod):
* bridge/jni/v8/JavaNPObjectV8.cpp:
(JSC::Bindings::JavaNPObjectHasMethod):
(JSC::Bindings::JavaNPObjectInvoke):
(JSC::Bindings::JavaNPObjectHasProperty):
(JSC::Bindings::JavaNPObjectGetProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix thread-safety of AudioNode deletion
crogers@google.com [Tue, 9 Aug 2011 00:49:04 +0000 (00:49 +0000)]
Fix thread-safety of AudioNode deletion
https://bugs.webkit.org/show_bug.cgi?id=65888

Reviewed by Kenneth Russell

No new tests - JavaScript API is not affected.

* webaudio/AudioContext.cpp:
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::constructCommon):
(WebCore::AudioContext::~AudioContext):
(WebCore::AudioContext::uninitialize):
(WebCore::AudioContext::handlePostRenderTasks):
(WebCore::AudioContext::scheduleNodeDeletion):
(WebCore::AudioContext::deleteMarkedNodesDispatch):
(WebCore::AudioContext::deleteMarkedNodes):
* webaudio/AudioContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-08-08 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Tue, 9 Aug 2011 00:25:39 +0000 (00:25 +0000)]
2011-08-08  Chris Marrin  <cmarrin@apple.com>

        Fix build breakage caused by http://trac.webkit.org/changeset/92651

        Unreviewed.

        * WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove deduplicate-tests
abarth@webkit.org [Tue, 9 Aug 2011 00:19:35 +0000 (00:19 +0000)]
Remove deduplicate-tests
https://bugs.webkit.org/show_bug.cgi?id=65886

Reviewed by Tony Chang.

This script is redundant with "webkit-patch bulk-optimize-baselines",
which can find many more duplicates than deduplicate-tests because
bulk-optimize-baselines can move results around whereas
deduplicate-tests can only remove results.

* Scripts/deduplicate-tests: Removed.
* Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
* Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoscm.delete should delete empty parent directories as well
abarth@webkit.org [Tue, 9 Aug 2011 00:11:31 +0000 (00:11 +0000)]
scm.delete should delete empty parent directories as well
https://bugs.webkit.org/show_bug.cgi?id=65878

Reviewed by Eric Seidel.

This behavior makes SVN match GIT (which has no concept of empty
directories).  This bug comes up a lot when optimizing baselines, which
often create empty directories when we're able to optimize everything
out of a given folder.

* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
* Scripts/webkitpy/common/checkout/scm/svn.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThis should actually be the correct fix for
abarth@webkit.org [Tue, 9 Aug 2011 00:05:10 +0000 (00:05 +0000)]
This should actually be the correct fix for
fast/js/regexp-overflow.html.  The bug in bulk-optimize-baselines is
https://bugs.webkit.org/show_bug.cgi?id=65891.

* platform/chromium/fast/js/regexp-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd fast/js/regexp-overflow.html result back for Chromium. I'm not
abarth@webkit.org [Mon, 8 Aug 2011 23:34:44 +0000 (23:34 +0000)]
Add fast/js/regexp-overflow.html result back for Chromium.  I'm not
sure why bulk-rebaseline-tests remove it.  There's some bug in the
script I need to track down.

* platform/chromium/fast/js/regexp-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, mark gradient-after-transparent-border.html as failed on chromium.
jianli@chromium.org [Mon, 8 Aug 2011 23:32:07 +0000 (23:32 +0000)]
Unreviewed, mark gradient-after-transparent-border.html as failed on chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLogic to compute visible display rect in GraphicsLayerCA::syncCompositingState
cmarrin@apple.com [Mon, 8 Aug 2011 23:21:16 +0000 (23:21 +0000)]
Logic to compute visible display rect in GraphicsLayerCA::syncCompositingState
https://bugs.webkit.org/show_bug.cgi?id=65708

Source/WebCore:

Add logic to syncCompositingState to compute the visible rect for each
layer. This can be used to synchronously render the visible tiles of a
TiledLayer and avoid the flashing that often occurs when tiles are rendered
asynchronously. A new synchronouslyDisplayTilesInRect is also added to do
the actual rendering, but the call is not currently being made.

Reviewed by Simon Fraser.

* page/FrameView.cpp:
(WebCore::FrameView::syncCompositingStateForThisFrame):
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::syncCompositingState):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::syncCompositingState):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::synchronouslyDisplayTilesInRect):
* platform/graphics/transforms/TransformState.cpp:
(WebCore::TransformState::operator=):
* platform/graphics/transforms/TransformState.h:
(WebCore::TransformState::TransformState):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

Source/WebKit/mac:

Supply initial display rects for the full-screen case

Reviewed by Simon Fraser.

* WebView/WebFullScreenController.mm:
(-[WebFullScreenController enterFullscreen:]):
(-[WebFullScreenController exitFullscreen]):

Source/WebKit2:

Supply initial display rects for the full-screen case

Reviewed by Simon Fraser.

* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
(WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation):
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize baselines for fast/js.
abarth@webkit.org [Mon, 8 Aug 2011 22:55:20 +0000 (22:55 +0000)]
Optimize baselines for fast/js.
This patch was created with webkit-patch bulk-optimize-baselines.

* fast/js/exception-linenums-in-html-3-expected.txt: Added.
* fast/js/global-constructors-expected.txt: Removed.
* fast/js/missing-style-end-tag-js-expected.txt: Added.
* platform/chromium-mac/fast/js/array-every-expected.txt: Removed.
* platform/chromium-mac/fast/js/array-foreach-expected.txt: Removed.
* platform/chromium-mac/fast/js/array-functions-non-arrays-expected.txt: Removed.
* platform/chromium-mac/fast/js/array-some-expected.txt: Removed.
* platform/chromium-mac/fast/js/assign-expected.txt: Removed.
* platform/chromium-mac/fast/js/break-ASI-expected.txt: Removed.
* platform/chromium-mac/fast/js/const-expected.txt: Removed.
* platform/chromium-mac/fast/js/constructor-attributes-expected.txt: Removed.
* platform/chromium-mac/fast/js/cyclic-proto-expected.txt: Removed.
* platform/chromium-mac/fast/js/cyclic-prototypes-expected.txt: Removed.
* platform/chromium-mac/fast/js/date-proto-generic-invocation-expected.txt: Removed.
* platform/chromium-mac/fast/js/date-toisostring-expected.txt: Removed.
* platform/chromium-mac/fast/js/deep-recursion-test-expected.txt: Removed.
* platform/chromium-mac/fast/js/delete-getters-setters-expected.txt: Removed.
* platform/chromium-mac/fast/js/exception-codegen-crash-expected.txt: Removed.
* platform/chromium-mac/fast/js/exception-for-nonobject-expected.txt: Removed.
* platform/chromium-mac/fast/js/exception-sequencing-binops2-expected.txt: Removed.
* platform/chromium-mac/fast/js/exception-thrown-from-new-expected.txt: Removed.
* platform/chromium-mac/fast/js/exceptions-thrown-in-callbacks-expected.txt: Removed.
* platform/chromium-mac/fast/js/function-declaration-expected.txt: Removed.
* platform/chromium-mac/fast/js/function-dot-arguments-and-caller-expected.txt: Removed.
* platform/chromium-mac/fast/js/function-prototype-descriptor-expected.txt: Removed.
* platform/chromium-mac/fast/js/function-toString-object-literals-expected.txt: Removed.
* platform/chromium-mac/fast/js/function-toString-parentheses-expected.txt: Removed.
* platform/chromium-mac/fast/js/function-toString-semicolon-insertion-expected.txt: Removed.
* platform/chromium-mac/fast/js/instance-of-immediates-expected.txt: Removed.
* platform/chromium-mac/fast/js/invalid-syntax-for-function-expected.txt: Removed.
* platform/chromium-mac/fast/js/js-continue-break-restrictions-expected.txt: Removed.
* platform/chromium-mac/fast/js/kde/RegExp-expected.txt: Removed.
* platform/chromium-mac/fast/js/kde/StringObject-expected.txt: Removed.
* platform/chromium-mac/fast/js/kde/encode_decode_uri-expected.txt: Removed.
* platform/chromium-mac/fast/js/kde/function-expected.txt: Removed.
* platform/chromium-mac/fast/js/kde/garbage-n-expected.txt: Removed.
* platform/chromium-mac/fast/js/kde/lval-exceptions-expected.txt: Removed.
* platform/chromium-mac/fast/js/kde/parse-expected.txt: Removed.
* platform/chromium-mac/fast/js/kde/string-1-n-expected.txt: Removed.
* platform/chromium-mac/fast/js/kde/string-2-n-expected.txt: Removed.
* platform/chromium-mac/fast/js/modify-non-references-expected.txt: Removed.
* platform/chromium-mac/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Removed.
* platform/chromium-mac/fast/js/number-toString-expected.txt: Removed.
* platform/chromium-mac/fast/js/number-tofixed-expected.txt: Removed.
* platform/chromium-mac/fast/js/object-extra-comma-expected.txt: Removed.
* platform/chromium-mac/fast/js/postfix-syntax-expected.txt: Removed.
* platform/chromium-mac/fast/js/prefix-syntax-expected.txt: Removed.
* platform/chromium-mac/fast/js/regexp-compile-crash-expected.txt: Removed.
* platform/chromium-mac/fast/js/regexp-compile-expected.txt: Removed.
* platform/chromium-mac/fast/js/regexp-no-extensions-expected.txt: Removed.
* platform/chromium-mac/fast/js/regexp-overflow-expected.txt: Removed.
* platform/chromium-mac/fast/js/regexp-range-out-of-order-expected.txt: Removed.
* platform/chromium-mac/fast/js/regexp-test-null-string-expected.txt: Removed.
* platform/chromium-mac/fast/js/string-capitalization-expected.txt: Removed.
* platform/chromium-mac/fast/js/toString-and-valueOf-override-expected.txt: Removed.
* platform/chromium-mac/fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Removed.
* platform/chromium-mac/fast/js/toString-stack-overflow-expected.txt: Removed.
* platform/chromium-mac/fast/js/uncaught-exception-line-number-expected.txt: Removed.
* platform/chromium-win/fast/js/array-every-expected.txt: Removed.
* platform/chromium-win/fast/js/array-foreach-expected.txt: Removed.
* platform/chromium-win/fast/js/array-functions-non-arrays-expected.txt: Removed.
* platform/chromium-win/fast/js/array-some-expected.txt: Removed.
* platform/chromium-win/fast/js/assign-expected.txt: Removed.
* platform/chromium-win/fast/js/break-ASI-expected.txt: Removed.
* platform/chromium-win/fast/js/const-expected.txt: Removed.
* platform/chromium-win/fast/js/constructor-attributes-expected.txt: Removed.
* platform/chromium-win/fast/js/cyclic-proto-expected.txt: Removed.
* platform/chromium-win/fast/js/cyclic-prototypes-expected.txt: Removed.
* platform/chromium-win/fast/js/date-proto-generic-invocation-expected.txt: Removed.
* platform/chromium-win/fast/js/date-toisostring-expected.txt: Removed.
* platform/chromium-win/fast/js/deep-recursion-test-expected.txt: Removed.
* platform/chromium-win/fast/js/delete-getters-setters-expected.txt: Removed.
* platform/chromium-win/fast/js/exception-codegen-crash-expected.txt: Removed.
* platform/chromium-win/fast/js/exception-for-nonobject-expected.txt: Removed.
* platform/chromium-win/fast/js/exception-sequencing-binops2-expected.txt: Removed.
* platform/chromium-win/fast/js/exception-thrown-from-new-expected.txt: Removed.
* platform/chromium-win/fast/js/exceptions-thrown-in-callbacks-expected.txt: Removed.
* platform/chromium-win/fast/js/function-declaration-expected.txt: Removed.
* platform/chromium-win/fast/js/function-dot-arguments-and-caller-expected.txt: Removed.
* platform/chromium-win/fast/js/function-prototype-descriptor-expected.txt: Removed.
* platform/chromium-win/fast/js/function-toString-object-literals-expected.txt: Removed.
* platform/chromium-win/fast/js/function-toString-parentheses-expected.txt: Removed.
* platform/chromium-win/fast/js/function-toString-semicolon-insertion-expected.txt: Removed.
* platform/chromium-win/fast/js/instance-of-immediates-expected.txt: Removed.
* platform/chromium-win/fast/js/invalid-syntax-for-function-expected.txt: Removed.
* platform/chromium-win/fast/js/js-continue-break-restrictions-expected.txt: Removed.
* platform/chromium-win/fast/js/kde/RegExp-expected.txt: Removed.
* platform/chromium-win/fast/js/kde/StringObject-expected.txt: Removed.
* platform/chromium-win/fast/js/kde/encode_decode_uri-expected.txt: Removed.
* platform/chromium-win/fast/js/kde/function-expected.txt: Removed.
* platform/chromium-win/fast/js/kde/garbage-n-expected.txt: Removed.
* platform/chromium-win/fast/js/kde/lval-exceptions-expected.txt: Removed.
* platform/chromium-win/fast/js/kde/parse-expected.txt: Removed.
* platform/chromium-win/fast/js/kde/string-1-n-expected.txt: Removed.
* platform/chromium-win/fast/js/kde/string-2-n-expected.txt: Removed.
* platform/chromium-win/fast/js/modify-non-references-expected.txt: Removed.
* platform/chromium-win/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Removed.
* platform/chromium-win/fast/js/number-toString-expected.txt: Removed.
* platform/chromium-win/fast/js/number-tofixed-expected.txt: Removed.
* platform/chromium-win/fast/js/object-extra-comma-expected.txt: Removed.
* platform/chromium-win/fast/js/postfix-syntax-expected.txt: Removed.
* platform/chromium-win/fast/js/prefix-syntax-expected.txt: Removed.
* platform/chromium-win/fast/js/regexp-compile-crash-expected.txt: Removed.
* platform/chromium-win/fast/js/regexp-compile-expected.txt: Removed.
* platform/chromium-win/fast/js/regexp-no-extensions-expected.txt: Removed.
* platform/chromium-win/fast/js/regexp-overflow-expected.txt: Removed.
* platform/chromium-win/fast/js/regexp-range-out-of-order-expected.txt: Removed.
* platform/chromium-win/fast/js/regexp-test-null-string-expected.txt: Removed.
* platform/chromium-win/fast/js/string-capitalization-expected.txt: Removed.
* platform/chromium-win/fast/js/toString-and-valueOf-override-expected.txt: Removed.
* platform/chromium-win/fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Removed.
* platform/chromium-win/fast/js/toString-stack-overflow-expected.txt: Removed.
* platform/chromium-win/fast/js/uncaught-exception-line-number-expected.txt: Removed.
* platform/chromium/fast/js/array-every-expected.txt: Added.
* platform/chromium/fast/js/array-foreach-expected.txt: Added.
* platform/chromium/fast/js/array-functions-non-arrays-expected.txt: Added.
* platform/chromium/fast/js/array-some-expected.txt: Added.
* platform/chromium/fast/js/assign-expected.txt: Added.
* platform/chromium/fast/js/break-ASI-expected.txt: Added.
* platform/chromium/fast/js/const-expected.txt: Added.
* platform/chromium/fast/js/constructor-attributes-expected.txt: Added.
* platform/chromium/fast/js/cyclic-proto-expected.txt: Added.
* platform/chromium/fast/js/cyclic-prototypes-expected.txt: Added.
* platform/chromium/fast/js/date-proto-generic-invocation-expected.txt: Added.
* platform/chromium/fast/js/date-toisostring-expected.txt: Added.
* platform/chromium/fast/js/deep-recursion-test-expected.txt: Added.
* platform/chromium/fast/js/delete-getters-setters-expected.txt: Added.
* platform/chromium/fast/js/exception-codegen-crash-expected.txt: Added.
* platform/chromium/fast/js/exception-for-nonobject-expected.txt: Added.
* platform/chromium/fast/js/exception-sequencing-binops2-expected.txt: Added.
* platform/chromium/fast/js/exception-thrown-from-new-expected.txt: Added.
* platform/chromium/fast/js/exceptions-thrown-in-callbacks-expected.txt: Added.
* platform/chromium/fast/js/function-declaration-expected.txt: Added.
* platform/chromium/fast/js/function-dot-arguments-and-caller-expected.txt: Added.
* platform/chromium/fast/js/function-prototype-descriptor-expected.txt: Added.
* platform/chromium/fast/js/function-toString-object-literals-expected.txt: Added.
* platform/chromium/fast/js/function-toString-parentheses-expected.txt: Added.
* platform/chromium/fast/js/function-toString-semicolon-insertion-expected.txt: Added.
* platform/chromium/fast/js/instance-of-immediates-expected.txt: Added.
* platform/chromium/fast/js/invalid-syntax-for-function-expected.txt: Added.
* platform/chromium/fast/js/js-continue-break-restrictions-expected.txt: Added.
* platform/chromium/fast/js/kde: Added.
* platform/chromium/fast/js/kde/RegExp-expected.txt: Added.
* platform/chromium/fast/js/kde/StringObject-expected.txt: Added.
* platform/chromium/fast/js/kde/encode_decode_uri-expected.txt: Added.
* platform/chromium/fast/js/kde/function-expected.txt: Added.
* platform/chromium/fast/js/kde/garbage-n-expected.txt: Added.
* platform/chromium/fast/js/kde/lval-exceptions-expected.txt: Added.
* platform/chromium/fast/js/kde/parse-expected.txt: Added.
* platform/chromium/fast/js/kde/string-1-n-expected.txt: Added.
* platform/chromium/fast/js/kde/string-2-n-expected.txt: Added.
* platform/chromium/fast/js/modify-non-references-expected.txt: Added.
* platform/chromium/fast/js/mozilla/strict/11.1.5-expected.txt: Removed.
* platform/chromium/fast/js/no-semi-insertion-at-end-of-script-expected.txt: Added.
* platform/chromium/fast/js/number-toString-expected.txt: Added.
* platform/chromium/fast/js/number-tofixed-expected.txt: Added.
* platform/chromium/fast/js/object-extra-comma-expected.txt: Added.
* platform/chromium/fast/js/postfix-syntax-expected.txt: Added.
* platform/chromium/fast/js/prefix-syntax-expected.txt: Added.
* platform/chromium/fast/js/regexp-compile-crash-expected.txt: Added.
* platform/chromium/fast/js/regexp-compile-expected.txt: Added.
* platform/chromium/fast/js/regexp-no-extensions-expected.txt: Added.
* platform/chromium/fast/js/regexp-overflow-expected.txt: Removed.
* platform/chromium/fast/js/regexp-range-out-of-order-expected.txt: Added.
* platform/chromium/fast/js/regexp-test-null-string-expected.txt: Added.
* platform/chromium/fast/js/string-capitalization-expected.txt: Added.
* platform/chromium/fast/js/toString-and-valueOf-override-expected.txt: Added.
* platform/chromium/fast/js/toString-prefix-postfix-preserve-parens-expected.txt: Added.
* platform/chromium/fast/js/toString-stack-overflow-expected.txt: Added.
* platform/chromium/fast/js/uncaught-exception-line-number-expected.txt: Added.
* platform/gtk/fast/js/exception-linenums-in-html-3-expected.txt: Removed.
* platform/gtk/fast/js/missing-style-end-tag-js-expected.txt: Removed.
* platform/mac/fast/js/exception-linenums-in-html-3-expected.txt: Removed.
* platform/mac/fast/js/global-constructors-expected.txt: Added.
* platform/mac/fast/js/missing-style-end-tag-js-expected.txt: Removed.
* platform/qt/fast/js/exception-linenums-in-html-3-expected.txt: Removed.
* platform/qt/fast/js/missing-style-end-tag-js-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd triggers for Lion WK2 test bots.
lforschler@apple.com [Mon, 8 Aug 2011 22:49:52 +0000 (22:49 +0000)]
Add triggers for Lion WK2 test bots.

Reviewed by Stephanie Lewis.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize baselines for fast/inspector-support.
abarth@webkit.org [Mon, 8 Aug 2011 22:29:33 +0000 (22:29 +0000)]
Optimize baselines for fast/inspector-support.
This patch was created with webkit-patch bulk-optimize-baselines.

* fast/inspector-support/style-expected.txt: Added.
* platform/chromium-mac/fast/inspector-support: Removed.
* platform/chromium-mac/fast/inspector-support/uncaught-dom1-exception-expected.txt: Removed.
* platform/chromium-mac/fast/inspector-support/uncaught-dom3-exception-expected.txt: Removed.
* platform/chromium-mac/fast/inspector-support/uncaught-dom8-exception-expected.txt: Removed.
* platform/chromium-win/fast/inspector-support/uncaught-dom1-exception-expected.txt: Removed.
* platform/chromium-win/fast/inspector-support/uncaught-dom3-exception-expected.txt: Removed.
* platform/chromium-win/fast/inspector-support/uncaught-dom8-exception-expected.txt: Removed.
* platform/chromium/fast/inspector-support: Added.
* platform/chromium/fast/inspector-support/uncaught-dom1-exception-expected.txt: Added.
* platform/chromium/fast/inspector-support/uncaught-dom3-exception-expected.txt: Added.
* platform/chromium/fast/inspector-support/uncaught-dom8-exception-expected.txt: Added.
* platform/gtk/fast/inspector-support/style-expected.txt: Removed.
* platform/mac/fast/inspector-support/style-expected.txt: Removed.
* platform/qt/fast/inspector-support/style-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize baselines for fast/dom/HTMLAnchorElement and fast/dom/Window.
abarth@webkit.org [Mon, 8 Aug 2011 22:24:01 +0000 (22:24 +0000)]
Optimize baselines for fast/dom/HTMLAnchorElement and fast/dom/Window.
This patch was created with webkit-patch bulk-optimize-baselines.
(Note: I massaged the two results that enumerate the global object to
leave the "base" results as matching mac even though the tool wanted to
push those results down into the mac directory.)

* platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Removed.
* platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt: Removed.
* platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Removed.
* platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Removed.
* platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt: Removed.
* platform/chromium-mac/fast/dom/Window/element-constructors-on-window-expected.txt: Removed.
* platform/chromium-mac/fast/dom/Window/get-set-properties-expected.txt: Removed.
* platform/chromium-mac/fast/dom/Window/window-custom-prototype-expected.txt: Removed.
* platform/chromium-mac/fast/dom/Window/window-postmessage-args-expected.txt: Removed.
* platform/chromium-mac/fast/dom/Window/window-properties-device-orientation-expected.txt: Removed.
* platform/chromium-mac/fast/dom/Window/window-properties-geolocation-expected.txt: Removed.
* platform/chromium-mac/fast/dom/Window/window-property-shadowing-expected.txt: Removed.
* platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Removed.
* platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Removed.
* platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Removed.
* platform/chromium-win/fast/dom/Window/element-constructors-on-window-expected.txt: Removed.
* platform/chromium-win/fast/dom/Window/get-set-properties-expected.txt: Removed.
* platform/chromium-win/fast/dom/Window/window-custom-prototype-expected.txt: Removed.
* platform/chromium-win/fast/dom/Window/window-postmessage-args-expected.txt: Removed.
* platform/chromium-win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
* platform/chromium-win/fast/dom/Window/window-properties-device-orientation-expected.txt: Removed.
* platform/chromium-win/fast/dom/Window/window-properties-geolocation-expected.txt: Removed.
* platform/chromium-win/fast/dom/Window/window-property-shadowing-expected.txt: Removed.
* platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Added.
* platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-hostname-expected.txt: Added.
* platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Added.
* platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-port-expected.txt: Added.
* platform/chromium/fast/dom/HTMLAnchorElement/set-href-attribute-search-expected.txt: Added.
* platform/chromium/fast/dom/Window/element-constructors-on-window-expected.txt: Added.
* platform/chromium/fast/dom/Window/get-set-properties-expected.txt: Added.
* platform/chromium/fast/dom/Window/window-custom-prototype-expected.txt: Added.
* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt: Added.
* platform/chromium/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Removed.
* platform/chromium/fast/dom/Window/window-properties-device-orientation-expected.txt: Added.
* platform/chromium/fast/dom/Window/window-properties-geolocation-expected.txt: Added.
* platform/chromium/fast/dom/Window/window-property-shadowing-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize baselines for fast/dom/DOMException.
abarth@webkit.org [Mon, 8 Aug 2011 22:18:38 +0000 (22:18 +0000)]
Optimize baselines for fast/dom/DOMException.
This patch was created with webkit-patch bulk-optimize-baselines.
(I've manually remove the README file because we don't use these sorts
of README files anymore.)

* platform/chromium-mac/fast/dom/DOMException: Removed.
* platform/chromium-mac/fast/dom/DOMException/EventException-expected.txt: Removed.
* platform/chromium-mac/fast/dom/DOMException/README: Removed.
* platform/chromium-mac/fast/dom/DOMException/RangeException-expected.txt: Removed.
* platform/chromium-mac/fast/dom/DOMException/XPathException-expected.txt: Removed.
* platform/chromium-mac/fast/dom/DOMException/prototype-object-expected.txt: Removed.
* platform/chromium-win/fast/dom/DOMException: Removed.
* platform/chromium-win/fast/dom/DOMException/EventException-expected.txt: Removed.
* platform/chromium-win/fast/dom/DOMException/README: Removed.
* platform/chromium-win/fast/dom/DOMException/RangeException-expected.txt: Removed.
* platform/chromium-win/fast/dom/DOMException/XPathException-expected.txt: Removed.
* platform/chromium-win/fast/dom/DOMException/prototype-object-expected.txt: Removed.
* platform/chromium/fast/dom/DOMException: Added.
* platform/chromium/fast/dom/DOMException/EventException-expected.txt: Added.
* platform/chromium/fast/dom/DOMException/RangeException-expected.txt: Added.
* platform/chromium/fast/dom/DOMException/XPathException-expected.txt: Added.
* platform/chromium/fast/dom/DOMException/prototype-object-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r92619.
commit-queue@webkit.org [Mon, 8 Aug 2011 22:17:46 +0000 (22:17 +0000)]
Unreviewed, rolling out r92619.
http://trac.webkit.org/changeset/92619
https://bugs.webkit.org/show_bug.cgi?id=65881

This patch breaks chromium canary (Requested by jianli on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-08

Source/WebCore:

* bindings/v8/V8Binding.h:
* bindings/v8/V8GCController.cpp:
(WebCore::globalHandleMap):
(WebCore::enumerateGlobalHandles):
(WebCore::V8GCController::registerGlobalHandle):
(WebCore::V8GCController::unregisterGlobalHandle):
* bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::V8HiddenPropertyName::createString):
* bindings/v8/V8HiddenPropertyName.h:
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8NPObject.cpp:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::checkNewLegal):
* bindings/v8/V8Utilities.h:
(WebCore::AllowAllocation::AllowAllocation):
(WebCore::AllowAllocation::~AllowAllocation):
(WebCore::SafeAllocation::newInstance):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initV8):
* bindings/v8/WorkerContextExecutionProxy.h:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::scheduleExecutionTermination):

Source/WebKit/chromium:

* src/BoundObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agobulk-optimize-baselines should take directories on the command line
abarth@webkit.org [Mon, 8 Aug 2011 22:04:34 +0000 (22:04 +0000)]
bulk-optimize-baselines should take directories on the command line
https://bugs.webkit.org/show_bug.cgi?id=65879

Reviewed by Dimitri Glazkov.

Passing lists of tests via stdin is a pain.  It's easier if the command
takes a list of tests on the command line, like run-webkit-tests.

* Scripts/webkitpy/tool/commands/rebaseline.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScroll animator changes to nail the framerate
commit-queue@webkit.org [Mon, 8 Aug 2011 22:01:15 +0000 (22:01 +0000)]
Scroll animator changes to nail the framerate
https://bugs.webkit.org/show_bug.cgi?id=65645

Patch by Scott Byer <scottbyer@chromium.org> on 2011-08-08
Reviewed by James Robinson.

Source/WebCore:

Partial test in ScrollAnimatorNoneTest::Enabled.

* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::PerAxisData::PerAxisData):
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
(WebCore::ScrollAnimatorNone::PerAxisData::animateScroll):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::~ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
(WebCore::ScrollAnimatorNone::stopAnimationTimerIfNeeded):
* platform/ScrollAnimatorNone.h:

Source/WebKit/chromium:

* tests/ScrollAnimatorNoneTest.cpp:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch legacy flexbox to to new layout types
eae@chromium.org [Mon, 8 Aug 2011 21:53:39 +0000 (21:53 +0000)]
Switch legacy flexbox to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=65340

Reviewed by Eric Seidel.

No new tests, no new functionality.

* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::calcHorizontalPrefWidths):
(WebCore::RenderDeprecatedFlexibleBox::calcVerticalPrefWidths):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::placeChild):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):
* rendering/RenderDeprecatedFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDeprecate rebaseline-chromium-webkit-tests
abarth@webkit.org [Mon, 8 Aug 2011 21:37:55 +0000 (21:37 +0000)]
Deprecate rebaseline-chromium-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=65873

Reviewed by Dimitri Glazkov.

This script never worked correctly and now is redundant with more
modern infrastructure for rebaselining tests.  This patch deprecates
the script in order to flush out any issues with the new tools.  Once
folks are happy with the new tools, we'll delete this script.

* Scripts/rebaseline-chromium-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agogarden-o-matic should only touch expectations that need updating.
dglazkov@chromium.org [Mon, 8 Aug 2011 21:35:08 +0000 (21:35 +0000)]
garden-o-matic should only touch expectations that need updating.
https://bugs.webkit.org/show_bug.cgi?id=65876

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,
    so that a caller could influence which lines to serialize from values.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
* Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUsing mprotect to create guard pages breaks our use of madvise to release executable...
oliver@apple.com [Mon, 8 Aug 2011 21:28:53 +0000 (21:28 +0000)]
Using mprotect to create guard pages breaks our use of madvise to release executable memory
https://bugs.webkit.org/show_bug.cgi?id=65870

Reviewed by Gavin Barraclough.

Use mmap rather than mprotect to clear guard page permissions.

* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTestExpectationsEditor should return a list of updated expectations.
dglazkov@chromium.org [Mon, 8 Aug 2011 21:28:03 +0000 (21:28 +0000)]
TestExpectationsEditor should return a list of updated expectations.
https://bugs.webkit.org/show_bug.cgi?id=65872

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, mark preventExtensions.html as failed on chromium.
jianli@chromium.org [Mon, 8 Aug 2011 21:07:33 +0000 (21:07 +0000)]
Unreviewed, mark preventExtensions.html as failed on chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix SCM webkitpy unit test failures
abarth@webkit.org [Mon, 8 Aug 2011 21:04:31 +0000 (21:04 +0000)]
Fix SCM webkitpy unit test failures
https://bugs.webkit.org/show_bug.cgi?id=65823

Patch by Jochen Eisinger <jochen@chromium.org> on 2011-08-08
Reviewed by Eric Seidel.

* Scripts/webkitpy/common/checkout/scm/git.py:
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch RenderStyle to to new layout types
eae@chromium.org [Mon, 8 Aug 2011 20:49:33 +0000 (20:49 +0000)]
Switch RenderStyle to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=65208

Reviewed by Eric Seidel.

No new tests, no new functionality.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::addShadowOverflow):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::applyTransform):
(WebCore::calcRadiiFor):
(WebCore::RenderStyle::getRoundedBorderFor):
(WebCore::RenderStyle::getRoundedInnerBorderFor):
* rendering/style/RenderStyle.h:
* rendering/style/ShadowData.cpp:
(WebCore::ShadowData::adjustRectForShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove counter nodes from the tree and fix-up children when they are removed from...
cdn@chromium.org [Mon, 8 Aug 2011 20:39:23 +0000 (20:39 +0000)]
Remove counter nodes from the tree and fix-up children when they are removed from the counter map.
https://bugs.webkit.org/show_bug.cgi?id=65346

Reviewed by Adam Barth.

Covered by existing CSS counter tests.

* rendering/CounterNode.cpp:
(WebCore::CounterNode::~CounterNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove the --leaks bot back over to NRWT now that I'm back
eric@webkit.org [Mon, 8 Aug 2011 20:37:24 +0000 (20:37 +0000)]
Move the --leaks bot back over to NRWT now that I'm back
from vacation and able to debug it.

Unreviewed.

* Scripts/run-webkit-tests:
(usingWebKit2):
(useNewRunWebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoimplement basic horizontal flexing
tony@chromium.org [Mon, 8 Aug 2011 20:29:40 +0000 (20:29 +0000)]
implement basic horizontal flexing
https://bugs.webkit.org/show_bug.cgi?id=65045

Reviewed by David Hyatt.

Source/WebCore:

Test: css3/flexbox/001.html

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidth):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::FlexibleBoxIterator::FlexibleBoxIterator): flexitem iterator
(WebCore::RenderFlexibleBox::FlexibleBoxIterator::first):
(WebCore::RenderFlexibleBox::FlexibleBoxIterator::next):
(WebCore::RenderFlexibleBox::FlexibleBoxIterator::reset):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::preferredFlexItemContentWidth): Returns the intrinsic size of a flex item's content.
(WebCore::RenderFlexibleBox::layoutHorizontalBlock): Runs the flex algorithm
(WebCore::preferredSizeForMarginsAndPadding):
(WebCore::RenderFlexibleBox::computePreferredSize): Calculate the preferred size of the
    flex items.
* rendering/RenderFlexibleBox.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
* rendering/style/RenderStyleConstants.h:

LayoutTests:

* css3/flexbox/001-expected.txt: Added.
* css3/flexbox/001.html: Added.
* css3/flexbox/resources/flexbox.js: Added. I plan on using this file for other tests.
(insertAfter):
(checkHorizontalBoxen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd detail to ASSERT message in IDBTransaction::enqueueEvent
commit-queue@webkit.org [Mon, 8 Aug 2011 20:18:33 +0000 (20:18 +0000)]
Add detail to ASSERT message in IDBTransaction::enqueueEvent
https://bugs.webkit.org/show_bug.cgi?id=65735

I've hit this a few times but haven't been able to pin it down.  The
extra detail could be helpful.

Patch by David Grogan <dgrogan@chromium.org> on 2011-08-08
Reviewed by Nate Chapin.

No new tests, just an error message.

* storage/IDBTransaction.cpp:
(WebCore::IDBTransaction::enqueueEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r92610.
commit-queue@webkit.org [Mon, 8 Aug 2011 20:13:48 +0000 (20:13 +0000)]
Unreviewed, rolling out r92610.
http://trac.webkit.org/changeset/92610
https://bugs.webkit.org/show_bug.cgi?id=65868

Caused assertion failures when running fast/multicol tests
(Requested by andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-08

PerformanceTests:

* Layout/floats.html:

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:
* platform/PODIntervalTree.h:
(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::searchForOverlapsFrom):
* platform/PODRedBlackTree.h:
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addPositionedFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::FloatingObjects::clear):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::set):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename absoluteQuadsForRange and InlineTextBox::selectionRect to local*
eae@chromium.org [Mon, 8 Aug 2011 20:11:22 +0000 (20:11 +0000)]
Rename absoluteQuadsForRange and InlineTextBox::selectionRect to local*
https://bugs.webkit.org/show_bug.cgi?id=65722

Reviewed by Simon Fraser.

No new tests, no new functionality.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::localSelectionRect):
Rename InlineTextBox::selectionRect to localSelectionRect to reflect that
it, unlike RenderObject::selectionRect returns a rect in the local
coordinate space.

* rendering/InlineTextBox.h:
* rendering/RenderText.cpp:
(WebCore::localQuadForTextBox):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::RenderText::selectionRectForRepaint):
Rename absoluteQuadForTextBox to localQuadForTextBox to reflect that it
returns a quad in the local coordinate space.

* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::localSelectionRect):
* rendering/svg/SVGInlineTextBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWire up updating expectations in garden-o-matic.
dglazkov@chromium.org [Mon, 8 Aug 2011 19:59:31 +0000 (19:59 +0000)]
Wire up updating expectations in garden-o-matic.
https://bugs.webkit.org/show_bug.cgi?id=65794

Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
* Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
* Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse a raw pointer to the security origin in the ctor of FrameLoadRequest
jochen@chromium.org [Mon, 8 Aug 2011 19:54:46 +0000 (19:54 +0000)]
Use a raw pointer to the security origin in the ctor of FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=65852

Reviewed by Alexey Proskuryakov.

* loader/FrameLoadRequest.h:
(WebCore::FrameLoadRequest::FrameLoadRequest):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::changeLocation):
* loader/FrameLoader.h:
* loader/NavigationScheduler.cpp:
(WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
(WebCore::ScheduledURLNavigation::fire):
(WebCore::ScheduledRedirect::ScheduledRedirect):
(WebCore::ScheduledLocationChange::ScheduledLocationChange):
(WebCore::ScheduledRefresh::ScheduledRefresh):
(WebCore::NavigationScheduler::scheduleLocationChange):
* loader/NavigationScheduler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebView::performLayeredWindowUpdate() crashes with
bfulgham@webkit.org [Mon, 8 Aug 2011 19:41:12 +0000 (19:41 +0000)]
WebView::performLayeredWindowUpdate() crashes with
NULL pointer when using layered window updates.
https://bugs.webkit.org/show_bug.cgi?id=60618

Reviewed by Adam Roben.

During resize operations, the backing store will be destroyed if
the window's size (either height or width) is set to zero. The
bug was identified when a user first resized a WebView to zero
dimensions, then attempted to perform a MoveWindow. The paint
message triggered by the MoveWindow attempted to use the layered
window update logic, which encountered the nulled backing store.

* WebView.cpp:
(WebView::performLayeredWindowUpdate): Add an early
 return when there is no backing store to blend with.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove redundant inline styles from the pasted contents more aggressively
rniwa@webkit.org [Mon, 8 Aug 2011 19:15:16 +0000 (19:15 +0000)]
Remove redundant inline styles from the pasted contents more aggressively
https://bugs.webkit.org/show_bug.cgi?id=65833

Reviewed by Tony Chang.

Source/WebCore:

Make removeRedundantStylesAndKeepStyleSpanInline more aggressively remove redundant styles by realizing that
when an editing inheritable property in an inline style declaration of an element can be safely removed
if it is present either in style rules or in its ancestor and not overridden by style rules or default style
of the element.

Test: editing/pasteboard/paste-with-redundant-style.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::pseudoStyleRulesForElement): Do not match author style sheets if AuthorCSSRules
is not included in the rules to include. This is used in EditingStyle::removePropertiesInElementDefaultStyle.
* editing/ApplyStyleCommand.cpp:
(WebCore::isStyleSpanOrSpanWithOnlyStyleAttribute): Added; returns true if the element is a style span or
span possibly with a style attribute.
* editing/ApplyStyleCommand.h:
* editing/EditingStyle.cpp:
(WebCore::styleFromMatchedRulesForElement): Takes rulesToInclude.
(WebCore::EditingStyle::mergeStyleFromRules): Calls styleFromMatchedRulesForElement with AuthorCSSRules
| CrossOriginCSSRules to keep the original behavior.
(WebCore::EditingStyle::removeStyleFromRulesAndContext): Renamed from removeStyleFromRules; removes styles that
are present in context and not overridden by matched rules.
(WebCore::EditingStyle::removePropertiesInElementDefaultStyle): Added.
* editing/EditingStyle.h:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): See the description above.

LayoutTests:

Added a test to paste contents with many redundant styles. WebKit should remove as much style spans as possible
(all of this in this case).

* editing/pasteboard/4930986-2-expected.txt: style attribute now has a trailing space.
* editing/pasteboard/interchange-newline-1-expected.txt: No longer has a wrapping span without any attributes.
* editing/pasteboard/nested-blocks-with-text-area-expected.txt: Ditto.
* editing/pasteboard/nested-blocks-with-text-field-expected.txt: Ditto.
* editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Ditto.
* editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Ditto.
* editing/pasteboard/prevent-block-nesting-01-expected.txt: Ditto.
* editing/pasteboard/paste-with-redundant-style-expected.txt: Added.
* editing/pasteboard/paste-with-redundant-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=65778
dslomov@google.com [Mon, 8 Aug 2011 19:11:33 +0000 (19:11 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates.

Reviewed by David Levin.

Covered by existing tests.

* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::lazyEventListenerToStringTemplate):
(WebCore::V8BindingPerIsolateData::hiddenPropertyName):
(WebCore::V8BindingPerIsolateData::globalHandleMap):
(WebCore::AllowAllocation::AllowAllocation): Moving to V8Binding.h from V8Utilities.h to resolve header dependency.
(WebCore::AllowAllocation::~AllowAllocation):
(WebCore::AllowAllocation::current):
(WebCore::SafeAllocation::newInstance):
* bindings/v8/V8GCController.cpp:
(WebCore::currentGlobalHandleMap):
(WebCore::enumerateGlobalHandles):
(WebCore::V8GCController::registerGlobalHandle):
(WebCore::V8GCController::unregisterGlobalHandle):
* bindings/v8/V8HiddenPropertyName.cpp:
(WebCore::V8HiddenPropertyName::createString):
* bindings/v8/V8HiddenPropertyName.h:
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::V8LazyEventListener::prepareListenerObject):
* bindings/v8/V8NPObject.cpp:
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::checkNewLegal):
* bindings/v8/V8Utilities.h:
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
(WebCore::WorkerContextExecutionProxy::initIsolate):
* bindings/v8/WorkerContextExecutionProxy.h:
* bindings/v8/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::scheduleExecutionTermination):

Source/WebKit/chromium: https://bugs.webkit.org/show_bug.cgi?id=65778
[WebWorkers][chromium] Make statics thread-safe and make sure V8 API accesses correct isolates

Reviewed by David Levin.

* src/BoundObject.cpp: AllowAllocation moved from V8Utilities.h to V8Binding.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNon-extensibility does not prevent mutating [[Prototype]]
oliver@apple.com [Mon, 8 Aug 2011 19:09:51 +0000 (19:09 +0000)]
Non-extensibility does not prevent mutating [[Prototype]]
https://bugs.webkit.org/show_bug.cgi?id=65832

Reviewed by Gavin Barraclough.

../../../../Volumes/Data/git/WebKit/OpenSource/LayoutTests:

Add tests to ensure we can't assign to __proto__ when an object
is not extensible.

* fast/js/preventExtensions-expected.txt:
* fast/js/script-tests/preventExtensions.js:

../../../../Volumes/Data/git/WebKit/OpenSource/Source/JavaScriptCore:

Disallow mutation of __proto__ on objects that are not extensible.

* runtime/JSObject.cpp:
(JSC::JSObject::put):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r92607.
commit-queue@webkit.org [Mon, 8 Aug 2011 19:09:46 +0000 (19:09 +0000)]
Unreviewed, rolling out r92607.
http://trac.webkit.org/changeset/92607
https://bugs.webkit.org/show_bug.cgi?id=65865

This patch breaks Chromium Mac Canary (Requested by jianli on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-08

Source/WebCore:

* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):

Source/WebKit/chromium:

* features.gypi:
* public/WebInputEvent.h:
(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
* public/mac/WebInputEventFactory.h:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
* src/WebInputEventConversion.h:
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
* src/WebViewImpl.h:
* src/mac/WebInputEventFactory.mm:
(WebKit::WebInputEventFactory::mouseWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, mark 1 test as flaky in chromium.
jianli@chromium.org [Mon, 8 Aug 2011 18:59:15 +0000 (18:59 +0000)]
Unreviewed, mark 1 test as flaky in chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Implement WebGL antialiasing (part 3)
commit-queue@webkit.org [Mon, 8 Aug 2011 18:42:21 +0000 (18:42 +0000)]
[Qt] Implement WebGL antialiasing (part 3)
https://bugs.webkit.org/show_bug.cgi?id=64879

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-08-08
Reviewed by Noam Rosenthal.

Existing WebGL layout tests cover this.

Implement WebGL antialiasing for Qt desktop.
Existing code in GraphicsContext3DOpenGL.cpp manages the
multisample FBO. GraphicsContext3DQt.cpp creates it and blits
it to the regular FBO when painting.
Requires adoption of Extensions3DOpenGL to be fully functional.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
(WebCore::GraphicsContext3DInternal::paintToTextureMapper):
(WebCore::GraphicsContext3DInternal::paint):
(WebCore::GraphicsContext3DInternal::multisampleResolve):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium test_expectations.
jianli@chromium.org [Mon, 8 Aug 2011 18:33:13 +0000 (18:33 +0000)]
Unreviewed, update chromium test_expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Mon, 8 Aug 2011 18:26:03 +0000 (18:26 +0000)]
Fix build.

* platform/PODRedBlackTree.h:
(WebCore::PODRedBlackTree::Counter::visit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize floating elements lookup
commit-queue@webkit.org [Mon, 8 Aug 2011 18:09:19 +0000 (18:09 +0000)]
Optimize floating elements lookup
https://bugs.webkit.org/show_bug.cgi?id=65668

PerformanceTests:

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-08
Reviewed by David Hyatt.

* Layout/floats.html: Added the nested divs, so that we can test the propagation impact of the floats tree.

Source/WebCore:

Added an interval tree in the FloatingObjects structure. Also added new mechanisms to make
sure the tree is updated correctly when a float is repositioned.

Changed the PODIntervalTree to support giving a search adapter that can be implemented by the
client. I'm not adding a different bug for that because PODIntervalTree is not used anywhere else
and would be hard to test that the change is not breaking anything.

Patch by Alexandru Chiculita <achicu@adobe.com> on 2011-08-08
Reviewed by David Hyatt.

No new tests, just a refactor on the floating objects data structure.

* WebCore.xcodeproj/project.pbxproj:
* platform/PODIntervalTree.h:
(WebCore::PODIntervalSearchAdapter::PODIntervalSearchAdapter):
(WebCore::PODIntervalSearchAdapter::lowValue):
(WebCore::PODIntervalSearchAdapter::highValue):
(WebCore::PODIntervalSearchAdapter::collectIfNeeded):
(WebCore::PODIntervalTree::PODIntervalTree):
(WebCore::PODIntervalTree::allOverlaps):
(WebCore::PODIntervalTree::allOverlapsWithAdapter):
(WebCore::PODIntervalTree::searchForOverlapsFrom):
* platform/PODRedBlackTree.h:
(WebCore::PODRedBlackTree::PODRedBlackTree):
(WebCore::PODRedBlackTree::clear):
(WebCore::PODRedBlackTree::isInitialized):
(WebCore::PODRedBlackTree::initIfNeeded):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::::collectIfNeeded):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addPositionedFloats):
(WebCore::RenderBlock::clearFloats):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
(WebCore::RenderBlock::FloatingObjects::clear):
(WebCore::RenderBlock::FloatingObjects::intervalForFloatingObject):
(WebCore::RenderBlock::FloatingObjects::addPlacedObject):
(WebCore::RenderBlock::FloatingObjects::removePlacedObject):
(WebCore::RenderBlock::FloatingObjects::add):
(WebCore::RenderBlock::FloatingObjects::remove):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTree):
(WebCore::::string):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::setX):
(WebCore::RenderBlock::FloatingObject::setY):
(WebCore::RenderBlock::FloatingObject::setWidth):
(WebCore::RenderBlock::FloatingObject::setHeight):
(WebCore::RenderBlock::FloatingObject::setFrameRect):
(WebCore::RenderBlock::FloatingObject::isInPlacedTree):
(WebCore::RenderBlock::FloatingObject::setIsInPlacedTree):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(WebCore::RenderBlock::FloatingObjects::FloatingObjects):
(WebCore::RenderBlock::FloatingObjects::setHorizontalWritingMode):
(WebCore::RenderBlock::FloatingObjects::set):
(WebCore::RenderBlock::FloatingObjects::placedFloatsTree):
(WebCore::RenderBlock::FloatingObjects::computePlacedFloatsTreeIfNeeded):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::matchedEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkit-patch doesn't get along with renamed files
jochen@chromium.org [Mon, 8 Aug 2011 18:02:59 +0000 (18:02 +0000)]
webkit-patch doesn't get along with renamed files
https://bugs.webkit.org/show_bug.cgi?id=48075

Possibly a bit heavy handed - I removed all instances of -C and
changed every instance of -M with '--no-renames' in git.py. This
forces git to not try to tell us about renames at all, which is
ultimately the behaviour we want. The old file is shown deleted,
then the new file is shown added, followed by any changes that
occurred. Also gets rid of the problem where deleting one file
and adding another file which has similar content would
unexpectedly show up as a rename, and fall out of a diff.

Based on a patch by Wyatt Carss.

Reviewed by Eric Seidel.

* Scripts/webkitpy/common/checkout/scm/git.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, mark some tests as flaky on chromium.
jianli@chromium.org [Mon, 8 Aug 2011 18:00:04 +0000 (18:00 +0000)]
Unreviewed, mark some tests as flaky on chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Enable rubber banding when scrolling.
commit-queue@webkit.org [Mon, 8 Aug 2011 17:56:40 +0000 (17:56 +0000)]
[Chromium] Enable rubber banding when scrolling.

https://bugs.webkit.org/show_bug.cgi?id=65707

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-08-08
Reviewed by Dimitri Glazkov.

Source/WebCore:

No new tests since this is just syncing changes to chromium platform.

* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
* platform/chromium/ScrollAnimatorChromiumMac.mm:
(WebCore::ScrollAnimatorChromiumMac::handleGestureEvent):

Source/WebKit/chromium:

* features.gypi:
* public/WebInputEvent.h:
(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):
(WebKit::WebGestureEvent::WebGestureEvent):
* public/mac/WebInputEventFactory.h:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
* src/WebInputEventConversion.h:
* src/WebPopupMenuImpl.cpp:
(WebKit::WebPopupMenuImpl::GestureEvent):
(WebKit::WebPopupMenuImpl::handleInputEvent):
* src/WebPopupMenuImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::gestureEvent):
(WebKit::WebViewImpl::handleInputEvent):
* src/WebViewImpl.h:
* src/mac/WebInputEventFactory.mm:
(WebKit::gestureEventTypeForEvent):
(WebKit::phaseForNSEventPhase):
(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled Chromium DEPS from 95576 to 95783.
rniwa@webkit.org [Mon, 8 Aug 2011 17:54:00 +0000 (17:54 +0000)]
Unreviewed. Rolled Chromium DEPS from 95576 to 95783.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Cairo][Gtk] Get more of the philip suite of canvas tests passing
commit-queue@webkit.org [Mon, 8 Aug 2011 17:52:26 +0000 (17:52 +0000)]
[Cairo][Gtk] Get more of the philip suite of canvas tests passing
https://bugs.webkit.org/show_bug.cgi?id=54458

Patch by Zan Dobersek <zandobersek@gmail.com> on 2011-08-08
Reviewed by Martin Robinson.

Update the list of skipped canvas tests and describe why platform-specific
failures occur.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore Lion specific results.
andersca@apple.com [Mon, 8 Aug 2011 17:43:17 +0000 (17:43 +0000)]
More Lion specific results.

* platform/mac-lion/Skipped:
* platform/mac-snowleopard/editing: Added.
* platform/mac-snowleopard/editing/input: Added.
* platform/mac-snowleopard/editing/input/devanagari-ligature-expected.png: Copied from platform/mac/editing/input/devanagari-ligature-expected.png.
* platform/mac-snowleopard/editing/input/devanagari-ligature-expected.txt: Copied from platform/mac/editing/input/devanagari-ligature-expected.txt.
* platform/mac-snowleopard/fast/xsl: Added.
* platform/mac-snowleopard/fast/xsl/sort-locale-expected.txt: Added.
* platform/mac/editing/input/devanagari-ligature-expected.png:
* platform/mac/editing/input/devanagari-ligature-expected.txt:
* platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
* platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
* platform/mac/fast/xsl/sort-locale-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9652350> REGRESSION (r87755): WKView doesn't update when I drag files...
mitz@apple.com [Mon, 8 Aug 2011 17:28:47 +0000 (17:28 +0000)]
<rdar://problem/9652350> REGRESSION (r87755): WKView doesn't update when I drag files into a background Safari window
https://bugs.webkit.org/show_bug.cgi?id=65860

Reviewed by Simon Fraser.

When layer flush scheduling is re-enabled, schedule a layer flush, just in case one was requested while
scheduling was disabled. It doesn’t seem worthwhile to track whether that in fact happened, so do so
unconditionally.

* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:
(WebKit::LayerTreeHostCAMac::setLayerFlushSchedulingEnabled):
* WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
(WebKit::LayerTreeHostCAWin::setLayerFlushSchedulingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, fix more typo in test_expectations.txt.
jianli@chromium.org [Mon, 8 Aug 2011 17:20:58 +0000 (17:20 +0000)]
Unreviewed, fix more typo in test_expectations.txt.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-08 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 8 Aug 2011 16:27:17 +0000 (16:27 +0000)]
2011-08-08  Pavel Podivilov  <podivilov@chromium.org>

        Web Inspector: unreviewed, build fix for r92598.

        * inspector/debugger/script-formatter.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mitz@apple.com [Mon, 8 Aug 2011 16:26:08 +0000 (16:26 +0000)]
Build fix.

* html/NumberInputType.cpp:
(WebCore::NumberInputType::sizeShouldIncludeDecoration): Fixed an obvious typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Clean up project file after r92492.
abecsi@webkit.org [Mon, 8 Aug 2011 16:13:07 +0000 (16:13 +0000)]
[Qt] Clean up project file after r92492.

Unreviewed gardening.

No new tests needed.

* WebCore.pro: remove nonexistent PluginHalterClient.h, PluginHalter.h, HaltablePlugin.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: refactor links creation.
podivilov@chromium.org [Mon, 8 Aug 2011 15:50:36 +0000 (15:50 +0000)]
Web Inspector: refactor links creation.
https://bugs.webkit.org/show_bug.cgi?id=65612

Reviewed by Pavel Feldman.

No new tests - it is refactoring, modified code covered by script-formatter.html test.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype._linkifyLocation):
(WebInspector.ConsoleMessage.prototype._linkifyCallFrame):
(WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.addSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.removeSourceMappingListener):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor.didGetLocation):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSourceFiles):
(WebInspector.DebuggerPresentationModel.prototype._sourceFileForScript):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/EventListenersSidebarPane.js:
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
* inspector/front-end/Panel.js:
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.createCell):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._folderAndDisplayNameForScriptURL):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection.linkifyUncopyable):
(WebInspector.StylePropertiesSection):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
* inspector/front-end/inspector.js:
(WebInspector._showSettingsScreen):
(WebInspector.formatLinkText):
(WebInspector.linkifyResourceAsNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-08 Andrei Popescu <andreip@google.com>
andreip@google.com [Mon, 8 Aug 2011 15:34:50 +0000 (15:34 +0000)]
2011-08-08  Andrei Popescu  <andreip@google.com>

        svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
        https://bugs.webkit.org/show_bug.cgi?id=63186

        Unreviewed gardening.

        Fix typo in test_expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Implement WebGL antialiasing (part 3)
commit-queue@webkit.org [Mon, 8 Aug 2011 15:29:46 +0000 (15:29 +0000)]
[Qt] Implement WebGL antialiasing (part 3)
https://bugs.webkit.org/show_bug.cgi?id=64879

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-08-08
Reviewed by Noam Rosenthal.

Existing WebGL layout tests.

Adopt Extensions3DOpenGL for Qt desktop as a prerequisite
for implementing WebGL antialiasing.
Extensions3DQt is still used for ES2.

* WebCore.pri:
* WebCore.pro:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::getExtensions):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::layerComposited):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-08-08 Andrei Popescu <andreip@google.com>
andreip@google.com [Mon, 8 Aug 2011 15:05:00 +0000 (15:05 +0000)]
2011-08-08  Andrei Popescu  <andreip@google.com>

        svg/zoom/page/zoom-svg-through-object-with-*.xhtml are flaky
        https://bugs.webkit.org/show_bug.cgi?id=63186

        Unreviewed gardening.

        Marks the tests as failing on Chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@92595 268f45cc-cd09-0410-ab3c-d52691b4dbfc