WebKit-https.git
8 years ago[wx] Unreviewed build fix. Remove from WebDOMEventTarget bindings methods that have...
kevino@webkit.org [Thu, 10 Nov 2011 04:13:00 +0000 (04:13 +0000)]
[wx] Unreviewed build fix. Remove from WebDOMEventTarget bindings methods that have been removed from EventTarget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Cairo] Avoid clipping when painting more often
mrobinson@webkit.org [Thu, 10 Nov 2011 03:10:09 +0000 (03:10 +0000)]
[Cairo] Avoid clipping when painting more often
https://bugs.webkit.org/show_bug.cgi?id=71179

Reviewed by Xan Lopez.

No new tests. These changes are covered by existing tests.

* platform/graphics/Gradient.h: Add a Cairo-specific method
that gets the platform gradient with a particular alpha value.
* platform/graphics/cairo/GradientCairo.cpp: Now cache the alpha
value of the last created platform gradient.
(WebCore::Gradient::platformGradient): If the cached platform gradient
has a different alpha value than the one requested, destroy it and start
over.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawPathShadow): Adjust the source to avoid calling
cairo_clip/cairo_paint_with_alpha and just do a fill.
(WebCore::shadowAndFillCurrentCairoPath): No need to clip here. Just
call cairo_fill.
* platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::drawPatternToCairoContext): If we have a >= 1 alpha value
we can simply fill and avoid calling cairo_clip here.
(WebCore::prepareCairoContextSource): Remove TODO about recreating the
gradient. No longer need to reduce the gradient source.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] [WebKit] Replace the gtkdoc autools magic with something more flexible
mrobinson@webkit.org [Thu, 10 Nov 2011 03:00:43 +0000 (03:00 +0000)]
[GTK] [WebKit] Replace the gtkdoc autools magic with something more flexible
https://bugs.webkit.org/show_bug.cgi?id=70877

Reviewed by Philippe Normand.

Add a script that runs gtkdoc manually instead of using the autotools
magic. Remove now unused gtkdoc files.

* GNUmakefile.am: Remove references to removed gtkdoc files.
* UIProcess/API/gtk/docs/GNUmakefile.am: Removed.
* UIProcess/API/gtk/docs/build-gtkdoc: Added.
* UIProcess/API/gtk/docs/gtkdoc.py: Added.
* UIProcess/API/gtk/docs/version.xml.in: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-09 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 10 Nov 2011 02:56:48 +0000 (02:56 +0000)]
2011-11-09  Andrew Scherkus  <scherkus@chromium.org>

        More media rebaselines due to r98596.

        * media/controls-without-preload-expected.txt: Removed.
        * platform/chromium-gpu-win/media/audio-controls-rendering-expected.txt: Removed.
        * platform/chromium-gpu-win/media/controls-after-reload-expected.txt: Removed.
        * platform/chromium-gpu-win/media/controls-strict-expected.txt: Removed.
        * platform/chromium-gpu-win/media/controls-styling-expected.txt: Removed.
        * platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Removed.
        * platform/mac/media/controls-strict-expected.txt: Removed.
        * platform/win-wk2/media/controls-without-preload-expected.txt: Removed.
        * platform/win-xp/media/controls-without-preload-expected.txt: Removed.
        * platform/win/media/controls-without-preload-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/10423024> WebProcess doesn't use AuthBrokerAgent for proxy credentials
ap@apple.com [Thu, 10 Nov 2011 02:48:40 +0000 (02:48 +0000)]
<rdar://problem/10423024> WebProcess doesn't use AuthBrokerAgent for proxy credentials
https://bugs.webkit.org/show_bug.cgi?id=71964

Reviewed by Darin Adler.

Source/WebCore:

* platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
* platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
Don't ask the client for proxy credentials. CFNetwork results are authoritative, and proxy
credentials are system-wide.

Source/WebKit2:

* WebProcess/com.apple.WebProcess.sb: Allow mach-lookup of com.apple.cfnetwork.AuthBrokerAgent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Fix typo in checkerboarding code
commit-queue@webkit.org [Thu, 10 Nov 2011 02:40:13 +0000 (02:40 +0000)]
[chromium] Fix typo in checkerboarding code
https://bugs.webkit.org/show_bug.cgi?id=71981

Patch by Daniel Sievers <sievers@chromium.org> on 2011-11-09
Reviewed by James Robinson.

No new tests.

* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::drawTiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRenovate ARMv7 assembler/macro-assembler
barraclough@apple.com [Thu, 10 Nov 2011 02:32:49 +0000 (02:32 +0000)]
Renovate ARMv7 assembler/macro-assembler
https://bugs.webkit.org/show_bug.cgi?id=71982

Reviewed by Geoff Garen.

ARMv7Assembler:
* add support for strb (byte stores)
* rename the VMOV_CtoS opcodes (there are currently backwards!)
* add support for adc (add with carry)
* add support for vsqrt, vabs
* add support for vmov (between FPRs, and to/from GPR pairs).
* remove '_F64' postfixes from instructions (these aren't helpful, functions can already be distinguished by their signatures).
* rename vcvt_F64_S32  to vcvt_signedToFloatingPoint, the prior postfix was unhelpful in failing to distinguish the types (S32 indicates a single precision register, but the type could be float, int32, or uint32).
* rename vcvtr_S32_F64 to vcvt_floatingPointToSigned, as for previous, also vcvtr was the incorrect name for the operation (the emitted instruction truncates).

MacroAssemblerARMv7:
* add 3-operand versions of and32, lshift32, or32, rshift32, urshift32, sub32, xor32,
* add store8, and store32 imm to base-index.
* fix load32WithCompactAddressOffsetPatch to work for all gprs (the fix is a little kludgy but functional; to do better we'll have to also fix the repatching code).
* Update supportsFloating* flags (all features now supported).
* add moveDouble, storeDouble to absolute address, addDouble to absolute address
* add 3-operand double operations.
* implement sqrtDouble/absDouble
* add branchTruncateDoubleToInt32, implement truncateDoubleToInt32
* move should do nothing if src == dest
* branchTest8-on-memory can be implemented in terms of branchTest32-on-register (branchTest8-on-register has been removed).
* add 3-operand branchAdd32, branchSub32, also branchAdd32 absolute address.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Add expectation files for locale-sensitive-fonts.html
tkent@chromium.org [Thu, 10 Nov 2011 02:27:01 +0000 (02:27 +0000)]
[Chromium] Add expectation files for locale-sensitive-fonts.html
https://bugs.webkit.org/show_bug.cgi?id=67019

* platform/chromium-win/fast/text/international/locale-sensitive-fonts-expected.png: Added.
* platform/chromium/fast/text/international/locale-sensitive-fonts-expected.png: Added.
* platform/chromium/fast/text/international/locale-sensitive-fonts-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] MediaStream API: Add WebMediaStreamRegistry
commit-queue@webkit.org [Thu, 10 Nov 2011 02:25:10 +0000 (02:25 +0000)]
[chromium] MediaStream API: Add WebMediaStreamRegistry
https://bugs.webkit.org/show_bug.cgi?id=71458

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-09
Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebMediaStreamRegistry.h: Added.
* src/WebMediaStreamRegistry.cpp: Added.
(WebKit::WebMediaStreamRegistry::lookupMediaStreamDescriptor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WinCairo] Further exclusions for unsupported features.
bfulgham@webkit.org [Thu, 10 Nov 2011 02:05:14 +0000 (02:05 +0000)]
[WinCairo] Further exclusions for unsupported features.

* platform/wincairo/Skipped: Turn off mathml and webgl tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99782.
commit-queue@webkit.org [Thu, 10 Nov 2011 01:53:02 +0000 (01:53 +0000)]
Unreviewed, rolling out r99782.
http://trac.webkit.org/changeset/99782
https://bugs.webkit.org/show_bug.cgi?id=71979

broke most of the feImage tests (Requested by thorton on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-09

Source/WebCore:

* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::parseMappedAttribute):
(WebCore::SVGFEImageElement::build):

LayoutTests:

* platform/mac/svg/filters/feImage-reference-svg-primitive-expected.png: Removed.
* platform/mac/svg/filters/feImage-reference-svg-primitive-expected.txt: Removed.
* svg/filters/feImage-reference-svg-primitive.svg: Removed.
* svg/filters/feImage-zero-size-crash-expected.txt: Removed.
* svg/filters/feImage-zero-size-crash.svg: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove [CanBeConstructed] IDL from CodeGenerator{JS,V8}.pm
haraken@chromium.org [Thu, 10 Nov 2011 01:41:24 +0000 (01:41 +0000)]
Remove [CanBeConstructed] IDL from CodeGenerator{JS,V8}.pm
https://bugs.webkit.org/show_bug.cgi?id=71938

Reviewed by Darin Adler.

Now no IDL files are using [CanBeConstructed] IDL.
We can safely remove [CanBeConstructed] IDL from CodeGenerator{JS,V8}.pm.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm: Removed [CanBeConstructed]-related code.
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateImplementation):
* bindings/scripts/test/TestInterface.idl: Removed [CanBeConstructed].
* bindings/v8/V8Proxy.h: Removed V8Proxy::constructDOMObject and V8Proxy::constructDOMObjectWithScriptExecutionContext, which had been used only by [CanBeConstructed].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the concept of platform-dependent unittests
eric@webkit.org [Thu, 10 Nov 2011 01:21:36 +0000 (01:21 +0000)]
Remove the concept of platform-dependent unittests
https://bugs.webkit.org/show_bug.cgi?id=71963

Unreviewed.  Fix test-webkitpy on cygwin.

* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix up expected results after http://trac.webkit.org/changeset/99772.
ojan@chromium.org [Thu, 10 Nov 2011 01:16:30 +0000 (01:16 +0000)]
Fix up expected results after trac.webkit.org/changeset/99772.
The chromium mac results match the platform/mac results.

* platform/chromium/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-09 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Thu, 10 Nov 2011 01:15:45 +0000 (01:15 +0000)]
2011-11-09  Andrew Scherkus  <scherkus@chromium.org>

        Rebaseline media layout tests due to r98596.

        * platform/chromium-cg-mac-snowleopard/media/audio-controls-rendering-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/audio-controls-rendering-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/controls-after-reload-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-after-reload-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/controls-strict-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-strict-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/controls-styling-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-styling-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/controls-without-preload-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-without-preload-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/media-controls-clone-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/media-controls-clone-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/video-display-toggle-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-display-toggle-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/video-empty-source-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-empty-source-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/video-no-audio-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-no-audio-expected.png.
        * platform/chromium-cg-mac-snowleopard/media/video-volume-slider-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-volume-slider-expected.png.
        * platform/chromium-gpu-linux/media/audio-controls-rendering-expected.png: Added.
        * platform/chromium-gpu-linux/media/media-controls-clone-expected.png: Added.
        * platform/chromium-gpu-linux/media/video-empty-source-expected.png: Added.
        * platform/chromium-gpu-mac/media/controls-after-reload-expected.png:
        * platform/chromium-gpu-mac/media/controls-strict-expected.png:
        * platform/chromium-gpu-mac/media/controls-styling-expected.png:
        * platform/chromium-gpu-mac/media/controls-without-preload-expected.png:
        * platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
        * platform/chromium-gpu-mac/media/video-no-audio-expected.png:
        * platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png:
        * platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
        * platform/chromium-gpu-win/media/audio-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/audio-controls-rendering-expected.txt.
        * platform/chromium-gpu-win/media/controls-after-reload-expected.png:
        * platform/chromium-gpu-win/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/controls-after-reload-expected.txt.
        * platform/chromium-gpu-win/media/controls-strict-expected.png:
        * platform/chromium-gpu-win/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/controls-strict-expected.txt.
        * platform/chromium-gpu-win/media/controls-styling-expected.png:
        * platform/chromium-gpu-win/media/controls-styling-expected.txt: Added.
        * platform/chromium-gpu-win/media/controls-without-preload-expected.png:
        * platform/chromium-gpu-win/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium-mac/media/controls-without-preload-expected.txt.
        * platform/chromium-gpu-win/media/video-display-toggle-expected.png:
        * platform/chromium-gpu-win/media/video-no-audio-expected.png:
        * platform/chromium-gpu-win/media/video-playing-and-pause-expected.png:
        * platform/chromium-gpu-win/media/video-volume-slider-expected.png:
        * platform/chromium-linux/media/audio-controls-rendering-expected.png:
        * platform/chromium-linux/media/controls-after-reload-expected.png:
        * platform/chromium-linux/media/controls-strict-expected.png:
        * platform/chromium-linux/media/controls-styling-expected.png:
        * platform/chromium-linux/media/controls-without-preload-expected.png:
        * platform/chromium-linux/media/media-controls-clone-expected.png:
        * platform/chromium-linux/media/media-document-audio-repaint-expected.png:
        * platform/chromium-linux/media/video-display-toggle-expected.png:
        * platform/chromium-linux/media/video-empty-source-expected.png:
        * platform/chromium-linux/media/video-no-audio-expected.png:
        * platform/chromium-linux/media/video-playing-and-pause-expected.png:
        * platform/chromium-linux/media/video-volume-slider-expected.png:
        * platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
        * platform/chromium-mac-leopard/media/controls-after-reload-expected.png:
        * platform/chromium-mac-leopard/media/controls-strict-expected.png:
        * platform/chromium-mac-leopard/media/controls-styling-expected.png:
        * platform/chromium-mac-leopard/media/controls-without-preload-expected.png:
        * platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
        * platform/chromium-mac-leopard/media/video-empty-source-expected.png:
        * platform/chromium-mac-leopard/media/video-no-audio-expected.png:
        * platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png:
        * platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
        * platform/chromium-mac-snowleopard/media/audio-controls-rendering-expected.png: Added.
        * platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/controls-after-reload-expected.png.
        * platform/chromium-mac-snowleopard/media/controls-strict-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/controls-strict-expected.png.
        * platform/chromium-mac-snowleopard/media/controls-styling-expected.png: Added.
        * platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png: Added.
        * platform/chromium-mac-snowleopard/media/media-controls-clone-expected.png: Added.
        * platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
        * platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-display-toggle-expected.png.
        * platform/chromium-mac-snowleopard/media/video-empty-source-expected.png: Added.
        * platform/chromium-mac-snowleopard/media/video-no-audio-expected.png: Added.
        * platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
        * platform/chromium-mac-snowleopard/media/video-volume-slider-expected.png: Renamed from LayoutTests/platform/chromium-mac/media/video-volume-slider-expected.png.
        * platform/chromium-mac/media/audio-controls-rendering-expected.png: Removed.
        * platform/chromium-mac/media/controls-styling-expected.png: Removed.
        * platform/chromium-mac/media/controls-styling-expected.txt: Removed.
        * platform/chromium-mac/media/controls-without-preload-expected.png: Removed.
        * platform/chromium-mac/media/media-controls-clone-expected.png: Removed.
        * platform/chromium-mac/media/media-controls-clone-expected.txt: Removed.
        * platform/chromium-mac/media/video-display-toggle-expected.txt: Removed.
        * platform/chromium-mac/media/video-empty-source-expected.png: Removed.
        * platform/chromium-mac/media/video-no-audio-expected.png: Removed.
        * platform/chromium-mac/media/video-no-audio-expected.txt: Removed.
        * platform/chromium-mac/media/video-volume-slider-expected.txt: Removed.
        * platform/chromium-win/media/audio-controls-rendering-expected.png:
        * platform/chromium-win/media/controls-after-reload-expected.png:
        * platform/chromium-win/media/controls-strict-expected.png:
        * platform/chromium-win/media/controls-styling-expected.png:
        * platform/chromium-win/media/controls-without-preload-expected.png:
        * platform/chromium-win/media/media-controls-clone-expected.png:
        * platform/chromium-win/media/media-document-audio-repaint-expected.png:
        * platform/chromium-win/media/video-display-toggle-expected.png:
        * platform/chromium-win/media/video-empty-source-expected.png:
        * platform/chromium-win/media/video-no-audio-expected.png:
        * platform/chromium-win/media/video-playing-and-pause-expected.png:
        * platform/chromium-win/media/video-volume-slider-expected.png:
        * platform/chromium/media/audio-controls-rendering-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/audio-controls-rendering-expected.txt.
        * platform/chromium/media/controls-after-reload-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-after-reload-expected.txt.
        * platform/chromium/media/controls-strict-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-strict-expected.txt.
        * platform/chromium/media/controls-styling-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-styling-expected.txt.
        * platform/chromium/media/controls-without-preload-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/controls-without-preload-expected.txt.
        * platform/chromium/media/media-controls-clone-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/media-controls-clone-expected.txt.
        * platform/chromium/media/video-display-toggle-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-display-toggle-expected.txt.
        * platform/chromium/media/video-no-audio-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-no-audio-expected.txt.
        * platform/chromium/media/video-volume-slider-expected.txt: Renamed from LayoutTests/platform/chromium-cg-mac/media/video-volume-slider-expected.txt.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=71873
barraclough@apple.com [Thu, 10 Nov 2011 01:10:40 +0000 (01:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG OSR exit code should be lazily generated
fpizlo@apple.com [Thu, 10 Nov 2011 01:08:50 +0000 (01:08 +0000)]
DFG OSR exit code should be lazily generated
https://bugs.webkit.org/show_bug.cgi?id=71744

Reviewed by Gavin Barraclough.

The OSR exit code is now generated the first time it is executed,
rather than right after speculative compilation. Because most OSR
exits are never taken, this should greatly reduce both code size
and compilation time.

This is a 1% win on SunSpider, and a 1% win on V8 when running in
my harness. No change in V8 in V8's harness (due to the long runs,
so compile time is not an issue) and no change in Kraken (again,
long runs of small code so compile time has no measurable effect).

* CMakeListsEfl.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::jump):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::jump):
* assembler/X86Assembler.h:
(JSC::X86Assembler::jmp_m):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::createDFGDataIfNecessary):
(JSC::CodeBlock::appendDFGOSREntryData):
(JSC::CodeBlock::numberOfDFGOSREntries):
(JSC::CodeBlock::dfgOSREntryData):
(JSC::CodeBlock::dfgOSREntryDataForBytecodeIndex):
(JSC::CodeBlock::appendOSRExit):
(JSC::CodeBlock::appendSpeculationRecovery):
(JSC::CodeBlock::numberOfOSRExits):
(JSC::CodeBlock::numberOfSpeculationRecoveries):
(JSC::CodeBlock::osrExit):
(JSC::CodeBlock::speculationRecovery):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::debugCall):
* dfg/DFGCorrectableJumpPoint.cpp: Added.
(JSC::DFG::CorrectableJumpPoint::codeLocationForRepatch):
* dfg/DFGCorrectableJumpPoint.h: Added.
(JSC::DFG::CorrectableJumpPoint::CorrectableJumpPoint):
(JSC::DFG::CorrectableJumpPoint::switchToLateJump):
(JSC::DFG::CorrectableJumpPoint::correctInitialJump):
(JSC::DFG::CorrectableJumpPoint::correctLateJump):
(JSC::DFG::CorrectableJumpPoint::initialJump):
(JSC::DFG::CorrectableJumpPoint::lateJump):
(JSC::DFG::CorrectableJumpPoint::correctJump):
(JSC::DFG::CorrectableJumpPoint::getJump):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
* dfg/DFGOSRExit.cpp: Added.
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::dump):
* dfg/DFGOSRExit.h:
* dfg/DFGOSRExitCompiler.cpp: Added.
* dfg/DFGOSRExitCompiler.h:
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationCheck):
* dfg/DFGThunks.cpp: Added.
(JSC::DFG::osrExitGenerationThunkGenerator):
* dfg/DFGThunks.h: Added.
* jit/JITCode.h:
(JSC::JITCode::dataAddressAtOffset):
* runtime/JSGlobalData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd cc-bugs group to watch changes in chromium graphics
commit-queue@webkit.org [Thu, 10 Nov 2011 01:07:12 +0000 (01:07 +0000)]
Add cc-bugs group to watch changes in chromium graphics
https://bugs.webkit.org/show_bug.cgi?id=71690

Patch by Dana Jansens <danakj@chromium.org> on 2011-11-09
Reviewed by David Levin.

* Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
* Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
* Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
* Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove more platform-dependent unittests
eric@webkit.org [Thu, 10 Nov 2011 01:04:21 +0000 (01:04 +0000)]
Remove more platform-dependent unittests
https://bugs.webkit.org/show_bug.cgi?id=71971

Reviewed by Adam Barth.

Tests which only run on a couple platforms will break.
All tests should run on all platforms where possible.

* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
* Scripts/webkitpy/layout_tests/port/config_unittest.py:
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMerge in results to the test results server even if build numbers conflict
ojan@chromium.org [Thu, 10 Nov 2011 00:49:03 +0000 (00:49 +0000)]
Merge in results to the test results server even if build numbers conflict
https://bugs.webkit.org/show_bug.cgi?id=71967

Reviewed by Tony Chang.

This was initially meant to be a sanity check that we don't
enter duplicate runs, but it turns out that we can reasonably get
in these situations when a builder is clobbered (e.g. the build
numbers start over again from 0).

* TestResultServer/model/jsonresults.py:
* TestResultServer/model/jsonresults_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofeImage referencing a primitive draws incorrectly
timothy_horton@apple.com [Thu, 10 Nov 2011 00:39:21 +0000 (00:39 +0000)]
feImage referencing a primitive draws incorrectly
https://bugs.webkit.org/show_bug.cgi?id=71731
<rdar://problem/10408178>

Reviewed by Simon Fraser.

Don't attempt to resolve an <feImage>'s referenced element until it's used, as it
may not exist at the time the attribute is set on the <feImage>.

Don't attempt to render an <feImage> if the referenced element is of size 0x0.

Tests: svg/filters/feImage-reference-svg-primitive.svg
       svg/filters/feImage-zero-size-crash.svg

* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::parseMappedAttribute):
(WebCore::SVGFEImageElement::build):

Add a test (feImage-reference-svg-primitive) that ensures that having
an <feImage> referencing an SVG primitive which is declared after it
successfully paints the referenced object.

Add a test (feImage-zero-size-crash) to see if we crash when <feImage>
references an object with 0x0 size.

* platform/mac/svg/filters/feImage-reference-svg-primitive-expected.png: Added.
* platform/mac/svg/filters/feImage-reference-svg-primitive-expected.txt: Added.
* svg/filters/feImage-reference-svg-primitive.svg: Added.
* svg/filters/feImage-zero-size-crash-expected.txt: Added.
* svg/filters/feImage-zero-size-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the concept of platform-dependent unittests
eric@webkit.org [Thu, 10 Nov 2011 00:24:08 +0000 (00:24 +0000)]
Remove the concept of platform-dependent unittests
https://bugs.webkit.org/show_bug.cgi?id=71963

Reviewed by Adam Barth.

These have been the source of never-ending sadness.
We'd change behavior and forget to update results in
some unittests because they were only run on certain platforms.
This change removes a large source of these platform-dependent
unittests, which was caused by the port_maker stuff.

It's possible that this change will break test-webkitpy
on some platforms, but that will be a one-time cost.
I will fix the breakage by removing the platform-dependantness
of any such broken tests.

* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
* Scripts/webkitpy/layout_tests/port/efl_unittest.py:
* Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
* Scripts/webkitpy/layout_tests/port/win_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove WebGLContextEvent.initEvent method
dominicc@chromium.org [Thu, 10 Nov 2011 00:11:52 +0000 (00:11 +0000)]
Remove WebGLContextEvent.initEvent method
https://bugs.webkit.org/show_bug.cgi?id=71720

Reviewed by Adam Barth.

The WebGL spec calls this method initWebGLContextEvent, but it may
adopt a constructor instead. Deleting the initEvent method for now
since it is definitely wrong and we don't want people to come to
depend on it.

No new tests--removing untested code.

* html/canvas/WebGLContextEvent.cpp:
* html/canvas/WebGLContextEvent.h:
* html/canvas/WebGLContextEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixing build breakage
mhahnenberg@apple.com [Thu, 10 Nov 2011 00:04:40 +0000 (00:04 +0000)]
Fixing build breakage

Unreviewed build fix

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoElement::boundsInWindowSpace should be Element::boundsInRootViewSpace
andersca@apple.com [Wed, 9 Nov 2011 23:59:21 +0000 (23:59 +0000)]
Element::boundsInWindowSpace should be Element::boundsInRootViewSpace
https://bugs.webkit.org/show_bug.cgi?id=71955

Reviewed by Sam Weinig.

Source/WebCore:

Element::boundsInWindowSpace is only used by WebKit2, where the window coordinate space is the
same as the root view coordinate space. This lets us get rid of another use of contentsToWindow.

* WebCore.exp.in:
* dom/Element.cpp:
(WebCore::Element::boundsInRootViewSpace):
* dom/Element.h:

Source/WebKit2:

* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::elementBounds):
Call Element::boundsInRootViewSpace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix file formatting.
lforschler@apple.com [Wed, 9 Nov 2011 23:56:43 +0000 (23:56 +0000)]
Fix file formatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline run-bindings-tests results.
haraken@chromium.org [Wed, 9 Nov 2011 23:55:47 +0000 (23:55 +0000)]
Unreviewed, rebaseline run-bindings-tests results.

* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestNamedConstructor::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestNamedConstructor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix break after r99644.
lforschler@apple.com [Wed, 9 Nov 2011 23:55:37 +0000 (23:55 +0000)]
Fix break after r99644.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add draw-time scale delta to compositor thread
commit-queue@webkit.org [Wed, 9 Nov 2011 23:47:45 +0000 (23:47 +0000)]
[chromium] Add draw-time scale delta to compositor thread
https://bugs.webkit.org/show_bug.cgi?id=71595

Patch by Alexandre Elias <aelias@google.com> on 2011-11-09
Reviewed by James Robinson.

There are two magnify values:
1. The WebKit-side pageScale value corresponding to the resolution of
   the painted content.
2. The Impl-side-only scaleDelta value representing the additional
   degree of current magnification, applied as a draw transform.  WebKit
   is never explicitly aware of this value and the only way to change it
   currently is via pinch events (and in the future, double-tap/etc
   events).  At the end of a pinch zoom, we multiply pageScale *
   scaleDelta and tell WebKit to use it as the new pageScale.

Scroll offsets and max-extents are maintained in pageScale space.
When the scale changes, we need to take care to convert them to the
new scale and avoid getting them clamped to the extents at the wrong
scale.

I removed maxScrollPosition on the non-impl side because it makes no
sense to precompute it in the presence of an impl-side zoom.  Replaced
with a simple 'bool m_scrollable'.

zoomAnimatorTransform is not used because it currently isn't in the
branch, and mostly doesn't behave the way we want anyway (it does most
things in WebKit thread).  We will need to unify these later.

Also introduce deviceOrPageScaleFactorChanged() call which invalidates
layers.

Source/WebCore:

No new tests (filed 71529 to remember to do it later).

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::deviceOrPageScaleFactorChanged):
* platform/graphics/chromium/GraphicsLayerChromium.h:
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setBounds):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::scrollable):
(WebCore::LayerChromium::setScrollable):
(WebCore::LayerChromium::pageScaleChanged):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayersInternal):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore::LayerRendererChromium::setPageMagnifyTransform):
* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::setViewport):
* platform/graphics/chromium/NonCompositedContentHost.h:
(WebCore::NonCompositedContentHost::topLevelRootLayer):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::scrollable):
(WebCore::CCLayerImpl::setScrollable):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setPageScale):
(WebCore::CCLayerTreeHost::setPageScaleFactorLimits):
(WebCore::CCLayerTreeHost::applyScrollAndScale):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::pageScale):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::commitComplete):
(WebCore::findScrollLayer):
(WebCore::CCLayerTreeHostImpl::setViewport):
(WebCore::CCLayerTreeHostImpl::setPageScale):
(WebCore::CCLayerTreeHostImpl::setScaleDelta):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorLimits):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::pinchGestureBegin):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::pinchGestureEnd):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::pageScale):
* platform/graphics/chromium/cc/CCScrollController.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::doCommit):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnImplThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
* platform/graphics/chromium/cc/CCThreadProxy.h:

Source/WebKit/chromium:

* public/WebLayerTreeViewClient.h:
* public/WebView.h:
* src/WebCompositorImpl.cpp:
* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::applyScrollAndScale):
* src/WebLayerTreeViewImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::enableFixedLayoutMode):
(WebKit::WebViewImpl::setPageScaleFactorLimits):
(WebKit::WebViewImpl::applyScrollAndScale):
(WebKit::WebViewImpl::updateLayerTreeViewport):
* src/WebViewImpl.h:
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::CCLayerTreeHostImplTest::expectContains):
(WebKit::TEST_F):
* tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::applyScrollAndScale):
(WTF::MockLayerTreeHostClient::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollSimple::beginTest):
(WTF::CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollSimple::applyScrollAndScale):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginTest):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::applyScrollAndScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake the Port object have a Host
eric@webkit.org [Wed, 9 Nov 2011 23:40:48 +0000 (23:40 +0000)]
Make the Port object have a Host
https://bugs.webkit.org/show_bug.cgi?id=71961

Reviewed by Adam Barth.

This has been a long time coming.
Now that Port has a Host object, it's very easy
to write unittests which use a properly mocked Port.
Soon we will remove the executive, filesystem and user
members of Port and get everything through the Host.

Note how in many callsites we're actually removing
explicit mocks, since we're now always going to get the
correct Executive/User/FileSystem from the
Host and callsites don't need to be careful to pass each one.

This is prep-work for adding a new Environment member to
Host and needing to be able to access the Environment
member from Port functions w/o needing to pass an Environment
object (or appropriate Mock) every place we create a Port object.
Now that we have a single Host object to reach out through, its
simple to add additional functionality (like Environment) while
keeping our unittests properly mocked.

* Scripts/webkitpy/common/host.py:
* Scripts/webkitpy/common/net/credentials_unittest.py:
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
* Scripts/webkitpy/layout_tests/port/apple.py:
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/base_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
* Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/efl.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
* Scripts/webkitpy/layout_tests/port/google_chrome.py:
* Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
* Scripts/webkitpy/layout_tests/port/gtk.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
* Scripts/webkitpy/layout_tests/port/qt.py:
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
* Scripts/webkitpy/layout_tests/port/win.py:
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
* Scripts/webkitpy/tool/servers/rebaselineserver.py:
* Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse dumpAsText() to avoid an image result being generated
haraken@chromium.org [Wed, 9 Nov 2011 23:40:17 +0000 (23:40 +0000)]
Use dumpAsText() to avoid an image result being generated
https://bugs.webkit.org/show_bug.cgi?id=71386

Reviewed by Tony Chang.

single-line-must-not-be-split-into-two-pages.html had been producing
a huge image result. What we need is a way by which we can generate a
DumpRenderTree result but do not generate an image even if
--pixel-test option is specified for ./Tools/Scripts/new-run-webkit-tests.
This patch realizes it using dumpAsText() and
window.internals.elementRenderTreeAsText.

* printing/single-line-must-not-be-split-into-two-pages.html: Used dumpAsText() and window.internals.elementRenderTreeAsText.
* platform/chromium-cg-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
* platform/chromium-cg-mac-snowleopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
* platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
* platform/chromium-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
* platform/chromium-mac-snowleopard/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
* platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png: Removed.
* platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Updated a test result.
* platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-09 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Wed, 9 Nov 2011 23:32:47 +0000 (23:32 +0000)]
2011-11-09  Andrew Scherkus  <scherkus@chromium.org>

        Clean up a few media test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit/chromium: Fix crash by handling case when AccessibilityObject::lineForP...
dmazzoni@google.com [Wed, 9 Nov 2011 23:28:12 +0000 (23:28 +0000)]
Source/WebKit/chromium: Fix crash by handling case when AccessibilityObject::lineForPosition
returns -1.
https://bugs.webkit.org/show_bug.cgi?id=71561

Adds layout test: platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html

Reviewed by Dimitri Glazkov.

* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::lineBreaks):

Tools: [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
https://bugs.webkit.org/show_bug.cgi?id=71561

Reviewed by Dimitri Glazkov.

* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::insertionPointLineNumberGetterCallback):

LayoutTests: [Chromium] Add new test for crash in WebAccessibilityObject::lineBreaks
https://bugs.webkit.org/show_bug.cgi?id=71561

Reviewed by Dimitri Glazkov.

* platform/chromium/accessibility/insertion-point-line-number-on-password-crashes-expected.txt: Added.
* platform/chromium/accessibility/insertion-point-line-number-on-password-crashes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebGraphicsLayer behaves wrongly when no contentsScale is set.
alexis.menard@openbossa.org [Wed, 9 Nov 2011 23:27:51 +0000 (23:27 +0000)]
WebGraphicsLayer behaves wrongly when no contentsScale is set.
https://bugs.webkit.org/show_bug.cgi?id=71959

Reviewed by Noam Rosenthal.

The contentsScale needs to get a default value just like
TiledBackingStore in case no value is explicitely set.

It is covered by existing tests.

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::WebGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize JSVariableObject::isDynamicScope
mhahnenberg@apple.com [Wed, 9 Nov 2011 23:21:56 +0000 (23:21 +0000)]
De-virtualize JSVariableObject::isDynamicScope
https://bugs.webkit.org/show_bug.cgi?id=71933

Reviewed by Geoffrey Garen.

* runtime/JSActivation.cpp:
* runtime/JSActivation.h: Inlined and de-virtualized isDynamicScope
(JSC::JSActivation::isDynamicScope):
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h: Inlined and de-virtualized isDynamicScope
(JSC::JSGlobalObject::isDynamicScope):
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h: Inlined and de-virtualized isDynamicScope
(JSC::JSStaticScopeObject::createStructure): Changed createStructure to use new JSType
(JSC::JSStaticScopeObject::isDynamicScope):
* runtime/JSType.h: Added new type for JSStaticScopeObject
* runtime/JSVariableObject.cpp: De-virtualized and added an implementation that checks the
object's type and calls the corresponding implementation.
(JSC::JSVariableObject::isDynamicScope):
* runtime/JSVariableObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize JSGlobalObject::hasOwnPropertyForWrite
mhahnenberg@apple.com [Wed, 9 Nov 2011 23:14:53 +0000 (23:14 +0000)]
De-virtualize JSGlobalObject::hasOwnPropertyForWrite
https://bugs.webkit.org/show_bug.cgi?id=71934

Reviewed by Geoffrey Garen.

* runtime/JSGlobalObject.h: Removed the virtual-ness of hasOwnPropertyForWrite since nobody overrides it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix MHTML generation to use the QuotedPrintable encoding for text resources.
jcivelli@chromium.org [Wed, 9 Nov 2011 23:13:59 +0000 (23:13 +0000)]
Fix MHTML generation to use the QuotedPrintable encoding for text resources.
This was regressed when we added binary encoding support.
https://bugs.webkit.org/show_bug.cgi?id=71857

Reviewed by Adam Barth.

Source/WebCore:

* loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::generateMHTMLData):

Source/WebKit/chromium:

* tests/WebPageNewSerializerTest.cpp:
(WebKit::LineReader::LineReader):
(WebKit::LineReader::getNextLine):
(WebKit::WebPageNewSerializeTest::setUpCSSTestPage):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=71873
barraclough@apple.com [Wed, 9 Nov 2011 23:05:03 +0000 (23:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::absDouble):
* assembler/MacroAssemblerARMv7.h:
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::absDouble):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::absDouble):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::absDouble):
* assembler/MacroAssemblerX86Common.h:
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::absDouble):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/ThunkGenerators.cpp:
(JSC::absThunkGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace [CanBeConstructed] IDL with [Constructor] IDL
haraken@chromium.org [Wed, 9 Nov 2011 22:58:30 +0000 (22:58 +0000)]
Replace [CanBeConstructed] IDL with [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=71927

Reviewed by Adam Barth.

With respect to the IDL files that have [CanBeConstructed]
but do not have [Constructor] nor [CustomConstructor],
[CanBeConstructed] is now equivalent to [Constructor].
Thus, this patch replaces [CanBeConstructed] with [Constructor].

No tests. No change in behavior.

* fileapi/FileReaderSync.idl: As I described above.
* fileapi/WebKitBlobBuilder.idl: Ditto.
* fileapi/WebKitFlags.idl: Ditto.
* xml/DOMParser.idl: Ditto.
* xml/XMLSerializer.idl: Ditto.
* xml/XPathEvaluator.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Separate image encoding from dataURL construction
noel.gordon@gmail.com [Wed, 9 Nov 2011 22:53:03 +0000 (22:53 +0000)]
[chromium] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=71846

Reviewed by Adam Barth.

Remove the implicit assumption that a dataURL is the only desired output format of the
the image encoding phase.

No new tests, refactoring only, covered by existing canvas tests.

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::encodeImage):  Output the encoded image to a Vector.
(WebCore::ImageBuffer::toDataURL):  Format the dataURL encoding of the mimeType encoded
image Vector here.  Move the mimeType encoding debug check here to better align this
code with the CG (CoreGraphics) ImageBuffer.cpp implementation.
(WebCore::ImageDataToDataURL): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement dumpProgressFinishedCallback() for Mac layoutTestController
commit-queue@webkit.org [Wed, 9 Nov 2011 22:43:05 +0000 (22:43 +0000)]
Implement dumpProgressFinishedCallback() for Mac layoutTestController
https://bugs.webkit.org/show_bug.cgi?id=66772

Patch by Benjamin Poulain <bpoulain@apple.com> on 2011-11-09
Reviewed by Simon Fraser.

Tools:

When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
"postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().

On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
in the FrameLoadDelegate and print the output in response to the notification.

* DumpRenderTree/mac/FrameLoadDelegate.mm:
(-[FrameLoadDelegate init]):
(-[FrameLoadDelegate dealloc]):
(-[FrameLoadDelegate webViewProgressFinishedNotification:]):

LayoutTests:

Unskip the skipped test.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium: Fix bad rubber-band overhang shadows being drawn in the presence of custom...
commit-queue@webkit.org [Wed, 9 Nov 2011 22:29:29 +0000 (22:29 +0000)]
Chromium: Fix bad rubber-band overhang shadows being drawn in the presence of custom scrollbar css.
https://bugs.webkit.org/show_bug.cgi?id=71719

Source/WebCore:

This was caused by the overhang calculation logic not being consistent when subtracting the scrollbar sizes from the overhang areas. This resulted in for e.g. a horizontal overhang that didn't overlap with the scrollbar while the vertical overhang overlapped with it. This fix makes the logic consistent so that the overhang areas do not overlap with the scrollbars (when scrollbars are opaque).

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-11-09
Reviewed by Beth Dakin.

Tests: platform/chromium/rubberbanding/custom-scrollbars-ne.html
       platform/chromium/rubberbanding/custom-scrollbars-nw.html
       platform/chromium/rubberbanding/custom-scrollbars-se.html
       platform/chromium/rubberbanding/custom-scrollbars-sw.html

* platform/ScrollView.cpp:
(WebCore::ScrollView::wheelEvent):

LayoutTests:

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-11-09
Reviewed by Beth Dakin.

* platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png: Added.
* platform/chromium/rubberbanding/custom-scrollbars-ne-expected.txt: Added.
* platform/chromium/rubberbanding/custom-scrollbars-ne.html: Added.
* platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png: Added.
* platform/chromium/rubberbanding/custom-scrollbars-nw-expected.txt: Added.
* platform/chromium/rubberbanding/custom-scrollbars-nw.html: Added.
* platform/chromium/rubberbanding/custom-scrollbars-se-expected.png: Added.
* platform/chromium/rubberbanding/custom-scrollbars-se-expected.txt: Added.
* platform/chromium/rubberbanding/custom-scrollbars-se.html: Added.
* platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png: Added.
* platform/chromium/rubberbanding/custom-scrollbars-sw-expected.txt: Added.
* platform/chromium/rubberbanding/custom-scrollbars-sw.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rebaseline after r99752.
jchaffraix@webkit.org [Wed, 9 Nov 2011 22:20:08 +0000 (22:20 +0000)]
Unreviewed rebaseline after r99752.

* platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
* platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed.
* platform/chromium-win/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/chromium-win/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-inside-table-cell-expected.png: Added.
* platform/chromium-win/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
* platform/chromium-win/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/chromium-win/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* platform/chromium-win/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Layout Test fast/forms/select-clientheight-large-size.html is timing out
ojan@chromium.org [Wed, 9 Nov 2011 22:16:50 +0000 (22:16 +0000)]
[Chromium] Layout Test fast/forms/select-clientheight-large-size.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=71880

Reviewed by Tony Chang.

Makes the test run ~10x faster by making the second select element only have 16
option elements. As best I can tell, that covers all the edge cases from r99653.

Also, cleaned up the test to make it a more normal js test:
-Gave it a doctype so it's in standards-mode.
-Moved the description to a description call.
-Generated both select element in script instead of just one of them.

* fast/forms/select-clientheight-large-size-expected.txt:
* fast/forms/select-clientheight-large-size.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate test description.
antti@apple.com [Wed, 9 Nov 2011 21:59:15 +0000 (21:59 +0000)]
Update test description.

Not reviewed.

* svg/dom/rgb-color-parser-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Indentation error in RenderObject::container
commit-queue@webkit.org [Wed, 9 Nov 2011 21:25:05 +0000 (21:25 +0000)]
Source/WebCore: Indentation error in RenderObject::container
https://bugs.webkit.org/show_bug.cgi?id=64780

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-09
Reviewed by Eric Seidel.

A conditional block was indented too far; correcting.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::container):

LayoutTests: Rebaselining gtk and qt results for foreign object overflow
https://bugs.webkit.org/show_bug.cgi?id=64780

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-09
Reviewed by Eric Seidel.

Fix for 64780 changed results for one layoutTest. This is the rebaseline for gtk and qt platforms.

* platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
* platform/qt/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse contentsToRootView/rootViewToContents when converting between frame coordinate...
andersca@apple.com [Wed, 9 Nov 2011 21:18:44 +0000 (21:18 +0000)]
Use contentsToRootView/rootViewToContents when converting between frame coordinate systems
https://bugs.webkit.org/show_bug.cgi?id=71947

Reviewed by Sam Weinig.

This gets rid of a few calls to contentsToWindow and windowToContents.

* inspector/DOMNodeHighlighter.cpp:
* page/DragController.cpp:
(WebCore::DragController::startDrag):
(WebCore::DragController::doSystemDrag):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize JSObject::getOwnPropertyDescriptor
mhahnenberg@apple.com [Wed, 9 Nov 2011 21:09:37 +0000 (21:09 +0000)]
De-virtualize JSObject::getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=71523

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added getOwnPropertyDescriptor to the MethodTable, changed all of the
virtual versions of getOwnPropertyDescriptor to static ones, and
changed all of the call sites to the corresponding lookup in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyDescriptor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertyDescriptor):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertyDescriptor):
* runtime/Arguments.h:
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getOwnPropertyDescriptor):
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertyDescriptor):
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::getOwnPropertyDescriptor):
* runtime/BooleanPrototype.h:
* runtime/ClassInfo.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getOwnPropertyDescriptor):
* runtime/DateConstructor.h:
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::getOwnPropertyDescriptor):
* runtime/DatePrototype.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::getOwnPropertyDescriptor):
* runtime/ErrorPrototype.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertyDescriptor):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertyDescriptor):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getOwnPropertyDescriptor):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertyDescriptor):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::getOwnPropertyDescriptor):
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertyDescriptor):
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::JSONObject::getOwnPropertyDescriptor):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::vtableAnchor):
(JSC::JSObject::propertyIsEnumerable):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::JSObject::getPropertyDescriptor):
(JSC::JSObject::defineOwnProperty):
* runtime/JSObject.h:
* runtime/JSString.cpp: Removed getOwnPropertyDescriptor, since this seems to be a relic from a
bygone era when getOwnPropertyDescriptor was rooted in JSCell rather than JSObject.  There were
no call sites for this version of getOwnPropertyDescriptor in the entire project.
* runtime/JSString.h:
* runtime/Lookup.h:
(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionDescriptor):
(JSC::getStaticValueDescriptor):
* runtime/MathObject.cpp:
(JSC::MathObject::getOwnPropertyDescriptor):
* runtime/MathObject.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertyDescriptor):
* runtime/NumberConstructor.h:
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::getOwnPropertyDescriptor):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyDescriptor):
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::getOwnPropertyDescriptor):
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getOwnPropertyDescriptor):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::getOwnPropertyDescriptor):
* runtime/RegExpObject.h:
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::getOwnPropertyDescriptor):
* runtime/RegExpPrototype.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getOwnPropertyDescriptor):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::vtableAnchor): Added to prevent a weak vtable.
(JSC::StringObject::getOwnPropertyDescriptor):
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::getOwnPropertyDescriptor):
* runtime/StringPrototype.h:

Source/WebCore:

No new tests.

Added getOwnPropertyDescriptor to the MethodTable, changed all of the
virtual versions of getOwnPropertyDescriptor to static ones, and
changed all of the call sites to the corresponding lookup in the MethodTable.

* WebCore.exp.in:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertyDescriptor):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::getOwnPropertyDescriptorDelegate):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestInterface::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestMediaQueryListListener::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
(WebCore::JSTestObj::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertyDescriptor):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):
* bridge/qt/qt_runtime.h:
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertyDescriptor):
* bridge/runtime_array.h:
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::vtableAnchor): Added to prevent a weak vtable.
(JSC::RuntimeMethod::getOwnPropertyDescriptor):
* bridge/runtime_method.h: Changed getOwnPropertyDescriptor from private to protected to allow
subclasses to use it in their MethodTables.
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
* bridge/runtime_object.h:

Source/WebKit2:

Added getOwnPropertyDescriptor to the MethodTable, changed all of the
virtual versions of getOwnPropertyDescriptor to static ones, and
changed all of the call sites to the corresponding lookup in the MethodTable.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getOwnPropertyDescriptor):
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline after r99616 and r99736.
xji@chromium.org [Wed, 9 Nov 2011 20:49:01 +0000 (20:49 +0000)]
Rebaseline after r99616 and r99736.
Delete platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
so that cr-mac failed for text too.

* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r93614): Content remains despite parent element being scrolled off page...
jchaffraix@webkit.org [Wed, 9 Nov 2011 20:35:23 +0000 (20:35 +0000)]
REGRESSION (r93614): Content remains despite parent element being scrolled off page using javascript.
https://bugs.webkit.org/show_bug.cgi?id=71550

Reviewed by Simon Fraser.

Source/WebCore:

Tests: fast/repaint/overflow-auto-in-overflow-auto-scrolled.html
       fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html
       fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html
       fast/repaint/scroll-inside-table-cell.html
       fast/repaint/scroll-relative-table-inside-table-cell.html
       fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html
       fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html
       fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html

The issue was that updateLayerPositionsAfterScroll would not update some layer's
repaint rectangles. Thus we would not properly repaint (if at all).

The optimization added in 93614 was short-sighted and missed the fact that tables are a
special case when it comes to updating the repaint rectangles. When we scroll a layer
with an overflow clip, most layers *do* need to update their repaint rectangles.

This changes keeps the optimization for cells as this is the hotest case for tables
with overflow: hidden on cells but is much more conservative: if we encounter an
overflow clip, we update the descendant's repaint rectangles.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
Refactored the code to use some flags (HasSeenFixedPositionedAncestor and
HasSeenAncestorWithOverflowClip). Also added an exception if
m_canSkipRepaintRectsUpdateOnScroll is set.

* rendering/RenderLayer.h:
Added a new field when it is fine to not update our repaint rects on scroll.

LayoutTests:

Added some repaint tests on the same idea (overflow: scroll / auto / hidden +/- table).

* fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
* fast/repaint/overflow-auto-in-overflow-auto-scrolled.html: Added.
* fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
* fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html: Added.
* fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
* fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html: Added.
* fast/repaint/scroll-inside-table-cell-expected.txt: Added.
* fast/repaint/scroll-inside-table-cell.html: Added.
* fast/repaint/scroll-relative-table-inside-table-cell-expected.txt: Added.
* fast/repaint/scroll-relative-table-inside-table-cell.html: Added.
* fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
* fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html: Added.
* fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
* fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html: Added.
* fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
* fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html: Added.
* platform/chromium-linux/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/chromium-linux/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
* platform/chromium-linux/fast/repaint/scroll-inside-table-cell-expected.png: Added.
* platform/chromium-linux/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
* platform/chromium-linux/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
* platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
* platform/chromium-linux/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTests depending on video-paint-test.js can run non-deterministically
scherkus@chromium.org [Wed, 9 Nov 2011 20:28:24 +0000 (20:28 +0000)]
Tests depending on video-paint-test.js can run non-deterministically
https://bugs.webkit.org/show_bug.cgi?id=71878

Reviewed by Darin Adler.

* media/video-frame-accurate-seek.html: changed init() to initAndSeeked()
* media/video-paint-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate the HTMLAudioElement constructor using [NamedConstructor] IDL
haraken@chromium.org [Wed, 9 Nov 2011 20:22:42 +0000 (20:22 +0000)]
Generate the HTMLAudioElement constructor using [NamedConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=71924

Reviewed by Adam Barth.

This patch removes a custom constructor of HTMLAudioElement
and generates it using [NamedConstructor] IDL.

Tests:  fast/js/custom-constructors.html
        media/audio-constructor.html
        media/audio-constructor-src.html
        media/audio-constructor-preload.html
        media/audio-controls-do-not-fade-out.html
        media/audio-controls-rendering.html

* Target.pri: Removed V8HTMLAudioElementConstructor.{h,cpp}
* WebCore.gypi: Ditto.
* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Removed.
* bindings/v8/custom/V8HTMLAudioElementConstructor.h: Removed.
* html/HTMLAudioElement.idl: Added [NamedConstructor] IDL.
* page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEliminate CSSMutableValue
antti@apple.com [Wed, 9 Nov 2011 20:13:02 +0000 (20:13 +0000)]
Eliminate CSSMutableValue
https://bugs.webkit.org/show_bug.cgi?id=71811

Source/WebCore:

Reviewed by Darin Adler, Andreas Kling and Nikolas Zimmerman.

Remove the implementations of setter functions in SVGColor and SVGPaint. These interfaces are
deprecated in SVG 1.1 (2nd edition) and are not really used by anybody. This allows
removal of CSSMutableValue and the associated (rather broken) code.

The setters now throw NO_MODIFICATION_ALLOWED_ERR.

* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSMutableStyleDeclaration.cpp:
(WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
* css/CSSMutableValue.h: Removed.
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::getPropertyCSSValue):
* css/CSSValue.h:
(WebCore::CSSValue::CSSValue):
* svg/SVGColor.cpp:
(WebCore::SVGColor::SVGColor):
(WebCore::SVGColor::setRGBColor):
(WebCore::SVGColor::setRGBColorICCColor):
(WebCore::SVGColor::setColor):
* svg/SVGColor.h:
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::setUri):
(WebCore::SVGPaint::setPaint):
* svg/SVGPaint.h:

LayoutTests:

Reviewed by Darin Adler, Andreas Kling and Nikolas Zimmerman.

SVGColor and SVGPaint setter function are deprecated and throw exception.

- Remove (mostly render tree dump based) tests for SVGColor mutations that have little useful
  coverage otherwise.
- Fix some other tests to work without the feature.
- Update rgb-color-parser.html to also cover the cases from rgbcolor-syntax.svg (which is removed).
  They test the same thing but the former uses a better mechanism.
- Update the test results to capture the new behavior.

* fast/css/parse-color-int-or-percent-crash.html:
* platform/gtk/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
* platform/gtk/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
* platform/gtk/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
* platform/gtk/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
* platform/gtk/svg/custom/rgbcolor-syntax-expected.png: Removed.
* platform/gtk/svg/custom/rgbcolor-syntax-expected.txt: Removed.
* platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
* platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
* platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
* platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
* platform/mac/svg/custom/rgbcolor-syntax-expected.png: Removed.
* platform/mac/svg/custom/rgbcolor-syntax-expected.txt: Removed.
* platform/qt/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
* platform/qt/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
* platform/qt/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
* platform/qt/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
* platform/qt/svg/custom/rgbcolor-syntax-expected.png: Removed.
* platform/qt/svg/custom/rgbcolor-syntax-expected.txt: Removed.
* svg/custom/SVGPaint-mutate-attribute.svg: Removed.
* svg/custom/SVGPaint-mutate-inline-style.svg: Removed.
* svg/custom/fill-SVGPaint-interface.svg:
* svg/custom/getPresentationAttribute-modify-expected.txt: Removed.
* svg/custom/getPresentationAttribute-modify.svg: Removed.
* svg/custom/getPresentationAttribute.svg:
* svg/custom/rgbcolor-syntax.svg: Removed.
* svg/dom/SVGColor-expected.txt:
* svg/dom/SVGPaint-expected.txt:
* svg/dom/getPresentationAttribute-cache-corruption-expected.txt: Removed.
* svg/dom/getPresentationAttribute-cache-corruption.svg: Removed.
* svg/dom/rgb-color-parser-expected.txt:
* svg/dom/rgb-color-parser.html:
* svg/dom/script-tests/SVGColor.js:
* svg/dom/script-tests/SVGPaint.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK][DRT] window internals object is not reset after each test
philn@webkit.org [Wed, 9 Nov 2011 20:10:58 +0000 (20:10 +0000)]
[GTK][DRT] window internals object is not reset after each test
https://bugs.webkit.org/show_bug.cgi?id=71890

Reviewed by Martin Robinson.

.:

* Source/autotools/symbols.filter: Revert un-needed symbol.

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Remove problematic
calls to WebCoreSupport which belongs to libWebCoreInternals, not libwebkitgtk.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:

Tools:

Call WebCoreTestSupport::resetInternalsObject without going
through DumpRenderTreeSupport.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate the HTMLOptionElement constructor using [NamedConstructor] IDL
haraken@chromium.org [Wed, 9 Nov 2011 20:05:40 +0000 (20:05 +0000)]
Generate the HTMLOptionElement constructor using [NamedConstructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=71925

Reviewed by Adam Barth.

This patch removes a custom constructor of HTMLOptionElement,
and generates it using [NamedConstructor] IDL.

Tests: fast/js/custom-constructors.html
       fast/forms/option-index.html
       fast/forms/add-and-remove-option.html
       fast/dom/dom-add-optionelement.html

* Target.pri: Removed V8HTMLOptionElementConstructor.{h,cpp}
* WebCore.gypi: Ditto.
* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Removed.
* bindings/v8/custom/V8HTMLOptionElementConstructor.h: Removed.
* html/HTMLOptionElement.idl: Added [NamedConstructor] IDL.
* page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
bdakin@apple.com [Wed, 9 Nov 2011 20:04:02 +0000 (20:04 +0000)]
Build fix.

* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementAttributeValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=71873
barraclough@apple.com [Wed, 9 Nov 2011 20:01:24 +0000 (20:01 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71873

Reviewed by Geoff Garen.

Incrementally re-landing these changes, trying to determine what went wrong.
(The whole patch failed tests on the build bot but worked locally.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::supportsFloatingPoint):
(JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARM::supportsFloatingPointAbs):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::supportsFloatingPoint):
(JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
(JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
(JSC::MacroAssemblerARMv7::supportsFloatingPointAbs):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::supportsFloatingPoint):
(JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
(JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
(JSC::MacroAssemblerMIPS::supportsFloatingPointAbs):
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::supportsFloatingPoint):
(JSC::MacroAssemblerSH4::supportsFloatingPointTruncate):
(JSC::MacroAssemblerSH4::supportsFloatingPointSqrt):
(JSC::MacroAssemblerSH4::supportsFloatingPointAbs):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::supportsFloatingPoint):
(JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86::supportsFloatingPointAbs):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::supportsFloatingPoint):
(JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
(JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
(JSC::MacroAssemblerX86_64::supportsFloatingPointAbs):
* jit/ThunkGenerators.cpp:
(JSC::absThunkGenerator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in RenderTableSection::splitColumn
jchaffraix@webkit.org [Wed, 9 Nov 2011 19:57:16 +0000 (19:57 +0000)]
Crash in RenderTableSection::splitColumn
https://bugs.webkit.org/show_bug.cgi?id=70171

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/table/crash-splitColumn-2.html
       fast/table/crash-splitColumn-3.html
       fast/table/crash-splitColumn.html

The old code would not take into account the fact that each RenderTableSection
can set its m_needsCellRecalc flag independently of the rest.

This means that you cannot assume that you can always split or append columns to
all the sections. Our approach is to skip sections needing cell recalc in several
parts of the code as they will be properly reset to the table's representations
during a cell recalc.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):
Skip sections needing cell recalc as they will be properly updated later.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addCell):
Ignore a section needing cell recalc as addCell will be called after sync'ing
the internal column representation in recalcCells.

(WebCore::RenderTableSection::recalcCells):
Clear the flag at the beginning of the function to activate the previous functions.
Added a comment as to why this is fine.

(WebCore::RenderTableSection::appendColumn):
Added an ASSERT. If we need cell recalc, we should NEVER update m_grid outside
of recalcCells().

LayoutTests:

Added a couple of tests where different sections get their
m_needsCellRecalc set independently.

* fast/table/crash-splitColumn-2-expected.txt: Added.
* fast/table/crash-splitColumn-2.html: Added.
* fast/table/crash-splitColumn-3-expected.txt: Added.
* fast/table/crash-splitColumn-3.html: Added.
* fast/table/crash-splitColumn-expected.txt: Added.
* fast/table/crash-splitColumn.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeculative build fix.
bdakin@apple.com [Wed, 9 Nov 2011 19:45:08 +0000 (19:45 +0000)]
Speculative build fix.

* DumpRenderTree/AccessibilityUIElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMicrodata: fast/dom/MicroData/itemid-attribute-test.html assertion failure in Element...
commit-queue@webkit.org [Wed, 9 Nov 2011 19:35:28 +0000 (19:35 +0000)]
Microdata: fast/dom/MicroData/itemid-attribute-test.html assertion failure in Element::getURLAttribute().
https://bugs.webkit.org/show_bug.cgi?id=71510

Patch by Arko Saha <arko@motorola.com> on 2011-11-09
Reviewed by Darin Adler.

Source/WebCore:

Override isURLAttribute() for HTMLElement and return true if attribute is itemidAttr.
All the classes derived from HTMLElement overrides this function should return true if attribute is itemidAttr.
Removed HTMLIFrameElement::isURLAttribute() method as HTMLFrameElementBase already takes care of it.

Test: fast/dom/MicroData/itemid-attribute-test-001.html

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isURLAttribute):
* html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::isURLAttribute):
* html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::isURLAttribute):
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::isURLAttribute):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::isURLAttribute):
* html/HTMLElement.h:
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::isURLAttribute):
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::isURLAttribute):
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::isURLAttribute):
* html/HTMLHtmlElement.cpp:
(WebCore::HTMLHtmlElement::isURLAttribute):
* html/HTMLIFrameElement.cpp:
* html/HTMLIFrameElement.h:
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::isURLAttribute):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isURLAttribute):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::isURLAttribute):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isURLAttribute):
* html/HTMLModElement.cpp:
(WebCore::HTMLModElement::isURLAttribute):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::isURLAttribute):
* html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::isURLAttribute):
* html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::isURLAttribute):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::isURLAttribute):
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::isURLAttribute):
* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::isURLAttribute):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::isURLAttribute):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::isURLAttribute):

LayoutTests:

* fast/dom/MicroData/itemid-attribute-test-001-expected.txt: Added.
* fast/dom/MicroData/itemid-attribute-test-001.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix.
jchaffraix@webkit.org [Wed, 9 Nov 2011 19:28:12 +0000 (19:28 +0000)]
Unreviewed build fix.

* DumpRenderTree/AccessibilityUIElement.cpp:
(AccessibilityUIElement::makeJSAccessibilityUIElement):
A bad merge added this check that is making the bots sad.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: crash when accessing selectedTab in a tab list
cfleizach@apple.com [Wed, 9 Nov 2011 19:08:03 +0000 (19:08 +0000)]
AX: crash when accessing selectedTab in a tab list
https://bugs.webkit.org/show_bug.cgi?id=70938

Reviewed by Beth Dakin.

Source/WebCore:

There were a few methods accessing m_children directly without first validating that those elements
needed to be updated (because the layout changed). Changing those to call children() ensures
that they will have the correct children.

Test: platform/mac/accessibility/selected-tab-crash.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isChecked):
(WebCore::AccessibilityRenderObject::selectedRadioButton):
(WebCore::AccessibilityRenderObject::selectedTabItem):
(WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
(WebCore::AccessibilityRenderObject::tabChildren):

Tools:

Add the ability to retrieve an element through an arbitrary attribute.

* DumpRenderTree/AccessibilityUIElement.cpp:
(uiElementAttributeValueCallback):
(AccessibilityUIElement::uiElementAttributeValue):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::uiElementAttributeValue):

LayoutTests:

* platform/mac/accessibility/selected-tab-crash-expected.txt: Added.
* platform/mac/accessibility/selected-tab-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove failures fixed with r99630.
ojan@chromium.org [Wed, 9 Nov 2011 19:03:20 +0000 (19:03 +0000)]
Remove failures fixed with r99630.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK new baselines for 2 svg tests and skip a crashing
philn@webkit.org [Wed, 9 Nov 2011 18:46:15 +0000 (18:46 +0000)]
Unreviewed, GTK new baselines for 2 svg tests and skip a crashing
test that needs investigation.

* platform/gtk/Skipped:
* platform/gtk/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
* platform/gtk/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline after r99616.
xji@chromium.org [Wed, 9 Nov 2011 18:44:25 +0000 (18:44 +0000)]
Rebaseline after r99616.

* platform/chromium-linux/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
* platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
* platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFixing build on MacOSX SL after 71838
achicu@adobe.com [Wed, 9 Nov 2011 18:41:14 +0000 (18:41 +0000)]
Fixing build on MacOSX SL after 71838
https://bugs.webkit.org/show_bug.cgi?id=71912

Reviewed by Anders Carlsson.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink HTMLCollection.
andreas.kling@nokia.com [Wed, 9 Nov 2011 18:14:09 +0000 (18:14 +0000)]
Shrink HTMLCollection.
<http://webkit.org/b/71928>

Reviewed by Darin Adler.

Rearrange the members of HTMLCollection, effectively shrinking
it by 16 bytes on 64-bit. This reduces memory consumption
by 531 kB when loading the full HTML5 spec.

On 32-bit it shrinks by 8 bytes, saving 265 kB.

* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::HTMLCollection):
* html/HTMLCollection.h:
(WebCore::HTMLCollection::type):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd code path in HashTable for emptyValueIsZero that does not require copying the...
darin@apple.com [Wed, 9 Nov 2011 18:11:47 +0000 (18:11 +0000)]
Add code path in HashTable for emptyValueIsZero that does not require copying the empty value
https://bugs.webkit.org/show_bug.cgi?id=71875

Reviewed by Anders Carlsson.

This is a step along the path of making OwnPtr work as HashMap value types.

* wtf/Alignment.h: Moved the AlignedBufferChar and AlignedBuffer types from Vector.h here.
Also fixed include style. To include other WTF headers inside WTF, we use "" includes.
I did not change the code to fix style checker complaints.

* wtf/HashTable.h: Added includes as needed and fixed include style.
(WTF::doubleHash): Removed the uneeeded and inappropriate "static" in this function, which
gave it internal linkage for no good reason.
(WTF::HashTable::checkKey): Made this use AlignedBuffer for the deleted value check to avoid
construction/destruction problems instead of doing the trick where we construct and destroy
an empty value twice. It's cleaner and simpler and avoids copying the empty value.
(WTF::HashTable::initializeBucket): Specialized initializeBucket to use memset when the
empty value is zero rather than copying an empty value.

* wtf/Vector.h: Moved the AlignedBufferChar and AlignedBuffer types into Alignment.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove redundant [CanBeConstructed] IDLs
haraken@chromium.org [Wed, 9 Nov 2011 18:07:12 +0000 (18:07 +0000)]
Remove redundant [CanBeConstructed] IDLs
https://bugs.webkit.org/show_bug.cgi?id=71868

Reviewed by Adam Barth.

If a class has [Constructor] or [CustomConstructor],
then [CanBeConstructed] is not necessary.
This patch just removes [CanBeConstructed] from all the classes
that already have [Constructor] or [CustomConstructor].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm: Corrected typo. This correction is required for this patch.
* bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-bindings-tests result.
(WebCore::ConfigureV8TestObjTemplate):
* css/WebKitCSSMatrix.idl:
* dom/BeforeLoadEvent.idl:
* dom/CustomEvent.idl:
* dom/ErrorEvent.idl:
* dom/Event.idl:
* dom/HashChangeEvent.idl:
* dom/MessageChannel.idl:
* dom/MessageEvent.idl:
* dom/OverflowEvent.idl:
* dom/PageTransitionEvent.idl:
* dom/PopStateEvent.idl:
* dom/ProgressEvent.idl:
* dom/WebKitAnimationEvent.idl:
* dom/WebKitMutationObserver.idl:
* dom/WebKitTransitionEvent.idl:
* fileapi/FileReader.idl:
* html/DOMFormData.idl:
* html/TextTrackCue.idl:
* html/canvas/ArrayBuffer.idl:
* html/canvas/DataView.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/track/TrackEvent.idl:
* mediastream/PeerConnection.idl:
* page/EventSource.idl:
* page/WebKitPoint.idl:
* webaudio/AudioContext.idl:
* websockets/CloseEvent.idl:
* websockets/WebSocket.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:
* xml/XMLHttpRequest.idl:
* xml/XSLTProcessor.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSVG foreignObject wrong container
commit-queue@webkit.org [Wed, 9 Nov 2011 18:02:50 +0000 (18:02 +0000)]
SVG foreignObject wrong container
https://bugs.webkit.org/show_bug.cgi?id=64780

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-09
Reviewed by Simon Fraser.

Source/WebCore:

Resubmitting a patch originally by scottmg@chromium.org.
In determining where to add to m_positionedObjects during a repaint,
containingBlock is used, which adds the absolute positioned object to
the containing foreignObject. But, when the contained object is
dirtied, container() was used to dirty up the tree, which skipped over
the foreignObject causing the wrong parent to needsLayout(). This fix
makes container() and containingBlock() handle svg foreignObject's in
the same way.

This patch will cause svg/overflow/overflow-on-foreignObject.svg to
require rebaselined results on qt and gtk ports.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::container):

LayoutTests:

Added layout test for 64780 fix, rebaselined a test that it broke.
This will cause gtk and qt ports to also need rebaseline.

* platform/mac/svg/overflow/overflow-on-foreignObject-expected.png: Rebaseline
* platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
* svg/foreignObject/absolute-position-foreign-object-child-crash.html: Added
* svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShrink StyleSheet on 64-bit.
andreas.kling@nokia.com [Wed, 9 Nov 2011 18:01:04 +0000 (18:01 +0000)]
Shrink StyleSheet on 64-bit.
<http://webkit.org/b/71923>

Reviewed by Darin Adler.

Move m_disabled to the top so it folds into the padding at
the end of RefCounted on 64-bit, shrinking StyleSheet by 8 bytes.

* css/StyleSheet.cpp:
(WebCore::StyleSheet::StyleSheet):
* css/StyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd webkitdirs.pm:getArchitecture implementation for GTK
commit-queue@webkit.org [Wed, 9 Nov 2011 17:40:35 +0000 (17:40 +0000)]
Add webkitdirs.pm:getArchitecture implementation for GTK
https://bugs.webkit.org/show_bug.cgi?id=71370

Patch by Andy Wingo <wingo@igalia.com> on 2011-11-09
Reviewed by Xan Lopez.

* Scripts/webkitdirs.pm (determineArchitecture): Add an
implementation for ports using autotools, so that a vanilla
`run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
to build-jsc on x86-64 machines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view.
commit-queue@webkit.org [Wed, 9 Nov 2011 17:32:47 +0000 (17:32 +0000)]
[EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=71891

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-09
Reviewed by Antonio Gomes.

This is C++ code, there is no need to cast the new objects to their
parents when creating them.

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, attempt to fix GTK 32-bits Release build after r99691.
philn@webkit.org [Wed, 9 Nov 2011 17:32:22 +0000 (17:32 +0000)]
Unreviewed, attempt to fix GTK 32-bits Release build after r99691.

* Source/autotools/symbols.filter: Add the missing symbol for resetInternalsObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding missing implementation of WebMediaStreamDescriptor::label().
commit-queue@webkit.org [Wed, 9 Nov 2011 17:07:42 +0000 (17:07 +0000)]
Adding missing implementation of WebMediaStreamDescriptor::label().

[Chromium] Missing WebMediaStreamDescriptor::label() implementation
https://bugs.webkit.org/show_bug.cgi?id=71657

Patch by Henrik Grunell <grunell@chromium.org> on 2011-11-09
Reviewed by Adam Barth.

* src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebKit2] Prepare viewport meta handling for desktop usage
kenneth@webkit.org [Wed, 9 Nov 2011 17:01:49 +0000 (17:01 +0000)]
[WebKit2] Prepare viewport meta handling for desktop usage
https://bugs.webkit.org/show_bug.cgi?id=71907

Reviewed by Simon Hausmann.

This is only used by Qt so far. Now we don't always layout pages
without the viewport meta tag, using 980 as the layout width, but
instead we use that value (it is a setting) as a minimum value, or
else we use the viewport width.

* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::updateViewportSize):
(QTouchWebViewPrivate::updateViewportConstraints):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-09 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 9 Nov 2011 16:31:48 +0000 (16:31 +0000)]
2011-11-09  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: make new inspector test pass on Qt.

        * http/tests/inspector-enabled/injected-script-discard.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEsperanto-translation
commit-queue@webkit.org [Wed, 9 Nov 2011 16:29:45 +0000 (16:29 +0000)]
Esperanto-translation
https://bugs.webkit.org/show_bug.cgi?id=69760

Unreviewed.
Patch by Kristjan SCHMIDT <kristjan.schmidt@googlemail.com>

Patch by Philippe Normand <pnormand@igalia.com> on 2011-11-09

* eo.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStyleSheet: Devirtualize styleSheetChanged().
andreas.kling@nokia.com [Wed, 9 Nov 2011 16:19:29 +0000 (16:19 +0000)]
StyleSheet: Devirtualize styleSheetChanged().
<http://webkit.org/b/71913>

Reviewed by Antti Koivisto.

Since this mechanism is only used by CSSStyleSheet, move it there.
Out-of-lined StyleSheet::setDisabled() so we can do a type check
before invoking it from there.

* css/CSSStyleSheet.h:
* css/StyleSheet.cpp:
(WebCore::StyleSheet::setDisabled):
* css/StyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
kbalazs@webkit.org [Wed, 9 Nov 2011 16:12:20 +0000 (16:12 +0000)]
[Qt] Unreviewed gardening.

Add platform results for Qt5.

* platform/qt-5.0/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
* platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99707.
hausmann@webkit.org [Wed, 9 Nov 2011 15:58:33 +0000 (15:58 +0000)]
Unreviewed, rolling out r99707.
http://trac.webkit.org/changeset/99707

Re-enable until we can disable it together with tests in one
shot.

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Disable use of QtUiTools if the library/module is not found
vestbo@webkit.org [Wed, 9 Nov 2011 15:52:02 +0000 (15:52 +0000)]
[Qt] Disable use of QtUiTools if the library/module is not found

We rely on the lookup order of prf files to inject our own uitools.prf
that will verify that QtUiTools is in fact present before allowing the
CONFIG += uitools to have any effect.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed, adding missing files to the build.
hausmann@webkit.org [Wed, 9 Nov 2011 15:46:49 +0000 (15:46 +0000)]
[Qt] Unreviewed, adding missing files to the build.

* Target.pri: Add ContentTypeParser.cpp/h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [refactoring] remove a bunch of methods from JavaScriptSourceFrameDelegate
caseq@chromium.org [Wed, 9 Nov 2011 15:40:50 +0000 (15:40 +0000)]
Web Inspector: [refactoring] remove a bunch of methods from JavaScriptSourceFrameDelegate
https://bugs.webkit.org/show_bug.cgi?id=71826

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.requestContent):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.editContent):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
* inspector/front-end/ScriptsPanel.js:

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-11-09 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 9 Nov 2011 15:35:11 +0000 (15:35 +0000)]
2011-11-09  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: annotate inspector front-end javascript so that it compiled again.

        * inspector/front-end/ShortcutsScreen.js:
        * inspector/front-end/WorkerManager.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix after r99711. (Signed/unsigned compare.)
andreas.kling@nokia.com [Wed, 9 Nov 2011 15:31:05 +0000 (15:31 +0000)]
Unreviewed build fix after r99711. (Signed/unsigned compare.)

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::getDoubleValueInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
pfeldman@chromium.org [Wed, 9 Nov 2011 15:30:38 +0000 (15:30 +0000)]
Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
https://bugs.webkit.org/show_bug.cgi?id=71842

These are the only WebKit-side changes needed. The rest will be done on the Chromium side.

Chromium bug: http://crbug.com/44350

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-11-09
Reviewed by Pavel Feldman.

* public/WebDevToolsFrontendClient.h:
(WebKit::WebDevToolsFrontendClient::moveWindowBy):
* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::moveWindowBy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Provisionally change StylesSidebarPane section DOM layout to allow...
apavlov@chromium.org [Wed, 9 Nov 2011 15:27:33 +0000 (15:27 +0000)]
Web Inspector: Provisionally change StylesSidebarPane section DOM layout to allow media queries
https://bugs.webkit.org/show_bug.cgi?id=71902

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):
(WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted.successCallback):
(WebInspector.BlankStylePropertiesSection.prototype.editingSelectorCommitted):

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles):
* inspector/elements/elements-delete-inline-style-expected.txt:
* inspector/elements/elements-panel-styles-expected.txt:
* inspector/styles/commit-selector-expected.txt:
* inspector/styles/css-live-edit-expected.txt:
* inspector/styles/metrics-box-sizing-expected.txt:
* inspector/styles/metrics-box-sizing.html:
* inspector/styles/parse-utf8-bom-expected.txt:
* inspector/styles/parse-utf8-bom.html:
* inspector/styles/show-user-agent-styles-expected.txt:
* inspector/styles/show-user-agent-styles.html:
* inspector/styles/styles-add-blank-property-expected.txt:
* inspector/styles/styles-add-invalid-property-expected.txt:
* inspector/styles/styles-add-new-rule-expected.txt:
* inspector/styles/styles-cancel-editing-expected.txt:
* inspector/styles/styles-change-node-while-editing-expected.txt:
* inspector/styles/styles-commit-editing-expected.txt:
* inspector/styles/styles-computed-trace-expected.txt:
* inspector/styles/styles-disable-inherited-expected.txt:
* inspector/styles/styles-disable-then-change-expected.txt:
* inspector/styles/styles-disable-then-delete-expected.txt:
* inspector/styles/styles-formatting-expected.txt:
* inspector/styles/styles-formatting.html:
* inspector/styles/styles-iframe-expected.txt:
* inspector/styles/styles-source-lines-expected.txt:
* inspector/styles/styles-source-lines-inline-expected.txt:
* inspector/styles/styles-update-from-js-expected.txt:
* inspector/styles/up-down-numerics-and-colors-expected.txt:
* inspector/styles/up-down-numerics-and-colors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r99701.
hausmann@webkit.org [Wed, 9 Nov 2011 15:12:58 +0000 (15:12 +0000)]
Unreviewed, rolling out r99701.
http://trac.webkit.org/changeset/99701

Breaks Qt mac build

Source/WebKit/qt:

* Api/qwebpage.cpp:
(initResources):
(QWebPagePrivate::QWebPagePrivate):

Source/WebKit2:

* WebProcess/WebPage/qt/WebPageQt.cpp:
(initResources):
(WebKit::WebPage::platformInitialize):

Tools:

* qmake/mkspecs/features/functions.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSSPrimitiveValue: Fix up bitfield member types.
andreas.kling@nokia.com [Wed, 9 Nov 2011 15:10:09 +0000 (15:10 +0000)]
CSSPrimitiveValue: Fix up bitfield member types.
<http://webkit.org/b/71751>

Reviewed by Antti Koivisto.

The primitive unit type doesn't need to be a signed value,
and by making it unsigned, we can shave one bit off of it.
Furthermore, m_hasCachedCSSText and m_isQuirkValue should be
bool, not unsigned.

* css/CSSValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK baselines for new tests.
philn@webkit.org [Wed, 9 Nov 2011 15:09:05 +0000 (15:09 +0000)]
Unreviewed, GTK baselines for new tests.

* platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
* platform/gtk/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
* platform/gtk/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
* platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
* platform/gtk/fast/hidpi/focus-rings-expected.txt: Added.
* platform/gtk/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
* platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-h-horizontal-bt-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-h-horizontal-tb-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-h-vertical-lr-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-h-vertical-rl-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-v-horizontal-bt-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-v-horizontal-tb-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-v-vertical-lr-expected.txt: Added.
* platform/gtk/fast/multicol/pagination-v-vertical-rl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: discard injected scripts upon front-end disconnect.
pfeldman@chromium.org [Wed, 9 Nov 2011 15:04:56 +0000 (15:04 +0000)]
Web Inspector: discard injected scripts upon front-end disconnect.
https://bugs.webkit.org/show_bug.cgi?id=71823

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector-enabled/injected-script-discard.html

* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::clearFrontend):

LayoutTests:

* http/tests/inspector-enabled/injected-script-discard-expected.txt: Added.
* http/tests/inspector-enabled/injected-script-discard.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS: Remove empty value and rule destructors.
andreas.kling@nokia.com [Wed, 9 Nov 2011 15:03:40 +0000 (15:03 +0000)]
CSS: Remove empty value and rule destructors.
<http://webkit.org/b/71901>

Reviewed by Antti Koivisto.

* css/CSSAspectRatioValue.h:
* css/CSSBorderImageSliceValue.h:
(WebCore::CSSBorderImageSliceValue::create):
* css/CSSBorderImageValue.h:
(WebCore::CSSBorderImageValue::create):
* css/CSSCharsetRule.cpp:
* css/CSSCharsetRule.h:
* css/CSSCrossfadeValue.h:
* css/CSSFlexValue.h:
* css/CSSFontFaceSrcValue.h:
* css/CSSFunctionValue.h:
* css/CSSPageRule.cpp:
* css/CSSPageRule.h:
* css/CSSUnicodeRangeValue.h:
* css/CSSValueList.h:
* css/WebKitCSSFilterValue.h:
* css/WebKitCSSTransformValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Prospective build fix for Win32/Mac with xmlpatterns
hausmann@webkit.org [Wed, 9 Nov 2011 15:02:41 +0000 (15:02 +0000)]
[Qt] Prospective build fix for Win32/Mac with xmlpatterns

Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/features.prf: Disable XSLT support initially.
We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
is not up to the task of full XSLT support, so we should disable it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCSS: Remove redudant WTF_MAKE_FAST_ALLOCATED macros.
andreas.kling@nokia.com [Wed, 9 Nov 2011 15:00:26 +0000 (15:00 +0000)]
CSS: Remove redudant WTF_MAKE_FAST_ALLOCATED macros.
<http://webkit.org/b/71897>

Reviewed by Antti Koivisto.

Everything that inherits from RefCounted<T> is already fast-allocated,
so we don't need this in subclasses.

* css/CSSImageValue.h:
* css/CSSImportRule.h:
* css/WebKitCSSShaderValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline and skip a crashing test.
philn@webkit.org [Wed, 9 Nov 2011 14:58:20 +0000 (14:58 +0000)]
Unreviewed, GTK rebaseline and skip a crashing test.

* platform/gtk/Skipped: Skip fast/css/webkit-mask-crash-table.html
* platform/gtk/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] failures in http/tests/security/contentSecurityPolicy with Qt5
kbalazs@webkit.org [Wed, 9 Nov 2011 14:51:33 +0000 (14:51 +0000)]
[Qt] failures in http/tests/security/contentSecurityPolicy with Qt5
https://bugs.webkit.org/show_bug.cgi?id=71906

Unreviewed gardening. Skip failing tests.

* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[TextureMapper] Clean up TextureMapperAnimation constructor
igor.oliveira@openbossa.org [Wed, 9 Nov 2011 14:45:09 +0000 (14:45 +0000)]
[TextureMapper] Clean up TextureMapperAnimation constructor
https://bugs.webkit.org/show_bug.cgi?id=71892

Remove copyAnimationValue and copyTimingFunction static functions. KeyframeList has
a copy constructor and it does not need anymore these copy functions.

Reviewed by Simon Hausmann.

* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperAnimation::TextureMapperAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning...
kbalazs@webkit.org [Wed, 9 Nov 2011 14:40:58 +0000 (14:40 +0000)]
[WK2] http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning.html fails
https://bugs.webkit.org/show_bug.cgi?id=71896

Unreviewed gardening.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit/qt: [Qt] Enable exports and constructor functions in static libs
hausmann@webkit.org [Wed, 9 Nov 2011 14:40:04 +0000 (14:40 +0000)]
Source/WebKit/qt: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate): Remove unnecessary manual Qt resource
initialization.

Source/WebKit2: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformInitialize): Remove unnecessary manual Qt resource
initialization.

Tools: [Qt] Enable exports and constructor functions in static libs

Reviewed by Tor Arne Vestbø.

* qmake/mkspecs/features/functions.prf: Use --whole-archive and their
mac/win32-msvc equivalents when linking static libraries into a shared
library or executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99701 268f45cc-cd09-0410-ab3c-d52691b4dbfc