WebKit-https.git
9 years ago2010-11-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>
commit-queue@webkit.org [Tue, 9 Nov 2010 05:05:51 +0000 (05:05 +0000)]
2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Link with target name set does not work
        https://bugs.webkit.org/show_bug.cgi?id=48865

        When a new page is created with a name (target=myFrame), the new
        mainFrame could not be found because they where not stored in the
        same PageGroup. As PageGroup are not exposed externally so the
        simpliest solution is to use a global page group name. This also fixes
        issue with visited link coloration across pages. After this change the
        private function webkit_web_view_set_group_name() was no longer used
        so it was removed completly.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::closeWindowSoon):
        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::openInspectorFrontend):
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_init):
2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Link with target name set does not work
        https://bugs.webkit.org/show_bug.cgi?id=48865

        When a new page is created with a name (target=myFrame), the new
        mainFrame could not be found because they where not stored in the
        same PageGroup. As PageGroup are not exposed externally so the
        simpliest solution is to use a global page group name. This also fixes
        issue with visited link coloration across pages. After this change the
        private function webkit_web_view_set_group_name() was no longer used
        so it was removed completly.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (createWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Jenn Braithwaite <jennb@chromium.org>
commit-queue@webkit.org [Tue, 9 Nov 2010 04:47:55 +0000 (04:47 +0000)]
2010-11-08  Jenn Braithwaite  <jennb@chromium.org>

        Reviewed by Pavel Feldman.

        _bindResourceURL in ResourceManager.js may not add resource to map
        https://bugs.webkit.org/show_bug.cgi?id=49088

        No new tests. pfeldman working on better test harness and tests.

        * inspector/front-end/ResourceManager.js:
        (WebInspector.ResourceManager.prototype._bindResourceURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 John Knottenbelt <jknotten@chromium.org>
commit-queue@webkit.org [Tue, 9 Nov 2010 04:14:36 +0000 (04:14 +0000)]
2010-11-08  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Convert to and from DOMTimeStamp with converter functions.
        This is a refactoring only, covered by existing layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=49066

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/DOMTimeStamp.h: Added.
        (WebCore::convertSecondsToDOMTimeStamp):
        (WebCore::convertDOMTimeStampToSeconds):
        * dom/Event.cpp:
        (WebCore::Event::Event):
        * dom/Event.h:
        * page/Geolocation.cpp:
        (WebCore::Geolocation::haveSuitableCachedPosition):
        * platform/android/GeolocationServiceAndroid.cpp:
        (WebCore::GeolocationServiceAndroid::isPositionMoreTimely):
2010-11-08  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Steve Block.

        Convert to and from DOMTimeStamp with converter functions
        https://bugs.webkit.org/show_bug.cgi?id=49066

        * src/WebDataSourceImpl.cpp:
        (WebKit::WebDataSourceImpl::triggeringEventTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 9 Nov 2010 04:14:11 +0000 (04:14 +0000)]
2010-11-08  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed. Rebaselines for r71589.

        * platform/chromium-linux/editing/deleting/5156801-2-expected.checksum:
        * platform/chromium-linux/editing/deleting/5156801-2-expected.png:
        * platform/chromium-linux/editing/deleting/delete-3608445-fix-expected.checksum:
        * platform/chromium-linux/editing/deleting/delete-3608445-fix-expected.png:
        * platform/chromium-linux/editing/deleting/delete-br-002-expected.checksum:
        * platform/chromium-linux/editing/deleting/delete-br-002-expected.png:
        * platform/chromium-linux/editing/deleting/delete-br-004-expected.checksum:
        * platform/chromium-linux/editing/deleting/delete-br-004-expected.png:
        * platform/chromium-linux/editing/deleting/delete-br-005-expected.checksum:
        * platform/chromium-linux/editing/deleting/delete-br-005-expected.png:
        * platform/chromium-linux/editing/deleting/delete-line-003-expected.checksum:
        * platform/chromium-linux/editing/deleting/delete-line-003-expected.png:
        * platform/chromium-linux/editing/deleting/delete-tab-004-expected.checksum:
        * platform/chromium-linux/editing/deleting/delete-tab-004-expected.png:
        * platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.checksum:
        * platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.png:
        * platform/chromium-linux/editing/execCommand/5482023-expected.checksum:
        * platform/chromium-linux/editing/execCommand/5482023-expected.png:
        * platform/chromium-linux/editing/inserting/4960120-2-expected.checksum:
        * platform/chromium-linux/editing/inserting/4960120-2-expected.png:
        * platform/chromium-linux/editing/inserting/5549929-2-expected.checksum:
        * platform/chromium-linux/editing/inserting/5549929-2-expected.png:
        * platform/chromium-linux/editing/inserting/5549929-3-expected.checksum:
        * platform/chromium-linux/editing/inserting/5549929-3-expected.png:
        * platform/chromium-linux/editing/inserting/editable-inline-element-expected.checksum:
        * platform/chromium-linux/editing/inserting/editable-inline-element-expected.png:
        * platform/chromium-linux/editing/inserting/insert-3654864-fix-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-3654864-fix-expected.png:
        * platform/chromium-linux/editing/inserting/insert-3775316-fix-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-3775316-fix-expected.png:
        * platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.png:
        * platform/chromium-linux/editing/inserting/insert-3800346-fix-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-3800346-fix-expected.png:
        * platform/chromium-linux/editing/inserting/insert-br-001-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-br-001-expected.png:
        * platform/chromium-linux/editing/inserting/insert-br-002-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-br-002-expected.png:
        * platform/chromium-linux/editing/inserting/insert-br-003-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-br-003-expected.png:
        * platform/chromium-linux/editing/inserting/insert-br-004-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-br-004-expected.png:
        * platform/chromium-linux/editing/inserting/insert-br-005-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-br-005-expected.png:
        * platform/chromium-linux/editing/inserting/insert-br-006-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-br-006-expected.png:
        * platform/chromium-linux/editing/inserting/insert-br-007-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-br-007-expected.png:
        * platform/chromium-linux/editing/inserting/insert-br-008-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-br-008-expected.png:
        * platform/chromium-linux/editing/inserting/insert-br-009-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-br-009-expected.png:
        * platform/chromium-linux/editing/inserting/insert-br-at-tabspan-001-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-br-at-tabspan-001-expected.png:
        * platform/chromium-linux/editing/inserting/insert-br-at-tabspan-002-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-br-at-tabspan-002-expected.png:
        * platform/chromium-linux/editing/inserting/insert-br-at-tabspan-003-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-br-at-tabspan-003-expected.png:
        * platform/chromium-linux/editing/inserting/insert-tab-004-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-tab-004-expected.png:
        * platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.checksum:
        * platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.png:
        * platform/chromium-linux/editing/inserting/line-break-expected.checksum:
        * platform/chromium-linux/editing/inserting/line-break-expected.png:
        * platform/chromium-linux/editing/inserting/paragraph-separator-in-table-1-expected.checksum:
        * platform/chromium-linux/editing/inserting/paragraph-separator-in-table-1-expected.png:
        * platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.checksum:
        * platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
        * platform/chromium-linux/editing/inserting/typing-003-expected.checksum:
        * platform/chromium-linux/editing/inserting/typing-003-expected.png:
        * platform/chromium-linux/editing/inserting/typing-around-br-001-expected.checksum:
        * platform/chromium-linux/editing/inserting/typing-around-br-001-expected.png:
        * platform/chromium-linux/editing/pasteboard/4989774-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/4989774-expected.png:
        * platform/chromium-linux/editing/pasteboard/5028447-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/5028447-expected.png:
        * platform/chromium-linux/editing/pasteboard/5601583-1-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/5601583-1-expected.png:
        * platform/chromium-linux/editing/pasteboard/merge-end-1-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/merge-end-1-expected.png:
        * platform/chromium-linux/editing/pasteboard/merge-end-2-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/merge-end-2-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-4035648-fix-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-4035648-fix-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-line-endings-001-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-line-endings-001-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-line-endings-006-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-line-endings-006-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-table-003-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-table-003-expected.png:
        * platform/chromium-linux/editing/pasteboard/paste-text-010-expected.checksum:
        * platform/chromium-linux/editing/pasteboard/paste-text-010-expected.png:
        * platform/chromium-linux/editing/selection/5007143-2-expected.checksum:
        * platform/chromium-linux/editing/selection/5007143-2-expected.png:
        * platform/chromium-linux/editing/selection/5007143-expected.checksum:
        * platform/chromium-linux/editing/selection/5007143-expected.png:
        * platform/chromium-linux/editing/selection/5234383-2-expected.checksum:
        * platform/chromium-linux/editing/selection/5234383-2-expected.png:
        * platform/chromium-linux/editing/selection/editable-html-element-expected.checksum:
        * platform/chromium-linux/editing/selection/editable-html-element-expected.png:
        * platform/chromium-linux/editing/selection/move-3875618-fix-expected.checksum:
        * platform/chromium-linux/editing/selection/move-3875618-fix-expected.png:
        * platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.checksum:
        * platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.png:
        * platform/chromium-linux/editing/selection/move-by-character-002-expected.checksum:
        * platform/chromium-linux/editing/selection/move-by-character-002-expected.png:
        * platform/chromium-linux/editing/selection/move-by-character-003-expected.checksum:
        * platform/chromium-linux/editing/selection/move-by-character-003-expected.png:
        * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum:
        * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png:
        * platform/chromium-linux/editing/selection/selection-3748164-fix-expected.checksum:
        * platform/chromium-linux/editing/selection/selection-3748164-fix-expected.png:
        * platform/chromium-linux/editing/unsupported-content/table-delete-001-expected.checksum:
        * platform/chromium-linux/editing/unsupported-content/table-delete-001-expected.png:
        * platform/chromium-linux/editing/unsupported-content/table-delete-003-expected.checksum:
        * platform/chromium-linux/editing/unsupported-content/table-delete-003-expected.png:
        * platform/chromium-win/editing/deleting/5156801-2-expected.checksum:
        * platform/chromium-win/editing/deleting/5156801-2-expected.png:
        * platform/chromium-win/editing/deleting/delete-3608445-fix-expected.checksum:
        * platform/chromium-win/editing/deleting/delete-3608445-fix-expected.png:
        * platform/chromium-win/editing/deleting/delete-br-002-expected.checksum:
        * platform/chromium-win/editing/deleting/delete-br-002-expected.png:
        * platform/chromium-win/editing/deleting/delete-br-004-expected.checksum:
        * platform/chromium-win/editing/deleting/delete-br-004-expected.png:
        * platform/chromium-win/editing/deleting/delete-br-005-expected.checksum:
        * platform/chromium-win/editing/deleting/delete-br-005-expected.png:
        * platform/chromium-win/editing/deleting/delete-line-003-expected.checksum:
        * platform/chromium-win/editing/deleting/delete-line-003-expected.png:
        * platform/chromium-win/editing/deleting/delete-tab-004-expected.checksum:
        * platform/chromium-win/editing/deleting/delete-tab-004-expected.png:
        * platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.checksum:
        * platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.png:
        * platform/chromium-win/editing/execCommand/5482023-expected.checksum:
        * platform/chromium-win/editing/execCommand/5482023-expected.png:
        * platform/chromium-win/editing/inserting/4960120-2-expected.checksum:
        * platform/chromium-win/editing/inserting/4960120-2-expected.png:
        * platform/chromium-win/editing/inserting/5549929-2-expected.checksum:
        * platform/chromium-win/editing/inserting/5549929-2-expected.png:
        * platform/chromium-win/editing/inserting/5549929-3-expected.checksum:
        * platform/chromium-win/editing/inserting/5549929-3-expected.png:
        * platform/chromium-win/editing/inserting/editable-inline-element-expected.checksum:
        * platform/chromium-win/editing/inserting/editable-inline-element-expected.png:
        * platform/chromium-win/editing/inserting/insert-3654864-fix-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-3654864-fix-expected.png:
        * platform/chromium-win/editing/inserting/insert-3775316-fix-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-3775316-fix-expected.png:
        * platform/chromium-win/editing/inserting/insert-3786362-fix-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-3786362-fix-expected.png:
        * platform/chromium-win/editing/inserting/insert-3800346-fix-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-3800346-fix-expected.png:
        * platform/chromium-win/editing/inserting/insert-br-001-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-br-001-expected.png:
        * platform/chromium-win/editing/inserting/insert-br-002-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-br-002-expected.png:
        * platform/chromium-win/editing/inserting/insert-br-003-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-br-003-expected.png:
        * platform/chromium-win/editing/inserting/insert-br-004-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-br-004-expected.png:
        * platform/chromium-win/editing/inserting/insert-br-005-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-br-005-expected.png:
        * platform/chromium-win/editing/inserting/insert-br-006-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-br-006-expected.png:
        * platform/chromium-win/editing/inserting/insert-br-007-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-br-007-expected.png:
        * platform/chromium-win/editing/inserting/insert-br-008-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-br-008-expected.png:
        * platform/chromium-win/editing/inserting/insert-br-009-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-br-009-expected.png:
        * platform/chromium-win/editing/inserting/insert-br-at-tabspan-001-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-br-at-tabspan-001-expected.png:
        * platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.png:
        * platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.png:
        * platform/chromium-win/editing/inserting/insert-tab-004-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-tab-004-expected.png:
        * platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.checksum:
        * platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.png:
        * platform/chromium-win/editing/inserting/line-break-expected.checksum:
        * platform/chromium-win/editing/inserting/line-break-expected.png:
        * platform/chromium-win/editing/inserting/paragraph-separator-in-table-1-expected.checksum:
        * platform/chromium-win/editing/inserting/paragraph-separator-in-table-1-expected.png:
        * platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.checksum:
        * platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
        * platform/chromium-win/editing/inserting/typing-003-expected.checksum:
        * platform/chromium-win/editing/inserting/typing-003-expected.png:
        * platform/chromium-win/editing/inserting/typing-around-br-001-expected.checksum:
        * platform/chromium-win/editing/inserting/typing-around-br-001-expected.png:
        * platform/chromium-win/editing/pasteboard/4989774-expected.checksum:
        * platform/chromium-win/editing/pasteboard/4989774-expected.png:
        * platform/chromium-win/editing/pasteboard/5028447-expected.checksum:
        * platform/chromium-win/editing/pasteboard/5028447-expected.png:
        * platform/chromium-win/editing/pasteboard/5601583-1-expected.checksum:
        * platform/chromium-win/editing/pasteboard/5601583-1-expected.png:
        * platform/chromium-win/editing/pasteboard/merge-end-1-expected.checksum:
        * platform/chromium-win/editing/pasteboard/merge-end-1-expected.png:
        * platform/chromium-win/editing/pasteboard/merge-end-2-expected.checksum:
        * platform/chromium-win/editing/pasteboard/merge-end-2-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-table-003-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-table-003-expected.png:
        * platform/chromium-win/editing/pasteboard/paste-text-010-expected.checksum:
        * platform/chromium-win/editing/pasteboard/paste-text-010-expected.png:
        * platform/chromium-win/editing/selection/5007143-2-expected.checksum:
        * platform/chromium-win/editing/selection/5007143-2-expected.png:
        * platform/chromium-win/editing/selection/5007143-expected.checksum:
        * platform/chromium-win/editing/selection/5007143-expected.png:
        * platform/chromium-win/editing/selection/5234383-2-expected.checksum:
        * platform/chromium-win/editing/selection/5234383-2-expected.png:
        * platform/chromium-win/editing/selection/editable-html-element-expected.checksum:
        * platform/chromium-win/editing/selection/editable-html-element-expected.png:
        * platform/chromium-win/editing/selection/extend-selection-expected.txt:
        * platform/chromium-win/editing/selection/move-3875618-fix-expected.checksum:
        * platform/chromium-win/editing/selection/move-3875618-fix-expected.png:
        * platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.checksum:
        * platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.png:
        * platform/chromium-win/editing/selection/move-by-character-002-expected.checksum:
        * platform/chromium-win/editing/selection/move-by-character-002-expected.png:
        * platform/chromium-win/editing/selection/move-by-character-003-expected.checksum:
        * platform/chromium-win/editing/selection/move-by-character-003-expected.png:
        * platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum:
        * platform/chromium-win/editing/selection/move-past-trailing-space-expected.png:
        * platform/chromium-win/editing/selection/selection-3748164-fix-expected.checksum:
        * platform/chromium-win/editing/selection/selection-3748164-fix-expected.png:
        * platform/chromium-win/editing/unsupported-content/table-delete-001-expected.checksum:
        * platform/chromium-win/editing/unsupported-content/table-delete-001-expected.png:
        * platform/chromium-win/editing/unsupported-content/table-delete-003-expected.checksum:
        * platform/chromium-win/editing/unsupported-content/table-delete-003-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Kenneth Rohde Christiansen <kenneth@webkit.org>
kenneth@webkit.org [Tue, 9 Nov 2010 03:41:14 +0000 (03:41 +0000)]
2010-11-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Send page scroll requests to the PageClient when scroll delegation is turned on
        https://bugs.webkit.org/show_bug.cgi?id=49171

        Implement the IPC and API required for making scroll delegation work
        with WebKit2. This is only used when you have tiling enabled.

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::pageDidRequestScroll):
        * UIProcess/API/qt/qwkpage.h:
        * UIProcess/API/qt/qwkpage_p.h:
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::pageDidRequestScroll):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::delegatedScrollRequested):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::pageDidRequestScroll):
        * WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8531943> Enable partial symbolication for sandbox violations in WebPr...
mrowe@apple.com [Tue, 9 Nov 2010 03:24:07 +0000 (03:24 +0000)]
<rdar://problem/8531943> Enable partial symbolication for sandbox violations in WebProcess.

Patch by Ivan Krstić <ike@apple.com> on 2010-11-08
Reviewed by Mark Rowe.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 9 Nov 2010 03:19:55 +0000 (03:19 +0000)]
2010-11-08  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed build fix for Chromium Mac for r71590.

        * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
        (WebCore::provideStringAndAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 John Knottenbelt <jknotten@chromium.org>
commit-queue@webkit.org [Tue, 9 Nov 2010 03:04:30 +0000 (03:04 +0000)]
2010-11-08  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Kent Tamura.

        WebViewHost::reset() uses placement new.
        https://bugs.webkit.org/show_bug.cgi?id=49069

        WebViewHost is using placement destruction / new to simulate a fresh
        WebViewHost object at the same address. This is because the WebView remains
        open across tests and maintains a pointer to the WebViewHost.
        This change resets member variables explictly instead of the placement new dance.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::WebViewHost):
        (WebViewHost::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Juha Savolainen <juha.savolainen@weego.fi>
commit-queue@webkit.org [Tue, 9 Nov 2010 02:48:21 +0000 (02:48 +0000)]
2010-11-08  Juha Savolainen  <juha.savolainen@weego.fi>

        Reviewed by Andreas Kling.

        [Qt] Added new methods to QWKHistory and made QWKHistoryItemPrivate to shared object.
        https://bugs.webkit.org/show_bug.cgi?id=49063

        Added more functionality to the QWKHistory and changed QWKHistoryItemPrivate to shared object.
        This is needed because we cannot delete the QWKHistoryItemPrivate pointer in destructor of QWKHistoryItem,
        there may have other history instances which share same private implementation.

        * UIProcess/API/qt/qwkhistory.cpp:
        (QWKHistoryItemPrivate::~QWKHistoryItemPrivate):
        (QWKHistoryItem::QWKHistoryItem):
        (QWKHistoryItem::QWKHistoryItem::operator=):
        (QWKHistory::currentItem): Added
        (QWKHistory::backItem): Added
        (QWKHistory::forwardItem): Added
        (QWKHistory::itemAt): Added
        (QWKHistory::backItems): Added
        (QWKHistory::forwardItems): Added
        * UIProcess/API/qt/qwkhistory.h:
        * UIProcess/API/qt/qwkhistory_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 9 Nov 2010 02:45:46 +0000 (02:45 +0000)]
2010-11-08  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        dump-as-markup conversion: editing/inserting/5607069-2.html and 5607069-3.html
        https://bugs.webkit.org/show_bug.cgi?id=49223

        Converted editing/inserting/5607069-2.html and editing/inserting/5607069-3.html
        to dump-as-markup tests. Re-enabled them on Qt, Gtk, and Chromium platforms.

        * editing/inserting/5607069-2-expected.txt: Added.
        * editing/inserting/5607069-2.html:
        * editing/inserting/5607069-3-expected.txt: Added.
        * editing/inserting/5607069-3.html:
        * platform/chromium-linux/editing/inserting/5607069-2-expected.checksum: Removed.
        * platform/chromium-linux/editing/inserting/5607069-2-expected.png: Removed.
        * platform/chromium-linux/editing/inserting/5607069-2-expected.txt: Removed.
        * platform/chromium-linux/editing/inserting/5607069-3-expected.checksum: Removed.
        * platform/chromium-linux/editing/inserting/5607069-3-expected.png: Removed.
        * platform/chromium-win/editing/inserting/5607069-2-expected.checksum: Removed.
        * platform/chromium-win/editing/inserting/5607069-2-expected.png: Removed.
        * platform/chromium-win/editing/inserting/5607069-2-expected.txt: Removed.
        * platform/chromium-win/editing/inserting/5607069-3-expected.checksum: Removed.
        * platform/chromium-win/editing/inserting/5607069-3-expected.png: Removed.
        * platform/chromium-win/editing/inserting/5607069-3-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac-leopard/editing/inserting/5607069-2-expected.checksum: Removed.
        * platform/mac-leopard/editing/inserting/5607069-2-expected.png: Removed.
        * platform/mac-leopard/editing/inserting/5607069-3-expected.checksum: Removed.
        * platform/mac-leopard/editing/inserting/5607069-3-expected.png: Removed.
        * platform/mac/editing/inserting/5607069-2-expected.checksum: Removed.
        * platform/mac/editing/inserting/5607069-2-expected.png: Removed.
        * platform/mac/editing/inserting/5607069-2-expected.txt: Removed.
        * platform/mac/editing/inserting/5607069-3-expected.checksum: Removed.
        * platform/mac/editing/inserting/5607069-3-expected.png: Removed.
        * platform/mac/editing/inserting/5607069-3-expected.txt: Removed.
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Anton Muhin <antonm@chromium.org>
antonm@chromium.org [Tue, 9 Nov 2010 02:32:04 +0000 (02:32 +0000)]
2010-11-08  Anton Muhin  <antonm@chromium.org>

        Reviewed by Nate Chapin.

        [v8] Get rid of automatically generated named property getter for classes with namedItem method
        https://bugs.webkit.org/show_bug.cgi?id=48770

        * platform/chromium-mac/fast/dom/HTMLSelectElement/named-options-expected.txt:
        * platform/chromium-win/fast/dom/HTMLSelectElement/named-options-expected.txt:
2010-11-08  Anton Muhin  <antonm@chromium.org>

        Reviewed by Nate Chapin.

        [v8] Get rid of automatically generated named property getter for classes with namedItem method
        https://bugs.webkit.org/show_bug.cgi?id=48770

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Tue, 9 Nov 2010 02:15:26 +0000 (02:15 +0000)]
2010-11-08  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] build error in WebKit/qt/Api/qwebpage.cpp in Qt 4.7.0
        https://bugs.webkit.org/show_bug.cgi?id=47427

        Add a missing guard in order to be able to compile when
        ENABLE(TOUCH_EVENTS) is not defined.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::touchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updating Chromium expectations.
dumi@chromium.org [Tue, 9 Nov 2010 02:08:51 +0000 (02:08 +0000)]
Unreviewed, updating Chromium expectations.

* platform/chromium-linux/editing/selection/home-end-expected.txt: Added.
* platform/chromium-linux/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
* platform/chromium-linux/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
* platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
* platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
* platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
* platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
* platform/chromium-linux/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
* platform/chromium-linux/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
* platform/chromium-linux/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
* platform/chromium-linux/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
* platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
* platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
* platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
* platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
* platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt: Added.
* platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
* platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
* platform/chromium-win/editing/selection/home-end-expected.txt:
* platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
* platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
* platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
* platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
* platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
* platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
* platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
* platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
* platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
* platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
* platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
* platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
* platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
* platform/chromium-win/fast/css/text-overflow-ellipsis-bidi-expected.txt:
* platform/chromium-win/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
* platform/chromium-win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
* platform/chromium-win/fast/text/international/bidi-explicit-embedding-expected.txt:
* platform/chromium-win/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
* platform/chromium-win/fast/text/international/bidi-neutral-run-expected.txt:
* platform/chromium-win/fast/text/international/bidi-override-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WKDownloadClient API
andersca@apple.com [Tue, 9 Nov 2010 01:54:16 +0000 (01:54 +0000)]
Add WKDownloadClient API
https://bugs.webkit.org/show_bug.cgi?id=49227

Reviewed by Dan Bernstein.

* Shared/API/c/WKBase.h:
Add WKDownloadRef.

* UIProcess/API/C/WKAPICast.h:
Add WKDownloadRef <-> DownloadProxy mapping.

* UIProcess/API/C/WKContext.cpp:
(WKContextSetDownloadClient):
Initialize the download client.

* UIProcess/API/C/WKContext.h:
Add new WKContextDownloadClient API.

* UIProcess/API/C/WKDownload.cpp: Added.
* UIProcess/API/C/WKDownload.h:
Add WKDownload files.

* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didStart):
(WebKit::DownloadProxy::didCreateDestination):
(WebKit::DownloadProxy::didFinish):
Call down to the the WebDownloadClient.

* UIProcess/Downloads/DownloadProxy.messages.in:
Rename DidBegin to DidStart.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::initializeDownloadClient):
Initialize the download client.

* UIProcess/WebContext.h:
(WebKit::WebContext::downloadClient):
Add getter.

* UIProcess/WebDownloadClient.cpp:
(WebKit::WebDownloadClient::didStart):
(WebKit::WebDownloadClient::didCreateDestination):
(WebKit::WebDownloadClient::didFinish):
Call the relevant WKContextDownloadClient functions.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
Add new files.

* WebProcess/Downloads/Download.cpp:
(WebKit::Download::didStart):
* WebProcess/Downloads/Download.h:
* WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate downloadDidBegin:]):
Rename Download::didBegin to Download::didStart.

* win/WebKit2.vcproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Ned Holbrook <nholbrook@apple.com>
commit-queue@webkit.org [Tue, 9 Nov 2010 01:53:55 +0000 (01:53 +0000)]
2010-11-08  Ned Holbrook  <nholbrook@apple.com>

        Reviewed by Adam Barth.

        Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
        https://bugs.webkit.org/show_bug.cgi?id=48886

        * WebCore.exp.in:
        * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
        (WebCore::provideStringAndAttributes):
        (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
2010-11-08  Ned Holbrook  <nholbrook@apple.com>

        Reviewed by Adam Barth.

        Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
        https://bugs.webkit.org/show_bug.cgi?id=48886

        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=49228
hyatt@apple.com [Tue, 9 Nov 2010 01:41:02 +0000 (01:41 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49228

Reviewed by Simon Fraser.

REGRESSION: caret too short when a positive line height is specified.  Now that lineTop no longer
accidentally incorporates the top leading, we need to use selectionTop/Bottom for the caret rect.

* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Tue, 9 Nov 2010 01:13:37 +0000 (01:13 +0000)]
2010-11-08  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Rebaesline for GTK after r71566
        https://bugs.webkit.org/show_bug.cgi?id=25321

        * platform/gtk/editing/selection/extend-selection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Pierre-Antoine LaFayette <pierre.lafayette@gmail.com>
commit-queue@webkit.org [Tue, 9 Nov 2010 01:05:37 +0000 (01:05 +0000)]
2010-11-08  Pierre-Antoine LaFayette  <pierre.lafayette@gmail.com>

        Reviewed by Darin Fisher.

        [chromium] Adding hasUserGesture flag to the ResourceRequest
        https://bugs.webkit.org/show_bug.cgi?id=37057

        This flag is to be used on the browser side to indicate when a
        download has been user initiated.

        No new tests. This change will be tested through a browser UI test.

        * platform/network/chromium/ResourceRequest.h:
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::hasUserGesture):
        (WebCore::ResourceRequest::setHasUserGesture):
2010-11-08  Pierre-Antoine LaFayette  <pierre.lafayette@gmail.com>

        Reviewed by Darin Fisher.

        [chromium] Adding hasUserGesture flag to the ResourceRequest
        https://bugs.webkit.org/show_bug.cgi?id=37057

        This flag is to be used on the browser side to indicate when a
        download has been user initiated.

        * public/WebURLRequest.h:
        * src/WebURLRequest.cpp:
        (WebKit::WebURLRequest::hasUserGesture):
        (WebKit::WebURLRequest::setHasUserGesture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Chris Rogers <crogers@google.com>
crogers@google.com [Tue, 9 Nov 2010 00:48:16 +0000 (00:48 +0000)]
2010-11-08  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Remove obsolete PASSTHROUGH and MATRIXMIX panner mode
        https://bugs.webkit.org/show_bug.cgi?id=49087

        No new tests since audio API is not yet implemented.

        * platform/audio/Panner.cpp:
        (WebCore::Panner::create):
        * platform/audio/Panner.h:
        * webaudio/AudioPannerNode.h:
        * webaudio/AudioPannerNode.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPart of https://bugs.webkit.org/show_bug.cgi?id=49222
beidson@apple.com [Tue, 9 Nov 2010 00:42:39 +0000 (00:42 +0000)]
Part of https://bugs.webkit.org/show_bug.cgi?id=49222
Rename "WebContextMenuItem" to "WebContextMenuItemData"

Reviewed by Anders Carlsson.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:

* Shared/WebContextMenuItem.cpp: Removed.
* Shared/WebContextMenuItem.h: Removed.
* Shared/WebContextMenuItemData.cpp: Copied from Shared/WebContextMenuItem.cpp.
(WebKit::WebContextMenuItemData::WebContextMenuItemData):
(WebKit::WebContextMenuItemData::encode):
(WebKit::WebContextMenuItemData::decode):
(WebKit::kitItems):
* Shared/WebContextMenuItemData.h: Copied from Shared/WebContextMenuItem.h.
(WebKit::WebContextMenuItemData::submenu):

* UIProcess/WebContextMenuProxy.h:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::contextMenuItemSelected):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

* UIProcess/mac/WebContextMenuProxyMac.h:
* UIProcess/mac/WebContextMenuProxyMac.mm:
(-[WebMenuTarget forwardContextMenuAction:]):
(WebKit::WebContextMenuProxyMac::contextMenuItemSelected):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):

* UIProcess/qt/WebContextMenuProxyQt.cpp:
(WebKit::WebContextMenuProxyQt::showContextMenu):
* UIProcess/qt/WebContextMenuProxyQt.h:

* UIProcess/win/WebContextMenuProxyWin.cpp:
(WebKit::WebContextMenuProxyWin::showContextMenu):
* UIProcess/win/WebContextMenuProxyWin.h:

* WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::itemSelected):
* WebProcess/WebPage/WebContextMenu.h:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didSelectItemFromActiveContextMenu):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Tue, 9 Nov 2010 00:23:47 +0000 (00:23 +0000)]
2010-11-08  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Merge EditorWinCE.cpp into EditorWin.cpp
        https://bugs.webkit.org/show_bug.cgi?id=49095

        * platform/win/EditorWin.cpp:
        (WebCore::Editor::newGeneralClipboard):
        * platform/wince/EditorWinCE.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFind in Page: scrolling the page with the scrollbar while overlay is up dismisses...
andersca@apple.com [Tue, 9 Nov 2010 00:08:53 +0000 (00:08 +0000)]
Find in Page: scrolling the page with the scrollbar while overlay is up dismisses the overlay
https://bugs.webkit.org/show_bug.cgi?id=49219
<rdar://problem/8569550>

Reviewed by John Sullivan and Dan Bernstein.

* WebProcess/WebPage/FindPageOverlay.cpp:
(WebKit::FindPageOverlay::bounds):
Return the bounds of the find page overlay, excluding any scrollbars.

(WebKit::FindPageOverlay::drawRect):
Call bounds.

(WebKit::FindPageOverlay::mouseEvent):
Only dismiss the find UI if the mouse down event happens inside the overlay bounds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=49217
hyatt@apple.com [Mon, 8 Nov 2010 23:59:58 +0000 (23:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49217

Reviewed by Simon Fraser.

Fix coordinate space mismatch in RenderReplaced and make sure RenderText retains its old behavior of
preferring later lines when there is overlap.

WebCore:

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::positionForPoint):
* rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):

LayoutTests:

* fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt:
* fast/dom/Document/CaretRangeFromPoint/replace-element.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd the ability to send messages to DownloadProxy objects
andersca@apple.com [Mon, 8 Nov 2010 23:52:56 +0000 (23:52 +0000)]
Add the ability to send messages to DownloadProxy objects
https://bugs.webkit.org/show_bug.cgi?id=49213

Reviewed by Adam Roben.

* DerivedSources.make:
* DerivedSources.pro:
Add Download.messages.in.

* Platform/CoreIPC/MessageID.h:
Add MessageClassDownloadProxy message class.

* Platform/CoreIPC/MessageSender.h:
Include Connection.h directly since it's required.

* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didBegin):
(WebKit::DownloadProxy::didCreateDestination):
(WebKit::DownloadProxy::didFinish):
Add stubs.

* UIProcess/Downloads/DownloadProxy.messages.in: Added.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::didReceiveMessage):
Handle DownloadProxy messages.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
Hand DownloadProxy messages off to the context.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
Add new files.

* WebProcess/Downloads/Download.cpp:
(WebKit::Download::didBegin):
(WebKit::Download::didReceiveData):
(WebKit::Download::didCreateDestination):
(WebKit::Download::didFinish):
Send messages.

* WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate download:didCreateDestination:]):
Call Download::didCreateDestination.

* win/WebKit2.vcproj:
Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 8 Nov 2010 23:36:07 +0000 (23:36 +0000)]
2010-11-08  Dirk Pranke <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py.
        It turns out that NRWT can't use the code in scm.find_checkout_root()
        because the Chromium bots don't do full checkouts of the WebKit
        tree; they only check out subdirectories like WebKitTools/Scripts.
        Until we can figure out a better approach for this, I've
        restored the base_dir-detecting code from NRWT, which works in
        any directory tree, scm or no.

        This also restores the files modified in r71475 and r71474.

        https://bugs.webkit.org/show_bug.cgi?id=49151

        * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
        * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build bustage.
hyatt@apple.com [Mon, 8 Nov 2010 23:07:42 +0000 (23:07 +0000)]
Fix build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Steve Block <steveblock@google.com>
steveblock@google.com [Mon, 8 Nov 2010 22:52:23 +0000 (22:52 +0000)]
2010-11-08  Steve Block  <steveblock@google.com>

        Reviewed by David Levin.

        Building for Android generates several compiler warnings
        https://bugs.webkit.org/show_bug.cgi?id=49175

        Fixes these warnings, most of which are trivial.
        - PREFIX_FOR_WEBCORE was previously required for STL's algorithm, but is no
          longer. See
          http://android.git.kernel.org/?p=platform/external/webkit.git;a=commit;h=a47ab5294213cca2741f453b450b02666e08cac8
        - The definition of EXPORT is required only for the JNI entry point in
          WebKit/android, so does not need to be in WebCorePrefix.h

        No new tests, fixes compile warnings only.

        * WebCorePrefix.h:
        * bridge/jni/jsc/JNIUtilityPrivate.cpp:
        (JSC::Bindings::convertValueToJValue):
        * platform/android/FileSystemAndroid.cpp:
        (WebCore::listDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed bot fix.
noam.rosenthal@nokia.com [Mon, 8 Nov 2010 22:52:19 +0000 (22:52 +0000)]
Unreviewed bot fix.

Removed a test that was added without results. Will add again later.

* compositing/layer-creation/many-layers.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8119781> Crash zooming into Word document at office.live.com
mitz@apple.com [Mon, 8 Nov 2010 22:48:57 +0000 (22:48 +0000)]
<rdar://problem/8119781> Crash zooming into Word document at office.live.com
https://bugs.webkit.org/show_bug.cgi?id=49203

Reviewed by Darin Adler.

WebCore:

Test: fast/css/zoom-change-triggering-layout.html

RenderBox::styleDidChange() was calling scrollLeft() and scrollTop(), whose RenderTextControlSingleLine
overrides can trigger layout.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange): Use the layer directly for updating the scroll offsets when
the zoom factor changes.

LayoutTests:

* fast/css/zoom-change-triggering-layout-expected.txt: Added.
* fast/css/zoom-change-triggering-layout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rolling out r71567.
ossy@webkit.org [Mon, 8 Nov 2010 22:43:45 +0000 (22:43 +0000)]
Unreviewed rolling out r71567.

r71567 was incorrect, because fast/js/navigator-mimeTypes-length.html contains relative paths to js files.

* fast/js/navigator-mimeTypes-length-expected.txt: Copied from LayoutTests/plugins/navigator-mimeTypes-length-expected.txt.
* fast/js/navigator-mimeTypes-length.html: Copied from LayoutTests/plugins/navigator-mimeTypes-length.html.
* plugins/navigator-mimeTypes-length-expected.txt: Removed.
* plugins/navigator-mimeTypes-length.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd DownloadProxy object
andersca@apple.com [Mon, 8 Nov 2010 22:39:07 +0000 (22:39 +0000)]
Add DownloadProxy object
https://bugs.webkit.org/show_bug.cgi?id=49211

Reviewed by Adam Roben.

DownloadProxy will be the implementation of the forthcoming WKDownloadRef object.

* Shared/APIObject.h:
Add TypeDownload.

* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::generateDownloadID):
Generate a unique download ID.

(WebKit::DownloadProxy::invalidate):
Null out the web context.

* UIProcess/Downloads/DownloadProxy.h:
(WebKit::WebContext::processDidClose):
Invalidate all downloads.

(WebKit::WebContext::createDownloadProxy):
Create a WebDownload object.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
Call createDownloadProxy instead.

* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add new files.

* win/WebKit2Common.vsprops:
Add new include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Mon, 8 Nov 2010 22:28:03 +0000 (22:28 +0000)]
2010-11-08  Stephen White  <senorblanco@chromium.org>

        Unreviewed; test expectations update.

        Add a test missing results to chromium-gpu test expectations.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=48587
hyatt@apple.com [Mon, 8 Nov 2010 22:21:35 +0000 (22:21 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=48587

Reviewed by Simon Fraser.

Make Ruby work with vertical text.  Ruby already nearly does work.  The only big issue I found was with
flipped lines writing modes.  Make sure to mutate the writing-mode of the RenderRubyRun to ensure that
the ruby text is on the correct side of the ruby base.

Added fast/blockflow tests of the various writing modes.

WebCore:

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::staticCreateRubyRun):

LayoutTests:

* fast/blockflow/japanese-ruby-horizontal-bt.html: Added.
* fast/blockflow/japanese-ruby-vertical-lr.html: Added.
* fast/blockflow/japanese-ruby-vertical-rl.html: Added.
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
* platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
* platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
* platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 8 Nov 2010 22:19:20 +0000 (22:19 +0000)]
2010-11-08  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        webkit-patch failure-reason explodes if a build is missing
        https://bugs.webkit.org/show_bug.cgi?id=49195

        This is likely a recent regression.  Adding a unit test for this case.

        * Scripts/webkitpy/common/net/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 8 Nov 2010 22:18:05 +0000 (22:18 +0000)]
2010-11-08  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Restore normal meaning of double-click on patch review page?
        https://bugs.webkit.org/show_bug.cgi?id=47641

        After this patch, you need to click on the line numbers to add a
        comment.

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build correction after @70369/@70846.
bfulgham@webkit.org [Mon, 8 Nov 2010 22:10:51 +0000 (22:10 +0000)]
Unreviewed build correction after @70369/@70846.

Please use PLATFORM(CG) to define CG-specific code, not
PLATFORM(CF).

* platform/image-decoders/ImageDecoder.cpp:
* platform/image-decoders/ImageDecoder.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 8 Nov 2010 21:52:40 +0000 (21:52 +0000)]
2010-11-08  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        Input element with inner spin button set to display:none causes crash
        https://bugs.webkit.org/show_bug.cgi?id=49121

        Adds a test for dispatching mouse events at an <input type="number"> with
        the inner spin button set to display:none does not crash.

        * fast/forms/input-number-spinbutton-crash-expected.txt: Added.
        * fast/forms/input-number-spinbutton-crash.html: Added.
2010-11-08  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        Input element with inner spin button set to display:none causes crash
        https://bugs.webkit.org/show_bug.cgi?id=49121

        Null check the inner spin button's renderer before dereferencing it.

        Test: fast/forms/input-number-spinbutton-crash.html

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::forwardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 8 Nov 2010 21:41:28 +0000 (21:41 +0000)]
2010-11-08  Tony Chang  <tony@chromium.org>

        Unreviewed.  Moving a plugin test into the plugins directory.

        * plugins/navigator-mimeTypes-length-expected.txt: Renamed from LayoutTests/fast/js/navigator-mimeTypes-length-expected.txt.
        * plugins/navigator-mimeTypes-length.html: Renamed from LayoutTests/fast/js/navigator-mimeTypes-length.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Mon, 8 Nov 2010 21:35:58 +0000 (21:35 +0000)]
2010-11-08  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix Unicode explicit bidi control characters are removed in editing operations,
        such as insert/copy/cut/paste.
        https://bugs.webkit.org/show_bug.cgi?id=25321

        Unicode explicit bidi control characters were excluded in BidiRun and
        consequently from InlineTextBoxes due to their effect on rendering complex
        text with ATSUI.
        The fix is including those characters in BidiRun and remove them from
        ComplexTextRun with ATSUI.

        Test: editing/inserting/insert-paste-bidi-control.html
               fast/text/atsui-bidi-control.html

        * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
        (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
        * platform/text/BidiResolver.h:
        (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel):
        (WebCore::::lowerExplicitEmbeddingLevel):
        (WebCore::::raiseExplicitEmbeddingLevel):
        (WebCore::::createBidiRunsForLine):
2010-11-08  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix Unicode explicit bidi control characters are removed in editing operations,
        such as insert/copy/cut/paste.
        https://bugs.webkit.org/show_bug.cgi?id=25321

        Unicode explicit bidi control characters were excluded in BidiRun and
        consequently from InlineTextBoxes due to their effect on rendering complex
        text with ATSUI.
        The fix is including those characters in BidiRun and remove them from
        ComplexTextRun with ATSUI.

        * editing/inserting/insert-paste-bidi-control-expected.txt: Added.
        * editing/inserting/insert-paste-bidi-control.html: Added.
        * editing/selection/extend-selection-expected.txt:
        * editing/selection/home-end-expected.txt:
        * fast/text/atsui-bidi-control-expected.txt: Added.
        * fast/text/atsui-bidi-control.html: Added.
        * platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
        * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
        * platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
        * platform/mac/fast/text/international/bidi-explicit-embedding-expected.txt:
        * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
        * platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
        * platform/mac/fast/text/international/bidi-override-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 8 Nov 2010 21:21:01 +0000 (21:21 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=49201
        Crash when closing a page

        Handle null frame by passing a 0 frame id (normal ones start from 1).

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::focusedFrameChanged):
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::focusedFrameChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 8 Nov 2010 21:20:53 +0000 (21:20 +0000)]
2010-11-08  Nate Chapin  <japhet@chromium.org>

        Unreviewed, build fix.

        Clumsy typo in r71562.

        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=49126
hyatt@apple.com [Mon, 8 Nov 2010 21:12:00 +0000 (21:12 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49126

Reviewed by Dan Bernstein.

RenderBlock::positionForPoint is not writing-mode aware.  Patch the function to examine lines in the correct
writing-mode direction.  Patched and renamed a number of helpers used by positionForPoint.

Fixed a bug with RenderReplaced's positionForPoint. There was a coordinate space mismatch between what the
function expected (local coordinates) and what was passed in (containing block coords), which meant the function didn't even work.

Fixed a bug with the propagation of selection state on RenderReplaced to its containing block.  The bit double propagated
because both the base class function and the derived class function did the propagation, and the setter function did not
do the right thing if this happened.

Patched the localSelectionRect method on RenderReplaced so that selection draws in the right place in all writing modes.

Added new tests of positionForPoint and replaced elements in fast/blockflow.

WebCore:

* editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
* platform/graphics/IntPoint.h:
(WebCore::IntPoint::transpose):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::paint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::positionForPoint):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::positionForPoint):
(WebCore::RenderReplaced::localSelectionRect):
(WebCore::RenderReplaced::setSelectionState):
* rendering/RenderReplaced.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition):
* rendering/RootInlineBox.h:

LayoutTests:

* fast/blockflow/horizontal-bt-replaced-selection.html: Added.
* fast/blockflow/vertical-lr-replaced-selection.html: Added.
* fast/blockflow/vertical-rl-replaced-selection.html: Added.
* platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
* platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
* platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
* platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
* platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
* platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
* platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
* platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
* platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 8 Nov 2010 21:01:53 +0000 (21:01 +0000)]
2010-11-08  Nate Chapin  <japhet@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Move connection-per-host counting and request prioritization out
        of Loader and down to the ResourceLoader level.

        https://bugs.webkit.org/show_bug.cgi?id=27165

        Refactor only, so no new tests.

        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::suspendPostAttachCallbacks):
        (WebCore::ContainerNode::resumePostAttachCallbacks):
        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::loadRequest):
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::loadNow):
        * loader/NetscapePlugInStreamLoader.cpp:
        (WebCore::NetscapePlugInStreamLoader::create):
        * loader/NetscapePlugInStreamLoader.h:
        * loader/ResourceLoadScheduler.cpp: Added.
        (WebCore::ResourceLoadScheduler::hostForURL):
        (WebCore::resourceLoadScheduler): Returns the single ResourceLoadScheduler instance
        (WebCore::ResourceLoadScheduler::ResourceLoadScheduler):
        (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad):
        (WebCore::ResourceLoadScheduler::schedulePluginStreamLoad):
        (WebCore::ResourceLoadScheduler::addMainResourceLoad):
        (WebCore::ResourceLoadScheduler::scheduleLoad):
        (WebCore::ResourceLoadScheduler::remove):
        (WebCore::ResourceLoadScheduler::crossOriginRedirectReceived):
        (WebCore::ResourceLoadScheduler::servePendingRequests):
        (WebCore::ResourceLoadScheduler::suspendPendingRequests):
        (WebCore::ResourceLoadScheduler::resumePendingRequests):
        (WebCore::ResourceLoadScheduler::scheduleServePendingRequests):
        (WebCore::ResourceLoadScheduler::requestTimerFired):
        (WebCore::ResourceLoadScheduler::assertLoaderBeingCounted):
        (WebCore::ResourceLoadScheduler::HostInformation::assertLoaderBeingCounted):
        (WebCore::ResourceLoadScheduler::HostInformation::HostInformation):
        (WebCore::ResourceLoadScheduler::HostInformation::~HostInformation):
        (WebCore::ResourceLoadScheduler::HostInformation::schedule):
        (WebCore::ResourceLoadScheduler::HostInformation::addLoadInProgress):
        (WebCore::ResourceLoadScheduler::HostInformation::remove):
        (WebCore::ResourceLoadScheduler::HostInformation::hasRequests):
        * loader/ResourceLoadScheduler.h: Added.
        (WebCore::ResourceLoadScheduler::HostInformation::name):
        (WebCore::ResourceLoadScheduler::HostInformation::limitRequests):
        (WebCore::ResourceLoadScheduler::HostInformation::requestsPending):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::releaseResources): Remove this from ResourceLoadScheduler's counting.
        (WebCore::ResourceLoader::load):
        (WebCore::ResourceLoader::start): Create the ResourceHandle, called by ResourceLoadScheduler.
        (WebCore::ResourceLoader::willSendRequest): Ensure ResourceLoadScheduler counts redirects
            correctly.
        * loader/ResourceLoader.h:
        (WebCore::ResourceLoader::url):
        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::startLoading):
        * loader/loader.cpp: Move scheduling to ResourceLoadScheduler, remove Host subclass
            and make Loader the SubresourceLoaderClient instead.
        (WebCore::determinePriority):
        (WebCore::Loader::load): Schedule the creation of the ResourceHandle, rather than
            doing it immediately.
        (WebCore::Loader::cancelRequests):
        (WebCore::Loader::didFinishLoading):
        (WebCore::Loader::didFail):
        (WebCore::Loader::didReceiveResponse):
        (WebCore::Loader::didReceiveData):
        (WebCore::Loader::didReceiveCachedMetadata):
        * loader/loader.h:
        * page/EventSource.cpp:
        (WebCore::EventSource::connect):
        (WebCore::EventSource::endRequest):
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::start):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::XMLHttpRequest):
        (WebCore::XMLHttpRequest::~XMLHttpRequest):
        (WebCore::XMLHttpRequest::createRequest):
        (WebCore::XMLHttpRequest::didFail):
        (WebCore::XMLHttpRequest::didFinishLoading):
        * xml/XMLHttpRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Rafael Antognolli <antognolli@profusion.mobi>
leandro@webkit.org [Mon, 8 Nov 2010 21:00:16 +0000 (21:00 +0000)]
2010-11-08  Rafael Antognolli  <antognolli@profusion.mobi>

        Reviewed by Antonio Gomes.

        [EFL] Change the usage of eina_iterator_next due to latest EFL changes.
        https://bugs.webkit.org/show_bug.cgi?id=49082

        A change on how the iterator for a tiler is used in EFL needs to be
        reflected in WebKit-EFL. The iterator now receives a pointer to an
        Eina_Rectangle and makes it point to its internal structure. The old
        usage was to receive a reference to a pre-allocated Eina_Rectangle.

        * ewk/ewk_view_single.c:
        (_ewk_view_single_smart_repaints_process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIgnore the system scrollbar setting.
mitz@apple.com [Mon, 8 Nov 2010 20:41:18 +0000 (20:41 +0000)]
Ignore the system scrollbar setting.

Reviewed by Darin Adler.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues): Set the scrollbar default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNPClass::construct and NPClass::invokeDefault never called with out-of-process plug...
andersca@apple.com [Mon, 8 Nov 2010 20:32:54 +0000 (20:32 +0000)]
NPClass::construct and NPClass::invokeDefault never called with out-of-process plug-ins in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49198

Reviewed by Adam Roben.

WebKit2:

* Shared/Plugins/NPObjectMessageReceiver.cpp:
(WebKit::NPObjectMessageReceiver::invokeDefault):
Call NPClass::invokeDefault.

(WebKit::NPObjectMessageReceiver::construct):
Call NPClass::construct

* Shared/Plugins/NPObjectMessageReceiver.messages.in:
Add InvokeDefault and Construct messages.

* Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::invokeDefault):
Send the InvokeDefault message.

(WebKit::NPObjectProxy::construct):
Send the Construct message.

(WebKit::NPObjectProxy::NP_InvokeDefault):
Call NPObjectProxy::invokeDefault.

(WebKit::NPObjectProxy::NP_Construct):
Call NPObjectProxy::construct.

LayoutTests:

Remove now passing tests.

* platform/mac-snowleopard/Skipped:
* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 8 Nov 2010 20:29:08 +0000 (20:29 +0000)]
2010-11-08  Tony Chang  <tony@chromium.org>

        Unreviewed, updating plugin expectations.

        * platform/chromium-mac/plugins/netscape-destroy-plugin-script-objects-expected.txt: Removed.
        * platform/chromium-win/plugins/netscape-destroy-plugin-script-objects-expected.txt: Removed.
        * platform/mac-snowleopard/Skipped: Only failing on SL.
        * platform/mac/Skipped:
        * platform/qt/plugins/nested-plugin-objects-expected.txt: Removed.
        * plugins/nested-plugin-objects-expected.txt: Made the main version
              have a console error line of 0 since it seems to be a chromium
              specific difference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWe should add a build step to comment out or remove the lines unsetting TEMP and...
jberlin@webkit.org [Mon, 8 Nov 2010 20:28:19 +0000 (20:28 +0000)]
We should add a build step to comment out or remove the lines unsetting TEMP and TMP in the
.bashrc file.
https://bugs.webkit.org/show_bug.cgi?id=49189

Reviewed by Adam Roben.

* building/tools.html:
Add a line recommending bash shell users to comment out or remove those lines, with an
explanation as to why.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 8 Nov 2010 20:15:38 +0000 (20:15 +0000)]
2010-11-08  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Remove the remaining editing-style functions from ApplyStyleCommand
        https://bugs.webkit.org/show_bug.cgi?id=49155

        Replaced removeNonEditingProperties, editingStyleAtPosition, prepareEditingStyleToApplyAt,
        and removeStylesAddedByNode in ApplyStyleCommand.cpp by removeNonEditingProperties, EditingStyle::create,
        prepareToApplyAt, and removeStyleAddedByNode in EditingStyle.cpp.

        Also removed unnecessary header includes from various cpp files.

        No tests are added since this is a cleanup.

        * editing/ApplyStyleCommand.cpp: Removed removeNonEditingProperties, editingStyleAtPosition,
        prepareEditingStyleToApplyAt, and removeStylesAddedByNode.
        * editing/ApplyStyleCommand.h: Ditto.
        * editing/DeleteSelectionCommand.cpp: Removed removeEnclosingAnchorStyle.
        (WebCore::DeleteSelectionCommand::saveTypingStyleState): Calls removeStylesAddedByNode instead.
        * editing/EditingStyle.cpp:
        (WebCore::copyEditingProperties): Moved and renamed ApplyStyleCommand::removeNonEditingProperties.
        (WebCore::editingStyleFromComputedStyle): Calls copyEditingProperties. Changed the argument to PassRefPtr
        as supposed to a raw pointer for convenience.
        (WebCore::EditingStyle::init): Calls editingStyleFromComputedStyle.
        (WebCore::EditingStyle::removeStyleAddedByNode): Added.
        (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): Added.
        (WebCore::EditingStyle::removeNonEditingProperties): Added.
        (WebCore::editingStyleIncludingTypingStyle): Calls copyEditingProperties.
        * editing/EditingStyle.h: Added prototypes.
        * editing/Editor.cpp:
        (WebCore::Editor::selectionComputedStyle): Uses EditingStyle.
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Ditto.
        (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto.
        * editing/InsertParagraphSeparatorCommand.h:
        * editing/RemoveFormatCommand.cpp:
        (WebCore::RemoveFormatCommand::doApply): Ditto.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::handleStyleSpansBeforeInsertion): Ditto.
        (WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.
        (WebCore::ReplaceSelectionCommand::doApply): Ditto.
        (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
        * editing/ReplaceSelectionCommand.h:
        * editing/markup.cpp: Removed removeEnclosingMailBlockquoteStyle and removeDefaultStyles.
        (WebCore::createMarkup): Uses EditingStyle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updating Chromium expectations.
dumi@chromium.org [Mon, 8 Nov 2010 20:02:56 +0000 (20:02 +0000)]
Unreviewed, updating Chromium expectations.

* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
* platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
* platform/chromium-mac/svg/custom/polyline-points-crash-expected.txt: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
* platform/chromium-win/svg/custom/polyline-points-crash-expected.txt: Removed.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
* platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPlug-in views should not assume that plugins are RenderEmbeddedObjects
andersca@apple.com [Mon, 8 Nov 2010 19:58:29 +0000 (19:58 +0000)]
Plug-in views should not assume that plugins are RenderEmbeddedObjects
https://bugs.webkit.org/show_bug.cgi?id=49196
<rdar://problem/8638467>

Reviewed by Dan Bernstein.

WebKit/mac:

* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView pluginHostDied]):

WebKit2:

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginProcessCrashed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 8 Nov 2010 19:47:51 +0000 (19:47 +0000)]
2010-11-08  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Media objects in nested iframes showing above everything else in TinyMCE
        https://bugs.webkit.org/show_bug.cgi?id=44877

        Tests: compositing/iframes/become-composited-nested-iframes.html
               compositing/iframes/overlapped-nested-iframes.html

        The overlap testing logic that connects compositing across iframe boundaries
        needed to be educated about nestd iframes, for platforms (i.e. Mac) where iframes
        are allowed to be independently composited.

        Also fix a bug that could cause iframes (and possibly other elements) that share
        style to fail to become composited.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::canShareStyleWithElement): Disable style sharing for elements
        that force synethetic style updates in order to gain RenderLayers, so they can become
        composited. This is tested by become-composited-nested-iframes.html, though it is very
        timing-dependent.

        * page/FrameView.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::hasCompositedContentIncludingDescendants): New method that
        is a "deep" version of hasCompositedContent() on platforms where that is necessary to ask.

        (WebCore::FrameView::hasCompositingAncestor): New method.
        (WebCore::FrameView::setIsOverlapped): If we can have independently composited iframes,
        we need to force all descendant iframes to update so that compositing gets hooked up across
        nested iframes.

        (WebCore::FrameView::isOverlappedIncludingAncestors): New method, only called on platforms
        where allowsIndependentlyCompositedIFrames() is true.

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::allowsIndependentlyCompositedIFrames): Utility method that
        returns true if an iframe can be a compositing root.

        (WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Make use of
        allowsIndependentlyCompositedIFrames().

        (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange): We need to notify all
        descendant frames, not just children.

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setStyle): Add assert to ensure that we don't do style sharing
        for elements that play tricks with synthetic style changes.

        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint): Run overlap testing if a frame has any composited
        descendants.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 8 Nov 2010 19:29:35 +0000 (19:29 +0000)]
2010-11-08  Tony Chang  <tony@chromium.org>

        Unreviewed, adding qt results for new test (only console line number
        is different).  Test failing for unknown reasons on mac-- will fix
        offline.

        * platform/mac/Skipped:
        * platform/qt/plugins/nested-plugin-objects-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNPN_Evaluate doesn't work with out-of-process plugins in WebKit2
andersca@apple.com [Mon, 8 Nov 2010 19:26:56 +0000 (19:26 +0000)]
NPN_Evaluate doesn't work with out-of-process plugins in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49193

Reviewed by Adam Roben.

WebKit2:

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::evaluate):
Send an Evaluate message.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::evaluate):
Call Evaluate on the plug-in proxy.

* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginProxy.messages.in:
Add Evaluate message.

LayoutTests:

Remove now passing tests.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolling back r71506 & r71507, broke inspector/debugger-pause-on-* tests.
caseq@chromium.org [Mon, 8 Nov 2010 19:22:13 +0000 (19:22 +0000)]
Unreviewed. Rolling back r71506 & r71507, broke inspector/debugger-pause-on-* tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Mon, 8 Nov 2010 19:18:27 +0000 (19:18 +0000)]
2010-11-08  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Unreviewed. Build fix after r71496.

        * CMakeLists.txt: Add WebCore/loader/cache directory to WebKit's
        include directories list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Windows build fix.
ap@apple.com [Mon, 8 Nov 2010 19:15:47 +0000 (19:15 +0000)]
    Windows build fix.

        * WebCoreSupport/WebChromeClient.h: Added namespace prefix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake webkitpy.common.system.executive_unittest pass when running under Win32 Python
aroben@apple.com [Mon, 8 Nov 2010 19:12:44 +0000 (19:12 +0000)]
Make webkitpy.common.system.executive_unittest pass when running under Win32 Python

Fixes <http://webkit.org/b/49033>.

Reviewed by Dave Levin and Eric Seidel.

* Scripts/webkitpy/common/system/executive.py:
(Executive._run_command_with_teed_output): Pass the arguments through
encode_argument_if_needed rather than using Cygwin-specific code here.
(Executive.run_and_throw_if_fail): Use child_process_encoding to decode
the output.
(Executive.run_command): Use encode_argument_if_needed to encode the
arguments and child_process_encoding to decode the output.
(Executive._child_process_encoding): Returns the encoding that should be
used when communicating with child processes. On Windows we use mbcs,
which maps to the current code page. On all other platforms we use
UTF-8.
(Executive._should_encode_child_process_arguments): Returns True if
arguments to child processes need to be encoded. This is currently
only needed on Cygwin and Win32 Python 2.x.
(Executive._encode_argument_if_needed): Encode the argument using
child_process_encoding if we need to encode arguments to child
processes on this platform.

* Scripts/webkitpy/common/system/executive_unittest.py:
(never_ending_command): Added. Returns arguments to run a command that
will not quit until we kill it. On Windows we use wmic, on other
platforms we use yes.
(ExecutiveTest.test_run_command_with_unicode): Changed to expect the
mbcs encoding to be used and for output from the child processes to
have been roundtripped through encode/decode on Win32 Python. When
UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
it's possible that some characters will not be able to be converted
and will be replaced by question marks; the round-tripping allows us
to expect this result.

(ExecutiveTest.test_kill_process):
(ExecutiveTest.test_kill_all):
Use never_ending_command instead of invoking "yes" directly. Expect an
exit code of 1 when using Win32 Python, as that's what seems to happen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrectly convert NPObjectProxy to NPVariantData
andersca@apple.com [Mon, 8 Nov 2010 19:05:44 +0000 (19:05 +0000)]
Correctly convert NPObjectProxy to NPVariantData
https://bugs.webkit.org/show_bug.cgi?id=49190

Reviewed by John Sullivan.

WebKit2:

* Shared/Plugins/NPObjectMessageReceiver.h:
(WebKit::NPObjectMessageReceiver::npObject):
Add NPObject getter.

* Shared/Plugins/NPObjectProxy.h:
(WebKit::NPObjectProxy::npObjectID):
Add NPObjectID getter.

* Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
Handle the case where the NPObject is an NPObjectProxy.

(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
Handle NPVariantData::LocalNPObjectID.

* Shared/Plugins/NPVariantData.cpp:
(WebKit::NPVariantData::makeRemoteNPObjectID):
* Shared/Plugins/NPVariantData.h:
New function for creating an NPVariantData that contains a remote NPObject ID.

LayoutTests:

Remove now passing test.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll out r71532
aroben@apple.com [Mon, 8 Nov 2010 19:04:40 +0000 (19:04 +0000)]
Roll out r71532

It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
.bashrc unsets %TEMP%, which broke copy-tools.cmd.

JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/copy-tools.cmd: Removed.
* JavaScriptCore.vcproj/JavaScriptCore/show-alert.js: Removed.

WebKitTools:

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* fast/images/image-map-multiple-xhtml.xhtml: Fixed this test to check that
darin@apple.com [Mon, 8 Nov 2010 19:00:56 +0000 (19:00 +0000)]
* fast/images/image-map-multiple-xhtml.xhtml: Fixed this test to check that
map name lookup is case sensitive.

Rubber stamped by Alexey Proskuryakov.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 8 Nov 2010 18:50:16 +0000 (18:50 +0000)]
2010-11-08  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Incorrect image map used when multiple maps have the same name
        https://bugs.webkit.org/show_bug.cgi?id=49086

        Test: fast/images/image-map-multiple.html

        Factored out the code used to look up elements by id and reused it
        to look up maps by name. It handles multiple elements efficiently.

        * dom/Document.cpp:
        (WebCore::Document::DocumentOrderedMap::clear): Added.
        (WebCore::Document::DocumentOrderedMap::add): Added. Has code that
        was formerly in addElementById.
        (WebCore::Document::DocumentOrderedMap::remove): Added. Has code that
        was formerly in removeElementById.
        (WebCore::Document::DocumentOrderedMap::get): Added. Has code that
        was formerly in getElementById.
        (WebCore::keyMatchesId): Added.
        (WebCore::Document::getElementById): Use DocumentOrderedMap::get.
        (WebCore::Document::addElementById): Use DocumentOrderedMap::add.
        (WebCore::Document::removeElementById): Use DocumentOrderedMap::remove.
        (WebCore::Document::addImageMap): Use DocumentOrderedMap::add.
        (WebCore::Document::removeImageMap): Use DocumentOrderedMap::remove.
        (WebCore::keyMatchesMapName): Added.
        (WebCore::keyMatchesLowercasedMapName): Added.
        (WebCore::Document::getImageMap): Use DocumentOrderedMap::get.

        * dom/Document.h: Added DocumentOrderedMap class, used inside the
        Document class. Changed m_imageMapsByName to be a DocumentOrderedMap.
        Changed m_elementsById to be a DocumentOrderedMap. Eliminated
        m_duplicateIds, since DocumentOrderedMap now has that internally.
2010-11-08  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Incorrect image map used when multiple maps have the same name
        https://bugs.webkit.org/show_bug.cgi?id=49086

        * fast/images/image-map-multiple-expected.txt: Added.
        * fast/images/image-map-multiple-xhtml-expected.txt: Added.
        * fast/images/image-map-multiple-xhtml.xhtml: Added.
        * fast/images/image-map-multiple.html: Added.

        * fast/images/zoomed-img-size-expected.txt: Removed property svn:executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 8 Nov 2010 18:36:35 +0000 (18:36 +0000)]
2010-11-08  Alexander Pavlov  <apavlov@chromium.org>

        Unreviewed, build fix from commit r71530.

        * fast/css/background-norepeat-crash-expected.txt:
        * fast/css/background-norepeat-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 8 Nov 2010 18:23:55 +0000 (18:23 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=48685
        Notify UI process about focused frame

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
andersca@apple.com [Mon, 8 Nov 2010 18:19:03 +0000 (18:19 +0000)]
Build fix.

* MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove use of HIGetScaleFactor
andersca@apple.com [Mon, 8 Nov 2010 18:16:38 +0000 (18:16 +0000)]
Remove use of HIGetScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=49186
<rdar://problem/8618410>

Reviewed by Adam Roben.

Scale factors can vary on a display-by-display basis and it doesn't make sense
to compute scale factor event coordinates like this.

WebCore:

* plugins/mac/PluginViewMac.mm:
(WebCore::PluginView::globalMousePosForPlugin):

WebKit/mac:

* Plugins/WebNetscapePluginEventHandlerCarbon.mm:
(getCarbonEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Texmap] [Qt] Texture mapper initial implementation
noam.rosenthal@nokia.com [Mon, 8 Nov 2010 18:04:58 +0000 (18:04 +0000)]
[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

Reviewed by Kenneth Rohde Christiansen.

WebCore:

Make the necessary changes in TextureMapperNode in preparation of making it possible to paint it
from a different thread.
The main problematic part was the cache, which made it so that textures can become invalid and have to
be rerendered from content during paint. This is solved here by creating a pack/unpack function for
textures, which lets a texture archive its data away from video memory, or do whatever the platform
thinks is right for freeing memory without needing to re-render again from content (which cannot be
made thread safe).

After this change, TextureMapperNode moved to its own file, and has 2 entry points: paint and syncCompositingState.
The idea is that syncCompositingState has to be called in the UI thread, paint can be called from a different
thread, and they should block each other.

The new test tests the cache code-path, to show that the pack/unpack technique works for cases where it
kicks in.

Test: compositing/layer-creation/many-layers.html

* WebCore.pro:
* platform/graphics/opengl/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::drawTexture):
* platform/graphics/opengl/TextureMapperGL.h:
(WebCore::TextureMapperGL::create):
* platform/graphics/qt/TextureMapperQt.cpp:
(WebCore::BitmapTextureQt::pack):
(WebCore::BitmapTextureQt::unpack):
(WebCore::TextureMapper::create):
(WebCore::BitmapTextureQt::BitmapTextureQt):
* platform/graphics/qt/TextureMapperQt.h: Added.

WebKit/qt:

Reorganized the textureMapper to be a member of QWebFramePrivate, to help with making
TextureMapper thread-safe.

* Api/qwebframe.cpp:
(QWebFramePrivate::renderCompositedLayers):
* Api/qwebframe_p.h:
* WebCoreSupport/PageClientQt.cpp:
(WebCore::PlatformLayerProxyQt::setTextureMapper):
(WebCore::PlatformLayerProxyQt::textureMapper):
(WebCore::PlatformLayerProxyQWidget::PlatformLayerProxyQWidget):
(WebCore::PlatformLayerProxyQGraphicsObject::PlatformLayerProxyQGraphicsObject):

LayoutTests:

Added a test that includes several composited layers, containing pixel data that's larger
than 24MB, which is the default value for TextureMapper's cache. This tests the video memory
ceiling functionality of TextureMapper, as purging that cache would kick in whe running this test.

* compositing/layer-creation/many-layers.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 8 Nov 2010 17:56:42 +0000 (17:56 +0000)]
2010-11-08  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        run platform/chromium/plugins/nested-plugin-objects.html on all platforms
        https://bugs.webkit.org/show_bug.cgi?id=49094

        * plugins/nested-plugin-objects-expected.txt: Renamed from LayoutTests/platform/chromium/plugins/nested-plugin-objects-expected.txt.
        * plugins/nested-plugin-objects.html: Renamed from LayoutTests/platform/chromium/plugins/nested-plugin-objects.html.
2010-11-08  Tony Chang  <tony@chromium.org>

        Reviewed by Adam Barth.

        run platform/chromium/plugins/nested-plugin-objects.html on all platforms
        https://bugs.webkit.org/show_bug.cgi?id=49094

        This tests that objects created by plugins are proplery cleaned up.

        * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
        (testPassTestObject):
        (pluginInvoke):
        * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
        (testAllocate):
        (testDeallocate):
        (testGetProperty):
        (testConstruct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 8 Nov 2010 17:48:22 +0000 (17:48 +0000)]
2010-11-08  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Sam Weinig.

        Allow applets to participate in accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=49117
        <rdar://problem/8625819>

        Add RenderApplet to the list of renderers that can optionally get RenderLayers,
        and be composited for some reason.

        Not currently testable.

        * rendering/RenderApplet.h: Outdented the class declaration.

        * rendering/RenderApplet.cpp:
        (WebCore::RenderApplet::requiresLayer): Return true if the underlying widget
        has a platform layer.
        (WebCore::RenderApplet::allowsAcceleratedCompositing): Check the widget to see
        if it has a platform layer.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::shouldBeNormalFlowOnly): Reformat, and add isApplet().
        (WebCore::RenderLayer::isSelfPaintingLayer): Reformat, and add isApplet().
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Use 'renderer' local variable
        for efficiency. Now check for embedded objects and applets.
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::requiresCompositingForPlugin): Check for embedded objects and applets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 8 Nov 2010 17:30:41 +0000 (17:30 +0000)]
2010-11-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        >=webkitgtk-1.2.5: parallel build fails with libtool: link: cannot find the library `libwebkit-1.0.la' or unhandled argument `libwebkit-1.0.la'
        https://bugs.webkit.org/show_bug.cgi?id=49128

        r59042 introduced a C++-style comment in Platform.h, which is often
        included in C source files. Change it to a C-style comment.

        * wtf/Platform.h: Fix the C++-style comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 8 Nov 2010 17:24:10 +0000 (17:24 +0000)]
2010-11-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        * GNUmakefile.am: add missing files to fix distcheck.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Andrey Kosyakov <caseq@chromium.org>
inferno@chromium.org [Mon, 8 Nov 2010 17:17:52 +0000 (17:17 +0000)]
2010-11-08  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Only call WebInspector_syncDispatch if it's actually a function.
        https://bugs.webkit.org/show_bug.cgi?id=49180

        * src/WebDevToolsFrontendImpl.cpp:
        (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
        (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
        * src/WebDevToolsFrontendImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShow a message and cause the build to immediately fail when any .vsprops files are...
aroben@apple.com [Mon, 8 Nov 2010 17:14:38 +0000 (17:14 +0000)]
Show a message and cause the build to immediately fail when any .vsprops files are copied

When $WebKitLibrariesDir is set to a non-standard location, the
.vsprops files have to be copied from WebKitLibraries/win to
$WebKitLibrariesDir. When this happens, Visual Studio doesn't pick up
changes to the .vsprops files until the next time it opens the solution
file. Before this patch, the build would soldier on with the old
.vsprops files, leading to strange build failures. Now we detect that
the .vsprops files have been updated, display a message to the user
telling them what to do, and make the build fail immediately.

Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
.vsprops files are updated

Reviewed by Steve Falkenburg.

JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
Moved code to copy the tools directory to the new copy-tools.cmd
script. Moved that after the command that writes the buildfailed file
so the build will be considered a failure if copy-tools.cmd fails.
Changed to write the project name into buildfailed like all our other
projects do, so those other projects will know that the failure was due
to this project.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj:
Added new scripts.

* JavaScriptCore.vcproj/JavaScriptCore/copy-tools.cmd: Added. Copies
the tools directory to $WebKitLibrariesDir. If any files were copied,
we display a message to the user and exit with error code 1 to cause
the build to fail. In non-interactive builds, we just print the message
to the build log. In interactive builds, we show the message in an
alert.

* JavaScriptCore.vcproj/JavaScriptCore/show-alert.js: Added. Uses
Windows Scripting Host to display a message in an alert.

WebKitTools:

Mark Windows builds triggered from Perl as being non-interactive

This affects whether some of our scripts will show alerts vs. printing
to the build log.

* Scripts/webkitdirs.pm:
(buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a sometimes-failing test to the Windows Skipped file
aroben@apple.com [Mon, 8 Nov 2010 17:02:29 +0000 (17:02 +0000)]
Add a sometimes-failing test to the Windows Skipped file

* platform/win/Skipped: Added
animations/stop-animation-on-suspend.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 8 Nov 2010 16:54:29 +0000 (16:54 +0000)]
2010-11-08  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by David Hyatt.

        getPropertyValue("background") causes crash
        https://bugs.webkit.org/show_bug.cgi?id=49055

        * fast/css/background-norepeat-crash-expected.txt: Added.
        * fast/css/background-norepeat-crash.html: Added.
2010-11-08  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by David Hyatt.

        getPropertyValue("background") causes crash
        https://bugs.webkit.org/show_bug.cgi?id=49055

        Test: fast/css/background-norepeat-crash.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 8 Nov 2010 16:48:08 +0000 (16:48 +0000)]
2010-11-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Andreas Kling.

        [GTK] Error page templates are not filled properly
        https://bugs.webkit.org/show_bug.cgi?id=49148

        Replace a call to makeString with String::format. This was mistakenly
        changed to makeString in an earlier commit.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidFailLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 8 Nov 2010 16:42:48 +0000 (16:42 +0000)]
2010-11-08  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Wrapped DOM bindings GObjects do not disconnect event listeners when they die
        https://bugs.webkit.org/show_bug.cgi?id=49136

        When GObjects are finalized and freed, disconnect their event listeners, so that
        WebCore does not try to fire signals on dead GObjects. We do this by holding a weak
        reference to the GObject in the signal listener. When the weak reference notification
        callback is executed, we disconnect the event listener.

        No new tests; this fix is proved by prevention of crashes in soon to be
        landed editing delegate signals, which are covered by the layout tests.

        * bindings/gobject/GObjectEventListener.cpp:
        (WebCore::GObjectEventListener::GObjectEventListener): Updated the constructor.
        (WebCore::GObjectEventListener::~GObjectEventListener): Disconnect the weak reference
        if the GObject is still alive.
        (WebCore::GObjectEventListener::gobjectDestroyed): When the GObject is destroyed,
        disconnect the appropriate event listener.
        (WebCore::GObjectEventListener::handleEvent): Changes to reflect use of CString
        instead of WebCore string.
        * bindings/gobject/GObjectEventListener.h:
        (WebCore::GObjectEventListener::addEventListener): Changed create to addEventListener,
        so that the connection and disconnection is an internal contract to the class.
        (WebCore::GObjectEventListener::gobjectDestroyedCallback): Added.
        * bindings/scripts/CodeGeneratorGObject.pm: Modified the code generate to use
        GObjectEventListener::addEventListener and no longer call addEventListener on
        its own.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake http locking default in NRWT.
ossy@webkit.org [Mon, 8 Nov 2010 16:27:55 +0000 (16:27 +0000)]
Make http locking default in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=48053

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-08
Reviewed by Ojan Vafai.

* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 8 Nov 2010 16:26:08 +0000 (16:26 +0000)]
2010-11-08  Martin Robinson  <mrobinson@igalia.com>

        Skip failing tests and rebaseline another test after r71512.

        * platform/gtk/Skipped: Update the skipped list.
        * platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
ossy@webkit.org [Mon, 8 Nov 2010 16:25:20 +0000 (16:25 +0000)]
2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>

        Reviewed by Csaba Osztrogonác.

        [NRWT] If the http lock fails we shouldn't do any locking
        https://bugs.webkit.org/show_bug.cgi?id=49164

        If something goes wrong with the locking, the test should keep going.

        * Scripts/webkitpy/layout_tests/port/http_lock.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 8 Nov 2010 15:50:27 +0000 (15:50 +0000)]
2010-11-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        Update version numbers for release.

        * configure.ac:

WebKit/gtk:

2010-11-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        * NEWS: update for release.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip plugins tests on Qt WebKit2 since we do
kbalazs@webkit.org [Mon, 8 Nov 2010 15:40:01 +0000 (15:40 +0000)]
Skip plugins tests on Qt WebKit2 since we do
not have plugin support yet.

Rubber-stamped by Csaba Osztrogonac.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Mon, 8 Nov 2010 15:30:28 +0000 (15:30 +0000)]
2010-11-08  Stephen White  <senorblanco@chromium.org>

        Unreviewed; test expectations update.

        Update chromium-gpu test_expectations after canvas/philip update, and
        other fixes.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows Release build fix after r71514
aroben@apple.com [Mon, 8 Nov 2010 15:19:20 +0000 (15:19 +0000)]
Windows Release build fix after r71514

The build was failing due to an alignment error. Strangely, depending
on the order of SVGStaticPropertyTearOff's members, the build will
either fail in Release (as it does before this change), or Debug (as it
did before r71514), but not both.

* svg/properties/SVGStaticPropertyTearOff.h:
(WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff): Copied
the #pragma pack trick from JSSVGPODTypeWrapper.h, which has similar
issues.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Update expectations.
ossy@webkit.org [Mon, 8 Nov 2010 15:09:47 +0000 (15:09 +0000)]
Unreviewed. Update expectations.

[Qt] DRT sideeffect revealed by r71518
https://bugs.webkit.org/show_bug.cgi?id=49174

The previous expected results were wrong, because they were modified by this sideeffect.
New results were generated by: WebKitTools/Scripts/run-webkit-tests --reset-results --singly TEST_NAME

* platform/qt/http/tests/navigation/error404-basic-expected.txt:
* platform/qt/http/tests/navigation/error404-goback-expected.txt:
* platform/qt/http/tests/navigation/error404-subframeload-expected.txt:
* platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/qt/http/tests/navigation/postredirect-basic-expected.txt:
* platform/qt/http/tests/navigation/postredirect-frames-expected.txt:
* platform/qt/http/tests/navigation/postredirect-goback1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Update Qt specific expected file after r71512.
ossy@webkit.org [Mon, 8 Nov 2010 14:48:47 +0000 (14:48 +0000)]
Unreviewed. Update Qt specific expected file after r71512.

* platform/qt/svg/custom/use-property-synchronization-crash-expected.txt: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed. Update/add expectations for passing editing/deleting/* tests.
ossy@webkit.org [Mon, 8 Nov 2010 14:31:32 +0000 (14:31 +0000)]
[Qt] Unreviewed. Update/add expectations for passing editing/deleting/* tests.
Compared to Mac png files and Mac expected files.

* platform/qt/Skipped:
* platform/qt/editing/deleting/4845371-expected.checksum: Added.
* platform/qt/editing/deleting/4845371-expected.png: Added.
* platform/qt/editing/deleting/4845371-expected.txt:
* platform/qt/editing/deleting/4922367-expected.checksum: Added.
* platform/qt/editing/deleting/4922367-expected.png: Added.
* platform/qt/editing/deleting/4922367-expected.txt:
* platform/qt/editing/deleting/5026848-1-expected.checksum: Added.
* platform/qt/editing/deleting/5026848-1-expected.png: Added.
* platform/qt/editing/deleting/5026848-1-expected.txt:
* platform/qt/editing/deleting/5026848-2-expected.checksum: Added.
* platform/qt/editing/deleting/5026848-2-expected.png: Added.
* platform/qt/editing/deleting/5026848-2-expected.txt:
* platform/qt/editing/deleting/5026848-3-expected.checksum: Added.
* platform/qt/editing/deleting/5026848-3-expected.png: Added.
* platform/qt/editing/deleting/5026848-3-expected.txt:
* platform/qt/editing/deleting/5032066-expected.checksum: Added.
* platform/qt/editing/deleting/5032066-expected.png: Added.
* platform/qt/editing/deleting/5032066-expected.txt:
* platform/qt/editing/deleting/5091898-expected.checksum: Added.
* platform/qt/editing/deleting/5091898-expected.png: Added.
* platform/qt/editing/deleting/5091898-expected.txt:
* platform/qt/editing/deleting/5099303-expected.checksum: Added.
* platform/qt/editing/deleting/5099303-expected.png: Added.
* platform/qt/editing/deleting/5099303-expected.txt:
* platform/qt/editing/deleting/5115601-expected.checksum: Added.
* platform/qt/editing/deleting/5115601-expected.png: Added.
* platform/qt/editing/deleting/5115601-expected.txt:
* platform/qt/editing/deleting/5126166-expected.checksum: Added.
* platform/qt/editing/deleting/5126166-expected.png: Added.
* platform/qt/editing/deleting/5126166-expected.txt:
* platform/qt/editing/deleting/5144139-2-expected.checksum: Added.
* platform/qt/editing/deleting/5144139-2-expected.png: Added.
* platform/qt/editing/deleting/5144139-2-expected.txt:
* platform/qt/editing/deleting/5156801-2-expected.checksum: Added.
* platform/qt/editing/deleting/5156801-2-expected.png: Added.
* platform/qt/editing/deleting/5156801-2-expected.txt:
* platform/qt/editing/deleting/5168598-expected.checksum: Added.
* platform/qt/editing/deleting/5168598-expected.png: Added.
* platform/qt/editing/deleting/5168598-expected.txt:
* platform/qt/editing/deleting/5206311-1-expected.checksum: Added.
* platform/qt/editing/deleting/5206311-1-expected.png: Added.
* platform/qt/editing/deleting/5206311-1-expected.txt:
* platform/qt/editing/deleting/5206311-2-expected.checksum: Added.
* platform/qt/editing/deleting/5206311-2-expected.png: Added.
* platform/qt/editing/deleting/5206311-2-expected.txt:
* platform/qt/editing/deleting/5272440-expected.checksum: Added.
* platform/qt/editing/deleting/5272440-expected.png: Added.
* platform/qt/editing/deleting/5272440-expected.txt:
* platform/qt/editing/deleting/5369009-expected.checksum: Added.
* platform/qt/editing/deleting/5369009-expected.png: Added.
* platform/qt/editing/deleting/5369009-expected.txt:
* platform/qt/editing/deleting/5390681-2-expected.checksum: Added.
* platform/qt/editing/deleting/5390681-2-expected.png: Added.
* platform/qt/editing/deleting/5390681-2-expected.txt:
* platform/qt/editing/deleting/5390681-expected.checksum: Added.
* platform/qt/editing/deleting/5390681-expected.png: Added.
* platform/qt/editing/deleting/5433862-2-expected.checksum: Added.
* platform/qt/editing/deleting/5433862-2-expected.png: Added.
* platform/qt/editing/deleting/5433862-2-expected.txt: Added.
* platform/qt/editing/deleting/5483370-expected.checksum: Added.
* platform/qt/editing/deleting/5483370-expected.png: Added.
* platform/qt/editing/deleting/5483370-expected.txt: Added.
* platform/qt/editing/deleting/delete-3608445-fix-expected.checksum: Added.
* platform/qt/editing/deleting/delete-3608445-fix-expected.png: Added.
* platform/qt/editing/deleting/delete-3608445-fix-expected.txt:
* platform/qt/editing/deleting/delete-3775172-fix-expected.checksum: Added.
* platform/qt/editing/deleting/delete-3775172-fix-expected.png: Added.
* platform/qt/editing/deleting/delete-3775172-fix-expected.txt:
* platform/qt/editing/deleting/delete-3857753-fix-expected.checksum: Added.
* platform/qt/editing/deleting/delete-3857753-fix-expected.png: Added.
* platform/qt/editing/deleting/delete-3857753-fix-expected.txt:
* platform/qt/editing/deleting/delete-3865854-fix-expected.checksum: Added.
* platform/qt/editing/deleting/delete-3865854-fix-expected.png: Added.
* platform/qt/editing/deleting/delete-3865854-fix-expected.txt:
* platform/qt/editing/deleting/delete-3928305-fix-expected.checksum: Added.
* platform/qt/editing/deleting/delete-3928305-fix-expected.png: Added.
* platform/qt/editing/deleting/delete-3928305-fix-expected.txt:
* platform/qt/editing/deleting/delete-3959464-fix-expected.checksum: Added.
* platform/qt/editing/deleting/delete-3959464-fix-expected.png: Added.
* platform/qt/editing/deleting/delete-3959464-fix-expected.txt:
* platform/qt/editing/deleting/delete-4038408-fix-expected.checksum: Added.
* platform/qt/editing/deleting/delete-4038408-fix-expected.png: Added.
* platform/qt/editing/deleting/delete-after-span-ws-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-after-span-ws-001-expected.png: Added.
* platform/qt/editing/deleting/delete-after-span-ws-001-expected.txt:
* platform/qt/editing/deleting/delete-after-span-ws-002-expected.checksum: Added.
* platform/qt/editing/deleting/delete-after-span-ws-002-expected.png: Added.
* platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
* platform/qt/editing/deleting/delete-after-span-ws-003-expected.checksum: Added.
* platform/qt/editing/deleting/delete-after-span-ws-003-expected.png: Added.
* platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.checksum: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.checksum: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.png: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.checksum: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.png: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.checksum: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.png: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.checksum: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.png: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.checksum: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.png: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.checksum: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.png: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.checksum: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.png: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.png: Added.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
* platform/qt/editing/deleting/delete-at-start-or-end-expected.checksum: Added.
* platform/qt/editing/deleting/delete-at-start-or-end-expected.png: Added.
* platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
* platform/qt/editing/deleting/delete-block-contents-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-contents-001-expected.png: Added.
* platform/qt/editing/deleting/delete-block-contents-001-expected.txt:
* platform/qt/editing/deleting/delete-block-contents-002-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-contents-002-expected.png: Added.
* platform/qt/editing/deleting/delete-block-contents-002-expected.txt:
* platform/qt/editing/deleting/delete-block-contents-003-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-contents-003-expected.png: Added.
* platform/qt/editing/deleting/delete-block-contents-003-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-001-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-002-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-002-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-002-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-003-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-003-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-003-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-004-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-004-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-004-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-005-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-005-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-006-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-006-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-007-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-007-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-008-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-008-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-009-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-009-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-009-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-010-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-010-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-011-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-011-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-011-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-012-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-012-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-012-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-013-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-013-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-013-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-014-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-014-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-014-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-015-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-015-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-015-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-016-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-016-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-016-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-017-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-017-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-017-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-019-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-019-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-020-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-020-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-023-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-023-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-023-expected.txt:
* platform/qt/editing/deleting/delete-block-merge-contents-024-expected.checksum: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-024-expected.png: Added.
* platform/qt/editing/deleting/delete-block-merge-contents-024-expected.txt:
* platform/qt/editing/deleting/delete-br-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-br-001-expected.png: Added.
* platform/qt/editing/deleting/delete-br-001-expected.txt:
* platform/qt/editing/deleting/delete-br-002-expected.checksum: Added.
* platform/qt/editing/deleting/delete-br-002-expected.png: Added.
* platform/qt/editing/deleting/delete-br-002-expected.txt:
* platform/qt/editing/deleting/delete-br-003-expected.checksum: Added.
* platform/qt/editing/deleting/delete-br-003-expected.png: Added.
* platform/qt/editing/deleting/delete-br-003-expected.txt:
* platform/qt/editing/deleting/delete-br-004-expected.checksum: Added.
* platform/qt/editing/deleting/delete-br-004-expected.png: Added.
* platform/qt/editing/deleting/delete-br-004-expected.txt:
* platform/qt/editing/deleting/delete-br-005-expected.checksum: Added.
* platform/qt/editing/deleting/delete-br-005-expected.png: Added.
* platform/qt/editing/deleting/delete-br-005-expected.txt:
* platform/qt/editing/deleting/delete-br-006-expected.checksum: Added.
* platform/qt/editing/deleting/delete-br-006-expected.png: Added.
* platform/qt/editing/deleting/delete-br-006-expected.txt:
* platform/qt/editing/deleting/delete-br-008-expected.checksum: Added.
* platform/qt/editing/deleting/delete-br-008-expected.png: Added.
* platform/qt/editing/deleting/delete-br-008-expected.txt:
* platform/qt/editing/deleting/delete-br-009-expected.checksum: Added.
* platform/qt/editing/deleting/delete-br-009-expected.png: Added.
* platform/qt/editing/deleting/delete-br-009-expected.txt:
* platform/qt/editing/deleting/delete-br-010-expected.checksum: Added.
* platform/qt/editing/deleting/delete-br-010-expected.png: Added.
* platform/qt/editing/deleting/delete-br-010-expected.txt:
* platform/qt/editing/deleting/delete-br-011-expected.checksum: Added.
* platform/qt/editing/deleting/delete-br-011-expected.png: Added.
* platform/qt/editing/deleting/delete-br-012-expected.checksum: Added.
* platform/qt/editing/deleting/delete-br-012-expected.png: Added.
* platform/qt/editing/deleting/delete-br-013-expected.checksum: Added.
* platform/qt/editing/deleting/delete-br-013-expected.png: Added.
* platform/qt/editing/deleting/delete-br-013-expected.txt: Added.
* platform/qt/editing/deleting/delete-br-in-last-table-cell-expected.checksum: Added.
* platform/qt/editing/deleting/delete-br-in-last-table-cell-expected.png: Added.
* platform/qt/editing/deleting/delete-by-word-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-by-word-001-expected.png: Added.
* platform/qt/editing/deleting/delete-by-word-001-expected.txt:
* platform/qt/editing/deleting/delete-by-word-002-expected.checksum: Added.
* platform/qt/editing/deleting/delete-by-word-002-expected.png: Added.
* platform/qt/editing/deleting/delete-by-word-002-expected.txt:
* platform/qt/editing/deleting/delete-character-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-character-001-expected.png: Added.
* platform/qt/editing/deleting/delete-character-001-expected.txt:
* platform/qt/editing/deleting/delete-first-list-item-expected.checksum: Added.
* platform/qt/editing/deleting/delete-first-list-item-expected.png: Added.
* platform/qt/editing/deleting/delete-first-list-item-expected.txt:
* platform/qt/editing/deleting/delete-hr-expected.checksum: Added.
* platform/qt/editing/deleting/delete-hr-expected.png: Added.
* platform/qt/editing/deleting/delete-hr-expected.txt:
* platform/qt/editing/deleting/delete-image-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-image-001-expected.png: Added.
* platform/qt/editing/deleting/delete-image-001-expected.txt:
* platform/qt/editing/deleting/delete-image-002-expected.checksum: Added.
* platform/qt/editing/deleting/delete-image-002-expected.png: Added.
* platform/qt/editing/deleting/delete-image-002-expected.txt:
* platform/qt/editing/deleting/delete-image-003-expected.checksum: Added.
* platform/qt/editing/deleting/delete-image-003-expected.png: Added.
* platform/qt/editing/deleting/delete-image-003-expected.txt:
* platform/qt/editing/deleting/delete-image-004-expected.checksum: Added.
* platform/qt/editing/deleting/delete-image-004-expected.png: Added.
* platform/qt/editing/deleting/delete-image-004-expected.txt:
* platform/qt/editing/deleting/delete-line-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-001-expected.png: Added.
* platform/qt/editing/deleting/delete-line-001-expected.txt:
* platform/qt/editing/deleting/delete-line-002-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-002-expected.png: Added.
* platform/qt/editing/deleting/delete-line-002-expected.txt:
* platform/qt/editing/deleting/delete-line-003-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-003-expected.png: Added.
* platform/qt/editing/deleting/delete-line-003-expected.txt:
* platform/qt/editing/deleting/delete-line-004-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-004-expected.png: Added.
* platform/qt/editing/deleting/delete-line-004-expected.txt:
* platform/qt/editing/deleting/delete-line-005-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-005-expected.png: Added.
* platform/qt/editing/deleting/delete-line-005-expected.txt:
* platform/qt/editing/deleting/delete-line-006-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-006-expected.png: Added.
* platform/qt/editing/deleting/delete-line-006-expected.txt:
* platform/qt/editing/deleting/delete-line-007-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-007-expected.png: Added.
* platform/qt/editing/deleting/delete-line-007-expected.txt:
* platform/qt/editing/deleting/delete-line-008-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-008-expected.png: Added.
* platform/qt/editing/deleting/delete-line-008-expected.txt:
* platform/qt/editing/deleting/delete-line-009-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-009-expected.png: Added.
* platform/qt/editing/deleting/delete-line-009-expected.txt:
* platform/qt/editing/deleting/delete-line-010-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-010-expected.png: Added.
* platform/qt/editing/deleting/delete-line-010-expected.txt:
* platform/qt/editing/deleting/delete-line-011-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-011-expected.png: Added.
* platform/qt/editing/deleting/delete-line-011-expected.txt:
* platform/qt/editing/deleting/delete-line-012-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-012-expected.png: Added.
* platform/qt/editing/deleting/delete-line-012-expected.txt:
* platform/qt/editing/deleting/delete-line-013-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-013-expected.png: Added.
* platform/qt/editing/deleting/delete-line-013-expected.txt:
* platform/qt/editing/deleting/delete-line-014-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-014-expected.png: Added.
* platform/qt/editing/deleting/delete-line-014-expected.txt:
* platform/qt/editing/deleting/delete-line-015-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-015-expected.png: Added.
* platform/qt/editing/deleting/delete-line-015-expected.txt:
* platform/qt/editing/deleting/delete-line-016-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-016-expected.png: Added.
* platform/qt/editing/deleting/delete-line-016-expected.txt:
* platform/qt/editing/deleting/delete-line-017-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-017-expected.png: Added.
* platform/qt/editing/deleting/delete-line-017-expected.txt:
* platform/qt/editing/deleting/delete-line-end-ws-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-line-end-ws-001-expected.png: Added.
* platform/qt/editing/deleting/delete-line-end-ws-001-expected.txt:
* platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.png: Added.
* platform/qt/editing/deleting/delete-select-all-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-select-all-001-expected.png: Added.
* platform/qt/editing/deleting/delete-select-all-002-expected.checksum: Added.
* platform/qt/editing/deleting/delete-select-all-002-expected.png: Added.
* platform/qt/editing/deleting/delete-select-all-002-expected.txt:
* platform/qt/editing/deleting/delete-select-all-003-expected.checksum: Added.
* platform/qt/editing/deleting/delete-select-all-003-expected.png: Added.
* platform/qt/editing/deleting/delete-select-all-003-expected.txt:
* platform/qt/editing/deleting/delete-selection-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-selection-001-expected.png: Added.
* platform/qt/editing/deleting/delete-selection-001-expected.txt:
* platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.checksum: Added.
* platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.png: Added.
* platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.txt: Copied from LayoutTests/platform/qt/editing/deleting/delete-line-009-expected.txt.
* platform/qt/editing/deleting/delete-to-select-table-expected.checksum: Added.
* platform/qt/editing/deleting/delete-to-select-table-expected.png: Added.
* platform/qt/editing/deleting/delete-to-select-table-expected.txt:
* platform/qt/editing/deleting/delete-trailing-ws-001-expected.checksum: Added.
* platform/qt/editing/deleting/delete-trailing-ws-001-expected.png: Added.
* platform/qt/editing/deleting/delete-trailing-ws-001-expected.txt:
* platform/qt/editing/deleting/delete-trailing-ws-002-expected.checksum: Added.
* platform/qt/editing/deleting/delete-trailing-ws-002-expected.png: Added.
* platform/qt/editing/deleting/delete-trailing-ws-002-expected.txt:
* platform/qt/editing/deleting/list-item-1-expected.checksum: Added.
* platform/qt/editing/deleting/list-item-1-expected.png: Added.
* platform/qt/editing/deleting/list-item-1-expected.txt:
* platform/qt/editing/deleting/merge-different-styles-expected.checksum: Added.
* platform/qt/editing/deleting/merge-different-styles-expected.png: Added.
* platform/qt/editing/deleting/merge-different-styles-expected.txt:
* platform/qt/editing/deleting/merge-endOfParagraph-expected.checksum: Added.
* platform/qt/editing/deleting/merge-endOfParagraph-expected.png: Added.
* platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
* platform/qt/editing/deleting/merge-into-empty-block-1-expected.checksum: Added.
* platform/qt/editing/deleting/merge-into-empty-block-1-expected.png: Added.
* platform/qt/editing/deleting/merge-into-empty-block-1-expected.txt:
* platform/qt/editing/deleting/merge-into-empty-block-2-expected.checksum: Added.
* platform/qt/editing/deleting/merge-into-empty-block-2-expected.png: Added.
* platform/qt/editing/deleting/merge-into-empty-block-2-expected.txt:
* platform/qt/editing/deleting/merge-no-br-expected.checksum: Added.
* platform/qt/editing/deleting/merge-no-br-expected.png: Added.
* platform/qt/editing/deleting/merge-no-br-expected.txt:
* platform/qt/editing/deleting/merge-unrendered-space-expected.checksum: Added.
* platform/qt/editing/deleting/merge-unrendered-space-expected.png: Added.
* platform/qt/editing/deleting/merge-unrendered-space-expected.txt:
* platform/qt/editing/deleting/merge-whitespace-pre-expected.checksum: Added.
* platform/qt/editing/deleting/merge-whitespace-pre-expected.png: Added.
* platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
* platform/qt/editing/deleting/move-nodes-001-expected.checksum: Added.
* platform/qt/editing/deleting/move-nodes-001-expected.png: Added.
* platform/qt/editing/deleting/move-nodes-001-expected.txt:
* platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.checksum: Added.
* platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.png: Added.
* platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.txt:
* platform/qt/editing/deleting/pruning-after-merge-2-expected.checksum: Added.
* platform/qt/editing/deleting/pruning-after-merge-2-expected.png: Added.
* platform/qt/editing/deleting/pruning-after-merge-2-expected.txt:
* platform/qt/editing/deleting/smart-delete-001-expected.checksum: Added.
* platform/qt/editing/deleting/smart-delete-001-expected.png: Added.
* platform/qt/editing/deleting/smart-delete-001-expected.txt:
* platform/qt/editing/deleting/table-cells-expected.checksum: Added.
* platform/qt/editing/deleting/table-cells-expected.png: Added.
* platform/qt/editing/deleting/table-cells-expected.txt:
* platform/qt/editing/deleting/type-delete-after-quote-expected.checksum: Added.
* platform/qt/editing/deleting/type-delete-after-quote-expected.png: Added.
* platform/qt/editing/deleting/type-delete-after-quote-expected.txt: Added.
* platform/qt/editing/deleting/whitespace-pre-1-expected.checksum: Added.
* platform/qt/editing/deleting/whitespace-pre-1-expected.png: Added.
* platform/qt/editing/deleting/whitespace-pre-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate Windows results after r71465
aroben@apple.com [Mon, 8 Nov 2010 14:20:24 +0000 (14:20 +0000)]
Update Windows results after r71465

* platform/win/fast/blockflow/border-vertical-lr-expected.checksum:
* platform/win/fast/blockflow/border-vertical-lr-expected.png:
* platform/win/fast/blockflow/border-vertical-lr-expected.txt:
* platform/win/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
* platform/win/fast/blockflow/japanese-lr-selection-expected.png: Added.
* platform/win/fast/blockflow/japanese-lr-selection-expected.txt: Added.
* platform/win/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
* platform/win/fast/blockflow/japanese-rl-selection-expected.png: Added.
* platform/win/fast/blockflow/japanese-rl-selection-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch back to using kCGImageAlphaPremultipliedFirst when generating pixel dumps...
aroben@apple.com [Mon, 8 Nov 2010 14:18:37 +0000 (14:18 +0000)]
Switch back to using kCGImageAlphaPremultipliedFirst when generating pixel dumps on Windows

I changed this behavior in r71418 thinking that it was required for
getting plugins to show up in pixel dumps. But it doesn't seem to be
necessary, and was making it impossible to compare new Windows pixel
dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
compare an image with alpha to an image without alpha).

Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
new Windows pixel results to existing Windows or Mac results

Reviewed by Antti Koivisto.

* DumpRenderTree/win/PixelDumpSupportWin.cpp:
(createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
with kCGImageAlphaPremultipliedFirst.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 8 Nov 2010 14:05:32 +0000 (14:05 +0000)]
2010-11-08  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: decouple ScriptArguments from ScriptCallStack
        https://bugs.webkit.org/show_bug.cgi?id=48058

        ScriptCallFrame and ScriptCallStack are now the same for both JSC and V8.
        The factory functions that allow to create ScriptCallStack from VM-specific
        objects are defined in ScriptCallStackFactory.cpp.

        ScriptArguments class is used for passing arguments from JS code to the native
        part.

        No new tests. This refactoring is covered with existing Console tests.

        * Android.jscbindings.mk:
        * Android.v8bindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSConsoleCustom.cpp:
        (WebCore::JSConsole::profile):
        (WebCore::JSConsole::profileEnd):
        * bindings/js/ScriptCallStackFactory.cpp: Renamed from WebCore/bindings/js/ScriptCallStack.cpp.
        (WebCore::createScriptCallStack):
        (WebCore::createScriptArguments):
        (WebCore::ScriptCallStack::stackTrace):
        * bindings/js/ScriptCallStackFactory.h: Copied from WebCore/bindings/js/ScriptCallFrame.cpp.
        * bindings/js/ScriptState.cpp:
        (WebCore::ScriptStateProtectedPtr::~ScriptStateProtectedPtr):
        (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr):
        (WebCore::ScriptStateProtectedPtr::get):
        * bindings/js/ScriptState.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::customArgsAndExceptionCallback):
        * bindings/v8/ScriptCallFrame.h: Removed.
        * bindings/v8/ScriptCallStack.h: Removed.
        * bindings/v8/ScriptCallStackFactory.cpp: Renamed from WebCore/bindings/v8/ScriptCallStack.cpp.
        (WebCore::toScriptCallFrame):
        (WebCore::toScriptCallFramesVector):
        (WebCore::createScriptCallStack):
        (WebCore::createScriptArguments):
        (WebCore::ScriptCallStack::stackTrace):
        * bindings/v8/ScriptCallStackFactory.h: Copied from WebCore/bindings/js/ScriptCallFrame.cpp.
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
        * bindings/v8/ScriptState.h:
        (WebCore::ScriptStateProtectedPtr::get):
        * bindings/v8/V8ConsoleMessage.cpp:
        (WebCore::V8ConsoleMessage::handler):
        (WebCore::V8ConsoleMessage::dispatchNow):
        * bindings/v8/V8ConsoleMessage.h:
        * bindings/v8/custom/V8ConsoleCustom.cpp:
        (WebCore::V8Console::traceCallback):
        (WebCore::V8Console::assertCallback):
        (WebCore::V8Console::profileCallback):
        (WebCore::V8Console::profileEndCallback):
        * dom/NodeFilter.h:
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::ConsoleMessage::addToFrontend):
        (WebCore::ConsoleMessage::updateRepeatCountInConsole):
        (WebCore::ConsoleMessage::isEqual):
        * inspector/ConsoleMessage.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addMessageToConsole):
        (WebCore::InspectorController::startGroup):
        * inspector/InspectorController.h:
        * inspector/ScriptArguments.cpp: Copied from WebCore/bindings/v8/ScriptCallFrame.cpp.
        (WebCore::ScriptArguments::ScriptArguments):
        (WebCore::ScriptArguments::~ScriptArguments):
        (WebCore::ScriptArguments::argumentAt):
        (WebCore::ScriptArguments::globalState):
        (WebCore::ScriptArguments::getFirstArgumentAsString):
        (WebCore::ScriptArguments::isEqual):
        * inspector/ScriptArguments.h: Copied from WebCore/bindings/js/ScriptCallFrame.h.
        (WebCore::ScriptArguments::argumentCount):
        * inspector/ScriptCallFrame.cpp: Renamed from WebCore/bindings/v8/ScriptCallFrame.cpp.
        (WebCore::ScriptCallFrame::ScriptCallFrame):
        (WebCore::ScriptCallFrame::~ScriptCallFrame):
        (WebCore::ScriptCallFrame::isEqual):
        (WebCore::ScriptCallFrame::buildInspectorObject):
        * inspector/ScriptCallFrame.h: Renamed from WebCore/bindings/js/ScriptCallFrame.h.
        (WebCore::ScriptCallFrame::functionName):
        (WebCore::ScriptCallFrame::sourceURL):
        (WebCore::ScriptCallFrame::lineNumber):
        * inspector/ScriptCallStack.cpp: Renamed from WebCore/bindings/js/ScriptCallFrame.cpp.
        (WebCore::ScriptCallStack::ScriptCallStack):
        (WebCore::ScriptCallStack::~ScriptCallStack):
        (WebCore::ScriptCallStack::at):
        (WebCore::ScriptCallStack::size):
        (WebCore::ScriptCallStack::isEqual):
        (WebCore::ScriptCallStack::buildInspectorObject):
        * inspector/ScriptCallStack.h: Renamed from WebCore/bindings/js/ScriptCallStack.h.
        * page/Console.cpp:
        (WebCore::Console::addMessage):
        (WebCore::Console::debug):
        (WebCore::Console::error):
        (WebCore::Console::info):
        (WebCore::Console::log):
        (WebCore::Console::dir):
        (WebCore::Console::dirxml):
        (WebCore::Console::trace):
        (WebCore::Console::assertCondition):
        (WebCore::Console::count):
        (WebCore::Console::markTimeline):
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd):
        (WebCore::Console::timeEnd):
        (WebCore::Console::group):
        (WebCore::Console::groupCollapsed):
        (WebCore::Console::shouldCaptureFullStackTrace):
        (WebCore::Console::warn):
        * page/Console.h:
        (WebCore::Console::profiles):
        * page/Console.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 8 Nov 2010 14:00:19 +0000 (14:00 +0000)]
2010-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Build fix.

        Attempt to fix windows builds after r71512. Swap order of members to avoid warning C4121.

        * svg/properties/SVGStaticPropertyTearOff.h:
        (WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Mon, 8 Nov 2010 13:49:19 +0000 (13:49 +0000)]
2010-11-08  Mikhail Naganov  <mnaganov@chromium.org>

        Unreviewed. Fix Qt build after r71511.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreInspectorStateFromCookie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 8 Nov 2010 13:43:41 +0000 (13:43 +0000)]
2010-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Convert SVGPoint/SVGPointList to the new SVGPropertyTearOff concept
        https://bugs.webkit.org/show_bug.cgi?id=49067

        Remove SVGAnimatedPoints interface, not reachable through bindings anyway, it was just another MI interface, that
        now has been integrated into SVGPolylineElement/SVGPolygonElement, simplfying the generation and avoiding virtual
        calls in SVGPolylineElement/SVGPolygonElement.

        Remove the need to use manual XML <-> SVG DOM synchronization. The points/animatedPoints methods now create
        SVGListPropertyTearOffs, thus using the same synchronization/expose-to-bindings concept like all other
        animated properties.

        Convert SVGPoint/SVGPointList to use the new SVGPropertyTearOff concept, adapted all code, as SVGPointList
        is now a plain Vector<FloatPoint>. Enable StrictTypeChecking for SVGPoint.

        Test: svg/dom/SVGPoint.html

        * Android.derived.v8bindings.mk: Remove SVGAnimatedPoints (and IDL generation).
        * Android.mk: Ditto.
        * CMakeLists.txt: Ditto.
        * DerivedSources.make: Ditto.
        * GNUmakefile.am: Ditto. Add SVGStaticPropertyTearOff.h to build.
        * WebCore.gypi: Ditto.
        * WebCore.order: Remove SVGAnimatedPoints symbols.
        * WebCore.pro: Remove SVGAnimatedPoints (and IDL generation). Add SVGStaticPropertyTearOff.h to build.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * bindings/objc/DOMSVG.h: Remove DOMSVGAnimatedPoints include.
        * bindings/scripts/CodeGenerator.pm: Adapt code converting SVGPoint/SVGPointList to use the new SVGPropertyTearOff concepts.
        * bindings/scripts/CodeGeneratorJS.pm: Ditto.
        * bindings/scripts/CodeGeneratorObjC.pm: Ditto.
        * bindings/scripts/CodeGeneratorV8.pm: Ditto.
        * rendering/SVGRenderTreeAsText.cpp: Adapt for SVGPolyElement API change, use pointList() instead of points() (which is only used for bindings now).
        (WebCore::operator<<):
        * svg/SVGAllInOne.cpp: Remove SVGAnimatedPoints.cpp.
        * svg/SVGAnimateElement.cpp: Adapt for SVGPointList API change, it's not refcounted anymore.
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::applyResultsToTarget):
        * svg/SVGAnimateElement.h:  Ditto.
        * svg/SVGAnimatedPoints.cpp: Removed.
        * svg/SVGAnimatedPoints.h: Removed.
        * svg/SVGAnimatedPoints.idl: Removed.
        * svg/SVGParserUtilities.cpp: Adapt for SVGPointList API change, it's not refcounted anymore.
        (WebCore::pointsListFromSVGData):
        * svg/SVGParserUtilities.h: Ditto.
        * svg/SVGPoint.idl: Remove PODType marker, and add StrictTypeChecking for x/y attributes.
        * svg/SVGPointList.cpp: SVGPointList is now a plain Vector<FloatPoint>, rewrite.
        (WebCore::SVGPointList::valueAsString):
        (WebCore::SVGPointList::createAnimated):
        * svg/SVGPointList.h: Ditto.
        (WebCore::SVGPointList::SVGPointList):
        * svg/SVGPolyElement.cpp: Remove manual SVG <-> XML DOM synchronization. Now handles through the SVGAnimatedPropertyTearOff concept.
        (WebCore::SVGPolyElement::parseMappedAttribute):
        (WebCore::SVGPolyElement::svgAttributeChanged):
        (WebCore::SVGPolyElement::synchronizeProperty):
        (WebCore::SVGPolyElement::synchronizePoints):
        (WebCore::SVGPolyElement::points):
        (WebCore::SVGPolyElement::animatedPoints):
        * svg/SVGPolyElement.h: Reindented.
        (WebCore::SVGPolyElement::pointList):
        (WebCore::SVGPolyElement::isValid):
        (WebCore::SVGPolyElement::supportsMarkers):
        * svg/SVGPolygonElement.cpp: Adapt for SVGPointList API change.
        (WebCore::SVGPolygonElement::toPathData):
        * svg/SVGPolygonElement.idl: Remove SVGAnimatedPoints inheritance.
        * svg/SVGPolylineElement.cpp: Adapt for SVGPointList API change.
        (WebCore::SVGPolylineElement::toPathData):
        * svg/SVGPolylineElement.idl: Remove SVGAnimatedPoints inheritance.
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::setCurrentTranslate): Use updateCurrentTranslate().
        (WebCore::SVGSVGElement::updateCurrentTranslate): Added, only used by the bindings, after changing a value of SVGStaticPropertyTearOff object.
        * svg/SVGSVGElement.h:
        (WebCore::SVGSVGElement::currentTranslate): Return reference to m_translation.
        * svg/properties/SVGPropertyTearOff.h: Made constructors protected, as SVGStaticPropertyTearOff inherits from it.
        (WebCore::SVGPropertyTearOff::commitChange):
        * svg/properties/SVGPropertyTraits.h: Add SVGPointList handing.
        * svg/properties/SVGStaticPropertyTearOff.h: Added. Used for SVGProperty types returned by attributes, that are not associated with a SVGAnimatedProperty. (SVGSVGElement::currentTranslate).
        (WebCore::SVGStaticPropertyTearOff::create):
        (WebCore::SVGStaticPropertyTearOff::commitChange):
        (WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff):

2010-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Convert SVGPoint/SVGPointList to the new SVGPropertyTearOff concept
        https://bugs.webkit.org/show_bug.cgi?id=49067

        * platform/mac/svg/custom/use-property-synchronization-crash-expected.txt: Cloned <polyline> now reports parsing problems as well.
        * svg/custom/polyline-points-crash-expected.txt: Update expectation.
        * svg/custom/polyline-points-crash.html: appendItem(null) now throws, catch exception.
        * svg/dom/points-parser.html: Fix failure reporting, use correct variable name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Mon, 8 Nov 2010 13:38:46 +0000 (13:38 +0000)]
2010-11-08  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Adam Barth.

        Web Inspector [Chromium]: Make CPU profiling to survive navigation.

        https://bugs.webkit.org/show_bug.cgi?id=48843

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreInspectorStateFromCookie):
        (WebCore::InspectorController::reuseFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::restoreProfiler):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::startUserInitiatedProfiling):
        (WebCore::InspectorController::stopUserInitiatedProfiling):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::startProfiling):
        (WebCore::InspectorController::stopProfiling):
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
        (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
        * inspector/InspectorProfilerAgent.h:
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        * inspector/InspectorState.h:
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.hasTemporaryProfile):
        (WebInspector.ProfilesPanel.prototype.hasProfile):
        * inspector/front-end/inspector.js:
        (WebInspector.setRecordingProfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Csaba Osztrogonac <ossy@webkit.org>
ossy@webkit.org [Mon, 8 Nov 2010 11:58:57 +0000 (11:58 +0000)]
2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>

        Unreviewed, rolling out r71466.
        http://trac.webkit.org/changeset/71466
        https://bugs.webkit.org/show_bug.cgi?id=48865

        It broke layout tests on GTK bots.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::closeWindowSoon):
        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        (webkit_web_view_init):
        (webkit_web_view_set_group_name):
2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>

        Unreviewed, rolling out r71466.
        http://trac.webkit.org/changeset/71466
        https://bugs.webkit.org/show_bug.cgi?id=48865

        It broke layout tests on GTK bots.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (createWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable running of Qt API tests on BuildBot
ossy@webkit.org [Mon, 8 Nov 2010 10:50:48 +0000 (10:50 +0000)]
Enable running of Qt API tests on BuildBot
https://bugs.webkit.org/show_bug.cgi?id=49004

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-08
Reviewed by Csaba Osztrogonác.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: SVGFEConvolveMatrixElement doesn't support dynamic invalidation
reni@webkit.org [Mon, 8 Nov 2010 10:43:35 +0000 (10:43 +0000)]
WebCore: SVGFEConvolveMatrixElement doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=47660

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-08
Reviewed by Nikolas Zimmermann.

Wrap orderX and orderY into the common order property according to the w3 standard and remove them from svnattrs.in.
The patch implements the orderXIdentifier and orderYIdentifier getter functions to reach
properly the orderX and orderY components of order property from SVG DOM.

Tests: svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop.html
       svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop.html
       svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop.html
       svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop.html
       svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop.html
       svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop.html
       svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop.html
       svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop.html
       svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html
       svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html

* svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::orderXIdentifier):
(WebCore::SVGFEConvolveMatrixElement::orderYIdentifier):
* svg/SVGFEConvolveMatrixElement.h:
* svg/svgattrs.in:

LayoutTests: SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47660

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-08
Reviewed by Nikolas Zimmermann.

This patch contains the SVG DOM dynamic update tests of feConvolveMatrix and it
fixes the DOM test of order attribute because the product of order components should be equal the
size of the kernelMatrix.

* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html: Added.
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js:
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-bias-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-divisor-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-in-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop.js: Added.
(SVGNumberListToString):
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-order-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-targetX-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-targetY-prop.js: Added.
(executeTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-08 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 8 Nov 2010 10:28:04 +0000 (10:28 +0000)]
2010-11-08  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: follow up to inspector commit.
        https://bugs.webkit.org/show_bug.cgi?id=49130

        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.reset):
        * inspector/front-end/inspector.css:
        (.event-bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-06 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 8 Nov 2010 10:12:36 +0000 (10:12 +0000)]
2010-11-06  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add more event listener breakpoint types, add support for regular breakpoint hit state, beautify hit rendering.
        https://bugs.webkit.org/show_bug.cgi?id=49130

        * English.lproj/localizedStrings.js:
        * inspector/front-end/BreakpointManager.js:
        (WebInspector.BreakpointManager.prototype.debuggerPaused):
        (WebInspector.Breakpoint.jsBreakpointId):
        (WebInspector.Breakpoint.prototype.get id):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.EventListenerBreakpointsSidebarPane):
        (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        * inspector/front-end/inspector.css:
        (#elements-sidebar):
        (.pane > .body):
        (#scripts-sidebar):
        (li.breakpoint-hit .breakpoint-hit-marker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updating Chromium expectations.
ukai@chromium.org [Mon, 8 Nov 2010 09:36:16 +0000 (09:36 +0000)]
Unreviewed, updating Chromium expectations.

Since r71493:r71496, http/tests/misc/prefetch-purpose.html start failing on Mac

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71505 268f45cc-cd09-0410-ab3c-d52691b4dbfc