WebKit-https.git
7 years agoSet Attr.ownerDocument in Element#setAttributeNode()
rniwa@webkit.org [Wed, 26 Jun 2013 17:47:49 +0000 (17:47 +0000)]
Set Attr.ownerDocument in Element#setAttributeNode()
https://bugs.webkit.org/show_bug.cgi?id=118031

Reviewed by Andreas Kling.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/fa739fe5369f55bbdcb3fa123cb64df36b8ae414.

Adopt Attr node as needed.

Test: fast/dom/Attr/set-attribute-node-from-iframe.html

* dom/Element.cpp:
(WebCore::Element::setAttributeNode):

LayoutTests:

Add a regression test.

* fast/dom/Attr/set-attribute-node-from-iframe-expected.txt: Added.
* fast/dom/Attr/set-attribute-node-from-iframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFlex boxes (both old and new) don't handle max-height images correctly.
hyatt@apple.com [Wed, 26 Jun 2013 17:31:26 +0000 (17:31 +0000)]
Flex boxes (both old and new) don't handle max-height images correctly.
https://bugs.webkit.org/show_bug.cgi?id=118000

Reviewed by Beth Dakin.

Source/WebCore:

Tests: css3/flexbox/image-percent-max-height.html
       fast/flexbox/image-percent-max-height.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::dirtyForLayoutFromPercentageHeightDescendants):
(WebCore::RenderBlock::layoutBlockChildren):
Pull the percentage height descendant code that dirties those descendants
out of layoutBlockChildren and into a protected helper function,
dirtyForLayoutFromPercentageHeightDescendants, that can be called from the
flex box code.

Also patch dirtyForLayoutFromPercentageHeightDescendants so that it will dirty
preferred logical widths when a child has an aspect ratio, since we know that
percentage height changes will potentially affect the preferred widths of the image and
its ancestor blocks.

* rendering/RenderBlock.h:
Declaration of the new dirtyForLayoutFromPercentageHeightDescendants function.

* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
Make the old flex box code call dirtyForLayoutFromPercentageHeightDescendants so
that everything is dirtied properly.

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
Remove the isReplaced()/percentage height/width dirtying now that the old flexible
box is using the same dirtying mechanism as RenderBlock.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
Patch the new flexible box code to use the dirtying mechanism that RenderBlock
uses for percentage heights/widths on replaced descendants.

* rendering/RenderObject.h:
(WebCore::RenderObject::hasAspectRatio):
Pulled the static helper function from RenderReplaced into a full-blown method
on RenderObject, so that dirtyForLayoutFromPercentageHeightDescendants can call
it to check if an object has an aspect ratio.

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox):
(WebCore::RenderReplaced::computeIntrinsicRatioInformation):
Patch the call sites of the static helper function to use hasAspectRatio instead
and get rid of the static in the cpp file.

LayoutTests:

* css3/flexbox/image-percent-max-height-expected.html: Added.
* css3/flexbox/image-percent-max-height.html: Added.
* css3/flexbox/resources/hero.png: Added.
* fast/flexbox/image-percent-max-height-expected.html: Added.
* fast/flexbox/image-percent-max-height.html: Added.
* fast/flexbox/resources/hero.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdopt is/toHTMLAreaElement for code cleanup
kangil.han@samsung.com [Wed, 26 Jun 2013 17:23:33 +0000 (17:23 +0000)]
Adopt is/toHTMLAreaElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117980

Reviewed by Antonio Gomes.

To enhance readibility, this patch adopts is/toHTMLAreaElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedUIElementForPage):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
* html/HTMLAreaElement.h:
(WebCore::isHTMLAreaElement):
(WebCore::toHTMLAreaElement):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::mapMouseEvent):
* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
* page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
(WebCore::areElementsOnSameLine):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteLinkURL):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintAreaElementFocusRing):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::elementForTapHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] ASSERT(!m_tileMatrixNeedsUpdate) in BackingStorePrivate::render()
zhajiang@rim.com [Wed, 26 Jun 2013 17:18:15 +0000 (17:18 +0000)]
[BlackBerry] ASSERT(!m_tileMatrixNeedsUpdate) in BackingStorePrivate::render()
https://bugs.webkit.org/show_bug.cgi?id=118062

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-06-26.
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

JIRA426949
requestLayoutIfNeeded() can cause zoomAboutPoint() when the layout
is finished and make the tile matrix stale. We need requestLayoutIfNeeded()
before we updateTileMatrixIfNeeded() so that we can fix the ASSERT and
also pass the valid TileIndexList to render().

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::render):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Document URL is not updated by HSTS
beidson@apple.com [Wed, 26 Jun 2013 17:03:48 +0000 (17:03 +0000)]
[Mac] Document URL is not updated by HSTS
<rdar://problem/14241270> and https://bugs.webkit.org/show_bug.cgi?id=118003

Patch started by Alexey Proskuryakov, finished by Brady Eidson.

Reviewed by Brady Eidson and then Alexey Proskuryakov.

Synthesize a response and properly handle willSendRequest when the URL changes in a way that's typical for HSTS.

* platform/network/mac/WebCoreURLResponse:
* platform/network/mac/WebCoreURLResponse:
(WebCore::synthesizeRedirectResponseIfNecessary): Synthesize a redirect response and when the URL changes in a way that's
  typical for HSTS connections.

* platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
(-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): Call synthesizeRedirectResponseIfNecessary.

* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoediting/selection/doubleclick-crash.html can be flaky
rniwa@webkit.org [Wed, 26 Jun 2013 16:28:49 +0000 (16:28 +0000)]
editing/selection/doubleclick-crash.html can be flaky
https://bugs.webkit.org/show_bug.cgi?id=118017

Reviewed by Jessie Berlin.

Merge https://chromium.googlesource.com/chromium/blink/+/45ac882064589ac41a63762905f0618fc035cd44.

* editing/selection/doubleclick-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] fast/regions/seamless-iframe-flowed-into-regions.html asserts
abucur@adobe.com [Wed, 26 Jun 2013 16:05:23 +0000 (16:05 +0000)]
[CSS Regions] fast/regions/seamless-iframe-flowed-into-regions.html asserts
https://bugs.webkit.org/show_bug.cgi?id=117797

Reviewed by Antti Koivisto.

The seamless iframes inherit the current RenderFlowThread during layout. This means getting
the LayoutState object from the flow thread RenderView object is not always correct.
For RenderObjects inside the seamless iframes the view()/LayoutState object is different than the one
of the RenderFlowThread. The patch changes the code to use the correct LayoutState object during
layout when pushing a new state.

Tests: covered by fast/regions/seamless-iframe-flowed-into-regions.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::currentActiveRenderBox):
(WebCore::RenderFlowThread::pushFlowThreadLayoutState):
(WebCore::RenderFlowThread::popFlowThreadLayoutState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: stepping through while paused in debugger makes a popover appear
graouts@apple.com [Wed, 26 Jun 2013 16:00:18 +0000 (16:00 +0000)]
Web Inspector: stepping through while paused in debugger makes a popover appear
https://bugs.webkit.org/show_bug.cgi?id=117994

There is no obvious need to call tokenTrackingControllerNewHighlightCandidate when the
active call frame changes and it leads to an extraneous display of the popover.

Reviewed by Timothy Hatcher.

* UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._activeCallFrameDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove many static_casts to Element types from AccessibilityNodeObject
rniwa@webkit.org [Wed, 26 Jun 2013 15:38:58 +0000 (15:38 +0000)]
Remove many static_casts to Element types from AccessibilityNodeObject
https://bugs.webkit.org/show_bug.cgi?id=118021

Reviewed by Chris Fleizach.

Merge https://chromium.googlesource.com/chromium/blink/+/ecd837f94996a20fdb8798e24f26cf6edea2a423.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::alternativeTextForWebArea):
(WebCore::AccessibilityNodeObject::text):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStop inheriting SVGExternalResourcesRequired, SVGFitToViewBox and SVGZoomAndPan
ch.dumez@sisa.samsung.com [Wed, 26 Jun 2013 14:28:00 +0000 (14:28 +0000)]
Stop inheriting SVGExternalResourcesRequired, SVGFitToViewBox and SVGZoomAndPan
https://bugs.webkit.org/show_bug.cgi?id=118029

Reviewed by Kentaro Hara.

Stop inheriting SVGExternalResourcesRequired, SVGFitToViewBox and SVGZoomAndPan
in the IDL and use implements statements instead.

This is one step towards getting rid of multiple inheritance in the SVG code
and matching the latest specification:
http://www.w3.org/TR/SVG2/types.html#BasicDOMInterfaces

There is no webexposed behavior change.

No new tests, no behavior change.

* svg/SVGAnimationElement.idl:
* svg/SVGCircleElement.idl:
* svg/SVGClipPathElement.idl:
* svg/SVGCursorElement.idl:
* svg/SVGDefsElement.idl:
* svg/SVGEllipseElement.idl:
* svg/SVGFEImageElement.idl:
* svg/SVGFilterElement.idl:
* svg/SVGForeignObjectElement.idl:
* svg/SVGGElement.idl:
* svg/SVGGradientElement.idl:
* svg/SVGImageElement.idl:
* svg/SVGLineElement.idl:
* svg/SVGMPathElement.idl:
* svg/SVGMarkerElement.idl:
* svg/SVGMaskElement.idl:
* svg/SVGPathElement.idl:
* svg/SVGPatternElement.idl:
* svg/SVGPolygonElement.idl:
* svg/SVGPolylineElement.idl:
* svg/SVGRectElement.idl:
* svg/SVGSVGElement.idl:
* svg/SVGScriptElement.idl:
* svg/SVGSwitchElement.idl:
* svg/SVGSymbolElement.idl:
* svg/SVGTextContentElement.idl:
* svg/SVGUseElement.idl:
* svg/SVGViewSpec.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agogdb: Remove the webcore.py pretty printer.
rakuco@webkit.org [Wed, 26 Jun 2013 11:45:42 +0000 (11:45 +0000)]
gdb: Remove the webcore.py pretty printer.
https://bugs.webkit.org/show_bug.cgi?id=117992

Reviewed by Jochen Eisinger.

webcore.py has been only a placeholder for backwards compatibility
for almost 3 years. It should be safe enough to remove it now.

* gdb/webcore.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse-after-free in RadioInputType::handleKeydownEvent
rniwa@webkit.org [Wed, 26 Jun 2013 10:49:02 +0000 (10:49 +0000)]
Use-after-free in RadioInputType::handleKeydownEvent
https://bugs.webkit.org/show_bug.cgi?id=118035

Reviewed by Kent Tamura.

Use RefPtr for inputElement since setFocusedNode could blow it away.

* html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of multiple inheritence for SVGViewElement interface
ch.dumez@sisa.samsung.com [Wed, 26 Jun 2013 10:39:50 +0000 (10:39 +0000)]
Get rid of multiple inheritence for SVGViewElement interface
https://bugs.webkit.org/show_bug.cgi?id=118014

Reviewed by Kentaro Hara.

Source/WebCore:

Web IDL no longer supports multiple inheritence. As per the latest
specification SVGViewElement should only inherit from SVGElement.
'implements' statements are used for the rest. This patch refactors
the IDL files to match the latest specification:
http://www.w3.org/TR/SVG2/linking.html#InterfaceSVGViewElement

Note that there is a WebExposed change as SVGZoomAndPan used to be
exposed on the Window and it is not anymore. SVGZoomAndPan merely
supplements SVGViewElement and should not be exposed to JavaScript
according to the latest specification.

No new tests, covered by existing tests.

* CMakeLists.txt:
* DerivedSources.pri:
* GNUmakefile.list.am:
* svg/SVGExternalResourcesRequired.idl:
* svg/SVGFitToViewBox.idl:
* svg/SVGViewElement.idl:
* svg/SVGZoomAndPan.idl:

LayoutTests:

Update / Rebaseline several SVG test cases now that SVGZoomAndPan interface
is no longer exposed.

* fast/js/global-constructors-attributes-expected.txt:
* platform/efl/fast/js/global-constructors-attributes-expected.txt:
* platform/gtk/fast/js/global-constructors-attributes-expected.txt:
* platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
* platform/qt/fast/js/global-constructors-attributes-expected.txt:
* svg/custom/global-constructors-expected.txt:
* svg/custom/js-svg-constructors-expected.txt:
* svg/custom/js-svg-constructors.svg:
* svg/custom/script-tests/global-constructors.js:
* svg/dom/SVGViewSpec-defaults-expected.txt:
* svg/dom/SVGViewSpec-expected.txt:
* svg/dom/resources/viewspec-parser.js:
(zoomAndPanToString):
(viewSpecToString):
* svg/dom/script-tests/SVGViewSpec-defaults.js:
* svg/dom/script-tests/SVGViewSpec.js:
(continueTesting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCreating cURL watchlist and adding myself to it.
ossy@webkit.org [Wed, 26 Jun 2013 08:18:24 +0000 (08:18 +0000)]
Creating cURL watchlist and adding myself to it.

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-26
Reviewed by Csaba Osztrogon√°c.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark SVG(Circle|Path|Rect)Element::createRenderer() with OVERRIDE
rniwa@webkit.org [Wed, 26 Jun 2013 08:14:11 +0000 (08:14 +0000)]
Mark SVG(Circle|Path|Rect)Element::createRenderer() with OVERRIDE
https://bugs.webkit.org/show_bug.cgi?id=118037

Reviewed by Philip Rogers.

Merge https://chromium.googlesource.com/chromium/blink/+/e8196920e769ab0786b2b4b21d3fdc2d87afef0d.

* svg/SVGCircleElement.h:
* svg/SVGPathElement.h:
* svg/SVGRectElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdopt is/toHTMLAudioElement for code cleanup
kangil.han@samsung.com [Wed, 26 Jun 2013 07:44:01 +0000 (07:44 +0000)]
Adopt is/toHTMLAudioElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117985

Reviewed by Jer Noble.

To enhance readibility, this patch adopts is/toHTMLAudioElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

* bindings/js/JSNodeCustom.cpp:
(WebCore::isReachableFromDOM):
* css/CSSDefaultStyleSheets.cpp:
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
* html/HTMLAudioElement.h:
(WebCore::isHTMLAudioElement):
(WebCore::toHTMLAudioElement):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::mediaElement):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForVideo):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMediaMuteButton):
(WebCore::RenderThemeMac::paintMediaPlayButton):

Source/WebKit/mac:

* Plugins/WebPluginController.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactoring: Fold Document::focusedNodeRemoved into Document::removeFocusedNodeOfSubtree
rniwa@webkit.org [Wed, 26 Jun 2013 07:24:13 +0000 (07:24 +0000)]
Refactoring: Fold Document::focusedNodeRemoved into Document::removeFocusedNodeOfSubtree
https://bugs.webkit.org/show_bug.cgi?id=118036

Reviewed by Kent Tamura.

Merge https://chromium.googlesource.com/chromium/blink/+/3391beabe75548cc638a6c88982f913621a4410f.

* dom/Document.cpp:
(WebCore::Document::removeFocusedNodeOfSubtree):
* dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSString should remember AtomicString
rniwa@webkit.org [Wed, 26 Jun 2013 03:48:12 +0000 (03:48 +0000)]
JSString should remember AtomicString
https://bugs.webkit.org/show_bug.cgi?id=117386

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added JSValue::toAtomicString and JSString::atomicString. These two functions allow WebCore to update
JSString's m_value to set isAtomic flag and avoid the AtomicStringTable lookups in subsequent attempts
to obtain the AtomicString of the same value.

* runtime/JSCJSValue.h:
* runtime/JSString.h:
(JSC::JSString::atomicString):
(JSC::JSValue::toAtomicString):

Source/WebCore:

Added "Atomic" attribute as a WebKit extension to WebIDL, and deployed it in Element.idl and Node.idl so that
the binding code can use newly added JSValue::toAtomic to update JSString's m_value.

* bindings/js/JSDOMBinding.cpp:
(WebCore::valueToAtomicStringWithNullCheck): Added.
(WebCore::valueToAtomicStringWithUndefinedOrNullCheck): Added.

* bindings/js/JSDOMBinding.h:

* bindings/scripts/CodeGeneratorJS.pm:
(GetNativeTypeFromSignature): Return const AtomicString& when either Atomic attribute is specified or the type is
Reflect. Note that setAttribute and getAttribute both use AtomicString for all arguments.
(JSValueToNative): Use AtomicString equivalents when possible when converting DOMString to a WebCore object.

* bindings/scripts/IDLAttributes.txt: Added "Atomic" attribute.

* bindings/scripts/test/JS/JSTestObj.cpp: Baselined test cases.
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):

* dom/Document.idl:
* dom/Element.idl:
* dom/Node.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdopt is/toHTMLAnchorElement for code cleanup
kangil.han@samsung.com [Wed, 26 Jun 2013 01:06:00 +0000 (01:06 +0000)]
Adopt is/toHTMLAnchorElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117973

Reviewed by Andreas Kling.

To enhance readibility, this patch adopts is/toHTMLAnchorElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::anchorElement):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::internalLinkElement):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
(WebCore::AccessibilityRenderObject::isLinked):
* css/CSSDefaultStyleSheets.cpp:
(WebCore::elementCanUseSimpleDefaultStyle):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* dom/Document.cpp:
(WebCore::Document::updateBaseURL):
* dom/TreeScope.cpp:
(WebCore::TreeScope::findAnchor):
* dom/VisitedLinkState.cpp:
(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
* html/HTMLAnchorElement.h:
(WebCore::isHTMLAnchorElement):
(WebCore::toHTMLAnchorElement):
* page/DragController.cpp:
(WebCore::DragController::draggableElement):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteLinkURL):
(WebCore::HitTestResult::isLiveLink):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):

Source/WebKit/blackberry:

* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't snapshot plug-ins that come from the same host as the page
dino@apple.com [Tue, 25 Jun 2013 21:48:11 +0000 (21:48 +0000)]
Don't snapshot plug-ins that come from the same host as the page
https://bugs.webkit.org/show_bug.cgi?id=117969
<rdar://problem/12885400>

Reviewed by Tim Horton.

If a page is serving plug-in content directly, then that content
is typically very important to the page. For example, embedding
a video or audio player. In this case, don't snapshot the plug-ins.

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Add a test
that compares the plug-in's URL against the main page's URL and don't snapshot
if they are the same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded PLATFORM(WIN) to many places where it was missing for compiling WebGL for Windows.
achristensen@apple.com [Tue, 25 Jun 2013 17:45:04 +0000 (17:45 +0000)]
Added PLATFORM(WIN) to many places where it was missing for compiling WebGL for Windows.
https://bugs.webkit.org/show_bug.cgi?id=117955

Reviewed by Brent Fulgham.

* platform/graphics/GraphicsContext3D.cpp:
* platform/graphics/OpenGLShims.cpp:
* platform/graphics/cairo/GraphicsContext3DCairo.cpp: Include new location of ShaderLang.h on Windows as of r151854.
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
* platform/graphics/opengl/Extensions3DOpenGL.h:
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp: Added PLATFORM(WIN) when necessary to each file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[AX][ATK] Update accessibility baselines after r151953
commit-queue@webkit.org [Tue, 25 Jun 2013 16:16:50 +0000 (16:16 +0000)]
[AX][ATK] Update accessibility baselines after r151953
https://bugs.webkit.org/show_bug.cgi?id=117983

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-06-25
Reviewed by Chris Fleizach.

Updating aria-option-role-expected.txt for EFL and GTK after the changes in aria-option-role.html test (r151953).
Moving platform aria-checkbox-text.html to LayoutTests/accessibility. Baseline is the same for mac, gtk, efl. Windows port has it's own specific version.

* accessibility/aria-checkbox-text-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-checkbox-text-expected.txt.
* platform/efl/accessibility/aria-checkbox-text-expected.txt: Removed.
* platform/efl/accessibility/aria-option-role-expected.txt:
* platform/gtk/accessibility/aria-checkbox-text-expected.txt: Removed.
* platform/gtk/accessibility/aria-option-role-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixes a typo in renderTextDecorationFlagsToCSSValue
commit-queue@webkit.org [Tue, 25 Jun 2013 15:24:47 +0000 (15:24 +0000)]
Fixes a typo in renderTextDecorationFlagsToCSSValue
https://bugs.webkit.org/show_bug.cgi?id=117989

Patch by Bruno de Oliveira Abinader <brunoabinader@gmail.com> on 2013-06-25
Reviewed by Gyuyoung Kim.

Return value should be PassRefPtr instead of RefPtr.

Backported from Blink:
https://src.chromium.org/viewvc/blink?view=rev&revision=152994

No new tests, no behavior change.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationFlagsToCSSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, change my email address for watch list.
gyuyoung.kim@samsung.com [Tue, 25 Jun 2013 13:09:13 +0000 (13:09 +0000)]
Unreviewed, change my email address for watch list.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago"application/x-mimearchive" should be included in finding remoteWebArchive while...
commit-queue@webkit.org [Tue, 25 Jun 2013 12:57:44 +0000 (12:57 +0000)]
"application/x-mimearchive" should be included in finding remoteWebArchive while document loading
https://bugs.webkit.org/show_bug.cgi?id=117734

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-25
Reviewed by Alexey Proskuryakov.

"application/x-mimearchive" is also used  while checking for
 RemoteArchive.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::continueAfterContentPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add a script to install dependencies.
bw80.lee@samsung.com [Tue, 25 Jun 2013 11:35:54 +0000 (11:35 +0000)]
[EFL] Add a script to install dependencies.
https://bugs.webkit.org/show_bug.cgi?id=117968

Reviewed by Christophe Dumez.

Add a script which installs basic dependencies for building WebKit EFL.

The dependencies are from the current EFLWebKit wiki page.
After this patch is landed, the wiki page will be updated to use
this script.

* efl/install-dependencies: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add bug report into TestExpectations for fast/text/international/synthesized...
commit-queue@webkit.org [Tue, 25 Jun 2013 10:57:48 +0000 (10:57 +0000)]
[GTK] Add bug report into TestExpectations for fast/text/international/synthesized-italic-vertical-latin.html
https://bugs.webkit.org/show_bug.cgi?id=117976

Unreviewed gardening.

TestExpectations was missing a bug number for a skip test (http://webkit.org/b/117975).

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-06-25

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skip failing inspector test.
kadam@inf.u-szeged.hu [Tue, 25 Jun 2013 09:17:46 +0000 (09:17 +0000)]
[Qt] Unreviewed gardening. Skip failing inspector test.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHTMLMediaElement should inherit from MediaPlayerClient privately
allan.jensen@digia.com [Tue, 25 Jun 2013 09:00:16 +0000 (09:00 +0000)]
HTMLMediaElement should inherit from MediaPlayerClient privately
https://bugs.webkit.org/show_bug.cgi?id=117874

Reviewed by Andreas Kling.

Fixing FIXME: HTMLMediaElement was stuck with public inheritance from
MediaPlayerClient due to the Chromium and Qt port.

The Qt port is changed to not cast from MediaPlayerClient to HTMLMediaElement.

* html/HTMLMediaElement.h:
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::commitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChecking if frame is complete and access duration doesn't need a decode
ossy@webkit.org [Tue, 25 Jun 2013 08:44:38 +0000 (08:44 +0000)]
Checking if frame is complete and access duration doesn't need a decode
https://bugs.webkit.org/show_bug.cgi?id=116041

Reviewed by Allan Sandfeld Jensen.

This change is to avoid image decoding for these two operations:
1. frameIsCompleteAtIndex
2. frameDurationAtIndex
These two operations are moved to ImageDecoder interface and are now const
to prevent future regression.

We are now able to check if a frame is complete by parsing the entire GIF file
without decoding. This also provides information like frame duration such that
controller the animation doesn't require any decoding.

Based on the Blink patch by Hin-Chung Lam <hclam@google.com>
https://src.chromium.org/viewvc/blink?revision=149883&view=revision

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::frameIsCompleteAtIndex):
(WebCore::BitmapImage::frameDurationAtIndex):
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameHasAlphaAtIndex):
(WebCore::ImageSource::frameIsCompleteAtIndex):
* platform/graphics/ImageSource.h:
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::frameHasAlphaAtIndex):
(WebCore::ImageDecoder::frameIsCompleteAtIndex):
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::frameDurationAtIndex):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameIsCompleteAtIndex):
(WebCore::GIFImageDecoder::frameDurationAtIndex):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::gifComplete):
(WebCore::GIFImageDecoder::decode):
(WebCore::GIFImageDecoder::initFrameBuffer):
* platform/image-decoders/gif/GIFImageDecoder.h:
* platform/image-decoders/gif/GIFImageReader.h:
(GIFImageReader::frameContext):
(GIFImageReader::parseCompleted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate AbstractWorker, Worker and SharedWorker to match the specification
ch.dumez@sisa.samsung.com [Tue, 25 Jun 2013 06:28:00 +0000 (06:28 +0000)]
Update AbstractWorker, Worker and SharedWorker to match the specification
https://bugs.webkit.org/show_bug.cgi?id=117930

Reviewed by Kentaro Hara.

Update AbstractWorker, Worker and SharedWorker to match the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#abstractworker
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#worker
http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#sharedworker

Worker and SharedWorker no longer inherit from AbstractWorker. Web IDL 'implements'
statements are used instead. Worker and SharedWorker can now inherit from EventTarget
as per the specification.

No new tests, no behavior change.

* workers/AbstractWorker.idl:
* workers/SharedWorker.idl:
* workers/Worker.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDerivedSources.make should optionally include SupplementalDependencies.dep
aestes@apple.com [Tue, 25 Jun 2013 05:58:25 +0000 (05:58 +0000)]
DerivedSources.make should optionally include SupplementalDependencies.dep
https://bugs.webkit.org/show_bug.cgi?id=117972

Reviewed by Dan Bernstein.

make(1) logs a non-fatal error to stderr when an included Makefile can't
be found. This error is non-fatal because after make(1) reads in all the
Makefiles it runs the recipe for any rule that specifies one of the
Makefiles as a target. Only if the Makefile is still missing after
applying these rules does the error become fatal.

Since SupplementalDependencies.dep is generated by running a script on
SupplementalDependencies.txt, the file won't exist during clean builds.
Each time make(1) logs this non-fatal error, Xcode sees it and itself
logs a non-fatal error. This is annoying.

We don't care about this error. We only care if the recipe to generate
SupplementalDependencies.dep fails, which is already a fatal error.
Suppress the error by including SupplementalDependencies.dep optionally.

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Update font used for Chinese in test systems
dino@apple.com [Tue, 25 Jun 2013 04:23:13 +0000 (04:23 +0000)]
[Mac] Update font used for Chinese in test systems
https://bugs.webkit.org/show_bug.cgi?id=117970

Reviewed by Alexey Proskuryakov.

Add "Songti TC" and "Songti SC" to the list of allowed fonts
in DRT and WKTR.

* DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
* WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
(WTR::allowedFontFamilySet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Build correction.
bfulgham@apple.com [Tue, 25 Jun 2013 04:07:26 +0000 (04:07 +0000)]
[Mac] Build correction.

* platform/mac/accessibility/aria-tab-roles-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSilverlight triggers sandbox violations: deny network-bind 0.0.0.0:0
commit-queue@webkit.org [Tue, 25 Jun 2013 03:47:34 +0000 (03:47 +0000)]
Silverlight triggers sandbox violations: deny network-bind 0.0.0.0:0
https://bugs.webkit.org/show_bug.cgi?id=117966
<rdar://problem/13927918>

Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Sam Weinig.

Allow assigning (via bind) an ephemeral port before connecting

* Resources/PlugInSandboxProfiles/com.apple.QuickTime Plugin.plugin.sb:
* Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
* Resources/PlugInSandboxProfiles/com.microsoft.SilverlightPlugin.sb:
* Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd support for document.currentScript
kangil.han@samsung.com [Tue, 25 Jun 2013 02:38:54 +0000 (02:38 +0000)]
Add support for document.currentScript
https://bugs.webkit.org/show_bug.cgi?id=104221

Reviewed by Ryosuke Niwa.

Merge http://src.chromium.org/viewvc/blink?view=revision&revision=152230
document.currentScript reflects the script that is currently being executed.

Merge http://src.chromium.org/viewvc/blink?view=revision&revision=152237
Following up patch for code clean-up.

Source/WebCore:

Tests: fast/dom/Document/document-current-script-async.html
       fast/dom/Document/document-current-script.html

* dom/Document.cpp:
(WebCore::Document::pushCurrentScript):
(WebCore::Document::popCurrentScript):
* dom/Document.h:
(WebCore::Document::currentScript):
* dom/Document.idl:
* dom/ScriptElement.cpp:
(WebCore::isHTMLScriptElement):
(WebCore::isSVGScriptElement):
(WebCore::ScriptElement::executeScript):
(WebCore::toScriptElementIfPossible):
* html/HTMLScriptElement.h:
(WebCore::toHTMLScriptElement):
* svg/SVGScriptElement.cpp:
* svg/SVGScriptElement.h:
(WebCore::toSVGScriptElement):

LayoutTests:

* fast/dom/Document/document-current-script-async-expected.txt: Added.
* fast/dom/Document/document-current-script-async.html: Added.
* fast/dom/Document/document-current-script-expected.txt: Added.
* fast/dom/Document/document-current-script.html: Added.
* fast/dom/Document/resources/log-current-script-b.js: Added.
* fast/dom/Document/resources/log-current-script-d.js: Added.
* fast/dom/Document/resources/log-current-script-f.js: Added.
* fast/dom/Document/resources/log-current-script.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPluginProcess deny file-read-data /Network/Library under addVolumeTracker
commit-queue@webkit.org [Tue, 25 Jun 2013 02:27:32 +0000 (02:27 +0000)]
PluginProcess deny file-read-data /Network/Library under addVolumeTracker
https://bugs.webkit.org/show_bug.cgi?id=117965
<rdar://problem/14121247>

Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Silently deny reading /Network/Applications and
/Network/Library.

* Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdopt is/toHTMLFormElement for code cleanup
kangil.han@samsung.com [Tue, 25 Jun 2013 02:19:53 +0000 (02:19 +0000)]
Adopt is/toHTMLFormElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117937

Reviewed by Andreas Kling.

This refers to http://src.chromium.org/viewvc/blink?view=revision&revision=152859

To enhance readibility, this patch adopts is/toHTMLFormElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* bindings/js/JSDOMFormDataCustom.cpp:
(WebCore::toHTMLFormElement):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter):
* editing/FrameSelection.cpp:
(WebCore::scanForForm):
(WebCore::FrameSelection::currentForm):
* editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::findAssociatedForm):
* html/HTMLElement.cpp:
(WebCore::HTMLElement::findFormAncestor):
* html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::HTMLFormControlsCollection::formControlElements):
(WebCore::HTMLFormControlsCollection::formImageElements):
(WebCore::HTMLFormControlsCollection::updateNameCache):
* html/HTMLFormElement.h:
(WebCore::isHTMLFormElement):
(WebCore::toHTMLFormElement):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::insertedInto):
* html/HTMLNameCollection.cpp:
(WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatches):
* html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
* html/RadioNodeList.cpp:
(WebCore::RadioNodeList::RadioNodeList):
(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::closestFormAncestor):
* page/Frame.cpp:
(WebCore::Frame::searchForLabelsBeforeElement):

Source/WebKit/blackberry:

* WebCoreSupport/CredentialManager.cpp:
(WebCore::CredentialManager::autofillPasswordForms):

Source/WebKit/win:

* DOMCoreClasses.cpp:
(DOMElement::createInstance):
* DOMHTMLClasses.cpp:
(DOMHTMLFormElement::action):
(DOMHTMLFormElement::method):
* WebFrame.cpp:
(formElementFromDOMElement):

Source/WebKit2:

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormElements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodeny file-read-data /Library/CoreMediaIO/Plug-Ins/DAL
commit-queue@webkit.org [Tue, 25 Jun 2013 01:44:39 +0000 (01:44 +0000)]
deny file-read-data /Library/CoreMediaIO/Plug-Ins/DAL
https://bugs.webkit.org/show_bug.cgi?id=117964
<rdar://problem/14036864>

Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Permit reading of the /Library/CoreMediaIO/Plug-Ins/DAL
subdirectory.

* Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unneeded include header files from WebCore
gyuyoung.kim@samsung.com [Tue, 25 Jun 2013 01:36:30 +0000 (01:36 +0000)]
Remove unneeded include header files from WebCore
https://bugs.webkit.org/show_bug.cgi?id=117926

Reviewed by Andreas Kling.

Merge from https://chromiumcodereview.appspot.com/17388003.

Cleanup unused includes from WebCore.

* editing/CompositeEditCommand.cpp:
* editing/DeleteSelectionCommand.cpp:
* editing/EditingStyle.cpp:
* editing/Editor.cpp:
* editing/FrameSelection.cpp:
* editing/HTMLInterchange.cpp:
* editing/IndentOutdentCommand.cpp:
* editing/InsertListCommand.cpp:
* editing/InsertTextCommand.cpp:
* editing/SpellChecker.h:
* editing/VisibleUnits.cpp:
* editing/VisibleUnits.h:
* editing/markup.cpp:
* fileapi/Blob.h:
* fileapi/File.h:
* fileapi/WebKitBlobBuilder.h:
* history/HistoryItem.cpp:
* history/HistoryItem.h:
* html/BaseDateAndTimeInputType.cpp:
* html/BaseDateAndTimeInputType.h:
* html/ClassList.cpp:
* html/ClassList.h:
* html/DOMSettableTokenList.h:
* html/DOMURL.cpp:
* html/DateInputType.h:
* html/FormController.h:
* html/HTMLCanvasElement.cpp:
* html/HTMLCollection.cpp:
* html/HTMLCollection.h:
* html/HTMLDocument.h:
* html/HTMLEmbedElement.cpp:
* html/HTMLFieldSetElement.h:
* html/HTMLFormElement.cpp:
* html/HTMLFrameOwnerElement.h:
* html/HTMLIFrameElement.cpp:
* html/HTMLInputElement.cpp:
* html/HTMLLegendElement.cpp:
* html/HTMLLinkElement.h:
* html/HTMLMediaElement.cpp:
* html/HTMLMeterElement.cpp:
* html/HTMLOptionElement.cpp:
* html/HTMLOutputElement.h:
* html/HTMLPlugInImageElement.cpp:
* html/HTMLPlugInImageElement.h:
* html/HTMLProgressElement.cpp:
* html/HTMLSelectElement.cpp:
* html/HTMLTableElement.cpp:
* html/HTMLTitleElement.cpp:
* html/HTMLTrackElement.cpp:
* html/ImageInputType.h:
* html/InputType.h:
* html/MediaController.h:
* html/MediaFragmentURIParser.h:
* html/NumberInputType.cpp:
* html/RadioNodeList.h:
* html/TextFieldInputType.h:
* html/TypeAhead.cpp:
* html/ValidityState.cpp:
* html/canvas/CanvasPathMethods.h:
* html/canvas/CanvasRenderingContext2D.cpp:
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/OESVertexArrayObject.h:
* html/canvas/WebGLBuffer.cpp:
* html/canvas/WebGLBuffer.h:
* html/canvas/WebGLCompressedTextureATC.h:
* html/canvas/WebGLCompressedTextureS3TC.cpp:
* html/canvas/WebGLCompressedTextureS3TC.h:
* html/canvas/WebGLContextObject.h:
* html/canvas/WebGLDebugShaders.cpp:
* html/canvas/WebGLObject.h:
* html/canvas/WebGLProgram.h:
* html/canvas/WebGLRenderingContext.cpp:
* html/canvas/WebGLRenderingContext.h:
* html/canvas/WebGLShader.h:
* html/canvas/WebGLTexture.h:
* html/canvas/WebGLUniformLocation.h:
* html/canvas/WebGLVertexArrayObjectOES.h:
* html/parser/BackgroundHTMLParser.cpp:
* html/parser/BackgroundHTMLParser.h:
* html/parser/CSSPreloadScanner.cpp:
* html/parser/HTMLConstructionSite.cpp:
* html/parser/HTMLConstructionSite.h:
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLElementStack.h:
* html/parser/HTMLParserIdioms.cpp:
* html/parser/HTMLParserIdioms.h:
* html/parser/HTMLParserScheduler.h:
* html/parser/HTMLPreloadScanner.cpp:
* html/parser/HTMLSourceTracker.h:
* html/parser/HTMLTreeBuilder.h:
* html/parser/HTMLTreeBuilderSimulator.h:
* html/parser/XSSAuditor.cpp:
* html/parser/XSSAuditorDelegate.h:
* html/shadow/HTMLContentElement.cpp:
* html/shadow/HTMLContentElement.h:
* html/shadow/MediaControlElements.cpp:
* html/shadow/MediaControls.h:
* html/shadow/SliderThumbElement.cpp:
* html/shadow/SliderThumbElement.h:
* html/shadow/TextControlInnerElements.cpp:
* html/track/InbandTextTrack.h:
* html/track/LoadableTextTrack.cpp:
* html/track/LoadableTextTrack.h:
* html/track/TextTrackCueGeneric.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't crash if renderName() is called on a renderer with no style
simon.fraser@apple.com [Tue, 25 Jun 2013 01:28:19 +0000 (01:28 +0000)]
Don't crash if renderName() is called on a renderer with no style
https://bugs.webkit.org/show_bug.cgi?id=117960

Reviewed by Dave Hyatt.

Calling renderName() at the top of RenderObject::willChangeStyle() when
adding debug logging would often crash because various functions called
from renderName() assume style is non-null. Fix this.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::renderName):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::renderName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRepeating sandbox violations when playing Amazon Prime videos with Flash
commit-queue@webkit.org [Tue, 25 Jun 2013 01:05:20 +0000 (01:05 +0000)]
Repeating sandbox violations when playing Amazon Prime videos with Flash
https://bugs.webkit.org/show_bug.cgi?id=117953
<rdar://problem/14193693>

Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Add some missing "standard" files for network service lookups

* Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlug-in sandbox violations attempting to access com.apple.CoreGraphics.plist
commit-queue@webkit.org [Tue, 25 Jun 2013 01:03:24 +0000 (01:03 +0000)]
Plug-in sandbox violations attempting to access com.apple.CoreGraphics.plist
https://bugs.webkit.org/show_bug.cgi?id=117963
<rdar://problem/14084234>

Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Permit the reading of the com.apple.CoreGraphics preference file

* Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] media/video-played-collapse.html is flakey on certain platforms.
jer.noble@apple.com [Tue, 25 Jun 2013 00:51:14 +0000 (00:51 +0000)]
[Mac] media/video-played-collapse.html is flakey on certain platforms.
https://bugs.webkit.org/show_bug.cgi?id=117034

Reviewed by Beth Dakin.

This test does not wait until a seek completes before issuing a play()
command during its subtests. This can cause flakiness on some platforms
where playback will begin from the pre-seek currentTime. Wait for the seek
to complete before continuing the sub-tests.

Additionally, a 2s watchdog timeout is present to catch stalled tests. This
timeout is fine for short-duration sub-tests, but longer tests' durations
approach this 2s timeout period. Make the timeout the test duration + 2s.

* media/video-played-collapse-expected.txt:
* media/video-played-collapse.html:
* media/video-played.js:
(playForMillisecs.callPauseIfTimeIsReached):
(playForMillisecs):
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agocom.oracle.javadeployment.plist is not correctly specified in the JavaApplet plugin...
commit-queue@webkit.org [Tue, 25 Jun 2013 00:41:56 +0000 (00:41 +0000)]
com.oracle.javadeployment.plist is not correctly specified in the JavaApplet plugin profile
https://bugs.webkit.org/show_bug.cgi?id=117961
<rdar://problem/14223823>

Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Remove the trailing extraneous .plist from the preference file rule

* Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPluginProcess sandbox violations on com.apple.networkConnect.plist when resetting...
commit-queue@webkit.org [Tue, 25 Jun 2013 00:40:34 +0000 (00:40 +0000)]
PluginProcess sandbox violations on com.apple.networkConnect.plist when resetting Safari
https://bugs.webkit.org/show_bug.cgi?id=117958
<rdar://problem/13938149>

Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Allow reading the com.apple.networkConnect plist.

* Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJava sandbox violation ipc-posix-shm-read-data /tmp/com.apple.csseed.67
commit-queue@webkit.org [Tue, 25 Jun 2013 00:38:56 +0000 (00:38 +0000)]
Java sandbox violation ipc-posix-shm-read-data /tmp/com.apple.csseed.67
https://bugs.webkit.org/show_bug.cgi?id=117954
<rdar://problem/14166577>

Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Permit read access to this shared memory segment

* Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPlugin Sandbox violation in /Library/Audio/Sounds/Banks
commit-queue@webkit.org [Tue, 25 Jun 2013 00:37:33 +0000 (00:37 +0000)]
Plugin Sandbox violation in /Library/Audio/Sounds/Banks
https://bugs.webkit.org/show_bug.cgi?id=117957
<rdar://problem/14163582>

Patch by Simon Cooper <scooper@apple.com> on 2013-06-24
Reviewed by Alexey Proskuryakov.

Permit read access to subdirectories under /Library/Audio/Sounds

* Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWindows build links to opengl32.lib to allow WebGL compiling.
achristensen@apple.com [Tue, 25 Jun 2013 00:15:07 +0000 (00:15 +0000)]
Windows build links to opengl32.lib to allow WebGL compiling.
https://bugs.webkit.org/show_bug.cgi?id=117949

Reviewed by Brent Fulgham.

* WebKit.vcxproj/WebKit/WebKitCommon.props: Added link to opengl32.lib.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Only resume root layer commits for visible WebPages
commit-queue@webkit.org [Tue, 25 Jun 2013 00:05:47 +0000 (00:05 +0000)]
[BlackBerry] Only resume root layer commits for visible WebPages
https://bugs.webkit.org/show_bug.cgi?id=117956
https://jira.bbqnx.net/browse/BRWSR-12047
JIRA428381

Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-06-24
Reviewed by George Staikos.

In r150629, the code from that change introduced to
suspend and resume root layer commits would not take into
account whether the page is actually visible.

Because application activation state is usually conveyed
to all or any WebPages, this would mean on transitioning
into an active application state, we were resuming
root layer commits that might have previously been
disabled for visibility reasons.

Fix this by going through a single function that knows
by itself whether to suspend or resume root layer commits,
so the calling code doesn't have a chance to get it wrong.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setVisible):
(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPagePrivate::updateRootLayerCommitEnabled):
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded /d option to xcopy to prevent unnecessary copying and compiling.
achristensen@apple.com [Mon, 24 Jun 2013 23:34:46 +0000 (23:34 +0000)]
Added /d option to xcopy to prevent unnecessary copying and compiling.
https://bugs.webkit.org/show_bug.cgi?id=117951

Reviewed by Brent Fulgham.

* WebCore.vcxproj/WebCorePreBuild.cmd:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix various crashes on sites with fixed backgrounds
simon.fraser@apple.com [Mon, 24 Jun 2013 23:27:02 +0000 (23:27 +0000)]
Fix various crashes on sites with fixed backgrounds
https://bugs.webkit.org/show_bug.cgi?id=117959

Source/WebCore:

Reviewed by Andy Estes.

FrameView::removeSlowRepaintObject() would assume that addSlowRepaintObject()
had been called before it, but this isn't always the case. For example, if
a page has a fixed background on the body, this falls into the accelerated
path in WK2 tiled mode, so addSlowRepaintObject() is never called. However,
we still call removeSlowRepaintObject() if the body is removed.

So null-check m_slowRepaintObjects to avoid crashing.

Test: platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-removal.html

* page/FrameView.cpp:
(WebCore::FrameView::removeSlowRepaintObject):

LayoutTests:

Reviewed by Andy Estes.

Test that does a document.write on a page with a fixed background on the body.

* platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-removal-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-removal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake MiniBrowser paginated mode work with WebKit1
timothy_horton@apple.com [Mon, 24 Jun 2013 22:56:23 +0000 (22:56 +0000)]
Make MiniBrowser paginated mode work with WebKit1
https://bugs.webkit.org/show_bug.cgi?id=117950

Reviewed by Beth Dakin.

* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController isPaginated]):
(-[WK1BrowserWindowController togglePaginationMode:]):
Hook up isPaginated and togglePaginationMode just as for WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake sure m_iconDatabaseImpl is not null before closing it
commit-queue@webkit.org [Mon, 24 Jun 2013 22:49:30 +0000 (22:49 +0000)]
Make sure m_iconDatabaseImpl is not null before closing it
https://bugs.webkit.org/show_bug.cgi?id=117943

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-06-24
Reviewed by Simon Fraser.

Since r150474 WebIconDatabase is closed unconditionally in
TestController destructor, in that case WebKitTestRunner crashes
when no icon database path is set. This misbehavior was observed in
ports such as efl and nix.
In this patch, WebIconDatabase::close() calls m_iconDatabaseImpl->close()
only if m_iconDatabaseImpl is not null, as it's already being done in other
WebIconDatabase's methods, such as isOpen().

* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::close):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes] split test shape-inside-first-fit-001.html into 800x600 parts
hmuller@adobe.com [Mon, 24 Jun 2013 21:36:50 +0000 (21:36 +0000)]
[CSS Shapes] split test shape-inside-first-fit-001.html into 800x600 parts
https://bugs.webkit.org/show_bug.cgi?id=117939

Reviewed by Dirk Schulze.

Split the test into two parts, to ensure that it first within the 800x600 limit.

* fast/exclusions/shape-inside/shape-inside-first-fit-001-horizontal-expected.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-first-fit-001-expected.html.
* fast/exclusions/shape-inside/shape-inside-first-fit-001-horizontal.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-first-fit-001.html.
* fast/exclusions/shape-inside/shape-inside-first-fit-001-vertical-expected.html: Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-first-fit-001-expected.html.
* fast/exclusions/shape-inside/shape-inside-first-fit-001-vertical.html: Renamed from LayoutTests/fast/exclusions/shape-inside/shape-inside-first-fit-001.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agobisect-builds: improve heuristic for choosing the next build after a broken build
ddkilzer@apple.com [Mon, 24 Jun 2013 21:33:17 +0000 (21:33 +0000)]
bisect-builds: improve heuristic for choosing the next build after a broken build
<http://webkit.org/b/117918>

Reviewed by Simon Fraser.

* Scripts/bisect-builds: When a build is broken, use a heuristic
that "bisects" the left side or the right side of the remaining
revisions to pick a revision that's sufficiently different from
the revision of the broken build.  This heuristic assumes there
is a sequential range of broken builds whenever one broken build
is found.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpose the mediaHasAudio() function in WK2
commit-queue@webkit.org [Mon, 24 Jun 2013 21:32:48 +0000 (21:32 +0000)]
Expose the mediaHasAudio() function in WK2
https://bugs.webkit.org/show_bug.cgi?id=117946
<rdar://problem/14250527>

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-24
Reviewed by Beth Dakin.

Source/WebCore:

* WebCore.exp.in: Updated to include symbol for
HTMLMediaElement::mediaHasAudio() function.

Source/WebKit2:

Exposes the WebCore::HTMLMediaElement::mediaHasAudio() function
in WK2.

* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultMediaHasAudio): Added.
* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
* WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::mediaHasAudio): Added.
* WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes] Remove setCSSShapesEnabled(true) from shape-inside-empty-expected.html...
zoltan@webkit.org [Mon, 24 Jun 2013 21:28:35 +0000 (21:28 +0000)]
[CSS Shapes] Remove setCSSShapesEnabled(true) from shape-inside-empty-expected.html since it isn't using shapes
https://bugs.webkit.org/show_bug.cgi?id=117945

Reviewed by Dirk Schulze.

* fast/exclusions/shape-inside/shape-inside-empty-expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r147591): can't type in Adobe Connect
andersca@apple.com [Mon, 24 Jun 2013 21:09:06 +0000 (21:09 +0000)]
REGRESSION (r147591): can't type in Adobe Connect
https://bugs.webkit.org/show_bug.cgi?id=117947
<rdar://problem/14223539>

Reviewed by Andreas Kling.

With the change in r147591, it is now possible for a plug-in element to be focused before the plug-in
starts. Handle this by focusing the plug-in right after it's started if necessary.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove displayID stuff from Widget to Chrome
simon.fraser@apple.com [Mon, 24 Jun 2013 21:02:36 +0000 (21:02 +0000)]
Move displayID stuff from Widget to Chrome
https://bugs.webkit.org/show_bug.cgi?id=117944

Reviewed by Anders Carlsson.

In r151877 I polluted Widget with displayID-related stuff. This would
be better on HostWindow, so move it there. This is a net code reduction,
and eliminates PlatformScreenMac.h, and the NSScreen category.

Source/WebCore:

* WebCore.exp.in: Remove some functions from the exports list.
* WebCore.xcodeproj/project.pbxproj: PlatformScreenMac.h is gone!
* dom/Document.cpp:
(WebCore::Document::requestAnimationFrame): Get the displayID from page->chrome()
* page/Chrome.cpp:
(WebCore::Chrome::Chrome): Initialize m_displayID.
(WebCore::Chrome::displayID):
(WebCore::Chrome::windowScreenDidChange): Code moved from Page; save the
displayID, and tell all subframes that the displayID changed.
* page/Chrome.h: Add displayID-related functions.
* page/FrameView.cpp: Removed windowDisplayID().
* page/FrameView.h: Ditto.
* page/Page.cpp: Removed code.
(WebCore::Page::Page):
* page/Page.h:
* platform/HostWindow.h: Added virtual displayID-related functions.
* platform/Widget.cpp: Removed code.
* platform/Widget.h: Ditto.
* platform/mac/PlatformScreenMac.h: Removed.
* platform/mac/PlatformScreenMac.mm: Removed the NSScreen category.
(WebCore::displayIDFromScreen):
(WebCore::screenForDisplayID):
(WebCore::displayFromWidget):
(WebCore::screenForWidget):
* platform/mac/WidgetMac.mm: Removed windowDisplayID().
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::notifyFlushBeforeDisplayRefresh): Get
the displayID via chrome().

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView doWindowDidChangeScreen]): Go via chrome().

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowScreenDidChange): Go via chrome().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't create Document's selector query cache just to invalidate it.
akling@apple.com [Mon, 24 Jun 2013 20:52:23 +0000 (20:52 +0000)]
Don't create Document's selector query cache just to invalidate it.
<http://webkit.org/b/117942>

Reviewed by Anders Carlsson.

If Document::m_selectorQueryCache is null, there's nothing to invalidate,
so don't go through the trouble of creating a query cache.

* dom/Document.cpp:
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::updateBaseURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Make tests usable on Mac and Windows
bfulgham@apple.com [Mon, 24 Jun 2013 20:46:38 +0000 (20:46 +0000)]
AX: Make tests usable on Mac and Windows
https://bugs.webkit.org/show_bug.cgi?id=117901

Reviewed by Chris Fleizach.

* accessibility/aria-checkbox-text.html:
* accessibility/aria-hidden-expected.txt:
* accessibility/aria-hidden-with-elements-expected.txt:
* accessibility/aria-hidden-with-elements.html:
* accessibility/aria-hidden.html:
* accessibility/aria-labelledby-overrides-label-expected.txt:
* accessibility/aria-labelledby-overrides-label.html:
* accessibility/aria-option-role.html:
* accessibility/aria-presentational-role-expected.txt:
* accessibility/aria-presentational-role.html:
* accessibility/aria-tab-roles-expected.txt:
* accessibility/aria-tab-roles.html:
* accessibility/empty-image-with-title-expected.txt:
* accessibility/empty-image-with-title.html:
* accessibility/html-html-element-is-ignored-expected.txt:
* accessibility/html-html-element-is-ignored.html:
* accessibility/img-aria-button-alt-tag-expected.txt:
* accessibility/img-aria-button-alt-tag.html:
* accessibility/input-image-alt-expected.txt:
* accessibility/input-image-alt.html:
* platform/mac/accessibility/aria-checkbox-text-expected.txt:
* platform/mac/accessibility/aria-option-role-expected.txt:
* platform/win/accessibility/aria-checkbox-text-expected.txt: Added.
* platform/win/accessibility/aria-hidden-expected.txt: Added.
* platform/win/accessibility/aria-hidden-with-elements-expected.txt: Added.
* platform/win/accessibility/aria-labelledby-overrides-label-expected.txt: Added.
* platform/win/accessibility/aria-option-role-expected.txt: Added.
* platform/win/accessibility/aria-presentational-role-expected.txt: Added.
* platform/win/accessibility/aria-tab-roles-expected.txt: Added.
* platform/win/accessibility/empty-image-with-title-expected.txt: Added.
* platform/win/accessibility/html-html-element-is-ignored-expected.txt: Added.
* platform/win/accessibility/img-aria-button-alt-tag-expected.txt: Added.
* platform/win/accessibility/input-image-alt-expected.txt: Added.
* platform/win/aria-labelledby-on-input-expected.txt: Removed.
* platform/win/aria-menubar-menuitems-expected.txt: Removed.
* platform/win/aria-roles-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Makefile build fix for AppleWindows.
roger_fong@apple.com [Mon, 24 Jun 2013 20:26:55 +0000 (20:26 +0000)]
Unreviewed. Makefile build fix for AppleWindows.

* JavaScriptCore.vcxproj/JavaScriptCore.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor adding a line break
robert@webkit.org [Mon, 24 Jun 2013 20:09:20 +0000 (20:09 +0000)]
Refactor adding a line break
https://bugs.webkit.org/show_bug.cgi?id=117907

Reviewed by Ryosuke Niwa.

Reduce code duplication when adding a line break.

No new tests, refactoring.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::addLineBreak):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. AppleWin build fix, followup to r151915.
roger_fong@apple.com [Mon, 24 Jun 2013 19:53:21 +0000 (19:53 +0000)]
Unreviewed. AppleWin build fix, followup to r151915.

* WTF.vcxproj/WTFProduction.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHashMap: reverse the order of the template arguments at alternate 'find', 'contains...
mikhail.pozdnyakov@intel.com [Mon, 24 Jun 2013 19:08:32 +0000 (19:08 +0000)]
HashMap: reverse the order of the template arguments at alternate 'find', 'contains' and 'add' methods
https://bugs.webkit.org/show_bug.cgi?id=117911

Reviewed by Anders Carlsson.

The order of the template arguments at HashMap alternate 'find', 'contains' and
'add' methods is reversed so that callers can just pass the translator
and let the compiler deduce input argument type.

Another rational is consistency with HashSet class.

Source/WebCore:

* platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::get):
(WebCore::HTTPHeaderMap::contains):
(WebCore::HTTPHeaderMap::add):

Source/WTF:

* wtf/HashMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnecessary check in RenderBlockLineLayout::nextSegmentBreak()
robert@webkit.org [Mon, 24 Jun 2013 18:47:27 +0000 (18:47 +0000)]
Remove unnecessary check in RenderBlockLineLayout::nextSegmentBreak()
https://bugs.webkit.org/show_bug.cgi?id=117713

Reviewed by David Hyatt.

Changeset r151613 should have done this instead. Since r151518 changed
nextSegmentBreak() to detect line-break opportunities between no-wrap
inlines there is no need to force the break later.

No new tests, covered by existing tests.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: WebInspector.displayNameForURL() failure prevents DOM inspection
graouts@apple.com [Mon, 24 Jun 2013 18:06:24 +0000 (18:06 +0000)]
Web Inspector: WebInspector.displayNameForURL() failure prevents DOM inspection
https://bugs.webkit.org/show_bug.cgi?id=117927

Handle possible mis-encoded URI fragments passed to decodeURIComponent() which
could prevent inspection of the DOM.

Reviewed by Timothy Hatcher.

* UserInterface/Main.js:
(WebInspector.displayNameForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded a Radar number to my last ChangeLog
ggaren@apple.com [Mon, 24 Jun 2013 17:42:22 +0000 (17:42 +0000)]
Added a Radar number to my last ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPotential crash when in-band track is removed
eric.carlson@apple.com [Mon, 24 Jun 2013 17:12:07 +0000 (17:12 +0000)]
Potential crash when in-band track is removed
https://bugs.webkit.org/show_bug.cgi?id=117938
<rdar://problem/14246763>

Reviewed by Jer Noble.

This is timing dependent and I was unable to come up with a reliable test.

* html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::willRemoveTextTrackPrivate): Early return if the media element
    has been cleared.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] WTF.dll is linking with CoreFoundation.lib in VS2010.
commit-queue@webkit.org [Mon, 24 Jun 2013 16:25:28 +0000 (16:25 +0000)]
[WinCairo] WTF.dll is linking with CoreFoundation.lib in VS2010.
https://bugs.webkit.org/show_bug.cgi?id=117294

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-24
Reviewed by Brent Fulgham.

WinCairo build should not use CoreFoundation.

* WTF.vcxproj/WTFCFLite.props: Added.
* WTF.vcxproj/WTFCommon.props: Remove CoreFoundation.lib from depencency list.
* WTF.vcxproj/WTFCoreFoundation.props: Added.
* WTF.vcxproj/WTFDebug.props: Import WTFCoreFoundation.props for WinApple.
* WTF.vcxproj/WTFDebugWinCairo.props: Import WTFCFLite.props for WinCairo.
* WTF.vcxproj/WTFRelease.props: Import WTFCoreFoundation.props for WinApple.
* WTF.vcxproj/WTFReleaseWinCairo.props: Import WTFCFLite.props for WinCairo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWaveTable name has changed to PeriodicWave
crogers@google.com [Mon, 24 Jun 2013 16:21:52 +0000 (16:21 +0000)]
WaveTable name has changed to PeriodicWave
https://bugs.webkit.org/show_bug.cgi?id=117748

Reviewed by Jer Noble.

Source/WebCore:

See related Web Audio bug and spec change:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=19561
https://dvcs.w3.org/hg/audio/rev/7c4a40a9bb57

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createPeriodicWave):
* Modules/webaudio/AudioContext.h:
* Modules/webaudio/AudioContext.idl:
* Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::setType):
(WebCore::OscillatorNode::calculateSampleAccuratePhaseIncrements):
(WebCore::OscillatorNode::process):
(WebCore::OscillatorNode::setPeriodicWave):
(WebCore::OscillatorNode::propagatesSilence):
* Modules/webaudio/OscillatorNode.h:
* Modules/webaudio/OscillatorNode.idl:
* Modules/webaudio/PeriodicWave.cpp: Renamed from Source/WebCore/Modules/webaudio/WaveTable.cpp.
(WebCore::PeriodicWave::create):
(WebCore::PeriodicWave::createSine):
(WebCore::PeriodicWave::createSquare):
(WebCore::PeriodicWave::createSawtooth):
(WebCore::PeriodicWave::createTriangle):
(WebCore::PeriodicWave::PeriodicWave):
(WebCore::PeriodicWave::waveDataForFundamentalFrequency):
(WebCore::PeriodicWave::maxNumberOfPartials):
(WebCore::PeriodicWave::numberOfPartialsForRange):
(WebCore::PeriodicWave::createBandLimitedTables):
(WebCore::PeriodicWave::generateBasicWaveform):
* Modules/webaudio/PeriodicWave.h: Renamed from Source/WebCore/Modules/webaudio/WaveTable.h.
(WebCore::PeriodicWave::rateScale):
(WebCore::PeriodicWave::periodicWaveSize):
(WebCore::PeriodicWave::sampleRate):
(WebCore::PeriodicWave::numberOfRanges):
* Modules/webaudio/PeriodicWave.idl: Renamed from Source/WebCore/Modules/webaudio/WaveTable.idl.
* Target.pri:
* WebCore.xcodeproj/project.pbxproj:

Tools:

* Scripts/do-webcore-rename:

LayoutTests:

* fast/js/global-constructors-attributes-expected.txt:
* webaudio/oscillator-basic-expected.txt:
* webaudio/oscillator-basic.html:
* webaudio/oscillator-custom.html:
* webaudio/resources/oscillator-testing.js:
(generateExponentialOscillatorSweep):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Unreviewed build correction after r151868
bfulgham@apple.com [Mon, 24 Jun 2013 15:35:49 +0000 (15:35 +0000)]
[Mac] Unreviewed build correction after r151868
New test expecation had been placed in the wrong directory.

* platform/mac/accessibility/listitem-title-expected.txt: Copied from platform/mac/listitem-title-actual.txt.
* platform/mac/listitem-title-actual.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCommented IDL implements statements should not impact code generation
ch.dumez@sisa.samsung.com [Mon, 24 Jun 2013 15:14:28 +0000 (15:14 +0000)]
Commented IDL implements statements should not impact code generation
https://bugs.webkit.org/show_bug.cgi?id=117932

Reviewed by Kentaro Hara.

Fix regular expression in preprocess-idls.pl script so that commented
IDL implements statements no longer cause any code to be generated.

No new tests, covered by TestObj.idl.

* bindings/scripts/preprocess-idls.pl:
(getImplementedInterfacesFromIDL):
* bindings/scripts/test/TestObj.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdopt is/toHTMLStyleElement for minor code cleanup
kangil.han@samsung.com [Mon, 24 Jun 2013 15:12:52 +0000 (15:12 +0000)]
Adopt is/toHTMLStyleElement for minor code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117917

Reviewed by Antti Koivisto.

This patch refers to http://src.chromium.org/viewvc/blink?view=revision&revision=152853

There are some usages of static_cast to HTMLStyleElement so this patch creates toHTMLStyleElement
function for code cleanup. Plus, isHTMLStyleElement is also made for same purpose.

* css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
* css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::scopeFor):
* css/StyleSheetList.cpp:
(WebCore::StyleSheetList::getNamedItem):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
* dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
* html/HTMLStyleElement.h:
(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::inlineStyleSheetText):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCleanup RenderThemeWin after r151783 and r151794.
paroga@webkit.org [Mon, 24 Jun 2013 15:09:35 +0000 (15:09 +0000)]
Cleanup RenderThemeWin after r151783 and r151794.
https://bugs.webkit.org/show_bug.cgi?id=117936

Reviewed by Alexis Menard.

GetSysColor() takes an integer as argument. Let cssValueIdToSysColorIndex()
return an int instead of casting the values to the CSSValueID type.

* rendering/RenderThemeWin.cpp:
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWin::systemColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse SetFilePointer instead of SetFilePointerEx in FileSystemWin
paroga@webkit.org [Mon, 24 Jun 2013 14:16:42 +0000 (14:16 +0000)]
Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
https://bugs.webkit.org/show_bug.cgi?id=116205

Reviewed by Ryosuke Niwa.

SetFilePointerEx is not available on Windows CE, so use SetFilePointer.
Also add a extra return for the case of an failure.

* platform/win/FileSystemWin.cpp:
(WebCore::seekFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroduce WindowTimers IDL interface
ch.dumez@sisa.samsung.com [Mon, 24 Jun 2013 14:07:53 +0000 (14:07 +0000)]
Introduce WindowTimers IDL interface
https://bugs.webkit.org/show_bug.cgi?id=117929

Reviewed by Kentaro Hara.

Introduce WindowTimers IDL interface and have both DOMWindow and WorkerContext
implement it to match the latest specification and avoid IDL duplication:
- http://www.whatwg.org/specs/web-apps/current-work/multipage/timers.html#windowtimers
- http://dev.w3.org/html5/workers/#apis-available-to-workers

No new tests, no behavior change.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* page/DOMWindow.idl:
* page/WindowTimers.idl:
* workers/WorkerContext.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r151563.
paroga@webkit.org [Mon, 24 Jun 2013 13:58:22 +0000 (13:58 +0000)]
Build fix for WinCE after r151563.

* bindings/js/JSDOMBinding.cpp:
(WebCore::toInt8): Use fabs() instead of abs().
(WebCore::toUInt8): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r151783.
paroga@webkit.org [Mon, 24 Jun 2013 13:09:08 +0000 (13:09 +0000)]
Build fix for WinCE after r151783.

* rendering/RenderThemeWinCE.cpp:
(WebCore::cssValueIdToSysColorIndex):
(WebCore::RenderThemeWinCE::systemColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMAKE] Clear unused cmakedefines
ryuan.choi@samsung.com [Mon, 24 Jun 2013 12:31:34 +0000 (12:31 +0000)]
[CMAKE] Clear unused cmakedefines
https://bugs.webkit.org/show_bug.cgi?id=117931

Reviewed by Christophe Dumez.

* Source/cmakeconfig.h.cmake:
Removed ENABLE_AS_IMAGE, ENABLE_LEGACY_WEBKIT_BLOB_BUILDER and
ENABLE_CLIENT_BASED_GEOLOCATION cmakedefines which already removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Implement unit test callback: onWordGuesses.
commit-queue@webkit.org [Mon, 24 Jun 2013 09:38:06 +0000 (09:38 +0000)]
[EFL][WK2] Implement unit test callback: onWordGuesses.
https://bugs.webkit.org/show_bug.cgi?id=117794

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-06-24
Reviewed by Christophe Dumez.

* UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(onWordGuesses):
Add client suggestions for the word.

(checkClientSuggestionsForWord):
Verify the suggestions that were given by the client.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r151021.
commit-queue@webkit.org [Mon, 24 Jun 2013 09:32:54 +0000 (09:32 +0000)]
Unreviewed, rolling out r151021.
http://trac.webkit.org/changeset/151021
https://bugs.webkit.org/show_bug.cgi?id=117924

caused regressions on Qt and GTK (#117141 and #117688)
(Requested by philn on #webkit).

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
(webKitWebSrcFinalize):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
(StreamingClient::StreamingClient):
(StreamingClient::~StreamingClient):
(StreamingClient::didReceiveResponse):
(StreamingClient::didReceiveData):
(StreamingClient::didFinishLoading):
(StreamingClient::wasBlocked):
(StreamingClient::cannotShowURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skipping the crashing tests on debug bots.
zarvai@inf.u-szeged.hu [Mon, 24 Jun 2013 08:03:41 +0000 (08:03 +0000)]
[Qt] Unreviewed gardening. Skipping the crashing tests on debug bots.
https://bugs.webkit.org/show_bug.cgi?id=94458

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-24

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove IDL implements statements to IDL files that implement the interface
ch.dumez@sisa.samsung.com [Mon, 24 Jun 2013 07:58:35 +0000 (07:58 +0000)]
Move IDL implements statements to IDL files that implement the interface
https://bugs.webkit.org/show_bug.cgi?id=117921

Reviewed by Kentaro Hara.

Move IDL implements statements to IDL files that implement the interface
so that we can more easily know that a given IDL interface implements
another.

The generator now enforces this as well for consistency.

No new tests, covered by TestImplements.idl.

* bindings/scripts/preprocess-idls.pl:
(getImplementedInterfacesFromIDL):
* bindings/scripts/test/TestImplements.idl:
* bindings/scripts/test/TestInterface.idl:
* dom/CharacterData.idl:
* dom/ChildNode.idl:
* dom/DocumentType.idl:
* dom/Element.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHittest finds the truncated text instead of the floating input, when the input is...
commit-queue@webkit.org [Mon, 24 Jun 2013 07:32:21 +0000 (07:32 +0000)]
Hittest finds the truncated text instead of the floating input, when the input is clicked.
https://bugs.webkit.org/show_bug.cgi?id=115675

Patch by Zalan Bujtas <zalan@apple.com> on 2013-06-24
Reviewed by David Hyatt.

Ignore truncated text on inline textbox and everything beyond the ellipsis box on
the root inlinebox while hittesting. (provided that nodeAtPoint finds no hit for any of
the root inline's children.)

Source/WebCore:

Test: fast/css/text-overflow-ellipsis-and-floating-input-hittest.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):

LayoutTests:

* fast/css/text-overflow-ellipsis-and-floating-input-hittest-expected.txt: Added.
* fast/css/text-overflow-ellipsis-and-floating-input-hittest.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Rebaseline test after r151868
bfulgham@apple.com [Mon, 24 Jun 2013 06:20:34 +0000 (06:20 +0000)]
AX: Rebaseline test after r151868
https://bugs.webkit.org/show_bug.cgi?id=117892

Rubber stamped by Chris Fleizach.

* platform/mac/accessibility/lists-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening. Unskip two media tests because there is no crash after...
gyuyoung.kim@samsung.com [Mon, 24 Jun 2013 05:49:47 +0000 (05:49 +0000)]
Unreviewed EFL gardening. Unskip two media tests because there is no crash after system update.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSort all the Xcode project files
darin@apple.com [Mon, 24 Jun 2013 00:40:06 +0000 (00:40 +0000)]
Sort all the Xcode project files
https://bugs.webkit.org/show_bug.cgi?id=117696

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/ThirdParty:

* gtest/xcode/Samples/FrameworkSample/WidgetFramework.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.
* gtest/xcode/gtest.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/ThirdParty/ANGLE:

* ANGLE.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WebInspectorUI:

* WebInspectorUI.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WebKit2:

* WebKit2.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

Source/WTF:

* WTF.xcodeproj/project.pbxproj: Ran the sort-Xcode-project-file script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove redundant helper from RenderRegion.
commit-queue@webkit.org [Sun, 23 Jun 2013 06:24:15 +0000 (06:24 +0000)]
Remove redundant helper from RenderRegion.
https://bugs.webkit.org/show_bug.cgi?id=117915

Patch by Zalan Bujtas <zalan@apple.com> on 2013-06-22
Reviewed by Andreas Kling.

Minor code cleanup.

* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::regionOversetState):
(WebCore::RenderRegion::setRegionOversetState):
* rendering/RenderRegion.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add support for MHTML save/load feature to MiniBrowser
commit-queue@webkit.org [Sun, 23 Jun 2013 06:14:13 +0000 (06:14 +0000)]
[EFL] Add support for MHTML save/load feature to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=106620

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-22
Reviewed by Christophe Dumez.

Enable CTRL + S as save page in mhtml and CTRL + L to load any page
from filesystem.

* MiniBrowser/efl/CMakeLists.txt:
* MiniBrowser/efl/main.c:
(page_contents_callback):
(on_key_down):
(show_file_entry_dialog): generic function to show file enrty
selector dialogue

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSlightly reduce width threshold on detection of primary snapshotted Plug-In
dino@apple.com [Sat, 22 Jun 2013 23:33:48 +0000 (23:33 +0000)]
Slightly reduce width threshold on detection of primary snapshotted Plug-In
https://bugs.webkit.org/show_bug.cgi?id=117914
<rdar://problem/14136687>

Reviewed by Simon Fraser.

We've noticed some content that should be detected as the primary snapshotted plug-in,
but is just a bit smaller than our 450x300 minimum threshold. Reduce the width to 400.

* WebProcess/WebPage/WebPage.cpp: Change primarySnapshottedPlugInMinimumWidth from 450 to 400.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix after r151878.
mrowe@apple.com [Sat, 22 Jun 2013 23:16:42 +0000 (23:16 +0000)]
Build fix after r151878.

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::startLoading): Pass the new UseDefaultOriginRestrictionsForType
argument to the ResourceLoaderOptions constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFollowup from r151877 .
simon.fraser@apple.com [Sat, 22 Jun 2013 20:29:30 +0000 (20:29 +0000)]
Followup from r151877 .
Fix crash in fast/frames/iframe-access-screen-of-deleted.html by null-checking the widget.

* platform/mac/PlatformScreenMac.mm:
(WebCore::screenForWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes] limit shape image values to same origin
hmuller@adobe.com [Sat, 22 Jun 2013 19:56:37 +0000 (19:56 +0000)]
[CSS Shapes] limit shape image values to same origin
https://bugs.webkit.org/show_bug.cgi?id=117610

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Restrict the image URL values for shape-inside and shape-outside to
the same origin as the document. The alpha channel of image shape values
will be thresholded to produce the shape's boundaries (see bug 116643)
so normal image access rules aren't secure enough.

Added a RequestOriginPolicy ResourceLoaderOption which is used by
StyleResolver::loadPendingShapeImage() to request the additional restriction.
The change should have no other effect although it does enable one to apply
the same restriction to other resources which can currently be loaded from
any origin - see CachedResourceLoader::canRequest().

Test: http/tests/security/shape-inside-image-origin.html

* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage): Add an effectively optional ResourceLoaderOptions parameter.
* css/CSSImageValue.h:
(WebCore::CSSImageValue::cachedImage): Ditto.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingShapeImage): Load the image with the default CachedResourceLoader options plus RestrictToSameOrigin.
(WebCore::StyleResolver::loadPendingImages): Call loadPendingShapeImage().
* css/StyleResolver.h:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Update the ResourceLoaderOptions static variable.
* loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): Ditto.
* loader/ResourceLoader.h:
(WebCore::ResourceLoader::options):
* loader/ResourceLoaderOptions.h: Add RequestOriginPolicy enum.
(WebCore::ResourceLoaderOptions::ResourceLoaderOptions):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest): Pass ResourceLoaderOptions along to revised CachedResourceLoader::canRequest().
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Update load() ResourceLoaderOptions.
(WebCore::CachedResourceLoader::canRequest): Replaced ContentSecurityPolicyCheck parameter with ResourceLoaderOptions.
(WebCore::CachedResourceLoader::requestResource): Pass ResourceLoaderOptions along to revised CachedResourceLoader::canRequest().
(WebCore::CachedResourceLoader::defaultCachedResourceOptions): Added UseDefaultOriginRestrictionsForType initializer.
* loader/cache/CachedResourceLoader.h:
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading): Added UseDefaultOriginRestrictionsForType intializer.

LayoutTests:

Verify that a non same-origin image URL specified for shape-inside or
shape-outside will not load and the shape property will be reset to "none".

* http/tests/resources/square100.png: Added.
* http/tests/security/shape-inside-image-origin-expected.txt: Added.
* http/tests/security/shape-inside-image-origin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoscreen.availWidth always returns width of primary display
simon.fraser@apple.com [Sat, 22 Jun 2013 19:41:31 +0000 (19:41 +0000)]
screen.availWidth always returns width of primary display
https://bugs.webkit.org/show_bug.cgi?id=117863

Source/WebCore:

Reviewed by Geoffrey Garen.

In WebKit2, Widgets have no platformWidget, so trying to get to the
NSScreen via the platform widget's window never succeeded, and we always
fell back on getting info for the main display.

However, we were already pushing the WKView's displayID down to the
WebProcess for the requestAnimationFrame infrastructure, so use that.

Add a virtual function on Widget windowDisplayID(), that is overridden
in FrameView to return the PlatformDisplayID which Page has.

Fix PlatformScreenMac to fall back to Widget::windowDisplayID() when it fails
to get an NSWindow from the Widget.

Add a utility category on NSScreen to get an NSScreen's displayID, and to
find an NSScreen given a displayID.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* page/FrameView.cpp:
(WebCore::FrameView::windowDisplayID):
* page/FrameView.h:
* platform/Widget.cpp:
(WebCore::Widget::windowDisplayID):
* platform/Widget.h:
* platform/mac/PlatformScreenMac.h: Added.
* platform/mac/PlatformScreenMac.mm:
(+[NSScreen screenForDislayID:]):
(-[NSScreen displayID]):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
* platform/mac/WidgetMac.mm:
(WebCore::Widget::windowDisplayID):

Source/WebKit2:

Reviewed by Geoffrey Garen.

In WebKit2, Widgets have no platformWidget, so trying to get to the
NSScreen via the platform widget's window never succeeded, and we always
fell back on getting info for the main display.

However, we were already pushing the WKView's displayID down to the
WebProcess for the requestAnimationFrame infrastructure, so use that.

The WebProcess would not receive a displayID for a WKView until the window
was activated; fix by calling -doWindowDidChangeScreen when the view
moves to a window, rather than doing it from -_windowDidBecomeKey:.

* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidBecomeKey:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrashes due to NULL dereference beneath WebCore::StyleResolver::loadPendingSVGDocumen...
ggaren@apple.com [Sat, 22 Jun 2013 02:36:13 +0000 (02:36 +0000)]
Crashes due to NULL dereference beneath WebCore::StyleResolver::loadPendingSVGDocuments and related functions
https://bugs.webkit.org/show_bug.cgi?id=117903

Reviewed by Darin Adler.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingSVGDocuments): Add a NULL check for
RenderStyle here...
(WebCore::StyleResolver::loadPendingResources): ...and here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOccasional crash swiping between pages
simon.fraser@apple.com [Sat, 22 Jun 2013 01:10:24 +0000 (01:10 +0000)]
Occasional crash swiping between pages
https://bugs.webkit.org/show_bug.cgi?id=117902

Reviewed by Beth Dakin.

m_scrollingStateTree->rootStateNode() can be null when quickly swiping between pages,
so check this in ScrollingCoordinatorMac::commitTreeState().

* page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed crash protection for DRT
bfulgham@apple.com [Sat, 22 Jun 2013 00:25:55 +0000 (00:25 +0000)]
[Windows] Unreviewed crash protection for DRT

* DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
to avoid crashing during test runs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Windows] Unreviewed gardening.
bfulgham@apple.com [Sat, 22 Jun 2013 00:08:34 +0000 (00:08 +0000)]
[Windows] Unreviewed gardening.

* platform/win/accessibility/aria-menubar-menuitems-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151870 268f45cc-cd09-0410-ab3c-d52691b4dbfc