WebKit-https.git
10 years ago[Qt] Add more support for textInputController
robert@webkit.org [Sat, 24 Apr 2010 14:43:28 +0000 (14:43 +0000)]
[Qt] Add more support for textInputController

2010-04-20  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add more support for textInputController

        Add support for selectedRange(), setMarkedText(), insertText(),
        and firstRectForCharacterRange().

        Unskip tests:

        fast/forms/input-maxlength-ime-preedit.html
        fast/forms/input-maxlength-ime-completed.html
        fast/text/international/thai-cursor-position.html
        fast/events/ime-composition-events-001.html
        editing/selection/5825350-1.html
        editing/selection/5825350-2.html
        editing/selection/mixed-editability-10.html

        https://bugs.webkit.org/show_bug.cgi?id=35702

        * platform/qt/Skipped:

2010-04-20  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add more support for textInputController

        Add support for selectedRange(), setMarkedText(), insertText(),
        and firstRectForCharacterRange().

        Unskip tests:

        fast/forms/input-maxlength-ime-preedit.html
        fast/forms/input-maxlength-ime-completed.html
        fast/text/international/thai-cursor-position.html
        fast/events/ime-composition-events-001.html
        editing/selection/5825350-1.html
        editing/selection/5825350-2.html
        editing/selection/mixed-editability-10.html

        https://bugs.webkit.org/show_bug.cgi?id=35702

        * DumpRenderTree/qt/TextInputControllerQt.cpp:
        (TextInputController::setMarkedText):
        (TextInputController::insertText):
        (TextInputController::selectedRange):
        (TextInputController::firstRectForCharacterRange):
        * DumpRenderTree/qt/TextInputControllerQt.h:

2010-04-20  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add more support for textInputController

        Add support for selectedRange(), setMarkedText(), insertText(),
        and firstRectForCharacterRange().

        https://bugs.webkit.org/show_bug.cgi?id=35702

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent):
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::selectedRange):
        (DumpRenderTreeSupportQt::firstRectForCharacterRange):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 13:48:33 +0000 (13:48 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Attempt to turn the last core builder green again (not related anymore to my previous SVG checkins :-)
        Skip http/tests/media/video-play-stall-seek.html on Windows as well (just like it has been done for Mac in r58107).
        Bug https://bugs.webkit.org/show_bug.cgi?id=38000 describes the problem, and says it's ok to skip the test.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 13:37:47 +0000 (13:37 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add new results for all SVG tests that were missing on Gtk/Qt (since a while, just took the opportunity to add them now)

        * platform/gtk/svg/custom/broken-internal-references-expected.txt: Added.
        * platform/gtk/svg/custom/clip-path-id-changes-expected.txt: Added.
        * platform/qt/svg/custom/broken-internal-references-expected.txt: Added.
        * platform/qt/svg/custom/clip-path-id-changes-expected.txt: Added.
        * platform/qt/svg/custom/mask-on-multiple-objects-expected.txt: Added.
        * platform/qt/svg/custom/resource-invalidate-on-target-update-expected.txt: Added.
        * platform/qt/svg/filters/feColorMatrix-values-expected.txt: Added.
        * platform/qt/svg/filters/filter-clip-expected.txt: Added.
        * platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Added.
        * platform/qt/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 13:01:26 +0000 (13:01 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Update Qt SVG results, and a weird fast/xpath change (newline added).

        * fast/xpath/namespace-vs-predicate-expected.txt:
        * platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
        * platform/qt/svg/css/mask-with-shadow-expected.txt:
        * platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
        * platform/qt/svg/custom/pattern-excessive-malloc-expected.txt:
        * platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
        * platform/qt/svg/custom/pattern-skew-transformed-expected.txt:
        * platform/qt/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
        * platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:
        * platform/qt/svg/filters/feTile-expected.txt:
        * platform/qt/svg/text/selection-background-color-expected.txt:
        * platform/qt/svg/text/selection-styles-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 12:47:00 +0000 (12:47 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix linkage on several bots (no idea, why it worked in a from-scratch rebuild on Leopard on my machine!) -> include NodeRenderStyle.h
        Having to include NodeRenderStyle.h just to pull in the renderStyle() is a crazy concept, but I see what it tries to avoid (including RenderObject.h in Node.h)

        * rendering/SVGRenderSupport.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 12:35:44 +0000 (12:35 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix release builds, wrap resourceMode assertion in NDEBUG blocks, use UNUSED_PARAM() otherwhise.

        * rendering/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::applyResource):
        * rendering/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::applyResource):
        (WebCore::RenderSVGResourceFilter::postApplyResource):
        * rendering/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::applyResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 11:42:46 +0000 (11:42 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVGPaintServer needs to be converted to the new RenderSVGResource* system
        https://bugs.webkit.org/show_bug.cgi?id=37986

        Huge speedup for SVG painting using paint servers (gradient/patterns). Cache underlying
        WebCore::Gradient/Pattern datastructures, do not rebuild them on every painting. This marks
        the finish of the SVGResource -> RenderSVGResource transition.

        Outline of same key changes:
        - RenderSVGResource is an abstract base class now, and the previous class is now named RenderSVGResourceContainer
          All resources except RenderSVGResourceSolidColor now inherit from RenderSVGResourceContainer, as they are all
          associated with a SVG*Element class. RenderSVGResourceSolidColor inherits from RenderSVGResource, and is not
          associated with any SVG*Element class. RenderSVGResourceSolidColor is not a render tree object, despite its name.
          The reason for that is consistency with all other painting resources.
        - RenderSVGResourceSolidColor does not live in the render tree, and exists only as static object, which is shared
          and always used when filling/stroking with solid colors - just like the old SVGPaintServerSolid.
        - RenderSVGResourceGradient/RenderSVGResourcePattern now store the underlying WebCore::Gradient/Pattern object
          instead of rebuilding it everytime we're asked to paint -> this is the main difference with the old concept, leading
          to much faster speed.
        - SVGResource has vanished. All resources (clipper/filter/marker/masker/gradient/pattern) now share the same codepaths
          to handle updates and client invalidation - which is a huge benefit, and makes the code easier to understand.

        * Android.mk: Remove svg/graphics/SVGResource*, svg/graphics/SVGPaintServer.h from build.
        * GNUmakefile.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * platform/graphics/Gradient.cpp: Add addColorStop() method taking a ColorStop const-reference.
        (WebCore::Gradient::addColorStop):
        * platform/graphics/Gradient.h: Ditto.
        * platform/graphics/TextRun.h: Rename SVGPaintServer to RenderSVGResource
        (WebCore::TextRun::TextRun):
        (WebCore::TextRun::activePaintingResource): Renamed from activePaintServer.
        (WebCore::TextRun::setActivePaintingResource): Renamed from setActivePaintServer.
        * platform/graphics/win/GraphicsContextWin.cpp: Remove references to SVGResourceImage, which was removed a long time ago.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::toRenderSVGResourceContainer): Renamed from toRenderSVGResource().
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isSVGGradientStop): Added.
        (WebCore::RenderObject::isSVGResourceContainer): Renamed from isSVGResource().
        * rendering/RenderPath.cpp: Utilize RenderSVGResource::fill/strokePaintingResource to request paint servers, instead of SVGPaintServer.
        (WebCore::RenderPath::fillContains): Adapt to new concept.
        (WebCore::RenderPath::strokeContains): Ditto.
        (WebCore::fillAndStrokePath): Ditto.
        (WebCore::RenderPath::paint): Ditto.
        * rendering/RenderSVGGradientStop.cpp:
        (WebCore::RenderSVGGradientStop::styleDidChange): Ditto.
        * rendering/RenderSVGGradientStop.h: Fixed indention.
        * rendering/RenderSVGResource.cpp: Refactored old SVGPaintServer code to request fill/stroke painting resources, splitted up in several methods to aid readability.
        (WebCore::registerPendingResource):
        (WebCore::adjustColorForPseudoRules):
        (WebCore::RenderSVGResource::fillPaintingResource):
        (WebCore::RenderSVGResource::strokePaintingResource):
        (WebCore::RenderSVGResource::sharedSolidPaintingResource):
        (WebCore::RenderSVGResource::markForLayoutAndResourceInvalidation):
        * rendering/RenderSVGResource.h: Make RenderSVGResource an abstract base class, see above for the reasoning.
        (WebCore::RenderSVGResource::RenderSVGResource):
        (WebCore::RenderSVGResource::~RenderSVGResource):
        (WebCore::RenderSVGResource::postApplyResource):
        * rendering/RenderSVGResourceClipper.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
        (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper):
        (WebCore::RenderSVGResourceClipper::invalidateClient):
        (WebCore::RenderSVGResourceClipper::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters)
        (WebCore::RenderSVGResourceClipper::applyClippingToContext):
        * rendering/RenderSVGResourceClipper.h:
        * rendering/RenderSVGResourceContainer.h: Added. Renamed from RenderSVGResource. Now inherits from RenderSVGHiddenContainer and RenderSVGResource.
        (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
        (WebCore::RenderSVGResourceContainer::~RenderSVGResourceContainer):
        (WebCore::RenderSVGResourceContainer::idChanged):
        (WebCore::RenderSVGResourceContainer::isSVGResourceContainer):
        (WebCore::RenderSVGResourceContainer::drawsContents):
        (WebCore::RenderSVGResourceContainer::toRenderSVGResourceContainer):
        (WebCore::getRenderSVGResourceContainerById):
        (WebCore::getRenderSVGResourceById):
        * rendering/RenderSVGResourceFilter.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
        (WebCore::RenderSVGResourceFilter::RenderSVGResourceFilter):
        (WebCore::RenderSVGResourceFilter::invalidateClient):
        (WebCore::RenderSVGResourceFilter::applyResource): Adapt to signature changes (add RenderStyle* and resource mode parameters)
        (WebCore::RenderSVGResourceFilter::postApplyResource):
        * rendering/RenderSVGResourceFilter.h:
        * rendering/RenderSVGResourceGradient.cpp: Moved from SVGPaintServerGradient, cleaned up and refactored.
        (WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
        (WebCore::RenderSVGResourceGradient::~RenderSVGResourceGradient):
        (WebCore::RenderSVGResourceGradient::invalidateClients):
        (WebCore::RenderSVGResourceGradient::invalidateClient):
        (WebCore::createMaskAndSwapContextForTextGradient):
        (WebCore::clipToTextMask):
        (WebCore::RenderSVGResourceGradient::applyResource):
        * rendering/RenderSVGResourceGradient.h:
        (WebCore::RenderSVGResourceGradient::resourceBoundingBox):
        * rendering/RenderSVGResourceLinearGradient.cpp: Moved from SVGPaintServerLinearGradient, cleaned up and refactored.
        (WebCore::RenderSVGResourceLinearGradient::RenderSVGResourceLinearGradient):
        (WebCore::RenderSVGResourceLinearGradient::~RenderSVGResourceLinearGradient):
        (WebCore::RenderSVGResourceLinearGradient::buildGradient):
        * rendering/RenderSVGResourceLinearGradient.h:
        (WebCore::RenderSVGResourceLinearGradient::renderName):
        (WebCore::RenderSVGResourceLinearGradient::resourceType):
        * rendering/RenderSVGResourceMarker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
        (WebCore::RenderSVGResourceMarker::RenderSVGResourceMarker):
        (WebCore::RenderSVGResourceMarker::invalidateClient):
        * rendering/RenderSVGResourceMarker.h:
        (WebCore::RenderSVGResourceMarker::applyResource):
        * rendering/RenderSVGResourceMasker.cpp: Inherit from RenderSVGResourceContainer instead of RenderSVGResource.
        (WebCore::RenderSVGResourceMasker::RenderSVGResourceMasker):
        (WebCore::RenderSVGResourceMasker::invalidateClient):
        (WebCore::RenderSVGResourceMasker::applyResource):
        * rendering/RenderSVGResourceMasker.h:
        (WebCore::MaskerData::MaskerData):
        * rendering/RenderSVGResourcePattern.cpp: Moved from SVGPaintServerPattern, cleaned up and refactored.
        (WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern):
        (WebCore::RenderSVGResourcePattern::~RenderSVGResourcePattern):
        (WebCore::RenderSVGResourcePattern::invalidateClients):
        (WebCore::RenderSVGResourcePattern::invalidateClient):
        (WebCore::RenderSVGResourcePattern::applyResource):
        (WebCore::RenderSVGResourcePattern::postApplyResource):
        (WebCore::calculatePatternBoundaries):
        (WebCore::RenderSVGResourcePattern::calculatePatternBoundariesIncludingOverflow):
        (WebCore::RenderSVGResourcePattern::createTileImage):
        (WebCore::RenderSVGResourcePattern::buildPattern):
        * rendering/RenderSVGResourcePattern.h:
        (WebCore::RenderSVGResourcePattern::renderName):
        (WebCore::RenderSVGResourcePattern::resourceBoundingBox):
        (WebCore::RenderSVGResourcePattern::resourceType):
        * rendering/RenderSVGResourceRadialGradient.cpp: Moved from SVGPaintServerRadialGradient, cleaned up and refactored.
        (WebCore::RenderSVGResourceRadialGradient::RenderSVGResourceRadialGradient):
        (WebCore::RenderSVGResourceRadialGradient::~RenderSVGResourceRadialGradient):
        (WebCore::RenderSVGResourceRadialGradient::buildGradient):
        * rendering/RenderSVGResourceRadialGradient.h:
        (WebCore::RenderSVGResourceRadialGradient::renderName):
        (WebCore::RenderSVGResourceRadialGradient::resourceType):
        * rendering/RenderSVGResourceSolidColor.cpp: Moved from SVGPaintServerSolid, cleaned up and refactored.
        (WebCore::RenderSVGResourceSolidColor::RenderSVGResourceSolidColor):
        (WebCore::RenderSVGResourceSolidColor::~RenderSVGResourceSolidColor):
        (WebCore::RenderSVGResourceSolidColor::applyResource):
        (WebCore::RenderSVGResourceSolidColor::postApplyResource):
        * rendering/RenderSVGResourceSolidColor.h:
        (WebCore::RenderSVGResourceSolidColor::invalidateClients):
        (WebCore::RenderSVGResourceSolidColor::invalidateClient):
        (WebCore::RenderSVGResourceSolidColor::resourceBoundingBox):
        (WebCore::RenderSVGResourceSolidColor::resourceType):
        (WebCore::RenderSVGResourceSolidColor::color):
        (WebCore::RenderSVGResourceSolidColor::setColor):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::paint): Early exit if painting is disabled.
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write): Add RenderSVGGradientStop dumping.
        (WebCore::externalRepresentation): Remove SVGResource dumping.
        * rendering/SVGInlineTextBox.cpp: Adapt to SVGPaintServer changes (paint server request).
        (WebCore::SVGInlineTextBox::paintCharacters):
        (WebCore::SVGInlineTextBox::paintDecoration):
        * rendering/SVGInlineTextBox.h: Ditto.
        (WebCore::SVGTextPaintInfo::SVGTextPaintInfo):
        * rendering/SVGRenderSupport.cpp: Ditto.
        (WebCore::SVGRenderBase::prepareToRenderSVGContent):
        (WebCore::SVGRenderBase::finishRenderSVGContent):
        (WebCore::invalidatePaintingResource):
        (WebCore::deregisterFromResources):
        (WebCore::dashArrayFromRenderingStyle): Moved here from SVGPaintServer.
        (WebCore::applyStrokeStyleToContext): Ditto.
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRenderTreeAsText.cpp: Add new gradient/pattern dumping code. Stops are now properly dumped as well!
        (WebCore::operator<<):
        (WebCore::writeSVGPaintingResource):
        (WebCore::writeStyle):
        (WebCore::boundingBoxModeString):
        (WebCore::writeCommonGradientProperties):
        (WebCore::writeSVGResourceContainer):
        (WebCore::writeSVGGradientStop):
        * rendering/SVGRenderTreeAsText.h:
        * rendering/SVGRootInlineBox.cpp: Adapt to SVGPaintServer changes (paint server request).
        (WebCore::SVGRootInlineBoxPaintWalker::SVGRootInlineBoxPaintWalker):
        (WebCore::SVGRootInlineBoxPaintWalker::~SVGRootInlineBoxPaintWalker):
        (WebCore::SVGRootInlineBoxPaintWalker::teardownFillPaintServer):
        (WebCore::SVGRootInlineBoxPaintWalker::teardownStrokePaintServer):
        (WebCore::SVGRootInlineBoxPaintWalker::setupBackground):
        (WebCore::SVGRootInlineBoxPaintWalker::setupFill):
        (WebCore::SVGRootInlineBoxPaintWalker::setupFillSelection):
        (WebCore::SVGRootInlineBoxPaintWalker::setupStroke):
        (WebCore::SVGRootInlineBoxPaintWalker::setupStrokeSelection):
        (WebCore::SVGRootInlineBoxPaintWalker::setupForeground):
        (WebCore::SVGRootInlineBoxPaintWalker::activePaintingResource):
        (WebCore::SVGRootInlineBoxPaintWalker::paintChunk):
        * svg/GradientAttributes.h: Remove SVGGradientStop, use Gradient::ColorStop vector. Cleanup.
        (WebCore::GradientAttributes::stops):
        (WebCore::GradientAttributes::setStops):
        * svg/LinearGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
        * svg/PatternAttributes.h: Add missing includes and class forwards.
        * svg/RadialGradientAttributes.h: Move ENABLE(SVG) guard to correct location.
        * svg/SVGClipPathElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
        (WebCore::SVGClipPathElement::svgAttributeChanged):
        (WebCore::SVGClipPathElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
        * svg/SVGClipPathElement.h:
        * svg/SVGDocumentExtensions.cpp: Change HashMaps to hash AtomicStrings instead of Strings. Rename RenderSVGResource to RenderSVGResourceContainer.
        (WebCore::SVGDocumentExtensions::addResource):
        (WebCore::SVGDocumentExtensions::removeResource):
        (WebCore::SVGDocumentExtensions::resourceById):
        (WebCore::SVGDocumentExtensions::addPendingResource):
        * svg/SVGDocumentExtensions.h:
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::insertedIntoDocument): Remove reference to SVGResource::invalidateClients(), handled differently now.
        (WebCore::SVGElement::updateAnimatedSVGAttribute): Change assertion, that is incorrect now.
        * svg/SVGElement.h: Make updateAnimatedSVGAttribute() public.
        * svg/SVGFont.cpp: Adapt to SVGPaintServer changes (paint server request).
        (WebCore::Font::drawTextUsingSVGFont):
        * svg/SVGGElement.cpp: If style()->display() is NONE, create a RenderSVGHiddenContainer, removing hacks in SVGStopElement for pservers-grad-19-b.svg (yes, SVG is crazy.)
        (WebCore::SVGGElement::createRenderer):
        * svg/SVGGElement.h: Remove childrenChanged() method which _always_ called renderer->setNeedsLayout(true), which is completly wrong and unnecessary.
        (WebCore::SVGGElement::rendererIsNeeded): Always return true.
        * svg/SVGGradientElement.cpp: Adapt to new RenderSVGResourceGradient code.
        (WebCore::SVGGradientElement::svgAttributeChanged):
        (WebCore::SVGGradientElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
        (WebCore::SVGGradientElement::buildStops):
        * svg/SVGGradientElement.h:
        * svg/SVGLinearGradientElement.cpp: Adapt to new RenderSVGResourceLinearGradient code.
        (WebCore::SVGLinearGradientElement::svgAttributeChanged):
        (WebCore::SVGLinearGradientElement::createRenderer):
        (WebCore::SVGLinearGradientElement::collectGradientProperties):
        (WebCore::SVGLinearGradientElement::calculateStartEndPoints):
        * svg/SVGLinearGradientElement.h:
        * svg/SVGMarkerElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
        (WebCore::SVGMarkerElement::svgAttributeChanged):
        (WebCore::SVGMarkerElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
        (WebCore::SVGMarkerElement::setOrientToAuto):
        (WebCore::SVGMarkerElement::setOrientToAngle):
        * svg/SVGMaskElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
        (WebCore::SVGMaskElement::svgAttributeChanged):
        (WebCore::SVGMaskElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
        * svg/SVGPatternElement.cpp: Rename invalidateCanvasResources() to invalidateResourceClients().
        (WebCore::SVGPatternElement::svgAttributeChanged):
        (WebCore::SVGPatternElement::childrenChanged): Only call invalidateResourceClients() when !changedByParser is set.
        (WebCore::SVGPatternElement::createRenderer):
        * svg/SVGPatternElement.h:
        * svg/SVGPolyElement.h: Remove unneded rendererIsNeeded() override.
        * svg/SVGRadialGradientElement.cpp: Adapt to new RenderSVGResourceRadialGradient code.
        (WebCore::SVGRadialGradientElement::svgAttributeChanged):
        (WebCore::SVGRadialGradientElement::createRenderer):
        (WebCore::SVGRadialGradientElement::collectGradientProperties):
        (WebCore::SVGRadialGradientElement::calculateFocalCenterPointsAndRadius):
        * svg/SVGRadialGradientElement.h:
        * svg/SVGStopElement.cpp: Clean up code, moved stop color calculation from SVGGradientElement to here, where it belongs.
        (WebCore::SVGStopElement::parseMappedAttribute):
        (WebCore::SVGStopElement::stopColorIncludingOpacity):
        * svg/SVGStopElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::~SVGStyledElement):
        (WebCore::SVGStyledElement::svgAttributeChanged): Only invalidateResourcesInAncestorChain()/deregisterFromResources() when we're not parsing.
        (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain): Early exit if we find a parent resources, there is no resource nesting.
        (WebCore::SVGStyledElement::invalidateResourceClients): Renamed from invalidateCanvasResources()
        (WebCore::SVGStyledElement::childrenChanged): Only invalidate SVGElementInstances when !changedByParser is set.
        * svg/SVGStyledElement.h: Remove canvasResource() logic, remove detach() method.
        * svg/SVGTextPathElement.h:
        * svg/graphics/SVGPaintServer.h: Removed.
        * svg/graphics/SVGResource.cpp: Removed.
        * svg/graphics/SVGResource.h: Removed.
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        SVGPaintServer needs to be converted to the new RenderSVGResource* system
        https://bugs.webkit.org/show_bug.cgi?id=37986

        Rebaseline SVG tests, after the RenderSVGResource transition.

        NOTE: This WILL affect _any_ platform with custom svg results for tests using gradients/patterns.
              That means I have to wait for the bot results, and update them ASAP. Therefore landing out
              of california business hours and on the weekend - please stay tuned I'll fix any breakages soon.
              (Except for chromium whose test results are not available on build.webkit.org, sorry.)

        * platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
        * platform/mac/svg/batik/filters/feTile-expected.txt:
        * platform/mac/svg/batik/masking/maskRegions-expected.txt:
        * platform/mac/svg/batik/paints/gradientLimit-expected.txt:
        * platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
        * platform/mac/svg/batik/paints/patternRegionA-expected.txt:
        * platform/mac/svg/batik/paints/patternRegions-expected.txt:
        * platform/mac/svg/batik/text/textEffect-expected.txt:
        * platform/mac/svg/batik/text/textEffect2-expected.txt:
        * platform/mac/svg/batik/text/textEffect3-expected.txt:
        * platform/mac/svg/batik/text/textProperties-expected.txt:
        * platform/mac/svg/carto.net/colourpicker-expected.txt:
        * platform/mac/svg/carto.net/tabgroup-expected.txt:
        * platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt:
        * platform/mac/svg/css/mask-with-shadow-expected.txt:
        * platform/mac/svg/custom/broken-internal-references-expected.txt:
        * platform/mac/svg/custom/deep-dynamic-updates-expected.txt:
        * platform/mac/svg/custom/dominant-baseline-hanging-expected.checksum:
        * platform/mac/svg/custom/dominant-baseline-hanging-expected.png:
        * platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
        * platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
        * platform/mac/svg/custom/fill-fallback-expected.txt:
        * platform/mac/svg/custom/gradient-add-stops-expected.txt:
        * platform/mac/svg/custom/gradient-attr-update-expected.txt:
        * platform/mac/svg/custom/gradient-cycle-detection-expected.txt:
        * platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
        * platform/mac/svg/custom/gradient-rotated-bbox-expected.txt:
        * platform/mac/svg/custom/gradient-stop-corner-cases-expected.txt:
        * platform/mac/svg/custom/gradient-stop-style-change-expected.txt:
        * platform/mac/svg/custom/gradient-stroke-width-expected.checksum:
        * platform/mac/svg/custom/gradient-stroke-width-expected.png:
        * platform/mac/svg/custom/gradient-stroke-width-expected.txt:
        * platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
        * platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
        * platform/mac/svg/custom/group-opacity-expected.txt:
        * platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
        * platform/mac/svg/custom/invalid-css-expected.txt:
        * platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
        * platform/mac/svg/custom/js-late-gradient-creation-expected.txt:
        * platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
        * platform/mac/svg/custom/js-late-pattern-creation-expected.txt:
        * platform/mac/svg/custom/js-update-gradient-expected.checksum:
        * platform/mac/svg/custom/js-update-gradient-expected.png:
        * platform/mac/svg/custom/js-update-gradient-expected.txt:
        * platform/mac/svg/custom/js-update-pattern-child-expected.txt:
        * platform/mac/svg/custom/js-update-pattern-expected.txt:
        * platform/mac/svg/custom/js-update-stop-expected.txt:
        * platform/mac/svg/custom/large-bounding-box-percents-expected.txt:
        * platform/mac/svg/custom/pattern-cycle-detection-expected.txt:
        * platform/mac/svg/custom/pattern-deep-referencing-expected.txt:
        * platform/mac/svg/custom/pattern-excessive-malloc-expected.txt:
        * platform/mac/svg/custom/pattern-in-defs-expected.txt:
        * platform/mac/svg/custom/pattern-rotate-expected.txt:
        * platform/mac/svg/custom/pattern-size-bigger-than-target-size-expected.txt:
        * platform/mac/svg/custom/pattern-skew-transformed-expected.txt:
        * platform/mac/svg/custom/pattern-with-transformation-expected.txt:
        * platform/mac/svg/custom/pattern-y-offset-expected.txt:
        * platform/mac/svg/custom/resource-client-removal-expected.txt:
        * platform/mac/svg/custom/stroke-fallback-expected.txt:
        * platform/mac/svg/custom/stroked-pattern-expected.txt:
        * platform/mac/svg/custom/text-gradient-no-content-expected.txt:
        * platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
        * platform/mac/svg/custom/use-recalcStyle-crash-expected.txt:
        * platform/mac/svg/filters/big-sized-filter-expected.txt:
        * platform/mac/svg/filters/feDisplacementMap-expected.txt:
        * platform/mac/svg/filters/feTile-expected.txt:
        * platform/mac/svg/filters/filterRes-expected.txt:
        * platform/mac/svg/hixie/error/003-expected.txt:
        * platform/mac/svg/hixie/perf/005-expected.txt:
        * platform/mac/svg/hixie/perf/006-expected.txt:
        * platform/mac/svg/text/selection-background-color-expected.txt:
        * platform/mac/svg/text/selection-styles-expected.txt:
        * platform/mac/svg/text/text-gradient-positioning-expected.txt:
        * platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
        * platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
        * platform/win/svg/custom/broken-internal-references-expected.txt:
        * svg/custom/gradient-with-1d-boundingbox-expected.txt:
        * svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-24 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 24 Apr 2010 10:29:00 +0000 (10:29 +0000)]
2010-04-24  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Add win specific result for svg/custom/broken-internal-references.svg
        It's a bad idea that textPath dumps FLT_MAX when it's not shown - that should be fixed, but it's not related to Moritas testcase.

        * platform/win/svg/custom/broken-internal-references-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 24 Apr 2010 07:03:24 +0000 (07:03 +0000)]
2010-04-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        check-webkit-style complains about non-utf8 data in layout test result
        https://bugs.webkit.org/show_bug.cgi?id=38027

        The problem was we were assuming patch files/diff output as utf-8.
        Turns out they're not.  We have to treat them as binary data because
        a single patch may have multiple text files in it with conflicting encodings!

        * Scripts/webkitpy/common/checkout/api.py:
         - contents_at_revision returns a byte array, so decode it to unicode
           before passing it to parse_latest_entry_from_file
        * Scripts/webkitpy/common/checkout/api_unittest.py:
         - Update our mock mock_contents_at_revision to match the encoding
           semantics of the real one.
        * Scripts/webkitpy/common/checkout/scm.py:
         - Be careful not to decode output which may contain file contents
           (like diff, cat or show) as the encoding for that content is unknown.
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
         - Update our tests to use both latin1 and utf-8 encoded data.
        * Scripts/webkitpy/common/net/bugzilla.py:
         - _fill_attachment_form should not assume unicode data.  Callers
           may wish to attach other types of files to bugs.
        * Scripts/webkitpy/common/prettypatch.py:
         - Diffs are byte arrays, deal with them as such.
        * Scripts/webkitpy/common/prettypatch_unittest.py:
         - Test to make sure we handle diffs with multiple conflicting encodings.
        * Scripts/webkitpy/common/system/executive_unittest.py:
         - Make sure that our unicode support does not break our
           byte array input support for run_command.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Sat, 24 Apr 2010 05:17:18 +0000 (05:17 +0000)]
2010-04-23  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Fisher.

        Add isGLES2Compliant to GraphicsContext3D: make the method const.
        https://bugs.webkit.org/show_bug.cgi?id=37872

        * platform/graphics/GraphicsContext3D.h: Make isGLES2Compliant() const.
        * platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto.
        (WebCore::GraphicsContext3D::isGLES2Compliant):
2010-04-23  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Fisher.

        Add isGLES2Compliant to GraphicsContext3D: make the method const.
        https://bugs.webkit.org/show_bug.cgi?id=37872

        * src/GraphicsContext3D.cpp: Make isGLES2Compliant() const.
        (WebCore::GraphicsContext3DInternal::isGLES2Compliant):
        (WebCore::GraphicsContext3D::isGLES2Compliant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Ben Murdoch <benm@google.com>
eric@webkit.org [Sat, 24 Apr 2010 03:36:47 +0000 (03:36 +0000)]
2010-04-23  Ben Murdoch  <benm@google.com>

        Reviewed by Jeremy Orlow.

        [Android] The touchmove delta used in basic-single-touch-events.html is too small for Android
        https://bugs.webkit.org/show_bug.cgi?id=38056

        * fast/events/touch/basic-single-touch-events-expected.txt:
            - update the test expected output
        * fast/events/touch/script-tests/basic-single-touch-events.js:
        (verifyTouch): update test expectation with new coordinates.
        (singleTouchSequence): increase the touch move delta.
        (touchTargets): Start the touch at a different point to
                 singleTouchSequence to make examining behavior easier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Qi Zhang <qi.2.zhang@nokia.com>
eric@webkit.org [Sat, 24 Apr 2010 03:27:37 +0000 (03:27 +0000)]
2010-04-23  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
        https://bugs.webkit.org/show_bug.cgi?id=37276

        pointInPath.html passed because the expected.txt expect it fail, it is wrong.

        * platform/qt/fast/canvas/pointInPath-expected.txt: Removed.
2010-04-23  Qi Zhang  <qi.2.zhang@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] LayoutTests/fast/canvas/pointInPath.html passed, actually it failed
        https://bugs.webkit.org/show_bug.cgi?id=37276

        QPainterPath::contains doesn't count the point on the bound.

        * platform/graphics/qt/PathQt.cpp:
        (WebCore::isPointOnPathBorder):
        (WebCore::Path::contains):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38060
weinig@apple.com [Sat, 24 Apr 2010 01:07:37 +0000 (01:07 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38060
Split up Threading.h

Reviewed by David Levin.

JavaScriptCore:

Move bits for of Threading.h into 3 new files.
- Atomics.h for atomic operations.
- ThreadSafeShared.h for the ThreadSafeShared class.
- ThreadingPrimitives.h for the primitives and platform types.

Basic threading operations (creation, etc.) remain in Threading.h.

* GNUmakefile.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/Atomics.h: Copied from wtf/Threading.h.
* wtf/ThreadSafeShared.h: Copied from wtf/Threading.h.
* wtf/Threading.h:
* wtf/ThreadingPrimitives.h: Copied from wtf/Threading.h.

JavaScriptGlue:

Add necessary forwarding headers.

* ForwardingHeaders/wtf/Atomics.h: Added.
* ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
* ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.

WebCore:

Add necessary forwarding headers.

* ForwardingHeaders/wtf/Atomics.h: Added.
* ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
* ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.

WebKitTools:

Add necessary forwarding headers.

* DumpRenderTree/ForwardingHeaders/wtf/Atomics.h: Added.
* DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Added.
* DumpRenderTree/ForwardingHeaders/wtf/ThreadingPrimitives.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Rafael Weinstein <rafaelw@grafaelw.sfo.corp.google.com>
eric@webkit.org [Sat, 24 Apr 2010 01:05:02 +0000 (01:05 +0000)]
2010-04-23  Rafael Weinstein  <rafaelw@grafaelw.sfo.corp.google.com>

        Reviewed by Darin Fisher.

        This patch adds a vector of additionalFeatures to WindowFeatures
        and populates it with any feature strings that evaluate to "yes"
        and aren't directly observed in WindowFeatures. This allows
        clients to capture experimental window features.

        https://bugs.webkit.org/show_bug.cgi?id=38013

        * page/WindowFeatures.cpp:
        (WebCore::WindowFeatures::setWindowFeature):
        * page/WindowFeatures.h:
2010-04-23  Rafael Weinstein  <rafaelw@grafaelw.sfo.corp.google.com>

        Reviewed by Darin Fisher.

        This patch adds a WebWindowFeatures binding struct for the
        chromium client in anticipation of a follow-on patch which will
        pass it to WebViewClient::createWindow.

        https://bugs.webkit.org/show_bug.cgi?id=38013

        * public/WebViewClient.h:
        (WebKit::WebViewClient::createView):
        * public/WebWindowFeatures.h: Added.
        (WebKit::WebWindowFeatures::WebWindowFeatures):
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Sat, 24 Apr 2010 00:54:14 +0000 (00:54 +0000)]
2010-04-23  Xiaomei Ji  <xji@chromium.org>

        No need to review.

        Add xji as committer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 24 Apr 2010 00:48:57 +0000 (00:48 +0000)]
2010-04-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        ASSERT(willBeComposited == needsToBeComposited(layer)); on gmail.com
        https://bugs.webkit.org/show_bug.cgi?id=38066

        When a layer goes into compositing mode because it has a negative z-index child that is going
        into compositing mode, then set willBeComposited to true. Also add another assertion to catch
        any other cases where the state of willBeComposited is mismanaged.

        Test: compositing/composited-negative-zindex-child.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::computeCompositingRequirements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 24 Apr 2010 00:48:51 +0000 (00:48 +0000)]
2010-04-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        <rdar://problem/7894489> When printing Flash, send a drawRect event, rather than NPPrint

        When printing Flash plug-ins in 32-bit, send a drawRect event with a CGContextRef, rather than calling
        NPPrint with a GWorldPtr, since Flash prefers the CGContext path.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView drawRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7898436> :after content is duplicated
mitz@apple.com [Sat, 24 Apr 2010 00:16:30 +0000 (00:16 +0000)]
<rdar://problem/7898436> :after content is duplicated

Reviewed by Simon Fraser.

WebCore:

Test: fast/css-generated-content/after-duplicated-after-split.html

* rendering/RenderInline.cpp:
(WebCore::RenderInline::splitInlines): Pass the correct owner of the child list.

LayoutTests:

* fast/css-generated-content/after-duplicated-after-split.html: Added.
* platform/mac/fast/css-generated-content/after-duplicated-after-split-expected.checksum: Added.
* platform/mac/fast/css-generated-content/after-duplicated-after-split-expected.png: Added.
* platform/mac/fast/css-generated-content/after-duplicated-after-split-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Build fix, add platform stub for new LayoutTestController method.
kevino@webkit.org [Sat, 24 Apr 2010 00:12:35 +0000 (00:12 +0000)]
[wx] Build fix, add platform stub for new LayoutTestController method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=38065
weinig@apple.com [Sat, 24 Apr 2010 00:02:16 +0000 (00:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=38065
Merge mac and win DrawingAreaProxyUpdateChunk implementations.

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
* UIProcess/DrawingAreaProxy.cpp: Copied from UIProcess/mac/DrawingAreaProxy.mm.
* UIProcess/DrawingAreaProxy.h: Copied from UIProcess/mac/DrawingAreaProxy.h.
* UIProcess/DrawingAreaProxyUpdateChunk.cpp: Copied from UIProcess/mac/DrawingAreaProxyUpdateChunk.mm.
(WebKit::DrawingAreaProxyUpdateChunk::DrawingAreaProxyUpdateChunk):
(WebKit::DrawingAreaProxyUpdateChunk::paint):
(WebKit::DrawingAreaProxyUpdateChunk::setSize):
(WebKit::DrawingAreaProxyUpdateChunk::didSetSize):
(WebKit::DrawingAreaProxyUpdateChunk::update):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
* UIProcess/DrawingAreaProxyUpdateChunk.h: Copied from UIProcess/mac/DrawingAreaProxyUpdateChunk.h.
* UIProcess/mac/DrawingAreaProxy.h: Removed.
* UIProcess/mac/DrawingAreaProxy.mm: Removed.
* UIProcess/mac/DrawingAreaProxyUpdateChunk.h: Removed.
* UIProcess/mac/DrawingAreaProxyUpdateChunk.mm: Removed.
* UIProcess/mac/DrawingAreaProxyUpdateChunkMac.mm: Copied from UIProcess/mac/DrawingAreaProxyUpdateChunk.mm.
(WebKit::DrawingAreaProxyUpdateChunk::page):
(WebKit::DrawingAreaProxyUpdateChunk::invalidateBackingStore):
(WebKit::DrawingAreaProxyUpdateChunk::platformPaint):
(WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):
* UIProcess/win/DrawingAreaProxy.cpp: Removed.
* UIProcess/win/DrawingAreaProxy.h: Removed.
* UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp: Copied from UIProcess/win/DrawingAreaProxy.cpp.
(WebKit::DrawingAreaProxyUpdateChunk::page):
(WebKit::DrawingAreaProxyUpdateChunk::ensureBackingStore):
(WebKit::DrawingAreaProxyUpdateChunk::invalidateBackingStore):
(WebKit::DrawingAreaProxyUpdateChunk::platformPaint):
(WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::onPaintEvent):
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Fri, 23 Apr 2010 23:50:28 +0000 (23:50 +0000)]
2010-04-23  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Eric Seidel

        QT does not support textInputController.firstRectForCharacterRange(),
        so, skip editing/inserting/caret-position.html for QT.
        https://bugs.webkit.org/show_bug.cgi?id=25319

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixing the Tiger build for real.
adele@apple.com [Fri, 23 Apr 2010 23:21:36 +0000 (23:21 +0000)]
Fixing the Tiger build for real.

* platform/graphics/mac/SimpleFontDataMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixing the Tiger build.
adele@apple.com [Fri, 23 Apr 2010 23:08:26 +0000 (23:08 +0000)]
Fixing the Tiger build.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformBoundsForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 23 Apr 2010 22:31:58 +0000 (22:31 +0000)]
2010-04-23  MORITA Hajime  <morrita@google.com>

        Not reviewed. Added missing expectation files for
        https://bugs.webkit.org/show_bug.cgi?id=37187

        * platform/mac/svg/custom/broken-internal-references-expected.checksum: Added.
        * platform/mac/svg/custom/broken-internal-references-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd FileError for File API.
jianli@chromium.org [Fri, 23 Apr 2010 22:20:24 +0000 (22:20 +0000)]
Add FileError for File API.
https://bugs.webkit.org/show_bug.cgi?id=37840

Reviewed by Dmitry Titov.

The test will be added when implementing FileReader and FilerWriter.

* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ExceptionCode.h:
(WebCore::):
* html/FileError.h: Added.
* html/FileError.idl: Added.
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImprove code generator scripts to handle OR ('|') condition in the
jianli@chromium.org [Fri, 23 Apr 2010 22:20:11 +0000 (22:20 +0000)]
Improve code generator scripts to handle OR ('|') condition in the
extended attributes.
https://bugs.webkit.org/show_bug.cgi?id=37998

Reviewed by Adam Barth.

* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/scripts/IDLStructure.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing...
adele@apple.com [Fri, 23 Apr 2010 22:16:27 +0000 (22:16 +0000)]
Fix for <rdar://problem/7855777> REGRESSION: Memory usage increase caused by storing glyph bounds in GlyphMetricsMap
https://bugs.webkit.org/show_bug.cgi?id=37936

Reviewed by Dan Bernstein.

This change breaks the GlyphMetricsMap into two maps - one for width and one for bounds, so that we don't store
a FloatRect for the glyph bounds unless we need to.

Covered by existing tests.  This should not cause any change in functionality.

Updated for removal of GlyphMetricsMap.cpp
* Android.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

Made GlyphMetricsMap a template, so it can be used for separate width and bounds maps.
* platform/graphics/GlyphMetricsMap.cpp: Removed.
* platform/graphics/GlyphMetricsMap.h:
(WebCore::GlyphMetricsMap::metricsForGlyph):
(WebCore::GlyphMetricsMap::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::metricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForGlyph):
(WebCore::GlyphMetricsMap::GlyphMetricsPage::setMetricsForIndex):
(WebCore::::unknownMetrics):
(WebCore::::locatePageSlowCase):

* platform/graphics/mac/ComplexTextController.cpp: (WebCore::ComplexTextController::adjustGlyphsAndAdvances):
Call boundsForGlyph instead of metricsForGlyph.
* platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::shapeAndPlaceItem):
ditto.
* platform/graphics/SimpleFontData.cpp: (WebCore::SimpleFontData::platformGlyphInit):
Call setMetricsForGlyph for both glyph maps.

Break getters and setters for metricsForGlyph into widthForGlyph and boundsForGlyph, maintaining present behavior.
* platform/graphics/SimpleFontData.h:
(WebCore::):
(WebCore::SimpleFontData::boundsForGlyph):
(WebCore::SimpleFontData::widthForGlyph):
* platform/graphics/cairo/SimpleFontDataCairo.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/gtk/SimpleFontDataPango.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
* platform/graphics/win/SimpleFontDataCairoWin.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::boundsForGDIGlyph):
(WebCore::SimpleFontData::widthForGDIGlyph):
* platform/graphics/wince/SimpleFontDataWince.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
* platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Fri, 23 Apr 2010 22:07:46 +0000 (22:07 +0000)]
2010-04-23  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein and Darin Adler

        Fix issue "caret does not paint after type in characters in right
        aligned div or after delete all characters in RTL div or
        0px right padding RTL textarea"
        https://bugs.webkit.org/show_bug.cgi?id=25319

        Test: editing/inserting/caret-position.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::localCaretRect):
2010-04-23  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein and Darin Adler

        Fix issue "caret does not paint after type in characters in right
        aligned div or after delete all characters in RTL div or
        0px right padding RTL textarea"
        https://bugs.webkit.org/show_bug.cgi?id=25319

        * editing/inserting/caret-position-expected.txt: Added.
        * editing/inserting/caret-position.html: Added.
        * platform/mac/editing/input/caret-primary-bidi-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 No'am Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Fri, 23 Apr 2010 22:02:16 +0000 (22:02 +0000)]
2010-04-23  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [Performance] GraphicsLayer: constructing the layers takes too long
        https://bugs.webkit.org/show_bug.cgi?id=36365

        The issue came from using QGraphicsView's cache as is. The problem is that
        several code-paths require re-rendering of the item, but not re-rendering
        of the web content into the cache.

        The way to solve it is by having GraphicsLayerQt manage the cache directly
        via QPixmapCache, instead of using QGraphicsItem cache modes.

        FPS measurement shows significant improvement (20FPS before, 40FPS after)
        on several use-cases, including blog-files/leaves on a desktop environment.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
        (WebCore::GraphicsLayerQtImpl::recache):
        (WebCore::GraphicsLayerQtImpl::paint):
        (WebCore::GraphicsLayerQtImpl::flushChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38059
weinig@apple.com [Fri, 23 Apr 2010 21:58:10 +0000 (21:58 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38059
Merge mac and win DrawingAreaUpdateChunk implementation.

Reviewed by Anders Carlsson.

* UIProcess/win/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::didSetSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):
* UIProcess/win/DrawingAreaProxy.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/DrawingAreaUpdateChunk.cpp: Copied from WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp.
(WebKit::DrawingAreaUpdateChunk::setSize):
* WebProcess/WebPage/DrawingAreaUpdateChunk.h: Copied from WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h.
* WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp: Removed.
* WebProcess/WebPage/mac/DrawingAreaUpdateChunk.h: Removed.
* WebProcess/WebPage/mac/DrawingAreaUpdateChunkMac.cpp: Copied from WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp.
* WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp: Removed.
* WebProcess/WebPage/win/DrawingAreaUpdateChunk.h: Removed.
* WebProcess/WebPage/win/DrawingAreaUpdateChunkWin.cpp: Copied from WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp.
(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 23 Apr 2010 21:13:32 +0000 (21:13 +0000)]
2010-04-23  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        Avoid marking symbols as dllexport in chromium win builds
        https://bugs.webkit.org/show_bug.cgi?id=38058

        No new tests.

        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 23 Apr 2010 20:39:38 +0000 (20:39 +0000)]
2010-04-23  MORITA Hajime  <morrita@google.com>

        Reviewed by Nikolas Zimmermann.

        https://bugs.webkit.org/show_bug.cgi?id=37187
        SVG <use href="foo"> is interpreted as <use href="#foo">

        getTarget() did return url parameter as is if doesn't have
        fragment identifier. So fixed to return empty string in such case
        because we need to distinguish "yyy.html" from "xxx.svg#yyy.html".

        Test: svg/custom/broken-internal-references.svg

        * svg/SVGElement.cpp:
        (WebCore::SVGElement::insertedIntoDocument):
        * svg/SVGURIReference.cpp:
        (WebCore::SVGURIReference::getTarget):
2010-04-23  MORITA Hajime  <morrita@google.com>

        Reviewed by Nikolas Zimmermann.

        https://bugs.webkit.org/show_bug.cgi?id=37187
        SVG <use href="foo"> is interpreted as <use href="#foo">

        * platform/mac/svg/custom/broken-internal-references-expected.checksum: Added.
        * platform/mac/svg/custom/broken-internal-references-expected.png: Added.
        * platform/mac/svg/custom/broken-internal-references-expected.txt: Added.
        * svg/custom/broken-internal-references.svg: Added.
        * svg/dynamic-updates/SVGTRefElement-dom-href-attr-expected.txt:
        * svg/dynamic-updates/script-tests/SVGTRefElement-dom-href-attr.js:
        (executeTest): Updated to follow this fix. href value should be an URL, not an id.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 23 Apr 2010 20:22:22 +0000 (20:22 +0000)]
2010-04-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        When webkitAnimationEnd event fires, on-screen rendering should show the last frame of animation
        https://bugs.webkit.org/show_bug.cgi?id=37955

        After r37484, animation and transition end events were fired on a timer, after the animation/transition
        ended. This opened up one event loop cycle in which the non-animating state of the element was visible
        before the event fired, resulting in flashes in content that reset style from the event handler.

        Fix by firing these events in the same event cycle as the animation end, once all animations
        have been updated. This also required moving the place that start animations are fixed until
        a later state in the state machine, so that animations have their start time set at the point
        the event is fired (to avoid an assertion when using the freeze API in DRT).

        Not testable, since the flash is very transitory and cannot be captured in a pixel test.

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::updateStateMachine): Move the firing of 'start' events into the state
        where the start time is known.
        * page/animation/AnimationControllerPrivate.h:
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired): Call the new fireEventsAndUpdateStyle()
        method.
        (WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): New method to share code that used to be in
        updateStyleIfNeededDispatcherFired().
        (WebCore::AnimationControllerPrivate::animationTimerFired): Call fireEventsAndUpdateStyle() once we've
        processed all animations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 23 Apr 2010 20:22:17 +0000 (20:22 +0000)]
2010-04-23  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        CompositeAnimation::updateKeyframeAnimations() can make a KeyframeAnimation for animation "none"
        https://bugs.webkit.org/show_bug.cgi?id=38017

        Check to see if the animation name is "none", and don't fire off a keyframe animation in
        that case.

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::updateKeyframeAnimations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove an assert. (It's not valid when resizing).
andersca@apple.com [Fri, 23 Apr 2010 20:10:25 +0000 (20:10 +0000)]
Remove an assert. (It's not valid when resizing).

Reviewed by Sam Weinig.

* WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::didUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-19 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 23 Apr 2010 19:43:12 +0000 (19:43 +0000)]
2010-04-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        new-run-webkit-tests: add a "--retry-failures" flag and a
        "--no-retry-failures" flag (the former is the default). Also, rename
        "--print-unexpected-results" and "--retry-unexpected-results" to
        "--print-last-failures" and "--retry-last-failures" because the
        retry flag was confusing. The new flag names aren't great, but
        hopefully they're less confusing.

        https://bugs.webkit.org/show_bug.cgi?id=37838

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Adam Langley <agl@chromium.org>
agl@chromium.org [Fri, 23 Apr 2010 19:35:17 +0000 (19:35 +0000)]
2010-04-23  Adam Langley  <agl@chromium.org>

        Unreviewed, expectations update.

        Merging Skia r526 lead to a number of pixels changing color by 1 in
        layout tests. This is the rebaseline for Windows and Linux. (Mac isn't
        using Skia for this.)

        * platform/chromium-linux/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum:
        * platform/chromium-linux/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png:
        * platform/chromium-linux/css2.1/t0804-c5509-padn-l-03-f-g-expected.checksum:
        * platform/chromium-linux/css2.1/t0804-c5509-padn-l-03-f-g-expected.png:
        * platform/chromium-linux/fast/dom/Window/btoa-pnglet-expected.checksum:
        * platform/chromium-linux/fast/dom/Window/btoa-pnglet-expected.png:
        * platform/chromium-linux/fast/replaced/image-solid-color-with-alpha-expected.checksum:
        * platform/chromium-linux/fast/replaced/image-solid-color-with-alpha-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug10565-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug10633-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug10633-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug14323-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug16012-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug20804-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug20804-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug4427-expected.png:
        * platform/chromium-linux/tables/mozilla/bugs/bug4803-expected.checksum:
        * platform/chromium-linux/tables/mozilla/bugs/bug4803-expected.png:
        * platform/chromium-win/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum:
        * platform/chromium-win/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png:
        * platform/chromium-win/css2.1/t0804-c5509-padn-l-03-f-g-expected.checksum:
        * platform/chromium-win/css2.1/t0804-c5509-padn-l-03-f-g-expected.png:
        * platform/chromium-win/fast/dom/Window/btoa-pnglet-expected.checksum:
        * platform/chromium-win/fast/dom/Window/btoa-pnglet-expected.png:
        * platform/chromium-win/fast/replaced/image-solid-color-with-alpha-expected.checksum:
        * platform/chromium-win/fast/replaced/image-solid-color-with-alpha-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug10565-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug10565-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug10633-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug10633-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug14323-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug14323-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug16012-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug16012-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug20804-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug20804-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug4427-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug4427-expected.png:
        * platform/chromium-win/tables/mozilla/bugs/bug4803-expected.checksum:
        * platform/chromium-win/tables/mozilla/bugs/bug4803-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Qt build.
weinig@apple.com [Fri, 23 Apr 2010 19:11:21 +0000 (19:11 +0000)]
Fix Qt build.

* wtf/qt/MainThreadQt.cpp: #include <QThread>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
andersca@apple.com [Fri, 23 Apr 2010 19:01:17 +0000 (19:01 +0000)]
Fix build.

* UIProcess/win/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::paint):
(WebKit::DrawingAreaProxy::setSize):
(WebKit::DrawingAreaProxy::didReceiveMessage):
* WebProcess/WebPage/win/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38022
weinig@apple.com [Fri, 23 Apr 2010 18:59:56 +0000 (18:59 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38022
Move isMainThread predicate function to MainThread.h

Reviewed by Anders Carlsson.

JavaScriptCore:

* wtf/MainThread.cpp:
(WTF::initializeMainThread):
(WTF::isMainThread):
* wtf/MainThread.h:
* wtf/Threading.h:
* wtf/ThreadingPthreads.cpp:
(WTF::initializeThreading):
* wtf/ThreadingWin.cpp:
(WTF::initializeThreading):
* wtf/gtk/ThreadingGtk.cpp:
(WTF::initializeThreading):
* wtf/mac/MainThreadMac.mm:
(WTF::initializeMainThreadPlatform):
(WTF::isMainThread):
* wtf/qt/MainThreadQt.cpp:
(WTF::isMainThread):
* wtf/qt/ThreadingQt.cpp:
(WTF::initializeThreading):
* wtf/text/AtomicString.cpp:

JavaScriptGlue:

Added forwarding header for MainThread.h

* ForwardingHeaders/wtf/MainThread.h: Added.

WebKitTools:

Added forwarding header for MainThread.h

* DumpRenderTree/ForwardingHeaders/wtf/MainThread.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Fri, 23 Apr 2010 18:31:37 +0000 (18:31 +0000)]
2010-04-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Disable Netscape plugin support for minimal configuration
        https://bugs.webkit.org/show_bug.cgi?id=38026

        No new tests, as there is no new functionality.

        * WebCore.pri:
2010-04-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Disable Netscape plugin support for minimal configuration
        https://bugs.webkit.org/show_bug.cgi?id=38026

        Pass the minimal configuration option to Qt build system
        as part of the CONFIG variable.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 23 Apr 2010 17:33:19 +0000 (17:33 +0000)]
2010-04-23  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Need borderAndPadding(Width|Height)
        https://bugs.webkit.org/show_bug.cgi?id=38046

        Refactoring only, so no new tests.

        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::height):
        * rendering/RenderApplet.cpp:
        (WebCore::RenderApplet::createWidgetIfNecessary):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isSelfCollapsingBlock):
        (WebCore::RenderBlock::calcPrefWidths):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcBorderBoxWidth):
        (WebCore::RenderBox::calcBorderBoxHeight):
        (WebCore::RenderBox::calcContentBoxWidth):
        (WebCore::RenderBox::calcContentBoxHeight):
        (WebCore::RenderBox::calcWidth):
        (WebCore::RenderBox::calcHeight):
        (WebCore::RenderBox::calcPercentageHeight):
        (WebCore::RenderBox::calcReplacedHeightUsing):
        (WebCore::RenderBox::availableHeightUsing):
        (WebCore::RenderBox::calcAbsoluteHorizontal):
        (WebCore::RenderBox::calcAbsoluteVertical):
        (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
        (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
        (WebCore::RenderBox::positionForPoint):
        * rendering/RenderBoxModelObject.h:
        (WebCore::RenderBoxModelObject::borderAndPaddingHeight):
        (WebCore::RenderBoxModelObject::borderAndPaddingWidth):
        * rendering/RenderDataGrid.cpp:
        (WebCore::RenderDataGrid::calcPrefWidths):
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::calcPrefWidths):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::calcPrefWidths):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::calcPrefWidths):
        (WebCore::RenderFlexibleBox::allowedChildFlex):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::calcPrefWidths):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::resize):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::calcPrefWidths):
        (WebCore::RenderListBox::calcHeight):
        * rendering/RenderMenuList.cpp:
        (WebCore::RenderMenuList::calcPrefWidths):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::calcPrefWidths):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::calcPrefWidths):
        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::calcPrefWidths):
        (WebCore::RenderSlider::layout):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::styleOrColWidth):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::textBlockHeight):
        (WebCore::RenderTextControl::textBlockWidth):
        (WebCore::RenderTextControl::calcHeight):
        (WebCore::RenderTextControl::calcPrefWidths):
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::layout):
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::updateWidgetPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSize mismatch between format string and argument in dumpTextEncodingNameMap()
ddkilzer@apple.com [Fri, 23 Apr 2010 17:18:10 +0000 (17:18 +0000)]
Size mismatch between format string and argument in dumpTextEncodingNameMap()

Reviewed by Darin Adler.

See Bug 38030 and r58157.

* platform/text/TextEncodingRegistry.cpp:
(WebCore::dumpTextEncodingNameMap): Assigned
textEncodingNameMap->size() to an unsigned variable before using
it in the fprintf() statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBUILD FIX: Attempt to fix Windows build after Bug 36187 landed in r58168
ddkilzer@apple.com [Fri, 23 Apr 2010 17:00:39 +0000 (17:00 +0000)]
BUILD FIX: Attempt to fix Windows build after Bug 36187 landed in r58168

* DerivedSources.cpp: Changed include of JSMedia.cpp to
JSStyleMedia.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBUILD FIX: Fix Mac build after Bug 36187 landed in r58168
ddkilzer@apple.com [Fri, 23 Apr 2010 16:47:33 +0000 (16:47 +0000)]
BUILD FIX: Fix Mac build after Bug 36187 landed in r58168

* WebCore.xcodeproj/project.pbxproj: Renamed DOMMedia.h,
DOMMedia.mm, DOMMediaInternal.h to DOMStyleMedia.h,
DOMStyleMedia.mm, DOMStyleMediaInternal.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix.
kenneth@webkit.org [Fri, 23 Apr 2010 16:33:40 +0000 (16:33 +0000)]
Unreviewed build fix.

Change Media to StyleMedia

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed layout fix.
kenneth@webkit.org [Fri, 23 Apr 2010 16:28:26 +0000 (16:28 +0000)]
Unreviewed layout fix.

Change [object Media] to [object StyleMedia]

* platform/qt/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch WebKit.idl to force a rebuild.
kenneth@webkit.org [Fri, 23 Apr 2010 16:24:40 +0000 (16:24 +0000)]
Touch WebKit.idl to force a rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed layout fix.
kenneth@webkit.org [Fri, 23 Apr 2010 16:15:54 +0000 (16:15 +0000)]
Unreviewed layout fix.

Change [object Media] to [object StyleMedia]

* fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 23 Apr 2010 16:08:32 +0000 (16:08 +0000)]
2010-04-23  Xan Lopez  <xlopez@igalia.com>

        Try to fix the GTK+ bots.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Rename window.media to window.styleMedia
kenneth@webkit.org [Fri, 23 Apr 2010 15:42:12 +0000 (15:42 +0000)]
WebCore: Rename window.media to window.styleMedia
https://bugs.webkit.org/show_bug.cgi?id=36187

Reviewed by Laszlo Gombos.

Rename the interface Media to StyleMedia as required by the
new CSSOM View spec.

* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/Media.cpp: Removed.
* css/Media.h: Removed.
* css/Media.idl: Removed.
* css/StyleMedia.cpp: Added.
(WebCore::StyleMedia::StyleMedia):
(WebCore::StyleMedia::type):
(WebCore::StyleMedia::matchMedium):
* css/StyleMedia.h: Added.
(WebCore::StyleMedia::create):
(WebCore::StyleMedia::disconnectFrame):
* css/StyleMedia.idl: Added.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::styleMedia):
* page/DOMWindow.h:
(WebCore::DOMWindow::optionalMedia):
* page/DOMWindow.idl:

LayoutTests: Updated test results as the interface Media was renamed
to StyleMedia.

Reviewed by NOBODY (OOPS!).

* fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
eric@webkit.org [Fri, 23 Apr 2010 15:38:43 +0000 (15:38 +0000)]
2010-04-23  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>

        Reviewed by Laszlo Gombos.

        Add RVCT support for Linux

        Developed in cooperation with Gabor Loki.

        * API/JSStringRef.h:
        * jit/ExecutableAllocator.h:
        * jit/ExecutableAllocatorPosix.cpp:
        (JSC::ExecutableAllocator::cacheFlush):
        * jit/JITStubs.cpp:
        * wtf/MathExtras.h:
        * wtf/unicode/qt4/UnicodeQt4.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 23 Apr 2010 15:02:02 +0000 (15:02 +0000)]
2010-04-23  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: provide JSC implementation for scopeType method on
        call frame and use same jsvascript code for JSC and v8 when collecting
        scope chain data.

        https://bugs.webkit.org/show_bug.cgi?id=37663

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::currentCallFrame):
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        (WebCore::JSJavaScriptCallFrame::scopeType):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
        * inspector/InjectedScriptHost.idl:
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Fri, 23 Apr 2010 14:59:41 +0000 (14:59 +0000)]
2010-04-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Laszlo Gombos.

        [WIN] Move OwnPtrWin.cpp into platform specific folder.
        https://bugs.webkit.org/show_bug.cgi?id=38042

        * JavaScriptCore.gypi:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * wtf/OwnPtrWin.cpp: Removed.
        * wtf/win/OwnPtrWin.cpp: Copied from JavaScriptCore/wtf/OwnPtrWin.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Fri, 23 Apr 2010 14:45:30 +0000 (14:45 +0000)]
2010-04-23  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Laszlo Gombos.

        [BREWMP] Move OwnPtrBrew.cpp into platform specific folder.
        https://bugs.webkit.org/show_bug.cgi?id=38042

        * wtf/OwnPtrBrew.cpp: Removed.
        * wtf/brew/OwnPtrBrew.cpp: Copied from JavaScriptCore/wtf/OwnPtrBrew.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Fri, 23 Apr 2010 13:05:03 +0000 (13:05 +0000)]
2010-04-23  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Audits (Image Dimensions): full image URLs are prefixed with the hosting page name
        https://bugs.webkit.org/show_bug.cgi?id=37988

        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Fri, 23 Apr 2010 09:51:34 +0000 (09:51 +0000)]
2010-04-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: Flaky Inspector tests.
        https://bugs.webkit.org/show_bug.cgi?id=36217

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didCommitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Fri, 23 Apr 2010 09:42:01 +0000 (09:42 +0000)]
2010-04-23  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Adam Barth.

        Auto-generate WebGLRenderingContext overloads in V8
        https://bugs.webkit.org/show_bug.cgi?id=37818

        * fast/canvas/webgl/script-tests/texImageTest.js: Test was wrong: Passing 0 value for a WebGLArray argument in texImage2D should throw the same exception as when passed to textSubImage2D.
        * platform/chromium-mac/fast/canvas/webgl/texImageTest-expected.txt:
        * fast/canvas/webgl/texImageTest-expected.txt: Changes to reflect test.
2010-04-23  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Adam Barth.

        Auto-generate WebGLRenderingContext overloads in V8
        https://bugs.webkit.org/show_bug.cgi?id=37818

        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        * html/canvas/WebGLRenderingContext.cpp: Added missing overloads for the following:.
        (WebCore::WebGLRenderingContext::texImage2D)
        (WebCore::WebGLRenderingContext::texSubImage2D)
        * html/canvas/WebGLRenderingContext.h: Added missing overloads.
        * html/canvas/WebGLRenderingContext.idl: IDL definition of overloads.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Jeff Schiller <codedread@gmail.com>
eric@webkit.org [Fri, 23 Apr 2010 09:31:53 +0000 (09:31 +0000)]
2010-04-23  Jeff Schiller  <codedread@gmail.com>

        Reviewed by Nikolas Zimmermann.

        Display tooltips when hovering over SVG elements, Bug 16854
        https://bugs.webkit.org/show_bug.cgi?id=16854

        Manual test added for verifying tooltips.

        * manual-tests/svg-tooltip.svg: Added.
        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::title): xlink:title takes precedence, otherwise SVGStyledElement::title() is used
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::title): checks for a shadow parent and uses that title, otherwise uses the content's title
        * svg/SVGStyledElement.h: add title() method declaration

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-23 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Fri, 23 Apr 2010 08:43:08 +0000 (08:43 +0000)]
2010-04-23  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed, Chromium test expectation change.

        Change expectation of fast/url/file-http-base.html for Chromium to TEXT.
        https://bugs.webkit.org/show_bug.cgi?id=38038

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/38032> No need to content sniff 304 responses
ddkilzer@apple.com [Fri, 23 Apr 2010 08:23:50 +0000 (08:23 +0000)]
<webkit.org/b/38032> No need to content sniff 304 responses
<rdar://problem/7891726>

Reviewed by Brady Eidson.

* platform/network/mac/ResourceHandleMac.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
No need to adjust the MIME type on 304 responses since they're
only used to determine if the resource needs to be refetched.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/38030> Add WebCore::dumpTextEncodingNameMap() to dump text encod...
ddkilzer@apple.com [Fri, 23 Apr 2010 08:05:09 +0000 (08:05 +0000)]
<webkit.org/b/38030> Add WebCore::dumpTextEncodingNameMap() to dump text encoding map on debug builds

Reviewed by Alexey Proskuryakov.

* platform/text/TextEncodingRegistry.cpp:
(WebCore::dumpTextEncodingNameMap): Added.
* platform/text/TextEncodingRegistry.h:
(WebCore::dumpTextEncodingNameMap): Added declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/38029> +[WebTextIteratorPrivate initialize] is missing call...
ddkilzer@apple.com [Fri, 23 Apr 2010 07:36:59 +0000 (07:36 +0000)]
<webkit.org/b/38029> +[WebTextIteratorPrivate initialize] is missing call to JSC::initializeThreading()

Reviewed by Timothy Hatcher.

Every other Objective-C class that calls
WebCoreObjCFinalizeOnMainThread(self) in +initialize also calls
JSC::initializeThreading().  The WebTextIteratorPrivate class
was the only one missing this call.

* WebView/WebTextIterator.mm:
(+[WebTextIteratorPrivate initialize]): Added call to
JSC::initializeThreading().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch WebKit.idl to force a rebuild.
aestes@apple.com [Fri, 23 Apr 2010 07:18:42 +0000 (07:18 +0000)]
Touch WebKit.idl to force a rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out http://trac.webkit.org/changeset/55385.
aestes@apple.com [Fri, 23 Apr 2010 07:14:07 +0000 (07:14 +0000)]
Roll out http://trac.webkit.org/changeset/55385.

Rubber stamped by Steve Falkenburg.

<rdar://problem/7884444>

* Interfaces/IWebUIDelegatePrivate.idl:
* Interfaces/WebKit.idl:
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 23 Apr 2010 07:04:31 +0000 (07:04 +0000)]
2010-04-22  Tony Chang  <tony@chromium.org>

        Reviewed by Dan Bernstein.

        Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
        https://bugs.webkit.org/show_bug.cgi?id=37950

        * editing/text-iterator/rtl-selection-crash-expected.txt: Added.
        * editing/text-iterator/rtl-selection-crash.html: Added.
2010-04-22  Tony Chang  <tony@chromium.org>

        Reviewed by Dan Bernstein.

        Crash in WebCore::TextIterator::handleTextNode() encountered in Google rich-text products
        https://bugs.webkit.org/show_bug.cgi?id=37950

        Test: editing/text-iterator/rtl-selection-crash.html

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::handleTextNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 23 Apr 2010 07:00:21 +0000 (07:00 +0000)]
2010-04-22  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Add a test for file URL canonicalization with an http base
        https://bugs.webkit.org/show_bug.cgi?id=38035

        * fast/url/file-http-base-expected.txt: Added.
        * fast/url/file-http-base.html: Added.
        * fast/url/script-tests/file-http-base.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix up my immediately previous ChangeLogs.
mjs@apple.com [Fri, 23 Apr 2010 05:59:17 +0000 (05:59 +0000)]
Fix up my immediately previous ChangeLogs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 23 Apr 2010 05:47:06 +0000 (05:47 +0000)]
2010-04-22  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Links around blocks (e.g. divs) results in too many VoiceOver call outs
        https://bugs.webkit.org/show_bug.cgi?id=37079

        The basic change is to modify the AccessibilityRenderObject tree
        traversal methods to account for inline continuations in the
        render tree and make the accessibility tree look as if
        continuations didn't exist - the same as if CSS blocks could just
        sit in CSS inlines. This is slightly tricky code but creates a
        much saner accessibility tree.

        Tests: accessibility/image-link-inline-cont.html
               accessibility/image-link.html
               accessibility/inline-continuations.html

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::isInlineWithContinuation): Helper function for traversal functions to use in accounting for continuations.
        (WebCore::firstChildInContinuation): ditto
        (WebCore::firstChildConsideringContinuation): ditto
        (WebCore::lastChildConsideringContinuation): ditto
        (WebCore::startOfContinuations): ditto
        (WebCore::endOfContinuations): ditto
        (WebCore::childBeforeConsideringContinuations): ditto
        (WebCore::firstChildIsInlineContinuation): ditto
        (WebCore::lastChildHasContinuation): ditto
        (WebCore::AccessibilityRenderObject::firstChild): Account for inline continuations.
        (WebCore::AccessibilityRenderObject::lastChild): ditto
        (WebCore::AccessibilityRenderObject::previousSibling): Account for inline continuations
        and their anonymous block parents.
        (WebCore::AccessibilityRenderObject::nextSibling): ditto
        (WebCore::AccessibilityRenderObject::parentObjectIfExists): Account for inline continuations.
        (WebCore::AccessibilityRenderObject::parentObject): Account for inline continuations.
        * rendering/RenderInline.h: Make RenderInline::inlineContinuation public.
2010-04-22  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Links around blocks (e.g. divs) results in too many VoiceOver call outs
        https://bugs.webkit.org/show_bug.cgi?id=37079

        The new test cases verify the accessibility tree created by an image inside a link, and verify
        that adding a div with role=presentation now has no effect on the accessibility tree (as expected).

        * accessibility/image-link-inline-cont-expected.txt: Added.
        * accessibility/image-link-inline-cont.html: Added.
        * accessibility/image-link.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/accessibility/image-link-expected.txt: Added.
        * platform/win/Skipped:

        Test to check that accessibility tree doesn't get duplicate content in the presence
        of inline continuations (this was a bug in an earlier version of this patch).

        * accessibility/inline-continuations-expected.txt: Added.
        * accessibility/inline-continuations.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 23 Apr 2010 04:51:39 +0000 (04:51 +0000)]
2010-04-22  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION: TextIterator may use freed memory
        https://bugs.webkit.org/show_bug.cgi?id=37973

        * platform/chromium/test_expectations.txt:
2010-04-22  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        REGRESSION: TextIterator may use freed memory
        https://bugs.webkit.org/show_bug.cgi?id=37973

        Added TextIterator::m_text to hold the returned String.

        No new tests because there are no behavior change, but
        copy-backslash-with-euc.html on chromium-win should test this.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::emitText):
        * editing/TextIterator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Adam Barth <abarth@webkit.org>
eric@webkit.org [Fri, 23 Apr 2010 04:48:24 +0000 (04:48 +0000)]
2010-04-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        The new review tools shouldn't clear the comment box automatically
        https://bugs.webkit.org/show_bug.cgi?id=38004

        Instead, we now have a button for doing that explicitly.  If people
        like this tool, we can look at fancier solutions.

        Also, tried to make the tool work on the edit page as well as the review page.

        * PrettyPatch/PrettyPatch.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed fix.
ukai@chromium.org [Fri, 23 Apr 2010 04:32:50 +0000 (04:32 +0000)]
Unreviewed fix.

* Scripts/webkitpy/layout_tests/port/websocket_server.py: fix NameError: global name 'f' is not defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 James Robinson <jamesr@chromium.org>
eric@webkit.org [Fri, 23 Apr 2010 04:29:05 +0000 (04:29 +0000)]
2010-04-22  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Revert 58077 and follow-ups.  It's broken.
        https://bugs.webkit.org/show_bug.cgi?id=37664

        * Scripts/new-run-webkit-httpd:
        * Scripts/new-run-webkit-websocketserver:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Michael Forney <mforney@mforney.org>
eric@webkit.org [Fri, 23 Apr 2010 04:20:01 +0000 (04:20 +0000)]
2010-04-22  Michael Forney  <mforney@mforney.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=37761

        Only include JSDatabase.h and JSDatabaseCallback.h when database is
        enabled. This partially fixes building with --disable-database.

        * bindings/js/JSDOMWindowCustom.cpp: Add a check for database around
        database-related headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Ray Rischpater <Raymond.Rischpater@Nokia.com>
eric@webkit.org [Fri, 23 Apr 2010 03:39:56 +0000 (03:39 +0000)]
2010-04-22  Ray Rischpater  <Raymond.Rischpater@Nokia.com>

        Reviewed by Darin Adler.

        In HTMLInputElement.cpp, shouldUseInputMethod does not return true for
        some text input types (TELEPHONE, NUMBER, URL, and EMAIL). Addressed
        this by changing shouldUseInputMethod to use internal methods to
        check that the field is a text field that isn't a password field.

        No new tests.

        Fixes <https://bugs.webkit.org/show_bug.cgi?id=37719>

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::shouldUseInputMethod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Fri, 23 Apr 2010 03:30:22 +0000 (03:30 +0000)]
2010-04-22  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Adam Barth.

        Integrate v8 testing utility with webkit tests
        https://bugs.webkit.org/show_bug.cgi?id=37731

        * bindings/v8/test/run_tests.py: Removed.
2010-04-22  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Adam Barth.

        Integrate v8 testing utility with webkit tests
        https://bugs.webkit.org/show_bug.cgi?id=37731

        * Scripts/run-bindings-tests: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Steve Block <steveblock@google.com>
eric@webkit.org [Fri, 23 Apr 2010 03:10:48 +0000 (03:10 +0000)]
2010-04-22  Steve Block  <steveblock@google.com>

        Reviewed by Adam Barth.

        Update Android to use isfinite, isinf, isnan and signbit from namespace std.
        https://bugs.webkit.org/show_bug.cgi?id=37948

        * wtf/MathExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 John Pavan <john.pavan@nokia.com>
eric@webkit.org [Fri, 23 Apr 2010 02:52:22 +0000 (02:52 +0000)]
2010-04-22  John Pavan  <john.pavan@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] inputMethodQuery returns coordinates in web page coordinates rather than in item coordinates.
        https://bugs.webkit.org/show_bug.cgi?id=37163

        QWebPage::inputMethodQuery is modified so that it
        returns coordinates in the widget's coordinate system.
        Tests are added for QGraphicsWebView and QWebView
        to verify that this behavior is correct after the webpage
        has been scrolled.

        * Api/qwebpage.cpp:
        (QWebPage::inputMethodQuery):
        * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
        (tst_QGraphicsWebView::microFocusCoordinates):
        * tests/qwebview/tst_qwebview.cpp:
        (tst_QWebView::microFocusCoordinates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Fri, 23 Apr 2010 02:07:07 +0000 (02:07 +0000)]
2010-04-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Fisher.

        Add isGLES2Compliant to GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=37872

        * html/canvas/WebGLRenderingContext.cpp: Add isGLES2Compliant().
        (WebCore::WebGLRenderingContext::isGLES2Compliant):
        * html/canvas/WebGLRenderingContext.h: Ditto.
        * platform/graphics/GraphicsContext3D.h: Ditto.
        * platform/graphics/mac/GraphicsContext3DMac.cpp: Ditto.
        (WebCore::GraphicsContext3D::isGLES2Compliant):
2010-04-22  Zhenyao Mo  <zmo@google.com>

        Reviewed by Darin Fisher.

        Add isGLES2Compliant to GraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=37872

        * public/WebGraphicsContext3D.h: Add isGLES2Compliant().
        * src/GraphicsContext3D.cpp: Ditto.
        * src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
        (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2Compliant):
        * src/WebGraphicsContext3DDefaultImpl.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 23 Apr 2010 01:55:53 +0000 (01:55 +0000)]
2010-04-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Dimitri Glazkov.

        new-run-webkit-tests --verbose shows ever-increasing #EOF lines
        https://bugs.webkit.org/show_bug.cgi?id=37794

        * Scripts/webkitpy/layout_tests/port/webkit.py:
         - Remove the assert() since our ServerProcess code does not always
           seem to be reading the full stderr output (or we're not waiting for it to).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix.
ukai@chromium.org [Fri, 23 Apr 2010 01:32:22 +0000 (01:32 +0000)]
Unreviewed build fix.

* wtf/MD5.cpp: fix include path of CString.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Fri, 23 Apr 2010 01:31:06 +0000 (01:31 +0000)]
2010-04-22  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed. Chromium test expectation change.

        Mark fast/events/touch/send-oncancel-event.html as failing (TEXT).
        https://bugs.webkit.org/show_bug.cgi?id=38020

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 23 Apr 2010 01:13:42 +0000 (01:13 +0000)]
2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Adam Barth.

        MD5 is required for WebSocket new protocol implementation
        https://bugs.webkit.org/show_bug.cgi?id=37913

        * GNUmakefile.am:
        * JavaScriptCore.exp:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/MD5.cpp: Added.
        * wtf/MD5.h: Added.
2010-04-22  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Adam Barth.

        MD5 is required for WebSocket new protocol implementation
        https://bugs.webkit.org/show_bug.cgi?id=37913

        * ForwardingHeaders/wtf/MD5.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove an assert. (It's not valid when resizing).
andersca@apple.com [Fri, 23 Apr 2010 00:44:26 +0000 (00:44 +0000)]
Remove an assert. (It's not valid when resizing).

Reviewed by Sam Weinig.

* WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::didUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoErrk, accidentally committed commenting out two ASSERTs! reverting.
barraclough@apple.com [Fri, 23 Apr 2010 00:16:22 +0000 (00:16 +0000)]
Errk, accidentally committed commenting out two ASSERTs! reverting.

Reviewed by NOBODY (build fix).

* runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=38006
barraclough@apple.com [Fri, 23 Apr 2010 00:11:37 +0000 (00:11 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=38006
Change lifetime of JSC::IdentifierTables used by WebCores to match AtomicStringTable

Reviewed by Geoff Garen.

Presently JSC's IdentifierTables are owned by the JSGlobalData.  For
JSGlobalData objects created via the API this should continue to be the case,
but for the JSGlobalData objects used by WebCore (the main thread's common
global data, and those for workers) use a IdentifierTable provided (and owned)
by wtfThreadData.  This allow the lifetime of these IdentifierTable to match
those of the corresponding AtomicStringTables.

* API/APIShims.h:
(JSC::APIEntryShim::APIEntryShim):
* API/JSContextRef.cpp:
(JSContextGroupCreate):
* runtime/Collector.cpp:
(JSC::Heap::protect):
(JSC::Heap::unprotect):
(JSC::Heap::markRoots):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
(JSC::JSGlobalData::createContextGroup):
(JSC::JSGlobalData::create):
(JSC::JSGlobalData::sharedInstance):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::):
(JSC::JSGlobalData::isSharedInstance):
* runtime/JSLock.cpp:
(JSC::JSLock::JSLock):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::DropAllLocks::DropAllLocks):
* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Fri, 23 Apr 2010 00:08:37 +0000 (00:08 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=38012
        REGRESSION: Ctrl- and Option- shortcuts get wrong keyCode on non-QWERTY keyboard

        * platform/mac/KeyEventMac.mm: (WebCore::windowsKeyCodeForKeyEvent): Also look at unmodified
        characters, to avoid falling through to virtual key code lookup for Roman characters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDo not get the globaldata for the APIShim via the
barraclough@apple.com [Fri, 23 Apr 2010 00:07:38 +0000 (00:07 +0000)]
Do not get the globaldata for the APIShim via the
global object; global object construction creates identifiers
which results in the ASSERTs checking the thread data's
identifierTable has been set failing.

Rubber stamped by Sam Weinig

* JSUtils.cpp:
(unprotectGlobalObject):
(getThreadGlobalData):
(getThreadGlobalObject):
(JSGlueAPIEntry::JSGlueAPIEntry):
(JSGlueAPICallback::~JSGlueAPICallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Fri, 23 Apr 2010 00:02:46 +0000 (00:02 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Apr 2010 23:46:56 +0000 (23:46 +0000)]
2010-04-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add code to help debug new-run-webkit-test hangs on the Chromium bots
        https://bugs.webkit.org/show_bug.cgi?id=38011

        I can see no reasonable way to test this change.
        Stubbing out sys._current_frames() and traceback.extract_stack
        seems folly.  Dumping real data would have line number
        (and possibly other call stack) variance between runs.

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
         - Add _dump_thread_states and _dump_thread_states_if_necessary
           to have our main thread dump the states of all threads every
           60 seconds when running in verbose mode.
         - Better document what is going on in our main loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 22 Apr 2010 23:40:27 +0000 (23:40 +0000)]
2010-04-22  James Robinson  <jamesr@chromium.org>

        Unreviewed, expectations only change.
        Land chromium platform-specific results for fast/text/format-control.html

        * platform/chromium-linux/fast/text/format-control-expected.checksum: Added.
        * platform/chromium-linux/fast/text/format-control-expected.png: Added.
        * platform/chromium-mac/fast/text/format-control-expected.checksum: Added.
        * platform/chromium-win/fast/text/format-control-expected.checksum: Added.
        * platform/chromium-win/fast/text/format-control-expected.png: Added.
        * platform/chromium-win/fast/text/format-control-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Thu, 22 Apr 2010 23:37:17 +0000 (23:37 +0000)]
2010-04-22  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Darin Adler.

        Fix the MSVC 64bit build.
        https://bugs.webkit.org/show_bug.cgi?id=37980

        * platform/text/TextStream.cpp:
        * platform/text/TextStream.h:
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::platformStart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMerge the prefix headers.
weinig@apple.com [Thu, 22 Apr 2010 23:35:16 +0000 (23:35 +0000)]
Merge the prefix headers.

Reviewed by Anders Carlsson.

* Configurations/BaseTarget.xcconfig:
* WebKit2.xcodeproj/project.pbxproj:
* WebKit2Prefix.h:
* WebKit2_Prefix.pch: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Thu, 22 Apr 2010 23:00:23 +0000 (23:00 +0000)]
2010-04-22  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Gustavo Noronha Silva.

        Implement findThemePath to locate the correct theme file instead of
        relying on a hardcoded location.
        http://webkit.org/b/37996

        * efl/EWebLauncher/main.c:
        (findThemePath): Fix to locate the correct theme files.
        (main): Use findThemePath() instead of a hardcoded one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't pass the new size when calling didSetSize, it's possible to get
andersca@apple.com [Thu, 22 Apr 2010 22:58:08 +0000 (22:58 +0000)]
Don't pass the new size when calling didSetSize, it's possible to get
the size from the update chunk.

Reviewed by Sam Weinig.

* UIProcess/mac/DrawingAreaProxyUpdateChunk.h:
* UIProcess/mac/DrawingAreaProxyUpdateChunk.mm:
(WebKit::DrawingAreaProxyUpdateChunk::didSetSize):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
* WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::setSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Thu, 22 Apr 2010 22:51:09 +0000 (22:51 +0000)]
2010-04-22  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Gustavo Noronha Silva.

        Update efl/ewebkit.pc.in to match the variable substitution syntax
        of CMake.
        http://webkit.org/b/37999

        * efl/ewebkit.pc.in: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Thu, 22 Apr 2010 22:41:32 +0000 (22:41 +0000)]
2010-04-22  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Gustavo Noronha Silva.

        Update EWebKit (EFL port) to match recent API changes.
        http://webkit.org/b/37997

        * efl/ewk/ewk_frame.cpp:
        (ewk_frame_zoom_set): Change to use WebCore::ZoomMode.
        (ewk_frame_zoom_text_only_set): Change to use WebCore::ZoomMode.
        (_ewk_frame_handle_key_scrolling): s/WebCore::VK_/VK_/g
        (ewk_frame_plugin_create): Disable temporarily PluginView-related
        code until a proper plugin implementation is made.
        * efl/ewk/ewk_view.cpp: Fix typo in _parent_sc declaration.
        (ewk_view_selection_get): Fix a reference to WebCore::CString to
        WTF::CString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Rubber-stamped by Mark Rowe.
ap@apple.com [Thu, 22 Apr 2010 22:33:13 +0000 (22:33 +0000)]
    Rubber-stamped by Mark Rowe.

        <rdar://problem/7805969> REGRESSION: iTunes unable to play trailers

        Undo the changes made for https://bugs.webkit.org/show_bug.cgi?id=35215 (<rdar://problem/7673157>)
        for now. Clients rely on the old behavior, so a fix that changes it will need to account for
        those.

        * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin): Pass pluginURL
        instead of baseURL again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename SetFrame and DidSetFrame to SetSize and DidSetSize.
andersca@apple.com [Thu, 22 Apr 2010 22:09:03 +0000 (22:09 +0000)]
Rename SetFrame and DidSetFrame to SetSize and DidSetSize.

Reviewed by Sam Weinig.

* Shared/CoreIPCSupport/DrawingAreaMessageKinds.h:
(DrawingAreaMessage::):
* Shared/CoreIPCSupport/DrawingAreaProxyMessageKinds.h:
(DrawingAreaProxyMessage::):
* UIProcess/mac/DrawingAreaProxyUpdateChunk.mm:
(WebKit::DrawingAreaProxyUpdateChunk::drawRectIntoContext):
(WebKit::DrawingAreaProxyUpdateChunk::setSize):
(WebKit::DrawingAreaProxyUpdateChunk::didReceiveMessage):
* WebProcess/WebPage/mac/DrawingAreaUpdateChunk.cpp:
(WebKit::DrawingAreaUpdateChunk::setSize):
(WebKit::DrawingAreaUpdateChunk::didReceiveMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Thu, 22 Apr 2010 21:44:46 +0000 (21:44 +0000)]
2010-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r58110.
        http://trac.webkit.org/changeset/58110
        https://bugs.webkit.org/show_bug.cgi?id=38007

        Caused an internal compiler error on Qt (Requested by abarth
        on #webkit).

        * wtf/MathExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58118 268f45cc-cd09-0410-ab3c-d52691b4dbfc