WebKit-https.git
6 years agoUnreviewed gardening. Added new common expectations for test after r151665.
mario@webkit.org [Tue, 2 Jul 2013 16:21:36 +0000 (16:21 +0000)]
Unreviewed gardening. Added new common expectations for test after r151665.

* accessibility/box-styled-lists-expected.txt: Added shared expectation.
* platform/efl/TestExpectations: Removed failure expectation.
* platform/gtk/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix WebKitTestRunner crashes.
bw80.lee@samsung.com [Tue, 2 Jul 2013 16:19:05 +0000 (16:19 +0000)]
Fix WebKitTestRunner crashes.
https://bugs.webkit.org/show_bug.cgi?id=117630

Reviewed by Darin Adler.

Create static function to dump for WebProcess unresponsiveness status,
and use it before calling TestController::runTest().

Accessing TestController::m_currentInvocation before calling
TestController::runTest() can make crash because the invocation
instance will be assigned at the function.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::run):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpWebProcessUnresponsiveness):
* WebKitTestRunner/TestInvocation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening. Added new baselines for GTK after revision r151841 and r151868.
mario@webkit.org [Tue, 2 Jul 2013 16:13:53 +0000 (16:13 +0000)]
Unreviewed gardening. Added new baselines for GTK after revision r151841 and r151868.

* accessibility/listitem-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/listitem-title-expected.txt.
* platform/gtk/accessibility/aria-tab-role-on-buttons-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] No other SVG elements except the SVGRoot must have RegionInfo objects...
commit-queue@webkit.org [Tue, 2 Jul 2013 15:00:31 +0000 (15:00 +0000)]
[CSSRegions] No other SVG elements except the SVGRoot must have RegionInfo objects attached
https://bugs.webkit.org/show_bug.cgi?id=118295

Patch by Radu Stavila <stavila@adobe.com> on 2013-07-02
Reviewed by Antti Koivisto.

Only the SVGRoot element can be collected in a named flow. As such, no SVG element below the root should
be attached to a RenderBoxRegionInfo object.

A larger patch's test (https://bugs.webkit.org/show_bug.cgi?id=118300) is failing because of this.
This change will be covered by that test.

* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion):
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderSVGBlock):
* rendering/svg/RenderSVGBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r152233.
commit-queue@webkit.org [Tue, 2 Jul 2013 14:32:45 +0000 (14:32 +0000)]
Unreviewed, rolling out r152233.
http://trac.webkit.org/changeset/152233
https://bugs.webkit.org/show_bug.cgi?id=118304

hopeful attempt to restore windows buildage (Requested by
kling on #webkit).

* win/tools/vsprops/debugsuffix.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening. Rebaseline background blend mode default test result.
abucur@adobe.com [Tue, 2 Jul 2013 14:04:16 +0000 (14:04 +0000)]
Unreviewed gardening. Rebaseline background blend mode default test result.

* platform/mac/css3/compositing/background-blend-mode-default-value-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agois/toHTMLStyleElement should use Element* for its argument
kangil.han@samsung.com [Tue, 2 Jul 2013 13:48:16 +0000 (13:48 +0000)]
is/toHTMLStyleElement should use Element* for its argument
https://bugs.webkit.org/show_bug.cgi?id=118286

Reviewed by Andreas Kling.

To reduce unnecessary call of isElementNode(), this patch replaces argument
of is/toHTMLStyleElement from Node* to Element*. Plus, use Element::hasTagName
in collectActiveStyleSheets function for minor code refactoring since
its cost is cheaper than Node::hasTagName.

* css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
* css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::scopeFor):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
* dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
* html/HTMLStyleElement.h:
(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid code duplication inside String::append()
mikhail.pozdnyakov@intel.com [Tue, 2 Jul 2013 13:36:09 +0000 (13:36 +0000)]
Avoid code duplication inside String::append()
https://bugs.webkit.org/show_bug.cgi?id=118290

Reviewed by Anders Carlsson.

The implementation of 'append(UChar)' had been repeated inside 'append(LChar)',
this duplication is obviated now.

* wtf/text/WTFString.cpp:
(WTF::String::appendInternal):
(WTF::String::append):
* wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkip fast/dom/timer-throttling-hidden-page.html after r152202.
akling@apple.com [Tue, 2 Jul 2013 13:31:27 +0000 (13:31 +0000)]
Skip fast/dom/timer-throttling-hidden-page.html after r152202.
<http://webkit.org/b/118301>

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkip 3 MathML tests that are failing after r152235.
akling@apple.com [Tue, 2 Jul 2013 12:53:57 +0000 (12:53 +0000)]
Skip 3 MathML tests that are failing after r152235.
<http://webkit.org/b/118298>

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnexpose EditingPropertiesToInclude in EditingStyle.h after r151772
rniwa@webkit.org [Tue, 2 Jul 2013 12:20:22 +0000 (12:20 +0000)]
Unexpose EditingPropertiesToInclude in EditingStyle.h after r151772
https://bugs.webkit.org/show_bug.cgi?id=118271

Reviewed by Andreas Kling.

Don't expose EditingPropertiesToInclude in EditingStyle.h and do other cleanups as described below.

No new tests since there should be no behavioral change.

* editing/EditingStyle.cpp:
(WebCore::copyEditingProperties): Use newly defined numAllEditingProperties and numInheritableEditingProperties
instead of a magic number of 2.
(WebCore::copyPropertiesFromComputedStyle): Renamed from editingStyleFromComputedStyle. It now takes ComputedStyleExtractor and
PropertiesToInclude instead of Node* and EditingPropertiesToInclude and handles AllProperties. Also added a helper that takes Node*.
(WebCore::EditingStyle::init): Calls copyPropertiesFromComputedStyle. Unfortunately, we need to special-case EditingPropertiesInEffect
and not set background-color and text-decoration. This is required probably due to a bug elsewhere.
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::extractEditingProperties): Renamed from EditingStyle::removeAllButEditingProperties; takes PropertiesToInclude instead of
EditingPropertiesToInclude since the only caller of this function, EditingStyle::mergeInlineAndImplicitStyleOfElement, was converting
the type.
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
* editing/EditingStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIntroduce toSVGInlineTextBox
gyuyoung.kim@samsung.com [Tue, 2 Jul 2013 11:56:29 +0000 (11:56 +0000)]
Introduce toSVGInlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=118289

Reviewed by Andreas Kling.

As a step to change static_cast with toXXX, static_cast<SVGInlineTextBox*> can
be changed with toSVGInlineTextBox().

Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153345

* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::positionForPoint):
* rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paintSelectionBackground):
(WebCore::SVGInlineFlowBox::paint):
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
* rendering/svg/SVGInlineTextBox.h:
(WebCore::toSVGInlineTextBox):
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGInlineTextBoxes):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
* rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::collectTextBoxesInFlowBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplify SVGTextContentElement::elementFromRenderer()
ch.dumez@sisa.samsung.com [Tue, 2 Jul 2013 11:50:24 +0000 (11:50 +0000)]
Simplify SVGTextContentElement::elementFromRenderer()
https://bugs.webkit.org/show_bug.cgi?id=118284

Reviewed by Andreas Kling.

Simplify SVGTextContentElement::elementFromRenderer() by leveraging
SVGElement::isTextContent() methods instead of explicitly checking
for tag names.

No new tests, no behavior change.

* svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::elementFromRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix cast-align warnings in WebCore/platform/graphics/texmap/TextureMapperGL.cpp
ossy@webkit.org [Tue, 2 Jul 2013 11:19:04 +0000 (11:19 +0000)]
Fix cast-align warnings in WebCore/platform/graphics/texmap/TextureMapperGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=118249

Reviewed by Allan Sandfeld Jensen.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK1] Support WebGL with EGL on Linux
allan.jensen@digia.com [Tue, 2 Jul 2013 11:04:48 +0000 (11:04 +0000)]
[Qt][WK1] Support WebGL with EGL on Linux
https://bugs.webkit.org/show_bug.cgi?id=118251

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Let GraphicsContext3D work without a GraphicsSurface.

* Target.pri:
* platform/graphics/OpenGLShims.cpp:
(WebCore::getProcAddress):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

Tools:

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS-Regions] OverrideLogicalHeight used by both regions and flexbox
commit-queue@webkit.org [Tue, 2 Jul 2013 07:43:19 +0000 (07:43 +0000)]
[CSS-Regions] OverrideLogicalHeight used by both regions and flexbox
https://bugs.webkit.org/show_bug.cgi?id=118057

Patch by Catalin Badea <badea@adobe.com> on 2013-07-02
Reviewed by David Hyatt.

Source/WebCore:

Remove the use of overrideLogicalContentHeight() from regions and
use a local variable instead. The change was needed to avoid
overlapping with flexbox containers.

Test: fast/regions/autoheight-flexbox.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::applyBreakAfterContent):
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
* rendering/RenderFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::updateLogicalHeight):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::computedAutoHeight):
(WebCore::RenderRegion::setComputedAutoHeight):
(WebCore::RenderRegion::clearComputedAutoHeight):
(WebCore::RenderRegion::hasComputedAutoHeight):
* rendering/RenderView.cpp:

LayoutTests:

Add test for auto-height regions and flexbox containers.

* fast/regions/autoheight-flexbox-expected.html: Added.
* fast/regions/autoheight-flexbox.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[JSC]: Fix maybe-uninitialized gcc 4.8 warning in DFGSpeculativeJIT.cpp
commit-queue@webkit.org [Tue, 2 Jul 2013 06:03:12 +0000 (06:03 +0000)]
[JSC]: Fix maybe-uninitialized gcc 4.8 warning in DFGSpeculativeJIT.cpp
https://bugs.webkit.org/show_bug.cgi?id=118278

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-07-01
Reviewed by Filip Pizlo.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
Initialize valueGPR with InvalidGPRReg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
commit-queue@webkit.org [Tue, 2 Jul 2013 02:00:40 +0000 (02:00 +0000)]
[Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
https://bugs.webkit.org/show_bug.cgi?id=118267

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-07-01
Reviewed by Gyuyoung Kim.

After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.

* efl/jhbuildrc:
* gtk/jhbuildrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWindows should be included in the list of platforms that can use OpenGL ES 2.
achristensen@apple.com [Tue, 2 Jul 2013 01:01:42 +0000 (01:01 +0000)]
Windows should be included in the list of platforms that can use OpenGL ES 2.
https://bugs.webkit.org/show_bug.cgi?id=118264

Reviewed by Dean Jackson.

* platform/graphics/GraphicsContext3D.h: Added PLATFORM(WIN) to platforms using OpenGL ES 2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Remove unsupported AC backends
kov@webkit.org [Tue, 2 Jul 2013 01:00:38 +0000 (01:00 +0000)]
[GTK] Remove unsupported AC backends
https://bugs.webkit.org/show_bug.cgi?id=117362

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-07-01
Reviewed by Martin Robinson.

.:

* Source/autotools/FindDependencies.m4: remove checks related to acceleration backend,
turn them into a check for OpenGL being available, simply.
* Source/autotools/ReadCommandLineArguments.m4: remove command line option to select
accelerated backend, it's now auto-detected.
* Source/autotools/SetupAutoconfHeader.m4: no longer defines USE_CLUTTER and
USE_TEXTURE_MAPPER_CAIRO.
* Source/autotools/SetupAutomake.m4: remove checks related to acceleration backend,
turn them into a check for OpenGL being available, simply.
* Source/autotools/Versions.m4: no longer check for clutter/clutter-gtk.

Source/WebCore:

* GNUmakefile.am:
* GNUmakefile.list.am:
* Source/WebCore/platform/graphics/PlatformLayer.h: Removed mentions of clutter
and the texmap cairo backend.
* platform/graphics/clutter/DrawingBufferClutter.cpp: Removed.
* platform/graphics/clutter/GraphicsContext3DClutter.cpp: Removed.
* platform/graphics/clutter/GraphicsContext3DPrivate.cpp: Removed.
* platform/graphics/clutter/GraphicsContext3DPrivate.h: Removed.
* platform/graphics/clutter/GraphicsLayerActor.cpp: Removed.
* platform/graphics/clutter/GraphicsLayerActor.h: Removed.
* platform/graphics/clutter/GraphicsLayerClutter.cpp: Removed.
* platform/graphics/clutter/GraphicsLayerClutter.h: Removed.
* platform/graphics/clutter/PlatformClutterAnimation.cpp: Removed.
* platform/graphics/clutter/PlatformClutterAnimation.h: Removed.
* platform/graphics/clutter/PlatformClutterLayerClient.h: Removed.
* platform/graphics/clutter/TransformationMatrixClutter.cpp: Removed.
* Source/WebCore/platform/graphics/transforms/TransformationMatrix.h: Removed cogl
matrix type conversion.

Source/WebKit/gtk:

* GNUmakefile.am:
* WebCoreSupport/AcceleratedCompositingContext.h: removed clutter and cairo
additions.
* WebCoreSupport/AcceleratedCompositingContextCairo.cpp: Removed.
* WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Removed.
* webkit/webkitglobals.cpp:
(webkitInit): removed clutter-gtk initialization.

Tools:

* gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
and cogl, so removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago Clean up private browsing session tracking
ap@apple.com [Tue, 2 Jul 2013 00:08:56 +0000 (00:08 +0000)]
    Clean up private browsing session tracking
        https://bugs.webkit.org/show_bug.cgi?id=118266
        <rdar://problem/13078036>

        Reviewed by Brady Eidson.

        Instead of counting API calls, we now watch actual WebPreferences objects.

        * UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetPrivateBrowsingEnabled):
        Removed code that used to notify WebContext. It's now done by WebPreferences.

        * UIProcess/WebContext.h:
        * UIProcess/WebContext.cpp:
        (WebKit::WebContext::ensureNetworkProcess): Instead of counting the number of times
        API was called, rely on WebPreferences tracking.
        (WebKit::WebContext::willStartUsingPrivateBrowsing): Ditto. This function is
        now only called when we detect a change in private browsing state.
        (WebKit::WebContext::willStopUsingPrivateBrowsing): Ditto.
        (WebKit::WebContext::createNewWebProcess): Tell the new process to create a private
        browsing session if needed.

        * UIProcess/WebPreferences.h:
        * UIProcess/WebPreferences.cpp:
        (WebKit::WebPreferences::addPageGroup): Count how many page groups use private
        browsing, and notify WebContext when a session is needed. Note that we don't notify
        WebContext about WebPreferences without any page groups, because it's likely
        that preferences will be updated by the client before groups are associated.
        (WebKit::WebPreferences::removePageGroup): Ditto.
        (WebKit::WebPreferences::updateBoolValueForKey): Perform special handling for
        private browsing mode changes.
        (WebKit::WebPreferences::updatePrivateBrowsingValue): Notify WebContext when
        it's time to create or destroy a private browsing session.
        (WebKit::WebPreferences::anyPageGroupsAreUsingPrivateBrowsing): A getter for
        WebContext to know when any page groups are in private browsing mode.

        * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::updatePreferences):
        Don't create a private browsing session implicitly, UI process takes care of it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDrawingBuffer constructor and destructor were not defined for Windows.
achristensen@apple.com [Mon, 1 Jul 2013 23:21:17 +0000 (23:21 +0000)]
DrawingBuffer constructor and destructor were not defined for Windows.
I moved duplicate code from Cairo and Qt to DrawingBuffer.cpp to be used by Qt, Cairo, and Windows.
https://bugs.webkit.org/show_bug.cgi?id=118262

Reviewed by Dean Jackson.

* platform/graphics/cairo/DrawingBufferCairo.cpp: Removed duplicate DrawingBuffer constructor and destructor.
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::~DrawingBuffer): Moved from Cairo and Qt implementation.
* platform/graphics/gpu/qt/DrawingBufferQt.cpp: Removed duplicate DrawingBuffer constructor and destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFixed unreachable return when GLX or EGL are used with WebGL.
achristensen@apple.com [Mon, 1 Jul 2013 22:44:47 +0000 (22:44 +0000)]
Fixed unreachable return when GLX or EGL are used with WebGL.
https://bugs.webkit.org/show_bug.cgi?id=118263

Reviewed by Noam Rosenthal.

* platform/graphics/opengl/GLPlatformContext.cpp:
(WebCore::createOffScreenContext): Fixed unreachable return.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLink to WebInspectorUI.framework at build time instead of soft linking.
timothy@apple.com [Mon, 1 Jul 2013 22:23:11 +0000 (22:23 +0000)]
Link to WebInspectorUI.framework at build time instead of soft linking.

https://bugs.webkit.org/show_bug.cgi?id=118261

Reviewed by Joseph Pecoraro.

.:

* Source/Makefile: Build WebInspectorUI before WebKit and WebKit2.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* Configurations/WebKit.xcconfig:
* WebCoreSupport/WebInspectorClient.mm:
(useWebKitWebInspector):

Source/WebKit2:

* Configurations/WebKit2.xcconfig:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::inspectorReallyUsesWebKitUserInterface):

Tools:

* Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[wk2] TiledCoreAnimationDrawingArea should support scrolling its exposed rect
timothy_horton@apple.com [Mon, 1 Jul 2013 21:47:51 +0000 (21:47 +0000)]
[wk2] TiledCoreAnimationDrawingArea should support scrolling its exposed rect
https://bugs.webkit.org/show_bug.cgi?id=118173
<rdar://problem/14301166>

Reviewed by Anders Carlsson.

Offset the exposed rect passed from the WKView by the main frame's current scroll position
before sending it to our TiledBackings, so that it is in the same coordinate space as their
ordinary visibleRects.

This has the side effect of making clips-to-exposed-rect testable (though useless) in Safari.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Add updateScrolledExposedRect() and m_scrolledExposedRect.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):
Call updateScrolledExposedRect when the main frame scrolls.

(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
Remove a FIXME about this change.
Call updateScrolledExposedRect instead of passing down the unscrolled rect.

(WebKit::TiledCoreAnimationDrawingArea::setClipsToExposedRect):
Call updateScrolledExposedRect, because that method will short-circuit if
setClipsToExposedRect is false, so we need to update here for correctness
if we get a setExposedRect(), setClipsToExposedRect(true) pair.

(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):
Update m_scrolledExposedRect and propagate it to our TiledBackings.

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Use the scrolled exposed rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMaximum scroll position can be negative in some cases
timothy_horton@apple.com [Mon, 1 Jul 2013 21:35:33 +0000 (21:35 +0000)]
Maximum scroll position can be negative in some cases
https://bugs.webkit.org/show_bug.cgi?id=118175
<rdar://problem/14301217>

Reviewed by Anders Carlsson.

Test (API): WebKit2.ResizeReversePaginatedWebView

* page/FrameView.cpp:
(WebCore::FrameView::maximumScrollPosition):
* page/FrameView.h:
Override maximumScrollPosition() in FrameView and don't clamp to zero if
a reverse pagination mode is enabled, as it is possible (and common) to
have a negative maximum scroll position with reverse pagination.

* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
Drive-by adoption of toIntSize().

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
(TestWebKitAPI::didRunJavaScript):
(TestWebKitAPI::didLayout):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
Add a test that loads a vertical-lr document, paginates it horizontally
from right to left, resizes the view to fit the entire document, and
verifies that the scroll position is negative, as it must be for the
document to be enclosed by the view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoProperly hide the header and footer banners if they are set to null.
adachan@apple.com [Mon, 1 Jul 2013 20:45:17 +0000 (20:45 +0000)]
Properly hide the header and footer banners if they are set to null.
https://bugs.webkit.org/show_bug.cgi?id=118219

Reviewed by Beth Dakin.

Call Page::addFooterWithHeight(0) to remove the parent layer that hosts the banner when
the footer banner is detached. Similarly for the header banner.

* WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::detachFromPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved all references to DrawingBuffer methods unused since the removal of Chromium:
achristensen@apple.com [Mon, 1 Jul 2013 19:48:10 +0000 (19:48 +0000)]
Removed all references to DrawingBuffer methods unused since the removal of Chromium:
DrawingBuffer::prepareBackBuffer,
DrawingBuffer::requiresCopyFromBackToFrontBuffer, and
DrawingBuffer::clearPlatformLayer.
https://bugs.webkit.org/show_bug.cgi?id=118257

Reviewed by Darin Adler.

* platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
(WebCore::DrawingBuffer::platformLayer):
* platform/graphics/cairo/DrawingBufferCairo.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/clutter/DrawingBufferClutter.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clear):
* platform/graphics/gpu/DrawingBuffer.h:
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::frontColorBuffer):
* platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed build correction.
bfulgham@apple.com [Mon, 1 Jul 2013 19:33:17 +0000 (19:33 +0000)]
[Windows] Unreviewed build correction.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Need to export tag for textarea element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove support for consumable user gestures
jochen@chromium.org [Mon, 1 Jul 2013 19:24:19 +0000 (19:24 +0000)]
Remove support for consumable user gestures
https://bugs.webkit.org/show_bug.cgi?id=118247

Reviewed by Geoffrey Garen.

Source/WebCore:

The features was not enabled on any port, and is meanwhile broken, so we
should delete it.

No new tests, just deleting dead code.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::increment):
(WebCore::AccessibilityNodeObject::decrement):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeScript):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorld):
* dom/UserGestureIndicator.cpp:
(WebCore::isDefinite):
(WebCore::UserGestureIndicator::UserGestureIndicator):
(WebCore::UserGestureIndicator::~UserGestureIndicator):
* dom/UserGestureIndicator.h:
(WebCore::UserGestureIndicator::processingUserGesture):
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openInNewTab):
* inspector/InspectorFrontendHost.cpp:
(WebCore::FrontendMenuProvider::contextMenuItemSelected):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::navigate):
* loader/NavigationScheduler.cpp:
(WebCore::ScheduledURLNavigation::fire):
(WebCore::ScheduledURLNavigation::didStartTimer):
(WebCore::ScheduledRedirect::fire):
(WebCore::ScheduledRefresh::fire):
(WebCore::ScheduledHistoryNavigation::fire):
(WebCore::ScheduledFormSubmission::fire):
(WebCore::ScheduledFormSubmission::didStartTimer):
* page/DOMTimer.cpp:
(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::fired):
* page/DOMTimer.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::showModalDialog):
* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
* page/EventHandler.h:
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::toggleMediaFullscreenState):
(WebCore::HitTestResult::enterFullscreenForVideo):

Source/WebKit/blackberry:

* WebKitSupport/NotificationManager.cpp:
(BlackBerry::WebKit::NotificationManager::notificationClicked):

Source/WebKit/mac:

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::evaluate):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView sendEvent:isDrawRect:]):

Source/WebKit/qt:

* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::notificationClicked):

Source/WebKit/win:

* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):

Source/WebKit2:

* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::didClickNotification):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::performFrameLoadURLRequest):
(WebKit::PluginView::evaluate):
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd screenshot of the inspector color picker for the blog
benjamin@webkit.org [Mon, 1 Jul 2013 18:54:01 +0000 (18:54 +0000)]
Add screenshot of the inspector color picker for the blog

* blog-files/last-week-in-webkit: Added.
* blog-files/last-week-in-webkit/Inspector_color_picker.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd Support for mspace element
commit-queue@webkit.org [Mon, 1 Jul 2013 18:41:43 +0000 (18:41 +0000)]
Add Support for mspace element
https://bugs.webkit.org/show_bug.cgi?id=115610

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-07-01
Reviewed by Chris Fleizach.

Source/WebCore:

This patch adds basic support for the MathML mspace element. This is
important to let people control spacing of mathematical formulas.
Attributes width, height and depth are implemented. For the moment,
only nonnegative width are accepted.

* CMakeLists.txt: add references to the RenderMathMLSpace files.
* GNUmakefile.list.am: ditto.
* Target.pri: ditto.
* WebCore.vcxproj/WebCore.vcxproj: ditto.
* WebCore.vcxproj/WebCore.vcxproj.filters: ditto.
* WebCore.xcodeproj/project.pbxproj: ditto.
* css/mathml.css:
(mtable[columnlines="dashed"] > mtr > mtd + mtd): remove the obsolete linebreaking rule.
* mathml/MathMLTextElement.cpp:
(WebCore::MathMLTextElement::createRenderer): map mspaceTag to RenderMathMLSpace.
* mathml/mathattrs.in: add width, height and depth attributes
* mathml/mathtags.in: add mspace element
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::parseMathMLLength): fix int to float conversion.
* rendering/mathml/RenderMathMLBlock.h: declare isRenderMathMLSpace.
(WebCore::RenderMathMLBlock::isRenderMathMLSpace):
* rendering/mathml/RenderMathMLSpace.cpp: Added.
(WebCore::RenderMathMLSpace::RenderMathMLSpace):
(WebCore::RenderMathMLSpace::isChildAllowed):
(WebCore::RenderMathMLSpace::computePreferredLogicalWidths):
(WebCore::RenderMathMLSpace::updateFromElement):
(WebCore::RenderMathMLSpace::updateLogicalWidth):
(WebCore::RenderMathMLSpace::updateLogicalHeight):
(WebCore::RenderMathMLSpace::layout):
(WebCore::RenderMathMLSpace::styleDidChange):
(WebCore::RenderMathMLSpace::firstLineBoxBaseline):
* rendering/mathml/RenderMathMLSpace.h: Added.
(WebCore::RenderMathMLSpace::isRenderMathMLSpace):
(WebCore::RenderMathMLSpace::renderName):
(WebCore::toRenderMathMLSpace):

LayoutTests:

Add a reftest for the mspace element (width, height and depth) and
the parsing of MathML lengths. Import a reftest from Gecko to check
positive namedspace values.

* mathml/presentation/mspace-expected.html: Added.
* mathml/presentation/mspace-units-expected.html: Added.
* mathml/presentation/mspace-units.html: Added.
* mathml/presentation/mspace.html: Added.
* mathml/presentation/positive-namedspace-expected.html: Added.
* mathml/presentation/positive-namedspace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAudio in apps which embed WebViews is corrupted.
jer.noble@apple.com [Mon, 1 Jul 2013 18:40:27 +0000 (18:40 +0000)]
Audio in apps which embed WebViews is corrupted.
https://bugs.webkit.org/show_bug.cgi?id=118163

Reviewed by Maciej Stachowiak.

Source/WebCore:

Add a preference, which defaults to off, which controls whether the
AudioSessionManager will switch to a large audio buffer setting for
power-savings during <video> playback.

* WebCore.exp.in:
* page/Settings.cpp:
(WebCore::Settings::setLowPowerVideoAudioBufferSizeEnabled): Added.  Simple setter.
* page/Settings.h:
(WebCore::Settings::lowPowerVideoAudioBufferSizeEnabled): Added.  Simple getter.
* platform/audio/mac/AudioSessionManagerMac.cpp:
(AudioSessionManager::updateSessionState): Only set the large audio buffer
    size if lowPowerVideoAudioBufferSize is enabled.

Source/WebKit/mac:

Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit clients.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences lowPowerVideoAudioBufferSizeEnabled]):
(-[WebPreferences setLowPowerVideoAudioBufferSizeEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit2:

Expose the WebCore lowPowerVideoAudioBufferSizeEnabled setting to WebKit2 clients.

* Shared/WebPreferencesStore.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed correction to DEBUG_ALL target. Target was undefining DEBUG_ALL...
bfulgham@apple.com [Mon, 1 Jul 2013 18:12:31 +0000 (18:12 +0000)]
[Windows] Unreviewed correction to DEBUG_ALL target.  Target was undefining DEBUG_ALL and DEBUG_INTERNAL,
which prevented proper build operation.

* win/tools/vsprops/debugsuffix.props: We should DEFINE (not UNDEFINE) the DEBUG_ALL and DEBUG_INTERNAL
macros when building with 'debugsuffix' target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Leak: leaks in WebKitAccessibleInterfaceText
commit-queue@webkit.org [Mon, 1 Jul 2013 18:04:34 +0000 (18:04 +0000)]
[ATK] Leak: leaks in WebKitAccessibleInterfaceText
https://bugs.webkit.org/show_bug.cgi?id=118248

Fixed memory leaks.

Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-01
Reviewed by Christophe Dumez.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getPangoLayoutForAtk):
(webkitAccessibleTextGetText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Make WebCore.make copy over QTMovieWin DLL's and PDB's.
roger_fong@apple.com [Mon, 1 Jul 2013 17:53:38 +0000 (17:53 +0000)]
Unreviewed. Make WebCore.make copy over QTMovieWin DLL's and PDB's.
<rdar://problem/14321403>

* WebCore.vcxproj/WebCore.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWKPageLoadDataWithUserData neglects to set the base URL that is passed in
weinig@apple.com [Mon, 1 Jul 2013 17:45:29 +0000 (17:45 +0000)]
WKPageLoadDataWithUserData neglects to set the base URL that is passed in
<rdar://problem/14306784>
https://bugs.webkit.org/show_bug.cgi?id=118256

Reviewed by Anders Carlsson.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadData):
Pass the baseURL, not blankURL(), and remove an unnecessary multiplication by sizeof(uint8_t) which is always 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Curl] WebDownload init method is not implemented.
commit-queue@webkit.org [Mon, 1 Jul 2013 16:47:45 +0000 (16:47 +0000)]
[Curl] WebDownload init method is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=118241

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-01
Reviewed by Brent Fulgham.

The WebDownload::init() method called when a normal load is changed to a download
because of a decision by the policy delegate, is not implemented for Curl.

* WebDownloadCurl.cpp:
(WebDownload::init): Implement init() method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Crash when scrolling page with images.
commit-queue@webkit.org [Mon, 1 Jul 2013 16:38:05 +0000 (16:38 +0000)]
[Win] Crash when scrolling page with images.
https://bugs.webkit.org/show_bug.cgi?id=117832

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-01
Reviewed by Brent Fulgham.

Avoid access violation by returning early from method if image frame doesn't have pixel data.

* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::hasPixelData): Added method to check if frame has pixel data.
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::haveDecodedRow): Early return if frame doesn't have pixel data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid calling RenderLayerBacking::resetContentsRect() if possible
commit-queue@webkit.org [Mon, 1 Jul 2013 16:32:07 +0000 (16:32 +0000)]
Avoid calling RenderLayerBacking::resetContentsRect() if possible
https://bugs.webkit.org/show_bug.cgi?id=118217

Patch by Noam Rosenthal <noam@webkit.org> on 2013-07-01
Reviewed by Simon Fraser.

Call resetContentsRect() only if the layer has a contentsLayer.
Otherwise the contentsRect is redundant for the GraphicsLayer.

No new tests - optimization only. This is covered by plenty of existing
tests in webgl/ and compositing/.

* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::GraphicsLayerTextureMapper::hasContentsLayer):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
    Added hasContentsLayer calls for TextureMapper/CoordinatedGraphics

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
commit-queue@webkit.org [Mon, 1 Jul 2013 16:25:21 +0000 (16:25 +0000)]
[EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
https://bugs.webkit.org/show_bug.cgi?id=117249

Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2013-07-01
Reviewed by Brent Fulgham.

Finish converting all use cases of WEBKITOUTPUTDIR to
WEBKIT_OUTPUTDIR, which seems to be preferred these days.

* DumpRenderTree/efl/FontManagement.cpp:
(getCustomBuildDir):
(getPlatformFontsPath):
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(getOutputDir):
* Scripts/webkitdirs.pm:
(determineBaseProductDir):
(usesPerConfigurationBuildDirectory):
* Scripts/webkitpy/port/base.py:
(Port.to.setup_environ_for_server):
* Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver):
* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::getOutputDir):
* jhbuild/jhbuildutils.py:
(get_dependencies_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix cast-align warnings in JavaScriptCore/heap/HandleBlockInlines.h
ossy@webkit.org [Mon, 1 Jul 2013 15:39:00 +0000 (15:39 +0000)]
Fix cast-align warnings in JavaScriptCore/heap/HandleBlockInlines.h
https://bugs.webkit.org/show_bug.cgi?id=118242

Reviewed by Mark Hahnenberg.

* heap/HandleBlockInlines.h:
(JSC::HandleBlock::nodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed change of my email address.
rafael.lobo@openbossa.org [Mon, 1 Jul 2013 15:29:02 +0000 (15:29 +0000)]
Unreviewed change of my email address.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUn-break the WebCore ChangeLog after http://trac.webkit.org/changeset/152219.
timothy_horton@apple.com [Mon, 1 Jul 2013 14:36:11 +0000 (14:36 +0000)]
Un-break the WebCore ChangeLog after trac.webkit.org/changeset/152219.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Avoid creating a QWindow for offscreen GraphicsContext3D
allan.jensen@digia.com [Mon, 1 Jul 2013 14:29:22 +0000 (14:29 +0000)]
[Qt] Avoid creating a QWindow for offscreen GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=118244

Reviewed by Noam Rosenthal.

In Qt 5.0 we had to create invisible windows, but in Qt 5.1
we can now create specific offscreen surfaces.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Skipping unsupported tests.
kadam@inf.u-szeged.hu [Mon, 1 Jul 2013 13:31:10 +0000 (13:31 +0000)]
[Qt] Unreviewed gardening. Skipping unsupported tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-01

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Remove long unused Qt4 forward definitions
allan.jensen@digia.com [Mon, 1 Jul 2013 13:29:21 +0000 (13:29 +0000)]
[Qt] Remove long unused Qt4 forward definitions

Unreviewed cleanu-up.

* platform/graphics/GraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse DeferrableOneShotTimer for deleting decoded data
antti@apple.com [Mon, 1 Jul 2013 13:27:28 +0000 (13:27 +0000)]
Use DeferrableOneShotTimer for deleting decoded data
https://bugs.webkit.org/show_bug.cgi?id=118150

Reviewed by Andreas Kling.

Adam Barth pointed out that the virtual function for overriding the default delay doesn't work
as expected from base class constructor.

* loader/cache/CachedResource.cpp:
(WebCore::deadDecodedDataDeletionIntervalForResourceType):
(WebCore::CachedResource::CachedResource):

    Use static function instead of calling a virtual.

* loader/cache/CachedResource.h:
* loader/cache/CachedScript.cpp:
* loader/cache/CachedScript.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdopt toHTMLTextAreaElement for code cleanup
kangil.han@samsung.com [Mon, 1 Jul 2013 10:43:48 +0000 (10:43 +0000)]
Adopt toHTMLTextAreaElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118226

Reviewed by Andreas Kling.

To enhance readability, this patch adopts toHTMLTextAreaElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::text):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendText):
* html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
* html/HTMLTextAreaElement.h:
(WebCore::toHTMLTextAreaElement):
* page/FocusController.cpp:
(WebCore::clearSelectionIfNeeded):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::isContentEditable):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):
(WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth):
(WebCore::RenderTextControlMultiLine::computeControlLogicalHeight):
* testing/Internals.cpp:
(WebCore::Internals::wasLastChangeUserEdit):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextInputElement):
(BlackBerry::WebKit::DOMSupport::inputElementText):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::elementType):
(BlackBerry::WebKit::InputHandler::boundingBoxForInputField):

Source/WebKit/mac:

* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::textDidChangeInTextArea):

Source/WebKit/win:

* DOMCoreClasses.cpp:
(DOMElement::createInstance):
* DOMHTMLClasses.cpp:
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):

Source/WebKit2:

* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
* WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textDidChangeInTextArea):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormControls):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd missing string headers that are used when LOG_DISABLED is 0.
commit-queue@webkit.org [Mon, 1 Jul 2013 08:44:44 +0000 (08:44 +0000)]
Add missing string headers that are used when LOG_DISABLED is 0.
https://bugs.webkit.org/show_bug.cgi?id=118227

Patch by Kwang Yul Seo <skyul@company100.net> on 2013-07-01
Reviewed by Andreas Kling.

Build fix for LOG_DISABLED=0.

No new tests, no behavior change.

* html/track/InbandTextTrack.cpp:
* rendering/RenderLayerCompositor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Use PassOwnPtr for the returned value of createBackingStore
commit-queue@webkit.org [Mon, 1 Jul 2013 08:44:06 +0000 (08:44 +0000)]
[GTK] Use PassOwnPtr for the returned value of createBackingStore
https://bugs.webkit.org/show_bug.cgi?id=118230

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-07-01
Reviewed by Andreas Kling.

It would be better that createBackingStore returns PassOwnPtr instread of OwnPtr
to keep compatibility with c++0x.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::createBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening. Rebaselining whatever can be rebaselined and adding failure...
zandobersek@gmail.com [Sun, 30 Jun 2013 17:30:43 +0000 (17:30 +0000)]
Unreviewed GTK gardening. Rebaselining whatever can be rebaselined and adding failure expectations for other current failures.

* platform/gtk-wk1/TestExpectations:
* platform/gtk/TestExpectations:
* platform/gtk/editing/selection/user-select-all-image-with-single-click-expected.txt: Added.
* platform/gtk/editing/selection/user-select-all-with-single-click-expected.txt: Added.
* platform/gtk/fast/events/ondragenter-expected.txt: Added.
* platform/gtk/fast/js/global-constructors-attributes-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid calling into Objective-C every time we get the scrollbar width
simon.fraser@apple.com [Sat, 29 Jun 2013 20:27:08 +0000 (20:27 +0000)]
Avoid calling into Objective-C every time we get the scrollbar width
https://bugs.webkit.org/show_bug.cgi?id=118216

Reviewed by Geoffrey Garen.

Profiling shows that calling Scrollbar::isOverlayScrollbar() is somewhat
expensive, because it calls down into Objective-C. Fix by caching in
ScrollbarThemeMac whether we're using overlay scrollbars. We update this
cache on creation, and when preferences change; ScrollAnimatorMac::updateScrollerStyle()
is the function that gets called when the user changes the setting in System Preferences.

* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::usesOverlayScrollbarsChanged):
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::preferencesChanged):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbars):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbarsChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid calling isSimpleContainerCompositingLayer() an extra time
simon.fraser@apple.com [Sat, 29 Jun 2013 20:22:19 +0000 (20:22 +0000)]
Avoid calling isSimpleContainerCompositingLayer() an extra time
https://bugs.webkit.org/show_bug.cgi?id=118218

Reviewed by Tim Horton.

containsPaintedContent() called isSimpleContainerCompositingLayer(), which
is not particularly cheap. But the caller already has this information,
so pass it in.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::containsPaintedContent):
* rendering/RenderLayerBacking.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid doing work in RenderBox::outlineBoundsForRepaint() when the repaintContainer...
simon.fraser@apple.com [Sat, 29 Jun 2013 20:19:43 +0000 (20:19 +0000)]
Avoid doing work in RenderBox::outlineBoundsForRepaint() when the repaintContainer is this
https://bugs.webkit.org/show_bug.cgi?id=118215

Reviewed by Tim Horton.

When the RenderGeometryMap code path was added, RenderBox::outlineBoundsForRepaint()
actually got slower if no coordinate mapping was needed. So avoid doing work when
we can, including avoiding the FloatQuad construction.

Speeds up scrolling overflow:scroll areas with large numbers of layer children.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::outlineBoundsForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdopt is/toHTMLOptGroupElement for code cleanup
kangil.han@samsung.com [Sat, 29 Jun 2013 15:49:55 +0000 (15:49 +0000)]
Adopt is/toHTMLOptGroupElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118213

Reviewed by Andreas Kling.

To enhance readability, this patch adopts is/toHTMLOptGroupElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isEnabled):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
* html/HTMLOptGroupElement.h:
(WebCore::isHTMLOptGroupElement):
(WebCore::toHTMLOptGroupElement):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
(WebCore::HTMLOptionElement::isDisabledFormControl):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::recalcListItems):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::hasImpliedEndTag):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isSelectScopeMarker):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemIsLabel):

Source/WebKit/blackberry:

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openSelectPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix for unguarded SVGGraphicsElement
commit-queue@webkit.org [Sat, 29 Jun 2013 15:15:10 +0000 (15:15 +0000)]
Build fix for unguarded SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118214

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-06-29
Reviewed by Christophe Dumez.

Add the SVG condition to SVGGraphicsElement.idl

No new tests required since no functionality changed.

* svg/SVGGraphicsElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFollow-up to r152206: also update HashFlags8BitBuffer in the LLInt.
akling@apple.com [Sat, 29 Jun 2013 14:59:31 +0000 (14:59 +0000)]
Follow-up to r152206: also update HashFlags8BitBuffer in the LLInt.

* llint/LowLevelInterpreter.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdopt is/toHTMLOptionElement for code cleanup
kangil.han@samsung.com [Sat, 29 Jun 2013 08:18:46 +0000 (08:18 +0000)]
Adopt is/toHTMLOptionElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118212

Reviewed by Andreas Kling.

To enhance readability, this patch adopts is/toHTMLOptionElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::setElement):
(WebCore::AccessibilityMenuListOption::isEnabled):
(WebCore::AccessibilityMenuListOption::isSelected):
(WebCore::AccessibilityMenuListOption::setSelected):
(WebCore::AccessibilityMenuListOption::stringValue):
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
* html/HTMLCollection.cpp:
(WebCore::isMatchingElement):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::index):
* html/HTMLOptionElement.h:
(WebCore::isHTMLOptionElement):
(WebCore::toHTMLOptionElement):
* html/HTMLOptionsCollection.cpp:
(WebCore::HTMLOptionsCollection::add):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::hasImpliedEndTag):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isSelectScopeMarker):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemIsSelected):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):

Source/WebKit/blackberry:

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
(BlackBerry::WebKit::InputHandler::didNodeOpenPopup):
(BlackBerry::WebKit::InputHandler::openSelectPopup):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
* WebKitSupport/SelectPopupClient.cpp:
(BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):

Source/WebKit/win:

* DOMCoreClasses.cpp:
(DOMElement::createInstance):
* DOMHTMLClasses.cpp:
(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(151586): multipart/x-mixed-replace images are broken
carlosgc@webkit.org [Sat, 29 Jun 2013 07:25:37 +0000 (07:25 +0000)]
REGRESSION(151586): multipart/x-mixed-replace images are broken
https://bugs.webkit.org/show_bug.cgi?id=118169

Reviewed by Alexey Proskuryakov.

When loading multipart content the resource data will change as
the next part is loaded, so we need to make a copy of the data
before sending it to the resource.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUn-crashify JSC tests on debug bots after Anders had his way with StringImpl.
akling@apple.com [Sat, 29 Jun 2013 06:02:59 +0000 (06:02 +0000)]
Un-crashify JSC tests on debug bots after Anders had his way with StringImpl.

* llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix Windows builds after deprecatedCharactersWithNullTermination() removal.
akling@apple.com [Sat, 29 Jun 2013 05:53:23 +0000 (05:53 +0000)]
Fix Windows builds after deprecatedCharactersWithNullTermination() removal.

Source/WebKit2:

* Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::createServerAndClientIdentifiers):

Tools:

* DumpRenderTree/win/DumpRenderTree.cpp:
(addFontFallbackIfPresent):
(removeFontFallbackIfPresent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] adopt new AVFoundation caption API
eric.carlson@apple.com [Sat, 29 Jun 2013 02:55:52 +0000 (02:55 +0000)]
[Mac] adopt new AVFoundation caption API
https://bugs.webkit.org/show_bug.cgi?id=118207

Reviewed by Dean Jackson.

No new tests, I was not able to come up with a reliable layout test.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::flushCues): New, call currentTrack->resetCueValues().
(-[WebCoreAVFMovieObserver outputSequenceWasFlushed:]): New delegate method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdopt is/toHTMLImageElement for code cleanup
kangil.han@samsung.com [Sat, 29 Jun 2013 02:41:54 +0000 (02:41 +0000)]
Adopt is/toHTMLImageElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118182

Reviewed by Andreas Kling.

To enhance readability, this patch adopts is/toHTMLImageElement.
This also helps out to reduce duplicated use of static_cast.

Source/WebCore:

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isNativeImage):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::url):
* bindings/js/JSNodeCustom.cpp:
(WebCore::isReachableFromDOM):
* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::QtPixmapRuntime::toQt):
* dom/Clipboard.cpp:
(WebCore::Clipboard::setDragImage):
* dom/Node.cpp:
(WebCore::Node::enclosingLinkEventParentOrSelf):
* editing/Editor.cpp:
(WebCore::imageElementFromImageDocument):
* html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition):
* html/HTMLImageElement.h:
(WebCore::isHTMLImageElement):
(WebCore::toHTMLImageElement):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):
* html/HTMLNameCollection.cpp:
(WebCore::WindowNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::nodeMatches):
* page/DragController.cpp:
(WebCore::DragController::draggableElement):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::getURLForImageNode):
* platform/mac/HTMLConverter.mm:
(+[WebHTMLConverter editingAttributedStringFromRange:]):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
(BlackBerry::WebKit::WebPage::blockZoom):
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPageThrottler::shouldThrottleTimers is wrong.
barraclough@apple.com [Sat, 29 Jun 2013 01:45:04 +0000 (01:45 +0000)]
PageThrottler::shouldThrottleTimers is wrong.
https://bugs.webkit.org/show_bug.cgi?id=118210

Reviewed by Anders Carlson.

m_throttleState == PageNotThrottledState
    -> page NOT throttled, so should NOT throttle timers
m_throttleState != PageNotThrottledState
    -> page NOT NOT throttled, so should throttle timers

This needs cleaning up, but for now, 1 character fix.

* page/PageThrottler.h:
(WebCore::PageThrottler::shouldThrottleTimers):
    == -> !=

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove String::deprecatedCharactersWithNullTermination() and related code
andersca@apple.com [Sat, 29 Jun 2013 01:39:28 +0000 (01:39 +0000)]
Remove String::deprecatedCharactersWithNullTermination() and related code
https://bugs.webkit.org/show_bug.cgi?id=118211

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

* API/JSStringRef.cpp:
(JSStringCreateWithCharactersNoCopy):
Update call to StringImpl::createWithoutCopying.

Source/WTF:

Remove String::deprecatedCharactersWithNullTermination, StringImpl::createWithTerminatingNullCharacter
and the s_hashFlagHasTerminatingNullCharacter flag. We no longer care about whether strings have a
terminating null character.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::createWithoutCopying):
(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::sizeInBytes):
* wtf/text/StringImpl.h:
(WTF::StringImpl::StringImpl):
(WTF::StringImpl::createFromLiteral):
(WTF::StringImpl::isolatedCopy):
* wtf/text/WTFString.cpp:
* wtf/text/WTFString.h:

Tools:

Remove all hasTerminatingNullCharacter() checks.

* TestWebKitAPI/Tests/WTF/AtomicString.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/WTFString.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate Apple System fonts in auto-complete
dino@apple.com [Sat, 29 Jun 2013 01:39:20 +0000 (01:39 +0000)]
Update Apple System fonts in auto-complete
https://bugs.webkit.org/show_bug.cgi?id=118205
<rdar://problem/14308488>

Reviewed by Joseph Pecoraro.

Update for the new Apple System font names, and remove some invalid entries.

* UserInterface/CSSKeywordCompletions.js: General cleanup. Note that
"apple-system-short-caption2" looks like it was accidentally omitted. It wasn't :)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
commit-queue@webkit.org [Sat, 29 Jun 2013 01:25:43 +0000 (01:25 +0000)]
Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
https://bugs.webkit.org/show_bug.cgi?id=118122

Patch by James Craig <james@cookiecrook.com> on 2013-06-28
Reviewed by Timothy Hatcher.

Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
so that screen readers will not indicate a bogus :required/:invalid state to the user.
Minor cosmetic difference blocked by http://webkit.org/b/118162

* UserInterface/FilterBar.css:
(.filter-bar > input[type="search"]:focus):
(.filter-bar > input[type="search"]:not(:placeholder-shown)):
* UserInterface/FilterBar.js:
(WebInspector.FilterBar):
* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
* UserInterface/SearchBar.css:
(.search-bar > input[type="search"]:focus):
(.search-bar > input[type="search"]:not(:placeholder-shown)):
* UserInterface/SearchBar.js:
(WebInspector.SearchBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAn element with -webkit-user-select: all should be selected on single click
rniwa@webkit.org [Sat, 29 Jun 2013 00:09:09 +0000 (00:09 +0000)]
An element with -webkit-user-select: all should be selected on single click
https://bugs.webkit.org/show_bug.cgi?id=117864

Reviewed by Darin Adler.

Source/WebCore:

Set m_mouseDownMayStartSelect true even when the node cannot start selection
if the node was inside an element with -webkit-user-select: all.

Test: editing/selection/user-select-all-with-single-click.html

* page/EventHandler.cpp:
(WebCore::canMouseDownStartSelect):

LayoutTests:

Add tests for single clicking on an element with user-select: all.
We select the entire element regardless of whether the user had clicked on text or an image
to be consistent even though Firefox requires a double click on the latter case.

* editing/selection/user-select-all-with-image-single-click-expected.txt: Added.
* editing/selection/user-select-all-with-image-single-click.html: Added.
* editing/selection/user-select-all-with-single-click-expected.txt: Added.
* editing/selection/user-select-all-with-single-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unused attachChildrenLazily method and make attach/detachChildren private
rniwa@webkit.org [Sat, 29 Jun 2013 00:01:37 +0000 (00:01 +0000)]
Remove unused attachChildrenLazily method and make attach/detachChildren private
https://bugs.webkit.org/show_bug.cgi?id=118016

Reviewed by Darin Adler.

Merge https://chromium.googlesource.com/chromium/blink/+/009520dc31c9458e0cf71cf212fa5688c4ca68b0

No one should be manually trying to attach or detach all their children so there's
no reason for these methods to be public.

In doing this I realized that attachChildrenLazily is not used and can be removed.

I also realized that we were detaching all our children before the ShadowRoots which
is sad since the InsertionPoints will call detach() on them as well, and then when we
call ContainerNode::detach at the end of Element::detach we'll go detach them again!
This patch makes it so we only go through and detach them twice instead of three times.
In the future we should figure out a way to only do this once.

* dom/ContainerNode.h:
* dom/Element.cpp:
(WebCore::Element::detach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago [Mac] Crash when loading is stopped from -didReceiveResponse
ap@apple.com [Fri, 28 Jun 2013 23:57:16 +0000 (23:57 +0000)]
    [Mac] Crash when loading is stopped from -didReceiveResponse
        https://bugs.webkit.org/show_bug.cgi?id=118209
        <rdar://problem/14259249>

        Reviewed by Brady Eidson.

        Test: TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm.

        * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse):
        Added yet another check for reachedTerminalState().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Newer versions of clang use a default template instantiation depth that is...
aestes@apple.com [Fri, 28 Jun 2013 23:40:09 +0000 (23:40 +0000)]
[Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=118208

Reviewed by Mark Rowe.

Newer versions of clang use a default template depth of 128, but this
is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
previous default.

Clang lowered the default to keep recursive template instantiation
from overflowing the stack (see <rdar://problem/13935016>), but
TestWebKitAPI's C++ files don't trigger a stack overflow even with the
higher limit. If for some reason this starts happening then we can
lower the limit back down.

* TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCached pages don't update their backing scale factor when it changes
bdakin@apple.com [Fri, 28 Jun 2013 23:11:39 +0000 (23:11 +0000)]
Cached pages don't update their backing scale factor when it changes
https://bugs.webkit.org/show_bug.cgi?id=118206
-and-
<rdar://problem/14261627>

Reviewed by Tim Horton.

It is not sufficient to mark pages in the PageCache as needing a full style
recalc. We also need to ensure that the RenderLayerCompositors for the CachesPages
get updated.

Keep track of whether device scale has been updated with
m_needsDeviceScaleChanged. If that has been marked true, then restore() will call
Frame::deviceOrPageScaleFactorChanged().
* history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
(WebCore::CachedPage::restore):
* history/CachedPage.h:
(WebCore::CachedPage::markForDeviceScaleChanged):

Propagate markForDeviceScaleChanged() to all of the CachedPages.
* history/PageCache.cpp:
(WebCore::PageCache::markPagesForDeviceScaleChanged):
* history/PageCache.h:

Call PageCache::markPagesForDeviceScaleChanged()
* page/Page.cpp:
(WebCore::Page::setDeviceScaleFactor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded template parameters to std::min to fix compile errors in Visual Studio x64.
achristensen@apple.com [Fri, 28 Jun 2013 22:48:13 +0000 (22:48 +0000)]
Added template parameters to std::min to fix compile errors in Visual Studio x64.
https://bugs.webkit.org/show_bug.cgi?id=118204

Reviewed by Geoffrey Garen.

* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeURLToDataObject): Added <unsigned> to std::min.
(WebCore::createGlobalImageFileDescriptor): Added <int> to std::min.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded WebGL files to Windows build.
achristensen@apple.com [Fri, 28 Jun 2013 22:43:33 +0000 (22:43 +0000)]
Added WebGL files to Windows build.
https://bugs.webkit.org/show_bug.cgi?id=118200

Reviewed by Brent Fulgham.

* WebCore.vcxproj/WebCore.vcxproj: Added WebGL files, removed unused GraphicsContext3DOpenGLES.cpp.
* WebCore.vcxproj/WebCore.vcxproj.filters: Added WebGL files, removed unused GraphicsContext3DOpenGLES.cpp.
* platform/graphics/cairo/GLContext.cpp: Only include GLContextEGL.h or GLContextGLX.h if they're needed.
* platform/graphics/cg/GraphicsContext3DCG.cpp: Only include GraphicsContext3DNEON.h if it's needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
commit-queue@webkit.org [Fri, 28 Jun 2013 22:21:03 +0000 (22:21 +0000)]
[Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
https://bugs.webkit.org/show_bug.cgi?id=118195

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-06-28
Reviewed by Daniel Bates.

Currently, ports that use jhbuild fail to determine jhbuild directory
when "webKitBranchBuild" git configuration property is enabled. To reproduce
that issue in Efl port, enable that flag in .git/config, switch to a git branch
other than "master" and try to build webkit. The build will fail to
locate dependencies due to lack of pkg-config paths which should be set
by jhbuild.

For more details about "webKitBranchBuild" option, see:
https://trac.webkit.org/wiki/UsingGitWithWebKit

* Scripts/webkitdirs.pm:
(getJhbuildPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[wk2] WKView shouldn't force scrolling off if shouldClipToVisibleRect is set
timothy_horton@apple.com [Fri, 28 Jun 2013 22:15:53 +0000 (22:15 +0000)]
[wk2] WKView shouldn't force scrolling off if shouldClipToVisibleRect is set
https://bugs.webkit.org/show_bug.cgi?id=118174
<rdar://problem/14301175>

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView _updateViewExposedRect]):
Pass whether or not clips-to-visibleRect is enabled down to the WebPageProxy.

(-[WKView setMinimumSizeForAutoLayout:]):
Disable scrolling when using autolayout instead of when using clips-to-visibleRect.

(-[WKView setShouldClipToVisibleRect:]):
Clipping to the WKView's visibleRect does not strictly require scrolling to be disabled,
and in fact there are cases (RTL/TB pagination) where we *must* scroll, even when the view
is big enough to fit the content (the case clip-to-visibleRect was added for).

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged):
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
Keep track of and forward to the drawing area whether or not clips-to-visibleRect is enabled.

* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setClipsToExposedRect): Added.
(WebKit::DrawingArea::didChangeScrollOffsetForAnyFrame): Added a missing space.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewExposedRectChanged):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
Forward clips-to-visibleRect enabled state to the drawing area.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
Add storage for m_clipsToExposedRect.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::updateMainFrameClipsToExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
Check m_clipsToExposedRect instead of the main-frame's isScrollable() to determine
whether we should tell our TiledBackings to clip to the exposed rect we provide.

We don't need to listen to mainFrameScrollabilityChanged anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebKitTestRunner should disable automatic quote and dash substitution like DumpRender...
jberlin@webkit.org [Fri, 28 Jun 2013 21:45:26 +0000 (21:45 +0000)]
WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
https://bugs.webkit.org/show_bug.cgi?id=118201

Reviewed by Dean Jackson.

* WebKitTestRunner/mac/main.mm:
(main):
Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
setAutomaticDashSubstitutionEnabled are not exposed on WKView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStale occlusion state after moving page back into window
barraclough@apple.com [Fri, 28 Jun 2013 20:40:43 +0000 (20:40 +0000)]
Stale occlusion state after moving page back into window
https://bugs.webkit.org/show_bug.cgi?id=118202

Reviewed by Anders Carlsson.

We need to update the occlusion state when the page goes back into the window.

* UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
    - update occlusion state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpstream WebKit Nightly’s WebKitLauncher
dfarler@apple.com [Fri, 28 Jun 2013 20:38:55 +0000 (20:38 +0000)]
Upstream WebKit Nightly’s WebKitLauncher
https://bugs.webkit.org/show_bug.cgi?id=117418

Reviewed by Mark Rowe.

Literal patch from Nightly's OpenSource repo.

* WebKitLauncher/Configurations/Base.xcconfig:
* WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
* WebKitLauncher/Info.plist:
* WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
* WebKitLauncher/WebKitLauncherURLProtocol.m:
(+[WebKitLauncherURLProtocol load]):
(+[WebKitLauncherURLProtocol canInitWithRequest:]):
(-[WebKitLauncherURLProtocol startLoading]):
(-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
(-[WebKitLauncherURLProtocol resourceNotFound]):
* WebKitLauncher/WebKitNightlyEnablerSparkle.m:
(initializeSparkle):
* WebKitLauncher/main.m:
(determineExecutablePath):
(currentMacOSXVersion):
(main):
* WebKitLauncher/start.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago-webkit-line-break: after-white-space sometimes truncates DOM on copy & paste
rniwa@webkit.org [Fri, 28 Jun 2013 19:59:04 +0000 (19:59 +0000)]
-webkit-line-break: after-white-space sometimes truncates DOM on copy & paste
https://bugs.webkit.org/show_bug.cgi?id=118164

Reviewed by Sam Weinig.

Source/WebCore:

We can't assume that all subsequent ancestors contain exactly one child since they could have been
added in the first if statement matching: currentNode->parentNode() != rootNode && isRemovableBlock(currentNode)

Exit early when we encounter such an ancestor since removing its ancestor (that contains multiple children
some of which aren't in nodesToRemove) can clobber more nodes than we're allowed to remove.

Test: editing/pasteboard/simplfiying-markup-should-not-strip-content.html

* editing/SimplifyMarkupCommand.cpp:
(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove):

LayoutTests:

Add a regression test.

* editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt: Added.
* editing/pasteboard/simplfiying-markup-should-not-strip-content.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agomedia/video-currentTime.html flakey
jer.noble@apple.com [Fri, 28 Jun 2013 19:55:18 +0000 (19:55 +0000)]
media/video-currentTime.html flakey
https://bugs.webkit.org/show_bug.cgi?id=118198

Reviewed by Jessie Berlin.

Update video-currentTime.html so that it listens for timeupdate events, and ends the test
after the first one with a >0 currentTime. Add a 3s watchdog for the failure case.

* media/video-currentTime-expected.txt:
* media/video-currentTime.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCoordinated Graphics: Separate CoordinatedLayerTreeHost into CoordinatedLayerTreeHost...
commit-queue@webkit.org [Fri, 28 Jun 2013 19:09:52 +0000 (19:09 +0000)]
Coordinated Graphics: Separate CoordinatedLayerTreeHost into CoordinatedLayerTreeHost and CompositingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=104360

Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-06-28
Reviewed by Noam Rosenthal.

The CoordinatedLayerTreeHost has too many responsibilities. It
implements LayerTreeHost, GraphicsLayerClient,
CoordinatedGraphicsLayerClient, CoordinatedImageBacking::Client,
UpdateAtlas::Client, GraphicsLayerFactory and
WebCustomFilterProgramProxyClient.

This refactoring reduces the responsibilities of CoordinatedLayerTreeHost.

This patch introduces a new class called CompositingCoordinator, which
takes the responsibility of managing compositing resources in
WebProcess.

CoordinatedLayerTreeHost is responsible only for the scheduling and
IPC-specific stuff, which are relevant only for WebKit2.

No new tests, covered by existing tests.

Source/WebCore:

* CMakeLists.txt:
* Target.pri:
* platform/graphics/texmap/coordinated/CompositingCoordinator.cpp: Added.
(WebCore::CompositingCoordinator::create):
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::setRootCompositingLayer):
(WebCore::CompositingCoordinator::sizeDidChange):
(WebCore::CompositingCoordinator::flushPendingLayerChanges):
(WebCore::CompositingCoordinator::syncDisplayState):
(WebCore::CompositingCoordinator::nextAnimationServiceTime):
(WebCore::CompositingCoordinator::clearPendingStateChanges):
(WebCore::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebCore::CompositingCoordinator::createRootLayer):
(WebCore::CompositingCoordinator::syncLayerState):
(WebCore::CompositingCoordinator::createImageBackingIfNeeded):
(WebCore::CompositingCoordinator::createImageBacking):
(WebCore::CompositingCoordinator::updateImageBacking):
(WebCore::CompositingCoordinator::clearImageBackingContents):
(WebCore::CompositingCoordinator::removeImageBacking):
(WebCore::CompositingCoordinator::flushPendingImageBackingChanges):
(WebCore::CompositingCoordinator::notifyAnimationStarted):
(WebCore::CompositingCoordinator::notifyFlushRequired):
(WebCore::CompositingCoordinator::paintContents):
(WebCore::CompositingCoordinator::createGraphicsLayer):
(WebCore::CompositingCoordinator::deviceScaleFactor):
(WebCore::CompositingCoordinator::pageScaleFactor):
(WebCore::CompositingCoordinator::createUpdateAtlas):
(WebCore::CompositingCoordinator::removeUpdateAtlas):
(WebCore::CompositingCoordinator::visibleContentsRect):
(WebCore::CompositingCoordinator::mainContentsLayer):
(WebCore::CompositingCoordinator::setVisibleContentsRect):
(WebCore::CompositingCoordinator::deviceOrPageScaleFactorChanged):
(WebCore::CompositingCoordinator::detachLayer):
(WebCore::CompositingCoordinator::commitScrollOffset):
(WebCore::CompositingCoordinator::renderNextFrame):
(WebCore::CompositingCoordinator::purgeBackingStores):
(WebCore::CompositingCoordinator::paintToSurface):
(WebCore::CompositingCoordinator::scheduleReleaseInactiveAtlases):
(WebCore::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
* platform/graphics/texmap/coordinated/CompositingCoordinator.h: Added.
(WebCore::CompositingCoordinator::clearRootLayer):
(WebCore::CompositingCoordinator::rootLayer):
(WebCore::CompositingCoordinator::state):

Source/WebKit2:

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::~CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::invalidate):
(WebKit::CoordinatedLayerTreeHost::forceRepaint):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::CoordinatedLayerTreeHost::renderNextFrame):
(WebKit::CoordinatedLayerTreeHost::purgeBackingStores):
(WebKit::CoordinatedLayerTreeHost::willSyncLayerState):
(WebKit::CoordinatedLayerTreeHost::prepareCustomFilterProxiesForAnimations):
(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):
(WebKit::CoordinatedLayerTreeHost::removeCustomFilterProgramProxy):
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):
(WebKit::CoordinatedLayerTreeHost::createPageOverlayLayer):
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::CoordinatedLayerTreeHost::graphicsLayerFactory):
(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):
(WebKit::CoordinatedLayerTreeHost::commitScrollOffset):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
* WebProcess/WebPage/LayerTreeHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake the UI process run the Java Updater
andersca@apple.com [Fri, 28 Jun 2013 18:57:39 +0000 (18:57 +0000)]
Make the UI process run the Java Updater
https://bugs.webkit.org/show_bug.cgi?id=118197
<rdar://problem/14255677>

Reviewed by Sam Weinig.

Patch the relevant NSWorkspace method and pipe through the request to launch the Java updater to the UI process.

* PluginProcess/PluginProcess.h:
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::replacedNSWorkspace_launchApplicationAtURL_options_configuration_error):
(WebKit::initializeCocoaOverrides):
(WebKit::PluginProcess::launchApplicationAtURL):
* UIProcess/Plugins/PluginProcessProxy.h:
* UIProcess/Plugins/PluginProcessProxy.messages.in:
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::isJavaUpdaterURL):
(WebKit::shouldLaunchApplicationAtURL):
(WebKit::PluginProcessProxy::launchApplicationAtURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r152135.
commit-queue@webkit.org [Fri, 28 Jun 2013 18:47:55 +0000 (18:47 +0000)]
Unreviewed, rolling out r152135.
http://trac.webkit.org/changeset/152135
https://bugs.webkit.org/show_bug.cgi?id=118199

Rolling out temporary patch used for debugging the test bots
(Requested by rfong on #webkit).

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::load):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate TestExpectations so new Shapes tests are skipped where the old ones were
commit-queue@webkit.org [Fri, 28 Jun 2013 18:08:13 +0000 (18:08 +0000)]
Update TestExpectations so new Shapes tests are skipped where the old ones were
https://bugs.webkit.org/show_bug.cgi?id=118192

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-06-28
Reviewed by Brent Fulgham.

Shapes still aren't enabled on some ports, so skip the tests there.
As part of this patch, it was discovered that they work on EFL, so the
skipping has been removed from there.

* platform/efl/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] back/forward keyboard shortcuts are non-intuitive
commit-queue@webkit.org [Fri, 28 Jun 2013 18:07:44 +0000 (18:07 +0000)]
[EFL] back/forward keyboard shortcuts are non-intuitive
https://bugs.webkit.org/show_bug.cgi?id=118193

Patch by Balazs Kelemen <b.kelemen@samsung.com> on 2013-06-28
Reviewed by Christophe Dumez.

Changed shortcuts for go-back/go-forward to alt+left and alt+right.

* EWebLauncher/main.c:
(on_key_down):
* MiniBrowser/efl/main.c:
(on_key_down):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSVG relayout problem when displayed with different image box heights
commit-queue@webkit.org [Fri, 28 Jun 2013 18:00:53 +0000 (18:00 +0000)]
SVG relayout problem when displayed with different image box heights
https://bugs.webkit.org/show_bug.cgi?id=118140

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-28
Reviewed by Philip Rogers.

Source/WebCore:

If the root element is an SVG, its position and height are affected
by the view height.

Test: svg/as-image/same-source-different-height.html

* rendering/RenderView.cpp:
(WebCore::RenderView::layout):

LayoutTests:

* svg/as-image/same-source-different-height-expected.html: Added.
* svg/as-image/same-source-different-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWARN_UNUSED_RESULT can't be used in API headers, but WKBundlePageExtendIncrementalRen...
timothy_horton@apple.com [Fri, 28 Jun 2013 17:54:50 +0000 (17:54 +0000)]
WARN_UNUSED_RESULT can't be used in API headers, but WKBundlePageExtendIncrementalRenderingSuppression tries to
https://bugs.webkit.org/show_bug.cgi?id=118196
<rdar://problem/14303613>

Reviewed by Anders Carlsson.

* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
roger_fong@apple.com [Fri, 28 Jun 2013 17:54:00 +0000 (17:54 +0000)]
Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
https://bugs.webkit.org/show_bug.cgi?id=118194.

Reviewed by Brent Fulgham.

* DumpRenderTree/win/DumpRenderTree.cpp:
(dllLauncherEntryPoint):
* WinLauncher/WinLauncher.cpp:
(dllLauncherEntryPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAllow some LayoutPoint and LayoutSize conversions to be inlined
simon.fraser@apple.com [Fri, 28 Jun 2013 17:31:30 +0000 (17:31 +0000)]
Allow some LayoutPoint and LayoutSize conversions to be inlined
https://bugs.webkit.org/show_bug.cgi?id=118167

Reviewed by Ryosuke Niwa.

Construction of FloatSize from LayoutSize, and FloatPoint's move(const LayoutSize&)
and moveBy(const LayoutPoint&) were not inlined, and showed up on some profiles.

Make them inlined by removing the overloaded functions, and instead providing
conversion operators from LayoutSize to FloatSize, and LayoutPoint to FloatPoint.
Do the same to allow a LayoutRect to be converted to a FloatRect.

This is nice because it removes pollution of FloatRect, FloatPoint and FloatSize with
Layout* entirely.

Remove Qt-specific conversions on LayoutRect, LayoutPoint and LayoutSize. Qt can
convert via IntRect/FloatRect as necessary.

* platform/graphics/FloatPoint.cpp:
* platform/graphics/FloatPoint.h:
(WebCore::FloatPoint::move):
(WebCore::FloatPoint::moveBy):
* platform/graphics/FloatRect.cpp:
* platform/graphics/FloatRect.h:
* platform/graphics/FloatSize.cpp:
* platform/graphics/FloatSize.h:
* platform/graphics/LayoutPoint.h:
(WebCore::LayoutPoint::operator FloatPoint):
* platform/graphics/LayoutRect.cpp:
* platform/graphics/LayoutRect.h:
(WebCore::LayoutRect::operator FloatRect):
* platform/graphics/LayoutSize.h:
(WebCore::LayoutSize::operator FloatSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix for AppleWin port. Fix some file paths.
roger_fong@apple.com [Fri, 28 Jun 2013 17:13:41 +0000 (17:13 +0000)]
Unreviewed build fix for AppleWin port. Fix some file paths.

* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoaccessibility/media-element.html does not support platforms without subroles
mario@webkit.org [Fri, 28 Jun 2013 16:39:33 +0000 (16:39 +0000)]
accessibility/media-element.html does not support platforms without subroles
https://bugs.webkit.org/show_bug.cgi?id=118187

Reviewed by Chris Fleizach.

Update the test to be more friendly with platforms not supporting subroles.

* accessibility/media-element.html: Updated test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd IAccessibilityDelegate implementation to WinLauncher for testing purposes.
roger_fong@apple.com [Fri, 28 Jun 2013 16:23:18 +0000 (16:23 +0000)]
Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
https://bugs.webkit.org/show_bug.cgi?id=118160.

Reviewed by Brent Fulgham.

* WinLauncher/AccessibilityDelegate.cpp: Added.
(AccessibilityDelegate::QueryInterface):
(AccessibilityDelegate::AddRef):
(AccessibilityDelegate::Release):
(AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
(AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
* WinLauncher/AccessibilityDelegate.h: Added.
(AccessibilityDelegate::AccessibilityDelegate):
* WinLauncher/WinLauncher.cpp:
(dllLauncherEntryPoint):
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up temporary files created by the bindings test script
ch.dumez@sisa.samsung.com [Fri, 28 Jun 2013 16:08:24 +0000 (16:08 +0000)]
Clean up temporary files created by the bindings test script
https://bugs.webkit.org/show_bug.cgi?id=118189

Reviewed by Kentaro Hara.

Remove temporary files created by preprocess-idls.pl script after
the bindings tests are executed.

Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.

* Scripts/webkitpy/bindings/main.py:
(BindingsTests.main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Compilation error.
commit-queue@webkit.org [Fri, 28 Jun 2013 16:07:37 +0000 (16:07 +0000)]
[WinCairo] Compilation error.
https://bugs.webkit.org/show_bug.cgi?id=118131

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-06-28
Reviewed by Brent Fulgham.

* Interfaces/IWebView.idl: Include needed accessibility interface.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::AXFinishFrameLoad): Accessibility methods should not be inside FULLSCREEN_API ifdef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes
ch.dumez@sisa.samsung.com [Fri, 28 Jun 2013 16:01:32 +0000 (16:01 +0000)]
Get rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes
https://bugs.webkit.org/show_bug.cgi?id=118191

Reviewed by Kentaro Hara.

Remove WebKit-specific [IsWorkerGlobalScope] and [ExtendsDOMGlobalObject] IDL
extended attributes and update the JSC bindings generator to figure this out
on its own.

No new tests, no behavior change.

* bindings/scripts/CodeGeneratorJS.pm:
(IsDOMGlobalObject):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorHelperMethods):
* bindings/scripts/IDLAttributes.txt:
* page/DOMWindow.idl:
* workers/DedicatedWorkerGlobalScope.idl:
* workers/SharedWorkerGlobalScope.idl:
* workers/WorkerGlobalScope.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIntroduce SVGGraphicsElement IDL interface
ch.dumez@sisa.samsung.com [Fri, 28 Jun 2013 15:58:03 +0000 (15:58 +0000)]
Introduce SVGGraphicsElement IDL interface
https://bugs.webkit.org/show_bug.cgi?id=118178

Reviewed by Kentaro Hara.

Source/WebCore:

Introduce SVGGraphicsElement IDL interface as per the latest SVG
specification:
- https://svgwg.org/svg2-draft/types.html#InterfaceSVGGraphicsElement

SVGGraphicsElement is a merge of SVGLocatable and SVGTransformable.
This is one step towards simplifying inheritance in SVG and matching
the latest SVG2 specification.

No new tests, already covered by existing tests.

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.order:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
* rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::RenderSVGEllipse):
* rendering/svg/RenderSVGEllipse.h:
* rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::RenderSVGPath):
* rendering/svg/RenderSVGPath.h:
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
* rendering/svg/RenderSVGResourceMarker.cpp:
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::RenderSVGShape):
(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::nonScalingStrokeTransform):
(WebCore::RenderSVGShape::shouldGenerateMarkerPositions):
* rendering/svg/RenderSVGShape.h:
* rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::RenderSVGTransformableContainer):
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
* rendering/svg/RenderSVGTransformableContainer.h:
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::SVGAElement):
(WebCore::SVGAElement::parseAttribute):
(WebCore::SVGAElement::svgAttributeChanged):
(WebCore::SVGAElement::defaultEventHandler):
(WebCore::SVGAElement::supportsFocus):
(WebCore::SVGAElement::isURLAttribute):
* svg/SVGAElement.h:
* svg/SVGAElement.idl:
* svg/SVGAllInOne.cpp:
* svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
* svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::SVGCircleElement):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):
* svg/SVGCircleElement.h:
* svg/SVGCircleElement.idl:
* svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::SVGClipPathElement):
(WebCore::SVGClipPathElement::parseAttribute):
(WebCore::SVGClipPathElement::svgAttributeChanged):
(WebCore::SVGClipPathElement::childrenChanged):
* svg/SVGClipPathElement.h:
* svg/SVGClipPathElement.idl:
* svg/SVGDefsElement.cpp:
(WebCore::SVGDefsElement::SVGDefsElement):
* svg/SVGDefsElement.h:
* svg/SVGDefsElement.idl:
* svg/SVGElement.h:
(WebCore::SVGElement::isSVGGraphicsElement):
* svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::SVGEllipseElement):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):
* svg/SVGEllipseElement.h:
* svg/SVGEllipseElement.idl:
* svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
(WebCore::SVGForeignObjectElement::rendererIsNeeded):
* svg/SVGForeignObjectElement.h:
* svg/SVGForeignObjectElement.idl:
* svg/SVGGElement.cpp:
(WebCore::SVGGElement::SVGGElement):
(WebCore::SVGGElement::parseAttribute):
(WebCore::SVGGElement::svgAttributeChanged):
* svg/SVGGElement.h:
* svg/SVGGElement.idl:
* svg/SVGGraphicsElement.cpp: Renamed from Source/WebCore/svg/SVGStyledTransformableElement.cpp.
(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::~SVGGraphicsElement):
(WebCore::SVGGraphicsElement::getCTM):
(WebCore::SVGGraphicsElement::getScreenCTM):
(WebCore::SVGGraphicsElement::animatedLocalTransform):
(WebCore::SVGGraphicsElement::supplementalTransform):
(WebCore::SVGGraphicsElement::isSupportedAttribute):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
(WebCore::SVGGraphicsElement::nearestViewportElement):
(WebCore::SVGGraphicsElement::farthestViewportElement):
(WebCore::SVGGraphicsElement::getBBox):
(WebCore::SVGGraphicsElement::createRenderer):
(WebCore::SVGGraphicsElement::toClipPath):
* svg/SVGGraphicsElement.h: Renamed from Source/WebCore/svg/SVGStyledTransformableElement.h.
(WebCore::SVGGraphicsElement::localCoordinateSpaceTransform):
(WebCore::SVGGraphicsElement::synchronizeRequiredFeatures):
(WebCore::SVGGraphicsElement::synchronizeRequiredExtensions):
(WebCore::SVGGraphicsElement::synchronizeSystemLanguage):
(WebCore::toSVGGraphicsElement):
* svg/SVGGraphicsElement.idl: Copied from Source/WebCore/svg/SVGForeignObjectElement.idl.
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::SVGImageElement):
(WebCore::SVGImageElement::isPresentationAttribute):
(WebCore::SVGImageElement::collectStyleForPresentationAttribute):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):
(WebCore::SVGImageElement::attach):
(WebCore::SVGImageElement::insertedInto):
(WebCore::SVGImageElement::addSubresourceAttributeURLs):
(WebCore::SVGImageElement::didMoveToNewDocument):
* svg/SVGImageElement.h:
* svg/SVGImageElement.idl:
* svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::SVGLineElement):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):
* svg/SVGLineElement.h:
* svg/SVGLineElement.idl:
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::insertedInto):
(WebCore::SVGPathElement::removedFrom):
* svg/SVGPathElement.h:
* svg/SVGPathElement.idl:
* svg/SVGPatternElement.cpp:
* svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::SVGPolyElement):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):
* svg/SVGPolyElement.h:
* svg/SVGPolygonElement.idl:
* svg/SVGPolylineElement.idl:
* svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::SVGRectElement):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):
* svg/SVGRectElement.h:
* svg/SVGRectElement.idl:
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::didMoveToNewDocument):
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):
* svg/SVGSVGElement.h:
* svg/SVGSVGElement.idl:
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::localCoordinateSpaceTransform):
* svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::SVGSwitchElement):
* svg/SVGSwitchElement.h:
* svg/SVGSwitchElement.idl:
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::insertedInto):
(WebCore::SVGUseElement::removedFrom):
(WebCore::SVGUseElement::svgAttributeChanged):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::finishParsingChildren):
* svg/SVGUseElement.h:
* svg/SVGUseElement.idl:

LayoutTests:

Rebaseline js/global-constructors-attributes.html test case now that
SVGGraphicsElement is exposed on the global Window object.

* fast/js/global-constructors-attributes-expected.txt:
* platform/efl/fast/js/global-constructors-attributes-expected.txt:
* platform/gtk/fast/js/global-constructors-attributes-expected.txt:
* platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
* platform/qt/fast/js/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't fire process-became-responsive callback when disconnecting it.
akling@apple.com [Fri, 28 Jun 2013 15:00:52 +0000 (15:00 +0000)]
Don't fire process-became-responsive callback when disconnecting it.
<http://webkit.org/b/118166>

Reviewed by Anders Carlsson.

When disconnecting from a web process, call ResponsivenessTimer::invalidate() instead of
stop() to avoid firing the didBecomeResponsive() callback.

This lets the UI process react faster to actually unresponsive processes.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][GTK] 100% CPU usage rendering a page with animations
sergio@webkit.org [Fri, 28 Jun 2013 14:49:24 +0000 (14:49 +0000)]
[WK2][GTK] 100% CPU usage rendering a page with animations
https://bugs.webkit.org/show_bug.cgi?id=117703

Reviewed by Martin Robinson.

Unconditionally update the value of m_lastFlushTime in
::flushAndRenderLayers. By doing that we avoid a neverending
sequence of layer flushes that happened when m_lastFlushTime==0
and flushPendingLayerChanges() was false. In that situation the
value m_lastFlushTime was never updated so a new flush was always
rescheduled.

* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::flushAndRenderLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152165 268f45cc-cd09-0410-ab3c-d52691b4dbfc