WebKit-https.git
6 years ago(CVE-2013-0786) [SECURITY] build_subselect() leaks the existence of products and...
ddkilzer@apple.com [Sat, 9 Mar 2013 05:54:10 +0000 (05:54 +0000)]
(CVE-2013-0786) [SECURITY] build_subselect() leaks the existence of products and components you cannot access
<https://bugzilla.mozilla.org/show_bug.cgi?id=824399>
<exp2://Ticket/14465628>

Applied "v5 patch, 3.6" to bugs.webkit.org.

* Bugzilla/Config/GroupSecurity.pm:
(get_param_list):
* buglist.cgi:
* report.cgi:
* template/en/default/admin/params/groupsecurity.html.tmpl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago(CVE-2013-0785) [SECURITY] XSS in show_bug.cgi when using an invalid page format
ddkilzer@apple.com [Sat, 9 Mar 2013 05:54:07 +0000 (05:54 +0000)]
(CVE-2013-0785) [SECURITY] XSS in show_bug.cgi when using an invalid page format
<https://bugzilla.mozilla.org/show_bug.cgi?id=842038>
<exp2://Ticket/14465628>

Applied "patch for 3.6 and 4.0, v1" to bugs.webkit.org.

* Bugzilla/Template.pm:
(get_format):
* show_bug.cgi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r145254, r145264, and r145288.
commit-queue@webkit.org [Sat, 9 Mar 2013 04:31:04 +0000 (04:31 +0000)]
Unreviewed, rolling out r145254, r145264, and r145288.
http://trac.webkit.org/changeset/145254
http://trac.webkit.org/changeset/145264
http://trac.webkit.org/changeset/145288
https://bugs.webkit.org/show_bug.cgi?id=111917

Test breakage hints at conceptual unsoundness (Requested by ap
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-08

Source/WebKit2:

* NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::invalidateSandboxExtensions):
* Shared/Downloads/Download.cpp:
(WebKit::Download::didFinish):
(WebKit::Download::didFail):
(WebKit::Download::didCancel):
* Shared/SandboxExtension.h:
(SandboxExtension):
(WebKit::SandboxExtension::invalidate):
* Shared/WebMemorySampler.cpp:
(WebKit::WebMemorySampler::stop):
* Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::SandboxExtension):
(WebKit::SandboxExtension::invalidate):
(WebKit::SandboxExtension::consume):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
(WebKit::WebPage::SandboxExtensionTracker::invalidate):
(WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension):
(WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad):
(WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):

LayoutTests:

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDFG overflow check elimination is too smart for its own good
fpizlo@apple.com [Sat, 9 Mar 2013 02:51:06 +0000 (02:51 +0000)]
DFG overflow check elimination is too smart for its own good
https://bugs.webkit.org/show_bug.cgi?id=111832

Source/JavaScriptCore:

Reviewed by Oliver Hunt and Gavin Barraclough.

This improves overflow check elimination in three ways:

1) It reduces the amount of time the compiler will spend doing it.

2) It fixes bugs where overflow check elimination was overzealous. Precisely, for a binary operation
   over @a and @b where both @a and @b will type check that their inputs (@a->children, @b->children)
   are int32's and then perform a possibly-overflowing operation, we must be careful not to assume
   that @a's non-int32 parts don't matter if at the point that @a runs we have as yet not proved that
   @b->children are int32's and that hence @b might produce a large enough result that doubles would
   start chopping low bits. The specific implication of this is that for a binary operation to not
   propagate that it cares about non-int32 parts (NodeUsedAsNumber), we must prove that at least one
   of the inputs is guaranteed to produce a result within 2^32 and that there won't be a tower of such
   operations large enough to ultimately produce a double greater than 2^52 (roughly). We achieve the
   latter by disabling this optimization for very large basic blocks. It's noteworthy that blocks that
   large won't even make it into the DFG currently.

3) It makes the overflow check elimination more precise for cases where the inputs to an Add or Sub
   are the outputs of a bit-op. For example in (@a + (@b | 0)) | 0, we don't need to propagate
   NodeUsedAsNumber to either @a or @b.

This is neutral on V8v7 and a slight speed-up on compile time benchmarks.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
* dfg/DFGBackwardsPropagationPhase.cpp: Added.
(DFG):
(BackwardsPropagationPhase):
(JSC::DFG::BackwardsPropagationPhase::BackwardsPropagationPhase):
(JSC::DFG::BackwardsPropagationPhase::run):
(JSC::DFG::BackwardsPropagationPhase::isNotNegZero):
(JSC::DFG::BackwardsPropagationPhase::isNotZero):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwoForConstant):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwoNonRecursive):
(JSC::DFG::BackwardsPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::BackwardsPropagationPhase::mergeDefaultFlags):
(JSC::DFG::BackwardsPropagationPhase::propagate):
(JSC::DFG::performBackwardsPropagation):
* dfg/DFGBackwardsPropagationPhase.h: Added.
(DFG):
* dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::clearIsLoadedFrom):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGNodeFlags.cpp:
(JSC::DFG::dumpNodeFlags):
(DFG):
* dfg/DFGNodeFlags.h:
(DFG):
* dfg/DFGPredictionPropagationPhase.cpp:
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGUnificationPhase.cpp:
(JSC::DFG::UnificationPhase::run):
* dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsLoadedFrom):
(VariableAccessData):
(JSC::DFG::VariableAccessData::setIsLoadedFrom):
(JSC::DFG::VariableAccessData::isLoadedFrom):

LayoutTests:

Reviewed by Oliver Hunt and Gavin Barraclough.

* fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int-expected.txt: Added.
* fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.html: Added.
* fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers-expected.txt: Added.
* fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.html: Added.
* fast/js/jsc-test-list:
* fast/js/script-tests/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js: Added.
(foo):
(bar):
* fast/js/script-tests/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.js: Added.
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate chromium baselines for transforms/3d/point-mapping
jamesr@google.com [Sat, 9 Mar 2013 02:29:31 +0000 (02:29 +0000)]
Update chromium baselines for transforms/3d/point-mapping

* platform/chromium-linux-x86/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png:
* platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png:
* platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-win-xp/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Removed.
* platform/chromium/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Resolve grid-{end|after} integer against the end|after edge
jchaffraix@webkit.org [Sat, 9 Mar 2013 01:48:17 +0000 (01:48 +0000)]
[CSS Grid Layout] Resolve grid-{end|after} integer against the end|after edge
https://bugs.webkit.org/show_bug.cgi?id=111885

Reviewed by Tony Chang.

Source/WebCore:

The current code resolves grid-end (resp. grid-after) <integer>'s format against the start
(resp. before) axis. The specification changed so that they are resolved against their matching
axis.

Test: fast/css-grid-layout/grid-auto-flow-resolution.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
Updated the code to do the grid sizing measurement without resolveGridPositionsFromStyle. That's required
as resolveGridPositionsFromStyle requires the grid to be sized.

(WebCore::RenderGrid::placeItemsOnGrid):
Added a comment about not recomputing after grid growth. This issue was raised to www-style
(http://lists.w3.org/Archives/Public/www-style/2013Mar/0182.html).

(WebCore::RenderGrid::resolveGridPositionsFromStyle):
Added an ASSERT now that we don't call it during grid construction. Also added some code to pass
the side of the GridPosition we give to resolveGridPositionFromStyle.

(WebCore::RenderGrid::resolveGridPositionFromStyle):
Updated the code to resolve the grid position against the right side.

* rendering/RenderGrid.h:
Added GridPositionSide and updated resolveGridPositionFromStyle's signature.

LayoutTests:

* fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
Moar passing tests!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r142015.
commit-queue@webkit.org [Sat, 9 Mar 2013 01:37:10 +0000 (01:37 +0000)]
Unreviewed, rolling out r142015.
http://trac.webkit.org/changeset/142015
https://bugs.webkit.org/show_bug.cgi?id=111904

The change caused 2 major regressions (bug 111091 and bug
111595) and Pravin doesn't have time to investigate them
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-08

Source/WebCore:

* dom/Node.cpp:
(WebCore::Node::diff):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::childBecameNonInline):
(WebCore):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::childBecameNonInline):
(RenderBoxModelObject):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::childBecameNonInline):
(WebCore):
* rendering/RenderInline.h:
(RenderInline):
* rendering/RenderObject.cpp:
(WebCore):
(WebCore::RenderObject::handleDynamicFloatPositionChange):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):
* rendering/RenderObject.h:
(RenderObject):

LayoutTests:

* fast/css/first-letter-removed-added-expected.txt:
* fast/dynamic/absolute-positioned-to-static-positioned-expected.txt: Removed.
* fast/dynamic/absolute-positioned-to-static-positioned.html: Removed.
* fast/dynamic/floating-to-non-floating-expected.txt: Removed.
* fast/dynamic/floating-to-non-floating.html: Removed.
* fast/dynamic/non-floating-to-floating-expected.txt: Removed.
* fast/dynamic/non-floating-to-floating.html: Removed.
* fast/dynamic/resources/helper-bug91665.js: Removed.
* fast/dynamic/resources/style-bug91665.css: Removed.
* fast/dynamic/static-positioned-to-absolute-positioned-expected.txt: Removed.
* fast/dynamic/static-positioned-to-absolute-positioned.html: Removed.
* fullscreen/full-screen-fixed-pos-parent-expected.txt:
* platform/chromium-mac/fast/repaint/absolute-position-change-containing-block-expected.png:
* platform/chromium-mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png:
* platform/chromium-win/fast/dynamic/002-expected.txt:
* platform/chromium/fast/dynamic/002-expected.txt:
* platform/chromium/fast/repaint/absolute-position-change-containing-block-expected.png: Removed.
* platform/chromium/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Removed.
* platform/mac/fast/dynamic/002-expected.txt:
* platform/mac/fast/repaint/absolute-position-change-containing-block-expected.png: Removed.
* platform/mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't snapshot Java plugins
dino@apple.com [Sat, 9 Mar 2013 01:31:22 +0000 (01:31 +0000)]
Don't snapshot Java plugins
https://bugs.webkit.org/show_bug.cgi?id=111899

Reviewed by Tim Horton.

Top-level:

Export MIMETypeRegistry::isJavaAppletMIMEType symbol.

* Source/autotools/symbols.filter:

Source/WebCore:

Export MIMETypeRegistry::isJavaAppletMIMEType symbol.

* WebCore.exp.in:

Source/WebKit2:

If the plugin is Java, return true from shouldAlwaysAutoStart.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::shouldAlwaysAutoStart): Check the mimetype for Java.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCleanup: Remove dead code.
jparent@chromium.org [Sat, 9 Mar 2013 01:31:15 +0000 (01:31 +0000)]
Cleanup: Remove dead code.
https://bugs.webkit.org/show_bug.cgi?id=111900

Reviewed by Dirk Pranke.

Treemap overrides a global function that used to be in
dashboard_base, but was removed months ago in
https://bugs.webkit.org/show_bug.cgi?id=99246, so this code has
no caller.

* TestResultServer/static-dashboards/treemap.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[HTMLTemplateElement] processTemplateEndTag() needs to check for template in html...
rafaelw@chromium.org [Sat, 9 Mar 2013 01:29:38 +0000 (01:29 +0000)]
[HTMLTemplateElement] processTemplateEndTag() needs to check for template in html scope
https://bugs.webkit.org/show_bug.cgi?id=111880

Reviewed by Eric Seidel.

Source/WebCore:

Currently, </template> handling exits with an error if there is not a template tag "in scope"
which will be true if there is a table (for instance) below a template. This makes it so that
the search (correctly) examines the entire element stack.

Tests added to html5lib testing library.

* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processTemplateEndTag):

LayoutTests:

* html5lib/resources/template.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBackgroundHTMLParser should be able to atomize well-known strings
eric@webkit.org [Sat, 9 Mar 2013 01:06:36 +0000 (01:06 +0000)]
BackgroundHTMLParser should be able to atomize well-known strings
https://bugs.webkit.org/show_bug.cgi?id=107337

Reviewed by Adam Barth.

Testing this patch easily requires applying bug 107236 locally
to remove all the rendering noise from Parser/html-threaded-parser.html.

This patch adds a new class HTMLIdentifier which allows us to avoid
allocating strings for known tag/attribute names from HTMLNames.

There is still a lot of meat on this bone, but I think it's important to
land something "smallish" to start and iterate from there.

This took Parser/html-threaded-parser.html from:
median= 443.726500002 ms, stdev= 7.25002679952 ms, min= 430.244000047 ms, max= 455.511000007 ms
to:
median= 427.849500004 ms, stdev= 9.96967058292 ms, min= 417.914000049 ms, max= 461.528000014 ms
on my MBP.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* html/parser/BackgroundHTMLParser.cpp:
(WebCore::tokenExitsForeignContent):
(WebCore::tokenExitsSVG):
(WebCore::tokenExitsMath):
(WebCore::BackgroundHTMLParser::simulateTreeBuilder):
* html/parser/CSSPreloadScanner.cpp:
(WebCore::CSSPreloadScanner::scan):
* html/parser/CSSPreloadScanner.h:
(WebCore):
(CSSPreloadScanner):
* html/parser/CompactHTMLToken.cpp:
(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken):
* html/parser/CompactHTMLToken.h:
(WebCore::CompactHTMLToken::Attribute::Attribute):
(Attribute):
(WebCore::CompactHTMLToken::data):
(WebCore::CompactHTMLToken::publicIdentifier):
(CompactHTMLToken):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::startBackgroundParser):
* html/parser/HTMLIdentifier.cpp: Added.
(WebCore):
(WebCore::identifierTable):
(WebCore::HTMLIdentifier::hasIndex):
(WebCore::HTMLIdentifier::findIndex):
(WebCore::nameForIndex):
(WebCore::HTMLIdentifier::asString):
(WebCore::HTMLIdentifier::asStringImpl):
(WebCore::HTMLIdentifier::addNames):
(WebCore::HTMLIdentifier::init):
* html/parser/HTMLIdentifier.h: Added.
(WebCore):
(HTMLIdentifier):
(WebCore::HTMLIdentifier::HTMLIdentifier):
(WebCore::HTMLIdentifier::isSafeToSendToAnotherThread):
* html/parser/HTMLParserIdioms.cpp:
(WebCore::threadSafeEqual):
(WebCore::threadSafeMatch):
* html/parser/HTMLParserIdioms.h:
(WebCore):
(WebCore::threadSafeHTMLNamesMatch):
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::tagIdFor):
(WebCore::TokenPreloadScanner::StartTagScanner::match):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
* html/parser/HTMLPreloadScanner.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a failing test expectation per bug 111901.
rniwa@webkit.org [Sat, 9 Mar 2013 00:42:12 +0000 (00:42 +0000)]
Add a failing test expectation per bug 111901.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate a few more chromium baselines.
jamesr@google.com [Sat, 9 Mar 2013 00:29:45 +0000 (00:29 +0000)]
Update a few more chromium baselines.

* platform/chromium-mac-lion/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
* platform/chromium-mac/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
* platform/chromium-win-xp/editing/pasteboard/paste-text-016-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt.
* platform/chromium-win-xp/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-text-016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCheck to ensure MultisampleRenderbuffer creation succeeds
commit-queue@webkit.org [Fri, 8 Mar 2013 23:47:16 +0000 (23:47 +0000)]
Check to ensure MultisampleRenderbuffer creation succeeds
https://bugs.webkit.org/show_bug.cgi?id=111780

Patch by Brandon Jones <bajones@google.com> on 2013-03-08
Reviewed by Dean Jackson.

On OSX systems using AMD graphics chips the allocation of large
Multisample Renderbuffers in Chromium would fail without any indication
of failure. Attempting to draw to the buffer resulted in garbage being
rendered onscreen. This could be reproduced by opening a full-page
WebGL app and pressing (Command + "-") several times. This patch adds an
additional check during DrawingBuffer resize to verify that the resized
buffer is valid.

* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
(WebCore::DrawingBuffer::checkBufferIntegrity):
(WebCore::DrawingBuffer::reset):
* platform/graphics/gpu/DrawingBuffer.h:
(DrawingBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplemented new API for RTCStatsReport object.
commit-queue@webkit.org [Fri, 8 Mar 2013 23:45:57 +0000 (23:45 +0000)]
Implemented new API for RTCStatsReport object.
https://bugs.webkit.org/show_bug.cgi?id=110333

Source/Platform:

Patch by Harald Alvestrand <hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.

* chromium/public/WebRTCStatsResponse.h:
(WebKit::WebRTCStatsResponse::WebRTCStatsResponse):
(WebRTCStatsResponse):

Source/WebCore:

Removed RTCStatsElement object, moved its interface to
RTCStatsReport. Preserved some interfaces for
backwards compatibility; will be removed in a later patch.

Patch by Harald Alvestrand <hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.

Tested by extensions to RTCPeerConnection-stats test.

* Modules/mediastream/RTCStatsElement.cpp: Removed.
* Modules/mediastream/RTCStatsElement.h: Removed.
* Modules/mediastream/RTCStatsElement.idl: Removed.
* Modules/mediastream/RTCStatsReport.cpp:
(WebCore::RTCStatsReport::create):
(WebCore::RTCStatsReport::RTCStatsReport):
(WebCore):
(WebCore::RTCStatsReport::names):
(WebCore::RTCStatsReport::local):
(WebCore::RTCStatsReport::remote):
(WebCore::RTCStatsReport::addStatistic):
(WebCore::RTCStatsReport::addElement):
* Modules/mediastream/RTCStatsReport.h:
(RTCStatsReport):
(WebCore::RTCStatsReport::timestamp):
(WebCore::RTCStatsReport::id):
(WebCore::RTCStatsReport::stat):
* Modules/mediastream/RTCStatsReport.idl:
* Modules/mediastream/RTCStatsResponse.cpp:
(WebCore::RTCStatsResponse::namedItem):
(WebCore):
(WebCore::RTCStatsResponse::addReport):
(WebCore::RTCStatsResponse::addStatistic):
* Modules/mediastream/RTCStatsResponse.h:
(RTCStatsResponse):
* Modules/mediastream/RTCStatsResponse.idl:
* WebCore.gypi:
* platform/chromium/support/WebRTCStatsResponse.cpp:
(WebKit::WebRTCStatsResponse::addReport):
(WebKit):
(WebKit::WebRTCStatsResponse::addStatistic):
(WebKit::WebRTCStatsResponse::addElement):
* platform/mediastream/RTCStatsResponseBase.h:
(RTCStatsResponseBase):

Tools:

Patch by Harald Alvestrand <hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.

* DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
(WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):

LayoutTests:

Patch by Harald Alvestrand <hta@chromium.org> on 2013-03-08
Reviewed by Adam Barth.

* fast/mediastream/RTCPeerConnection-stats-expected.txt:
* fast/mediastream/RTCPeerConnection-stats.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChromium rebaselines and expectations updates.
jamesr@google.com [Fri, 8 Mar 2013 23:40:40 +0000 (23:40 +0000)]
Chromium rebaselines and expectations updates.

* platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
* platform/chromium-linux/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
* platform/chromium-linux/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
* platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
* platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-mac/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
* platform/chromium-mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-se-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scroll-expected.txt: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
* platform/chromium-win/compositing/tiling/rotated-tiled-clamped-expected.png: Added.
* platform/chromium-win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scroll-expected.txt: Added.
* platform/chromium-win/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
* platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
* platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
* platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.txt: Added.
* platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFree up background parser's checkpoints when speculation succeeds
eric@webkit.org [Fri, 8 Mar 2013 23:39:25 +0000 (23:39 +0000)]
Free up background parser's checkpoints when speculation succeeds
https://bugs.webkit.org/show_bug.cgi?id=110547

Reviewed by Adam Barth.

This should be a memory (and possible perf) win while parsing
pages, as we will no longer hold multiple copies of every
source byte during the whole parse.

Many LayoutTests exercise this code path, and I've manually (debugger and printf)
that we're hitting this code, but we'll have to wait for the memory/perf bots
to tell us if this shows up as a win.

We only bother to message the parser at the end of a speculation chain, so as not
to send too many messages to the background parser.

* html/parser/BackgroundHTMLInputStream.cpp:
(WebCore::BackgroundHTMLInputStream::BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::invalidateCheckpointsUpThrough):
(WebCore):
(WebCore::BackgroundHTMLInputStream::rewindTo):
* html/parser/BackgroundHTMLInputStream.h:
(BackgroundHTMLInputStream):
(Checkpoint):
(WebCore::BackgroundHTMLInputStream::Checkpoint::isNull):
(WebCore::BackgroundHTMLInputStream::Checkpoint::clear):
* html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::passedCheckpoint):
(WebCore):
* html/parser/BackgroundHTMLParser.h:
(BackgroundHTMLParser):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Keydown event for 'shift+alt' returns win keycode instead of 'alt'
commit-queue@webkit.org [Fri, 8 Mar 2013 23:27:11 +0000 (23:27 +0000)]
[chromium] Keydown event for 'shift+alt' returns win keycode instead of 'alt'
https://bugs.webkit.org/show_bug.cgi?id=111112

Patch by Chandra Shekar Vallala <brk376@motorola.com> on 2013-03-08
Reviewed by Tony Chang.

.:

Return windows keycode of Alt incase of GDK_META_L, GDK_META_R.

Try press Shift then alt key. The test passes if the shiftKey, altKey values
of JSKeyEvent are true and keycode/which is 18.

* ManualTests/shift-alt-key-event.html: Added.

Source/WebCore:

Return windows keycode of Alt incase of GDK_META_L, GDK_META_R. This matches
the firefox behaviour in linux platform.

Added Manual Test : ManualTests/shift-alt-key-event.html
Try press Shift then alt key. The test passes if the shiftKey, altKey values
of JSKeyEvent are true and keycode/which is 18.

* platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate some more chromium compositor pixel baselines.
jamesr@google.com [Fri, 8 Mar 2013 22:57:54 +0000 (22:57 +0000)]
Update some more chromium compositor pixel baselines.

* platform/chromium-linux/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-linux/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
* platform/chromium-linux/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-linux/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
* platform/chromium-linux/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-linux/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/chromium-mac-lion/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-mac-lion/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-mac-lion/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
* platform/chromium-mac-lion/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-mac-lion/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/chromium-mac-snowleopard/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-mac-snowleopard/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/chromium-mac/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-mac/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-mac/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
* platform/chromium-mac/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/chromium-win/compositing/masks/simple-composited-mask-expected.png:
* platform/chromium-win/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png: Added.
* platform/chromium-win/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.png: Added.
* platform/chromium-win/compositing/reflections/load-video-in-reflection-expected.png:
* platform/chromium-win/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
* platform/chromium/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
* platform/chromium/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.txt: Added.
* platform/efl-wk2/compositing/reflections/nested-reflection-anchor-point-expected.png: Renamed from LayoutTests/platform/efl/compositing/reflections/nested-reflection-anchor-point-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled Chromium DEPS to r187037. Requested by
commit-queue@webkit.org [Fri, 8 Mar 2013 22:45:34 +0000 (22:45 +0000)]
Unreviewed.  Rolled Chromium DEPS to r187037.  Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-08

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] use custom freetype on linux asan builds again
dpranke@chromium.org [Fri, 8 Mar 2013 22:41:10 +0000 (22:41 +0000)]
[chromium] use custom freetype on linux asan builds again
https://bugs.webkit.org/show_bug.cgi?id=111884

Reviewed by Tony Chang.

We no longer need the workaround after chromium r186540.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening. AppleWin port.
roger_fong@apple.com [Fri, 8 Mar 2013 22:38:55 +0000 (22:38 +0000)]
Unreviewed gardening. AppleWin port.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWarning about the user not having edit rights on Bugzilla is confusing new contributors
rniwa@webkit.org [Fri, 8 Mar 2013 22:36:47 +0000 (22:36 +0000)]
Warning about the user not having edit rights on Bugzilla is confusing new contributors
https://bugs.webkit.org/show_bug.cgi?id=111798

Reviewed by Dirk Pranke.

Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate baselines for a few chromium compositor tests.
jamesr@google.com [Fri, 8 Mar 2013 22:26:57 +0000 (22:26 +0000)]
Update baselines for a few chromium compositor tests.

* platform/chromium-linux/compositing/checkerboard-expected.png: Removed.
* platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-mac-lion/compositing/checkerboard-expected.png: Removed.
* platform/chromium-mac/compositing/checkerboard-expected.png:
* platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-win/compositing/checkerboard-expected.png: Removed.
* platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCSP: 'eval()' is blocked in report-only mode.
mkwst@chromium.org [Fri, 8 Mar 2013 22:19:51 +0000 (22:19 +0000)]
CSP: 'eval()' is blocked in report-only mode.
https://bugs.webkit.org/show_bug.cgi?id=111867

Reviewed by Adam Barth.

Source/WebCore:

Setting a 'Content-Security-Policy-Report-Only' header should not have
any effect on what a page actually executes. Currently, however, setting
a 'script-src' directive that doesn't whitelist 'unsafe-eval' actually
blocks 'eval()' on the page. This patch fixes that by checking whether
we're in report-only mode before turning 'eval()' off inside the script
engine.

This leaves us in a weird state, however. We don't currently have any
mechanism of explaining to the VM that we just want to be notified of
'eval()' usage. I've filed http://wkbug.com/111869 to cover this
aspect.

Test: http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode.html

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
    For each policy we parse, check that we're only turning off eval in
    the VM when we're in enforce mode. If we're in report-only mode,
    skip it.

LayoutTests:

* http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago <rdar://problem/13338743> Fix sandbox profile preprocessor flags for compatib...
ap@apple.com [Fri, 8 Mar 2013 22:09:09 +0000 (22:09 +0000)]
    <rdar://problem/13338743> Fix sandbox profile preprocessor flags for compatibility with new clang.

        Reviewed by Alexey Proskuryakov.
        Patch by Bob Wilson.

        * DerivedSources.make: Only use -traditional when we have to work around old
        behavior of -std=c89.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate baselines for string prototypes fixed by v8-i18n roll 164:171
jamesr@google.com [Fri, 8 Mar 2013 21:47:42 +0000 (21:47 +0000)]
Update baselines for string prototypes fixed by v8-i18n roll 164:171

* platform/chromium/fast/js/kde/function_length-expected.txt: Removed.
* platform/chromium/fast/js/kde/inbuilt_function_tostring-expected.txt:
* platform/chromium/fast/js/string-prototype-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r143643): <button> should support ::first-line and ::first-letter
commit-queue@webkit.org [Fri, 8 Mar 2013 21:45:29 +0000 (21:45 +0000)]
REGRESSION (r143643): <button> should support ::first-line and ::first-letter
https://bugs.webkit.org/show_bug.cgi?id=111782

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-08
Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/forms/button-first-line-first-letter.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::firstLineBlock):
(WebCore::findFirstLetterBlock):
Add isRenderButton to the first-line and first-letter checks that
don't allow ::first-* styles for flexbox.

LayoutTests:

* fast/forms/button-first-line-first-letter-expected.html: Added.
* fast/forms/button-first-line-first-letter.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix for EFL, GTK and Qt after r145254.
joone.hur@intel.com [Fri, 8 Mar 2013 21:25:18 +0000 (21:25 +0000)]
Unreviewed build fix for EFL, GTK and Qt after r145254.

* Shared/SandboxExtension.h:
(WebKit::SandboxExtension::revoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLayout Test fast/dom/HTMLMeterElement/meter-element-crash.html is failing
jamesr@google.com [Fri, 8 Mar 2013 21:20:24 +0000 (21:20 +0000)]
Layout Test fast/dom/HTMLMeterElement/meter-element-crash.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88131

Reviewed by Tony Chang.

This test was calling setTimeout(..., 0) in a <script> block before the end of the document.
The timeout sometimes fired before parsing the rest of the document and sometimes after,
depending on when the parser yielded. This moves the <script> block to the end of the document
so it always runs after parsing the rest of the test, which is the more common and expected
behavior.

* fast/dom/HTMLMeterElement/meter-element-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix for AppleWin VS2010.
roger_fong@apple.com [Fri, 8 Mar 2013 21:14:48 +0000 (21:14 +0000)]
Build fix for AppleWin VS2010.

* WebKit.vcxproj/FeatureDefines.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded a regression test for raw parsing speed
ggaren@apple.com [Fri, 8 Mar 2013 21:11:53 +0000 (21:11 +0000)]
Added a regression test for raw parsing speed
https://bugs.webkit.org/show_bug.cgi?id=111808

Reviewed by Oliver Hunt.

* fast/js/regress/nested-function-parsing-random.html: Added.
* fast/js/regress/script-tests/nested-function-parsing-random.js: Added.
(randomIdent): Use randomness to defeat caching.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved an out-of-date comment from SharedTimer
ggaren@apple.com [Fri, 8 Mar 2013 21:11:05 +0000 (21:11 +0000)]
Removed an out-of-date comment from SharedTimer
https://bugs.webkit.org/show_bug.cgi?id=111875

Reviewed by Mark Hahnenberg.

Even if we surround each call to an ObjC interface with an autorelease
pool, it's still nice to have one at top-level entry points like
timers, to avoid turning a single mistake into a long-term leak.

* platform/ios/SharedTimerIOS.mm:
(WebCore::timerFired):
* platform/mac/SharedTimerMac.mm:
(WebCore::timerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChromium gardening.
jamesr@google.com [Fri, 8 Mar 2013 21:04:27 +0000 (21:04 +0000)]
Chromium gardening.

* platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
* platform/chromium-linux/editing/pasteboard/paste-text-016-expected.txt: Added.
* platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-016-expected.txt: Added.
* platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
commit-queue@webkit.org [Fri, 8 Mar 2013 21:02:00 +0000 (21:02 +0000)]
[chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
https://bugs.webkit.org/show_bug.cgi?id=111632

Patch by James Robinson <jamesr@chromium.org> on 2013-03-08
Reviewed by Adrienne Walker.

Source/Platform:

Neither of these are used any more. All callbacks from the compositor are handled by
the embedder and plumbed (where appropriate) through the WebWidget/WebView APIs. All
settings are handled by the embedder.

* Platform.gypi:
* chromium/public/WebLayerTreeView.h:
(WebKit):
* chromium/public/WebLayerTreeViewClient.h: Removed.
* chromium/public/WebUnitTestSupport.h:
(WebKit):

Source/WebKit/chromium:

* public/WebWidgetClient.h:
(WebWidgetClient):
(WebKit::WebWidgetClient::initializeLayerTreeView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:
* tests/ScrollingCoordinatorChromiumTest.cpp:
(WebKit::FakeWebViewClient::initializeLayerTreeView):

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::initializeLayerTreeView):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMac rebaseline after r145242. I'm really hoping that the optimization didn't mess...
rniwa@webkit.org [Fri, 8 Mar 2013 20:56:39 +0000 (20:56 +0000)]
Mac rebaseline after r145242. I'm really hoping that the optimization didn't mess this up.

* css1/box_properties/margin_bottom-expected.txt: Replaced.
* css1/box_properties/margin_top-expected.txt: Replaced.
* css1/box_properties/padding_bottom-expected.txt: Replaced.
* css1/box_properties/padding_top-expected.txt: Replaced.
* css1/color_and_background/background_attachment-expected.txt: Replaced.
* platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
* platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
* platform/mac/css3/flexbox/flexbox-baseline-expected.txt:
* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/mac/tables/mozilla/bugs/bug126742-expected.txt:
* platform/mac/tables/mozilla/bugs/bug69187-expected.txt:
* platform/win-future/css1: Added.
* platform/win-future/css1/box_properties: Added.
* platform/win-future/css1/box_properties/margin_bottom-expected.txt: Added.
* platform/win-future/css1/box_properties/margin_top-expected.txt: Added.
* platform/win-future/css1/box_properties/padding_bottom-expected.txt: Added.
* platform/win-future/css1/box_properties/padding_top-expected.txt: Added.
* platform/win-future/css1/color_and_background: Added.
* platform/win-future/css1/color_and_background/background_attachment-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agonon-Mac ports build fix after r145235.
rniwa@webkit.org [Fri, 8 Mar 2013 20:47:53 +0000 (20:47 +0000)]
non-Mac ports build fix after r145235.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
benjamin@webkit.org [Fri, 8 Mar 2013 20:40:09 +0000 (20:40 +0000)]
[Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
https://bugs.webkit.org/show_bug.cgi?id=111297

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

The 'view-mode' Media Feature spec is implemented in WebCore but
there is no WebKit support for it on Mac.
Because of this, we always lie and report a windowed view mode.

This patch add a feature flag for the feature and disable it on
Mac so that we stop reporting incorrect default values.

* WebCore.exp.in:
* css/CSSValueKeywords.in:
* css/MediaFeatureNames.h:
(MediaFeatureNames):
* css/MediaQueryEvaluator.cpp:
* css/MediaQueryExp.cpp:
(WebCore::featureWithCSSValueID):
(WebCore::featureWithoutValue):
* page/Page.cpp:
(WebCore::Page::Page):
* page/Page.h:
(Page):

Source/WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:

Source/WTF:

* wtf/FeatureDefines.h: Add a new feature flag for the view-mode
CSS media: ENABLE_VIEW_MODE_CSS_MEDIA.

Tools:

* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setViewModeMediaFeature):

LayoutTests:

* platform/mac/TestExpectations:
Mark the view-mode tests as failing to track any regression
or crash in this area.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago Make it possible to reuse sandbox extensions
ap@apple.com [Fri, 8 Mar 2013 20:25:58 +0000 (20:25 +0000)]
    Make it possible to reuse sandbox extensions
        https://bugs.webkit.org/show_bug.cgi?id=111883

        Reviewed by Anders Carlsson.

        Replaced invalidate() with revoke().

        We now count how many times consume() was called, and keep the extension active
        for as long as revoke() hasn't been called as many times. Also, we only permanently
        destroy the extension in destructor.

        This allows for properly keeping extensions in NetworkBlobRegistry for as long as
        they are needed.

        * NetworkProcess/SchedulableLoader.cpp:
        (WebKit::SchedulableLoader::invalidateSandboxExtensions):
        * Shared/Downloads/Download.cpp:
        (WebKit::Download::didFinish):
        (WebKit::Download::didFail):
        (WebKit::Download::didCancel):
        * Shared/SandboxExtension.h:
        (SandboxExtension):
        * Shared/WebMemorySampler.cpp:
        (WebKit::WebMemorySampler::stop):
        * Shared/mac/SandboxExtensionMac.mm:
        (WebKit::SandboxExtension::SandboxExtension):
        (WebKit::SandboxExtension::revoke):
        (WebKit::SandboxExtension::consume):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::performDragControllerAction):
        (WebKit::WebPage::SandboxExtensionTracker::invalidate):
        (WebKit::WebPage::SandboxExtensionTracker::setPendingProvisionalSandboxExtension):
        (WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad):
        (WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAfter sending message, Mail changes formatting
rniwa@webkit.org [Fri, 8 Mar 2013 20:11:02 +0000 (20:11 +0000)]
After sending message, Mail changes formatting
https://bugs.webkit.org/show_bug.cgi?id=111360

Reviewed by Enrica Casucci.

Source/WebCore:

Added makeInsertedContentRoundTrippableWithHTMLTreeBuilder to move prohibited children (e.g. p, h1, etc...)
out of paragraph elements to run immediately after the fragment insertion. This function splits trees and
moves prohibited children out of paragraph elements to keep the tree isomorphic under HTML serialization and
parsing. Unfortunately, there are many other DOM tree constructs we need to fix to make the subtree truly
isomorphic but this is a step forward.

Test: editing/pasteboard/pasting-into-p-should-not-nest-p.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::isProhibitedParagraphChild): Added. Matches the list at
https://dvcs.w3.org/hg/editing/raw-file/57abe6d3cb60/editing.html#prohibited-paragraph-child
except main element, which is currently missing in the specification.
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder): Added.
(WebCore::ReplaceSelectionCommand::moveNodeOutOfAncestor): Added.
(WebCore::ReplaceSelectionCommand::doApply): Call moveProhibitedChildrenOutOfParagraphElements.

* editing/ReplaceSelectionCommand.h:
(ReplaceSelectionCommand):

LayoutTests:

Added a regression test, demonstrating that a paragraph element is not nested after a paste.
Also rebaselined multiple tests that had been exhibiting this bug in their expected results.

* editing/pasteboard/block-wrappers-necessary-expected.txt:
* editing/pasteboard/paste-table-001-expected.txt:
* editing/pasteboard/paste-text-011-expected.txt:
* editing/pasteboard/paste-text-015-expected.txt:
* editing/pasteboard/pasting-into-p-should-not-nest-p-expected.txt: Added.
* editing/pasteboard/pasting-into-p-should-not-nest-p.html: Added.
* editing/pasteboard/pasting-into-h6-should-not-nest-h6-expected.txt: Added.
* editing/pasteboard/pasting-into-h6-should-not-nest-h6.html: Added.
* platform/mac/editing/pasteboard/paste-text-016-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled Chromium DEPS to r186991. Requested by
commit-queue@webkit.org [Fri, 8 Mar 2013 19:58:54 +0000 (19:58 +0000)]
Unreviewed.  Rolled Chromium DEPS to r186991.  Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-08

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed chromium mac/win rebaselines for r145242.
eae@chromium.org [Fri, 8 Mar 2013 19:34:08 +0000 (19:34 +0000)]
Unreviewed chromium mac/win rebaselines for r145242.

* css1/basic/inheritance-expected.txt: Added.
* css1/box_properties/clear_float-expected.txt: Added.
* css1/box_properties/margin-expected.txt: Added.
* css1/box_properties/padding-expected.txt: Added.
* css1/font_properties/font_weight-expected.txt: Added.
* fast/css-generated-content/015-expected.txt: Added.
* fast/css/h1-in-section-elements-expected.txt: Added.
* platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
* platform/chromium-mac-lion/css1/box_properties/clear_float-expected.png:
* platform/chromium-mac-lion/css1/box_properties/padding-expected.png:
* platform/chromium-mac-lion/css1/font_properties/font_weight-expected.png:
* platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-expected.png:
* platform/chromium-mac-lion/fast/css/h1-in-section-elements-expected.png:
* platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
* platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac-lion/tables/mozilla/bugs/bug126742-expected.png:
* platform/chromium-mac-lion/tables/mozilla/bugs/bug69187-expected.png:
* platform/chromium-mac-lion/tables/mozilla/bugs/bug73321-expected.png:
* platform/chromium-mac-lion/tables/mozilla/bugs/bug73321-expected.txt: Added.
* platform/chromium-mac-snowleopard/css1/basic/inheritance-expected.png:
* platform/chromium-mac-snowleopard/css1/box_properties/padding-expected.png:
* platform/chromium-mac-snowleopard/css1/color_and_background/background_attachment-expected.png:
* platform/chromium-mac-snowleopard/css1/font_properties/font_weight-expected.png:
* platform/chromium-mac-snowleopard/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
* platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png:
* platform/chromium-mac-snowleopard/fast/css/h1-in-section-elements-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug126742-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug69187-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.txt: Added.
* platform/chromium-mac/css1/basic/inheritance-expected.txt: Removed.
* platform/chromium-mac/css1/box_properties/clear_float-expected.png:
* platform/chromium-mac/css1/box_properties/clear_float-expected.txt: Removed.
* platform/chromium-mac/css1/box_properties/margin-expected.txt: Removed.
* platform/chromium-mac/css1/box_properties/margin_bottom-expected.txt: Added.
* platform/chromium-mac/css1/box_properties/margin_top-expected.txt: Added.
* platform/chromium-mac/css1/box_properties/padding-expected.png:
* platform/chromium-mac/css1/box_properties/padding-expected.txt: Removed.
* platform/chromium-mac/css1/box_properties/padding_bottom-expected.txt: Added.
* platform/chromium-mac/css1/box_properties/padding_top-expected.txt: Added.
* platform/chromium-mac/css1/color_and_background/background_attachment-expected.txt: Added.
* platform/chromium-mac/css1/font_properties/font_weight-expected.png:
* platform/chromium-mac/css1/font_properties/font_weight-expected.txt: Removed.
* platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.txt:
* platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
* platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png:
* platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt:
* platform/chromium-mac/fast/css-generated-content/015-expected.txt: Removed.
* platform/chromium-mac/fast/css/h1-in-section-elements-expected.png:
* platform/chromium-mac/fast/css/h1-in-section-elements-expected.txt: Removed.
* platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Added.
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug126742-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug126742-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug69187-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug69187-expected.txt:
* platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.txt: Added.
* platform/chromium-win/css1/basic/inheritance-expected.png:
* platform/chromium-win/css1/box_properties/clear_float-expected.png:
* platform/chromium-win/css1/box_properties/margin_top-expected.png:
* platform/chromium-win/css1/font_properties/font_weight-expected.png:
* platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png:
* platform/chromium-win/fast/css/h1-in-section-elements-expected.png:
* platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
* platform/chromium-win/tables/mozilla/bugs/bug126742-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug69187-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:
* platform/chromium/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt: Removed.
* platform/chromium/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
* platform/chromium/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Removed.
* platform/mac/css1/basic/inheritance-expected.txt: Removed.
* platform/mac/css1/box_properties/clear_float-expected.txt: Removed.
* platform/mac/css1/box_properties/margin-expected.txt: Removed.
* platform/mac/css1/box_properties/padding-expected.txt: Removed.
* platform/mac/css1/font_properties/font_weight-expected.txt: Removed.
* platform/mac/fast/css-generated-content/015-expected.txt: Removed.
* platform/mac/fast/css/h1-in-section-elements-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed apple rebaselines for r145242.
eae@chromium.org [Fri, 8 Mar 2013 19:28:30 +0000 (19:28 +0000)]
Unreviewed apple rebaselines for r145242.

* css1/box_properties/margin_bottom-expected.txt: Added.
* css1/box_properties/margin_top-expected.txt: Added.
* css1/box_properties/padding_bottom-expected.txt: Added.
* css1/box_properties/padding_top-expected.txt: Added.
* css1/color_and_background/background_attachment-expected.txt: Added.
* platform/chromium-mac/css1/box_properties/margin_bottom-expected.txt: Removed.
* platform/chromium-mac/css1/box_properties/margin_top-expected.txt: Removed.
* platform/chromium-mac/css1/box_properties/padding_bottom-expected.txt: Removed.
* platform/chromium-mac/css1/box_properties/padding_top-expected.txt: Removed.
* platform/chromium-mac/css1/color_and_background/background_attachment-expected.txt: Removed.
* platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.txt: Removed.
* platform/chromium/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.
* platform/efl/tables/mozilla/bugs/bug73321-expected.txt: Removed.
* platform/mac-lion/css1/box_properties: Removed.
* platform/mac/css1/basic/inheritance-expected.txt:
* platform/mac/css1/box_properties/clear_float-expected.txt:
* platform/mac/css1/box_properties/margin-expected.txt:
* platform/mac/css1/box_properties/margin_bottom-expected.txt: Removed.
* platform/mac/css1/box_properties/margin_top-expected.txt: Removed.
* platform/mac/css1/box_properties/padding-expected.txt:
* platform/mac/css1/box_properties/padding_bottom-expected.txt: Removed.
* platform/mac/css1/box_properties/padding_top-expected.txt: Removed.
* platform/mac/css1/color_and_background/background_attachment-expected.txt: Removed.
* platform/mac/css1/font_properties/font_weight-expected.txt:
* platform/mac/fast/css-generated-content/015-expected.txt:
* platform/mac/fast/css/h1-in-section-elements-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/mac/tables/mozilla/bugs/bug73321-expected.txt:
* tables/mozilla/bugs/bug73321-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAtomicHTMLToken should not be heap allocated or RefCounted
eric@webkit.org [Fri, 8 Mar 2013 19:15:40 +0000 (19:15 +0000)]
AtomicHTMLToken should not be heap allocated or RefCounted
https://bugs.webkit.org/show_bug.cgi?id=111250

Reviewed by Adam Barth.

It was clearly an oversight on our part to ever make AtomicHTMLToken ref-counted.
We don't need the actual "token" saved, just enough of it to recreate a fake token.

This removed many more mallocs than I thought it would, for a nice little speed win.
Before:
median= 450.482999993 ms, stdev= 7.2381436538 ms, min= 436.084999994 ms, max= 464.968999964 ms
After:
median= 436.41600004 ms, stdev= 5.71435647554 ms, min= 427.160999971 ms, max= 446.753000026 ms

* html/parser/AtomicHTMLToken.h:
(AtomicHTMLToken):
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createElementFromSavedToken):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):
(WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):
* html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::isHTMLIntegrationPoint):
* html/parser/HTMLFormattingElementList.cpp:
(WebCore):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition):
* html/parser/HTMLStackItem.h:
(WebCore::HTMLStackItem::create):
(WebCore::HTMLStackItem::localName):
(WebCore::HTMLStackItem::attributes):
(WebCore::HTMLStackItem::getAttributeItem):
(HTMLStackItem):
(WebCore::HTMLStackItem::hasLocalName):
(WebCore::HTMLStackItem::hasTagName):
(WebCore::HTMLStackItem::HTMLStackItem):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
* html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMakefile fixes.
roger_fong@apple.com [Fri, 8 Mar 2013 18:57:08 +0000 (18:57 +0000)]
Makefile fixes.

* WTF.vcxproj/WTF.make:
* JavaScriptCore.vcxproj/JavaScriptCore.make:
* WebCore.vcxproj/WebCore.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][GTK] Invalid request returned by webkit_download_get_request if called before...
commit-queue@webkit.org [Fri, 8 Mar 2013 18:42:29 +0000 (18:42 +0000)]
[WK2][GTK] Invalid request returned by webkit_download_get_request if called before download starts
https://bugs.webkit.org/show_bug.cgi?id=111574

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Alexey Proskuryakov.

webkit_download_get_request() creates the WebKitURIRequest object
on demand using the ResourceRequest from the DownloadProxy. The
ResourceRequest of the DownloadProxy is set in
DownloadProxy::didStart(), so if we call
webkit_download_get_request() before didStart we return an invalid
WebKitURIRequest created from a NULL ResourceRequest. This is not
a problem for downloads started in the web process, because we
create the WebKitDownload after DownloadProxy::didStart(). For
downloads started manually with webkit_web_context_download_uri()
we need to create download object with the ResourceRequest passed
to the DownloadProxy.

* UIProcess/API/gtk/WebKitDownload.cpp:
(webkitDownloadCreateForRequest): New helper function for
downloads started manually to created them with a given
ResourceRequest.
* UIProcess/API/gtk/WebKitDownloadPrivate.h:
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextStartDownload): Use
webkitDownloadCreateForRequest().
* UIProcess/API/gtk/tests/TestDownloads.cpp:
(testDownloadLocalFile):
(testDownloadLocalFileError):
(testDownloadRemoteFile):
(testDownloadRemoteFileError):
(testPolicyResponseDownload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkip editing/selection/drag-list-item.html on Mac WebKit2 since drag and drop is...
rniwa@webkit.org [Fri, 8 Mar 2013 18:33:39 +0000 (18:33 +0000)]
Skip editing/selection/drag-list-item.html on Mac WebKit2 since drag and drop is not supported
in WebKitTestRunner yet.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[sub-pixel] Rounding error in table cell height calculation causes unnecessary scrollbar
eae@chromium.org [Fri, 8 Mar 2013 18:30:46 +0000 (18:30 +0000)]
[sub-pixel] Rounding error in table cell height calculation causes unnecessary scrollbar
https://bugs.webkit.org/show_bug.cgi?id=111794

Source/WebCore:

Reviewed by Levi Weintraub.

In RenderTableCell::logicalHeightForRowSizing the
adjustedLogicalHeight is calculated from the logicalHeight and
intrinsic padding and is then returned and floored. This can
cause cause the cell to be slightly smaller (0.5px) than the
element it contains.

Test: fast/sub-pixel/table-cell-height.html

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::logicalHeightForRowSizing):
Change to use pixelSnapped version of logicalHeight method and
change signature to return int as the only caller immediately
down-casts the result to an int.

LayoutTests:

Reviewed by Levi Weintraub.

Add test for zoomed-in table containing block child.

* fast/sub-pixel/table-cell-height-expected.html: Added.
* fast/sub-pixel/table-cell-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderFullScreen needs to clear override sizes when exiting full screen
commit-queue@webkit.org [Fri, 8 Mar 2013 18:27:59 +0000 (18:27 +0000)]
RenderFullScreen needs to clear override sizes when exiting full screen
https://bugs.webkit.org/show_bug.cgi?id=111775

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-08
Reviewed by Ojan Vafai.

Source/WebCore:

Test: fullscreen/full-screen-with-flex-item.html

* rendering/RenderFullScreen.cpp:
(RenderFullScreen::unwrapRenderer):
RenderFullScreen is a flexbox, so it will potentially set override
sizes on its children while in fullscreen mode. When we exit
fullscreen mode, we need to clear this override size, otherwise the
the leftover override size may affect layout. See the testcase for an
example.

LayoutTests:

* fullscreen/full-screen-with-flex-item-expected.txt: Added.
* fullscreen/full-screen-with-flex-item.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Handle 2 positions with one 'auto' properly
jchaffraix@webkit.org [Fri, 8 Mar 2013 18:25:30 +0000 (18:25 +0000)]
[CSS Grid Layout] Handle 2 positions with one 'auto' properly
https://bugs.webkit.org/show_bug.cgi?id=111653

Reviewed by Tony Chang.

Source/WebCore:

The rendering code was making the assumption that we have one position.
Thus it couldn't fully match what the specification wants as the 2 opposite
positions are required to resolve either position in several cases (e.g.
1 / span 2, auto / 'c').

This change introduces resolveGridPositionsFromStyle to do both opposite
positions resolution in one pass and thus handling more cases.

Test: fast/css-grid-layout/grid-item-spanning-resolution.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
Updated the above functions to rely on resolveGridPositionsFromStyle.

(WebCore::RenderGrid::resolveGridPositionsFromStyle):
Added this new function that handle the correct resolution.

(WebCore::RenderGrid::resolveGridPositionFromStyle):
Updated the ASSERT to match the new code flow.

* rendering/RenderGrid.h:
(WebCore::RenderGrid::GridSpan::GridSpan):
Introduced this new struct to hold the 2 positions along one axis.

LayoutTests:

* fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
* fast/css-grid-layout/grid-auto-flow-resolution.html:
* fast/css-grid-layout/grid-item-spanning-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-item-spanning-resolution.html: Added.
Extended and added a new test. Most of the new testing is failing as it
requires other changes to land. This will help us track our progress
towards fully supporting the new syntax and padding.

* fast/css-grid-layout/resources/grid.css:
Added the 2 new classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderTextControlSingleLine should not assume that its text element has a renderer
dominicc@chromium.org [Fri, 8 Mar 2013 18:12:39 +0000 (18:12 +0000)]
RenderTextControlSingleLine should not assume that its text element has a renderer
https://bugs.webkit.org/show_bug.cgi?id=111826

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/forms/search/search-autoscroll-hidden-decoration-container-crash.html
       fast/forms/search/search-hide-decoration-container-crash.html
       fast/forms/search/search-scroll-hidden-decoration-container-crash.html

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::controlClipRect):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scroll):

LayoutTests:

* fast/forms/search/search-autoscroll-hidden-decoration-container-crash-expected.txt: Added.
* fast/forms/search/search-autoscroll-hidden-decoration-container-crash.html: Added.
* fast/forms/search/search-hide-decoration-container-crash-expected.txt: Added.
* fast/forms/search/search-hide-decoration-container-crash.html: Added.
* fast/forms/search/search-scroll-hidden-decoration-container-crash-expected.txt: Added.
* fast/forms/search/search-scroll-hidden-decoration-container-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIndexedDB: Use WeakPtr for Factory-to-BackingStore reference
jsbell@chromium.org [Fri, 8 Mar 2013 18:06:23 +0000 (18:06 +0000)]
IndexedDB: Use WeakPtr for Factory-to-BackingStore reference
https://bugs.webkit.org/show_bug.cgi?id=111459

Reviewed by Adam Barth.

Source/WebCore:

IDBFactoryBackendImpl maintains a map of backing stores - if another database in the same
origin is opened, the backing store instance must be re-used). This was a map to raw
pointers so that the backing store can be collected when all database references are
dropped. The map was maintained manually by passing the factory to the IDBBackingStore which
would add/remove itself on creation/destruction.

Replace this with a HashMap<WeakPtr<T>>. This simplifies the plumbing; map entries
"leak" but are purged on subsequent opens.

Added webkit_unit_test (Chromium port) to verify refcounts.

* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore): No need to notify factory of lifetime.
(WebCore::IDBBackingStore::~IDBBackingStore): Ditto.
(WebCore::IDBBackingStore::open): Ditto.
* Modules/indexeddb/IDBBackingStore.h: No reference to the factory, but...
(WebCore::IDBBackingStore::createWeakPtr): Do need to expose weak pointers for the factory to hold.
* Modules/indexeddb/IDBFactoryBackendImpl.cpp:
(WebCore::cleanWeakMap): Helper function to scrub a HashMap<WeakPtr<T>> of empty pointers.
May move to WTF when we've learned how general it is, or come up with a dedicated WeakPtrHashMap type.
(WebCore::IDBFactoryBackendImpl::openBackingStore): WeakPtr fu.
* Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl): Remove plumbing methods.

Source/WebKit/chromium:

Add new test that verifies refcounts.

* WebKit.gyp: Don't include files depending on webkit_support.
* tests/IDBBackingStoreTest.cpp:
(WebCore::IDBBackingStoreTest::SetUp): No need for dummy factory.
(MockIDBFactoryBackend): Allow access to protected openBackingStore method.
(WebCore::TEST): Add new test that verifies refcounts.
* tests/IDBCleanupOnIOErrorTest.cpp:
(WebCore::TEST): No need for dummy factory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago <rdar://problem/13363499> Blobs are not cleaned up when WebProcess terminates
ap@apple.com [Fri, 8 Mar 2013 17:38:36 +0000 (17:38 +0000)]
    <rdar://problem/13363499> Blobs are not cleaned up when WebProcess terminates
        https://bugs.webkit.org/show_bug.cgi?id=111803

        Reviewed by Brady Eidson.

        Track which blobs were created for each connection, and unregister them when
        the connection closes.

        Normally, this happens when a document is destroyed through PublicURLManager
        in WebProcess. But we don't get there when the web process crashes, or is terminated
        without waiting for document destruction.

        * NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
        (WebKit::NetworkBlobRegistry::registerBlobURL):
        (WebKit::NetworkBlobRegistry::unregisterBlobURL):
        (WebKit::NetworkBlobRegistry::connectionToWebProcessDidClose):
        * NetworkProcess/FileAPI/NetworkBlobRegistry.h:
        * NetworkProcess/NetworkConnectionToWebProcess.cpp:
        (WebKit::NetworkConnectionToWebProcess::didClose):
        (WebKit::NetworkConnectionToWebProcess::registerBlobURL):
        (WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL):
        (WebKit::NetworkConnectionToWebProcess::unregisterBlobURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake the WebKit2 Web Inspector use tiled drawing and accelerated drawing.
timothy@apple.com [Fri, 8 Mar 2013 17:30:54 +0000 (17:30 +0000)]
Make the WebKit2 Web Inspector use tiled drawing and accelerated drawing.

<rdar://problem/12676223>

Reviewed by David Kilzer.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup): Call setAcceleratedDrawingEnabled with true on 10.8+.
* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorWKView _shouldUseTiledDrawingArea]): Added. Return YES on 10.8+.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago@media queries do not take zooming into account
commit-queue@webkit.org [Fri, 8 Mar 2013 17:19:58 +0000 (17:19 +0000)]
@media queries do not take zooming into account
https://bugs.webkit.org/show_bug.cgi?id=53186

Patch by John Mellor <johnme@chromium.org> on 2013-03-08
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Fixes @media width and height to take into account full page zoom, by
adding code to MediaQueryEvaluator's width/heightMediaFeatureEval,
corresponding to the existing code in Element::clientWidth which makes
document.documentElement.clientWidth take into account page zoom.

Test: fast/media/mq-width-pagezoom.html

* css/MediaQueryEvaluator.cpp:
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):

LayoutTests:

* fast/media/mq-width-pagezoom-expected.html: Added.
* fast/media/mq-width-pagezoom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Add stubs for DNSResolveQueue platform specific methods
commit-queue@webkit.org [Fri, 8 Mar 2013 17:12:24 +0000 (17:12 +0000)]
[BlackBerry] Add stubs for DNSResolveQueue platform specific methods
https://bugs.webkit.org/show_bug.cgi?id=111841

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.

Add empty implementations of
DNSResolveQueue::platformProxyIsEnabledInSystemPreferences() and
DNSResolveQueue::platformResolve() to DNSBlackBerry.cpp to make it
build.

* platform/network/blackberry/DNSBlackBerry.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
cfleizach@apple.com [Fri, 8 Mar 2013 16:59:16 +0000 (16:59 +0000)]
[Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
https://bugs.webkit.org/show_bug.cgi?id=111814

Reviewed by Ryosuke Niwa.

Tools:

Add the needed supportedActions() attribute to WKTestRunner.

* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::supportedActions):
* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
* WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::supportedActions):

LayoutTests:

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCoordinated Graphics: Handle scrolling correctly.
commit-queue@webkit.org [Fri, 8 Mar 2013 16:33:39 +0000 (16:33 +0000)]
Coordinated Graphics: Handle scrolling correctly.
https://bugs.webkit.org/show_bug.cgi?id=111406

Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-08
Reviewed by Simon Fraser.

Coordinated Graphics deals with fast scrolling and slow scrolling in the same
routine, so WebChromeClient::invalidateContentsForSlowScroll() should call
DrawingArea:scroll().

When CoordinatedLayerTreeHost::scrollNonCompositedContents() is called, we
should call scheduleLayerFlush() to notify to UI Process. In addition, when we
don't use fixed layout, we should call setNonCompositedContentsNeedDisplay() to
update non composited contents.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago Adding a hook to collect data for a Google UMA histogram to track when
commit-queue@webkit.org [Fri, 8 Mar 2013 16:28:32 +0000 (16:28 +0000)]
   Adding a hook to collect data for a Google UMA histogram to track when
       m_needsCompositedScrolling is turned on and off.
       https://bugs.webkit.org/show_bug.cgi?id=111725

       Reviewed by Julien Chaffraix.

       We want to keep track of this information to quantify the effects of a
       few patches that will cause us to opt in to composited scrolling.
       Specifically, we want to measure the effects of
       https://bugs.webkit.org/show_bug.cgi?id=109302,
       https://bugs.webkit.org/show_bug.cgi?id=109966,
       https://bugs.webkit.org/show_bug.cgi?id=109591, and
       https://bugs.webkit.org/show_bug.cgi?id=107618.

       We do this by measuring a per-layer boolean value, and comparing the
       ratio between number of layers opted in and number of layers that remain
       uncomposited. We hope the relative number of layers opting in will
       increase after the relevant patches land and are enabled.

       Unfortunately implementing extra statistics is impractical at the
       moment since most of the actionable relevant data is expensive to
       compute. For example, it would be useful to know if the layers that opt
       out do so because of invisible or non-overlapping layers that cause a
       potential stacking container's children to be discontiguous, because we
       would potentially be able to mitigate the problem. However, this would
       add considerable overhead to perform overlap testing just to gather
       data.

       No new tests (no change in behaviour).

       * rendering/RenderLayer.cpp:
       (WebCore::RenderLayer::updateNeedsCompositedScrolling):

Patch by Glenn Hartmann <hartmanng@chromium.org> on 2013-03-08

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
sudarsana.nagineni@linux.intel.com [Fri, 8 Mar 2013 16:28:21 +0000 (16:28 +0000)]
Unreviewed EFL gardening.

Update platform expectations for failing tests after r145024 and r145067.

* platform/efl/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added.
* platform/efl/fast/forms/datalist/input-list-expected.txt:
* platform/efl/fast/forms/validationMessage-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
sudarsana.nagineni@linux.intel.com [Fri, 8 Mar 2013 16:06:21 +0000 (16:06 +0000)]
Unreviewed EFL gardening.

Skip failing tests on EFL bots.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] GraphicsContext: rename addRoundedRectClip to clipRoundedRect
commit-queue@webkit.org [Fri, 8 Mar 2013 16:00:59 +0000 (16:00 +0000)]
[BlackBerry] GraphicsContext: rename addRoundedRectClip to clipRoundedRect
https://bugs.webkit.org/show_bug.cgi?id=111852

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.

This changed in r139353.

* platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
(WebCore::GraphicsContext::clipRoundedRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Add BlendMode parameter to GraphicsContext::setPlatformCompositeOperation
commit-queue@webkit.org [Fri, 8 Mar 2013 15:59:17 +0000 (15:59 +0000)]
[BlackBerry] Add BlendMode parameter to GraphicsContext::setPlatformCompositeOperation
https://bugs.webkit.org/show_bug.cgi?id=111840

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.

This parameter was added in r137011.

* platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Remove unused GraphicsContext::addInnerRoundedRectClip()
commit-queue@webkit.org [Fri, 8 Mar 2013 15:57:27 +0000 (15:57 +0000)]
[BlackBerry] Remove unused GraphicsContext::addInnerRoundedRectClip()
https://bugs.webkit.org/show_bug.cgi?id=111838

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.

This was removed in r139138.

* platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] GraphicsContext: add fillRule parameter to clip() and canvasClip()
commit-queue@webkit.org [Fri, 8 Mar 2013 15:56:00 +0000 (15:56 +0000)]
[BlackBerry] GraphicsContext: add fillRule parameter to clip() and canvasClip()
https://bugs.webkit.org/show_bug.cgi?id=111836

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.

This parameter was added in r139967.

* platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Unskip now passing compositing tests.
kadam@inf.u-szeged.hu [Fri, 8 Mar 2013 15:51:34 +0000 (15:51 +0000)]
[Qt] Unreviewed gardening. Unskip now passing compositing tests.

* platform/qt-5.0-wk2/TestExpectations:
* platform/qt/TestExpectations:
* platform/qt/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Get rid of file system ids and use file pathes as uri for file based...
vsevik@chromium.org [Fri, 8 Mar 2013 15:39:36 +0000 (15:39 +0000)]
Web Inspector: Get rid of file system ids and use file pathes as uri for file based uiSourceCodes.
https://bugs.webkit.org/show_bug.cgi?id=111753

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/FileSystemMapping.js:
(WebInspector.FileSystemMappingImpl):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings.get this):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings):
(WebInspector.FileSystemMappingImpl.prototype._saveToSettings):
(WebInspector.FileSystemMappingImpl.prototype.set addFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.removeFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPaths):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPathForPrefix):
* inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.projectId):
(WebInspector.FileSystemProjectDelegate.prototype.id):
(WebInspector.FileSystemProjectDelegate.prototype.fileSystemPath):
(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemRemoved):
(WebInspector.FileSystemWorkspaceProvider.prototype.fileSystemPath):
* inspector/front-end/IsolatedFileSystemManager.js:
(WebInspector.IsolatedFileSystemManager.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemManager.prototype._fileSystemRemoved):
* inspector/front-end/Workspace.js:
(WebInspector.Workspace.prototype.uiSourceCodeForURL):

LayoutTests:

* inspector/file-system-mapping-expected.txt:
* inspector/file-system-mapping.html:
* inspector/file-system-project-expected.txt:
* inspector/workspace-mapping-expected.txt:
* inspector/workspace-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Polish TabbedEditorContaner and ScriptsNavigator behavior.
vsevik@chromium.org [Fri, 8 Mar 2013 15:25:04 +0000 (15:25 +0000)]
Web Inspector: Polish TabbedEditorContaner and ScriptsNavigator behavior.
https://bugs.webkit.org/show_bug.cgi?id=111732

Reviewed by Pavel Feldman.

Resources matching inspectedPageURL are always expanded in NavigatorView now.
Snippets tab in scripts navigator is not automatically opened anymore.
Cleared saved TabbedEditorContainer history because it might have been corrupted due to errors in earlier versions.
Snippets are not revealed in TabbedEditorContainer anymore unless they were actually selected by user or there is no other tabs opened.

* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._inspectedURLChanged):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.uiSourceCode):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.reveal):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._showFile):
* inspector/front-end/Settings.js:
(WebInspector.VersionController.prototype._updateVersionFrom1To2):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype.addUISourceCode.tabId.this._tabIds.get this):
(WebInspector.TabbedEditorContainer.prototype.addUISourceCode):
(WebInspector.TabbedEditorContainer.History.prototype._rebuildItemIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Fri, 8 Mar 2013 15:14:52 +0000 (15:14 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/TestExpectations: Skip test after r145195.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Add shortcut for running a snippet.
vsevik@chromium.org [Fri, 8 Mar 2013 15:11:30 +0000 (15:11 +0000)]
Web Inspector: Add shortcut for running a snippet.
https://bugs.webkit.org/show_bug.cgi?id=111680

Reviewed by Pavel Feldman.

Added Ctrl/Cmd+Enter as a shortcut for running a snippet.

* inspector/front-end/SnippetJavaScriptSourceFrame.js:
(WebInspector.SnippetJavaScriptSourceFrame):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runButtonClicked):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._runSnippet):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._onKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Memory leak at WKViewClientWebProcessCallbacks API test
mikhail.pozdnyakov@intel.com [Fri, 8 Mar 2013 15:05:26 +0000 (15:05 +0000)]
[EFL] Memory leak at WKViewClientWebProcessCallbacks API test
https://bugs.webkit.org/show_bug.cgi?id=111851

Reviewed by Kenneth Rohde Christiansen.

* TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
(TestWebKitAPI::TEST):

    Fixed WKURLRef instance leaking.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPrevent infinite loop in SVG use cycle detection
pdr@google.com [Fri, 8 Mar 2013 14:37:57 +0000 (14:37 +0000)]
Prevent infinite loop in SVG use cycle detection
https://bugs.webkit.org/show_bug.cgi?id=111822

Reviewed by Stephen Chenney.

Source/WebCore:

SVG use cycle detection depended on idForStyleResolution() which differs from
getIdAttribute() in quirks mode. During use tree cycle detection, this difference
resulted in an infinite loop because idForStyleResolution() used lower-cased id
attributes. This patch removes an existing fixme for this and switches to using
getIdAttribute().

Test: svg/custom/use-cycle-detection.html

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::hasCycleUseReferencing):

LayoutTests:

* svg/custom/use-cycle-detection-expected.html: Added.
* svg/custom/use-cycle-detection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWhen we set word-wrap: break-word and xml:space="preserve" to svg text element, the...
commit-queue@webkit.org [Fri, 8 Mar 2013 14:32:54 +0000 (14:32 +0000)]
When we set word-wrap: break-word and xml:space="preserve" to svg text element, the text is collapsed.
https://bugs.webkit.org/show_bug.cgi?id=111675

Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-03-08
Reviewed by Stephen Chenney.

Source/WebCore:

RenderSVGText define its size when it laid out its first line at SVGRootInlineBox::computePerCharacterLayoutInformation().

In the following spec, SVG don't perform automatic line break or word wrapping.
http://www.w3.org/TR/SVG/text.html#Introduction
> SVG performs no automatic line breaking or word wrapping.
However, when we set word-wrap: break-word and xml:space="preserve" to svg text element, RenderBlock::LineBreaker::nextLineBreak() breaks the text.
This make single character lines and make RenderSVGText narrow.

We must ignore word-wrap property to make the text a single line.

We always disable break words and break all in nextLineBreak() when the object is SVGInlineText.

Test: svg/text/preserve-break-word.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Disable break words and break all when we process SVG Text.

LayoutTests:

Test combination of xml:space="preserve" and word-wrap: break-word to SVG Text.
These text should not be collapsed.

* svg/text/preserve-break-word-expected.html: Added.
* svg/text/preserve-break-word.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] HTML5 video - sound volume bar out of widget
allan.jensen@digia.com [Fri, 8 Mar 2013 14:23:01 +0000 (14:23 +0000)]
[Qt] HTML5 video - sound volume bar out of widget
https://bugs.webkit.org/show_bug.cgi?id=108213

Reviewed by Jocelyn Turcotte.

Since we use Safari shadow DOM for media controls, follow
the overall layout of Safari media control CSS.

* css/mediaControlsQt.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
(audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2][EFL] Remove EwkView::setImageData()
mikhail.pozdnyakov@intel.com [Fri, 8 Mar 2013 14:13:35 +0000 (14:13 +0000)]
[WK2][EFL] Remove EwkView::setImageData()
https://bugs.webkit.org/show_bug.cgi?id=111849

Reviewed by Andreas Kling.

EwkView::setImageData() removed as it is not used at the moment
(it used to be part of eliminated non coord graphics code path).

* UIProcess/API/efl/EwkView.cpp:
* UIProcess/API/efl/EwkView.h:
(EwkView):
* UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::incorporateUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAllow platform-dependent strings for validationMessage property
tkent@chromium.org [Fri, 8 Mar 2013 14:12:56 +0000 (14:12 +0000)]
Allow platform-dependent strings for validationMessage property
https://bugs.webkit.org/show_bug.cgi?id=111846

Reviewed by Kentaro Hara.

Do not check matching with fixed strings in validationMessage.html
test. We print validationMessage values in the test instead.
We'd like to change user-visible strings at our own discretion.

* fast/forms/validationMessage-expected.txt:
Note that many platforms don't have a dedicated message for
badInput and uses the same message as typeMismatch for now.
* fast/forms/validationMessage.html:
* platform/chromium/fast/forms/validationMessage-expected.txt:
Chromium has a dedicated one for badInput.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] QWebSettings::clearMemoryCaches should release FastMalloc's free pages to OS
commit-queue@webkit.org [Fri, 8 Mar 2013 13:43:50 +0000 (13:43 +0000)]
[Qt] QWebSettings::clearMemoryCaches should release FastMalloc's free pages to OS
https://bugs.webkit.org/show_bug.cgi?id=111605

Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-03-08
Reviewed by Jocelyn Turcotte.

* Api/qwebsettings.cpp:
(QWebSettings::clearMemoryCaches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Doesn't build with QtMultimedia
allan.jensen@digia.com [Fri, 8 Mar 2013 13:24:11 +0000 (13:24 +0000)]
[Qt] Doesn't build with QtMultimedia
https://bugs.webkit.org/show_bug.cgi?id=111847

Reviewed by Jocelyn Turcotte.

Fix include.

* platform/graphics/qt/MediaPlayerPrivateQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] [WK2] Some authentication tests fail in WebKit2
ch.dumez@sisa.samsung.com [Fri, 8 Mar 2013 13:18:57 +0000 (13:18 +0000)]
[EFL] [WK2] Some authentication tests fail in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=106407

Reviewed by Kenneth Rohde Christiansen.

Tools:

Add patch from upstream for libsoup 2.40 to fix several authentication
test cases.

* efl/jhbuild.modules:
* efl/patches/libsoup-2.40-auth-fix.patch: Added.

LayoutTests:

Unskip several authentication test cases now that we cherry-picked
the needed libsoup fix from upstream.

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 8 Mar 2013 12:12:07 +0000 (12:12 +0000)]
Unreviewed GTK gardening.

* platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r145200.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][Qt] REGRESSION(r144787): A fixed element lags when scrolling and wheeling.
commit-queue@webkit.org [Fri, 8 Mar 2013 11:25:47 +0000 (11:25 +0000)]
[EFL][Qt] REGRESSION(r144787): A fixed element lags when scrolling and wheeling.
https://bugs.webkit.org/show_bug.cgi?id=111829

Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-08
Reviewed by Noam Rosenthal.

Currently, flagsChanged deals with all boolean flags. It introduces this bug
because when another flag (i.e. preserves3D) is changed, fixedToViewport is set
to false. So this patch updates all flags when at least one flag is changed.

In addition, this patch amends isScrollable code to match other flags.

This patch can only be tested manually since there is no automated
testing facilities for in-motion touch.
Test: ManualTests/fixed-position.html
      ManualTests/nested-fixed-position.html

* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setScrollableArea):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::setLayerState):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Memory leak in webkit_web_view_load_request() in WebKit2 API
commit-queue@webkit.org [Fri, 8 Mar 2013 10:40:10 +0000 (10:40 +0000)]
[GTK] Memory leak in webkit_web_view_load_request() in WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=111160

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Benjamin Poulain.

leakRef() is used for the returned PassRefPtr without taking the
ownership of the leaked ref.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_request): Use RefPtr local variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Autotools] Remove definitions of unnecessary Automake conditionals
zandobersek@gmail.com [Fri, 8 Mar 2013 10:29:30 +0000 (10:29 +0000)]
[Autotools] Remove definitions of unnecessary Automake conditionals
https://bugs.webkit.org/show_bug.cgi?id=111830

Reviewed by Philippe Normand.

The following Automake conditionals are not used anywhere and should have their
definitions in SetupAutomake.m4 removed:
ENABLE_GAMEPAD, ENABLE_XSLT, ENABLE_GEOLOCATION, ENABLE_SVG_FONTS,
ENABLE_OPCODE_STATS, ENABLE_CSS_FILTERS, ENABLE_CSS_SHADERS.

* Source/autotools/SetupAutomake.m4:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Enable Web Audio in development builds
zandobersek@gmail.com [Fri, 8 Mar 2013 10:08:05 +0000 (10:08 +0000)]
[GTK] Enable Web Audio in development builds
https://bugs.webkit.org/show_bug.cgi?id=111831

Reviewed by Philippe Normand.

Web Audio is already quite well supported on the GTK port but still has a few issues
that must be addressed before it is enabled by default. Despite that it should be enabled
in development builds just so we are up-to-date with future feature infrastructure changes.
The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
that's an obvious goal before enabling the feature in release builds.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Remove media stream support from the configuration options
zandobersek@gmail.com [Fri, 8 Mar 2013 10:06:35 +0000 (10:06 +0000)]
[GTK] Remove media stream support from the configuration options
https://bugs.webkit.org/show_bug.cgi?id=111813

Reviewed by Philippe Normand.

Remove the media-stream configuration flag. The feature is incomplete and
thus unsupported, so it really shouldn't be possible to enable it.

* Source/autotools/PrintBuildConfiguration.m4:
* Source/autotools/ReadCommandLineArguments.m4:
* Source/autotools/SetupAutomake.m4:
* Source/autotools/SetupWebKitFeatures.m4:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 8 Mar 2013 10:04:28 +0000 (10:04 +0000)]
Unreviewed GTK gardening.

Skipping the tests in inspector-protocol/layers as they rely on compositing support
which is not available on the GTK builders.
Adding failure expectations for tests that regressed with r145100.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove dead label code in snapshotted plugin
dino@apple.com [Fri, 8 Mar 2013 10:01:42 +0000 (10:01 +0000)]
Remove dead label code in snapshotted plugin
https://bugs.webkit.org/show_bug.cgi?id=111781

Reviewed by Tim Horton.

Since ports can use the shadow tree to do label display,
there is no need for the hardcoded timers in RenderSnapshottedPlugin.

* rendering/RenderSnapshottedPlugIn.cpp: Remove label flags and timers.
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::updateSnapshot):
(WebCore::RenderSnapshottedPlugIn::handleEvent):
* rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn):

Conflicts:
Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImplement a custom appearance for the snapshotted plugin background
dino@apple.com [Fri, 8 Mar 2013 10:01:21 +0000 (10:01 +0000)]
Implement a custom appearance for the snapshotted plugin background
https://bugs.webkit.org/show_bug.cgi?id=108368

Reviewed by NOBODY (OOPS!).

Source/WebCore:

After https://bugs.webkit.org/show_bug.cgi?id=108284 (r142507), a
snapshotted plugin was no longer drawing the background of the
label blurred. Since the snapshot content was now a shadow tree,
it wasn't feasible to pre-blur a region of the snapshot: the label
could be any size and in any location, with ports being able to
override the appearance through their UA style sheet.

Instead we now use one of the elements in the tree, the snapshot-overlay,
as a hook where ports can add any effect they want. This could be simply
a border, or a transparent mask, or even a CSS filter. We introduce a custom
CSS appearance "snapshotted-plugin-overlay", which could be added to the
element in the injected UA stylesheet. This calls into RenderTheme in
the same way that custom controls do.

Meanwhile, in RenderThemeMac, we implement the appearance by drawing the
content of the plugin snapshot into the background of the element. That
way we can add effects in CSS.

Test: plugins/snapshot-appearance.html

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Handle SnapshottedPluginOverlayPart.
* css/CSSValueKeywords.in: New appearance value snapshotted-plugin-overlay.
* platform/ThemeTypes.h: New value SnapshottedPluginOverlayPart.
* html/HTMLPlugInElement.h:
(WebCore::toHTMLPlugInElement): Add safer casting helpers.
* html/HTMLPlugInImageElement.h:
(WebCore::toHTMLPlugInImageElement): Ditto.
* rendering/RenderSnapshottedPlugIn.cpp: Remove the code for handling
    the blur directly in the renderer.
(WebCore::RenderSnapshottedPlugIn::paint): Simplify the paint logic since we're
    no longer trying to blur here.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Ditto.
* rendering/RenderSnapshottedPlugIn.h: Remove the methods that were trying
    to blur the image directly.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint): Call paintSnapshottedPluginOverlay.
* rendering/RenderTheme.h:
(WebCore::RenderTheme::paintSnapshottedPluginOverlay): New virtual method with default implementation.
* rendering/RenderThemeMacShared.h:
(RenderThemeMacShared): Override paintSnapshottedPluginOverlay.
* rendering/RenderThemeMacShared.mm:
(WebCore::RenderThemeMacShared::paintSnapshottedPluginOverlay): Implement a custom render path
    that takes the snapshot image from the node's parent, and draws it into the background.
    Along the way make sure we're actually using the right type of element (an HTMLPlugInImageElement).

LayoutTests:

Toggles our new snapshotted-plugin-overlay appearance, to make sure it
isn't getting applied to non-plugins.

* plugins/snapshot-appearance-expected.html: Added.
* plugins/snapshot-appearance.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImprove drag&drop of list items in contentEditable divs
sergio@webkit.org [Fri, 8 Mar 2013 09:58:28 +0000 (09:58 +0000)]
Improve drag&drop of list items in contentEditable divs
https://bugs.webkit.org/show_bug.cgi?id=111556

Reviewed by Ryosuke Niwa.

Source/WebCore:

A single fully selected <li> should generate the same markup as if
we were selecting some of them, i.e., we should preserve the list
structure and appearance.

Test: editing/selection/drag-list-item.html

* editing/htmlediting.cpp:
(WebCore::isListItem): modified constness.
* editing/htmlediting.h:
(WebCore): ditto.
* editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup):

LayoutTests:

Added a new test case. The test performs 2 drag&drops, first of
all a selection of a single list item, and secondly a selection of
two list items. It checks that both behave the same way, i.e, the
whole <li> is moved and not only the text.

* editing/selection/drag-list-item-expected.txt: Added.
* editing/selection/drag-list-item.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCache flush problem on ARMv7 JSC
rgabor@webkit.org [Fri, 8 Mar 2013 09:27:38 +0000 (09:27 +0000)]
Cache flush problem on ARMv7 JSC
https://bugs.webkit.org/show_bug.cgi?id=111441

Reviewed by Zoltan Herczeg.

Not proper cache flush causing random crashes on ARMv7 Linux with V8 tests.
The problem is similar to https://bugs.webkit.org/show_bug.cgi?id=77712.
Change the cache fulsh mechanism similar to ARM traditinal and revert the
temporary fix.

Source/JavaScriptCore:

* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::cacheFlush):

Source/WTF:

* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveUncommitted):
(WTF::OSAllocator::decommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] LayerTiler: rename currentFrameHasAlpha as currentFrameKnownToBeOpaque
commit-queue@webkit.org [Fri, 8 Mar 2013 09:21:24 +0000 (09:21 +0000)]
[BlackBerry] LayerTiler: rename currentFrameHasAlpha as currentFrameKnownToBeOpaque
https://bugs.webkit.org/show_bug.cgi?id=111828

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-08
Reviewed by Carlos Garcia Campos.

This changed in r141637.

* platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::updateTextureContentsIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Fri, 8 Mar 2013 09:17:18 +0000 (09:17 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/TestExpectations: Skip failing test after r145100.
* platform/qt/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Rebaselining after r145067.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix a couple of typos, unreviewed.
graouts@apple.com [Fri, 8 Mar 2013 08:56:45 +0000 (08:56 +0000)]
Fix a couple of typos, unreviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Use OwnPtr for CredentialBackingStore members
commit-queue@webkit.org [Fri, 8 Mar 2013 08:29:02 +0000 (08:29 +0000)]
[BlackBerry] Use OwnPtr for CredentialBackingStore members
https://bugs.webkit.org/show_bug.cgi?id=111737

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-08
Reviewed by Rob Buis.

It simplifies the code a bit.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::CredentialBackingStore::~CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::certMgrWrapper):
* platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] delay clearing the TestRunners until the main view was deleted
jochen@chromium.org [Fri, 8 Mar 2013 08:00:54 +0000 (08:00 +0000)]
[chromium] delay clearing the TestRunners until the main view was deleted
https://bugs.webkit.org/show_bug.cgi?id=111823

Reviewed by Eric Seidel.

During WebViewHost::shutdown, we navigate the WebView to about:blank.
This may call into the test runners which assume that the delegate is
always non-NULL.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::~TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMemoryPressureHandler should fully flush the WebCore & NS URL caches
barraclough@apple.com [Fri, 8 Mar 2013 07:57:01 +0000 (07:57 +0000)]
MemoryPressureHandler should fully flush the WebCore & NS URL caches
https://bugs.webkit.org/show_bug.cgi?id=111827

Rubber Stamped by Geoff Garen

When the handler is fired we should free as much memory as possible.

* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::releaseMemory):
    - fully flush the WebCore & NS URL caches

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSheriffbot whois command can't search by full name
commit-queue@webkit.org [Fri, 8 Mar 2013 07:55:38 +0000 (07:55 +0000)]
Sheriffbot whois command can't search by full name
https://bugs.webkit.org/show_bug.cgi?id=111825

Patch by Alan Cutter <alancutter@chromium.org> on 2013-03-07
Reviewed by Eric Seidel.

Allowed multiple arguments to Sheriffbot's whois command.
Updated test expectations.

* Scripts/webkitpy/tool/bot/irc_command.py:
(Whois.execute):
* Scripts/webkitpy/tool/bot/irc_command_unittest.py:
(IRCCommandTest.test_whois):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate calendar picker UI
keishi@webkit.org [Fri, 8 Mar 2013 07:37:00 +0000 (07:37 +0000)]
Update calendar picker UI
https://bugs.webkit.org/show_bug.cgi?id=109439

Reviewed by Kent Tamura.

.:

* ManualTests/forms/calendar-picker.html: New test file with more options.
* ManualTests/forms/date-suggestion-picker.html: Copied from ManualTests/forms/calendar-picker.html. Old one kept for dat/time suggestion picker testing.

Source/WebCore:

This patch changes the calendar picker UI.

Added tests to existing calendar picker tests.
Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html

* Resources/pagepopups/calendarPicker.css:
(body):
(.rtl):
(.scroll-view):
(.scroll-view-content):
(.list-cell):
(.list-cell.hidden):
(.day-cell):
(.week-number-cell):
(.day-cell.today):
(.day-cell.highlighted):
(.day-cell.highlighted.disabled):
(.day-cell.selected):
(.day-cell.disabled):
(.day-cell.current-month):
(.calendar-table-view):
(.preparing .calendar-table-view:focus):
(.week-day-label):
(.week-number-label):
(.calendar-table-header-view):
(.calendar-picker):
(.calendar-header-view):
(.calendar-title):
(.rtl .calendar-title):
(.month-popup-button:disabled):
(.month-popup-button):
(.month-popup-button .disclosure-triangle):
(.month-popup-button .disclosure-triangle svg):
(.today-button::after):
(.calendar-navigation-button):
(.year-list-view):
(.year-list-cell):
(.year-list-cell .label):
(.year-list-cell .month-chooser):
(.month-buttons-row):
(.month-button):
(.month-button.highlighted):
(.scrubby-scroll-bar):
(.scrubby-scroll-thumb):
(.month-popup-view):
(.year-list-view .scrubby-scroll-bar):
(.rtl .year-list-view .scrubby-scroll-bar):
* Resources/pagepopups/calendarPicker.js:
(setGlobalParams): Sets the global params.
(initialize):
(openCalendarPicker):
(CalendarHeaderView.prototype.onNavigationButtonClick): Fix typo.
(CalendarPicker):
(CalendarPicker.prototype.onWindowResize): We want to have the "preparing" class applied
to cancel css transitions while setting up the calendar picker so we can avoid flaky pixel tests.
(CalendarPicker.prototype.onYearListViewDidHide): The user clicked on a month so hide the month popup.
(CalendarPicker.prototype.onYearListViewDidSelectMonth): Change the current month in response to the month popup.
(CalendarPicker.prototype.attachTo): We want the calendar table focused when the calendar picker first opens.
(CalendarPicker.prototype.cleanup): Clean up any event listeners or elements attached to nodes outside of this.element.
(CalendarPicker.prototype.onMonthPopupButtonClick): Open the month popup in response to the month popup button being clicked.
(CalendarPicker.prototype._setConfig): Configures the calendar picker.
(CalendarPicker.prototype.currentMonth): The currently shown month.
(CalendarPicker.prototype.setCurrentMonth): Scrolls the calendar table to the given month. Use the navigation behavior param to specify if you want a transition animation.
(CalendarPicker.prototype.adjustHeight): Adjusts the height so its just tall enough to fit the current month. If the month picker is open, fit that.
(CalendarPicker.prototype.selection): Currently selected date range.
(CalendarPicker.prototype.highlight): Currently highlighted date range.
(CalendarPicker.prototype.firstVisibleDay): Returns the first visible day ignoring scroll animation (i.e. this is the first visible day when the scroll animation is done).
(CalendarPicker.prototype.lastVisibleDay): Returns the last visible day ignoring scroll animation.
(CalendarPicker.prototype.selectRangeContainingDay): Sets the selection to the date range containing the given day.
(CalendarPicker.prototype.highlightRangeContainingDay): Sets the highlight to the date range containing the given day.
(CalendarPicker.prototype.setSelection): Sets the selection to the given date range.
(CalendarPicker.prototype._setHighlight): Sets the highlight to the given date range.
(CalendarPicker.prototype._stepMismatch): Just moving.
(CalendarPicker.prototype._outOfRange): Ditto.
(CalendarPicker.prototype.isValid): Returns true if the given date range is a valid selection.
(CalendarPicker.prototype.isValidDay): Returns true if the day is part of a valid selection.
(CalendarPicker.prototype._moveHighlight): Moves the highlight to the given date range if possible. Returns true if it succeeds.
(CalendarPicker.prototype.onCalendarTableKeyDown): Handles the arrow keys, etc.
(CalendarPicker.prototype.width):
(CalendarPicker.prototype.height):
(CalendarPicker.prototype.setHeight):
(CalendarPicker.prototype.onBodyKeyDown): Handles esc/m/y/d.
* Resources/pagepopups/chromium/calendarPickerChromium.css:
(.calendar-table-view:focus):
(.preparing .calendar-table-view:focus):

Source/WebKit/chromium:

* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::writeDocument): Adding shortMonthLabels property.

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt: Removed.
* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt: Removed.
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations-expected.txt:
* platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-key-operations-expected.txt:
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetimelocal-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-datetimelocal.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-pre-100-year-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-pre-100-year.html:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-with-step.html:
* platform/chromium/fast/forms/calendar-picker/date-picker-events-expected.txt:
* platform/chromium/fast/forms/calendar-picker/date-picker-events.html:
* platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events-expected.txt:
* platform/chromium/fast/forms/calendar-picker/datetimelocal-picker-events.html:
* platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
* platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html:
* platform/chromium/fast/forms/calendar-picker/month-picker-with-step-expected.txt:
* platform/chromium/fast/forms/calendar-picker/month-picker-with-step.html:
* platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:
(currentMonth):
(highlightedValue):
(selectedValue):
(skipAnimation):
(hoverOverDayCellAt):
(clickDayCellAt):
* platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:
* platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations.html:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html:
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html:
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-key-operations.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] EwkView should keep css position instead of scroll position in device pixel.
commit-queue@webkit.org [Fri, 8 Mar 2013 07:30:02 +0000 (07:30 +0000)]
[EFL] EwkView should keep css position instead of scroll position in device pixel.
https://bugs.webkit.org/show_bug.cgi?id=110847

Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-07
Reviewed by Kenneth Rohde Christiansen.

Signed off for WebKit2 by Benjamin Poulain.

There are bugs that some code expect that EwkView::pagePosition() returns css
position while others expect that it returns scroll position in device pixel.
In addition, some code call EwkView::setPagePosition() with css position while
others call it with scroll position in device pixel.

This patch makes all code use setPagePosition() and pagePosition() with
UI pixels (a.k.a Density Independent Pixel).

* UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::paintToCairoSurface):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::transformToScene):
(WebKit::WebView::pageDidRequestScroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago https://bugs.webkit.org/show_bug.cgi?id=111801
ap@apple.com [Fri, 8 Mar 2013 07:17:30 +0000 (07:17 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=111801
        https://bugs.webkit.org/show_bug.cgi?id=111801

        Reviewed by Geoff Garen.

        Move unnecessary includes out of headers.

        * NetworkProcess/HostRecord.h:
        * NetworkProcess/NetworkConnectionToWebProcess.cpp:
        * NetworkProcess/NetworkProcess.cpp:
        * NetworkProcess/NetworkResourceLoadScheduler.cpp:
        * NetworkProcess/NetworkResourceLoadScheduler.h:
        * NetworkProcess/NetworkResourceLoader.h:
        * NetworkProcess/SchedulableLoader.cpp:
        * NetworkProcess/SchedulableLoader.h:
        * NetworkProcess/SyncNetworkResourceLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145184 268f45cc-cd09-0410-ab3c-d52691b4dbfc