WebKit-https.git
10 years ago* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
alice.liu@apple.com [Tue, 30 Mar 2010 06:52:27 +0000 (06:52 +0000)]
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make:
add JSObjectRefPrivate.h

Reviewed by NOBODY (build fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Many new test results are needed due to recent check-ins.
levin@chromium.org [Tue, 30 Mar 2010 06:44:29 +0000 (06:44 +0000)]
[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

Reviewed by Shinichiro Hamaji.

Various rebaselines due to changes in layout or new tests. The revision that caused
each change is by the change.

* platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.checksum: Added. Due to r56655.
* platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png: Added. Ditto.
* platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1296-expected.txt.
* platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.checksum: Added. Ditto.
* platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png: Added. Ditto.
* platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1430-expected.txt.
* platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.checksum: Added. Due to r56740.
* platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.png: Added. Ditto.
* platform/chromium-win/fast/media/media-feature-wgt-view-mode-expected.txt: Added. Ditto.
* platform/chromium-win/svg/custom/marker-overflow-clip-expected.txt: Due to r56693.
* platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.checksum: Due to r56655.
* platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Ditto.
* platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.checksum: Ditto.
* platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png: Ditto.
* platform/chromium/test_expectations.txt: Added a few failures with follow up bugs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 30 Mar 2010 06:16:14 +0000 (06:16 +0000)]
2010-03-29  Eric Seidel  <eric@webkit.org>

        Unreviewed, build fix only.

        * Scripts/webkitpy/tool/steps/validatereviewer.py: Add missing import.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 30 Mar 2010 06:15:21 +0000 (06:15 +0000)]
2010-03-29  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Hyatt.

        No vertical scrollbar after the CSS class change
        https://bugs.webkit.org/show_bug.cgi?id=36461

        * fast/repaint/overflow-scroll-body-appear.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
        * platform/mac/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
        * platform/mac/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
        * platform/qt/Skipped:
        * platform/win/Skipped:
2010-03-29  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Hyatt.

        No vertical scrollbar after the CSS class change
        https://bugs.webkit.org/show_bug.cgi?id=36461

        Don't suppress scrollbar change for non-first layouts.
        In the first layout, the scrollbar change will happen in later
        adjustViewSize() call, but in other layouts, adjustViewSize() may
        not be called when the size of contents doesn't change.

        * page/FrameView.cpp:
        (WebCore::FrameView::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Hayato Ito <hayato@chromium.org>
eric@webkit.org [Tue, 30 Mar 2010 06:08:34 +0000 (06:08 +0000)]
2010-03-29  Hayato Ito  <hayato@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Remove '_flymake' suffix from base part of file name so that
        check-webkit-style uses a correct header guard name when it is called from Emacs's flymake.

        https://bugs.webkit.org/show_bug.cgi?id=36573

        * Scripts/webkitpy/style/processors/cpp.py:
        * Scripts/webkitpy/style/processors/cpp_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Chris Jerdonek <cjerdonek@webkit.org>
eric@webkit.org [Tue, 30 Mar 2010 05:41:24 +0000 (05:41 +0000)]
2010-03-29  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Eric Seidel.

        Get the following test-webkitpy unit test working again:
        scm_unittest.SVNTest.test_svn_apply().

        https://bugs.webkit.org/show_bug.cgi?id=36696

        * Scripts/webkitpy/common/checkout/scm_unittest.py:
          - Add leading spaces to the empty lines of the ChangeLog strings.
          - Manually set the _reviewer attribute on the Attachment object
            to get the tests to pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Tue, 30 Mar 2010 05:09:07 +0000 (05:09 +0000)]
2010-03-29  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adele Peterson.

        Default value of accelerated compositing should be false for Windows
        https://bugs.webkit.org/show_bug.cgi?id=36805

        * WebPreferences.cpp:
        (WebPreferences::initializeDefaultSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Martin Robinson <mrobinson@webkit.org>
mrobinson@webkit.org [Tue, 30 Mar 2010 04:04:40 +0000 (04:04 +0000)]
2010-03-29  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Holger Freyther.

        [GTK] suppress (un)desired launcher output that can make layout test to fail with stderr
        https://bugs.webkit.org/show_bug.cgi?id=36390

        Suppress debugging messages sent to the GLib logger during DRT runs.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (logHandler): Added.
        (main): Use logHandler as the default GLib log message handler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Chao-ying Fu <fu@mips.com>
eric@webkit.org [Tue, 30 Mar 2010 02:59:20 +0000 (02:59 +0000)]
2010-03-29  Chao-ying Fu  <fu@mips.com>

        Reviewed by Oliver Hunt.

        MIPS JIT Supports
        https://bugs.webkit.org/show_bug.cgi?id=30144

        The following changes enable MIPS JIT.

        * assembler/MIPSAssembler.h:
        (JSC::MIPSAssembler::lbu):
        (JSC::MIPSAssembler::linkWithOffset):
        * assembler/MacroAssemblerMIPS.h:
        (JSC::MacroAssemblerMIPS::load8):
        (JSC::MacroAssemblerMIPS::branch8):
        (JSC::MacroAssemblerMIPS::branchTest8):
        (JSC::MacroAssemblerMIPS::setTest8):
        (JSC::MacroAssemblerMIPS::setTest32):
        * jit/JIT.h:
        * jit/JITInlineMethods.h:
        (JSC::JIT::preserveReturnAddressAfterCall):
        (JSC::JIT::restoreReturnAddressBeforeReturn):
        * jit/JITOpcodes.cpp:
        * jit/JITStubs.cpp:
        (JSC::JITThunks::JITThunks):
        * jit/JITStubs.h:
        (JSC::JITStackFrame::returnAddressSlot):
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Many new test results are needed due to recent check-ins.
levin@chromium.org [Tue, 30 Mar 2010 02:44:28 +0000 (02:44 +0000)]
[chromium] Many new test results are needed due to recent check-ins.
https://bugs.webkit.org/show_bug.cgi?id=36799

Reviewed by Dimitri Glazkov.

r56655 changed how tables layout which causes a lot of pixels tests for
tables to need rebaselines.

r56693 did some svg changes.

* platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.checksum: Due to r56655.
* platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png: Ditto.
* platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.checksum: Ditto.
* platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png: Ditto.
* platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Ditto.
* platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Ditto.
* platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Ditto.
* platform/chromium-linux/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Ditto.
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Ditto.
* platform/chromium-win/svg/custom/invalid-css-expected.txt: Due to r56693.
* platform/chromium-win/svg/custom/marker-default-width-height-expected.txt: Ditto.
* platform/chromium-win/svg/custom/shapes-supporting-markers-expected.txt: Ditto.
* platform/chromium-win/tables/mozilla/bugs/bug1296-expected.checksum: Due to r56655.
* platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png: Ditto.
* platform/chromium-win/tables/mozilla/bugs/bug1430-expected.checksum: Ditto.
* platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png: Ditto.
* platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum: Ditto.
* platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Ditto.
* platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum: Ditto.
* platform/chromium-win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum: Ditto.
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Ditto.
* platform/chromium/test_expectations.txt: Two newly added tests are timing out (covered by http://crbug.com/35387).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Chris Evans <cevans@chromium.org>
eric@webkit.org [Tue, 30 Mar 2010 02:32:14 +0000 (02:32 +0000)]
2010-03-29  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        * fast/xmlhttprequest/xmlhttprequest-no-file-access.html:
          Check that an isolated file:// origin can access about:blank iframes
          that it created itself.
2010-03-29  Chris Evans  <cevans@chromium.org>

        Reviewed by Adam Barth.

        Don't use unique domains for file:// separation: it breaks local
        databases, and access to your own same-origin iframes. Instead, use
        path-based access checks.

        https://bugs.webkit.org/show_bug.cgi?id=36692

        Test: fast/xmlhttprequest/xmlhttprequest-no-file-access.html

        * dom/Document.cpp:
        (WebCore::Document::initSecurityContext): renamed API.
        * page/SecurityOrigin.h:
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::SecurityOrigin):
          Initialize new flag. Take note of file:// path.
          Copy new fields in copy constructor.
        (WebCore::SecurityOrigin::canAccess):
          Take into account path-based origin separation for file://
        (WebCore::SecurityOrigin::enforceFilePathSeparation):
          New method to enable file:// path origin separation.
        (WebCore::SecurityOrigin::toString):
          Return a null domain for an isolated file origin.
        (WebCore::SecurityOrigin::isSameSchemeHostPort):
          Take into account path-based origin separation for file://
        (WebCore::SecurityOrigin::passesFileCheck):
          Abstraction of common logic for file:// access checks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Rafael Weinstein <rafaelw@chromium.org>
eric@webkit.org [Tue, 30 Mar 2010 01:38:03 +0000 (01:38 +0000)]
2010-03-29  Rafael Weinstein  <rafaelw@chromium.org>

        Reviewed by Adam Barth.

        Change NotificationPresenter::checkPermission() to take the source frames full KURL,
        rather than its SecurityOrigin. This will aid chromium in having more fine grained
        permissions to control notification spam.

        * notifications/Notification.cpp:
        (WebCore::Notification::Notification):
        * notifications/NotificationCenter.cpp:
        (WebCore::NotificationCenter::checkPermission):
        * notifications/NotificationPresenter.h:
2010-03-29  Rafael Weinstein  <rafaelw@chromium.org>

        Reviewed by Adam Barth.

        Change NotificationPresenter::checkPermission() to take the source frames full KURL,
        rather than its SecurityOrigin. This will aid chromium in having more fine grained
        permissions to control notification spam.

        * public/WebNotificationPresenter.h:
        (WebKit::WebNotificationPresenter::checkPermission):
        * src/NotificationPresenterImpl.cpp:
        (WebKit::NotificationPresenterImpl::checkPermission):
        * src/NotificationPresenterImpl.h:
2010-03-29  Rafael Weinstein  <rafaelw@chromium.org>

        Reviewed by Adam Barth.

        Change NotificationPresenter::checkPermission() to take the source frames full KURL,
        rather than its SecurityOrigin. This will aid chromium in having more fine grained
        permissions to control notification spam.

        * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
        (WebDesktopNotificationsDelegate::checkPermission):
        * WebCoreSupport/WebDesktopNotificationsDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 30 Mar 2010 01:15:35 +0000 (01:15 +0000)]
2010-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        sheriff-bot should comment on bugs when builders break
        https://bugs.webkit.org/show_bug.cgi?id=36786

        * Scripts/webkitpy/tool/commands/sheriffbot.py:
         - Add a new _post_blame_comment_to_bug and all it from process_work_item
         - Move commit-queue logic into _post_rollout_patch to make its api match the other _post commands.
        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
         - Test the new _post_blame_comment_to_bug call

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 30 Mar 2010 01:07:53 +0000 (01:07 +0000)]
2010-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        sheriff-bot fails to get information about certain builds
        https://bugs.webkit.org/show_bug.cgi?id=36768

        This seems to be caused by:
        http://buildbot.net/trac/ticket/753
        I have no work-around, but for now at least we're logging
        the error better.  I also added allow_none to our ServerProxy
        creation in case that fixes things for other versions of python.

        * Scripts/webkitpy/common/net/buildbot.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Victor Wang <victorw@chromium.org>
eric@webkit.org [Tue, 30 Mar 2010 00:34:42 +0000 (00:34 +0000)]
2010-03-29  Victor Wang  <victorw@chromium.org>

        Reviewed by Adam Barth.

        Add sign in/out link to TestResults appengine

        Add a link to main menu for sign in/out to this appengine.
        People signed in with admin privilege could perform
        actions that are only allowed to admins like deleting files.

        https://bugs.webkit.org/show_bug.cgi?id=36767

        * TestResultServer/handlers/menu.py:
        * TestResultServer/stylesheets/menu.css:
        (.sign):
        * TestResultServer/templates/menu.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Tue, 30 Mar 2010 00:16:17 +0000 (00:16 +0000)]
2010-03-29  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Multiselect - Adding method itemIsSelected() to QtAbstractWebPopup
        https://bugs.webkit.org/show_bug.cgi?id=36769

        Adding method itemIsSelected() to QtAbstractWebPopup.

        * platform/qt/QtAbstractWebPopup.h:
        (WebCore::QtAbstractWebPopup::itemIsSelected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Dmitry Titov.
levin@chromium.org [Mon, 29 Mar 2010 23:58:55 +0000 (23:58 +0000)]
Rubber-stamped by Dmitry Titov.

[Chromium] pixel layout test fixes.

r56655 caused runin test which needed separate results for each platform.
r56673 caused computed-style-expected.
r56655 cause the fast/table changes (and we need linux specific results).
r56644 caused clip-path-referencing-use2-expected.
r56693 caused painting-marker-01-f-expected.

* platform/chromium-linux/fast/runin/generated2-expected.checksum: Added.
* platform/chromium-linux/fast/runin/generated2-expected.png: Added.
* platform/chromium-linux/fast/runin/generated2-expected.txt: Added.
* platform/chromium-linux/fast/runin/generated3-expected.checksum: Added.
* platform/chromium-linux/fast/runin/generated3-expected.png: Added.
* platform/chromium-linux/fast/runin/generated3-expected.txt: Added.
* platform/chromium-linux/fast/runin/generated4-expected.checksum: Added.
* platform/chromium-linux/fast/runin/generated4-expected.png: Added.
* platform/chromium-linux/fast/runin/generated4-expected.txt: Added.
* platform/chromium-linux/fast/table/table-background-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-background-expected.png: Added.
* platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
* platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
* platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
* platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
* platform/chromium-linux/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-cell-overrides-row-background-expected.png: Added.
* platform/chromium-linux/fast/table/table-col-background-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-col-background-expected.png: Added.
* platform/chromium-linux/fast/table/table-col-group-background-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-col-group-background-expected.png: Added.
* platform/chromium-linux/fast/table/table-col-group-col-span-background-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-col-group-col-span-background-expected.png: Added.
* platform/chromium-linux/fast/table/table-col-group-span-background-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-col-group-span-background-expected.png: Added.
* platform/chromium-linux/fast/table/table-col-span-background-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-col-span-background-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-background-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-row-background-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-background-left-50px-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-row-background-left-50px-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-background-right-100percent-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-row-background-right-100percent-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-background-right-50px-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-row-background-right-50px-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-group-background-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-row-group-background-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-group-background-positioned-expected.checksum: Added.
* platform/chromium-linux/fast/table/table-row-group-background-positioned-expected.png: Added.
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-mac/fast/runin/generated2-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated2-expected.checksum.
* platform/chromium-mac/fast/runin/generated2-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated2-expected.png.
* platform/chromium-mac/fast/runin/generated3-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated3-expected.checksum.
* platform/chromium-mac/fast/runin/generated3-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated3-expected.png.
* platform/chromium-mac/fast/runin/generated4-expected.checksum: Renamed from LayoutTests/platform/chromium/fast/runin/generated4-expected.checksum.
* platform/chromium-mac/fast/runin/generated4-expected.png: Renamed from LayoutTests/platform/chromium/fast/runin/generated4-expected.png.
* platform/chromium-mac/svg/custom/clip-path-referencing-use2-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/runin/generated2-expected.checksum: Added.
* platform/chromium-win/fast/runin/generated2-expected.png: Added.
* platform/chromium-win/fast/runin/generated2-expected.txt: Added.
* platform/chromium-win/fast/runin/generated3-expected.checksum: Added.
* platform/chromium-win/fast/runin/generated3-expected.png: Added.
* platform/chromium-win/fast/runin/generated3-expected.txt: Added.
* platform/chromium-win/fast/runin/generated4-expected.checksum: Added.
* platform/chromium-win/fast/runin/generated4-expected.png: Added.
* platform/chromium-win/fast/runin/generated4-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
* platform/chromium-win/svg/custom/clip-path-referencing-use2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Dawit Alemayehu <adawit@kde.org>
eric@webkit.org [Mon, 29 Mar 2010 23:58:03 +0000 (23:58 +0000)]
2010-03-29  Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Simon Hausmann.

        Added a function, WebCore::shouldTreatAsAttachment, to HTTPParsers.*

        https://bugs.webkit.org/show_bug.cgi?id=36395

        This function, which was moved from WebKit/chromium/src/FrameClientImpl.cpp,
        is used to check whether or not a request is supposed to be rendered or
        simply downloaded based on the "Content-Disposition" header sent by the
        web server. The intent of code refactoring is to avoid code duplication
        so that this piece of code can be used by other implementations such as
        QtWebKit.

        * platform/network/HTTPParsers.cpp:
        (WebCore::shouldTreatAsAttachment):
        * platform/network/HTTPParsers.h:
2010-03-29  Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Simon Hausmann.

        Factored out the 'ShouldTreatAsAttachment' function to HTTPParsers.*
        and replacted local version with the factored out version.

        The code was factored out to make possible its use in other implementations
        such as QtWebKit.

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):
2010-03-29  Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Simon Hausmann.

        [Qt] Added support for handling the HTTP "Content-Disposition" header.

        https://bugs.webkit.org/show_bug.cgi?id=36395

        Whenever a server response contains a "Content-Disposition: attachment..." header,
        treat the request as a download and emit the unsupportedContent signal.

        * Api/qwebpage.cpp:
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::download):
        (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Chris Fleizach <cfleizach@apple.com>
eric@webkit.org [Mon, 29 Mar 2010 23:38:40 +0000 (23:38 +0000)]
2010-03-29  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        Bug 36735 - Live regions don't send out notifications when the element changing is the live region
        https://bugs.webkit.org/show_bug.cgi?id=36735

        * platform/mac/accessibility/aria-liveregion-on-image-expected.txt: Added.
        * platform/mac/accessibility/aria-liveregion-on-image.html: Added.
2010-03-29  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        Bug 36735 - Live regions don't send out notifications when the element changing is the live region
        https://bugs.webkit.org/show_bug.cgi?id=36735

        Test: platform/mac/accessibility/aria-liveregion-on-image.html

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::contentChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 29 Mar 2010 23:33:49 +0000 (23:33 +0000)]
2010-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        ValidateReviewer step is draconian and un-tested
        https://bugs.webkit.org/show_bug.cgi?id=36792

        ValidateReviewer logic was commented out in
        http://trac.webkit.org/changeset/56744
        That was a symptom of the fact that validatereviewer.py
        is too inflexible to be used when real humans are driving webkit-patch.
        For now we just disable ValidateReviewer when humans are at the keyboard.

        * Scripts/webkitpy/tool/steps/validatereviewer.py:
         - Only run when in non-interactive mode.
        * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Added.
         - Test our validation logic to make sure it's sane.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Chris Jerdonek <cjerdonek@webkit.org>
eric@webkit.org [Mon, 29 Mar 2010 23:18:27 +0000 (23:18 +0000)]
2010-03-29  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Shinichiro Hamaji.

        Eliminate explicit slash characters from check-webkit-style's
        _rel_path() method to make its implementation more platform
        independent.

        https://bugs.webkit.org/show_bug.cgi?id=36759

        * Scripts/webkitpy/style/main.py:
          - Changed to use os.sep instead of slash_chars "/\\".  This can
            be done since os.path.abspath() converts slashes to os.sep.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 29 Mar 2010 22:35:35 +0000 (22:35 +0000)]
2010-03-29  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Change new-run-webkit-tests to not use more than four threads by
        default on the mac port until
        https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed.

        https://bugs.webkit.org/show_bug.cgi?id=36687

        * Scripts/webkitpy/layout_tests/port/mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 29 Mar 2010 22:34:33 +0000 (22:34 +0000)]
2010-03-29  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Dimitri Glazkov.

        Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance.

        https://bugs.webkit.org/show_bug.cgi?id=36691

        * Scripts/webkitpy/layout_tests/port/mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Mon, 29 Mar 2010 22:28:45 +0000 (22:28 +0000)]
2010-03-29  Stephen White  <senorblanco@chromium.org>

        Reviewed by Dave Hyatt.

        In order to speed up multiple calls to CSSPrimitiveValue::cssText(),
        this CL caches the String result.  When m_value is changed, the
        cached string is cleared.  This gives a good speedup on benchmarks
        which do a lot of CSS property gets, such as Peacekeeper.
        The processing cost should be negligible, since the strings are
        refcounted.  The memory cost is an additional 4 bytes per
        CSSPrimitiveValue, and the extended lifetime of the computed string
        (potentially, the same as the lifetime of the CSSPrimitiveValue).

        https://bugs.webkit.org/show_bug.cgi?id=36556

        Covered by fast/css/cssText-cache.html, and more.

        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::cleanup):
        (WebCore::CSSPrimitiveValue::cssText):
        * css/CSSPrimitiveValue.h:
2010-03-29  Stephen White  <senorblanco@chromium.org>

        Reviewed by Dave Hyatt.

        Added a test for CSSPrimitiveValue::cssText() string cacheing.

        https://bugs.webkit.org/show_bug.cgi?id=36556

        * fast/css/cssText-cache-expected.txt: Added.
        * fast/css/cssText-cache.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 29 Mar 2010 22:20:25 +0000 (22:20 +0000)]
2010-03-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        new-run-webkit-tests fails java/lc3 on a clean checkout
        https://bugs.webkit.org/show_bug.cgi?id=36078

        * Scripts/webkitpy/layout_tests/port/mac.py:
         - Build the java support files in check_build
         - Unwrap a line which would still fit under 80col

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild Fix: Touch WebKit.idl to force Interfaces to rebuild
bweinstein@apple.com [Mon, 29 Mar 2010 22:19:55 +0000 (22:19 +0000)]
Build Fix: Touch WebKit.idl to force Interfaces to rebuild

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. Touch WebKit.idl to force rebuild.
sfalken@apple.com [Mon, 29 Mar 2010 22:15:59 +0000 (22:15 +0000)]
Build fix. Touch WebKit.idl to force rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore: Add an enable flag for the Widgets (http://www.w3.org/TR/widgets...
kenneth@webkit.org [Mon, 29 Mar 2010 21:44:44 +0000 (21:44 +0000)]
JavaScriptCore: Add an enable flag for the Widgets (w3.org/TR/widgets-reqs/)
and turn it on for Qt only.

Reviewed by Simon Fraser.

* wtf/Platform.h:

WebCore: When enabling Web Widgets, add support for the view-mode media
feature (http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

Test: fast/media/media-feature-wgt-view-mode.html

* css/CSSValueKeywords.in:
* css/MediaFeatureNames.h:
* css/MediaQueryEvaluator.cpp:
(WebCore::view_modeMediaFeatureEval):
* page/ChromeClient.h:
(WebCore::ChromeClient::isDocked):
(WebCore::ChromeClient::isFloating):
(WebCore::ChromeClient::isApplication):
(WebCore::ChromeClient::isFullscreen):

WebKit/qt: Add an internal Qt API for changing the view mode media feature
(http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

* Api/qwebpage.cpp:
(qt_wrt_setViewMode):
(QWebPagePrivate::priv):
* Api/qwebpage_p.h:
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::isDocked):
(WebCore::ChromeClientQt::isFloating):
(WebCore::ChromeClientQt::isApplication):
(WebCore::ChromeClientQt::isFullscreen):
* WebCoreSupport/ChromeClientQt.h:

WebKitTools: Add hooks to the Qt DRT for testing the view mode media feature.

Reviewed by Simon Fraser.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setViewModeMediaFeature):
* DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests: Add a test and an expected result for the Widgets 1.0: View Mode
Media Feature (http://www.w3.org/TR/widgets-vmmf/).

Reviewed by Simon Fraser.

Skip on all other platforms than Qt, that has Skipped files.

* fast/media/media-feature-wgt-view-mode.html: Added.
* fast/media/media-feature-wgt-view-mode-expected.txt: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 29 Mar 2010 20:51:44 +0000 (20:51 +0000)]
2010-03-29  Adam Barth  <abarth@webkit.org>

        Unreviewed.  Update expected results for unit tests.

        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 29 Mar 2010 20:49:23 +0000 (20:49 +0000)]
2010-03-29  Adam Barth  <abarth@webkit.org>

        Unreviewed.  I think Eric meant svn_revision.

        * Scripts/webkitpy/tool/commands/sheriffbot.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 29 Mar 2010 20:40:06 +0000 (20:40 +0000)]
2010-03-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        webkit-patch commit-queue should notice if it breaks builders (and roll out its own changes)
        https://bugs.webkit.org/show_bug.cgi?id=29311

        Now that we have sheriff-bot watching the tree, it can post
        rollout patches on behalf of the commit queue.

        * Scripts/webkitpy/common/checkout/commitinfo.py: add responsible_parties()
        * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: test responsible_parties()
        * Scripts/webkitpy/tool/commands/sheriffbot.py:
         - Break IRC logic out into _post_irc_warning for easier testing.
         - Add _post_rollout_patch for posting rollout patches to bugzilla.
        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
         - Test _rollout_reason
        * Scripts/webkitpy/tool/grammar.py:
         - Fix join_with_separators to not add Adam's "oxford comma" for two item lists.
        * Scripts/webkitpy/tool/grammar_unittest.py:
         - Test join_with_separators

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 29 Mar 2010 20:31:58 +0000 (20:31 +0000)]
2010-03-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Sheriffbot should actually run commands
        https://bugs.webkit.org/show_bug.cgi?id=36776

        Some minor changes to Sheriffbot:

        1) We should actually run commands (by giving control back to the
        command processing object.

        2) Use URLs instead of just numbers to represent SVN revisions (making
        it easier to folks in IRC ot followup).

        * Scripts/webkitpy/tool/bot/irc_command.py:
        * Scripts/webkitpy/tool/bot/queueengine.py:
        * Scripts/webkitpy/tool/commands/sheriffbot.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Kenneth Russell <kbr@google.com>
kbr@google.com [Mon, 29 Mar 2010 18:28:08 +0000 (18:28 +0000)]
2010-03-29  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Eliminate use of GL_BGRA in GraphicsContext3DSkia.cpp
        https://bugs.webkit.org/show_bug.cgi?id=36737

        No new tests; ran WebGL demos in Chromium on Windows to verify fix.

        * platform/graphics/skia/GraphicsContext3DSkia.cpp:
        (WebCore::GraphicsContext3D::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Dmitry Titov.
levin@chromium.org [Mon, 29 Mar 2010 18:20:38 +0000 (18:20 +0000)]
Rubber-stamped by Dmitry Titov.

Add chromium specific baselines for table tests added in r56641
and for runin tests added in r56655.

* platform/chromium-mac/fast/table/table-background-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-background-expected.png: Added.
* platform/chromium-mac/fast/table/table-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-background-expected.txt.
* platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
* platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt.
* platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
* platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt.
* platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
* platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt.
* platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
* platform/chromium-mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt.
* platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.png: Added.
* platform/chromium-mac/fast/table/table-cell-overrides-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-cell-overrides-row-background-expected.txt.
* platform/chromium-mac/fast/table/table-col-background-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-col-background-expected.png: Added.
* platform/chromium-mac/fast/table/table-col-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-background-expected.txt.
* platform/chromium-mac/fast/table/table-col-group-background-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-col-group-background-expected.png: Added.
* platform/chromium-mac/fast/table/table-col-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-background-expected.txt.
* platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.png: Added.
* platform/chromium-mac/fast/table/table-col-group-col-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-col-span-background-expected.txt.
* platform/chromium-mac/fast/table/table-col-group-span-background-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-col-group-span-background-expected.png: Added.
* platform/chromium-mac/fast/table/table-col-group-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-group-span-background-expected.txt.
* platform/chromium-mac/fast/table/table-col-span-background-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-col-span-background-expected.png: Added.
* platform/chromium-mac/fast/table/table-col-span-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-col-span-background-expected.txt.
* platform/chromium-mac/fast/table/table-row-background-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-row-background-expected.png: Added.
* platform/chromium-mac/fast/table/table-row-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-expected.txt.
* platform/chromium-mac/fast/table/table-row-background-left-50px-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-row-background-left-50px-expected.png: Added.
* platform/chromium-mac/fast/table/table-row-background-left-50px-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-left-50px-expected.txt.
* platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.png: Added.
* platform/chromium-mac/fast/table/table-row-background-right-100percent-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-right-100percent-expected.txt.
* platform/chromium-mac/fast/table/table-row-background-right-50px-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-row-background-right-50px-expected.png: Added.
* platform/chromium-mac/fast/table/table-row-background-right-50px-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-background-right-50px-expected.txt.
* platform/chromium-mac/fast/table/table-row-group-background-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-row-group-background-expected.png: Added.
* platform/chromium-mac/fast/table/table-row-group-background-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-group-background-expected.txt.
* platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.checksum: Added.
* platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.png: Added.
* platform/chromium-mac/fast/table/table-row-group-background-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/table/table-row-group-background-positioned-expected.txt.
* platform/chromium-win/fast/table/table-background-expected.checksum: Added.
* platform/chromium-win/fast/table/table-background-expected.png: Added.
* platform/chromium-win/fast/table/table-background-expected.txt: Added.
* platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
* platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
* platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Added.
* platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
* platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
* platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Added.
* platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
* platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
* platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Added.
* platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
* platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
* platform/chromium-win/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Added.
* platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
* platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.png: Added.
* platform/chromium-win/fast/table/table-cell-overrides-row-background-expected.txt: Added.
* platform/chromium-win/fast/table/table-col-background-expected.checksum: Added.
* platform/chromium-win/fast/table/table-col-background-expected.png: Added.
* platform/chromium-win/fast/table/table-col-background-expected.txt: Added.
* platform/chromium-win/fast/table/table-col-group-background-expected.checksum: Added.
* platform/chromium-win/fast/table/table-col-group-background-expected.png: Added.
* platform/chromium-win/fast/table/table-col-group-background-expected.txt: Added.
* platform/chromium-win/fast/table/table-col-group-col-span-background-expected.checksum: Added.
* platform/chromium-win/fast/table/table-col-group-col-span-background-expected.png: Added.
* platform/chromium-win/fast/table/table-col-group-col-span-background-expected.txt: Added.
* platform/chromium-win/fast/table/table-col-group-span-background-expected.checksum: Added.
* platform/chromium-win/fast/table/table-col-group-span-background-expected.png: Added.
* platform/chromium-win/fast/table/table-col-group-span-background-expected.txt: Added.
* platform/chromium-win/fast/table/table-col-span-background-expected.checksum: Added.
* platform/chromium-win/fast/table/table-col-span-background-expected.png: Added.
* platform/chromium-win/fast/table/table-col-span-background-expected.txt: Added.
* platform/chromium-win/fast/table/table-row-background-expected.checksum: Added.
* platform/chromium-win/fast/table/table-row-background-expected.png: Added.
* platform/chromium-win/fast/table/table-row-background-expected.txt: Added.
* platform/chromium-win/fast/table/table-row-background-left-50px-expected.checksum: Added.
* platform/chromium-win/fast/table/table-row-background-left-50px-expected.png: Added.
* platform/chromium-win/fast/table/table-row-background-left-50px-expected.txt: Added.
* platform/chromium-win/fast/table/table-row-background-right-100percent-expected.checksum: Added.
* platform/chromium-win/fast/table/table-row-background-right-100percent-expected.png: Added.
* platform/chromium-win/fast/table/table-row-background-right-100percent-expected.txt: Added.
* platform/chromium-win/fast/table/table-row-background-right-50px-expected.checksum: Added.
* platform/chromium-win/fast/table/table-row-background-right-50px-expected.png: Added.
* platform/chromium-win/fast/table/table-row-background-right-50px-expected.txt: Added.
* platform/chromium-win/fast/table/table-row-group-background-expected.checksum: Added.
* platform/chromium-win/fast/table/table-row-group-background-expected.png: Added.
* platform/chromium-win/fast/table/table-row-group-background-expected.txt: Added.
* platform/chromium-win/fast/table/table-row-group-background-positioned-expected.checksum: Added.
* platform/chromium-win/fast/table/table-row-group-background-positioned-expected.png: Added.
* platform/chromium-win/fast/table/table-row-group-background-positioned-expected.txt: Added.
* platform/chromium/fast/runin/generated2-expected.checksum: Added.
* platform/chromium/fast/runin/generated2-expected.png: Added.
* platform/chromium/fast/runin/generated3-expected.checksum: Added.
* platform/chromium/fast/runin/generated3-expected.png: Added.
* platform/chromium/fast/runin/generated4-expected.checksum: Added.
* platform/chromium/fast/runin/generated4-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Mon, 29 Mar 2010 18:10:34 +0000 (18:10 +0000)]
2010-03-29  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Darin Adler.

        Test for Ensuring Pseudo Class's are Respected on Dynamic Changes
        https://bugs.webkit.org/show_bug.cgi?id=36765

        This tests elements affected by a CSS pseudo class selector is updated
        after a dynamic DOM change.

        * fast/css/dynamic-pseudo-class-expected.txt: Added.
        * fast/css/dynamic-pseudo-class.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 29 Mar 2010 17:59:51 +0000 (17:59 +0000)]
2010-03-29  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Cover the Audits panel with tests
        https://bugs.webkit.org/show_bug.cgi?id=36613

        LayoutTests:
        * inspector/audits-panel-functional-expected.txt: Added.
        * inspector/audits-panel-functional.html: Added.
        * inspector/resources/audits-script1.js: Added.
        (foo1):
        * inspector/resources/audits-script2.js: Added.
        (foo2):
        * inspector/resources/audits-script3.js: Added.
        (foo3):

        WebCore:
        * English.lproj/localizedStrings.js:
        * inspector/front-end/AuditResultView.js:
        (WebInspector.AuditResultView):
        (WebInspector.AuditCategoryResultPane.ruleSorter):
        (WebInspector.AuditCategoryResultPane):
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.GzipRule.prototype.doRun):
        (WebInspector.AuditRules.CombineExternalResourcesRule.prototype.doRun):
        (WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun):
        (WebInspector.AuditRules.CssInHeadRule.prototype.doRun):
        (WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditRuleResult.linkifyDisplayName):
        (WebInspector.AuditRuleResult.resourceDomain):
        (WebInspector.AuditRuleResult.prototype.addURL):
        * inspector/front-end/inspector.js:
        (WebInspector.displayNameForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Kenneth Rohde Christiansen <kenneth@webkit.org>
eric@webkit.org [Mon, 29 Mar 2010 17:50:17 +0000 (17:50 +0000)]
2010-03-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Antti Koivisto.

        Use 'Mobile Safari' instead of 'Safari' on mobile Qt platforms.

        * Api/qwebpage.cpp:
        (QWebPage::userAgentForUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Fix build break introduced in r56724.
jocelyn.turcotte@nokia.com [Mon, 29 Mar 2010 17:39:48 +0000 (17:39 +0000)]
[Qt] Fix build break introduced in r56724.

Reviewed by nobody, build fix.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Mon, 29 Mar 2010 17:31:53 +0000 (17:31 +0000)]
2010-03-29  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        Corrected name of (u)int64_t compile time assert.
        https://bugs.webkit.org/show_bug.cgi?id=36739

        int64_t_is_four_bytes -> int64_t_is_eight_bytes

        * os-win32/stdint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Jochen Eisinger <jochen@chromium.org>
eric@webkit.org [Mon, 29 Mar 2010 17:13:52 +0000 (17:13 +0000)]
2010-03-29  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Darin Fisher.

        Pass a WebFrame to WebFrameClient::allowDatabase instead of a WebSecurityOrigin
        https://bugs.webkit.org/show_bug.cgi?id=36743

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::allowDatabase):
        * src/DatabaseObserver.cpp:
        (WebCore::DatabaseObserver::canEstablishDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 29 Mar 2010 17:11:06 +0000 (17:11 +0000)]
2010-03-29  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector should highlight when clicking a node's closing tag
        https://bugs.webkit.org/show_bug.cgi?id=16258

        LayoutTests:
        * inspector/elements-panel-limited-children.html:

        WebCore:
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype.set suppressRevealAndSelect):
        (WebInspector.ElementsTreeOutline.prototype.revealAndSelectNode):
        (WebInspector.ElementsTreeOutline.prototype._keyDown):
        (WebInspector.ElementsTreeOutline.prototype._onmousemove):
        (WebInspector.ElementsTreeElement):
        (WebInspector.ElementsTreeElement.prototype.showChild):
        (WebInspector.ElementsTreeElement.prototype.onpopulate):
        (WebInspector.ElementsTreeElement.prototype.updateChildren):
        (WebInspector.ElementsTreeElement.prototype.insertChildElement):
        (WebInspector.ElementsTreeElement.prototype.moveChild):
        (WebInspector.ElementsTreeElement.prototype._updateChildren):
        (WebInspector.ElementsTreeElement.prototype.onexpand):
        (WebInspector.ElementsTreeElement.prototype.oncollapse):
        (WebInspector.ElementsTreeElement.prototype.onselect):
        (WebInspector.ElementsTreeElement.prototype.ondblclick):
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Mon, 29 Mar 2010 16:56:02 +0000 (16:56 +0000)]
2010-03-29  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        https://bugs.webkit.org/show_bug.cgi?id=36315

        Remove obsolete Geolocation::m_currentPosition
        (follow up on https://bugs.webkit.org/show_bug.cgi?id=30676)

        * page/Geolocation.cpp:
        (WebCore::Geolocation::positionChanged):
        (WebCore::Geolocation::makeSuccessCallbacks):
        * page/Geolocation.h:
        * platform/chromium/GeolocationServiceChromium.cpp:
        (WebCore::GeolocationServiceChromium::GeolocationServiceChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Use the -l syntax for linking against JavaScriptCore on Windows.
jocelyn.turcotte@nokia.com [Mon, 29 Mar 2010 16:24:44 +0000 (16:24 +0000)]
[Qt] Use the -l syntax for linking against JavaScriptCore on Windows.
This allow qmake to extract dependencies correctly when generating VS
solutions.

Reviewed by Simon Hausmann.

* JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Do not generate INSTALLS for webkit when building inside Qt.
jocelyn.turcotte@nokia.com [Mon, 29 Mar 2010 16:24:15 +0000 (16:24 +0000)]
[Qt] Do not generate INSTALLS for webkit when building inside Qt.
Qt will do this for us.

Reviewed by Simon Hausmann.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=36703
antti.j.koivisto@nokia.com [Mon, 29 Mar 2010 16:05:34 +0000 (16:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=36703
Timer restart loop during page loading

Reviewed by Kenneth Rohde Christiansen.

Fix regression introduced in http://trac.webkit.org/changeset/54526.
Restarting the request timer unconditionally from the timer callback is a bad idea.
Instead, start the timer when a non-cached request completes.

* loader/loader.cpp:
(WebCore::Loader::Host::nonCacheRequestComplete):
(WebCore::Loader::Host::servePendingRequests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Mon, 29 Mar 2010 15:15:10 +0000 (15:15 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

Add support for iframe flattening
https://bugs.webkit.org/show_bug.cgi?id=36662

* platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] unit tests don't compile inside of Qt
hausmann@webkit.org [Mon, 29 Mar 2010 14:48:47 +0000 (14:48 +0000)]
[Qt] unit tests don't compile inside of Qt

Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=36756

* tests/tests.pri: Don't do the target substitution inside Qt and find the sources
through VPATH instead of relying on the location of the .pro file exclusively.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Mon, 29 Mar 2010 14:40:47 +0000 (14:40 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

Add support for iframe flattening
https://bugs.webkit.org/show_bug.cgi?id=36662

* platform/mac/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt: updated after r56718.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Shadowbuilds of WebCore with Qt on Symbian fails.
hausmann@webkit.org [Mon, 29 Mar 2010 14:03:56 +0000 (14:03 +0000)]
[Qt] Shadowbuilds of WebCore with Qt on Symbian fails.

Patch by Thomas Zander <t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=36749

Doing a 'make sis' expects the dll in the libdir, so place it
there. This fixes out-of-source building to always put the dll
in the expected dir.

* WebCore.pro: Fix for shadow builds inside Qt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Implement flattening for iframes.
kenneth@webkit.org [Mon, 29 Mar 2010 14:03:06 +0000 (14:03 +0000)]
WebCore: Implement flattening for iframes.

Reviewed by Antti Koivisto.

Refactoring of frameset flattening code to reuse it for
iframe flattening.

Tests: fast/frames/flattening/iframe-flattening-simple.html

* WebCore.base.exp:
* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::scheduleRelayout):
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setFrameFlatteningEnabled):
* page/Settings.h:
(WebCore::Settings::frameFlatteningEnabled):
* rendering/RenderFrame.cpp:
* rendering/RenderFrame.h:
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::flattenFrameSet):
* rendering/RenderFrameSet.h:
* rendering/RenderPart.cpp:
(WebCore::RenderPart::layoutWithFlattening):
* rendering/RenderPart.h:
* rendering/RenderPartObject.cpp:
(WebCore::RenderPartObject::flattenFrame):
(WebCore::RenderPartObject::calcHeight):
(WebCore::RenderPartObject::calcWidth):
(WebCore::RenderPartObject::layout):
* rendering/RenderPartObject.h:

WebKit/mac: Change method name due to it dealing with both flattening
of frame sets and inner frames.

Reviewed by Antti Koivisto.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences isFrameFlatteningEnabled]):
(-[WebPreferences setFrameFlatteningEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChangedNotification:]):

WebKit/qt: Change due to renaming of frame flattening setting.

Reviewed by Antti Koivisto.

* Api/qwebpage.cpp:
(qt_drt_setFrameFlatteningEnabled):
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
* symbian/eabi/QtWebKitu.def:

WebKit/win: Change method name due to it dealing with both flattening
of frame sets and inner frames.

Reviewed by Antti Koivisto.

* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::isFrameFlatteningEnabled):
(WebPreferences::setFrameFlatteningEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):

WebKitTools: Renaming of frame flattening LayoutTestController method
to setFrameFlatteningEnabled(bool)

Reviewed by Antti Koivisto.

* DumpRenderTree/LayoutTestController.cpp:
(setFrameFlatteningEnabledCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setFrameFlatteningEnabled):
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setFrameFlatteningEnabled):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::resetSettings):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setFrameFlatteningEnabled):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setFrameFlatteningEnabled):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setFrameFlatteningEnabled):

LayoutTests: Add new iframe flattening test and change existing frameset
flattening tests to use the new LayoutTestController method.

Reviewed by Antti Koivisto.

       * fast/frames/flattening/frameset-flattening-advanced.html:
* fast/frames/flattening/frameset-flattening-grid.html:
* fast/frames/flattening/frameset-flattening-simple.html:
* fast/frames/flattening/frameset-flattening-subframe-resize.html:
* fast/frames/flattening/frameset-flattening-subframesets.html:
* fast/frames/flattening/iframe-flattening-simple.html: Added.
* platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Platform specific expected file added for tests introduced in r56655,
ossy@webkit.org [Mon, 29 Mar 2010 12:23:31 +0000 (12:23 +0000)]
[Qt] Platform specific expected file added for tests introduced in r56655,
because they pass. Compared to png file and Mac expected file.

Reviewed by Kenneth Rohde Christiansen.

* platform/qt/fast/table/table-background-expected.checksum: Added.
* platform/qt/fast/table/table-background-expected.png: Added.
* platform/qt/fast/table/table-background-expected.txt: Added.
* platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.checksum: Added.
* platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.png: Added.
* platform/qt/fast/table/table-cell-border-draws-on-top-of-col-background-expected.txt: Added.
* platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.checksum: Added.
* platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.png: Added.
* platform/qt/fast/table/table-cell-border-draws-on-top-of-col-group-background-expected.txt: Added.
* platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.checksum: Added.
* platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.png: Added.
* platform/qt/fast/table/table-cell-border-draws-on-top-of-row-background-expected.txt: Added.
* platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.checksum: Added.
* platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.png: Added.
* platform/qt/fast/table/table-cell-border-draws-on-top-of-row-group-background-expected.txt: Added.
* platform/qt/fast/table/table-cell-overrides-row-background-expected.checksum: Added.
* platform/qt/fast/table/table-cell-overrides-row-background-expected.png: Added.
* platform/qt/fast/table/table-cell-overrides-row-background-expected.txt: Added.
* platform/qt/fast/table/table-col-background-expected.checksum: Added.
* platform/qt/fast/table/table-col-background-expected.png: Added.
* platform/qt/fast/table/table-col-background-expected.txt: Added.
* platform/qt/fast/table/table-col-group-background-expected.checksum: Added.
* platform/qt/fast/table/table-col-group-background-expected.png: Added.
* platform/qt/fast/table/table-col-group-background-expected.txt: Added.
* platform/qt/fast/table/table-col-group-col-span-background-expected.checksum: Added.
* platform/qt/fast/table/table-col-group-col-span-background-expected.png: Added.
* platform/qt/fast/table/table-col-group-col-span-background-expected.txt: Added.
* platform/qt/fast/table/table-col-group-span-background-expected.checksum: Added.
* platform/qt/fast/table/table-col-group-span-background-expected.png: Added.
* platform/qt/fast/table/table-col-group-span-background-expected.txt: Added.
* platform/qt/fast/table/table-col-span-background-expected.checksum: Added.
* platform/qt/fast/table/table-col-span-background-expected.png: Added.
* platform/qt/fast/table/table-col-span-background-expected.txt: Added.
* platform/qt/fast/table/table-row-background-expected.checksum: Added.
* platform/qt/fast/table/table-row-background-expected.png: Added.
* platform/qt/fast/table/table-row-background-expected.txt: Added.
* platform/qt/fast/table/table-row-background-left-50px-expected.checksum: Added.
* platform/qt/fast/table/table-row-background-left-50px-expected.png: Added.
* platform/qt/fast/table/table-row-background-left-50px-expected.txt: Added.
* platform/qt/fast/table/table-row-background-right-100percent-expected.checksum: Added.
* platform/qt/fast/table/table-row-background-right-100percent-expected.png: Added.
* platform/qt/fast/table/table-row-background-right-100percent-expected.txt: Added.
* platform/qt/fast/table/table-row-background-right-50px-expected.checksum: Added.
* platform/qt/fast/table/table-row-background-right-50px-expected.png: Added.
* platform/qt/fast/table/table-row-background-right-50px-expected.txt: Added.
* platform/qt/fast/table/table-row-group-background-expected.checksum: Added.
* platform/qt/fast/table/table-row-group-background-expected.png: Added.
* platform/qt/fast/table/table-row-group-background-expected.txt: Added.
* platform/qt/fast/table/table-row-group-background-positioned-expected.checksum: Added.
* platform/qt/fast/table/table-row-group-background-positioned-expected.png: Added.
* platform/qt/fast/table/table-row-group-background-positioned-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPage Cache does not work on Android with V8
benm@google.com [Mon, 29 Mar 2010 11:49:02 +0000 (11:49 +0000)]
Page Cache does not work on Android with V8
https://bugs.webkit.org/show_bug.cgi?id=36665

Patch by Andrei Popescu <andreip@google.com> on 2010-03-29
Reviewed by Adam Barth.

No new tests, existing tests should suffice, this is platform code.

This implementation simply saves the context and the global object
just before the frame is navigated to a new url. At restore time,
the global object is reattached to the context and the context
is attached to the window shell of the frame.

Note that isolated worlds are not taken into account in any way,
as Android does not use them.

* bindings/v8/ScriptCachedFrameData.cpp: Added.
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::domWindow):
(WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
(WebCore::ScriptCachedFrameData::clear):
* bindings/v8/ScriptCachedFrameData.h:
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::setContext):
* bindings/v8/V8DOMWindowShell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Make it possible to build using both Windows and Linux for Symbian
hausmann@webkit.org [Mon, 29 Mar 2010 11:14:27 +0000 (11:14 +0000)]
[Qt] Make it possible to build using both Windows and Linux for Symbian
https://bugs.webkit.org/show_bug.cgi?id=36748

Patch by Thomas Zander <t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

* WebCore.pro: don't assume Windows buildsystem is the only one
and exclude the windows-only setters from the linux builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=36745
hausmann@webkit.org [Mon, 29 Mar 2010 10:44:21 +0000 (10:44 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=36745

Patch by Thomas Zander <t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

[Qt] Fix def file builds with Qt 4.7.

Switched to using DEF_FILE, which is the official variable.

* WebCore.pro: Use DEF_FILE

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-24 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Mon, 29 Mar 2010 09:26:16 +0000 (09:26 +0000)]
2010-03-24  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        A few more steps towards IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=36546

        Add a callback interface to be used by all async methods.
        Add the first fragments of IDBDatabase.
        Clean up on IDBDatabaseError.
        Flesh out IndexedDatabase further.

        Not enough hooked up yet to test.  Soon though...

        * WebCore.gypi:
        * storage/IDBCallbacks.h: Added.
        (WebCore::IDBCallbacks::~IDBCallbacks):
        * storage/IDBDatabase.cpp: Added.
        * storage/IDBDatabase.h: Added.
        (WebCore::IDBDatabase::~IDBDatabase):
        * storage/IDBDatabaseError.h:
        (WebCore::IDBDatabaseError::create):
        (WebCore::IDBDatabaseError::message):
        (WebCore::IDBDatabaseError::IDBDatabaseError):
        * storage/IndexedDatabase.h:
        * storage/IndexedDatabaseImpl.cpp:
        (WebCore::IndexedDatabaseImpl::IndexedDatabaseImpl):
        (WebCore::IndexedDatabaseImpl::~IndexedDatabaseImpl):
        (WebCore::IndexedDatabaseImpl::open):
        * storage/IndexedDatabaseImpl.h:
        * storage/IndexedDatabaseRequest.cpp:
        (WebCore::IndexedDatabaseRequest::open):
2010-03-24  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        More IndexedDB plumbing
        https://bugs.webkit.org/show_bug.cgi?id=36546

        Plumbing work towards the goal of making IndexedDatabase::open work.

        * WebKit.gyp:
        * public/WebIDBCallbacks.h: Added.
        (WebKit::WebIDBCallbacks::~WebIDBCallbacks):
        * public/WebIDBDatabase.h: Added.
        (WebKit::WebIDBDatabase::~WebIDBDatabase):
        * public/WebIDBDatabaseError.h: Added.
        (WebKit::WebIDBDatabaseError::WebIDBDatabaseError):
        (WebKit::WebIDBDatabaseError::operator=):
        * public/WebIndexedDatabase.h:
        * public/WebKitClient.h:
        (WebKit::WebKitClient::indexedDatabase):
        * public/WebSerializedScriptValue.h:
        * src/IDBCallbacksProxy.h: Added.
        (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
        (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy):
        (WebCore::IDBCallbacksProxy::onSuccess):
        (WebCore::IDBCallbacksProxy::onError):
        * src/IDBDatabaseProxy.cpp: Added.
        (WebCore::IDBDatabaseProxy::create):
        (WebCore::IDBDatabaseProxy::IDBDatabaseProxy):
        (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy):
        * src/IDBDatabaseProxy.h: Added.
        * src/IndexedDatabaseProxy.cpp:
        (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy):
        (WebCore::IndexedDatabaseProxy::open):
        * src/IndexedDatabaseProxy.h:
        * src/WebIDBDatabaseError.cpp: Added.
        (WebKit::WebIDBDatabaseError::~WebIDBDatabaseError):
        (WebKit::WebIDBDatabaseError::WebIDBDatabaseError):
        (WebKit::WebIDBDatabaseError::assign):
        (WebKit::WebIDBDatabaseError::code):
        (WebKit::WebIDBDatabaseError::message):
        (WebKit::WebIDBDatabaseError::operator=):
        (WebKit::WebIDBDatabaseError::operator PassRefPtr<IDBDatabaseError>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=36742
hausmann@webkit.org [Mon, 29 Mar 2010 09:10:47 +0000 (09:10 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=36742

Patch by Thomas Zander <t.zander@nokia.com> on 2010-03-29
Reviewed by Simon Hausmann.

gcc for Symbian doesn't support gcc extensions like atomicity.h - disable

* wtf/Threading.h: also detect os symbian

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Mon, 29 Mar 2010 08:52:19 +0000 (08:52 +0000)]
2010-03-29  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Remove a possibility of confusion from Profiles panel Welcome screen
        by turning buttons into non-clickable glyphs. Also, span instructions
        alongside panel width.

        https://bugs.webkit.org/show_bug.cgi?id=34319

        * English.lproj/localizedStrings.js:
        * inspector/front-end/ProfileView.js:
        (WebInspector.CPUProfileType.prototype.get welcomeMessage):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._addWelcomeMessage):
        * inspector/front-end/inspector.css:
        (.panel-enabler-view.welcome .instructions):
        (.panel-enabler-view.welcome button.status-bar-item):
        * src/js/HeapProfilerPanel.js:
        (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-26 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 29 Mar 2010 07:41:01 +0000 (07:41 +0000)]
2010-03-26  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Seidel.

        [GStreamer] define static variables with DEFINE_STATIC_LOCAL macro
        https://bugs.webkit.org/show_bug.cgi?id=36653

        Defined the static variables using DEFINE_STATIC_GLOBAL.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-26 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 29 Mar 2010 07:37:33 +0000 (07:37 +0000)]
2010-03-26  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Seidel.

        [GStreamer] player header cleanups
        https://bugs.webkit.org/show_bug.cgi?id=36656

        Destructor made private and added missing
        mediaPlayerPrivateMuteChangedCallback declaration.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-29 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 29 Mar 2010 07:34:38 +0000 (07:34 +0000)]
2010-03-29  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Protect global object from being GC'ed if there are messages written to console from the iframe with that global object.

        Whent serializing objects in the injected script check that global object properties are still defined before using them as arguments. The may become undefined if owning frame navigated to a different domain.

        https://bugs.webkit.org/show_bug.cgi?id=36612

        Test: http/tests/inspector-enabled/console-log-before-frame-navigation.html

        * bindings/js/ScriptState.h:
        (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr):
        (WebCore::ScriptStateProtectedPtr::get):
        * bindings/v8/ScriptState.h:
        (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr):
        (WebCore::ScriptStateProtectedPtr::~ScriptStateProtectedPtr):
        (WebCore::ScriptStateProtectedPtr::get):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToFrontend):
        * inspector/ConsoleMessage.h:
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        (injectedScriptConstructor.):

2010-03-29  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: don't crash when there are messages in console from previous iframe content.

        https://bugs.webkit.org/show_bug.cgi?id=36612

        * http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt: Added.
        * http/tests/inspector-enabled/console-log-before-frame-navigation.html: Added.
        * http/tests/inspector-enabled/resources/console-log-before-frame-navigation.js: Added.
        (doit.callback):
        (doit):
        (receiveMessage):
        (frontend_dumpConsoleMessages):
        * http/tests/inspector-enabled/resources/console-log-frame-after-navigation.html: Added.
        * http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-26 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 29 Mar 2010 07:29:28 +0000 (07:29 +0000)]
2010-03-26  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        It should be possible to use GStreamer in addition to another media engine
        https://bugs.webkit.org/show_bug.cgi?id=36654

        Renamed gstreamer player and added a WTF_USE_GSTREAMER
        define. Made the MediaPlayer register the GStreamer backend only
        if it's enabled (true by default on WebKitGTK+).

        * GNUmakefile.am:
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::installedMediaEngines):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateMessageCallback):
        (WebCore::mediaPlayerPrivateSourceChangedCallback):
        (WebCore::mediaPlayerPrivateVolumeChangedCallback):
        (WebCore::mediaPlayerPrivateMuteChangedCallback):
        (WebCore::mediaPlayerPrivateRepaintCallback):
        (WebCore::MediaPlayerPrivateGStreamer::create):
        (WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine):
        (WebCore::MediaPlayerPrivateGStreamer::isAvailable):
        (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
        (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
        (WebCore::MediaPlayerPrivateGStreamer::load):
        (WebCore::MediaPlayerPrivateGStreamer::commitLoad):
        (WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
        (WebCore::MediaPlayerPrivateGStreamer::prepareToPlay):
        (WebCore::MediaPlayerPrivateGStreamer::play):
        (WebCore::MediaPlayerPrivateGStreamer::pause):
        (WebCore::MediaPlayerPrivateGStreamer::duration):
        (WebCore::MediaPlayerPrivateGStreamer::currentTime):
        (WebCore::MediaPlayerPrivateGStreamer::seek):
        (WebCore::MediaPlayerPrivateGStreamer::startEndPointTimerIfNeeded):
        (WebCore::MediaPlayerPrivateGStreamer::cancelSeek):
        (WebCore::MediaPlayerPrivateGStreamer::endPointTimerFired):
        (WebCore::MediaPlayerPrivateGStreamer::paused):
        (WebCore::MediaPlayerPrivateGStreamer::seeking):
        (WebCore::MediaPlayerPrivateGStreamer::naturalSize):
        (WebCore::MediaPlayerPrivateGStreamer::hasVideo):
        (WebCore::MediaPlayerPrivateGStreamer::hasAudio):
        (WebCore::MediaPlayerPrivateGStreamer::setVolume):
        (WebCore::MediaPlayerPrivateGStreamer::volumeChangedTimerFired):
        (WebCore::MediaPlayerPrivateGStreamer::volumeChanged):
        (WebCore::MediaPlayerPrivateGStreamer::setRate):
        (WebCore::MediaPlayerPrivateGStreamer::networkState):
        (WebCore::MediaPlayerPrivateGStreamer::readyState):
        (WebCore::MediaPlayerPrivateGStreamer::buffered):
        (WebCore::MediaPlayerPrivateGStreamer::processBufferingStats):
        (WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
        (WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable):
        (WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded):
        (WebCore::MediaPlayerPrivateGStreamer::bytesLoaded):
        (WebCore::MediaPlayerPrivateGStreamer::totalBytes):
        (WebCore::MediaPlayerPrivateGStreamer::cancelLoad):
        (WebCore::MediaPlayerPrivateGStreamer::updateStates):
        (WebCore::MediaPlayerPrivateGStreamer::mediaLocationChanged):
        (WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):
        (WebCore::MediaPlayerPrivateGStreamer::loadStateChanged):
        (WebCore::MediaPlayerPrivateGStreamer::sizeChanged):
        (WebCore::MediaPlayerPrivateGStreamer::timeChanged):
        (WebCore::MediaPlayerPrivateGStreamer::didEnd):
        (WebCore::MediaPlayerPrivateGStreamer::durationChanged):
        (WebCore::MediaPlayerPrivateGStreamer::supportsMuting):
        (WebCore::MediaPlayerPrivateGStreamer::setMuted):
        (WebCore::MediaPlayerPrivateGStreamer::muteChangedTimerFired):
        (WebCore::MediaPlayerPrivateGStreamer::muteChanged):
        (WebCore::MediaPlayerPrivateGStreamer::loadingFailed):
        (WebCore::MediaPlayerPrivateGStreamer::setSize):
        (WebCore::MediaPlayerPrivateGStreamer::setVisible):
        (WebCore::MediaPlayerPrivateGStreamer::repaint):
        (WebCore::MediaPlayerPrivateGStreamer::paint):
        (WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes):
        (WebCore::MediaPlayerPrivateGStreamer::supportsType):
        (WebCore::MediaPlayerPrivateGStreamer::hasSingleSecurityOrigin):
        (WebCore::MediaPlayerPrivateGStreamer::supportsFullscreen):
        (WebCore::MediaPlayerPrivateGStreamer::setPreload):
        (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Build fix. Removed extraneous includes of KeyboardCodesWin.h and KeyboardCode...
ap@apple.com [Mon, 29 Mar 2010 04:11:11 +0000 (04:11 +0000)]
    Build fix. Removed extraneous includes of KeyboardCodesWin.h and KeyboardCodesPosix.h -
        these no longer exist, but they weren't needed even before reshuffling KeyboardCodes headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Build fix. Include WindowsKeyboardCodes.h instead of KeyboardCodes.h.
ap@apple.com [Mon, 29 Mar 2010 03:53:37 +0000 (03:53 +0000)]
    Build fix. Include WindowsKeyboardCodes.h instead of KeyboardCodes.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Sam Weinig.
ap@apple.com [Mon, 29 Mar 2010 03:41:13 +0000 (03:41 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=36733
        Use a common header for Windows virtual key codes on all platforms

        No change in functionality, so no new tests.

        * platform/WindowsKeyboardCodes.h: Added. Define VK_* key codes as macros, matching Windows.

        * platform/KeyboardCodes.h: Removed.
        * platform/android/KeyboardCodes.h: Removed.
        * platform/chromium/KeyboardCodesPosix.h: Removed.
        * platform/chromium/KeyboardCodesWin.h: Removed.
        * platform/haiku/KeyboardCodes.h: Removed.
        * platform/wx/KeyboardCodes.h: Removed.
        Removed platform specific attempts to do the same thing. In fact, platform/KeyboardCodes.h
        was supposed to be cross-platform, but it didn't have a sufficiently descriptive name, and
        its name was the same as platform-specific versions, so I chose a new one.

        * platform/chromium/KeyboardCodes.h: Copied from WebCore/platform/chromium/KeyboardCodesWin.h.
        Chromium redefines Windows constants to different names; keeping the header doing that to
        avoid breaking Chromium code.

        * GNUmakefile.am:
        * WebCore.gypi:
        Replaced KeyboardCodes.h with WindowsKeyboardCodes.h.

        * WebCore.xcodeproj/project.pbxproj:
        * platform/cocoa/KeyEventCocoa.mm:
        (WebCore::windowsKeyCodeForKeyCode):
        (WebCore::windowsKeyCodeForCharCode):
        Mac used to hardcode the key codes; changed to use VK_* macros.

        * config.h: Removed a hack to include KeyboardCodes.h, it shouldn't be necessary any more.

        * platform/android/KeyEventAndroid.cpp:
        * platform/brew/PlatformKeyboardEventBrew.cpp:
        * platform/efl/PlatformKeyboardEventEfl.cpp:
        * platform/gtk/KeyEventGtk.cpp:
        * platform/haiku/PlatformKeyboardEventHaiku.cpp:
        * platform/qt/PlatformKeyboardEventQt.cpp:
        * platform/wx/KeyboardEventWx.cpp:
        Changed to include WindowsKeyboardCodes.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 28 Mar 2010 22:48:24 +0000 (22:48 +0000)]
2010-03-28  Gustavo Noronha Silva  <gns@gnome.org>

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        Skip tests that need more load notifications than we provide in
        our DRT currently.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 28 Mar 2010 22:36:22 +0000 (22:36 +0000)]
2010-03-28  Gustavo Noronha Silva  <gns@gnome.org>

        Skipping new tests.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sun, 28 Mar 2010 22:29:19 +0000 (22:29 +0000)]
2010-03-28  Gustavo Noronha Silva  <gns@gnome.org>

        No review, rolling out r56679.
        http://trac.webkit.org/changeset/56679
        https://bugs.webkit.org/show_bug.cgi?id=36454

        Lots of tests broken.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (createWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sun, 28 Mar 2010 21:41:50 +0000 (21:41 +0000)]
2010-03-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Remove the definition of WTF_CHANGES guards from the build system
        https://bugs.webkit.org/show_bug.cgi?id=31670

        * JavaScriptCore.pro: Remove the definition of WTF_CHANGES
        as it is already defined in config.h
2010-03-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Remove the definition of WTF_CHANGES guards from the build system
        https://bugs.webkit.org/show_bug.cgi?id=31670

        No new tests as there is no new functionality.

        * WebCore.pri: Remove the definition of WTF_CHANGES
        as it is already defined in config.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
cjerdonek@webkit.org [Sun, 28 Mar 2010 19:19:43 +0000 (19:19 +0000)]
Unreviewed.

Fixed typo in deprecated_logging_unittest.py, which is masking
sys.stderr while running test-webkitpy.

See also-- https://bugs.webkit.org/show_bug.cgi?id=36725#c3

* Scripts/webkitpy/common/system/deprecated_logging_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up the Xcode project a bit.
weinig@apple.com [Sun, 28 Mar 2010 17:47:43 +0000 (17:47 +0000)]
Clean up the Xcode project a bit.

Reviewed by Dan Bernstein.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 28 Mar 2010 17:41:20 +0000 (17:41 +0000)]
2010-03-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Toggling style properties on/off does not always work.

        https://bugs.webkit.org/show_bug.cgi?id=36720

        * inspector/InspectorController.cpp:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::toggleStyleEnabled):
        (WebCore::InspectorDOMAgent::buildObjectForStyle):
        (WebCore::InspectorDOMAgent::buildArrayForDisabledStyleProperties):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/DOMAgent.js:
        (WebInspector.CSSStyleDeclaration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 28 Mar 2010 17:32:04 +0000 (17:32 +0000)]
2010-03-28  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: resource links should navigate to resource panel enabler when resource tracking is off.

        https://bugs.webkit.org/show_bug.cgi?id=36722

        * English.lproj/localizedStrings.js:
        * inspector/front-end/inspector.js:
        (WebInspector.documentMouseOver):
        (WebInspector.documentClick.followLink):
        (WebInspector.documentClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 28 Mar 2010 16:59:20 +0000 (16:59 +0000)]
2010-03-28  Dirk Schulze  <krit@webkit.org>

        Unreviewed test update for Win.

        Out of bounds read in SVG feColorMatrix filter
        https://bugs.webkit.org/show_bug.cgi?id=32714

        May mixed up the win bot with the win-chromium bot.

        * platform/win/svg/filters/feColorMatrix-values-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 28 Mar 2010 16:30:53 +0000 (16:30 +0000)]
2010-03-28  Dirk Schulze  <krit@webkit.org>

        Unreviewed build-fix for chromium linux.

        SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
        https://bugs.webkit.org/show_bug.cgi?id=36185

        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::invalidateResources):

2010-03-28  Dirk Schulze  <krit@webkit.org>

        Unreviewed test update.

        SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
        https://bugs.webkit.org/show_bug.cgi?id=36185

        Marker results update for Qt port.

        * platform/qt/svg/custom/marker-opacity-expected.txt:
        * platform/qt/svg/custom/marker-referencePoint-expected.txt:
        * platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 28 Mar 2010 16:01:18 +0000 (16:01 +0000)]
2010-03-28  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
        https://bugs.webkit.org/show_bug.cgi?id=36185

        This moves SVGResourceMarker to RenderersSVGResourceMarker. This follows other
        SVG resources like masker and clipper and makes DRT results more readable and
        adds additonal informations.
        Some marker specific code also moved out from RenderSVGViewportContainer to
        RenderersSVGResourceMarker.

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::calculateMarkerBoundsIfNeeded):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::destroy):
        * rendering/RenderSVGResource.h:
        (WebCore::):
        * rendering/RenderSVGResourceMarker.cpp: Added.
        (WebCore::RenderSVGResourceMarker::RenderSVGResourceMarker):
        (WebCore::RenderSVGResourceMarker::~RenderSVGResourceMarker):
        (WebCore::RenderSVGResourceMarker::layout):
        (WebCore::RenderSVGResourceMarker::addClient):
        (WebCore::RenderSVGResourceMarker::invalidateClients):
        (WebCore::RenderSVGResourceMarker::invalidateClient):
        (WebCore::RenderSVGResourceMarker::applyViewportClip):
        (WebCore::RenderSVGResourceMarker::markerBoundaries):
        (WebCore::RenderSVGResourceMarker::localToParentTransform):
        (WebCore::RenderSVGResourceMarker::referencePoint):
        (WebCore::RenderSVGResourceMarker::angle):
        (WebCore::RenderSVGResourceMarker::markerTransformation):
        (WebCore::RenderSVGResourceMarker::draw):
        (WebCore::RenderSVGResourceMarker::markerContentTransformation):
        (WebCore::RenderSVGResourceMarker::viewportTransform):
        (WebCore::RenderSVGResourceMarker::calcViewport):
        * rendering/RenderSVGResourceMarker.h: Added.
        (WebCore::RenderSVGResourceMarker::renderName):
        (WebCore::RenderSVGResourceMarker::applyResource):
        (WebCore::RenderSVGResourceMarker::resourceBoundingBox):
        (WebCore::RenderSVGResourceMarker::markerUnits):
        (WebCore::RenderSVGResourceMarker::resourceType):
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::calcViewport):
        (WebCore::RenderSVGViewportContainer::viewportTransform):
        * rendering/RenderSVGViewportContainer.h:
        * rendering/SVGMarkerData.h:
        (WebCore::SVGMarkerData::SVGMarkerData):
        (WebCore::SVGMarkerData::marker):
        (WebCore::SVGMarkerData::updateTypeAndMarker):
        * rendering/SVGMarkerLayoutInfo.cpp:
        (WebCore::processStartAndMidMarkers):
        (WebCore::SVGMarkerLayoutInfo::calculateBoundaries):
        (WebCore::SVGMarkerLayoutInfo::addLayoutedMarker):
        * rendering/SVGMarkerLayoutInfo.h:
        (WebCore::MarkerLayout::MarkerLayout):
        (WebCore::SVGMarkerLayoutInfo::midMarker):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::deregisterFromResources):
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::operator<<):
        (WebCore::writeSVGResource):
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::svgAttributeChanged):
        (WebCore::SVGMarkerElement::childrenChanged):
        (WebCore::SVGMarkerElement::setOrientToAuto):
        (WebCore::SVGMarkerElement::setOrientToAngle):
        (WebCore::SVGMarkerElement::createRenderer):
        * svg/SVGMarkerElement.h:
        (WebCore::SVGMarkerElement::):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::invalidateResources):
        * svg/graphics/SVGResource.h:
        (WebCore::):
        (WebCore::SVGResource::isFilter):
        * svg/graphics/SVGResourceMarker.cpp: Removed.
        * svg/graphics/SVGResourceMarker.h: Removed.

2010-03-28  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGResourceMarker needs to be moved to RenderersSVGResourceMarker
        https://bugs.webkit.org/show_bug.cgi?id=36185

        DRT results changed after moving SVGResourceMarker and need updates.

        * platform/mac/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
        * platform/mac/svg/custom/invalid-css-expected.txt:
        * platform/mac/svg/custom/js-late-marker-and-object-creation-expected.txt:
        * platform/mac/svg/custom/js-late-marker-creation-expected.txt:
        * platform/mac/svg/custom/marker-changes-expected.txt:
        * platform/mac/svg/custom/marker-child-changes-expected.txt:
        * platform/mac/svg/custom/marker-default-width-height-expected.txt:
        * platform/mac/svg/custom/marker-opacity-expected.txt:
        * platform/mac/svg/custom/marker-overflow-clip-expected.txt:
        * platform/mac/svg/custom/marker-referencePoint-expected.txt:
        * platform/mac/svg/custom/marker-strokeWidth-changes-expected.txt:
        * platform/mac/svg/custom/marker-viewBox-changes-expected.txt:
        * platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
        * platform/mac/svg/custom/shapes-supporting-markers-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRenamed check-webkit-style's --debug flag to --verbose to be more
cjerdonek@webkit.org [Sun, 28 Mar 2010 15:23:41 +0000 (15:23 +0000)]
Renamed check-webkit-style's --debug flag to --verbose to be more
in line with other WebKit scripts.  Also renamed the current
--verbose flag to --min-confidence to allow the --debug rename.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=36521

We also renamed the internal "verbose" variables to "confidence" or
"min_confidence," as appropriate, to avoid confusion with the
--verbose flag, and because the new names are more accurate.

* Scripts/check-webkit-style:
  - Renamed is_debug to is_verbose.

* Scripts/webkitpy/style/checker.py:
  - Renamed _DEFAULT_VERBOSITY to _DEFAULT_CONFIDENCE.
  - Renamed "verbosity" parameters to "min_confidence" throughout.
  - Renamed configure_logging()'s is_debug parameter to is_verbose.

* Scripts/webkitpy/style/checker_unittest.py:
  - Updated the unit tests as necessary.

* Scripts/webkitpy/style/error_handlers.py:
  - Updated the call to StyleCheckerConfiguration.write_style_error().

* Scripts/webkitpy/style/error_handlers_unittest.py:
  - Updated the unit tests as necessary.

* Scripts/webkitpy/style/optparser.py:
  - Updated the usage string with the new flag names.
  - Renamed the verbosity parameter to min_confidence throughout.
  - Renamed the is_debug parameter to is_verbose throughout.

* Scripts/webkitpy/style/optparser_unittest.py:
  - Updated the unit tests as necessary.

* Scripts/webkitpy/style/processors/cpp.py:
  - Renamed the verbosity parameter to min_confidence throughout.

* Scripts/webkitpy/style/processors/cpp_unittest.py:
  - Updated the unit tests as necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
cjerdonek@webkit.org [Sun, 28 Mar 2010 15:05:23 +0000 (15:05 +0000)]
Unreviewed.

Added back a line that accidentally got deleted in r56690.

* Scripts/check-webkit-style:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd to check-webkit-style support for checking directories.
cjerdonek@webkit.org [Sun, 28 Mar 2010 14:51:51 +0000 (14:51 +0000)]
Add to check-webkit-style support for checking directories.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35234

* Scripts/check-webkit-style:
  - Replaced the call to check_file() with a call to check_paths().

* Scripts/webkitpy/style/checker.py:
  - In the StyleChecker class:
    - Added a check_paths() method that accepts a list of paths
      to files and directories.
    - Added a _check_directory() method that checks the files
      in a directory.

* Scripts/webkitpy/style/checker_unittest.py:
  - Added a StyleCheckerCheckPathsTest to unit-test the new
    check_paths() method.

* Scripts/webkitpy/style/optparser.py:
  - Updated the usage string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Kent Hansen <kent.hansen@nokia.com>
eric@webkit.org [Sun, 28 Mar 2010 10:43:05 +0000 (10:43 +0000)]
2010-03-28  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Add API for reporting additional memory cost of JavaScript objects
        https://bugs.webkit.org/show_bug.cgi?id=36650

        * qt/api/qscriptengine.cpp:
        (QScriptEngine::reportAdditionalMemoryCost):
        * qt/api/qscriptengine.h:
        * qt/api/qscriptengine_p.h:
        (QScriptEnginePrivate::reportAdditionalMemoryCost):
        * qt/tests/qscriptengine/tst_qscriptengine.cpp:
        (tst_QScriptEngine::reportAdditionalMemoryCost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sun, 28 Mar 2010 10:33:23 +0000 (10:33 +0000)]
2010-03-28  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Consolidate Tree Hierarchy Attribute HTML Generation
        https://bugs.webkit.org/show_bug.cgi?id=36719

          Consolidates the generation of Element Tree Hierarchy attribute code
          generation to a single function: _attributeHTML.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._addNewAttribute): convert to use attributeHTML.
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.regenerateStyledAttribute): convert to use attributeHTML.
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
        (WebInspector.ElementsTreeElement.prototype._attributeHTML): a single point for generating the html for attributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sun, 28 Mar 2010 10:33:10 +0000 (10:33 +0000)]
2010-03-28  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Edit Tag Names
        https://bugs.webkit.org/show_bug.cgi?id=36481

          Ensure blacklisting happens by checking it in _startEditingTagName
          instead of all the possible entry points.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): don't check blacklist here.
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName): check blacklist here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Sun, 28 Mar 2010 10:03:50 +0000 (10:03 +0000)]
2010-03-28  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Simon Hausmann.

        QScriptEngine API was enriched by globalObject() method
        which give an access to the global object.

        [Qt] QScriptEngine doesn't give an access to global object
        https://bugs.webkit.org/show_bug.cgi?id=36603

        * qt/api/qscriptengine.cpp:
        (QScriptEngine::globalObject):
        * qt/api/qscriptengine.h:
        * qt/api/qscriptengine_p.cpp:
        (QScriptEnginePrivate::globalObject):
        * qt/api/qscriptengine_p.h:
        * qt/tests/qscriptengine/tst_qscriptengine.cpp:
        (tst_QScriptEngine::globalObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-28 Kim Grönholm <kim.gronholm@nomovok.com>
eric@webkit.org [Sun, 28 Mar 2010 09:46:06 +0000 (09:46 +0000)]
2010-03-28  Kim Grönholm  <kim.gronholm@nomovok.com>

        Reviewed by Simon Hausmann.

        [Qt] GraphicsLayer: Timing functions don't work with transitions
        https://bugs.webkit.org/show_bug.cgi?id=36589

        If the animation value doesn't have timing function set, we need to
        use the animation's timing function.

        Fixed also a bug in passing the duration to solveCubicBezierFunction.
        The duration was divided two times by 1000 and meanwhile casted to int.
        It needs to be kept as double and divided by 1000 only once.

        Test case: https://bugs.webkit.org/attachment.cgi?id=51619

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::applyTimingFunction):
        (WebCore::AnimationQt:::AnimationQtBase):
        (WebCore::AnimationQt::updateCurrentTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-27 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sun, 28 Mar 2010 08:49:52 +0000 (08:49 +0000)]
2010-03-27  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Edit Tag Names
        https://bugs.webkit.org/show_bug.cgi?id=36481

        Allow tabbing back and forth between the tag name and element
        attributes when editing. Also, fixed a number of minor issues with
        editing attributes and tabbing.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName): find the tag name if it wasn't provided.
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): fix tabbing issues, enable tab to tag name.
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.regenerateStyledAttribute): cleanup styles when tabbing.
        * inspector/front-end/inspector.css: do not display <br>s while editing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-27 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sun, 28 Mar 2010 08:49:39 +0000 (08:49 +0000)]
2010-03-27  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Edit Tag Names
        https://bugs.webkit.org/show_bug.cgi?id=36481

        Allow editing an Element's Tag Name by double clicking
        on the tag name in the Element's Tree Hierarchy.

          The usual asynchronous InspectorBackend, InspectorDOMAgent, InspectorFrontend flow.

        * inspector/InspectorBackend.cpp: moved DOM manipulation to InspectorDOMAgent
        (WebCore::InspectorBackend::removeNode):
        (WebCore::InspectorBackend::changeTagName):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::removeNode):
        (WebCore::InspectorDOMAgent::changeTagName):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::didChangeTagName):
        * inspector/InspectorFrontend.h:

        * inspector/front-end/DOMAgent.js:

          Handle the UI for editing an Element's tag name.

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._startEditingFromEvent): allow editing from double click.
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName.keyupListener): update the closing tag
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName.editingComitted): remove extra listener and commit
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName.editingCancelled): remove extra listener and cancel
        (WebInspector.ElementsTreeElement.prototype._startEditingTagName):
        (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.cancel):
        (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded):
        (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.editTagNameCallback):
        (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
        (WebInspector.ElementsTreeElement.prototype._distinctClosingTagElement): get the closing tag for an opening tag
        (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo): wrap the tagName in span.webkit-html-tag-name

          Miscellaneous updates.

        * inspector/front-end/treeoutline.js: fixed a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChanged check-webkit-style to convert paths to paths relative to
cjerdonek@webkit.org [Sun, 28 Mar 2010 07:54:00 +0000 (07:54 +0000)]
Changed check-webkit-style to convert paths to paths relative to
the checkout root when invoking check-webkit-style with path
arguments.  Also added warning messages where appropriate.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=35498

Converting paths to paths relative to the checkout root ensures
that style checking will behave as expected (since path-specific
rules assume input paths are relative to a source root).

* Scripts/check-webkit-style:
  - Added debug logging of whether the current directory was found
    to be in a WebKit checkout.
  - Added the found_checkout parameter to the call to parser.parse().
  - Renamed the files variable to paths.
  - Added a call to change_directory() prior to checking style.

* Scripts/webkitpy/style/checker.py:
  - For StyleChecker.check_file():
    - Updated the docstring.
    - Added two log messages.

* Scripts/webkitpy/style/checker_unittest.py:
  - Updated a call to parser.parse() with the found_checkout parameter.

* Scripts/webkitpy/style/main.py: Added.
  - Added a new file so the code in this patch could be unit-tested,
    as opposed to adding new code to check-webkit-style.
  - Added the method _rel_path() as a substitute for os.path.relpath(),
    which is available only in Python 2.6.
  - Added the method change_directory(), which contains most of the
    new functionality in this patch.

* Scripts/webkitpy/style/main_unittest.py: Added.
  - Added RelPathTest to test main._rel_path().
  - Added ChangeDirectoryTest to test main.change_directory().

* Scripts/webkitpy/style/optparser.py:
  - Updated check-webkit-style's usage string.
  - For the ArgumentParser.parse() method:
    - Added a found_checkout parameter.
    - Renamed filenames to paths.
    - Added logic so that an error is raised if no paths are passed
      if found_checkout is False.

* Scripts/webkitpy/style/optparser_unittest.py:
  - Updated the ArgumentParser.parse() unit tests to include
    coverage for the new found_checkout parameter.

* Scripts/webkitpy/style/unittests.py:
  - Added an import statement for main_unittest.

* Scripts/webkitpy/style_references.py:
  - Renamed SimpleScm to WebKitCheckout.
  - Added a detect_checkout() function to allow returning None
    instead of a WebKitCheckout instance if no checkout is found.
  - Renamed checkout_root to root_path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-27 Sergio Villar Senin <svillar@igalia.com>
eric@webkit.org [Sun, 28 Mar 2010 06:09:26 +0000 (06:09 +0000)]
2010-03-27  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Eric Seidel.

        Removed 5 http/history tests from Skipped file

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * platform/gtk/Skipped:
2010-03-27  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Eric Seidel.

        FrameLoader emits onload-event when handling
        dispatchDidHandleOnloadEvents

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents):
        implemented, now it emits onload-event signal
        * webkit/webkitwebview.cpp: added onload-event signal
2010-03-27  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Eric Seidel.

        Print didHandleOnloadEventsForFrame in the callback of
        onload-event signal comming from frame loader

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewOnloadEvent):
        (createWebView): added connection to signal::onload-event and
        signal callback

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-27 Sergio Villar Senin <svillar@igalia.com>
eric@webkit.org [Sun, 28 Mar 2010 05:51:57 +0000 (05:51 +0000)]
2010-03-27  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Eric Seidel.

        Print didCommitLoadForFrame in the callback of signal::load-committed

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewLoadCommitted):
        (createWebView): added connection to sinal::load-committed and
        signal callback

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-27 Sergio Villar Senin <svillar@igalia.com>
eric@webkit.org [Sun, 28 Mar 2010 05:34:30 +0000 (05:34 +0000)]
2010-03-27  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Eric Seidel.

        Print didStartProvisionalLoadForFrame in the callback of
        notify::load-status property change notification

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webInspectorCloseWindow):
        (webInspectorInspectWebView):
        (createWebView): added connection to notify::load-status and
        signal callback

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-27 Kenneth Russell <kbr@google.com>
kbr@google.com [Sun, 28 Mar 2010 04:16:50 +0000 (04:16 +0000)]
2010-03-27  Kenneth Russell  <kbr@google.com>

        Reviewed by Darin Fisher.

        Use WebKitClient to instantiate WebGraphicsContext3D
        https://bugs.webkit.org/show_bug.cgi?id=36669

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3DInternal::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-27 Chris Jerdonek <cjerdonek@webkit.org>
eric@webkit.org [Sun, 28 Mar 2010 02:50:39 +0000 (02:50 +0000)]
2010-03-27  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Adam Barth.

        In webkitpy/, deleted the /unittests.py files since test-webkitpy
        now auto-detects all *_unittest.py files.

        https://bugs.webkit.org/show_bug.cgi?id=36712

        * Scripts/webkitpy/common/net/irc/unittests.py: Removed.
        * Scripts/webkitpy/common/system/unittests.py: Removed.
        * Scripts/webkitpy/common/thread/unittests.py: Removed.
        * Scripts/webkitpy/common/unittests.py: Removed.
        * Scripts/webkitpy/python24/unittests.py: Removed.
        * Scripts/webkitpy/style/unittests.py: Removed.
        * Scripts/webkitpy/tool/unittests.py: Removed.
        * Scripts/webkitpy/unittests.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-27 Dmitry Gorbik <socket.h@gmail.com>
eric@webkit.org [Sun, 28 Mar 2010 02:32:49 +0000 (02:32 +0000)]
2010-03-27  Dmitry Gorbik  <socket.h@gmail.com>

        Reviewed by Pavel Feldman.

        Fix the regression caused by r28078: a global variable
        definition masks a local one in an inspector console
        https://bugs.webkit.org/show_bug.cgi?id=32442

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMore updated results for r56673.
mitz@apple.com [Sun, 28 Mar 2010 01:56:05 +0000 (01:56 +0000)]
More updated results for r56673.

* platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-27 Sergio Villar Senin <svillar@igalia.com>
eric@webkit.org [Sun, 28 Mar 2010 01:07:29 +0000 (01:07 +0000)]
2010-03-27  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Eric Seidel.

        Add a CR after printing didFinishDocumentLoadForFrame

        [GTK] Improve reporting of frame loader callbacks in DRT
        https://bugs.webkit.org/show_bug.cgi?id=36454

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewLoadFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: <rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image...
mitz@apple.com [Sun, 28 Mar 2010 00:59:12 +0000 (00:59 +0000)]
WebCore: <rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
https://bugs.webkit.org/show_bug.cgi?id=36700

Reviewed by Darin Adler.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::createColor): Reverted to returning an RGB color value rather than an
identifier for the transparent color.

LayoutTests: Updated results and one test for
<rdar://problem/7801598> REGRESSION (r56182): iWeb shadow drawn around image rectangle, not around opaque part of the image
https://bugs.webkit.org/show_bug.cgi?id=36700

Reviewed by Darin Adler.

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/invalid-import-rule-insertion.html:
* http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-and-css-extension-expected.txt:
* http/tests/mime/standard-mode-does-not-load-stylesheet-with-text-plain-expected.txt:
* http/tests/security/cross-origin-css-expected.txt:
* http/tests/security/cross-origin-css-in-xml-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Adam Barth.
cjerdonek@webkit.org [Sat, 27 Mar 2010 23:29:26 +0000 (23:29 +0000)]
Rubber-stamped by Adam Barth.

Fixed the name of a unit test file in webkitpy.

* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py.
* Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-26 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Sat, 27 Mar 2010 22:56:20 +0000 (22:56 +0000)]
2010-03-26  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Adam Barth.

        The test-webkitpy script now automatically detects all unit-test
        files in webkitpy/.  This lets us eliminate the need to have and
        maintain all of the unittests.py files.

        https://bugs.webkit.org/show_bug.cgi?id=36591

        * Scripts/test-webkitpy:
          - Replaced the "from webkitpy.unittests import *" with a call
            to webkitpy.test.main.Tester().run_tests().

        * Scripts/webkitpy/test/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
          - Required file for the new webkitpy/test/ directory.

        * Scripts/webkitpy/test/main.py: Added.
          - Added a Tester class that contains the following methods:
            - _find_unittest_files() to detect all the unit-test files.
            - _modules_from_paths() to convert the paths to the unit-test
              files to fully-qualified module names.
            - run_tests() which calls the above two methods and then passes
              the module names to Python's unittest module.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-26 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 27 Mar 2010 21:42:23 +0000 (21:42 +0000)]
2010-03-26  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Converge Inspector ids to be long, not ints
        https://bugs.webkit.org/show_bug.cgi?id=36706

          Part 1: Converge on `long` for callIds, nodeIds, and other Ids.

        * inspector/InspectorController.cpp:
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        * inspector/InspectorFrontend.cpp:
        * inspector/InspectorFrontend.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the newly-added test to not trip over a bug that causes some subsequent tests...
mrowe@apple.com [Sat, 27 Mar 2010 19:51:44 +0000 (19:51 +0000)]
Fix the newly-added test to not trip over a bug that causes some subsequent tests to fail.

Rubber-stamped by Dan Bernstein.

* fast/dom/script-tests/setPrimitiveValue-exceptions.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-03-27 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 27 Mar 2010 19:31:21 +0000 (19:31 +0000)]
2010-03-27  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Fraser.

        [Qt/Win] Add support to unix and windows NS plugin for executing scripts on setWindow.

        https://bugs.webkit.org/show_bug.cgi?id=36701

        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_new_instance): Add onSetWindow.
        (webkit_test_plugin_destroy_instance): Add onSetWindow.
        (webkit_test_plugin_set_window): Add onSetWindow.
        * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
        (NPP_New): Add onSetWindow.
        (NPP_Destroy): Add onSetWindow.
        (NPP_SetWindow): Add onSetWindow.

2010-03-27  Robert Hogan  <robert@webkit.org>

        Unreviewed skip failing test.

        [Qt] Skip test added in r56646. Tracked by https://bugs.webkit.org/show_bug.cgi?id=36702

        https://bugs.webkit.org/show_bug.cgi?id=36701

        * platform/qt/Skipped: Add plugins/reentrant-update-widget-positions.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56668 268f45cc-cd09-0410-ab3c-d52691b4dbfc