WebKit-https.git
6 years agoBuilding EFL Webkit again with mediastream enabled
commit-queue@webkit.org [Thu, 28 Nov 2013 19:33:27 +0000 (19:33 +0000)]
Building EFL Webkit again with mediastream enabled
https://bugs.webkit.org/show_bug.cgi?id=124930

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderTableSection Blink merge asserting
ossy@webkit.org [Thu, 28 Nov 2013 19:03:10 +0000 (19:03 +0000)]
RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase GTK results after r159848.

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

* platform/mac/accessibility/table-detection-expected.txt:
* platform/mac/fast/forms/input-value-expected.txt:
* platform/mac/fast/table/[...]:
* platform/mac/tables/[...]:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderTableSection Blink merge asserting
ossy@webkit.org [Thu, 28 Nov 2013 18:54:03 +0000 (18:54 +0000)]
RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase GTK results after r159848.

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

* platform/gtk/accessibility/table-detection-expected.txt:
* platform/gtk/fast/forms/input-value-expected.png:
* platform/gtk/fast/forms/input-value-expected.txt:
* platform/gtk/fast/table/[...]:
* platform/gtk/tables/[...]:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Update vcxproj.filters, since LineInfo.h and LineLayoutState.h have been moved...
zoltan@webkit.org [Thu, 28 Nov 2013 17:43:06 +0000 (17:43 +0000)]
[Win] Update vcxproj.filters, since LineInfo.h and LineLayoutState.h have been moved to rendering/line
https://bugs.webkit.org/show_bug.cgi?id=124959

Reviewed by Brent Fulgham.

Update WebCore.vcxproj.filters, since LineInfo.h (r155628) and LineLayoutState.h (158121) have been moved to rendering/line.

No new tests, no behavior change.

* WebCore.vcxproj/WebCore.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderTableSection Blink merge asserting
ossy@webkit.org [Thu, 28 Nov 2013 17:40:59 +0000 (17:40 +0000)]
RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Source/WebCore:

Use border spacing at the end of all sections.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

Skipped tests enabled.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r159839.
commit-queue@webkit.org [Thu, 28 Nov 2013 16:55:28 +0000 (16:55 +0000)]
Unreviewed, rolling out r159839.
http://trac.webkit.org/changeset/159839
https://bugs.webkit.org/show_bug.cgi?id=124974

run-webkit-tests doesn't generate pretty diff (Requested by
Ossy on #webkit).

* Scripts/webkitpy/common/prettypatch.py:
(PrettyPatch.__init__):
(PrettyPatch.pretty_diff):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.create_text_diff_and_write_result):
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results):
* Scripts/webkitpy/port/base.py:
(Port.__init__):
(Port.pretty_patch_available):
(Port.check_pretty_patch):
(Port.variable):
(Port.variable.pretty_patch_text):
* Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Thu, 28 Nov 2013 16:35:28 +0000 (16:35 +0000)]
Unreviewed EFL gardening

* platform/efl/TestExpectations: Added test expectations for failing tests.
* platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Added.
* platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuildfix after r159824 for GCC 4.6
commit-queue@webkit.org [Thu, 28 Nov 2013 16:20:01 +0000 (16:20 +0000)]
Buildfix after r159824 for GCC 4.6
https://bugs.webkit.org/show_bug.cgi?id=124968

Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Added explicit "friend class", because GCC 4.6 doesn't support extended friend declaration (c++11)

* Shared/APIObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNo need to skip css variables tests as they were removed.
antti@apple.com [Thu, 28 Nov 2013 16:19:30 +0000 (16:19 +0000)]
No need to skip css variables tests as they were removed.

* platform/mac/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
gns@gnome.org [Thu, 28 Nov 2013 16:02:34 +0000 (16:02 +0000)]
REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
https://bugs.webkit.org/show_bug.cgi?id=124954

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-11-28
Reviewed by Carlos Garcia Campos.

* tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
* webkit/webkitwebview.cpp:
(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove feature: CSS variables
antti@apple.com [Thu, 28 Nov 2013 15:46:53 +0000 (15:46 +0000)]
Remove feature: CSS variables
https://bugs.webkit.org/show_bug.cgi?id=114119

.:

Reviewed by Andreas Kling.

* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Reviewed by Andreas Kling.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Reviewed by Andreas Kling.

The feature is unmaintained and it is getting in the way of refactoring. Code quality is not up to
WebKit standards either.

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.list.am:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSBasicShapes.cpp:
* css/CSSBasicShapes.h:
* css/CSSCalculationValue.cpp:
(WebCore::unitCategory):
(WebCore::hasDoubleValue):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::determineCategory):
(WebCore::CSSCalcBinaryOperation::primitiveType):
* css/CSSCalculationValue.h:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::validCalculationUnit):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::realLex):
* css/CSSParser.h:
* css/CSSParserMode.h:
* css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
* css/CSSParserValues.h:
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customCSSText):
(WebCore::CSSPrimitiveValue::equals):
* css/CSSPrimitiveValue.h:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
* css/CSSProperty.cpp:
* css/CSSProperty.h:
(WebCore::CSSProperty::CSSProperty):
* css/CSSReflectValue.cpp:
* css/CSSReflectValue.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::setCssText):
* css/CSSValueList.cpp:
* css/CSSValueList.h:
* css/CSSVariableValue.h: Removed.
* css/Pair.h:
* css/Rect.h:
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::PropertyReference::cssName):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyProperty):
* css/StyleResolver.h:
* css/WebKitCSSTransformValue.cpp:
* css/WebKitCSSTransformValue.h:
(WebCore::WebKitCSSTransformValue::equals):
* css/makeprop.pl:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
* rendering/style/StyleVariableData.h: Removed.
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

Source/WebKit/mac:

Reviewed by Andreas Kling.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Andreas Kling.

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

Reviewed by Andreas Kling.

* wtf/FeatureDefines.h:

Tools:

Reviewed by Andreas Kling.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Reviewed by Andreas Kling.

* fast/css/variables: Removed.
* fast/css/variables/border-width-expected.html: Removed.
* fast/css/variables/border-width.html: Removed.
* fast/css/variables/build-supports-variables-expected.txt: Removed.
* fast/css/variables/build-supports-variables.html: Removed.
* fast/css/variables/calc-expected.html: Removed.
* fast/css/variables/calc-inside-calc-expected.html: Removed.
* fast/css/variables/calc-inside-calc.html: Removed.
* fast/css/variables/calc-invalid-value-expected.html: Removed.
* fast/css/variables/calc-invalid-value.html: Removed.
* fast/css/variables/calc-invalid-variable-expected.html: Removed.
* fast/css/variables/calc-invalid-variable.html: Removed.
* fast/css/variables/calc-negated-variable-expected.html: Removed.
* fast/css/variables/calc-negated-variable.html: Removed.
* fast/css/variables/calc-vw-crash-expected.txt: Removed.
* fast/css/variables/calc-vw-crash.html: Removed.
* fast/css/variables/calc.html: Removed.
* fast/css/variables/case-sensitive-expected.html: Removed.
* fast/css/variables/case-sensitive.html: Removed.
* fast/css/variables/colors-test-expected.html: Removed.
* fast/css/variables/colors-test.html: Removed.
* fast/css/variables/complex-cycle-expected.html: Removed.
* fast/css/variables/complex-cycle.html: Removed.
* fast/css/variables/computed-style-expected.html: Removed.
* fast/css/variables/computed-style.html: Removed.
* fast/css/variables/deferred-image-load-from-variable-expected.txt: Removed.
* fast/css/variables/deferred-image-load-from-variable.html: Removed.
* fast/css/variables/inherited-values-expected.html: Removed.
* fast/css/variables/inherited-values.html: Removed.
* fast/css/variables/inline-styles-expected.html: Removed.
* fast/css/variables/inline-styles.html: Removed.
* fast/css/variables/invalid-font-reference-expected.txt: Removed.
* fast/css/variables/invalid-font-reference.html: Removed.
* fast/css/variables/invalid-shorthand-expected.html: Removed.
* fast/css/variables/invalid-shorthand.html: Removed.
* fast/css/variables/invalid-value-list-crash-expected.txt: Removed.
* fast/css/variables/invalid-value-list-crash.html: Removed.
* fast/css/variables/invalid-variable-value-expected.html: Removed.
* fast/css/variables/invalid-variable-value.html: Removed.
* fast/css/variables/multi-level-cycle-expected.html: Removed.
* fast/css/variables/multi-level-cycle.html: Removed.
* fast/css/variables/redefinition-expected.html: Removed.
* fast/css/variables/redefinition.html: Removed.
* fast/css/variables/root-background-size-expected.html: Removed.
* fast/css/variables/root-background-size.html: Removed.
* fast/css/variables/shorthand-expected.html: Removed.
* fast/css/variables/shorthand.html: Removed.
* fast/css/variables/simple-cycle-expected.html: Removed.
* fast/css/variables/simple-cycle.html: Removed.
* fast/css/variables/transform-test-expected.html: Removed.
* fast/css/variables/transform-test.html: Removed.
* fast/css/variables/undefined-expected.html: Removed.
* fast/css/variables/undefined.html: Removed.
* fast/css/variables/use-before-defined-expected.html: Removed.
* fast/css/variables/use-before-defined.html: Removed.
* fast/css/variables/var-filter-expected.txt: Removed.
* fast/css/variables/var-filter.html: Removed.
* fast/css/variables/var-inside-box-reflect-expected.html: Removed.
* fast/css/variables/var-inside-box-reflect.html: Removed.
* fast/css/variables/var-inside-pair-expected.html: Removed.
* fast/css/variables/var-inside-pair.html: Removed.
* fast/css/variables/var-inside-quad-expected.html: Removed.
* fast/css/variables/var-inside-quad.html: Removed.
* fast/css/variables/var-inside-shape-expected.html: Removed.
* fast/css/variables/var-inside-shape.html: Removed.
* fast/css/variables/var-inside-shorthand-expected.html: Removed.
* fast/css/variables/var-inside-shorthand.html: Removed.
* fast/css/variables/variable-chain-expected.html: Removed.
* fast/css/variables/variable-chain.html: Removed.
* fast/css/variables/variable-unparseable-value-crash-expected.txt: Removed.
* fast/css/variables/variable-unparseable-value-crash.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Layout tests need to be rebaselined.
commit-queue@webkit.org [Thu, 28 Nov 2013 15:27:04 +0000 (15:27 +0000)]
[EFL] Layout tests need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124879

Unreviewed, EFL rebaseline.

EFL tests need to be rebaselined after r159747

Patch by Jongwoo Choi <jw0330.choi@samsung.com> on 2013-11-28

* platform/efl/fast/table/011-expected.txt:
* platform/efl/fast/table/border-collapsing/004-expected.txt:
* platform/efl/fast/table/tableInsideCaption-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdating RTCPeerConnectionHandlerMock after r159769
commit-queue@webkit.org [Thu, 28 Nov 2013 15:15:49 +0000 (15:15 +0000)]
Updating RTCPeerConnectionHandlerMock after r159769
https://bugs.webkit.org/show_bug.cgi?id=124947

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Philippe Normand.

Adding its create function back, in order to run RTCPeerConnection LayoutTests.

No new tests needed.

* platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::create):
* platform/mock/RTCPeerConnectionHandlerMock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove PrettyPatch related code to prettypatch.py
commit-queue@webkit.org [Thu, 28 Nov 2013 15:14:42 +0000 (15:14 +0000)]
Move PrettyPatch related code to prettypatch.py
https://bugs.webkit.org/show_bug.cgi?id=124937

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-28
Reviewed by Ryosuke Niwa.

This code seems to have a better place here than in Port, since PrettyPatch already knows
pretty_patch_path, and this also unifies the usage of PrettyPatch

* Scripts/webkitpy/common/prettypatch.py:
(PrettyPatch.__init__):
(PrettyPatch.pretty_diff):
(PrettyPatch):
(PrettyPatch.pretty_patch_available):
(PrettyPatch.check_pretty_patch):
(PrettyPatch.pretty_patch_text):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.create_text_diff_and_write_result):
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results):
* Scripts/webkitpy/port/base.py:
(Port.__init__):
(Port.wdiff_available):
(Port.check_image_diff):
(Port.wdiff_text):
* Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCheckout should own the scm object in Host
commit-queue@webkit.org [Thu, 28 Nov 2013 13:46:26 +0000 (13:46 +0000)]
Checkout should own the scm object in Host
https://bugs.webkit.org/show_bug.cgi?id=124943

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-28
Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/common/host.py:
(Host.__init__):
(Host.initialize_scm):
(Host.scm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Support custom types for drag and drop data
gns@gnome.org [Thu, 28 Nov 2013 12:40:59 +0000 (12:40 +0000)]
[GTK] Support custom types for drag and drop data
https://bugs.webkit.org/show_bug.cgi?id=124659

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-11-27
Reviewed by Martin Robinson.

Source/WebCore:

Covered by fast/events/drag-customData.html.

* platform/gtk/DataObjectGtk.cpp:
(WebCore::DataObjectGtk::unknownTypes): returns a hash map with all custom types set.
(WebCore::DataObjectGtk::clearAllExceptFilenames): clear custom types.
* platform/gtk/DataObjectGtk.h:
(WebCore::DataObjectGtk::hasUnknownTypeData): returns whether custom types are set.
(WebCore::DataObjectGtk::unknownTypeData): returns the data for a custom type.
(WebCore::DataObjectGtk::setUnknownTypeData): sets the data for a custom type.
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeString): handle unknown types as custom.
(WebCore::Pasteboard::writePasteboard): ditto.
(WebCore::Pasteboard::hasData): also check for custom types.
(WebCore::Pasteboard::types): also obtain the list of custom types.
(WebCore::Pasteboard::readString): handle unknown types as custom.
* platform/gtk/PasteboardHelper.cpp:
(WebCore::initGdkAtoms): new unknown atom.
(WebCore::PasteboardHelper::PasteboardHelper): add custom type to the list of targets.
(WebCore::PasteboardHelper::fillSelectionData): turns any custom types' data into a GVariant, which
is in turn serialized to a single string for GtkSelectionData to hold.
(WebCore::PasteboardHelper::targetListForDataObject): add custom data to the target list if any is
set.
(WebCore::PasteboardHelper::fillDataObjectFromDropData): retrieve the custom types and their data
from the serialized GVariant string held by GtkSelectionData.
(WebCore::PasteboardHelper::dropAtomsForContext): handle custom types.

Source/WebKit2:

* Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::encodeDataObject): encode the unknown types data.
(CoreIPC::decodeDataObject): decode the unknown types data.

LayoutTests:

* platform/gtk/TestExpectations: remove failure expectation for test that now passes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTypo fix after r159834 to fix 32 bit builds.
ossy@webkit.org [Thu, 28 Nov 2013 10:28:04 +0000 (10:28 +0000)]
Typo fix after r159834 to fix 32 bit builds.

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a bunch of early exits and local optimizations to the x86 assembler.
nrotem@apple.com [Thu, 28 Nov 2013 07:40:03 +0000 (07:40 +0000)]
Add a bunch of early exits and local optimizations to the x86 assembler.
https://bugs.webkit.org/show_bug.cgi?id=124904

Reviewed by Filip Pizlo.

* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::add32):
(JSC::MacroAssemblerX86::add64):
(JSC::MacroAssemblerX86::or32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::or32):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::or32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::or64):
(JSC::MacroAssemblerX86_64::xor64):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoInfer one-time scopes
fpizlo@apple.com [Thu, 28 Nov 2013 07:10:10 +0000 (07:10 +0000)]
Infer one-time scopes
https://bugs.webkit.org/show_bug.cgi?id=124812

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This detects JSActivations that are created only once. The JSActivation pointer is then
baked into the machine code.

This takes advantage of the one-time scope inference to reduce the number of
indirections needed to get to a closure variable in case where the scope is only
allocated once. This isn't really a speed-up since in the common case the total number
of instruction bytes needed to load the scope from the stack is about equal to the
number of instruction bytes needed to materialize the absolute address of a scoped
variable. But, this is a necessary prerequisite to
https://bugs.webkit.org/show_bug.cgi?id=124630, so it's probably a good idea anyway.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
* bytecode/Instruction.h:
* bytecode/Opcode.h:
(JSC::padOpcodeName):
* bytecode/Watchpoint.h:
(JSC::WatchpointSet::notifyWrite):
(JSC::InlineWatchpointSet::notifyWrite):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolveScope):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::tryGetRegisters):
* dfg/DFGGraph.h:
* dfg/DFGNode.h:
(JSC::DFG::Node::varNumber):
(JSC::DFG::Node::hasSymbolTable):
(JSC::DFG::Node::symbolTable):
* dfg/DFGNodeType.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGWatchpointCollectionPhase.cpp:
(JSC::DFG::WatchpointCollectionPhase::handle):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetClosureRegisters):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/JSActivation.h:
(JSC::JSActivation::create):
* runtime/JSScope.cpp:
(JSC::abstractAccess):
(JSC::JSScope::abstractResolve):
* runtime/JSScope.h:
(JSC::ResolveOp::ResolveOp):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::registers):
* runtime/SymbolTable.cpp:
(JSC::SymbolTable::SymbolTable):
* runtime/SymbolTable.h:

LayoutTests:

Reviewed by Oliver Hunt.

* js/regress/infer-one-time-closure-expected.txt: Added.
* js/regress/infer-one-time-closure-ten-vars-expected.txt: Added.
* js/regress/infer-one-time-closure-ten-vars.html: Added.
* js/regress/infer-one-time-closure-two-vars-expected.txt: Added.
* js/regress/infer-one-time-closure-two-vars.html: Added.
* js/regress/infer-one-time-closure.html: Added.
* js/regress/infer-one-time-deep-closure-expected.txt: Added.
* js/regress/infer-one-time-deep-closure.html: Added.
* js/regress/script-tests/infer-one-time-closure-ten-vars.js: Added.
* js/regress/script-tests/infer-one-time-closure-two-vars.js: Added.
* js/regress/script-tests/infer-one-time-closure.js: Added.
* js/regress/script-tests/infer-one-time-deep-closure.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGive the PageClient a chance to handle geolocation permission requests if the UIClien...
weinig@apple.com [Thu, 28 Nov 2013 04:34:08 +0000 (04:34 +0000)]
Give the PageClient a chance to handle geolocation permission requests if the UIClient doesn't handle it
https://bugs.webkit.org/show_bug.cgi?id=124955

Reviewed by Dan Bernstein.

Use the new PageClient function to remove the need for WKContentView to take over the WKPageUIClient.

* UIProcess/API/ios/PageClientImplIOS.h:
* UIProcess/API/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):
* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):
(-[WKContentView _commonInitWithProcessGroup:browsingContextGroup:]):
* UIProcess/API/ios/WKContentViewInternal.h:
* UIProcess/PageClient.h:
(WebKit::PageClient::decidePolicyForGeolocationPermissionRequest):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the iOS build.
weinig@apple.com [Thu, 28 Nov 2013 03:23:48 +0000 (03:23 +0000)]
Fix the iOS build.

* UIProcess/API/ios/WKGeolocationProviderIOS.mm:
* UIProcess/API/ios/WKGeolocationProviderIOSObjCSecurityOrigin.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the iOS build.
weinig@apple.com [Thu, 28 Nov 2013 03:14:43 +0000 (03:14 +0000)]
Fix the iOS build.

../WebKit:

* WebKit.xcodeproj/project.pbxproj:

../WebKit/mac:

* WebView/WebAllowDenyPolicyListener.h: Added.
* WebView/WebUIDelegatePrivate.h:
Move the WebAllowDenyPolicyListener protocol to its own file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd accessors for the WKProcessGroup and WKBrowsingContextGroup on the WKBrowsingCont...
weinig@apple.com [Thu, 28 Nov 2013 02:25:46 +0000 (02:25 +0000)]
Add accessors for the WKProcessGroup and WKBrowsingContextGroup on the WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=124953

Reviewed by Dan Bernstein.

* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController processGroup]):
(-[WKBrowsingContextController browsingContextGroup]):
Add accessors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake WKProcessGroup work with WKObject wrapping
weinig@apple.com [Thu, 28 Nov 2013 02:03:41 +0000 (02:03 +0000)]
Make WKProcessGroup work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=124952

Reviewed by Dan Bernstein.

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
Add support for WKProcessGroup.

* UIProcess/API/mac/WKProcessGroup.mm:
(-[WKProcessGroup initWithInjectedBundleURL:]):
(-[WKProcessGroup dealloc]):
(-[WKProcessGroup API::]):
(-[WKProcessGroup _contextRef]):
(-[WKProcessGroup _geolocationProvider]):
Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline

* UIProcess/API/mac/WKProcessGroupInternal.h: Added.
(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::create):
(WebKit::WebContext::WebContext):
* UIProcess/WebContext.h:
Make the WebContext constructor public (for use with Object::constructInWrapper) and remove unused ProcessModel parameter.

* WebKit2.xcodeproj/project.pbxproj:
Add new file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] The remote inspector does not show the base page.
commit-queue@webkit.org [Thu, 28 Nov 2013 01:20:54 +0000 (01:20 +0000)]
[EFL] The remote inspector does not show the base page.
https://bugs.webkit.org/show_bug.cgi?id=124942

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-27
Reviewed by Gyuyoung Kim.

On EFL the remote inspector does not show the base page about
which pages are available for debug. This should be fixed for
further inspector development.

* Source/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAllow the QuickTime plug-in to be replaced by script in an isolated word
eric.carlson@apple.com [Thu, 28 Nov 2013 01:05:35 +0000 (01:05 +0000)]
Allow the QuickTime plug-in to be replaced by script in an isolated word
https://bugs.webkit.org/show_bug.cgi?id=124900

Reviewed by Dean Jackson.

Source/WebCore:

Test: plugins/quicktime-plugin-replacement.html

* CMakeLists.txt: Add new Modules path.
* DerivedSources.make: Add new files.
* GNUmakefile.am: Add new Modules path.
* GNUmakefile.list.am: Add new header.
* WebCore.vcxproj/WebCore.vcxproj: Add new header.
* WebCore.vcxproj/WebCoreCommon.props: Add new Modules path.
* WebCore.xcodeproj/project.pbxproj: Add new files.

* Modules/plugins: Added.
* Modules/plugins/PluginReplacement.h: Added. Defines the interface for a plug-in replacement.

Create a replacement for the QuickTime plug-in.
* Modules/plugins/QuickTimePluginReplacement.cpp: Added.
* Modules/plugins/QuickTimePluginReplacement.css: Added.
* Modules/plugins/QuickTimePluginReplacement.h: Added.
* Modules/plugins/QuickTimePluginReplacement.idl: Added.
* Modules/plugins/QuickTimePluginReplacement.js: Added.

Allow plug-in replacement to be enabled at runtime.
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setPluginReplacementEnabled):
(WebCore::RuntimeEnabledFeatures::pluginReplacementEnabled):

* bindings/js/JSDOMBinding.h:
(WebCore::toJS): Add toJS(... const String& ...).

* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginScriptObject): Give a plug-in replacement a first shot at defining the
    script interface.

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget): Call base class requestObject.

* html/HTMLMediaElement.cpp:
(HTMLMediaElement::fileSize): New, passthrough to media engine.
* html/HTMLMediaElement.h:

* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget): Call base class requestObject.

Moved some logic that was previously used only for creating a plug-in snapshot to the base
class so it can be shared by a plug-in replacement.
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::HTMLPlugInElement): Initialize timer used to swap renderers.
(WebCore::HTMLPlugInElement::createRenderer): Allow plug-in replacement to create the renderer.
(WebCore::HTMLPlugInElement::swapRendererTimerFired): Create a shadow root.
(WebCore::HTMLPlugInElement::setDisplayState): Set the new state, prime the swap renderer
    timer if necessary.
(WebCore::HTMLPlugInElement::didAddUserAgentShadowRoot): Tell the plug-in replacement to
    install itself in the new shadow DOM.
(WebCore::registeredPluginReplacements): Return vector of all registered plug-in replacements.
(WebCore::registerPluginReplacement): Add a plug-in replacement.
(WebCore::pluginReplacementForType): Find a plug-in replacement for a MIME type.
(WebCore::HTMLPlugInElement::requestObject): If there is a plug-in replacement for the MIME type,
    create it and set the display state.
(WebCore::HTMLPlugInElement::scriptObjectForPluginReplacement): Return the script object for
    the current plug-in replacement, if any.
* html/HTMLPlugInElement.h:

Move some plug-in snapshot code into the base class.
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): No need to initialize timer.
(WebCore::HTMLPlugInImageElement::setDisplayState): Call base class.
(WebCore::HTMLPlugInImageElement::createRenderer): Ditto.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Ditto.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Remove unnecessary class name.
(WebCore::HTMLPlugInImageElement::requestObject): New.
* html/HTMLPlugInImageElement.h:

* html/HTMLVideoElement.h: Make createRenderer public so the QuickTime plug-in replacement can
    call it.

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::fileSize): New.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::extraMemoryCost): totalBytes returns an unsigned long long.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::fileSize):

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes): Return an unsigned long long.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::totalBytes): Ditto.

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Backup the plug-in replacement runtime setting.
(WebCore::InternalSettings::Backup::restoreTo): Restore it.
(WebCore::InternalSettings::setPluginReplacementEnabled): Set it.
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

LayoutTests:

* platform/efl/TestExpectations: Skip the new test.
* platform/gtk/TestExpectations: Ditto.
* platform/wincairo/TestExpectations: Ditto.
* plugins/quicktime-plugin-replacement.html: Added.
* plugins/quicktime-plugin-replacement-expected.txt: Added.
* plugins/resources/orange.mov: Replace movie compressed with ancient (and deprecated)
    animated gif codec with one compressed with H.264 codec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFinally fix some obvious Bartlett bugs
fpizlo@apple.com [Thu, 28 Nov 2013 00:22:43 +0000 (00:22 +0000)]
Finally fix some obvious Bartlett bugs
https://bugs.webkit.org/show_bug.cgi?id=124951

Reviewed by Mark Hahnenberg.

Sanitize the stack (i.e. zero parts of it known to be dead) at three key points:

- GC.

- At beginning of OSR entry.

- Just as we finish preparing OSR entry. This clears those slots on the stack that
  could have been live in baseline but that are known to be dead in DFG.

This is as much as a 2x speed-up on splay if you run it in certain modes, and run it
for a long enough interval. It appears to fix all instances of the dreaded exponential
heap growth that splay gets into when some stale pointer stays around.

This doesn't have much of an effect on real-world programs. This bug has only ever
manifested in splay and for that reason we thus far opted against fixing it. But splay
is, for what it's worth, the premiere GC stress test in JavaScript - so making sure we
can run it without pathologies - even when you tweak its configuration - is probably
fairly important.

* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGOSREntry.h:
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* interpreter/JSStack.cpp:
(JSC::JSStack::JSStack):
(JSC::JSStack::sanitizeStack):
* interpreter/JSStack.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDo bytecode validation as part of testing
fpizlo@apple.com [Wed, 27 Nov 2013 23:15:48 +0000 (23:15 +0000)]
Do bytecode validation as part of testing
https://bugs.webkit.org/show_bug.cgi?id=124913

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Also fix some small bugs in the bytecode liveness analysis that I found by doing
this validation thingy.

* bytecode/BytecodeLivenessAnalysis.cpp:
(JSC::isValidRegisterForLiveness):
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::validate):
(JSC::CodeBlock::beginValidationDidFail):
(JSC::CodeBlock::endValidationDidFail):
* bytecode/CodeBlock.h:
* runtime/Executable.cpp:
(JSC::ScriptExecutable::prepareForExecutionImpl):
* runtime/Options.h:

Source/WTF:

Reviewed by Oliver Hunt.

* GNUmakefile.list.am:
* WTF.vcxproj/WTF.vcxproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/FastBitVector.cpp: Added.
(WTF::FastBitVector::dump):
* wtf/FastBitVector.h:
(WTF::FastBitVector::resize):
(WTF::FastBitVector::bitCount):
(WTF::FastBitVector::arrayLength):

Tools:

Reviewed by Oliver Hunt.

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake WKBrowsingContextGroup work with WKObject wrapping
weinig@apple.com [Wed, 27 Nov 2013 22:48:32 +0000 (22:48 +0000)]
Make WKBrowsingContextGroup work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=124948

Reviewed by Dan Bernstein.

- Adds mechanism to use the inline data wrapping mechanism when the Objective-C wrapper is created
  by the caller (rather than by Object::newObject).
- Adopts the mechanism for WKBrowsingContextGroup.

* Shared/APIObject.h:
(API::Object::constructInWrapper):
Add a helper which does a forwarding placement-new into the API::Object of the passed in wrapper, after which it sets up m_wrapper.

(API::TypedObject::operator new):
Add a operator new to for placement-new. Also make TypedObject friends with Object so that constructInWrapper can call this.

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
Add support for WKBrowsingContextGroup.

* UIProcess/API/mac/WKBrowsingContextGroup.mm:
(-[WKBrowsingContextGroup API::]):
(-[WKBrowsingContextGroup dealloc]):
(-[WKBrowsingContextGroup initWithIdentifier:]):
(-[WKBrowsingContextGroup allowsJavaScript]):
(-[WKBrowsingContextGroup setAllowsJavaScript:]):
(-[WKBrowsingContextGroup allowsJavaScriptMarkup]):
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]):
(-[WKBrowsingContextGroup allowsPlugIns]):
(-[WKBrowsingContextGroup setAllowsPlugIns:]):
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]):
(-[WKBrowsingContextGroup removeAllUserStyleSheets]):
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]):
(-[WKBrowsingContextGroup removeAllUserScripts]):
(-[WKBrowsingContextGroup _pageGroupRef]):
Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline (modeled on WKBackForwardList).

* UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Added.
(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol.

* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::create):
(WebKit::WebPageGroup::WebPageGroup):
* UIProcess/WebPageGroup.h:
Make the WebPageGroup constructor public (for use with Object::constructInWrapper) and move being set in the webPageGroupMap()
to the constructor.

* WebKit2.xcodeproj/project.pbxproj:
Add new file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdding MediaConstraintsMock class
commit-queue@webkit.org [Wed, 27 Nov 2013 21:03:51 +0000 (21:03 +0000)]
Adding MediaConstraintsMock class
https://bugs.webkit.org/show_bug.cgi?id=124902

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-27
Reviewed by Eric Carlson.

Validate constraints used in RTCPeerConnection LayoutTests

Source/WebCore:

Existing test was updated.

* CMakeLists.txt:
* GNUmakefile.list.am:
* platform/mock/MediaConstraintsMock.cpp: Added.
* platform/mock/MediaConstraintsMock.h: Added.
* platform/mock/MockMediaStreamCenter.cpp:
(WebCore::MockMediaStreamCenter::validateRequestConstraints): Now using MediaConstraintsMock
(WebCore::MockMediaStreamCenter::createMediaStream): Ditto.
* platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::initialize): Ditto.

LayoutTests:

* fast/mediastream/RTCPeerConnection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Shape-Inside Should Default to 'auto'
betravis@adobe.com [Wed, 27 Nov 2013 20:19:48 +0000 (20:19 +0000)]
[CSS Shapes] Shape-Inside Should Default to 'auto'
https://bugs.webkit.org/show_bug.cgi?id=124851

Reviewed by Alexandru Chiculita.

Source/WebCore:

The current shape-inside specification has the property default to the 'auto'
value, not 'outside-shape'.

Updated tests are under fast/shapes.

* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:

LayoutTests:

Update tests to reflect a default shape-inside value of 'auto'.

* fast/shapes/css-shapes-disabled-expected.txt:
* fast/shapes/css-shapes-disabled.html:
* fast/shapes/parsing/parsing-shape-inside-expected.txt:
* fast/shapes/parsing/parsing-shape-inside.html:
* fast/shapes/parsing/parsing-shape-lengths-expected.txt:
* fast/shapes/parsing/parsing-shape-lengths.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] shape-inside rectangle layout can fail
hmuller@adobe.com [Wed, 27 Nov 2013 20:17:06 +0000 (20:17 +0000)]
[CSS Shapes] shape-inside rectangle layout can fail
https://bugs.webkit.org/show_bug.cgi?id=124784

Reviewed by Andreas Kling.

Source/WebCore:

Apply LayoutUnit::fromFloatCeil() consistently in RectangleShape::firstIncludedIntervalLogicalTop().

Test: fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html

* rendering/shapes/RectangleShape.cpp:
(WebCore::RectangleShape::firstIncludedIntervalLogicalTop):

LayoutTests:

Regression test.

* fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Qt-specific .qrc files
commit-queue@webkit.org [Wed, 27 Nov 2013 19:02:40 +0000 (19:02 +0000)]
Remove Qt-specific .qrc files
https://bugs.webkit.org/show_bug.cgi?id=124944

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-27
Reviewed by Andreas Kling.

Source/WebCore:

No new tests needed.

* WebCore.qrc: Removed.

Source/WebKit2:

* WebKit2.qrc: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies...
commit-queue@webkit.org [Wed, 27 Nov 2013 17:41:03 +0000 (17:41 +0000)]
[GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
https://bugs.webkit.org/show_bug.cgi?id=124940

Patch by Andres Gomez <agomez@igalia.com> on 2013-11-27
Reviewed by Martin Robinson.

xserver-font-utils is needed for building gtk port dependencies
with jhbuild.

* gtk/install-dependencies: Added xserver-font-utils to jhbuild
dependecies.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing ...
commit-queue@webkit.org [Wed, 27 Nov 2013 17:24:48 +0000 (17:24 +0000)]
[GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
https://bugs.webkit.org/show_bug.cgi?id=124938

Patch by Andres Gomez <agomez@igalia.com> on 2013-11-27
Reviewed by Philippe Normand.

Added needed git dependency for building the gtk port with
jhbuild. Also, the dependencies needed for building the gtk port
are now sorted alphabetically.

* gtk/install-dependencies: Added git as jhbuild dependency and
sorted dependencies alphabetically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Sparc specific code.
commit-queue@webkit.org [Wed, 27 Nov 2013 16:35:29 +0000 (16:35 +0000)]
Remove Sparc specific code.
https://bugs.webkit.org/show_bug.cgi?id=124941

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-11-27
Reviewed by Michael Saboff.

Sparc is not supported, remove leftover code.

* wtf/Platform.h:
* wtf/dtoa/utils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix after r159805.
rniwa@webkit.org [Wed, 27 Nov 2013 16:12:34 +0000 (16:12 +0000)]
Build fix after r159805.

* resources/runner.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agorun_webkit_tests.py: error: no such option: --wincairo
commit-queue@webkit.org [Wed, 27 Nov 2013 15:55:18 +0000 (15:55 +0000)]
run_webkit_tests.py: error: no such option: --wincairo
https://bugs.webkit.org/show_bug.cgi?id=124927

Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-27
Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
the layout testing on wincairo, so it is turned off.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStructure::m_staticFunctionReified should be a single bit.
akling@apple.com [Wed, 27 Nov 2013 15:10:25 +0000 (15:10 +0000)]
Structure::m_staticFunctionReified should be a single bit.
<https://webkit.org/b/124912>

Shave 8 bytes off of JSC::Structure by jamming m_staticFunctionReified
into the bitfield just above.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJSActivation constructor should use NotNull placement new.
akling@apple.com [Wed, 27 Nov 2013 15:05:53 +0000 (15:05 +0000)]
JSActivation constructor should use NotNull placement new.
<https://webkit.org/b/124909>

Knock a null check outta the storage initialization loop.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Wed, 27 Nov 2013 14:34:04 +0000 (14:34 +0000)]
Unreviewed EFL gardening

Add test expectations for flaky tests.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing
zandobersek@gmail.com [Wed, 27 Nov 2013 13:04:26 +0000 (13:04 +0000)]
[GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=124924

Reviewed by Carlos Garcia Campos.

'Chrome'/'Chromium' substrings were removed from the user agent string in r159572, meaning the unit
test shouldn't check for those two substrings anymore. Instead, 'Safari' (as until now) and 'AppleWebKit'
substrings should be checked for.

* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettingsUserAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GStreamer] Invalid command line error when visiting www.chessbase.com
calvaris@igalia.com [Wed, 27 Nov 2013 10:47:56 +0000 (10:47 +0000)]
[GStreamer] Invalid command line error when visiting chessbase.com
https://bugs.webkit.org/show_bug.cgi?id=124715

Reviewed by Philippe Normand.

Source/WebCore:

We were not handling the HTTP errors in the WebKit GStreamer
source and therefore the 404 error page was being 'decoded'. As no
decoder could be found (for obvious reasons), playback failed, but
it should be failing for the source not being found instead of the
decoding problem.

Test: http/tests/media/video-error-does-not-exist.html

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::handleResponseReceived): Handle HTTP errors in
the source and raise a GStreamer error to the pipeline.

LayoutTests:

Copied and adapted for HTTP from
media/video-error-does-not-exist.html.

* http/tests/media/video-error-does-not-exist-expected.txt: Added.
* http/tests/media/video-error-does-not-exist.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Fix positioning of grid items with margins
svillar@igalia.com [Wed, 27 Nov 2013 08:43:07 +0000 (08:43 +0000)]
[CSS Grid Layout] Fix positioning of grid items with margins
https://bugs.webkit.org/show_bug.cgi?id=124345

Reviewed by David Hyatt.

From Blink r157925 and r158041 by <jchaffraix@chromium.org>

Source/WebCore:

Test: fast/css-grid-layout/grid-item-margin-resolution.html

Adds margin start/before to the positions of grid items (removing
several FIXME's in the current code). This means calling
findChildLogicalPosition() after the layout in order to have the
right values for the margins.

In order to match flexbox and author's intents we're also
including the margins of grid items in the intrinsic size of the
grid. That's why flexbox's marginLogicalPositionForChild() is
moved up to RenderBlock in order to share it with RenderGrid.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::marginIntrinsicLogicalWidthForChild): Moved
from RenderFlexibleBox::marginLogicalWidthForChild().
* rendering/RenderBlock.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computePreferredTrackWidth):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::findChildLogicalPosition):

LayoutTests:

New test case for grid items margin resolution. Extended the
preferred logical widths checks with grid items with margins.

* fast/css-grid-layout/grid-item-margin-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-item-margin-resolution.html: Added.
* fast/css-grid-layout/grid-preferred-logical-widths-expected.txt:
* fast/css-grid-layout/grid-preferred-logical-widths.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax
svillar@igalia.com [Wed, 27 Nov 2013 08:31:14 +0000 (08:31 +0000)]
[CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax
https://bugs.webkit.org/show_bug.cgi?id=103312

Reviewed by Andreas Kling.

PerformanceTests:

Use the repeat() syntax to build the huge grids used by the
performance tests.

* Layout/auto-grid-lots-of-data.html:
* Layout/fixed-grid-lots-of-data.html:

Source/WebCore:

Added support for the repeat() syntax inside
grid-definition-{rows|columns} by just adding the repeated values
to our list of column|row definitions.

The parsing of <track-name> was refactored in a new function as
it's used now in three different places. The <track-size> parsing
was also refactored to share it with the repeat() parsing.

Test: fast/css-grid-layout/grid-element-repeat-get-set.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTrackNames):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseGridTrackRepeatFunction):
(WebCore::CSSParser::parseGridTrackSize):
* css/CSSParser.h:

LayoutTests:

Based on Blink r153155 by <jchaffraix@chromium.org>. Some code was
refactored in a helper function to have a more compact test.

* fast/css-grid-layout/grid-element-repeat-get-set-expected.txt: Added.
* fast/css-grid-layout/grid-element-repeat-get-set.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWindows rebaselines after r158547.
rniwa@webkit.org [Wed, 27 Nov 2013 06:14:46 +0000 (06:14 +0000)]
Windows rebaselines after r158547.

* platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
* platform/win/editing/selection/drag-text-delay-expected.txt: Added.
* platform/win/editing/selection/extend-selection-home-end-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNix upstreaming - Adding build files and supporting scripts
marcelo.lira@openbossa.org [Wed, 27 Nov 2013 06:05:27 +0000 (06:05 +0000)]
Nix upstreaming - Adding build files and supporting scripts
https://bugs.webkit.org/show_bug.cgi?id=118367

Reviewed by Ryosuke Niwa.

.:

* CMakeLists.txt:
* Source/CMakeLists.txt:
* Source/cmake/FindEGL.cmake:
* Source/cmake/FindOpenGLES2.cmake: Added.
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsNix.cmake: Added.

Source/Platform:

* CMakeLists.txt: Added.
* PlatformNix.cmake: Added.

Source/WebCore:

No new tests needed.

* CMakeLists.txt:
* PlatformNix.cmake: Added.

Source/WTF:

* wtf/FeatureDefines.h:
* wtf/Platform.h:
* wtf/PlatformNix.cmake: Added.

Tools:

* Scripts/build-webkit:
* Scripts/run-nix-tests: Added.
* Scripts/run-webkit-tests:
* Scripts/update-webkit-libs-jhbuild:
* Scripts/update-webkitnix-libs: Added.
* Scripts/webkitdirs.pm:
(determineArchitecture):
(argumentsForConfiguration):
(jscProductDir):
(builtDylibPathForName):
(determineIsNix):
(isNix):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):
(copyInspectorFrontendFiles):
(jhbuildWrapperPrefixIfNeeded):
(buildCMakeProjectOrExit):
(cmakeBasedPortName):
* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(EflWK2Port.build_webkit_command):
(NixPort):
(NixPort.build_webkit_command):
* Scripts/webkitpy/port/factory.py:
(platform_options):
(PortFactory):
* Scripts/webkitpy/port/nix.py: Added.
(NixPort):
(NixPort._wk2_port_name):
(NixPort.determine_full_port_name):
(NixPort.__init__):
(NixPort._port_flag_for_scripts):
(NixPort.setup_test_run):
(NixPort.setup_environ_for_server):
(NixPort.default_timeout_ms):
(NixPort.clean_up_test_run):
(NixPort._generate_all_test_configurations):
(NixPort._path_to_driver):
(NixPort._path_to_image_diff):
(NixPort._image_diff_command):
(NixPort._search_paths):
(NixPort.show_results_html_file):
(NixPort._port_specific_expectations_files):
(NixPort.default_baseline_search_path):
* Scripts/webkitpy/port/nix_unittest.py: Added.
(NixPortTest):
(NixPortTest._assert_search_path):
(NixPortTest._assert_expectations_files):
(NixPortTest.test_baseline_search_path):
(NixPortTest.test_expectations_files):
(NixPortTest.test_default_timeout_ms):
* jhbuild/jhbuild-wrapper:
(determine_platform):
* nix/common.py: Added.
(script_path):
(top_level_path):
* nix/jhbuild.modules: Added.
* nix/jhbuildrc: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRecord subtest values in Dromaeo tests
rniwa@webkit.org [Wed, 27 Nov 2013 05:33:17 +0000 (05:33 +0000)]
Record subtest values in Dromaeo tests
https://bugs.webkit.org/show_bug.cgi?id=124498

Reviewed by Andreas Kling.

PerformanceTests:

Made Dromaeo's test runner report values in DRT.progress via newly added PerfTestRunner.reportValues.

* Dromaeo/resources/dromaeorunner.js:
(.): Moved the definition out of DRT.setup.
(DRT.setup): Ditto.
(DRT.testObject): Extracted from DRT.setup. Set the subtest name and continueTesting.
continueTesting is set true for subtests; i.e. when name is specified.
(DRT.progress): Call PerfTestRunner.reportValues to report subtest results.
(DRT.teardown): Call PerfTestRunner.reportValues instead of measureValueAsync.

* resources/runner.js: Made various changes for newly added PerfTestRunner.reportValues.
(.): Moved the initialization of completedIterations, results, jsHeapResults, and mallocHeapResults into
start since they need to be initialized before running each subtest. Initialize logLines here since we
need to use the same logger for all subtests.
(.start): Initialize the variables mentioned above here. Also respect doNotLogStart used by reportValues.
(ignoreWarmUpAndLog): Added doNotLogProgress. Used by reportValues since it reports all values at once.
(finish): Compute the metric name such as FrameFrame and Runs from unit. Also don't log or notify done
when continueTesting is set on the test object.
(PerfTestRunner.reportValues): Added. Reports all values for the main/sub test.

Tools:

Supported parsing subtest results.

* Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
which contains a dictionary with its name and an ordered list of subtest's metrics.
(PerfTest.__init__): Initialize _metrics as a list.
(PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
(PerfTest._run_with_driver):
(PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.

* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
(TestPerfTest.test_parse_output): Ditto.
(TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
assertions to ensure subtest results are parsed properly.
(TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
adding new results.

* Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(TestWithSubtestsData): Added.
(TestDriver.run_test):
(MainTest.test_run_test_with_subtests): Added.

LayoutTests:

Rebaselined the test.

* fast/harness/perftests/runs-per-second-log-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnable HTML template element on Windows ports
rniwa@webkit.org [Wed, 27 Nov 2013 05:13:51 +0000 (05:13 +0000)]
Enable HTML template element on Windows ports
https://bugs.webkit.org/show_bug.cgi?id=124758

Reviewed by Andreas Kling.

Tools:

* Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

Enable TEMPLATE_ELEMENT. Also removed UNDO_MANAGER since that feature has been removed
from the tree in r133326.

* win/tools/vsprops/FeatureDefines.props:
* win/tools/vsprops/FeatureDefinesCairo.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove replay performance tests as it's not actively maintained
rniwa@webkit.org [Wed, 27 Nov 2013 04:36:18 +0000 (04:36 +0000)]
Remove replay performance tests as it's not actively maintained
https://bugs.webkit.org/show_bug.cgi?id=124764

Reviewed by Andreas Kling.

PerformanceTests:

Removed the replay performance tests. We can add them back when time comes.

* Replay/Chinese/chinaz.com.replay: Removed.
* Replay/Chinese/www.163.com.replay: Removed.
* Replay/Chinese/www.alipay.com.replay: Removed.
* Replay/Chinese/www.baidu.com.replay: Removed.
* Replay/Chinese/www.csdn.net.replay: Removed.
* Replay/Chinese/www.douban.com.replay: Removed.
* Replay/Chinese/www.hao123.com.replay: Removed.
* Replay/Chinese/www.xinhuanet.com.replay: Removed.
* Replay/Chinese/www.xunlei.com.replay: Removed.
* Replay/Chinese/www.youku.com.replay: Removed.
* Replay/English/beatonna.livejournal.com.replay: Removed.
* Replay/English/cakewrecks.blogspot.com.replay: Removed.
* Replay/English/chemistry.about.com.replay: Removed.
* Replay/English/digg.com.replay: Removed.
* Replay/English/en.wikipedia.org-rorschach_test.replay: Removed.
* Replay/English/icanhascheezburger.com.replay: Removed.
* Replay/English/imgur.com-gallery.replay: Removed.
* Replay/English/online.wsj.com.replay: Removed.
* Replay/English/stockoverflow.com-best-comment.replay: Removed.
* Replay/English/www.alibaba.com.replay: Removed.
* Replay/English/www.amazon.com-kindle.replay: Removed.
* Replay/English/www.apple.com.replay: Removed.
* Replay/English/www.cnet.com.replay: Removed.
* Replay/English/www.dailymotion.com.replay: Removed.
* Replay/English/www.ehow.com-prevent-fire.replay: Removed.
* Replay/English/www.filestube.com-amy-adams.replay: Removed.
* Replay/English/www.foxnews.replay: Removed.
* Replay/English/www.huffingtonpost.com.replay: Removed.
* Replay/English/www.imdb.com-twilight.replay: Removed.
* Replay/English/www.mozilla.com-all-order.replay: Removed.
* Replay/English/www.php.net.replay: Removed.
* Replay/English/www.reddit.com.replay: Removed.
* Replay/English/www.telegraph.co.uk.replay: Removed.
* Replay/English/www.w3.org-htmlcss.replay: Removed.
* Replay/English/www.w3schools.com-html.replay: Removed.
* Replay/English/www.youtube.com-music.replay: Removed.
* Replay/French/www.orange.fr.replay: Removed.
* Replay/Italian/www.repubblica.it.replay: Removed.
* Replay/Japanese/2ch.net-newsplus.replay: Removed.
* Replay/Japanese/entameblog.seesaa.net.replay: Removed.
* Replay/Japanese/ja.wikipedia.org.replay: Removed.
* Replay/Japanese/www.hatena.ne.jp.replay: Removed.
* Replay/Japanese/www.livedoor.com.replay: Removed.
* Replay/Japanese/www.nicovideo.jp.replay: Removed.
* Replay/Japanese/www.rakuten.co.jp.replay: Removed.
* Replay/Japanese/www.yahoo.co.jp.replay: Removed.
* Replay/Korean/www.naver.com.replay: Removed.
* Replay/Persian/blogfa.com.replay: Removed.
* Replay/Polish/www.wp.pl.replay: Removed.
* Replay/Portuguese/www.uol.com.br.replay: Removed.
* Replay/Russian/lenta.ru.replay: Removed.
* Replay/Russian/vkontakte.ru-help.replay: Removed.
* Replay/Russian/www.ixbt.com.replay: Removed.
* Replay/Russian/www.kp.ru.replay: Removed.
* Replay/Russian/www.liveinternet.ru.replay: Removed.
* Replay/Russian/www.pravda.ru.replay: Removed.
* Replay/Russian/www.rambler.ru.replay: Removed.
* Replay/Russian/www.ucoz.ru.replay: Removed.
* Replay/Russian/www.yandex.ru.replay: Removed.
* Replay/Spanish/www.taringa.net.replay: Removed.
* Replay/Swedish/www.flashback.se.replay: Removed.
* Replay/Swedish/www.tradera.com.replay: Removed.
* Replay/www.google.com.replay: Removed.
* Replay/www.techcrunch.com.replay: Removed.
* Replay/www.youtube.com.replay: Removed.

Tools:

Removed the feature.

* Scripts/webkitpy/performance_tests/perftest.py:
(SingleProcessPerfTest.__init__):
(PerfTestFactory):
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._collect_tests):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_collect_tests_with_ignored_skipped_list):
(MainTest.test_default_args):
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_unittest2):
* Scripts/webkitpy/thirdparty/__init___unittest.py:
(ThirdpartyTest.test_imports):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImport W3C tests for cloning template elements and default stylesheet for template...
rniwa@webkit.org [Wed, 27 Nov 2013 04:32:51 +0000 (04:32 +0000)]
Import W3C tests for cloning template elements and default stylesheet for template element
https://bugs.webkit.org/show_bug.cgi?id=124882

Reviewed by Andreas Kling.

Imported tests under html-templates/additions-to-the-steps-to-clone-a-node and
html-templates/additions-to-the-css-user-agent-style-sheet at d38dbd5b492808811bc0fe04a8cc49f28863c5cc.

Renamed and replicated css-user-agent-style-sheet-test-001-ref.html as -00*-expected.html for ref testing.

* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-001-expected.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-001.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-002-expected.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-002.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-003-expected.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-003.html: Added.
* html-templates/additions-to-the-steps-to-clone-a-node/template-clone-children-expected.txt: Added.
* html-templates/additions-to-the-steps-to-clone-a-node/template-clone-children.html: Added.
* html-templates/additions-to-the-steps-to-clone-a-node/templates-copy-document-owner-expected.txt: Added.
* html-templates/additions-to-the-steps-to-clone-a-node/templates-copy-document-owner.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnable aggressive DFG validation in testing
fpizlo@apple.com [Wed, 27 Nov 2013 04:05:12 +0000 (04:05 +0000)]
Enable aggressive DFG validation in testing
https://bugs.webkit.org/show_bug.cgi?id=124911

Rubber stamped by Ryosuke Niwa.

This enables validation testing in non-concurrent-JIT runs.

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't parent the TileController root layer in two places
timothy_horton@apple.com [Wed, 27 Nov 2013 03:50:06 +0000 (03:50 +0000)]
Don't parent the TileController root layer in two places
https://bugs.webkit.org/show_bug.cgi?id=124873

Reviewed by Brent Fulgham.

* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
The TileController's layer is already parented by callers of
TileController::create, and in a special way. TileController
shouldn't parent itself, anyway...

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoASSERT_WITH_SECURITY_IMPLICATION should crash in a distinct way.
commit-queue@webkit.org [Wed, 27 Nov 2013 03:35:14 +0000 (03:35 +0000)]
ASSERT_WITH_SECURITY_IMPLICATION should crash in a distinct way.
https://bugs.webkit.org/show_bug.cgi?id=124757

Change ASSERT_WITH_SECURITY_IMPLICATION to access a different address from CRASH()
in order to help screen fuzzing bugs.

Patch by Drew Yao <ayao@apple.com> on 2013-11-26
Reviewed by Brent Fulgham.

* wtf/Assertions.cpp:
* wtf/Assertions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRestructure global variable constant inference so that it could work for any kind...
fpizlo@apple.com [Wed, 27 Nov 2013 02:47:43 +0000 (02:47 +0000)]
Restructure global variable constant inference so that it could work for any kind of symbol table variable
https://bugs.webkit.org/show_bug.cgi?id=124760

Reviewed by Oliver Hunt.

This changes the way global variable constant inference works so that it can be reused
for closure variable constant inference. Some of the premises that originally motivated
this patch are somewhat wrong, but it led to some simplifications anyway and I suspect
that we'll be able to fix those premises in the future. The main point of this patch is
to make it easy to reuse global variable constant inference for closure variable
constant inference, and this will be possible provided we can also either (a) infer
one-shot closures (easy) or (b) infer closure variables that are always assigned prior
to first use.

One of the things that this patch is meant to enable is constant inference for closure
variables that may be part of a multi-shot closure. Closure variables may be
instantiated multiple times, like:

    function foo() {
        var WIDTH = 45;
        function bar() {
            ... use WIDTH ...
        }
        ...
    }

Even if foo() is called many times and WIDTH is assigned to multiple times, that
doesn't change the fact that it's a constant. The goal of closure variable constant
inference is to catch any case where a closure variable has been assigned at least once
and its value has never changed. This patch doesn't implement that, but it does change
global variable constant inference to have most of the powers needed to do that. Note
that most likely we will use this functionality only to implement constant inference
for one-shot closures, but the resulting machinery is still simpler than what we had
before.

This involves three changes:

    - The watchpoint object now contains the inferred value. This involves creating a
      new kind of watchpoint set, the VariableWatchpointSet. We will reuse this object
      for closure variables.

    - Writing to a variable that is watchpointed still involves these three states that
      we proceed through monotonically (Uninitialized->Initialized->Invalidated) but
      now, the Initialized->Invalidated state transition only happens if we change the
      variable's value, rather than store to the variable. Repeatedly storing the same
      value won't change the variable's state.

    - On 64-bit systems (the only systems on which we do concurrent JIT), you no longer
      need fancy fencing to get a consistent view of the watchpoint in the JIT. The
      state of the VariableWatchpointSet for the purposes of constant folding is
      entirely encapsulated in the VariableWatchpointSet::m_inferredValue. If that is
      JSValue() then you cannot fold (either because the set is uninitialized or
      because it's invalidated - doesn't matter which); on the other hand if the value
      is anything other than JSValue() then you can fold, and that's the value you fold
      to. Simple!

This also changes the way that DFG IR deals with variable watchpoints. It's now
oblivious to global variables. You install a watchpoint using VariableWatchpoint and
you notify write using NotifyWrite. Easy!

Note that this will requires some more tweaks because of the fact that op_enter will
store Undefined into every captured variable. Hence it won't even work for one-shot
closures. One-shot closures are easily fixed by introducing another state (so we'll
have Uninitialized->Undefined->Initialized->Invalidated). Multi-shot closures will
require static analysis. One-shot closures are clearly a higher priority.

* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/Instruction.h:
* bytecode/VariableWatchpointSet.h: Added.
(JSC::VariableWatchpointSet::VariableWatchpointSet):
(JSC::VariableWatchpointSet::~VariableWatchpointSet):
(JSC::VariableWatchpointSet::inferredValue):
(JSC::VariableWatchpointSet::notifyWrite):
(JSC::VariableWatchpointSet::invalidate):
(JSC::VariableWatchpointSet::finalizeUnconditionally):
(JSC::VariableWatchpointSet::addressOfInferredValue):
* bytecode/Watchpoint.h:
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasRegisterPointer):
(JSC::DFG::Node::hasVariableWatchpointSet):
(JSC::DFG::Node::variableWatchpointSet):
* dfg/DFGNodeType.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMod):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGWatchpointCollectionPhase.cpp:
(JSC::DFG::WatchpointCollectionPhase::handle):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNotifyWrite):
* jit/JIT.h:
* jit/JITOperations.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitNotifyWrite):
(JSC::JIT::emitPutGlobalVar):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitNotifyWrite):
(JSC::JIT::emitPutGlobalVar):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::addGlobalVar):
(JSC::JSGlobalObject::addFunction):
* runtime/JSGlobalObject.h:
* runtime/JSScope.h:
(JSC::ResolveOp::ResolveOp):
* runtime/JSSymbolTableObject.h:
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):
* runtime/SymbolTable.cpp:
(JSC::SymbolTableEntry::inferredValue):
(JSC::SymbolTableEntry::prepareToWatch):
(JSC::SymbolTableEntry::addWatchpoint):
(JSC::SymbolTableEntry::notifyWriteSlow):
(JSC::SymbolTable::visitChildren):
(JSC::SymbolTable::WatchpointCleanup::WatchpointCleanup):
(JSC::SymbolTable::WatchpointCleanup::~WatchpointCleanup):
(JSC::SymbolTable::WatchpointCleanup::finalizeUnconditionally):
* runtime/SymbolTable.h:
(JSC::SymbolTableEntry::watchpointSet):
(JSC::SymbolTableEntry::notifyWrite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[MediaStream API] HTMLMediaElement should be able to use MediaStream as source
commit-queue@webkit.org [Wed, 27 Nov 2013 02:13:04 +0000 (02:13 +0000)]
[MediaStream API] HTMLMediaElement should be able to use MediaStream as source
https://bugs.webkit.org/show_bug.cgi?id=121943

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-26
Reviewed by Eric Carlson.

Source/WebCore:

Implement MediaStream direct assignment to Media Elements using the new 'srcObject'
attribute: http://www.w3.org/TR/mediacapture-streams/#direct-assignment-to-media-elements

Test: fast/mediastream/MediaStream-MediaElement-srcObject.html

* CMakeLists.txt: Added new HTMLMediaElementMediaStream.h and .cpp to cmake build.
* DerivedSources.make: Added HTMLMediaElementMediaStream.idl.
* GNUmakefile.list.am: Added new HTMLMediaElementMediaStream* to autotools build.
* WebCore.xcodeproj/project.pbxproj: Added new files.
* Modules/mediastream/HTMLMediaElementMediaStream.cpp: Added.
(WebCore::HTMLMediaElementMediaStream::srcObject): implements srcObject getter.
(WebCore::HTMLMediaElementMediaStream::setSrcObject): implements srcObject setter.
* Modules/mediastream/HTMLMediaElementMediaStream.h: Added.
* Modules/mediastream/HTMLMediaElementMediaStream.idl: Added.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setSrcObject): This is an initial implementation, and
is still incomplete, that will be addressed in a separate bug: https://webkit.org/b/124896
* html/HTMLMediaElement.h: Added m_mediaStreamSrcObject class variable
and its corresponding getter.

Source/WebKit2:

Add mediastream module and platform to cmake include directories.

* CMakeLists.txt:

LayoutTests:

Add layout tests to MediaStream direct assignment to HTMLMediaElement
using brand new srcObject attribute.

* fast/mediastream/MediaStream-MediaElement-srcObject-expected.txt: Added.
* fast/mediastream/MediaStream-MediaElement-srcObject.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMoved methods which belong to Checkout into checkout.py
commit-queue@webkit.org [Wed, 27 Nov 2013 01:27:28 +0000 (01:27 +0000)]
Moved methods which belong to Checkout into checkout.py
https://bugs.webkit.org/show_bug.cgi?id=124889

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-26
Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/common/checkout/checkout.py:
(Checkout.scripts_directory):
(Checkout):
(Checkout.script_path):
(Checkout.commit_message_for_this_commit):
(Checkout.apply_patch):
* Scripts/webkitpy/common/checkout/checkout_unittest.py:
(test_commit_message_for_this_commit):
(CheckoutTest.test_apply_patch):
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.absolute_path):
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(SCMTest._setup_webkittools_scripts_symlink):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.create_patch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCreate a new SymbolTable every time code is loaded so that the watchpoints don't...
fpizlo@apple.com [Wed, 27 Nov 2013 01:22:07 +0000 (01:22 +0000)]
Create a new SymbolTable every time code is loaded so that the watchpoints don't get reused
https://bugs.webkit.org/show_bug.cgi?id=124824

Reviewed by Oliver Hunt.

This helps with one shot closure inference as well as closure variable constant
inference, since without this, if code was reloaded from the cache then we would
think that the first run was actually an Nth run. This would cause us to think that
the watchpoint(s) should all be invalidated.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::stronglyVisitStrongReferences):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::symbolTable):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::symbolTable):
* runtime/Executable.h:
* runtime/SymbolTable.cpp:
(JSC::SymbolTable::clone):
* runtime/SymbolTable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse child iterator to find operators in RenderMathMLRow::layout().
bfulgham@apple.com [Tue, 26 Nov 2013 23:55:16 +0000 (23:55 +0000)]
Use child iterator to find operators in RenderMathMLRow::layout().
<https://webkit.org/b/124108>

Replace manual children walk with childrenOfType<RenderMathMLBlock>.
Minor update to fix build.

Patch by Andreas Kling <akling@apple.com> on 2013-11-26
Reviewed by Martin Robinson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderObject: Inline isBody() and isHR().
akling@apple.com [Tue, 26 Nov 2013 23:36:00 +0000 (23:36 +0000)]
RenderObject: Inline isBody() and isHR().
<https://webkit.org/b/124901>

Together these account for ~0.3% of samples on HTML5-8266.
Almost all of it is call overhead.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Layout using [<box> || <shape>] value
betravis@adobe.com [Tue, 26 Nov 2013 23:05:28 +0000 (23:05 +0000)]
[CSS Shapes] Layout using [<box> || <shape>] value
https://bugs.webkit.org/show_bug.cgi?id=124428

Reviewed by David Hyatt.

Source/WebCore:

When a box value is supplied, use it to size and position the shape. Otherwise,
use a default value (content-box for shape-inside, margin-box for shape-outside).
This patch extends the sizing and positioning code used for the box patch (Bug 124227)
to also apply to shapes. With this patch, we also no longer use the box-sizing
property to size and position shapes.

Tests: fast/shapes/shape-outside-floats/shape-outside-shape-boxes-001.html
       fast/shapes/shape-outside-floats/shape-outside-shape-boxes-002.html
       fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue): Adjust for ShapeValues storing
BasicShape::ReferenceBox as their box value, rather than a CSSValueID.
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyShape::applyValue): Ditto.
* rendering/shapes/ShapeInfo.h:
(WebCore::ShapeInfo::setShapeSize): Adjust for BasicShapes with reference boxes
as well as plain box values. Also, remove old box-sizing code.
(WebCore::ShapeInfo::logicalTopOffset): Ditto.
(WebCore::ShapeInfo::logicalLeftOffset): Ditto.
* rendering/shapes/ShapeInsideInfo.h:
* rendering/shapes/ShapeOutsideInfo.h:
* rendering/style/ShapeValue.h:
(WebCore::ShapeValue::createBoxValue): Adjust for boxes being stored as
BasicShape::ReferenceBoxes.
(WebCore::ShapeValue::box): Ditto.
(WebCore::ShapeValue::ShapeValue): Ditto.

LayoutTests:

Adding tests to make sure that shapes properly size and position themselves across box values
and writing modes. Some shape-outside tests needed to be updated to explicitly size themselves
to content-box, as they were relying on that being the default value. Some shape-inside tests
needed to be adjusted as box-sizing no longer affects the shape size and position.

* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001.html:
Explicitly size to content-box.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html: Ditto.
* csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html: Ditto.
* fast/shapes/shape-inside/shape-inside-box-sizing-expected.html: Small test cleanup.
* fast/shapes/shape-inside/shape-inside-box-sizing.html: Modify shapes to provide their sizing box.
* fast/shapes/shape-inside/shape-inside-empty-expected.html: Small test cleanup.
* fast/shapes/shape-inside/shape-inside-empty.html: Modify shapes to provide their sizing box.
* fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html: Ditto.
* fast/shapes/shape-outside-floats/shape-outside-shape-boxes-001-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-shape-boxes-001.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-shape-boxes-002-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-shape-boxes-002.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003.html: Added.
* inspector-protocol/model/highlight-shape-outside.html: Modify shapes to provide their sizing box.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImageBuffer::create should return a std::unique_ptr instead of OwnPtr.
commit-queue@webkit.org [Tue, 26 Nov 2013 22:58:17 +0000 (22:58 +0000)]
ImageBuffer::create should return a std::unique_ptr instead of OwnPtr.
https://bugs.webkit.org/show_bug.cgi?id=124822

Patch by Brian J. Burg <burg@cs.washington.edu> on 2013-11-26
Reviewed by Andreas Kling.

Replace all uses of OwnPtr<ImageBuffer> and PassOwnPtr<ImageBuffer> with
std::unique_ptr<ImageBuffer>. Replace calls to OwnPtr::clear() and
OwnPtr::release() with reset() and std::move(). Remove unnecessary includes.

No new tests. This is a mechanical refactoring.

* css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::setSurfaceSize):
* html/HTMLCanvasElement.h:
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* html/canvas/CanvasRenderingContext2D.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache):
(WebCore::WebGLRenderingContext::LRUImageBufferCache::imageBuffer):
* html/canvas/WebGLRenderingContext.h:
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
* page/Frame.cpp:
(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::drawPattern):
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::drawPattern):
* platform/graphics/GradientImage.h:
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::createCompatibleBuffer):
* platform/graphics/GraphicsContext.h:
* platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::createCompatibleBuffer):
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::create):
* platform/graphics/ShadowBlur.cpp:
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::putByteArray):
* platform/graphics/cg/PDFDocumentImage.h:
* platform/graphics/filters/FETile.cpp:
(WebCore::FETile::platformApplySoftware):
* platform/graphics/filters/Filter.h:
(WebCore::Filter::setSourceImage):
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::clearResult):
* platform/graphics/filters/FilterEffect.h:
* platform/graphics/texmap/TextureMapper.cpp:
(WebCore::BitmapTexture::updateContents):
* platform/graphics/texmap/TextureMapperImageBuffer.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDecoration):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintProgressBar):
* rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::invalidateBufferedForeground):
* rendering/svg/RenderSVGImage.h:
* rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
* rendering/svg/RenderSVGResourceClipper.h:
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
* rendering/svg/RenderSVGResourceFilter.h:
* rendering/svg/RenderSVGResourceGradient.cpp: Remove method parameter wrapping/indentation.
(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/svg/RenderSVGResourceGradient.h:
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/svg/RenderSVGResourceMasker.h:
* rendering/svg/RenderSVGResourcePattern.cpp: Remove method parameter wrapping/indentation.
(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::createTileImage):
* rendering/svg/RenderSVGResourcePattern.h: Remove method parameter wrapping/indentation.
* rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::createImageBuffer):
(WebCore::SVGRenderingContext::createImageBufferForPattern):
(WebCore::SVGRenderingContext::clipToImageBuffer):
(WebCore::SVGRenderingContext::bufferForeground):
* rendering/svg/SVGRenderingContext.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::nativeImageForCurrentFrame):
(WebCore::SVGImage::drawPatternForContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash in JSC::ASTBuilder::Expression JSC::Parser<JSC::Lexer<unsigned char> >::parseUn...
oliver@apple.com [Tue, 26 Nov 2013 20:24:58 +0000 (20:24 +0000)]
Crash in JSC::ASTBuilder::Expression JSC::Parser<JSC::Lexer<unsigned char> >::parseUnaryExpression<JSC::ASTBuilder>(JSC::ASTBuilder&)
https://bugs.webkit.org/show_bug.cgi?id=124886

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Make sure the error macros propagate an existing error before
trying to create a new error message.  We need to do this as
the parser state may not be safe for any specific error message
if we are already unwinding due to an error.

* parser/Parser.cpp:

LayoutTests:

Add tests

* js/parser-syntax-check-expected.txt:
* js/script-tests/parser-syntax-check.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agovideo.currentSrc should return empty when no resource is loaded
eric.carlson@apple.com [Tue, 26 Nov 2013 20:11:31 +0000 (20:11 +0000)]
video.currentSrc should return empty when no resource is loaded
https://bugs.webkit.org/show_bug.cgi?id=124898

Reviewed by Dan Bernstein.

Source/WebCore:

Test: media/video-currentsrc-cleared.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::prepareForLoad): Set m_currentSrc to empty in
    preparation for attempting to load a new url.

LayoutTests:

* media/video-currentsrc-cleared-expected.txt: Added.
* media/video-currentsrc-cleared.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSome WebKit2 headers are not self-contained
mitz@apple.com [Tue, 26 Nov 2013 20:07:48 +0000 (20:07 +0000)]
Some WebKit2 headers are not self-contained
https://bugs.webkit.org/show_bug.cgi?id=124884

Reviewed by Anders Carlsson.

* Shared/API/Cocoa/WKRemoteObjectInterface.h: Added import.
* Shared/API/Cocoa/WKRemoteObjectRegistry.h: Ditto.
* Shared/API/c/WKContextMenuItemTypes.h: Added include.
* Shared/API/c/WKFindOptions.h: Ditto.
* Shared/API/c/WKMutableArray.h: Ditto.
* Shared/API/c/WKPageLoadTypes.h: Ditto.
* Shared/API/c/WKPageVisibilityTypes.h: Ditto.

* Shared/API/c/WKPluginInformation.cpp:
(WKPluginInformationBundleIdentifierKey): Made this API function always be defined. When
the Netscape plug-in API is not enabled, it returns 0.
(WKPluginInformationBundleVersionKey): Ditto.
(WKPluginInformationBundleShortVersionKey): Ditto.
(WKPluginInformationPathKey): Ditto.
(WKPluginInformationDisplayNameKey): Ditto.
(WKPluginInformationDefaultLoadPolicyKey): Ditto.
(WKPluginInformationUpdatePastLastBlockedVersionIsKnownAvailableKey): Ditto.
(WKPluginInformationHasSandboxProfileKey): Ditto.
(WKPluginInformationFrameURLKey): Ditto.
(WKPluginInformationMIMETypeKey): Ditto.
(WKPluginInformationPageURLKey): Ditto.
(WKPluginInformationPluginspageAttributeURLKey): Ditto.
(WKPluginInformationPluginURLKey): Ditto.
(WKPlugInInformationReplacementObscuredKey): Ditto.

* Shared/API/c/WKString.h: Added include.
* UIProcess/API/C/WKCredentialTypes.h: Ditto.
* UIProcess/API/C/WKPageContextMenuClient.h: Ditto.
* UIProcess/API/C/WKPageLoaderClient.h: Added includes.
* UIProcess/API/C/WKPagePolicyClient.h: Ditto.
* UIProcess/API/C/WKPageUIClient.h: Ditto.

* UIProcess/API/C/WKPluginSiteDataManager.cpp:
(WKPluginSiteDataManagerGetTypeID): Fixed the !ENABLE(NETSCAPE_PLUGIN_API) build.

* UIProcess/API/C/mac/WKContextPrivateMac.h: Removed use of ENABLE() from this private
header.
* UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextCopyPlugInInfoForBundleIdentifier): Made this API function always be defined.
When the Netscape plug-in API is not enabled, it returns 0.
(WKContextGetInfoForInstalledPlugIns): Made this API function always be defined.

* UIProcess/API/C/mac/WKInspectorPrivateMac.h: Added imports.
* UIProcess/API/C/mac/WKPagePrivateMac.h: Added include.
* UIProcess/API/Cocoa/WKBackForwardListItem.h: Added import.
* UIProcess/API/Cocoa/WKNavigationData.h: Ditto.
* UIProcess/API/cpp/WKRetainPtr.h: Replaced use of WARN_UNUSED_RETURN in this private header
with an equivalent macro defined in the header.

* WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: Added include.
* WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:
(WKBundleInspectorGetTypeID): Made this API function always be defined. When the Inspector
is not enabled, it returns the Null type.
(WKBundleInspectorShow): Made this API function always be defined.
(WKBundleInspectorClose): Ditto.
(WKBundleInspectorEvaluateScriptForTest): Ditto.
(WKBundleInspectorSetPageProfilingEnabled): Ditto.
* WebProcess/InjectedBundle/API/c/WKBundleInspector.h: Removed use of ENABLE() from this
private header.

* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Added includes.
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added include.

* WebProcess/Plugins/Netscape/mac/WKNPAPIPlugInContainer.mm:
(-[WKNPAPIPlugInContainer openPlugInPreferencePane]): Fixed the !ENABLE(NETSCAPE_PLUGIN_API)
build.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget): Ditto.

* WebProcess/WebPage/mac/WebInspectorMac.mm: Fixed the !ENABLE(INSPECTOR) build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Support for shape-margin in BoxShape
hmuller@adobe.com [Tue, 26 Nov 2013 19:19:37 +0000 (19:19 +0000)]
[CSS Shapes] Support for shape-margin in BoxShape
https://bugs.webkit.org/show_bug.cgi?id=124788

Source/WebCore:

Reviewed by Andreas Kling.

Corrected BoxShape's internal shape-margin/padding bounds FloatRoundedRect
initialization. Tests for the padding bounds will be added when the rest of
shape-padding for box shapes implementation is ready.

Tests: fast/shapes/shape-outside-floats/shape-outside-margin-boxes-001.html
       fast/shapes/shape-outside-floats/shape-outside-margin-boxes-002.html

* rendering/shapes/BoxShape.cpp: Use constructor shape-margin,shape-padding parameters.
(WebCore::BoxShape::BoxShape):
* rendering/shapes/BoxShape.h:
* rendering/shapes/Shape.cpp:
(WebCore::createBoxShape): Pass the shape-margin and shape-padding values along to the BoxShape constructor.
(WebCore::Shape::createShape): Ditto.

LayoutTests:

Verify that shape-margin has the expected effect on the four possible shape-outside box values
for left and right floats.

Reviewed by Andreas Kling.

* fast/shapes/shape-outside-floats/shape-outside-margin-boxes-001-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-margin-boxes-001.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-margin-boxes-002-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-margin-boxes-002.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unnecessary webaudio include from MediaStreamSource header
commit-queue@webkit.org [Tue, 26 Nov 2013 18:34:06 +0000 (18:34 +0000)]
Remove unnecessary webaudio include from MediaStreamSource header
https://bugs.webkit.org/show_bug.cgi?id=124897

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-26
Reviewed by Eric Carlson.

AudioDestinationConsumer.h is included but not used anywhere in
MediaStreamSource implementation.

* platform/mediastream/MediaStreamSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdated Brazilian Portuguese translation of WebKitGTK+ - November 02, 2013
gns@gnome.org [Tue, 26 Nov 2013 17:47:07 +0000 (17:47 +0000)]
Updated Brazilian Portuguese translation of WebKitGTK+ - November 02, 2013
https://bugs.webkit.org/show_bug.cgi?id=123694

Patch by Enrico Nicoletto <liverig@gmail.com> on 2013-11-26
Reviewed by Gustavo Noronha.

* pt_BR.po: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Tue, 26 Nov 2013 17:21:08 +0000 (17:21 +0000)]
Unreviewed EFL gardening

Add test expectations for failing accessibility tests.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOptimize away OR with zero - a common ASM.js pattern.
nrotem@apple.com [Tue, 26 Nov 2013 17:10:00 +0000 (17:10 +0000)]
Optimize away OR with zero - a common ASM.js pattern.
https://bugs.webkit.org/show_bug.cgi?id=124869

Reviewed by Filip Pizlo.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAvoid unnecessary copy-on-write in FillLayer style application.
akling@apple.com [Tue, 26 Nov 2013 16:20:16 +0000 (16:20 +0000)]
Avoid unnecessary copy-on-write in FillLayer style application.
<https://webkit.org/b/124878>

We ended up with a lot of cloned StyleBackgroundData objects on
HTML5-8266. This happened because we always forced a copy-on-write
when applying background-image:inherit / background-image:initial.

This patch adds early returns to both functions. In the "inherit"
case, we bail early if the target style already has the same fill
layer data as its parent style.

In the "initial" case, we optimize for the single-FillLayer case
and add an early return if the relevant value is either unset or
equal to the templatized initial value.

2.46 MB progression on HTML5-8266 locally.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed ATK gardening
m.pakula@samsung.com [Tue, 26 Nov 2013 14:09:15 +0000 (14:09 +0000)]
Unreviewed ATK gardening

Rebaseline accessibility tests after r159747.

* platform/efl-wk1/accessibility/table-detection-expected.txt:
* platform/efl-wk2/accessibility/table-detection-expected.txt:
* platform/gtk/accessibility/table-detection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Allow showing a context menu on all mouse events.
graouts@apple.com [Tue, 26 Nov 2013 08:29:11 +0000 (08:29 +0000)]
Web Inspector: Allow showing a context menu on all mouse events.
https://bugs.webkit.org/show_bug.cgi?id=124747

Reviewed by Joseph Pecoraro.

Source/WebCore:

Add a new InspectorFrontendHost::dispatchEventAsContextMenuEvent(Event*) method
to let the inspector front-end dispatch a native contextmenu event that will allow
for a context menu to be shown from within a non-contextmenu event handler.

* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):
Check that we're dealing with a mouse event, get the frame for the event target
and the event's location to call ContextMenuController::showContextMenuAt()
which will handle the new contextmenu event dispatch to the original event target.

* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:

Source/WebInspectorUI:

Automatically dispatch a contextmenu event in case WebInspector.ContextMenu.prototype.show()
is called outside of a contextmenu event handler and would therefore not show the expected
context menu (except in the Remote Web Inspector where this already works).

* UserInterface/ContextMenu.js:
(WebInspector.ContextMenu.prototype.show):
Check whether the event is a contextmenu event, and if not, add an event listener for a manually
dispatched contextmenu event such that we may then call InspectorFrontendHost.showContextMenu()
in a contextmenu event handler.

(WebInspector.ContextMenu.prototype.handleEvent):
Call InspectorFrontendHost.showContextMenu() now that we received the manually dispatched
contextmenu event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoConvert some Shape code to use references
weinig@apple.com [Tue, 26 Nov 2013 05:54:30 +0000 (05:54 +0000)]
Convert some Shape code to use references
https://bugs.webkit.org/show_bug.cgi?id=124876

Reviewed by Andreas Kling.

* inspector/InspectorOverlay.cpp:
* rendering/FloatingObjects.cpp:
* rendering/LayoutState.cpp:
* rendering/RenderBlock.cpp:
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
* rendering/RenderBox.cpp:
* rendering/RenderBox.h:
* rendering/line/BreakingContextInlineHeaders.h:
* rendering/line/LineWidth.cpp:
* rendering/shapes/ShapeInfo.cpp:
* rendering/shapes/ShapeInfo.h:
* rendering/shapes/ShapeInsideInfo.cpp:
* rendering/shapes/ShapeInsideInfo.h:
* rendering/shapes/ShapeOutsideInfo.cpp:
* rendering/shapes/ShapeOutsideInfo.h:
Replace yet more pointers with references.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] E_DBus should be an optional
ryuan.choi@samsung.com [Tue, 26 Nov 2013 05:46:52 +0000 (05:46 +0000)]
[EFL] E_DBus should be an optional
https://bugs.webkit.org/show_bug.cgi?id=124881

Reviewed by Gyuyoung Kim.

* Source/cmake/OptionsEfl.cmake:
Checked E_DBus when only ENABLE_BATTERY_STATUS is on.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [CSS Regions] A page with many flows should collapse the resources...
achicu@adobe.com [Tue, 26 Nov 2013 02:21:04 +0000 (02:21 +0000)]
Web Inspector: [CSS Regions] A page with many flows should collapse the resources tree
https://bugs.webkit.org/show_bug.cgi?id=122926

Reviewed by Timothy Hatcher.

Refactored the code in FrameTreeElement._shouldGroupIntoFolders to make it easy to track
more types of resources. Added the content flows as another type of resource that would trigger the
collapsing.

* UserInterface/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype.namedFlowRemoved): Added code to remove the content nodes from
a flow that has been removed.
* UserInterface/FrameTreeElement.js:
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushCategory):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushResourceType):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Use Config mode of find_package for EFL 1.8
ryuan.choi@samsung.com [Tue, 26 Nov 2013 02:16:29 +0000 (02:16 +0000)]
[EFL] Use Config mode of find_package for EFL 1.8
https://bugs.webkit.org/show_bug.cgi?id=124555

Reviewed by Gyuyoung Kim.

.:

EFL 1.8 changed VERSION macro so it's difficult to use tricky approach
which parses header files to know the version. Instead, EFL 1.8 supports
FooConfig.cmake such as EinaConfig.cmake.

This patch tries to use a config mode if it is available.
If config mode is not available with Eo, FindFoo.cmake will be used without
version requirement.

* Source/cmake/FindEo.cmake: Removed.
EoConfig.cmake is only preffered for EFL 1.8.
* Source/cmake/OptionsEfl.cmake:

Tools:

* MiniBrowser/efl/CMakeLists.txt:
Added optional config mode and made version requirement optional.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] Use class extensions for IPI
mitz@apple.com [Tue, 26 Nov 2013 00:47:51 +0000 (00:47 +0000)]
[Cocoa] Use class extensions for IPI
https://bugs.webkit.org/show_bug.cgi?id=124870

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKBrowsingContextController.mm: Reordered methods so that the Private
cateogry isn’t stuck between the API methods and the internal methods.
(-[WKBrowsingContextController setPaginationMode:]):
(-[WKBrowsingContextController paginationMode]):
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]):
(-[WKBrowsingContextController paginationBehavesLikeColumns]):
(-[WKBrowsingContextController setPageLength:]):
(-[WKBrowsingContextController pageLength]):
(-[WKBrowsingContextController setGapBetweenPages:]):
(-[WKBrowsingContextController gapBetweenPages]):
(-[WKBrowsingContextController pageCount]):
(-[WKBrowsingContextController handle]):
* UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Changed Internal category into
a class extension.

* UIProcess/API/mac/WKConnection.mm:
* UIProcess/API/mac/WKConnectionInternal.h: Changed Internal category into a class
extension.

* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Search functionality in MiniBrowser provides feedback on search fail
commit-queue@webkit.org [Tue, 26 Nov 2013 00:21:07 +0000 (00:21 +0000)]
[GTK] Search functionality in MiniBrowser provides feedback on search fail
https://bugs.webkit.org/show_bug.cgi?id=122681

Patch by Andres Gomez <agomez@igalia.com> on 2013-11-25
Reviewed by Mario Sanchez Prada.

When using the search functionality in MiniBrowser, if the search
fails, the entry background color gets red to report the user
about the failing condition. When the entry is cleaned or the
search is again succesful the background turns back to its
original color.

* MiniBrowser/gtk/BrowserSearchBar.c:
(setFailedStyleForEntry): Added.
(doSearch): Sets the entry's background to its original style if
there is no text to search.
(findControllerFailedToFindTextCallback): Added.
(findControllerFoundTextCallback): Added.
(browser_search_bar_init): Creates and adds a new CSS provider to
the text entry so we can change its style based on the success
condition of the search.
(browserSearchBarFinalize): Frees the new CSS provider.
(browser_search_bar_new): Connects the two new handlers to the
"failed-to-find-text" and "found-text" signals emitted by the
WebKitFindController.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFixed the iOS build.
mitz@apple.com [Tue, 26 Nov 2013 00:20:42 +0000 (00:20 +0000)]
Fixed the iOS build.

* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadDelegateInternal]):
(-[WKBrowsingContextController setLoadDelegateInternal:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] X11Helper::createPixmap doesn't initialise out value handleId
simon.pena@samsung.com [Mon, 25 Nov 2013 23:55:45 +0000 (23:55 +0000)]
[EFL] X11Helper::createPixmap doesn't initialise out value handleId
https://bugs.webkit.org/show_bug.cgi?id=124722

Reviewed by Gyuyoung Kim.

The overloaded functions X11Helper::createPixmap don't initialise out
value handleId, and they do early returns on error situations. Since
the functions are void and they don't communicate their failure in any
way, returning an out value without initialising it could make the
error go farther unnoticed. With the variable being initialised, it can
be reliably checked for errors when the function returns.

* platform/graphics/surfaces/glx/X11Helper.cpp:
(WebCore::X11Helper::createPixmap): Initialise handleId to 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark URLRegistry's lookup() as const and its child classes as final
commit-queue@webkit.org [Mon, 25 Nov 2013 23:50:36 +0000 (23:50 +0000)]
Mark URLRegistry's lookup() as const and its child classes as final
https://bugs.webkit.org/show_bug.cgi?id=124865

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.

No new tests needed. No behavior changes.

* Modules/mediasource/MediaSourceRegistry.cpp:
(WebCore::MediaSourceRegistry::lookup): marked as const.
* Modules/mediasource/MediaSourceRegistry.h: MediaSourceRegistry
marked as final.
* Modules/mediastream/MediaStreamRegistry.cpp:
(WebCore::MediaStreamRegistry::lookup): marked as const.
* Modules/mediastream/MediaStreamRegistry.h: MediaStreamRegistry
marked as final.
* fileapi/Blob.cpp:
* html/URLRegistry.h: lookup() marked as const.
(WebCore::URLRegistry::lookup): marked as const.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] Remove some indirection that was only necessary for supporting the legacy...
mitz@apple.com [Mon, 25 Nov 2013 23:50:27 +0000 (23:50 +0000)]
[Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime
https://bugs.webkit.org/show_bug.cgi?id=123065

Reviewed by Sam Weinig.

* UIProcess/API/mac/WKBrowsingContextController.h: Removed _data ivar and
WKBrowsingContextControllerData class declaration.
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController dealloc]): Removed
WKBrowsingContextControllerData class and moved ivars directly into
WKBrowsingContextController, declaring them in the @implementation. Removed ivar and
accessors for the delegate properties, letting the compiler synthesize them.
(-[WKBrowsingContextController _pageRef]): Removed indirection via _data.
(-[WKBrowsingContextController loadRequest:userData:]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]): Ditto.
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController stopLoading]): Ditto.
(-[WKBrowsingContextController reload]): Ditto.
(-[WKBrowsingContextController reloadFromOrigin]): Ditto.
(-[WKBrowsingContextController goForward]): Ditto.
(-[WKBrowsingContextController canGoForward]): Ditto.
(-[WKBrowsingContextController goBack]): Ditto.
(-[WKBrowsingContextController canGoBack]): Ditto.
(-[WKBrowsingContextController goToBackForwardListItem:]): Ditto.
(-[WKBrowsingContextController backForwardList]): Ditto.
(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController unreachableURL]): Removed idirection via _data.
(-[WKBrowsingContextController estimatedProgress]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController title]): Ditto.
(-[WKBrowsingContextController textZoom]): Ditto.
(-[WKBrowsingContextController setTextZoom:]): Ditto.
(-[WKBrowsingContextController pageZoom]): Ditto.
(-[WKBrowsingContextController setPageZoom:]): Ditto.
(-[WKBrowsingContextController setPaginationMode:]): Ditto.
(-[WKBrowsingContextController paginationMode]): Ditto.
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]): Ditto.
(-[WKBrowsingContextController paginationBehavesLikeColumns]): Ditto.
(-[WKBrowsingContextController setPageLength:]): Ditto.
(-[WKBrowsingContextController pageLength]): Ditto.
(-[WKBrowsingContextController setGapBetweenPages:]): Ditto.
(-[WKBrowsingContextController gapBetweenPages]): Ditto.
(-[WKBrowsingContextController pageCount]): Ditto.
(-[WKBrowsingContextController handle]): Ditto.
(-[WKBrowsingContextController _initWithPageRef:]): Removed indirection via _data.

* UIProcess/API/mac/WKBrowsingContextGroup.h: Removed _data ivar and
WKBrowsingContextGroupData class declaration.
* UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed WKBrowsingContextGroupData class and
moved _pageGroupRef ivar directly into WKBrowsingContextGroup, declaring it in the
@implementation.
(-[WKBrowsingContextGroup initWithIdentifier:]): Removed indirection via _data.
(-[WKBrowsingContextGroup allowsJavaScript]): Removed indirection via -_pageGroupRef.
(-[WKBrowsingContextGroup setAllowsJavaScript:]): Ditto.
(-[WKBrowsingContextGroup allowsJavaScriptMarkup]): Ditto.
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]): Ditto.
(-[WKBrowsingContextGroup allowsPlugIns]): Ditto.
(-[WKBrowsingContextGroup setAllowsPlugIns:]): Ditto.
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]): Ditto.
(-[WKBrowsingContextGroup removeAllUserStyleSheets]): Ditto.
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]): Ditto.
(-[WKBrowsingContextGroup removeAllUserScripts]): Ditto.
(-[WKBrowsingContextGroup _pageGroupRef]): Removed indirection via _data.

* UIProcess/API/mac/WKConnection.h: Removed _data ivar and WKConnectionData class declaration.
* UIProcess/API/mac/WKConnection.mm: Removed WKConnectionData class and moved _connectionRef
ivar directly into WKConnection, declaring it in the @implementation. Removed ivar and
accessors for the delegate property, letting the compiler synthesize them.
(-[WKConnection dealloc]): Removed indirection via _data.
(-[WKConnection sendMessageWithName:body:]): Ditto.
(-[WKConnection remoteObjectRegistry]): Ditto.
(didReceiveMessage): Ditto.
(-[WKConnection _initWithConnectionRef:]): Ditto.

* UIProcess/API/mac/WKProcessGroup.h: Replaced forward declaration of WKConnection with an
import. Removed _data ivar and WKProcessGroupData class declaration.
* UIProcess/API/mac/WKProcessGroup.mm: Removed WKProcessGroupData class and moved
_contextRef ivar directly into WKProcessGroup, declaring it in the @implementation. Removed
ivar and accessors for the delegate property, letting the compiler synthesize them.
(-[WKProcessGroup initWithInjectedBundleURL:]): Removed indirection via _data.
(-[WKProcessGroup dealloc]): Ditto.
(-[WKProcessGroup _contextRef]): Ditto.
(-[WKProcessGroup _geolocationProvider]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[MediaStream] Use std::unique_ptr instead of OwnPtr/PassOwnPtr
commit-queue@webkit.org [Mon, 25 Nov 2013 23:21:47 +0000 (23:21 +0000)]
[MediaStream] Use std::unique_ptr instead of OwnPtr/PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=124858

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.

Another step of the OwnPtr/PassOwnPtr => std::unique_ptr conversion,
now targeting mediastream-related code.

No new tests, covered by existing ones.

* Modules/mediastream/RTCDTMFSender.cpp:
* Modules/mediastream/RTCDTMFSender.h:
* Modules/mediastream/RTCDataChannel.cpp:
* Modules/mediastream/RTCDataChannel.h:
* Modules/mediastream/RTCPeerConnection.cpp:
* Modules/mediastream/RTCPeerConnection.h:
* platform/mediastream/MediaStreamSource.cpp:
* platform/mediastream/RTCPeerConnectionHandler.cpp:
* platform/mediastream/RTCPeerConnectionHandler.h:
* platform/mediastream/RTCPeerConnectionHandlerClient.h:
* platform/mock/RTCNotifiersMock.cpp:
* platform/mock/RTCPeerConnectionHandlerMock.cpp:
* platform/mock/RTCPeerConnectionHandlerMock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] WebKit version in user agent string is incorrect.
commit-queue@webkit.org [Mon, 25 Nov 2013 23:08:46 +0000 (23:08 +0000)]
[Win] WebKit version in user agent string is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=124454

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-25
Reviewed by Brent Fulgham.

Source/WebKit:

Generate WebKitVersion.h file from mac's Version.xcconfig file.

* WebKit.vcxproj/WebKit/WebKit.vcxproj:
* WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
* WebKit.vcxproj/WebKit/WebKitVersion.cmd: Added.

Source/WebKit/win:

* WebView.cpp: Use WebKit version from WebKitVersion.h in user agent.
(webKitVersionString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMediaStreamRegistry should store MediaStreams instead of MediaStreamPrivates
commit-queue@webkit.org [Mon, 25 Nov 2013 22:55:39 +0000 (22:55 +0000)]
MediaStreamRegistry should store MediaStreams instead of MediaStreamPrivates
https://bugs.webkit.org/show_bug.cgi?id=124860

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.

MediaStreamRegistry::lookup() should return a MediaStream instead of MediaStreamPrivate.

No new tests needed. No behavior changes.

* Modules/mediastream/MediaStreamRegistry.cpp:
(WebCore::MediaStreamRegistry::registerURL): m_privateStreams -> m_mediaStreams
(WebCore::MediaStreamRegistry::unregisterURL): Ditto.
(WebCore::MediaStreamRegistry::lookup): Override URLRegistry::lookup() instead of add a
new method MediaStream::lookupMediaStreamPrivate().
* Modules/mediastream/MediaStreamRegistry.h:
* html/HTMLMediaElement.cpp:
(HTMLMediaElement::loadResource): call lookup() instead of lookupMediaStreamPrivate()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCairo] Compile fails when GSTREAMER is not used.
commit-queue@webkit.org [Mon, 25 Nov 2013 22:08:33 +0000 (22:08 +0000)]
[WinCairo] Compile fails when GSTREAMER is not used.
https://bugs.webkit.org/show_bug.cgi?id=124853

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-25
Reviewed by Philippe Normand.

* platform/graphics/gstreamer/GStreamerUtilities.cpp: Don't include GStreamerUtilities.h when GSTREAMER is not used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r159740.
commit-queue@webkit.org [Mon, 25 Nov 2013 22:02:32 +0000 (22:02 +0000)]
Unreviewed, rolling out r159740.
http://trac.webkit.org/changeset/159740
https://bugs.webkit.org/show_bug.cgi?id=124859

Crashing xmlhttprequest/access-control-repeated-failed-
preflight-crash.html on Mavericks and Mountain Lion -
ASSERT(m_pageGroup) WebPage.cpp:352 (Requested by dino_ on
#webkit).

* Scripts/webkit2/messages.py:
(struct_or_class):
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* Shared/mac/ObjCObjectGraphCoders.h:
* Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::ObjCObjectGraphEncoder::baseEncode):
(WebKit::WebContextObjCObjectGraphEncoderImpl::WebContextObjCObjectGraphEncoderImpl):
(WebKit::WebContextObjCObjectGraphEncoderImpl::encode):
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):
(WebKit::WebContextObjCObjectGraphEncoder::WebContextObjCObjectGraphEncoder):
(WebKit::WebContextObjCObjectGraphEncoder::encode):
* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::encodeMessageBody):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveSyncMessage):
* UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):
* UIProcess/WebPageGroup.cpp:
* UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::postMessageToInjectedBundle):
(WebKit::WebPageProxy::initializeCreationParameters):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/WebProcessProxy.h:
* WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webPageGroup):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDeduplicate shortish Text node strings during tree construction.
akling@apple.com [Mon, 25 Nov 2013 21:53:32 +0000 (21:53 +0000)]
Deduplicate shortish Text node strings during tree construction.
<https://webkit.org/b/124855>

Let HTMLConstructionSite keep a hash set of already seen strings over
its lifetime. Use this to deduplicate the strings inside Text nodes
for any string up to 64 characters of length.

This optimization already sort-of existed for whitespace-only Texts,
but those are laundered in the AtomicString table which we definitely
don't want to pollute with every single Text. It might be a good idea
to stop using the AtomicString table for all-whitespace Text too.

3.82 MB progression on HTML5-8266 locally.

Reviewed by Anders Carlsson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderTableSection Blink merge asserting
dino@apple.com [Mon, 25 Nov 2013 21:36:10 +0000 (21:36 +0000)]
RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Skipping these tests for now, since Ossy + Laszlo checked
in a lot of rebaselines and I didn't want to roll
everything out.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unnecessary MediaStreamTrackDescriptor forward declaration
commit-queue@webkit.org [Mon, 25 Nov 2013 21:29:25 +0000 (21:29 +0000)]
Remove unnecessary MediaStreamTrackDescriptor forward declaration
https://bugs.webkit.org/show_bug.cgi?id=124854

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.

No new tests needed. No behavior changed.

* Modules/mediastream/VideoStreamTrack.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFixed a typo in the change log.
mitz@apple.com [Mon, 25 Nov 2013 20:53:27 +0000 (20:53 +0000)]
Fixed a typo in the change log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
mitz@apple.com [Mon, 25 Nov 2013 20:52:04 +0000 (20:52 +0000)]
[Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
https://bugs.webkit.org/show_bug.cgi?id=124850

Reviewed by Brady Eidson.

Source/WebKit2:

Guarded all Cocoa API headers and implementatiosn with WK_API_ENABLED. Left the WKView class
unguarded, but limited its API.

* Shared/API/Cocoa/WKFoundation.h: Replaced OBJ_VISIBLE with an explicit attribute.
* Shared/API/Cocoa/WKRemoteObjectCoder.mm: Moved #if WK_API_ENABLED before the rest of the
imports.
* Shared/API/Cocoa/WKRemoteObjectInterface.mm: Ditto.
* Shared/API/Cocoa/WKRemoteObjectRegistry.mm: Ditto.
* Shared/API/Cocoa/WKRemoteObjectRegistryPrivate.h: Ditto.
* UIProcess/API/mac/WKBrowsingContextController.h: Guarded all declarations with
WK_API_ENABLED, changed to use WK_API_CLASS instead of WK_EXPORT.
* UIProcess/API/mac/WKBrowsingContextController.mm: Guarded everything with WK_API_ENABLED.
(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController setPolicyDelegate:]):
(-[WKBrowsingContextController backForwardList]):
(didChangeBackForwardList):
(setUpPageLoaderClient):
(setUpPagePolicyClient):
(-[WKBrowsingContextController _initWithPageRef:]):
* UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Ditto.
* UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Ditto.
* UIProcess/API/mac/WKBrowsingContextGroup.h: Guarded all declarations with WK_API_ENABLED,
chanegd to use WK_API_CLASS instead of WK_EXPORT.
* UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed redundant import, guarded everything
with WK_API_ENABLED.
* UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Guarded with WK_API_ENABLED.
* UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Added necessary import.
* UIProcess/API/mac/WKConnection.h: Guarded all declarations with WK_API_ENABLED, chanegd to
use WK_API_CLASS instead of WK_EXPORT.
* UIProcess/API/mac/WKConnection.mm: Guarded everything with WK_API_ENABLED.
(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):
* UIProcess/API/mac/WKConnectionInternal.h: Guarded the delcarations with WK_API_ENABLED.
* UIProcess/API/mac/WKProcessGroup.h: Ditto. Also changed to use WK_API_CLASS instead of
WK_EXPORT.
* UIProcess/API/mac/WKProcessGroup.mm: Guarded everything with WK_API_ENABLED.
(-[WKProcessGroup initWithInjectedBundleURL:]):
* UIProcess/API/mac/WKProcessGroupPrivate.h: Guarded the declarations with WK_API_ENABLED.
* UIProcess/API/mac/WKTypeRefWrapper.h: Moved #if WK_API_ENABLED before the rest of the
imports, changed to use WK_API_CLASS instead of WK_EXPORT.
* UIProcess/API/mac/WKTypeRefWrapper.mm: Removed empty line after #import "config.h".
* UIProcess/API/mac/WKView.h: Added #if WK_API_ENABLED around API that uses other Cocoa API
types.
* UIProcess/API/mac/WKView.mm: Added #if WK_API_ENABLED around implementations of methods
that are only declared when the API is enabled.
* UIProcess/API/mac/WKViewInternal.h: Reordered imports.
* UIProcess/mac/WKFullScreenWindowController.mm: Added comment to #endif.
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformInitializeWebProcess): Guarded use of
WKBrowsingContextController with WK_API_ENABLED.
(WebKit::WebContext::platformInitializeNetworkProcess): Ditto.
* UIProcess/mac/WebContextMenuProxyMac.mm: Removed newline between imports.
* WebProcess/InjectedBundle/API/mac/WKDOMDocument.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm: Removed newline after #import
"config.h".
* WebProcess/InjectedBundle/API/mac/WKDOMElement.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMElement.mm: Removed newline after #import
"config.h".
* WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm: Ditto.
* WebProcess/InjectedBundle/API/mac/WKDOMNode.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMNode.mm: Removed redundant import.
* WebProcess/InjectedBundle/API/mac/WKDOMRange.h:  Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMRange.mm: Removed newline and redundant import.
* WebProcess/InjectedBundle/API/mac/WKDOMText.h: Moved #if WK_API_ENABLED before the
rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h: Ditto.
* WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm: Removed newline after
#import "config.h".
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h: Moved #if WK_API_ENABLED before
the rest of the imports, and changed to use WK_API_CLASS instead of WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm: Removed newline and redundant
imports.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:  Moved #if
WK_API_ENABLED before the rest of the imports, and changed to use WK_API_CLASS instead of
WK_EXPORT.
* WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm: Removed
newline after #import "config.h".

Tools:

Added #if WK_API_ENABLED guards around tests that use the Objective-C API.

* TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSet the svn:ignore property on the Xcode project to ignore the workspace and user...
mitz@apple.com [Mon, 25 Nov 2013 19:10:18 +0000 (19:10 +0000)]
Set the svn:ignore property on the Xcode project to ignore the workspace and user data.

* WebInspectorUI.xcodeproj: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove code now unnecessary after r159575
robert@webkit.org [Mon, 25 Nov 2013 18:50:36 +0000 (18:50 +0000)]
Remove code now unnecessary after r159575
https://bugs.webkit.org/show_bug.cgi?id=124809

Reviewed by Antti Koivisto.

Covered by existing tests fast/block/margin-collapse/self-collapsing-block-with-float*

* rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::skipLeadingWhitespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd complex line layout path version of empty-clear-blocks.html
robert@webkit.org [Mon, 25 Nov 2013 18:46:51 +0000 (18:46 +0000)]
Add complex line layout path version of empty-clear-blocks.html
https://bugs.webkit.org/show_bug.cgi?id=124808

Reviewed by Sam Weinig.

* fast/block/margin-collapse/empty-clear-blocks-complex-expected.html: Added.
* fast/block/margin-collapse/empty-clear-blocks-complex.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r159752 and r159754.
commit-queue@webkit.org [Mon, 25 Nov 2013 18:41:13 +0000 (18:41 +0000)]
Unreviewed, rolling out r159752 and r159754.
http://trac.webkit.org/changeset/159752
http://trac.webkit.org/changeset/159754
https://bugs.webkit.org/show_bug.cgi?id=124847

Broke linux test bots. (Requested by mhahnenberg on #webkit).

* Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
* Scripts/run-javascriptcore-tests:
* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoVertical border spacing is doubled between table row groups
ossy@webkit.org [Mon, 25 Nov 2013 18:24:56 +0000 (18:24 +0000)]
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebaseline the rest of EFL and GTK tests.

* platform/efl/tables/mozilla/bugs/bug10296-1-expected.txt:
* platform/efl/tables/mozilla/bugs/bug26178-expected.txt:
* platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt:
* platform/efl/tables/mozilla/bugs/bug278385-expected.txt:
* platform/efl/tables/mozilla/bugs/bug55789-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
* platform/efl/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
* platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/efl/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
* platform/efl/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
* platform/efl/tables/mozilla_expected_failures/other/test4-expected.txt:
* platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
* platform/gtk/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFollowup fix after r159752
mhahnenberg@apple.com [Mon, 25 Nov 2013 18:02:58 +0000 (18:02 +0000)]
Followup fix after r159752

* Scripts/run-jsc-stress-tests: We need to handle Release builds too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoVertical border spacing is doubled between table row groups
ossy@webkit.org [Mon, 25 Nov 2013 17:34:35 +0000 (17:34 +0000)]
Vertical border spacing is doubled between table row groups
https://bugs.webkit.org/show_bug.cgi?id=20040

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-25
Reviewed by Csaba Osztrogonác.

Rebaseline efl tests (+mac corrections).

* platform/efl/fast/forms/input-align-expected.png:
* platform/efl/fast/forms/input-align-expected.txt:
* platform/efl/fast/forms/input-value-expected.png:
* platform/efl/fast/forms/input-value-expected.txt:
* platform/efl/fast/table/border-collapsing/004-vertical-expected.png:
* platform/efl/fast/table/border-collapsing/004-vertical-expected.txt:
* platform/efl/fast/table/floating-th-expected.png:
* platform/efl/fast/table/floating-th-expected.txt:
* platform/efl/fast/table/frame-and-rules-expected.png:
* platform/efl/fast/table/frame-and-rules-expected.txt:
* platform/efl/fast/table/multiple-captions-display-expected.png:
* platform/efl/fast/table/multiple-captions-display-expected.txt:
* platform/efl/fast/table/rowindex-expected.png:
* platform/efl/fast/table/rowindex-expected.txt:
* platform/efl/fast/table/table-display-types-expected.png:
* platform/efl/fast/table/table-display-types-expected.txt:
* platform/efl/fast/table/table-display-types-strict-expected.png:
* platform/efl/fast/table/table-display-types-strict-expected.txt:
* platform/efl/fast/table/table-display-types-vertical-expected.png:
* platform/efl/fast/table/table-display-types-vertical-expected.txt:
* platform/efl/tables/mozilla/bugs/bug119786-expected.png:
* platform/efl/tables/mozilla/bugs/bug119786-expected.txt:
* platform/efl/tables/mozilla/bugs/bug13118-expected.png:
* platform/efl/tables/mozilla/bugs/bug13118-expected.txt:
* platform/efl/tables/mozilla/bugs/bug19061-1-expected.png:
* platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt:
* platform/efl/tables/mozilla/bugs/bug19061-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt:
* platform/efl/tables/mozilla/bugs/bug220536-expected.png:
* platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
* platform/efl/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt:
* platform/efl/tables/mozilla/bugs/bug27038-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug27038-3-expected.txt: Added.
* platform/efl/tables/mozilla/bugs/bug30418-expected.png:
* platform/efl/tables/mozilla/bugs/bug30418-expected.txt:
* platform/efl/tables/mozilla/bugs/bug3263-expected.png:
* platform/efl/tables/mozilla/bugs/bug3263-expected.txt:
* platform/efl/tables/mozilla/bugs/bug38916-expected.png:
* platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
* platform/efl/tables/mozilla/bugs/bug46268-3-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-3-expected.txt:
* platform/efl/tables/mozilla/bugs/bug46268-5-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-5-expected.txt:
* platform/efl/tables/mozilla/bugs/bug46268-expected.png:
* platform/efl/tables/mozilla/bugs/bug46268-expected.txt:
* platform/efl/tables/mozilla/bugs/bug46924-expected.png:
* platform/efl/tables/mozilla/bugs/bug46924-expected.txt:
* platform/efl/tables/mozilla/bugs/bug57378-expected.png:
* platform/efl/tables/mozilla/bugs/bug57378-expected.txt:
* platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.png:
* platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_position-table-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_position-table-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
* platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
* platform/efl/tables/mozilla/marvin/body_tfoot-expected.png:
* platform/efl/tables/mozilla/marvin/body_tfoot-expected.txt:
* platform/efl/tables/mozilla/marvin/body_thead-expected.png:
* platform/efl/tables/mozilla/marvin/body_thead-expected.txt:
* platform/efl/tables/mozilla/marvin/table_rules_groups-expected.png:
* platform/efl/tables/mozilla/marvin/table_rules_groups-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_char-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_char-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_char-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_char-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/thead_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_char-expected.png:
* platform/efl/tables/mozilla/marvin/thead_char-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/thead_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table-expected.png:
* platform/efl/tables/mozilla/marvin/x_table-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table_border-expected.png:
* platform/efl/tables/mozilla/marvin/x_table_border-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table_border_none-expected.png:
* platform/efl/tables/mozilla/marvin/x_table_border_none-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table_border_px-expected.png:
* platform/efl/tables/mozilla/marvin/x_table_border_px-expected.txt:
* platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.png:
* platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_class-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_class-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_id-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_id-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_style-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_style-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
* platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.png:
* platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
* platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
* platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
* platform/mac-mountainlion/fast/forms/input-value-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:
* platform/mac/fast/forms/input-value-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159753 268f45cc-cd09-0410-ab3c-d52691b4dbfc