WebKit-https.git
6 years ago[Mac] Remove the MiniBrowser injected bundle
mitz@apple.com [Sun, 1 Dec 2013 17:03:43 +0000 (17:03 +0000)]
[Mac] Remove the MiniBrowser injected bundle
https://bugs.webkit.org/show_bug.cgi?id=125041

Reviewed by Anders Carlsson.

It had no ops!

* MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
* MiniBrowser/mac/WebBundle/Info.plist: Removed.
* MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK build fix after r159896.
philn@webkit.org [Sun, 1 Dec 2013 13:45:49 +0000 (13:45 +0000)]
Unreviewed GTK build fix after r159896.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextCreatePageForWebView):
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed):
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseUpdatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after r159896.
ryuan.choi@samsung.com [Sun, 1 Dec 2013 08:07:41 +0000 (08:07 +0000)]
Unreviewed build fix after r159896.

* UIProcess/API/efl/ewk_settings.cpp:
(EwkSettings::preferences):
* UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:
(WebKit::CoordinatedDrawingAreaProxy::CoordinatedDrawingAreaProxy):
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::WebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Implement scrollbarThickness for opaque scrollbar
ryuan.choi@samsung.com [Sun, 1 Dec 2013 07:05:42 +0000 (07:05 +0000)]
[EFL] Implement scrollbarThickness for opaque scrollbar
https://bugs.webkit.org/show_bug.cgi?id=125034

Reviewed by Gyuyoung Kim.

Implemented scrollbarThickness to support opaque scrollbar.
Now, edj can decide whether to support opaque scrollbar by adding scrollbar.thickness.
In addition, added OVERRIDE/FINAL keyword and removed unnecessary destructor
in ScrollbarThemeEfl.cpp.

No new tests, no behavior changes with default theme.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::loadTheme):
Update thickness of scrollbar when theme was loaded.
* platform/efl/ScrollbarThemeEfl.cpp:
* platform/efl/ScrollbarThemeEfl.h:
(WebCore::ScrollbarThemeEfl::setScrollbarThickness):
(WebCore::ScrollbarThemeEfl::scrollbarThickness):
(WebCore::ScrollbarThemeEfl::registerScrollbar):
(WebCore::ScrollbarThemeEfl::unregisterScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CTTE] The WebPageProxy's WebPageGroup is never null so it should be stored in a Ref
weinig@apple.com [Sun, 1 Dec 2013 06:40:24 +0000 (06:40 +0000)]
[CTTE] The WebPageProxy's WebPageGroup is never null so it should be stored in a Ref
https://bugs.webkit.org/show_bug.cgi?id=125038

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKPage.cpp:
(WKPageGetPageGroup):
* UIProcess/API/C/mac/WKPagePrivateMac.cpp:
(WKPageIsURLKnownHSTSHost):
* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController browsingContextGroup]):
* UIProcess/API/mac/WKView.mm:
(-[WKView _preferencesDidChange]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::createWebPage):
* UIProcess/WebContext.h:
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorPageGroups::inspectorLevel):
(WebKit::WebInspectorPageGroups::isInspectorPageGroup):
(WebKit::WebInspectorPageGroups::inspectorPageGroupLevel):
(WebKit::WebInspectorProxy::isInspectorPage):
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::createNonNull):
* UIProcess/WebPageGroup.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::maybeInitializeSandboxExtensionHandle):
(WebKit::WebPageProxy::preferencesDidChange):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageGroup):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/WebProcessProxy.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::windowFrameDidChange):
* UIProcess/mac/WebProcessProxyMac.mm:
(WebKit::WebProcessProxy::pageIsProcessSuppressible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded a version of +[NSURL _web_URLWithWTFString:relativeToURL:] that doesn’t take...
mitz@apple.com [Sun, 1 Dec 2013 06:24:05 +0000 (06:24 +0000)]
Added a version of +[NSURL _web_URLWithWTFString:relativeToURL:] that doesn’t take a base URL and switched all callers to it.
https://bugs.webkit.org/show_bug.cgi?id=125040

Reviewed by Sam Weinig.

* Shared/Cocoa/WKNSURLExtras.h: Declared new method.
* Shared/Cocoa/WKNSURLExtras.mm:
(urlWithWTFString): Added helper function.
(+[NSURL _web_URLWithWTFString:]): Added.
(+[NSURL _web_URLWithWTFString:relativeToURL:]): Changed to use helper function.
* UIProcess/API/Cocoa/WKBackForwardListItem.mm:
(-[WKBackForwardListItem URL]): Changed to call new method.
(-[WKBackForwardListItem originalURL]): Ditto.
* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController unreachableURL]): Ditto.
(setUpPagePolicyClient): Ditto.
* UIProcess/API/Cocoa/WKNavigationData.mm:
(-[WKNavigationData destinationURL]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] Stop using the WKPageRef API in WKBrowsingContextController
mitz@apple.com [Sun, 1 Dec 2013 06:02:32 +0000 (06:02 +0000)]
[Cocoa] Stop using the WKPageRef API in WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=125036

Reviewed by Sam Weinig.

* Shared/Cocoa/WKNSURLExtras.h: Declared new method.
* Shared/Cocoa/WKNSURLExtras.mm:
(-[NSURL _web_originalDataAsWTFString]): Added. Returns a WTF::String with the receiver’s
bytes.

* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadRequest:userData:]):
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]):
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]):
(-[WKBrowsingContextController loadAlternateHTMLString:baseURL:forUnreachableURL:]):
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
(-[WKBrowsingContextController stopLoading]):
(-[WKBrowsingContextController reload]):
(-[WKBrowsingContextController reloadFromOrigin]):
(-[WKBrowsingContextController goForward]):
(-[WKBrowsingContextController canGoForward]):
(-[WKBrowsingContextController goBack]):
(-[WKBrowsingContextController canGoBack]):
(-[WKBrowsingContextController activeURL]):
(-[WKBrowsingContextController provisionalURL]):
(-[WKBrowsingContextController committedURL]):
(-[WKBrowsingContextController title]):
(-[WKBrowsingContextController textZoom]):
(-[WKBrowsingContextController setTextZoom:]):
(-[WKBrowsingContextController pageZoom]):
(-[WKBrowsingContextController setPageZoom:]):
(setUpPageLoaderClient):
(setUpPagePolicyClient):
(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController setPolicyDelegate:]):
(-[WKBrowsingContextController _pageRef]):
(-[WKBrowsingContextController setPaginationMode:]):
(-[WKBrowsingContextController paginationMode]):
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]):
(-[WKBrowsingContextController paginationBehavesLikeColumns]):
(-[WKBrowsingContextController setPageLength:]):
(-[WKBrowsingContextController pageLength]):
(-[WKBrowsingContextController setGapBetweenPages:]):
(-[WKBrowsingContextController gapBetweenPages]):
(-[WKBrowsingContextController pageCount]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r159865.
commit-queue@webkit.org [Sun, 1 Dec 2013 03:52:23 +0000 (03:52 +0000)]
Unreviewed, rolling out r159865.
http://trac.webkit.org/changeset/159865
https://bugs.webkit.org/show_bug.cgi?id=125037

the position of mouse events are wrong at MiniBrowser/efl
(Requested by ryuan on #webkit).

* UIProcess/API/efl/EwkView.cpp:
(EwkView::displayTimerFired):
(EwkView::createGLSurface):
(EwkView::handleEvasObjectCalculate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Some JavaScript date tests are failing.
commit-queue@webkit.org [Sun, 1 Dec 2013 03:33:39 +0000 (03:33 +0000)]
[Win] Some JavaScript date tests are failing.
https://bugs.webkit.org/show_bug.cgi?id=124946

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-30
Reviewed by Brent Fulgham.

Use native Win32 api functions to compute Daylight saving time offset.

* wtf/DateMath.cpp:
(WTF::UnixTimeToFileTime): Added method to calculate Win32 specific struct FILETIME from time_t value.
(WTF::calculateDSTOffset): Use native Win32 api functions to compute Daylight saving time offset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CTTE] The WebPageProxy's WebBackForwardList is never null so it should be stored...
weinig@apple.com [Sun, 1 Dec 2013 02:25:39 +0000 (02:25 +0000)]
[CTTE] The WebPageProxy's WebBackForwardList is never null so it should be stored in a Ref
https://bugs.webkit.org/show_bug.cgi?id=125035

Reviewed by Dan Bernstein.

* UIProcess/API/C/WKPage.cpp:
(WKPageGetBackForwardList):
* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController backForwardList]): Remove null check.
* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::currentItem): Constify.
(WebKit::WebBackForwardList::backItem): Constify.
(WebKit::WebBackForwardList::forwardItem): Constify.
(WebKit::WebBackForwardList::itemAtIndex): Constify.
* UIProcess/WebBackForwardList.h:
(WebKit::WebBackForwardList::create):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::backForwardList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK build fix after r159889.
zandobersek@gmail.com [Sat, 30 Nov 2013 20:15:46 +0000 (20:15 +0000)]
Unreviewed GTK build fix after r159889.

* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::viewWidget): Adjust the static cast of the PageClient reference to PageClientImpl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CTTE] WebPageProxy should store the PageClient as a reference
weinig@apple.com [Sat, 30 Nov 2013 19:14:13 +0000 (19:14 +0000)]
[CTTE] WebPageProxy should store the PageClient as a reference
https://bugs.webkit.org/show_bug.cgi?id=125030

Reviewed by Dan Bernstein.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCreateWebPage):
* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
* UIProcess/CoordinatedGraphics/WebPageProxyCoordinatedGraphics.cpp:
(WebKit::WebPageProxy::didFindZoomableArea):
* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::WebView):
* UIProcess/WebContext.cpp:
(WebKit::WebContext::createWebPage):
* UIProcess/WebContext.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::setViewNeedsDisplay):
(WebKit::WebPageProxy::displayView):
(WebKit::WebPageProxy::canScrollView):
(WebKit::WebPageProxy::scrollView):
(WebKit::WebPageProxy::updateViewState):
(WebKit::WebPageProxy::viewStateDidChange):
(WebKit::WebPageProxy::viewSize):
(WebKit::WebPageProxy::startDrag):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::closePage):
(WebKit::WebPageProxy::setWindowFrame):
(WebKit::WebPageProxy::getWindowFrame):
(WebKit::WebPageProxy::screenToWindow):
(WebKit::WebPageProxy::windowToScreen):
(WebKit::WebPageProxy::pageDidRequestScroll):
(WebKit::WebPageProxy::pageTransitionViewportReady):
(WebKit::WebPageProxy::didRenderFrame):
(WebKit::WebPageProxy::didChangeViewportProperties):
(WebKit::WebPageProxy::handleDownloadRequest):
(WebKit::WebPageProxy::didChangeContentSize):
(WebKit::WebPageProxy::showColorPicker):
(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::canUndoRedo):
(WebKit::WebPageProxy::executeUndoRedo):
(WebKit::WebPageProxy::clearAllEditCommands):
(WebKit::WebPageProxy::setFindIndicator):
(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::internalShowContextMenu):
(WebKit::WebPageProxy::registerEditCommand):
(WebKit::WebPageProxy::setToolTip):
(WebKit::WebPageProxy::setCursor):
(WebKit::WebPageProxy::setCursorHiddenUntilMouseMoves):
(WebKit::WebPageProxy::didReceiveEvent):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
(WebKit::WebPageProxy::initializeCreationParameters):
(WebKit::WebPageProxy::enterAcceleratedCompositingMode):
(WebKit::WebPageProxy::exitAcceleratedCompositingMode):
(WebKit::WebPageProxy::updateAcceleratedCompositingMode):
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):
(WebKit::WebPageProxy::recommendedScrollbarStyleDidChange):
(WebKit::WebPageProxy::updateBackingStoreDiscardableState):
(WebKit::WebPageProxy::showCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanel):
(WebKit::WebPageProxy::dismissCorrectionPanelSoon):
(WebKit::WebPageProxy::recordAutocorrectionResponse):
(WebKit::WebPageProxy::showDictationAlternativeUI):
(WebKit::WebPageProxy::removeDictationAlternatives):
(WebKit::WebPageProxy::dictationAlternatives):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/WebProcessProxy.h:
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::getEditorCommandsForKeyEvent):
* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::mainDocumentDidReceiveMobileDocType):
(WebKit::WebPageProxy::didGetTapHighlightGeometries):
(WebKit::WebPageProxy::didChangeViewportArguments):
(WebKit::WebPageProxy::startAssistingNode):
(WebKit::WebPageProxy::stopAssistingNode):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::insertDictatedText):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::setPromisedData):
(WebKit::WebPageProxy::interpretQueuedKeyEvent):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::makeFirstResponder):
(WebKit::WebPageProxy::colorSpace):
(WebKit::WebPageProxy::pluginFocusOrWindowFocusChanged):
(WebKit::WebPageProxy::setPluginComplexTextInputState):
(WebKit::WebPageProxy::executeSavedCommandBySelector):
(WebKit::WebPageProxy::wkView):
(WebKit::WebPageProxy::intrinsicContentSizeDidChange):
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[RTTE] The PermissionRequestManagerProxies should use WebPageProxy references.
weinig@apple.com [Sat, 30 Nov 2013 18:55:27 +0000 (18:55 +0000)]
[RTTE] The PermissionRequestManagerProxies should use WebPageProxy references.
https://bugs.webkit.org/show_bug.cgi?id=125029

Reviewed by Dan Bernstein.

* UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
(WebKit::GeolocationPermissionRequestManagerProxy::GeolocationPermissionRequestManagerProxy):
(WebKit::GeolocationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision):
* UIProcess/GeolocationPermissionRequestManagerProxy.h:
* UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:
(WebKit::NotificationPermissionRequestManagerProxy::NotificationPermissionRequestManagerProxy):
(WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests):
(WebKit::NotificationPermissionRequestManagerProxy::didReceiveNotificationPermissionDecision):
* UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Do some additional modernization while we are here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<rdar://problem/15560240> ResourceError encoding drops NSURL-valued keys in the NSErr...
mitz@apple.com [Sat, 30 Nov 2013 18:49:53 +0000 (18:49 +0000)]
<rdar://problem/15560240> ResourceError encoding drops NSURL-valued keys in the NSError’s userInfo, including NSErrorFailingURLKey
https://bugs.webkit.org/show_bug.cgi?id=125016

Reviewed by Anders “happy name day” Carlsson.

* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::encodePlatformData): Encode all string- and URL-valued keys as a dictionary.
(CoreIPC::::decodePlatformData): Decode user info as a dictionary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFinally remove those DFG_ENABLE things
fpizlo@apple.com [Sat, 30 Nov 2013 17:23:32 +0000 (17:23 +0000)]
Finally remove those DFG_ENABLE things
https://bugs.webkit.org/show_bug.cgi?id=125025

Rubber stamped by Sam Weinig.

This removes a bunch of unused and untested insanity.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::tallyFrequentExitSites):
* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getArrayModeConsideringSlowPath):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):
* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::convertToJump):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGCommon.h:
(JSC::DFG::verboseCompilationEnabled):
(JSC::DFG::logCompilationChanges):
(JSC::DFG::shouldDumpGraphAtEachPhase):
* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
* dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::initialize):
(JSC::DFG::InPlaceAbstractState::endBasicBlock):
(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):
(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::link):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::adjustAndJumpToTarget):
* dfg/DFGPredictionInjectionPhase.cpp:
(JSC::DFG::PredictionInjectionPhase::run):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::propagateForward):
(JSC::DFG::PredictionPropagationPhase::propagateBackward):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
* dfg/DFGScoreBoard.h:
(JSC::DFG::ScoreBoard::use):
* dfg/DFGSlowPathGenerator.h:
(JSC::DFG::SlowPathGenerator::generate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
* dfg/DFGVariableEventStream.h:
(JSC::DFG::VariableEventStream::appendAndLog):
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
* jit/JIT.cpp:
(JSC::JIT::privateCompile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<https://webkit.org/b/125027> Update the analytics account used by webkit.org
mrowe@apple.com [Sat, 30 Nov 2013 17:05:06 +0000 (17:05 +0000)]
<https://webkit.org/b/125027> Update the analytics account used by webkit.org

Switch to a Google Analytics id that's accessible to someone that's involved with the WebKit project.

Reviewed by Sam Weinig.

* footer.inc: Remove the old analytics code.
* header.inc: Add the new stuff.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix for EFL and GTK WK2 builds.
zandobersek@gmail.com [Sat, 30 Nov 2013 07:41:14 +0000 (07:41 +0000)]
Unreviewed build fix for EFL and GTK WK2 builds.

* Scripts/generate-forwarding-headers.pl: Add Cocoa to the list of platform prefixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFTL IC should nop-fill to make up the difference between the actual IC size and the...
fpizlo@apple.com [Sat, 30 Nov 2013 04:17:29 +0000 (04:17 +0000)]
FTL IC should nop-fill to make up the difference between the actual IC size and the requested patchpoint size
https://bugs.webkit.org/show_bug.cgi?id=124960

Reviewed by Sam Weinig.

* assembler/LinkBuffer.h:
(JSC::LinkBuffer::size):
* assembler/X86Assembler.h:
(JSC::X86Assembler::fillNops):
* dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::dumpHeader):
* ftl/FTLCompile.cpp:
(JSC::FTL::generateICFastPath):
* jit/JITDisassembler.cpp:
(JSC::JITDisassembler::dumpHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build warnings in WebKit2
commit-queue@webkit.org [Sat, 30 Nov 2013 04:13:42 +0000 (04:13 +0000)]
Fix build warnings in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=125012

Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-29
Reviewed by Anders Carlsson.

fix unused parameter warnings in the following files:

* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::SocketEventSource::eventCallback):
* Shared/API/c/WKDeprecatedFunctions.cpp:
(WKArrayIsMutable):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::unavailablePluginButtonClicked):
(WebKit::WebChromeClient::didAddHeaderLayer):
(WebKit::WebChromeClient::didAddFooterLayer):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] Add a little template magic to the inline API::Object storage to remove the...
weinig@apple.com [Sat, 30 Nov 2013 02:04:12 +0000 (02:04 +0000)]
[Cocoa] Add a little template magic to the inline API::Object storage to remove the need for all the reinterpret_casts
https://bugs.webkit.org/show_bug.cgi?id=125024

Reviewed by Dan Bernstein.

Introduce API::ObjectStorage which wraps std::aligned_storage and adds some convenience functions
to reinterpret the data as the corresponding type. Deploy it everywhere we were previously using
std::aligned_storage.

* Shared/Cocoa/WKNSArray.mm:
* Shared/Cocoa/WKNSDictionary.mm:
* Shared/Cocoa/WKObject.h:
* UIProcess/API/Cocoa/WKBackForwardList.mm:
* UIProcess/API/Cocoa/WKBackForwardListItem.mm:
* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
* UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
* UIProcess/API/Cocoa/WKNavigationData.mm:
* UIProcess/API/Cocoa/WKProcessGroup.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix crashing API tests.
weinig@apple.com [Sat, 30 Nov 2013 01:46:44 +0000 (01:46 +0000)]
Fix crashing API tests.

* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix some style boo-boos.
weinig@apple.com [Sat, 30 Nov 2013 00:56:53 +0000 (00:56 +0000)]
Fix some style boo-boos.

* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController policyDelegate]):
(-[WKBrowsingContextController setPolicyDelegate:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the iOS build.
weinig@apple.com [Sat, 30 Nov 2013 00:53:39 +0000 (00:53 +0000)]
Fix the iOS build.

* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadDelegate]):
(-[WKBrowsingContextController policyDelegate]):
(-[WKBrowsingContextController setPolicyDelegate:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] Make WKBrowsingContextController work with WKObject wrapping
weinig@apple.com [Sat, 30 Nov 2013 00:27:38 +0000 (00:27 +0000)]
[Cocoa] Make WKBrowsingContextController work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=125022

Reviewed by Dan Bernstein.

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):

* Shared/mac/ObjCObjectGraphCoders.mm:
Add support for WKProcessGroup.

(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
Replace call to _browsingContextControllerForPageRef: with wrapper.

* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline.

(-[WKBrowsingContextController dealloc]):
Add explicit destructor call.

(-[WKBrowsingContextController setLoadDelegate:]):
(-[WKBrowsingContextController setPolicyDelegate:]):
Lazily set up the load and policy clients only once a delegate has been set to allow
continued use of the C-SPI clients for WebKitTestRunner.

(-[WKBrowsingContextController _finishInitialization]):
Move remaining work that was done in the initialize (setting up the observer) here,
and have the WebPageProxy call it.

* UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:
(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol. Remove no longer used
_initWithPageRef: and _browsingContextControllerForPageRef: helpers.

* UIProcess/API/Cocoa/WKProcessGroup.mm:
(didNavigateWithNavigationData):
(didPerformClientRedirect):
(didPerformServerRedirect):
(didUpdateHistoryTitle):
Switch to using wrapper().

* UIProcess/API/ios/WKContentView.mm:
* UIProcess/API/mac/WKView.mm:
Stop caching the WKBrowsingContextController, as it no long makes sense since it is the same object
as the WebPageProxy.

* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::platformInitialize):
Inform the wrapper that it is safe to finish initialization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] Add a way to recover from load errors
mitz@apple.com [Fri, 29 Nov 2013 23:21:08 +0000 (23:21 +0000)]
[Cocoa] Add a way to recover from load errors
https://bugs.webkit.org/show_bug.cgi?id=125020

Reviewed by Sam Weinig.

* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(createErrorWithRecoveryAttempter): Added this helper function. It creates an NSError from
the given error, adding two keys to the user info dictionary: the context controller under
the recovery attempter key, and the frame under a private key.
(didFailProvisionalLoadWithErrorForFrame): Changed to use createErrorWithRecoveryAttempter.
(didFailLoadWithErrorForFrame): Ditto.
(-[WKBrowsingContextController attemptRecoveryFromError:]): Implemented this
WKErrorRecoveryAttempting protocol method by loading the failing URL from the error into the
frame from the error.

* UIProcess/API/Cocoa/WKErrorRecoveryAttempting.h: Added. Defines a protocol for attempting
recovery from errors and declares the error user info dictionary key under which an object
conforming to this protocol may be stored.
* UIProcess/API/Cocoa/WKErrorRecoveryAttempting.m: Added. Defines
WKRecoveryAttempterErrorKey.

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::loadURL): Added. Sends the LoadURLInFrame message to the page.
* UIProcess/WebFrameProxy.h:

* WebKit2.xcodeproj/project.pbxproj: Added references to new files.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadURLInFrame): Added. Loads the URL in the given frame.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Added LoadURLInFrame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Cocoa] Expose loadAlternateHTMLString via the API
mitz@apple.com [Fri, 29 Nov 2013 21:15:28 +0000 (21:15 +0000)]
[Cocoa] Expose loadAlternateHTMLString via the API
https://bugs.webkit.org/show_bug.cgi?id=125019

Reviewed by Sam Weinig.

* UIProcess/API/Cocoa/WKBrowsingContextController.h: Declared new method.
* UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadAlternateHTMLString:baseURL:forUnreachableURL:]): Added.
Calls WebPageProxy::loadAlternateHTMLString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove API files shared between Mac and iOS to the Cocoa directory
weinig@apple.com [Fri, 29 Nov 2013 20:54:46 +0000 (20:54 +0000)]
Move API files shared between Mac and iOS to the Cocoa directory
https://bugs.webkit.org/show_bug.cgi?id=125017

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKBrowsingContextController.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.h.
* UIProcess/API/Cocoa/WKBrowsingContextController.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm.
* UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h.
* UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerPrivate.h.
* UIProcess/API/Cocoa/WKBrowsingContextGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.h.
* UIProcess/API/Cocoa/WKBrowsingContextGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm.
* UIProcess/API/Cocoa/WKBrowsingContextGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h.
* UIProcess/API/Cocoa/WKBrowsingContextGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupPrivate.h.
* UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextLoadDelegate.h.
* UIProcess/API/Cocoa/WKBrowsingContextPolicyDelegate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h.
* UIProcess/API/Cocoa/WKConnection.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.h.
* UIProcess/API/Cocoa/WKConnection.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKConnection.mm.
* UIProcess/API/Cocoa/WKConnectionInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKConnectionInternal.h.
* UIProcess/API/Cocoa/WKProcessGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h.
* UIProcess/API/Cocoa/WKProcessGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm.
* UIProcess/API/Cocoa/WKProcessGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h.
* UIProcess/API/Cocoa/WKProcessGroupPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessGroupPrivate.h.
* UIProcess/API/Cocoa/WKTypeRefWrapper.h: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.h.
* UIProcess/API/Cocoa/WKTypeRefWrapper.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKTypeRefWrapper.mm.
* UIProcess/API/Cocoa/WKView.h: Copied from Source/WebKit2/UIProcess/API/mac/WKView.h.
* UIProcess/API/Cocoa/WKViewPrivate.h: Copied from Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h.
* UIProcess/API/Cocoa/WebKit2.h: Copied from Source/WebKit2/UIProcess/API/mac/WebKit2.h.
* UIProcess/API/mac/WKBrowsingContextController.h: Removed.
* UIProcess/API/mac/WKBrowsingContextController.mm: Removed.
* UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Removed.
* UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Removed.
* UIProcess/API/mac/WKBrowsingContextGroup.h: Removed.
* UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed.
* UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Removed.
* UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Removed.
* UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Removed.
* UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Removed.
* UIProcess/API/mac/WKConnection.h: Removed.
* UIProcess/API/mac/WKConnection.mm: Removed.
* UIProcess/API/mac/WKConnectionInternal.h: Removed.
* UIProcess/API/mac/WKProcessGroup.h: Removed.
* UIProcess/API/mac/WKProcessGroup.mm: Removed.
* UIProcess/API/mac/WKProcessGroupInternal.h: Removed.
* UIProcess/API/mac/WKProcessGroupPrivate.h: Removed.
* UIProcess/API/mac/WKTypeRefWrapper.h: Removed.
* UIProcess/API/mac/WKTypeRefWrapper.mm: Removed.
* UIProcess/API/mac/WKView.h: Removed.
* UIProcess/API/mac/WKViewPrivate.h: Removed.
* UIProcess/API/mac/WebKit2.h: Removed.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64...
commit-queue@webkit.org [Fri, 29 Nov 2013 17:25:55 +0000 (17:25 +0000)]
Use moveDoubleToInts in SpecializedThunkJIT::returnDouble for non-X86 JSVALUE32_64 ports.
https://bugs.webkit.org/show_bug.cgi?id=124936

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

The moveDoubleToInts implementations in ARM, MIPS and SH4 macro assemblers do not clobber
src FPRegister and are likely to be more efficient than the current generic implementation
using the stack.

* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agocheck-webkit-style should check for extraneous newline between config.h and primary...
commit-queue@webkit.org [Fri, 29 Nov 2013 14:32:53 +0000 (14:32 +0000)]
check-webkit-style should check for extraneous newline between config.h and primary header.
https://bugs.webkit.org/show_bug.cgi?id=124821

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-11-29
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_include_line):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(OrderOfIncludesTest.test_check_line_break_after_own_header):
(OrderOfIncludesTest):
(OrderOfIncludesTest.test_check_line_break_before_own_header):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMerge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions.
commit-queue@webkit.org [Fri, 29 Nov 2013 14:16:18 +0000 (14:16 +0000)]
Merge arm and sh4 paths in nativeForGenerator and privateCompileCTINativeCall functions.
https://bugs.webkit.org/show_bug.cgi?id=124892

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::call): Pick a scratch register instead of getting it as a
parameter. The sh4 port was the only one to have this call(Address, RegisterID) prototype.
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall): Use argumentGPRx and merge arm and sh4 paths.
* jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator): Use argumentGPRx and merge arm and sh4 paths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Fri, 29 Nov 2013 12:23:14 +0000 (12:23 +0000)]
Unreviewed EFL gardening

Accessibility rebaselines after r159848.

* platform/efl-wk1/accessibility/table-detection-expected.txt:
* platform/efl-wk2/accessibility/table-detection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Symbian specific code.
commit-queue@webkit.org [Fri, 29 Nov 2013 12:06:14 +0000 (12:06 +0000)]
Remove Symbian specific code.
https://bugs.webkit.org/show_bug.cgi?id=124939

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-11-29
Reviewed by Zoltan Herczeg.

Symbian is not supported, remove leftover code.

* plugins/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agotest-webkit-scripts should show the failing tests and use an appropriate exit code
ossy@webkit.org [Fri, 29 Nov 2013 11:41:02 +0000 (11:41 +0000)]
test-webkit-scripts should show the failing tests and use an appropriate exit code
https://bugs.webkit.org/show_bug.cgi?id=124840

Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-29
Reviewed by Ryosuke Niwa.

A fixme in test-webkit-scripts asked that the script should display success or failiure
and exit with a 0 or 1 value accordingly after all of the tests have completed.

* Scripts/test-webkit-scripts:
(ScriptsTester.run_test_script):
The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
because at this point we don't need to pass on more information other than success or failiure.
(ScriptsTester.main):
The return values are now stored for each script and when all tests have completed successfully,
the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
commit-queue@webkit.org [Fri, 29 Nov 2013 11:38:18 +0000 (11:38 +0000)]
[ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
https://bugs.webkit.org/show_bug.cgi?id=124923

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-29
Reviewed by Mario Sanchez Prada.

Tools:

Added missing implementation of isAttributeSettable. Using
ATK_STATE_EDITABLE for checking whether attribute is settable.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isAttributeSettable):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isAttributeSettable):

LayoutTests:

Test could be reused by EFL and GTK as well.

* accessibility/content-editable-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/content-editable-expected.txt.
* accessibility/content-editable.html: Renamed from LayoutTests/platform/mac/accessibility/content-editable.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[cmake] Fix cmake warning: Argument not separated from preceding token by whitespace
commit-queue@webkit.org [Fri, 29 Nov 2013 10:51:50 +0000 (10:51 +0000)]
[cmake] Fix cmake warning: Argument not separated from preceding token by whitespace
https://bugs.webkit.org/show_bug.cgi?id=124899

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-29
Reviewed by Gyuyoung Kim.

* Source/cmake/FindCairo.cmake:
* Source/cmake/FindGStreamer.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] viewport must be same with the size of webview
commit-queue@webkit.org [Fri, 29 Nov 2013 08:37:31 +0000 (08:37 +0000)]
[EFL] viewport must be same with the size of webview
https://bugs.webkit.org/show_bug.cgi?id=124965

Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2013-11-29
Reviewed by Gyuyoung Kim.

Currently, size of the viewport is larger than size of webview.
Changed the size of viewport with size of webview, because viewport is translated by wrong calculation.

* UIProcess/API/efl/EwkView.cpp:
(EwkView::displayTimerFired): Changed to use the (0,0).
(EwkView::createGLSurface): Modified to use the viewSize instead of the boundsEnd.
(EwkView::handleEvasObjectCalculate): Removed the WKViewSetUserViewportTranslation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CoordinatedGraphics][WK2] Correct wrong usage of m_contentPosition variable in the...
commit-queue@webkit.org [Fri, 29 Nov 2013 07:51:24 +0000 (07:51 +0000)]
[CoordinatedGraphics][WK2] Correct wrong usage of m_contentPosition variable in the WebView.
https://bugs.webkit.org/show_bug.cgi?id=118548

Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-11-28
Reviewed by Noam Rosenthal.

CoordinatedGraphics uses its own scaling logic - contents scaling - and
WebView of CoordinatedGraphics maintains contents position by scaling
with contents scaling factor.
However transformToScene() and updateViewportSize() of WebView regard
the contents position as a non-scaled value, so it should be fixed.

* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::transformToScene):
(WebKit::WebView::updateViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] PageViewportController does not need to be unique_ptr instance
ryuan.choi@samsung.com [Fri, 29 Nov 2013 03:42:04 +0000 (03:42 +0000)]
[EFL] PageViewportController does not need to be unique_ptr instance
https://bugs.webkit.org/show_bug.cgi?id=124993

Reviewed by Gyuyoung Kim.

PageViewportController and PageViewportControllerEfl have same life cycle
with EwkView. So, we don't need to make them as unique_ptr instance.

* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::handleEvasObjectCalculate):
(EwkView::scrollBy):
* UIProcess/API/efl/EwkView.h:
(EwkView::pageViewportController):
* UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
* UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeContentsSize):
(WebKit::ViewClientEfl::didChangeContentsPosition):
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didCompletePageTransition):
(WebKit::ViewClientEfl::didChangeViewportAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Build fix after r159859
commit-queue@webkit.org [Fri, 29 Nov 2013 01:35:45 +0000 (01:35 +0000)]
[GTK] Build fix after r159859
https://bugs.webkit.org/show_bug.cgi?id=124992

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-28
Reviewed by Gyuyoung Kim.

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::didCommitLoadForMainFrame): Added.
* UIProcess/API/gtk/PageClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Build fix after r159859
jinwoo7.song@samsung.com [Fri, 29 Nov 2013 01:02:20 +0000 (01:02 +0000)]
[EFL] Build fix after r159859
https://bugs.webkit.org/show_bug.cgi?id=124991

Reviewed by Gyuyoung Kim.

Redefined newly added pure virtual function in PageClient class after r159859.

* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::didCommitLoadForMainFrame):
* UIProcess/CoordinatedGraphics/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename InlineIterator::m_obj and make it private
gyuyoung.kim@samsung.com [Thu, 28 Nov 2013 23:25:19 +0000 (23:25 +0000)]
Rename InlineIterator::m_obj and make it private
https://bugs.webkit.org/show_bug.cgi?id=124837

Reviewed by Antti Koivisto.

InlineIterator has been exported m_obj as public though there is a getter function.
Besides *object* name isn't ambigious. So, changed it with m_renderer and renderer().
Additionally, setRenderer() is added as well.

No new tests, no behavior changes.

* rendering/InlineIterator.h:
(WebCore::InlineIterator::setObject):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::InlineBidiResolver::appendRun):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::appendRunsForObject):
(WebCore::constructBidiRunsForLine):
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::matchedEndLine):
* rendering/line/BreakingContextInlineHeaders.h:
(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::currentObject):
(WebCore::BreakingContext::initializeForCurrentObject):
(WebCore::BreakingContext::handleBR):
(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::BreakingContext::handleFloat):
(WebCore::BreakingContext::handleEmptyInline):
(WebCore::BreakingContext::handleReplaced):
(WebCore::iteratorIsBeyondEndOfRenderCombineText):
(WebCore::ensureCharacterGetsLineBox):
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
(WebCore::checkMidpoints):
(WebCore::BreakingContext::handleEndOfLine):
* rendering/line/LineBreaker.cpp:
(WebCore::LineBreaker::skipTrailingWhitespace):
(WebCore::LineBreaker::skipLeadingWhitespace):
* rendering/line/LineInlineHeaders.h:
(WebCore::skipNonBreakingSpace):
(WebCore::requiresLineBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPerform some spring cleaning to WKContentView and WKView
weinig@apple.com [Thu, 28 Nov 2013 21:01:11 +0000 (21:01 +0000)]
Perform some spring cleaning to WKContentView and WKView
https://bugs.webkit.org/show_bug.cgi?id=124961

Reviewed by Dan Bernstein.

- Store the PageClientImpl in a std::unique_ptr.
- Remove the WKBrowsingContextController internal load delegate. Replace its use with
  a new PageClient function, didCommitLoadForMainFrame.
- Fix typo in the WKContentViewDelegate. contentViewdidCommitLoadForMainFrame -> contentViewDidCommitLoadForMainFrame.
- Add initializers for WKContentView and WKView that take WKContextRefs and WKPageGroupRefs to match the Mac WKView.
  These are needed for WebKitTestRunner.
- Require a WKProcessGroup (or WKContextRef) and a WKBrowsingContextGroup (or WKPageGroupRef).
- Stop caching the WKProcessGroup and WKBrowsingContextGroup on the WKContentView.
- Remove incorrect implementations of initWithCoder.
- Make WKContentView lazily create its WKBrowsingContextController wrapper.

* UIProcess/API/ios/PageClientImplIOS.h:
* UIProcess/API/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::mainDocumentDidReceiveMobileDocType):
* UIProcess/API/ios/WKContentView.h:
* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView initWithCoder:]):
(-[WKContentView initWithFrame:processGroup:browsingContextGroup:]):
(-[WKContentView browsingContextController]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _didReceiveMobileDocTypeForMainFrame]):
(-[WKContentView _didChangeViewportArguments:WebCore::]):
(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):
(-[WKContentView _pageRef]):
(-[WKContentView initWithFrame:contextRef:pageGroupRef:]):
(-[WKContentView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
* UIProcess/API/ios/WKContentViewInternal.h:
* UIProcess/API/ios/WKContentViewPrivate.h: Added.
* UIProcess/API/ios/WKView.mm:
(-[WKView initWithFrame:processGroup:browsingContextGroup:]):
(-[WKView initWithFrame:processGroup:browsingContextGroup:relatedToView:]):
(-[WKView contentViewDidCommitLoadForMainFrame:]):
(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
(-[WKView pageRef]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
* UIProcess/API/mac/WKBrowsingContextController.mm:
(didCommitLoadForFrame):
* UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
* UIProcess/API/mac/WKViewPrivate.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove an oddly named css variables test
antti@apple.com [Thu, 28 Nov 2013 20:59:06 +0000 (20:59 +0000)]
Remove an oddly named css variables test

Rubber-stamped by Andreas Kling.

* css3/filters/reference-filter-update-after-remove-expected.txt: Removed.
* css3/filters/reference-filter-update-after-remove.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNix Upstream: Updating Nix WTF files
commit-queue@webkit.org [Thu, 28 Nov 2013 20:55:19 +0000 (20:55 +0000)]
Nix Upstream: Updating Nix WTF files
https://bugs.webkit.org/show_bug.cgi?id=124980

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Just to sync our private repo files and the trunk, as part of the upstream process.

* wtf/DisallowCType.h:
* wtf/PlatformNix.cmake:
* wtf/nix/FeatureDefinesNix.h:
* wtf/nix/PlatformNix.h:
* wtf/nix/RunLoopNix.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename StylePropertySet to StyleProperties
antti@apple.com [Thu, 28 Nov 2013 20:53:22 +0000 (20:53 +0000)]
Rename StylePropertySet to StyleProperties
https://bugs.webkit.org/show_bug.cgi?id=124990

Reviewed by Andreas Kling.

"Set" does not add useful information here. Use less clunky plural name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert the X86 assembler peephole changes
nrotem@apple.com [Thu, 28 Nov 2013 20:33:44 +0000 (20:33 +0000)]
Revert the X86 assembler peephole changes
https://bugs.webkit.org/show_bug.cgi?id=124988

Reviewed by Csaba Osztrogonác.

* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::add32):
(JSC::MacroAssemblerX86::add64):
(JSC::MacroAssemblerX86::or32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::branchAdd32):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::or32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::or64):
(JSC::MacroAssemblerX86_64::xor64):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNix Upstream: Adding EditorNix to WebCore
commit-queue@webkit.org [Thu, 28 Nov 2013 19:43:50 +0000 (19:43 +0000)]
Nix Upstream: Adding EditorNix to WebCore
https://bugs.webkit.org/show_bug.cgi?id=124984

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

No new tests needed.

* PlatformNix.cmake:
* editing/nix/EditorNix.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderTableSection Blink merge asserting
ossy@webkit.org [Thu, 28 Nov 2013 19:35:24 +0000 (19:35 +0000)]
RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase EFL results (and the remaining Mac) after r159848.

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

* fast/table/anonymous-table-section-removed.html: Updated.
* platform/efl/accessibility/table-attributes-expected.txt: Added.
* platform/efl/accessibility/table-sections-expected.txt: Added.
* platform/efl/fast/forms/input-value-expected.png:
* platform/efl/fast/forms/input-value-expected.txt:
* platform/efl/fast/table/[...]:
* platform/efl/tables/[...]:
* platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
* platform/mac-mountainlion/fast/forms/input-value-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuilding EFL Webkit again with mediastream enabled
commit-queue@webkit.org [Thu, 28 Nov 2013 19:33:27 +0000 (19:33 +0000)]
Building EFL Webkit again with mediastream enabled
https://bugs.webkit.org/show_bug.cgi?id=124930

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderTableSection Blink merge asserting
ossy@webkit.org [Thu, 28 Nov 2013 19:03:10 +0000 (19:03 +0000)]
RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase GTK results after r159848.

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

* platform/mac/accessibility/table-detection-expected.txt:
* platform/mac/fast/forms/input-value-expected.txt:
* platform/mac/fast/table/[...]:
* platform/mac/tables/[...]:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderTableSection Blink merge asserting
ossy@webkit.org [Thu, 28 Nov 2013 18:54:03 +0000 (18:54 +0000)]
RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase GTK results after r159848.

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

* platform/gtk/accessibility/table-detection-expected.txt:
* platform/gtk/fast/forms/input-value-expected.png:
* platform/gtk/fast/forms/input-value-expected.txt:
* platform/gtk/fast/table/[...]:
* platform/gtk/tables/[...]:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] Update vcxproj.filters, since LineInfo.h and LineLayoutState.h have been moved...
zoltan@webkit.org [Thu, 28 Nov 2013 17:43:06 +0000 (17:43 +0000)]
[Win] Update vcxproj.filters, since LineInfo.h and LineLayoutState.h have been moved to rendering/line
https://bugs.webkit.org/show_bug.cgi?id=124959

Reviewed by Brent Fulgham.

Update WebCore.vcxproj.filters, since LineInfo.h (r155628) and LineLayoutState.h (158121) have been moved to rendering/line.

No new tests, no behavior change.

* WebCore.vcxproj/WebCore.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderTableSection Blink merge asserting
ossy@webkit.org [Thu, 28 Nov 2013 17:40:59 +0000 (17:40 +0000)]
RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Source/WebCore:

Use border spacing at the end of all sections.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

Skipped tests enabled.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r159839.
commit-queue@webkit.org [Thu, 28 Nov 2013 16:55:28 +0000 (16:55 +0000)]
Unreviewed, rolling out r159839.
http://trac.webkit.org/changeset/159839
https://bugs.webkit.org/show_bug.cgi?id=124974

run-webkit-tests doesn't generate pretty diff (Requested by
Ossy on #webkit).

* Scripts/webkitpy/common/prettypatch.py:
(PrettyPatch.__init__):
(PrettyPatch.pretty_diff):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.create_text_diff_and_write_result):
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results):
* Scripts/webkitpy/port/base.py:
(Port.__init__):
(Port.pretty_patch_available):
(Port.check_pretty_patch):
(Port.variable):
(Port.variable.pretty_patch_text):
* Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Thu, 28 Nov 2013 16:35:28 +0000 (16:35 +0000)]
Unreviewed EFL gardening

* platform/efl/TestExpectations: Added test expectations for failing tests.
* platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Added.
* platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuildfix after r159824 for GCC 4.6
commit-queue@webkit.org [Thu, 28 Nov 2013 16:20:01 +0000 (16:20 +0000)]
Buildfix after r159824 for GCC 4.6
https://bugs.webkit.org/show_bug.cgi?id=124968

Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Added explicit "friend class", because GCC 4.6 doesn't support extended friend declaration (c++11)

* Shared/APIObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNo need to skip css variables tests as they were removed.
antti@apple.com [Thu, 28 Nov 2013 16:19:30 +0000 (16:19 +0000)]
No need to skip css variables tests as they were removed.

* platform/mac/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
gns@gnome.org [Thu, 28 Nov 2013 16:02:34 +0000 (16:02 +0000)]
REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
https://bugs.webkit.org/show_bug.cgi?id=124954

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-11-28
Reviewed by Carlos Garcia Campos.

* tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
* webkit/webkitwebview.cpp:
(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove feature: CSS variables
antti@apple.com [Thu, 28 Nov 2013 15:46:53 +0000 (15:46 +0000)]
Remove feature: CSS variables
https://bugs.webkit.org/show_bug.cgi?id=114119

.:

Reviewed by Andreas Kling.

* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Reviewed by Andreas Kling.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Reviewed by Andreas Kling.

The feature is unmaintained and it is getting in the way of refactoring. Code quality is not up to
WebKit standards either.

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.list.am:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSBasicShapes.cpp:
* css/CSSBasicShapes.h:
* css/CSSCalculationValue.cpp:
(WebCore::unitCategory):
(WebCore::hasDoubleValue):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::determineCategory):
(WebCore::CSSCalcBinaryOperation::primitiveType):
* css/CSSCalculationValue.h:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::validCalculationUnit):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::realLex):
* css/CSSParser.h:
* css/CSSParserMode.h:
* css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
* css/CSSParserValues.h:
* css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customCSSText):
(WebCore::CSSPrimitiveValue::equals):
* css/CSSPrimitiveValue.h:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
* css/CSSProperty.cpp:
* css/CSSProperty.h:
(WebCore::CSSProperty::CSSProperty):
* css/CSSReflectValue.cpp:
* css/CSSReflectValue.h:
* css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
* css/CSSValue.h:
(WebCore::CSSValue::setCssText):
* css/CSSValueList.cpp:
* css/CSSValueList.h:
* css/CSSVariableValue.h: Removed.
* css/Pair.h:
* css/Rect.h:
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::PropertyReference::cssName):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyProperty):
* css/StyleResolver.h:
* css/WebKitCSSTransformValue.cpp:
* css/WebKitCSSTransformValue.h:
(WebCore::WebKitCSSTransformValue::equals):
* css/makeprop.pl:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
* rendering/style/StyleVariableData.h: Removed.
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

Source/WebKit/mac:

Reviewed by Andreas Kling.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Andreas Kling.

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

Reviewed by Andreas Kling.

* wtf/FeatureDefines.h:

Tools:

Reviewed by Andreas Kling.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Reviewed by Andreas Kling.

* fast/css/variables: Removed.
* fast/css/variables/border-width-expected.html: Removed.
* fast/css/variables/border-width.html: Removed.
* fast/css/variables/build-supports-variables-expected.txt: Removed.
* fast/css/variables/build-supports-variables.html: Removed.
* fast/css/variables/calc-expected.html: Removed.
* fast/css/variables/calc-inside-calc-expected.html: Removed.
* fast/css/variables/calc-inside-calc.html: Removed.
* fast/css/variables/calc-invalid-value-expected.html: Removed.
* fast/css/variables/calc-invalid-value.html: Removed.
* fast/css/variables/calc-invalid-variable-expected.html: Removed.
* fast/css/variables/calc-invalid-variable.html: Removed.
* fast/css/variables/calc-negated-variable-expected.html: Removed.
* fast/css/variables/calc-negated-variable.html: Removed.
* fast/css/variables/calc-vw-crash-expected.txt: Removed.
* fast/css/variables/calc-vw-crash.html: Removed.
* fast/css/variables/calc.html: Removed.
* fast/css/variables/case-sensitive-expected.html: Removed.
* fast/css/variables/case-sensitive.html: Removed.
* fast/css/variables/colors-test-expected.html: Removed.
* fast/css/variables/colors-test.html: Removed.
* fast/css/variables/complex-cycle-expected.html: Removed.
* fast/css/variables/complex-cycle.html: Removed.
* fast/css/variables/computed-style-expected.html: Removed.
* fast/css/variables/computed-style.html: Removed.
* fast/css/variables/deferred-image-load-from-variable-expected.txt: Removed.
* fast/css/variables/deferred-image-load-from-variable.html: Removed.
* fast/css/variables/inherited-values-expected.html: Removed.
* fast/css/variables/inherited-values.html: Removed.
* fast/css/variables/inline-styles-expected.html: Removed.
* fast/css/variables/inline-styles.html: Removed.
* fast/css/variables/invalid-font-reference-expected.txt: Removed.
* fast/css/variables/invalid-font-reference.html: Removed.
* fast/css/variables/invalid-shorthand-expected.html: Removed.
* fast/css/variables/invalid-shorthand.html: Removed.
* fast/css/variables/invalid-value-list-crash-expected.txt: Removed.
* fast/css/variables/invalid-value-list-crash.html: Removed.
* fast/css/variables/invalid-variable-value-expected.html: Removed.
* fast/css/variables/invalid-variable-value.html: Removed.
* fast/css/variables/multi-level-cycle-expected.html: Removed.
* fast/css/variables/multi-level-cycle.html: Removed.
* fast/css/variables/redefinition-expected.html: Removed.
* fast/css/variables/redefinition.html: Removed.
* fast/css/variables/root-background-size-expected.html: Removed.
* fast/css/variables/root-background-size.html: Removed.
* fast/css/variables/shorthand-expected.html: Removed.
* fast/css/variables/shorthand.html: Removed.
* fast/css/variables/simple-cycle-expected.html: Removed.
* fast/css/variables/simple-cycle.html: Removed.
* fast/css/variables/transform-test-expected.html: Removed.
* fast/css/variables/transform-test.html: Removed.
* fast/css/variables/undefined-expected.html: Removed.
* fast/css/variables/undefined.html: Removed.
* fast/css/variables/use-before-defined-expected.html: Removed.
* fast/css/variables/use-before-defined.html: Removed.
* fast/css/variables/var-filter-expected.txt: Removed.
* fast/css/variables/var-filter.html: Removed.
* fast/css/variables/var-inside-box-reflect-expected.html: Removed.
* fast/css/variables/var-inside-box-reflect.html: Removed.
* fast/css/variables/var-inside-pair-expected.html: Removed.
* fast/css/variables/var-inside-pair.html: Removed.
* fast/css/variables/var-inside-quad-expected.html: Removed.
* fast/css/variables/var-inside-quad.html: Removed.
* fast/css/variables/var-inside-shape-expected.html: Removed.
* fast/css/variables/var-inside-shape.html: Removed.
* fast/css/variables/var-inside-shorthand-expected.html: Removed.
* fast/css/variables/var-inside-shorthand.html: Removed.
* fast/css/variables/variable-chain-expected.html: Removed.
* fast/css/variables/variable-chain.html: Removed.
* fast/css/variables/variable-unparseable-value-crash-expected.txt: Removed.
* fast/css/variables/variable-unparseable-value-crash.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Layout tests need to be rebaselined.
commit-queue@webkit.org [Thu, 28 Nov 2013 15:27:04 +0000 (15:27 +0000)]
[EFL] Layout tests need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124879

Unreviewed, EFL rebaseline.

EFL tests need to be rebaselined after r159747

Patch by Jongwoo Choi <jw0330.choi@samsung.com> on 2013-11-28

* platform/efl/fast/table/011-expected.txt:
* platform/efl/fast/table/border-collapsing/004-expected.txt:
* platform/efl/fast/table/tableInsideCaption-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdating RTCPeerConnectionHandlerMock after r159769
commit-queue@webkit.org [Thu, 28 Nov 2013 15:15:49 +0000 (15:15 +0000)]
Updating RTCPeerConnectionHandlerMock after r159769
https://bugs.webkit.org/show_bug.cgi?id=124947

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Philippe Normand.

Adding its create function back, in order to run RTCPeerConnection LayoutTests.

No new tests needed.

* platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::create):
* platform/mock/RTCPeerConnectionHandlerMock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove PrettyPatch related code to prettypatch.py
commit-queue@webkit.org [Thu, 28 Nov 2013 15:14:42 +0000 (15:14 +0000)]
Move PrettyPatch related code to prettypatch.py
https://bugs.webkit.org/show_bug.cgi?id=124937

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-28
Reviewed by Ryosuke Niwa.

This code seems to have a better place here than in Port, since PrettyPatch already knows
pretty_patch_path, and this also unifies the usage of PrettyPatch

* Scripts/webkitpy/common/prettypatch.py:
(PrettyPatch.__init__):
(PrettyPatch.pretty_diff):
(PrettyPatch):
(PrettyPatch.pretty_patch_available):
(PrettyPatch.check_pretty_patch):
(PrettyPatch.pretty_patch_text):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.create_text_diff_and_write_result):
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(summarize_results):
* Scripts/webkitpy/port/base.py:
(Port.__init__):
(Port.wdiff_available):
(Port.check_image_diff):
(Port.wdiff_text):
* Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCheckout should own the scm object in Host
commit-queue@webkit.org [Thu, 28 Nov 2013 13:46:26 +0000 (13:46 +0000)]
Checkout should own the scm object in Host
https://bugs.webkit.org/show_bug.cgi?id=124943

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-28
Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/common/host.py:
(Host.__init__):
(Host.initialize_scm):
(Host.scm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Support custom types for drag and drop data
gns@gnome.org [Thu, 28 Nov 2013 12:40:59 +0000 (12:40 +0000)]
[GTK] Support custom types for drag and drop data
https://bugs.webkit.org/show_bug.cgi?id=124659

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-11-27
Reviewed by Martin Robinson.

Source/WebCore:

Covered by fast/events/drag-customData.html.

* platform/gtk/DataObjectGtk.cpp:
(WebCore::DataObjectGtk::unknownTypes): returns a hash map with all custom types set.
(WebCore::DataObjectGtk::clearAllExceptFilenames): clear custom types.
* platform/gtk/DataObjectGtk.h:
(WebCore::DataObjectGtk::hasUnknownTypeData): returns whether custom types are set.
(WebCore::DataObjectGtk::unknownTypeData): returns the data for a custom type.
(WebCore::DataObjectGtk::setUnknownTypeData): sets the data for a custom type.
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeString): handle unknown types as custom.
(WebCore::Pasteboard::writePasteboard): ditto.
(WebCore::Pasteboard::hasData): also check for custom types.
(WebCore::Pasteboard::types): also obtain the list of custom types.
(WebCore::Pasteboard::readString): handle unknown types as custom.
* platform/gtk/PasteboardHelper.cpp:
(WebCore::initGdkAtoms): new unknown atom.
(WebCore::PasteboardHelper::PasteboardHelper): add custom type to the list of targets.
(WebCore::PasteboardHelper::fillSelectionData): turns any custom types' data into a GVariant, which
is in turn serialized to a single string for GtkSelectionData to hold.
(WebCore::PasteboardHelper::targetListForDataObject): add custom data to the target list if any is
set.
(WebCore::PasteboardHelper::fillDataObjectFromDropData): retrieve the custom types and their data
from the serialized GVariant string held by GtkSelectionData.
(WebCore::PasteboardHelper::dropAtomsForContext): handle custom types.

Source/WebKit2:

* Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::encodeDataObject): encode the unknown types data.
(CoreIPC::decodeDataObject): decode the unknown types data.

LayoutTests:

* platform/gtk/TestExpectations: remove failure expectation for test that now passes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTypo fix after r159834 to fix 32 bit builds.
ossy@webkit.org [Thu, 28 Nov 2013 10:28:04 +0000 (10:28 +0000)]
Typo fix after r159834 to fix 32 bit builds.

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a bunch of early exits and local optimizations to the x86 assembler.
nrotem@apple.com [Thu, 28 Nov 2013 07:40:03 +0000 (07:40 +0000)]
Add a bunch of early exits and local optimizations to the x86 assembler.
https://bugs.webkit.org/show_bug.cgi?id=124904

Reviewed by Filip Pizlo.

* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::add32):
(JSC::MacroAssemblerX86::add64):
(JSC::MacroAssemblerX86::or32):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::or32):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::or32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::or64):
(JSC::MacroAssemblerX86_64::xor64):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInfer one-time scopes
fpizlo@apple.com [Thu, 28 Nov 2013 07:10:10 +0000 (07:10 +0000)]
Infer one-time scopes
https://bugs.webkit.org/show_bug.cgi?id=124812

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This detects JSActivations that are created only once. The JSActivation pointer is then
baked into the machine code.

This takes advantage of the one-time scope inference to reduce the number of
indirections needed to get to a closure variable in case where the scope is only
allocated once. This isn't really a speed-up since in the common case the total number
of instruction bytes needed to load the scope from the stack is about equal to the
number of instruction bytes needed to materialize the absolute address of a scoped
variable. But, this is a necessary prerequisite to
https://bugs.webkit.org/show_bug.cgi?id=124630, so it's probably a good idea anyway.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
* bytecode/Instruction.h:
* bytecode/Opcode.h:
(JSC::padOpcodeName):
* bytecode/Watchpoint.h:
(JSC::WatchpointSet::notifyWrite):
(JSC::InlineWatchpointSet::notifyWrite):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolveScope):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::tryGetRegisters):
* dfg/DFGGraph.h:
* dfg/DFGNode.h:
(JSC::DFG::Node::varNumber):
(JSC::DFG::Node::hasSymbolTable):
(JSC::DFG::Node::symbolTable):
* dfg/DFGNodeType.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGWatchpointCollectionPhase.cpp:
(JSC::DFG::WatchpointCollectionPhase::handle):
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetClosureRegisters):
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/JSActivation.h:
(JSC::JSActivation::create):
* runtime/JSScope.cpp:
(JSC::abstractAccess):
(JSC::JSScope::abstractResolve):
* runtime/JSScope.h:
(JSC::ResolveOp::ResolveOp):
* runtime/JSVariableObject.h:
(JSC::JSVariableObject::registers):
* runtime/SymbolTable.cpp:
(JSC::SymbolTable::SymbolTable):
* runtime/SymbolTable.h:

LayoutTests:

Reviewed by Oliver Hunt.

* js/regress/infer-one-time-closure-expected.txt: Added.
* js/regress/infer-one-time-closure-ten-vars-expected.txt: Added.
* js/regress/infer-one-time-closure-ten-vars.html: Added.
* js/regress/infer-one-time-closure-two-vars-expected.txt: Added.
* js/regress/infer-one-time-closure-two-vars.html: Added.
* js/regress/infer-one-time-closure.html: Added.
* js/regress/infer-one-time-deep-closure-expected.txt: Added.
* js/regress/infer-one-time-deep-closure.html: Added.
* js/regress/script-tests/infer-one-time-closure-ten-vars.js: Added.
* js/regress/script-tests/infer-one-time-closure-two-vars.js: Added.
* js/regress/script-tests/infer-one-time-closure.js: Added.
* js/regress/script-tests/infer-one-time-deep-closure.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGive the PageClient a chance to handle geolocation permission requests if the UIClien...
weinig@apple.com [Thu, 28 Nov 2013 04:34:08 +0000 (04:34 +0000)]
Give the PageClient a chance to handle geolocation permission requests if the UIClient doesn't handle it
https://bugs.webkit.org/show_bug.cgi?id=124955

Reviewed by Dan Bernstein.

Use the new PageClient function to remove the need for WKContentView to take over the WKPageUIClient.

* UIProcess/API/ios/PageClientImplIOS.h:
* UIProcess/API/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):
* UIProcess/API/ios/WKContentView.mm:
(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):
(-[WKContentView _commonInitWithProcessGroup:browsingContextGroup:]):
* UIProcess/API/ios/WKContentViewInternal.h:
* UIProcess/PageClient.h:
(WebKit::PageClient::decidePolicyForGeolocationPermissionRequest):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the iOS build.
weinig@apple.com [Thu, 28 Nov 2013 03:23:48 +0000 (03:23 +0000)]
Fix the iOS build.

* UIProcess/API/ios/WKGeolocationProviderIOS.mm:
* UIProcess/API/ios/WKGeolocationProviderIOSObjCSecurityOrigin.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the iOS build.
weinig@apple.com [Thu, 28 Nov 2013 03:14:43 +0000 (03:14 +0000)]
Fix the iOS build.

../WebKit:

* WebKit.xcodeproj/project.pbxproj:

../WebKit/mac:

* WebView/WebAllowDenyPolicyListener.h: Added.
* WebView/WebUIDelegatePrivate.h:
Move the WebAllowDenyPolicyListener protocol to its own file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd accessors for the WKProcessGroup and WKBrowsingContextGroup on the WKBrowsingCont...
weinig@apple.com [Thu, 28 Nov 2013 02:25:46 +0000 (02:25 +0000)]
Add accessors for the WKProcessGroup and WKBrowsingContextGroup on the WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=124953

Reviewed by Dan Bernstein.

* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController processGroup]):
(-[WKBrowsingContextController browsingContextGroup]):
Add accessors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake WKProcessGroup work with WKObject wrapping
weinig@apple.com [Thu, 28 Nov 2013 02:03:41 +0000 (02:03 +0000)]
Make WKProcessGroup work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=124952

Reviewed by Dan Bernstein.

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
Add support for WKProcessGroup.

* UIProcess/API/mac/WKProcessGroup.mm:
(-[WKProcessGroup initWithInjectedBundleURL:]):
(-[WKProcessGroup dealloc]):
(-[WKProcessGroup API::]):
(-[WKProcessGroup _contextRef]):
(-[WKProcessGroup _geolocationProvider]):
Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline

* UIProcess/API/mac/WKProcessGroupInternal.h: Added.
(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::create):
(WebKit::WebContext::WebContext):
* UIProcess/WebContext.h:
Make the WebContext constructor public (for use with Object::constructInWrapper) and remove unused ProcessModel parameter.

* WebKit2.xcodeproj/project.pbxproj:
Add new file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] The remote inspector does not show the base page.
commit-queue@webkit.org [Thu, 28 Nov 2013 01:20:54 +0000 (01:20 +0000)]
[EFL] The remote inspector does not show the base page.
https://bugs.webkit.org/show_bug.cgi?id=124942

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-27
Reviewed by Gyuyoung Kim.

On EFL the remote inspector does not show the base page about
which pages are available for debug. This should be fixed for
further inspector development.

* Source/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAllow the QuickTime plug-in to be replaced by script in an isolated word
eric.carlson@apple.com [Thu, 28 Nov 2013 01:05:35 +0000 (01:05 +0000)]
Allow the QuickTime plug-in to be replaced by script in an isolated word
https://bugs.webkit.org/show_bug.cgi?id=124900

Reviewed by Dean Jackson.

Source/WebCore:

Test: plugins/quicktime-plugin-replacement.html

* CMakeLists.txt: Add new Modules path.
* DerivedSources.make: Add new files.
* GNUmakefile.am: Add new Modules path.
* GNUmakefile.list.am: Add new header.
* WebCore.vcxproj/WebCore.vcxproj: Add new header.
* WebCore.vcxproj/WebCoreCommon.props: Add new Modules path.
* WebCore.xcodeproj/project.pbxproj: Add new files.

* Modules/plugins: Added.
* Modules/plugins/PluginReplacement.h: Added. Defines the interface for a plug-in replacement.

Create a replacement for the QuickTime plug-in.
* Modules/plugins/QuickTimePluginReplacement.cpp: Added.
* Modules/plugins/QuickTimePluginReplacement.css: Added.
* Modules/plugins/QuickTimePluginReplacement.h: Added.
* Modules/plugins/QuickTimePluginReplacement.idl: Added.
* Modules/plugins/QuickTimePluginReplacement.js: Added.

Allow plug-in replacement to be enabled at runtime.
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setPluginReplacementEnabled):
(WebCore::RuntimeEnabledFeatures::pluginReplacementEnabled):

* bindings/js/JSDOMBinding.h:
(WebCore::toJS): Add toJS(... const String& ...).

* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginScriptObject): Give a plug-in replacement a first shot at defining the
    script interface.

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::updateWidget): Call base class requestObject.

* html/HTMLMediaElement.cpp:
(HTMLMediaElement::fileSize): New, passthrough to media engine.
* html/HTMLMediaElement.h:

* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateWidget): Call base class requestObject.

Moved some logic that was previously used only for creating a plug-in snapshot to the base
class so it can be shared by a plug-in replacement.
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::HTMLPlugInElement): Initialize timer used to swap renderers.
(WebCore::HTMLPlugInElement::createRenderer): Allow plug-in replacement to create the renderer.
(WebCore::HTMLPlugInElement::swapRendererTimerFired): Create a shadow root.
(WebCore::HTMLPlugInElement::setDisplayState): Set the new state, prime the swap renderer
    timer if necessary.
(WebCore::HTMLPlugInElement::didAddUserAgentShadowRoot): Tell the plug-in replacement to
    install itself in the new shadow DOM.
(WebCore::registeredPluginReplacements): Return vector of all registered plug-in replacements.
(WebCore::registerPluginReplacement): Add a plug-in replacement.
(WebCore::pluginReplacementForType): Find a plug-in replacement for a MIME type.
(WebCore::HTMLPlugInElement::requestObject): If there is a plug-in replacement for the MIME type,
    create it and set the display state.
(WebCore::HTMLPlugInElement::scriptObjectForPluginReplacement): Return the script object for
    the current plug-in replacement, if any.
* html/HTMLPlugInElement.h:

Move some plug-in snapshot code into the base class.
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): No need to initialize timer.
(WebCore::HTMLPlugInImageElement::setDisplayState): Call base class.
(WebCore::HTMLPlugInImageElement::createRenderer): Ditto.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Ditto.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Remove unnecessary class name.
(WebCore::HTMLPlugInImageElement::requestObject): New.
* html/HTMLPlugInImageElement.h:

* html/HTMLVideoElement.h: Make createRenderer public so the QuickTime plug-in replacement can
    call it.

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::fileSize): New.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::extraMemoryCost): totalBytes returns an unsigned long long.
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::fileSize):

* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes): Return an unsigned long long.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::totalBytes): Ditto.

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Backup the plug-in replacement runtime setting.
(WebCore::InternalSettings::Backup::restoreTo): Restore it.
(WebCore::InternalSettings::setPluginReplacementEnabled): Set it.
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

LayoutTests:

* platform/efl/TestExpectations: Skip the new test.
* platform/gtk/TestExpectations: Ditto.
* platform/wincairo/TestExpectations: Ditto.
* plugins/quicktime-plugin-replacement.html: Added.
* plugins/quicktime-plugin-replacement-expected.txt: Added.
* plugins/resources/orange.mov: Replace movie compressed with ancient (and deprecated)
    animated gif codec with one compressed with H.264 codec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFinally fix some obvious Bartlett bugs
fpizlo@apple.com [Thu, 28 Nov 2013 00:22:43 +0000 (00:22 +0000)]
Finally fix some obvious Bartlett bugs
https://bugs.webkit.org/show_bug.cgi?id=124951

Reviewed by Mark Hahnenberg.

Sanitize the stack (i.e. zero parts of it known to be dead) at three key points:

- GC.

- At beginning of OSR entry.

- Just as we finish preparing OSR entry. This clears those slots on the stack that
  could have been live in baseline but that are known to be dead in DFG.

This is as much as a 2x speed-up on splay if you run it in certain modes, and run it
for a long enough interval. It appears to fix all instances of the dreaded exponential
heap growth that splay gets into when some stale pointer stays around.

This doesn't have much of an effect on real-world programs. This bug has only ever
manifested in splay and for that reason we thus far opted against fixing it. But splay
is, for what it's worth, the premiere GC stress test in JavaScript - so making sure we
can run it without pathologies - even when you tweak its configuration - is probably
fairly important.

* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::noticeOSREntry):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
* dfg/DFGOSREntry.h:
* heap/Heap.cpp:
(JSC::Heap::markRoots):
* interpreter/JSStack.cpp:
(JSC::JSStack::JSStack):
(JSC::JSStack::sanitizeStack):
* interpreter/JSStack.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDo bytecode validation as part of testing
fpizlo@apple.com [Wed, 27 Nov 2013 23:15:48 +0000 (23:15 +0000)]
Do bytecode validation as part of testing
https://bugs.webkit.org/show_bug.cgi?id=124913

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Also fix some small bugs in the bytecode liveness analysis that I found by doing
this validation thingy.

* bytecode/BytecodeLivenessAnalysis.cpp:
(JSC::isValidRegisterForLiveness):
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::validate):
(JSC::CodeBlock::beginValidationDidFail):
(JSC::CodeBlock::endValidationDidFail):
* bytecode/CodeBlock.h:
* runtime/Executable.cpp:
(JSC::ScriptExecutable::prepareForExecutionImpl):
* runtime/Options.h:

Source/WTF:

Reviewed by Oliver Hunt.

* GNUmakefile.list.am:
* WTF.vcxproj/WTF.vcxproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/FastBitVector.cpp: Added.
(WTF::FastBitVector::dump):
* wtf/FastBitVector.h:
(WTF::FastBitVector::resize):
(WTF::FastBitVector::bitCount):
(WTF::FastBitVector::arrayLength):

Tools:

Reviewed by Oliver Hunt.

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake WKBrowsingContextGroup work with WKObject wrapping
weinig@apple.com [Wed, 27 Nov 2013 22:48:32 +0000 (22:48 +0000)]
Make WKBrowsingContextGroup work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=124948

Reviewed by Dan Bernstein.

- Adds mechanism to use the inline data wrapping mechanism when the Objective-C wrapper is created
  by the caller (rather than by Object::newObject).
- Adopts the mechanism for WKBrowsingContextGroup.

* Shared/APIObject.h:
(API::Object::constructInWrapper):
Add a helper which does a forwarding placement-new into the API::Object of the passed in wrapper, after which it sets up m_wrapper.

(API::TypedObject::operator new):
Add a operator new to for placement-new. Also make TypedObject friends with Object so that constructInWrapper can call this.

* Shared/Cocoa/APIObject.mm:
(API::Object::newObject):
Add support for WKBrowsingContextGroup.

* UIProcess/API/mac/WKBrowsingContextGroup.mm:
(-[WKBrowsingContextGroup API::]):
(-[WKBrowsingContextGroup dealloc]):
(-[WKBrowsingContextGroup initWithIdentifier:]):
(-[WKBrowsingContextGroup allowsJavaScript]):
(-[WKBrowsingContextGroup setAllowsJavaScript:]):
(-[WKBrowsingContextGroup allowsJavaScriptMarkup]):
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]):
(-[WKBrowsingContextGroup allowsPlugIns]):
(-[WKBrowsingContextGroup setAllowsPlugIns:]):
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]):
(-[WKBrowsingContextGroup removeAllUserStyleSheets]):
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]):
(-[WKBrowsingContextGroup removeAllUserScripts]):
(-[WKBrowsingContextGroup _pageGroupRef]):
Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline (modeled on WKBackForwardList).

* UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Added.
(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol.

* UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::create):
(WebKit::WebPageGroup::WebPageGroup):
* UIProcess/WebPageGroup.h:
Make the WebPageGroup constructor public (for use with Object::constructInWrapper) and move being set in the webPageGroupMap()
to the constructor.

* WebKit2.xcodeproj/project.pbxproj:
Add new file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdding MediaConstraintsMock class
commit-queue@webkit.org [Wed, 27 Nov 2013 21:03:51 +0000 (21:03 +0000)]
Adding MediaConstraintsMock class
https://bugs.webkit.org/show_bug.cgi?id=124902

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-27
Reviewed by Eric Carlson.

Validate constraints used in RTCPeerConnection LayoutTests

Source/WebCore:

Existing test was updated.

* CMakeLists.txt:
* GNUmakefile.list.am:
* platform/mock/MediaConstraintsMock.cpp: Added.
* platform/mock/MediaConstraintsMock.h: Added.
* platform/mock/MockMediaStreamCenter.cpp:
(WebCore::MockMediaStreamCenter::validateRequestConstraints): Now using MediaConstraintsMock
(WebCore::MockMediaStreamCenter::createMediaStream): Ditto.
* platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::initialize): Ditto.

LayoutTests:

* fast/mediastream/RTCPeerConnection-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes] Shape-Inside Should Default to 'auto'
betravis@adobe.com [Wed, 27 Nov 2013 20:19:48 +0000 (20:19 +0000)]
[CSS Shapes] Shape-Inside Should Default to 'auto'
https://bugs.webkit.org/show_bug.cgi?id=124851

Reviewed by Alexandru Chiculita.

Source/WebCore:

The current shape-inside specification has the property default to the 'auto'
value, not 'outside-shape'.

Updated tests are under fast/shapes.

* rendering/style/RenderStyle.cpp:
* rendering/style/RenderStyle.h:

LayoutTests:

Update tests to reflect a default shape-inside value of 'auto'.

* fast/shapes/css-shapes-disabled-expected.txt:
* fast/shapes/css-shapes-disabled.html:
* fast/shapes/parsing/parsing-shape-inside-expected.txt:
* fast/shapes/parsing/parsing-shape-inside.html:
* fast/shapes/parsing/parsing-shape-lengths-expected.txt:
* fast/shapes/parsing/parsing-shape-lengths.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shapes] shape-inside rectangle layout can fail
hmuller@adobe.com [Wed, 27 Nov 2013 20:17:06 +0000 (20:17 +0000)]
[CSS Shapes] shape-inside rectangle layout can fail
https://bugs.webkit.org/show_bug.cgi?id=124784

Reviewed by Andreas Kling.

Source/WebCore:

Apply LayoutUnit::fromFloatCeil() consistently in RectangleShape::firstIncludedIntervalLogicalTop().

Test: fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html

* rendering/shapes/RectangleShape.cpp:
(WebCore::RectangleShape::firstIncludedIntervalLogicalTop):

LayoutTests:

Regression test.

* fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove Qt-specific .qrc files
commit-queue@webkit.org [Wed, 27 Nov 2013 19:02:40 +0000 (19:02 +0000)]
Remove Qt-specific .qrc files
https://bugs.webkit.org/show_bug.cgi?id=124944

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-27
Reviewed by Andreas Kling.

Source/WebCore:

No new tests needed.

* WebCore.qrc: Removed.

Source/WebKit2:

* WebKit2.qrc: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies...
commit-queue@webkit.org [Wed, 27 Nov 2013 17:41:03 +0000 (17:41 +0000)]
[GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
https://bugs.webkit.org/show_bug.cgi?id=124940

Patch by Andres Gomez <agomez@igalia.com> on 2013-11-27
Reviewed by Martin Robinson.

xserver-font-utils is needed for building gtk port dependencies
with jhbuild.

* gtk/install-dependencies: Added xserver-font-utils to jhbuild
dependecies.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing ...
commit-queue@webkit.org [Wed, 27 Nov 2013 17:24:48 +0000 (17:24 +0000)]
[GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
https://bugs.webkit.org/show_bug.cgi?id=124938

Patch by Andres Gomez <agomez@igalia.com> on 2013-11-27
Reviewed by Philippe Normand.

Added needed git dependency for building the gtk port with
jhbuild. Also, the dependencies needed for building the gtk port
are now sorted alphabetically.

* gtk/install-dependencies: Added git as jhbuild dependency and
sorted dependencies alphabetically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove Sparc specific code.
commit-queue@webkit.org [Wed, 27 Nov 2013 16:35:29 +0000 (16:35 +0000)]
Remove Sparc specific code.
https://bugs.webkit.org/show_bug.cgi?id=124941

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-11-27
Reviewed by Michael Saboff.

Sparc is not supported, remove leftover code.

* wtf/Platform.h:
* wtf/dtoa/utils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix after r159805.
rniwa@webkit.org [Wed, 27 Nov 2013 16:12:34 +0000 (16:12 +0000)]
Build fix after r159805.

* resources/runner.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorun_webkit_tests.py: error: no such option: --wincairo
commit-queue@webkit.org [Wed, 27 Nov 2013 15:55:18 +0000 (15:55 +0000)]
run_webkit_tests.py: error: no such option: --wincairo
https://bugs.webkit.org/show_bug.cgi?id=124927

Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-27
Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
the layout testing on wincairo, so it is turned off.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStructure::m_staticFunctionReified should be a single bit.
akling@apple.com [Wed, 27 Nov 2013 15:10:25 +0000 (15:10 +0000)]
Structure::m_staticFunctionReified should be a single bit.
<https://webkit.org/b/124912>

Shave 8 bytes off of JSC::Structure by jamming m_staticFunctionReified
into the bitfield just above.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSActivation constructor should use NotNull placement new.
akling@apple.com [Wed, 27 Nov 2013 15:05:53 +0000 (15:05 +0000)]
JSActivation constructor should use NotNull placement new.
<https://webkit.org/b/124909>

Knock a null check outta the storage initialization loop.

Reviewed by Antti Koivisto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening
m.pakula@samsung.com [Wed, 27 Nov 2013 14:34:04 +0000 (14:34 +0000)]
Unreviewed EFL gardening

Add test expectations for flaky tests.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing
zandobersek@gmail.com [Wed, 27 Nov 2013 13:04:26 +0000 (13:04 +0000)]
[GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing
https://bugs.webkit.org/show_bug.cgi?id=124924

Reviewed by Carlos Garcia Campos.

'Chrome'/'Chromium' substrings were removed from the user agent string in r159572, meaning the unit
test shouldn't check for those two substrings anymore. Instead, 'Safari' (as until now) and 'AppleWebKit'
substrings should be checked for.

* UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettingsUserAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] Invalid command line error when visiting www.chessbase.com
calvaris@igalia.com [Wed, 27 Nov 2013 10:47:56 +0000 (10:47 +0000)]
[GStreamer] Invalid command line error when visiting chessbase.com
https://bugs.webkit.org/show_bug.cgi?id=124715

Reviewed by Philippe Normand.

Source/WebCore:

We were not handling the HTTP errors in the WebKit GStreamer
source and therefore the 404 error page was being 'decoded'. As no
decoder could be found (for obvious reasons), playback failed, but
it should be failing for the source not being found instead of the
decoding problem.

Test: http/tests/media/video-error-does-not-exist.html

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::handleResponseReceived): Handle HTTP errors in
the source and raise a GStreamer error to the pipeline.

LayoutTests:

Copied and adapted for HTTP from
media/video-error-does-not-exist.html.

* http/tests/media/video-error-does-not-exist-expected.txt: Added.
* http/tests/media/video-error-does-not-exist.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Fix positioning of grid items with margins
svillar@igalia.com [Wed, 27 Nov 2013 08:43:07 +0000 (08:43 +0000)]
[CSS Grid Layout] Fix positioning of grid items with margins
https://bugs.webkit.org/show_bug.cgi?id=124345

Reviewed by David Hyatt.

From Blink r157925 and r158041 by <jchaffraix@chromium.org>

Source/WebCore:

Test: fast/css-grid-layout/grid-item-margin-resolution.html

Adds margin start/before to the positions of grid items (removing
several FIXME's in the current code). This means calling
findChildLogicalPosition() after the layout in order to have the
right values for the margins.

In order to match flexbox and author's intents we're also
including the margins of grid items in the intrinsic size of the
grid. That's why flexbox's marginLogicalPositionForChild() is
moved up to RenderBlock in order to share it with RenderGrid.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::marginIntrinsicLogicalWidthForChild): Moved
from RenderFlexibleBox::marginLogicalWidthForChild().
* rendering/RenderBlock.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computePreferredTrackWidth):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::findChildLogicalPosition):

LayoutTests:

New test case for grid items margin resolution. Extended the
preferred logical widths checks with grid items with margins.

* fast/css-grid-layout/grid-item-margin-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-item-margin-resolution.html: Added.
* fast/css-grid-layout/grid-preferred-logical-widths-expected.txt:
* fast/css-grid-layout/grid-preferred-logical-widths.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax
svillar@igalia.com [Wed, 27 Nov 2013 08:31:14 +0000 (08:31 +0000)]
[CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax
https://bugs.webkit.org/show_bug.cgi?id=103312

Reviewed by Andreas Kling.

PerformanceTests:

Use the repeat() syntax to build the huge grids used by the
performance tests.

* Layout/auto-grid-lots-of-data.html:
* Layout/fixed-grid-lots-of-data.html:

Source/WebCore:

Added support for the repeat() syntax inside
grid-definition-{rows|columns} by just adding the repeated values
to our list of column|row definitions.

The parsing of <track-name> was refactored in a new function as
it's used now in three different places. The <track-size> parsing
was also refactored to share it with the repeat() parsing.

Test: fast/css-grid-layout/grid-element-repeat-get-set.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTrackNames):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseGridTrackRepeatFunction):
(WebCore::CSSParser::parseGridTrackSize):
* css/CSSParser.h:

LayoutTests:

Based on Blink r153155 by <jchaffraix@chromium.org>. Some code was
refactored in a helper function to have a more compact test.

* fast/css-grid-layout/grid-element-repeat-get-set-expected.txt: Added.
* fast/css-grid-layout/grid-element-repeat-get-set.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWindows rebaselines after r158547.
rniwa@webkit.org [Wed, 27 Nov 2013 06:14:46 +0000 (06:14 +0000)]
Windows rebaselines after r158547.

* platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
* platform/win/editing/selection/drag-text-delay-expected.txt: Added.
* platform/win/editing/selection/extend-selection-home-end-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNix upstreaming - Adding build files and supporting scripts
marcelo.lira@openbossa.org [Wed, 27 Nov 2013 06:05:27 +0000 (06:05 +0000)]
Nix upstreaming - Adding build files and supporting scripts
https://bugs.webkit.org/show_bug.cgi?id=118367

Reviewed by Ryosuke Niwa.

.:

* CMakeLists.txt:
* Source/CMakeLists.txt:
* Source/cmake/FindEGL.cmake:
* Source/cmake/FindOpenGLES2.cmake: Added.
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsNix.cmake: Added.

Source/Platform:

* CMakeLists.txt: Added.
* PlatformNix.cmake: Added.

Source/WebCore:

No new tests needed.

* CMakeLists.txt:
* PlatformNix.cmake: Added.

Source/WTF:

* wtf/FeatureDefines.h:
* wtf/Platform.h:
* wtf/PlatformNix.cmake: Added.

Tools:

* Scripts/build-webkit:
* Scripts/run-nix-tests: Added.
* Scripts/run-webkit-tests:
* Scripts/update-webkit-libs-jhbuild:
* Scripts/update-webkitnix-libs: Added.
* Scripts/webkitdirs.pm:
(determineArchitecture):
(argumentsForConfiguration):
(jscProductDir):
(builtDylibPathForName):
(determineIsNix):
(isNix):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):
(copyInspectorFrontendFiles):
(jhbuildWrapperPrefixIfNeeded):
(buildCMakeProjectOrExit):
(cmakeBasedPortName):
* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(EflWK2Port.build_webkit_command):
(NixPort):
(NixPort.build_webkit_command):
* Scripts/webkitpy/port/factory.py:
(platform_options):
(PortFactory):
* Scripts/webkitpy/port/nix.py: Added.
(NixPort):
(NixPort._wk2_port_name):
(NixPort.determine_full_port_name):
(NixPort.__init__):
(NixPort._port_flag_for_scripts):
(NixPort.setup_test_run):
(NixPort.setup_environ_for_server):
(NixPort.default_timeout_ms):
(NixPort.clean_up_test_run):
(NixPort._generate_all_test_configurations):
(NixPort._path_to_driver):
(NixPort._path_to_image_diff):
(NixPort._image_diff_command):
(NixPort._search_paths):
(NixPort.show_results_html_file):
(NixPort._port_specific_expectations_files):
(NixPort.default_baseline_search_path):
* Scripts/webkitpy/port/nix_unittest.py: Added.
(NixPortTest):
(NixPortTest._assert_search_path):
(NixPortTest._assert_expectations_files):
(NixPortTest.test_baseline_search_path):
(NixPortTest.test_expectations_files):
(NixPortTest.test_default_timeout_ms):
* jhbuild/jhbuild-wrapper:
(determine_platform):
* nix/common.py: Added.
(script_path):
(top_level_path):
* nix/jhbuild.modules: Added.
* nix/jhbuildrc: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRecord subtest values in Dromaeo tests
rniwa@webkit.org [Wed, 27 Nov 2013 05:33:17 +0000 (05:33 +0000)]
Record subtest values in Dromaeo tests
https://bugs.webkit.org/show_bug.cgi?id=124498

Reviewed by Andreas Kling.

PerformanceTests:

Made Dromaeo's test runner report values in DRT.progress via newly added PerfTestRunner.reportValues.

* Dromaeo/resources/dromaeorunner.js:
(.): Moved the definition out of DRT.setup.
(DRT.setup): Ditto.
(DRT.testObject): Extracted from DRT.setup. Set the subtest name and continueTesting.
continueTesting is set true for subtests; i.e. when name is specified.
(DRT.progress): Call PerfTestRunner.reportValues to report subtest results.
(DRT.teardown): Call PerfTestRunner.reportValues instead of measureValueAsync.

* resources/runner.js: Made various changes for newly added PerfTestRunner.reportValues.
(.): Moved the initialization of completedIterations, results, jsHeapResults, and mallocHeapResults into
start since they need to be initialized before running each subtest. Initialize logLines here since we
need to use the same logger for all subtests.
(.start): Initialize the variables mentioned above here. Also respect doNotLogStart used by reportValues.
(ignoreWarmUpAndLog): Added doNotLogProgress. Used by reportValues since it reports all values at once.
(finish): Compute the metric name such as FrameFrame and Runs from unit. Also don't log or notify done
when continueTesting is set on the test object.
(PerfTestRunner.reportValues): Added. Reports all values for the main/sub test.

Tools:

Supported parsing subtest results.

* Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
which contains a dictionary with its name and an ordered list of subtest's metrics.
(PerfTest.__init__): Initialize _metrics as a list.
(PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
(PerfTest._run_with_driver):
(PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.

* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
(TestPerfTest.test_parse_output): Ditto.
(TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
assertions to ensure subtest results are parsed properly.
(TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
adding new results.

* Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(TestWithSubtestsData): Added.
(TestDriver.run_test):
(MainTest.test_run_test_with_subtests): Added.

LayoutTests:

Rebaselined the test.

* fast/harness/perftests/runs-per-second-log-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable HTML template element on Windows ports
rniwa@webkit.org [Wed, 27 Nov 2013 05:13:51 +0000 (05:13 +0000)]
Enable HTML template element on Windows ports
https://bugs.webkit.org/show_bug.cgi?id=124758

Reviewed by Andreas Kling.

Tools:

* Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

Enable TEMPLATE_ELEMENT. Also removed UNDO_MANAGER since that feature has been removed
from the tree in r133326.

* win/tools/vsprops/FeatureDefines.props:
* win/tools/vsprops/FeatureDefinesCairo.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove replay performance tests as it's not actively maintained
rniwa@webkit.org [Wed, 27 Nov 2013 04:36:18 +0000 (04:36 +0000)]
Remove replay performance tests as it's not actively maintained
https://bugs.webkit.org/show_bug.cgi?id=124764

Reviewed by Andreas Kling.

PerformanceTests:

Removed the replay performance tests. We can add them back when time comes.

* Replay/Chinese/chinaz.com.replay: Removed.
* Replay/Chinese/www.163.com.replay: Removed.
* Replay/Chinese/www.alipay.com.replay: Removed.
* Replay/Chinese/www.baidu.com.replay: Removed.
* Replay/Chinese/www.csdn.net.replay: Removed.
* Replay/Chinese/www.douban.com.replay: Removed.
* Replay/Chinese/www.hao123.com.replay: Removed.
* Replay/Chinese/www.xinhuanet.com.replay: Removed.
* Replay/Chinese/www.xunlei.com.replay: Removed.
* Replay/Chinese/www.youku.com.replay: Removed.
* Replay/English/beatonna.livejournal.com.replay: Removed.
* Replay/English/cakewrecks.blogspot.com.replay: Removed.
* Replay/English/chemistry.about.com.replay: Removed.
* Replay/English/digg.com.replay: Removed.
* Replay/English/en.wikipedia.org-rorschach_test.replay: Removed.
* Replay/English/icanhascheezburger.com.replay: Removed.
* Replay/English/imgur.com-gallery.replay: Removed.
* Replay/English/online.wsj.com.replay: Removed.
* Replay/English/stockoverflow.com-best-comment.replay: Removed.
* Replay/English/www.alibaba.com.replay: Removed.
* Replay/English/www.amazon.com-kindle.replay: Removed.
* Replay/English/www.apple.com.replay: Removed.
* Replay/English/www.cnet.com.replay: Removed.
* Replay/English/www.dailymotion.com.replay: Removed.
* Replay/English/www.ehow.com-prevent-fire.replay: Removed.
* Replay/English/www.filestube.com-amy-adams.replay: Removed.
* Replay/English/www.foxnews.replay: Removed.
* Replay/English/www.huffingtonpost.com.replay: Removed.
* Replay/English/www.imdb.com-twilight.replay: Removed.
* Replay/English/www.mozilla.com-all-order.replay: Removed.
* Replay/English/www.php.net.replay: Removed.
* Replay/English/www.reddit.com.replay: Removed.
* Replay/English/www.telegraph.co.uk.replay: Removed.
* Replay/English/www.w3.org-htmlcss.replay: Removed.
* Replay/English/www.w3schools.com-html.replay: Removed.
* Replay/English/www.youtube.com-music.replay: Removed.
* Replay/French/www.orange.fr.replay: Removed.
* Replay/Italian/www.repubblica.it.replay: Removed.
* Replay/Japanese/2ch.net-newsplus.replay: Removed.
* Replay/Japanese/entameblog.seesaa.net.replay: Removed.
* Replay/Japanese/ja.wikipedia.org.replay: Removed.
* Replay/Japanese/www.hatena.ne.jp.replay: Removed.
* Replay/Japanese/www.livedoor.com.replay: Removed.
* Replay/Japanese/www.nicovideo.jp.replay: Removed.
* Replay/Japanese/www.rakuten.co.jp.replay: Removed.
* Replay/Japanese/www.yahoo.co.jp.replay: Removed.
* Replay/Korean/www.naver.com.replay: Removed.
* Replay/Persian/blogfa.com.replay: Removed.
* Replay/Polish/www.wp.pl.replay: Removed.
* Replay/Portuguese/www.uol.com.br.replay: Removed.
* Replay/Russian/lenta.ru.replay: Removed.
* Replay/Russian/vkontakte.ru-help.replay: Removed.
* Replay/Russian/www.ixbt.com.replay: Removed.
* Replay/Russian/www.kp.ru.replay: Removed.
* Replay/Russian/www.liveinternet.ru.replay: Removed.
* Replay/Russian/www.pravda.ru.replay: Removed.
* Replay/Russian/www.rambler.ru.replay: Removed.
* Replay/Russian/www.ucoz.ru.replay: Removed.
* Replay/Russian/www.yandex.ru.replay: Removed.
* Replay/Spanish/www.taringa.net.replay: Removed.
* Replay/Swedish/www.flashback.se.replay: Removed.
* Replay/Swedish/www.tradera.com.replay: Removed.
* Replay/www.google.com.replay: Removed.
* Replay/www.techcrunch.com.replay: Removed.
* Replay/www.youtube.com.replay: Removed.

Tools:

Removed the feature.

* Scripts/webkitpy/performance_tests/perftest.py:
(SingleProcessPerfTest.__init__):
(PerfTestFactory):
* Scripts/webkitpy/performance_tests/perftest_unittest.py:
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
(PerfTestsRunner._collect_tests):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_collect_tests_with_ignored_skipped_list):
(MainTest.test_default_args):
* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_unittest2):
* Scripts/webkitpy/thirdparty/__init___unittest.py:
(ThirdpartyTest.test_imports):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImport W3C tests for cloning template elements and default stylesheet for template...
rniwa@webkit.org [Wed, 27 Nov 2013 04:32:51 +0000 (04:32 +0000)]
Import W3C tests for cloning template elements and default stylesheet for template element
https://bugs.webkit.org/show_bug.cgi?id=124882

Reviewed by Andreas Kling.

Imported tests under html-templates/additions-to-the-steps-to-clone-a-node and
html-templates/additions-to-the-css-user-agent-style-sheet at d38dbd5b492808811bc0fe04a8cc49f28863c5cc.

Renamed and replicated css-user-agent-style-sheet-test-001-ref.html as -00*-expected.html for ref testing.

* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-001-expected.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-001.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-002-expected.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-002.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-003-expected.html: Added.
* html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-003.html: Added.
* html-templates/additions-to-the-steps-to-clone-a-node/template-clone-children-expected.txt: Added.
* html-templates/additions-to-the-steps-to-clone-a-node/template-clone-children.html: Added.
* html-templates/additions-to-the-steps-to-clone-a-node/templates-copy-document-owner-expected.txt: Added.
* html-templates/additions-to-the-steps-to-clone-a-node/templates-copy-document-owner.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable aggressive DFG validation in testing
fpizlo@apple.com [Wed, 27 Nov 2013 04:05:12 +0000 (04:05 +0000)]
Enable aggressive DFG validation in testing
https://bugs.webkit.org/show_bug.cgi?id=124911

Rubber stamped by Ryosuke Niwa.

This enables validation testing in non-concurrent-JIT runs.

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159801 268f45cc-cd09-0410-ab3c-d52691b4dbfc