WebKit-https.git
17 years ago Reviewed by John.
mjs [Tue, 9 Dec 2003 22:26:20 +0000 (22:26 +0000)]
    Reviewed by John.

<rdar://problem/3505183>: JavaScriptCore should assert that interpreter is locked in collector

        * kjs/collector.cpp:
        (KJS::Collector::allocate): Assert that interpreter lock count is not 0.
        (KJS::Collector::collect): likewise

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin.
mjs [Tue, 9 Dec 2003 22:26:12 +0000 (22:26 +0000)]
    Reviewed by Darin.

<rdar://problem/3501030>: JavaScript sites crash when a PAC file is in place (WebCore,Safari 1.2)

        * khtml/ecma/kjs_events.cpp:
        (JSEventListener::handleEvent): Lock interpreter when needed.
        (JSLazyEventListener::parseCode): Likewise.
        (KJS::getDOMEvent): Likewise.
        * khtml/ecma/kjs_proxy.cpp:
        (KJSProxyImpl::evaluate): Likewise.
        (KJSProxyImpl::initScript): Likewise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3491235, really make <script src="..."/> work in HTML. My original attempt...
hyatt [Tue, 9 Dec 2003 22:11:56 +0000 (22:11 +0000)]
Fix for 3491235, really make <script src="..."/> work in HTML.  My original attempt to fix this only made
the tag flat, but did not ensure that the script got processed.

        Reviewed by john

        * khtml/html/htmltokenizer.cpp:
        (HTMLTokenizer::parseTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
cblu [Tue, 9 Dec 2003 21:52:36 +0000 (21:52 +0000)]
WebKit:

Fixed: <rdar://problem/3504237>: add downloaded certificates to keychain

        Reviewed by darin.

        * WebCoreSupport.subproj/WebKeyGeneration.cpp:
        (signedPublicKeyAndChallengeString):
        (addCertificateToKeyChainFromData): new
        (addCertificateToKeyChainFromFile): new
        * WebCoreSupport.subproj/WebKeyGeneration.h:
        * WebCoreSupport.subproj/WebKeyGenerator.h:
        * WebCoreSupport.subproj/WebKeyGenerator.m:
        (-[WebKeyGenerator addCertificateToKeyChainFromFileAtPath:]): new
        * WebKit.exp:
        * WebKit.pbproj/project.pbxproj: made WebKeyGenerator.h private

WebBrowser:

Fixed: <rdar://problem/3504237>: add downloaded certificates to keychain

        Reviewed by darin.

        * DownloadProgressEntry.m:
        (-[DownloadProgressEntry _addCertificateToKeyChain]): new, calls [WebKeyGenerator addCertificateToKeyChainFromFileAtPath:]
        (-[DownloadProgressEntry autoOpen]): call _addCertificateToKeyChain

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - fixed <rdar://problem/3504907>: REGRESSION (100-116):
sullivan [Tue, 9 Dec 2003 21:23:07 +0000 (21:23 +0000)]
    - fixed <rdar://problem/3504907>: REGRESSION (100-116):
        Clicking QuickTime-requiring link twice crashes (wholenote.com)

        I found the bug; Darin wrote the fix; I reviewed and tested.

        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage stringForStringListID:andIndex:]):
        Rewrote this method to not use GetIndString, because GetIndString looks
        at all open resource files and in this case was reading information from
        the wrong plugin file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdding a dynamic cell array test.
hyatt [Tue, 9 Dec 2003 19:56:10 +0000 (19:56 +0000)]
Adding a dynamic cell array test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3503652, news.com misrenders badly (footer is out of position). My fix...
hyatt [Tue, 9 Dec 2003 06:58:56 +0000 (06:58 +0000)]
Fix for 3503652, news.com misrenders badly (footer is out of position).  My fix to 3495748 caused this
regression.  I made the tag priority of <nobr> too high.  It needed to be the same as <div>, and I
accidentally made it higher.  I intended for it to be the same as <div>.

I also had to make a fix (now that <nobr> has a higher priority) to ensure <nobr> can't be nested inside
other <nobr>.

Both fixes were required to make news.com render correctly again.

        Reviewed by darin

        * khtml/html/dtd.cpp:
        * khtml/html/htmlparser.cpp:
        (KHTMLParser::getElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
cblu [Tue, 9 Dec 2003 02:12:56 +0000 (02:12 +0000)]
WebCore:

Fixed: <rdar://problem/3234676>: Support for KEYGEN tag (ie 509 email certificates from www.thawte.com)

        Reviewed by mjs.

        * WebCore-combined.exp:
        * WebCore.exp:
        * WebCore.pbproj/project.pbxproj:
        * khtml/html/html_formimpl.cpp:
        (HTMLKeygenElementImpl::parseAttribute): store the KEYTYPE attribute
        (HTMLKeygenElementImpl::encoding): call KSSLKeyGen::signedPublicKeyAndChallengeString
        * khtml/html/html_formimpl.h: remove 2 declared but unimplemented methods
        * khtml/misc/htmlattrs.c: generated changes
        (hash_attr):
        (findAttr):
        * khtml/misc/htmlattrs.h: generated change
        * khtml/misc/htmlattrs.in: added KEYTYPE
        * kwq/KWQKSSLKeyGen.h:
        * kwq/KWQKSSLKeyGen.mm:
        (KSSLKeyGen::supportedKeySizes): call renamed strengthMenuItemTitles
        (KSSLKeyGen::signedPublicKeyAndChallengeString): new, calls [WebCoreKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]
        * kwq/WebCoreKeyGenerationFactory.h: Added.
        * kwq/WebCoreKeyGenerationFactory.m: Added.
        (+[WebCoreKeyGenerationFactory sharedFactory]):
        (-[WebCoreKeyGenerationFactory init]):
        (-[WebCoreKeyGenerationFactory strengthMenuItemTitles]):
        (-[WebCoreKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]):
        * kwq/WebCoreLocalizedStringFactory.h: Removed.
        * kwq/WebCoreLocalizedStringFactory.m: Removed.

WebKit:

Fixed: <rdar://problem/3234676>: Support for KEYGEN tag (ie 509 email certificates from www.thawte.com)

        Reviewed by mjs.

        * WebCoreSupport.subproj/WebKeyGeneration.cpp: Added.
        (gnrAddContextAttribute): new
        (gnrGetSubjPubKey): new
        (gnrNullAlgParams): new
        (gnrSign): new
        (gnrFreeCssmData): new
        (signedPublicKeyAndChallengeString): new
        * WebCoreSupport.subproj/WebKeyGeneration.h: Added.
        * WebCoreSupport.subproj/WebKeyGenerationFactory.h: Added. Renamed from WebLocalizedStringFactory.
        * WebCoreSupport.subproj/WebKeyGenerationFactory.m: Added.
        (+[WebKeyGenerationFactory createSharedFactory]): no change
        (-[WebKeyGenerationFactory dealloc]): no change
        (-[WebKeyGenerationFactory strengthMenuItemTitles]): new
        (-[WebKeyGenerationFactory signedPublicKeyAndChallengeStringWithStrengthIndex:challenge:]): new
        * WebCoreSupport.subproj/WebLocalizedStringFactory.h: Removed.
        * WebCoreSupport.subproj/WebLocalizedStringFactory.m: Removed.
        * WebCoreSupport.subproj/WebNetscapeTemplates.cpp: Added.
        * WebCoreSupport.subproj/WebNetscapeTemplates.h: Added.
        * WebKit.pbproj/project.pbxproj:
        * WebKitPrefix.h:
        * WebView.subproj/WebFrameView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
mjs [Tue, 9 Dec 2003 01:02:38 +0000 (01:02 +0000)]
    Reviewed by Ken.

<rdar://problem/3504047>: XMLHttpRequest object needs onload event

* khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::getValueProperty): Implemented onload property.
        (KJS::XMLHttpRequest::putValue): Ditto.
        (KJS::XMLHttpRequest::XMLHttpRequest): Ditto.
        (KJS::XMLHttpRequest::changeState): Ditto.
        * khtml/ecma/xmlhttprequest.h:
        * khtml/ecma/xmlhttprequest.lut.h: Regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoJavaScriptCore:
rjw [Tue, 9 Dec 2003 00:53:54 +0000 (00:53 +0000)]
JavaScriptCore:
LiveConnect:  The last piece of the JavaScript side of the
LiveConnect implementation.  This change adds support for
setting/getting values from Java arrays in JavaScript.

        Reviewed by John.

        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        (JavaField::JavaField):
        (convertJObjectToArray):
        (JavaArray::JavaArray):
        (JavaArray::~JavaArray):
        (JavaArray::setValueAt):
        (JavaArray::valueAt):
        (JavaArray::getLength):
        * bindings/jni/jni_runtime.h:
        (Bindings::JavaArray::operator=):
        (Bindings::JavaArray::javaArray):
        * bindings/jni/jni_utility.cpp:
        (JNITypeFromPrimitiveType):
        (convertValueToJValue):
        * bindings/jni/jni_utility.h:
        * bindings/runtime.h:
        * bindings/runtime_array.cpp:
        (RuntimeArrayImp::RuntimeArrayImp):
        (RuntimeArrayImp::~RuntimeArrayImp):
        (RuntimeArrayImp::get):
        (RuntimeArrayImp::put):
        (RuntimeArrayImp::hasProperty):
        * bindings/runtime_array.h:
        (KJS::RuntimeArrayImp::getLength):
        (KJS::RuntimeArrayImp::getConcreteArray):
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::get):
        (RuntimeObjectImp::canPut):
        (RuntimeObjectImp::hasProperty):

Tests:
        LiveConnect:  Added tests for JavaScript to Java
        array access.

        Reviewed by John.

        * LiveConnect/Blink/Blink.java:
        (Blink):
        (Blink.init):
        * LiveConnect/Blink/test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdd asahi.com layout test.
hyatt [Mon, 8 Dec 2003 23:51:45 +0000 (23:51 +0000)]
Add asahi.com layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3503022, asahi.com is too wide. Bugs in line breaking of breakable Japanese...
hyatt [Mon, 8 Dec 2003 23:50:26 +0000 (23:50 +0000)]
Fix for 3503022, asahi.com is too wide.  Bugs in line breaking of breakable Japanese characters caused
the breaks to be ignored.

        Reviewed by john

        * khtml/rendering/render_text.cpp:
        (RenderText::calcMinMaxWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix the position method to return screen coords like it should and to use the lower...
hyatt [Mon, 8 Dec 2003 19:44:04 +0000 (19:44 +0000)]
Fix the position method to return screen coords like it should and to use the lower left corner instead of
the upper left.

        Reviewed by john

        * kwq/KWQAccObject.h:
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject position]):
        (-[KWQAccObject size]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John.
darin [Mon, 8 Dec 2003 16:45:07 +0000 (16:45 +0000)]
    Reviewed by John.

        - fixed 3502347: REGRESSION (100-116): bottom of login window sometimes missing (TR background image)

        * khtml/rendering/render_object.h: Added setPixmap.
        * khtml/rendering/render_object.cpp: (RenderObject::setPixmap): Moved this
        function here from RenderBox. This code is needed for the table row class and
        similar classes that supply a background image that is drawn by the table cell,
        and those are not RenderBox subclasses.

        * khtml/rendering/render_box.cpp: Removed setPixmap.
        * khtml/rendering/render_box.h: Removed setPixmap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - fixed <rdar://problem/3502655>: REGRESSION: Repro crash at espn.com
sullivan [Mon, 8 Dec 2003 06:04:13 +0000 (06:04 +0000)]
    - fixed <rdar://problem/3502655>: REGRESSION: Repro crash at espn.com

        Reviewed by Darin.

        * khtml/html/html_objectimpl.cpp:
        (HTMLAppletElementImpl::getAppletInstance):
        Check for nil RenderApplet before dereferencing rather than after.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Add support for link clicking as an accessibility action.
hyatt [Fri, 5 Dec 2003 23:22:01 +0000 (23:22 +0000)]
Add support for link clicking as an accessibility action.

        Reviewed by john

        * kwq/KWQAccObject.mm:
        (-[KWQAccObject anchorElement]):
        (-[KWQAccObject role]):
        (-[KWQAccObject accessibilityAttributeNames]):
        (-[KWQAccObject accessibilityActionNames]):
        (-[KWQAccObject accessibilityActionDescription:]):
        (-[KWQAccObject accessibilityPerformAction:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoJavaScriptCore:
rjw [Fri, 5 Dec 2003 23:05:10 +0000 (23:05 +0000)]
JavaScriptCore:
LiveConnect:  Part 1 of supporting JS bindings to
native language arrays.

        Reviewed by Chris.

        * JavaScriptCore.pbproj/project.pbxproj:
        * bindings/jni/jni_runtime.cpp:
        (JavaField::JavaField):
        (convertJObjectToArray):
        (JavaField::valueFromInstance):
        (JavaField::setValueToInstance):
        * bindings/jni/jni_runtime.h:
        * bindings/runtime.cpp:
        (Instance::setValueOfField):
        * bindings/runtime.h:
        (Bindings::Array::~Array):

Tests:
        Added tests to access Java arrays.

        Reviewed by Chris.

        * LiveConnect/Blink/Blink.java:
        (Blink):
        (Blink.init):
        * LiveConnect/Blink/test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John.
mjs [Fri, 5 Dec 2003 22:03:07 +0000 (22:03 +0000)]
    Reviewed by John.

<rdar://problem/3487222>: Add ability to create working fully standalone document object

        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::CSSStyleSelector):
        (khtml::CSSStyleSelector::addSheet):
        (khtml::CSSStyleSelector::initForStyleResolve):
        (khtml::CSSStyleSelector::applyRule):
        * khtml/dom/dom_doc.cpp:
        (DOM::Document::part):
        * khtml/dom/dom_doc.h:
        * khtml/ecma/kjs_dom.cpp:
        (DOMDocument::getValueProperty):
        (KJS::checkNodeSecurity):
        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLDocFunction::tryCall):
        (KJS::HTMLDocument::tryGet):
        (KJS::HTMLDocument::putValue):
        (KJS::HTMLElement::tryGet):
        (Image::notifyFinished):
        * khtml/ecma/kjs_traversal.cpp:
        (JSNodeFilter::acceptNode):
        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::changeState):
        * khtml/html/html_baseimpl.cpp:
        (HTMLBodyElementImpl::insertedIntoDocument):
        (HTMLFrameElementImpl::isURLAllowed):
        (HTMLFrameElementImpl::attach):
        (HTMLFrameElementImpl::detach):
        (HTMLFrameElementImpl::contentDocument):
        (HTMLIFrameElementImpl::attach):
        * khtml/html/html_documentimpl.cpp:
        (HTMLDocumentImpl::referrer):
        (HTMLDocumentImpl::lastModified):
        * khtml/html/html_formimpl.cpp:
        (HTMLFormElementImpl::formData):
        (HTMLFormElementImpl::prepareSubmit):
        (HTMLFormElementImpl::submit):
        (HTMLFormElementImpl::reset):
        (HTMLGenericFormElementImpl::isKeyboardFocusable):
        (HTMLGenericFormElementImpl::defaultEventHandler):
        * khtml/html/html_headimpl.cpp:
        (HTMLBaseElementImpl::process):
        (HTMLLinkElementImpl::process):
        * khtml/html/html_inlineimpl.cpp:
        (HTMLAnchorElementImpl::isKeyboardFocusable):
        (HTMLAnchorElementImpl::defaultEventHandler):
        * khtml/html/html_objectimpl.cpp:
        (HTMLAppletElementImpl::createRenderer):
        (HTMLAppletElementImpl::getAppletInstance):
        (HTMLEmbedElementImpl::rendererIsNeeded):
        (HTMLObjectElementImpl::rendererIsNeeded):
        * khtml/html/htmltokenizer.cpp:
        (HTMLTokenizer::scriptExecution):
        (HTMLTokenizer::parseTag):
        * khtml/rendering/render_applet.cpp:
        (RenderApplet::RenderApplet):
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::setTitle):
        (DocumentImpl::part):
        (DocumentImpl::close):
        (DocumentImpl::processHttpEquiv):
        * khtml/xml/dom_docimpl.h:
        * khtml/xml/dom_nodeimpl.cpp:
        (NodeImpl::dispatchEvent):
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject textUnderElement]):
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::partForNode):
        (KWQKHTMLPart::attributedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed 3501885. Added null test to returned node from collection.
rjw [Fri, 5 Dec 2003 22:00:06 +0000 (22:00 +0000)]
Fixed 3501885.  Added null test to returned node from collection.

        Reviewed by John.

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLCollection::tryGet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - fixed <rdar://problem/3491427>: REGRESSION (100-114): multi-page HTML
sullivan [Fri, 5 Dec 2003 18:06:33 +0000 (18:06 +0000)]
    - fixed <rdar://problem/3491427>: REGRESSION (100-114): multi-page HTML
        content in Mail is blank when printed

        Darin and I figured this one out.

        Reviewed by Ken.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
        Don't call setNeedsDisplay:NO when we're turning printing on, as doing so prevents
        anything from drawing in the case where this is called from
        adjustPageHeightsNew:top:bottom:limit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John.
darin [Fri, 5 Dec 2003 16:52:36 +0000 (16:52 +0000)]
    Reviewed by John.

        - fixed  regression in small caps with substituted fonts my patch from yesterday caused
        - fixed 3463599: if Lucida font is installed, you see bad glyphs on pages that use it (advogato.org)
        - fixed storage leak if a renderer is ever deallocated (I don't think we ever do that)
        - fixed some small leaks in various error cases by adding appropriate free and dispose calls

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer dealloc]): Free the Unicode glyph map too.
        (fontContainsString): Moved inline function up here so it will be inlined.
        (-[WebTextRenderer _setupFont]): Free the glyph map and set it back to zero if we fail after
        extending the glyph map to include space. This fixes the "wrong glyph codes" bug with Lucida above.
        (-[WebTextRenderer _extendUnicodeCharacterToGlyphMapToInclude:]): Add free calls needed to avoid
        storage leaks in failure cases.
        (-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]): Ditto.
        (-[WebTextRenderer _initializeATSUStyle]): Add ATSUDisposeStyle to fix storage leak.
        (freeWidthMap): Use a loop instead of recursion.
        (freeGlyphMap): Use a loop instead of recursion.
        (freeUnicodeGlyphMap): Added.
        (widthForNextCharacter): Don't use the original characters or cluster length, because the
        character may have been capitalized for use in small caps rendering. So check the character
        for <= 0xFFFF instead of looking at clusterLength, and break the character into a local array
        instead of using the original character pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Richard.
darin [Fri, 5 Dec 2003 01:27:10 +0000 (01:27 +0000)]
    Reviewed by Richard.

        - fixed 3497879: REGRESSION (100-115): all non-BMP characters (including Deseret) are broken

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _CG_pointToOffset:style:position:reversed:]): Bump offset by getting it from
        the iterator; don't assume we can just bump it by one each time. It would be even nicer to have
        a bit more abstraction.
        (initializeCharacterWidthIterator): Remove call to initializeCharacterShapeIterator.
        (widthForNextCharacter): Move handling of surrogate pairs (non-BMP) in here and unify it with
        the handling of BMP characters; this removes the broken code that was returning the wrong font,
        and changes us to use the code that was already doing the right thing for the surrogate pair case.
        Also get rid of the use of 0 width to mean "no glyph", which fixes the doubled glyph problem.
        Also got rid of remnants of use of the shape iterator.

        * Misc.subproj/WebUnicode.h: Remove obsolete shape iterator.
        * Misc.subproj/WebUnicode.m: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoJavaScriptCore:
rjw [Fri, 5 Dec 2003 01:05:49 +0000 (01:05 +0000)]
JavaScriptCore:
LiveConnect:  Moved defaultValue into concrete implementation because
more intelligent conversion can be perform with knowledge
of the class of the original instance.

        Reviewed by Chris.

        * bindings/jni/jni_class.cpp:
        (JavaClass::isNumberClass):
        (JavaClass::isBooleanClass):
        (JavaClass::isStringClass):
        * bindings/jni/jni_class.h:
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::defaultValue):
        (JavaInstance::valueOf):
        * bindings/jni/jni_instance.h:
        (Bindings::JavaInstance::javaInstance):
        * bindings/runtime.h:
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::defaultValue):

Tests:
        Fixed incorrect log of boolean type.

        Reviewed by Chris.

        * LiveConnect/Blink/test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoJavaScriptCore:
rjw [Fri, 5 Dec 2003 00:28:00 +0000 (00:28 +0000)]
JavaScriptCore:
LiveConnect:  Added support for setting the value of Java
fields.

        Reviewed by Chris.

        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bindings/jni/jni_runtime.cpp:
        (JavaParameter::JavaParameter):
        (JavaField::JavaField):
        (JavaField::valueFromInstance):
        (JavaField::setValueToInstance):
        (JavaMethod::JavaMethod):
        * bindings/jni/jni_runtime.h:
        (Bindings::JavaField::getJNIType):
        * bindings/jni/jni_utility.cpp:
        (JNITypeFromClassName):
        (convertValueToJValue):
        * bindings/jni/jni_utility.h:
        * bindings/runtime.cpp:
        (Instance::setValueOfField):
        * bindings/runtime.h:
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::get):
        (RuntimeObjectImp::put):
        (RuntimeObjectImp::defaultValue):

Tests:
        Added test of setting Java fields from JavaScript.

        Reviewed by Chris.

        * LiveConnect/Blink/Holder.java:
        (Holder):
        * LiveConnect/Blink/test.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
rjw [Thu, 4 Dec 2003 22:33:12 +0000 (22:33 +0000)]
WebCore:
Added support for named applet access from document node.
Factored creation of KJS::Values from RuntimeObjectImps.

        Reviewed by Chris.

        * khtml/ecma/kjs_dom.cpp:
        (KJS::getDOMNamedNodeMap):
        (KJS::getRuntimeObject):
        * khtml/ecma/kjs_dom.h:
        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLDocument::tryGet):
        (KJS::HTMLElement::tryGet):
        (KJS::HTMLCollection::tryGet):

JavaScriptCore:
Added support for string conversions.
Changed various JavaString member variables to be inline.
Implemented defaultValue for context relevant type coercion.

        Reviewed by Chris.

        * bindings/jni/jni_class.cpp:
        (JavaClass::JavaClass):
        (JavaClass::setClassName):
        (JavaClass::classForInstance):
        * bindings/jni/jni_class.h:
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::stringValue):
        (JavaInstance::numberValue):
        (JavaInstance::booleanValue):
        (JavaInstance::invokeMethod):
        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        (JavaParameter::JavaParameter):
        (JavaField::JavaField):
        (JavaMethod::JavaMethod):
        (appendClassName):
        (JavaMethod::signature):
        * bindings/jni/jni_runtime.h:
        (Bindings::JavaString::JavaString):
        (Bindings::JavaString::~JavaString):
        (Bindings::JavaString::operator=):
        (Bindings::JavaString::characters):
        (Bindings::JavaParameter::JavaParameter):
        (Bindings::JavaParameter::~JavaParameter):
        (Bindings::JavaParameter::operator=):
        (Bindings::JavaParameter::type):
        (Bindings::JavaField::JavaField):
        (Bindings::JavaField::~JavaField):
        (Bindings::JavaField::operator=):
        (Bindings::JavaField::name):
        (Bindings::JavaField::type):
        (Bindings::JavaMethod::JavaMethod):
        (Bindings::JavaMethod::_commonDelete):
        (Bindings::JavaMethod::name):
        (Bindings::JavaMethod::returnType):
        * bindings/jni/jni_utility.cpp:
        (convertValueToJValue):
        * bindings/runtime.h:
        (Bindings::Instance::valueOf):
        * bindings/runtime_method.cpp:
        (RuntimeMethodImp::call):
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::RuntimeObjectImp):
        (RuntimeObjectImp::get):
        (RuntimeObjectImp::defaultValue):
        * bindings/runtime_object.h:
        (KJS::RuntimeObjectImp::classInfo):

Tests:
        Added tests passing various parameters type to Java methods.

        Reviewed by Chris.

        * LiveConnect/Blink/Blink.java:
        (Blink):
        (Blink.setTextWithString):
        (Blink.setTextWithNumberValueUsingByte):
        (Blink.setTextWithNumberValueUsingShort):
        (Blink.setTextWithNumberValueUsingInt):
        (Blink.setTextWithNumberValueUsingLong):
        (Blink.setTextWithNumberValueUsingFloat):
        (Blink.setTextWithNumberValueUsingDouble):
        (Blink.setTextWithNumberValueUsingChar):
        (Blink.setTextWithNumberValueUsingBoolean):
        * LiveConnect/Blink/Blink.pbproj/project.pbxproj:
        * LiveConnect/Blink/test.html:
        * PDFBundle/PDFBundle.pbproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John.
darin [Thu, 4 Dec 2003 19:45:42 +0000 (19:45 +0000)]
    Reviewed by John.

        - fixed 3498712: REGRESSION (100-115): Safari aborts at http://www11.dht.dk/~blangstrup_org/

        This was an uncaught exception thrown by DocumentImpl. But the design of KHTML DOM is that
        "impl" classes return exception codes; they don't throw exceptions.

        * khtml/dom/dom_doc.cpp:
        (DOM::Document::createElement): Throw exception if necessary. The impl function now returns
        an exception code.
        (DOM::Document::createElementNS): Ditto.

        * khtml/html/html_documentimpl.h: Add exception code parameter to createElement.
        * khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::createElement): Pass along the
        exception code from the lower level.

        * khtml/xml/dom_docimpl.h: Add exception code parameters to createElement, createElementNS,
        and createHTMLElement.
        * khtml/xml/dom_docimpl.cpp:
        (DOMImplementationImpl::createDocument): Handle exception code from createElementNS.
        (DocumentImpl::createElement): Add exception code parameter, not set since there is
        no exception.
        (DocumentImpl::importNode): Handle exception code from createElementNS.
        (DocumentImpl::createElementNS): Add exception code parameter. Propagate the exception
        codes that we get from createHTMLElement and setPrefix.
        (DocumentImpl::createHTMLElement): Add exception code parameter. Use an exception code
        rather than a C++ exception for INVALID_CHARACTER_ERR.

        * khtml/xml/dom_elementimpl.cpp: (ElementImpl::cloneNode): Pass exception code parameter to
        createElement.

        * khtml/xml/xml_tokenizer.cpp:
        (XMLHandler::startElement): Pass exception code parameter to createElementNS, and return false
        if it is not zero. This is where the bug happened. Before we would get an exception from
        createElementNS, but "impl" functions are not supposed to throw in KHTML's DOM.
        (XMLTokenizer::finish): Add various exception code parameters to compile, but we know we won't
        get any exceptions.

        * kwq/WebCoreDOMDocument.mm:
        (-[WebCoreDOMDocument createElement:]): Pass an (ignored) exception code parameter.
        (-[WebCoreDOMDocument createElementNS::]): Pass an (ignored) exception code parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agothe tree is open for Safari-117
vicki [Thu, 4 Dec 2003 19:01:16 +0000 (19:01 +0000)]
the tree is open for Safari-117

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoSafari-116, Safari 1.2 stamp
vicki [Thu, 4 Dec 2003 18:57:43 +0000 (18:57 +0000)]
Safari-116, Safari 1.2 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
darin [Thu, 4 Dec 2003 16:28:01 +0000 (16:28 +0000)]
    Reviewed by Ken.

        - fixed 3498426: assertion failure in tooltip code at macosx.apple.com

        * WebView.subproj/WebHTMLView.m: (-[WebHTMLView _setToolTip:]): Work around
        the apparent bug in AppKit (3500217) that causes it to return 0 for the tool tip
        tag by using removeAllToolTips and not storing the tag at all. Besides the assertion
        failure there may also be a symptom of a "stuck" tool tip and a small memory
        leak until the window is closed.
        * WebView.subproj/WebHTMLViewPrivate.h: Remove unused toolTipTag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
rjw [Thu, 4 Dec 2003 01:41:24 +0000 (01:41 +0000)]
WebCore:
LiveConnect:  Removed some debugging.

        Reviewed by Chris.

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLCollection::tryGet):

JavaScriptCore:
LiveConnect:  Added support for parameter passing to Java and conversion
of return values.

        Reviewed by Chris.

        * bindings/jni/jni_instance.cpp:
        (JavaInstance::invokeMethod):
        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        (JavaParameter::JavaParameter):
        (JavaMethod::JavaMethod):
        (JavaMethod::signature):
        * bindings/jni/jni_runtime.h:
        (Bindings::JavaParameter::JavaParameter):
        (Bindings::JavaParameter::operator=):
        (Bindings::JavaParameter::getJNIType):
        * bindings/jni/jni_utility.cpp:
        (callJNIBooleanMethodA):
        (convertValueToJValue):
        * bindings/jni/jni_utility.h:
        * bindings/runtime.h:
        * bindings/runtime_method.cpp:
        (RuntimeMethodImp::call):
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3475761, list bullets mislayout after text zooming.
hyatt [Thu, 4 Dec 2003 00:17:14 +0000 (00:17 +0000)]
Fix for 3475761, list bullets mislayout after text zooming.

        Reviewed by kocienda

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::setStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3493356, table cells didn't repaint properly.
hyatt [Wed, 3 Dec 2003 22:46:42 +0000 (22:46 +0000)]
Fix for 3493356, table cells didn't repaint properly.

        Reviewed by kocienda

        * khtml/rendering/render_object.cpp:
        (RenderObject::repaintObjectsBeforeLayout):
        * khtml/rendering/render_table.cpp:
        (RenderTableCell::getAbsoluteRepaintRect):
        * khtml/rendering/render_table.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago*** empty log message ***
hyatt [Wed, 3 Dec 2003 22:07:32 +0000 (22:07 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3495748, hang in parser at ocelot.ca. <nobr> needs to have very high priori...
hyatt [Wed, 3 Dec 2003 22:04:45 +0000 (22:04 +0000)]
Fix for 3495748, hang in parser at ocelot.ca.  <nobr> needs to have very high priority (equal to the
priority of blocks like h1-6, p, and div), so that unclosed <nobr>s will close divs and ps.

        Reviewed by gramps

        * khtml/html/dtd.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3475767, hang at saabnet.com. Fix h1-h6 to be more tolerant regarding allow...
hyatt [Wed, 3 Dec 2003 20:58:20 +0000 (20:58 +0000)]
Fix for 3475767, hang at saabnet.com.  Fix h1-h6 to be more tolerant regarding allowed child elements, to avoid
deeply nested pages.

        Reviewed by darin

        * khtml/html/dtd.cpp:
        (DOM::checkChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago - fixed these two design issues after Dave and I talked to HI:
sullivan [Wed, 3 Dec 2003 20:50:36 +0000 (20:50 +0000)]
    - fixed these two design issues after Dave and I talked to HI:
        <rdar://problem/3497072>: There shouldn't be a focus ring around clicked regions
        <rdar://problem/3499315>: Focus ring should use aqua color always

        Reviewed by Dave.

        * khtml/css/html4.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
mjs [Wed, 3 Dec 2003 19:46:12 +0000 (19:46 +0000)]
    Reviewed by Ken.

<rdar://problem/3395759>: results of parent.document.getElementsByTagName can't be added to string

* khtml/ecma/kjs_dom.cpp:
        (DOMNodeList::toPrimitive): Always convert to string instead of trying to convert
to number and failing, as is done for DOMNode.
        * khtml/ecma/kjs_dom.h: Prototype new method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
rjw [Wed, 3 Dec 2003 01:21:39 +0000 (01:21 +0000)]
WebCore:
Return a value that is backed by RuntimeObjectImpl, instead
of a DOM object for applet[0].  This is better than having
the DOM object redirect to the RuntimeObjectImpl.

        Reviewed by Chris.

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLCollection::tryGet):

JavaScriptCore:
Added support for calling simple methods in Java from JavaScript.
(void return and no parameters).  Yay, LiveConnect lives.

Still need write argument and return value conversion code.

        Reviewed by Chris.

        * JavaScriptCore.pbproj/project.pbxproj:
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::getClass):
        (JavaInstance::invokeMethod):
        * bindings/jni/jni_instance.h:
        * bindings/jni/jni_runtime.cpp:
        (JavaMethod::JavaMethod):
        (JavaMethod::signature):
        (JavaMethod::JNIReturnType):
        * bindings/jni/jni_runtime.h:
        (Bindings::JavaMethod::_commonDelete):
        (Bindings::JavaMethod::_commonCopy):
        (Bindings::JavaMethod::name):
        * bindings/jni/jni_utility.cpp:
        (signatureFromPrimitiveType):
        * bindings/jni/jni_utility.h:
        * bindings/runtime.h:
        * bindings/runtime_method.cpp: Added.
        (RuntimeMethodImp::RuntimeMethodImp):
        (RuntimeMethodImp::~RuntimeMethodImp):
        (RuntimeMethodImp::get):
        (RuntimeMethodImp::implementsCall):
        (RuntimeMethodImp::call):
        (RuntimeMethodImp::codeType):
        (RuntimeMethodImp::execute):
        * bindings/runtime_method.h: Added.
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::RuntimeObjectImp):
        (RuntimeObjectImp::get):
        * bindings/runtime_object.h:
        * kjs/function.cpp:
        (FunctionImp::FunctionImp):
        * kjs/interpreter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John.
mjs [Wed, 3 Dec 2003 01:09:01 +0000 (01:09 +0000)]
    Reviewed by John.

<rdar://problem/3488220>: namespaces test from David Faure causes Safari to crash in DOM::DocumentImpl::createElementNS

        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::createElementNS): Check if new element is NULL
before messing with it, to avoid a crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3497999, null check the text() of RenderTexts to avoid a crash in current().
hyatt [Tue, 2 Dec 2003 23:19:11 +0000 (23:19 +0000)]
Fix for 3497999, null check the text() of RenderTexts to avoid a crash in current().

        Reviewed by kocienda

        * khtml/rendering/bidi.cpp:
        (khtml::BidiIterator::current):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin.
mjs [Tue, 2 Dec 2003 23:13:50 +0000 (23:13 +0000)]
    Reviewed by Darin.

Implemented a simple form of document serialization, enough to take care of:

<rdar://problem/3487190>: implement send of DOMDocument for XMLHttpRequest

        * khtml/dom/dom_doc.cpp:
        (DOM::Document::toString):
        * khtml/dom/dom_doc.h:
        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::urlMatchesDocumentDomain):
        (KJS::XMLHttpRequestProtoFunc::tryCall):
        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::toString):
        * khtml/html/html_elementimpl.h:
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::toString):
        (DocumentFragmentImpl::toString):
        (DocumentTypeImpl::copyFrom):
        (DocumentTypeImpl::toString):
        * khtml/xml/dom_docimpl.h:
        * khtml/xml/dom_elementimpl.cpp:
        (AttrImpl::toString):
        (ElementImpl::openTagStartToString):
        (ElementImpl::toString):
        * khtml/xml/dom_elementimpl.h:
        * khtml/xml/dom_nodeimpl.h:
        * khtml/xml/dom_textimpl.cpp:
        (CommentImpl::toString):
        (TextImpl::toString):
        (CDATASectionImpl::toString):
        * khtml/xml/dom_textimpl.h:
        * khtml/xml/dom_xmlimpl.cpp:
        (EntityImpl::toString):
        (EntityReferenceImpl::toString):
        (ProcessingInstructionImpl::setStyleSheet):
        (ProcessingInstructionImpl::toString):
        * khtml/xml/dom_xmlimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3493677, containingBlock() null because we tried to support position:relativ...
hyatt [Tue, 2 Dec 2003 22:54:42 +0000 (22:54 +0000)]
Fix for 3493677, containingBlock() null because we tried to support position:relative on table rows.  Fix
is to disallow this.

        Reviewed by kocienda

        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::adjustRenderStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3493697, nil-deref in bidi code. Need to null-check strings with no length.
hyatt [Tue, 2 Dec 2003 22:25:31 +0000 (22:25 +0000)]
Fix for 3493697, nil-deref in bidi code.  Need to null-check strings with no length.

        Reviewed by john

        * khtml/rendering/bidi.cpp:
        (khtml::addRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3495746, nil deref of containing block (frame inside frameset).
hyatt [Tue, 2 Dec 2003 22:06:13 +0000 (22:06 +0000)]
Fix for 3495746, nil deref of containing block (frame inside frameset).

        Reviewed by kocienda

        * khtml/rendering/render_box.cpp:
        (RenderBox::containingBlockWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed:
cblu [Tue, 2 Dec 2003 19:58:03 +0000 (19:58 +0000)]
Fixed:
<rdar://problem/3439222>: always hangs opening plain text file on a particular machine due to missing font, no UI to detect
<rdar://problem/3492983>: Certain fonts cause Safari to hang on text/plain pages

        Reviewed by rjw.

        * WebView.subproj/WebTextView.m:
        (-[WebTextView setFixedWidthFont]): Use [[WebTextRendererFactory sharedFactory] fontWithFamilies:traits:size:] to get the font since it takes the font family which is what we store in WebPreferences and it does fallback work. Only set the font if non-nil is returned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John
kocienda [Tue, 2 Dec 2003 19:48:06 +0000 (19:48 +0000)]
    Reviewed by John

        * kwq/KWQRect.h:
        * kwq/KWQRect.mm:
        (QRect::bottomRight): Added helper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
darin [Tue, 2 Dec 2003 16:04:55 +0000 (16:04 +0000)]
    Reviewed by Maciej.

        - fixed 3493799: JavaScript string.replace expands $ if it's the last character in replacement string

        * kjs/ustring.cpp: (KJS::UString::toDouble): Fix backwards handling of the "tolerant" boolean.
        This indirectly caused the string.replace bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Merged the following patch from David Faure to fix:
mjs [Tue, 2 Dec 2003 11:00:40 +0000 (11:00 +0000)]
Merged the following patch from David Faure to fix:

<rdar://problem/3497663>: Can't look up frames by number using windw[i] notation

    2003-11-25  David Faure  <faure@kde.org>

        * ecma/kjs_window.cpp: Implement hasProperty and get for frames by number in Window,
        to fix window[0] and parent[1] etc. (#56983)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Merged patches from Harri Porten and David Faure to fix:
mjs [Tue, 2 Dec 2003 10:11:47 +0000 (10:11 +0000)]
    Merged patches from Harri Porten and David Faure to fix:

<rdar://problem/3497643>: reproducible crash printing self-referential array

* kjs/array_object.cpp:
        (ArrayProtoFuncImp::call): Break out of the loop if an exception was thrown.
        * kjs/nodes.cpp:
        (FunctionCallNode::evaluate): Move function call depth check from here...
        * kjs/object.cpp:
        (KJS::Object::call): ...to here.
        * kjs/object.h: Un-inline Object::call now that it does more.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed mistake in method signatures used to get boolean and integer fields.
rjw [Mon, 1 Dec 2003 23:11:22 +0000 (23:11 +0000)]
Fixed mistake in method signatures used to get boolean and integer fields.

        Reviewed by Chris.

        * bindings/jni/jni_runtime.cpp:
        (JavaField::valueFromInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Richard.
mjs [Mon, 1 Dec 2003 22:53:31 +0000 (22:53 +0000)]
    Reviewed by Richard.

<rdar://problem/3487185>: implement security checks for XMLHttpRequest

* WebCoreSupport.subproj/WebSubresourceClient.m:
        (-[WebSubresourceClient connection:willSendRequest:redirectResponse:]): Let
WebCore know about redirects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Richard.
mjs [Mon, 1 Dec 2003 22:52:24 +0000 (22:52 +0000)]
    Reviewed by Richard.

<rdar://problem/3487185>: implement security checks for XMLHttpRequest

        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::open): Refuse to start if the URL is not one
this document is allowed to access.
        (KJS::XMLHttpRequest::slotRedirection): Stop the job if we redirect
to a URL the home document is not allowed to access.
        * kwq/KWQResourceLoader.mm:
        (-[KWQResourceLoader redirectedToURL:]): emit the right signal
        * kwq/WebCoreResourceLoader.h: Prototype new method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
rjw [Mon, 1 Dec 2003 22:44:54 +0000 (22:44 +0000)]
WebKit:
Moved grungy polling code from WebKit to the JavaPlugin.

        Reviewed by Chris.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge pollForAppletInView:]):

WebCore:
Fixed parameter passing to applet.  Child elements are NOT valid in setStyle().  So we now either create the widget before needed with createWidgetIfNecessary.  This either happens when doing the first layout, or when JavaScript first references the applet element.

Fixed early delete of the the main applet instance.  When the JS collector cleaned up the last JS object referring to the applet instance we were deleting the java instance.  This caused the applet instance cached on the applet element to be invalid.  The applet instance is the only Java object not to be cleaned up by the JS collector.

Added support for getting at Java object fields.

        Reviewed by Chris.

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLElement::tryGet):
        * khtml/html/html_objectimpl.cpp:
        (HTMLAppletElementImpl::createRenderer):
        (HTMLAppletElementImpl::getAppletInstance):
        * khtml/html/html_objectimpl.h:
        * khtml/rendering/render_applet.cpp:
        (RenderApplet::createWidgetIfNecessary):
        (RenderApplet::layout):
        * khtml/rendering/render_applet.h:
        (khtml::RenderApplet::renderName):

JavaScriptCore:
Fixed parameter passing to applet.  Child elements are NOT valid in setStyle().  So we now create the widget before needed with createWidgetIfNecessary.  This either happens when doing the first layout, or when JavaScript first references the applet element.

Fixed early delete of the the main applet instance.  When the JS collector cleaned up the last JS object referring to the applet instance we were deleting the java instance.  This caused the applet instance cached on the applet element to be invalid.  The applet instance is the only Java object not to be cleaned up by the JS collector.

Added support for getting at Java object fields.

        Reviewed by Chris.

        * JavaScriptCore.pbproj/project.pbxproj:
        * Makefile.am:
        * bindings/jni/jni_instance.cpp:
        (JObjectWrapper::JObjectWrapper):
        * bindings/jni/jni_instance.h:
        (Bindings::JObjectWrapper::~JObjectWrapper):
        * bindings/jni/jni_runtime.cpp:
        (JavaField::valueFromInstance):
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::~RuntimeObjectImp):
        (RuntimeObjectImp::RuntimeObjectImp):
        (RuntimeObjectImp::get):
        (RuntimeObjectImp::deleteProperty):
        * bindings/runtime_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
darin [Mon, 1 Dec 2003 21:33:54 +0000 (21:33 +0000)]
    Reviewed by Dave.

        - fixed 3496960: nil-deref in idFromNode inside elementDoesAutoComplete:

        * kwq/WebCoreBridge.mm:
        (inputElementFromDOMElement): Added nil check.
        (formElementFromDOMElement): Added nil check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3490959, collapsed border tables don't paint backgrounds.
hyatt [Mon, 1 Dec 2003 19:22:06 +0000 (19:22 +0000)]
Fix for 3490959, collapsed border tables don't paint backgrounds.

        Reviewed by darin

        * khtml/rendering/render_table.cpp:
        (RenderTable::setStyle):
        (RenderTable::paint):
        (RenderTable::paintBoxDecorations):
        * khtml/rendering/render_table.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
darin [Mon, 1 Dec 2003 19:18:51 +0000 (19:18 +0000)]
    Reviewed by Dave.

        - fixed 3493939: ordered lists with type="A" roll over to A' after X rather than after Z

        * khtml/rendering/render_list.cpp: (toLetter): Change 24 to 26.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
kocienda [Mon, 1 Dec 2003 19:05:21 +0000 (19:05 +0000)]
WebKit:

        Reviewed by John

Fix for this bug:

<rdar://problem/3496873>: Move key event helper functions to WebKit

        * Misc.subproj/WebNSEventExtras.h: Add declarations for new key event
helpers.
        * Misc.subproj/WebNSEventExtras.m:
        (-[NSEvent _web_isKeyEvent:]): Added.
        (-[NSEvent _web_isDeleteKeyEvent]): Added.
        (-[NSEvent _web_isEscapeKeyEvent]): Added.
        (-[NSEvent _web_isOptionTabKeyEvent]): Added.
        (-[NSEvent _web_isReturnOrEnterKeyEvent]): Added.
        (-[NSEvent _web_isTabKeyEvent]): Added.
        * WebKit.pbproj/project.pbxproj: Made WebNSEventExtras.h a private header
so WebBrowser can use the new helpers.

WebBrowser:

        Reviewed by John

Fix for this bug:

<rdar://problem/3496873>: Move key event helper functions to WebKit

        * BookmarksViewController.m:
        (-[BookmarksViewController handleKeyDown:inSourceColumn:]): Move
to new key event helper.
        * BrowserNSEventExtras.h: Remove key event helpers from here. WebBrowser
will now pick these up from WebKit.
        * BrowserNSEventExtras.m: Ditto.
        * BrowserWindowController.m: Move to new key event helpers.
        (-[BrowserWindowController cancel:]): Ditto.
        (-[BrowserWindowController windowWillHandleKeyEvent:]): Ditto.
        (-[BrowserWindowController performQuickSearch:]): Ditto.
        * DownloadViewController.m:
        (-[DownloadViewController keyDown:]): Ditto.
        * Preferences.subproj/SheetWithTableController.m:
        (-[SheetWithTableController tableView:keyDown:]): Ditto.
        * TitleBarButton.m: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agotree is open for Safari-116
vicki [Sat, 22 Nov 2003 00:38:32 +0000 (00:38 +0000)]
tree is open for Safari-116

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoSafari-115 stamp
vicki [Sat, 22 Nov 2003 00:27:22 +0000 (00:27 +0000)]
Safari-115 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
mjs [Fri, 21 Nov 2003 23:27:33 +0000 (23:27 +0000)]
WebCore:

        Reviewed by Ken.

WebCore part of fix for:

<rdar://problem/3487134>: Implement http request/response status and headers for XMLHttpRequest

        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::getValueProperty): Call appropriate methods for
status and statusText.
        (KJS::XMLHttpRequest::send): Set request headers as "customHeaders"
metadata property.
        (KJS::XMLHttpRequest::setRequestHeader): Simply append to header
string.
        (KJS::XMLHttpRequest::getAllResponseHeaders): Return the header string
except for the first line.
(KJS::XMLHttpRequest::getResponseHeader): Scan the response header
string for the header field. Not sure if it's worth being more
efficient.
        (KJS::XMLHttpRequest::getStatus): Try to pull a code out
of the status line.
        (KJS::XMLHttpRequest::getStatusText): Pull the first line
off the headers (if any), otherwise return undefined.
        (KJS::XMLHttpRequest::slotData): The first time through, save
the response headers, retrieved from "HTTP-Headers" metadata
property.
        (KJS::XMLHttpRequestProtoFunc::tryCall): Make setRequestHeader,
getResponseHeader, getAllResponseHeaders call the right thing.
        * khtml/ecma/xmlhttprequest.h:
        * kwq/KWQKJobClasses.h:
        * kwq/KWQKJobClasses.mm:
        (KIO::TransferJobPrivate::TransferJobPrivate): Added header
support.
        (KIO::TransferJobPrivate::~TransferJobPrivate):
        (KIO::TransferJob::assembleResponseHeaders): Get a header string
out of the response if needed.
        (KIO::TransferJob::queryMetaData): Special-case "HTTP-Headers".
        (KIO::TransferJob::emitReceivedResponse): Save response.
        * kwq/KWQLoader.h:
        * kwq/KWQLoader.mm:
        (-[NSDictionary _webcore_initWithHeaderString:]): Helper method to
turn a string of header fields into a dictionary.
        (KWQServeRequest): Pass custom headers through.
        (KWQResponseMIMEType): Admit it's an NSURLResponse *.
        (KWQResponseHeaderString): Assembled status code and response
header fields into response header. Cheat a little on the status
line.
        * kwq/KWQResourceLoader.mm:
        (-[KWQResourceLoader receivedResponse:]): Admit it's an
NSURLResponse *.
        * kwq/WebCoreResourceLoader.h: Ditto.
* kwq/WebCoreBridge.h: Add customHeader: arguments.

WebKit:

        Reviewed by Ken.

WebKit part of fix for:

<rdar://problem/3487134>: Implement http request/response status and headers for XMLHttpRequest

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge startLoadingResource:withURL:customHeaders:]): Added customHeaders
parameter.
        (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]): Ditto.
        * WebCoreSupport.subproj/WebSubresourceClient.h:
        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (+[WebSubresourceClient startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): Add the custom headers.
        (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:referrer:forDataSource:]): Pass along the custom headers.
        (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]): Pass along the custom headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed: <rdar://problem/3491907>: When viewing applet, view hierarchy was an empty...
cblu [Fri, 21 Nov 2003 19:14:23 +0000 (19:14 +0000)]
Fixed: <rdar://problem/3491907>: When viewing applet, view hierarchy was an empty KWQView

        Reviewed by rjw.

        * WebCore.pbproj/project.pbxproj:
        * khtml/html/html_objectimpl.cpp: removed setupApplet because that work is done when the applet widget is created
        (HTMLAppletElementImpl::createRenderer): pass the PARAM args to the render object
        (HTMLAppletElementImpl::getAppletInstance): don't call setupApplet
        * khtml/rendering/render_applet.cpp:
        (RenderApplet::RenderApplet): store args and context, don't call setQWidget here
        (RenderApplet::setStyle): call setQWidget here
        (RenderApplet::layout): don't parse args here, that is done in HTMLAppletElementImpl::createRenderer
        * khtml/rendering/render_applet.h:
        * kwq/KWQKJavaAppletWidget.h:
        (KJavaApplet::KJavaApplet): turned into a stub, this work is no longer needed
        (KJavaApplet::setAppletClass): ditto
        (KJavaApplet::setAppletName): ditto
        (KJavaApplet::setArchives): ditto
        (KJavaApplet::setBaseURL): ditto
        (KJavaApplet::setCodeBase): ditto
        (KJavaApplet::setParameter): ditto
        (KJavaAppletWidget::~KJavaAppletWidget): ditto
        (KJavaAppletWidget::applet): ditto
        (KJavaAppletWidget::setBaseURL): ditto
        (KJavaAppletWidget::setParameter): ditto
        (KJavaAppletWidget::showApplet): ditto
        * kwq/KWQKJavaAppletWidget.mm:
        (KJavaAppletWidget::KJavaAppletWidget): create the java here instead of doing it later

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
sullivan [Fri, 21 Nov 2003 18:16:07 +0000 (18:16 +0000)]
WebCore:

        - WebCore part of fix for <rdar://problem/3333744>: Safari prints page with
        very, very long line very, very small

        Reviewed by Ken.

        * kwq/KWQKHTMLPart.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::forceLayoutWithPageWidthRange):
        Changed method name from forceLayoutForPageWidth; now takes min and max
        page width values. Use max page width value to limit how wide page will
        get when there's a very long line.

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
        changed pageWidth parameter into min and max parameters; pass them along to KWQKHTMLPart.

WebKit:

        - WebKit part of fix for <rdar://problem/3333744>: Safari prints page with
        very, very long line very, very small

        Reviewed by Ken.

        * WebView.subproj/WebHTMLView.m:
        renamed PrintingExtraWidthFactor to PrintingMinimumShrinkFactor, added
        PrintingMaximumShrinkFactor of 2.0, which matches IE
        (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
        now takes a min and max page width; passes them along to bridge
        (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
        now takes a min and max page width; passes them along to layoutTo...
        (-[WebHTMLView _scaleFactorForPrintOperation:]):
        now takes PrintingMaximumScaleFactor into account
        (-[WebHTMLView knowsPageRange:]):
        now takes PrintingMaximumScaleFactor into account

        (-[WebHTMLView layout]):
        pass 0 for maximumPageWidth when passing 0 for minimumPageWidth
        (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
        ditto
        (-[WebHTMLView _web_setPrintingModeRecursive]):
        ditto
        (-[WebHTMLView _web_clearPrintingModeRecursive]):
        ditto
        (-[WebHTMLView endDocument]):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
darin [Fri, 21 Nov 2003 17:29:00 +0000 (17:29 +0000)]
    Reviewed by Ken.

        - fixed 3490260: allow &sup1 to be misspelled &supl (lowercase l instead of numeral 1) because WinIE does

        * khtml/html/kentities.gperf: Added supl to the list. Maps to U+00B9, just as sup1 does.
        * khtml/html/kentities.c: Regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Patch from Harri Porten, reviewed by me.
mjs [Fri, 21 Nov 2003 08:54:42 +0000 (08:54 +0000)]
    Patch from Harri Porten, reviewed by me.

- fixed 3491712 - String slice with negative arguments does not offset from end of string

* kjs/string_object.cpp:
        (StringProtoFuncImp::call): Handle negative arguments as offsets from end by
adding length and clamping to [0,length-1].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Patch from Harri Porten, reviewed by me.
mjs [Fri, 21 Nov 2003 08:49:58 +0000 (08:49 +0000)]
    Patch from Harri Porten, reviewed by me.

- fixed 3491709 - using Function.apply with a primitive type as the arg list causes crash

* kjs/function_object.cpp:
        (FunctionProtoFuncImp::call): Nest parentheses properly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin.
mjs [Fri, 21 Nov 2003 06:53:17 +0000 (06:53 +0000)]
    Reviewed by Darin.

- fixed 3487201 - Implement abort for XMLHttpRequest async loads

        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::abort): Kill and clear job.
        (KJS::XMLHttpRequest::slotData): Avoid moving to state 3 on early abort.
        (KJS::XMLHttpRequestProtoFunc::tryCall): Call abort when appropriate.
        * khtml/ecma/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoJavaScriptCore:
rjw [Fri, 21 Nov 2003 03:13:52 +0000 (03:13 +0000)]
JavaScriptCore:
More LiveConnect stuff.  Primitive Java fields are now
accessible from JavaScript!  Yay!

        Reviewed by Maciej.

        * bindings/jni/jni_class.cpp:
        (JavaClass::methodNamed):
        (JavaClass::fieldNamed):
        * bindings/jni/jni_class.h:
        (Bindings::JavaClass::_commonDelete):
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::JavaInstance):
        (JavaInstance::~JavaInstance):
        (JavaInstance::getClass):
        * bindings/jni/jni_instance.h:
        (Bindings::JavaInstance::javaInstance):
        * bindings/jni/jni_runtime.cpp:
        (JavaField::JavaField):
        (JavaField::valueFromInstance):
        * bindings/jni/jni_runtime.h:
        (Bindings::JavaField::JavaField):
        (Bindings::JavaField::~JavaField):
        (Bindings::JavaField::operator=):
        * bindings/jni/jni_utility.cpp:
        (callJNIMethod):
        (callJNIMethodA):
        (callJNIVoidMethod):
        (callJNIObjectMethod):
        (callJNIBooleanMethod):
        (callJNIByteMethod):
        (callJNICharMethod):
        (callJNIShortMethod):
        (callJNIIntMethod):
        (callJNILongMethod):
        (callJNIFloatMethod):
        (callJNIDoubleMethod):
        (callJNIVoidMethodA):
        (callJNIObjectMethodA):
        (callJNIByteMethodA):
        (callJNICharMethodA):
        (callJNIShortMethodA):
        (callJNIIntMethodA):
        (callJNILongMethodA):
        (callJNIFloatMethodA):
        (callJNIDoubleMethodA):
        (releaseCharactersForJStringInEnv):
        (primitiveTypeFromClassName):
        (getJNIField):
        * bindings/jni/jni_utility.h:
        * bindings/runtime.cpp:
        (Instance::createBindingForLanguageInstance):
        (Instance::getValueOfField):
        * bindings/runtime.h:
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
sullivan [Fri, 21 Nov 2003 02:01:02 +0000 (02:01 +0000)]
WebCore:

        - WebCore part of <rdar://problem/3183124>: Support page-break-before/after with a value of "always"

        Dave wrote this part and we reviewed it together.

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::paintObject):
        if printing, check for CSS page break locations
        (khtml::RenderBlock::inRootBlockContext):
        new method, used to check whether we're in a context for which
        CSS page breaks are legal.

        * khtml/rendering/render_block.h:
        prototype for inRootBlockContext; this might be useful for
        other code later.

        * khtml/rendering/render_canvas.cpp:
        (RenderCanvas::setBestTruncatedAt):
        now takes a forcedBreak parameter which overrides others.

        * khtml/rendering/render_canvas.h:
        (khtml::RenderCanvas::setTruncatedAt):
        set default value for m_forcedPageBreak

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge computePageRects:withPageHeight:]):
        do the real work of pagination here

WebKit:

        - WebKit part of <rdar://problem/3183124>: Support page-break-before/after with a value of "always"

        Dave and I wrote and reviewed this.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView _setPrinting:pageWidth:adjustViewSize:]):
        reset page rects when printing status changes
        (-[WebHTMLView _availablePaperWidthForPrintOperation:]):
        new helper method to compute paper width taking margins into account
        (-[WebHTMLView _scaleFactorForPrintOperation:]):
        new helper method to compute how much we need to shrink to fit one page across
        (-[WebHTMLView _provideTotalScaleFactorForPrintOperation:]):
        we overrode this secret internal AppKit method to make shrink-to-fit work;
        we wrote bug 3491344 about the need for this to be public.
        (-[WebHTMLView knowsPageRange:]):
        new method, computes rects and returns YES
        (-[WebHTMLView rectForPage:]):
        new method, returns rect computed above
        (-[WebHTMLView _calculatePrintHeight]):
        new method, used by knowsPageRange

        * WebView.subproj/WebHTMLViewPrivate.h:
        new pageRects ivar

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoCorrected ChangeLog comment.
mjs [Fri, 21 Nov 2003 00:54:25 +0000 (00:54 +0000)]
Corrected ChangeLog comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin.
mjs [Fri, 21 Nov 2003 00:53:22 +0000 (00:53 +0000)]
    Reviewed by Darin.

- fixed 3487201 - Implement abort for XMLHttpRequest async loads

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge startLoadingResource:withURL:postData:]):
        * WebCoreSupport.subproj/WebSubresourceClient.h:
        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (+[WebSubresourceClient startLoadingResource:withRequest:referrer:forDataSource:]):
        (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]):
        (+[WebSubresourceClient startLoadingResource:withURL:postData:referrer:forDataSource:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebCore:
cblu [Thu, 20 Nov 2003 23:05:33 +0000 (23:05 +0000)]
WebCore:

Fixed: <rdar://problem/3491225>: Need UI and localized strings for <KEYGEN> support

        Reviewed by john.

        * WebCore-combined.exp:
        * WebCore.exp:
        * WebCore.pbproj/project.pbxproj:
        * kwq/KWQKSSLKeyGen.h:
        * kwq/KWQKSSLKeyGen.mm: Added.
        (KSSLKeyGen::supportedKeySizes): implemented, calls [WebCoreLocalizedStringFactory keyGenerationMenuItemTitles]
        * kwq/WebCoreLocalizedStringFactory.h: Added.
        * kwq/WebCoreLocalizedStringFactory.m: Added.
        (+[WebCoreLocalizedStringFactory sharedFactory]): new
        (-[WebCoreLocalizedStringFactory init]): new
        (-[WebCoreLocalizedStringFactory keyGenerationMenuItemTitles]): new

WebKit:

Fixed: <rdar://problem/3491229>: Need UI and localized strings for <KEYGEN> support

        Reviewed by john.

        * ChangeLog:
        * English.lproj/Localizable.strings:
        * WebCoreSupport.subproj/WebLocalizedStringFactory.h: Added.
        * WebCoreSupport.subproj/WebLocalizedStringFactory.m: Added.
        (+[WebLocalizedStringFactory createSharedFactory]): new
        (-[WebLocalizedStringFactory dealloc]): new
        (-[WebLocalizedStringFactory keyGenerationMenuItemTitles]): new
        * WebKit.pbproj/project.pbxproj:
        * WebView.subproj/WebFrameView.m: call [WebLocalizedStringFactory createSharedFactory]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Ken.
mjs [Thu, 20 Nov 2003 22:45:40 +0000 (22:45 +0000)]
    Reviewed by Ken.

- fixed 3490086 - support http post for XMLHttpRequest

        * kwq/KWQKJobClasses.h:
        * kwq/KWQKJobClasses.mm:
        (KIO::TransferJobPrivate::TransferJobPrivate):
        (KIO::TransferJob::TransferJob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
rjw [Thu, 20 Nov 2003 22:00:33 +0000 (22:00 +0000)]
WebKit:
Added spin of event loop during applet lookup poll.  This
is necessary to allow timers and performOnMainThread: methods
a chance to fire.  The plugin depends on these mechanisms during
initialization.

        Reviewed by Chris.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge pollForAppletInView:]):

WebCore:
Cleaned up synchronous applet lookup and initialization.
We need to further cleanup applet instantiation.  It doesn't
need to be lazy with my modified Java Plugin.

        Reviewed by Chris.

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLElement::tryGet):
        * khtml/html/html_objectimpl.cpp:
        (HTMLAppletElementImpl::setupApplet):
        (HTMLAppletElementImpl::getAppletInstance):
        * khtml/html/html_objectimpl.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::getAppletInstanceForView):
        * kwq/KWQKJavaAppletWidget.h:
        * kwq/KWQKJavaAppletWidget.mm:
        (KJavaAppletWidget::showApplet):

JavaScriptCore:
More LiveConnect stuff.

        Reviewed by Chris.

        * bindings/jni/jni_class.cpp:
        (JavaClass::classForName):
        (JavaClass::classForInstance):
        * bindings/jni/jni_instance.cpp:
        (JavaInstance::getValueOfField):
        * bindings/jni/jni_instance.h:
        (Bindings::JObjectWrapper::JObjectWrapper):
        * bindings/jni/jni_runtime.h:
        (Bindings::JavaConstructor::~JavaConstructor):
        (Bindings::JavaConstructor::operator=):
        (Bindings::JavaMethod::JavaMethod):
        (Bindings::JavaMethod::_commonDelete):
        (Bindings::JavaMethod::signature):
        * bindings/jni/jni_utility.cpp:
        (getJNIEnv):
        (attachToJavaVM):
        * bindings/jni/jni_utility.h:
        * bindings/runtime.h:
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::~RuntimeObjectImp):
        (RuntimeObjectImp::get):
        * bindings/runtime_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by me
kocienda [Thu, 20 Nov 2003 21:56:13 +0000 (21:56 +0000)]
    Reviewed by me

John and I decided to apply the _web_ prefix to the tab key
event method in the extras file, but I neglected to do this
before checking in. Fixed now.

        * Misc.subproj/WebNSEventExtras.h:
        * Misc.subproj/WebNSEventExtras.m:
        (-[NSEvent _web_isTabKeyEvent])
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView keyDown:])

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by David
kocienda [Thu, 20 Nov 2003 21:01:35 +0000 (21:01 +0000)]
    Reviewed by David

Fix for this bug:

<rdar://problem/3487421>: crash/exception when tabbing to a link without text

        * khtml/html/html_inlineimpl.cpp:
        (HTMLAnchorElementImpl::isFocusable): A link is also not focusable
if it has zero width or height, if it has no children, or if it is
is not a continuation.
        * kwq/KWQPainter.mm:
        (QPainter::drawFocusRing): Put in a guard against trying to draw a focus
        ring with no control points. Log this as an error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John
kocienda [Thu, 20 Nov 2003 20:59:55 +0000 (20:59 +0000)]
    Reviewed by John

Fix for this bug:

<rdar://problem/3482159>: Tabbing to links gets "stuck" in "style switcher" on zeldman.com

        * Misc.subproj/WebNSEventExtras.h: Added.
        * Misc.subproj/WebNSEventExtras.m: Added.
        (-[NSEvent _isTabKeyEvent]): New helper.
        * WebKit.pbproj/project.pbxproj:
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView keyDown:]): Pass the key event to super unconditionally
if it is a tab key. This fixes the bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3486963, crash because generated content was referencing a deleted object...
hyatt [Thu, 20 Nov 2003 04:28:38 +0000 (04:28 +0000)]
Fix for 3486963, crash because generated content was referencing a deleted object.  Fix is to update the
variable to a sane value after deleting old generated content.

        Reviewed by darin

        * khtml/rendering/render_container.cpp:
        (RenderContainer::updatePseudoChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
sullivan [Thu, 20 Nov 2003 03:57:18 +0000 (03:57 +0000)]
WebKit:

        - WebKit part of fix for:
        <rdar://problem/3305671>: Web pages print with 1.25" border without regard to Page
        Setup margin settings

        Reviewed by Dave.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView beginDocument]):
        Lay out the page into a width 25% wider than there's room for on the printed page.
        This will make pages that can fit into a thin area be scaled down a little when printed,
        which lets them fit on fewer pages. This closely matches what IE and Camino (at least)
        do; I used Google as my test page, and the Google logo is now precisely the same size
        when printed from Safari as when printed from IE. Pages that don't fit into a thin
        area are already causing the printed page to be scaled horizontally to fit, and this
        won't affect them.

WebBrowser:

        - WebBrowser part of fix for:
        <rdar://problem/3305671>: Web pages print with 1.25" border without regard to Page
        Setup margin settings

        Reviewed by Dave.

        * BrowserDocument.m:
        (-[BrowserDocument printInfo]):
        Use the entire imageable area of the page (except max out at the paper size).
        This matches what IE does; you can tell by formatting for different printers
        in Page Setup and checking the printed margins against the margins reported
        in the Settings:Summary part of Page Setup.

        With this change and the accompanying WebKit change to initially lay out into
        an area 25% wider than fits on the page, and Hyatt's earlier change to re-layout
        to the width of the widest element on the page, our printed pages are much, much
        closer to how other browsers print. We are now no more different from other
        browsers than they are from each other, at least for non-edge case pages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by John.
mjs [Thu, 20 Nov 2003 00:46:23 +0000 (00:46 +0000)]
    Reviewed by John.

- fixed 3486998 - Implement asynchronous http loading for XMLHttpRequest

        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequestQObject::XMLHttpRequestQObject): New QObject to use to
connect to signals.
        (KJS::XMLHttpRequestQObject::slotData): Call XMLHttpRequest.
        (KJS::XMLHttpRequestQObject::slotFinished): Ditto.
        (KJS::XMLHttpRequestQObject::slotRedirection): Ditto.
        (KJS::XMLHttpRequest::getValueProperty): Implemented, onrequeststatechange,
readyState and responseText.
        (KJS::XMLHttpRequest::putValue): Implemented onrequeststatechange.
        (KJS::XMLHttpRequest::XMLHttpRequest): Initialize new fields.
        (KJS::XMLHttpRequest::~XMLHttpRequest): Delete decoder.
        (KJS::XMLHttpRequest::changeState): Update state, and send event if needed.
        (KJS::XMLHttpRequest::open): Save the parameters.
        (KJS::XMLHttpRequest::send): Fire up a post or get job.
        (KJS::XMLHttpRequest::slotFinished): go to final state.
        (KJS::XMLHttpRequest::slotRedirection): Just stub for now.
        (KJS::XMLHttpRequest::slotData): Update state; decode & save data.
        (KJS::XMLHttpRequestProtoFunc::tryCall): Implemented open and send.
        * khtml/ecma/xmlhttprequest.h: Prototyped new stuff.
        * khtml/xml/dom2_eventsimpl.cpp:
        (EventImpl::typeToId): Added "readystatechange" event.
        (EventImpl::idToType): Ditto.
        * khtml/xml/dom2_eventsimpl.h: Ditto.
        * kwq/KWQLoader.h:
        * kwq/KWQLoader.mm:
        (KWQServeRequest): New variant that doesn't need a Request.
        * kwq/KWQSlot.mm:
        (KWQSlot::KWQSlot): Handle XMLHttpRequestQObject's slots.
        (KWQSlot::call): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed: <rdar://problem/3489935>: Mentioning "to Disk" in context menus such as ...
cblu [Wed, 19 Nov 2003 23:45:18 +0000 (23:45 +0000)]
Fixed: <rdar://problem/3489935>: Mentioning "to Disk" in context menus such as "Download Linked File To Disk..." is redundant

        Reviewed by john.

        * English.lproj/Localizable.strings:
        * English.lproj/StringsNotToBeLocalized.txt:
        * WebView.subproj/WebDefaultContextMenuDelegate.m:
        (-[WebDefaultUIDelegate menuItemWithTag:]): use "Download Linked File" and "Download Image"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoForget to check these in earlier.
rjw [Wed, 19 Nov 2003 22:41:04 +0000 (22:41 +0000)]
Forget to check these in earlier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fixed: <rdar://problem/3488783>: Flash at http://www.sjwilson.net/reef/ does not...
cblu [Wed, 19 Nov 2003 22:25:08 +0000 (22:25 +0000)]
Fixed: <rdar://problem/3488783>: Flash at sjwilson.net/reef/ does not load photos

        Reviewed by rjw.

        * Misc.subproj/WebKitNSStringExtras.h:
        * Misc.subproj/WebKitNSStringExtras.m:
        (-[NSString _web_stringByStrippingReturnCharacters]): new
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView requestWithURLCString:]): call _web_stringByStrippingReturnCharacters on the relative string

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
rjw [Wed, 19 Nov 2003 22:21:40 +0000 (22:21 +0000)]
WebKit:
More LiveConnect stuff.  Horrible polling hack that
blocks main thread waiting for applet to fully initialize.

        Reviewed by Ken.

        * Plugins.subproj/WebPluginController.m:
        (-[WebPluginController addPlugin:]):
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge pollForAppletInView:]):

WebCore:
More LiveConnect stuff.  With that patch we make the applet
visible to JavaScript in an Bindings::Instance.  Next step
it to flush out implementation of RuntimeObjectImp and
RuntimeFunctionImp.

        Reviewed by Ken.

        * khtml/html/html_objectimpl.cpp:
        (HTMLAppletElementImpl::HTMLAppletElementImpl):
        (HTMLAppletElementImpl::~HTMLAppletElementImpl):
        (HTMLAppletElementImpl::getAppletInstance):
        * khtml/html/html_objectimpl.h:
        * kwq/KWQKHTMLPart.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::getAppletInstanceForView):
        * kwq/WebCoreBridge.h:

JavaScript:
More LiveConnect stuff.

        Reviewed by Ken.

        * JavaScriptCore.pbproj/project.pbxproj:
        * bindings/jni/jni_class.cpp: Added.
        (JavaClass::_commonInit):
        (JavaClass::JavaClass):
        (_createClassesByNameIfNecessary):
        (JavaClass::classForName):
        (JavaClass::classForInstance):
        (JavaClass::methodNamed):
        (JavaClass::fieldNamed):
        * bindings/jni/jni_class.h: Added.
        (Bindings::JavaClass::_commonDelete):
        (Bindings::JavaClass::~JavaClass):
        (Bindings::JavaClass::_commonCopy):
        (Bindings::JavaClass::JavaClass):
        (Bindings::JavaClass::operator=):
        (Bindings::JavaClass::name):
        (Bindings::JavaClass::constructorAt):
        (Bindings::JavaClass::numConstructors):
        * bindings/jni/jni_instance.cpp: Added.
        (JavaInstance::JavaInstance):
        (JavaInstance::~JavaInstance):
        * bindings/jni/jni_instance.h: Added.
        (Bindings::JObjectWrapper::JObjectWrapper):
        (Bindings::JObjectWrapper::~JObjectWrapper):
        (Bindings::JObjectWrapper::ref):
        (Bindings::JObjectWrapper::deref):
        (Bindings::JavaInstance::getClass):
        (Bindings::JavaInstance::operator=):
        * bindings/jni/jni_runtime.cpp:
        (JavaMethod::JavaMethod):
        * bindings/jni/jni_runtime.h:
        (Bindings::JavaString::JavaString):
        (Bindings::JavaString::~JavaString):
        (Bindings::JavaString::operator=):
        * bindings/jni/jni_utility.cpp:
        (getJavaVM):
        (getJNIEnv):
        (getCharactersFromJString):
        (releaseCharactersForJString):
        (getCharactersFromJStringInEnv):
        (releaseCharactersForJStringInEnv):
        * bindings/jni/jni_utility.h:
        * bindings/runtime.cpp:
        (Instance::createBindingForLanguageInstance):
        * bindings/runtime.h:
        (Bindings::Instance::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3488888, about:blank in iframes doesn't repaint properly. Fix for 3485478...
hyatt [Wed, 19 Nov 2003 20:36:13 +0000 (20:36 +0000)]
Fix for 3488888, about:blank in iframes doesn't repaint properly.  Fix for 3485478, refreshing a remote
page often causes a white flash.  Fix for 3488827, XML/XHTML documents don't fire load events on bodies/framesets.

        Reviewed by darin

        * khtml/html/html_documentimpl.cpp:
        (HTMLDocumentImpl::HTMLDocumentImpl):
        * khtml/html/html_documentimpl.h:
        * khtml/rendering/render_canvas.cpp:
        (RenderCanvas::RenderCanvas):
        (RenderCanvas::layout):
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::DocumentImpl):
        (DocumentImpl::body):
        (DocumentImpl::close):
        * khtml/xml/dom_docimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Make updateScrollers guard non-static, so that it applies only to the view whose...
hyatt [Wed, 19 Nov 2003 20:30:24 +0000 (20:30 +0000)]
Make updateScrollers guard non-static, so that it applies only to the view whose scrollers are being
updated.

        Reviewed by darin

        * WebView.subproj/WebDynamicScrollBarsView.h:
        * WebView.subproj/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView reflectScrolledClipView:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Darin.
mjs [Wed, 19 Nov 2003 18:55:18 +0000 (18:55 +0000)]
    Reviewed by Darin.

- fixed 3488883 - KIO::TransferJob needs to really use signals instead of calling loader directly

* khtml/khtml_part.cpp:
        (KHTMLPart::openURL):
        * khtml/misc/loader.cpp:
        (Loader::servePendingRequests):
        (Loader::slotReceivedResponse):
        * khtml/misc/loader.h:
        * kwq/KWQKJobClasses.h:
        * kwq/KWQKJobClasses.mm:
        (KIO::TransferJob::TransferJob):
        (KIO::TransferJob::url):
        (KIO::TransferJob::emitData):
        (KIO::TransferJob::emitRedirection):
        (KIO::TransferJob::emitResult):
        (KIO::TransferJob::emitReceivedResponse):
        * kwq/KWQLoader.mm:
        (KWQServeRequest):
        * kwq/KWQObject.mm:
        (QObject::connect):
        * kwq/KWQResourceLoader.h:
        * kwq/KWQResourceLoader.mm:
        (-[KWQResourceLoader receivedResponse:]):
        (-[KWQResourceLoader addData:]):
        (-[KWQResourceLoader finishJobAndHandle]):
        * kwq/KWQSignal.h:
        * kwq/KWQSignal.mm:
        (KWQSignal::call):
        * kwq/KWQSlot.h:
        * kwq/KWQSlot.mm:
        (KWQSlot::KWQSlot):
        (KWQSlot::call):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3488244, marquee-increments with percentage values not handled correctly...
hyatt [Tue, 18 Nov 2003 22:12:18 +0000 (22:12 +0000)]
Fix for 3488244, marquee-increments with percentage values not handled correctly.  Also added a tweak to ensure
that 1% of a small value ends up being at least an increment of 1.  Also added an optimization to not even
bother kicking off the marquee timer if the increment's initial value is 0 (matches WinIE).

        * khtml/rendering/render_layer.cpp:
        (Marquee::start):
        (Marquee::timerEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoWebKit:
rjw [Tue, 18 Nov 2003 21:23:28 +0000 (21:23 +0000)]
WebKit:
More live connect stubs.  We're getting close.

        Reviewed by Chris.

        * Plugins.subproj/WebPluginController.m:
        (-[WebPluginController addPlugin:]):
        (-[WebPluginController _delayedGetApplet:]):
        * WebView.subproj/WebView.m:
        (-[WebView _goToItem:withLoadType:]):

WebCore:
More live connect stubs.  We're getting close.

        Reviewed by Chris.

        * WebCore.pbproj/project.pbxproj:
        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLElement::tryGet):
        * khtml/html/html_objectimpl.cpp:
        (HTMLAppletElementImpl::parseAttribute):
        (HTMLAppletElementImpl::getAppletInstance):
        * khtml/html/html_objectimpl.h:

JavaScriptCore:
More live connect stubs.  We're getting close.

        Reviewed by Chris.

        * JavaScriptCore.pbproj/project.pbxproj:
        * bindings/jni/jni_runtime.cpp:
        (JavaClass::JavaClass):
        (JavaInstance::JavaInstance):
        (JavaInstance::~JavaInstance):
        * bindings/jni/jni_runtime.h:
        (Bindings::JavaConstructor::value):
        (Bindings::JavaField::value):
        (Bindings::JavaMethod::value):
        (Bindings::JavaClass::_commonDelete):
        (Bindings::JavaClass::_commonCopy):
        (Bindings::JavaClass::methodNamed):
        (Bindings::JavaClass::fieldNamed):
        (Bindings::JavaInstance::getClass):
        * bindings/runtime.cpp: Added.
        * bindings/runtime.h:
        (Bindings::Instance::~Instance):
        * bindings/runtime_object.cpp: Added.
        (RuntimeObjectImp::classInfo):
        (RuntimeObjectImp::RuntimeObjectImp):
        (RuntimeObjectImp::get):
        (RuntimeObjectImp::put):
        (RuntimeObjectImp::canPut):
        (RuntimeObjectImp::hasProperty):
        (RuntimeObjectImp::deleteProperty):
        (RuntimeObjectImp::defaultValue):
        (RuntimeObjectImp::_initializeClassInfoFromInstance):
        * bindings/runtime_object.h: Added.
        (KJS::RuntimeObjectImp::setInternalInstance):
        (KJS::RuntimeObjectImp::getInternalInstance):
        * kjs/object.cpp:
        (KJS::ObjectImp::get):
        (KJS::ObjectImp::hasProperty):
        * kjs/value.h:
        (KJS::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Maciej.
darin [Tue, 18 Nov 2003 15:57:46 +0000 (15:57 +0000)]
    Reviewed by Maciej.

        - fixed 3487335: REGRESSION (112-113): "a:b" error message does not cite the URL properly

        * Misc.subproj/WebKitErrors.m:
        (+[NSError _webKitErrorWithCode:failingURL:]): Call _webKitErrorWithDomain:code:URL:.
        (+[NSError _webKitErrorWithDomain:code:URL:]): Call _web_errorWithDomain:code:URL:, instead of using
        the deprecated failingURL: flavor.
        (-[NSError _initWithPluginErrorCode:contentURLString:pluginPageURLString:pluginName:MIMEType:]):
        Change this method to call the other one.
        (-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]): Implement this one,
        and put in the NSErrorFailingURLKey, as well as the NSErrorFailingURLStringKey, to match what Foundation
        now does for other errors.

        * WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]):
        Change to use the non-deprecated flavor of the NSError call above.

        * English.lproj/StringsNotToBeLocalized.txt: Updated for above changes and other recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoFix for generated content problems fixes test 4.
hyatt [Tue, 18 Nov 2003 10:05:14 +0000 (10:05 +0000)]
Fix for generated content problems fixes test 4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoUpdate option document.write layout test. Somebody fixed a bug and didn't run the...
hyatt [Tue, 18 Nov 2003 10:04:32 +0000 (10:04 +0000)]
Update option document.write layout test.  Somebody fixed a bug and didn't run the layout tests to see that they'd fixed a layout test. ;)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3478122, crash using first-letter and zooming, and also the fix for 3478078...
hyatt [Tue, 18 Nov 2003 09:55:06 +0000 (09:55 +0000)]
Fix for 3478122, crash using first-letter and zooming, and also the fix for 3478078, generated content
does not get removed properly on w3c site.  The root cause of these two bugs was the same, namely my
change to meld the concept of generated anonymous content and anonymous blocks created by the layout
engine together.  RenderBlock's setStyle method was incorrectly updating before/after/first-letter content
and wiping out its style in random (and bad) ways.

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::setStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years agoAdding layout test to cover image generated content.
hyatt [Tue, 18 Nov 2003 09:28:28 +0000 (09:28 +0000)]
Adding layout test to cover image generated content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3487424, images not painting because of dropped layouts. When replaced...
hyatt [Tue, 18 Nov 2003 09:21:44 +0000 (09:21 +0000)]
Fix for 3487424, images not painting because of dropped layouts.  When replaced elements dirtied
themselves during line layout, they only needed to do a local dirty and not walk up the parent chain.

        Reviewed by mjs

        * khtml/rendering/bidi.cpp:
        (khtml::RenderBlock::layoutInlineChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Reviewed by Dave.
mjs [Tue, 18 Nov 2003 08:52:21 +0000 (08:52 +0000)]
    Reviewed by Dave.

- fixed 3486991 - Add XMLHttpRequest object and stub methods

        * khtml/ecma/kjs_window.cpp:
        (Window::get): Handle XMLHttpRequest constructor like Option and Image.
        * khtml/ecma/kjs_window.h: Ditto.
        * khtml/ecma/kjs_window.lut.h: Regenerated.
        * khtml/ecma/xmlhttprequest.cpp: Added. Stub implementations of everything.
        (KJS::XMLHttpRequestConstructorImp::XMLHttpRequestConstructorImp):
        (KJS::XMLHttpRequestConstructorImp::implementsConstruct):
        (KJS::XMLHttpRequestConstructorImp::construct):
        (KJS::XMLHttpRequest::tryGet):
        (KJS::XMLHttpRequest::getValueProperty):
        (KJS::XMLHttpRequest::tryPut):
        (KJS::XMLHttpRequest::putValue):
        (KJS::XMLHttpRequest::notifyFinished):
        (KJS::XMLHttpRequest::XMLHttpRequest):
        (KJS::XMLHttpRequest::~XMLHttpRequest):
        (KJS::XMLHttpRequestProtoFunc::tryCall):
        * khtml/ecma/xmlhttprequest.h: Added. Stub implementations of everything.
        (KJS::XMLHttpRequest::toBoolean):
        (KJS::XMLHttpRequest::classInfo):
        * khtml/ecma/xmlhttprequest.lut.h: Added.
        * khtml/ecma/Makefile.am: Add new .lut.h file.
* WebCore.pbproj/project.pbxproj: Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Fix for 3487136, marquees reset when you return to a page in the b/f cache. This...
hyatt [Tue, 18 Nov 2003 08:41:19 +0000 (08:41 +0000)]
Fix for 3487136, marquees reset when you return to a page in the b/f cache.  This patch makes
marquees suspend and resume properly, so they pick up animating where they left off.

        Reviewed by mjs

        * khtml/rendering/render_layer.cpp:
        (RenderLayer::suspendMarquees):
        (m_direction):
        (Marquee::start):
        (Marquee::suspend):
        * khtml/rendering/render_layer.h:
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::clearTimers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Patch from Harri, reviewed by me.
mjs [Tue, 18 Nov 2003 05:40:43 +0000 (05:40 +0000)]
    Patch from Harri, reviewed by me.

- fixed 3487375 - backwards array slice causes infinite loop

* kjs/array_object.cpp:
        (ArrayProtoFuncImp::call):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Patch from Harri Porten reviewed by me.
mjs [Tue, 18 Nov 2003 05:30:37 +0000 (05:30 +0000)]
    Patch from Harri Porten reviewed by me.

- fixed 3487371 - operator precedence for bitwise or, xor and and is wrong

        * kjs/grammar.y: Correct the precedence.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago Merged from khtml:
mjs [Tue, 18 Nov 2003 04:15:14 +0000 (04:15 +0000)]
Merged from khtml:

-fixed 3487324 -  CSS url values should be wrapped in "url()" for cssText purposes

    2003-11-07  Dirk Mueller  <mueller@kde.org>

* css/css_valueimpl.cpp (cssText): wrap uri's into url().
Stephan Kulow noted that other browsers do that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 years ago*** empty log message ***
hyatt [Tue, 18 Nov 2003 02:39:00 +0000 (02:39 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@5562 268f45cc-cd09-0410-ab3c-d52691b4dbfc