WebKit-https.git
7 years ago[GTK] Set up the TestJavaScriptCore in TestWebKitAPI
zandobersek@gmail.com [Mon, 29 Apr 2013 17:38:31 +0000 (17:38 +0000)]
[GTK] Set up the TestJavaScriptCore in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=115236

Reviewed by Gustavo Noronha Silva.

Set up the TestJavaScriptCore unit test program, consisting of the unit tests
under the TestWebKitAPI/Tests/JavaScriptCore directory.

* TestWebKitAPI/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WIN] Add workaround for UNUSED_PARAM()
paroga@webkit.org [Mon, 29 Apr 2013 17:13:31 +0000 (17:13 +0000)]
[WIN] Add workaround for UNUSED_PARAM()
https://bugs.webkit.org/show_bug.cgi?id=115350

Reviewed by Andreas Kling.

r147882 added an workaround for the MSVC compiler on Windows CE.
Extend this workaround to whole MSVC compiler, since the same
problem occurs with the Visual Studio 10 compiler too.

* wtf/UnusedParam.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd branch-prediction hint to FAST_RETURN_IF_NO_FRONTENDS.
akling@apple.com [Mon, 29 Apr 2013 17:12:00 +0000 (17:12 +0000)]
Add branch-prediction hint to FAST_RETURN_IF_NO_FRONTENDS.
<http://webkit.org/b/115357>

Reviewed by Anders Carlsson.

Since this macro is used in some very hot code paths, give the compiler an extra hint
to try and minimize the impact it has when the inspector is not active.

* inspector/InspectorInstrumentation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WIN] Add WTF_USE_IMLANG_FONT_LINK2
paroga@webkit.org [Mon, 29 Apr 2013 16:33:04 +0000 (16:33 +0000)]
[WIN] Add WTF_USE_IMLANG_FONT_LINK2
https://bugs.webkit.org/show_bug.cgi?id=115198

Reviewed by Andreas Kling.

Source/WebCore:

Add this new define to have a central place for switching
the IMLangFontLinkType and adop all usages of the type.
This makes the usage of the code easier on desktop pcs.

* platform/graphics/FontCache.h:
(WebCore):
* platform/graphics/wince/FontCacheWinCE.cpp:
(WebCore::currentFontContainsCharacter):
(WebCore::createMLangFont):
(WebCore::FontCache::getFontDataForCharacters):
* platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore::SimpleFontData::containsCharacters):

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of "non-composited contents" in CoordinatedLayerTreeHost
commit-queue@webkit.org [Mon, 29 Apr 2013 16:24:18 +0000 (16:24 +0000)]
Get rid of "non-composited contents" in CoordinatedLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=110355

Patch by Noam Rosenthal <noam@webkit.org> on 2013-04-29
Reviewed by Jocelyn Turcotte.

Source/WebCore:

When in force compositing mode, always assume that the main layer needs
a backing store. Make setVisibleContentRectTrajectoryVector and accumulatedCoverRect
recursive so that they don't rely on a specialized layer.

No new testable behavior, changes to coverRect and trajectory vector only
affect tiling latency in rare cases that are not trivial to test.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer:setVisibleContentRectTrajectoryVector):
    Make the trajectory vector recursive, though limited only to layers with
    translate/identity. This allows us to keep the trajectory vector while removing
    the non-composited contents specialization.

(WebCore::CoordinatedGraphicsLayer::accumulatedCoverRect):
    Added accumulatedCoverRect, so that the coverRect calculations for the UI process
    are not bound to the non-composited contents layer.

(WebCore::CoordinatedGraphicsLayer::findDescendantWithContentsRecursively):
    Instead of saving a reference to the non-composited contents layer, we assume that
    the first layer we found recursively which has contents is the one to be used for
    coverRect/trajectory calculations.

(WebCore):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintsIntoWindow):
    Always create a layer for the non-composited contents when in forceCompositing mode.

Source/WebKit2:

Instead of using a special non-composited contents layer, we let RenderLayerCompositor create
a proper GraphicsLayer for that content.
CoordinatedLayerTreeHost now needs to find the main contents layer for the purpose of setting
the trajectory vector and applying the cover rect.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
    Don't create the non-composited layer, instead keep a raw pointer to the root
    compositing layer created by the WebCore compositor.

(WebKit::CoordinatedLayerTreeHost::setNonCompositedContentsNeedDisplay):
(WebKit::CoordinatedLayerTreeHost::setNonCompositedContentsNeedDisplayInRect):
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::paintContents):
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::CoordinatedLayerTreeHost::setVisibleContentsRect):
    Remove non-composited layer specialization.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Build fix. Enabling c++11 for Qt WK2 after r149259.
zarvai@inf.u-szeged.hu [Mon, 29 Apr 2013 16:07:10 +0000 (16:07 +0000)]
[Qt] Build fix. Enabling c++11 for Qt WK2 after r149259.
https://bugs.webkit.org/show_bug.cgi?id=115345

Reviewed by Anders Carlsson.

* WebKit2.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDefine USE(ICU_UNICODE) if USE(WCHAR_UNICODE) is false
paroga@webkit.org [Mon, 29 Apr 2013 15:59:10 +0000 (15:59 +0000)]
Define USE(ICU_UNICODE) if USE(WCHAR_UNICODE) is false
https://bugs.webkit.org/show_bug.cgi?id=115349

Reviewed by Andreas Kling.

Since we support only ICU and WCHAR as Unicode backend (ICU is the default)
automatically use ICU if WCHAR was not selected via compiler defines.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Skip cancel fullscreen request if not made from FullScreen API
bruno.abinader@basyskom.com [Mon, 29 Apr 2013 15:57:49 +0000 (15:57 +0000)]
[WK2][EFL] Skip cancel fullscreen request if not made from FullScreen API
https://bugs.webkit.org/show_bug.cgi?id=108201

Reviewed by Andreas Kling.

Adds a check on WebFullScreenManagerProxyEfl whether fullscreen mode was
set from FullScreen API or not, so it can skip cancelling fullscreen
request if fullscreen mode was set by application, preventing
WebProcess' FullScreenManager from crashing.

EFL unit test available: ewk_view_cancel_full_screen_request.

* UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
(WKViewExitFullScreen):
* UIProcess/API/C/CoordinatedGraphics/WKView.h:
WKViewExitFullScreen now returns a bool, indicating whether the
operation has succeeded or not.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_fullscreen_exit):
Skip request if not in fullscreen mode.

* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
Added ewk_view_cancel_full_screen_request unit test.

* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::exitFullScreen):
* UIProcess/CoordinatedGraphics/WebView.h:
(WebView):
exitFullScreen now returns a bool, indicating whether the operation has
succeeded or not.

* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::WebFullScreenManagerProxy):
* UIProcess/WebFullScreenManagerProxy.h:
(WebFullScreenManagerProxy):
* UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:
(WebKit::WebFullScreenManagerProxy::isFullScreen):
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
Added m_hasRequestedFullScreen boolean flag to EFL port. Used to
indicate if fullscreen mode is enabled, as well as sanity checks on both
{enter,exit}FullScreen functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnimate clip rect() between different Length types
krit@webkit.org [Mon, 29 Apr 2013 15:46:26 +0000 (15:46 +0000)]
Animate clip rect() between different Length types
https://bugs.webkit.org/show_bug.cgi?id=115336

Reviewed by Andreas Kling.

Source/WebCore:

At the moment the animation for the 'clip' property
has an early return if the type of two Length values
does not match. This patch removes this early return.

Modified existing tests to cover the changes.

* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):

LayoutTests:

Modify test for clip animation to cover animations between
different Length types.

* transitions/clip-transition.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWhen updating geometry, send JavaScript resize before before layout/paint.
akling@apple.com [Mon, 29 Apr 2013 15:33:31 +0000 (15:33 +0000)]
When updating geometry, send JavaScript resize before before layout/paint.
<http://webkit.org/b/115199>
<rdar://problem/13735535>

Reviewed by Geoffrey Garen.

Make the "resize" event synchronous and dispatch it before doing any automatic
resize-induced layout. This avoids unnecessary work in cases where an event handler
does something that dirties style.

It also avoids a kind of JS-side FOUC that happens if we drop out to the runloop
and paint before the resize event handler runs; for example, when viewing a popup
on <http://lokeshdhakar.com/projects/lightbox2/> and resizing the window, the dark
overlay sometimes resizes out of sync with the web view, since a paint may happen
between automatic layout and the resize event.

* page/EventHandler.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchResizeEvent):
* page/FrameView.h:
* page/FrameView.cpp:
(WebCore::FrameView::dispatchResizeEvent):

    Renamed sendResizeEvent() to dispatchResizeEvent() and made it dispatch the event
    synchronously instead of adding it to the DocumentEventQueue.

(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::setFrameRect):

    Dispatch the "resize" event right when the new frame rect is set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStop using range-based for syntax
andersca@apple.com [Mon, 29 Apr 2013 15:30:19 +0000 (15:30 +0000)]
Stop using range-based for syntax
https://bugs.webkit.org/show_bug.cgi?id=115356

Reviewed by Andreas Kling.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r148888 and r149097
paroga@webkit.org [Mon, 29 Apr 2013 15:22:32 +0000 (15:22 +0000)]
Build fix for WinCE after r148888 and r149097
https://bugs.webkit.org/show_bug.cgi?id=115168

Reviewed by Anders Carlsson.

When using compiler intrinsics on Windows CE the compiler complains
about wrong linkage specification of replaced CRT functions defined
in math.h. This is because the compiler has intrinsics for this
functions defined, and requires them to have extern "C" linkage.

* wtf/MathExtras.h:
(wtf_atan2): Added extern "C" to function signature.
(wtf_fmod): Ditto.
(wtf_pow): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove OS(WINCE) from (Render|Scrollbar)ThemeWin.cpp
paroga@webkit.org [Mon, 29 Apr 2013 15:04:10 +0000 (15:04 +0000)]
Remove OS(WINCE) from (Render|Scrollbar)ThemeWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=115348

Reviewed by Andreas Kling.

Compile DIBPixelData.cpp on Windows CE too, which allows us
to get rid of a few #if OS(WINCE) in other code parts.

* PlatformWinCE.cmake:
* platform/graphics/win/DIBPixelData.cpp:
(WebCore::DIBPixelData::setRGBABitmapAlpha):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::paintTrackPiece):
(WebCore::ScrollbarThemeWin::paintButton):
(WebCore::ScrollbarThemeWin::paintThumb):
* rendering/RenderThemeWin.cpp:
(WebCore::drawControl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2]: WebProcessMain: hide call to ecore_x_shutdown() under guard
commit-queue@webkit.org [Mon, 29 Apr 2013 14:55:05 +0000 (14:55 +0000)]
[EFL][WK2]: WebProcessMain: hide call to ecore_x_shutdown() under guard
https://bugs.webkit.org/show_bug.cgi?id=115295

Patch by Sergio Correia <sergio.correia@openbossa.org> on 2013-04-29
Reviewed by Andreas Kling.

Since the mentioned function is declared in a header that is included
conditionally depending on HAVE_ECORE_X being defined.

* WebProcess/efl/WebProcessMainEfl.cpp:
(WebKit::WebProcessMainEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fake-bold monospace fonts need to use non-fake-bold advances
commit-queue@webkit.org [Mon, 29 Apr 2013 14:46:05 +0000 (14:46 +0000)]
[BlackBerry] Fake-bold monospace fonts need to use non-fake-bold advances
https://bugs.webkit.org/show_bug.cgi?id=115280

Patch by Eli Fidler <efidler@blackberry.com> on 2013-04-29
Reviewed by George Staikos.

BlackBerry PR 330864

Tested by fast/css/css3-ch-unit.html

* platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp:
(WebCore::FontPlatformData::applyState):
(WebCore::FontPlatformData::isFixedPitch):
* platform/graphics/blackberry/ITypeUtils.h:
* platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:
(WebCore::SimpleFontData::platformWidthForGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][AC] Clean up code related with the children management stuff for clutter based AC
commit-queue@webkit.org [Mon, 29 Apr 2013 14:36:31 +0000 (14:36 +0000)]
[GTK][AC] Clean up code related with the children management stuff for clutter based AC
https://bugs.webkit.org/show_bug.cgi?id=114260

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-04-29
Reviewed by Gustavo Noronha Silva.

Remove unused or usless code for children management stuff.

No new tests since no functionality changed.

* platform/graphics/clutter/GraphicsLayerActor.cpp:
(_GraphicsLayerActorPrivate):
(graphics_layer_actor_class_init):
(graphicsLayerActorAllocate):
(graphicsLayerActorDraw):
(graphicsLayerActorNew):
(graphicsLayerActorSetSublayers):
* platform/graphics/clutter/GraphicsLayerActor.h:
* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::idleDestroy):
(WebCore::GraphicsLayerClutter::ensureStructuralLayer):
(WebCore::GraphicsLayerClutter::updateLayerDrawsContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WIN] Guard cfHDropFormat() with USE(CF) instead of OS(WINCE)
paroga@webkit.org [Mon, 29 Apr 2013 14:26:09 +0000 (14:26 +0000)]
[WIN] Guard cfHDropFormat() with USE(CF) instead of OS(WINCE)
https://bugs.webkit.org/show_bug.cgi?id=115195

Reviewed by Andreas Kling.

USE(CF) is the correct guard, which works on desktop pcs too.

* platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::files):
* platform/win/DragDataWin.cpp:
(WebCore::DragData::containsFiles):
(WebCore::DragData::numberOfFiles):
(WebCore::DragData::asFilenames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Remove build warnings by -Wunused-parameter
commit-queue@webkit.org [Mon, 29 Apr 2013 14:16:20 +0000 (14:16 +0000)]
[WK2] Remove build warnings by -Wunused-parameter
https://bugs.webkit.org/show_bug.cgi?id=115344

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-29
Reviewed by Noam Rosenthal.

Fix build warnigs -Wunused-parameter.

* UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createContextMenuProxy):
* UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::waitForPossibleGeometryUpdate):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::connectionWillClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Mon, 29 Apr 2013 14:06:29 +0000 (14:06 +0000)]
[Qt] Unreviewed gardening.

Move Qt Mac specific results to qt-mac after r149210.

* platform/qt-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Renamed from LayoutTests/platform/qt-5.0/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
* platform/qt-mac/editing/selection/collapse-selection-in-bidi-expected.txt: Renamed from LayoutTests/platform/qt-5.0/editing/selection/collapse-selection-in-bidi-expected.txt.
* platform/qt-mac/editing/selection/drag-start-event-client-x-y-expected.txt: Renamed from LayoutTests/platform/qt-5.0/editing/selection/drag-start-event-client-x-y-expected.txt.
* platform/qt-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt.
* platform/qt-mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/block/basic/fieldset-stretch-to-legend-expected.txt.
* platform/qt-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt.
* platform/qt-mac/fast/borders/fieldsetBorderRadius-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/borders/fieldsetBorderRadius-expected.txt.
* platform/qt-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt.
* platform/qt-mac/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt.
* platform/qt-mac/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt.
* platform/qt-mac/fast/events/document-elementFromPoint-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/events/document-elementFromPoint-expected.txt.
* platform/qt-mac/fast/flexbox/flex-hang-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/flexbox/flex-hang-expected.txt.
* platform/qt-mac/fast/images/repaint-subrect-grid-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/images/repaint-subrect-grid-expected.txt.
* platform/qt-mac/fast/images/zoomed-img-size-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/images/zoomed-img-size-expected.txt.
* platform/qt-mac/fast/multicol/break-properties-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/multicol/break-properties-expected.txt.
* platform/qt-mac/fast/multicol/vertical-lr/break-properties-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/multicol/vertical-lr/break-properties-expected.txt.
* platform/qt-mac/fast/multicol/vertical-rl/break-properties-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/multicol/vertical-rl/break-properties-expected.txt.
* platform/qt-mac/fast/overflow/infiniteRecursionGuard-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/overflow/infiniteRecursionGuard-expected.txt.
* platform/qt-mac/fast/parser/style-script-head-test-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/parser/style-script-head-test-expected.txt.
* platform/qt-mac/fast/reflections/reflection-with-zoom-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/reflections/reflection-with-zoom-expected.txt.
* platform/qt-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt.
* platform/qt-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Renamed from LayoutTests/platform/qt-5.0/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt.
* platform/qt-mac/http/tests/misc/acid3-expected.txt: Renamed from LayoutTests/platform/qt-5.0/http/tests/misc/acid3-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt.
* platform/qt-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt.
* platform/qt-mac/svg/as-image/svg-non-integer-scaled-image-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/as-image/svg-non-integer-scaled-image-expected.txt.
* platform/qt-mac/svg/custom/fractional-rects-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/fractional-rects-expected.txt.
* platform/qt-mac/svg/custom/js-update-container-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/js-update-container-expected.txt.
* platform/qt-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt.
* platform/qt-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt.
* platform/qt-mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt.
* platform/qt-mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/svg-fonts-with-no-element-reference-expected.txt.
* platform/qt-mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt.
* platform/qt-mac/svg/custom/viewBox-hit-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/custom/viewBox-hit-expected.txt.
* platform/qt-mac/svg/hixie/text/001-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/hixie/text/001-expected.txt.
* platform/qt-mac/svg/hixie/text/003a-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/hixie/text/003a-expected.txt.
* platform/qt-mac/svg/text/small-fonts-2-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/text/small-fonts-2-expected.txt.
* platform/qt-mac/svg/text/text-hkern-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/text/text-hkern-expected.txt.
* platform/qt-mac/svg/text/text-viewbox-rescale-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/text/text-viewbox-rescale-expected.txt.
* platform/qt-mac/svg/wicd/sizing-flakiness-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/wicd/sizing-flakiness-expected.txt.
* platform/qt-mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/zoom/page/zoom-background-image-tiled-expected.txt.
* platform/qt-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt.
* platform/qt-mac/svg/zoom/page/zoom-svg-as-image-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/zoom/page/zoom-svg-as-image-expected.txt.
* platform/qt-mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/zoom/page/zoom-svg-as-object-expected.txt.
* platform/qt-mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/zoom/page/zoom-svg-as-relative-image-expected.txt.
* platform/qt-mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Renamed from LayoutTests/platform/qt-5.0/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt.
* platform/qt-mac/tables/mozilla/bugs/bug83786-expected.txt: Renamed from LayoutTests/platform/qt-5.0/tables/mozilla/bugs/bug83786-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Mon, 29 Apr 2013 11:28:53 +0000 (11:28 +0000)]
Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

* GNUmakefile.list.am: Add missing headers files to compilation
and offlineasm/sh4.rb script.

Source/WebCore:

* GNUmakefile.am: Add missing scripts to EXTRA_DIST.
* GNUmakefile.list.am: Add missing files to compilation.

Source/WebKit2:

* GNUmakefile.list.am: Add missing header files to compilation.

Source/WTF:

* GNUmakefile.list.am: Add missing header file to compilation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] fast/canvas/webgl/webgl-composite-modes.html broken after r148433.
commit-queue@webkit.org [Mon, 29 Apr 2013 09:52:58 +0000 (09:52 +0000)]
[Qt] fast/canvas/webgl/webgl-composite-modes.html broken after r148433.
https://bugs.webkit.org/show_bug.cgi?id=115243

Patch by Noam Rosenthal <noam@webkit.org> on 2013-04-29
Reviewed by Jocelyn Turcotte.

When compositing a layer with a canvas or directly composited image, it is
wrong to use TextureMapperLayer::setBackingStore. Instead, setContentsLayer
should be used, which allows for the layer to have both a backing store and
a contents layer.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintSelf):
* platform/graphics/texmap/TextureMapperLayer.h:
(State):
(WebCore::TextureMapperLayer::State::State):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::destroyCanvasIfNeeded):
(WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix.
paroga@webkit.org [Mon, 29 Apr 2013 09:44:07 +0000 (09:44 +0000)]
Unreviewed build fix.

* WebCoreSupport/FrameLoaderClientWinCE.cpp: Added missing header.
* WebView.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix.
paroga@webkit.org [Mon, 29 Apr 2013 09:03:51 +0000 (09:03 +0000)]
Unreviewed build fix.

* bindings/js/WorkerScriptDebugServer.cpp: Added missing header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix.
paroga@webkit.org [Mon, 29 Apr 2013 08:56:15 +0000 (08:56 +0000)]
Unreviewed build fix.

* platform/graphics/wince/FontWinCE.cpp:
(WebCore::generateComponents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove OS(WINCE) from HTMLSelectElement.cpp
paroga@webkit.org [Mon, 29 Apr 2013 08:47:31 +0000 (08:47 +0000)]
Remove OS(WINCE) from HTMLSelectElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=115194

Reviewed by Andreas Kling.

Use the same files like the the other PLATFORM(WIN) ports use.

* PlatformWinCE.cmake:
* html/HTMLSelectElement.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
zandobersek@gmail.com [Mon, 29 Apr 2013 08:05:37 +0000 (08:05 +0000)]
[GTK] Export the COLLECT_NO_DEMANGLE variable on the builders
https://bugs.webkit.org/show_bug.cgi?id=115323

Reviewed by Philippe Normand.

Export the COLLECT_NO_DEMANGLE environment variable on the GTK BuildBot builders.
Its presence enforces linkers to output mangled symbols when reporting linking failures
due to unresolved references. People trying to fix the build can then simply copy
the printed mangled symbol into the symbols.filter file instead of doing a manual build
or connecting to the builders to discover the mangled version of the missing symbol.

* BuildSlaveSupport/gtk/daemontools-buildbot.conf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove Chromium code from Tools/BuildSlaveSupport
zandobersek@gmail.com [Mon, 29 Apr 2013 06:51:20 +0000 (06:51 +0000)]
Remove Chromium code from Tools/BuildSlaveSupport
https://bugs.webkit.org/show_bug.cgi?id=115325

Reviewed by Benjamin Poulain.

Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
covering archiving test results and built products.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
(extractBuiltProduct):
* BuildSlaveSupport/chromium/output-android-device-status: Removed.
* BuildSlaveSupport/chromium/remove-crash-logs: Removed.
* BuildSlaveSupport/test-result-archive:
(archiveTestResults):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove support for Chromium from webkitdirs.pm
commit-queue@webkit.org [Mon, 29 Apr 2013 06:43:25 +0000 (06:43 +0000)]
Remove support for Chromium from webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=115338

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-28
Reviewed by Darin Adler.

* Scripts/webkitdirs.pm:
(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(determineIsQt):
(isAppleWebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename TestRunner's setAudioData to setAudioResult
zandobersek@gmail.com [Mon, 29 Apr 2013 06:17:52 +0000 (06:17 +0000)]
Rename TestRunner's setAudioData to setAudioResult
https://bugs.webkit.org/show_bug.cgi?id=115326

Reviewed by Darin Adler.

Tools:

Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
than the previous one. The change is a simple rename, there's no change in the method's functionality. The
affected tests are adjusted accordingly.

* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::setAudioResult):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setAudioResult):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):

LayoutTests:

Adjust the testRunner.setAudioData references/callsites, the method is now named setAudioResult.

* platform/efl-wk1/TestExpectations:
* webaudio/resources/audio-codec-test.js:
(finishedLoading):
* webaudio/resources/audio-testing.js:
(finishAudioTest):
* webaudio/test-basic.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed fix build break on EFL port since r149259.
gyuyoung.kim@samsung.com [Mon, 29 Apr 2013 05:04:48 +0000 (05:04 +0000)]
Unreviewed fix build break on EFL port since r149259.

In EFL port, there is a non-compatible code when compiling based on C++11. This is a trivial build fix.

I got a confirm from Sam about landing a trivial build fix patch without sign-off from
WK2 owner.

* UIProcess/API/efl/EwkViewCallbacks.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][CMAKE] Build break after r149259
ryuan.choi@samsung.com [Mon, 29 Apr 2013 04:13:56 +0000 (04:13 +0000)]
[EFL][CMAKE] Build break after r149259
https://bugs.webkit.org/show_bug.cgi?id=115339

Reviewed by Gyuyoung Kim.

r149259 used c++11 features(Right angle bracket, Range-based for-loop).
This patch enforces c++0x when cmake based ports build WebKit2 using gcc.

* Source/cmake/WebKitHelpers.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of a duplicate file from LayoutTests/TestExpectations
commit-queue@webkit.org [Mon, 29 Apr 2013 00:57:05 +0000 (00:57 +0000)]
Get rid of a duplicate file from LayoutTests/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=115337

Unreviewed gardening.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-28

* TestExpectations: Remove one of two svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWindows build fix.
rniwa@webkit.org [Sun, 28 Apr 2013 22:45:26 +0000 (22:45 +0000)]
Windows build fix.

Source/WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

* WebKit.vcproj/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStaticHashSetNodeList is unnecessary
rniwa@webkit.org [Sun, 28 Apr 2013 22:21:55 +0000 (22:21 +0000)]
StaticHashSetNodeList is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=115219

Reviewed by Antonio Gomes.

Source/WebCore:

Moved Document::nodesFromRect into Internals::nodesFromRect per
https://chromium.googlesource.com/chromium/blink/+/78207c5c34383fbb807bb9347deb67168f09bb04.

Also made TouchAdjustment functions use HashListSet directly instead of wrapping it inside
a StaticHashSetNodeList since there was no need to use the latter.

With these two changes, I deleted StaticHashSetNodeList.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore):
* dom/Document.h:
(Document):
* dom/StaticHashSetNodeList.cpp: Removed.
* dom/StaticHashSetNodeList.h: Removed.
* page/EventHandler.cpp:
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
* page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::TouchAdjustment::compileZoomableSubtargets):
(WebCore::findBestClickableCandidate):
(WebCore::findBestContextMenuCandidate):
(WebCore::findBestZoomableArea):
* page/TouchAdjustment.h:
(WebCore):
* testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):

Source/WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

* WebKit.vcproj/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Disable canvas backing store scaling (HIGH_DPI_CANVAS)
dino@apple.com [Sun, 28 Apr 2013 21:52:25 +0000 (21:52 +0000)]
[Mac] Disable canvas backing store scaling (HIGH_DPI_CANVAS)
https://bugs.webkit.org/show_bug.cgi?id=115310

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Remove ENABLE_HIGH_DPI_CANVAS_macosx.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Disable the automatic pixel doubling in canvas backing stores on high
dpi devices. This will potentially make canvases look worse of high dpi
displays, but only if they were ignoring devicePixelRatio. Since the
majority of high dpi displays *do not* auto-double (including mobile
devices and other desktop browsers), this provides consistency and less
chance of unnecessary memory use.

* Configurations/FeatureDefines.xcconfig: Remove ENABLE_HIGH_DPI_CANVAS_macosx.

Source/WebKit/mac:

Remove ENABLE_HIGH_DPI_CANVAS_macosx.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Remove ENABLE_HIGH_DPI_CANVAS_macosx.

* Configurations/FeatureDefines.xcconfig:

LayoutTests:

No need for platform-specific results any more.

* fast/canvas/2d.backingStorePixelRatio-expected.txt:
* fast/canvas/2d.imageDataHD-expected.txt:
* fast/canvas/canvas-resize-reset-pixelRatio-expected.txt:
* platform/win/fast/canvas/2d.backingStorePixelRatio-expected.txt: Removed.
* platform/win/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebKit2] Adopt new API for detecting window occlusion
weinig@apple.com [Sun, 28 Apr 2013 20:31:22 +0000 (20:31 +0000)]
[WebKit2] Adopt new API for detecting window occlusion
https://bugs.webkit.org/show_bug.cgi?id=115334

Reviewed by Simon Fraser.

Switch off of WKSI for window occlusion and use the new NSWindowDidChangeOcclusionState notification
instead.

* UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]):
(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
(-[WKView viewWillMoveToWindow:]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView _setIsWindowOccluded:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView windowOcclusionDetectionEnabled]):
(-[WKView setWindowOcclusionDetectionEnabled:]):
Only compile occlusion detection code where supported and remove calls to register/deregister
for detection callbacks, now that NSWindow will handle that for us. We also no longer need to
track all the WKViews, as that was only required to lookup the view that matched the window number
returned from the occlusion callback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse OwnPtr<PluginControllerProxy> for storing plug-in controllers in WebProcessConnection
andersca@apple.com [Sun, 28 Apr 2013 18:17:18 +0000 (18:17 +0000)]
Use OwnPtr<PluginControllerProxy> for storing plug-in controllers in WebProcessConnection
https://bugs.webkit.org/show_bug.cgi?id=115259

Reviewed by Andreas Kling.

* PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::addPluginControllerProxy):
(WebKit::WebProcessConnection::removePluginControllerProxy):
(WebKit::WebProcessConnection::didClose):
* PluginProcess/WebProcessConnection.h:
(WebProcessConnection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WKTR] Tests dumping audio data shouldn't dump pixels
zandobersek@gmail.com [Sun, 28 Apr 2013 12:39:19 +0000 (12:39 +0000)]
[WKTR] Tests dumping audio data shouldn't dump pixels
https://bugs.webkit.org/show_bug.cgi?id=115270

Reviewed by Benjamin Poulain.

Tools:

Prevent dumping the pixel output when Web Audio tests are dumping output data
as the testing output. Pixel output in these tests has no real meaning and is
as such unnecessary.

* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setAudioData):

LayoutTests:

Remove the now-unnecessary pixel baselines for audio tests that were used on the EFL WK2 platform.

* platform/efl-wk2/webaudio/audiobuffersource-expected.png: Removed.
* platform/efl-wk2/webaudio/audiobuffersource-loop-points-expected.png: Removed.
* platform/efl-wk2/webaudio/audiobuffersource-multi-channels-expected.png: Removed.
* platform/efl-wk2/webaudio/audiobuffersource-playbackrate-expected.png: Removed.
* platform/efl-wk2/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.png: Removed.
* platform/efl-wk2/webaudio/codec-tests/wav/24bit-22khz-resample-expected.png: Removed.
* platform/efl-wk2/webaudio/codec-tests/wav/24bit-44khz-expected.png: Removed.
* platform/efl-wk2/webaudio/gain-expected.png: Removed.
* platform/efl-wk2/webaudio/mixing-expected.png: Removed.
* platform/efl-wk2/webaudio/oscillator-custom-expected.png: Removed.
* platform/efl-wk2/webaudio/oscillator-sawtooth-expected.png: Removed.
* platform/efl-wk2/webaudio/oscillator-sine-expected.png: Removed.
* platform/efl-wk2/webaudio/oscillator-square-expected.png: Removed.
* platform/efl-wk2/webaudio/oscillator-triangle-expected.png: Removed.
* platform/efl-wk2/webaudio/up-mixing-mono-51-expected.png: Removed.
* platform/efl-wk2/webaudio/up-mixing-mono-stereo-expected.png: Removed.
* platform/efl-wk2/webaudio/up-mixing-stereo-51-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of [Callback] IDL extended attribute for parameters
ch.dumez@sisa.samsung.com [Sun, 28 Apr 2013 09:38:28 +0000 (09:38 +0000)]
Get rid of [Callback] IDL extended attribute for parameters
https://bugs.webkit.org/show_bug.cgi?id=115250

Reviewed by Kentaro Hara.

Remove the WebKit-specific [Callback] extended attribute and make the bindings
generator smart enough to know when a parameter is of callback type on its
own.

No new tests, no behavior change.

* DerivedSources.make: Use WebCore/Modules as IDL include path instead of using
subdirs. The generator will search recursively anyway and the list of subdirs was
incomplete.
* Modules/filesystem/DOMWindowFileSystem.idl:
* Modules/filesystem/DirectoryEntry.idl:
* Modules/filesystem/DirectoryReader.idl:
* Modules/filesystem/Entry.idl:
* Modules/filesystem/FileEntry.idl:
* Modules/filesystem/WorkerContextFileSystem.idl:
* Modules/mediastream/NavigatorMediaStream.idl:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/notifications/Notification.idl:
* Modules/notifications/NotificationCenter.idl:
* Modules/quota/StorageInfo.idl:
* Modules/quota/StorageQuota.idl:
* Modules/webaudio/AudioContext.idl:
* Modules/webdatabase/DOMWindowWebDatabase.idl:
* Modules/webdatabase/Database.idl:
* Modules/webdatabase/DatabaseSync.idl:
* Modules/webdatabase/SQLTransaction.idl:
* Modules/webdatabase/WorkerContextWebDatabase.idl:
* bindings/gobject/GNUmakefile.am: Add missing IDL include dirs.
* bindings/scripts/CodeGenerator.pm:
(IsWrapperType):
(IsCallbackInterface):
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
* bindings/scripts/IDLAttributes.txt: Remove "Callback" extended attribute.
* bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
(WebDOMTestCallback::callbackWithArrayParam):
(WebDOMTestCallback::callbackWithSerializedScriptValueParam):
(WebDOMTestCallback::callbackWithNonBoolReturnType):
(WebDOMTestCallback::callbackRequiresThisToPass):
* bindings/scripts/test/CPP/WebDOMTestCallback.h:
(WebDOMTestCallback):
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::convert1):
(WebDOMTestObj::convert2):
(WebDOMTestObj::convert4):
(WebDOMTestObj::convert5):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
(WebDOMTestSerializedScriptValueInterface::acceptTransferList):
(WebDOMTestSerializedScriptValueInterface::multiTransferList):
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
* bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
(WebDOMTestTypedefs::multiTransferList):
* bindings/scripts/test/CPP/WebDOMTestTypedefs.h:
(WebDOMTestTypedefs):
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
(webkit_dom_test_callback_callback_with_array_param):
(webkit_dom_test_callback_callback_with_serialized_script_value_param):
(webkit_dom_test_callback_callback_with_non_bool_return_type):
(webkit_dom_test_callback_callback_requires_this_to_pass):
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_convert1):
(webkit_dom_test_obj_convert2):
(webkit_dom_test_obj_convert4):
(webkit_dom_test_obj_convert5):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_accept_transfer_list):
(webkit_dom_test_serialized_script_value_interface_multi_transfer_list):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
(webkit_dom_test_typedefs_multi_transfer_list):
* bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::callbackWithArrayParam):
(WebCore::JSTestCallback::callbackWithSerializedScriptValueParam):
(WebCore::JSTestCallback::callbackRequiresThisToPass):
* bindings/scripts/test/JS/JSTestCallback.h:
(JSTestCallback):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionMultiTransferList):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsPrototypeFunctionMultiTransferList):
* bindings/scripts/test/ObjC/DOMTestCallback.h:
* bindings/scripts/test/ObjC/DOMTestCallback.mm:
(-[DOMTestCallback callbackWithArrayParam:]):
(-[DOMTestCallback callbackWithSerializedScriptValueParam:strArg:]):
(-[DOMTestCallback callbackWithNonBoolReturnType:]):
(-[DOMTestCallback callbackRequiresThisToPass:testNodeParam:]):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj convert1:]):
(-[DOMTestObj convert2:]):
(-[DOMTestObj convert4:]):
(-[DOMTestObj convert5:]):
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
(-[DOMTestSerializedScriptValueInterface acceptTransferList:transferList:]):
(-[DOMTestSerializedScriptValueInterface multiTransferList:tx:second:txx:]):
* bindings/scripts/test/ObjC/DOMTestTypedefs.h:
* bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
(-[DOMTestTypedefs multiTransferList:tx:second:txx:]):
* bindings/scripts/test/TestCallback.idl: Use valid types instead of Class1, Class2, ...
so that the bindings generator does not complain about not being able to resolve
them.
* bindings/scripts/test/TestObj.idl: Use valid parameter types instead of 'a', 'b', 'd', 'e'
so that the bindings generator does not complain about them.
* bindings/scripts/test/TestSerializedScriptValueInterface.idl:
* bindings/scripts/test/TestTypedefs.idl:
* css/FontLoader.idl:
* dom/DataTransferItem.idl:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix.
jberlin@webkit.org [Sun, 28 Apr 2013 04:53:52 +0000 (04:53 +0000)]
Build fix.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveBuffer):
Do not declare another variable with the same name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove from constructor and member function adoptCF/NS to free function adoptCF/NS.
darin@apple.com [Sun, 28 Apr 2013 03:51:20 +0000 (03:51 +0000)]
Move from constructor and member function adoptCF/NS to free function adoptCF/NS.
https://bugs.webkit.org/show_bug.cgi?id=115307

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* heap/HeapTimer.cpp:
(JSC::HeapTimer::HeapTimer):
* runtime/VM.cpp:
(JSC::enableAssembler):
Use adoptCF free function.

Source/WebCore:

This change was done by a global replace followed by compiling and inspecting for
cases that needed to be tweaked by hand.

* accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::attachWrapper):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::attachWrapper):
* bridge/objc/objc_class.mm:
(JSC::Bindings::ObjcClass::methodNamed):
(JSC::Bindings::ObjcClass::fieldNamed):
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcField::ObjcField):
* editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
* history/cf/HistoryPropertyList.cpp:
(WebCore::HistoryPropertyListWriter::releaseData):
* html/HTMLMediaElement.cpp:
(WebCore::createFileURLForApplicationCacheResource):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::rawDataRepresentation):
* loader/archive/cf/LegacyWebArchiveMac.mm:
(WebCore::LegacyWebArchive::createPropertyListRepresentation):
* loader/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::willCacheResponse):
* page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::userPrefersCaptions):
(WebCore::CaptionUserPreferencesMac::userPrefersSubtitles):
(WebCore::CaptionUserPreferencesMac::captionsWindowCSS):
(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS):
(WebCore::CaptionUserPreferencesMac::captionsTextColor):
(WebCore::CaptionUserPreferencesMac::captionsDefaultFontCSS):
(WebCore::CaptionUserPreferencesMac::preferredLanguages):
(WebCore::trackDisplayName):
* platform/Language.cpp:
(WebCore::displayNameForLanguageLocale):
* platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagSearchWeb):
(WebCore::imageTitle):
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):
* platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::AudioFileReader):
* platform/cf/KURLCFNet.cpp:
(WebCore::KURL::fileSystemPath):
* platform/cf/SharedBufferCF.cpp:
(WebCore::SharedBuffer::maybeTransferPlatformData):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setContentsToImage):
* platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
(WebCore::LayerFlushScheduler::schedule):
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
(PlatformCAAnimation::PlatformCAAnimation):
* platform/graphics/ca/mac/PlatformCAFiltersMac.mm:
(PlatformCAFilters::filterValueForOperation):
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::addAnimationForKey):
(PlatformCALayer::setBackgroundColor):
(PlatformCALayer::setBorderColor):
* platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::getCGImageArray):
* platform/graphics/cg/ColorCG.cpp:
(WebCore::cachedCGColor):
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::setURLForRect):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::createIOSurface):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::putByteArray):
(WebCore::CGImageEncodeToData):
(WebCore::CGImageToDataURL):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):
* platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::imageWithColorSpace):
(WebCore::Image::drawPattern):
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::setData):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::dataChanged):
* platform/graphics/cg/PathCG.cpp:
(WebCore::createScratchContext):
(WebCore::Path::contains):
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):
(WebCore::createFeatureSettingDictionary):
(WebCore::cascadeToLastResortFontDescriptor):
(WebCore::cascadeToLastResortAndDisableSwashesFontDescriptor):
(WebCore::FontPlatformData::ctFont):
(WebCore::FontPlatformData::description):
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::DrawingBuffer):
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
(-[WebCascadeList objectAtIndex:]):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
* platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::GlyphPage::fill):
* platform/graphics/mac/GraphicsContext3DMac.mm:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::linearRGBColorSpaceRef):
* platform/graphics/mac/ImageMac.mm:
(WebCore::BitmapImage::getTIFFRepresentation):
(WebCore::BitmapImage::getNSImage):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
(WebCore::addFileTypesToCache):
* platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::SimpleFontData::getCFStringAttributes):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::fontHasVerticalGlyphs):
(WebCore::SimpleFontData::getCompositeFontReferenceFontData):
(WebCore::SimpleFontData::platformCharWidthInit):
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):
* platform/graphics/mac/WebGLLayer.mm:
(-[WebGLLayer copyImageSnapshotWithColorSpace:]):
* platform/mac/ContentFilterMac.mm:
(WebCore::ContentFilter::ContentFilter):
* platform/mac/ContextMenuItemMac.mm:
(WebCore::ContextMenuItem::ContextMenuItem):
* platform/mac/CursorMac.mm:
(WebCore::createCustomCursor):
(WebCore::createNamedCursor):
* platform/mac/DisplaySleepDisabler.cpp:
(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):
* platform/mac/DragImageMac.mm:
(WebCore::dissolveDragImageToFraction):
(WebCore::createDragImageFromImage):
* platform/mac/HTMLConverter.mm:
(+[WebHTMLConverter editingAttributedStringFromRange:]):
* platform/mac/Language.mm:
(WebCore::httpStyleLanguageCode):
(WebCore::platformUserPreferredLanguages):
* platform/mac/LocalizedStringsMac.cpp:
(WebCore::localizedString):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getDataSelection):
(WebCore::Pasteboard::writeSelectionForTypes):
(WebCore::fragmentFromWebArchive):
* platform/mac/PlatformClockCM.mm:
(PlatformClockCM::PlatformClockCM):
(PlatformClockCM::initializeWithTimingSource):
* platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::addTypes):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setPathnamesForType):
* platform/mac/PlatformSpeechSynthesizerMac.mm:
(WebCore::PlatformSpeechSynthesizer::speak):
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenuMac::populate):
(WebCore::PopupMenuMac::show):
* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateExpansionTransitionWithDuration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
* platform/mac/SharedBufferMac.mm:
(WebCore::SharedBuffer::createCFData):
* platform/mac/WebCoreNSStringExtras.mm:
(stringEncodingForResource):
* platform/network/ProtectionSpace.cpp:
(WebCore::ProtectionSpace::receivesCredentialSecurely):
* platform/network/SynchronousLoaderClient.cpp:
(WebCore::SynchronousLoaderClient::platformBadResponseError):
* platform/network/cf/CredentialStorageCFNet.cpp:
(WebCore::CredentialStorage::getFromPersistentStorage):
* platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
* platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::advanceCurrentStream):
* platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::overrideCookieStorage):
* platform/network/cf/ProxyServerCFNet.cpp:
(WebCore::proxyAutoConfigurationResultCallback):
(WebCore::processProxyServers):
(WebCore::addProxyServersForURL):
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::platformLazyInit):
(WebCore::ResourceError::cfError):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::handleDataArray):
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::setHeaderFields):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::setStorageSession):
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::cfURLResponse):
(WebCore::ResourceResponse::platformLazyInit):
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::executePACFileURL):
(WebCore::SocketStreamHandle::chooseProxy):
(WebCore::SocketStreamHandle::createStreams):
(WebCore::SocketStreamHandle::addCONNECTCredentials):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::reportErrorToClient):
* platform/network/mac/AuthenticationMac.mm:
(WebCore::mac):
(WebCore::AuthenticationChallenge::setAuthenticationClient):
* platform/network/mac/CookieJarMac.mm:
(WebCore::filterCookies):
* platform/network/mac/NetworkStateNotifierMac.cpp:
(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
* platform/network/mac/ResourceErrorMac.mm:
(WebCore::createNSErrorFromResourceErrorBase):
(WebCore::ResourceError::nsError):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::initNSURLResponse):
(WebCore::ResourceResponse::nsURLResponse):
(WebCore::ResourceResponse::platformLazyInit):
* platform/network/mac/UTIUtilities.mm:
(WebCore::mimeTypeFromUTITree):
* platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary):
* platform/text/cf/HyphenationCF.cpp:
(WebCore::::createValueForNullKey):
(WebCore::lastHyphenLocation):
* platform/text/mac/HyphenationMac.mm:
(WebCore::::createValueForKey):
(WebCore::lastHyphenLocation):
* platform/text/mac/LocaleMac.mm:
(WebCore::determineLocale):
(WebCore::LocaleMac::LocaleMac):
(WebCore::LocaleMac::initializeLocaleData):
* platform/text/mac/TextBreakIteratorInternalICUMac.mm:
(WebCore::textBreakLocalePreference):
(WebCore::canonicalLanguageIdentifier):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::popupButton):
(WebCore::RenderThemeMac::search):
(WebCore::RenderThemeMac::searchMenuTemplate):
(WebCore::RenderThemeMac::sliderThumbHorizontal):
(WebCore::RenderThemeMac::sliderThumbVertical):
(WebCore::RenderThemeMac::textField):
Use adoptNS and adoptCF free functions.

Source/WebKit/cf:

* WebCoreSupport/WebInspectorClientCF.cpp:
(populateSetting): Use adoptCF.

Source/WebKit/mac:

This change was done by a global replace followed by compiling and inspecting for
cases that needed to be tweaked by hand.

* DefaultDelegates/WebDefaultContextMenuDelegate.mm:
(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
* Misc/WebNSFileManagerExtras.mm:
(-[NSFileManager _webkit_startupVolumeName]):
* Plugins/Hosted/HostedNetscapePluginStream.mm:
(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
* Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::instantiatePlugin):
* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::beginModal):
(WKPCBooleanAndDataReply):
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::print):
(WebKit::NetscapePluginInstanceProxy::snapshot):
(WebKit::NetscapePluginInstanceProxy::status):
(WebKit::NetscapePluginInstanceProxy::loadURL):
(WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
(WebKit::NetscapePluginInstanceProxy::enumerate):
(WebKit::NetscapePluginInstanceProxy::marshalValue):
(WebKit::NetscapePluginInstanceProxy::marshalValues):
(WebKit::NetscapePluginInstanceProxy::demarshalValue):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView setAttributeKeys:andValues:]):
(-[WebHostedNetscapePluginView createPlugin]):
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebBaseNetscapePluginView cacheSnapshot]):
(WebKit::getAuthenticationInfo):
* Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage initWithPath:]):
* Plugins/WebNetscapePluginEventHandlerCarbon.mm:
(WebNetscapePluginEventHandlerCarbon::startTimers):
* Plugins/WebNetscapePluginEventHandlerCocoa.mm:
(WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
(WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
* Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage _initWithPath:]):
* Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::WebNetscapePluginStream):
(WebNetscapePluginStream::deliverData):
(WebNetscapePluginStream::deliverDataToFile):
(WebNetscapePluginStream::didReceiveData):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView createPlugin]):
(-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
* Storage/WebDatabaseManagerClient.mm:
(WebDatabaseManagerClient::dispatchDidModifyOrigin):
(WebDatabaseManagerClient::dispatchDidModifyDatabase):
* Storage/WebStorageTrackerClient.mm:
(WebStorageTrackerClient::dispatchDidModifyOrigin):
* WebCoreSupport/CorrectionPanel.mm:
(CorrectionPanel::handleAcceptedReplacement):
* WebCoreSupport/WebApplicationCache.mm:
(+[WebApplicationCache originsWithCache]):
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::didRunInsecureContent):
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):
* WebView/WebFullScreenController.mm:
(-[WebFullScreenController enterFullScreen:]):
* WebView/WebPDFDocumentExtras.mm:
(allScriptsInPDFDocument):
* WebView/WebPreferences.mm:
(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences initWithCoder:]):
* WebView/WebScriptDebugger.mm:
(WebScriptDebugger::initGlobalCallFrame):
(WebScriptDebugger::callEvent):
* WebView/WebView.mm:
(-[WebView previousValidKeyView]):
Use adoptNS and adoptCF free functions.

Source/WebKit2:

This change was done by a global replace followed by compiling and inspecting for
cases that needed to be tweaked by hand.

* Platform/cg/CGUtilities.cpp:
(WebKit::paintBitmapContext):
* Platform/mac/ModuleMac.mm:
(WebKit::Module::load):
(WebKit::Module::platformFunctionPointer):
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::initializeSandbox):
* Shared/API/c/mac/WKURLRequestNS.mm:
(WKURLRequestCreateWithNSURLRequest):
* Shared/API/c/mac/WKURLResponseNS.mm:
(WKURLResponseCreateWithNSURLResponse):
* Shared/Downloads/mac/DownloadMac.mm:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
* Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
(WebKit::ChildProcessMain):
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginArchitecture):
(WebKit::contentsOfPropertyListAtURL):
(WebKit::getMIMETypesFromPluginBundle):
(WebKit::getStringListResource):
(WebKit::NetscapePluginModule::getPluginInfo):
* Shared/ShareableResource.cpp:
(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):
* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode):
(CoreIPC::encode):
* Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::makeCGImageCopy):
(WebKit::ShareableBitmap::makeCGImage):
(WebKit::ShareableBitmap::createCGImage):
* Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::decode):
* Shared/mac/PlatformCertificateInfo.mm:
(WebKit::PlatformCertificateInfo::dump):
* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
* UIProcess/API/mac/FindIndicatorWindow.mm:
(WebKit::FindIndicatorWindow::setFindIndicator):
(WebKit::FindIndicatorWindow::startFadeOutTimerFired):
* UIProcess/API/mac/PDFViewController.mm:
(-[WKPDFView initWithFrame:PDFViewController:]):
(WebKit::PDFViewController::PDFViewController):
(WebKit::convertPostScriptDataSourceToPDF):
(WebKit::PDFViewController::setPDFDocumentData):
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::setDragImage):
* UIProcess/API/mac/WKBrowsingContextController.mm:
(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):
* UIProcess/API/mac/WKConnection.mm:
(didReceiveMessage):
* UIProcess/API/mac/WKPrintingView.mm:
(-[WKPrintingView drawRect:]):
* UIProcess/API/mac/WKView.mm:
(-[WKView browsingContextController]):
(-[WKView _setAcceleratedCompositingModeRootLayer:]):
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):
(-[WKView fullScreenWindowController]):
(-[WKView _executeSavedCommandBySelector:]):
(-[WKView printOperationWithPrintInfo:forFrame:]):
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::createProcess):
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::pluginPathsInDirectory):
(WebKit::PluginInfoStore::getMIMETypeForExtension):
* UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::beginModal):
* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::sessionStateData):
(WebKit::WebPageProxy::restoreFromSessionStateData):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):
* UIProcess/cf/WebPreferencesCF.cpp:
(WebKit::cfStringFromWebCoreString):
(WebKit::setStringValueIfInUserDefaults):
(WebKit::setBoolValueIfInUserDefaults):
(WebKit::setUInt32ValueIfInUserDefaults):
(WebKit::setDoubleValueIfInUserDefaults):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
(WebKit::WebPreferences::platformUpdateDoubleValueForKey):
(WebKit::WebPreferences::platformUpdateFloatValueForKey):
* UIProcess/mac/BackingStoreMac.mm:
(WebKit::BackingStore::resetScrolledRect):
(WebKit::BackingStore::backingStoreContext):
* UIProcess/mac/CorrectionPanel.mm:
(WebKit::CorrectionPanel::handleAcceptedReplacement):
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultDiskCacheDirectory):
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::populate):
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::populate):
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
* WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::load):
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::updatePluginLayer):
* WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
(WebKit::PluginProxy::pluginLayer):
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::PDFPlugin):
(WebKit::PDFPlugin::createScrollbar):
(WebKit::PDFPlugin::pdfDocumentDidLoad):
(WebKit::PDFPlugin::writeItemsToPasteboard):
* WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
(getAllScriptsInPDFDocument):
(WebKit::SimplePDFPlugin::pdfDocumentDidLoad):
(WebKit::SimplePDFPlugin::streamDidReceiveData):
(WebKit::SimplePDFPlugin::manualStreamDidReceiveData):
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
* WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:
(WebKit::WebResourceCacheManager::cfURLCacheHostNames):
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames):
* WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
(WebKit::createNSError):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawPagesToPDF):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForRange):
(WebKit::cachedResponseForURL):
(WebKit::WebPage::drawPagesToPDFFromPDFDocument):
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformSetCacheModel):
Use adoptCF and adoptNS free functions.

Source/WTF:

* wtf/RunLoopTimerCF.cpp:
(WTF::RunLoopTimerBase::start):
* wtf/SchedulePair.h:
(WTF::SchedulePair::SchedulePair):
* wtf/SchedulePairMac.mm:
(WTF::SchedulePair::SchedulePair):
* wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault):
Use adoptCF free function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPressing mouse button inside a dragstart event causes a crash
rniwa@webkit.org [Sun, 28 Apr 2013 03:43:25 +0000 (03:43 +0000)]
Pressing mouse button inside a dragstart event causes a crash
https://bugs.webkit.org/show_bug.cgi?id=115296

Reviewed by Darin Adler.

Source/WebCore:

Add a missing null pointer check. We should better encapsulate the states in DragState in the long term
but this is good enough for now.

Test: fast/events/mousedown-inside-dragstart-should-not-cause-crash.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag):

LayoutTests:

Added a regression test. While the bug report involves opening inspector and setting a breakpoint,
a simpler reduction that uses eventSender significantly reduces the complexity.

* fast/events/mousedown-inside-dragstart-should-not-cause-crash-expected.txt: Added.
* fast/events/mousedown-inside-dragstart-should-not-cause-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago <rdar://problem/13757007> Crashes in NetworkResourceLoader::didReceiveRespons...
ap@apple.com [Sun, 28 Apr 2013 03:38:57 +0000 (03:38 +0000)]
    <rdar://problem/13757007> Crashes in NetworkResourceLoader::didReceiveResponseAsync
        https://bugs.webkit.org/show_bug.cgi?id=115318

        Reviewed by Darin Adler.

        sendAbortingOnFailure may actually fail, and abort the request, making m_handle null.

        * NetworkProcess/NetworkResourceLoader.cpp:
        (WebKit::NetworkResourceLoader::didReceiveResponseAsync): Null check m_handle after
        sending a message, because the request will cancelled when connection is invalid.
        (WebKit::NetworkResourceLoader::didReceiveBuffer): Assert that m_handle matches
        the handle that we are called with.
        (WebKit::NetworkResourceLoader::didFinishLoading): Ditto.
        (WebKit::NetworkResourceLoader::didFail): Ditto.
        (WebKit::NetworkResourceLoader::willSendRequestAsync): Ditto.
        (WebKit::NetworkResourceLoader::didSendData): Ditto.
        (WebKit::NetworkResourceLoader::shouldUseCredentialStorage): Ditto.
        (WebKit::NetworkResourceLoader::shouldUseCredentialStorageAsync): Ditto.
        (WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge): Ditto.
        (WebKit::NetworkResourceLoader::didCancelAuthenticationChallenge): Ditto.
        (WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix the Windows build.
andersca@apple.com [Sun, 28 Apr 2013 03:37:12 +0000 (03:37 +0000)]
Try to fix the Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/13757687> Threads get stuck in NetworkProcess when canceling loads
ap@apple.com [Sun, 28 Apr 2013 03:22:55 +0000 (03:22 +0000)]
<rdar://problem/13757687> Threads get stuck in NetworkProcess when canceling loads
https://bugs.webkit.org/show_bug.cgi?id=115319

Reviewed by Darin Adler.

WebResourceLoader was second-guessing NetworkProcess as to whether it needs a response
to DidReceiveResponseWithCertificateInfo, and it was guessing wrong if the load was
alrady canceled on WebProcess side.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
* WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
* WebProcess/Network/WebResourceLoader.h:
* WebProcess/Network/WebResourceLoader.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix when disabling video and video-track.
gyuyoung.kim@samsung.com [Sun, 28 Apr 2013 01:17:01 +0000 (01:17 +0000)]
Unreviewed build fix when disabling video and video-track.

* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebGL shouldn't allocate a "length" Identifier just to move some numbers around
ggaren@apple.com [Sun, 28 Apr 2013 00:09:21 +0000 (00:09 +0000)]
WebGL shouldn't allocate a "length" Identifier just to move some numbers around
https://bugs.webkit.org/show_bug.cgi?id=115317

Reviewed by Dean Jackson.

Saw this while debugging an ammo.js bug.

* bindings/js/JSArrayBufferViewHelper.h:
(WebCore::setWebGLArrayWithTypedArrayArgument):
(WebCore::setWebGLArrayHelper):
(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore::constructArrayBufferView):
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toVector): Use the pre-computed "length" identifier instead of
allocating a new one for each vector operation. There are lots more
optimizations we could do here. This is a start.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCleaned up pre/post inc/dec in bytecode
ggaren@apple.com [Sat, 27 Apr 2013 23:14:04 +0000 (23:14 +0000)]
Cleaned up pre/post inc/dec in bytecode
https://bugs.webkit.org/show_bug.cgi?id=115222

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

A few related changes here:

(*) Removed post_inc and post_dec. The two-result form was awkward to
reason about. Being explicit about the intermediate mov and to_number
reduces DFG overhead, removes some fragile ASSERTs from the DFG, and
fixes a const bug. Plus, we get to blow away 262 lines of code.

(*) Renamed pre_inc and pre_dec to inc and dec, since there's only one
version now.

(*) Renamed to_jsnumber to to_number, to match the ECMA name.

(*) Tightened up the codegen and runtime support for to_number.

* JavaScriptCore.order: Order!

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
* bytecode/Opcode.h:
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitInc):
(JSC::BytecodeGenerator::emitDec):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitToNumber):
(BytecodeGenerator): Removed post_inc and post_dec.

* bytecompiler/NodesCodegen.cpp:
(JSC::emitPreIncOrDec): Updated for rename.

(JSC::emitPostIncOrDec): Issue an explicit mov and to_number when needed.
These are rare, and they boil away in the DFG.

(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve): For const, use an explicit mov instead
of any special forms. This fixes a bug where we would do string
add/subtract instead of number.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_inc):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emitSlow_op_dec):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_inc):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emitSlow_op_dec): Removed post_inc/dec, and updated for renames.

* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_to_number):
(JSC::JIT::emitSlow_op_to_number): Removed a test for number cells. There's
no such thing!

* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_to_number): Use LowestTag to avoid making assumptions
about the lowest valued tag.

(JSC::JIT::emitSlow_op_to_number): Updated for renames.

* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LLIntSlowPaths.h:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* parser/NodeConstructors.h:
(JSC::UnaryPlusNode::UnaryPlusNode): Removed post_inc/dec, and updated for renames.

* runtime/Operations.cpp:
(JSC::jsIsObjectType): Removed a test for number cells. There's
no such thing!

LayoutTests:

* fast/js/const-expected.txt:
* fast/js/resources/const.js: Added tests for some const cases we used
to get wrong.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression tests that reference a non-local resource crash with NetworkProcess enabled
ap@apple.com [Sat, 27 Apr 2013 23:02:47 +0000 (23:02 +0000)]
Regression tests that reference a non-local resource crash with NetworkProcess enabled
https://bugs.webkit.org/show_bug.cgi?id=115290

Reviewed by Sam Weinig.

Covered by fast/dom/icon-url-change.html and many other existing tests.

* WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::remove): Handle this case. Architecturally, it
would be better if SubresourceLoad::create just created an object an didn't do
further checks before returning a pointer, but changing that is beyond the scope
of the fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove two more StorageTask types
andersca@apple.com [Sat, 27 Apr 2013 20:55:45 +0000 (20:55 +0000)]
Remove two more StorageTask types
https://bugs.webkit.org/show_bug.cgi?id=115312

Reviewed by Dean Jackson.

* storage/StorageTask.cpp:
(WebCore::StorageTask::performTask):
* storage/StorageTask.h:
* storage/StorageTracker.cpp:
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::deleteOrigin):
* storage/StorageTracker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of more uses of StorageTask
andersca@apple.com [Sat, 27 Apr 2013 20:44:04 +0000 (20:44 +0000)]
Get rid of more uses of StorageTask
https://bugs.webkit.org/show_bug.cgi?id=115311

Reviewed by Dean Jackson.

Make StorageAreaSync derive from ThreadSafeRefCounted as well, since it's passed between threads.

* storage/StorageAreaSync.h:
* storage/StorageSyncManager.cpp:
(WebCore::StorageSyncManager::scheduleImport):
(WebCore::StorageSyncManager::scheduleSync):
(WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase):
* storage/StorageTask.cpp:
(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::performTask):
* storage/StorageTask.h:
(StorageTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndent StorageAreaSync to match the style guidelines.
andersca@apple.com [Sat, 27 Apr 2013 20:32:28 +0000 (20:32 +0000)]
Indent StorageAreaSync to match the style guidelines.

Rubber-stamped by Andreas Kling.

* storage/StorageAreaSync.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace uses of StorageTask with StorageThread::dispatch and WTF::bind
andersca@apple.com [Sat, 27 Apr 2013 20:28:30 +0000 (20:28 +0000)]
Replace uses of StorageTask with StorageThread::dispatch and WTF::bind
https://bugs.webkit.org/show_bug.cgi?id=115309

Reviewed by Andreas Kling.

* storage/StorageTask.cpp:
(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::performTask):
* storage/StorageTask.h:
* storage/StorageThread.cpp:
(WebCore::StorageThread::terminate):
(WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads):
* storage/StorageThread.h:
* storage/StorageTracker.cpp:
(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::deleteAllOrigins):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd StorageThread::dispatch
andersca@apple.com [Sat, 27 Apr 2013 19:59:04 +0000 (19:59 +0000)]
Add StorageThread::dispatch
https://bugs.webkit.org/show_bug.cgi?id=115308

Reviewed by Andreas Kling.

StorageThread::dispatch takes a Function<void ()> and runs it on the storage thread. This will be used to eventually get rid of StorageTask.

* storage/StorageTask.cpp:
(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::performTask):
* storage/StorageTask.h:
(WebCore::StorageTask::createDispatch):
* storage/StorageThread.cpp:
(WebCore::StorageThread::dispatch):
* storage/StorageThread.h:
(StorageThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r149114): cache flush for SH4 arch may flush an extra page.
commit-queue@webkit.org [Sat, 27 Apr 2013 18:25:19 +0000 (18:25 +0000)]
REGRESSION(r149114): cache flush for SH4 arch may flush an extra page.
https://bugs.webkit.org/show_bug.cgi?id=115305

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-27
Reviewed by Andreas Kling.

* assembler/SH4Assembler.h:
(JSC::SH4Assembler::cacheFlush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed Intel bots fix after r149231.
rakuco@webkit.org [Sat, 27 Apr 2013 18:18:43 +0000 (18:18 +0000)]
[EFL] Unreviewed Intel bots fix after r149231.

* efl/jhbuild.modules: Disable the libxml Python bindings since the
bots don't have Python's development files installed. libxml should
detect this kind of thing better.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r147261): Audio controls background not displayed after loading audio...
jer.noble@apple.com [Sat, 27 Apr 2013 17:08:17 +0000 (17:08 +0000)]
REGRESSION (r147261): Audio controls background not displayed after loading audio file
https://bugs.webkit.org/show_bug.cgi?id=115221

Reviewed by Darin Adler.

As in r147261, set a flex-shrink: 0 to avoid shrinking the media controls panel
below the specified height.

No new tests; fixes the media/media-document-audio-repaint.html test.

* css/mediaControlsQuickTime.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/JavaScriptCore: Re-landing <http://trac.webkit.org/changeset/148999>
ggaren@apple.com [Sat, 27 Apr 2013 06:43:33 +0000 (06:43 +0000)]
Source/JavaScriptCore: Re-landing <trac.webkit.org/changeset/148999>

    Filled out more cases of branch folding in bytecode when emitting
    expressions into a branching context
    https://bugs.webkit.org/show_bug.cgi?id=115057

    Reviewed by Phil Pizlo.

We can't fold the number == 1 case to boolean because all non-zero numbers
down-cast to true, but only 1 is == to true.

Source/WTF: Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Filip Pizlo.

Added a helper constructor for TriState so clients can make one without
branching or making assumptions about the integer values of TriStates.

* wtf/TriState.h:
(WTF::triState):
(WTF):

LayoutTests: Re-landing <http://trac.webkit.org/changeset/148999>

    Filled out more cases of branch folding in bytecode when emitting
    expressions into a branching context
    https://bugs.webkit.org/show_bug.cgi?id=115057

    Reviewed by Phil Pizlo.

Added a more exhaustive correctness test.

* fast/js/branch-fold-correctness-expected.txt: Added.
* fast/js/branch-fold-correctness.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCorrect indentation of SymbolTable.h
fpizlo@apple.com [Sat, 27 Apr 2013 06:28:59 +0000 (06:28 +0000)]
Correct indentation of SymbolTable.h

Rubber stamped by Mark Hahnenberg.

* runtime/SymbolTable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVideo playback has corruption on the edges of the video
jer.noble@apple.com [Sat, 27 Apr 2013 05:30:40 +0000 (05:30 +0000)]
Video playback has corruption on the edges of the video
https://bugs.webkit.org/show_bug.cgi?id=115216

Reviewed by Simon Fraser.

Source/WebCore:

Test: media/video-poster-background.html

RenderImage correctly answers foregroundIsKnownToBeOpaqueInRect() method
when a poster image is displayed, but once the video begins playing and
the poster image is no longer displayed, RenderImage will continue to
answer 'true' even when the video does not occupy the entire render box.
Override foregroundIsKnownToBeOpaqueInRect() in order to more correctly
answer the question for the video layer.

* rendering/RenderImage.h: Make foregroundIsKnownToBeOpaqueInRect() protected
    (vs. private).
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::foregroundIsKnownToBeOpaqueInRect): Added. Return
    true if the rect parameter is entirely contained by the video box.
* rendering/RenderVideo.h:

LayoutTests:

* media/content/test.jpg: Added.
* media/video-poster-background-expected.html: Added.
* media/video-poster-background.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Build break using jhbuild on ubuntu 13.04
ryuan.choi@samsung.com [Sat, 27 Apr 2013 04:41:12 +0000 (04:41 +0000)]
[EFL] Build break using jhbuild on ubuntu 13.04
https://bugs.webkit.org/show_bug.cgi?id=115225

Reviewed by Gyuyoung Kim.

libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
libxml 2.9.0 has a bug to make regression which r138422 mentioned.
So this patch bumped libxml version to 2.9.1.

* efl/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Build break after r149212
commit-queue@webkit.org [Sat, 27 Apr 2013 01:31:16 +0000 (01:31 +0000)]
[WK2][EFL] Build break after r149212
https://bugs.webkit.org/show_bug.cgi?id=115294

Patch by Yael Aharon <yael.aharon@intel.com> on 2013-04-26
Reviewed by Simon Fraser.
r144672 bumped up the revision of WKContextClient API, and introduced a version array
APIClientTraits<WKContextClient>::interfaceSizesByVersion .
In r149212, the version was bumped back down and the version array was emptied but not removed.
This causes a warning "array subscript is below array bounds", and in EFL the warning is
treated as error.

* Shared/APIClientTraits.cpp:
(WebKit):
* Shared/APIClientTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Skipping some more tests that still need rebaselining after disabling...
roger_fong@apple.com [Sat, 27 Apr 2013 00:51:26 +0000 (00:51 +0000)]
Unreviewed. Skipping some more tests that still need rebaselining after disabling subpixel layout on mac.
http://bugs.webkit.org/show_bug.cgi?id=115292

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodelete-stale-build-files does not clear .d files
jpfau@apple.com [Sat, 27 Apr 2013 00:51:12 +0000 (00:51 +0000)]
delete-stale-build-files does not clear .d files
http://bugs.webkit.org/show_bug.cgi?id=115293

Reviewed by Ryosuke Niwa.

* BuildSlaveSupport/delete-stale-build-files:
(main): Add .d to the file type list

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable sub-pixel-layout on Apple Windows port, VS2005 edition.
roger_fong@apple.com [Sat, 27 Apr 2013 00:38:30 +0000 (00:38 +0000)]
Disable sub-pixel-layout on Apple Windows port, VS2005 edition.

* win/tools/vsprops/FeatureDefines.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] ExclusionShape bounding box methods should return LayoutRects
hmuller@adobe.com [Sat, 27 Apr 2013 00:35:41 +0000 (00:35 +0000)]
[CSS Exclusions] ExclusionShape bounding box methods should return LayoutRects
https://bugs.webkit.org/show_bug.cgi?id=115117

Reviewed by Dirk Schulze.

Redefined the ExclusionShape API in terms of LayoutUnits, instead of floats: all of the
ExclusionShape methods now have LayoutUnit parameters and return LayoutUnit values.
This is more natural, since the callers work exclusively in LayoutUnits.

This is strictly a refactoring, no new tests were needed.

* rendering/ExclusionPolygon.cpp:
(WebCore::ExclusionPolygon::getExcludedIntervals):
(WebCore::ExclusionPolygon::getIncludedIntervals):
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop):
* rendering/ExclusionPolygon.h:
* rendering/ExclusionRectangle.cpp:
(WebCore::ExclusionRectangle::getExcludedIntervals):
(WebCore::ExclusionRectangle::getIncludedIntervals):
(WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop):
* rendering/ExclusionRectangle.h:
* rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape):
* rendering/ExclusionShape.h:
(LineSegment):
(ExclusionShape):
* rendering/ExclusionShapeInfo.cpp:
(WebCore):
(WebCore::::computedShape):
* rendering/ExclusionShapeInfo.h:
(WebCore):
(WebCore::ExclusionShapeInfo::shapeLogicalTop):
(WebCore::ExclusionShapeInfo::shapeLogicalBottom):
(ExclusionShapeInfo):
* rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop):
* rendering/ExclusionShapeInsideInfo.h:
* rendering/ExclusionShapeOutsideInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNil-check the results of -[AVPlayerItemVideoOutput copyPixelBufferForItemTime:itemTim...
jer.noble@apple.com [Sat, 27 Apr 2013 00:17:53 +0000 (00:17 +0000)]
Nil-check the results of -[AVPlayerItemVideoOutput copyPixelBufferForItemTime:itemTimeForDisplay:].
https://bugs.webkit.org/show_bug.cgi?id=115265

Reviewed by Eric Carlson.

copyPixelBufferForItemTime:itemTimeForDisplay: can return nil, even
when hasNewPixelBufferForItemTime: returns YES. Check the results
before passing the buffer on to VTPixelTransferSessionTransferImage()
which does not NULL-check its parameters.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Skipping some tests that still need rebaselining after disabling subpixel...
roger_fong@apple.com [Sat, 27 Apr 2013 00:09:55 +0000 (00:09 +0000)]
Unreviewed. Skipping some tests that still need rebaselining after disabling subpixel layout on mac.
http://bugs.webkit.org/show_bug.cgi?id=115292

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUninflate caret rect.
roger_fong@apple.com [Fri, 26 Apr 2013 23:45:41 +0000 (23:45 +0000)]
Uninflate caret rect.
http://bugs.webkit.org/show_bug.cgi?id=114997.
<rdar://problem/12629007>.

Reviewed by Timothy Horton.

Inflation was causing painting errors with focus rings.
It is no longer needed after disabling subpixel layout.

* editing/FrameSelection.cpp:
(WebCore::repaintCaretForLocalRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. More rebaselines for mac after disabling sub-pixel layout.
roger_fong@apple.com [Fri, 26 Apr 2013 23:40:43 +0000 (23:40 +0000)]
Unreviewed. More rebaselines for mac after disabling sub-pixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable sub-pixel-layout on Apple Windows port.
roger_fong@apple.com [Fri, 26 Apr 2013 23:40:34 +0000 (23:40 +0000)]
Disable sub-pixel-layout on Apple Windows port.

* win/tools/vsprops/FeatureDefines.props:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake Apple Windows VS2010 build results into and get dependencies from __32 suffixed...
roger_fong@apple.com [Fri, 26 Apr 2013 23:17:15 +0000 (23:17 +0000)]
Make Apple Windows VS2010 build results into and get dependencies from __32 suffixed folders.
Make the DebugSuffix configuration use _debug dependencies.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add methods to add a user style sheet to the WebKit2 GTK+ API
mrobinson@webkit.org [Fri, 26 Apr 2013 23:06:10 +0000 (23:06 +0000)]
[GTK] Add methods to add a user style sheet to the WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=99081

Reviewed by Carlos Garcia Campos, Gustavo Noronha Silva, and Benjamin Poulain.

Add methods to WebKitWebViewGroup to add and remove user style sheets.
This allows clients to inject style sheets into pages with a set of
rules for when those style sheets apply.

* UIProcess/API/gtk/WebKitWebViewGroup.cpp:
(toImmutableArray): Added this helper which converts the GList* parameters into
ImmutableArrays for use with the WebKit2 internal API.
(webkit_web_view_group_add_user_style_sheet): Added new API for adding a style sheet.
(webkit_web_view_group_remove_all_user_style_sheets): Add new API for clearing out all style sheets.
* UIProcess/API/gtk/WebKitWebViewGroup.h: Added new method declarations.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new API to the documentation.
* UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp: Added a test for the new API.
(isStyleSheetInjectedForURLAtPath): Function to check whether the style sheet has been injected for a given URL.
(fillURLListFromPaths): Helper which converts paths passed via varargs into a whitelist or blacklist.
(removeOldInjectedStyleSheetsAndResetLists): Function to start afresh.
(testWebViewGroupInjectedStyleSheet): The actual test.
(serverCallback): Server callback for use with the test. We cannot use loadHTML or
loadAlternateHTML, because that checks the whitelist and blacklist against about:blank.
(beforeAll): Initialize the server and new test.
(afterAll): Clean up the server.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix.
roger_fong@apple.com [Fri, 26 Apr 2013 22:29:00 +0000 (22:29 +0000)]
Unreviewed build fix.

* platform/LayoutUnit.h:
(WebCore::LayoutUnit::LayoutUnit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2013-04-26 Simon Cooper <scooper@apple.com>
ap@apple.com [Fri, 26 Apr 2013 22:22:53 +0000 (22:22 +0000)]
2013-04-26  Simon Cooper  <scooper@apple.com>

        Permit ~/Library or ~/Library/Preferences to be symlinks
        https://bugs.webkit.org/show_bug.cgi?id=115142
        <rdar://problem/12953603>

        Reviewed by Alexey Proskuryakov.

        Pass in two new parameters which are the resolved paths to ~/Library
        and ~/Library/Preferences. Added new expansion functions and
        substituted the new functions for home-regex, home-subpath and
        home-literal for places referencing resources in "~/Library" or
        "~/Library/Preferences".

        * Resources/PlugInSandboxProfiles/com.apple.QuickTime Plugin.plugin.sb:
        * Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
        * Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:
        * Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
        * Resources/PlugInSandboxProfiles/com.microsoft.SilverlightPlugin.sb:
        * Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb:
        * Shared/mac/ChildProcessMac.mm:
        (WebKit::ChildProcess::initializeSandbox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebCore ObjC bridge is missing support for bool type
msaboff@apple.com [Fri, 26 Apr 2013 22:20:51 +0000 (22:20 +0000)]
WebCore ObjC bridge is missing support for bool type
https://bugs.webkit.org/show_bug.cgi?id=115276

Reviewed by Geoffrey Garen.

Added code to handle conversion between ObjC and JS booleans.

* bridge/objc/objc_instance.mm:
(ObjcInstance::invokeObjcMethod):
* bridge/objc/objc_utility.h:
* bridge/objc/objc_utility.mm:
(JSC::Bindings::convertValueToObjcValue):
(JSC::Bindings::convertObjcValueToValue):
(JSC::Bindings::objcValueTypeForType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] WKContextClient doesn't need to be versioned yet
ap@apple.com [Fri, 26 Apr 2013 21:54:22 +0000 (21:54 +0000)]
    [WK2] WKContextClient doesn't need to be versioned yet
        https://bugs.webkit.org/show_bug.cgi?id=115279

        Reviewed by Anders Carlsson.

        * Shared/APIClientTraits.cpp:
        * Shared/APIClientTraits.h:
        * UIProcess/API/C/WKContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDownloads need to be converted from the NSURLConnection, not canceled and restarted...
andersca@apple.com [Fri, 26 Apr 2013 21:39:27 +0000 (21:39 +0000)]
Downloads need to be converted from the NSURLConnection, not canceled and restarted, when using the NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=115277
<rdar://problem/12890184>

Reviewed by Sam Weinig.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
Ask the download manager to convert the main resource load to a download.

* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
Add new message.

* NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::handle):
Add getter.

* Shared/Downloads/mac/DownloadMac.mm:
(dispatchOnMainThread):
Helper function that ensures that a given block is called on the main thread.

(-[WKDownloadAsDelegate downloadDidBegin:]):
(-[WKDownloadAsDelegate download:didReceiveAuthenticationChallenge:]):
(-[WKDownloadAsDelegate download:didReceiveResponse:]):
(-[WKDownloadAsDelegate download:didReceiveDataOfLength:]):
(-[WKDownloadAsDelegate download:shouldDecodeSourceDataOfMIMEType:]):
(-[WKDownloadAsDelegate download:decideDestinationWithSuggestedFilename:]):
(-[WKDownloadAsDelegate download:didCreateDestination:]):
(-[WKDownloadAsDelegate downloadDidFinish:]):
(-[WKDownloadAsDelegate download:didFailWithError:]):
Use dispatchOnMainThread.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
Remove code that cancels the current load and starts a new download.

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::convertMainResourceLoadToDownload):
Send the ConvertMainResourceLoadToDownload message to the network process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rebaseline a bunch of tests and run optimize-baselines after disabling...
roger_fong@apple.com [Fri, 26 Apr 2013 21:25:16 +0000 (21:25 +0000)]
Unreviewed. Rebaseline a bunch of tests and run optimize-baselines after disabling sub-pixel layout on mac.
https://bugs.webkit.org/show_bug.cgi?id=114999.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable sub-pixel layout on mac.
roger_fong@apple.com [Fri, 26 Apr 2013 21:19:43 +0000 (21:19 +0000)]
Disable sub-pixel layout on mac.
https://bugs.webkit.org/show_bug.cgi?id=114999.

Reviewed by Simon Fraser.

* Configurations/FeatureDefines.xcconfig:
* WebCore.exp.in:
Export symbol needed to be added for IntRect(const LayoutRect&) constructor,
which is now being used in pixelSnappedIntRect(const LayoutRect&) in LayoutRect.h after disabling sub-pixel layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInspector window is often blank when opened
simon.fraser@apple.com [Fri, 26 Apr 2013 21:13:22 +0000 (21:13 +0000)]
Inspector window is often blank when opened
https://bugs.webkit.org/show_bug.cgi?id=115220
<rdar://problem/13735496>

Reviewed by Tim Horton.

After disabling tiled scrolling and accelerated drawing in r149006, the
Inspector window was often missing its content after opening. This only
happened when the user has a preference on disk to use accelerated drawing
in the Inspector.

The missing content was caused by a failure to connect the correct contextID
for remote layer hosting. On window creation, we hook up a context using
WindowServer layer hosting (the default), but then switch back to app-hosted
layers for the Inspector window. This switching happens in didUpdateBackingStoreState(),
but that can be re-entered via its call to sendUpdateBackingStoreState(). In
that cause, on unwinding the stack it would call enterAcceleratedCompositingMode()
with a stale layerTreeContext.

Fix by moving the code that exits/enters accelerated compositing mode to before
the call to sendUpdateBackingStoreState() that can cause re-entrancy. That avoids
use of a possibly stale layerTreeContext.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayer-backed WebViews don't repaint content outside the visible area
simon.fraser@apple.com [Fri, 26 Apr 2013 21:13:19 +0000 (21:13 +0000)]
Layer-backed WebViews don't repaint content outside the visible area
https://bugs.webkit.org/show_bug.cgi?id=115275

Reviewed by Beth Dakin.

Source/WebCore:

Export ScrollView::setPaintsEntireContents(bool).

* WebCore.exp.in:

Source/WebKit/mac:

When a client of WebView makes the WebView be layer-backed, then
AppKit propagaes the layer-backing down to the WebHTMLView (but
no further).

In this situation, we had a bug where content that was not
in the visible content rect would not get repainted, because
WebCore clips repaints to the visible rect.

Fix by calling ScrollView::setPaintsEntireContents(bool) from
-[WebHTMLView setLayer:], saying that we need
to paint the entire contents if we have a layer.

* WebView/WebHTMLView.mm:
(-[WebHTMLView setLayer:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Check for valid element in elementTouched
commit-queue@webkit.org [Fri, 26 Apr 2013 20:34:12 +0000 (20:34 +0000)]
[BlackBerry] Check for valid element in elementTouched
https://bugs.webkit.org/show_bug.cgi?id=115205

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-04-26
Reviewed by Rob Buis.

Internally reviewed by Genevieve Mak.

PR 331546
We might receive a null ptr from nodeAsElementIfApplicable which
is passed in here. Check to make sure it's valid before using.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::elementTouched):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake stack tracing more robust
oliver@apple.com [Fri, 26 Apr 2013 20:12:04 +0000 (20:12 +0000)]
Make stack tracing more robust
https://bugs.webkit.org/show_bug.cgi?id=115272

Reviewed by Geoffrey Garen.

CallFrame already handles stack walking confusion robustly,
so we should make sure that the actual walk handles that as well.

* interpreter/Interpreter.cpp:
(JSC::getCallerInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Crashes under ResourceHandle::continueDidReceiveResponse when loading blobs
ap@apple.com [Fri, 26 Apr 2013 19:42:29 +0000 (19:42 +0000)]
    Crashes under ResourceHandle::continueDidReceiveResponse when loading blobs
        https://bugs.webkit.org/show_bug.cgi?id=115273

        Reviewed by Anders Carlsson.

        Covered by multiple existing tests (when using NetworkProcess), including:
        - http/tests/fileapi/blob-url-in-subframe.html
        - http/tests/fileapi/create-blob-url-from-data-url.html

        * NetworkProcess/NetworkResourceLoader.cpp:
        (WebKit::NetworkResourceLoader::continueDidReceiveResponse):
        Work around BlobResourceHandle badness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChange RenderMeter::valueRatio() visibility to public
commit-queue@webkit.org [Fri, 26 Apr 2013 19:09:56 +0000 (19:09 +0000)]
Change RenderMeter::valueRatio() visibility to public
https://bugs.webkit.org/show_bug.cgi?id=115266

This function is currently unused.
However, it is necessary to implement a RenderTheme capable of rendering Meter elements.

Patch by Daker Fernandes Pinheiro <daker.pinheiro@openbossa.org> on 2013-04-26
Reviewed by Alexis Menard.

No new tests, because no behaviour is changed.

* rendering/RenderMeter.h:
(RenderMeter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Runtime.parse to the Inspector protocol.
timothy@apple.com [Fri, 26 Apr 2013 19:08:33 +0000 (19:08 +0000)]
Add Runtime.parse to the Inspector protocol.

This will be used to parse console expressions for errors
before evaluating them fully.

https://webkit.org/b/115242

Reviewed by Oliver Hunt.

* ForwardingHeaders/parser/ParserError.h: Added.
* inspector/Inspector.json:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::parse):
* inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the copyright years after r149057
benjamin@webkit.org [Fri, 26 Apr 2013 19:04:58 +0000 (19:04 +0000)]
Fix the copyright years after r149057

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-26

* page/DiagnosticLoggingKeys.cpp: I accidentally removed a year from
the copyright in r149057.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Crash due to null items from getDOMStorageItems
commit-queue@webkit.org [Fri, 26 Apr 2013 18:57:35 +0000 (18:57 +0000)]
Web Inspector: Crash due to null items from getDOMStorageItems
https://bugs.webkit.org/show_bug.cgi?id=115176

Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-04-26
Reviewed by Joseph Pecoraro.

Source/WebCore:

findStorageArea was returning a null storageArea causing the items
input paramater to not be set.  This was happening without any error
being set at all.  Set an error to prevent a crash when we try to
convert the result to a JSON string.

Added tests to check if session and local storage are empty that
they are still functional.

* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):

LayoutTests:

Tests to check that if local and session storage are empty
that they still work corerctly.

* inspector/storage-panel-dom-storage-empty-expected.txt: Added.
* inspector/storage-panel-dom-storage-empty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Remove NetworkResourceLoader::cleanupOnMainThread
ap@apple.com [Fri, 26 Apr 2013 18:40:29 +0000 (18:40 +0000)]
    [WK2] Remove NetworkResourceLoader::cleanupOnMainThread
        https://bugs.webkit.org/show_bug.cgi?id=115268

        Reviewed by Brady Eidson.

        All cleanup() callers are now on main thread, and this indirection only complicates debugging.

        * NetworkProcess/NetworkResourceLoader.cpp:
        (WebKit::NetworkResourceLoader::connectionToWebProcessDidClose):
        (WebKit::NetworkResourceLoader::abortInProgressLoad):
        (WebKit::NetworkResourceLoader::didFinishLoading):
        (WebKit::NetworkResourceLoader::didFail):
        * NetworkProcess/NetworkResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebKit2] CustomProtocolManager's m_registeredSchemes HashSet can be accessed by...
aestes@apple.com [Fri, 26 Apr 2013 18:24:08 +0000 (18:24 +0000)]
[WebKit2] CustomProtocolManager's m_registeredSchemes HashSet can be accessed by multiple threads
https://bugs.webkit.org/show_bug.cgi?id=115267

Reviewed by Alexey Proskuryakov.

* Shared/Network/CustomProtocols/CustomProtocolManager.h: Added a Mutex to protect m_registeredSchemes.
* Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::registerScheme): Acquired the mutex before accessing m_registeredSchemes.
(WebKit::CustomProtocolManager::unregisterScheme): Ditto.
(WebKit::CustomProtocolManager::supportsScheme): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] media/track/track-mode.html sometimes trigger InvalidStateError
eric.carlson@apple.com [Fri, 26 Apr 2013 18:10:38 +0000 (18:10 +0000)]
[Mac] media/track/track-mode.html sometimes trigger InvalidStateError
https://bugs.webkit.org/show_bug.cgi?id=115045

Reviewed by Alexey Proskuryakov.

* media/track/track-mode.html: Don't assume that the video element is ready for seeking
    after a 100ms timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Blobs are not associated with connection when there are no sandbox extensions
ap@apple.com [Fri, 26 Apr 2013 17:51:13 +0000 (17:51 +0000)]
    Blobs are not associated with connection when there are no sandbox extensions
        https://bugs.webkit.org/show_bug.cgi?id=115264

        Reviewed by Brady Eidson.

        Covered by multiple fast/files tests when using NetworkProcess.

        * NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
        (WebKit::NetworkBlobRegistry::registerBlobURL): Fixed a logic error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Clean up the TestWebKitAPI GNUmakefile.am
zandobersek@gmail.com [Fri, 26 Apr 2013 17:41:17 +0000 (17:41 +0000)]
[GTK] Clean up the TestWebKitAPI GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=115233

Reviewed by Martin Robinson.

Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.

* TestWebKitAPI/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
aestes@apple.com [Fri, 26 Apr 2013 16:55:12 +0000 (16:55 +0000)]
[WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
https://bugs.webkit.org/show_bug.cgi?id=115223

Reviewed by Darin Adler.

Source/WebKit2:

When WebKit performs a synchronous load on the Mac, it spins a nested
run loop in a mode that only accepts input from the NSURLConnection
performing the load. When the load is for a custom protocol in WebKit2,
we proxy it to the UI process via CoreIPC messages, but the response
messages from the UI process are never processed as long as the run
loop is in a non-common mode (and we wouldn't want to process messages
that could re-enter WebCore in the middle of loading, anyway). Since
these messages never make it back to the NSURLConnection handling the
request, the connection eventually times out.

Fix this by using a work queue to handle custom protocol messages in
the networking process. The work queue can process incoming custom
protocol messages while the main thread is blocked.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeConnection): Called
initializeConnection() on all the NetworkProcess's supplements.
* Shared/ChildProcessSupplement.h: Added a base class for
NetworkProcessSupplement and WebProcessSupplement which defines
initializeConnection and provides an empty default implementation.
(WebKit::ChildProcessSupplement::~ChildProcessSupplement):
(WebKit::ChildProcessSupplement::initializeConnection):
* Shared/Network/CustomProtocols/CustomProtocolManager.h:
* Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::CustomProtocolManager): Instantiated a
work queue for message processing.
(WebKit::CustomProtocolManager::initializeConnection): Added the work
queue as a message receiver on the CoreIPC connection.
(WebKit::CustomProtocolManager::initialize): If we're in the web
process and the network process is being used, unregister and destroy
the work queue we previously created. It'd be better to not create it
in the first place, but we have to register our work queue with the
CoreIPC connection before it is established, which is before the UI
process has told us whether the network process is in use.
* Shared/Network/NetworkProcessSupplement.h: Inherited from
ChildProcessSupplement.
* WebKit2.xcodeproj/project.pbxproj: Added ChildProcessSupplement.h.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection): Called
initializeConnection() on all the WebProcess's supplements.
* WebProcess/WebProcessSupplement.h: Inherited from
ChildProcessSupplement.

Tools:

Added an API test.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
* TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.
(TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
when it loads a request with a custom protocol.
* TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the
NSURLProtocol subclass to TestProtocol.{h, mm} and did some
miscellaneous cleanup.
* TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
* TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.
(+[TestProtocol canInitWithRequest:]):
(+[TestProtocol canonicalRequestForRequest:]):
(+[TestProtocol requestIsCacheEquivalent:toRequest:]):
(+[TestProtocol scheme]):
(-[TestProtocol startLoading]):
(-[TestProtocol stopLoading]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the remaining Skia #ifdefs
mrobinson@webkit.org [Fri, 26 Apr 2013 16:24:37 +0000 (16:24 +0000)]
Remove the remaining Skia #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=114886

Reviewed by Benjamin Poulain.

Source/WebCore:

* html/HTMLCanvasElement.cpp: Remove Skia #ifdef references.
* platform/graphics/BitmapImage.cpp: Ditto.
* platform/graphics/FloatPoint.h: Ditto.
* platform/graphics/FloatRect.h: Ditto.
* platform/graphics/FontCache.h: Ditto.
* platform/graphics/Gradient.cpp: Ditto.
* platform/graphics/Gradient.h: Ditto.
* platform/graphics/GraphicsContext.cpp: Ditto.
* platform/graphics/GraphicsContext.h: Ditto.
* platform/graphics/GraphicsContext3D.h: Ditto.
* platform/graphics/ImageBuffer.cpp: Ditto.
* platform/graphics/ImageBuffer.h: Ditto.
* platform/graphics/ImageBufferData.h: Ditto.
* platform/graphics/IntPoint.h: Ditto.
* platform/graphics/IntRect.h: Ditto.
* platform/graphics/NativeImagePtr.h: Ditto.
* platform/graphics/Path.h: Ditto.
* platform/graphics/Pattern.cpp: Ditto.
* platform/graphics/Pattern.h: Ditto.
* platform/graphics/filters/FEBlend.h: Ditto.
* platform/graphics/filters/FEColorMatrix.h: Ditto.
* platform/graphics/filters/FEComponentTransfer.h: Ditto.
* platform/graphics/filters/FEComposite.h: Ditto.
* platform/graphics/filters/FEConvolveMatrix.h: Ditto.
* platform/graphics/filters/FEDisplacementMap.h: Ditto.
* platform/graphics/filters/FEGaussianBlur.h: Ditto.
* platform/graphics/filters/FELighting.h: Ditto.
* platform/graphics/filters/FEMorphology.h: Ditto.
* platform/graphics/filters/FEOffset.h: Ditto.
* platform/graphics/filters/FilterEffect.cpp: Ditto.
* platform/graphics/filters/FilterEffect.h: Ditto.
* platform/graphics/transforms/AffineTransform.h: Ditto.
* platform/graphics/transforms/TransformationMatrix.h: Ditto.
* platform/image-decoders/ImageDecoder.cpp: Ditto.
* platform/image-decoders/ImageDecoder.h: Ditto.
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Ditto.
* platform/image-decoders/webp/WEBPImageDecoder.cpp: Ditto.
* platform/mac/LocalCurrentGraphicsContext.h: Ditto.
* platform/mac/LocalCurrentGraphicsContext.mm: Ditto.
* rendering/svg/RenderSVGResourceSolidColor.cpp: Ditto.
* svg/graphics/SVGImage.cpp: Ditto.
* svg/graphics/SVGImage.h: Ditto.

Source/WebKit/blackberry:

* Api/WebPage.cpp: Remove Skia #ifdef references.
* WebCoreSupport/AboutDataUseFeatures.in: Ditto.

Source/WTF:

* wtf/Platform.h:

Tools:

* DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
(createBitmapContextFromWebView): Remove Skia #ifdef references.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Compilation of ProcessLauncherGtk.cpp fails due to unresolved symbols
commit-queue@webkit.org [Fri, 26 Apr 2013 16:16:04 +0000 (16:16 +0000)]
[GTK] Compilation of ProcessLauncherGtk.cpp fails due to unresolved symbols
https://bugs.webkit.org/show_bug.cgi?id=115240

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-04-26
Reviewed by Martin Robinson.

* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: Includes sys/socket.h if OS is Linux

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSort jsc-test-list
ddkilzer@apple.com [Fri, 26 Apr 2013 16:15:12 +0000 (16:15 +0000)]
Sort jsc-test-list

$ sort -f -o LayoutTests/fast/js/jsc-test-list LayoutTests/fast/js/jsc-test-list

* fast/js/jsc-test-list: Sort case-insensitively.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpstream iOS changes to jsc-test-list
ddkilzer@apple.com [Fri, 26 Apr 2013 16:15:10 +0000 (16:15 +0000)]
Upstream iOS changes to jsc-test-list

Reviewed by Michael Saboff.

* fast/js/jsc-test-list: Add tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skip two failing tests.
kadam@inf.u-szeged.hu [Fri, 26 Apr 2013 16:12:44 +0000 (16:12 +0000)]
[Qt] Unreviewed gardening. Skip two failing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@149189 268f45cc-cd09-0410-ab3c-d52691b4dbfc