WebKit-https.git
8 years agoFixing windows build
mhahnenberg@apple.com [Thu, 27 Oct 2011 17:55:26 +0000 (17:55 +0000)]
Fixing windows build

Unreviewed build fix

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, fixing duplicate entries in test expectations.
johnnyg@google.com [Thu, 27 Oct 2011 17:42:39 +0000 (17:42 +0000)]
Unreviewed, fixing duplicate entries in test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd ability to check for presence of static members at compile time
mhahnenberg@apple.com [Thu, 27 Oct 2011 17:38:19 +0000 (17:38 +0000)]
Add ability to check for presence of static members at compile time
https://bugs.webkit.org/show_bug.cgi?id=70986

Reviewed by Geoffrey Garen.

Added new CREATE_MEMBER_CHECKER macro to instantiate the template and the
HAS_MEMBER_NAMED macro to use that template to check if the specified class
does indeed have a method with that name.  This mechanism is not currently
used anywhere, but will be in the future when adding virtual methods from
JSObject to the MethodTable.

* runtime/ClassInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSSRegions]Flag regions with custom styling
mihnea@adobe.com [Thu, 27 Oct 2011 17:33:07 +0000 (17:33 +0000)]
[CSSRegions]Flag regions with custom styling
https://bugs.webkit.org/show_bug.cgi?id=70733

Reviewed by David Hyatt.

Region elements that have custom region styling are now marked accordingly.

Source/WebCore:

Test: fast/regions/render-region-custom-style-mark.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::checkRegionStyle):
* css/CSSStyleSelector.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::styleDidChange):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::hasCustomRegionStyle):
(WebCore::RenderRegion::setHasCustomRegionStyle):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderFlowThreads):

LayoutTests:

* fast/regions/render-region-custom-style-mark.html: Added.
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/fast/regions/render-region-custom-style-mark-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Cairo] Implement ShareableBitmap::paint() when scaleFactor=1
carlosgc@webkit.org [Thu, 27 Oct 2011 17:27:15 +0000 (17:27 +0000)]
[Cairo] Implement ShareableBitmap::paint() when scaleFactor=1
https://bugs.webkit.org/show_bug.cgi?id=71027

Reviewed by Martin Robinson.

Fixes windowless plugins in GTK+ port.

* Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::paint): When scaleFactor is 1, simply
call the paint method that doesn't receive a scaleFactor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r98556.
commit-queue@webkit.org [Thu, 27 Oct 2011 17:24:49 +0000 (17:24 +0000)]
Unreviewed, rolling out r98556.
http://trac.webkit.org/changeset/98556
https://bugs.webkit.org/show_bug.cgi?id=71031

The test added by the patch doesn't pass on Snow Leopard
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-27

.:

* Source/autotools/symbols.filter:

Source/WebCore:

* editing/TextCheckingHelper.cpp:
(WebCore::checkTextOfParagraph):
* testing/Internals.cpp:
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* editing/spelling/spelling-unified-emulation-expected.txt: Removed.
* editing/spelling/spelling-unified-emulation.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTemporarily skip tables/mozilla_expected_failures/bugs/bug14007-2.html on all platforms
rniwa@webkit.org [Thu, 27 Oct 2011 17:22:18 +0000 (17:22 +0000)]
Temporarily skip tables/mozilla_expected_failures/bugs/bug14007-2.html on all platforms
since r98542 regressed it. The failure is tracked by the bug 71032.

* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[skia] replace offscreen technique with native support for antialiased clipping
reed@google.com [Thu, 27 Oct 2011 17:19:28 +0000 (17:19 +0000)]
[skia] replace offscreen technique with native support for antialiased clipping
https://bugs.webkit.org/show_bug.cgi?id=70748

Reviewed by Stephen White.

~100 layout tests need to be rebaselined, as the native aa-clipping differs sometimes in the low
bits of the result. Other than that, the results should be the same, except that now the drawing
can go directly to the canvas, rather than being direct offscreen and then have that result
"clipped" during the restore. This has the effect of allowing LCD text to be drawing inside a
antialiased clip area.

Source/WebCore:

* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::cloneInheritedProperties):
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::restore):
* platform/graphics/skia/PlatformContextSkia.h:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed. Add pixel baselines for table tests.
leandro@webkit.org [Thu, 27 Oct 2011 17:17:39 +0000 (17:17 +0000)]
[EFL] Unreviewed. Add pixel baselines for table tests.

* platform/efl/tables: [...]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agouse main/cross instead of logical width/height when talking about flow direction
tony@chromium.org [Thu, 27 Oct 2011 17:04:03 +0000 (17:04 +0000)]
use main/cross instead of logical width/height when talking about flow direction
https://bugs.webkit.org/show_bug.cgi?id=70977

Reviewed by Ojan Vafai.

Flexbox code uses logical in function names to refer to the flow
direction. This is confusing because writing mode also uses logical,
but this is a diffent usage. To avoid confusion, be explicit about
main vs cross axis. Extent is used instead of width/height.

No new tests, just a refactoring.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisLengthForChild):
(WebCore::RenderFlexibleBox::crossAxisLength):
(WebCore::RenderFlexibleBox::setCrossExtent):
(WebCore::RenderFlexibleBox::crossExtentForChild):
(WebCore::RenderFlexibleBox::mainExtentForChild):
(WebCore::RenderFlexibleBox::crossAxisExtent):
(WebCore::RenderFlexibleBox::mainAxisExtent):
(WebCore::RenderFlexibleBox::crossAxisContentExtent):
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
(WebCore::RenderFlexibleBox::crossAxisBorderAndPaddingExtent):
(WebCore::RenderFlexibleBox::crossAxisMarginExtentForChild):
(WebCore::RenderFlexibleBox::flowAwareLocationForChild):
(WebCore::RenderFlexibleBox::setFlowAwareLocationForChild):
(WebCore::RenderFlexibleBox::mainAxisBorderAndPaddingExtentForChild):
(WebCore::RenderFlexibleBox::mainAxisScrollbarExtentForChild):
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::positiveFlexForChild): Since flex only
    matters in the main axis, there's no reason to deambiguate it here.
(WebCore::RenderFlexibleBox::negativeFlexForChild): Ditto.
(WebCore::RenderFlexibleBox::availableAlignmentSpaceForChild): Alignment is always
    in the cross axis direction, so don't include that in the method name.
(WebCore::RenderFlexibleBox::marginBoxAscent):
(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
(WebCore::RenderFlexibleBox::adjustAlignmentForChild):  Alignment is always
    in the cross axis direction, so don't include that in the method name.
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):
* rendering/RenderFlexibleBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDe-virtualize JSCell::toThisObject
mhahnenberg@apple.com [Thu, 27 Oct 2011 17:01:38 +0000 (17:01 +0000)]
De-virtualize JSCell::toThisObject
https://bugs.webkit.org/show_bug.cgi?id=70958

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.

* API/JSContextRef.cpp:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/ClassInfo.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::toThisObject):
* runtime/JSActivation.h:
* runtime/JSCell.cpp:
(JSC::JSCell::toThisObject):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::toThisObject):
* runtime/JSObject.h:
(JSC::JSValue::toThisObject):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::toThisObject):
* runtime/JSStaticScopeObject.h:
* runtime/JSString.cpp:
(JSC::JSString::toThisObject):
* runtime/JSString.h:
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::toThisObject):
* runtime/StrictEvalActivation.h:

Source/WebCore:

No new tests.

Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::toThisObject):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
* bridge/NP_jsobject.cpp:
(_NPN_Invoke):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeConnectionMethod::call):

Source/WebKit/mac:

Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):

Source/WebKit2:

Converted all instances of toThisObject to static functions,
added toThisObject to the MethodTable, and replaced all call sites
with a corresponding lookup in the MethodTable.

* WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::invoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build fix after r98512
aroben@apple.com [Thu, 27 Oct 2011 16:41:50 +0000 (16:41 +0000)]
Windows build fix after r98512

* html/HTMLMediaElement.cpp: Moved a Web Audio-related #include inside an appropriate ENABLE
guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegenerate WebCore's Localizable.strings file
aroben@apple.com [Thu, 27 Oct 2011 16:32:00 +0000 (16:32 +0000)]
Regenerate WebCore's Localizable.strings file

All I did was run update-webkit-localizable-strings. A few localizer comments changed, and
some strings (which must have been hand-added) got moved to a different part of the file.

* English.lproj/Localizable.strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd WKBundlePageGetBackingScaleFactor
aroben@apple.com [Thu, 27 Oct 2011 16:24:41 +0000 (16:24 +0000)]
Add WKBundlePageGetBackingScaleFactor

Fixes <http://webkit.org/b/71025> <rdar://problem/10355037> REGRESSION (r97191): Clients
can't reliably determine the scale factor of snapshots returned via
WKBundlePageCreateSnapshot* API

Reviewed by Sam Weinig.

Source/WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetBackingScaleFactor):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Added. Calls through to WebPage::deviceScaleFactor.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::deviceScaleFactor):
* WebProcess/WebPage/WebPage.h:
Added. Calls through to Page::deviceScaleFactor.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.

* TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
(TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
(TestWebKitAPI::createWindow): Conjure up a window.
(TestWebKitAPI::TEST): Ask the injected bundle code to call the new
WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
factors and when using a custom scale factor, and check that we get those same scale factors
back.

* TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.
(TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
members.
(TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
(TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
from the page using the new API and send it back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline.
philn@webkit.org [Thu, 27 Oct 2011 16:18:11 +0000 (16:18 +0000)]
Unreviewed, GTK rebaseline.

* platform/gtk/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, skipping 2 new failing tests in GTK.
philn@webkit.org [Thu, 27 Oct 2011 16:00:29 +0000 (16:00 +0000)]
Unreviewed, skipping 2 new failing tests in GTK.

* platform/gtk/Skipped: Skip
fast/canvas/canvas-composite-image.html and editing/spelling/spelling-unified-emulation.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 27 Oct 2011 15:41:55 +0000 (15:41 +0000)]
2011-10-27  Yury Semikhatsky  <yurys@chromium.org>

        Rebaseline tables/mozilla_expected_failures/bugs/bug14007-2.html after r98542.

        * platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
        * platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
        * platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
        * platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Removed.
        * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
        * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
        * platform/chromium/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMicrodata: Add test cases for itemscope attribute.
commit-queue@webkit.org [Thu, 27 Oct 2011 15:24:44 +0000 (15:24 +0000)]
Microdata: Add test cases for itemscope attribute.
https://bugs.webkit.org/show_bug.cgi?id=71014

Patch by Arko Saha <arko@motorola.com> on 2011-10-27
Reviewed by Ryosuke Niwa.

* fast/dom/MicroData/itemscope-attribute-test-expected.txt: Added.
* fast/dom/MicroData/itemscope-attribute-test.html: Added.
* fast/dom/MicroData/itemscope-must-be-read-write-expected.txt: Added.
* fast/dom/MicroData/itemscope-must-be-read-write.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2]Add setViewportSize API to WebKit2.
commit-queue@webkit.org [Thu, 27 Oct 2011 15:19:22 +0000 (15:19 +0000)]
[Qt][WK2]Add setViewportSize API to WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=71006

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-27
Reviewed by Kenneth Rohde Christiansen.

Fixed layout rendering needs the viewport size information on the WebProcess
side to be able to do viewport attribute calculations.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setViewportSize):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::viewportSize):
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up MicroDataItemValue to use const String& instead of String
dcheng@chromium.org [Thu, 27 Oct 2011 15:14:55 +0000 (15:14 +0000)]
Clean up MicroDataItemValue to use const String& instead of String
https://bugs.webkit.org/show_bug.cgi?id=70978

Reviewed by Tony Chang.

* html/MicroDataItemValue.cpp:
(WebCore::MicroDataItemValue::MicroDataItemValue):
* html/MicroDataItemValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 27 Oct 2011 15:12:04 +0000 (15:12 +0000)]
2011-10-27  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed, gardening.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMiniBrowser crashes when started with 0 arguments
kbalazs@webkit.org [Thu, 27 Oct 2011 15:09:10 +0000 (15:09 +0000)]
MiniBrowser crashes when started with 0 arguments

Rubber-stamped by Simon Hausmann.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::handleUserOptions):
Fix typo error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WebSocket] update pywebsocket to 0.7.
commit-queue@webkit.org [Thu, 27 Oct 2011 15:06:18 +0000 (15:06 +0000)]
[WebSocket] update pywebsocket to 0.7.
https://bugs.webkit.org/show_bug.cgi?id=70992

Patch by Takashi Toyoshima <toyoshim@chromium.org> on 2011-10-27
Reviewed by Kent Tamura.

pywebsocket 0.7 fixed the bug on dual stack support on OS X.

* Scripts/webkitpy/thirdparty/__init__.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a small bug in callOperation after r98431
commit-queue@webkit.org [Thu, 27 Oct 2011 15:05:47 +0000 (15:05 +0000)]
Fix a small bug in callOperation after r98431
https://bugs.webkit.org/show_bug.cgi?id=70984

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-27
Reviewed by Geoffrey Garen.

TrustedImmPtr is not expecting "int" type parameters.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse StringHasher to generate the matched declaration cache hash
antti@apple.com [Thu, 27 Oct 2011 15:03:48 +0000 (15:03 +0000)]
Use StringHasher to generate the matched declaration cache hash
https://bugs.webkit.org/show_bug.cgi?id=71012

Reviewed by Kenneth Rohde Christiansen and Andreas Kling.

It is faster and better than the current custom function.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::computeDeclarationHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactor OptionsObject.cpp
haraken@chromium.org [Thu, 27 Oct 2011 14:51:52 +0000 (14:51 +0000)]
Refactor OptionsObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=70572

Reviewed by Adam Barth.

For example, OptionsObject::getKeyBool() is an alias of
OptionsObject::getKeyValue(const String& key, bool& value).
We should remove OptionsObject::getKeyXXXX() (XXXX is some specific type)
and unify them into OptionsObject::get(const String& key, XXXX& value).
c.f. Corresponding JSC methods are unified into
JSDictionary::convertValue(JSC::ExecState*, JSC::JSValue, XXXX&).

The result of git diff is weird, but this patch is making just the following changes:
- Replaced getKeyBool(), getKeyInt32(), getKeyDouble() and getKeyString() with get().
- Renamed getKeyStringWithUndefinedOrNullCheck() to getWithUndefinedOrNullCheck().
- Removed getKeyDOMStringList() and getKeyKeyRange(), since these are not used.
- Move definitions of get() from .h to .cpp.

No new tests. No change in behavior.

* bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::get): Renamed from getKeyValue().
(WebCore::OptionsObject::getKey): No change to this method. git diff seems to misunderstand as if it is modified.
(WebCore::OptionsObject::getKeyDOMStringList): Removed, since no one is using it.
(WebCore::OptionsObject::getKeyKeyRange): Ditto.
(WebCore::OptionsObject::getWithUndefinedOrNullCheck): No change to this method. git diff seems to misunderstand as if it is modified.
* bindings/v8/OptionsObject.h: Moved definitions of get() to OptionsObject.cpp
* bindings/v8/custom/V8EventConstructors.cpp:
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::observeCallback): Replaced getKeyXXXX() to get();
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::createObjectStore): Ditto.
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Move the C API callback setup out of QtWebPageProxy
alexis.menard@openbossa.org [Thu, 27 Oct 2011 14:36:59 +0000 (14:36 +0000)]
[Qt][WK2] Move the C API callback setup out of QtWebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=70965

Reviewed by Andreas Kling.

Move out the setup of C API callback into ClientImpl file
so that QtWebPageProxy will be less polluted.

* UIProcess/qt/ClientImpl.cpp:
(qt_wk_didStartProvisionalLoadForFrame):
(qt_wk_didFailProvisionalLoadWithErrorForFrame):
(qt_wk_didCommitLoadForFrame):
(qt_wk_didFinishLoadForFrame):
(qt_wk_didFailLoadWithErrorForFrame):
(qt_wk_didSameDocumentNavigationForFrame):
(qt_wk_didReceiveTitleForFrame):
(qt_wk_didStartProgress):
(qt_wk_didChangeProgress):
(qt_wk_didFinishProgress):
(qt_wk_runJavaScriptAlert):
(qt_wk_runJavaScriptConfirm):
(qt_wk_runJavaScriptPrompt):
(qt_wk_setStatusText):
(qt_wk_runOpenPanel):
(qt_wk_mouseDidMoveOverElement):
(qt_wk_decidePolicyForNavigationAction):
(qt_wk_decidePolicyForResponse):
(setupPageLoaderClient):
(setupPageUiClient):
(setupPagePolicyClient):
* UIProcess/qt/ClientImpl.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::init):
* UIProcess/qt/QtWebPageProxy.h:
(QtWebPageProxy::viewInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoneed to rebaseline after skia 2527 lands, fixing an off-by-1 bug in blending (with...
reed@google.com [Thu, 27 Oct 2011 14:33:11 +0000 (14:33 +0000)]
need to rebaseline after skia 2527 lands, fixing an off-by-1 bug in blending (with alpha==0)
https://bugs.webkit.org/show_bug.cgi?id=70963

Reviewed by James Robinson.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStyleSheet.parentStyleSheet does not work.
commit-queue@webkit.org [Thu, 27 Oct 2011 14:26:04 +0000 (14:26 +0000)]
StyleSheet.parentStyleSheet does not work.
https://bugs.webkit.org/show_bug.cgi?id=70956

Patch by Andreas Kling <kling@webkit.org> on 2011-10-27
Reviewed by Antti Koivisto.

Source/WebCore:

Since StyleSheet is only ever parented by a CSSRule, we need
to go through that rule when resolving the StyleSheet's parent.

Test: fast/css/stylesheet-parentStyleSheet.html

* css/StyleSheet.cpp:
(WebCore::StyleSheet::parentStyleSheet):

LayoutTests:

* fast/css/stylesheet-parentStyleSheet-expected.txt: Added.
* fast/css/stylesheet-parentStyleSheet.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable blending when drawing opaque layers
commit-queue@webkit.org [Thu, 27 Oct 2011 14:23:49 +0000 (14:23 +0000)]
Disable blending when drawing opaque layers
https://bugs.webkit.org/show_bug.cgi?id=70085

Patch by Antoine Labour <piman@chromium.org> on 2011-10-27
Reviewed by James Robinson.

Covered by compositing/ tests, as well as a new unit test:
CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawLayer):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setOpaque):
(WebCore::CCLayerImpl::opaque):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium ui_tests WorkerTest.WorkerMessagePort[GC] were broken by https://bugs.webkit...
commit-queue@webkit.org [Thu, 27 Oct 2011 14:03:32 +0000 (14:03 +0000)]
Chromium ui_tests WorkerTest.WorkerMessagePort[GC] were broken by https://bugs.webkit.org/attachment.cgi?id=112342
https://bugs.webkit.org/show_bug.cgi?id=70953

Patch by Dave Michael <dmichael@chromium.org> on 2011-10-27
Reviewed by David Levin.

* src/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::hasPendingActivity):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-27 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 27 Oct 2011 14:00:48 +0000 (14:00 +0000)]
2011-10-27  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed, gardening.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agomake lion observe MAC lines in test_expectations.txt
commit-queue@webkit.org [Thu, 27 Oct 2011 13:35:53 +0000 (13:35 +0000)]
make lion observe MAC lines in test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=70941

Patch by Elliot Poger <epoger@google.com> on 2011-10-27
Reviewed by Ojan Vafai.

* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Passing empty array to IDBDatabase.transaction should raise exception
commit-queue@webkit.org [Thu, 27 Oct 2011 13:35:51 +0000 (13:35 +0000)]
IndexedDB: Passing empty array to IDBDatabase.transaction should raise exception
https://bugs.webkit.org/show_bug.cgi?id=70251

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-27
Reviewed by Adam Barth.

Source/WebCore:

IDBDatabase.transaction() supported being called with an empty array to
lock all object stores. Support for this was rejected from inclusion in
the IDB spec due to performance concerns. This patch removes that
functionality.

A special case in the spec (passing a string instead of an array) worked
in WebKit accidentally, by resolving the string to an empty array. This
needed explicit support. Support for DOMString[] is added to the binding
code generators (reliant on DOMStringList) to ensure JS arrays are not
coerced to DOMStrings. This matches the proposed IDL.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheckExpression):
(GetNativeType):
(JSValueToNative):
(IsArrayType):
* bindings/scripts/IDLStructure.pm:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.h:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.idl:
* storage/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::objectStore):

LayoutTests:

Many tests relied on the non-specified behavior of passing an empty
array into IDBDatabase.transaction() to include all object stores in
scopes. Worse, non-arrays would be treated as empty arrays, and hence
"just worked".

* storage/indexeddb/create-and-remove-object-store-expected.txt:
* storage/indexeddb/create-and-remove-object-store.html:
* storage/indexeddb/create-object-store-options-expected.txt:
* storage/indexeddb/create-object-store-options.html:
* storage/indexeddb/cursor-inconsistency-expected.txt:
* storage/indexeddb/cursor-inconsistency.html:
* storage/indexeddb/cursor-skip-deleted-expected.txt:
* storage/indexeddb/cursor-skip-deleted.html:
* storage/indexeddb/cursor-update-expected.txt:
* storage/indexeddb/cursor-update.html:
* storage/indexeddb/data-corruption-expected.txt:
* storage/indexeddb/data-corruption.html:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/error-causes-abort-by-default-expected.txt:
* storage/indexeddb/error-causes-abort-by-default.html:
* storage/indexeddb/exception-in-event-aborts-expected.txt:
* storage/indexeddb/exception-in-event-aborts.html:
* storage/indexeddb/index-unique-expected.txt:
* storage/indexeddb/index-unique.html:
* storage/indexeddb/mutating-cursor-expected.txt:
* storage/indexeddb/mutating-cursor.html:
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-autoincrement.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
* storage/indexeddb/objectstore-clear-expected.txt:
* storage/indexeddb/objectstore-clear.html:
* storage/indexeddb/objectstore-removeobjectstore-expected.txt:
* storage/indexeddb/objectstore-removeobjectstore.html:
* storage/indexeddb/request-event-propagation-expected.txt:
* storage/indexeddb/request-event-propagation.html:
* storage/indexeddb/transaction-abort-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion-expected.txt:
* storage/indexeddb/transaction-abort-with-js-recursion.html:
* storage/indexeddb/transaction-abort.html:
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/transaction-after-close.html:
* storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
* storage/indexeddb/transaction-and-objectstore-calls.html:
* storage/indexeddb/transaction-basics-expected.txt:
* storage/indexeddb/transaction-basics.html:
* storage/indexeddb/transaction-crash-on-abort-expected.txt:
* storage/indexeddb/transaction-crash-on-abort.html:
* storage/indexeddb/transaction-event-propagation-expected.txt:
* storage/indexeddb/transaction-event-propagation.html:
* storage/indexeddb/transaction-read-only-expected.txt:
* storage/indexeddb/transaction-read-only.html:
* storage/indexeddb/transaction-storeNames-required-expected.txt:
* storage/indexeddb/tutorial.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnable MEDIA_SOURCE feature for Chromium
commit-queue@webkit.org [Thu, 27 Oct 2011 13:31:28 +0000 (13:31 +0000)]
Enable MEDIA_SOURCE feature for Chromium
https://bugs.webkit.org/show_bug.cgi?id=70745

Patch by Aaron Colwell <acolwell@chromium.org> on 2011-10-27
Reviewed by David Levin.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash due to nested first-letter selectors
commit-queue@webkit.org [Thu, 27 Oct 2011 13:22:56 +0000 (13:22 +0000)]
Crash due to nested first-letter selectors
https://bugs.webkit.org/show_bug.cgi?id=70457

Source/WebCore:

Now only the lowest-level first-letter pseudostyle will be applied to
a given piece of text. Previously the last renderer to have layout
done would have its pseudostyle applied, no matter where it was in the
tree.

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-10-27
Reviewed by David Hyatt.

* renderer/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter): Use the pseudostyle from
the lowest level node to have one

LayoutTests:

Adding layout test for nested first-letter pseudostyles causing a crash.

Patch by Ken Buchanan <kenrb@chromium.org> on 2011-10-27
Reviewed by David Hyatt.

* fast/css/nested-first-letter-with-float-crash.html: Added
* fast/css/nested-first-letter-with-float-crash-expected.txt: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Remove QAction from MiniBrowser
abecsi@webkit.org [Thu, 27 Oct 2011 13:19:53 +0000 (13:19 +0000)]
[Qt][WK2] Remove QAction from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=70525

This fixes the commonview tests that were failing
after r98447.
WebViewAbstraction must forward actions to both
the TouchWebView and the DesktopWebView.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-27
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Allow DRT to be built without notifications enabled.
jknotten@chromium.org [Thu, 27 Oct 2011 13:07:23 +0000 (13:07 +0000)]
[Chromium] Allow DRT to be built without notifications enabled.
https://bugs.webkit.org/show_bug.cgi?id=70919

Reviewed by Tony Gentilcore.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::grantDesktopNotificationPermission):
(LayoutTestController::simulateDesktopNotificationClick):
* DumpRenderTree/chromium/NotificationPresenter.cpp:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetTestController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2]Content size changed event does not require viewport attribute calculation.
commit-queue@webkit.org [Thu, 27 Oct 2011 13:05:47 +0000 (13:05 +0000)]
[Qt][WK2]Content size changed event does not require viewport attribute calculation.
https://bugs.webkit.org/show_bug.cgi?id=70920

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2011-10-27
Reviewed by Kenneth Rohde Christiansen.

Remove unnecessary recalculation of viewport attributes.

* UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::contentSizeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix the build if NO_LISTBOX_RENDERING is enabled
abecsi@webkit.org [Thu, 27 Oct 2011 13:02:42 +0000 (13:02 +0000)]
Fix the build if NO_LISTBOX_RENDERING is enabled
https://bugs.webkit.org/show_bug.cgi?id=71009

Reviewed by Kenneth Rohde Christiansen.

If NO_LISTBOX_RENDERING is enabled RenderMenuList::listBoxSelectItem uses the
HTMLSelectElement::listBoxSelectItem function which was accidentally removed in r97533.
Reintroduce HTMLSelectElement::listBoxSelectItem with a NO_LISTBOX_RENDERING guard to unbreak this setup.

This is covered by:
Source/WebCore/manual-tests/no-listbox-rendering.html

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::listBoxSelectItem): Reintroduce.
* html/HTMLSelectElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement legacy text check emulation in unified text check interface.
commit-queue@webkit.org [Thu, 27 Oct 2011 12:52:16 +0000 (12:52 +0000)]
Implement legacy text check emulation in unified text check interface.
https://bugs.webkit.org/show_bug.cgi?id=70299

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-10-27
Reviewed by Hajime Morita.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

When UNIFIED_TEXT_CHECKING is off, WebCore::checkTextOfParagraph() emulates
TextCheckerClient::checkTextOfParagraph() using checkSpellingOfString and checkGrammarOfString.

This emulation can be used by setting the flag on.
This can be done by WebCore::Internals::setUnifiedTextCheckingEnabled.

Test: editing/spelling/spelling-unified-emulation.html

* editing/TextCheckingHelper.cpp:
(WebCore::findBadGrammars): Added.
(WebCore::findMisspellings): Added.
(WebCore::checkTextOfParagraph):
  Emulates TextCheckerClients::checkTextOfParagraph if UNIFIED_TEXT_CHECKING is off.
* testing/Internals.cpp:
(WebCore::Internals::setUnifiedTextCheckingEnabled): flag setter.
(WebCore::Internals::unifiedTextCheckingEnabled): flag getter.
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Added tests for the case unified text checker is used when WebCore::checkTextOfParagraph() is not supported.

* editing/spelling/spelling-unified-emulation-expected.txt: Added.
* editing/spelling/spelling-unified-emulation.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, remove those un-needed files committed by error in
philn@webkit.org [Thu, 27 Oct 2011 12:37:41 +0000 (12:37 +0000)]
Unreviewed, remove those un-needed files committed by error in
r98554.

* platform/audio/gstreamer/#AudioFileReaderGStreamer.h#: Removed.
* platform/audio/gstreamer/.#AudioFileReaderGStreamer.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] WebAudio AudioFileReader implementation
philn@webkit.org [Thu, 27 Oct 2011 12:31:44 +0000 (12:31 +0000)]
[GStreamer] WebAudio AudioFileReader implementation
https://bugs.webkit.org/show_bug.cgi?id=69834

.:

Patch by Philippe Normand  <pnormand@igalia.com> and Zan Dobersek <zandobersek@gmail.com> on 2011-10-27
Reviewed by Martin Robinson.

* configure.ac: Check for libfftw and gstreamer-audio if WebAudio
build is enabled.

Source/WebCore:

Patch by Philippe Normand  <pnormand@igalia.com> and Zan Dobersek <zandobersek@gmail.com> on 2011-10-27
Reviewed by Martin Robinson.

Basic FileReader implementation, supporting one or 2 audio
channels. An empty AudioDestination is also provided, its complete
implementation is handled in bug 69835.

* GNUmakefile.am:
* GNUmakefile.list.am:
* platform/audio/gstreamer/AudioDestinationGStreamer.cpp: Added.
(WebCore::AudioDestination::create):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::start):
(WebCore::AudioDestinationGStreamer::stop):
* platform/audio/gstreamer/AudioDestinationGStreamer.h: Added.
(WebCore::AudioDestinationGStreamer::isPlaying):
(WebCore::AudioDestinationGStreamer::sampleRate):
(WebCore::AudioDestinationGStreamer::sourceProvider):
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp: Added.
(WebCore::getGStreamerAudioCaps):
(WebCore::getFloatFromByteReader):
(WebCore::copyGstreamerBuffersToAudioChannel):
(WebCore::onAppsinkNewBufferCallback):
(WebCore::messageCallback):
(WebCore::onGStreamerDeinterleavePadAddedCallback):
(WebCore::onGStreamerDeinterleaveReadyCallback):
(WebCore::onGStreamerDecodebinPadAddedCallback):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::~AudioFileReader):
(WebCore::AudioFileReader::handleBuffer):
(WebCore::AudioFileReader::handleMessage):
(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::deinterleavePadsConfigured):
(WebCore::AudioFileReader::plugDeinterleave):
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):
* platform/audio/gtk/AudioBusGtk.cpp: Added.
(WebCore::AudioBus::loadPlatformResource):

Source/WebKit/gtk:

Reviewed by Martin Robinson.

* GNUmakefile.am: Link against libfftw.

Source/WebKit2:

Reviewed by Martin Robinson.

* GNUmakefile.am: Link against libfftw.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, GTK rebaseline after r98507.
philn@webkit.org [Thu, 27 Oct 2011 12:23:26 +0000 (12:23 +0000)]
Unreviewed, GTK rebaseline after r98507.

* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rebaseline of the bindings tests after r98501 which
philn@webkit.org [Thu, 27 Oct 2011 12:19:19 +0000 (12:19 +0000)]
Unreviewed, rebaseline of the bindings tests after r98501 which
removed getOwnPropertySlotVirtual.

* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestInterface.h:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttp/tests/inspector/search/search-in-resources.html fails on all platforms
vsevik@chromium.org [Thu, 27 Oct 2011 11:51:59 +0000 (11:51 +0000)]
http/tests/inspector/search/search-in-resources.html fails on all platforms
https://bugs.webkit.org/show_bug.cgi?id=70993

Reviewed by Pavel Feldman.

* http/tests/inspector/search/search-test.js:
(initialize_SearchTest.InspectorTest.dumpSearchResults):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebInspector: View throughs the exception when a child view are removed by removeChil...
loislo@chromium.org [Thu, 27 Oct 2011 11:50:53 +0000 (11:50 +0000)]
WebInspector: View throughs the exception when a child view are removed by removeChildren call.
https://bugs.webkit.org/show_bug.cgi?id=71002

Another followup fix after r98225.

Reviewed by Pavel Feldman.

* inspector/front-end/DatabaseTableView.js:
(WebInspector.DatabaseTableView.prototype._queryFinished):
(WebInspector.DatabaseTableView.prototype._queryError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Execution line in selected call frame should keep showing after toggli...
vsevik@chromium.org [Thu, 27 Oct 2011 11:49:18 +0000 (11:49 +0000)]
Web Inspector: Execution line in selected call frame should keep showing after toggling format source.
https://bugs.webkit.org/show_bug.cgi?id=70906

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/selected-call-frame-after-formatting-source.html

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):

LayoutTests:

* inspector/debugger/selected-call-frame-after-formatting-source-expected.txt: Added.
* inspector/debugger/selected-call-frame-after-formatting-source.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNumerous debug build fixes
steveblock@google.com [Thu, 27 Oct 2011 11:47:51 +0000 (11:47 +0000)]
Numerous debug build fixes

Unreviewed build fix.

No new tests, buuld fix only.

* loader/icon/IconDatabase.cpp: urlForLogging() is used by both LOG() and LOG_ERROR()
* storage/AbstractDatabase.h: databaseDebugName() is used by both LOG() and LOG_ERROR()
* storage/DatabaseTask.cpp: m_complete is only available when !LOG_DISABLED

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Improve command line arguments handling for MiniBrowser.
jocelyn.turcotte@nokia.com [Thu, 27 Oct 2011 11:43:39 +0000 (11:43 +0000)]
[Qt] Improve command line arguments handling for MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=70616

Reviewed by Kenneth Rohde Christiansen.

- Use two dashes for word arguments.
- Return with an error when an unsupported argument is given.
- Allow the URL to be placed before option arguments.

* MiniBrowser/qt/MiniBrowserApplication.cpp:
(printHelp):
(MiniBrowserApplication::handleUserOptions):
* MiniBrowser/qt/utils.cpp:
(takeOptionFlag):
(takeOptionValue):
* MiniBrowser/qt/utils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Refactor ScriptsPanel so that ConsoleView does not depend on it.
vsevik@chromium.org [Thu, 27 Oct 2011 11:36:09 +0000 (11:36 +0000)]
Web Inspector: Refactor ScriptsPanel so that ConsoleView does not depend on it.
https://bugs.webkit.org/show_bug.cgi?id=70899

Moved methods used in console view to DebuggerPresentationModel.
Changed debuggerPaused handler logic so that selectedCallFrame is never null when debugger is paused.

Reviewed by Pavel Feldman.

* inspector/front-end/ConsoleView.js:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
(WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.evaluateInSelectedCallFrame):
(WebInspector.DebuggerPresentationModel.prototype.getSelectedCallFrameVariables.propertiesCollected):
(WebInspector.DebuggerPresentationModel.prototype.getSelectedCallFrameVariables):
(WebInspector.DebuggerPresentationModel.prototype._dispatchExecutionLineChanged):
(WebInspector.DebuggerPresentationModel.prototype.get executionLineLocation):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._consoleCommandEvaluatedInSelectedCallFrame):
(WebInspector.ScriptsPanel.prototype._executionLineChanged):
(WebInspector.ScriptsPanel.prototype._updateExecutionLine):
(WebInspector.ScriptsPanel.prototype._callFrameSelected):
(WebInspector.ScriptsPanel.prototype._updateCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Add support for advanced search in content scripts.
vsevik@chromium.org [Thu, 27 Oct 2011 11:30:44 +0000 (11:30 +0000)]
Web Inspector: Add support for advanced search in content scripts.
https://bugs.webkit.org/show_bug.cgi?id=70923

Reviewed by Yury Semikhatsky.

* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsSearchScope.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] NRWT doesn't work on qt-mac platform
ossy@webkit.org [Thu, 27 Oct 2011 11:30:14 +0000 (11:30 +0000)]
[Qt] NRWT doesn't work on qt-mac platform
https://bugs.webkit.org/show_bug.cgi?id=64445

Reviewed by Adam Barth.

* Scripts/run-webkit-tests: Switch qt-mac platform to NRWT.
(useNewRunWebKitTests):
* Scripts/webkitpy/layout_tests/port/qt.py: Fix library path on Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed one line fix for DOMStorageItemsView.
loislo@chromium.org [Thu, 27 Oct 2011 09:55:32 +0000 (09:55 +0000)]
Unreviewed one line fix for DOMStorageItemsView.
It have to use this.detachChildViews instead of this.element.removeChildren after r98225.

* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMatched declaration cache
antti@apple.com [Thu, 27 Oct 2011 09:39:48 +0000 (09:39 +0000)]
Matched declaration cache
https://bugs.webkit.org/show_bug.cgi?id=70931

Reviewed by Darin Adler.

Sets of style declarations are applied repeatedly for different elements when calculating the document style.
The same set of applied declarations results in the same non-inherited style, independent of the element and
its context. We can use this to build a cache to speed up style applying and to share more style data for
reduced memory usage.

The patch reduces RenderStyle memory use ~40% and total memory use by ~7% over HTML5 spec load.
It is also ~10% progression in PerformanceTests/Parser/html5-full-render.html.

* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSProperty.h:
(WebCore::CSSProperty::CSSProperty):
(WebCore::CSSProperty::isInherited):

    We need to know which properties are inherited, something we didn't have available so far.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchAllRules):

    A set of declarations is only cacheable if it contains no element specific style. This way we
    don't need to worry about cache invalidation. The whole style selector is reconstructed if the
    stylesheets change, invalidating the cache too.

(WebCore::CSSStyleSelector::styleForElement):

    Trigger image loads bit earlier so cached style will have them too.

(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):

    Allow skipping over non-inherited properties.

(WebCore::CSSStyleSelector::computeDeclarationHash):

    Hash function for declartion cache lookups.

(WebCore::operator==):
(WebCore::operator!=):
(WebCore::CSSStyleSelector::findFromMatchedDeclarationCache):

    Lookup from cache.

(WebCore::CSSStyleSelector::addToMatchedDeclarationCache):

    Add to cache.

(WebCore::CSSStyleSelector::applyMatchedDeclarations):

    If cached style is found, copy the non-inherited properties from the cache and apply the inherited properties (if any) only.

    Font and zoom changes force full applying as they can affect values of other properties (this can be relaxed later).

* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::MatchResult::MatchResult):

    Cacheability bit.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::copyNonInheritedFrom):
* rendering/style/RenderStyle.h:
* rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::copyNonInheritedFrom):
* rendering/style/SVGRenderStyle.h:

    Functions for assembling RenderStyle from non-inherited parts of the cached style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Extensions API] add ignoreCache flag to options of inspectedWindow...
caseq@chromium.org [Thu, 27 Oct 2011 09:37:00 +0000 (09:37 +0000)]
Web Inspector: [Extensions API] add ignoreCache flag to options of inspectedWindow.reload()
https://bugs.webkit.org/show_bug.cgi?id=70926

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/extensions-ignore-cache.html

* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onReload):
* inspector/front-end/externs.js:
():

LayoutTests:

* http/tests/inspector/extensions-ignore-cache-expected.txt: Added.
* http/tests/inspector/extensions-ignore-cache.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, fix typo in skiplist.
rgabor@webkit.org [Thu, 27 Oct 2011 09:33:59 +0000 (09:33 +0000)]
Unreviewed, fix typo in skiplist.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add bugzilla link to skipped test.
rgabor@webkit.org [Thu, 27 Oct 2011 08:54:57 +0000 (08:54 +0000)]
Unreviewed. Add bugzilla link to skipped test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoinspector/storage-panel-dom-storage.html has results platform dependant?
yurys@chromium.org [Thu, 27 Oct 2011 07:53:44 +0000 (07:53 +0000)]
inspector/storage-panel-dom-storage.html has results platform dependant?
https://bugs.webkit.org/show_bug.cgi?id=70985

The items set in DOM storage is unsorted and as result the test is platform dependant.
We will sort it before the dumping.

Patch by Ilya Tikhonovsky <loislo@chromium.org> on 2011-10-27
Reviewed by Yury Semikhatsky.

* inspector/storage-panel-dom-storage-expected.txt:
* inspector/storage-panel-dom-storage.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-26 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 27 Oct 2011 06:50:04 +0000 (06:50 +0000)]
2011-10-26  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed, gardening.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-26 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 27 Oct 2011 06:37:45 +0000 (06:37 +0000)]
2011-10-26  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update Chromium test_expectations.

        inspector/storage-panel-dom-storage.html has results platform dependant?
        https://bugs.webkit.org/show_bug.cgi?id=70985

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-26 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 27 Oct 2011 06:27:36 +0000 (06:27 +0000)]
2011-10-26  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Update test expecatations for search-in-resources.html

        http/tests/inspector/search/search-in-resources.html fails on all platforms
        https://bugs.webkit.org/show_bug.cgi?id=70993

        * http/tests/inspector/search/search-in-resources-expected.txt:
        * platform/chromium-linux/http/tests/inspector/search/search-in-resources-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium Windows and Linux rebaselines.
rniwa@webkit.org [Thu, 27 Oct 2011 05:16:06 +0000 (05:16 +0000)]
Chromium Windows and Linux rebaselines.

* platform/chromium-linux/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium-linux/platform/mac/editing: Added.
* platform/chromium-linux/platform/mac/editing/pasteboard: Added.
* platform/chromium-linux/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium-win/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium-win/http/tests/security/dataTransfer-set-data-file-url-expected.txt: Added.
* platform/chromium-win/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium-win/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConsole message in copy-standalone-image-crash.html bleeds into the result of copy...
rniwa@webkit.org [Thu, 27 Oct 2011 04:56:44 +0000 (04:56 +0000)]
Console message in copy-standalone-image-crash.html bleeds into the result of copy-standalone-image.html
https://bugs.webkit.org/show_bug.cgi?id=70957

Reviewed by Ojan Vafai.

The bug was caused by the delayed hideDiv call in a mousedown event listener.
Fixed the bug by not attaching this event listener inside DRT or TestRunner.

* editing/pasteboard/copy-standalone-image-crash.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMassive gardening.
jchaffraix@webkit.org [Thu, 27 Oct 2011 01:51:50 +0000 (01:51 +0000)]
Massive gardening.

* platform/chromium/test_expectations.txt: Lots of tests were regularly failing
or timing out but were not marked. Added them as they were consistently flaky.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
jchaffraix@webkit.org [Thu, 27 Oct 2011 01:12:09 +0000 (01:12 +0000)]
Unreviewed gardening.

* platform/chromium-linux/http/tests/inspector: Added.
* platform/chromium-linux/http/tests/inspector/search: Added.
* platform/chromium-linux/http/tests/inspector/search/search-in-resources-expected.txt: Added.
Rebaselined (looks like the urls are sorted differently on Linux).

* platform/chromium/test_expectations.txt: Marked inspector/storage-panel-dom-storage.html
as TEXT as it started failing on the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoResourceError doesn't support custom domains on Windows
sfalken@apple.com [Thu, 27 Oct 2011 00:43:15 +0000 (00:43 +0000)]
ResourceError doesn't support custom domains on Windows
https://bugs.webkit.org/show_bug.cgi?id=70983
<rdar://problem/10352145>

Reviewed by Oliver Hunt.

* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::platformLazyInit): Add fallback case for unknown error types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a slider thumb rendering regression in Chromium on OS X in r98520.
mitz@apple.com [Thu, 27 Oct 2011 00:29:32 +0000 (00:29 +0000)]
Fix a slider thumb rendering regression in Chromium on OS X in r98520.

Reviewed by Anders Carlsson.

* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSliderThumb): Reverted the changes to the Chromium code path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r98486.
jchaffraix@webkit.org [Thu, 27 Oct 2011 00:21:34 +0000 (00:21 +0000)]
Unreviewed, rolling out r98486.
http://trac.webkit.org/changeset/98486
https://bugs.webkit.org/show_bug.cgi?id=70748

Broke Chromium's test_expectation.txt

Source/WebCore:

* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::State::State):
(WebCore::PlatformContextSkia::State::cloneInheritedProperties):
(WebCore::PlatformContextSkia::clipPathAntiAliased):
(WebCore::PlatformContextSkia::restore):
(WebCore::PlatformContextSkia::applyAntiAliasedClipPaths):
* platform/graphics/skia/PlatformContextSkia.h:

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago REGRESSION (r98153): Safari crashes if WebProcess crashed during printing
ap@apple.com [Thu, 27 Oct 2011 00:20:38 +0000 (00:20 +0000)]
    REGRESSION (r98153): Safari crashes if WebProcess crashed during printing
        https://bugs.webkit.org/show_bug.cgi?id=70982

        Reviewed by Dan Bernstein.

        * UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
        Null check page, it may be invalid already.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRestore structure-clearing behaviour of allocateCell<>
oliver@apple.com [Thu, 27 Oct 2011 00:19:31 +0000 (00:19 +0000)]
Restore structure-clearing behaviour of allocateCell<>
https://bugs.webkit.org/show_bug.cgi?id=70976

Reviewed by Geoffrey Garen.

This restores the logic that allows the markstack to filter
live objects that have not yet been initialised.

* runtime/JSCell.h:
(JSC::JSCell::clearStructure):
   Validation-safe method to clear a cell's structure.
(JSC::allocateCell):
   Call the above method.
* runtime/Structure.h:
(JSC::MarkStack::internalAppend):
   Don't visit cells that haven't been initialised.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed trivial renaming.
jchaffraix@webkit.org [Wed, 26 Oct 2011 22:42:55 +0000 (22:42 +0000)]
Unreviewed trivial renaming.

* fast/js/dfg-intrinsic-osr-exit-expected.html: Removed.
* fast/js/dfg-intrinsic-osr-exit-expected.txt: Copied from LayoutTests/fast/js/dfg-intrinsic-osr-exit-expected.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
jchaffraix@webkit.org [Wed, 26 Oct 2011 22:26:52 +0000 (22:26 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt:
storage/domstorage/events/basic-setattribute.html is a flaky crasher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/10350775> REGRESSION (r97032): Slider thumb is not drawn
mitz@apple.com [Wed, 26 Oct 2011 21:41:01 +0000 (21:41 +0000)]
<rdar://problem/10350775> REGRESSION (r97032): Slider thumb is not drawn
https://bugs.webkit.org/show_bug.cgi?id=70891

Reviewed by Anders Carlsson.

* platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::ensuredView): Set the WebCoreFlippedView’s size, because NSSliderCell
always shrinks the slider thumb to fit in the control view’s bounds.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSliderThumb): Removed workaround code no longer needed after
r97032.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening: sixth chunk of baselines for Chromium-Skia
caryclark@google.com [Wed, 26 Oct 2011 21:32:22 +0000 (21:32 +0000)]
Unreviewed gardening: sixth chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 674 of 680 files for brevity.]

* platform/chromium-mac-leopard/svg/as-background-image: Added.
* platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-1-expected.png: Added.
* platform/chromium-mac-leopard/svg/as-background-image/svg-as-background-5-expected.png: Added.
...
* platform/chromium-mac-leopard/tables/mozilla/core/margins-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/marvin/x_col_valign_baseline-expected.png: Added.
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r97030): Cannot log in to progressive.com
fpizlo@apple.com [Wed, 26 Oct 2011 21:13:52 +0000 (21:13 +0000)]
REGRESSION (r97030): Cannot log in to progressive.com
https://bugs.webkit.org/show_bug.cgi?id=70094

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):

LayoutTests:

* fast/js/dfg-intrinsic-osr-exit-expected.html: Added.
* fast/js/dfg-intrinsic-osr-exit.html: Added.
* fast/js/script-tests/dfg-intrinsic-osr-exit.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed. Add pixel baselines for CSS3 tests.
leandro@webkit.org [Wed, 26 Oct 2011 20:43:26 +0000 (20:43 +0000)]
[EFL] Unreviewed. Add pixel baselines for CSS3 tests.

* platform/efl/css3: [...]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd chromium bridging for AudioSourceProviderClient and setFormat() method so we...
crogers@google.com [Wed, 26 Oct 2011 20:20:09 +0000 (20:20 +0000)]
Add chromium bridging for AudioSourceProviderClient and setFormat() method so we can know audio stream format
https://bugs.webkit.org/show_bug.cgi?id=70650

Reviewed by Darin Fisher.

* WebKit.gyp:
* public/WebAudioSourceProvider.h:
(WebKit::WebAudioSourceProvider::setClient):
* public/WebAudioSourceProviderClient.h: Copied from Source/WebKit/chromium/public/WebAudioSourceProvider.h.
(WebKit::WebAudioSourceProviderClient::~WebAudioSourceProviderClient):
* public/WebMediaPlayer.h:
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit::WebMediaPlayerClientImpl::audioSourceProvider):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::wrap):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::setClient):
(WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::provideInput):
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::setFormat):
* src/WebMediaPlayerClientImpl.h:
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::AudioClientImpl):
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::~AudioClientImpl):
(WebKit::WebMediaPlayerClientImpl::AudioClientImpl::wrap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit2 should respect secret WebKitOmitPDFSupport preference on the Mac
jeffm@apple.com [Wed, 26 Oct 2011 20:19:14 +0000 (20:19 +0000)]
WebKit2 should respect secret WebKitOmitPDFSupport preference on the Mac
https://bugs.webkit.org/show_bug.cgi?id=70943

If WebKitOmitPDFSupport pref is set, disable both the new "plug-in" for subframes and the PDFKit-based support for the main frame only.

Reviewed by Alexey Proskuryakov.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::getPlugins): Don't register built-in PDF plugin if WebKitOmitPDFSupport pref is set.

* UIProcess/WebContext.h: Added omitPDFSupport().

* UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::canShowMIMEType): Don't show PDFs if WebKitOmitPDFSupport is set.

* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::omitPDFSupport): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd AudioSourceProviderClient and setFormat() method so we can know audio stream...
crogers@google.com [Wed, 26 Oct 2011 19:57:36 +0000 (19:57 +0000)]
Add AudioSourceProviderClient and setFormat() method so we can know audio stream format
https://bugs.webkit.org/show_bug.cgi?id=70155

Reviewed by Eric Carlson.

No new tests.  There isn't yet an implementation to test.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::setAudioSourceNode):
Let MediaPlayer know about the MediaElementAudioSourceNode so it can callback with audio stream format information.
* platform/audio/AudioSourceProvider.h:
(WebCore::AudioSourceProvider::setClient):
Add abstract setClient() method so a client may know about stream format information when it becomes available.
* platform/audio/AudioSourceProviderClient.h: Copied from Source/WebCore/webaudio/MediaElementAudioSourceNode.h.
(WebCore::AudioSourceProviderClient::~AudioSourceProviderClient):
Add abstract class AudioSourceProviderClient which implements setFormat() to receive audio stream format information.
* webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::setFormat):
Concrete implementation of setFormat() so MediaElementAudioSourceNode can create necessary audio converters.
* webaudio/MediaElementAudioSourceNode.h:
Make MediaElementAudioSourceNode implement AudioSourceProviderClient so it can get audio stream format information
when its setFormat() method is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Unreviewed. Add pixel baselines for CSS2.1 tests.
leandro@webkit.org [Wed, 26 Oct 2011 19:55:26 +0000 (19:55 +0000)]
[EFL] Unreviewed. Add pixel baselines for CSS2.1 tests.

* platform/efl/css2.1: [...]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium Mac rebaseline.
rniwa@webkit.org [Wed, 26 Oct 2011 19:06:21 +0000 (19:06 +0000)]
Chromium Mac rebaseline.

* platform/chromium-mac-leopard/editing/pasteboard/copy-standalone-image-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/pasteboard/copy-standalone-image-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd initial setting to WKBrowsingContextGroup
weinig@apple.com [Wed, 26 Oct 2011 19:01:32 +0000 (19:01 +0000)]
Add initial setting to WKBrowsingContextGroup
https://bugs.webkit.org/show_bug.cgi?id=70942

Reviewed by Anders Carlsson.

Source/WebKit2:

Test: WKBrowsingContextGroupTest.

* UIProcess/API/mac/WKBrowsingContextGroup.h:
* UIProcess/API/mac/WKBrowsingContextGroup.mm:
(-[WKBrowsingContextGroup isJavaScriptEnabled]):
(-[WKBrowsingContextGroup setJavaScriptEnabled:]):
Add setting to enabled/disable javascript. By default it is enabled.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Added.
Add basic test that setting the javaScriptEnabled setting takes. It is not
possible to test its effect quite yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r98483.
jchaffraix@webkit.org [Wed, 26 Oct 2011 18:58:59 +0000 (18:58 +0000)]
Unreviewed, rolling out r98483.
http://trac.webkit.org/changeset/98483
https://bugs.webkit.org/show_bug.cgi?id=47156

Change is causing some crashes and ASSERTs.

Source/WebCore:

* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::lookupImageForSize):
(WebCore::CachedImage::lookupImageForRenderer):
(WebCore::CachedImage::lookupOrCreateImageForRenderer):
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
(WebCore::CachedImage::computeIntrinsicDimensions):
(WebCore::CachedImage::createImage):
* loader/cache/CachedImage.h:
* page/ChromeClient.h:
* rendering/ImageBySizeCache.cpp:
(WebCore::ImageBySizeCache::addClient):
(WebCore::ImageBySizeCache::removeClient):
(WebCore::ImageBySizeCache::imageForSize):
(WebCore::ImageBySizeCache::sizeForClient):
* rendering/ImageBySizeCache.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
* rendering/RenderBoxModelObject.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::imageDimensionsChanged):
(WebCore::RenderImage::isLogicalWidthSpecified):
(WebCore::RenderImage::isLogicalHeightSpecified):
(WebCore::RenderImage::computeReplacedLogicalWidth):
(WebCore::RenderImage::computeReplacedLogicalHeight):
(WebCore::RenderImage::calcAspectRatioLogicalWidth):
(WebCore::RenderImage::calcAspectRatioLogicalHeight):
* rendering/RenderImage.h:
* rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::setContainerSizeForRenderer):
* rendering/RenderImageResourceStyleImage.cpp:
* rendering/RenderImageResourceStyleImage.h:
(WebCore::RenderImageResourceStyleImage::image):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::computePreferredLogicalWidths):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeIntrinsicLogicalWidth):
(WebCore::RenderReplaced::computeIntrinsicLogicalHeight):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
* rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::computeIntrinsicDimensions):
(WebCore::StyleCachedImage::setContainerSizeForRenderer):
(WebCore::StyleCachedImage::addClient):
(WebCore::StyleCachedImage::removeClient):
* rendering/style/StyleCachedImage.h:
* rendering/style/StyleGeneratedImage.h:
(WebCore::StyleGeneratedImage::setContainerSizeForRenderer):
* rendering/style/StyleImage.h:
* rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::setContainerSizeForRenderer):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::layout):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeIntrinsicWidth):
(WebCore::RenderSVGRoot::computeIntrinsicHeight):
(WebCore::RenderSVGRoot::computeReplacedLogicalWidth):
(WebCore::RenderSVGRoot::computeReplacedLogicalHeight):
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::paint):
(WebCore::RenderSVGRoot::calcViewport):
(WebCore::RenderSVGRoot::computeRectForRepaint):
* rendering/svg/RenderSVGRoot.h:
* svg/SVGLength.cpp:
(WebCore::SVGLength::determineViewport):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::relativeWidthValue):
(WebCore::SVGSVGElement::relativeHeightValue):
(WebCore::SVGSVGElement::currentViewBoxRect):
* svg/SVGSVGElement.h:
(WebCore::SVGSVGElement::setContainerSize):
(WebCore::SVGSVGElement::containerSize):
(WebCore::SVGSVGElement::hasSetContainerSize):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::usesContainerSize):
(WebCore::SVGImage::size):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::dataChanged):
* svg/graphics/SVGImage.h:

LayoutTests:

* css2.1/20110323/background-intrinsic-001.htm: Removed.
* css2.1/20110323/background-intrinsic-002.htm: Removed.
* css2.1/20110323/background-intrinsic-003.htm: Removed.
* css2.1/20110323/background-intrinsic-004.htm: Removed.
* css2.1/20110323/background-intrinsic-005.htm: Removed.
* css2.1/20110323/background-intrinsic-006.htm: Removed.
* css2.1/20110323/background-intrinsic-007.htm: Removed.
* css2.1/20110323/background-intrinsic-008.htm: Removed.
* css2.1/20110323/background-intrinsic-009.htm: Removed.
* css2.1/20110323/resources/green-intrinsic-height-ratio.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-height.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-none.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-ratio-landscape.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-ratio-portrait.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-width-height.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-width-pc-height-pc.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-width-ratio.svg: Removed.
* css2.1/20110323/resources/green-intrinsic-width.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-height-ratio.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-height.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-none.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-ratio-landscape.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-ratio-portrait.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-width-height.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-width-pc-height-pc.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-width-ratio.svg: Removed.
* css2.1/20110323/resources/red-intrinsic-width.svg: Removed.
* fast/backgrounds/size/contain-and-cover-zoomed.html: Removed.
* fast/images/percent-height-image-expected.txt:
* fast/images/percent-height-image.html:
* platform/mac-snowleopard/svg/zoom/page/relative-sized-document-scrollbars-expected.png: Added.
* platform/mac-snowleopard/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/mac/css1/text_properties/vertical_align-expected.txt:
* platform/mac/css2.1/20110323/background-intrinsic-001-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-001-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-002-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-002-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-003-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-003-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-004-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-004-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-005-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-005-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-006-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-006-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-007-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-007-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-008-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-008-expected.txt: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-009-expected.png: Removed.
* platform/mac/css2.1/20110323/background-intrinsic-009-expected.txt: Removed.
* platform/mac/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Removed.
* platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
* platform/mac/fast/block/float/015-expected.png:
* platform/mac/fast/block/float/015-expected.txt:
* platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
* platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt:
* platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/mac/fast/repaint/block-layout-inline-children-replaced-expected.txt:
* platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png: Removed.
* platform/mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.txt: Removed.
* platform/mac/svg/as-background-image/background-image-tiled-expected.png: Removed.
* platform/mac/svg/as-background-image/background-image-tiled-expected.txt: Removed.
* platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.png: Removed.
* platform/mac/svg/as-background-image/same-image-two-instances-background-image-expected.txt: Removed.
* platform/mac/svg/as-background-image/svg-as-background-4-expected.png:
* platform/mac/svg/as-border-image/svg-as-border-image-expected.png:
* platform/mac/svg/as-image/animated-svg-as-image-expected.png:
* platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png: Removed.
* platform/mac/svg/as-image/img-preserveAspectRatio-support-1-expected.txt: Removed.
* platform/mac/svg/as-image/same-image-two-instances-expected.png: Removed.
* platform/mac/svg/as-image/same-image-two-instances-expected.txt: Removed.
* platform/mac/svg/as-image/svg-as-relative-image-expected.png:
* platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png: Removed.
* platform/mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.txt: Removed.
* platform/mac/svg/as-image/svg-image-change-content-size-expected.png: Removed.
* platform/mac/svg/as-image/svg-image-change-content-size-expected.txt: Removed.
* platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
* platform/mac/svg/zoom/page/relative-sized-document-scrollbars-expected.txt:
* platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.png: Removed.
* platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-background-images-expected.png: Removed.
* platform/mac/svg/zoom/page/zoom-background-images-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
* platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
* platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png: Removed.
* platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Removed.
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png: Removed.
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
* svg/as-background-image/background-image-preserveaspectRatio-support.html: Removed.
* svg/as-background-image/background-image-tiled.html: Removed.
* svg/as-background-image/resources/construction-tape.svg: Removed.
* svg/as-background-image/resources/hearts.svg:
* svg/as-background-image/same-image-two-instances-background-image.html: Removed.
* svg/as-image/img-preserveAspectRatio-support-1.html: Removed.
* svg/as-image/resources/circle-default-meet.svg: Removed.
* svg/as-image/resources/circle-default-none.svg: Removed.
* svg/as-image/resources/circle-default-slice.svg: Removed.
* svg/as-image/resources/circle-nosize.svg: Removed.
* svg/as-image/resources/circle-viewbox-default.svg: Removed.
* svg/as-image/resources/circle-viewbox-meet.svg: Removed.
* svg/as-image/resources/circle-viewbox-none.svg: Removed.
* svg/as-image/resources/circle-viewbox-slice.svg: Removed.
* svg/as-image/resources/green-relative-size-rect.svg:
* svg/as-image/same-image-two-instances.html: Removed.
* svg/as-image/svg-as-relative-image-with-explicit-size.html: Removed.
* svg/as-image/svg-image-change-content-size.xhtml: Removed.
* svg/zoom/page/resources/relative-sized-background-with-viewBox.svg: Removed.
* svg/zoom/page/zoom-background-image-tiled.html: Removed.
* svg/zoom/page/zoom-background-images.html: Removed.
* svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html: Removed.
* svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox.html: Removed.
* svg/zoom/page/zoom-svg-as-background-with-relative-size.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConstructors for all TextTrack interfaces should be available on DOMWindow
eric.carlson@apple.com [Wed, 26 Oct 2011 18:51:17 +0000 (18:51 +0000)]
Constructors for all TextTrack interfaces should be available on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=70734

Source/WebCore:

Reviewed by Sam Weinig.

window-properties-expected.txt and global-constructors-expected.txt updated for this change.

* page/DOMWindow.idl: Add HTMLTrackElement, TextTrack, and TextTrackCueList.

LayoutTests:

Reviewed by Sam Weinig.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r93108): Shadow DOM media controls created for plug-in backed media elements.
aestes@apple.com [Wed, 26 Oct 2011 18:41:27 +0000 (18:41 +0000)]
REGRESSION (r93108): Shadow DOM media controls created for plug-in backed media elements.
https://bugs.webkit.org/show_bug.cgi?id=70872

Reviewed by Eric Carlson.

r93108 added a call to HTMLMediaElement::configureMediaControls() in
HTMLMediaElement::prepareForLoad(), which creates shadow DOM media
controls and is only appropriate to call when media elements are not
backed by plug-in proxies.

Resolve this by refactoring configureMediaControls() to do the right
thing for the plug-in proxy case by calling MediaPlayer::setControls().

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::attributeChanged): Call
configureMediaControls() directly and remove the preprocessor
conditional.
(WebCore::HTMLMediaElement::configureMediaControls): Call
MediaPlayer::setControls() if PLUGIN_PROXY_FOR_VIDEO is enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoselectedIndex gets set from -1 to 0 when modifying options
jonlee@apple.com [Wed, 26 Oct 2011 18:36:22 +0000 (18:36 +0000)]
selectedIndex gets set from -1 to 0 when modifying options
https://bugs.webkit.org/show_bug.cgi?id=70547
<rdar://problem/8388856>

Reviewed by Darin Adler.

Source/WebCore:

Changing the text causes a recalculation of the list items, which in the menu list case
forces the first element to be selected. We check the value of the selected option prior,
and restore it if it differs.

Test: fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes.html

* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setText):
* html/HTMLSelectElement.h: promote usesMenuList() from private to public for use by HTMLOptionElement

LayoutTests:

The added tests set the selected index to either -1 or 1 (a legitimate value), and then change
the text, value, and label of the option. In all cases, the selected index should remain unchanged.

* fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes-expected.txt: Added.
* fast/dom/HTMLSelectElement/selected-index-preserved-when-option-text-changes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd new CSS escape sequence parsing tests
zherczeg@webkit.org [Wed, 26 Oct 2011 18:29:55 +0000 (18:29 +0000)]
Add new CSS escape sequence parsing tests
https://bugs.webkit.org/show_bug.cgi?id=70909

Reviewed by Darin Adler.

Test escape various sequences terminated by \n \f \r and \r\n.

* fast/css/parsing-css-escapes-expected.txt: Added.
* fast/css/parsing-css-escapes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Embedded PDFs should be known to DocumentLoader
ap@apple.com [Wed, 26 Oct 2011 18:11:51 +0000 (18:11 +0000)]
    Embedded PDFs should be known to DocumentLoader
        https://bugs.webkit.org/show_bug.cgi?id=70864

        Reviewed by Darin Adler.

        * WebProcess/Plugins/Plugin.h: Plugin stream load notifications now contain a suggested
        file name, in case the plug-in wants to save the file properly.

        * WebProcess/Plugins/PDF/BuiltInPDFView.h:
        * WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
        (WebKit::BuiltInPDFView::addArchiveResource): Add the PDF as resource in DocumentLoader.
        (WebKit::BuiltInPDFView::pdfDocumentDidLoad): Call addArchiveResource.
        (WebKit::BuiltInPDFView::initialize): We need to remember source URL to create a resource
        for that. The URL needs to match one in HitTestResult, so we can't use response URL.
        (WebKit::BuiltInPDFView::streamDidReceiveResponse): Remember suggested file name, so
        that we could put it in archive resource later.
        (WebKit::BuiltInPDFView::manualStreamDidReceiveResponse): Ditto.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::streamDidReceiveResponse):
        (WebKit::PluginControllerProxy::manualStreamDidReceiveResponse):
        Pass an empty string for suggested file name. No plug-in that runs in a separate process
        cares about it, so it's not sent to the plugin process.

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::streamDidReceiveResponse):
        (WebKit::NetscapePlugin::manualStreamDidReceiveResponse):
        * WebProcess/Plugins/Netscape/NetscapePlugin.h:
        Updated for new signatures.

        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::streamDidReceiveResponse):
        (WebKit::PluginProxy::manualStreamDidReceiveResponse):
        * WebProcess/Plugins/PluginProxy.h:
        Updated for new signatures.

        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::Stream::didReceiveResponse):
        (WebKit::PluginView::manualLoadDidReceiveResponse):
        Pass suggested file name to plug-in, in case the plug-in wants to save the file properly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChromium Mac editing test rebaseline.
rniwa@webkit.org [Wed, 26 Oct 2011 17:56:41 +0000 (17:56 +0000)]
Chromium Mac editing test rebaseline.

* platform/chromium-cg-mac-leopard/platform/mac/editing: Added.
* platform/chromium-cg-mac-leopard/platform/mac/editing/pasteboard: Added.
* platform/chromium-cg-mac-leopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium-mac-leopard/http/tests/security: Added.
* platform/chromium-mac-leopard/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium-mac-leopard/platform/mac: Added.
* platform/chromium-mac-leopard/platform/mac/editing: Added.
* platform/chromium-mac-leopard/platform/mac/editing/pasteboard: Added.
* platform/chromium-mac-leopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium-mac-snowleopard/http: Added.
* platform/chromium-mac-snowleopard/http/tests: Added.
* platform/chromium-mac-snowleopard/http/tests/security: Added.
* platform/chromium-mac-snowleopard/http/tests/security/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium-mac-snowleopard/platform: Added.
* platform/chromium-mac-snowleopard/platform/mac: Added.
* platform/chromium-mac-snowleopard/platform/mac/editing: Added.
* platform/chromium-mac-snowleopard/platform/mac/editing/pasteboard: Added.
* platform/chromium-mac-snowleopard/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove getOwnPropertySlotVirtual
mhahnenberg@apple.com [Wed, 26 Oct 2011 17:55:34 +0000 (17:55 +0000)]
Remove getOwnPropertySlotVirtual
https://bugs.webkit.org/show_bug.cgi?id=70741

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyDescriptor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertySlot):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
* runtime/Arguments.h:
* runtime/ArrayConstructor.cpp:
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
* runtime/DateConstructor.h:
* runtime/DatePrototype.cpp:
* runtime/DatePrototype.h:
(JSC::DatePrototype::create):
* runtime/ErrorPrototype.cpp:
* runtime/ErrorPrototype.h:
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlotByIndex):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::hasOwnProperty):
* runtime/JSObject.h:
(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSValue::get):
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlot):
* runtime/JSString.h:
* runtime/MathObject.cpp:
* runtime/MathObject.h:
(JSC::MathObject::create):
* runtime/NumberConstructor.cpp:
* runtime/NumberConstructor.h:
* runtime/NumberPrototype.cpp:
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::createStructure):
* runtime/RegExpObject.cpp:
* runtime/RegExpObject.h:
* runtime/RegExpPrototype.cpp:
* runtime/RegExpPrototype.h:
* runtime/StringConstructor.cpp:
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
* runtime/StringPrototype.h:

Source/JavaScriptGlue:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

* UserObjectImp.cpp:
* UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

* WebCore.exp.in:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::DialogHandler::returnValue):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::getSparseIndex):
(WebCore::CloneSerializer::getProperty):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
* bridge/qt/qt_runtime.cpp:
* bridge/qt/qt_runtime.h:
* bridge/runtime_array.cpp:
* bridge/runtime_array.h:
* bridge/runtime_method.cpp:
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
* bridge/runtime_object.h:

Source/WebKit2:

Removed all declarations and definitions of getOwnPropertySlotVirtual.
Also replaced all call sites to getOwnPropertyVirtualVirtual with a
corresponding lookup in the MethodTable.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-26 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 26 Oct 2011 17:54:00 +0000 (17:54 +0000)]
2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] Update NEWS and configure.ac for 1.7.1 release
        https://bugs.webkit.org/show_bug.cgi?id=70932

        Reviewed by Martin Robinson.

        * configure.ac: Bumped version number.

2011-10-26  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Update NEWS and configure.ac for 1.7.1 release
        https://bugs.webkit.org/show_bug.cgi?id=70932

        Reviewed by Martin Robinson.

        * NEWS: Added release notes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix typo. The expected results don't change.
ojan@chromium.org [Wed, 26 Oct 2011 17:53:52 +0000 (17:53 +0000)]
Fix typo. The expected results don't change.

* fast/writing-mode/borders.html:
* fast/writing-mode/margins.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-26 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 26 Oct 2011 17:45:31 +0000 (17:45 +0000)]
2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] [WK2] Add WebKit2 distcheck support
        https://bugs.webkit.org/show_bug.cgi?id=70933

        Reviewed by Martin Robinson.

        * GNUmakefile.am: Added WebKit2 compilation to the distcheck.
        * configure.ac: Removed WebKit2 doc generation for the moment.

2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] [WK2] Add WebKit2 distcheck support
        https://bugs.webkit.org/show_bug.cgi?id=70933

        Reviewed by Martin Robinson.

        * GNUmakefile.list.am: Add MemoryStatistics.h to the sources list.

2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] [WK2] Add WebKit2 distcheck support
        https://bugs.webkit.org/show_bug.cgi?id=70933

        Reviewed by Martin Robinson.

        * GNUmakefile.am: Add a bunch of missing files from API and
        sources, also include more files in the EXTRA_DIST.
        * UIProcess/API/gtk/docs/GNUmakefile.am: Add the version.xml to
        the cleaning section.

2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] [WK2] Add WebKit2 distcheck support
        https://bugs.webkit.org/show_bug.cgi?id=70933

        Reviewed by Martin Robinson.

        * WebKitTestRunner/GNUmakefile.am: Add missing files to the
        sources and EXTRA_DIST.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-26 Carlos Garcia Campos <cgarcia@igalia.com>
alex@webkit.org [Wed, 26 Oct 2011 17:40:08 +0000 (17:40 +0000)]
2011-10-26  Carlos Garcia Campos  <cgarcia@igalia.com>

        [GTK] Fix gtk-doc warnings and style issues in WebKit2 GTK+ API
        https://bugs.webkit.org/show_bug.cgi?id=70930

        Reviewed by Martin Robinson.

        * UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
        * UIProcess/API/gtk/WebKitSettings.cpp:
        (webkit_settings_class_init):
        * UIProcess/API/gtk/WebKitWebView.h:
        * UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-10-26 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 26 Oct 2011 17:35:41 +0000 (17:35 +0000)]
2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] Fix distcheck compilation
        https://bugs.webkit.org/show_bug.cgi?id=70921

        Add EventTargetFactory.in to the dist files, required after
        r98388.

        Reviewed by Martin Robinson.

        * GNUmakefile.am:

2011-10-26  Alejandro G. Castro  <alex@igalia.com>

        [GTK] Fix distcheck compilation
        https://bugs.webkit.org/show_bug.cgi?id=70921

        Add new files required by doc compilation to the clean process.

        Reviewed by Martin Robinson.

        * docs/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIncrease StringImpl Flag Bits for 8 bit Strings
msaboff@apple.com [Wed, 26 Oct 2011 17:12:13 +0000 (17:12 +0000)]
Increase StringImpl Flag Bits for 8 bit Strings
https://bugs.webkit.org/show_bug.cgi?id=70937

Increased the number of bits used for flags in StringImpl
from 6 to 8 bits. This frees up 2 flag bits that will be
used for 8-bit string support. Updated hash methods accordingly.
Changed hash value masking from the low bits to the high
bits.

Reviewed by Darin Adler.

Source/JavaScriptCore:

* create_hash_table:
* wtf/StringHasher.h:
(WTF::StringHasher::hash):
* wtf/text/StringImpl.h:

Source/WebCore:

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse the right contents scale factor for non-Mac plug-ins
andersca@apple.com [Wed, 26 Oct 2011 17:06:03 +0000 (17:06 +0000)]
Use the right contents scale factor for non-Mac plug-ins
https://bugs.webkit.org/show_bug.cgi?id=70939

Reviewed by Adam Roben.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::paint):
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r94887): Scrolling the HTML spec is more jerky now than it was (regression)
dglazkov@chromium.org [Wed, 26 Oct 2011 16:58:44 +0000 (16:58 +0000)]
REGRESSION (r94887): Scrolling the HTML spec is more jerky now than it was (regression)
https://bugs.webkit.org/show_bug.cgi?id=70857

Source/WebCore:

Revert r94887, because it regressed performance.

Rubber-stamped by Antti Koivisto.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::parentStylePreventsSharing):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkSelector):
* dom/Element.cpp:
(WebCore::Element::recalcStyle):
(WebCore::checkForSiblingStyleChanges):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::childrenAffectedByDirectAdjacentRules):
(WebCore::InheritedFlags::setChildrenAffectedByDirectAdjacentRules):

LayoutTests:

Rubber-stamped by Antti Koivisto.

* fast/css/adjacent-sibling-selector-expected.txt: Removed.
* fast/css/adjacent-sibling-selector.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
mitz@apple.com [Wed, 26 Oct 2011 16:30:50 +0000 (16:30 +0000)]
Build fix.

Reverted r98488, which caused the scripts’ status messages to be included in the generated
files.

* create_hash_table:
* create_jit_stubs:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98491 268f45cc-cd09-0410-ab3c-d52691b4dbfc