WebKit-https.git
9 years ago2010-05-03 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Mon, 3 May 2010 20:36:15 +0000 (20:36 +0000)]
2010-05-03  Yaar Schnitman  <yaar@chromium.org>

        Not Reviewed.

        Preparing for chromium webkit roll 58626:TBD: Rebaselines
        https://bugs.webkit.org/show_bug.cgi?id=38485

        * platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 3 May 2010 20:19:27 +0000 (20:19 +0000)]
2010-05-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Implement PageClient::isPageVisible on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=38483

        * UIProcess/PageClient.h:
        * UIProcess/win/WebView.cpp:
        (WebKit::WebView::isPageVisible):
        * UIProcess/win/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed a typo in ChangeLog.
ap@apple.com [Mon, 3 May 2010 20:12:35 +0000 (20:12 +0000)]
Fixed a typo in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Adam Barth.
ap@apple.com [Mon, 3 May 2010 20:04:16 +0000 (20:04 +0000)]
    Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=38285
        <rdar://problem/7903453> REGRESSION: Javascript command window.open does not work in empty tab

        Cannot be tested, because new windows created in DRT always have an opener, and thus inherit
        its security origin. Only new windows and tabs created by browser chrome had this problem.

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Moved updateSandboxFlags() call to
        the beginning, so that an initial document would get correct flags.

LayoutTests:
        These tests don't verify that this bug is fixed (that cannpt be tested automatically),
        but test closely related behavior that hasn't been covered before.

        * http/tests/security/resources/iframe-no-src.html: Added.
        * http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt: Added.
        * http/tests/security/sandbox-inherit-to-initial-document-2.html: Added.
        * http/tests/security/sandbox-inherit-to-initial-document-expected.txt: Added.
        * http/tests/security/sandbox-inherit-to-initial-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Mon, 3 May 2010 19:51:18 +0000 (19:51 +0000)]
2010-05-03  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Darin Adler.

        WebGL compile issue.
        Added ExceptionCode.h to JSWebGLArrayBufferConstructor.cpp, for some reason it was missing.
        https://bugs.webkit.org/show_bug.cgi?id=38453

        No new tests: compile fix.

        * bindings/js/JSWebGLArrayBufferConstructor.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Windows build.
andersca@apple.com [Mon, 3 May 2010 19:47:56 +0000 (19:47 +0000)]
Fix Windows build.

* Platform/CoreIPC/win/ConnectionWin.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
* Shared/win/UpdateChunk.cpp:
(WebKit::UpdateChunk::UpdateChunk):
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):
* Shared/win/UpdateChunk.h:
(WebKit::UpdateChunk::rect):
* UIProcess/DrawingAreaProxy.h:
* UIProcess/DrawingAreaProxyUpdateChunk.h:
* UIProcess/win/DrawingAreaProxyUpdateChunkWin.cpp:
(WebKit::DrawingAreaProxyUpdateChunk::drawUpdateChunkIntoBackingStore):
* WebProcess/WebPage/win/DrawingAreaUpdateChunkWin.cpp:
(WebKit::DrawingAreaUpdateChunk::paintIntoUpdateChunk):
* WebProcess/win/WebProcessMain.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Mon, 3 May 2010 19:11:26 +0000 (19:11 +0000)]
2010-05-03  Yaar Schnitman  <yaar@chromium.org>

        Not Reviewed.

        Preparing for Chromium WebKit roll 58626:TBD
        https://bugs.webkit.org/show_bug.cgi?id=38479

        * platform/chromium/test_expectations.txt: added missing expectation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Mon, 3 May 2010 18:51:03 +0000 (18:51 +0000)]
2010-05-03  Yaar Schnitman  <yaar@chromium.org>

        Not Reviewed.

        Added missing chromium baselines for svg text kerning
        https://bugs.webkit.org/show_bug.cgi?id=38476

        * platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
        * platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
        * platform/chromium-win/svg/text/kerning-expected.checksum:
        * platform/chromium-win/svg/text/kerning-expected.png:
        * platform/chromium-win/svg/text/text-hkern-expected.checksum: Added.
        * platform/chromium-win/svg/text/text-hkern-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 3 May 2010 18:49:49 +0000 (18:49 +0000)]
2010-05-03  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r58685.
        http://trac.webkit.org/changeset/58685
        https://bugs.webkit.org/show_bug.cgi?id=38461

        Broke a test on Gtk

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::updateStates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Yaar Schnitman <yaar@chromium.org>
yaar@chromium.org [Mon, 3 May 2010 18:23:59 +0000 (18:23 +0000)]
2010-05-03  Yaar Schnitman  <yaar@chromium.org>

        Not Reviewed.

        Preparing for chromium webkit roll 58626:TBD
        https://bugs.webkit.org/show_bug.cgi?id=38474

        * platform/chromium/test_expectations.txt: Added temporary expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 3 May 2010 18:19:50 +0000 (18:19 +0000)]
2010-04-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=38415
        Have the WKView notify the DrawingAreaProxy when its visibility changes.

        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::isPageVisible):
        * UIProcess/API/mac/WKView.mm:
        (-[WKView viewDidMoveToWindow]):
        (-[WKView viewDidHide]):
        (-[WKView viewDidUnhide]):
        * UIProcess/DrawingAreaProxy.h:
        * UIProcess/DrawingAreaProxyUpdateChunk.cpp:
        (WebKit::DrawingAreaProxyUpdateChunk::DrawingAreaProxyUpdateChunk):
        (WebKit::DrawingAreaProxyUpdateChunk::didChangeVisibility):
        * UIProcess/DrawingAreaProxyUpdateChunk.h:
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::isVisible):
        * UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse HTML5 number parsing in HTMLProgressElement
yael.aharon@nokia.com [Mon, 3 May 2010 18:16:21 +0000 (18:16 +0000)]
Use HTML5 number parsing in HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=38434

Reviewed by Darin Adler.

WebCore:

Use parseToDoubleForNumberType instead of toDouble.
Throw an exception when the number is NaN or Infinity.

* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::value):
(WebCore::HTMLProgressElement::setValue):
(WebCore::HTMLProgressElement::max):
(WebCore::HTMLProgressElement::setMax):
* html/HTMLProgressElement.h:
* html/HTMLProgressElement.idl:

LayoutTests:

* fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js:
* fast/dom/HTMLProgressElement/set-progress-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Jens Alfke <snej@chromium.org>
eric@webkit.org [Mon, 3 May 2010 18:12:40 +0000 (18:12 +0000)]
2010-05-03  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=38397

        No tests (functionality is exposed only through native WebKit API.)

        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::prepareSubmit):  Call frame loader's dispatchWillSendSubmitEvent
        * loader/EmptyClients.h:
        * loader/FrameLoaderClient.h:
        (WebCore::FrameLoaderClient::dispatchWillSendSubmitEvent):  New empty method
2010-05-03  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=38397

        No tests (functionality is exposed only through native WebKit API.)

        * efl/WebCoreSupport/FrameLoaderClientEfl.h:
        (WebCore::FrameLoaderClientEfl::dispatchWillSendSubmitEvent):
2010-05-03  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=38397

        No tests (functionality is exposed only through native WebKit API.)

        * public/WebFrameClient.h:
        (WebKit::WebFrameClient::willSendSubmitEvent): New empty method
        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchWillSendSubmitEvent): Delegate to client
        * src/FrameLoaderClientImpl.h:
2010-05-03  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=38397

        No tests (functionality is exposed only through native WebKit API.)

        * WebCoreSupport/FrameLoaderClientGtk.h:
        (WebKit::FrameLoaderClient::dispatchWillSendSubmitEvent):
2010-05-03  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=38397

        No tests (functionality is exposed only through native WebKit API.)

        * WebCoreSupport/FrameLoaderClientHaiku.h:
        (WebCore::FrameLoaderClientHaiku::dispatchWillSendSubmitEvent):
2010-05-03  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=38397

        No tests (functionality is exposed only through native WebKit API.)

        * WebCoreSupport/WebFrameLoaderClient.h:
        (WebFrameLoaderClient::dispatchWillSendSubmitEvent):
2010-05-03  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=38397

        No tests (functionality is exposed only through native WebKit API.)

        * WebCoreSupport/FrameLoaderClientQt.h:
        (WebCore::FrameLoaderClientQt::dispatchWillSendSubmitEvent):
2010-05-03  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=38397

        No tests (functionality is exposed only through native WebKit API.)

        * WebFrame.h:
2010-05-03  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=38397

        No tests (functionality is exposed only through native WebKit API.)

        * WebKitSupport/FrameLoaderClientWx.h:
        (WebCore::FrameLoaderClientWx::dispatchWillSendSubmitEvent):
2010-05-03  Jens Alfke  <snej@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
        https://bugs.webkit.org/show_bug.cgi?id=38397

        No tests (functionality is exposed only through native WebKit API.)

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
        (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 3 May 2010 17:58:56 +0000 (17:58 +0000)]
2010-05-03  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GStreamer] forgotten call to durationChanged in updateStates()
        https://bugs.webkit.org/show_bug.cgi?id=38461

        Notify MediaPlayer if duration is known after playback started.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::updateStates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38471
weinig@apple.com [Mon, 3 May 2010 17:28:17 +0000 (17:28 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38471
Add generic callback mechanism

Reviewed by Anders Carlsson.

Added GenericCallback class replacing RenderTreeExternalRepresentationCallback
and ScriptReturnValueCallback.

Also,
- Standardize C API callbacks to take the context last.
- Standardize C API callbacks to not have the _f suffix (now the block
  variants have a _b suffix).
- Re-write toWK and toRef methods as a set of template functions using
  the generic API->implementation mapping information.

* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageRunJavaScriptInMainFrame):
(callRunJavaScriptBlockAndRelease):
(disposeRunJavaScriptBlock):
(WKPageRunJavaScriptInMainFrame_b):
(WKPageRenderTreeExternalRepresentation):
(WKPageRenderTreeExternalRepresentation_b):
* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WKPagePrivate.h:
* UIProcess/GenericCallback.h: Added.
(WebKit::GenericCallback::create):
(WebKit::GenericCallback::~GenericCallback):
(WebKit::GenericCallback::performCallbackWithReturnValue):
(WebKit::GenericCallback::invalidate):
(WebKit::GenericCallback::callbackID):
(WebKit::GenericCallback::generateCallbackID):
(WebKit::GenericCallback::GenericCallback):
* UIProcess/RenderTreeExternalRepresentationCallback.cpp: Removed.
* UIProcess/RenderTreeExternalRepresentationCallback.h: Removed.
* UIProcess/ScriptReturnValueCallback.cpp: Removed.
* UIProcess/ScriptReturnValueCallback.h: Removed.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didRunJavaScriptInMainFrame):
(WebKit::WebPageProxy::didGetRenderTreeExternalRepresentation):
* UIProcess/WebPageProxy.h:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove URLCore top-level directory. The diff wasn't clear where this folder was...
abarth@webkit.org [Mon, 3 May 2010 17:25:36 +0000 (17:25 +0000)]
Remove URLCore top-level directory.  The diff wasn't clear where this folder was going and Darin Adler would prefer that we not put this code in a top-level directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Ryuan Choi <ryuan.choi@gmail.com>
eric@webkit.org [Mon, 3 May 2010 17:24:23 +0000 (17:24 +0000)]
2010-05-03  Ryuan Choi  <ryuan.choi@gmail.com>

        Reviewed by Darin Adler.

        fixing build break due to clearWatch() when Geolocation feature is
        disabled.

        https://bugs.webkit.org/show_bug.cgi?id=38091

        no test because this is a build fix only

        * page/Geolocation.cpp:
        (WebCore::Geolocation::clearWatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Chris Jerdonek <cjerdonek@webkit.org>
eric@webkit.org [Mon, 3 May 2010 17:09:47 +0000 (17:09 +0000)]
2010-05-03  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Daniel Bates.

        Added a parseGitDiffHeader() subroutine to VCSUtils.pm that
        parses any changes to the executable bit in a Git diff.

        https://bugs.webkit.org/show_bug.cgi?id=38425

        This revision is more preparation towards adding "executable bit"
        support to svn-apply and svn-unapply.  No code is going "live" in
        this change except for the new unit tests in test-webkitperl.

        * Scripts/VCSUtils.pm:
          - Added isExecutable() to determine whether a file mode has the
            executable bit set or not.
          - Added parseGitDiffHeader() to parse the header of a Git diff.

        * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Added.
          - Added unit tests for parseGitDiffHeader().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd empty folder to house URL parser
abarth@webkit.org [Mon, 3 May 2010 17:00:28 +0000 (17:00 +0000)]
Add empty folder to house URL parser
https://bugs.webkit.org/show_bug.cgi?id=38470

Reviewed by Darin Adler.

Add URLCore directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Stephan Aßmus <superstippi@gmx.de>
eric@webkit.org [Mon, 3 May 2010 16:56:51 +0000 (16:56 +0000)]
2010-05-03  Stephan Aßmus  <superstippi@gmx.de>

        Reviewed by Holger Freyther.

        [Gtk] Fix leaking the FontPlatformData instance used to create the the
        small caps font data.
        https://bugs.webkit.org/show_bug.cgi?id=37500

        No new tests needed.

        * platform/graphics/gtk/SimpleFontDataPango.cpp:
        (WebCore::SimpleFontData::smallCapsFontData):
            - Use a stack allocated FontPlatformData instead of a heap allocated
              one that is never freed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
eric@webkit.org [Mon, 3 May 2010 16:37:05 +0000 (16:37 +0000)]
2010-05-03  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] GraphicsLayer: support webGL
        https://bugs.webkit.org/show_bug.cgi?id=35388

        Added support GraphicsContext3D to GraphicsLayer.
        Added paint method to GraphicsContext3D for Qt platform that
        uses drawTexture() when QGLWidget is used as viewport of
        QGraphicsWebView.
        Fine-tuned texture and handling and image to texture conversion to
        work also when drawTexture() blitting is used.

        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3D::beginPaint):
        (WebCore::GraphicsContext3D::paint):
        (WebCore::GraphicsContext3D::texImage2D):
        (WebCore::GraphicsContext3D::texSubImage2D):
        (WebCore::GraphicsContext3D::getImageData):
        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::):
        (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
        (WebCore::GraphicsLayerQtImpl::paint):
        (WebCore::GraphicsLayerQtImpl::flushChanges):
        (WebCore::GraphicsLayerQt::setContentsToGraphicsContext3D):
        (WebCore::GraphicsLayerQt::setGraphicsContext3DNeedsDisplay):
        * platform/graphics/qt/GraphicsLayerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 3 May 2010 16:20:11 +0000 (16:20 +0000)]
2010-05-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Add some more Chromium-specific files to gitignore
        https://bugs.webkit.org/show_bug.cgi?id=38469

        These files are generated as part of the update-webkit --chromium
        script.

        * .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Qt specific expected files added after r58675.
ossy@webkit.org [Mon, 3 May 2010 15:59:24 +0000 (15:59 +0000)]
Unreviewed. Qt specific expected files added after r58675.

* platform/qt/editing/pasteboard/4944770-2-expected.txt: Added.
* platform/qt/editing/pasteboard/5028447-expected.txt: Added.
* platform/qt/editing/pasteboard/5089327-expected.txt: Added.
* platform/qt/editing/pasteboard/5601583-1-expected.txt: Added.
* platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
* platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
* platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
* platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
* platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
* platform/qt/editing/pasteboard/paste-text-013-expected.txt: Added.
* platform/qt/editing/pasteboard/select-element-1-expected.txt: Added.
* platform/qt/editing/pasteboard/testcase-9507-expected.txt: Added.
* platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
* platform/qt/editing/pasteboard/unrendered-br-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Csaba Osztrogonác <ossy@webkit.org>
robert@webkit.org [Mon, 3 May 2010 15:39:54 +0000 (15:39 +0000)]
2010-05-03  Csaba Osztrogonác  <ossy@webkit.org>

        Unreviewed. Qt specific expected files added and updated.

        [Qt] Unskip editing/pasteboard tests that fail due to 'x,y' differences
        https://bugs.webkit.org/show_bug.cgi?id=38435

        * platform/qt/editing/pasteboard/3976872-expected.txt:
        * platform/qt/editing/pasteboard/4076267-3-expected.txt:
        * platform/qt/editing/pasteboard/4242293-expected.txt:
        * platform/qt/editing/pasteboard/4631972-expected.txt:
        * platform/qt/editing/pasteboard/4641033-expected.txt:
        * platform/qt/editing/pasteboard/4700297-expected.txt:
        * platform/qt/editing/pasteboard/4806874-expected.txt:
        * platform/qt/editing/pasteboard/4840662-expected.txt:
        * platform/qt/editing/pasteboard/4944770-1-expected.txt:
        * platform/qt/editing/pasteboard/4944770-2-expected.txt: Added.
        * platform/qt/editing/pasteboard/4989774-expected.txt:
        * platform/qt/editing/pasteboard/5006779-expected.txt:
        * platform/qt/editing/pasteboard/5027857-expected.txt:
        * platform/qt/editing/pasteboard/5028447-expected.txt: Added.
        * platform/qt/editing/pasteboard/5032095-expected.txt:
        * platform/qt/editing/pasteboard/5065605-expected.txt:
        * platform/qt/editing/pasteboard/5071074-2-expected.txt:
        * platform/qt/editing/pasteboard/5071074-expected.txt:
        * platform/qt/editing/pasteboard/5075944-2-expected.txt:
        * platform/qt/editing/pasteboard/5075944-3-expected.txt:
        * platform/qt/editing/pasteboard/5075944-expected.txt:
        * platform/qt/editing/pasteboard/5089327-expected.txt: Added.
        * platform/qt/editing/pasteboard/5134759-expected.txt:
        * platform/qt/editing/pasteboard/5156401-1-expected.txt:
        * platform/qt/editing/pasteboard/5245519-expected.txt:
        * platform/qt/editing/pasteboard/5247341-expected.txt:
        * platform/qt/editing/pasteboard/5368833-expected.txt:
        * platform/qt/editing/pasteboard/5478250-expected.txt:
        * platform/qt/editing/pasteboard/5483567-expected.txt:
        * platform/qt/editing/pasteboard/5601583-1-expected.txt: Added.
        * platform/qt/editing/pasteboard/5780697-2-expected.txt:
        * platform/qt/editing/pasteboard/7955-expected.txt:
        * platform/qt/editing/pasteboard/8145-1-expected.txt:
        * platform/qt/editing/pasteboard/8145-2-expected.txt:
        * platform/qt/editing/pasteboard/8145-3-expected.txt:
        * platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
        * platform/qt/editing/pasteboard/cut-text-001-expected.txt:
        * platform/qt/editing/pasteboard/displaced-generic-placeholder-expected.txt:
        * platform/qt/editing/pasteboard/displaced-placeholder-expected.txt:
        * platform/qt/editing/pasteboard/display-block-on-spans-expected.txt:
        * platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
        * platform/qt/editing/pasteboard/innerText-inline-table-expected.txt:
        * platform/qt/editing/pasteboard/interchange-newline-1-expected.txt:
        * platform/qt/editing/pasteboard/interchange-newline-3-expected.txt:
        * platform/qt/editing/pasteboard/interchange-newline-4-expected.txt:
        * platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
        * platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
        * platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-1-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-2-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-3-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-4-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-5-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-blockquote-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-borders-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-list-expected.txt:
        * platform/qt/editing/pasteboard/merge-end-table-expected.txt:
        * platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
        * platform/qt/editing/pasteboard/merge-start-list-expected.txt:
        * platform/qt/editing/pasteboard/paste-4035648-fix-expected.txt:
        * platform/qt/editing/pasteboard/paste-4038267-fix-expected.txt:
        * platform/qt/editing/pasteboard/paste-4039777-fix-expected.txt:
        * platform/qt/editing/pasteboard/paste-blockquote-1-expected.txt:
        * platform/qt/editing/pasteboard/paste-blockquote-2-expected.txt:
        * platform/qt/editing/pasteboard/paste-blockquote-3-expected.txt:
        * platform/qt/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
        * platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt: Added.
        * platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt: Added.
        * platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt: Added.
        * platform/qt/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt: Added.
        * platform/qt/editing/pasteboard/paste-line-endings-001-expected.txt:
        * platform/qt/editing/pasteboard/paste-line-endings-002-expected.txt:
        * platform/qt/editing/pasteboard/paste-line-endings-003-expected.txt:
        * platform/qt/editing/pasteboard/paste-line-endings-004-expected.txt:
        * platform/qt/editing/pasteboard/paste-line-endings-005-expected.txt:
        * platform/qt/editing/pasteboard/paste-line-endings-006-expected.txt:
        * platform/qt/editing/pasteboard/paste-line-endings-007-expected.txt:
        * platform/qt/editing/pasteboard/paste-line-endings-008-expected.txt:
        * platform/qt/editing/pasteboard/paste-line-endings-009-expected.txt:
        * platform/qt/editing/pasteboard/paste-line-endings-010-expected.txt:
        * platform/qt/editing/pasteboard/paste-list-001-expected.txt:
        * platform/qt/editing/pasteboard/paste-match-style-001-expected.txt:
        * platform/qt/editing/pasteboard/paste-match-style-002-expected.txt:
        * platform/qt/editing/pasteboard/paste-pre-001-expected.txt:
        * platform/qt/editing/pasteboard/paste-pre-002-expected.txt:
        * platform/qt/editing/pasteboard/paste-table-001-expected.txt:
        * platform/qt/editing/pasteboard/paste-table-003-expected.txt:
        * platform/qt/editing/pasteboard/paste-table-cells-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-002-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-003-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-004-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-005-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-006-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-007-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-009-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-010-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-011-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-012-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-013-expected.txt: Added.
        * platform/qt/editing/pasteboard/paste-text-014-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-015-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-016-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-017-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-018-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-019-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
        * platform/qt/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
        * platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt:
        * platform/qt/editing/pasteboard/pasting-object-expected.txt:
        * platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt:
        * platform/qt/editing/pasteboard/quirks-mode-br-1-expected.txt:
        * platform/qt/editing/pasteboard/select-element-1-expected.txt: Added.
        * platform/qt/editing/pasteboard/styled-element-markup-expected.txt:
        * platform/qt/editing/pasteboard/testcase-9507-expected.txt: Added.
        * platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
        * platform/qt/editing/pasteboard/unrendered-br-expected.txt: Added.

2010-05-03  Robert Hogan  <robert@webkit.org>

        Reviewed by Eric Seidel.

        [Qt] Unskip editing/pasteboard tests that fail due to 'x,y' differences

        https://bugs.webkit.org/show_bug.cgi?id=38435

        Unskip a large number of editing/pasteboard tests that fail only due
        to rendertree differences in the height/width of rendered text.

        Reduce the skipped editing/pasteboard tests to those that fail for
        a good reason and add some initial commentary on each.

        Unskip:

          editing/pasteboard/3976872.html
          editing/pasteboard/4076267-3.html
          editing/pasteboard/4242293.html
          editing/pasteboard/4631972.html
          editing/pasteboard/4641033.html
          editing/pasteboard/4700297.html
          editing/pasteboard/4840662.html
          editing/pasteboard/4944770-1.html
          editing/pasteboard/4944770-2.html
          editing/pasteboard/4989774.html
          editing/pasteboard/5006779.html
          editing/pasteboard/5027857.html
          editing/pasteboard/5028447.html
          editing/pasteboard/5032095.html
          editing/pasteboard/5065605.html
          editing/pasteboard/5071074-2.html
          editing/pasteboard/5071074.html
          editing/pasteboard/5075944-2.html
          editing/pasteboard/5075944-3.html
          editing/pasteboard/5075944.html
          editing/pasteboard/5089327.html
          editing/pasteboard/5134759.html
          editing/pasteboard/5156401-1.html
          editing/pasteboard/5245519.html
          editing/pasteboard/5247341.html
          editing/pasteboard/5368833.html
          editing/pasteboard/5478250.html
          editing/pasteboard/5483567.html
          editing/pasteboard/5601583-1.html
          editing/pasteboard/5780697-2.html
          editing/pasteboard/7955.html
          editing/pasteboard/8145-1.html
          editing/pasteboard/8145-2.html
          editing/pasteboard/8145-3.html
          editing/pasteboard/copy-paste-bidi.html
          editing/pasteboard/cut-text-001.html
          editing/pasteboard/displaced-generic-placeholder.html
          editing/pasteboard/displaced-placeholder.html
          editing/pasteboard/display-block-on-spans.html
          editing/pasteboard/emacs-cntl-y-001.html
          editing/pasteboard/innerText-inline-table.html
          editing/pasteboard/interchange-newline-1.html
          editing/pasteboard/interchange-newline-3.html
          editing/pasteboard/interchange-newline-4.html
          editing/pasteboard/merge-after-delete-1.html
          editing/pasteboard/merge-after-delete-2.html
          editing/pasteboard/merge-after-delete.html
          editing/pasteboard/merge-end-1.html
          editing/pasteboard/merge-end-2.html
          editing/pasteboard/merge-end-3.html
          editing/pasteboard/merge-end-4.html
          editing/pasteboard/merge-end-5.html
          editing/pasteboard/merge-end-blockquote.html
          editing/pasteboard/merge-end-borders.html
          editing/pasteboard/merge-end-list.html
          editing/pasteboard/merge-end-table.html
          editing/pasteboard/merge-start-blockquote.html
          editing/pasteboard/merge-start-list.html
          editing/pasteboard/paste-4035648-fix.html
          editing/pasteboard/paste-4038267-fix.html
          editing/pasteboard/paste-4039777-fix.html
          editing/pasteboard/paste-blockquote-1.html
          editing/pasteboard/paste-blockquote-2.html
          editing/pasteboard/paste-blockquote-3.html
          editing/pasteboard/paste-blockquote-after-blockquote.html
          editing/pasteboard/paste-blockquote-into-blockquote-2.html
          editing/pasteboard/paste-blockquote-into-blockquote-3.html
          editing/pasteboard/paste-blockquote-into-blockquote-4.html
          editing/pasteboard/paste-blockquote-into-blockquote.html
          editing/pasteboard/paste-line-endings-001.html
          editing/pasteboard/paste-line-endings-002.html
          editing/pasteboard/paste-line-endings-003.html
          editing/pasteboard/paste-line-endings-004.html
          editing/pasteboard/paste-line-endings-005.html
          editing/pasteboard/paste-line-endings-006.html
          editing/pasteboard/paste-line-endings-007.html
          editing/pasteboard/paste-line-endings-008.html
          editing/pasteboard/paste-line-endings-009.html
          editing/pasteboard/paste-line-endings-010.html
          editing/pasteboard/paste-list-001.html
          editing/pasteboard/paste-match-style-001.html
          editing/pasteboard/paste-match-style-002.html
          editing/pasteboard/paste-pre-001.html
          editing/pasteboard/paste-pre-002.html
          editing/pasteboard/paste-table-001.html
          editing/pasteboard/paste-table-003.html
          editing/pasteboard/paste-table-cells.html
          editing/pasteboard/paste-text-002.html
          editing/pasteboard/paste-text-003.html
          editing/pasteboard/paste-text-004.html
          editing/pasteboard/paste-text-005.html
          editing/pasteboard/paste-text-006.html
          editing/pasteboard/paste-text-007.html
          editing/pasteboard/paste-text-009.html
          editing/pasteboard/paste-text-010.html
          editing/pasteboard/paste-text-011.html
          editing/pasteboard/paste-text-012.html
          editing/pasteboard/paste-text-013.html
          editing/pasteboard/paste-text-014.html
          editing/pasteboard/paste-text-015.html
          editing/pasteboard/paste-text-016.html
          editing/pasteboard/paste-text-017.html
          editing/pasteboard/paste-text-018.html
          editing/pasteboard/paste-text-019.html
          editing/pasteboard/paste-text-at-tabspan-002.html
          editing/pasteboard/paste-text-at-tabspan-003.html
          editing/pasteboard/paste-unrendered-select.html
          editing/pasteboard/pasting-object.html
          editing/pasteboard/prevent-block-nesting-01.html
          editing/pasteboard/quirks-mode-br-1.html
          editing/pasteboard/select-element-1.html
          editing/pasteboard/styled-element-markup.html
          editing/pasteboard/testcase-9507.html
          editing/pasteboard/undoable-fragment-removes.html
          editing/pasteboard/unrendered-br.html

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 3 May 2010 15:18:31 +0000 (15:18 +0000)]
2010-05-03  Philippe Normand  <pnormand@igalia.com>

        Rubber-stamped by Csaba Osztrogonac.

        media/video-duration-known-after-eos.html failing
        https://bugs.webkit.org/show_bug.cgi?id=38466

        * platform/qt/Skipped: Skipping failing test. A lot of media tests
        are already skipped on this platform. Tor Arne said he'd look at
        them, at some point.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix qtlibraryinfix not to contain space
hausmann@webkit.org [Mon, 3 May 2010 14:13:55 +0000 (14:13 +0000)]
[Qt] Fix qtlibraryinfix not to contain space

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-05-03
Reviewed by Simon Hausmann.

List catenation with += adds whitespace cutting the infix
from the final target.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix rendering of <button> elements on Mac OS X
vestbo@webkit.org [Mon, 3 May 2010 14:10:11 +0000 (14:10 +0000)]
[Qt] Fix rendering of <button> elements on Mac OS X

Reviewed by Simon Hausmann.

The <button> element has ButtonPart appearance, not PushButton part,
so we have to include ButtonPart when we decide if we should draw the
button as raised on Mac OS X.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 3 May 2010 14:09:35 +0000 (14:09 +0000)]
2010-04-30  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Seidel.

        [GStreamer] endless loop after playback ended
        https://bugs.webkit.org/show_bug.cgi?id=38384

        At playback end ensure duration() will return a valid duration if
        we managed to calculate it based on current position.

        Test: media/video-duration-known-after-eos.html

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::didEnd):

2010-04-30  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Seidel.

        [GStreamer] endless loop after playback ended
        https://bugs.webkit.org/show_bug.cgi?id=38384

        * media/video-duration-known-after-eos-expected.txt: Added.
        * media/video-duration-known-after-eos.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Prune dead code in QWebPage
vestbo@webkit.org [Mon, 3 May 2010 12:00:23 +0000 (12:00 +0000)]
[Qt] Prune dead code in QWebPage

Reviewed by Simon Hausmann.

* Api/qwebpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix build break on Mac OS X
vestbo@webkit.org [Mon, 3 May 2010 11:17:10 +0000 (11:17 +0000)]
[Qt] Fix build break on Mac OS X

* plugins/mac/PluginPackageMac.cpp: Use correct type
* WebCore.pro: Remove duplicate symbol, we now have a Qt implementation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-03 Daniel Bates <dbates@rim.com>
eric@webkit.org [Mon, 3 May 2010 11:00:47 +0000 (11:00 +0000)]
2010-05-03  Daniel Bates  <dbates@rim.com>

        Reviewed by Chris Jerdonek.

        https://bugs.webkit.org/show_bug.cgi?id=38447

        Refactor the unit tests in VCSUtils_unittest/parseDiff.pl to use
        Test::More::is_deeply like we do in VCSUtils_unittest/parseDiffHeader.pl.

        * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix library infix usage when compiling inside of Qt
hausmann@webkit.org [Mon, 3 May 2010 07:12:57 +0000 (07:12 +0000)]
[Qt] Fix library infix usage when compiling inside of Qt

Patch by Thomas Zander <t.zander@nokia.com> on 2010-05-03
Reviewed by Simon Hausmann.

Don't apply the infix when building inside Qt, as that's done through the
inclusion of qbase.pri.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
cjerdonek@webkit.org [Mon, 3 May 2010 05:40:53 +0000 (05:40 +0000)]
Unreviewed.

Corrected a file path in the ChangeLog entry for r58663 (bug 38319) below.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother case of <rdar://problem/7552959> REGRESSION: Infinite recursion in Position...
mitz@apple.com [Mon, 3 May 2010 04:25:27 +0000 (04:25 +0000)]
Another case of <rdar://problem/7552959> REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()
https://bugs.webkit.org/show_bug.cgi?id=38445

Reviewed by Simon Fraser.

WebCore:

Test: editing/selection/mixed-editability-11.html

* dom/Position.cpp:
(WebCore::downstreamIgnoringEditingBoundaries): Added. Returns the furthest visually equivalent
position downstream, crossing any editability boundaries.
(WebCore::upstreamIgnoringEditingBoundaries): Similarly for upstream.
(WebCore::Position::getInlineBoxAndOffset): Changed the logic for finding an inline box for positions
whose node is a block flow. Instead of traversing the DOM, advance downstream or upstream as far as
possible, crossing any editability boudaries. Infinite recursion is avoided by advancing all the way
and checking that the new position is different from the starting position. Also replaced the specific
test for buttons with the generic and more comprehensive canHaveChildrenForEditing().

LayoutTests:

* editing/selection/mixed-editability-11-expected.txt: Added.
* editing/selection/mixed-editability-11.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Geoff Levand <geoff.levand@am.sony.com>
eric@webkit.org [Mon, 3 May 2010 02:21:35 +0000 (02:21 +0000)]
2010-05-02  Geoff Levand  <geoff.levand@am.sony.com>

        Reviewed by Eric Seidel.

        [GTK] Fix out of source build failure
        https://bugs.webkit.org/show_bug.cgi?id=38051

        Add a preprocessor include path for generated GTK header files.
        Fixes build errors like these when building GTK out of source:

          webkit.h: error: webkit/webkitversion.h: No such file or directory

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Chris Jerdonek <cjerdonek@webkit.org>
eric@webkit.org [Mon, 3 May 2010 01:49:27 +0000 (01:49 +0000)]
2010-05-02  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=38319

        * Scripts/VCSUtils.pm:
          - In parseDiffHeader()--
            - Added an "scmFormat" hash key to the return value to represent
              whether the diff is Git or SVN formatted.
            - Adjusted the code so the value of "copiedFromPath" will
              be undef rather than "does not exist" if the file was not
              copied.

        * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
          - Added a FIXME to refactor these unit tests to use is_deeply().

        * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
          - Updated the unit tests to test the "scmFormat" value.
          - Simplified the unit tests by refactoring them to use is_deeply().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>
eric@webkit.org [Sun, 2 May 2010 22:18:56 +0000 (22:18 +0000)]
2010-05-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix compilation with QT_NO_BEARERMANAGEMENT
        https://bugs.webkit.org/show_bug.cgi?id=38324

        * platform/network/NetworkStateNotifier.h:
        * platform/network/qt/NetworkStateNotifierQt.cpp:
2010-05-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix compilation with QT_NO_BEARERMANAGEMENT
        https://bugs.webkit.org/show_bug.cgi?id=38324

        * Api/qwebsettings.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] QtWebKit versioning added
hausmann@webkit.org [Sun, 2 May 2010 21:48:07 +0000 (21:48 +0000)]
[Qt] QtWebKit versioning added
https://bugs.webkit.org/show_bug.cgi?id=37207

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-04-29
Reviewed by Simon Hausmann.

QtWebkit releases separated from Qt release cycle.

WebCore:

* WebCore.pro:

WebKit/qt:

* qtwebkit_version.pri: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Joseph Pecoraro <joepeck@webkit.org>
eric@webkit.org [Sun, 2 May 2010 21:42:05 +0000 (21:42 +0000)]
2010-05-02  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Old Style trimWhitespace() should be trim()
        https://bugs.webkit.org/show_bug.cgi?id=38441

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Tasuku Suzuki <tasuku.suzuki@nokia.com>
eric@webkit.org [Sun, 2 May 2010 21:31:27 +0000 (21:31 +0000)]
2010-05-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix compilation with QT_NO_LINEEDIT
        https://bugs.webkit.org/show_bug.cgi?id=38324

        * platform/qt/RenderThemeQt.cpp:
        (WebCore::RenderThemeQt::~RenderThemeQt):
        (WebCore::RenderThemeQt::findFrameLineWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 2 May 2010 20:18:48 +0000 (20:18 +0000)]
2010-05-02  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: Touch inspector controller to kick windows tests.

        * inspector/InspectorController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sun, 2 May 2010 18:32:02 +0000 (18:32 +0000)]
2010-05-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: IMG nodes are being added to the DOM tree late, sometimes hiding the revealed element.

        https://bugs.webkit.org/show_bug.cgi?id=38432

        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype._onmousemove):
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.setTooltip):
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
        (WebInspector.ElementsTreeElement.prototype.updateTitle):
        (WebInspector.ElementsTreeElement.prototype._attributeHTML):
        ():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 2 May 2010 16:30:24 +0000 (16:30 +0000)]
2010-05-02  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG hkern implementation incomplete
        https://bugs.webkit.org/show_bug.cgi?id=38407

        Test: svg/text/text-hkern.svg

        The current SVG hkern implementation is incomplete and partly wrong. We pass the ACID3 test
        by accident.
        The new implementation supports all glyph and unicode combinations that are allowed by the Spec
        and fixes various of bugs. The parser moved from SVGFontElement to the general parsing code in
        SVGParserUtilities.
        Some clean-up makes the code more readable and reuseable for the upcoming vkern implementation.
        hkern support for text on path is missing and will be added by a following patch.
        Unicode strings of hkern elements are just parsed once and not on every glyph again anymore.

        * rendering/SVGRootInlineBox.cpp:
        (WebCore::calculateCSSKerning):
        (WebCore::applySVGKerning):
        (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
        * svg/SVGFontElement.cpp:
        (WebCore::stringMatchesUnicodeRange):
        (WebCore::stringMatchesGlyphName):
        (WebCore::matches):
        (WebCore::SVGFontElement::getHorizontalKerningPairForStringsAndGlyphs):
        * svg/SVGFontElement.h:
        * svg/SVGHKernElement.cpp:
        (WebCore::SVGHKernElement::buildHorizontalKerningPair):
        * svg/SVGHKernElement.h:
        * svg/SVGParserUtilities.cpp:
        (WebCore::parseGlyphName):
        (WebCore::parseUnicodeRange):
        (WebCore::parseKerningUnicodeString):
        * svg/SVGParserUtilities.h:
2010-05-02  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG hkern implementation incomplete
        https://bugs.webkit.org/show_bug.cgi?id=38407

        The hkern patch fixes some very old bugs in some tests of the official
        SVG Test suite. Added a new test to check correct behavior on different
        use cases of textin SVG.

        * platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
        * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
        * platform/mac/svg/text/kerning-expected.checksum:
        * platform/mac/svg/text/kerning-expected.png:
        * platform/mac/svg/text/text-hkern-expected.checksum: Added.
        * platform/mac/svg/text/text-hkern-expected.png: Added.
        * platform/mac/svg/text/text-hkern-expected.txt: Added.
        * svg/text/text-hkern.svg: Added.
2010-05-02  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG hkern implementation incomplete
        https://bugs.webkit.org/show_bug.cgi?id=38407

        We support hkern now. Mention this in the SVG status page.

        * projects/svg/status.xml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Sun, 2 May 2010 15:27:53 +0000 (15:27 +0000)]
2010-05-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: debugger shortcuts are processed twice if source frame has focus.

        https://bugs.webkit.org/show_bug.cgi?id=38431

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype._createViewerIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Build fix on Japanese Windows.
tkent@chromium.org [Sun, 2 May 2010 15:03:12 +0000 (15:03 +0000)]
Unreviewed. Build fix on Japanese Windows.
Replace a non-ASCII character in a comment with an ASCII character.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Kartikaya Gupta <kagupta@rim.com>
eric@webkit.org [Sun, 2 May 2010 12:47:07 +0000 (12:47 +0000)]
2010-05-02  Kartikaya Gupta  <kagupta@rim.com>

        Reviewed by George Staikos.

        When running the IDL file through the preprocessor, wait for the preprocessor subcommand to fully terminate before continuing. Without this, if multiple IDL files are parsed in a tight loop, the code dies after 64 IDL files because it exhausts the available system resources.

        https://bugs.webkit.org/show_bug.cgi?id=37888

        No new tests. None needed.

        * bindings/scripts/IDLParser.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sun, 2 May 2010 12:26:39 +0000 (12:26 +0000)]
2010-05-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] Enable JIT for QtWebKit on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=38339

        JIT on Symbian has been stable for quite some time, it
        is time to turn it on by default.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
eric@webkit.org [Sun, 2 May 2010 12:05:20 +0000 (12:05 +0000)]
2010-05-02  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] Build error in GraphicsContext3DQt.cpp
        https://bugs.webkit.org/show_bug.cgi?id=38382

        Removed duplicate implementation of isGLES2Compliant from
        GraphicsContext3DQt.cpp. Removed deprecated API stuff for
        texImage2D/texSubImage2D.
        * platform/graphics/qt/GraphicsContext3DQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Garret Kelly <gdk@chromium.org>
eric@webkit.org [Sun, 2 May 2010 11:54:17 +0000 (11:54 +0000)]
2010-05-02  Garret Kelly  <gdk@chromium.org>

        Reviewed by David Levin.

        Make the Touch RuntimeEnabledFeature disabled by default.
        https://bugs.webkit.org/show_bug.cgi?id=38392

        * bindings/generic/RuntimeEnabledFeatures.cpp: Disable the Touch feature by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix a build failure by r58647.
tkent@chromium.org [Sun, 2 May 2010 11:29:44 +0000 (11:29 +0000)]
Unreviewed.  Fix a build failure by r58647.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Benjamin Poulain <benjamin.poulain@nokia.com>
eric@webkit.org [Sun, 2 May 2010 08:55:04 +0000 (08:55 +0000)]
2010-05-02  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QWebPage::userAgentForUrl is terrible API
        https://bugs.webkit.org/show_bug.cgi?id=33875

        Simplify the creation of the user agent string to avoid some
        overhead for each loaded url.

        The static part of the user agent is cached so it only have
        to be made once.
        This creation has been made in order to simplify the code.

        The two variable: application name and current language are
        set dynamically when needed.
        The default locale is non longer created if the widget locale
        is used.

        * Api/qwebpage.cpp:
        (QWebPage::userAgentForUrl):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::userAgentApplicationName):
        (tst_QWebPage::userAgentLocaleChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Michael Nordman <michaeln@google.com>
eric@webkit.org [Sun, 2 May 2010 08:39:21 +0000 (08:39 +0000)]
2010-05-02  Michael Nordman  <michaeln@google.com>

        Reviewed by Dmitry Titov.

        Define two new ResourceRequestBase TargetTypes for worker and shared worker
        main resources. Use the new target types where appropiate. Add logic to marshal
        the target type specified by requests initiated on a background worker thread.

        https://bugs.webkit.org/show_bug.cgi?id=38295

        No new tests. This doesn't have script visible artifacts.

        * platform/network/ResourceRequestBase.cpp: marshal the values
        (WebCore::ResourceRequestBase::adopt):
        (WebCore::ResourceRequestBase::copyData):
        * platform/network/ResourceRequestBase.h:  define the types
        (WebCore::ResourceRequestBase::):
        * workers/DefaultSharedWorkerRepository.cpp: use TargetIsSharedWorker
        (WebCore::SharedWorkerScriptLoader::load):
        * workers/Worker.cpp: use TargetIsWorker
        (WebCore::Worker::Worker):
        * workers/WorkerContext.cpp: use TargetIsScript for importScripts
        (WebCore::WorkerContext::importScripts):
        * workers/WorkerScriptLoader.cpp: add a data member for the target type
        (WebCore::WorkerScriptLoader::WorkerScriptLoader):
        (WebCore::WorkerScriptLoader::createResourceRequest):
        * workers/WorkerScriptLoader.h:
2010-05-02  Michael Nordman  <michaeln@google.com>

        Reviewed by Dmitry Titov.

        Define two new ResourceRequestBase TargetTypes for worker and shared worker
        main resources. Use the new target types where appropiate. Add logic to marshal
        the target type specified by requests initiated on a background worker thread.

        https://bugs.webkit.org/show_bug.cgi?id=38295

        * src/SharedWorkerRepository.cpp:  use TargetIsSharedWorker
        (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Sun, 2 May 2010 08:12:47 +0000 (08:12 +0000)]
2010-05-02  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        [chromium] Upstream test expectations for:
        http/tests/loading/basic-auth-resend-wrong-credentials.html
        https://bugs.webkit.org/show_bug.cgi?id=38387

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sun, 2 May 2010 08:01:33 +0000 (08:01 +0000)]
2010-05-02  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] GraphicsLayer: animation incorrect when scrolling
        https://bugs.webkit.org/show_bug.cgi?id=38371

        This is a regression introduced with the invalidate-on-scroll code path, that uses QGraphicsWebViewPrivate::update()
        instead of QGraphicsWebViewPrivate::scroll(). The patch makes sure that the scrolling position is correct on
        each content update - this shouldn't have a performance impact - the only overhead is an additional value-test on each update.

        Tested by http://www.the-art-of-web.com/css/css-animation/

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Ben Murdoch <benm@google.com>
eric@webkit.org [Sun, 2 May 2010 07:50:41 +0000 (07:50 +0000)]
2010-05-02  Ben Murdoch  <benm@google.com>

        Reviewed by Darin Adler.

        fast/events/touch has non-standard script test wrappers
        https://bugs.webkit.org/show_bug.cgi?id=38084

        Tidy up the touch event layout tests. Make the script-tests TEMPLATE.html
        generate asynchronous style tests using js-test-post-function.js and move
        the non-standard synchronous test into the resources directory.

        * fast/events/touch/basic-multi-touch-events.html: Regenerate from TEMPLATE.html
        * fast/events/touch/basic-single-touch-events.html: ditto.
        * fast/events/touch/send-oncancel-event.html: ditto.
        * fast/events/touch/touch-target.html: ditto.
        * fast/events/touch/create-touch-event.html: Link to script in resources rather than
            script-tests as this test is not generated from TEMPLATE.html.
        * fast/events/touch/resources/create-touch-event.js: Copied from LayoutTests/fast/events/touch/script-tests/create-touch-event.js.
        * fast/events/touch/script-tests/TEMPLATE.html: Update to generate asynchronous tests.
        * fast/events/touch/script-tests/create-touch-event.js: Removed.
        * fast/events/touch/script-tests/touch-target.js: Refactor to work with new wrapper
            generated from TEMPLATE.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Rafael Weinstein <rafaelw@chromium.org>
eric@webkit.org [Sun, 2 May 2010 07:23:16 +0000 (07:23 +0000)]
2010-05-02  Rafael Weinstein  <rafaelw@chromium.org>

        Reviewed by Darin Fisher.

        Include WebWindowFeatures in call to WebViewClient::createView.
        https://bugs.webkit.org/show_bug.cgi?id=38301

        * public/WebViewClient.h:
        (WebKit::WebViewClient::createView):
        * public/WebWindowFeatures.h:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::createWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-02 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sun, 2 May 2010 07:12:35 +0000 (07:12 +0000)]
2010-05-02  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Adele Peterson.

        Webkit doesn't compile with 3D-canvas enabled and video disabled
        https://bugs.webkit.org/show_bug.cgi?id=38297

        Added a #ifdef ENABLE(VIDEO) to WebGL code

        No new tests: compile fix.

        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::JSWebGLRenderingContext::texImage2D):
        (WebCore::JSWebGLRenderingContext::texSubImage2D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-01 Evan Stade <estade@chromium.org>
eric@webkit.org [Sun, 2 May 2010 07:01:31 +0000 (07:01 +0000)]
2010-05-01  Evan Stade  <estade@chromium.org>

        Reviewed by David Levin.

        [chromium] Skia needs to fade DragImages
        https://bugs.webkit.org/show_bug.cgi?id=38008

        tested by DragImageTest

        * platform/chromium/DragImageChromiumSkia.cpp:
        (WebCore::dissolveDragImageToFraction):implement
        (WebCore::createDragImageFromImage):deep copy instead of shallow
2010-05-01  Evan Stade  <estade@chromium.org>

        Reviewed by David Levin

        [chromium] Skia needs to fade DragImages
        https://bugs.webkit.org/show_bug.cgi?id=38008

        * tests/DragImageTest.cpp:
        (DragImageTest.CreateDragImage): test that the drag image is a deep copy

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Not reviewed.
ap@apple.com [Sun, 2 May 2010 05:27:34 +0000 (05:27 +0000)]
    Not reviewed.

        More shortening of Sputnik paths.

        * fast/js/sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples: Copied from fast/js/sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples_of_Automatic_Semicolon_Insertion.
        * fast/js/sputnik/Conformance/07_Lexical_Conventions/7.9_Automatic_Semicolon_Insertion/7.9.2_Examples_of_Automatic_Semicolon_Insertion: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-01 James Robinson <jamesr@chromium.org>
eric@webkit.org [Sun, 2 May 2010 05:07:00 +0000 (05:07 +0000)]
2010-05-01  James Robinson  <jamesr@chromium.org>

        Reviewed by Eric Seidel.

        Add fast/repaint/fixed-move-after-keyboard-scroll.html to skipped list pending investigation
        https://bugs.webkit.org/show_bug.cgi?id=38416

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Land test case that was supposed to be in r53607.
ddkilzer@apple.com [Sun, 2 May 2010 01:25:53 +0000 (01:25 +0000)]
    Land test case that was supposed to be in r53607.

    2010-01-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Stylesheet href property shows redirected URL unlike other browsers
        https://bugs.webkit.org/show_bug.cgi?id=33683

        Test whether the href property of style sheets contains the original or
        final URL of the redirect chain that lead to the style sheet.

        I couldn't figure out how to test the XSLStyleSheet parts of this
        change.  There didn't seem to be DOM bindings for the href property
        here.  If I missed it, please let me know.

        * http/tests/security/stylesheet-href-redirect-expected.txt: Added.
        * http/tests/security/stylesheet-href-redirect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-01 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Sat, 1 May 2010 22:44:25 +0000 (22:44 +0000)]
2010-05-01  Daniel Bates  <dbates@rim.com>

        Reviewed by Chris Jerdonek.

        https://bugs.webkit.org/show_bug.cgi?id=38423

        Adds infrastructure to change the file mode of a file using
        the appropriate SCM-specific routines.

        No functionality was changed, so no new tests.

        * Scripts/VCSUtils.pm: Added subroutines scmToggleExecutableBit,
        scmAddExecutableBit, and scmRemoveExecutableBit.
        * Scripts/svn-apply: Check for the hash key executableBitDelta
        and toggle the executable bit.
        * Scripts/svn-unapply: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-01 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 1 May 2010 20:23:35 +0000 (20:23 +0000)]
2010-05-01  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (r58273): Visited links do not change color immediately when Cmd-clicked
        https://bugs.webkit.org/show_bug.cgi?id=38422
        <rdar://problem/7921778>

        Tests:
            manual-tests/visited-link-new-window.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::initElement): Only cache the visited link state
        when invoked as part of a helper call to styleForElement or pseudoStyleForElement,
        to avoid caching the visited link state beyond the scope of a single style lookup.
        (WebCore::CSSStyleSelector::styleForElement): Adjust for above change.
        (WebCore::CSSStyleSelector::pseudoStyleForElement): Adjust for above change.
        * css/CSSStyleSelector.h:
        (WebCore::CSSStyleSelector::styleForElement): Change so "visited link helper mode"
        can't accidentally be called from outside CSSStyleSelector itself.
        (WebCore::CSSStyleSelector::pseudoStyleForElement): ditto
        * manual-tests/visited-link-new-window.html: Added. I could not figure out any way
        to make an automated test that supports visited link coloring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove number parsing code out of HTMLInputElement.
yael.aharon@nokia.com [Sat, 1 May 2010 12:06:35 +0000 (12:06 +0000)]
Move number parsing code out of HTMLInputElement.
https://bugs.webkit.org/show_bug.cgi?id=38203

Reviewed by Darin Adler.

The numebr parsing code follows HTML5 parsing rules and should be available outside of HTMLInputElement.
No new tests as no new functionality was introduced.

* html/HTMLInputElement.cpp:
* html/HTMLInputElement.h:
* html/HTMLParser.cpp:
* html/HTMLParser.h:
* html/StepRange.cpp:
* html/ValidityState.cpp:
* rendering/RenderSlider.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-01 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 1 May 2010 10:42:04 +0000 (10:42 +0000)]
2010-05-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Oliver Hunt.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Test webkit_dom_document_get_links.

        * tests/testdomdocument.c:
        (test_dom_document_get_links):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-05-01 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sat, 1 May 2010 10:40:45 +0000 (10:40 +0000)]
2010-05-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Oliver Hunt.

        [GTK] GObject DOM bindings
        https://bugs.webkit.org/show_bug.cgi?id=33590

        Unify more logic to skip functions into SkipFunction, and
        whitelist the two [Custom] methods in HTMLCollection.idl.

        * bindings/scripts/CodeGeneratorGObject.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix up width/height differences in smart-paste-00* results
robert@webkit.org [Sat, 1 May 2010 10:20:06 +0000 (10:20 +0000)]
[Qt] Fix up width/height differences in smart-paste-00* results

        Unreviewed fix to height/width rendering differences in results added
        by r58631.

        [Qt] Fix up width/height differences in smart-paste-00* results

        https://bugs.webkit.org/show_bug.cgi?id=38136

        * platform/qt/editing/pasteboard/smart-paste-001-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-002-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-003-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-004-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-005-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-006-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-007-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add smart paste support
robert@webkit.org [Sat, 1 May 2010 10:02:49 +0000 (10:02 +0000)]
[Qt] Add smart paste support
2010-05-01  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Add smart paste support

        https://bugs.webkit.org/show_bug.cgi?id=38136

        Add platform specific results.

        Unskip tests:
         editing/pasteboard/smart-paste-001.html
         editing/pasteboard/smart-paste-002.html
         editing/pasteboard/smart-paste-003.html
         editing/pasteboard/smart-paste-004.html
         editing/pasteboard/smart-paste-005.html
         editing/pasteboard/smart-paste-006.html
         editing/pasteboard/smart-paste-007.html

        * platform/qt/Skipped:
        * platform/qt/editing/pasteboard/smart-paste-001-expected.txt: Added.
        * platform/qt/editing/pasteboard/smart-paste-002-expected.txt: Added.
        * platform/qt/editing/pasteboard/smart-paste-003-expected.txt: Added.
        * platform/qt/editing/pasteboard/smart-paste-004-expected.txt: Added.
        * platform/qt/editing/pasteboard/smart-paste-005-expected.txt: Added.
        * platform/qt/editing/pasteboard/smart-paste-006-expected.txt:
        * platform/qt/editing/pasteboard/smart-paste-007-expected.txt: Added.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate): Enable smart paste support by default.

        * WebCore.pro:
        * editing/qt/SmartReplaceQt.cpp: Added.
        (WebCore::isCharacterSmartReplaceExempt):
        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::canSmartReplace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Yoshiki Hayashi <yhayashi@google.com>
hamaji@chromium.org [Sat, 1 May 2010 07:07:03 +0000 (07:07 +0000)]
2010-04-30  Yoshiki Hayashi  <yhayashi@google.com>

        Reviewed by Shinichiro Hamaji.

        https://bugs.webkit.org/show_bug.cgi?id=38249

        Fixes an issue where border height and padding height are ignored when computing vertically shrinking flexbox's height.

        * fast/flexbox/child-flexing-expected.txt: Added.
        * fast/flexbox/child-flexing.html: Added.
2010-04-30  Yoshiki Hayashi  <yhayashi@google.com>

        Reviewed by Shinichiro Hamaji.

        https://bugs.webkit.org/show_bug.cgi?id=38249

        Fixes an issue where border height and padding height are ignored when computing vertically shrinking flexbox's height.

        Test: fast/flexbox/child-flexing.html

        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::allowedChildFlex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Sat, 1 May 2010 05:34:28 +0000 (05:34 +0000)]
2010-04-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        * platform/mac/Skipped:
        * platform/mac/printing/media-queries-print-expected.txt:
2010-04-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Add layoutTestController.setPrinting()
        https://bugs.webkit.org/show_bug.cgi?id=37203

        Use the renderer's width insteead of screen's width as the width of
        a screen depends on machines.

        * rendering/RenderTreeAsText.cpp:
        (WebCore::externalRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 1 May 2010 03:09:01 +0000 (03:09 +0000)]
2010-04-30  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Missing INSPECTOR Guard in Console::lastWMLErrorMessage
        https://bugs.webkit.org/show_bug.cgi?id=38366

        Console::lastWMLErrorMessage is only available if WML is enabled, however
        its implementation only makes sense as long as INSPECTOR is enabled
        as well. So this adds the ENABLE(INSPECTOR) guard in the function. A
        browser without ENABLE(INSPECTOR) will always get an empty result.

        * page/Console.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-28 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sat, 1 May 2010 02:54:08 +0000 (02:54 +0000)]
2010-04-28  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Oliver Hunt.

        <input type="search"> with uneven padding causes text clipping
        https://bugs.webkit.org/show_bug.cgi?id=38160

        * fast/css/input-search-padding.html: Added.
        * platform/mac/fast/css/input-search-padding-expected.checksum: Added.
        * platform/mac/fast/css/input-search-padding-expected.png: Added.
        * platform/mac/fast/css/input-search-padding-expected.txt: Added.

2010-04-28  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Oliver Hunt.

        <input type="search"> with uneven padding causes text clipping
        https://bugs.webkit.org/show_bug.cgi?id=38160

        Test: fast/css/input-search-padding.html

        An <input type="search"> contains an inner block, which is explicitly
        centered in RenderTextControlSingleLine based on the height of the element.
        However, the clipping rect was not using the set location, and instead
        calculated off of the top border and padding alone. This also vertically
        centers the Caps Lock indicator.

        * rendering/RenderTextControl.cpp: moved controlClipRect implementation to RenderTextControlSingleLine
        * rendering/RenderTextControl.h: allow a subclass implementation of controlClipRect, removed redundant hasControlClip implementation, and moved controlClipRect
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::paint): vertically center the Caps Lock indicator
        (WebCore::RenderTextControlSingleLine::controlClipRect): use the set location of the anonymous inner block instead
        * rendering/RenderTextControlSingleLine.h: allow for an implementation of controlClipRect for <input type="search">

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the build.
weinig@apple.com [Sat, 1 May 2010 01:01:06 +0000 (01:01 +0000)]
Fix the build.

* Platform/CoreIPC/mac/ConnectionMac.cpp: Add missing #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCaret may fail to blink if a focus handler brings up a modal dialog
jhoneycutt@apple.com [Sat, 1 May 2010 00:49:01 +0000 (00:49 +0000)]
Caret may fail to blink if a focus handler brings up a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=38372

Reviewed by Darin Adler.

WebCore:

* manual-tests/onfocus-alert-blinking-caret.html: Added.

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
Moved the call to setCaretBlinkingSuspended() from here...
(WebCore::EventHandler::handleMousePressEvent):
... to here. This makes us suspend caret blinking before dispatching the
mouse down event. If dispatching the mouse down event allows the message
loop to run, we want mouse up events received in that message loop to be
able to resume caret blinking.
(WebCore::EventHandler::lostMouseCapture):
We've lost mouse capture and won't be notified of mouse up events;
resume caret blinking.

* page/EventHandler.h:
Declare lostMouseCapture().

WebKit/win:

* WebView.cpp:
(WebView::handleMouseEvent):
If the message is WM_CANCELMODE, which indicates that we our capturing
of mouse events has been cancelled, tell the EventHandler.
It's possible to re-enter this function if handling a mouse event allows
the message loop to run; moved up the call to setMouseActivated(), so
that if we do re-enter this function, the later mouse event will not be
considered as activating the window.
(WebView::WebViewWndProc):
Handle WM_CANCELMODE by calling handleMouseEvent().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=38413
weinig@apple.com [Sat, 1 May 2010 00:22:24 +0000 (00:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=38413
Add callback based API to get the textual representation of the RenderTree.

Reviewed by Anders Carlsson.

- Also ensures that any pending callbacks are invalidated if the WebPage
  closes (expectedly or unexpectedly).
- A follow up patch will unify the callback mechanism with a common base
  class.

* Shared/CoreIPCSupport/WebPageMessageKinds.h:
(WebPageMessage::):
* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
(WebPageProxyMessage::):
* UIProcess/API/C/WKPage.cpp:
(WKPageRunJavaScriptInMainFrame_f):
(WKPageRenderTreeExternalRepresentation_f):
(callRenderTreeExternalRepresentationBlockAndDispose):
(disposeRenderTreeExternalRepresentationBlock):
(WKPageRenderTreeExternalRepresentation):
* UIProcess/API/C/WKPagePrivate.h: Added.
* UIProcess/RenderTreeExternalRepresentationCallback.cpp: Added.
(WebKit::generateCallbackID):
(WebKit::RenderTreeExternalRepresentationCallback::RenderTreeExternalRepresentationCallback):
(WebKit::RenderTreeExternalRepresentationCallback::~RenderTreeExternalRepresentationCallback):
(WebKit::RenderTreeExternalRepresentationCallback::performCallbackWithReturnValue):
(WebKit::RenderTreeExternalRepresentationCallback::invalidate):
* UIProcess/RenderTreeExternalRepresentationCallback.h: Added.
(WebKit::RenderTreeExternalRepresentationCallback::create):
(WebKit::RenderTreeExternalRepresentationCallback::callbackID):
* UIProcess/ScriptReturnValueCallback.cpp:
(WebKit::ScriptReturnValueCallback::~ScriptReturnValueCallback):
(WebKit::ScriptReturnValueCallback::performCallbackWithReturnValue):
(WebKit::ScriptReturnValueCallback::invalidate):
* UIProcess/ScriptReturnValueCallback.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::getRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::didReceiveMessage):
(WebKit::WebPageProxy::didRunJavaScriptInMainFrame):
(WebKit::WebPageProxy::didGetRenderTreeExternalRepresentation):
(WebKit::WebPageProxy::processDidExit):
* UIProcess/WebPageProxy.h:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getRenderTreeExternalRepresentation):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:
* win/WebKit2.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 30 Apr 2010 23:54:24 +0000 (23:54 +0000)]
2010-04-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/7477071> REGRESSION: Bad flicker when wheel-scrolling Google Maps, iPad gallery and other sites

        Sites that frequently toggle content in and out of compositing layers (like http://www.tumblr.com/boothed)
        can cause flickering because of unsychronized compositing layer and view-based updates. There were two
        underlying issues:

        1. On SnowLeopard, AppKit can throttle window updates, thus breaking an assumption that
           NSView drawing will happen on the runloop cycle after a repaint. This provided a window
           for the layerSyncRunLoopObserver to fire and commit layer changes too early.

           Fix this by having the layerSyncRunLoopObserver in WebView check to see if a display is pending,
           and not commit layer changes in that case. We'll commit layer changes later when we
           finally draw.

        2. The change in r49269 was wrong; it was attempting to fix an issue that was actually caused
           by -drawRects: coming in for page snapshots. The correct approach is to avoid hitting the
           synchronization and update disabling code in WebHTMLView for draws that are not to the screen.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView drawRect:]):
        * WebView/WebView.mm:
        (layerSyncRunLoopObserverCallBack):
        (-[WebView _scheduleCompositingLayerSync]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Enabled accelerated compositing in DRT for Windows
cmarrin@apple.com [Fri, 30 Apr 2010 23:42:04 +0000 (23:42 +0000)]
    Enabled accelerated compositing in DRT for Windows
        https://bugs.webkit.org/show_bug.cgi?id=38404

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, build fix.
dglazkov@chromium.org [Fri, 30 Apr 2010 23:30:31 +0000 (23:30 +0000)]
Unreviewed, build fix.

[Chromium] Added a simple IdentifierRep struct and removed dependency on
IdentifierRep.h.

* bindings/v8/V8NPObject.cpp: Added simple IdentifierRep struct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, expectations update.
dglazkov@chromium.org [Fri, 30 Apr 2010 23:30:24 +0000 (23:30 +0000)]
Unreviewed, expectations update.

[Chromium] More missing pixel test results.

* platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.checksum: Added.
* platform/chromium-mac/fast/borders/svg-as-border-image-expected.checksum: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 30 Apr 2010 23:25:38 +0000 (23:25 +0000)]
2010-04-30  James Robinson  <jamesr@chromium.org>

        Unreviewed. Add Chromium expectations for a bunch of repaint tests that we now pass (yay!)

        * platform/chromium-linux/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
        * platform/chromium-linux/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
        * platform/chromium-linux/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
        * platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
        * platform/chromium-linux/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
        * platform/chromium-linux/fast/repaint/fixed-move-after-scroll-expected.png: Added.
        * platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
        * platform/chromium-win/fast/repaint/fixed-child-move-after-scroll-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/fixed-child-move-after-scroll-expected.png: Added.
        * platform/chromium-win/fast/repaint/fixed-child-move-after-scroll-expected.txt: Added.
        * platform/chromium-win/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.png: Added.
        * platform/chromium-win/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt: Added.
        * platform/chromium-win/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.png: Added.
        * platform/chromium-win/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt: Added.
        * platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
        * platform/chromium-win/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.
        * platform/chromium-win/fast/repaint/fixed-move-after-scroll-expected.checksum: Added.
        * platform/chromium-win/fast/repaint/fixed-move-after-scroll-expected.png: Added.
        * platform/chromium-win/fast/repaint/fixed-move-after-scroll-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38406
weinig@apple.com [Fri, 30 Apr 2010 23:06:45 +0000 (23:06 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38406
Add support for sending messages with a size greater than 4096 bytes

Reviewed by Anders Carlsson.

Adds support by putting message bodies that are larger than 4096 bytes
in OOL memory.

* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::dispatchMessages):
* Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::OutgoingMessage::OutgoingMessage):
(CoreIPC::Connection::OutgoingMessage::messageID):
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
* Platform/CoreIPC/MessageID.h:
(CoreIPC::MessageID::):
(CoreIPC::MessageID::MessageID):
(CoreIPC::MessageID::equalIgnoringFlags):
(CoreIPC::MessageID::copyAddingFlags):
(CoreIPC::MessageID::fromInt):
(CoreIPC::MessageID::toInt):
(CoreIPC::MessageID::isMessageBodyOOL):
* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createArgumentDecoder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, build fix.
dglazkov@chromium.org [Fri, 30 Apr 2010 23:00:48 +0000 (23:00 +0000)]
Unreviewed, build fix.

[Chromium] Remove bridge/ from include paths.

* WebCore.gyp/WebCore.gyp: Removed bridge/ from include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
ddkilzer@apple.com [Fri, 30 Apr 2010 22:54:03 +0000 (22:54 +0000)]
WebCore: Convert m_documentUnderMouse, m_dragInitiator to RefPtr.
Eliminated unused m_dragInitiator accessor to prevent dereferencing.
https://bugs.webkit.org/show_bug.cgi?id=37618

Patch by Abhishek Arya <inferno@chromium.org> on 2010-04-30
Reviewed by David Kilzer.

Test: editing/pasteboard/drag-drop-iframe-refresh-crash.html

* page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):
* page/DragController.h:
(WebCore::DragController::draggingImageURL):
(WebCore::DragController::documentUnderMouse):

LayoutTests: Tests for a crash when an image drag-drop operation happens inside a continuously refreshing iframe.
https://bugs.webkit.org/show_bug.cgi?id=37618

Patch by Abhishek Arya <inferno@chromium.org> on 2010-04-30
Reviewed by David Kilzer.

* editing/pasteboard/drag-drop-iframe-refresh-crash-expected.txt: Added.
* editing/pasteboard/drag-drop-iframe-refresh-crash.html: Added.
* editing/resources/drag-drop.html: Added.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-29 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 30 Apr 2010 22:26:31 +0000 (22:26 +0000)]
2010-04-29  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Calls FrameView::scrollPositionChanged whenever a ScrollView is scrolled
        https://bugs.webkit.org/show_bug.cgi?id=38286

        When a ScrollView's  scroll position is changed, we have to call
        FrameView::scrollPositionChanged to generate repaint invalidation for
        fixed position elements.  This ends up getting called indirectly when
        the ScrollView has a platformWidget through the port layer
        (see WebHTMLView.mm's _frameOrBoundsChanged method for how the mac
        port does it) but not when there is no platformWidget.

        This is tested by the fast/repaint/fixed-* tests when run in pixel
        mode.

        Test: fast/repaint/fixed-move-after-keyboard-scroll.html

        * page/FrameView.h:
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::valueChanged):
        * platform/ScrollView.h:
        (WebCore::ScrollView::scrollPositionChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPart of the previous part (forgot to save).
andersca@apple.com [Fri, 30 Apr 2010 22:22:44 +0000 (22:22 +0000)]
Part of the previous part (forgot to save).

* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView stopTimers]):
(-[WebNetscapePluginView startTimers]):
(-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:context:]):
(-[WebNetscapePluginView _containerCheckResult:contextInfo:]):
(-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]):
(-[WebNetscapePluginView scheduleTimerWithInterval:repeat:timerFunc:]):
(-[WebNetscapePluginView unscheduleTimer:]):
(-[WebNetscapePluginView getVariable:forURL:value:length:]):
(-[WebNetscapePluginView setVariable:forURL:value:length:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse C99 integer types in more places.
andersca@apple.com [Fri, 30 Apr 2010 22:20:29 +0000 (22:20 +0000)]
Use C99 integer types in more places.

Reviewed by Darin Adler.

WebCore:

* manual-tests/NPN_Invoke/main.c:
(NPP_New):
(NPP_NewStream):
(NPP_WriteReady):
(NPP_Write):
(NPP_HandleEvent):
(functionPointerForTVector):
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::handlePostReadFile):

WebKit/mac:

* Plugins/WebNetscapePluginView.mm:
(getNPRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, expectations update.
dglazkov@chromium.org [Fri, 30 Apr 2010 22:18:19 +0000 (22:18 +0000)]
Unreviewed, expectations update.

[Chromium] Add more missing pixel results.

* platform/chromium-win/transforms/svg-vs-css-expected.checksum: Added.
* platform/chromium-win/transforms/svg-vs-css-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-04-30 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 30 Apr 2010 22:03:14 +0000 (22:03 +0000)]
2010-04-30  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Remove unused scrollRectIntoViewRecursively function
        https://bugs.webkit.org/show_bug.cgi?id=38403

        * page/Chrome.cpp:
        (WebCore::Chrome::scrollRectIntoView): Moved comment here that was previously
        in the scrollRectIntoViewRecursively function.

        * platform/ScrollView.cpp: Get rid scrollRectIntoViewRecursively.
        * platform/ScrollView.h: Ditto. Fix comment that refers to the two functions.
        Also correct all uses of the term "method" to use the C++ term "function" and
        got rid of double spaces after periods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Tiger build.
andersca@apple.com [Fri, 30 Apr 2010 21:59:13 +0000 (21:59 +0000)]
Fix Tiger build.

* Plugins/WebBaseNetscapePluginStream.h:
* Plugins/WebBaseNetscapePluginStream.mm:
(WebNetscapePluginStream::startStream):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother Qt build fix.
andersca@apple.com [Fri, 30 Apr 2010 21:42:18 +0000 (21:42 +0000)]
Another Qt build fix.

* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::platformGetValueStatic):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother 32-bit build fix.
andersca@apple.com [Fri, 30 Apr 2010 21:35:50 +0000 (21:35 +0000)]
Another 32-bit build fix.

* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, expectations updated.
dglazkov@chromium.org [Fri, 30 Apr 2010 21:34:16 +0000 (21:34 +0000)]
Unreviewed, expectations updated.

[Chromium] Add missing pixel results.

* platform/chromium-linux/fast/borders/svg-as-border-image-2-expected.checksum: Added.
* platform/chromium-linux/fast/borders/svg-as-border-image-expected.checksum: Added.
* platform/chromium-linux/transforms/svg-vs-css-expected.checksum: Added.
* platform/chromium-linux/transforms/svg-vs-css-expected.png: Added.
* platform/chromium-mac/svg/custom/mask-changes-expected.checksum: Added.
* platform/chromium-mac/svg/custom/mask-changes-expected.png: Added.
* platform/chromium-mac/transforms/svg-vs-css-expected.checksum: Added.
* platform/chromium-win/fast/borders/svg-as-border-image-2-expected.checksum: Added.
* platform/chromium-win/fast/borders/svg-as-border-image-2-expected.png: Added.
* platform/chromium-win/fast/borders/svg-as-border-image-expected.checksum: Added.
* platform/chromium-win/fast/borders/svg-as-border-image-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix GTK+ build.
andersca@apple.com [Fri, 30 Apr 2010 21:23:59 +0000 (21:23 +0000)]
Try to fix GTK+ build.

* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
(webkit_test_plugin_new_stream):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd back TRUE, FALSE and NULL macros. They were not meant to be removed!
andersca@apple.com [Fri, 30 Apr 2010 21:13:22 +0000 (21:13 +0000)]
Add back TRUE, FALSE and NULL macros. They were not meant to be removed!

* bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<http://webkit.org/b/38364> MIME typo in LayoutTests/http/tests/security/xss-DENIED...
ddkilzer@apple.com [Fri, 30 Apr 2010 21:04:49 +0000 (21:04 +0000)]
<webkit.org/b/38364> MIME typo in LayoutTests/http/tests/security/xss-DENIED-mime-type-execute-as-html.html

Reviewed by NOBODY (OOPS!).

* http/tests/security/xss-DENIED-mime-type-execute-as-html.html:
Fixed MIME typo from "application-javascript" to
"application/javascript".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry to fix the Qt build this time.
andersca@apple.com [Fri, 30 Apr 2010 21:04:46 +0000 (21:04 +0000)]
Try to fix the Qt build this time.

* plugins/qt/PluginPackageQt.cpp:
(WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue):
(WebCore::PluginPackage::NPVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoYet another build fix.
andersca@apple.com [Fri, 30 Apr 2010 21:03:36 +0000 (21:03 +0000)]
Yet another build fix.

* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::PluginPackage::NPVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix 32-bit build (again).
andersca@apple.com [Fri, 30 Apr 2010 21:02:14 +0000 (21:02 +0000)]
Fix 32-bit build (again).

* Plugins/WebNetscapeContainerCheckContextInfo.h:
* Plugins/WebNetscapeContainerCheckContextInfo.mm:
(-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:context:]):
(-[WebNetscapeContainerCheckContextInfo checkRequestID]):
(-[WebNetscapeContainerCheckContextInfo callback]):
* Plugins/WebNetscapePluginPackage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build.
andersca@apple.com [Fri, 30 Apr 2010 20:55:18 +0000 (20:55 +0000)]
Fix build.

* bridge/npapi.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add WebFileSystem interface and hook up with all FileSystem methods.
jianli@chromium.org [Fri, 30 Apr 2010 20:50:52 +0000 (20:50 +0000)]
[chromium] Add WebFileSystem interface and hook up with all FileSystem methods.
https://bugs.webkit.org/show_bug.cgi?id=38228

Reviewed by Darin Fisher.

WebCore:

* platform/chromium/ChromiumBridge.h:
* platform/chromium/FileSystemChromium.cpp:
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):

WebKit/chromium:

* WebKit.gyp:
* public/WebFileSystem.h: Added.
* public/WebKitClient.h:
(WebKit::WebKitClient::fileSystem):
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::fileExists):
(WebCore::ChromiumBridge::deleteFile):
(WebCore::ChromiumBridge::deleteEmptyDirectory):
(WebCore::ChromiumBridge::getFileSize):
(WebCore::ChromiumBridge::getFileModificationTime):
(WebCore::ChromiumBridge::directoryName):
(WebCore::ChromiumBridge::pathByAppendingComponent):
(WebCore::ChromiumBridge::makeAllDirectories):
(WebCore::ChromiumBridge::getAbsolutePath):
(WebCore::ChromiumBridge::isDirectory):
(WebCore::ChromiumBridge::filePathToURL):
(WebCore::ChromiumBridge::openFile):
(WebCore::ChromiumBridge::closeFile):
(WebCore::ChromiumBridge::seekFile):
(WebCore::ChromiumBridge::truncateFile):
(WebCore::ChromiumBridge::readFromFile):
(WebCore::ChromiumBridge::writeToFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58599 268f45cc-cd09-0410-ab3c-d52691b4dbfc