WebKit-https.git
9 years agoWebKit2: Spelling and Grammar Checking: Make sure to remove the markings from the...
jberlin@webkit.org [Tue, 12 Apr 2011 20:14:20 +0000 (20:14 +0000)]
WebKit2: Spelling and Grammar Checking: Make sure to remove the markings from the document
when spelling and/or grammar checking is disabled.
https://bugs.webkit.org/show_bug.cgi?id=58350

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView toggleContinuousSpellChecking:]):
Move the call to unmark the errors to the WebProcess.
(-[WKView setGrammarCheckingEnabled:]):
Ditto.
(-[WKView toggleGrammarChecking:]):
Ditto.

* UIProcess/WebPageProxy.cpp:
Remove unused functions.
* UIProcess/WebPageProxy.h:
Ditto.
* WebProcess/WebPage/WebPage.messages.in:
Ditto.
* WebProcess/WebPage/WebPage.h:

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setTextCheckerState):
If grammar or spelling checking is disabled, unmark all the pages.
Doing it here allows makes it possible to unmark all pages in a cross-platform way that is
triggered both by selecting the the context menu items and by any other methods of updating
the enabled / disabled state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Thouraya ANDOLSI <thouraya.andolsi@st.com>
commit-queue@webkit.org [Tue, 12 Apr 2011 20:05:45 +0000 (20:05 +0000)]
2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Eric Seidel.

        [QT] Enable JIT build for SH4 platforms.
        https://bugs.webkit.org/show_bug.cgi?id=58317
        add disable_uitools for SH4 platforms.

        * Source/WebKit.pri:
2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Eric Seidel.

        [Qt] Enable JIT build for SH4 platforms.
        https://bugs.webkit.org/show_bug.cgi?id=58317
        enable JIT build for QT backend  for SH4 platforms.

        * JavaScriptCore.pro:
        * wtf/Platform.h:
2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Eric Seidel.

        [Qt] Enable JIT build for SH4 platforms.
        https://bugs.webkit.org/show_bug.cgi?id=58317

        * DumpRenderTree/qt/DumpRenderTree.pro:
        * QtTestBrowser/QtTestBrowser.pro:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 12 Apr 2011 19:56:04 +0000 (19:56 +0000)]
2011-04-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Cisco Meeting Center will not download or launch from Safari
        https://bugs.webkit.org/show_bug.cgi?id=58366
        <rdar://problem/8987139>

        It's OK if a plug-in has less (or more) MIME type descriptions than actual MIME types.

        * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
        (WebKit::getPluginInfoFromCarbonResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 12 Apr 2011 19:45:15 +0000 (19:45 +0000)]
2011-04-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Call PluginControllerProxy::platformGeometryDidChange before Plugin::geometryDidChange
        https://bugs.webkit.org/show_bug.cgi?id=58361

        Since Plugin::geometryDidChange ends up calling plug-in code it can resize the plug-in which causes
        platformGeometryDidChange to be called with the wrong rect.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::geometryDidChange):
        Call platformGeometryDidChange.

        * PluginProcess/PluginControllerProxy.h:
        * PluginProcess/mac/PluginControllerProxyMac.mm:
        (WebKit::PluginControllerProxy::platformGeometryDidChange):
        Remove the parameters to platformGeometryDidChange and just use m_frameRect instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove three Mac specific functions to PluginControllerProxyMac.mm.
andersca@apple.com [Tue, 12 Apr 2011 19:37:44 +0000 (19:37 +0000)]
Move three Mac specific functions to PluginControllerProxyMac.mm.

Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 12 Apr 2011 19:35:10 +0000 (19:35 +0000)]
2011-04-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Cache the window and plug-in element NPObjects
        https://bugs.webkit.org/show_bug.cgi?id=58355

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::PluginControllerProxy):
        (WebKit::PluginControllerProxy::~PluginControllerProxy):
        (WebKit::PluginControllerProxy::windowScriptNPObject):
        (WebKit::PluginControllerProxy::pluginElementNPObject):
        * PluginProcess/PluginControllerProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Thouraya ANDOLSI <thouraya.andolsi@st.com>
commit-queue@webkit.org [Tue, 12 Apr 2011 19:24:28 +0000 (19:24 +0000)]
2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Eric Seidel.

        [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
        https://bugs.webkit.org/show_bug.cgi?id=58333

        * Scripts/build-jsc:
        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 George Guo <George.Guo@nokia.com>
commit-queue@webkit.org [Tue, 12 Apr 2011 19:17:06 +0000 (19:17 +0000)]
2011-04-12  George Guo  <George.Guo@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] On Symbian got "Update Error" when installing QtWebkit.sis
        http://bugs.webkit.org/show_bug.cgi?id=58141

        If QtWebKit is already in Symbian ROM, we need package to be
        both SA and RU type

        * QtWebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 12 Apr 2011 19:10:37 +0000 (19:10 +0000)]
2011-04-12  Tony Chang  <tony@chromium.org>

        Reviewed by Andreas Kling.

        [Qt] embed checksums in PNGs written by Qt-DRT
        https://bugs.webkit.org/show_bug.cgi?id=58173

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 12 Apr 2011 19:02:11 +0000 (19:02 +0000)]
2011-04-12  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Move StyleChange and other global functions from ApplyStyleCommand to EditingStyle
        https://bugs.webkit.org/show_bug.cgi?id=55974

        Moved StyleChange, getIdentifierValue, and legacyFontSizeFromCSSValue from ApplyStyleCommand
        to EditingStyle. Also moved reconcileTextDecorationProperties, getIdentifierValue,
        setTextDecorationProperty, isCSSValueLength, legacyFontSizeFromCSSValue, extractTextStyles,
        diffTextDecorations, fontWeightIsBold, getTextAlignment, and getPropertiesNotIn.

        Because of this move, getPropertiesNotIn is no longer visible outside of EditingStyle.cpp

        * editing/ApplyStyleCommand.cpp:
        * editing/ApplyStyleCommand.h:
        * editing/EditingStyle.cpp:
        (WebCore::reconcileTextDecorationProperties):
        (WebCore::StyleChange::StyleChange):
        (WebCore::setTextDecorationProperty):
        (WebCore::getRGBAFontColor):
        (WebCore::StyleChange::extractTextStyles):
        (WebCore::diffTextDecorations):
        (WebCore::fontWeightIsBold):
        (WebCore::getTextAlignment):
        (WebCore::getPropertiesNotIn):
        (WebCore::getIdentifierValue):
        (WebCore::isCSSValueLength):
        (WebCore::legacyFontSizeFromCSSValue):
        * editing/EditingStyle.h:
        (WebCore::StyleChange::cssStyle):
        (WebCore::StyleChange::applyBold):
        (WebCore::StyleChange::applyItalic):
        (WebCore::StyleChange::applyUnderline):
        (WebCore::StyleChange::applyLineThrough):
        (WebCore::StyleChange::applySubscript):
        (WebCore::StyleChange::applySuperscript):
        (WebCore::StyleChange::applyFontColor):
        (WebCore::StyleChange::applyFontFace):
        (WebCore::StyleChange::applyFontSize):
        (WebCore::StyleChange::fontColor):
        (WebCore::StyleChange::fontFace):
        (WebCore::StyleChange::fontSize):
        (WebCore::StyleChange::operator==):
        (WebCore::StyleChange::operator!=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Tue, 12 Apr 2011 18:45:33 +0000 (18:45 +0000)]
2011-04-11  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium]: Get the list of misspelled words in the WebKit code insetad of in chromium's RenderView
        https://bugs.webkit.org/show_bug.cgi?id=58260

        * public/WebContextMenuData.h:
        * public/WebSpellCheckClient.h:
        (WebKit::WebSpellCheckClient::spellCheck):
        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::checkSpellingOfString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 12 Apr 2011 18:40:45 +0000 (18:40 +0000)]
2011-04-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Review tool should work well on iPad
        https://bugs.webkit.org/show_bug.cgi?id=58351

        On the iPad, the toolbar ends up at some random position in the middle
        of the page because of how position:fixed interacts with scrolling on
        the iPad.  I feel a bit dirty using a user agent detect, but I'm not
        sure if there's a better way to detect whether the user agent has this
        behavior.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Diego Gonzalez <diegohcg@webkit.org>
diegohcg@webkit.org [Tue, 12 Apr 2011 18:30:44 +0000 (18:30 +0000)]
2011-04-12  Diego Gonzalez  <diegohcg@webkit.org>

    [Qt] Better padding for inputs and comboxes in mobile theme
    https://bugs.webkit.org/show_bug.cgi?id=58248

    Reviewed by Kenneth Rohde Christiansen.

    * platform/qt/RenderThemeQt.cpp:
    (WebCore::RenderThemeQt::setButtonPadding):
    (WebCore::RenderThemeQt::adjustTextFieldStyle):
    (WebCore::RenderThemeQt::paintTextField):
    (WebCore::RenderThemeQt::adjustMenuListStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 12 Apr 2011 18:30:17 +0000 (18:30 +0000)]
2011-04-12  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue should upload failure diffs when tests fail
        https://bugs.webkit.org/show_bug.cgi?id=58348

        This change was mostly just plumbing.  We were already saving
        this information for flaky test reporting.  I just made it possible
        for normal failures to report archives as well.

        I did a little abstraction work to try and share some code between
        flakytestreporter.py and this new code.  There is still more we could do.

        In making this change I also went through and updated the various
        places we have urls hard-coded in our python and pointed them at
        common.config.urls.

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/common/net/buildbot/buildbot.py:
        * Scripts/webkitpy/common/net/statusserver.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/tool/bot/botinfo.py: Added.
        * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Bill Budge <bbudge@chromium.org>
commit-queue@webkit.org [Tue, 12 Apr 2011 18:19:09 +0000 (18:19 +0000)]
2011-04-12  Bill Budge  <bbudge@chromium.org>

        Reviewed by Darin Fisher.

        Move the WebURLLoaderOptions struct into its own file and rename the CrossOriginRequestPolicy enum to conform to the WebKit coding standard.
        https://bugs.webkit.org/show_bug.cgi?id=58287

        No new tests. No new functionality exposed.

        * WebKit.gyp:
        * public/WebURLLoader.h:
        * public/WebURLLoaderOptions.h: Added.
        (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::AssociatedURLLoader):
        * src/AssociatedURLLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate pixel results for editable-inline-element.html since it progressed following...
hyatt@apple.com [Tue, 12 Apr 2011 18:00:32 +0000 (18:00 +0000)]
Update pixel results for editable-inline-element.html since it progressed following r83075.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 12 Apr 2011 17:52:56 +0000 (17:52 +0000)]
2011-04-11  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that we do not crash when reparenting a runin to a details block.
        https://bugs.webkit.org/show_bug.cgi?id=58228

        * fast/runin/runin-reparent-crash-expected.txt: Added.
        * fast/runin/runin-reparent-crash.html: Added.
2011-04-11  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Replace insertChildNode with addChild in handleRunIn's reparenting
        of inlineRunIn to currBlock.
        https://bugs.webkit.org/show_bug.cgi?id=58228

        Use addChild instead of insertChildNode since it handles
        correct placement of the children, esp where we cannot insert
        anything before the first child. e.g. details tag requires that its
        first child be a summary child and won't be able to remove child if
        that is not the case.

        Test: fast/runin/runin-reparent-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::handleRunInChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 12 Apr 2011 17:50:07 +0000 (17:50 +0000)]
2011-04-12  Stephen White  <senorblanco@chromium.org>

        Unreviewed; new chromium layout test baselines.

        New baselines after r83541.  Note that these look worse, but that's
        because we went from greyscale antialiasing to ClearType antialiasing,
        but the layout tests turn off ClearType, so they don't get any AA
        at all.  It looks fine in Chrome.

        * platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum: Removed.
        * platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
        * platform/chromium-win/fast/text/shadow-translucent-fill-expected.checksum: Removed.
        * platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
        * platform/chromium-win/fast/transforms/shadows-expected.png:
        * platform/chromium-win/svg/css/composite-shadow-text-expected.checksum: Removed.
        * platform/chromium-win/svg/css/composite-shadow-text-expected.png:
        * platform/chromium-win/svg/css/shadow-changes-expected.checksum: Removed.
        * platform/chromium-win/svg/css/shadow-changes-expected.png:
        * platform/chromium-win/svg/css/text-shadow-multiple-expected.checksum: Removed.
        * platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
        * platform/chromium-win/transitions/svg-text-shadow-transition-expected.checksum: Removed.
        * platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fixing Leopard build.
cfleizach@apple.com [Tue, 12 Apr 2011 17:46:47 +0000 (17:46 +0000)]
Unreviewed. Fixing Leopard build.

REGRESSION: WK2: misspelled AX attributes no longer returned from text fields
https://bugs.webkit.org/show_bug.cgi?id=58304

checkTextOfParagraph is not available on Leopard. That code needs to be conditionalized with USE(UNIFIED_TEXT_CHECKING).

* accessibility/mac/AccessibilityObjectWrapper.mm:
(AXAttributeStringSetSpelling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 12 Apr 2011 17:40:09 +0000 (17:40 +0000)]
2011-04-12  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed. Added missing files to GNUmakefile.list.am.

        * GNUmakefile.list.am: Added IDBLevelDBBackingStore.[h|cpp].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Cris Neckar <cdn@chromium.org>
cdn@chromium.org [Tue, 12 Apr 2011 17:39:10 +0000 (17:39 +0000)]
2011-04-12  Cris Neckar  <cdn@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Tests for crash when non-svg inline text boxes exist in the list of text boxes.
        https://bugs.webkit.org/show_bug.cgi?id=57933

        * svg/text/svg-rtl-text-crash-expected.txt: Added.
        * svg/text/svg-rtl-text-crash.html: Added.
2011-04-12  Cris Neckar  <cdn@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Add handling for non-svg inline text boxes in text box lists.
        https://bugs.webkit.org/show_bug.cgi?id=57933

        Test: svg/text/svg-rtl-text-crash.html

        * rendering/svg/RenderSVGInlineText.cpp:
        (WebCore::RenderSVGInlineText::positionForPoint):
        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
        * rendering/svg/SVGRenderTreeAsText.cpp:
        (WebCore::writeSVGInlineTextBoxes):
        * rendering/svg/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::closestLeafChildForPosition):
        (WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
        * rendering/svg/SVGTextQuery.cpp:
        (WebCore::SVGTextQuery::collectTextBoxesInFlowBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 12 Apr 2011 17:35:36 +0000 (17:35 +0000)]
2011-04-12  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Expose menu items and menus as children of a menu bar
        https://bugs.webkit.org/show_bug.cgi?id=56659

        New cross-platform test. Skipped in platforms with no results yet.

        * accessibility/aria-menubar-menuitems.html: Added.
        * platform/gtk/accessibility/aria-menubar-menuitems-expected.txt: Added.
        * platform/mac/Skipped: Skipped the new test.
        * platform/win/Skipped: Ditto.
2011-04-12  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Expose menu items and menus as children of a menu bar
        https://bugs.webkit.org/show_bug.cgi?id=56659

        Ensure menu items get exposed when they're children of menu bars.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
        Consider menu bars as potential parent objects for menu items.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WebKit2 Release Tests] fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html...
jberlin@webkit.org [Tue, 12 Apr 2011 17:29:27 +0000 (17:29 +0000)]
[WebKit2 Release Tests] fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html flakey
https://bugs.webkit.org/show_bug.cgi?id=58337

Skip the test to get the bots green.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium test expectations.
jianli@chromium.org [Tue, 12 Apr 2011 17:23:20 +0000 (17:23 +0000)]
Unreviewed, update chromium test expectations.

Mark access-zero-sized-canvas as crash on chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 12 Apr 2011 17:18:35 +0000 (17:18 +0000)]
2011-04-12  Daniel Bates  <dbates@rim.com>

        Rubber-stamped by Eric Seidel.

        svn-apply and/or patch(1) has trouble applying patches that makes changes to files
        with Windows line endings
        https://bugs.webkit.org/show_bug.cgi?id=53625

        Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
        applied to an SCM checkout on a Windows file system and vice-versa.

        This issue manifests itself due to custom SCM settings as well as differences in
        gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
        into svn-apply/unapply to compensate for differences in line endings by converting
        the line endings in a patch to match the line endings in the target file (if it exists).

        * Scripts/VCSUtils.pm:
          - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
            content read from the specified file handle. Obviously, this heuristic will not work
            for files with mixed line endings, but I don't envision such files to be the norm. If
            this turns out to be an issue then we can improve the heuristic.
          - Added firstEOLInFile().
          - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
            In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
            endings in the diff instead of the line endings in the target file.
          - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
            re-used in parseDiff().
        * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
          to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
          mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
        * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
        * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneat...
weinig@apple.com [Tue, 12 Apr 2011 17:11:42 +0000 (17:11 +0000)]
REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
https://bugs.webkit.org/show_bug.cgi?id=58336

Reviewed by Adam Roben.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
Remove cache clearing as that is causing tests to crash on Windows 7.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 12 Apr 2011 17:07:33 +0000 (17:07 +0000)]
2011-04-12  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: remove scriptWorldType from the protocol.
        https://bugs.webkit.org/show_bug.cgi?id=58324

        * inspector/Inspector.json:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::didParseSource):
        * inspector/ScriptDebugListener.h:
        (WebCore::ScriptDebugListener::~ScriptDebugListener):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerDispatcher.prototype.scriptParsed):
        * inspector/front-end/Script.js:
        (WebInspector.Script):
        * inspector/front-end/ScriptsPanel.js:
        * inspector/front-end/SourceFile.js:
        (WebInspector.SourceFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 12 Apr 2011 16:44:56 +0000 (16:44 +0000)]
2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Carlson.

        Should MediaControls::changedNetworkState fiddle with Fullscreen controls?
        https://bugs.webkit.org/show_bug.cgi?id=58163

        Covered by existing tests and manual-tests/media-controls.html.

        * html/shadow/MediaControls.cpp:
        (WebCore::MediaControls::reset): Moved fullscreen showing/hiding here.
        (WebCore::MediaControls::changedNetworkState): ... from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 12 Apr 2011 16:36:22 +0000 (16:36 +0000)]
2011-04-12  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
        https://bugs.webkit.org/show_bug.cgi?id=58335

        It was the method for Inspector layout tests.
        We can use RuntimeAgent.evaluate instead.

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.completeTest):
2011-04-12  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: remove unnecessary method InspectorAgent.didEvaluateForTestInFrontend.
        https://bugs.webkit.org/show_bug.cgi?id=58335

        It was the method for Inspector layout tests.
        We can use RuntimeAgent.evaluate instead.

        * inspector/Inspector.json:
        * inspector/InspectorAgent.cpp:
        * inspector/InspectorAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        * inspector/front-end/TestController.js:
        (WebInspector.TestController.prototype.notifyDone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMerge branch 'bug/58307' into staging
philn@webkit.org [Tue, 12 Apr 2011 16:34:43 +0000 (16:34 +0000)]
Merge branch 'bug/58307' into staging

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 12 Apr 2011 16:29:48 +0000 (16:29 +0000)]
2011-04-12  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GStreamer] advertize HTTP Live Streaming mime-type
        https://bugs.webkit.org/show_bug.cgi?id=58318

        Register the hls mime-type in the internal cache if found in the
        typefind factories.

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mimeTypeCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 12 Apr 2011 16:24:38 +0000 (16:24 +0000)]
2011-04-11  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        RenderIndicator and ShadowBlockElement are no longer used.
        https://bugs.webkit.org/show_bug.cgi?id=58277

        Removed RenderIndicator and ShadowBlockElement.

        No new tests. Just removed unused code.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderIndicator.cpp: Removed.
        * rendering/RenderIndicator.h: Removed.
        * rendering/RenderMeter.h:
        * rendering/RenderingAllInOne.cpp:
        * rendering/ShadowElement.cpp:
        * rendering/ShadowElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=58334
beidson@apple.com [Tue, 12 Apr 2011 16:22:12 +0000 (16:22 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=58334
LayoutTestController.computedStyleIncludingVisitedInfo-based tests don't work in WK2

Rubberstamped by Adam Roben.

* platform/mac-wk2/Skipped: Skip a new test due to an identified bug in WKTR and classify
  three other skipped tests with that same bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 12 Apr 2011 16:13:57 +0000 (16:13 +0000)]
2011-04-12  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Adjusted chromium test expectations (webgl-reflection.html sometimes crashes on chromium mac debug)

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofast/css/dashboard-regions-attr-crash.html asserts
ossy@webkit.org [Tue, 12 Apr 2011 15:58:49 +0000 (15:58 +0000)]
fast/css/dashboard-regions-attr-crash.html asserts
https://bugs.webkit.org/show_bug.cgi?id=58233

Reviewed by Benjamin Poulain.

Move DASHBOARD_SUPPORT feature detection from features.pri to CodeGenerators.pri
not to generate incorrect properties into CSSPropertyNames.h.

* CodeGenerators.pri:
* features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Leopard Intel Debug Tests] fast/events/tabindex-focus-blur-all.html crashing since...
jberlin@webkit.org [Tue, 12 Apr 2011 15:56:44 +0000 (15:56 +0000)]
[Leopard Intel Debug Tests] fast/events/tabindex-focus-blur-all.html crashing since (83513,
83521].
https://bugs.webkit.org/show_bug.cgi?id=58327

Skip the test on Leopard to get the bots green.

* platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows expected failure results for a new test
aroben@apple.com [Tue, 12 Apr 2011 15:50:30 +0000 (15:50 +0000)]
Add Windows expected failure results for a new test

<http://webkit.org/b/58325> tracks the failure.

* platform/win/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove no-longer-needed Windows-specific results for an arraybuffer test
aroben@apple.com [Tue, 12 Apr 2011 15:49:57 +0000 (15:49 +0000)]
Remove no-longer-needed Windows-specific results for an arraybuffer test

Fixes <http://webkit.org/b/58326> REGRESSION (r83532):
http/tests/xmlhttprequest/send-array-buffer.html failing on Windows

* platform/win/http/tests/xmlhttprequest/send-array-buffer-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: WK2: misspelled AX attributes no longer returned from text fields
cfleizach@apple.com [Tue, 12 Apr 2011 15:45:46 +0000 (15:45 +0000)]
REGRESSION: WK2: misspelled AX attributes no longer returned from text fields
https://bugs.webkit.org/show_bug.cgi?id=58304

Reviewed by Dan Bernstein.

checkSpellingOfString is no longer implemented in WK2. Accessibility needs to change to use
checkTextOfParagraph in order to retrieve misspelled ranges.

Existing tests cover this functionality.

* accessibility/mac/AccessibilityObjectWrapper.mm:
(AXAttributeStringSetSpelling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocompositing/objects/composited-object-alignment.html causing failures in other tests...
jberlin@webkit.org [Tue, 12 Apr 2011 15:35:30 +0000 (15:35 +0000)]
compositing/objects/composited-object-alignment.html causing failures in other tests since
it's introduction in r83518
https://bugs.webkit.org/show_bug.cgi?id=58323

Disabling the test until it is fixed in order to get the bots green.

* compositing/objects/composited-object-alignment.html: Removed.
* compositing/objects/composited-object-alignment.html-disabled: Copied from LayoutTests/compositing/objects/composited-object-alignment.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Tue, 12 Apr 2011 14:43:20 +0000 (14:43 +0000)]
2011-04-12  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Remove m_idleHandler from ResourceHandleSoup
        https://bugs.webkit.org/show_bug.cgi?id=58319

        The m_idleHandler attribute is no longer used in ResourceHandleSoup.
        No new tests needed, no functionality change.

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Andrey Adaikin <aandrey@google.com>
commit-queue@webkit.org [Tue, 12 Apr 2011 14:01:49 +0000 (14:01 +0000)]
2011-04-12  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Breakpoints and execution line decoration should stay in place if the edited line is not whitespace
        https://bugs.webkit.org/show_bug.cgi?id=58314

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._lineNumberAfterEditing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 12 Apr 2011 13:52:32 +0000 (13:52 +0000)]
2011-04-11  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move shortcut handlers from SourceFrame to TextViewer.
        https://bugs.webkit.org/show_bug.cgi?id=58238

        * inspector/debugger/live-edit.html:
2011-04-11  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: move shortcut handlers from SourceFrame to TextViewer.
        https://bugs.webkit.org/show_bug.cgi?id=58238

        Commit/cancel editing functionality is common for all resource types, and it deals with TextViewer state.

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype.isContentEditable):
        (WebInspector.SourceFrame.prototype._createTextViewer):
        (WebInspector.SourceFrame.prototype.commitEditing.didEditContent):
        (WebInspector.SourceFrame.prototype.commitEditing):
        (WebInspector.SourceFrame.prototype.cancelEditing):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._doubleClick):
        (WebInspector.TextViewer.prototype._registerShortcuts):
        (WebInspector.TextViewer.prototype._handleKeyDown):
        (WebInspector.TextViewer.prototype._commitEditing.didCommitEditing):
        (WebInspector.TextViewer.prototype._commitEditing):
        (WebInspector.TextViewer.prototype._cancelEditing):
        (WebInspector.TextViewerDelegate.prototype.endEditing):
        (WebInspector.TextViewerDelegate.prototype.commitEditing):
        (WebInspector.TextViewerDelegate.prototype.cancelEditing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 12 Apr 2011 13:25:43 +0000 (13:25 +0000)]
2011-04-12  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: cookies view is empty even for sites with cookies.
        https://bugs.webkit.org/show_bug.cgi?id=58316

        * http/tests/inspector/resource-tree-model-expected.txt: Added.
        * http/tests/inspector/resource-tree-model.html: Added.
2011-04-12  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: cookies view is empty even for sites with cookies.
        https://bugs.webkit.org/show_bug.cgi?id=58316

        Test: http/tests/inspector/resource-tree-model.html

        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel.prototype._callForFrameResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 12 Apr 2011 13:03:49 +0000 (13:03 +0000)]
2011-04-12  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: InspectorTest.addObject dumps inner array properties as objects.
        https://bugs.webkit.org/show_bug.cgi?id=58310

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.addObject):
        (initialize_InspectorTest.InspectorTest.addArray):
        (initialize_InspectorTest.InspectorTest.dump):
        * http/tests/inspector/resource-har-conversion-expected.txt:
        * http/tests/inspector/resource-parameters-expected.txt:
        * inspector/protocol/console-agent-expected.txt:
        * inspector/protocol/runtime-agent-expected.txt:
        * inspector/report-protocol-errors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 12 Apr 2011 12:57:03 +0000 (12:57 +0000)]
2011-04-11  Stephen White  <senorblanco@chromium.org>

        Reviewed by James Robinson.

        [chromium] GPU-accelerated canvas-to-canvas drawImage is incorrect.
        https://bugs.webkit.org/show_bug.cgi?id=58258

        When one accelerated canvas is drawn to another via drawImage(), if the
        prior call in the source canvas was non-accelerated, the
        hardware canvas is not up-to-date, and the results will be incorrect.
        Fixed by calling prepareForHardwareDraw() on the source context.

        Test: fast/canvas/canvas-to-canvas.html

        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::draw):
2011-04-11  Stephen White  <senorblanco@chromium.org>

        Reviewed by James Robinson.

        [chromium] Accelerated canvas-to-canvas drawImage() is incorrect.
        https://bugs.webkit.org/show_bug.cgi?id=58258

        Add a new test to cover canvas-to-canvas drawImage() after a
        non-accelerated (strokeRect()) call.

        * fast/canvas/canvas-to-canvas-expected.txt: Added.
        * fast/canvas/canvas-to-canvas.html: Added.
        * fast/canvas/script-tests/canvas-to-canvas.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 12 Apr 2011 12:28:11 +0000 (12:28 +0000)]
2011-04-12  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Add some more tests for detailed heap snapshots UI.
        https://bugs.webkit.org/show_bug.cgi?id=58146

        Tests: inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-comparison-show-all.html
               inspector/profiler/detailed-heapshots-comparison-show-next.html
               inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-comparison-sorting.html
               inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-dominators-show-all.html
               inspector/profiler/detailed-heapshots-dominators-show-next.html
               inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-dominators-sorting.html
               inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html

        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotDiffDataGrid):

2011-04-12  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Add some more tests for detailed heap snapshots UI.
        https://bugs.webkit.org/show_bug.cgi?id=58146

        * inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-comparison-show-all.html: Added.
        * inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-comparison-show-next.html: Added.
        * inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html: Copied from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html.
        * inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-comparison-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-dominators-show-all.html: Added.
        * inspector/profiler/detailed-heapshots-dominators-show-next-actual.txt: Added.
        * inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-dominators-show-next.html: Added.
        * inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-dominators-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html:
        * inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html: Copied from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html.
        * inspector/profiler/detailed-heapshots-test.js:
        (initialize_DetailedHeapshotTest.):
        (initialize_DetailedHeapshotTest):
        * platform/chromium/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 12 Apr 2011 12:12:04 +0000 (12:12 +0000)]
2011-04-12  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: there was incorrect value of id property of responses for malformed json-rpc 2.0 requests.
        https://bugs.webkit.org/show_bug.cgi?id=58305

        It was 0 if the message is not a json object or it has no id property. But according to spec it must be null.

        * inspector/CodeGeneratorInspector.pm:

2011-04-12  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: there was incorrect value of id property of responses for malformed json-rpc 2.0 requests.
        https://bugs.webkit.org/show_bug.cgi?id=58305

        It was 0 if the message is not a json object or it has no id property. But according to spec it must be null.

        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Tue, 12 Apr 2011 12:00:33 +0000 (12:00 +0000)]
2011-04-12  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
        https://bugs.webkit.org/show_bug.cgi?id=58251

        Fix an issue with slot names after http://trac.webkit.org/changeset/83512.

        * Api/qwebframe.cpp:
        (QWebFrame::QWebFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 12 Apr 2011 11:39:43 +0000 (11:39 +0000)]
2011-04-11  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [chromium] script formatting doesn't work when chromium is built with debug_devtools=1.
        https://bugs.webkit.org/show_bug.cgi?id=58232

        * WebCore.gypi:
2011-04-11  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [chromium] script formatting doesn't work when chromium is built with debug_devtools=1.
        https://bugs.webkit.org/show_bug.cgi?id=58232

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 12 Apr 2011 11:38:11 +0000 (11:38 +0000)]
2011-04-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: REGRESSION: Most resources in the Network panel show a blank panel when clicked.
        https://bugs.webkit.org/show_bug.cgi?id=58273

        * inspector/debugger/source-frame-expected.txt:
        * inspector/debugger/source-frame.html:
2011-04-12  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: REGRESSION: Most resources in the Network panel show a blank panel when clicked.
        https://bugs.webkit.org/show_bug.cgi?id=58273

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        (WebInspector.SourceFrame.prototype.get visible):
        (WebInspector.SourceFrame.prototype.set visible):
        (WebInspector.SourceFrame.prototype.show):
        (WebInspector.SourceFrame.prototype.hide):
        (WebInspector.SourceFrame.prototype.detach):
        (WebInspector.SourceFrame.prototype._ensureContentLoaded):
        (WebInspector.SourceFrame.prototype.markDiff):
        (WebInspector.SourceFrame.prototype.addMessage):
        (WebInspector.SourceFrame.prototype.clearMessages):
        (WebInspector.SourceFrame.prototype.get scrollTop):
        (WebInspector.SourceFrame.prototype.set scrollTop):
        (WebInspector.SourceFrame.prototype.highlightLine):
        (WebInspector.SourceFrame.prototype._clearLineHighlight):
        (WebInspector.SourceFrame.prototype._initializeTextViewer):
        (WebInspector.SourceFrame.prototype.performSearch):
        (WebInspector.SourceFrame.prototype.searchCanceled):
        (WebInspector.SourceFrame.prototype._jumpToSearchResult):
        (WebInspector.SourceFrame.prototype.setExecutionLine):
        (WebInspector.SourceFrame.prototype.clearExecutionLine):
        (WebInspector.SourceFrame.prototype.resize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 12 Apr 2011 11:37:10 +0000 (11:37 +0000)]
2011-04-12  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document runtime agent, share remote object definition between domains.
        https://bugs.webkit.org/show_bug.cgi?id=58246

        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 12 Apr 2011 11:35:50 +0000 (11:35 +0000)]
2011-04-12  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document console domain, support cross-domain type references.
        https://bugs.webkit.org/show_bug.cgi?id=58240

        * inspector/protocol/console-agent-expected.txt:
2011-04-12  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document console domain, support cross-domain type references.
        https://bugs.webkit.org/show_bug.cgi?id=58240

        * inspector/ConsoleMessage.cpp:
        (WebCore::messageSourceValue):
        (WebCore::messageTypeValue):
        (WebCore::messageLevelValue):
        (WebCore::ConsoleMessage::addToFrontend):
        * inspector/Inspector.json:
        * inspector/ScriptCallFrame.cpp:
        (WebCore::ScriptCallFrame::buildInspectorObject):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):
        (WebInspector.ConsoleMessage):
        (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
        (WebInspector.ConsoleMessage.prototype.isEqual):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
        * inspector/generate-inspector-idl:
        * page/Console.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] inspector/styles/styles-disable-then-enable.html make inspector/styles/styles...
ossy@webkit.org [Tue, 12 Apr 2011 11:09:05 +0000 (11:09 +0000)]
[Qt] inspector/styles/styles-disable-then-enable.html make inspector/styles/styles-iframe.html fail in debug mode
https://bugs.webkit.org/show_bug.cgi?id=58313

* platform/qt/Skipped: Add inspector/styles/styles-disable-then-enable.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 12 Apr 2011 10:57:56 +0000 (10:57 +0000)]
2011-04-12  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for 2 new tests.

        * platform/gtk/fast/multicol/huge-column-count-expected.txt: Added.
        * platform/gtk/fast/overflow/trailing-float-linebox-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] 9 tests have different results on 64 bit and/or in debug mode compared to 32...
ossy@webkit.org [Tue, 12 Apr 2011 10:05:10 +0000 (10:05 +0000)]
[Qt] 9 tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52810
https://bugs.webkit.org/show_bug.cgi?id=52812

* platform/qt/Skipped: Add one more test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip a test on WebKit2 that depends on layoutTestController.setGeolocationPermission.
kbalazs@webkit.org [Tue, 12 Apr 2011 09:35:04 +0000 (09:35 +0000)]
Skip a test on WebKit2 that depends on layoutTestController.setGeolocationPermission.

Rubber-stamped by Csaba Osztrogon√°c.

* platform/mac-wk2/Skipped:
* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 12 Apr 2011 09:18:09 +0000 (09:18 +0000)]
2011-04-12  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline of fast/block/float/021.html and
        skipping 2 failing tests.

        * platform/gtk/Skipped:
        * platform/gtk/fast/block/float/021-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 12 Apr 2011 09:11:06 +0000 (09:11 +0000)]
2011-04-12  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Adjusted chromium test expectations (negative-z-index.html may crash on win & linux debug)

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Tue, 12 Apr 2011 09:06:12 +0000 (09:06 +0000)]
2011-04-12  Alejandro G. Castro  <alex@igalia.com>

        Fixed GTK compilation after r83454.

        * UIProcess/gtk/WebView.cpp:
        (WebKit::WebView::findStringInCustomRepresentation):
        (WebKit::WebView::countStringMatchesInCustomRepresentation):
        * UIProcess/gtk/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 12 Apr 2011 08:54:46 +0000 (08:54 +0000)]
2011-04-12  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Adjusted chromium test expectations (webgl-nonpremultiplied-blend.html crashes on Mac OS 10.6 DEBUG)

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-06 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 12 Apr 2011 08:53:34 +0000 (08:53 +0000)]
2011-04-06  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GStreamer] RTSP playback broken
        https://bugs.webkit.org/show_bug.cgi?id=56930

        Rely on {audio,video}-changed playbin2 signals instead of the
        -tags-changed signals because some media don't provide tags and
        then can trick the media-player to not paint video, for instance.

        Also trigger a video size calculation after the video sink
        negotiated its caps. This is useful in the cases where
        audio-changed signal is emitted but the video sink takes more time
        to negociate caps with its peer.

        This patch also fixes the rtsp manual-test with a new stream url
        which seems to be more permanent than the previous WWDC keynote
        stream.

        * manual-tests/video-rtsp.html:
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::mediaPlayerPrivateVideoChangedCallback):
        (WebCore::mediaPlayerPrivateAudioChangedCallback):
        (WebCore::mediaPlayerPrivateAudioChangeTimeoutCallback):
        (WebCore::mediaPlayerPrivateVideoChangeTimeoutCallback):
        (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
        (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
        (WebCore::MediaPlayerPrivateGStreamer::naturalSize):
        (WebCore::MediaPlayerPrivateGStreamer::videoChanged):
        (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
        (WebCore::MediaPlayerPrivateGStreamer::audioChanged):
        (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
        (WebCore::MediaPlayerPrivateGStreamer::paint):
        (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] 9 tests have different results on 64 bit and/or in debug mode compared to 32...
ossy@webkit.org [Tue, 12 Apr 2011 08:39:34 +0000 (08:39 +0000)]
[Qt] 9 tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
[Qt] 6 tests have different results on 64 bit compared to 32 bit
https://bugs.webkit.org/show_bug.cgi?id=52810
https://bugs.webkit.org/show_bug.cgi?id=52812

* platform/qt/Skipped: Add failing tests until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Tue, 12 Apr 2011 08:29:35 +0000 (08:29 +0000)]
2011-04-12  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Failed/canceled resource requests kept showing as Pending in network panel.
        https://bugs.webkit.org/show_bug.cgi?id=58135

        Added statuses for failed/canceled resource loading.

        * English.lproj/localizedStrings.js:
        * inspector/Inspector.json:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::didFailLoading):
        * inspector/front-end/NetworkManager.js:
        * inspector/front-end/NetworkPanel.js:
        * inspector/front-end/Resource.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add platform specific expected files for new tests introduced in r83514 and...
ossy@webkit.org [Tue, 12 Apr 2011 08:14:32 +0000 (08:14 +0000)]
[Qt] Add platform specific expected files for new tests introduced in r83514 and r83470.

* platform/qt/fast/multicol/huge-column-count-expected.checksum: Added.
* platform/qt/fast/multicol/huge-column-count-expected.png: Added.
* platform/qt/fast/multicol/huge-column-count-expected.txt: Added.
* platform/qt/fast/overflow/trailing-float-linebox-expected.checksum: Added.
* platform/qt/fast/overflow/trailing-float-linebox-expected.png: Added.
* platform/qt/fast/overflow/trailing-float-linebox-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 12 Apr 2011 08:13:34 +0000 (08:13 +0000)]
2011-04-12  Steve Block  <steveblock@google.com>

        Reviewed by Oliver Hunt.

        Callable objects created via JavaScriptCore API cannot be used as Geolocation callbacks
        https://bugs.webkit.org/show_bug.cgi?id=40012

        Covered by fast/dom/Geolocation/argument-types.html
        This is a revert of http://trac.webkit.org/changeset/60522

        * fast/dom/Geolocation/argument-types-expected.txt:
        * fast/dom/Geolocation/script-tests/argument-types.js:
2011-04-12  Steve Block  <steveblock@google.com>

        Reviewed by Oliver Hunt.

        Callable objects created via JavaScriptCore API cannot be used as Geolocation callbacks
        https://bugs.webkit.org/show_bug.cgi?id=40012

        Covered by fast/dom/Geolocation/argument-types.html

        * bindings/js/CallbackFunction.cpp:
        (WebCore::checkFunctionOnlyCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-07 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 12 Apr 2011 07:52:58 +0000 (07:52 +0000)]
2011-04-07  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GStreamer] report playback statistics
        https://bugs.webkit.org/show_bug.cgi?id=58033

        Provide media playback statistics using fpsdisplaysink and
        position queries.

        * manual-tests/video-statistics.html: Added.
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::decodedFrameCount):
        (WebCore::MediaPlayerPrivateGStreamer::droppedFrameCount):
        (WebCore::MediaPlayerPrivateGStreamer::audioDecodedByteCount):
        (WebCore::MediaPlayerPrivateGStreamer::videoDecodedByteCount):
        (WebCore::MediaPlayerPrivateGStreamer::updateAudioSink):
        (WebCore::MediaPlayerPrivateGStreamer::updateStates):
        (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 12 Apr 2011 07:48:21 +0000 (07:48 +0000)]
2011-04-11  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GStreamer] warnings in media/video-set-rate-from-pause.html
        https://bugs.webkit.org/show_bug.cgi?id=58220

        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::setRate): Pause the
        pipeline if new rate is zero, like advised in the GStreamer
        documentation of gst_event_new_seek().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-12 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 12 Apr 2011 07:13:09 +0000 (07:13 +0000)]
2011-04-12  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Adjusted chrome test exceptations (state-url-sets-links-visited.html fails
        because of https://bugs.webkit.org/show_bug.cgi?id=37297)

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Tue, 12 Apr 2011 06:03:51 +0000 (06:03 +0000)]
2011-04-11  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by James Robinson.

        Adding a test which verifies that compositing image layers
        update correctly when their contents change.
        https://bugs.webkit.org/show_bug.cgi?id=58181

        * compositing/images/content-image-change-expected.txt: Added.
        * compositing/images/content-image-change.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/compositing/images/content-image-change-expected.checksum: Added.
        * platform/mac/compositing/images/content-image-change-expected.png: Added.
2011-04-11  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Properly invalidate the contents of ImageLayerChromium's
        when the actual image contents change.
        https://bugs.webkit.org/show_bug.cgi?id=58181

        Test: compositing/images/content-image-change.html

        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::updateTexture):
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::ImageLayerChromium):
        (WebCore::ImageLayerChromium::setContents):
        (WebCore::ImageLayerChromium::paintContentsIfDirty):
        * platform/graphics/chromium/ImageLayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Tue, 12 Apr 2011 05:40:06 +0000 (05:40 +0000)]
2011-04-11  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=58289

        Fix compilation on Solaris/Studio 12 C++ in wtf/FastMalloc.cpp,
        WTF::TCMalloc_PageHeap::runScavengerThread(void*) expected to return a value.

        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::runScavengerThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 12 Apr 2011 04:52:56 +0000 (04:52 +0000)]
2011-04-11  Daniel Bates  <dbates@webkit.org>

        Attempt to fix the Qt Linux Release build after changeset 83550 <http://trac.webkit.org/changeset/83550>
        (https://bugs.webkit.org/show_bug.cgi?id=54159).

        * WebKit2API.pri: Append UIProcess/API/C/WKResourceCacheManager.cpp to the list WEBKIT2_API_SOURCES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 12 Apr 2011 04:14:39 +0000 (04:14 +0000)]
2011-04-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        -webkit-box-shadow:inset does not animate transform as an inset shadow
        https://bugs.webkit.org/show_bug.cgi?id=45176

        Two fixes:
        1. Don't run transitions between different shadow styles (normal vs. inset).
        2. When either source or destination is null, use a default shadow with a
        matching style so that the transition runs.

        Test: transitions/mismatched-shadow-styles.html

        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc):
        (WebCore::PropertyWrapperShadow::blend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Xianzhu Wang <wangxianzhu@google.com>
commit-queue@webkit.org [Tue, 12 Apr 2011 03:57:41 +0000 (03:57 +0000)]
2011-04-11  Xianzhu Wang  <wangxianzhu@google.com>

        Reviewed by Tony Gentilcore.

        loader/reload-subresource-when-type-changes.html might be flaky
        https://bugs.webkit.org/show_bug.cgi?id=56360

        Onload of the third image might be triggered before that of the second image.
        This might ahppen in environment with slow access (such as NFS, or tests
        accessed through HTTP).

        * loader/reload-subresource-when-type-changes.html:
        * loader/resources/reload-subresource-when-type-changes.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Tue, 12 Apr 2011 03:40:58 +0000 (03:40 +0000)]
2011-04-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Adjust dpi value to viewport computation.
        https://bugs.webkit.org/show_bug.cgi?id=58130

        In viewport computation, EFL port have used 160 value for DPI since now.
        But, we have to use device's dpi value for viewport meta tag computation.

        * ewk/ewk_view.cpp:
        (_ewk_view_viewport_attributes_compute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 John Bates <jbates@google.com>
commit-queue@webkit.org [Tue, 12 Apr 2011 02:30:01 +0000 (02:30 +0000)]
2011-04-11  John Bates  <jbates@google.com>

        Reviewed by Kenneth Russell.

        chromium support for glSetLatch and glWaitLatch between 3D contexts
        https://bugs.webkit.org/show_bug.cgi?id=58003

        * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
        (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
        (WebCore::Canvas2DLayerChromium::setDrawingBuffer):
        (WebCore::Canvas2DLayerChromium::setLayerRenderer):
        * platform/graphics/chromium/Canvas2DLayerChromium.h:
        * platform/graphics/chromium/Extensions3DChromium.h:
        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::Cubic::Cubic):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::updateAndDrawLayers):
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::addChildContext):
        (WebCore::LayerRendererChromium::removeChildContext):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/WebGLLayerChromium.cpp:
        (WebCore::WebGLLayerChromium::~WebGLLayerChromium):
        (WebCore::WebGLLayerChromium::updateCompositorResources):
        (WebCore::WebGLLayerChromium::setContext):
        (WebCore::WebGLLayerChromium::setLayerRenderer):
        * platform/graphics/chromium/WebGLLayerChromium.h:
2011-04-11  John Bates  <jbates@google.com>

        Reviewed by Kenneth Russell.

        chromium support for glSetLatch and glWaitLatch between 3D contexts
        https://bugs.webkit.org/show_bug.cgi?id=58003

        * public/WebGraphicsContext3D.h:
        (WebKit::WebGraphicsContext3D::getParentToChildLatchCHROMIUM):
        (WebKit::WebGraphicsContext3D::getChildToParentLatchCHROMIUM):
        (WebKit::WebGraphicsContext3D::waitLatchCHROMIUM):
        (WebKit::WebGraphicsContext3D::setLatchCHROMIUM):
        * src/Extensions3DChromium.cpp:
        (WebCore::Extensions3DChromium::waitLatchCHROMIUM):
        (WebCore::Extensions3DChromium::setLatchCHROMIUM):
        * src/GraphicsContext3DChromium.cpp:
        * src/GraphicsContext3DInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Alexey Marinichev <amarinichev@chromium.org>
commit-queue@webkit.org [Tue, 12 Apr 2011 02:22:06 +0000 (02:22 +0000)]
2011-04-11  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by James Robinson.

        LayerChromium/CCLayerImpl ownership fix
        https://bugs.webkit.org/show_bug.cgi?id=58283

        CCLayerImpl's m_owner field lifetime should match the lifetime of the
        corresponding LayerChromium.  This change moves resetting of m_owner
        into LayerChromium's destructor.

        Tested similarly to bug 57577.

        * platform/graphics/chromium/LayerChromium.cpp:
        (WebCore::LayerChromium::~LayerChromium):
        * platform/graphics/chromium/cc/CCLayerImpl.cpp:
        (WebCore::CCLayerImpl::cleanupResources):
        * platform/graphics/chromium/cc/CCLayerImpl.h:
        (WebCore::CCLayerImpl::resetOwner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 12 Apr 2011 02:10:14 +0000 (02:10 +0000)]
2011-04-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
        <rdar://problem/8981346>
        https://bugs.webkit.org/show_bug.cgi?id=54159

        * platform/mac-wk2/Skipped:
        Remove http/tests/security/aboutBlank/security-context-window-open.html from the skipped list.
2011-04-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
        <rdar://problem/8981346>
        https://bugs.webkit.org/show_bug.cgi?id=54159

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::InjectedBundlePage):
        (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
        (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
        (WTR::InjectedBundlePage::decidePolicyForResponse):
        (WTR::InjectedBundlePage::unableToImplementPolicy):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
        Add short-circuited policy client which matches WebKit1.

        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetStateToConsistentValues):
        Clear the cache between tests to ensure consistent results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Tue, 12 Apr 2011 01:38:04 +0000 (01:38 +0000)]
2011-04-11  Daniel Bates  <dbates@rim.com>

        Attempt to fix the GTK build after changeset 83527 <http://trac.webkit.org/changeset/83527>
        (https://bugs.webkit.org/show_bug.cgi?id=53556).

        * GNUmakefile.list.am: Append files HTMLTrackElement.{h, cpp} to the list webcore_sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 12 Apr 2011 01:33:48 +0000 (01:33 +0000)]
2011-04-11  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        [chromium] Crash in WebViewImpl::caretOrSelectionBounds
        https://bugs.webkit.org/show_bug.cgi?id=58269

        The bug was caused by caretOrSelectionBounds's incorrectly assuming
        SelectionController::toNormalizedRange to always return a non-null Range.

        Fixed the bug by adding a null pointer check. Also replaced calls to deprecatedNode
        by containerNode() and calls to SelectionController::start() and SelectionController::end()
        by calls to SelectionController::base() and SelectionController::extent() because
        selection extends from base to extent, not from start to end.

        Test: editing/selection/extend-over-file-input-by-drag-crash.html

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::caretOrSelectionBounds):
2011-04-11  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        [chromium] Crash in WebViewImpl::caretOrSelectionBounds
        https://bugs.webkit.org/show_bug.cgi?id=58269

        Added a test to ensure WebKit does not crash when selecting over a file input element.
        While the bug was specific to Chromium port, the test will be run on all ports because
        all other ports should not crash either.

        * editing/selection/extend-over-file-input-by-drag-crash-expected.txt: Added.
        * editing/selection/extend-over-file-input-by-drag-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9251515> and https://bugs.webkit.org/show_bug.cgi?id=58072
beidson@apple.com [Tue, 12 Apr 2011 01:27:57 +0000 (01:27 +0000)]
<rdar://problem/9251515> and https://bugs.webkit.org/show_bug.cgi?id=58072
URLs accessed as a result of pushState/replaceState should count as "visited" and be in the global history

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/loader/stateobjects/state-url-sets-links-visited.html

* loader/HistoryController.cpp:
(WebCore::HistoryController::pushState): Notify the history client and add the visited link.
(WebCore::HistoryController::replaceState): Ditto.

LayoutTests:

* fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Added.
* fast/loader/stateobjects/state-url-sets-links-visited.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 George Guo <George.Guo@nokia.com>
commit-queue@webkit.org [Tue, 12 Apr 2011 01:13:17 +0000 (01:13 +0000)]
2011-04-11  George Guo  <George.Guo@nokia.com>

        Reviewed by Eric Seidel.

        prepare-ChangeLog support email input but -h did not show the option
        https://bugs.webkit.org/show_bug.cgi?id=58164

        Add email option to -h to improve the usability

        * Scripts/prepare-ChangeLog:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 12 Apr 2011 01:06:06 +0000 (01:06 +0000)]
2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Carlson.

        Rename MediaControls to MediaControlRootElement.
        https://bugs.webkit.org/show_bug.cgi?id=58250

        * Scripts/do-webcore-rename: Documented the renaming.
2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Carlson.

        Rename MediaControls to MediaControlRootElement.
        https://bugs.webkit.org/show_bug.cgi?id=58250

        Mechanical move using do-webcore-rename.
2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Carlson.

        Rename MediaControls to MediaControlRootElement.
        https://bugs.webkit.org/show_bug.cgi?id=58250

        Mechanical move using do-webcore-rename.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Dean Jackson <dino@apple.com>
dino@apple.com [Tue, 12 Apr 2011 00:37:50 +0000 (00:37 +0000)]
2011-04-11  Dean Jackson  <dino@apple.com>

        Reviewed by Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=58285
        CompositeAnimation is cleared while an AnimationBase is waiting for notification

        Occasionally hardware animations would trigger a state where
        they would tell the AnimationControllerPrivate that it should notify
        any waiting animations that they are ready to start, even though
        the RenderObject had gone away and hence the CompositeAnimation
        had been destroyed. The fix is to zero the pointer from AnimationBase
        when the CompositeAnimation destructor runs (or its animations are
        cleared) and test the validity of the CompositeAnimation before it
        is used in AnimationBase.

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::updateStateMachine):
        (WebCore::AnimationBase::fireAnimationEventsIfNeeded):
        (WebCore::AnimationBase::updatePlayState):
        (WebCore::AnimationBase::freezeAtTime):
        (WebCore::AnimationBase::beginAnimationUpdateTime):
        - test that the CompositeAnimation exists
        * page/animation/AnimationBase.h:
        (WebCore::AnimationBase::clear):
        - rename clearRenderer() to clear() as it now also clears the CompositeAnimation
        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::clearRenderer):
        (WebCore::CompositeAnimation::updateKeyframeAnimations):
        - call clear() rather than clearRenderer()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Justin Novosad <junov@chromium.org>
commit-queue@webkit.org [Tue, 12 Apr 2011 00:31:31 +0000 (00:31 +0000)]
2011-04-11  Justin Novosad  <junov@chromium.org>

        Reviewed by Kenneth Russell.

        [Chromium] Text anti-aliasing fails when rendering text with shadow
        https://bugs.webkit.org/show_bug.cgi?id=57584

        * platform/chromium/test_expectations.txt:
        Tempoaray test failures that will need to be rebaselined
2011-04-11  Justin Novosad  <junov@chromium.org>

        Reviewed by Kenneth Russell.

        [Chromium] Text anti-aliasing fails when rendering text with shadow
        https://bugs.webkit.org/show_bug.cgi?id=57584

        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::drawGlyphsWin): new static function, code factored-out
        from WebCore::Font::drawGlyphs
        (WebCore::Font::drawGlyphs): may separate font rendering into two
        passes to allow foreground glyphs to be rendered with GDI when Skia
        is required for rendering shadows
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::windowsCanHandleDrawTextShadow):
        Modified method so that it does not assume a shadow is present, and
        returns true if there is no shadow (GDI can draw 'no shadow')
        (WebCore::windowsCanHandleTextDrawing):
        Factored out into sub methods so that the the shadow and foregound
        glyph properties can be tested separately independently.
        (WebCore::windowsCanHandleTextDrawingWithoutShadow):
        New method returns true if the foreground glyph only has effect
        that can be draw with GDI
        (WebCore::paintSkiaText):
        * platform/graphics/skia/SkiaFontWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 12 Apr 2011 00:16:10 +0000 (00:16 +0000)]
2011-04-11  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed, rolling out r83515.
        http://trac.webkit.org/changeset/83515
        https://bugs.webkit.org/show_bug.cgi?id=57178

        Broke GTK builds. nextOnLineExists and prevOnLineExists are still used in AccessibilityObjectWrapperAtk.cpp.

        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::nextOnLineExists):
        (WebCore::InlineBox::prevOnLineExists):
        * rendering/InlineBox.h:
        (WebCore::InlineBox::InlineBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Tue, 12 Apr 2011 00:13:23 +0000 (00:13 +0000)]
2011-04-11  Alexis Menard  <alexis.menard@openbossa.org>

        Unreviewed build fix for Mac.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReverting, seeing something else still broken. Sorry.
beidson@apple.com [Tue, 12 Apr 2011 00:11:44 +0000 (00:11 +0000)]
Reverting, seeing something else still broken.  Sorry.

* html/HTMLTrackElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the build.
beidson@apple.com [Tue, 12 Apr 2011 00:07:51 +0000 (00:07 +0000)]
Fix the build.

* html/HTMLTrackElement.cpp: Case-sensitive, please.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium test expectations.
jianli@chromium.org [Mon, 11 Apr 2011 23:52:06 +0000 (23:52 +0000)]
Unreviewed, update chromium test expectations.

Mark failed tests in chromium that could be caused by r83514 & r83518.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the build. Don't enable TRACK, whatever that is, in an inconsistent manner.
mrowe@apple.com [Mon, 11 Apr 2011 23:49:26 +0000 (23:49 +0000)]
Fix the build.  Don't enable TRACK, whatever that is, in an inconsistent manner.

Different projects had different settings at the Xcode level, and the Xcode settings didn't match the preprocessor define.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Mon, 11 Apr 2011 23:42:32 +0000 (23:42 +0000)]
2011-04-11  Alexis Menard  <alexis.menard@openbossa.org>

        Unreviewed build fix for Mac.

        An idl file was added in the wrong place.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Windows build.
weinig@apple.com [Mon, 11 Apr 2011 23:37:55 +0000 (23:37 +0000)]
Fix Windows build.

* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Mon, 11 Apr 2011 23:31:47 +0000 (23:31 +0000)]
2011-04-11  Chris Marrin  <cmarrin@apple.com>

        Rubberstamped by Dan Bernstein.

        xhr.responseType = 'arraybuffer' works on Mac but not on Windows
        https://bugs.webkit.org/show_bug.cgi?id=50334

        Got rid of guards around arraybuffer logic in XHR. ArrayBuffer and friends
        are always turned on now, so there's not need for the guard. I reenabled the
        test that was Skipped on Windows and it works now.

        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::markChildren):
        (WebCore::JSXMLHttpRequest::send):
        (WebCore::JSXMLHttpRequest::response):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::responseArrayBuffer):
        (WebCore::XMLHttpRequest::setResponseType):
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::clearResponseBuffers):
        (WebCore::XMLHttpRequest::didReceiveData):
        * xml/XMLHttpRequest.h:
        (WebCore::XMLHttpRequest::optionalResponseArrayBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 11 Apr 2011 23:26:02 +0000 (23:26 +0000)]
2011-04-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Move focus management out of WebKit via  the UIClient
        <rdar://problem/8784068>
        https://bugs.webkit.org/show_bug.cgi?id=58278

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::createOtherPage):
        (WTR::TestController::initialize):
        Add stubs for new UIClient functions.
2011-04-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Move focus management out of WebKit via  the UIClient
        <rdar://problem/8784068>
        https://bugs.webkit.org/show_bug.cgi?id=58278

        * UIProcess/API/C/WKPage.h:
        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage):
        * UIProcess/API/qt/qwkpage_p.h:
        * UIProcess/PageClient.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::setFocus):
        * UIProcess/WebUIClient.cpp:
        (WebKit::WebUIClient::focus):
        (WebKit::WebUIClient::unfocus):
        * UIProcess/WebUIClient.h:
        * UIProcess/gtk/WebView.cpp:
        * UIProcess/gtk/WebView.h:
        * UIProcess/win/WebView.h:
        Remove PageClient::setFocus() in favor of WebUIClient::focus and WebUIClient::unfocus.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-02-03 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 11 Apr 2011 23:23:13 +0000 (23:23 +0000)]
2011-02-03  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] The GTK+ DRT needs an implementation of the PlainTextController
        https://bugs.webkit.org/show_bug.cgi?id=53605

        * platform/gtk/Skipped: Unskipped test which is now passing.
2011-02-03  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] The GTK+ DRT needs an implementation of the PlainTextController
        https://bugs.webkit.org/show_bug.cgi?id=53605

        Added jsValueToDOMRange to DumpRenderTreeSupportGtk. This static method can convert
        a JSValueRef to a WebKitDOMRange. When it's possible to do this with the public
        API, we can remove this method.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::jsValueToDOMRange): Added.
        * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added declaration.
2011-02-03  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] The GTK+ DRT needs an implementation of the PlainTextController
        https://bugs.webkit.org/show_bug.cgi?id=53605

        Add an implementation of the PlainTextController for the GTK+ DRT.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (addControllerToWindow): Added this helper method.
        (webViewWindowObjectCleared): Use the new helper to add EventSender
        and the PlainTextController to the window object.
        * GNUmakefile.am: Added PlainTextController source files.
        * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
        on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
        until that functionality exists somewhere in the WebKitGTK+ stack.
        * DumpRenderTree/gtk/PlainTextController.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the build.
mrowe@apple.com [Mon, 11 Apr 2011 23:17:34 +0000 (23:17 +0000)]
Fix the build.

* JavaScriptCore.xcodeproj/project.pbxproj: Headers used outside of JavaScriptCore need to be marked as private.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Mon, 11 Apr 2011 23:12:26 +0000 (23:12 +0000)]
2011-04-11  Stephen White  <senorblanco@chromium.org>

        Unreviewed; new chromium baselines.

        New chromium-mac-leopard baseline images for tests affected by r83490.

        * platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.png:
        * platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.checksum: Removed.
        * platform/chromium-mac-leopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
        * platform/chromium-mac-leopard/svg/zoom/page/zoom-foreignObject-expected.checksum: Removed.
        * platform/chromium-mac-leopard/svg/zoom/page/zoom-foreignObject-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Anna Cavender <annacc@chromium.org>
alexis.menard@openbossa.org [Mon, 11 Apr 2011 23:11:00 +0000 (23:11 +0000)]
2011-04-11  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Setup ENABLE(TRACK) feature define
        https://bugs.webkit.org/show_bug.cgi?id=53556

        * configure.ac:
2011-04-11  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Setup ENABLE(TRACK) feature define
        https://bugs.webkit.org/show_bug.cgi?id=53556

        * Configurations/FeatureDefines.xcconfig:
2011-04-11  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
        https://bugs.webkit.org/show_bug.cgi?id=53556

        * WebKit.xcodeproj/project.pbxproj:
2011-04-11  Anna Cavender  <annacc@chromium.org>

        Reviewed by Eric Carlson.

        Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
        https://bugs.webkit.org/show_bug.cgi?id=53556

        No new tests. No real functionality added just yet.

        * CMakeLists.txt:
        * CodeGenerators.pri:
        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.make:
        * GNUmakefile.am:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * features.pri:
        * html/HTMLAttributeNames.in:
        * html/HTMLTagNames.in:
        * html/HTMLTrackElement.cpp: Added.
        (WebCore::HTMLTrackElement::HTMLTrackElement):
        (WebCore::HTMLTrackElement::create):
        (WebCore::HTMLTrackElement::insertedIntoTree):
        (WebCore::HTMLTrackElement::willRemove):
        (WebCore::HTMLTrackElement::src):
        (WebCore::HTMLTrackElement::setSrc):
        (WebCore::HTMLTrackElement::kind):
        (WebCore::HTMLTrackElement::setKind):
        (WebCore::HTMLTrackElement::srclang):
        (WebCore::HTMLTrackElement::setSrclang):
        (WebCore::HTMLTrackElement::label):
        (WebCore::HTMLTrackElement::setLabel):
        (WebCore::HTMLTrackElement::isDefault):
        (WebCore::HTMLTrackElement::setIsDefault):
        (WebCore::HTMLTrackElement::isURLAttribute):
        * html/HTMLTrackElement.h: Added.
        * html/HTMLTrackElement.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-04-11 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Mon, 11 Apr 2011 23:06:22 +0000 (23:06 +0000)]
2011-04-11  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=57535

        Better compile fix for Solaris 10/Sun Studio 12 CC
        needing <sys/time.h>

        * loader/icon/IconRecord.h:
        * page/Page.h:
        * platform/network/ResourceResponseBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83526 268f45cc-cd09-0410-ab3c-d52691b4dbfc