WebKit-https.git
6 years ago[WK2] callOnMainThread() from main thread sometimes results in ASSERTs.
jer.noble@apple.com [Mon, 27 Jan 2014 21:16:50 +0000 (21:16 +0000)]
[WK2] callOnMainThread() from main thread sometimes results in ASSERTs.
https://bugs.webkit.org/show_bug.cgi?id=127370

Reviewed by Alexey Proskuryakov.

When WEB_THREAD is enabled, and callOnMainThread() is called from the main
thread, if the web thread is locked, a timer is set and the passed-in function
is called on the next run-loop. However, by that time the web thread may have
been unlocked, and isMainThread() will no longer return true, resulting in
an assert.

Instead, scheduleDispatchFunctionsOnMainThread() should check isWebThread(),
which is equivalent to isMainThread() when the WEB_THREAD is disabled, but
will do the correct thing when WEB_THREAD is enabled.

* wtf/mac/MainThreadMac.mm:
(WTF::scheduleDispatchFunctionsOnMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the build on case-sensitive filesystems
timothy_horton@apple.com [Mon, 27 Jan 2014 20:53:33 +0000 (20:53 +0000)]
Fix the build on case-sensitive filesystems

* WebProcess/WebPage/ViewGestureGeometryCollector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r162837): fast/writing-mode/ruby-text-logical-left.html fails on WK1
antti@apple.com [Mon, 27 Jan 2014 20:52:17 +0000 (20:52 +0000)]
REGRESSION(r162837): fast/writing-mode/ruby-text-logical-left.html fails on WK1

* TestExpectations: skip for now

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix.
mitz@apple.com [Mon, 27 Jan 2014 20:51:35 +0000 (20:51 +0000)]
Build fix.

* wtf/ThreadSafeRefCounted.h: Added a necessary #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIDB: Refactor out the last of the operation callbacks that are called by the LevelDB...
beidson@apple.com [Mon, 27 Jan 2014 20:34:55 +0000 (20:34 +0000)]
IDB: Refactor out the last of the operation callbacks that are called by the LevelDB backing store
https://bugs.webkit.org/show_bug.cgi?id=127592

Reviewed by Tim Horton.

Source/WebCore:

For each of the 3 remaining operations where the backing store calls callbacks directly,
factor out the callbacks to the operation itself.

* Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
* Modules/indexeddb/IDBTransactionBackendOperations.h:

* Modules/indexeddb/IDBServerConnection.h:
* Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::openCursor):
(WebCore::IDBServerConnectionLevelDB::count):
(WebCore::IDBServerConnectionLevelDB::deleteRange):
* Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

Source/WebKit2:

Update the WebIDBServerConnection to the new callback signatures:
* WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::count):
* WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r162755.
commit-queue@webkit.org [Mon, 27 Jan 2014 20:31:09 +0000 (20:31 +0000)]
Unreviewed, rolling out r162755.
http://trac.webkit.org/changeset/162755
https://bugs.webkit.org/show_bug.cgi?id=127696

not quite right, breaks subframe scrolling in some cases
(Requested by thorton on #webkit).

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::removeDestroyedNodes):
* page/scrolling/ScrollingTree.h:
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebKit2 View Gestures: Fluid back-forward swipe
timothy_horton@apple.com [Mon, 27 Jan 2014 20:21:21 +0000 (20:21 +0000)]
WebKit2 View Gestures: Fluid back-forward swipe
https://bugs.webkit.org/show_bug.cgi?id=127363

Reviewed by Anders Carlsson.

Add support for a "back-forward swipe", which allows fluid swiping between
items in the back-forward list. Currently disabled by default.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetViewGestureDebuggingEnabled):
(WKPreferencesGetViewGestureDebuggingEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:
Add a ViewGestureDebuggingEnabled preference, which currently causes snapshots to be blurred.
Additional view gesture debugging features could come in the future.

* UIProcess/API/Cocoa/WKViewPrivate.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _ensureGestureController]):
(-[WKView scrollWheel:]):
If back-forward navigation gestures are enabled, intercept scrollWheel events
on the WKView and let the ViewGestureController take the first crack at them.

(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):
* UIProcess/API/mac/WKViewInternal.h:
Add allowsBackForwardNavigationGesture property, which enables the gesture.

* UIProcess/mac/ViewGestureController.h:
Add swipe-related methods, which will be described below.

Add an enum for the swipe transition style. Currently only Overlap is accessible,
but in the future one could see having API to choose the style.
'Overlap' has the outgoing page swipe out to the right (when swiping right)
or the incoming page swipe in from the right (when swiping left).
'Push' has the pages push each other along in sync, as if all the pages in the
back-forward list were oriented from left to right.

* UIProcess/mac/ViewGestureController.messages.in:
* UIProcess/mac/ViewGestureController.mm: Renamed from Source/WebKit2/UIProcess/mac/ViewGestureController.cpp.
Use some CAFilter SPI to blur the snapshot if ViewGestureDebuggingEnabled is on.

(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::~ViewGestureController):
(WebKit::ViewGestureController::endMagnificationGesture):
Move m_activeGestureType clearing to each end* function instead of one global place,
so that each gesture can handle when it ends separately.

(WebKit::ViewGestureController::handleScrollWheelEvent):
If we receive a scroll wheel event which is appropriate for starting a
fluid swipe, in a direction where the main frame is pinned to the appropriate
edge of the view, start tracking a swipe.

This should eventually have some hysterisis to avoid stealing scrolls that
venture into the wrong direction, but for now it starts tracking immediately.

Forward events from the tracking loop to {begin, handle, end}SwipeGesture.

(WebKit::ViewGestureController::beginSwipeGesture):
Create a layer with the destination page's snapshot, and set it up.

(WebKit::ViewGestureController::handleSwipeGesture):
Appropriately adjust the position of the root layer and snapshot layer,
given the transition style and swipe direction.

(WebKit::ViewGestureController::endSwipeGesture):
When the gesture ends, do the navigation, and tell the WebProcess to
inform us when the render tree hits half the size it was when the
snapshot was taken (when that happens, we will remove the snapshot
and the gesture will be truly complete). Also, start a watchdog timer
in case the render tree never hits that size, after which we will
also remove the snapshot.

(WebKit::ViewGestureController::didHitRenderTreeSizeThreshold):
(WebKit::ViewGestureController::swipeSnapshotWatchdogTimerFired):
(WebKit::ViewGestureController::removeSwipeSnapshot):
Tear down the swipe snapshot layer, and mark our current gesture as complete.

(WebKit::ViewGestureController::endActiveGesture):
Simplify endActiveGesture; it only has work to do for a pinch-zoom gesture,
as those are the only gestures where the user is directly in control of when they end.

* WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::ViewGestureGeometryCollector):
(WebKit::ViewGestureGeometryCollector::mainFrameDidLayout):
(WebKit::ViewGestureGeometryCollector::renderTreeSizeNotificationTimerFired):
* WebProcess/WebPage/ViewGestureGeometryCollector.h:
(WebKit::ViewGestureGeometryCollector::setRenderTreeSizeNotificationThreshold):
* WebProcess/WebPage/ViewGestureGeometryCollector.messages.in:
ViewGestureController pushes a render-tree size threshold to the WebProcess;
ViewGestureGeometryCollector (whose name is now more unfortunate than before)
monitors render-tree size changes and informs ViewGestureController when
it reaches that threshold via the 'DidHitRenderTreeSizeThreshold' message.

* UIProcess/API/Cocoa/WKViewPrivate.h:
* UIProcess/API/ios/PageClientImplIOS.h:
* UIProcess/API/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::acceleratedCompositingRootLayer):
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::acceleratedCompositingRootLayer):
* UIProcess/API/mac/WKView.mm:
(-[WKView _acceleratedCompositingModeRootLayer]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::acceleratedCompositingRootLayer):
Add a getter for the accelerated compositing root layer.

* UIProcess/mac/ViewSnapshotStore.mm:
(WebKit::ViewSnapshotStore::snapshotAndRenderTreeSize):
Don't extract the CGImageRef from a RetainPtr just to put it back in one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r162846.
commit-queue@webkit.org [Mon, 27 Jan 2014 19:49:10 +0000 (19:49 +0000)]
Unreviewed, rolling out r162846.
http://trac.webkit.org/changeset/162846
https://bugs.webkit.org/show_bug.cgi?id=127695

"Broke the WebKit Bot Watcher's Dashboard; will fix offline"
(Requested by dydz on #webkit).

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype.update.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] inset() function with multiple spaces on element style
zoltan@webkit.org [Mon, 27 Jan 2014 19:15:25 +0000 (19:15 +0000)]
[CSS Shapes] inset() function with multiple spaces on element style
https://bugs.webkit.org/show_bug.cgi?id=127617

Reviewed by Dirk Schulze.

Source/WebCore:

When only a subset of parameters were defined for an inset shape, the built
inset string contained some extra spaces. This patch fixes the behavior and
adds tests for the case. I also removed the string allocation optimization from
buildInsetString, since it's not worthwhile to always allocate as many memory
as needed for a fully defined inset.

I added the new test cases to the shapes parser code test.

* css/CSSBasicShapes.cpp:
(WebCore::buildInsetString):

LayoutTests:

* fast/shapes/parsing/parsing-shape-inside-expected.txt:
* fast/shapes/parsing/parsing-shape-outside-expected.txt:
* fast/shapes/parsing/parsing-test-utils.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd support for displaying results from multiple Buildbots on WebKit Bot Watcher...
dbates@webkit.org [Mon, 27 Jan 2014 19:08:51 +0000 (19:08 +0000)]
Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
https://bugs.webkit.org/show_bug.cgi?id=127564

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTeach Buildbot dashboard to parse alternative revision format
dbates@webkit.org [Mon, 27 Jan 2014 19:06:40 +0000 (19:06 +0000)]
Teach Buildbot dashboard to parse alternative revision format
https://bugs.webkit.org/show_bug.cgi?id=127561

Reviewed by Alexey Proskuryakov.

Add support for extracting the OpenSource and Internal revision numbers when Buildbot
returns a dictionary for the value of property got_revision.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
string or a dictionary.
(BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
the OpenSource and Internal revision numbers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unused CodeBlock::createActivation().
mark.lam@apple.com [Mon, 27 Jan 2014 18:53:26 +0000 (18:53 +0000)]
Remove unused CodeBlock::createActivation().
<https://webkit.org/b/127686>

Reviewed by Filip Pizlo.

* bytecode/CodeBlock.cpp:
* bytecode/CodeBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago* WebCore.exp.in: Add export needed for iOS.
antti@apple.com [Mon, 27 Jan 2014 17:48:04 +0000 (17:48 +0000)]
* WebCore.exp.in: Add export needed for iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r133214): Don't invalidate style when adding classes that don't match...
antti@apple.com [Mon, 27 Jan 2014 17:12:46 +0000 (17:12 +0000)]
REGRESSION(r133214): Don't invalidate style when adding classes that don't match rules
https://bugs.webkit.org/show_bug.cgi?id=126177

Reviewed by Anders Carlsson.

Spotted by Elliott Sprehn in Chromium.

* dom/Element.cpp:
(WebCore::checkSelectorForClassChange):

    Remove unnecessary templating.

(WebCore::Element::classAttributeChanged):

    Fix logic error with 'continue'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GStreamer] Lockup when playing Icecast radio
b.long@cablelabs.com [Mon, 27 Jan 2014 16:57:30 +0000 (16:57 +0000)]
[GStreamer] Lockup when playing Icecast radio
https://bugs.webkit.org/show_bug.cgi?id=127452

Reviewed by Philippe Normand.

No new tests. This bug can only be demonstrated with an Icecast stream, and it's
not clear how to do that in our testing framework.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::handleResponseReceived): Wait until we unlock to send notifications.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTypo fix after r162838.
ossy@webkit.org [Mon, 27 Jan 2014 16:49:42 +0000 (16:49 +0000)]
Typo fix after r162838.

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix after r162838.
jberlin@webkit.org [Mon, 27 Jan 2014 16:31:24 +0000 (16:31 +0000)]
Build fix after r162838.

* page/FrameView.cpp:
Remove an unused constant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove repaint throttling
hyatt@apple.com [Mon, 27 Jan 2014 16:27:45 +0000 (16:27 +0000)]
Remove repaint throttling
https://bugs.webkit.org/show_bug.cgi?id=127681

Patch by Antti Koivisto <antti@apple.com> on 2014-01-27
Reviewed by Sam Weinig.

Nowadays we throttle layer flushes. This code is unnecessary.

* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* dom/Element.cpp:
(WebCore::Element::classAttributeChanged):
* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::insertDictatedText):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::layout):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
* page/FrameView.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::setSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening, unskip now passing tests.
ossy@webkit.org [Mon, 27 Jan 2014 16:18:06 +0000 (16:18 +0000)]
Unreviewed gardening, unskip now passing tests.

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove repaint throttling
antti@apple.com [Mon, 27 Jan 2014 15:11:08 +0000 (15:11 +0000)]
Remove repaint throttling
https://bugs.webkit.org/show_bug.cgi?id=127681

Reviewed by Sam Weinig.

Nowadays we throttle layer flushes. This code is unnecessary.

* WebCore.exp.in:
* dom/Document.cpp:
(WebCore::Document::recalcStyle):
* dom/Element.cpp:
(WebCore::Element::classAttributeChanged):
* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::insertDictatedText):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::reset):
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::layout):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
* page/FrameView.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::setSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMerge Chromium TextTrack cleanups
eric.carlson@apple.com [Mon, 27 Jan 2014 15:05:44 +0000 (15:05 +0000)]
Merge Chromium TextTrack cleanups
https://bugs.webkit.org/show_bug.cgi?id=127483

Reviewed by Darin Adler.

Merge some TextTrack cleanups:
https://chromium.googlesource.com/chromium/blink/+/b571b9fbc6e62e05aa77a402cf8f447e681b8ee3
https://chromium.googlesource.com/chromium/blink/+/6b1940151258150ea01bcf21ebfd958e2af247f4
https://chromium.googlesource.com/chromium/blink/+/397c2a2d9416f5c0d79bca22d6979f174eefcce2
https://chromium.googlesource.com/chromium/blink/+/f42ad93e25c6310b2b0327ab7ce5d82d3c4a6c1b
https://chromium.googlesource.com/chromium/blink/+/d55b52b53b7da05bba5fe378a4278250b9347430
https://chromium.googlesource.com/chromium/blink/+/cac766ecaaac477a08879f0b3157d0327cc75d96
https://chromium.googlesource.com/chromium/blink/+/6197ce278696cdd52fc2ad81893f369492468ca0

* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::loadTimerFired): Remove the LoadableTextTrack* parameter, it isn't used.
(WebCore::HTMLTrackElement::didCompleteLoad): Ditto.
* html/HTMLTrackElement.h: didCompleteLoad doesn't need to be virtual.

* html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::loadTimerFired): Pass a reference, not a pointer.
(WebCore::LoadableTextTrack::cueLoadingStarted): Removed, it wasn't used.
(WebCore::LoadableTextTrack::cueLoadingCompleted): Pass a reference, not a pointer.
* html/track/LoadableTextTrack.h: Delete LoadableTextTrackClient, it is no longer used.

* loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::TextTrackLoader): Take a TextTrackLoaderClient reference.
(WebCore::TextTrackLoader::~TextTrackLoader): Rename m_cachedCueData m_resource.
(WebCore::TextTrackLoader::cueLoadTimerFired): m_client is a reference.
(WebCore::TextTrackLoader::cancelLoad): m_cachedCueData -> m_resource.
(WebCore::TextTrackLoader::processNewCueData): Ditto.
(WebCore::TextTrackLoader::deprecatedDidReceiveCachedResource): Ditto.
(WebCore::TextTrackLoader::notifyFinished): Ditto.
(WebCore::TextTrackLoader::load): shouldLoadCues was removed from the client interface because
    the only implementation always returned true.
(WebCore::TextTrackLoader::newRegionsParsed): m_client is a reference
* loader/TextTrackLoader.h:

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest): Remove an outdated comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Implement custom URI schemes with CustomProtocols
carlosgc@webkit.org [Mon, 27 Jan 2014 13:14:49 +0000 (13:14 +0000)]
[GTK] Implement custom URI schemes with CustomProtocols
https://bugs.webkit.org/show_bug.cgi?id=127091

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

The old classes are no longer built for GTK+ and should be removed once
other ports using soup backend switch to custom protocols implementation.

* GNUmakefile.am: Remove include path.
* GNUmakefile.list.am: Remove files from compilation.
* PlatformGTK.cmake: Ditto.
* UIProcess/API/gtk/WebKitPrivate.h:
* UIProcess/API/gtk/WebKitRequestManagerClient.cpp:
(startLoading):
(stopLoading):
(attachRequestManagerClientToContext):
* UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
(webkitURISchemeRequestCreate):
(webkit_uri_scheme_request_get_web_view):
(webkitURISchemeRequestReadCallback):
(webkit_uri_scheme_request_finish):
(webkit_uri_scheme_request_finish_error):
* UIProcess/API/gtk/WebKitURISchemeRequestPrivate.h:
* UIProcess/API/gtk/WebKitWebContext.cpp:
(createDefaultWebContext):
(webkit_web_context_register_uri_scheme):
(webkitWebContextGetRequestManager):
(webkitWebContextStartLoadingCustomProtocol):
(webkitWebContextStopLoadingCustomProtocol):
(webkitWebContextDidFinishLoadingCustomProtocol):
* UIProcess/API/gtk/WebKitWebContextPrivate.h:
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformInitializeWebProcess):
* WebKit2Prefix.h: Enable CustomProtocols unconditionally for the
GTK+ port.

Tools:

Temporarily disable the WebKitWebView check until we figure out
how to implement it with CustomProtocols.

* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Disable accessibility after every test run
ossy@webkit.org [Mon, 27 Jan 2014 12:40:18 +0000 (12:40 +0000)]
AX: Disable accessibility after every test run
https://bugs.webkit.org/show_bug.cgi?id=127439

Patch by Chris Fleizach <cfleizach@apple.com> on 2014-01-27
Reviewed by Csaba Osztrogon√°c.

Speculative fix for EFL build. Don't process these notifications unless accessibility is enabled.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForLoadStart):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuildfix for !ENABLE(COMPARE_AND_SWAP) platforms after r162774
ossy@webkit.org [Mon, 27 Jan 2014 11:13:19 +0000 (11:13 +0000)]
Buildfix for !ENABLE(COMPARE_AND_SWAP) platforms after r162774
https://bugs.webkit.org/show_bug.cgi?id=127678

Reviewed by Zoltan Herczeg.

* platform/text/TextBreakIterator.cpp:
(WebCore::compareAndSwapNonSharedCharacterBreakIterator):
Use std::mutex instead of Mutex and std::lock_guard instead of MutexLocker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] fast/profiler/stop-profiling-after-setTimeout.html and fast/profiler/dead-time...
ossy@webkit.org [Mon, 27 Jan 2014 10:46:31 +0000 (10:46 +0000)]
[Mac] fast/profiler/stop-profiling-after-setTimeout.html and fast/profiler/dead-time.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=84102

Reviewed by Darin Adler.

* fast/profiler/dead-time-expected.txt: Updated.
* fast/profiler/stop-profiling-after-setTimeout-expected.txt: Updated.
* platform/efl/TestExpectations: Unskip tests.
* platform/gtk/fast/profiler/dead-time-expected.txt: Removed.
* platform/gtk/fast/profiler/stop-profiling-after-setTimeout-expected.txt: Removed.
* platform/mac/TestExpectations: Unskip tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAnother iOS build fix.
timothy_horton@apple.com [Mon, 27 Jan 2014 09:09:18 +0000 (09:09 +0000)]
Another iOS build fix.

* Misc/WebElementDictionary.mm:
(-[WebElementDictionary _image]):
We were apparently depending on Image::getNSImage() being defined
(yet always returning nullptr) on iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[SOUP] WebProcess sometimes crashes when a download is cancelled
carlosgc@webkit.org [Mon, 27 Jan 2014 08:27:01 +0000 (08:27 +0000)]
[SOUP] WebProcess sometimes crashes when a download is cancelled
https://bugs.webkit.org/show_bug.cgi?id=127650

Reviewed by Martin Robinson.

The problem is that when the download is cancelled, the download
manager removes the download from the map and it's deleted. The
Download destructor calls platformInvalidate() that cancels the
resource handle if there's still one. We set to nullptr the
ResourceHandle when the download is cancelled to avoid cancelling
it twice, but it's done after calling Download::didCancel(). It
should be done before, because at that moment, when the download
is deleted, the resource handle pointer is still valid.

* Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Fix GTK+ build after r162808.
carlosgc@webkit.org [Mon, 27 Jan 2014 08:18:51 +0000 (08:18 +0000)]
Unreviewed. Fix GTK+ build after r162808.

* webkit/webkitwebhistoryitem.cpp:
(webkit_web_history_item_new_with_data):
(webkit_web_history_item_get_last_visited_time):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the iOS build (failed to correctly revert some broken changes in the last patch).
timothy_horton@apple.com [Mon, 27 Jan 2014 07:33:19 +0000 (07:33 +0000)]
Fix the iOS build (failed to correctly revert some broken changes in the last patch).

* platform/graphics/cg/BitmapImageCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStart cleaning up iOS upstreaming #ifs in platform/graphics
timothy_horton@apple.com [Mon, 27 Jan 2014 07:16:13 +0000 (07:16 +0000)]
Start cleaning up iOS upstreaming #ifs in platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=127641

Reviewed by Sam Weinig.

* platform/graphics/BitmapImage.h:
* platform/graphics/mac/ColorMac.h:
Use USE(APPKIT) instead of PLATFORM(MAC) && !PLATFORM(IOS) for NSImage/getNSImage().

* platform/graphics/avfoundation/AVTrackPrivateAVFObjCImpl.mm:
(WebCore::AVTrackPrivateAVFObjCImpl::label):
* platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
Remove some code that was only used on OS X on Lion or below.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::platformInit):
ToT WebKit doesn't build on Lion or earlier anymore, so this code can always run.

* platform/graphics/cg/FloatPointCG.cpp:
* platform/graphics/cg/FloatRectCG.cpp:
* platform/graphics/cg/FloatSizeCG.cpp:
* platform/graphics/cg/GradientCG.cpp:
* platform/graphics/cg/ImageBufferCG.cpp:
* platform/graphics/cg/ImageCG.cpp:
* platform/graphics/cg/IntPointCG.cpp:
* platform/graphics/cg/IntRectCG.cpp:
* platform/graphics/cg/PathCG.cpp:
* platform/graphics/cg/PatternCG.cpp:
* platform/graphics/mac/FontCustomPlatformData.cpp:
Use CoreGraphics/CoreGraphics.h instead of ApplicationServices/ApplicationServices.h
even on Mac, so we can share the include.

* platform/graphics/cg/IntSizeCG.cpp:
Remove a random comment of a style we don't tend to use in WebKit,
and from a file not large enough to need it.

* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):
Remove some more always-true #ifs.

* platform/graphics/mac/WebLayer.mm:
Move a #if'd include out to its own block as per the style guide.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
ap@apple.com [Mon, 27 Jan 2014 06:23:11 +0000 (06:23 +0000)]
REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.

* DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
Fixed an incorrect ifdef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoJSC: Pack unlinked instructions harder.
akling@apple.com [Mon, 27 Jan 2014 05:45:30 +0000 (05:45 +0000)]
JSC: Pack unlinked instructions harder.
<https://webkit.org/b/127660>

Store UnlinkedCodeBlock's instructions in a variable-length stream
to reduce memory usage. Compression rate ends up around 60-61%.

The format is very simple. Every instruction starts with a 1 byte
opcode. It's followed by an opcode-dependent number of argument
values, each encoded separately for maximum packing. There are
7 packed value formats:

    5-bit positive integer
    5-bit negative integer
    13-bit positive integer
    13-bit positive integer
    5-bit constant register index
    13-bit constant register index
    32-bit value (fallback)

27.5 MB progression on Membuster3. (~2% of total memory.)

Reviewed by Filip Pizlo.

* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/UnlinkedInstructionStream.h: Added.
(JSC::UnlinkedInstructionStream::count):
(JSC::UnlinkedInstructionStream::Reader::atEnd):
* bytecode/UnlinkedInstructionStream.cpp: Added.
(JSC::UnlinkedInstructionStream::Reader::Reader):
(JSC::UnlinkedInstructionStream::Reader::read8):
(JSC::UnlinkedInstructionStream::Reader::read32):
(JSC::UnlinkedInstructionStream::Reader::next):
(JSC::append8):
(JSC::append32):
(JSC::UnlinkedInstructionStream::UnlinkedInstructionStream):
(JSC::UnlinkedInstructionStream::unpackForDebugging):
* bytecompiler/BytecodeGenerator.cpp:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
* bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::lineNumberForBytecodeOffset):
(JSC::dumpLineColumnEntry):
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
(JSC::UnlinkedCodeBlock::setInstructions):
(JSC::UnlinkedCodeBlock::instructions):
* bytecode/UnlinkedCodeBlock.h:
(JSC::BytecodeGenerator::generate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove duplicate settings for ENABLE(DISK_IMAGE_CACHE)
ddkilzer@apple.com [Mon, 27 Jan 2014 05:44:39 +0000 (05:44 +0000)]
Remove duplicate settings for ENABLE(DISK_IMAGE_CACHE)
<http://webkit.org/b/127669>

Reviewed by Joseph Pecoraro.

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Remove duplicate code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are...
b.long@cablelabs.com [Mon, 27 Jan 2014 05:21:49 +0000 (05:21 +0000)]
[GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
https://bugs.webkit.org/show_bug.cgi?id=110602

Reviewed by Philippe Normand.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
(initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[New Multicolumn] Change the axis property to be a boolean like other isInline checks
hyatt@apple.com [Mon, 27 Jan 2014 03:57:22 +0000 (03:57 +0000)]
[New Multicolumn] Change the axis property to be a boolean like other isInline checks
https://bugs.webkit.org/show_bug.cgi?id=127661

Reviewed by Simon Fraser.

* rendering/ColumnInfo.h:
(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::progressionIsInline):
(WebCore::ColumnInfo::setProgressionIsInline):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::initialBlockOffsetForPainting):
(WebCore::RenderBlock::blockDeltaForPaintingNextColumn):
(WebCore::RenderBlock::setComputedColumnCountAndWidth):
(WebCore::RenderBlock::updateColumnInfoFromStyle):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):
* rendering/RenderMultiColumnFlowThread.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::columnNumberForOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake DOMStringMap a typedef of DatasetDOMStringMap
benjamin@webkit.org [Mon, 27 Jan 2014 02:22:34 +0000 (02:22 +0000)]
Make DOMStringMap a typedef of DatasetDOMStringMap
https://bugs.webkit.org/show_bug.cgi?id=127658

Reviewed by Sam Weinig.

The only concrete implementation of DOMStringMap is DatasetDOMStringMap.
The abstract interface for a single definition is adding complexity for no gain.

This patch removes DOMStringMap and simply keeps the name through a typedef.
I used a typedef instead of just renaming DatasetDOMStringMap because I think
having both name has value. DatasetDOMStringMap is a better description of what
the implementation does. DOMStringMap is the public name and the classname is
the same as the JavaScript type by convention.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/DOMStringMap.cpp: Removed.
* dom/DOMStringMap.h:
* dom/DatasetDOMStringMap.h:
* dom/Element.cpp:
(WebCore::Element::dataset):
* dom/Element.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPart 2: Assertion failure in WebCore::PseudoElement::didRecalcStyle()
ddkilzer@apple.com [Mon, 27 Jan 2014 01:34:45 +0000 (01:34 +0000)]
Part 2: Assertion failure in WebCore::PseudoElement::didRecalcStyle()
<https://bugs.webkit.org/show_bug.cgi?id=126761>
<rdar://problem/15793540>

Reviewed by Simon Fraser.

* bindings/objc/DOM.mm:
(-[DOMElement image]):
(-[DOMElement _imageTIFFRepresentation]):
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeImage):
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage):
(WebCore::getCachedImage):
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::image):
- More places where toRenderImage() should be used instead of
  toImage().
- Fixed last two places where static_cast<WebCore::RenderImage*>
  was being used instead of toRenderImage().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening after r162742, r162791 and r162803.
jinwoo7.song@samsung.com [Mon, 27 Jan 2014 01:28:01 +0000 (01:28 +0000)]
Unreviewed EFL gardening after r162742, r162791 and r162803.

* platform/efl-wk1/fast/forms/basic-inputs-expected.png: Removed.
* platform/efl-wk1/fast/forms/indeterminate-expected.png: Removed.
* platform/efl-wk2/fast/forms/basic-inputs-expected.png: Removed.
* platform/efl-wk2/fast/forms/indeterminate-expected.png: Removed.
* platform/efl/compositing/overflow/theme-affects-visual-overflow-expected.png:
* platform/efl/compositing/overflow/theme-affects-visual-overflow-expected.txt:
* platform/efl/css1/box_properties/acid_test-expected.png:
* platform/efl/css1/box_properties/acid_test-expected.txt:
* platform/efl/css2.1/t09-c5526c-display-00-e-expected.png:
* platform/efl/css2.1/t09-c5526c-display-00-e-expected.txt:
* platform/efl/css3/selectors3/html/css3-modsel-25-expected.png:
* platform/efl/css3/selectors3/html/css3-modsel-25-expected.txt:
* platform/efl/css3/selectors3/html/css3-modsel-70-expected.png:
* platform/efl/css3/selectors3/html/css3-modsel-70-expected.txt:
* platform/efl/css3/selectors3/xhtml/css3-modsel-25-expected.png:
* platform/efl/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
* platform/efl/css3/selectors3/xhtml/css3-modsel-70-expected.png:
* platform/efl/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
* platform/efl/css3/selectors3/xml/css3-modsel-25-expected.png:
* platform/efl/css3/selectors3/xml/css3-modsel-25-expected.txt:
* platform/efl/css3/selectors3/xml/css3-modsel-70-expected.png:
* platform/efl/css3/selectors3/xml/css3-modsel-70-expected.txt:
* platform/efl/fast/block/basic/011-expected.png:
* platform/efl/fast/block/basic/011-expected.txt:
* platform/efl/fast/block/margin-collapse/103-expected.png:
* platform/efl/fast/block/margin-collapse/103-expected.txt:
* platform/efl/fast/css/non-standard-checkbox-size-expected.png:
* platform/efl/fast/css/non-standard-checkbox-size-expected.txt:
* platform/efl/fast/forms/001-expected.png:
* platform/efl/fast/forms/001-expected.txt:
* platform/efl/fast/forms/basic-inputs-expected.txt:
* platform/efl/fast/forms/box-shadow-override-expected.png:
* platform/efl/fast/forms/box-shadow-override-expected.txt:
* platform/efl/fast/forms/file/file-input-disabled-expected.png:
* platform/efl/fast/forms/file/file-input-disabled-expected.txt:
* platform/efl/fast/forms/form-element-geometry-expected.png:
* platform/efl/fast/forms/form-element-geometry-expected.txt:
* platform/efl/fast/forms/formmove-expected.png:
* platform/efl/fast/forms/formmove-expected.txt:
* platform/efl/fast/forms/formmove2-expected.png:
* platform/efl/fast/forms/formmove2-expected.txt:
* platform/efl/fast/forms/indeterminate-expected.txt:
* platform/efl/fast/forms/input-appearance-height-expected.png:
* platform/efl/fast/forms/input-appearance-height-expected.txt:
* platform/efl/fast/forms/input-value-expected.png:
* platform/efl/fast/forms/input-value-expected.txt:
* platform/efl/fast/forms/search-vertical-alignment-expected.png:
* platform/efl/fast/forms/search-vertical-alignment-expected.txt:
* platform/efl/fast/forms/searchfield-heights-expected.png:
* platform/efl/fast/forms/searchfield-heights-expected.txt:
* platform/efl/fast/inline/positionedLifetime-expected.png:
* platform/efl/fast/inline/positionedLifetime-expected.txt:
* platform/efl/fast/parser/bad-xml-slash-expected.png:
* platform/efl/fast/parser/bad-xml-slash-expected.txt:
* platform/efl/fast/replaced/replaced-breaking-expected.png:
* platform/efl/fast/replaced/replaced-breaking-expected.txt:
* platform/efl/fast/replaced/width100percent-checkbox-expected.png:
* platform/efl/fast/replaced/width100percent-checkbox-expected.txt:
* platform/efl/fast/replaced/width100percent-radio-expected.png:
* platform/efl/fast/replaced/width100percent-radio-expected.txt:
* platform/efl/fast/text/textIteratorNilRenderer-expected.png:
* platform/efl/fast/text/textIteratorNilRenderer-expected.txt:
* platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
* platform/efl/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
* platform/efl/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/efl/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/efl/tables/mozilla/bugs/bug1318-expected.png:
* platform/efl/tables/mozilla/bugs/bug1318-expected.txt:
* platform/efl/tables/mozilla/bugs/bug4527-expected.png:
* platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
* platform/efl/tables/mozilla_expected_failures/core/captions1-expected.png:
* platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/efl/tables/mozilla_expected_failures/core/captions2-expected.png:
* platform/efl/tables/mozilla_expected_failures/core/captions2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix on the EFL build since r162808
ryuan.choi@samsung.com [Mon, 27 Jan 2014 00:44:51 +0000 (00:44 +0000)]
Unreviewed build fix on the EFL build since r162808

lastVisitedTime and visitCount are removed from WebCore::HistoryItem

* ewk/ewk_history.cpp:
(ewk_history_item_new):
(ewk_history_item_time_last_visited_get):
(ewk_history_item_visit_count):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Upstream changes in Tools/DumpRenderTree
aestes@apple.com [Mon, 27 Jan 2014 00:01:15 +0000 (00:01 +0000)]
[iOS] Upstream changes in Tools/DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=127412

Reviewed by Simon Fraser.

Source/WebKit/mac:

* Misc/WebCoreStatistics.h: Included CGContext.h.

Tools:

Upstream all iOS changes. Added a new target called DumpRenderTree.app,
which builds the DumpRenderTree static library into an app bundle as
expected by the iOS Simulator.

* DumpRenderTree/AccessibilityTextMarker.h:
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
* DumpRenderTree/DumpRenderTreePrefix.h:
* DumpRenderTree/PixelDumpSupport.cpp:
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
* DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
* DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
* DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
* DumpRenderTree/TestNetscapePlugIn/TestObject.h:
* DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
* DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
* DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
* DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
* DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
* DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
* DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
* DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
* DumpRenderTree/TestNetscapePlugIn/main.cpp:
* DumpRenderTree/TestRunner.cpp:
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/cg/ImageDiffCG.cpp:
* DumpRenderTree/cg/PixelDumpSupportCG.cpp:
* DumpRenderTree/ios/AccessibilityControllerIOS.mm:
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
* DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
* DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
* DumpRenderTree/ios/Info.plist: Added.
* DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
* DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
* DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
* DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
* DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
* DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
* DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
* DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
* DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
* DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
* DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
* DumpRenderTree/ios/PerlSupport/Makefile: Added.
* DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
* DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
* DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
* DumpRenderTree/mac/AppleScriptController.m:
* DumpRenderTree/mac/Configurations/Base.xcconfig:
* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
* DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
* DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
* DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
* DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
* DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
* DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
* DumpRenderTree/mac/DumpRenderTree.mm:
* DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
* DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
* DumpRenderTree/mac/DumpRenderTreeMac.h:
* DumpRenderTree/mac/DumpRenderTreePasteboard.h:
* DumpRenderTree/mac/DumpRenderTreePasteboard.m:
* DumpRenderTree/mac/DumpRenderTreeWindow.h:
* DumpRenderTree/mac/DumpRenderTreeWindow.mm:
* DumpRenderTree/mac/EditingDelegate.h:
* DumpRenderTree/mac/EventSendingController.h:
* DumpRenderTree/mac/EventSendingController.mm:
* DumpRenderTree/mac/FrameLoadDelegate.mm:
* DumpRenderTree/mac/HistoryDelegate.h:
* DumpRenderTree/mac/LayoutTestHelper.m:
* DumpRenderTree/mac/MockGeolocationProvider.mm:
* DumpRenderTree/mac/NavigationController.h:
* DumpRenderTree/mac/ObjCPlugin.h:
* DumpRenderTree/mac/ObjCPlugin.m:
* DumpRenderTree/mac/ObjCPluginFunction.h:
* DumpRenderTree/mac/PolicyDelegate.h:
* DumpRenderTree/mac/ResourceLoadDelegate.h:
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
* DumpRenderTree/mac/TestRunnerMac.mm:
* DumpRenderTree/mac/TextInputController.h:
* DumpRenderTree/mac/TextInputController.m:
* DumpRenderTree/mac/UIDelegate.h:
* DumpRenderTree/mac/UIDelegate.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Disable accessibility after every test run
cfleizach@apple.com [Sun, 26 Jan 2014 23:40:41 +0000 (23:40 +0000)]
AX: Disable accessibility after every test run
https://bugs.webkit.org/show_bug.cgi?id=127439

Reviewed by Alexey Proskuryakov.

../WebCore:

If accessibility is disabled, we may still need to return the existing
AXObjectCache, so that objects can be cleaned up appropriately.

A such we have to be prepared to handle a nullptr return value in more cases.

* accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::disableAccessibility):
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::childrenChanged):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remoteSVGRootElement):
* dom/Document.cpp:
(WebCore::Document::existingAXObjectCache):

../WebKit:

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFollow-up build fix.
andersca@apple.com [Sun, 26 Jan 2014 22:55:41 +0000 (22:55 +0000)]
Follow-up build fix.

* WebHistoryItem.cpp:
(WebHistoryItem::visitedWithTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove even more Windows history code.
andersca@apple.com [Sun, 26 Jan 2014 22:52:17 +0000 (22:52 +0000)]
Remove even more Windows history code.

* WebHistory.cpp:
(WebHistory::removeItemForURLString):
* WebHistoryItem.cpp:
(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):
(WebHistoryItem::getDailyVisitCounts):
(WebHistoryItem::getWeeklyVisitCounts):
(WebHistoryItem::recordInitialVisit):
(WebHistoryItem::initWithURLString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAnother follow-up build fix.
andersca@apple.com [Sun, 26 Jan 2014 22:46:32 +0000 (22:46 +0000)]
Another follow-up build fix.

* WebHistory.cpp:
(WebHistory::removeAllItems):
(WebHistory::orderedItemsLastVisitedOnDay):
* WebHistoryItem.cpp:
(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):
(WebHistoryItem::visitCount):
(WebHistoryItem::setVisitCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove more history gunk.
andersca@apple.com [Sun, 26 Jan 2014 22:41:13 +0000 (22:41 +0000)]
Remove more history gunk.

* WebHistory.cpp:
(WebHistory::orderedLastVisitedDays):
(WebHistory::addItem):
(WebHistory::visitedURL):
(WebHistory::removeItemForURLString):
* WebHistory.h:
* WebHistoryItem.cpp:
(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):
(WebHistoryItem::mergeAutoCompleteHints):
(WebHistoryItem::setLastVisitedTimeInterval):
(WebHistoryItem::initWithURLString):
(WebHistoryItem::lastVisitedTimeInterval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix.
andersca@apple.com [Sun, 26 Jan 2014 22:34:13 +0000 (22:34 +0000)]
Build fix.

* WebHistoryItem.cpp:
(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::dictionaryRepresentation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSome more Apple Windows port rebaseline.
zalan@apple.com [Sun, 26 Jan 2014 22:29:06 +0000 (22:29 +0000)]
Some more Apple Windows port rebaseline.

* platform/win/svg/custom/foreign-object-skew-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove history item visit count handling to WebKit
andersca@apple.com [Sun, 26 Jan 2014 22:22:05 +0000 (22:22 +0000)]
Move history item visit count handling to WebKit
https://bugs.webkit.org/show_bug.cgi?id=127659

Reviewed by Dan Bernstein.

Source/WebCore:

Remove all members dealing with visit handling - they're going back to WebKit.

* WebCore.exp.in:
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::reset):
(WebCore::HistoryItem::decodeBackForwardTree):
* history/HistoryItem.h:
(WebCore::HistoryItem::create):

Source/WebKit/mac:

Move code to deal with visit count and visit dates here from WebCore.

* History/HistoryPropertyList.mm:
(HistoryPropertyListWriter::writeHistoryItem):
* History/WebHistoryItem.mm:
(-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
(-[WebHistoryItem copyWithZone:]):
(-[WebHistoryItem lastVisitedTimeInterval]):
(-[WebHistoryItem initWithURLString:title:displayTitle:lastVisitedTimeInterval:]):
(-[WebHistoryItem setVisitCount:]):
(-[WebHistoryItem _mergeAutoCompleteHints:]):
(-[WebHistoryItem initFromDictionaryRepresentation:]):
(-[WebHistoryItem _visitedWithTitle:increaseVisitCount:]):
(-[WebHistoryItem _recordInitialVisit]):
(timeToDay):
(-[WebHistoryItem _padDailyCountsForNewVisit:]):
(-[WebHistoryItem _collapseDailyVisitsToWeekly]):
(-[WebHistoryItem _recordVisitAtTime:increaseVisitCount:]):
(-[WebHistoryItem _setLastVisitedTimeInterval:]):
* History/WebHistoryItemInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebKit: Fix build.
andersca@apple.com [Sun, 26 Jan 2014 21:32:59 +0000 (21:32 +0000)]
Source/WebKit: Fix build.

Make HistoryPropertyList an Objective-C++ class.

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac: Fix build.

Pass a WebHistoryItem to writeHistoryItem so we can extract _lastVisitWasHTTPNonGet from it.

* History/HistoryPropertyList.h:
* History/HistoryPropertyList.mm:
(HistoryPropertyListWriter::HistoryPropertyListWriter):
(HistoryPropertyListWriter::buffer):
(HistoryPropertyListWriter::releaseData):
(HistoryPropertyListWriter::writeObjects):
(HistoryPropertyListWriter::writeHistoryItem):
* History/WebHistory.mm:
(WebHistoryWriter::writeHistoryItems):
* History/WebHistoryItem.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove lastVisitWasHTTPNonGet out to WebHistoryItem
andersca@apple.com [Sun, 26 Jan 2014 21:21:39 +0000 (21:21 +0000)]
Move lastVisitWasHTTPNonGet out to WebHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=127657

Reviewed by Dan Bernstein.

Source/WebCore:

Remove m_lastVisitWasHTTPNonGet, it's only used by WebKit.

* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::reset):
* history/HistoryItem.h:

Source/WebKit/mac:

Keep track of _lastVisitWasHTTPNonGet inside WebHistoryItem.

* History/WebHistory.mm:
(-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
Set entry->_private->_lastVisitWasHTTPNonGet.

* History/WebHistoryItem.h:
Change @private to @package so we can get at WebHistoryItemPrivate from WebHistory.

* History/WebHistoryItem.mm:
(-[WebHistoryItem copyWithZone:]):
Assign _private->_lastVisitWasHTTPNonGet.

(-[WebHistoryItem initFromDictionaryRepresentation:]):
Set _private->_lastVisitWasHTTPNonGet.

* History/WebHistoryItemInternal.h:
Move WebHistoryItemPrivate interface here.

Source/WebKit/win:

Remove uses of lastVisitWasHTTPNonGet.

* WebHistory.cpp:
(WebHistory::visitedURL):
* WebHistoryItem.cpp:
(WebHistoryItem::initFromDictionaryRepresentation):
(WebHistoryItem::lastVisitWasHTTPNonGet):
(WebHistoryItem::setLastVisitWasHTTPNonGet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed Apple Windows port rebaseline after r162803.
zalan@apple.com [Sun, 26 Jan 2014 20:04:29 +0000 (20:04 +0000)]
Unreviewed Apple Windows port rebaseline after r162803.

* platform/win/editing/selection/3690703-2-expected.txt: Added.
* platform/win/editing/selection/3690703-expected.txt: Added.
* platform/win/editing/selection/3690719-expected.txt: Added.
* platform/win/editing/selection/4397952-expected.txt: Added.
* platform/win/editing/selection/5240265-expected.txt: Added.
* platform/win/editing/selection/selection-button-text-expected.txt: Added.
* platform/win/fast/block/float/float-avoidance-expected.txt: Added.
* platform/win/fast/css/continuationCrash-expected.txt: Added.
* platform/win/fast/css/margin-top-bottom-dynamic-expected.txt: Added.
* platform/win/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
* platform/win/fast/forms/001-expected.txt: Added.
* platform/win/fast/forms/blankbuttons-expected.txt: Added.
* platform/win/fast/forms/button-table-styles-expected.txt: Added.
* platform/win/fast/forms/control-restrict-line-height-expected.txt: Added.
* platform/win/fast/forms/file/file-input-direction-expected.txt: Added.
* platform/win/fast/forms/file/input-file-re-render-expected.txt: Added.
* platform/win/fast/forms/formmove3-expected.txt: Added.
* platform/win/fast/forms/input-appearance-height-expected.txt: Added.
* platform/win/fast/forms/input-button-sizes-expected.txt: Added.
* platform/win/fast/forms/input-value-expected.txt: Added.
* platform/win/fast/forms/targeted-frame-submission-expected.txt: Added.
* platform/win/fast/html/details-replace-summary-child-expected.txt: Added.
* platform/win/fast/html/details-replace-text-expected.txt: Added.
* platform/win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Added.
* platform/win/fast/overflow/scrollRevealButton-expected.txt: Added.
* platform/win/fast/replaced/width100percent-button-expected.txt: Added.
* platform/win/fast/text/textIteratorNilRenderer-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug138725-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug18359-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug2479-3-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug2479-4-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug26178-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug28928-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug33855-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug39209-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug4429-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug46368-1-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug46368-2-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug51037-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug51727-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug52505-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug52506-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug60749-expected.txt: Added.
* platform/win/tables/mozilla/bugs/bug7342-expected.txt: Added.
* platform/win/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Added.
* platform/win/tables/mozilla/dom/tableDom-expected.txt: Added.
* platform/win/tables/mozilla/other/move_row-expected.txt: Added.
* platform/win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt: Added.
* platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Added.
* platform/win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTurn WebHistoryItemPrivate back into a real Objective-C class
andersca@apple.com [Sun, 26 Jan 2014 18:54:11 +0000 (18:54 +0000)]
Turn WebHistoryItemPrivate back into a real Objective-C class
https://bugs.webkit.org/show_bug.cgi?id=127653

Reviewed by Sam Weinig.

This is a first step towards moving some history specific code from WebCore::HistoryItem back into WebKit.

* History/WebHistoryItem.mm:
(-[WebHistoryItem dealloc]):
(-[WebHistoryItem finalize]):
(-[WebHistoryItem initWithWebCoreHistoryItem:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSubpixel Layout: Align <input type="button", submit etc (PushButtonPart) top and...
zalan@apple.com [Sun, 26 Jan 2014 18:28:26 +0000 (18:28 +0000)]
Subpixel Layout: Align <input type="button", submit etc (PushButtonPart) top and bottom paddings with <button>
https://bugs.webkit.org/show_bug.cgi?id=127640

Reviewed by Simon Fraser.

<button> sets padding-top: 2px and padding-bottom: 3px as default values (html.css),
while <input type="button" (submit, etc) has the hardcoded values of 0, 0 and we center the text using the available space.
This results in different baseline text position in normal cases. This adjustment puts the <input type='button'
rendering back to the pre-subpixel layout state.

Source/WebCore:

* platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::controlPadding):

LayoutTests:

* platform/mac/css3/flexbox/button-expected.txt:
* platform/mac/editing/selection/3690703-2-expected.txt:
* platform/mac/editing/selection/3690703-expected.txt:
* platform/mac/editing/selection/3690719-expected.txt:
* platform/mac/editing/selection/4397952-expected.txt:
* platform/mac/editing/selection/5240265-expected.txt:
* platform/mac/editing/selection/selection-button-text-expected.txt:
* platform/mac/fast/block/float/float-avoidance-expected.txt:
* platform/mac/fast/css/continuationCrash-expected.txt:
* platform/mac/fast/css/margin-top-bottom-dynamic-expected.txt:
* platform/mac/fast/css/rtl-ordering-expected.txt:
* platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
* platform/mac/fast/forms/001-expected.png:
* platform/mac/fast/forms/001-expected.txt:
* platform/mac/fast/forms/basic-buttons-expected.png:
* platform/mac/fast/forms/basic-buttons-expected.txt:
* platform/mac/fast/forms/blankbuttons-expected.txt:
* platform/mac/fast/forms/box-shadow-override-expected.png:
* platform/mac/fast/forms/box-shadow-override-expected.txt:
* platform/mac/fast/forms/button-positioned-expected.png:
* platform/mac/fast/forms/button-positioned-expected.txt:
* platform/mac/fast/forms/button-sizes-expected.png:
* platform/mac/fast/forms/button-sizes-expected.txt:
* platform/mac/fast/forms/button-style-color-expected.png:
* platform/mac/fast/forms/button-style-color-expected.txt:
* platform/mac/fast/forms/button-table-styles-expected.png:
* platform/mac/fast/forms/button-table-styles-expected.txt:
* platform/mac/fast/forms/button-text-transform-expected.png:
* platform/mac/fast/forms/button-text-transform-expected.txt:
* platform/mac/fast/forms/control-restrict-line-height-expected.png:
* platform/mac/fast/forms/control-restrict-line-height-expected.txt:
* platform/mac/fast/forms/file/file-input-direction-expected.png:
* platform/mac/fast/forms/file/file-input-direction-expected.txt:
* platform/mac/fast/forms/file/file-input-disabled-expected.txt:
* platform/mac/fast/forms/file/input-file-re-render-expected.txt:
* platform/mac/fast/forms/form-element-geometry-expected.png:
* platform/mac/fast/forms/form-element-geometry-expected.txt:
* platform/mac/fast/forms/formmove3-expected.txt:
* platform/mac/fast/forms/input-appearance-height-expected.png:
* platform/mac/fast/forms/input-appearance-height-expected.txt:
* platform/mac/fast/forms/input-button-sizes-expected.png:
* platform/mac/fast/forms/input-button-sizes-expected.txt:
* platform/mac/fast/forms/input-value-expected.png:
* platform/mac/fast/forms/input-value-expected.txt:
* platform/mac/fast/forms/targeted-frame-submission-expected.txt:
* platform/mac/fast/forms/validation-message-appearance-expected.png:
* platform/mac/fast/forms/validation-message-appearance-expected.txt:
* platform/mac/fast/html/details-replace-summary-child-expected.txt:
* platform/mac/fast/html/details-replace-text-expected.txt:
* platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
* platform/mac/fast/overflow/scrollRevealButton-expected.txt:
* platform/mac/fast/replaced/replaced-breaking-expected.txt:
* platform/mac/fast/replaced/width100percent-button-expected.txt:
* platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
* platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/mac/svg/custom/foreign-object-skew-expected.txt: Added.
* platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
* platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
* platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
* platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
* platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
* platform/mac/tables/mozilla/bugs/bug39209-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4429-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
* platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
* platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
* platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
* platform/mac/tables/mozilla/bugs/bug60749-expected.txt:
* platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
* platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
* platform/mac/tables/mozilla/dom/tableDom-expected.txt:
* platform/mac/tables/mozilla/other/move_row-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening. Rebaselining after r162553, r162742, r162791 and possibly...
zandobersek@gmail.com [Sun, 26 Jan 2014 13:33:44 +0000 (13:33 +0000)]
Unreviewed GTK gardening. Rebaselining after r162553, r162742, r162791 and possibly other revisions.

* platform/gtk/css1/box_properties/padding-expected.txt:
* platform/gtk/css1/box_properties/padding_top-expected.txt:
* platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
* platform/gtk/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
* platform/gtk/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
* platform/gtk/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
* platform/gtk/css3/selectors3/html/css3-modsel-25-expected.txt:
* platform/gtk/css3/selectors3/html/css3-modsel-70-expected.txt:
* platform/gtk/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
* platform/gtk/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
* platform/gtk/css3/selectors3/xml/css3-modsel-25-expected.txt:
* platform/gtk/css3/selectors3/xml/css3-modsel-70-expected.txt:
* platform/gtk/fast/block/basic/011-expected.txt:
* platform/gtk/fast/block/float/032-expected.txt:
* platform/gtk/fast/block/margin-collapse/103-expected.txt:
* platform/gtk/fast/css/empty-pseudo-class-expected.txt:
* platform/gtk/fast/css/fieldset-display-row-expected.txt:
* platform/gtk/fast/css/first-child-pseudo-class-expected.txt:
* platform/gtk/fast/css/input-search-padding-expected.txt:
* platform/gtk/fast/css/last-child-pseudo-class-expected.txt:
* platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
* platform/gtk/fast/css/only-child-pseudo-class-expected.txt:
* platform/gtk/fast/forms/001-expected.txt:
* platform/gtk/fast/forms/basic-inputs-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
* platform/gtk/fast/forms/form-element-geometry-expected.txt:
* platform/gtk/fast/forms/formmove-expected.txt:
* platform/gtk/fast/forms/formmove2-expected.txt:
* platform/gtk/fast/forms/indeterminate-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
* platform/gtk/fast/forms/input-value-expected.txt:
* platform/gtk/fast/forms/large-toggle-elements-expected.txt:
* platform/gtk/fast/inline/positionedLifetime-expected.txt:
* platform/gtk/fast/parser/bad-xml-slash-expected.txt:
* platform/gtk/fast/repaint/reflection-redraw-expected.txt:
* platform/gtk/fast/replaced/replaced-breaking-expected.txt:
* platform/gtk/fast/replaced/width100percent-checkbox-expected.txt:
* platform/gtk/fast/replaced/width100percent-radio-expected.txt:
* platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.txt:
* platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
* platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
* platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
* platform/gtk/tables/mozilla/marvin/body_col-expected.txt:
* platform/gtk/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
* platform/gtk/tables/mozilla/other/body_col-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/core/captions3-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImprove the bindings of NodeList's name accessor
benjamin@webkit.org [Sun, 26 Jan 2014 10:30:47 +0000 (10:30 +0000)]
Improve the bindings of NodeList's name accessor
https://bugs.webkit.org/show_bug.cgi?id=127358

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-26
Reviewed by Geoffrey Garen.

Source/WebCore:

When accessing an item of NodeList by name, the default bindings was
going through the list of node twice:
-First, getOwnProperty calls canGetItemsForName() to find if a property exists for
 the given name. This in turn used NodeList::namedItem() which is a slow operation.
-Then, the value itself was queried through nameGetter(), calling NodeList::namedItem()
 a second time to find the same value.

This patch kills the default name getter in favor of a getOwnPropertySlotDelegate() returning
the value directly on the PropertySlot.

Ad Hoc testing show about 15% speed up for simple cases.

* bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeList::getOwnPropertySlotDelegate):
* dom/NodeList.idl:

LayoutTests:

* fast/dom/NodeList/nodelist-name-getter-properties-expected.txt: Added.
* fast/dom/NodeList/nodelist-name-getter-properties.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoASSERTION FAILED: !m_hasPendingCharacter
benjamin@webkit.org [Sun, 26 Jan 2014 10:26:44 +0000 (10:26 +0000)]
ASSERTION FAILED: !m_hasPendingCharacter
https://bugs.webkit.org/show_bug.cgi?id=110118

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-26
Reviewed by Sam Weinig.

Add more test coverage for r144552 with a use case that use to hit the assertion.

* fast/dom/xml-parser-entity-in-attribute-value-expected.txt: Added.
* fast/dom/xml-parser-entity-in-attribute-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Move InspectorDebuggerAgent into JavaScriptCore
joepeck@webkit.org [Sun, 26 Jan 2014 08:39:12 +0000 (08:39 +0000)]
Web Inspector: Move InspectorDebuggerAgent into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=127629

Rubber-stamped by Sam Weinig.

Source/JavaScriptCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
- Add new files to the build.
- Also, since non REMOTE_INSPECTOR ports cannot yet connect to a
  JSGlobalObject for inspection remove those files as they don't
  need to be built.

* inspector/EventLoop.cpp: Added.
(Inspector::EventLoop::cycle):
* inspector/EventLoop.h: Added.
(Inspector::EventLoop::EventLoop):
(Inspector::EventLoop::ended):
Add a JavaScriptCore version of EventLoop. This is currently only
used by the Mac port for JSGlobalObject remote inspection. Keep
the WebCore/platform version alive because for the Mac port it does
slightly different things involving AppKit.

* inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
Create DebuggerAgent and hook up ScriptDebugServer where needed.

* inspector/JSGlobalObjectScriptDebugServer.cpp: Added.
(Inspector::JSGlobalObjectScriptDebugServer::JSGlobalObjectScriptDebugServer):
(Inspector::JSGlobalObjectScriptDebugServer::addListener):
(Inspector::JSGlobalObjectScriptDebugServer::removeListener):
(Inspector::JSGlobalObjectScriptDebugServer::recompileAllJSFunctions):
(Inspector::JSGlobalObjectScriptDebugServer::runEventLoopWhilePaused):
* inspector/JSGlobalObjectScriptDebugServer.h: Added.
Simple implementation of ScriptDebugServer with a JSGlobalObject.

* inspector/agents/InspectorDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorDebuggerAgent.cpp.
* inspector/agents/InspectorDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorDebuggerAgent.h.
Copied from WebCore. A few methods need to be made virtual so that Web implementations
can override and extend the funcitonality. E.g. sourceMapURLForScript and enable/disable.

* inspector/agents/JSGlobalObjectDebuggerAgent.cpp: Added.
* inspector/agents/JSGlobalObjectDebuggerAgent.h: Added.
(Inspector::JSGlobalObjectDebuggerAgent::JSGlobalObjectDebuggerAgent):
(Inspector::JSGlobalObjectDebuggerAgent::startListeningScriptDebugServer):
(Inspector::JSGlobalObjectDebuggerAgent::stopListeningScriptDebugServer):
(Inspector::JSGlobalObjectDebuggerAgent::injectedScriptForEval):
Simple implementation of DebuggerAGent with a JSGlobalObject.

Source/WebCore:

Test: inspector-protocol/debugger/pause-on-assert.html

* CMakeLists.txt:
* ForwardingHeaders/inspector/agents/InspectorDebuggerAgent.h: Added.
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorAllInOne.cpp:
- Remove InspectorDebuggerAgent.
- Add WebDebuggerAgent (shared between Page and Worker).

* inspector/WebDebuggerAgent.h: Added.
(WebCore::WebDebuggerAgent::~WebDebuggerAgent):
* inspector/WebDebuggerAgent.cpp: Added.
(WebCore::WebDebuggerAgent::WebDebuggerAgent):
(WebCore::WebDebuggerAgent::enable):
(WebCore::WebDebuggerAgent::disable):
Shared code for Page and Worker debugger agents.
Instrumenting agents is a concept in WebCore only,
and the Debugger agent is only in the instrumenting
agents list when it is enabled and removed when disabled.

* inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::inspectorDebuggerAgent):
(WebCore::InstrumentingAgents::setInspectorDebuggerAgent):
* inspector/InspectorDOMDebuggerAgent.cpp:
* inspector/InspectorDOMDebuggerAgent.h:
Update namespace for debugger agent.

* inspector/InspectorInstrumentation.cpp:
(WebCore::isConsoleAssertMessage):
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
DebuggerAgent in JavaScriptCore does not yet know about console
types. So temporarily handle it here. We need to give JavaScriptCore
some concept of Console messages and types.

* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::PageDebuggerAgent):
(WebCore::PageDebuggerAgent::enable):
(WebCore::PageDebuggerAgent::disable):
(WebCore::PageDebuggerAgent::sourceMapURLForScript):
(WebCore::PageDebuggerAgent::injectedScriptForEval):
* inspector/PageDebuggerAgent.h:
* inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::injectedScriptForEval):
* inspector/WorkerDebuggerAgent.h:
Modernize the Page and Worker debugger agents.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorController.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
New constructors for the debugger agents.

LayoutTests:

Add a test that we pause in the debugger for console.assert failures
when the DebuggerAgent is enabled.

* inspector-protocol/debugger/pause-on-assert-expected.txt: Added.
* inspector-protocol/debugger/pause-on-assert.html: Added.
* inspector-protocol/debugger/resources/assert.js: Added.
(assertTrue):
(assertFalse):
(assertCondition):
(assertConditionWithMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGardening: fix build breakage from previous commit.
mark.lam@apple.com [Sun, 26 Jan 2014 06:53:00 +0000 (06:53 +0000)]
Gardening: fix build breakage from previous commit.

Not reviewed.

* profiler/ProfileNode.cpp:
(JSC::ProfileNode::debugPrintData):
- Removed obsolete references to "visible" timers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove dead code from the JSC profiler.
timothy@apple.com [Sun, 26 Jan 2014 06:30:38 +0000 (06:30 +0000)]
Remove dead code from the JSC profiler.

https://bugs.webkit.org/show_bug.cgi?id=127643

Reviewed by Mark Lam.

Source/JavaScriptCore:

* profiler/Profile.cpp:
* profiler/Profile.h:
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::stopProfiling):
* profiler/ProfileNode.cpp:
(JSC::ProfileNode::ProfileNode):
(JSC::ProfileNode::stopProfiling):
(JSC::ProfileNode::endAndRecordCall):
(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):
* profiler/ProfileNode.h:
(JSC::ProfileNode::totalTime):
(JSC::ProfileNode::setTotalTime):
(JSC::ProfileNode::selfTime):
(JSC::ProfileNode::setSelfTime):
(JSC::ProfileNode::totalPercent):
(JSC::ProfileNode::selfPercent):
Remove support for things like focus and exclude. The Inspector does those in JS now.

Source/WebCore:

Passes existing tests in fast/profiler.

* bindings/js/ScriptProfile.cpp:
(WebCore::buildInspectorObjectFor): Remove visible.
* inspector/ScriptProfileNode.idl: Ditto.
* inspector/protocol/Profiler.json: Ditto.

Source/WebInspectorUI:

* Versions/Inspector-iOS-7.0.json: Remove visible from CPUProfileNode.

LayoutTests:

* fast/profiler/resources/profiler-test-JS-resources.js:
(printProfileNodeWithoutTime): Don't use visible. It was always true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unused support for DRAGGABLE_REGION
commit-queue@webkit.org [Sun, 26 Jan 2014 06:25:55 +0000 (06:25 +0000)]
Remove unused support for DRAGGABLE_REGION
https://bugs.webkit.org/show_bug.cgi?id=127642

Patch by Sam Weinig <sam@webkit.org> on 2014-01-25
Reviewed by Simon Fraser.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* WebCore.exp.in:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPropertyNames.in:
* css/CSSValueKeywords.in:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
* page/Chrome.cpp:
* page/ChromeClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::paintContents):
* page/FrameView.h:
* rendering/RenderElement.cpp:
(WebCore::RenderElement::styleWillChange):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::addAnnotatedRegions):
* rendering/RenderInline.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::setHasVerticalScrollbar):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addAnnotatedRegions):
* rendering/RenderObject.h:
(WebCore::AnnotatedRegionValue::operator==):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove FIXME in CSSKeywordCompletions.js about "inherit" keyword
commit-queue@webkit.org [Sun, 26 Jan 2014 04:15:18 +0000 (04:15 +0000)]
Remove FIXME in CSSKeywordCompletions.js about "inherit" keyword
https://bugs.webkit.org/show_bug.cgi?id=127638

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-25
Reviewed by Timothy Hatcher.

* UserInterface/CSSKeywordCompletions.js:
(WebInspector.CSSKeywordCompletions.forProperty):
Replace FIXME with a descriptive comment about why the code is what it is.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd FALLTHROUGH and -Wimplicit-fallthrough to warn about unannotated implicit fallthr...
commit-queue@webkit.org [Sun, 26 Jan 2014 03:54:55 +0000 (03:54 +0000)]
Add FALLTHROUGH and -Wimplicit-fallthrough to warn about unannotated implicit fallthroughs in switches
https://bugs.webkit.org/show_bug.cgi?id=127637

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-25
Reviewed by Darin Adler.

For information about [[clang::fallthrough]], see:
<http://clang.llvm.org/docs/LanguageExtensions.html#the-clang-fallthrough-attribute>

* Configurations/Base.xcconfig:
Enable -Wimplicit-fallthrough warnings.

* wtf/Compiler.h:
Define FALLTHROUGH on clang and fallback to outputing nothing when unsupported.

* wtf/dtoa/fast-dtoa.cc:
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::convertLatin1ToUTF8):
(WTF::Unicode::convertUTF16ToUTF8):
(WTF::Unicode::isLegalUTF8):
(WTF::Unicode::readUTF8Sequence):
Explicitly annotate implicit fallthroughs with FALLTHROUGH.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean up SVGPatternElement::collectPatternAttributes
gyuyoung.kim@samsung.com [Sun, 26 Jan 2014 03:43:21 +0000 (03:43 +0000)]
Clean up SVGPatternElement::collectPatternAttributes
https://bugs.webkit.org/show_bug.cgi?id=127612

Reviewed by Andreas Kling.

This patch refactors SVGPatternElement::collectPatternAttributes() by extracting
the setPatternAttributes logic into a new function. This patch also changes the
while loop to be easier to understand and similar to collectGradientAttributes.

* svg/SVGPatternElement.cpp:
(WebCore::setPatternAttributes):
(WebCore::SVGPatternElement::collectPatternAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSubpixel layout: RenderInline is not centered when child RenderTextControl's innerTex...
zalan@apple.com [Sun, 26 Jan 2014 01:27:28 +0000 (01:27 +0000)]
Subpixel layout: RenderInline is not centered when child RenderTextControl's innerTextRenderer needs bias centering.
https://bugs.webkit.org/show_bug.cgi?id=125659

Source/WebCore:

Reviewed by Andreas Kling

layoutMod(logicalHeightDiff, 2) fails to bias round when subpixel layout is enabled. It sets
the denominator value to 2, which returns incorrect modulo result.
(subpixel off: 3px % 2 = 1 vs subpixel on: (3px * 64) -> 192 % 2 = 0)

Covered by existing tests.

* platform/LayoutUnit.h:
* rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::centerContainerIfNeeded):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::centerRenderer):
(WebCore::RenderTextControlSingleLine::layout):
* rendering/RenderTextControlSingleLine.h:

LayoutTests:

Reviewed by Andreas Kling.

layoutMod(logicalHeightDiff, 2) fails to bias round when subpixel layout is enabled. It sets
the denominator value to 2, which returns incorrect modulo result.
(subpixel off: 3px % 2 = 1 vs subpixel on: (3px * 64) -> 192 % 2 = 0)

Covered by existing tests.

* platform/mac/fast/block/float/032-expected.txt:
* platform/mac/fast/forms/search-vertical-alignment-expected.png:
* platform/mac/fast/forms/search-vertical-alignment-expected.txt:
* platform/mac-mountainlion/fast/forms/search-vertical-alignment-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Position the completion suggestions popup below if there is room
commit-queue@webkit.org [Sun, 26 Jan 2014 01:08:21 +0000 (01:08 +0000)]
Web Inspector: Position the completion suggestions popup below if there is room
https://bugs.webkit.org/show_bug.cgi?id=127615

Patch by Diego Pino Garcia <dpino@igalia.com> on 2014-01-25
Reviewed by Joseph Pecoraro.

* UserInterface/CompletionSuggestionsView.js:
(WebInspector.CompletionSuggestionsView.prototype.show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove more unnecessary #if PLATFORM(IOS)s in ApplicationCacheStorage.cpp
weinig@apple.com [Sun, 26 Jan 2014 00:50:21 +0000 (00:50 +0000)]
Remove more unnecessary #if PLATFORM(IOS)s in ApplicationCacheStorage.cpp
https://bugs.webkit.org/show_bug.cgi?id=127635

Reviewed by Antti Koivisto.

* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::executeSQLCommand):
(WebCore::ApplicationCacheStorage::verifySchemaVersion):
(WebCore::ApplicationCacheStorage::executeStatement):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::ensureOriginRecord):
(WebCore::ApplicationCacheStorage::loadCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove some iOS #ifdefs by adding SQLiteDatabaseTracker to all the builds
weinig@apple.com [Sun, 26 Jan 2014 00:36:23 +0000 (00:36 +0000)]
Remove some iOS #ifdefs by adding SQLiteDatabaseTracker to all the builds
https://bugs.webkit.org/show_bug.cgi?id=127632

Reviewed by Darin Adler.

Move the SQLiteDatabaseTracker and client from platform/sql/ios to platform/sql,
as there is nothing iOS specific about it. Then, un-#ifdef all its uses. For
ports that don't setup a client, this has no change in behavior.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/webdatabase/DatabaseBackendBase.cpp:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* loader/appcache/ApplicationCacheStorage.cpp:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::sendWillRevealEdgeEventsIfNeeded):
* platform/sql/SQLiteDatabaseTracker.cpp: Copied from Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.cpp.
* platform/sql/SQLiteDatabaseTracker.h: Copied from Source/WebCore/platform/sql/ios/SQLiteDatabaseTracker.h.
* platform/sql/SQLiteDatabaseTrackerClient.h: Copied from Source/WebCore/platform/sql/ios/SQLiteDatabaseTrackerClient.h.
* platform/sql/ios: Removed.
* platform/sql/ios/SQLiteDatabaseTracker.cpp: Removed.
* platform/sql/ios/SQLiteDatabaseTracker.h: Removed.
* platform/sql/ios/SQLiteDatabaseTrackerClient.h: Removed.
* storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::openDatabase):
(WebCore::StorageAreaSync::sync):
* storage/StorageTracker.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove an unused FrameLoaderClient function
andersca@apple.com [Sat, 25 Jan 2014 23:04:54 +0000 (23:04 +0000)]
Remove an unused FrameLoaderClient function
https://bugs.webkit.org/show_bug.cgi?id=127628

Reviewed by Andreas Kling.

Source/WebCore:

All implementations of FrameLoaderClient::shouldStopLoadingForHistoryItem return true and this function
was only used by Chromium so we can get rid of it.

* loader/EmptyClients.h:
* loader/FrameLoaderClient.h:
* loader/HistoryController.cpp:
(WebCore::HistoryController::shouldStopLoadingForHistoryItem):

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.cpp:
* WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/FrameLoaderClientGtk.cpp:
* WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
* WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to fix Mac build.
darin@apple.com [Sat, 25 Jan 2014 22:58:43 +0000 (22:58 +0000)]
Try to fix Mac build.

* runtime/DatePrototype.cpp: Put the include of <unicode/udat.h> inside
a conditional since we don't have that header in our Mac build configuration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCall deprecatedCharacters instead of characters at more call sites
darin@apple.com [Sat, 25 Jan 2014 22:47:20 +0000 (22:47 +0000)]
Call deprecatedCharacters instead of characters at more call sites
https://bugs.webkit.org/show_bug.cgi?id=127631

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* API/JSValueRef.cpp:
(JSValueMakeFromJSONString):
* API/OpaqueJSString.cpp:
(OpaqueJSString::~OpaqueJSString):
* bindings/ScriptValue.cpp:
(Deprecated::jsToInspectorValue):
* inspector/ContentSearchUtilities.cpp:
(Inspector::ContentSearchUtilities::createSearchRegexSource):
* inspector/InspectorValues.cpp:
* runtime/Identifier.h:
(JSC::Identifier::deprecatedCharacters):
* runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::append):
Use the new name.

Source/WebCore:

* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
* editing/CompositeEditCommand.cpp:
(WebCore::containsOnlyWhitespace):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText):
* editing/VisibleUnits.cpp:
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):
* html/parser/HTMLParserIdioms.cpp:
(WebCore::stripLeadingAndTrailingHTMLSpaces):
(WebCore::parseHTMLNonNegativeInteger):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):
* inspector/InspectorStyleTextEditor.cpp:
(WebCore::InspectorStyleTextEditor::insertProperty):
(WebCore::InspectorStyleTextEditor::internalReplaceProperty):
* platform/Length.cpp:
(WebCore::newCoordsArray):
* platform/LinkHash.cpp:
(WebCore::visitedLinkHash):
* platform/graphics/Color.cpp:
(WebCore::Color::parseHexColor):
(WebCore::Color::Color):
* platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
* platform/text/TextEncodingRegistry.cpp:
(WebCore::atomicCanonicalTextEncodingName):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::constructTextRun):
* rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::width):
* svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::registerLigaturesInGlyphCache):
* xml/XPathFunctions.cpp:
(WebCore::XPath::FunId::evaluate):
Use the new name.

Source/WTF:

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::replace):
* wtf/text/WTFString.h:
(WTF::String::isAllSpecialCharacters):
Use the new name.

Tools:

* TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
(TestWebKitAPI::expectBuilderContent):
(TestWebKitAPI::expectEmpty):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/StringImpl.cpp:
(TestWebKitAPI::TEST):
Use the new name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a new separate LChar.h header file, to be used after we remove Unicode.h
darin@apple.com [Sat, 25 Jan 2014 22:46:42 +0000 (22:46 +0000)]
Add a new separate LChar.h header file, to be used after we remove Unicode.h
https://bugs.webkit.org/show_bug.cgi?id=127630

Reviewed by Sam Weinig.

* GNUmakefile.list.am: Added the new file
* WTF.vcxproj/WTF.vcxproj: Ditto.
* WTF.vcxproj/WTF.vcxproj.filters: Ditto.
* WTF.xcodeproj/project.pbxproj: Ditto.
* wtf/CMakeLists.txt: Ditto.
* wtf/text/LChar.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of ICU_UNICODE and WCHAR_UNICODE remnants
darin@apple.com [Sat, 25 Jan 2014 21:36:37 +0000 (21:36 +0000)]
Get rid of ICU_UNICODE and WCHAR_UNICODE remnants
https://bugs.webkit.org/show_bug.cgi?id=127623

Reviewed by Anders Carlsson.

.:

* Source/cmake/OptionsEfl.cmake: Removed ICU_UNICODE and WCHAR_UNICODE flags.
* Source/cmake/OptionsGTK.cmake: Ditto.
* Source/cmake/OptionsWinCE.cmake: Ditto.

Source/JavaScriptCore:

* runtime/DatePrototype.cpp: Removed USE(ICU_UNICODE) checks, since that's always true now.

Source/WebCore:

* CMakeLists.txt: Removed SmartReplaceICU.cpp.
* GNUmakefile.list.am: Ditto.
* PlatformEfl.cmake: Ditto.
* PlatformGTK.cmake: Ditto.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::modifyMovingRight): Ditto.
(WebCore::FrameSelection::modifyMovingLeft): Ditto.

* editing/SmartReplace.cpp: Moved code here from SmartReplaceICU,
since we always support ICU now. Added some FIXME comments about
bugs and mistakes I spotted in the code as I was moving it.
* editing/SmartReplaceICU.cpp: Removed.

* editing/TextIterator.cpp: Removed unneeded checks.
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData): Ditto.
(WebCore::ThreadGlobalData::destroy): Ditto.
* platform/ThreadGlobalData.h: Ditto.
* platform/URL.cpp:
(WebCore::appendEncodedHostname): Ditto.
* platform/graphics/SurrogatePairAwareTextIterator.cpp: Ditto.
Also removed unneeded "using namespace".
* platform/text/TextCodecICU.cpp: Ditto.
* platform/text/TextEncoding.cpp:
(WebCore::TextEncoding::encode): Ditto.
* platform/text/TextEncodingRegistry.cpp:
(WebCore::extendTextCodecMaps): Ditto.

Source/WTF:

* wtf/CMakeLists.txt: Removed WTF_USE_ICU_UNICODE and
WTF_USE_WCHAR_UNICODE since they are true and false respectively.

* wtf/Platform.h: Removed code to set WTF_USE_ICU_UNICODE.

* wtf/unicode/Collator.h: Removed ifdefs.
* wtf/unicode/CollatorDefault.cpp: Ditto.
* wtf/unicode/Unicode.h: Ditto.
* wtf/unicode/icu/CollatorICU.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Rewrite locale-specific date formatting code to remove strange string creation
darin@apple.com [Sat, 25 Jan 2014 21:31:51 +0000 (21:31 +0000)]
[Mac] Rewrite locale-specific date formatting code to remove strange string creation
https://bugs.webkit.org/show_bug.cgi?id=127624

Reviewed by Anders Carlsson.

* runtime/DatePrototype.cpp:
(JSC::formatLocaleDate): Use some smart pointers and conversion operators we already
have to do the formatting in a more straightforward way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of UnicodeRange.h/cpp, using ICU instead
darin@apple.com [Sat, 25 Jan 2014 21:31:00 +0000 (21:31 +0000)]
Get rid of UnicodeRange.h/cpp, using ICU instead
https://bugs.webkit.org/show_bug.cgi?id=127622

Reviewed by Anders Carlsson.

* CMakeLists.txt: Remove UnicodeRange.h/cpp.
* GNUmakefile.list.am: Ditto.
* WebCore.vcxproj/WebCore.vcxproj: Ditto.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.

* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::systemFallbackForCharacters): To check if a character has
multiple code pages, use UCHAR_UNIFIED_IDEOGRAPH instead of cRangeSetCJK.
* platform/graphics/wince/FontCacheWinCE.cpp:
(WebCore::FontCache::systemFallbackForCharacters): Ditto. Also, to check if a
character is in the Thai block, use UBLOCK_THAI.

* platform/graphics/wince/FontPlatformData.cpp: Removed include of UnicodeRange.h.

* platform/text/UnicodeRange.cpp: Removed.
* platform/text/UnicodeRange.h: Removed.

* rendering/svg/SVGTextLayoutEngineBaseline.cpp:
(WebCore::SVGTextLayoutEngineBaseline::calculateGlyphOrientationAngle): To figure
out if a character is full width, use UCHAR_EAST_ASIAN_WIDTH, instead of hard-coding
"not Latin or Arabic" as the rule.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove an unnecessary platform #if in BitmapImage(CG)::checkForSolidColor()
timothy_horton@apple.com [Sat, 25 Jan 2014 21:25:58 +0000 (21:25 +0000)]
Remove an unnecessary platform #if in BitmapImage(CG)::checkForSolidColor()
https://bugs.webkit.org/show_bug.cgi?id=127610

Reviewed by Simon Fraser.

* platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::BitmapImage::checkForSolidColor):
Over time, the two sides of this #if !PLATFORM(IOS) converged. Remove the #if
and merge the code. We explicitly use kCGBitmapByteOrder32Big to be correct everywhere.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[cg] Look in the PNG dictionary for image duration information
timothy_horton@apple.com [Sat, 25 Jan 2014 21:24:10 +0000 (21:24 +0000)]
[cg] Look in the PNG dictionary for image duration information
https://bugs.webkit.org/show_bug.cgi?id=127611
<rdar://problem/15408643>

Reviewed by Simon Fraser.

We should look in the PNG properties dictionary for frame duration and loop count data.

* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::repetitionCount):
Mush repetitionCount a bit more to make it easier to read (early returns, etc.)
Also, look in the PNG properties dictionary for a loop count.

(WebCore::ImageSource::frameDurationAtIndex):
Look in the PNG properties dictionary for delay time.
Get rid of WebCoreCGImagePropertyGIFUnclampedDelayTime; it hasn't
been needed since Snow Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove atomicIncrement/atomicDecrement
andersca@apple.com [Sat, 25 Jan 2014 21:16:42 +0000 (21:16 +0000)]
Remove atomicIncrement/atomicDecrement
https://bugs.webkit.org/show_bug.cgi?id=127625

Reviewed by Andreas Kling.

Replace atomicIncrement/atomicDecrement with std::atomic.

Source/JavaScriptCore:

* bytecode/Watchpoint.h:
* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
* profiler/ProfilerDatabase.cpp:
(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::addDatabaseToAtExit):

Source/WebCore:

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::incrementActiveSourceCount):
(WebCore::AudioContext::decrementActiveSourceCount):
* Modules/webaudio/AudioContext.h:
* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::finishDeref):
* Modules/webaudio/AudioNode.h:
* Modules/webdatabase/OriginLock.h:

Source/WebKit2:

* Platform/IPC/Connection.cpp:
(IPC::Connection::createSyncMessageEncoder):
* Shared/mac/SecItemShim.cpp:
(WebKit::generateSecItemRequestID):
* UIProcess/StatisticsRequest.cpp:
(WebKit::StatisticsRequest::addOutstandingRequest):

Source/WTF:

* wtf/Atomics.h:
* wtf/RefCountedLeakCounter.cpp:
(WTF::RefCountedLeakCounter::~RefCountedLeakCounter):
(WTF::RefCountedLeakCounter::increment):
(WTF::RefCountedLeakCounter::decrement):
* wtf/RefCountedLeakCounter.h:
* wtf/ThreadSafeRefCounted.h:
(WTF::ThreadSafeRefCountedBase::ref):
(WTF::ThreadSafeRefCountedBase::refCount):
(WTF::ThreadSafeRefCountedBase::derefBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Unreviewed build fix for WinCairo.
alex.christensen@flexsim.com [Sat, 25 Jan 2014 20:49:23 +0000 (20:49 +0000)]
Source/WebCore: Unreviewed build fix for WinCairo.

* platform/network/curl/CurlDownload.h:
Included wtf/Threading.h for ThreadIdentifier definition.

Source/WebKit: Unreviewed build fix for Win64.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Corrected 64-bit linker symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix.
andersca@apple.com [Sat, 25 Jan 2014 20:10:46 +0000 (20:10 +0000)]
Build fix.

* WebView/WebViewData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoModernize HashTable threading code
andersca@apple.com [Sat, 25 Jan 2014 19:24:14 +0000 (19:24 +0000)]
Modernize HashTable threading code
https://bugs.webkit.org/show_bug.cgi?id=127621

Reviewed by Darin Adler.

Source/WebCore:

Explicitly include headers that used to be brought in by HashTable.h

* platform/DragData.h:
Change a Windows-specific typedef to avoid having to include WindDef.h from a header.

* platform/audio/AudioSession.h:
* platform/network/cf/SocketStreamHandle.h:

Source/WebKit/win:

Explicitly include headers that used to be brought in by HashTable.h

* WebLocalizableStrings.cpp:

Source/WebKit2:

Explicitly include headers that used to be brought in by HashTable.h

* Shared/BlockingResponseMap.h:

Source/WTF:

Use std::mutex and std::atomic instead of WTF threading primitives.

* wtf/DynamicAnnotations.h:
Include Platform.h here since this file relies on USE macros.

* wtf/HashTable.cpp:
(WTF::HashTableStats::recordCollisionAtCount):
Change this to take an unsigned.

(WTF::HashTableStats::dumpStats):
* wtf/HashTable.h:
(WTF::KeyTraits>::HashTable):
(WTF::KeyTraits>::remove):
(WTF::KeyTraits>::invalidateIterators):
Use a single probe counter.

(WTF::addIterator):
(WTF::removeIterator):

Tools:

Explicitly include headers that used to be brought in by HashTable.h

* DumpRenderTree/JavaScriptThreading.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove CSSGroupingRule, CSSStyleSheet, ElementRuleCollector to std::unique_ptr
zandobersek@gmail.com [Sat, 25 Jan 2014 18:55:51 +0000 (18:55 +0000)]
Move CSSGroupingRule, CSSStyleSheet, ElementRuleCollector to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127575

Reviewed by Andreas Kling.

Use std::unique_ptr and std::make_unique in place of OwnPtr and adoptPtr
in the CSSGroupingRule, CSSStyleSheet and ElementRuleCollector classes.

* css/CSSFunctionValue.cpp: Remove the unnecessary PassOwnPtr header inclusion.
* css/CSSGroupingRule.cpp:
(WebCore::CSSGroupingRule::cssRules):
* css/CSSGroupingRule.h:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::cssRules):
* css/CSSStyleSheet.h:
* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::addMatchedRule):
* css/ElementRuleCollector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove MediaQueryMatcher, SelectorFilter to std::unique_ptr
zandobersek@gmail.com [Sat, 25 Jan 2014 18:54:02 +0000 (18:54 +0000)]
Move MediaQueryMatcher, SelectorFilter to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127574

Reviewed by Andreas Kling.

Replace the use of OwnPtr and adoptPtr with std::unique_ptr and std::make_unique
in the MediaQueryMatcher and SelectorFilter classes.

* css/MediaQueryMatcher.cpp:
(WebCore::MediaQueryMatcher::prepareEvaluator):
(WebCore::MediaQueryMatcher::evaluate):
(WebCore::MediaQueryMatcher::addListener):
(WebCore::MediaQueryMatcher::styleResolverChanged):
* css/MediaQueryMatcher.h:
* css/SelectorFilter.cpp:
(WebCore::SelectorFilter::popParentStackFrame):
(WebCore::SelectorFilter::setupParentStack):
* css/SelectorFilter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove PropertySetCSSStyleDeclaration, WebKitCSSKeyframesRule to std::unique_ptr
zandobersek@gmail.com [Sat, 25 Jan 2014 18:52:42 +0000 (18:52 +0000)]
Move PropertySetCSSStyleDeclaration, WebKitCSSKeyframesRule to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127572

Reviewed by Andreas Kling.

Switch the PropertySetCSSStyleDeclaration and WebKitCSSKeyframesRule classes from using
OwnPtr and adoptPtr to using std::unique_ptr and std::make_unique.

* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::didMutate):
* css/PropertySetCSSStyleDeclaration.h:
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::cssRules):
* css/WebKitCSSKeyframesRule.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove StyleProperties, StyleResolver to std::unique_ptr
zandobersek@gmail.com [Sat, 25 Jan 2014 18:51:20 +0000 (18:51 +0000)]
Move StyleProperties, StyleResolver to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127570

Reviewed by Andreas Kling.

Move the StyleProperties and StyleResolver classes from using OwnPtr and adoptPtr
to using std::unique_ptr and std::make_unique.

* css/StyleInvalidationAnalysis.h: Remove the PassOwnPtr.h header inclusion.
* css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::ensureCSSStyleDeclaration):
(WebCore::MutableStyleProperties::ensureInlineCSSStyleDeclaration):
* css/StyleProperties.h:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::addViewportDependentMediaQueryResult):
* css/StyleResolver.h:
* css/StyleScopeResolver.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove CSSFontFace, CSSFontSelector to std::unique_ptr
zandobersek@gmail.com [Sat, 25 Jan 2014 18:49:50 +0000 (18:49 +0000)]
Move CSSFontFace, CSSFontSelector to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127569

Reviewed by Andreas Kling.

Move the CSSFontFace and CSSFontSelector classes from using OwnPtr, PassOwnPtr and adoptPtr
to using std::unique_ptr, move semantics and std::make_unique.

* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::addSource):
* css/CSSFontFace.h:
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontFace):
* css/CSSFontSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Remove null check for WebPopupMenuProxy::Client in WebPopupMenuProxyGtk::showPo...
zandobersek@gmail.com [Sat, 25 Jan 2014 18:48:02 +0000 (18:48 +0000)]
[GTK] Remove null check for WebPopupMenuProxy::Client in WebPopupMenuProxyGtk::showPopupMenu
https://bugs.webkit.org/show_bug.cgi?id=107036

Reviewed by Andreas Kling.

* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Don't perform an early return
if the client is not available - it always should be. The client is set to null
only when the proxy is invalidated. This happens immediately after this function
returns, either with the popup being forced to close or being closed by the user
with possibly an item being chosen. Rather than the early return, use an ASSERT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Move InspectorRuntimeAgent into JavaScriptCore
joepeck@webkit.org [Sat, 25 Jan 2014 17:48:16 +0000 (17:48 +0000)]
Web Inspector: Move InspectorRuntimeAgent into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=127605

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
Add new files to the build.

* inspector/agents/InspectorRuntimeAgent.h: Renamed from Source/WebCore/inspector/InspectorRuntimeAgent.h.
* inspector/agents/InspectorRuntimeAgent.cpp: Renamed from Source/WebCore/inspector/InspectorRuntimeAgent.cpp.
(Inspector::InspectorRuntimeAgent::InspectorRuntimeAgent):
(Inspector::InspectorRuntimeAgent::parse):
(Inspector::InspectorRuntimeAgent::evaluate):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getProperties):
- Move the agent into JavaScriptCore.
- Modernize and cleanup.
- Make globalVM a pure virtual function for subclasses to implement.

* inspector/agents/JSGlobalObjectRuntimeAgent.h: Added.
* inspector/agents/JSGlobalObjectRuntimeAgent.cpp: Added.
(Inspector::JSGlobalObjectRuntimeAgent::JSGlobalObjectRuntimeAgent):
(Inspector::JSGlobalObjectRuntimeAgent::didCreateFrontendAndBackend):
(Inspector::JSGlobalObjectRuntimeAgent::willDestroyFrontendAndBackend):
(Inspector::JSGlobalObjectRuntimeAgent::globalVM):
(Inspector::JSGlobalObjectRuntimeAgent::injectedScriptForEval):
Straightforward JSGlobalObject implementation.

* inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
Add a runtime agent when inspecting a JSContext!

Source/WebCore:

Covered by existing tests. No change in functionality.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorAllInOne.cpp:
Remove WebCore InspectorRuntimeAgent.

* ForwardingHeaders/inspector/agents/InspectorRuntimeAgent.h: Added.
Add JavaScriptCore InspectorRuntimeAgent.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/WorkerInspectorController.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
New constructors for the runtime agent.

* inspector/PageRuntimeAgent.h:
* inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
(WebCore::PageRuntimeAgent::enable):
(WebCore::PageRuntimeAgent::disable):
(WebCore::PageRuntimeAgent::didCreateMainWorldContext):
(WebCore::PageRuntimeAgent::didCreateIsolatedContext):
(WebCore::PageRuntimeAgent::globalVM):
Modernize and implement globalVM.

* inspector/WorkerRuntimeAgent.h:
* inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
(WebCore::WorkerRuntimeAgent::injectedScriptForEval):
(WebCore::WorkerRuntimeAgent::globalVM):
Modernize and implement globalVM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Add parameters from 'DOM Object Model Core' spec and 'DOM CSS' spec that can...
commit-queue@webkit.org [Sat, 25 Jan 2014 17:25:03 +0000 (17:25 +0000)]
[GTK] Add parameters from 'DOM Object Model Core' spec and 'DOM CSS' spec that can be NULL

https://bugs.webkit.org/show_bug.cgi?id=117536

Patch by Diego Pino Garcia <dpino@igalia.com> on 2014-01-25
Reviewed by Xan Lopez.

* bindings/scripts/CodeGeneratorGObject.pm:
(ParamCanBeNull): Add new pairs (function, parameter) that can be NULL

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRestore alphabetical order in Compiler.h
darin@apple.com [Sat, 25 Jan 2014 17:18:37 +0000 (17:18 +0000)]
Restore alphabetical order in Compiler.h
https://bugs.webkit.org/show_bug.cgi?id=127620

Reviewed by Sam Weinig.

* wtf/Compiler.h: Resorted some things into alphabetical order

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of BackForwardController::isActive()
andersca@apple.com [Sat, 25 Jan 2014 17:16:49 +0000 (17:16 +0000)]
Get rid of BackForwardController::isActive()
https://bugs.webkit.org/show_bug.cgi?id=127604

Reviewed by Sam Weinig.

Source/WebCore:

BackForwardController::isActive() used to mean "my page maintains a back forward
list that has zero capacity". Move that logic into WebKit instead, namely the
WebFrameLoaderClient::canCachePage function so we can simplify WebCore.

* history/BackForwardClient.h:
* history/BackForwardController.cpp:
* history/BackForwardController.h:
* history/BackForwardList.h:
* history/PageCache.cpp:
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::canCachePage):
Move isActive logic here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r162744): wsj.com paints white
antti@apple.com [Sat, 25 Jan 2014 17:15:51 +0000 (17:15 +0000)]
REGRESSION(r162744): wsj.com paints white
https://bugs.webkit.org/show_bug.cgi?id=127619

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/css/stylesheet-layout-with-pending-paint.html

* dom/Document.cpp:
(WebCore::Document::styleResolverChanged):

    Ensure we switch out from IgnoreLayoutWithPendingSheets state after stylesheet loads complete.

LayoutTests:

* fast/css/stylesheet-layout-with-pending-paint-expected.html: Added.
* fast/css/stylesheet-layout-with-pending-paint.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK1] Fix broken rendering while navigating history in EWebLauncher
ryuan.choi@samsung.com [Sat, 25 Jan 2014 14:19:50 +0000 (14:19 +0000)]
[EFL][WK1] Fix broken rendering while navigating history in EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=127601

Reviewed by Anders Carlsson.

When scrolled after requested repaints, rendering was broken because scrollDelta
changed repaints area.

* ewk/ewk_view.cpp:
(ewk_view_scroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReverted r162760. It broke more things.
mitz@apple.com [Sat, 25 Jan 2014 07:44:27 +0000 (07:44 +0000)]
Reverted r162760. It broke more things.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to fix some 32-bit builds.
mitz@apple.com [Sat, 25 Jan 2014 07:10:31 +0000 (07:10 +0000)]
Try to fix some 32-bit builds.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Replace usage of DEFINE_STATIC_LOCAL with NeverDestroyed in WebCore/platform/efl
jinwoo7.song@samsung.com [Sat, 25 Jan 2014 06:40:43 +0000 (06:40 +0000)]
[EFL] Replace usage of DEFINE_STATIC_LOCAL with NeverDestroyed in WebCore/platform/efl
https://bugs.webkit.org/show_bug.cgi?id=127607

Reviewed by Anders Carlsson.

* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::keyMap): Use NeverDestroyed instead of DEFINE_STATIC_LOCAL.
(WebCore::windowsKeyMap): Ditto.
(WebCore::keyDownCommandsMap): Ditto.
(WebCore::keyPressCommandsMap): Ditto.
* platform/efl/GamepadsEfl.cpp:
(WebCore::sampleGamepads): Ditto.
* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::systemFont): Do not use unnecessary DEFINE_STATIC_LOCAL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebKit2 View Gestures (Smart Zoom): Can't double-tap zoom-out on the body
timothy_horton@apple.com [Sat, 25 Jan 2014 06:01:29 +0000 (06:01 +0000)]
WebKit2 View Gestures (Smart Zoom): Can't double-tap zoom-out on the body
https://bugs.webkit.org/show_bug.cgi?id=127602

Reviewed by Anders Carlsson.

* UIProcess/mac/ViewGestureController.h:
* UIProcess/mac/ViewGestureController.mm:
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::didCollectGeometryForSmartMagnificationGesture):
Use an explicit boolean instead of the emptiness of the renderRect() to determine
whether or not the user has already smart-zoomed. renderRect() can be 0x0
if our hit-test hits the body element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove JavaScriptCallFrame and ScriptDebugServer into JavaScriptCore for inspector
joepeck@webkit.org [Sat, 25 Jan 2014 04:42:25 +0000 (04:42 +0000)]
Move JavaScriptCallFrame and ScriptDebugServer into JavaScriptCore for inspector
https://bugs.webkit.org/show_bug.cgi?id=127543

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
Add new files.

* inspector/ScriptDebugListener.h:
Extract WebCore knowledge from ScriptDebugServer. This will
eventually be made to work outside of WebCore.

* inspector/ScriptDebugServer.h: Renamed from Source/WebCore/bindings/js/ScriptDebugServer.h.
* inspector/ScriptDebugServer.cpp: Renamed from Source/WebCore/bindings/js/ScriptDebugServer.cpp.
(Inspector::ScriptDebugServer::evaluateBreakpointAction):
(Inspector::ScriptDebugServer::dispatchDidPause):
(Inspector::ScriptDebugServer::dispatchBreakpointActionLog):
(Inspector::ScriptDebugServer::dispatchBreakpointActionSound):
(Inspector::ScriptDebugServer::sourceParsed):
(Inspector::ScriptDebugServer::dispatchFunctionToListeners):
(Inspector::ScriptDebugServer::handlePause):
Modernize code, and call the new ScriptDebugListener callbacks where appropriate.

* inspector/JSJavaScriptCallFrame.cpp: Renamed from Source/WebCore/bindings/js/JSJavaScriptCallFrameCustom.cpp.
(Inspector::JSJavaScriptCallFrame::JSJavaScriptCallFrame):
(Inspector::JSJavaScriptCallFrame::finishCreation):
(Inspector::JSJavaScriptCallFrame::createPrototype):
(Inspector::JSJavaScriptCallFrame::destroy):
(Inspector::JSJavaScriptCallFrame::releaseImpl):
(Inspector::JSJavaScriptCallFrame::~JSJavaScriptCallFrame):
(Inspector::JSJavaScriptCallFrame::evaluate):
(Inspector::JSJavaScriptCallFrame::scopeType):
(Inspector::JSJavaScriptCallFrame::caller):
(Inspector::JSJavaScriptCallFrame::sourceID):
(Inspector::JSJavaScriptCallFrame::line):
(Inspector::JSJavaScriptCallFrame::column):
(Inspector::JSJavaScriptCallFrame::functionName):
(Inspector::JSJavaScriptCallFrame::scopeChain):
(Inspector::JSJavaScriptCallFrame::thisObject):
(Inspector::JSJavaScriptCallFrame::type):
(Inspector::toJS):
(Inspector::toJSJavaScriptCallFrame):
* inspector/JSJavaScriptCallFrame.h: Added.
(Inspector::JSJavaScriptCallFrame::createStructure):
(Inspector::JSJavaScriptCallFrame::create):
(Inspector::JSJavaScriptCallFrame::impl):
* inspector/JSJavaScriptCallFramePrototype.cpp: Added.
(Inspector::JSJavaScriptCallFramePrototype::finishCreation):
(Inspector::jsJavaScriptCallFramePrototypeFunctionEvaluate):
(Inspector::jsJavaScriptCallFramePrototypeFunctionScopeType):
(Inspector::jsJavaScriptCallFrameAttributeCaller):
(Inspector::jsJavaScriptCallFrameAttributeSourceID):
(Inspector::jsJavaScriptCallFrameAttributeLine):
(Inspector::jsJavaScriptCallFrameAttributeColumn):
(Inspector::jsJavaScriptCallFrameAttributeFunctionName):
(Inspector::jsJavaScriptCallFrameAttributeScopeChain):
(Inspector::jsJavaScriptCallFrameAttributeThisObject):
(Inspector::jsJavaScriptCallFrameAttributeType):
(Inspector::jsJavaScriptCallFrameConstantGLOBAL_SCOPE):
(Inspector::jsJavaScriptCallFrameConstantLOCAL_SCOPE):
(Inspector::jsJavaScriptCallFrameConstantWITH_SCOPE):
(Inspector::jsJavaScriptCallFrameConstantCLOSURE_SCOPE):
(Inspector::jsJavaScriptCallFrameConstantCATCH_SCOPE):
* inspector/JSJavaScriptCallFramePrototype.h: Added.
(Inspector::JSJavaScriptCallFramePrototype::create):
(Inspector::JSJavaScriptCallFramePrototype::createStructure):
(Inspector::JSJavaScriptCallFramePrototype::JSJavaScriptCallFramePrototype):
* inspector/JavaScriptCallFrame.cpp: Renamed from Source/WebCore/bindings/js/JavaScriptCallFrame.cpp.
(Inspector::JavaScriptCallFrame::caller):
* inspector/JavaScriptCallFrame.h: Renamed from Source/WebCore/bindings/js/JavaScriptCallFrame.h.
Port of JavaScriptCallFrame.idl to a set of native JS classes.

Source/WebCore:

Covered by existing tests.

* ForwardingHeaders/inspector/ScriptDebugServer.h: Added.
* GNUmakefile.list.am:
* UseJSC.cmake:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* inspector/JavaScriptCallFrame.idl: Removed.
Update builds now that ScriptDebugServer moved to JavaScriptCore.

* bindings/js/PageScriptDebugServer.h:
* bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::runEventLoopWhilePaused):
(WebCore::PageScriptDebugServer::isContentScript):
(WebCore::PageScriptDebugServer::reportException):
* bindings/js/WorkerScriptDebugServer.h:
* bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
(WebCore::WorkerScriptDebugServer::reportException):
Handle ScriptDebugServer functionality depending on WebCore knowledge.

* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::breakpointActionSound):
Handle ScriptDebugServer functionality that depended on WebCore knowledge.
This will eventually be written in a non-WebCore specific way.

* inspector/InspectorRuntimeAgent.cpp:
* inspector/InspectorRuntimeAgent.h:
Update ScriptDebugServer type now that it is in namespace Inspector.

* workers/WorkerGlobalScope.h:
Make addConsoleMessage public again so the inspector can call it.

* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::breakpointActionLog):
* inspector/PageDebuggerAgent.h:
* inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::breakpointActionLog):
* inspector/WorkerDebuggerAgent.h:
Let each of these handle console logs in their own way. Both of these
eventually go through the PageConsole and log through the InspectorConsoleAgent
and ChromeClient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix EFL WebKit2 build.
jinwoo7.song@samsung.com [Sat, 25 Jan 2014 04:42:00 +0000 (04:42 +0000)]
Fix EFL WebKit2 build.

* WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoImprove latching behavior for wheel events
bfulgham@apple.com [Sat, 25 Jan 2014 04:33:48 +0000 (04:33 +0000)]
Improve latching behavior for wheel events
https://bugs.webkit.org/show_bug.cgi?id=127386
<rdar://problem/12176858>

Reviewed by Simon Fraser.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree): Initialize new values used for tracking
scroll latching state.
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously): Check for an existing
latched node and stay in fast scrolling mode if possible.
(WebCore::ScrollingTree::removeDestroyedNodes): Clear latched node if it's being removed.
(WebCore::ScrollingTree::latchedNode): Added
(WebCore::ScrollingTree::setLatchedNode): Added
(WebCore::ScrollingTree::clearLatchedNode): Added
* page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::hasLatchedNode): Added
* page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::shouldConsiderLatching): Added
(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent): Determine latching state
based on wheel event state and position of mouse pointer in the document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix GTK+ WebKit2 build.
andersca@apple.com [Sat, 25 Jan 2014 03:38:35 +0000 (03:38 +0000)]
Fix GTK+ WebKit2 build.

* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162754 268f45cc-cd09-0410-ab3c-d52691b4dbfc