WebKit-https.git
7 years agoRefactor SVG parts of Node::addEventListener/removeEventListener
rwlbuis@webkit.org [Tue, 15 May 2012 16:59:12 +0000 (16:59 +0000)]
Refactor SVG parts of Node::addEventListener/removeEventListener
https://bugs.webkit.org/show_bug.cgi?id=86426

Reviewed by Nikolas Zimmermann.

Move SVG parts of Node::addEventListener/removeEventListener into svg/. Now we do not
have to check in Node::addEventListener/removeEventListener if we are dealing with an SVG
element. Make tryAddEventListener/tryRemoveEventListener protected methods on Node to be able to use
it in SVGElement.

No new tests, since no change in behavior, just refactoring.

* dom/Node.cpp:
(WebCore::tryAddEventListener):
(WebCore::Node::addEventListener):
(WebCore::tryRemoveEventListener):
(WebCore::Node::removeEventListener):
* svg/SVGElement.cpp:
(WebCore::collectInstancesForSVGElement):
(WebCore):
(WebCore::SVGElement::addEventListener):
(WebCore::SVGElement::removeEventListener):
* svg/SVGElement.h:
(SVGElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGuard some AppKit-specific code in WebKit2 with USE(APPKIT)
aestes@apple.com [Tue, 15 May 2012 16:38:03 +0000 (16:38 +0000)]
Guard some AppKit-specific code in WebKit2 with USE(APPKIT)
https://bugs.webkit.org/show_bug.cgi?id=86444

Reviewed by Sam Weinig.

* Shared/NativeWebKeyboardEvent.h:
(NativeWebKeyboardEvent):
(WebKit::NativeWebKeyboardEvent::nativeEvent):
* Shared/NativeWebMouseEvent.h:
(NativeWebMouseEvent):
(WebKit::NativeWebMouseEvent::nativeEvent):
* Shared/NativeWebWheelEvent.h:
(NativeWebWheelEvent):
(WebKit::NativeWebWheelEvent::nativeEvent):
* Shared/mac/ArgumentCodersMac.h:
(CoreIPC):
* Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::typeFromObject):
(CoreIPC::encode):
(CoreIPC::decode):
* Shared/mac/WebEventFactory.mm:
* WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:
(WebKit::WebPopupMenu::setUpPlatformData):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRuleSet::addToRuleSet wastes a bit of Vector capacity.
kling@webkit.org [Tue, 15 May 2012 16:34:20 +0000 (16:34 +0000)]
RuleSet::addToRuleSet wastes a bit of Vector capacity.
<http://webkit.org/b/86434>

Reviewed by Antti Koivisto.

Have makeRuleSet call shrinkToFit() on the vectors before returning them.
This avoids wasting space for the rulesets constructed in collectFeatures().

* css/StyleResolver.cpp:
(WebCore::makeRuleSet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CG] CGImageCreateWithImageInRect is too slow, but for now we still need to use it
darin@apple.com [Tue, 15 May 2012 16:22:54 +0000 (16:22 +0000)]
[CG] CGImageCreateWithImageInRect is too slow, but for now we still need to use it
https://bugs.webkit.org/show_bug.cgi?id=86340

Reviewed by Geoffrey Garen.

This patch adds a subimage cache to defray the cost of CGImageCreateWithImageInRect.
Later, we will restructure the code so it doesn't use that function, but at the
moment there are CG issues blocking that change.

* platform/graphics/cg/GraphicsContextCG.cpp:
(SubimageCacheEntry): Added. An entry in the cache.
(SubimageCacheEntryTraits): Added. Traits for the cache.
(SubimageCacheHash): Added. Hash function for the cache.
(SubimageCacheTimer): Added. Timer that clears the cache after a second
of inactivity.
(SubimageCacheWithTimer): Added. Cache and its timer.
(WebCore::subimageCache): Added. Function returning the single global timer.
(WebCore::SubimageCacheTimer::restart): Added. Start the timer.
(WebCore::SubimageCacheTimer::fired): Added. Clear the cache when the timer fires.
(SubimageRequest): Added. A key to look up in the cache.
(SubimageCacheAdder): Added. Translator to add to the cache.
(WebCore::subimage): Added. Puts an entry in the cache.
(WebCore::GraphicsContext::drawNativeImage): Changed to call the subimage function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
commit-queue@webkit.org [Tue, 15 May 2012 16:18:21 +0000 (16:18 +0000)]
Unreviewed EFL gardening.

Move http/tests/cookies/third-party-cookie-relaxing.html from Skipped
list to test_expectations.txt. This test is expected to fail on EFL
port and won't be fixed.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-15

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Remove duplicated entries because of disabled SUBPIXEL_LAYOUT.
ossy@webkit.org [Tue, 15 May 2012 16:16:42 +0000 (16:16 +0000)]
[Qt] Unreviewed gardening. Remove duplicated entries because of disabled SUBPIXEL_LAYOUT.

* platform/qt-4.8/Skipped:
* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:
* platform/qt-arm/Skipped:
* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: AdvancedSearchController is not stopped then view is hidden.
commit-queue@webkit.org [Tue, 15 May 2012 16:13:05 +0000 (16:13 +0000)]
Web Inspector: AdvancedSearchController is not stopped then view is hidden.
https://bugs.webkit.org/show_bug.cgi?id=86466

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-15
Reviewed by Vsevolod Vlasov.

AdvancedSearchController overrides "wasHidden" method instead of "willHide".

UI event-flow, not tested.

* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype.willHide): Renamed function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening of flaky tests
commit-queue@webkit.org [Tue, 15 May 2012 16:05:23 +0000 (16:05 +0000)]
[EFL] Gardening of flaky tests
https://bugs.webkit.org/show_bug.cgi?id=86485

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-15

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] adding a functionality for web inspector to inspect current selected...
commit-queue@webkit.org [Tue, 15 May 2012 15:52:05 +0000 (15:52 +0000)]
[BlackBerry] adding a functionality for web inspector to inspect current selected element
https://bugs.webkit.org/show_bug.cgi?id=86394

Patch by Hanna Ma <Hanma@rim.com> on 2012-05-15
Reviewed by Rob Buis.

Add a way to trigger the remote web inspector on selected element.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::inspectCurrentContextElement):
(WebKit):
* Api/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Wk2] Unskip passing svg/dynamic-updates tests after r95878.
ossy@webkit.org [Tue, 15 May 2012 15:48:22 +0000 (15:48 +0000)]
[Qt][Wk2] Unskip passing svg/dynamic-updates tests after r95878.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-15
Reviewed by Csaba Osztrogonác.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] css1/box_properties/acid_test.html fails in release mode on 32 bit Linux
ossy@webkit.org [Tue, 15 May 2012 15:45:45 +0000 (15:45 +0000)]
[Qt] css1/box_properties/acid_test.html fails in release mode on 32 bit Linux
https://bugs.webkit.org/show_bug.cgi?id=36954

Unreviewed gardening, unskip it, because it passes on 32/64 bit too now. (Maybe after r112397)

* platform/qt/Skipped: Try to unskip really. :)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] fast/repaint/scroll-in-clipped-layer.html crashes
ossy@webkit.org [Tue, 15 May 2012 15:43:22 +0000 (15:43 +0000)]
[Qt][WK2] fast/repaint/scroll-in-clipped-layer.html crashes
https://bugs.webkit.org/show_bug.cgi?id=80387

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2012-05-15
Reviewed by Csaba Osztrogonác.

Unskip tests for bug 80387. They do not crash now.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL gardening.
commit-queue@webkit.org [Tue, 15 May 2012 15:40:54 +0000 (15:40 +0000)]
Unreviewed EFL gardening.

Unskip test which require USE(ZLIB). It has been enabled for EFL port
since r110896).

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-15

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [DRT] Unskip passing tests related to computedStyleIncludingVisitedInfo and...
commit-queue@webkit.org [Tue, 15 May 2012 15:38:30 +0000 (15:38 +0000)]
[EFL] [DRT] Unskip passing tests related to computedStyleIncludingVisitedInfo and display
https://bugs.webkit.org/show_bug.cgi?id=86473

Unreviewed gardening, unskip now passing tests.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-15

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] css1/box_properties/acid_test.html fails in release mode on 32 bit Linux
ossy@webkit.org [Tue, 15 May 2012 15:36:02 +0000 (15:36 +0000)]
[Qt] css1/box_properties/acid_test.html fails in release mode on 32 bit Linux
https://bugs.webkit.org/show_bug.cgi?id=36954

Unreviewed gardening, unskip it, because it passes on 32/64 bit too now. (Maybe after r112397)

* platform/qt/css1/box_properties/acid_test-expected.png: Added.
* platform/qt/css1/box_properties/acid_test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html...
jocelyn.turcotte@nokia.com [Tue, 15 May 2012 15:34:09 +0000 (15:34 +0000)]
[Qt] http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html times out
https://bugs.webkit.org/show_bug.cgi?id=84016

Reviewed by Simon Hausmann.

Source/WebCore:

Calling didFail abort the connection and doesn't activate the HEADERS_RECEIVED state.
Since the goal of HEAD is to test then the request should be marked as finished
also in cases of HTTP errors.
This matches other ports behavior.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::shouldIgnoreHttpError):

LayoutTests:

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] fast/loader/create-frame-in-DOMContentLoaded.html crashes
commit-queue@webkit.org [Tue, 15 May 2012 15:15:51 +0000 (15:15 +0000)]
[Qt][WK2] fast/loader/create-frame-in-DOMContentLoaded.html crashes
https://bugs.webkit.org/show_bug.cgi?id=83578

Source/WebKit2:

Retrieve and save page ID only for a valid page in WebFrameNetworkingContext.
The page will be null if the frame was detached from the page.

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-15
Reviewed by Simon Hausmann.

* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
(WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):

LayoutTests:

Unskip passing test.

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-15
Reviewed by Simon Hausmann.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Fix scrolling in touch mode
commit-queue@webkit.org [Tue, 15 May 2012 15:07:59 +0000 (15:07 +0000)]
[Qt][WK2] Fix scrolling in touch mode
https://bugs.webkit.org/show_bug.cgi?id=75006

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

* page/FrameView.cpp:
(WebCore::FrameView::setFixedVisibleContentRect):
    On changes to fixedVisibleContentRect update scroll-animators position, and
    recalculate page-step sizes in scrollbars.
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollTo):
    Forward scrolling-request to the host window.
(WebCore::ScrollView::updateScrollbars):
    Allow ScrollViews to have invisible scrollbars when scrolling is delegated.
* platform/ScrollView.h:
(ScrollView):

Source/WebKit2:

Only handle mouse-wheel events in WebCore to avoid double scrolling, and
scale pixels scrolled by wheel events according to viewport transformation.

* Shared/qt/WebEventFactoryQt.cpp:
(WebKit::WebEventFactory::createWebWheelEvent):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handleWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Refactor SnippetsModel: extract SnippetStorage, make SnippetScriptMapp...
vsevik@chromium.org [Tue, 15 May 2012 14:37:01 +0000 (14:37 +0000)]
Web Inspector: Refactor SnippetsModel: extract SnippetStorage, make SnippetScriptMapping delegate calls to ScriptSnippetModel and provide public interface on ScriptSnippetModel in terms of uiSourceCodes
https://bugs.webkit.org/show_bug.cgi?id=86477

Reviewed by Pavel Feldman.

Source/WebCore:

Extracted SnippetStorage to be reused for other snippet types.
Made SnippetScriptMapping delegate all calls to ScriptSnippetModel and injected it in DebuggerPresentationModel.
ScriptSnippetModel now provides public interface for ScriptsPanel in terms of uiSourceCodes.

Tests: inspector/debugger/script-snippet-model.html
       inspector/snippet-storage.html

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
* inspector/front-end/ScriptSnippetModel.js: Added.
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype.get scriptMapping):
(WebInspector.ScriptSnippetModel.prototype.createScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._rawLocationToUILocation):
(WebInspector.ScriptSnippetModel.prototype._uiLocationToRawLocation.get if):
(WebInspector.ScriptSnippetModel.prototype._uiLocationToRawLocation):
(WebInspector.ScriptSnippetModel.prototype._uiSourceCodeList):
(WebInspector.ScriptSnippetModel.prototype._releasedUISourceCodes):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.ScriptSnippetModel.prototype._sourceURLForSnippet):
(WebInspector.ScriptSnippetModel.prototype._snippetIdForSourceURL):
(WebInspector.ScriptSnippetModel.prototype._snippetForSourceURL):
(WebInspector.ScriptSnippetModel.prototype._reset):
(WebInspector.SnippetScriptMapping):
(WebInspector.SnippetScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.SnippetScriptMapping.prototype.uiLocationToRawLocation):
(WebInspector.SnippetScriptMapping.prototype.uiSourceCodeList):
(WebInspector.SnippetScriptMapping.prototype.snippetIdForSourceURL):
(WebInspector.SnippetScriptMapping.prototype.addScript):
(WebInspector.SnippetScriptMapping.prototype._uiSourceCodesAdded):
(WebInspector.SnippetScriptMapping.prototype._uiSourceCodesRemoved):
(WebInspector.SnippetScriptMapping.prototype.reset):
(WebInspector.SnippetContentProvider):
* inspector/front-end/SnippetStorage.js: Added.
(WebInspector.SnippetStorage):
(WebInspector.SnippetStorage.prototype.get namePrefix):
(WebInspector.SnippetStorage.prototype._saveSettings):
(WebInspector.SnippetStorage.prototype.set snippets):
(WebInspector.SnippetStorage.prototype.snippetForId):
(WebInspector.SnippetStorage.prototype.deleteSnippet):
(WebInspector.SnippetStorage.prototype._snippetAdded):
(WebInspector.SnippetStorage.prototype.reset.set this):
(WebInspector.Snippet):
(WebInspector.Snippet.fromObject):
(WebInspector.Snippet.prototype.get id):
(WebInspector.Snippet.prototype.get name):
(WebInspector.Snippet.prototype.set name):
(WebInspector.Snippet.prototype.get content):
(WebInspector.Snippet.prototype.set content):
(WebInspector.Snippet.prototype.serializeToObject):
* inspector/front-end/SnippetsModel.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

LayoutTests:

* inspector/debugger/script-snippet-model-expected.txt: Added.
* inspector/debugger/script-snippet-model.html: Added.
* inspector/debugger/snippets-model-expected.txt: Removed.
* inspector/debugger/snippets-model.html: Removed.
* inspector/snippet-storage-expected.txt: Added.
* inspector/snippet-storage.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add show/hide debugger sidebar button.
pfeldman@chromium.org [Tue, 15 May 2012 14:15:57 +0000 (14:15 +0000)]
Web Inspector: add show/hide debugger sidebar button.
https://bugs.webkit.org/show_bug.cgi?id=86478

Reviewed by Vsevolod Vlasov.

As with the navigator, but with no overlay. See the screenshot.

* English.lproj/localizedStrings.js:
* inspector/front-end/NavigatorOverlayController.js:
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._debuggerPaused):
(WebInspector.ScriptsPanel.prototype._debuggerResumed):
(WebInspector.ScriptsPanel.prototype._showJavaScriptOutlineDialog):
(WebInspector.ScriptsPanel.prototype._installDebuggerSidebarController.clickHandler):
(WebInspector.ScriptsPanel.prototype._showDebuggerSidebar):
(WebInspector.ScriptsPanel.prototype.set _hideDebuggerSidebar):
* inspector/front-end/scriptsPanel.css:
(#scripts-editor-container-tabbed-pane .tabbed-pane-header-contents):
(button.status-bar-item.scripts-debugger-show-hide-button):
(.status-bar-item.scripts-debugger-show-hide-button > .glyph):
(.status-bar-item.scripts-debugger-show-hide-button.toggled-shown > .glyph):
(.status-bar-item.scripts-debugger-show-hide-button.toggled-hidden > .glyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=83133
ossy@webkit.org [Tue, 15 May 2012 14:11:36 +0000 (14:11 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=83133

Unreviewed gardening, unskip the now passing test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMaking layout testcase: fast/table/empty-section-crash.html result platform independent
commit-queue@webkit.org [Tue, 15 May 2012 13:57:59 +0000 (13:57 +0000)]
Making layout testcase: fast/table/empty-section-crash.html result platform independent
https://bugs.webkit.org/show_bug.cgi?id=86352

After modifying the current handling of collapsed borders for
table (https://bugs.webkit.org/show_bug.cgi?id=67877), the expected output for this testcase
changes. Hence, instead of generating new png images and dumprendertext platform specific
output files, have made the output platform independant by making it dumpAsText() only.
Shall be adding a reftest for this along with https://bugs.webkit.org/show_bug.cgi?id=67877.

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-05-15
Reviewed by Antti Koivisto.

* fast/table/empty-section-crash-expected.txt: Added.
Added new expected file.
* fast/table/empty-section-crash.html:
Modified testcase to make it dumpAsText().

* platform/chromium-linux/fast/table/empty-section-crash-expected.png: Removed.
* platform/chromium-mac-leopard/fast/table/empty-section-crash-expected.png: Removed.
* platform/chromium-win/fast/table/empty-section-crash-expected.png: Removed.
* platform/chromium-win/fast/table/empty-section-crash-expected.txt: Removed.
* platform/efl/fast/table/empty-section-crash-expected.png: Removed.
* platform/efl/fast/table/empty-section-crash-expected.txt: Removed.
* platform/gtk/fast/table/empty-section-crash-expected.png: Removed.
* platform/gtk/fast/table/empty-section-crash-expected.txt: Removed.
* platform/mac/fast/table/empty-section-crash-expected.png: Removed.
* platform/mac/fast/table/empty-section-crash-expected.txt: Removed.
* platform/qt/fast/table/empty-section-crash-expected.png: Removed.
* platform/qt/fast/table/empty-section-crash-expected.txt: Removed.
Removed the platform specific expected output files for empty-section-crash.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Add infra for testing double-tap to zoom functionality etc
kenneth@webkit.org [Tue, 15 May 2012 13:55:26 +0000 (13:55 +0000)]
[Qt] Add infra for testing double-tap to zoom functionality etc
https://bugs.webkit.org/show_bug.cgi?id=86474

Reviewed by Simon Hausmann.

Source/WebKit/qt:

The WebViewportInfo class was renamed to QWebKitTest in preparation
of becoming a separate module. Adapt the use API.

* declarative/experimental/plugin.cpp:

Source/WebKit2:

Rename the WebViewportInfo class to QWebKitTest in preparation
of becoming a separate module. Adapt the use API.

Modify the API to work better for testing and make sure the
signals are emitted the right places. Also add a method for
simulating a double tap.

Work around issue with animations not running when the item
doesn't have focus.

Create an example test for double-tap to zoom, showing how we can
now create UI tests using QML.

* Target.pri:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::setContentsSize):
(QQuickWebPage::setContentsScale):
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
(QQuickWebViewFlickablePrivate::didChangeContentsSize):
(QQuickWebViewExperimental::QQuickWebViewExperimental):
(QQuickWebViewExperimental::test):
(QQuickWebView::mouseDoubleClickEvent):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/qwebkittest.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qwebviewportinfo.cpp.
(QWebKitTest::QWebKitTest):
(QWebKitTest::~QWebKitTest):
(QWebKitTest::touchDoubleTap):
(QWebKitTest::contentsSize):
(QWebKitTest::contentsScale):
(QWebKitTest::devicePixelRatio):
(QWebKitTest::initialScale):
(QWebKitTest::minimumScale):
(QWebKitTest::maximumScale):
(QWebKitTest::isScalable):
(QWebKitTest::layoutSize):
* UIProcess/API/qt/qwebkittest_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qwebviewportinfo_p.h.
* UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml: Added.
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::animateItemRectVisible):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):

Tools:

The WebViewportInfo class was renamed to QWebKitTest in preparation
of becoming a separate module. Adapt the use API.

* MiniBrowser/qt/qml/BrowserWindow.qml:
* MiniBrowser/qt/qml/ViewportInfoItem.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTests added in r117012 (plugins/npruntime/delete-plugin-within-*) failing on Mac...
antti@apple.com [Tue, 15 May 2012 13:41:39 +0000 (13:41 +0000)]
Tests added in r117012 (plugins/npruntime/delete-plugin-within-*) failing on Mac bots
https://bugs.webkit.org/show_bug.cgi?id=86480

Not reviewed.

Skipping.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-05-15 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 15 May 2012 13:23:36 +0000 (13:23 +0000)]
2012-05-15  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Rebaseline svg/repaint/mask-clip-target-transform-expected.png on Lion.

        * platform/mac/svg/repaint/mask-clip-target-transform-expected.png: Added.
        * platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNEONizing forceValidPreMultipliedPixels
zherczeg@webkit.org [Tue, 15 May 2012 13:18:14 +0000 (13:18 +0000)]
NEONizing forceValidPreMultipliedPixels
https://bugs.webkit.org/show_bug.cgi?id=86468

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Optimize forceValidPreMultipliedPixels with ARM-NEON intrinsics.

Existing tests cover this feature.

* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::forceValidPreMultipliedPixels):

Source/WTF:

Allow to disable all intrinsics with a single macro.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: remove unnecessary setTimeout in HeapSnapshotGridNodes.js
yurys@chromium.org [Tue, 15 May 2012 13:08:28 +0000 (13:08 +0000)]
Web Inspector: remove unnecessary setTimeout in HeapSnapshotGridNodes.js
https://bugs.webkit.org/show_bug.cgi?id=86464

Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.childrenRetrieved): Posting
a message to worker is already asynchronous, no need to postpone the call via setTimeout.
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMask deformations when masked content is rotated
fmalita@chromium.org [Tue, 15 May 2012 12:56:35 +0000 (12:56 +0000)]
Mask deformations when masked content is rotated
https://bugs.webkit.org/show_bug.cgi?id=76527

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Test: svg/repaint/mask-clip-target-transform.svg

RenderSVGResource::markForLayoutAndParentResourceInvalidation() needs to also
invalidate parent mask and clip resources, not just filters.

* rendering/svg/RenderSVGResource.cpp:
(WebCore::removeFromCacheAndInvalidateDependencies):
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):

LayoutTests:

* platform/chromium-linux/svg/repaint/mask-clip-target-transform-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/test_expectations.txt:
* svg/repaint/mask-clip-target-transform-expected.txt: Added.
* svg/repaint/mask-clip-target-transform.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: merge show navigator with pin navigator buttons.
pfeldman@chromium.org [Tue, 15 May 2012 12:50:02 +0000 (12:50 +0000)]
Web Inspector: merge show navigator with pin navigator buttons.
https://bugs.webkit.org/show_bug.cgi?id=86469

Reviewed by Vsevolod Vlasov.

See screenshots attached to the bug.

* English.lproj/localizedStrings.js:
* inspector/front-end/Images/navigatorPinButton.png: Removed.
* inspector/front-end/Images/navigatorShowHideButton.png:
* inspector/front-end/NavigatorOverlayController.js:
(WebInspector.NavigatorOverlayController.prototype._toggleNavigator):
(WebInspector.NavigatorOverlayController.prototype.set _pinNavigator):
(WebInspector.NavigatorOverlayController.prototype.set showNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype.hideNavigatorOverlay):
(WebInspector.NavigatorOverlayController.prototype._containingElementFocused):
* inspector/front-end/SidebarOverlay.js:
(WebInspector.SidebarOverlay):
(WebInspector.SidebarOverlay.prototype.show):
(WebInspector.SidebarOverlay.prototype.hide):
* inspector/front-end/navigatorView.css:
(.navigator-tabbed-pane .tabbed-pane-header-contents):
* inspector/front-end/scriptsPanel.css:
(.status-bar-item.scripts-navigator-show-hide-button > .glyph):
(.status-bar-item.scripts-navigator-show-hide-button.toggled-shown > .glyph):
(.status-bar-item.scripts-navigator-show-hide-button.toggled-overlay > .glyph):
(button.status-bar-item.scripts-navigator-show-hide-button):
(button.status-bar-item.scripts-navigator-show-hide-button.toggled-overlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r117052.
ossy@webkit.org [Tue, 15 May 2012 12:47:33 +0000 (12:47 +0000)]
Unreviewed, rolling out r117052.
http://trac.webkit.org/changeset/117052
https://bugs.webkit.org/show_bug.cgi?id=86470

Unskipping compositing tests made 500+ other tests fail
(sideeffect bug) (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-15

* platform/qt-4.8/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroduce ENABLE_CSS_VARIABLES compile flag.
ossy@webkit.org [Tue, 15 May 2012 11:58:30 +0000 (11:58 +0000)]
Introduce ENABLE_CSS_VARIABLES compile flag.
https://bugs.webkit.org/show_bug.cgi?id=86338

Reviewed by Hajime Morita.

* Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Unittest fix after r117028.
(WebKitPortTest.test_skipped_directories_for_symbols):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Wk1] Unskip now passig tests.
ossy@webkit.org [Tue, 15 May 2012 11:33:00 +0000 (11:33 +0000)]
[Qt][Wk1] Unskip now passig tests.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-15
Reviewed by Csaba Osztrogonác.

* platform/qt-4.8/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: implement "Reveal in Dominators view" context menu action
yurys@chromium.org [Tue, 15 May 2012 11:18:07 +0000 (11:18 +0000)]
Web Inspector: implement "Reveal in Dominators view" context menu action
https://bugs.webkit.org/show_bug.cgi?id=86455

Reviewed by Pavel Feldman.

Source/WebCore:

Implemented "Reveal in Dominators view" context menu action for objects
in the console.

Test: inspector/profiler/heap-snapshot-reveal-in-dominators-view.html

* English.lproj/localizedStrings.js:
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._nodeForSnapshotObjectId):
(WebInspector.HeapSnapshot.prototype.nodeClassName):
(WebInspector.HeapSnapshot.prototype.dominatorIdsForNode):
* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId.didGetDominators):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId.expandNextDominator):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.childForPosition):
(WebInspector.HeapSnapshotGridNode.prototype.expandWithoutPopulate):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId.didGetNodePosition):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId.didPopulateChildren):
* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy.prototype.dominatorIdsForNode):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.revealInSummaryView):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId):
(WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu):

LayoutTests:

Test that an object can be revealed in the heap snapshot dominators view
by its heap snapshot object id.

* inspector/profiler/heap-snapshot-reveal-in-dominators-view-expected.txt: Added.
* inspector/profiler/heap-snapshot-reveal-in-dominators-view.html: Added.
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest):
(initialize_HeapSnapshotTest.):
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: exception when switching to heap profiler comparison view
yurys@chromium.org [Tue, 15 May 2012 11:10:22 +0000 (11:10 +0000)]
Web Inspector: exception when switching to heap profiler comparison view
https://bugs.webkit.org/show_bug.cgi?id=86224

Reviewed by Pavel Feldman.

Make sure the messages are dispatched in the same order as they are sent in
case a fake worker is used for heap snapshot processing.

* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.TimerQueue):
(WebInspector.TimerQueue.prototype.addTask):
(WebInspector.TimerQueue.prototype._onTimeout):
(WebInspector.TimerQueue.prototype._scheduleTimer):
(WebInspector.HeapSnapshotFakeWorker):
(WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
(WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTeach webkit-patch to gracefully handle writes of raw utf-8 encoded strings to sys...
vestbo@webkit.org [Tue, 15 May 2012 10:16:35 +0000 (10:16 +0000)]
Teach webkit-patch to gracefully handle writes of raw utf-8 encoded strings to sys.stdout

https://bugs.webkit.org/show_bug.cgi?id=85809

webkit-patch overrides sys.stdout with a StreamWriter that ensures we write utf8
output to stdout, but StreamWriter will by default always encode the object that's
passed to write(). This blows up when the object is a raw string, already encoded
as utf8, and does not match the default behavior of sys.stdout.

To solve this in one place, instead of every single call-site that might write
raw strings, we extend the stdout-wrapper to assume raw strings are utf8 before
passing them on to StreamWriter.write(). This has the benefit of also making the
stacktrace easy to read in the case where this assumption does not hold.

The source of this particular bug was that Executive.run_and_throw_if_fail() will
tee the output of the subprocess, and in the case of running prepare-ChangeLog this
might produce non-ascii output, which gets written directly to sys.stdout as raw
utf8-encoded strings.

Reviewed by Dirk Pranke.

* Scripts/webkit-patch:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe ARM NEON optimized filters does not compile on THUMB2
zherczeg@webkit.org [Tue, 15 May 2012 10:09:31 +0000 (10:09 +0000)]
The ARM NEON optimized filters does not compile on THUMB2
https://bugs.webkit.org/show_bug.cgi?id=86457

Reviewed by Csaba Osztrogonác.

We should disable the compilation on Thumb2 until we fix the code.

* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformArithmeticSoftware):
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):
* platform/graphics/filters/FELighting.cpp:
(WebCore::FELighting::platformApply):
* platform/graphics/filters/arm/FECompositeArithmeticNEON.cpp:
* platform/graphics/filters/arm/FECompositeArithmeticNEON.h:
* platform/graphics/filters/arm/FEGaussianBlurNEON.cpp:
* platform/graphics/filters/arm/FEGaussianBlurNEON.h:
* platform/graphics/filters/arm/FELightingNEON.cpp:
* platform/graphics/filters/arm/FELightingNEON.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, marking plugins/npruntime/delete-plugin-within-getProperty.html
zandobersek@gmail.com [Tue, 15 May 2012 10:04:49 +0000 (10:04 +0000)]
Unreviewed, marking plugins/npruntime/delete-plugin-within-getProperty.html
as crashing for GTK.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit: [EFL] Split ewk_private.h file to multiple private files.
commit-queue@webkit.org [Tue, 15 May 2012 09:49:23 +0000 (09:49 +0000)]
Source/WebKit: [EFL] Split ewk_private.h file to multiple private files.
https://bugs.webkit.org/show_bug.cgi?id=84572

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-05-15
Reviewed by Antonio Gomes.

* PlatformEfl.cmake: Removed ewk_logging.h file from EWebKit_HEADERS.

Source/WebKit/efl: [EFL] Split ewk_private.h file to multiple private files.
https://bugs.webkit.org/show_bug.cgi?id=84572

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-05-15
Reviewed by Antonio Gomes.

Split ewk_private file to multiple private files.
Delete ewk_logging.h and ewk_tiled_private.h files and removed tiled_backing_store logging domain.

* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/EditorClientEfl.cpp:
* WebCoreSupport/FrameLoaderClientEfl.cpp:
* ewk/ewk_auth.cpp:
* ewk/ewk_auth_soup.cpp:
(detach):
* ewk/ewk_auth_soup_private.h: Renamed from Source/WebKit/efl/ewk/ewk_auth_soup.h.
* ewk/ewk_contextmenu_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
(WebCore):
* ewk/ewk_frame.cpp:
* ewk/ewk_frame_private.h: Added.
(WebCore):
(EWKPrivate):
* ewk/ewk_history.cpp:
* ewk/ewk_history_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
(WebCore):
(EWKPrivate):
* ewk/ewk_js.cpp:
* ewk/ewk_js_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
(_Ewk_JS_Object):
* ewk/ewk_main.cpp:
* ewk/ewk_network.cpp:
* ewk/ewk_private.h:
(WebCore):
* ewk/ewk_security_origin_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
(WebCore):
* ewk/ewk_settings.cpp:
* ewk/ewk_settings_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
* ewk/ewk_tiled_backing_store.cpp:
(_Ewk_Tiled_Backing_Store_Item):
(ewk_tiled_backing_store_add):
* ewk/ewk_tiled_backing_store_private.h: Renamed from Source/WebKit/efl/ewk/ewk_tiled_backing_store.h.
(_Ewk_Tile_Stats):
(_Ewk_Tile):
* ewk/ewk_tiled_matrix.cpp:
* ewk/ewk_tiled_matrix_private.h: Renamed from Source/WebKit/efl/ewk/ewk_tiled_matrix.h.
* ewk/ewk_tiled_model.cpp:
(tile_account):
* ewk/ewk_tiled_model_private.h: Renamed from Source/WebKit/efl/ewk/ewk_tiled_model.h.
* ewk/ewk_util.cpp:
* ewk/ewk_util_private.h: Renamed from Source/WebKit/efl/ewk/ewk_util.h.
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
* ewk/ewk_view_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.
(WebCore):
(EWKPrivate):
* ewk/ewk_view_single.cpp:
* ewk/ewk_view_tiled.cpp:
* ewk/ewk_window_features.cpp:
* ewk/ewk_window_features_private.h: Copied from Source/WebKit/efl/ewk/ewk_private.h.

Tools: [EFL][DRT] Split ewk_private.h file to multiple private files.
https://bugs.webkit.org/show_bug.cgi?id=84572

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2012-05-15
Reviewed by Antonio Gomes.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] http/tests/navigation/https-in-page-cache.html fails with timeout
commit-queue@webkit.org [Tue, 15 May 2012 09:39:10 +0000 (09:39 +0000)]
[Qt][WK2] http/tests/navigation/https-in-page-cache.html fails with timeout
https://bugs.webkit.org/show_bug.cgi?id=83576

Patch by Michael Brüning <michael.bruning@nokia.com> on 2012-05-15
Reviewed by Simon Hausmann.

Source/WebKit2:

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleCertificateVerificationRequest):
(QQuickWebView::allowAnyHTTPSCertificateForLocalHost): Added.
(QQuickWebView::setAllowAnyHTTPSCertificateForLocalHost): Added.
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):  Added bool m_allowAnyHTTPSCertificateForLocalHost.

Tools:

Set the PlatformWebView for the Qt port to accept all SSL certificates.

* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::PlatformWebView::PlatformWebView):

LayoutTests:

Unskipped http/tests/navgiation/https-in-page-cache.html

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoKill unnecessary RuntimeEnabledFeatures.h inclusion
morrita@google.com [Tue, 15 May 2012 09:13:39 +0000 (09:13 +0000)]
Kill unnecessary RuntimeEnabledFeatures.h inclusion
https://bugs.webkit.org/show_bug.cgi?id=86451

Reviewed by Kentaro Hara.

No new tests. No behavior change.

* dom/Element.cpp:
* dom/ElementShadow.cpp:
* dom/TreeScope.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeech JavaScript API: Introduce error code enum in Chromium plumbing
hans@chromium.org [Tue, 15 May 2012 08:59:58 +0000 (08:59 +0000)]
Speech JavaScript API: Introduce error code enum in Chromium plumbing
https://bugs.webkit.org/show_bug.cgi?id=86353

Reviewed by Adam Barth.

Introduce an enum for receiving error codes from the embedder.
This enum matches the enum in SpeechRecognitionError.

* public/WebSpeechRecognizerClient.h:
* src/AssertMatchingEnums.cpp:
* src/SpeechRecognitionClientProxy.cpp:
(WebKit::SpeechRecognitionClientProxy::didReceiveError):
* src/SpeechRecognitionClientProxy.h:
(SpeechRecognitionClientProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, GTK gardening after r116986, r117012 and r117016.
zandobersek@gmail.com [Tue, 15 May 2012 08:51:10 +0000 (08:51 +0000)]
Unreviewed, GTK gardening after r116986, r117012 and r117016.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodocument.execCommand('Indent') in the direct child of ShadowRoot causes a crash.
shinyak@chromium.org [Tue, 15 May 2012 08:24:22 +0000 (08:24 +0000)]
document.execCommand('Indent') in the direct child of ShadowRoot causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=86341

Reviewed by Ryosuke Niwa.

.:

Exports necessary symbols.

* Source/autotools/symbols.filter:

Source/WebCore:

When document.execCommand('Indent') is executed in the direct child of ShadowRoot,
the scope variable of TextIterator becomes ShadowRoot. However, an element is assumed for it,
so a crash happended.

This patch enables TextIterator to have ShadowRoot as a scope variable.

Test: editing/shadow/execcommand-indent-in-shadow.html

* WebCore.exp.in:
* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
* editing/TextIterator.cpp:
(WebCore::TextIterator::rangeFromLocationAndLength):
* editing/TextIterator.h:
(TextIterator):
* editing/htmlediting.cpp:
(WebCore::indexForVisiblePosition):
(WebCore::visiblePositionForIndex):
* editing/htmlediting.h:
(WebCore):

Source/WebKit/chromium:

* src/WebRange.cpp:
(WebKit::WebRange::fromDocumentRange):

Source/WebKit2:

Exports necessary symbols.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

* editing/shadow/execcommand-indent-in-shadow-expected.txt: Added.
* editing/shadow/execcommand-indent-in-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] 6 SVG tests assert after r107207
kkristof@inf.u-szeged.hu [Tue, 15 May 2012 08:15:09 +0000 (08:15 +0000)]
[Qt] 6 SVG tests assert after r107207
https://bugs.webkit.org/show_bug.cgi?id=78332

Reviewed by Csaba Osztrogonác.

Unskip these tests because they don't assert now.

* platform/qt/Skipped:
* platform/qt/svg/custom/absolute-sized-content-with-resources-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip one more crashing/asserting test.
ossy@webkit.org [Tue, 15 May 2012 07:59:01 +0000 (07:59 +0000)]
[Qt] Unreviewed gardening, skip one more crashing/asserting test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Update test expectations.
commit-queue@webkit.org [Tue, 15 May 2012 07:42:28 +0000 (07:42 +0000)]
[EFL] Update test expectations.

Unreviewed EFL gardening, add 2 failing tests to
test_expectations.txt and remove 1 test that no longer exists.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-15

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2012-05-14 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Tue, 15 May 2012 07:13:40 +0000 (07:13 +0000)]
2012-05-14  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Renegerate three pixel test results on Lion, so that the svg/ pixel tests pass with tolerance 0 again.

        * platform/mac/svg/as-image/image-respects-pageScaleFactor-expected.png:
        * platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
        * platform/mac/svg/hixie/mixed/003-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNode::shadowTreeRootNode() should return ShadowRoot instead of Node.
shinyak@chromium.org [Tue, 15 May 2012 07:11:59 +0000 (07:11 +0000)]
Node::shadowTreeRootNode() should return ShadowRoot instead of Node.
https://bugs.webkit.org/show_bug.cgi?id=86428

Reviewed by Hajime Morita.

Source/WebCore:

Since Node::shadowTreeRootNode() returns only ShadowRoot or 0 now, its return type should be ShadowRoot.
This patch changes the return type and adds include directive to build.

No new tests, no change in behavior.

* dom/Node.cpp:
(WebCore::Node::shadowAncestorNode):
(WebCore::Node::shadowTreeRootNode):
* dom/Node.h:
(WebCore):
(Node):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
* dom/Range.cpp:
(WebCore::Range::shadowTreeRootNode):
* dom/Range.h:
(Range):
* editing/Editor.cpp:
* editing/TextIterator.cpp:
* editing/htmlediting.cpp:
* html/shadow/ContentSelectorQuery.cpp:
* html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::parseAttribute):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::detach):
* page/EventHandler.cpp:

Source/WebKit/chromium:

Adds include directive to build.

* src/WebFrameImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoContent Security Policy console error messages should include the violated directive.
commit-queue@webkit.org [Tue, 15 May 2012 07:04:00 +0000 (07:04 +0000)]
Content Security Policy console error messages should include the violated directive.
https://bugs.webkit.org/show_bug.cgi?id=86323

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-15
Reviewed by Adam Barth.

Update global expectations for 1 Content Security Policy test after r117006.

* http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake StyleResolver::applyMatchedProperties and ::applyProperties use enum template...
macpherson@chromium.org [Tue, 15 May 2012 06:36:25 +0000 (06:36 +0000)]
Make StyleResolver::applyMatchedProperties and ::applyProperties use enum template parameter instead of bool.
https://bugs.webkit.org/show_bug.cgi?id=86424

Reviewed by Dimitri Glazkov.

This patch changes from using a boolean template parameter for StyleResolver::applyMatchedProperties and
StyleResolver::applyProperties functions. The motivation for this change is that it paves the way for
CSS Variables to make the value tri-state, which is a requirement because variable definitions must occur
before high priority CSS properties such that they can be referenced by the latter. This change affects
only the type signatures of those functions, and not their behavior.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Get rid of ContentDistribution::Item
morrita@google.com [Tue, 15 May 2012 06:30:25 +0000 (06:30 +0000)]
[Refactoring] Get rid of ContentDistribution::Item
https://bugs.webkit.org/show_bug.cgi?id=86350

This change replaces the linked list on ContentDistribution with a Vector.
We no longer link item class ContentDistribution::Item.
This simplification also allows ContentDistribution to go.
ContentDistribution is now just a typedef of Vector<RefPtr<Node> >.

Reviewed by Dimitri Glazkov.

No new tests. Covered by existing tests.

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
* dom/ElementShadow.cpp:
* dom/ElementShadow.h:
(ElementShadow):
* dom/NodeRenderingContext.cpp:
(WebCore::nextRendererOfInsertionPoint):
(WebCore::previousRendererOfInsertionPoint):
(WebCore::firstRendererOfInsertionPoint):
(WebCore::lastRendererOfInsertionPoint):
* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::clearDistribution):
(WebCore::ContentDistributor::findInsertionPointFor):
* html/shadow/ContentDistributor.h:
(WebCore):
(ContentDistributor):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::attachDistributedNode):
(WebCore::InsertionPoint::assignShadowRoot):
(WebCore::InsertionPoint::nextTo):
(WebCore):
(WebCore::InsertionPoint::previousTo):
* html/shadow/InsertionPoint.h: Added a set of delegate method to m_distribution.
(WebCore::InsertionPoint::hasDistribution):
(WebCore::InsertionPoint::indexOf):
(WebCore::InsertionPoint::size):
(WebCore::InsertionPoint::at):
(WebCore::InsertionPoint::first):
(WebCore::InsertionPoint::last):
(InsertionPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderLayer::repaintRectIncludingDescendants shouldn't include repaint rects of compo...
timothy_horton@apple.com [Tue, 15 May 2012 06:12:05 +0000 (06:12 +0000)]
RenderLayer::repaintRectIncludingDescendants shouldn't include repaint rects of composited descendants
https://bugs.webkit.org/show_bug.cgi?id=86429
<rdar://problem/11445132>

Reviewed by Simon Fraser.

Change repaintRectIncludingDescendants to not include repaint rects for composited child layers,
and rename the function to make it more clear that that's what it does now.

No new tests, scrolling performance optimization.

* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::repaintRectIncludingNonCompositingDescendants):
* rendering/RenderLayer.h:
(RenderLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed morning gardening to paint the Qt bots green.
ossy@webkit.org [Tue, 15 May 2012 05:55:57 +0000 (05:55 +0000)]
[Qt] Unreviewed morning gardening to paint the Qt bots green.

* http/tests/security/contentSecurityPolicy/shared-worker-connect-src-blocked-expected.txt: Updated after r117006.
* platform/qt/Skipped: Skip new failing/crashing tests.
* platform/qt/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Updated after r117006.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update test expectations.
tkent@chromium.org [Tue, 15 May 2012 05:08:34 +0000 (05:08 +0000)]
[Chromium] Update test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Prerenderer, PrerenderHandle and a chromium interface for Prerendering.
gavinp@chromium.org [Tue, 15 May 2012 04:42:52 +0000 (04:42 +0000)]
Add Prerenderer, PrerenderHandle and a chromium interface for Prerendering.
https://bugs.webkit.org/show_bug.cgi?id=85005

Reviewed by Adam Barth.

Source/Platform:

* Platform.gypi:
* chromium/public/WebPrerender.h:
(WebKit::WebPrerender::referrer):
(WebCore):
(WebPrerender):
* chromium/public/WebPrerenderingSupport.h:
(WebKit):
(WebPrerenderingSupport):
* chromium/public/WebURLRequest.h:
* chromium/src/WebPrerenderingSupport.cpp: Added.
(WebKit):
(WebKit::WebPrerenderingSupport::initialize):
(WebKit::WebPrerenderingSupport::shutdown):
(WebKit::WebPrerenderingSupport::current):

Source/WebCore:

The prerender case isn't quite a resource load, and using resource loading to
retrieve them has constrained the API, and unnecessarily complicated the loader.

The new Prerenderer and PrerenderHandle let <link rel=prerender...> elements signal
removal and unload to their platform.

No new tests, as this interface requires a full platform to work, and doesn't affect layout.  Test
it with your platform when implemented for it.

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore):
(Document):
(WebCore::Document::prerenderer):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::removedFrom):
* html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::LinkRelAttribute):
* html/LinkRelAttribute.h:
(LinkRelAttribute):
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
(WebCore::LinkLoader::released):
* loader/LinkLoader.h:
(WebCore):
(LinkLoader):
* loader/Prerenderer.cpp: Added.
(WebCore):
(WebCore::Prerenderer::create):
(WebCore::Prerenderer::Prerenderer):
(WebCore::Prerenderer::~Prerenderer):
(WebCore::Prerenderer::render):
(WebCore::Prerenderer::stop):
(WebCore::Prerenderer::suspend):
(WebCore::Prerenderer::resume):
(WebCore::Prerenderer::document):
(WebCore::Prerenderer::client):
* loader/Prerenderer.h: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebCore):
(Prerenderer):
* loader/PrerendererClient.cpp: Copied from Source/WebCore/html/LinkRelAttribute.h.
(WebCore):
(WebCore::PrerendererClient::supplementName):
(WebCore::PrerendererClient::from):
(WebCore::providePrerendererClientTo):
* loader/PrerendererClient.h: Copied from Source/WebCore/html/LinkRelAttribute.h.
(WebCore):
(PrerendererClient):
(WebCore::PrerendererClient::~PrerendererClient):
(WebCore::PrerendererClient::PrerendererClient):
* loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):
(WebCore::cachedResourceTypeToTargetType):
(WebCore::CachedResource::load):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::ignoreForRequestCount):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::checkInsecureContent):
(WebCore::CachedResourceLoader::canRequest):
* platform/PrerenderHandle.h: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebCore):
(PrerenderHandle):
* platform/chromium/Prerender.cpp: Added.
(WebCore):
(WebCore::Prerender::Prerender):
(WebCore::Prerender::~Prerender):
(WebCore::Prerender::setState):
(WebCore::Prerender::add):
(WebCore::Prerender::cancel):
(WebCore::Prerender::abandon):
(WebCore::Prerender::suspend):
(WebCore::Prerender::resume):
* platform/chromium/Prerender.h: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebCore):
(Prerender):
(ExtraData):
(WebCore::Prerender::ExtraData::~ExtraData):
(WebCore::Prerender::url):
(WebCore::Prerender::referrer):
(WebCore::Prerender::referrerPolicy):
(WebCore::Prerender::setExtraData):
(WebCore::Prerender::extraData):
* platform/chromium/PrerenderHandle.cpp: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebCore):
(WebCore::PrerenderHandle::create):
(WebCore::PrerenderHandle::PrerenderHandle):
(WebCore::PrerenderHandle::~PrerenderHandle):
(WebCore::PrerenderHandle::prerender):
(WebCore::PrerenderHandle::add):
(WebCore::PrerenderHandle::cancel):
(WebCore::PrerenderHandle::abandon):
(WebCore::PrerenderHandle::suspend):
(WebCore::PrerenderHandle::resume):
(WebCore::PrerenderHandle::url):
(WebCore::PrerenderHandle::referrer):
(WebCore::PrerenderHandle::referrerPolicy):
* platform/chromium/support/WebPrerender.cpp: Copied from Source/Platform/chromium/public/WebPrerender.h.
(WebKit::WebPrerender::WebPrerender):
(WebKit):
(WebKit::WebPrerender::~WebPrerender):
(WebKit::WebPrerender::url):
(WebKit::WebPrerender::referrer):
(WebKit::WebPrerender::referrerPolicy):
(WebKit::WebPrerender::setExtraData):
(WebKit::WebPrerender::extraData):
* platform/network/blackberry/ResourceRequest.h:
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::platformTargetTypeForRequest):
* platform/network/chromium/ResourceRequest.h:

Source/WebKit/chromium:

The prerender case isn't quite a resource load, and using resource loading to
retrieve them has constrained the API, and unnecessarily complicated the loader.

The new Prerenderer and PrerenderHandle let <link rel=prerender...> elements signal
removal and unload to their platform.

* WebKit.gyp:
* public/WebView.h:
* src/PrerendererClientImpl.cpp: Copied from Source/WebCore/html/LinkRelAttribute.h.
(WebKit):
(WebKit::PrerendererClientImpl::PrerendererClientImpl):
(WebKit::PrerendererClientImpl::willAddPrerender):
* src/PrerendererClientImpl.h: Copied from Source/WebCore/html/LinkRelAttribute.h.
(WebCore):
(WebKit):
(PrerendererClientImpl):
* src/WebKit.cpp:
(WebKit::shutdown):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setPrerendererClient):
(WebKit):
* src/WebViewImpl.h:
(WebKit):
(WebViewImpl):

LayoutTests:

The prerender case isn't quite a resource load, and using resource loading to
retrieve them has constrained the API, and unnecessarily complicated the loader.

The new Prerenderer and PrerenderHandle let <link rel=prerender...> elements signal
removal and unload to their platform.

These tests are being removed, and expectations updated, because the old phantom-load
prerendering interface was susceptible to layout testing, and the new interface requires
a full platform to test, so it can't really be a layout test.

* fast/dom/HTMLLinkElement/prerender-expected.txt: Removed.
* fast/dom/HTMLLinkElement/prerender.html: Removed.
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIntroduce ENABLE_CSS_VARIABLES compile flag.
macpherson@chromium.org [Tue, 15 May 2012 04:39:07 +0000 (04:39 +0000)]
Introduce ENABLE_CSS_VARIABLES compile flag.
https://bugs.webkit.org/show_bug.cgi?id=86338

Reviewed by Dimitri Glazkov.

Add a configuration option for CSS Variables support, disabling it by default.

.:

* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests. This patch only introduces an unused build flag.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort._missing_symbol_to_skipped_tests):
* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd WTF_USE_APPKIT to differentiate platforms that use AppKit.framework from other...
aestes@apple.com [Tue, 15 May 2012 04:36:26 +0000 (04:36 +0000)]
Add WTF_USE_APPKIT to differentiate platforms that use AppKit.framework from other Darwin platforms
https://bugs.webkit.org/show_bug.cgi?id=86432

Reviewed by Maciej Stachowiak.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStyles are not recalculated when the seamless attribute is dynamically added/removed
eric@webkit.org [Tue, 15 May 2012 04:36:22 +0000 (04:36 +0000)]
Styles are not recalculated when the seamless attribute is dynamically added/removed
https://bugs.webkit.org/show_bug.cgi?id=86315

Reviewed by Andreas Kling.

Source/WebCore:

Covered by fast/frames/seamless/seamless-css-cascade.html.

* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::isPresentationAttribute):
 - Make seamless a presentational attribute, which means style on the <iframe> will
   be forced to recalculate when it changes.  This is correct, but not observable
   until the layout changes are landed (as then the iframe should correctly revert to not
   being sized to fit its content if seamless is removed).
(WebCore::HTMLIFrameElement::parseAttribute):
 - When the seamless attribute is added or remove, force the content document to recalc
   its style resolver, which will refresh the list of inherited stylesheets from the
   parent.  This doesn't need to happen synchronously.  When the layout changes land
   the content document will actually cause that recalc to redirect to the parent document
   in the seamless case anyway, but it's more correct to ask the content document directly.

LayoutTests:

Add a subtest to cover this case.

* fast/frames/seamless/seamless-css-cascade-expected.txt:
* fast/frames/seamless/seamless-css-cascade.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCannot login to iCloud
barraclough@apple.com [Tue, 15 May 2012 03:43:54 +0000 (03:43 +0000)]
Cannot login to iCloud
https://bugs.webkit.org/show_bug.cgi?id=86321

Reviewed by Filip Pizlo.

This is a bug introduced by bug#85853, we shouldn't allow assignment to
the prototype property of functions to be cached, since we need to clear
the cached inheritorID.

* runtime/JSFunction.cpp:
(JSC::JSFunction::put):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update text expectations.
tkent@chromium.org [Tue, 15 May 2012 03:42:19 +0000 (03:42 +0000)]
[Chromium] Update text expectations.

* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt.
* platform/chromium-linux-x86/fast/replaced/replaced-breaking-expected.txt: Removed.
* platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
* platform/chromium-mac-snowleopard/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.
* platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] remove skia/third_party/glu from DEPS
gavinp@chromium.org [Tue, 15 May 2012 03:26:48 +0000 (03:26 +0000)]
[Chromium] remove skia/third_party/glu from DEPS
https://bugs.webkit.org/show_bug.cgi?id=86431

Chromium rev 136872 removed skia/third_party/glu, but nobody updated it in WebKit.  This
patch fixes that.

Unreviewed, remove bad Chromium repo.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Prevent KeyCodeConversionAndroid from breaking on next NDK roll
abarth@webkit.org [Tue, 15 May 2012 01:10:52 +0000 (01:10 +0000)]
[chromium] Prevent KeyCodeConversionAndroid from breaking on next NDK roll
https://bugs.webkit.org/show_bug.cgi?id=86415

Patch by Alexandre Elias <aelias@google.com> on 2012-05-14
Reviewed by Adam Barth.

The new enum values added in this file have been added in recent
versions of the NDK, so this file will fail to compile with duplicate
enum error when we roll NDK to r7c or higher.  A workaround is
to move our enum values to the WebCore namespace.  When the NDK
upgrade is complete, we can delete them.

No new tests. (No-op change.)

* platform/chromium/KeyCodeConversionAndroid.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=86420
bdakin@apple.com [Tue, 15 May 2012 01:06:42 +0000 (01:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86420
ScrollbarPainter should support expansionTransitionProgress

Reviewed by Sam Weinig.

expansionTransitionProgress works the same as
uiStateTransitionProgress. This code just echoes that code, but for
expansion instead of uiState.
* platform/mac/NSScrollerImpDetails.h:
* platform/mac/ScrollAnimatorMac.mm:
(supportsExpansionTransitionProgress):
(-[WebScrollbarPartAnimation setCurrentProgress:]):
(-[WebScrollbarPainterDelegate cancelAnimations]):
(-[WebScrollbarPainterDelegate scrollerImp:animateExpansionTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate invalidate]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebKit/chromium: Unreviewed, roll Chromium DEPS to r136942.
dpranke@chromium.org [Tue, 15 May 2012 00:22:21 +0000 (00:22 +0000)]
Source/WebKit/chromium: Unreviewed, roll Chromium DEPS to r136942.

LayoutTests: fast/loader/javascript-url-in-embed.html is failing after r115646
https://bugs.webkit.org/show_bug.cgi?id=86414

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix RunLoopCF.cpp's copyright string.
aestes@apple.com [Tue, 15 May 2012 00:11:23 +0000 (00:11 +0000)]
Fix RunLoopCF.cpp's copyright string.

* platform/cf/RunLoopCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove the parts of RunLoopMac.mm that aren't Mac-specific into RunLoopCF.cpp
aestes@apple.com [Tue, 15 May 2012 00:05:12 +0000 (00:05 +0000)]
Move the parts of RunLoopMac.mm that aren't Mac-specific into RunLoopCF.cpp
https://bugs.webkit.org/show_bug.cgi?id=86411

Reviewed by Anders Carlsson.

Most of RunLoopMac.mm was written in terms of CF API. Move these bits
to a new file called RunLoopCF.cpp, leaving only the bits dealing with
NSApplication.

* WebCore.xcodeproj/project.pbxproj: Xcode decided to give
VisitedLinks.* new UUIDs. I'll allow it.
* platform/cf/RunLoopCF.cpp: Copied from Source/WebCore/platform/mac/RunLoopMac.mm.
* platform/mac/RunLoopMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Add "stack" property to DOMException
arv@chromium.org [Mon, 14 May 2012 23:54:49 +0000 (23:54 +0000)]
[V8] Add "stack" property to DOMException
https://bugs.webkit.org/show_bug.cgi?id=85057

Reviewed by Kentaro Hara.

When we create a DOM exception we define a V8 accessor for the stack property. This
accessor uses a new Error object to get the underlying stack string.

Source/WebCore:

Test: fast/dom/DOMException/stack-trace.html

* bindings/v8/V8Proxy.cpp:
(WebCore::DOMExceptionStackGetter):
(WebCore):
(WebCore::DOMExceptionStackSetter):
(WebCore::V8Proxy::setDOMException):

LayoutTests:

* fast/dom/DOMException/stack-trace-expected.txt: Added.
* fast/dom/DOMException/stack-trace.html: Added.
* platform/chromium/fast/dom/DOMException/stack-trace-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnh: Add the Ability to Disable / Enable JavaScript GC Timer
msaboff@apple.com [Mon, 14 May 2012 23:47:53 +0000 (23:47 +0000)]
Enh: Add the Ability to Disable / Enable JavaScript GC Timer
https://bugs.webkit.org/show_bug.cgi?id=86382

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add flag to GCActivityCallback to enable / disable activity timer.
Add api via Heap to set the flag's value.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Windows export
* heap/Heap.cpp:
(JSC::Heap::setGarbageCollectionTimerEnabled):
* heap/Heap.h:
* runtime/GCActivityCallback.h:
(JSC::GCActivityCallback::isEnabled):
(JSC::GCActivityCallback::setEnabled):
(JSC::GCActivityCallback::GCActivityCallback):
* runtime/GCActivityCallbackCF.cpp:
(JSC::DefaultGCActivityCallbackPlatformData::timerDidFire):

Source/WebCore:

Plumbing to set / clear JS GC activity timer enable flag.

* WebCore.exp.in:
* bindings/js/GCController.cpp:
(WebCore::GCController::setJavaScriptGarbageCollectorTimerEnabled):
* bindings/js/GCController.h:

Source/WebKit/mac:

Plumbing to set / clear JS GC activity timer enable flag.

* Misc/WebCoreStatistics.h:
* Misc/WebCoreStatistics.mm:
(+[WebCoreStatistics setJavaScriptGarbageCollectorTimerEnabled:]):

Source/WebKit2:

Plumbing to set / clear JS GC activity timer enable flag.

* UIProcess/API/C/WKContext.cpp:
(WKContextSetJavaScriptGarbageCollectorTimerEnabled):
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::setJavaScriptGarbageCollectorTimerEnabled):
* UIProcess/WebContext.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setJavaScriptGarbageCollectorTimerEnabled):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/replaced/width100percent-searchfield is still failing on chromium leopard/snowle...
dpranke@chromium.org [Mon, 14 May 2012 23:47:22 +0000 (23:47 +0000)]
fast/replaced/width100percent-searchfield is still failing on chromium leopard/snowleopard
https://bugs.webkit.org/show_bug.cgi?id=86412

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncrease Debug Logging in MarkStack::validate()
msaboff@apple.com [Mon, 14 May 2012 23:45:45 +0000 (23:45 +0000)]
Increase Debug Logging in MarkStack::validate()
https://bugs.webkit.org/show_bug.cgi?id=86408

Rubber-stamped by Filip Pizlo.

Added some descriptive debug messages for the conditions and
values when a cell validation fails.

* heap/MarkStack.cpp:
(JSC::MarkStack::validate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [V8] Crash in npObjectGetProperty() in V8NPObject.cpp
japhet@chromium.org [Mon, 14 May 2012 23:37:39 +0000 (23:37 +0000)]
Source/WebCore: [V8] Crash in npObjectGetProperty() in V8NPObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=86131

Reviewed by Adam Barth.

Tests: plugins/npruntime/delete-plugin-within-getProperty.html
       plugins/npruntime/delete-plugin-within-hasProperty-return-false.html
       plugins/npruntime/delete-plugin-within-hasProperty-return-true.html
       plugins/npruntime/delete-plugin-within-invoke.html
       plugins/npruntime/delete-plugin-within-setProperty.html

* bindings/v8/NPV8Object.cpp:
(_NPN_EvaluateHelper):
* bindings/v8/V8NPObject.cpp: Check NPN_IsAlive in a bunch of places we're not currently.
(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):
(WebCore::npObjectSetProperty):

Tools: Add end-of-life test cases for https://bugs.webkit.org/show_bug.cgi?id=86131.

Reviewed by Adam Barth.

* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(callDeletePlugin):
(pluginHasProperty):
(pluginHasMethod):
(pluginGetProperty):
(pluginSetProperty):
(pluginInvoke):

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=86131.

Reviewed by Adam Barth.

* plugins/npruntime/delete-plugin-within-getProperty-expected.txt: Added.
* plugins/npruntime/delete-plugin-within-getProperty.html: Added.
* plugins/npruntime/delete-plugin-within-hasProperty-return-false-expected.txt: Added.
* plugins/npruntime/delete-plugin-within-hasProperty-return-false.html: Added.
* plugins/npruntime/delete-plugin-within-hasProperty-return-true-expected.txt: Added.
* plugins/npruntime/delete-plugin-within-hasProperty-return-true.html: Added.
* plugins/npruntime/delete-plugin-within-invoke-expected.txt: Added.
* plugins/npruntime/delete-plugin-within-invoke.html: Added.
* plugins/npruntime/delete-plugin-within-setProperty-expected.txt: Added.
* plugins/npruntime/delete-plugin-within-setProperty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WinCairo] Unreviewed build correction.
bfulgham@webkit.org [Mon, 14 May 2012 23:19:09 +0000 (23:19 +0000)]
[WinCairo] Unreviewed build correction.

* platform/win/DragImageCairoWin.cpp: Add missing include for
new NativeImageCairo.h type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRe-enable "drt mode" on chromium-mac-leopard
dpranke@chromium.org [Mon, 14 May 2012 23:19:04 +0000 (23:19 +0000)]
Re-enable "drt mode" on chromium-mac-leopard
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, build fix (change?).

This change is another attempt to gather data on
the flakiness and timeouts we're seeing on Mac SL
now that we have another bot.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline http/tests/misc/will-send-request-returns-null-on-redirect on chromium.
dpranke@chromium.org [Mon, 14 May 2012 23:11:46 +0000 (23:11 +0000)]
Rebaseline http/tests/misc/will-send-request-returns-null-on-redirect on chromium.

https://bugs.webkit.org/show_bug.cgi?id=60121

Unreviewed, baselines change.

* platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<http://webkit.org/b/86320> WTF.xcodeproj builds with -O3 in debug builds
mrowe@apple.com [Mon, 14 May 2012 23:02:20 +0000 (23:02 +0000)]
<webkit.org/b/86320> WTF.xcodeproj builds with -O3 in debug builds

Reviewed by Simon Fraser.

* WTF.xcodeproj/project.pbxproj: Ensure that the debug configuration uses the
same settings as the debug variant would.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in WebCore::RenderObject::repaint
commit-queue@webkit.org [Mon, 14 May 2012 22:36:03 +0000 (22:36 +0000)]
Crash in WebCore::RenderObject::repaint
https://bugs.webkit.org/show_bug.cgi?id=86162

Patch by Takashi Sakamoto <tasak@google.com> on 2012-05-14
Reviewed by Abhishek Arya.

Source/WebCore:

As RenderScrollbarPart has no parent renderer, we crash in
WebCore::RenderBoxModelObject::paddingLeft when paddingLeft has
percent value, e.g. 5%. However if we set the scrollbar's parent
renderer to a renderer owning the scrollbar by using setParent method,
RenderScrollbarPart::styleWillChange will invoke parent renderer's
repaint. This causes crash in WebCore::RenderObject::repaint if the
owning renderer is already destroyed.
To fix the first crash without the second crash, modify
RenderObject::containingBlock() to check isRenderScrollbarPart or not,
if parent() is 0.
If so, use scrollbar's owningRenderer from RenderScrollbarPart.

Test: scrollbars/scrollbar-percent-padding-crash.html
      scrollbars/scrollbar-scrollbarparts-repaint-crash.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock):
Modifying containingBlock. If parent() is 0 and isRenderScrollbarPart()
is true, use RenderScrollbarPart's m_scrollbar->owningRenderer()
instead of parent().
* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderScrollbarPart):
(RenderObject):
Adding a new method, isRenderScrollbarPart.
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::rendererOwningScrollbar):
(WebCore):
Adding a new method, scrollbarOwningRenderer to obtain m_scrollar's
owningRenderer.
* rendering/RenderScrollbarPart.h:
(RenderScrollbarPart):
Removing "friend class RenderScrollbar".
(WebCore::RenderScrollbarPart::isRenderScrollbarPart):
(WebCore::toRenderScrollbarPart):
(WebCore):
Implementing isRenderScrollbarPart and toRenderScrollbarPart.

LayoutTests:

* scrollbars/scrollbar-scrollbarparts-repaint-crash-expected.txt: Added.
* scrollbars/scrollbar-scrollbarparts-repaint-crash.html: Added.
* scrollbars/scrollbar-percent-padding-crash-expected.txt: Added.
* scrollbars/scrollbar-percent-padding-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoContent Security Policy console errors include violated directive.
commit-queue@webkit.org [Mon, 14 May 2012 21:53:58 +0000 (21:53 +0000)]
Content Security Policy console errors include violated directive.
https://bugs.webkit.org/show_bug.cgi?id=86323

Source/WebCore:

Patch by Mike West <mike@mikewest.org> on 2012-05-14
Reviewed by Adam Barth.

Console errors generated when resources, inline script/style, or eval
are blocked by Content Security Policy directives should include the
text of the directive that's been violated. This gives developers more
of the information they need to resolve the issue.

Test: http/tests/security/contentSecurityPolicy/*

* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):

LayoutTests:

Sharded http/tests/security/contentSecurityPolicy/source-list-parsing.html
into four tests, and reworked it to have a well-defined order.

Patch by Mike West <mike@mikewest.org> on 2012-05-14
Reviewed by Adam Barth.

* http/tests/security/contentSecurityPolicy/block-mixed-content-hides-warning-expected.txt:
* http/tests/security/contentSecurityPolicy/combine-multiple-policies-expected.txt:
* http/tests/security/contentSecurityPolicy/connect-src-eventsource-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/directive-parsing-01-expected.txt:
* http/tests/security/contentSecurityPolicy/directive-parsing-02-expected.txt:
* http/tests/security/contentSecurityPolicy/directive-parsing-03-expected.txt:
* http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/image-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
* http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
* http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
* http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt:
* http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-expected.txt:
* http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
* http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
* http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-self-blocked-01-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-self-blocked-02-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-self-blocked-03-expected.txt:
* http/tests/security/contentSecurityPolicy/source-list-parsing-expected.txt: Removed
* http/tests/security/contentSecurityPolicy/source-list-parsing.html: Removed
* http/tests/security/contentSecurityPolicy/source-list-parsing-01-expected.txt: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-01.html: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-02-expected.txt: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-02.html: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-03-expected.txt: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-03.html: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-04-expected.txt: Added
* http/tests/security/contentSecurityPolicy/source-list-parsing-04.html: Added
* http/tests/security/contentSecurityPolicy/srcdoc-doesnt-bypass-script-src-expected.txt:
* http/tests/security/contentSecurityPolicy/style-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/worker-connect-src-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt:
* http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt:
* media/csp-blocks-video-expected.txt:
* platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in FrameView::windowClipRectForFrameOwner after r116371
jchaffraix@webkit.org [Mon, 14 May 2012 21:50:42 +0000 (21:50 +0000)]
Crash in FrameView::windowClipRectForFrameOwner after r116371
https://bugs.webkit.org/show_bug.cgi?id=86035

Reviewed by David Hyatt.

Added a NULL-check for |parentView| as nothing guarantees it to be
non-NULL. Unfortunately no test as this is a crasher I couldn't
reproduce on my machine and the user logs were not helpful.

* page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=86403
bdakin@apple.com [Mon, 14 May 2012 21:47:48 +0000 (21:47 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86403
ASSERTION FAILED: m_verticalScrollbarPainterDelegate on recent builds
-and corresponding-
<rdar://problem/11448841>

Reviewed by Simon Fraser.

http://trac.webkit.org/changeset/116476 accidentally started calling
these functions for custom scrollbars. This change replaces that
guard.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::destroyScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r116981.
commit-queue@webkit.org [Mon, 14 May 2012 21:28:37 +0000 (21:28 +0000)]
Unreviewed, rolling out r116981.
http://trac.webkit.org/changeset/116981
https://bugs.webkit.org/show_bug.cgi?id=86402

Caused compositing and mathml tests to fail. (Requested by
rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_webcore_library):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix regressions in garden-o-matic after r116988.
dpranke@chromium.org [Mon, 14 May 2012 21:25:09 +0000 (21:25 +0000)]
Fix regressions in garden-o-matic after r116988.

Unreviewed, build fix.

I had a typo in a field name in checkout.js, and unfortunately
the unittests had the same typo :(.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert CSS and Parser tests to runs/s tests
rniwa@webkit.org [Mon, 14 May 2012 21:19:51 +0000 (21:19 +0000)]
Convert CSS and Parser tests to runs/s tests
https://bugs.webkit.org/show_bug.cgi?id=86399

Reviewed by Ojan Vafai.

Use runPerSecond instead of run to measure results in function calls per second (run/s) instead of time (ms).
This allows us to continue measuring performance reliably even when WebKit's performance improves and results
become too small for Date.now()'s precision (around 15 ms).

It should also reduce perf. bots cycle time for slower tests because we limit the number of function calls by time.

* CSS/CSSPropertySetterGetter.html:
* CSS/CSSPropertyUpdateValue.html:
* Parser/css-parser-yui.html:
* Parser/simple-url.html:
* Parser/tiny-innerHTML.html:
* Parser/url-parser.html:
* Parser/xml-parser.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove redundant pixel snapping in calculateCompositedBounds()
simon.fraser@apple.com [Mon, 14 May 2012 21:12:38 +0000 (21:12 +0000)]
Remove redundant pixel snapping in calculateCompositedBounds()
https://bugs.webkit.org/show_bug.cgi?id=86400

Reviewed by Sam Weinig.

RenderLayer::calculateLayerBounds() returns a pixel-snapped rect,
so we don't need to pixel-snap it again.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::calculateCompositedBounds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Layout Test svg/carto.net/window.svg is failing
schenney@chromium.org [Mon, 14 May 2012 21:10:02 +0000 (21:10 +0000)]
[chromium] Layout Test svg/carto.net/window.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=84810

Unreviewed Chromium test expectations update.

* platform/chromium-linux/svg/carto.net/window-expected.png:
* platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
* platform/chromium-mac/svg/carto.net/window-expected.png:
* platform/chromium-win/svg/carto.net/window-expected.png:
* platform/chromium-win/svg/carto.net/window-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/efl/svg/carto.net/window-expected.txt: Removed.
* platform/gtk/svg/carto.net/window-expected.txt: Removed.
* svg/carto.net/window-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] android/WebInputEventFactory should handle wheel events and gesture events
abarth@webkit.org [Mon, 14 May 2012 21:04:10 +0000 (21:04 +0000)]
[Chromium] android/WebInputEventFactory should handle wheel events and gesture events
https://bugs.webkit.org/show_bug.cgi?id=86270

Reviewed by Eric Seidel.

* public/android/WebInputEventFactory.h:
* src/android/WebInputEventFactory.cpp:
(WebKit::WebInputEventFactory::keyboardEvent):
(WebKit::WebInputEventFactory::mouseEvent):
(WebKit):
(WebKit::WebInputEventFactory::mouseWheelEvent):
(WebKit::WebInputEventFactory::gestureEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAvoid logging related to setting shadow-related properties on a transform-only layer
simon.fraser@apple.com [Mon, 14 May 2012 20:58:39 +0000 (20:58 +0000)]
Avoid logging related to setting shadow-related properties on a transform-only layer
https://bugs.webkit.org/show_bug.cgi?id=86398

Reviewed by Dan Bernstein.

When making a CATransformLayer to support transform-style: preserve-3d, avoid trying
to set filters on the transform layer. We should never have this combination,
because filters force flattening to occur.

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::ensureStructuralLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r116983.
commit-queue@webkit.org [Mon, 14 May 2012 20:52:05 +0000 (20:52 +0000)]
Unreviewed, rolling out r116983.
http://trac.webkit.org/changeset/116983
https://bugs.webkit.org/show_bug.cgi?id=86397

Does not compile on chromium-win (Requested by abarth on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-14

Source/WebCore:

* WebCore.gypi:
* page/TouchAdjustment.cpp:

Source/WebKit/chromium:

* features.gypi:
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

LayoutTests:

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe "plug-in was blocked" callback needs to include enough info to uniquely identify...
andersca@apple.com [Mon, 14 May 2012 20:49:54 +0000 (20:49 +0000)]
The "plug-in was blocked" callback needs to include enough info to uniquely identify the plug-in + version
https://bugs.webkit.org/show_bug.cgi?id=86395
<rdar://problem/11447652>

Reviewed by John Sullivan.

Add the plug-in identifier and version string to the didFail client callback.

* UIProcess/API/C/WKPage.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFailToInitializePlugin):
Pass a null plug-in identifier and version here since we don't have the plug-in information here.

(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
* UIProcess/WebLoaderClient.h:
(WebLoaderClient):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SVG] Nothing should be stroked when the stroke-width is 0
schenney@chromium.org [Mon, 14 May 2012 20:48:43 +0000 (20:48 +0000)]
[SVG] Nothing should be stroked when the stroke-width is 0
https://bugs.webkit.org/show_bug.cgi?id=83568

Unreviewed Chromium test expectations update.

* platform/chromium-linux/svg/custom/path-zero-strokewidth-expected.png:
* platform/chromium-mac/svg/custom/js-update-style-expected.png:
* platform/chromium-mac/svg/custom/path-zero-strokewidth-expected.png: Modified property svn:mime-type.
* platform/chromium-win/svg/custom/js-update-style-expected.png:
* platform/chromium-win/svg/custom/path-zero-strokewidth-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Added more detail to marked test failure for chromium.
jianli@chromium.org [Mon, 14 May 2012 20:39:46 +0000 (20:39 +0000)]
Unreviewed. Added more detail to marked test failure for chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix typo in expectations file causing lint to fail.
dpranke@chromium.org [Mon, 14 May 2012 20:20:49 +0000 (20:20 +0000)]
Fix typo in expectations file causing lint to fail.

Unreviewed, build fix.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a line layout performance test
mitz@apple.com [Mon, 14 May 2012 20:16:32 +0000 (20:16 +0000)]
Add a line layout performance test
https://bugs.webkit.org/show_bug.cgi?id=86216

Reviewed by Ryosuke Niwa.

* Layout/line-layout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agogarden-o-matic should specify which types of baselines to rebaseline
dpranke@chromium.org [Mon, 14 May 2012 20:11:23 +0000 (20:11 +0000)]
garden-o-matic should specify which types of baselines to rebaseline
https://bugs.webkit.org/show_bug.cgi?id=86242

Reviewed by Adam Barth.

This change modifies garden-o-matic so that we are explicit
about whether to rebaseline the text file, the image file, or
both. This should prevent us from pulling incorrect or
unexpected baselines off the bots.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
(.):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(AbstractRebaseliningCommand.__init__):
(RebaselineTest):
(RebaselineTest._rebaseline_test_and_update_expectations):
(RebaselineTest.execute):
(OptimizeBaselines):
(OptimizeBaselines._optimize_baseline):
(OptimizeBaselines.execute):
(AnalyzeBaselines):
(AnalyzeBaselines._analyze_baseline):
(AnalyzeBaselines.execute):
(RebaselineExpectations._rebaseline_port):
* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.rebaseline):
(GardeningHTTPRequestHandler.optimizebaselines):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline):
(GardeningServerTest.test_rebaseline_new_port):
(GardeningServerTest.test_optimizebaselines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] ASSERT failure in FrameView::paintContents when refleshing www.thestar...
commit-queue@webkit.org [Mon, 14 May 2012 20:09:41 +0000 (20:09 +0000)]
[BlackBerry] ASSERT failure in FrameView::paintContents when refleshing thestar.com/iphone
https://bugs.webkit.org/show_bug.cgi?id=86391

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-05-14
Reviewed by Adam Treat.

PR 156992
Request layout first if needed before painting contents.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPagination splits lines that could fit on a single page if it were not for their...
mitz@apple.com [Mon, 14 May 2012 20:04:37 +0000 (20:04 +0000)]
Pagination splits lines that could fit on a single page if it were not for their top leading
https://bugs.webkit.org/show_bug.cgi?id=86388

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/split-in-top-margin.html

When a line’s visible content fits on a page, but adding the top leading makes it taller than
a page, instead of giving up and splitting the line in an arbitrary position, add a strut
to push it downwards so that the split occurs in the top leading, and the visible content is
fully contained on a single page.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustLinePositionForPagination):

LayoutTests:

* fast/multicol/split-in-top-margin-expected.html: Added.
* fast/multicol/split-in-top-margin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed - remove a Chromium test expectation. Regressed (with others) by r115582,
jsbell@chromium.org [Mon, 14 May 2012 19:52:16 +0000 (19:52 +0000)]
Unreviewed - remove a Chromium test expectation. Regressed (with others) by r115582,
the specific test (storage/indexeddb/noblobs.html) was fixed in r116337.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't append log lines while perf tests are running.
tony@chromium.org [Mon, 14 May 2012 19:28:47 +0000 (19:28 +0000)]
Don't append log lines while perf tests are running.
https://bugs.webkit.org/show_bug.cgi?id=86028

Reviewed by Ryosuke Niwa.

In some tests, the extra DOM nodes can cause the test timing to change.
Avoid adding DOM nodes until the test is over. When running in a browser,
we append nodes as we run so the user can have some feedback.

* resources/runner.js:
(PerfTestRunner.log): Store the log lines in an array until the test is finished.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Compute the best target node on a GestureTap event
commit-queue@webkit.org [Mon, 14 May 2012 19:24:16 +0000 (19:24 +0000)]
[chromium] Compute the best target node on a GestureTap event
https://bugs.webkit.org/show_bug.cgi?id=85101

Patch by Terry Anderson <tdanderson@chromium.org> on 2012-05-14
Reviewed by Adam Barth.

Source/WebCore:

Using tests in the touchadjustment/ directory.

* WebCore.gypi:
Include TouchAdjustment.* files.
* page/TouchAdjustment.cpp:
Included math.h because of an 'Undeclared identifier: INFINITY' when
this patch was landed before.

Source/WebKit/chromium:

* features.gypi:
Enable the touch adjustment code by default.
* src/WebInputEventConversion.cpp:
(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
In the case of a GestureTap, deltaX represents the horizontal padding of the touch
area and deltaY represents the vertical padding of the touch area.

LayoutTests:

* platform/chromium/test_expectations.txt:
The flaky tests in touchadjustment/ have been addressed in WK86218.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Fix WebCore library path
commit-queue@webkit.org [Mon, 14 May 2012 19:14:03 +0000 (19:14 +0000)]
[EFL][DRT] Fix WebCore library path
https://bugs.webkit.org/show_bug.cgi?id=86355

Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-14
Reviewed by Dirk Pranke.

Currently EFL DRT uses wrong WebCore library path when running DRT.
This patch simply adjusted it.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort._path_to_webcore_library):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Mark one test as failed on chromium.
jianli@chromium.org [Mon, 14 May 2012 19:12:24 +0000 (19:12 +0000)]
Unreviewed. Mark one test as failed on chromium.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116980 268f45cc-cd09-0410-ab3c-d52691b4dbfc