WebKit-https.git
3 years agoWeb Inspector: add filter for draw actions in Recordings
webkit@devinrousso.com [Fri, 25 Aug 2017 00:57:42 +0000 (00:57 +0000)]
Web Inspector: add filter for draw actions in Recordings
https://bugs.webkit.org/show_bug.cgi?id=175448
<rdar://problem/34040764>

Reviewed by Matt Baker.

* Localizations/en.lproj/localizedStrings.js:

* UserInterface/Views/RecordingNavigationSidebarPanel.js:
(WI.RecordingNavigationSidebarPanel.prototype.initialLayout):
(WI.RecordingNavigationSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
Add button to filter visual actions.
Drive-by fix: ensure that frame folders are still visible when filtering.

* UserInterface/Images/Paint.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/PaintFlashing.svg.
* UserInterface/Images/gtk/Paint.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/gtk/PaintFlashing.svg.
* UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView):
Rename PaintFlashing.svg to Paint.svg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling out r221139.
ryanhaddad@apple.com [Fri, 25 Aug 2017 00:39:40 +0000 (00:39 +0000)]
Unreviewed, rolling out r221139.

This change did not resolve the LayoutTest assertion failure.

Reverted changeset:

"REGRESSION (r220052): ASSERTION FAILED:
!frame().isMainFrame() || !needsStyleRecalcOrLayout()  in
WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive()"
https://bugs.webkit.org/show_bug.cgi?id=175270
http://trac.webkit.org/changeset/221139

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd WKUIDelegatePrivate equivalent of WKPageUIClient's handleAutoplayEvent
achristensen@apple.com [Fri, 25 Aug 2017 00:28:56 +0000 (00:28 +0000)]
Add WKUIDelegatePrivate equivalent of WKPageUIClient's handleAutoplayEvent
https://bugs.webkit.org/show_bug.cgi?id=175965
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

Covered by updating API tests to use UIDelegate instead of _pageForTesting and WKPageUIClient.

* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::toWKFocusDirection):
(WebKit::toWKAutoplayEventFlags):
(WebKit::toWKAutoplayEvent):
(WebKit::UIDelegate::UIClient::handleAutoplayEvent):

Tools:

* TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
(TEST):
* TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
(-[AutoplayPoliciesDelegate _webView:handleAutoplayEvent:withFlags:]):
(TEST):
(handleAutoplayEvent): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agodidNotHandleWheelEvent test times out
achristensen@apple.com [Fri, 25 Aug 2017 00:05:56 +0000 (00:05 +0000)]
didNotHandleWheelEvent test times out
https://bugs.webkit.org/show_bug.cgi?id=175967

* TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
Skip the test until WebCore's wheel event handling is reliable enough to test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWPT harness errors on leaks and iOS-sim EWS bots
commit-queue@webkit.org [Thu, 24 Aug 2017 23:52:14 +0000 (23:52 +0000)]
WPT harness errors on leaks and iOS-sim EWS bots
https://bugs.webkit.org/show_bug.cgi?id=175269
<rdar://problem/33902404>

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-24

* TestExpectations: Skipping a test that uses a python script run by WPT that makes a lot of noise in the log.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed.
jonlee@apple.com [Thu, 24 Aug 2017 23:43:45 +0000 (23:43 +0000)]
Unreviewed.

* Modules/mediastream/MediaStreamTrack.idl: Remove extraneous and confusing comment in IDL.
The 'new' enum was removed via r215198, so we can remove this specific FIXME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUpdate configure-xcode-for-ios-development for iOS 11
jbedard@apple.com [Thu, 24 Aug 2017 23:18:15 +0000 (23:18 +0000)]
Update configure-xcode-for-ios-development for iOS 11
https://bugs.webkit.org/show_bug.cgi?id=173937
<rdar://problem/33038924>

Reviewed by Daniel Bates.

Xcode 9 has removed the following headers from the iOS 11 Simulator SDK:
        /usr/include/crt_externs.h
        /usr/include/mach/mach_types.defs
        /usr/include/mach/machine/machine_types.defs
        /usr/include/mach/std_types.defs
        /usr/include/objc/objc-class.h
        /usr/include/objc/objc-runtime.h
        /usr/include/objc/Protocol.h
        /usr/include/readline/history.h
        /usr/include/readline/readline.h
To solve this problem, configure-xcode-for-ios-development copies these headers
from the active macOS SDK into the iOS Simulator SDK.

* Scripts/configure-xcode-for-ios-development:
(copyMissingHeadersFromSDKToSDKIfNeeded): Copy all missing header from one SDK
into another if those headers do not exist in the destination SDK.
(copyMissingHeadersToIPhoneOSSDKIfNeeded): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoEnable moving fixed character class terms after fixed character terms for BMP only...
msaboff@apple.com [Thu, 24 Aug 2017 23:03:27 +0000 (23:03 +0000)]
Enable moving fixed character class terms after fixed character terms for BMP only character classes
https://bugs.webkit.org/show_bug.cgi?id=175958

Reviewed by Saam Barati.

Currently we don't perform the reordering optimiaztion of fixed character terms that
follow fixed character class terms for Unicode patterns.

This change allows that reordering when the character class contains only BMP
characters.

This fix is covered by existing tests.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::optimizeAlternative):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Create experimental Layers tab
commit-queue@webkit.org [Thu, 24 Aug 2017 22:43:08 +0000 (22:43 +0000)]
Web Inspector: Create experimental Layers tab
https://bugs.webkit.org/show_bug.cgi?id=175728

Patch by Ross Kirsling <ross.kirsling@sony.com> on 2017-08-24
Reviewed by Devin Rousso.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Main.js:
* UserInterface/Base/Setting.js:
* UserInterface/Images/Layers.svg: Added.
* UserInterface/Main.html:
* UserInterface/Views/Layers3DContentView.js: Added.
* UserInterface/Views/LayersTabContentView.js: Added.
* UserInterface/Views/SettingsTabContentView.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove duplicate WebCore::URL encoder/decoder
beidson@apple.com [Thu, 24 Aug 2017 22:37:15 +0000 (22:37 +0000)]
Remove duplicate WebCore::URL encoder/decoder
https://bugs.webkit.org/show_bug.cgi?id=175952

Reviewed by Chris Dumez.

Don't need the WebCoreArgumentCoder in WebKit since the URL class defines its own coders.

* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<URL>::encode): Deleted.
(IPC::ArgumentCoder<URL>::decode): Deleted.
* Shared/WebCoreArgumentCoders.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd WKUIDelegatePrivate callback corresponding to PageUIClient's didNotHandleWheelEvent
achristensen@apple.com [Thu, 24 Aug 2017 22:10:57 +0000 (22:10 +0000)]
Add WKUIDelegatePrivate callback corresponding to PageUIClient's didNotHandleWheelEvent
https://bugs.webkit.org/show_bug.cgi?id=175957
<rdar://problem/29270035>

Reviewed by Geoffrey Garen.

Source/WebKit:

* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didNotHandleWheelEvent):

Tools:

* TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
(synthesizeWheelEvents):
(-[WheelDelegate _webView:didNotHandleWheelEvent:]):
(-[WheelDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMarked quicklook/multi-sheet-numbers-09.html as flaky.
jlewis3@apple.com [Thu, 24 Aug 2017 21:53:12 +0000 (21:53 +0000)]
Marked quicklook/multi-sheet-numbers-09.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175865

Unreviewed test gardening.
* platform/ios-simulator-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoStop using PolicyCallback for new window policies
commit-queue@webkit.org [Thu, 24 Aug 2017 21:45:38 +0000 (21:45 +0000)]
Stop using PolicyCallback for new window policies
https://bugs.webkit.org/show_bug.cgi?id=175907

Patch by Alex Christensen <achristensen@webkit.org> on 2017-08-24
Reviewed by Andy Estes.

PolicyCallback is an artifact from the days before C++11.  Let's use lambdas instead!
No change in behaviour.

* loader/PolicyCallback.cpp:
(WebCore::PolicyCallback::set):
(WebCore::PolicyCallback::call):
(WebCore::PolicyCallback::cancel):
* loader/PolicyCallback.h:
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):
(WebCore::PolicyChecker::continueAfterNewWindowPolicy): Deleted.
* loader/PolicyChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoOverflow scroll views are inset to avoid safe areas even if the parent view is not
timothy_horton@apple.com [Thu, 24 Aug 2017 21:41:50 +0000 (21:41 +0000)]
Overflow scroll views are inset to avoid safe areas even if the parent view is not
https://bugs.webkit.org/show_bug.cgi?id=175949
<rdar://problem/34063057>

Reviewed by Beth Dakin.

* UIProcess/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
Disable automatic content inset adjustment to avoid safe areas on
all of WKWebView's child UIScrollViews.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd support for RegExp "dotAll" flag
msaboff@apple.com [Thu, 24 Aug 2017 21:14:43 +0000 (21:14 +0000)]
Add support for RegExp "dotAll" flag
https://bugs.webkit.org/show_bug.cgi?id=175924

Reviewed by Keith Miller.

JSTests:

Updated tests for new dotAll ('s' flag) changes.

* es6/Proxy_internal_get_calls_RegExp.prototype.flags.js:
* stress/static-getter-in-names.js:

Source/JavaScriptCore:

The dotAll RegExp flag, 's', changes . to match any character including line terminators.
Added a the "dotAll" identifier as well as RegExp.prototype.dotAll getter.
Added a new any character CharacterClass that is used to match . terms in a dotAll flags
RegExp.  In the YARR pattern and parsing code, changed the NewlineClassID, which was only
used for '.' processing, to DotClassID.  The selection of which builtin character class
that DotClassID resolves to when generating the pattern is conditional on the dotAll flag.
This NewlineClassID to DotClassID refactoring includes the atomBuiltInCharacterClass() in
the WebCore content extensions code in the PatternParser class.

As an optimization, the Yarr JIT actually doesn't perform match checks against the builtin
any character CharacterClass, it merely reads the character.  There is another optimization
in our DotStart enclosure processing where a non-capturing regular expression in the form
of .*<expression.*, with options beginning ^ and/or trailing $, match the contained
expression and then look for the extents of the surrounding .*'s.  When used with the
dotAll flag, that processing alwys results with the beinning of the string and the end
of the string.  Therefore we short circuit the finding the beginning and end of the line
or string with dotAll patterns.

* bytecode/BytecodeDumper.cpp:
(JSC::regexpToSourceString):
* runtime/CommonIdentifiers.h:
* runtime/RegExp.cpp:
(JSC::regExpFlags):
(JSC::RegExpFunctionalTestCollector::outputOneTest):
* runtime/RegExp.h:
* runtime/RegExpKey.h:
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::finishCreation):
(JSC::flagsString):
(JSC::regExpProtoGetterDotAll):
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::matchDotStarEnclosure):
* yarr/YarrInterpreter.h:
(JSC::Yarr::BytecodePattern::dotAll const):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::optimizeAlternative):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generateDotStarEnclosure):
* yarr/YarrParser.h:
(JSC::Yarr::Parser::parseTokens):
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::atomBuiltInCharacterClass):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassBuiltIn):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):
(JSC::Yarr::YarrPattern::YarrPattern):
(JSC::Yarr::PatternTerm::dump):
(JSC::Yarr::anycharCreate):
* yarr/YarrPattern.h:
(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::anyCharacterClass):
(JSC::Yarr::YarrPattern::dotAll const):

Source/WebCore:

Changed due to refactoring NewlineClassID to DotClassID.

No new tests. No change in behavior.

* contentextensions/URLFilterParser.cpp:
(WebCore::ContentExtensions::PatternParser::atomBuiltInCharacterClass):

LayoutTests:

* js/regexp-dotall-expected.txt: Added.
* js/regexp-dotall.html: Added.
* js/script-tests/Object-getOwnPropertyNames.js:
* js/script-tests/regexp-dotall.js: Added.
New tests.

* js/Object-getOwnPropertyNames-expected.txt:
Updated tests for new dotAll ('s' flag) changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, revert part of r221152 to fix internal builds.
ryanhaddad@apple.com [Thu, 24 Aug 2017 21:03:05 +0000 (21:03 +0000)]
Unreviewed, revert part of r221152 to fix internal builds.

* crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Table grid shouldn't show behind empty state
webkit@devinrousso.com [Thu, 24 Aug 2017 20:18:15 +0000 (20:18 +0000)]
Web Inspector: Table grid shouldn't show behind empty state
https://bugs.webkit.org/show_bug.cgi?id=175943

Reviewed by Brian Burg.

* UserInterface/Views/RecordingNavigationSidebarPanel.css:
(.sidebar > .panel.navigation.recording > .content > .tree-outline):
(.sidebar > .panel.navigation.recording > .content > .tree-outline:not(:empty)):
Only apply the background when the TreeOutline has children.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoHTMLTrackElement behavior violates the standard
commit-queue@webkit.org [Thu, 24 Aug 2017 19:44:20 +0000 (19:44 +0000)]
HTMLTrackElement behavior violates the standard
https://bugs.webkit.org/show_bug.cgi?id=175888

Patch by Kirill Ovchinnikov <kirill.ovchinn@gmail.com> on 2017-08-24
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/text-track-src-change.html: added asserts

* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::parseAttribute):
(WebCore::HTMLTrackElement::loadTimerFired):
* html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::scheduleLoad):
* html/track/TextTrack.cpp:
(WebCore::TextTrack::removeAllCues):
* html/track/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::removeAll):
* html/track/TextTrackCueList.h:

LayoutTests:

* media/track/text-track-src-change-expected.txt:
* media/track/text-track-src-change.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoLayout size override changes during in-flight animated resize are dropped on the...
timothy_horton@apple.com [Thu, 24 Aug 2017 18:57:36 +0000 (18:57 +0000)]
Layout size override changes during in-flight animated resize are dropped on the floor forever
https://bugs.webkit.org/show_bug.cgi?id=175916
<rdar://problem/33887295>

Reviewed by Beth Dakin.

Source/WebKit:

Layout size override changes that come in during an animated resize
are currently stored, but not sent in a separate message, because
they're sent as part of the resize. However, if a layout size override
change happens after the animated resize message was already sent, but
before the animated resize is ended, that change will be stored, but
not sent in the animated resize message (because it's too late), and
then subsequent calls with the same size will early-return, because
we're testing against the stored size, not the size we last actually
sent to the Web Content process.

Instead, store the last-sent size, so that subsequent layout size override
changes with the same size won't bail, and if it differs from the active
state after the animated resize completes, send an out-of-band update.

All of the above also applies to device orientation, which follows
exactly the same pattern.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _dispatchSetMinimumLayoutSize:]):
(-[WKWebView _dispatchSetMaximumUnobscuredSize:]):
(-[WKWebView _dispatchSetDeviceOrientation:]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _windowDidRotate:]):
(-[WKWebView _didRelaunchProcess]):
(-[WKWebView _setMinimumLayoutSizeOverride:]):
(-[WKWebView _setInterfaceOrientationOverride:]):
(-[WKWebView _setMaximumUnobscuredSizeOverride:]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):

Tools:

* TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
(TEST):
Add a test ensuring that override layout size changes
during an animated resize actually take effect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix -Wcast-qual and -Wunused-lambda-capture warnings in WebCore with new clang compiler
ddkilzer@apple.com [Thu, 24 Aug 2017 18:35:39 +0000 (18:35 +0000)]
Fix -Wcast-qual and -Wunused-lambda-capture warnings in WebCore with new clang compiler
<https://webkit.org/b/175910>
<rdar://problem/33667497>

Reviewed by Alex Christensen.

Fix -Wunused-lambda-capture warnings:

* Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::setBodyData): Remove unused lambda
capture of 'this'.
* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::createRenderer): Add
UNUSED_PARAM(style) when ENABLE(CSS_REGIONS) is turned off.

Fix -Wcast-qual warnings:

* crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::create): Switch from C-style cast to
reinterpret_cast with const keyword.  This better matches the
argument types used in CCRSACryptorCreateFromData().
* platform/audio/mac/FFTFrameMac.cpp:
(WebCore::FFTFrame::doFFT): Switch from C-style cast to
reinterpret_cast with const keyword.  This better matches the
argument type used in vDSP_ctoz().
* platform/graphics/FontPlatformData.h: Only define
WebCore::toCTFont() and WebCore::toNSFont() when building for
Objective-C++.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
Switch from C-style cast to reinterpret_cast with const keyword.
This better matches the argument type used in
Uint8Array::setRange().
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::CMTimebaseEffectiveRateChangedCallback): Use
const_cast to avoid warning.
* platform/mac/SSLKeyGeneratorMac.mm:
(WebCore::signedPublicKeyAndChallengeString): Use const_cast to
avoid warning, and switch C-style cast to reinterpret_cast.
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::XSLTProcessor::transformToString):
- Use const_cast to avoid warning, and switch C-style cast to
  reinterpret_cast.
- Switch C-style cast to reinterpret_cast and add const keyword.
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLParserContext::createMemoryParser): Use const_cast
to avoid warning, and switch C-style cast to reinterpret_cast.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoDisabled VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling.
jlewis3@apple.com [Thu, 24 Aug 2017 18:27:54 +0000 (18:27 +0000)]
Disabled VideoControlsManagerMultipleVideosSwitchControlledVideoWhenScrolling.
https://bugs.webkit.org/show_bug.cgi?id=175909

Unreviewed test gardening.

* TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMove imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type...
jbedard@apple.com [Thu, 24 Aug 2017 18:18:56 +0000 (18:18 +0000)]
Move imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm expectation.
<rdar://problem/32826391>

Unreviewed test gardening.

* platform/ios-simulator-wk2/TestExpectations:
* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago_WKThumbnailView snapshots have to be copied by CA on first commit due to bad row...
timothy_horton@apple.com [Thu, 24 Aug 2017 18:11:16 +0000 (18:11 +0000)]
_WKThumbnailView snapshots have to be copied by CA on first commit due to bad row alignment
https://bugs.webkit.org/show_bug.cgi?id=175898
<rdar://problem/34029673>

Reviewed by Sam Weinig.

In order to avoid copying, CGImages used as layer contents need to have certain
alignment requirements fulfilled. Align the row stride to the desired value.

* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
(WebKit::ShareableBitmap::numBytesForSize):
(WebKit::ShareableBitmap::calculateBytesPerPixel): Deleted.
* Shared/ShareableBitmap.h:
(WebKit::ShareableBitmap::sizeInBytes const):
(WebKit::ShareableBitmap::numBytesForSize): Deleted.
Merge the interfaces of numBytesPerSize and sizeInBytes between the platforms.
numBytesForSize now makes use of the new calculateBytesPerRow, which is
implemented by each platform ShareableBitmap implementation to do the
requisite alignment for that platform.

* Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::calculateBytesPerRow):
(WebKit::ShareableBitmap::calculateBytesPerPixel):
(WebKit::createSurfaceFromData):
(WebKit::ShareableBitmap::numBytesForSize): Deleted.
Implement calculateBytesPerRow (which used to be hidden inside of numBytesForSize)
and get rid of the now-duplicative numBytesForSize.

* Shared/cg/ShareableBitmapCG.cpp:
(WebKit::ShareableBitmap::calculateBytesPerRow):
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::createCGImage const):
Implement calculateBytesPerRow and make use of it when providing a row stride
to CoreGraphics.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoReduce Gigacage sizes
fpizlo@apple.com [Thu, 24 Aug 2017 18:00:09 +0000 (18:00 +0000)]
Reduce Gigacage sizes
https://bugs.webkit.org/show_bug.cgi?id=175920

Reviewed by Mark Lam.

Source/bmalloc:

This introduces the ability to have different gigacage sizes for different gigacages, and uses it to reduce the size of both
gigacages, but to different extents: Primitive gets 32GB with a 16GB runway and JSValue gets 16GB.

This is a ~10% membuster progression on my Mac Pro.

* bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
* bmalloc/Gigacage.h:
(Gigacage::size):
(Gigacage::alignment):
(Gigacage::mask):
(Gigacage::runway):
(Gigacage::totalSize):
(Gigacage::caged):
* bmalloc/Heap.cpp:
(bmalloc::Heap::Heap):
(bmalloc::Heap::gigacageSize):
* bmalloc/Heap.h:

Source/JavaScriptCore:

Teach all of the code generators to use the right gigacage masks.

Also teach Wasm that it has much less memory for signaling memories. With 32GB, we have room for 7 signaling memories. But if
we actually did that, then we'd have no memory left for anything else. So, this caps us at 4 signaling memories.

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::caged):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::cage):
(JSC::AssemblyHelpers::cageConditionally):
* llint/LowLevelInterpreter64.asm:
* runtime/Options.h:

Source/WTF:

Provide filler API for the no-bmalloc/no-Gigacage case.

* wtf/Gigacage.h:
(Gigacage::mask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Repaint Outside Layout] Add a pref for repainting outside of layout
hyatt@apple.com [Thu, 24 Aug 2017 17:53:33 +0000 (17:53 +0000)]
[Repaint Outside Layout] Add a pref for repainting outside of layout
https://bugs.webkit.org/show_bug.cgi?id=175729

Reviewed by Daniel Bates.

* page/Settings.in:
* rendering/RenderElement.cpp:
(WebCore::RenderElement::checkForRepaintDuringLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoLand regression test for https://bugs.webkit.org/show_bug.cgi?id=164081.
mark.lam@apple.com [Thu, 24 Aug 2017 17:42:45 +0000 (17:42 +0000)]
Land regression test for https://bugs.webkit.org/show_bug.cgi?id=164081.
https://bugs.webkit.org/show_bug.cgi?id=175940
<rdar://problem/29003921>

Reviewed by Saam Barati.

* stress/regress-164081.js: Added.
(shouldEqual):
(testcase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMove imported/w3c/web-platform-tests/IndexedDB/large-nested-cloning.html expectations.
jbedard@apple.com [Thu, 24 Aug 2017 17:05:38 +0000 (17:05 +0000)]
Move imported/w3c/web-platform-tests/IndexedDB/large-nested-cloning.html expectations.
https://bugs.webkit.org/show_bug.cgi?id=173487

Unreviewed test gardening.

imported/w3c/web-platform-tests/IndexedDB/large-nested-cloning.html is flakey on both
iOS Simulator and iOS Device.

* platform/ios-simulator-wk2/TestExpectations:
* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoDFG::JITCode::osrEntry should get sorted since we perform a binary search on it
sbarati@apple.com [Thu, 24 Aug 2017 16:59:00 +0000 (16:59 +0000)]
DFG::JITCode::osrEntry should get sorted since we perform a binary search on it
https://bugs.webkit.org/show_bug.cgi?id=175893

Reviewed by Mark Lam.

* dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::finalizeOSREntrypoints):
* dfg/DFGJITCode.h:
(JSC::DFG::JITCode::finalizeCatchOSREntrypoints): Deleted.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::linkOSREntries):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMove http/tests/preload/viewport/meta-viewport-link-headers.php back to iOS.
jbedard@apple.com [Thu, 24 Aug 2017 16:53:31 +0000 (16:53 +0000)]
Move http/tests/preload/viewport/meta-viewport-link-headers.php back to iOS.
https://bugs.webkit.org/show_bug.cgi?id=172518

Unreviewed test gardening.

This test is flakey on both iOS device and iOS simulator. http/tests/preload/viewport
should be marked as passing for iOS, but we should not re-mark it for iOS Simulator.

* platform/ios-simulator/TestExpectations:
* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWPT harness errors on leaks and iOS-sim EWS bots
commit-queue@webkit.org [Thu, 24 Aug 2017 16:49:36 +0000 (16:49 +0000)]
WPT harness errors on leaks and iOS-sim EWS bots
https://bugs.webkit.org/show_bug.cgi?id=175269
<rdar://problem/33902404>

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-24
Reviewed by Alexey Proskuryakov.

Adding more logging to check whether the server is hanging or TCP connection is timing out.

* web-platform-tests/tools/wptserve/wptserve/response.py:
(Response.write_content):
(ResponseWriter.write):
(ResponseWriter.write_content_file):
* web-platform-tests/tools/wptserve/wptserve/server.py:
(WebTestRequestHandler.handle_one_request):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSkip editing/execCommand/forward-delete-read-write-canvas.html.
ryanhaddad@apple.com [Thu, 24 Aug 2017 16:42:50 +0000 (16:42 +0000)]
Skip editing/execCommand/forward-delete-read-write-canvas.html.
https://bugs.webkit.org/show_bug.cgi?id=175939

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoREGRESSION (r220052): ASSERTION FAILED: !frame().isMainFrame() || !needsStyleRecalcOr...
darin@apple.com [Thu, 24 Aug 2017 16:37:53 +0000 (16:37 +0000)]
REGRESSION (r220052): ASSERTION FAILED: !frame().isMainFrame() || !needsStyleRecalcOrLayout()  in WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive()
https://bugs.webkit.org/show_bug.cgi?id=175270

Reviewed by Simon Fraser.

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::Document): Initialize m_styleRecalcTimer with a lamdba so it can work
with a function that returns a bool and ignore the return value.
(WebCore::Document::updateStyleIfNeeded): Added a boolean return value indicating if the
function did any work or not.
* dom/Document.h: Updated for above change.

* page/FrameView.cpp:
(WebCore::appendRenderedChildren): Added helper that will later replace the
FrameView::renderedChildFrameViews function and is used below.
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive): Instead of always doing two
passes of style and layout update do up to four passes, but stop as soon as a pass does
no work. This is slightly more efficient in cases where no layout and style update is
needed, and works correctly when a third pass is needed, which is what happens in the
test that was failing. We can eventually improve this further, but this resolves the
immediate problem we are seeing in the test.

LayoutTests:

* platform/mac-wk2/TestExpectations: Re-enable the disabled test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[iOS] ViewServices started by StoreKitUIService may get suspended unexpectedly
cdumez@apple.com [Thu, 24 Aug 2017 15:59:24 +0000 (15:59 +0000)]
[iOS] ViewServices started by StoreKitUIService may get suspended unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=175922
<rdar://problem/34028921>

Reviewed by Tim Horton.

ViewServices started by StoreKitUIService may get suspended unexpectedly. This is
because StoreKitUIService is itself a ViewService and is therefore in the background.
To address the issue, treat StoreKitUIService as initially foreground in
ApplicationStateTracker so that its ViewServices do not get suspended. We don't
have good way to deal with ViewServices started by other ViewServices unfortunately.

* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ApplicationStateTracker.mm:
(WebKit::ApplicationStateTracker::ApplicationStateTracker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSkip flaky JSC test stress/test-finally.js.
ryanhaddad@apple.com [Thu, 24 Aug 2017 15:45:20 +0000 (15:45 +0000)]
Skip flaky JSC test stress/test-finally.js.
https://bugs.webkit.org/show_bug.cgi?id=160283

Unreviewed test gardening.

* stress/test-finally.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoBump trunk version to be 2.19.1
tpopela@redhat.com [Thu, 24 Aug 2017 15:35:58 +0000 (15:35 +0000)]
Bump trunk version to be 2.19.1

Rubber-stamped by Michael Catanzaro.

* Source/cmake/OptionsGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[CMake] Use find_package for SQLite
don.olmstead@sony.com [Thu, 24 Aug 2017 14:36:31 +0000 (14:36 +0000)]
[CMake] Use find_package for SQLite
https://bugs.webkit.org/show_bug.cgi?id=175803

Reviewed by Konstantin Tokarev.

.:

* Source/cmake/OptionsAppleWin.cmake:
* Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

No new tests. No change in behavior.

* CMakeLists.txt:
* PlatformGTK.cmake:
* PlatformMac.cmake:
* PlatformWPE.cmake:
* PlatformWinCairo.cmake:

Source/WebKitLegacy:

* PlatformWin.cmake:

Tools:

* TestWebKitAPI/PlatformWin.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemove some duplicated media track tests.
commit-queue@webkit.org [Thu, 24 Aug 2017 14:12:39 +0000 (14:12 +0000)]
Remove some duplicated media track tests.
https://bugs.webkit.org/show_bug.cgi?id=175929

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-24
Reviewed by Sam Weinig.

All these tests have been submitted to web-platform-tests and are maintained
there. A copy of them exists in
imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/.
Most of the retained tests also exist in web-platform-tests, but in the
webvtt/ top-level directory, which is currently not imported.

* media/track/opera/interfaces/TextTrack/activeCues.html: Removed.
* media/track/opera/interfaces/TextTrackCue/onenter.html: Removed.
* media/track/opera/interfaces/TextTrackCue/onexit.html: Removed.
* media/track/opera/interfaces/TextTrackCueList/getter.html: Removed.
* media/track/opera/interfaces/TextTrackList/getter.html: Removed.
* media/track/opera/interfaces/TrackEvent/constructor.html: Removed.
* media/track/opera/interfaces/TrackEvent/createEvent.html: Removed.
* media/track/opera/track/track-element/src-clear-cues.html: Removed.
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed GTK+ gardening. Update expectations of several tests failing at r221132.
magomez@igalia.com [Thu, 24 Aug 2017 13:50:30 +0000 (13:50 +0000)]
Unreviewed GTK+ gardening. Update expectations of several tests failing at r221132.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoGeoclue2 based backend should provide the right desktop ID
aperez@igalia.com [Thu, 24 Aug 2017 08:45:07 +0000 (08:45 +0000)]
Geoclue2 based backend should provide the right desktop ID
https://bugs.webkit.org/show_bug.cgi?id=129879

Reviewed by Michael Catanzaro.

* platform/geoclue/GeolocationProviderGeoclue.cpp:
(GeolocationProviderGeoclue::createGeoclueClientProxyCallback): Try first obtaining the application
identifier using GApplication first, keeping a fallback to the value returned by g_get_prgname().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[EME] Implement HTMLMediaElement dispatch of the onencrypted event
zandobersek@gmail.com [Thu, 24 Aug 2017 08:07:38 +0000 (08:07 +0000)]
[EME] Implement HTMLMediaElement dispatch of the onencrypted event
https://bugs.webkit.org/show_bug.cgi?id=175927

Reviewed by Xabier Rodriguez-Calvar.

Add the MediaPlayerClient::mediaPlayerInitializationDataEncountered()
method that the platform-layer media pipeline can invoke when it hits
encrypted content in the media data. The initialization data and its type
are passed by the caller, allowing the HTMLMediaElement override to
process it further.

This is done in the mediaPlayerInitializationDataEncountered() override
in the HTMLMediaElement class. Partially implementing the 'Initialization
Data Encountered' algorithm, the 'encrypted' event is dispatched, with the
MediaEncryptedEvent interface being leveraged to embed init data and init
data type information. CORS and mixed-content validation of the media data
is skipped for now.

MediaPlayer::initializationDataEncountered() method should be used to
dispatch the corresponding method on the client, passing on the given init
data and init data type values.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerInitializationDataEncountered):
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::initializationDataEncountered):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerInitializationDataEncountered):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoBuild fix. Copy the missing statistics.js for Speedometer 2.0.
rniwa@webkit.org [Thu, 24 Aug 2017 06:17:22 +0000 (06:17 +0000)]
Build fix. Copy the missing statistics.js for Speedometer 2.0.

* resources/statistics.js: Copied from PerformanceTests/resources/statistics.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSpeedometer: Add missing stylesheet to Angular example
rniwa@webkit.org [Thu, 24 Aug 2017 06:13:42 +0000 (06:13 +0000)]
Speedometer: Add missing stylesheet to Angular example
​https://bugs.webkit.org/show_bug.cgi?id=175820

Fix r221042. It was supposed to add an empty file but git-svn failed to do so.

* Speedometer/resources/todomvc/architecture-examples/angular/dist/styles.d41d8cd98f00b204e980.bundle.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoDeleteSelectionCommand should be robust when starting and ending editable positions...
wenson_hsieh@apple.com [Thu, 24 Aug 2017 04:12:55 +0000 (04:12 +0000)]
DeleteSelectionCommand should be robust when starting and ending editable positions cannot be found
https://bugs.webkit.org/show_bug.cgi?id=175914
<rdar://problem/29792688>

Reviewed by Ryosuke Niwa.

Source/WebCore:

DeleteSelectionCommand can cause a null dereference if editable start and end positions are not found. This can
happen when attempting to delete after selecting the contents within a canvas or output element with `read-write`
`-webkit-user-modify` style. To fix this, we make the initialization step of the DeleteSelectionCommand robust
when editable start and end positions are missing.

Test: editing/execCommand/forward-delete-read-write-canvas.html

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::initializePositionData):

Make this initialization helper indicate failure via a bool return value. DeleteSelectionCommand::doApply bails
early if initializePositionData returned false.

(WebCore::DeleteSelectionCommand::doApply):
* editing/DeleteSelectionCommand.h:

LayoutTests:

Adds a new LayoutTest. This test passes if WebKit successfully loaded the page.

* editing/execCommand/forward-delete-read-write-canvas-expected.txt: Added.
* editing/execCommand/forward-delete-read-write-canvas.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMerge the latest version of Speedometer 2.0 to browserbench.org against at r221126.
rniwa@webkit.org [Thu, 24 Aug 2017 02:12:48 +0000 (02:12 +0000)]
Merge the latest version of Speedometer 2.0 to browserbench.org against at r221126.

Rubber-stamped by Yusuke Suzuki.

* Speedometer2.0: Replaced with PerformanceTests/Speedometer.
* Speedometer2.0/resources/todomvc/architecture-examples/preact/dist/app.js:
* Speedometer2.0/resources/todomvc/architecture-examples/preact/dist/todomvc.css:
* Speedometer2.0/resources/todomvc/architecture-examples/preact/src/app/footer.js:
* Speedometer2.0/resources/todomvc/architecture-examples/preact/src/app/index.js:
* Speedometer2.0/resources/todomvc/architecture-examples/preact/src/app/item.js:
* Speedometer2.0/resources/todomvc/architecture-examples/preact/src/app/util.js:
(export.uuid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix Titzer bench on iOS.
keith_miller@apple.com [Thu, 24 Aug 2017 02:11:02 +0000 (02:11 +0000)]
Fix Titzer bench on iOS.
https://bugs.webkit.org/show_bug.cgi?id=175917

Reviewed by Ryosuke Niwa.

Currently, Titzer bench doesn't run on iOS since the benchmark
allocates lots of physical pages that it never actually writes
to. We limited the total number wasm physical pages to the ram
size of the phone, which caused us to fail a memory
allocation. This patch changes it so we will allocate up to 3x ram
size, which seems to fix the problem.

* wasm/WasmMemory.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, fix for test262
utatane.tea@gmail.com [Thu, 24 Aug 2017 01:07:43 +0000 (01:07 +0000)]
Unreviewed, fix for test262
https://bugs.webkit.org/show_bug.cgi?id=175915

* runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
* runtime/SetPrototype.cpp:
(JSC::SetPrototype::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, build fix in GTK port
utatane.tea@gmail.com [Thu, 24 Aug 2017 01:05:02 +0000 (01:05 +0000)]
Unreviewed, build fix in GTK port
https://bugs.webkit.org/show_bug.cgi?id=174590

Source/JavaScriptCore:

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCatch):
* bytecompiler/BytecodeGenerator.h:

Source/WTF:

* wtf/SingleRootGraph.h:
(WTF::SingleRootGraph::successors const):
(WTF::SingleRootGraph::predecessors const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Cache API] Unify WebCore and WebKit error handling
commit-queue@webkit.org [Thu, 24 Aug 2017 00:39:23 +0000 (00:39 +0000)]
[Cache API] Unify WebCore and WebKit error handling
https://bugs.webkit.org/show_bug.cgi?id=175902
<rdar://problem/34045933>

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-23

* Modules/cache/DOMCache.h: Fixing Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, rolling out r221109.
ryanhaddad@apple.com [Thu, 24 Aug 2017 00:31:22 +0000 (00:31 +0000)]
Unreviewed, rolling out r221109.

This change caused assertion failures on iOS and macOS debug
bots.

Reverted changeset:

"Stop using PolicyCallback for new window policies"
https://bugs.webkit.org/show_bug.cgi?id=175907
http://trac.webkit.org/changeset/221109

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSpeedometer: Update to modern Preact version
commit-queue@webkit.org [Thu, 24 Aug 2017 00:14:55 +0000 (00:14 +0000)]
Speedometer: Update to modern Preact version
https://bugs.webkit.org/show_bug.cgi?id=175763

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-23
Reviewed by Ryosuke Niwa.

* Speedometer/resources/todomvc/architecture-examples/preact/README.md: Documented build steps.
* Speedometer/resources/todomvc/architecture-examples/preact/dist/*: Renamed from build to dist so it can be checked in, and updated per build steps.
* Speedometer/resources/todomvc/architecture-examples/preact/package-lock.json: Locked dependencies to ensure builds are deterministic.
* Speedometer/resources/todomvc/architecture-examples/preact/package.json: Updated build commands and dependencies.
* Speedometer/resources/todomvc/architecture-examples/preact/rollup.config.js: Updated configuration.
* Speedometer/resources/todomvc/architecture-examples/preact/src/app/footer.js: Updated to modern Preact version.
* Speedometer/resources/todomvc/architecture-examples/preact/src/app/index.js: Updated to modern Preact version.
* Speedometer/resources/todomvc/architecture-examples/preact/src/app/util.js: Updated to modern Preact version.
* Speedometer/resources/todomvc/architecture-examples/preact/src/index.html: Made title consistent.
* Speedometer/resources/todomvc/architecture-examples/preact/webpack.config.babel.js: Updated configuration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMerge the latest version of Speedometer 2.0 to browserbench.org against at r221119.
rniwa@webkit.org [Thu, 24 Aug 2017 00:09:28 +0000 (00:09 +0000)]
Merge the latest version of Speedometer 2.0 to browserbench.org against at r221119.

Rubber-stamped by Joseph Pecoraro.

* Speedometer2.0: Replaced with PerformanceTests/Speedometer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSupport compiling catch in the DFG
sbarati@apple.com [Wed, 23 Aug 2017 23:58:36 +0000 (23:58 +0000)]
Support compiling catch in the DFG
https://bugs.webkit.org/show_bug.cgi?id=174590

Reviewed by Filip Pizlo.

JSTests:

* microbenchmarks/delta-blue-try-catch.js: Added.
(exception):
(value):
(OrderedCollection):
(OrderedCollection.prototype.add):
(OrderedCollection.prototype.at):
(OrderedCollection.prototype.size):
(OrderedCollection.prototype.removeFirst):
(OrderedCollection.prototype.remove):
(Strength):
(Strength.stronger):
(Strength.weaker):
(Strength.weakestOf):
(Strength.strongest):
(Strength.prototype.nextWeaker):
(Constraint):
(Constraint.prototype.addConstraint):
(Constraint.prototype.satisfy):
(Constraint.prototype.destroyConstraint):
(Constraint.prototype.isInput):
(UnaryConstraint):
(UnaryConstraint.prototype.addToGraph):
(UnaryConstraint.prototype.chooseMethod):
(UnaryConstraint.prototype.isSatisfied):
(UnaryConstraint.prototype.markInputs):
(UnaryConstraint.prototype.output):
(UnaryConstraint.prototype.recalculate):
(UnaryConstraint.prototype.markUnsatisfied):
(UnaryConstraint.prototype.inputsKnown):
(UnaryConstraint.prototype.removeFromGraph):
(StayConstraint):
(StayConstraint.prototype.execute):
(EditConstraint.prototype.isInput):
(EditConstraint.prototype.execute):
(BinaryConstraint):
(BinaryConstraint.prototype.chooseMethod):
(BinaryConstraint.prototype.addToGraph):
(BinaryConstraint.prototype.isSatisfied):
(BinaryConstraint.prototype.markInputs):
(BinaryConstraint.prototype.input):
(BinaryConstraint.prototype.output):
(BinaryConstraint.prototype.recalculate):
(BinaryConstraint.prototype.markUnsatisfied):
(BinaryConstraint.prototype.inputsKnown):
(BinaryConstraint.prototype.removeFromGraph):
(ScaleConstraint):
(ScaleConstraint.prototype.addToGraph):
(ScaleConstraint.prototype.removeFromGraph):
(ScaleConstraint.prototype.markInputs):
(ScaleConstraint.prototype.execute):
(ScaleConstraint.prototype.recalculate):
(EqualityConstraint):
(EqualityConstraint.prototype.execute):
(Variable):
(Variable.prototype.addConstraint):
(Variable.prototype.removeConstraint):
(Planner):
(Planner.prototype.incrementalAdd):
(Planner.prototype.incrementalRemove):
(Planner.prototype.newMark):
(Planner.prototype.makePlan):
(Planner.prototype.extractPlanFromConstraints):
(Planner.prototype.addPropagate):
(Planner.prototype.removePropagateFrom):
(Planner.prototype.addConstraintsConsumingTo):
(Plan):
(Plan.prototype.addConstraint):
(Plan.prototype.size):
(Plan.prototype.constraintAt):
(Plan.prototype.execute):
(chainTest):
(projectionTest):
(change):
(deltaBlue):
* microbenchmarks/fake-iterators-that-throw-when-finished.js: Added.
(assert):
(Numbers):
(Numbers.prototype.next):
(return.Transpose):
(return.Transpose.prototype.next):
(transpose):
(verifyEven):
(verifyString):
(foo):
(runIterators):
* microbenchmarks/try-catch-word-count.js: Added.
(let.assert):
(EOF):
(let.texts):
(let.o.apply):
(foo):
(bar):
(f):
(run):
(test1):
(test2):
(test3):
(fn):
(A):
(B):
(A.prototype.getValue):
(B.prototype.getParentValue):
(strlen):
(sum.0):
(test):
(result.test.o):
(set add.set add):
(set forEach):
(stringHash):
(set if):
(testFunction):
(set delete.set has.set add):
* stress/catch-set-argument-speculation-failure.js: Added.
(o):
(e):
(e2):
(escape):
(baz):
(noInline.run):
(noInline):
* stress/osr-enter-to-catch-with-set-local-type-check-failure.js: Added.
(foo):
(e):
(baz):
(bar):

Source/JavaScriptCore:

This patch implements OSR entry into op_catch in the DFG. We will support OSR entry
into the FTL in a followup: https://bugs.webkit.org/show_bug.cgi?id=175396

To implement catch in the DFG, this patch introduces the concept of multiple
entrypoints into CPS/LoadStore DFG IR. A lot of this patch is stringing this concept
through the DFG. Many phases used to assume that Graph::block(0) is the only root, and this
patch contains many straight forward changes generalizing the code to handle more than
one entrypoint.

A main building block of this is moving to two CFG types: SSACFG and CPSCFG. SSACFG
is the same CFG we used to have. CPSCFG is a new type that introduces a fake root
that has an outgoing edge to all the entrypoints. This allows our existing graph algorithms
to Just Work over CPSCFG. For example, there is now the concept of SSADominators vs CPSDominators,
and SSANaturalLoops vs CPSNaturalLoops.

The way we compile the catch entrypoint is by bootstrapping the state
of the program by loading all live bytecode locals from a buffer. The OSR
entry code will store all live values into that buffer before jumping to
the entrypoint. The OSR entry code is also responsible for performing type
proofs of the arguments before doing an OSR entry. If there is a type
mismatch, it's not legal to OSR enter into the DFG compilation. Currently,
each catch entrypoint knows the argument type proofs it must perform to enter
into the DFG. Currently, all entrypoints' arguments flush format are unified
via ArgumentPosition, but this is just an implementation detail. The code is
written more generally to assume that each entrypoint may perform its own distinct
proof.

op_catch now performs value profiling for all live bytecode locals in the
LLInt and baseline JIT. This information is then fed into the DFG via the
ExtractCatchLocal node in the prediction propagation phase.

This patch also changes how we generate op_catch in bytecode. All op_catches
are now split out at the end of the program in bytecode. This ensures that
no op_catch is inside a try block. This is needed to ensure correctness in
the DFGLiveCatchVariablePreservationPhase. That phase only inserts flushes
before SetLocals inside a try block. If an op_catch were in a try block, this
would cause the phase to insert a Flush before one of the state bootstrapping
SetLocals, which would generate invalid IR. Moving op_catch to be generated on
its own at the end of a bytecode stream seemed like the most elegant solution since
it better represents that we treat op_catch as an entrypoint. This is true
both in the DFG and in the baseline and LLInt: we don't reach an op_catch
via normal control flow. Because op_catch cannot throw, this will not break
any previous semantics of op_catch. Logically, it'd be valid to split try
blocks around any non-throwing bytecode operation.

* CMakeLists.txt:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/BytecodeDumper.cpp:
(JSC::BytecodeDumper<Block>::dumpBytecode):
* bytecode/BytecodeList.json:
* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::validate):
* bytecode/CodeBlock.h:
* bytecode/ValueProfile.h:
(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfileAndOperandBuffer::ValueProfileAndOperandBuffer):
(JSC::ValueProfileAndOperandBuffer::~ValueProfileAndOperandBuffer):
(JSC::ValueProfileAndOperandBuffer::forEach):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCatch):
(JSC::BytecodeGenerator::emitEnumeration):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::TryNode::emitBytecode):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGBackwardsCFG.h:
(JSC::DFG::BackwardsCFG::BackwardsCFG):
* dfg/DFGBasicBlock.cpp:
(JSC::DFG::BasicBlock::BasicBlock):
* dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::findTerminal const):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::DelayedSetLocal::DelayedSetLocal):
(JSC::DFG::ByteCodeParser::DelayedSetLocal::execute):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGCFG.h:
(JSC::DFG::CFG::root):
(JSC::DFG::CFG::roots):
(JSC::DFG::CPSCFG::CPSCFG):
(JSC::DFG::selectCFG):
* dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::specialCaseArguments):
* dfg/DFGCSEPhase.cpp:
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGControlEquivalenceAnalysis.h:
(JSC::DFG::ControlEquivalenceAnalysis::ControlEquivalenceAnalysis):
* dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::run):
* dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::createDumpList):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGDominators.h:
(JSC::DFG::Dominators::Dominators):
(JSC::DFG::ensureDominatorsForCFG):
* dfg/DFGEdgeDominates.h:
(JSC::DFG::EdgeDominates::EdgeDominates):
(JSC::DFG::EdgeDominates::operator()):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupChecksInBlock):
* dfg/DFGFlushFormat.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::unboxLoopNode):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::determineReachability):
(JSC::DFG::Graph::invalidateCFG):
(JSC::DFG::Graph::blocksInPreOrder):
(JSC::DFG::Graph::blocksInPostOrder):
(JSC::DFG::Graph::ensureCPSDominators):
(JSC::DFG::Graph::ensureSSADominators):
(JSC::DFG::Graph::ensureCPSNaturalLoops):
(JSC::DFG::Graph::ensureSSANaturalLoops):
(JSC::DFG::Graph::ensureBackwardsCFG):
(JSC::DFG::Graph::ensureBackwardsDominators):
(JSC::DFG::Graph::ensureControlEquivalenceAnalysis):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
(JSC::DFG::Graph::clearCPSCFGData):
(JSC::DFG::Graph::ensureDominators): Deleted.
(JSC::DFG::Graph::ensurePrePostNumbering): Deleted.
(JSC::DFG::Graph::ensureNaturalLoops): Deleted.
* dfg/DFGGraph.h:
(JSC::DFG::Graph::willCatchExceptionInMachineFrame):
(JSC::DFG::Graph::isEntrypoint const):
* dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::initialize):
(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):
* dfg/DFGJITCode.cpp:
(JSC::DFG::JITCode::shrinkToFit):
* dfg/DFGJITCode.h:
(JSC::DFG::JITCode::catchOSREntryDataForBytecodeIndex):
(JSC::DFG::JITCode::finalizeCatchOSREntrypoints):
(JSC::DFG::JITCode::appendCatchEntrypoint):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::noticeCatchEntrypoint):
(JSC::DFG::JITCompiler::noticeOSREntry):
(JSC::DFG::JITCompiler::makeCatchOSREntryBuffer):
* dfg/DFGJITCompiler.h:
* dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::run):
(JSC::DFG::LICMPhase::attemptHoist):
* dfg/DFGLiveCatchVariablePreservationPhase.cpp:
(JSC::DFG::LiveCatchVariablePreservationPhase::run):
(JSC::DFG::LiveCatchVariablePreservationPhase::isValidFlushLocation):
(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlockForTryCatch):
(JSC::DFG::LiveCatchVariablePreservationPhase::newVariableAccessData):
(JSC::DFG::LiveCatchVariablePreservationPhase::willCatchException): Deleted.
(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlock): Deleted.
* dfg/DFGLoopPreHeaderCreationPhase.cpp:
(JSC::DFG::createPreHeader):
(JSC::DFG::LoopPreHeaderCreationPhase::run):
* dfg/DFGMaximalFlushInsertionPhase.cpp:
(JSC::DFG::MaximalFlushInsertionPhase::run):
(JSC::DFG::MaximalFlushInsertionPhase::treatRegularBlock):
(JSC::DFG::MaximalFlushInsertionPhase::treatRootBlock):
* dfg/DFGMayExit.cpp:
* dfg/DFGNaturalLoops.h:
(JSC::DFG::NaturalLoops::NaturalLoops):
* dfg/DFGNode.h:
(JSC::DFG::Node::isSwitch const):
(JSC::DFG::Node::successor):
(JSC::DFG::Node::catchOSREntryIndex const):
(JSC::DFG::Node::catchLocalPrediction):
(JSC::DFG::Node::isSwitch): Deleted.
* dfg/DFGNodeType.h:
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareCatchOSREntry):
* dfg/DFGOSREntry.h:
* dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
* dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
* dfg/DFGObjectAllocationSinkingPhase.cpp:
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
* dfg/DFGPrePostNumbering.cpp:
(JSC::DFG::PrePostNumbering::PrePostNumbering): Deleted.
(JSC::DFG::PrePostNumbering::~PrePostNumbering): Deleted.
(WTF::printInternal): Deleted.
* dfg/DFGPrePostNumbering.h:
(): Deleted.
(JSC::DFG::PrePostNumbering::preNumber const): Deleted.
(JSC::DFG::PrePostNumbering::postNumber const): Deleted.
(JSC::DFG::PrePostNumbering::isStrictAncestorOf const): Deleted.
(JSC::DFG::PrePostNumbering::isAncestorOf const): Deleted.
(JSC::DFG::PrePostNumbering::isStrictDescendantOf const): Deleted.
(JSC::DFG::PrePostNumbering::isDescendantOf const): Deleted.
(JSC::DFG::PrePostNumbering::edgeKind const): Deleted.
* dfg/DFGPredictionInjectionPhase.cpp:
(JSC::DFG::PredictionInjectionPhase::run):
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGPutStackSinkingPhase.cpp:
* dfg/DFGSSACalculator.cpp:
(JSC::DFG::SSACalculator::nonLocalReachingDef):
(JSC::DFG::SSACalculator::reachingDefAtTail):
* dfg/DFGSSACalculator.h:
(JSC::DFG::SSACalculator::computePhis):
* dfg/DFGSSAConversionPhase.cpp:
(JSC::DFG::SSAConversionPhase::run):
(JSC::DFG::performSSAConversion):
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStaticExecutionCountEstimationPhase.cpp:
(JSC::DFG::StaticExecutionCountEstimationPhase::run):
* dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
* dfg/DFGTierUpCheckInjectionPhase.cpp:
(JSC::DFG::TierUpCheckInjectionPhase::run):
(JSC::DFG::TierUpCheckInjectionPhase::buildNaturalLoopToLoopHintMap):
* dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::run):
* dfg/DFGValidate.cpp:
* ftl/FTLLink.cpp:
(JSC::FTL::link):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
(JSC::FTL::DFG::LowerDFGToB3::safelyInvalidateAfterTermination):
(JSC::FTL::DFG::LowerDFGToB3::isValid):
* jit/JIT.h:
* jit/JITInlines.h:
(JSC::JIT::callOperation):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_catch):
* jit/JITOperations.cpp:
* jit/JITOperations.h:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LLIntSlowPaths.h:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

Source/WTF:

This patch generalizes the BackwardsGraph fake root into a more generalizable
class called SingleRootGraph. SingleRootGraph exposes the general graph interface
used in Dominators and NaturalLoops. SingleRootGraph takes as input a graph with
the normal graph interface, but also allows the input graph to contain more than
one root. SingleRootGraph then exposes a single root, which it creates, that has
an outgoing edge to all the roots in the original graph.

* WTF.xcodeproj/project.pbxproj:
* wtf/BackwardsGraph.h:
(WTF::BackwardsGraph::dump const):
(WTF::BackwardsGraph::rootName): Deleted.
(WTF::BackwardsGraph::Node::Node): Deleted.
(WTF::BackwardsGraph::Node::root): Deleted.
(WTF::BackwardsGraph::Node::operator== const): Deleted.
(WTF::BackwardsGraph::Node::operator!= const): Deleted.
(WTF::BackwardsGraph::Node::operator bool const): Deleted.
(WTF::BackwardsGraph::Node::isRoot const): Deleted.
(WTF::BackwardsGraph::Node::node const): Deleted.
(): Deleted.
(WTF::BackwardsGraph::Set::Set): Deleted.
(WTF::BackwardsGraph::Set::add): Deleted.
(WTF::BackwardsGraph::Set::remove): Deleted.
(WTF::BackwardsGraph::Set::contains): Deleted.
(WTF::BackwardsGraph::Set::dump const): Deleted.
(WTF::BackwardsGraph::Map::Map): Deleted.
(WTF::BackwardsGraph::Map::clear): Deleted.
(WTF::BackwardsGraph::Map::size const): Deleted.
(WTF::BackwardsGraph::Map::operator[]): Deleted.
(WTF::BackwardsGraph::Map::operator[] const): Deleted.
* wtf/Dominators.h:
(WTF::Dominators::Dominators):
(WTF::Dominators::forAllBlocksInIteratedDominanceFrontierOf):
(WTF::Dominators::forAllBlocksInPrunedIteratedDominanceFrontierOf):
(WTF::Dominators::iteratedDominanceFrontierOf const):
(WTF::Dominators::forAllBlocksInIteratedDominanceFrontierOfImpl const):
* wtf/SingleRootGraph.h: Added.
(WTF::SingleRootGraphNode::rootName):
(WTF::SingleRootGraphNode::SingleRootGraphNode):
(WTF::SingleRootGraphNode::root):
(WTF::SingleRootGraphNode::operator== const):
(WTF::SingleRootGraphNode::operator!= const):
(WTF::SingleRootGraphNode::operator bool const):
(WTF::SingleRootGraphNode::isRoot const):
(WTF::SingleRootGraphNode::node const):
(WTF::SingleRootGraphSet::add):
(WTF::SingleRootGraphSet::remove):
(WTF::SingleRootGraphSet::contains):
(WTF::SingleRootGraphSet::dump const):
(WTF::SingleRootMap::SingleRootMap):
(WTF::SingleRootMap::clear):
(WTF::SingleRootMap::size const):
(WTF::SingleRootMap::operator[]):
(WTF::SingleRootMap::operator[] const):
(WTF::SingleRootGraph::SingleRootGraph):
(WTF::SingleRootGraph::root const):
(WTF::SingleRootGraph::newMap):
(WTF::SingleRootGraph::successors const):
(WTF::SingleRootGraph::predecessors const):
(WTF::SingleRootGraph::index const):
(WTF::SingleRootGraph::node const):
(WTF::SingleRootGraph::numNodes const):
(WTF::SingleRootGraph::dump const):
(WTF::SingleRootGraph::assertIsConsistent const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSpeedometer 2.0: Add the capability to run a specific suite
rniwa@webkit.org [Wed, 23 Aug 2017 23:54:40 +0000 (23:54 +0000)]
Speedometer 2.0: Add the capability to run a specific suite
https://bugs.webkit.org/show_bug.cgi?id=175908

Address Joe's review comments.

* Speedometer/resources/main.js:
(startBenchmark):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoLeaking CARenderServerBuffer in PlatformWebView::windowSnapshotImage()
jbedard@apple.com [Wed, 23 Aug 2017 23:53:42 +0000 (23:53 +0000)]
Leaking CARenderServerBuffer in PlatformWebView::windowSnapshotImage()
https://bugs.webkit.org/show_bug.cgi?id=175905

Reviewed by Tim Horton.

* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::windowSnapshotImage): Pass CARenderServerBuffer to CGDataProviderCreateWithData
so that the buffer can be destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[EME] WebCoreDecompressionSession should only report having an available frame if...
jer.noble@apple.com [Wed, 23 Aug 2017 23:23:21 +0000 (23:23 +0000)]
[EME] WebCoreDecompressionSession should only report having an available frame if it has one for the current time.
https://bugs.webkit.org/show_bug.cgi?id=175901

Reviewed by Eric Carlson.

The WebCoreDecompressionSession will trigger the hasAvailableFrame callback whenever a frame is decoded,
regardless of its presentation time. For formats which have out-of-order decoding, the newly decoded frame could
have a presentation time far in the future. Instead, only fire the callback if the decoded frame's presentation
times contains the timebase's current time.

* platform/graphics/cocoa/WebCoreDecompressionSession.mm:
(WebCore::WebCoreDecompressionSession::enqueueDecodedSample):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMarked loader/stateobjects/replacestate-size.html as flaky.
jlewis3@apple.com [Wed, 23 Aug 2017 23:06:43 +0000 (23:06 +0000)]
Marked loader/stateobjects/replacestate-size.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172829

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSpeedometer 2.0: Add the capability to run a specific suite
rniwa@webkit.org [Wed, 23 Aug 2017 23:04:13 +0000 (23:04 +0000)]
Speedometer 2.0: Add the capability to run a specific suite
https://bugs.webkit.org/show_bug.cgi?id=175908

Reviewed by Saam Barati.

Added ?suite=X query parameter to specify a specific suite (e.g. React-TodoMVC) to run.

* Speedometer/resources/main.js:
(enableOneSuite): Added.
(startBenchmark): Return true if the benchmark actually had started running.
(startTest): Don't transition to the "running" state if the benchmark failed to start (e.g. no tests to run).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed, debug build fix
utatane.tea@gmail.com [Wed, 23 Aug 2017 22:53:14 +0000 (22:53 +0000)]
Unreviewed, debug build fix
https://bugs.webkit.org/show_bug.cgi?id=174355

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucketNext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Cache API] Unify WebCore and WebKit error handling
commit-queue@webkit.org [Wed, 23 Aug 2017 22:33:15 +0000 (22:33 +0000)]
[Cache API] Unify WebCore and WebKit error handling
https://bugs.webkit.org/show_bug.cgi?id=175902

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-23
Reviewed by Alex Christensen.

Source/WebCore:

No change of behavior.

Introducing a DOMCache namespace enclosing structures, callbacks and function definitions
previously found in either WebCore::CacheStorageConnection or WebKit::CacheStorage.

Some previously used callbacks had no way to pass errors in WebCore while they had in WebKit.
Updated Cache, CacheStorage, CacheStorageConnection and WorkerCacheStorageConnection to deal with these potential errors.

* CMakeLists.txt:
* Modules/cache/Cache.cpp:
(WebCore::FetchTasksHandler::FetchTasksHandler):
(WebCore::FetchTasksHandler::records const):
(WebCore::FetchTasksHandler::addRecord):
(WebCore::Cache::addAll):
(WebCore::Cache::put):
(WebCore::Cache::retrieveRecords):
(WebCore::queryCacheMatch):
(WebCore::Cache::batchDeleteOperation):
(WebCore::toConnectionRecord):
(WebCore::Cache::batchPutOperation):
(WebCore::Cache::updateRecords):
* Modules/cache/Cache.h:
* Modules/cache/CacheStorage.cpp:
(WebCore::CacheStorage::retrieveCaches):
(WebCore::CacheStorage::open):
(WebCore::CacheStorage::remove):
* Modules/cache/CacheStorage.h:
* Modules/cache/CacheStorageConnection.cpp:
(WebCore::CacheStorageConnection::open):
(WebCore::CacheStorageConnection::remove):
(WebCore::CacheStorageConnection::retrieveCaches):
(WebCore::CacheStorageConnection::batchDeleteOperation):
(WebCore::CacheStorageConnection::batchPutOperation):
(WebCore::CacheStorageConnection::openOrRemoveCompleted):
(WebCore::CacheStorageConnection::updateCaches):
(WebCore::CacheStorageConnection::updateRecords):
(WebCore::CacheStorageConnection::deleteRecordsCompleted):
(WebCore::CacheStorageConnection::putRecordsCompleted):
* Modules/cache/CacheStorageConnection.h:
(WebCore::CacheStorageConnection::openCompleted):
(WebCore::CacheStorageConnection::removeCompleted):
(WebCore::CacheStorageConnection::doOpen):
(WebCore::CacheStorageConnection::doRemove):
(WebCore::CacheStorageConnection::doBatchDeleteOperation):
(WebCore::CacheStorageConnection::doBatchPutOperation):
* Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):
(WebCore::WorkerCacheStorageConnection::doOpen):
(WebCore::WorkerCacheStorageConnection::doRemove):
(WebCore::WorkerCacheStorageConnection::doRetrieveCaches):
(WebCore::recordsDataFromRecords):
(WebCore::recordsDataOrErrorFromRecords):
(WebCore::recordsFromRecordsData):
(WebCore::recordsOrErrorFromRecordsData):
(WebCore::WorkerCacheStorageConnection::doRetrieveRecords):
(WebCore::WorkerCacheStorageConnection::doBatchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::doBatchPutOperation):
* Modules/cache/DOMCache.cpp: Added.
* Modules/cache/DOMCache.h: Added.
* Modules/cache/WorkerCacheStorageConnection.h:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

Removing all callbacks and error definitions from WebKit
and reusing DOMCache ones instead.

* NetworkProcess/cache/CacheStorage.h: Removed.
* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::caches const):
(WebKit::CacheStorage::Engine::queryCache):
* NetworkProcess/cache/CacheStorageEngine.h:
* NetworkProcess/cache/CacheStorageEngineCache.h:
* NetworkProcess/cache/CacheStorageEngineConnection.cpp:
(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::putRecords):
* NetworkProcess/cache/CacheStorageEngineConnection.h:
* NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<DOMCache::CacheInfo>::encode):
(IPC::ArgumentCoder<DOMCache::CacheInfo>::decode):
(IPC::ArgumentCoder<DOMCache::Record>::encode):
(IPC::ArgumentCoder<DOMCache::Record>::decode):
* Shared/WebCoreArgumentCoders.h:
* WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::doBatchPutOperation):
(WebKit::WebCacheStorageConnection::openCompleted):
(WebKit::WebCacheStorageConnection::removeCompleted):
(WebKit::WebCacheStorageConnection::updateCaches):
(WebKit::WebCacheStorageConnection::updateRecords):
(WebKit::WebCacheStorageConnection::deleteRecordsCompleted):
(WebKit::WebCacheStorageConnection::putRecordsCompleted):
* WebProcess/Cache/WebCacheStorageConnection.h:
* WebProcess/Cache/WebCacheStorageConnection.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoREGRESSION (r221052): DumpRenderTree crashed in com.apple.JavaScriptCore: JSC::Yarr...
msaboff@apple.com [Wed, 23 Aug 2017 22:24:30 +0000 (22:24 +0000)]
REGRESSION (r221052): DumpRenderTree crashed in com.apple.JavaScriptCore: JSC::Yarr::YarrCodeBlock::execute + 137
https://bugs.webkit.org/show_bug.cgi?id=175903

Reviewed by Saam Barati.

Source/JavaScriptCore:

In generateCharacterClassGreedy we were incrementing the "count" register before checking
for the end of the input string.  The at-end-of-input check is the final check before
knowing that the current character matched.  In this case, the end of input check
indicates that we ran out of prechecked characters and therefore should fail the match of
the current character.  The backtracking code uses the value in the "count" register as
the number of character that successfully matched, which shouldn't include the current
character.  Therefore we need to move the incrementing of "count" to after the
at end of input check.

Through code inspection of the expectations of other backtracking code, I determined that
the non greedy character class matching code had a similar issue.  I fixed that as well
and added a new test case.

* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):

LayoutTests:

New regression test case.

* js/regexp-unicode-expected.txt:
* js/script-tests/regexp-unicode.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[JSC] Optimize Map iteration with intrinsic
utatane.tea@gmail.com [Wed, 23 Aug 2017 22:19:13 +0000 (22:19 +0000)]
[JSC] Optimize Map iteration with intrinsic
https://bugs.webkit.org/show_bug.cgi?id=174355

Reviewed by Saam Barati.

JSTests:

* stress/map-iterator-result-should-have-expected-shape.js: Added.
(shouldBe):
(throw.new.Error):
* stress/set-iterator-result-should-have-expected-shape.js: Added.
(shouldBe):
(throw.new.Error.let.iterator.set Symbol):
(throw.new.Error.set add):
(let.iterator.set Symbol):

Source/JavaScriptCore:

This patch optimizes Map/Set iteration by taking the approach similar to Array iteration.
We create a simple iterator object instead of JSMapIterator and JSSetIterator. And we
directly handles Map/Set buckets in JS builtins. We carefully create mapIteratorNext and
setIteratorNext functions which should be inlined. This leads significant performance boost
when they are inlined in for-of iteration.

This patch changes how DFG and FTL handles MapBucket if the bucket is not found.
Previously, we use nullptr for that, and DFG and FTL specially handle this nullptr as bucket.
Instead, this patch introduces sentinel buckets. They are marked as deleted, and not linked
to any hash maps. And its key and value fields are filled with Undefined. By returning this
sentinel bucket instead of returning nullptr, we simplify DFG and FTL's LoadXXXFromMapBucket
code.

We still keep JSMapIterator and JSSetIterator because they are useful to serialize Map and Set
in WebCore. So they are not used in user observable JS. We change them from JS objects to JS cells.

Existing microbenchmarks shows performance improvements.

large-map-iteration                           164.1622+-4.1618     ^     56.6284+-1.5355        ^ definitely 2.8989x faster
set-for-of                                     15.4369+-1.0631     ^      9.2955+-0.5979        ^ definitely 1.6607x faster
map-for-each                                    7.5889+-0.5792     ^      6.3011+-0.4816        ^ definitely 1.2044x faster
map-for-of                                     32.3904+-1.3003     ^     12.6907+-0.6118        ^ definitely 2.5523x faster
map-rehash                                     13.9275+-0.9187     ^     11.5367+-0.6430        ^ definitely 1.2072x faster

* CMakeLists.txt:
* DerivedSources.make:
* builtins/ArrayPrototype.js:
(globalPrivate.createArrayIterator):
* builtins/BuiltinNames.h:
* builtins/MapIteratorPrototype.js: Copied from Source/JavaScriptCore/builtins/MapPrototype.js.
(globalPrivate.mapIteratorNext):
(next):
* builtins/MapPrototype.js:
(globalPrivate.createMapIterator):
(values):
(keys):
(entries):
(forEach):
* builtins/SetIteratorPrototype.js: Copied from Source/JavaScriptCore/builtins/MapPrototype.js.
(globalPrivate.setIteratorNext):
(next):
* builtins/SetPrototype.js:
(globalPrivate.createSetIterator):
(values):
(entries):
(forEach):
* bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
* bytecode/BytecodeIntrinsicRegistry.h:
* bytecode/SpeculatedType.h:
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGHeapLocation.cpp:
(WTF::printInternal):
* dfg/DFGHeapLocation.h:
* dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasBucketOwnerType):
(JSC::DFG::Node::bucketOwnerType):
(JSC::DFG::Node::OpInfoWrapper::as const):
* dfg/DFGNodeType.h:
* dfg/DFGOperations.cpp:
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetMapBucketHead):
(JSC::DFG::SpeculativeJIT::compileGetMapBucketNext):
(JSC::DFG::SpeculativeJIT::compileLoadKeyFromMapBucket):
(JSC::DFG::SpeculativeJIT::compileLoadValueFromMapBucket):
(JSC::DFG::SpeculativeJIT::compileCompareEqPtr): Deleted.
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileCompareEqPtr):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileCompareEqPtr):
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLAbstractHeapRepository.h:
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucket):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucketHead):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucketNext):
(JSC::FTL::DFG::LowerDFGToB3::compileLoadValueFromMapBucket):
(JSC::FTL::DFG::LowerDFGToB3::compileLoadKeyFromMapBucket):
(JSC::FTL::DFG::LowerDFGToB3::setStorage):
(JSC::FTL::DFG::LowerDFGToB3::compileLoadFromJSMapBucket): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::compileIsNonEmptyMapBucket): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::lowMapBucket): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::setMapBucket): Deleted.
* inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties):
(Inspector::cloneMapIteratorObject):
(Inspector::cloneSetIteratorObject):
(Inspector::JSInjectedScriptHost::iteratorEntries):
* runtime/HashMapImpl.h:
(JSC::HashMapBucket::createSentinel):
(JSC::HashMapBucket::offsetOfNext):
(JSC::HashMapBucket::offsetOfDeleted):
(JSC::HashMapImpl::offsetOfHead):
* runtime/Intrinsic.cpp:
(JSC::intrinsicName):
* runtime/Intrinsic.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* runtime/JSGlobalObject.h:
* runtime/JSMap.h:
* runtime/JSMapIterator.cpp:
(JSC::JSMapIterator::clone): Deleted.
* runtime/JSMapIterator.h:
(JSC::JSMapIterator::iteratedValue const):
* runtime/JSSet.h:
* runtime/JSSetIterator.cpp:
(JSC::JSSetIterator::clone): Deleted.
* runtime/JSSetIterator.h:
(JSC::JSSetIterator::iteratedValue const):
* runtime/MapConstructor.cpp:
(JSC::mapPrivateFuncMapBucketHead):
(JSC::mapPrivateFuncMapBucketNext):
(JSC::mapPrivateFuncMapBucketKey):
(JSC::mapPrivateFuncMapBucketValue):
* runtime/MapConstructor.h:
* runtime/MapIteratorPrototype.cpp:
(JSC::MapIteratorPrototype::finishCreation):
(JSC::MapIteratorPrototypeFuncNext): Deleted.
* runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
(JSC::mapProtoFuncValues): Deleted.
(JSC::mapProtoFuncEntries): Deleted.
(JSC::mapProtoFuncKeys): Deleted.
(JSC::privateFuncMapIterator): Deleted.
(JSC::privateFuncMapIteratorNext): Deleted.
* runtime/MapPrototype.h:
* runtime/SetConstructor.cpp:
(JSC::setPrivateFuncSetBucketHead):
(JSC::setPrivateFuncSetBucketNext):
(JSC::setPrivateFuncSetBucketKey):
* runtime/SetConstructor.h:
* runtime/SetIteratorPrototype.cpp:
(JSC::SetIteratorPrototype::finishCreation):
(JSC::SetIteratorPrototypeFuncNext): Deleted.
* runtime/SetPrototype.cpp:
(JSC::SetPrototype::finishCreation):
(JSC::setProtoFuncSize):
(JSC::setProtoFuncValues): Deleted.
(JSC::setProtoFuncEntries): Deleted.
(JSC::privateFuncSetIterator): Deleted.
(JSC::privateFuncSetIteratorNext): Deleted.
* runtime/SetPrototype.h:
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:

Source/WebCore:

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::serialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoStop using PolicyCallback for new window policies
achristensen@apple.com [Wed, 23 Aug 2017 22:11:11 +0000 (22:11 +0000)]
Stop using PolicyCallback for new window policies
https://bugs.webkit.org/show_bug.cgi?id=175907

Reviewed by Andy Estes.

PolicyCallback is an artifact from the days before C++11.  Let's use lambdas instead!
No change in behaviour.

* loader/PolicyCallback.cpp:
(WebCore::PolicyCallback::set):
(WebCore::PolicyCallback::call):
(WebCore::PolicyCallback::cancel):
* loader/PolicyCallback.h:
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):
(WebCore::PolicyChecker::continueAfterNewWindowPolicy): Deleted.
* loader/PolicyChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSpeedometer 2.0: Async time is not always capturing layout time
rniwa@webkit.org [Wed, 23 Aug 2017 21:40:41 +0000 (21:40 +0000)]
Speedometer 2.0: Async time is not always capturing layout time
https://bugs.webkit.org/show_bug.cgi?id=175871

Reviewed by Simon Fraser.

Speedometer harness was designed to capture the time browser engine spends relayouting and repainting the content
after DOM mutations this in its async time measurement, which is the time between each test case's code had finished
running and when a newly scheduled 0s timer is fired immediately afterwards.

It turns out that modern web browsers defer this reflow and repaint work until the next animation frame is requested.
This results in Speedometer harness measuring reflow and repaint cost only sometimes depending on when each test case
had finished running relative to the next frame request.

While such a behavior makes sense and might be desirable for a modern browser engine, we would like to capture it in
the async time for the purpose of Speedometer. Unfortunately, there isn't an interoperable API for browsers to report
the total layout and repaint time, and relying on 16ms-granularity requestAnimationFrame is too coarse for Speedometer.

This patch works around these limitations by manually forcing the layout in async time measurement by calling
getBoundingClientRect() in iframe's document. Since the height of the document depends on the number of todo items,
this should cause browser engines to do most if not all of the work needed to reflow the document at least for now.

Note that even new async time doesn't always capture painting time but there isn't a good cross-browser mechanism
to measure paint time in the granurality we need for Speedometer at the moment anyway. (Should such a mechanism exist,
that could be a huge timing attack surface so it's probably best that we don't have one.)

* Speedometer/resources/benchmark-runner.js:
(BenchmarkRunner.prototype._runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSpeedometer: Make React/Redux item order consistent
rniwa@webkit.org [Wed, 23 Aug 2017 21:39:28 +0000 (21:39 +0000)]
Speedometer: Make React/Redux item order consistent
https://bugs.webkit.org/show_bug.cgi?id=175818

Reviewed by Joseph Pecoraro.

Based on the patch made by Mathias Bynens. Re-generated project files.

Also tweaked the instruction in package.json so that newly generated files in build/* replace dist/* instead of
being moved under dist/build/ by rm -rf'ing dist directory first.

* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/index.html:
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.43a0948c.js: Removed.
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.43a0948c.js.map: Removed.
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.69cd9655.js: Added.
* Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.69cd9655.js.map: Added.
* Speedometer/resources/todomvc/architecture-examples/react-redux/package.json:
* Speedometer/resources/todomvc/architecture-examples/react-redux/src/reducers/todos.js: Forced new items to be appended rather than prepended.
* Speedometer/resources/todomvc/architecture-examples/react-redux/yarn.lock: Removed unnecessary file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoSpeedometer: Update to modern React version
commit-queue@webkit.org [Wed, 23 Aug 2017 21:37:45 +0000 (21:37 +0000)]
Speedometer: Update to modern React version
https://bugs.webkit.org/show_bug.cgi?id=175715

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-23
Reviewed by Ryosuke Niwa.

This patch pins React and react-dom to v15.5.4 (released in May 2017).

* Speedometer/resources/todomvc/architecture-examples/react/README.md: Documented build steps.
* Speedometer/resources/todomvc/architecture-examples/react/index.html: Made title consistent.
* Speedometer/resources/todomvc/architecture-examples/react/node_modules/*: Remove unneeded files and update per build instructions.
* Speedometer/resources/todomvc/architecture-examples/react/npm-shrinkwrap.json: Removed in favor of package-lock.json.
* Speedometer/resources/todomvc/architecture-examples/react/package-lock.json: Pinned dependencies to make build deterministic.
* Speedometer/resources/todomvc/architecture-examples/react/package.json: Update dependencies.
* Speedometer/resources/todomvc/architecture-examples/react/yarn.lock: Removed in favor of package-lock.json.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoStop using PolicyChecker for ContentPolicy
achristensen@apple.com [Wed, 23 Aug 2017 21:10:09 +0000 (21:10 +0000)]
Stop using PolicyChecker for ContentPolicy
https://bugs.webkit.org/show_bug.cgi?id=175904

Reviewed by Tim Horton.

PolicyChecker is an artifact from the days before C++11.  Now we have lambdas which
have a cleaner flow than one class that exists to be effectively one of three lambda types.
Let's remove them one at a time, starting with ContentPolicy checks.

No change in behaviour.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkContentPolicy):
* loader/FrameLoader.h:
* loader/PolicyCallback.cpp:
(WebCore::PolicyCallback::set):
(WebCore::PolicyCallback::call):
(WebCore::PolicyCallback::cancel):
* loader/PolicyCallback.h:
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkContentPolicy): Deleted.
(WebCore::PolicyChecker::continueAfterContentPolicy): Deleted.
* loader/PolicyChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoClean up UIClients
achristensen@apple.com [Wed, 23 Aug 2017 21:08:28 +0000 (21:08 +0000)]
Clean up UIClients
https://bugs.webkit.org/show_bug.cgi?id=175906

Reviewed by Tim Horton.

There were some unnecessary checks to see if the client implements something,
when the default behavior is to do nothing if the client doesn't implement the callback.
Also, make some overrides finals and fix some spacing.

* UIProcess/API/APIUIClient.h:
(API::UIClient::didNotHandleKeyEvent):
(API::UIClient::implementsDidNotHandleKeyEvent const): Deleted.
(API::UIClient::implementsDidNotHandleWheelEvent const): Deleted.
* UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMarked webrtc/filtering-ice-candidate-after-reload.html a flaky.
jlewis3@apple.com [Wed, 23 Aug 2017 21:04:46 +0000 (21:04 +0000)]
Marked webrtc/filtering-ice-candidate-after-reload.html a flaky.
https://bugs.webkit.org/show_bug.cgi?id=174471

Unreviewed test gardening.

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoBuild fix for 32-bit Mac after r221098. Make sure constant used in WebCoreDecompressi...
jer.noble@apple.com [Wed, 23 Aug 2017 20:41:36 +0000 (20:41 +0000)]
Build fix for 32-bit Mac after r221098. Make sure constant used in WebCoreDecompressionSession is SoftLinked.

* platform/cf/CoreMediaSoftLink.cpp:
* platform/cf/CoreMediaSoftLink.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAdd WKUIDelegatePrivate callbacks corresponding to WKPageUIClient's takeFocus, focus...
achristensen@apple.com [Wed, 23 Aug 2017 20:35:49 +0000 (20:35 +0000)]
Add WKUIDelegatePrivate callbacks corresponding to WKPageUIClient's takeFocus, focus, and unfocus
https://bugs.webkit.org/show_bug.cgi?id=175896

Reviewed by Tim Horton.
Source/WebKit:

I also renamed _webViewShow to _showWebView based on feedback from https://bugs.webkit.org/show_bug.cgi?id=175797

Added an API test.

* UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
* UIProcess/Cocoa/UIDelegate.h:
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::toWKFocusDirection):
(WebKit::UIDelegate::UIClient::takeFocus):
(WebKit::UIDelegate::UIClient::focus):
(WebKit::UIDelegate::UIClient::unfocus):
(WebKit::UIDelegate::UIClient::showPage):

Tools:

* TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:
(-[UITestDelegate _showWebView:]):
(TEST):
(tabEvent):
(synthesizeTab):
(-[FocusDelegate _webView:takeFocus:]):
(-[FocusDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[UITestDelegate _webViewShow:]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoTrack VideoPlaybackQuality metrics when using WebCoreDecompressionSession.
jer.noble@apple.com [Wed, 23 Aug 2017 20:16:51 +0000 (20:16 +0000)]
Track VideoPlaybackQuality metrics when using WebCoreDecompressionSession.
https://bugs.webkit.org/show_bug.cgi?id=175835
<rdar://problem/34022234>

Reviewed by Eric Carlson.

Source/WebCore:

Test: platform/mac/media/media-source/videoplaybackquality-decompressionsession.html

Track the total number of frames decoded, dropped, & corrupted, as well as the total
delay imposed by decoding in the WebCoreDecompressionSession.

Drive-by fix: implement frame dropping by skipping frames whose presentation times are
before the video's current time and which aren't depended upon by other frames.

* platform/cf/CoreMediaSoftLink.cpp:
* platform/cf/CoreMediaSoftLink.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::videoPlaybackQualityMetrics):
* platform/graphics/cocoa/WebCoreDecompressionSession.h:
(WebCore::WebCoreDecompressionSession::totalVideoFrames):
(WebCore::WebCoreDecompressionSession::droppedVideoFrames):
(WebCore::WebCoreDecompressionSession::corruptedVideoFrames):
(WebCore::WebCoreDecompressionSession::totalFrameDelay):
* platform/graphics/cocoa/WebCoreDecompressionSession.mm:
(WebCore::WebCoreDecompressionSession::shouldDecodeSample):
(WebCore::WebCoreDecompressionSession::decodeSample):
(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):

LayoutTests:

* platform/mac/media/media-source/videoplaybackquality-decompressionsession-expected.txt: Added.
* platform/mac/media/media-source/videoplaybackquality-decompressionsession.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix -Wcast-qual warnings in JavaScriptCore with new clang compiler
ddkilzer@apple.com [Wed, 23 Aug 2017 20:14:37 +0000 (20:14 +0000)]
Fix -Wcast-qual warnings in JavaScriptCore with new clang compiler
<https://webkit.org/b/175889>
<rdar://problem/33667497>

Reviewed by Mark Lam.

* API/ObjCCallbackFunction.mm:
(JSC::objCCallbackFunctionCallAsConstructor): Use
const_cast<JSObjectRef>() since JSValueRef is const while
JSObjectRef is not.
* API/tests/CurrentThisInsideBlockGetterTest.mm:
(+[JSValue valueWithConstructorDescriptor:inContext:]): Use
const_cast<void*>() since JSObjectMake() takes a void*, but
CFBridgingRetain() returns const void*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRemoved flaky timeout expectation for inspector/codemirror/prettyprinting-css.html.
jlewis3@apple.com [Wed, 23 Aug 2017 20:05:44 +0000 (20:05 +0000)]
Removed flaky timeout expectation for inspector/codemirror/prettyprinting-css.html.

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoPlatform code should be able to safely log in release builds
eric.carlson@apple.com [Wed, 23 Aug 2017 20:01:59 +0000 (20:01 +0000)]
Platform code should be able to safely log in release builds
https://bugs.webkit.org/show_bug.cgi?id=175854
<rdar://problem/34022930>

Reviewed by Jer Noble.

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/Logger.h: Added.
(PAL::Logger::create):
(PAL::Logger::error const):
(PAL::Logger::warning const):
(PAL::Logger::notice const):
(PAL::Logger::info const):
(PAL::Logger::debug const):
(PAL::Logger::willLog const):
(PAL::Logger::enabled const):
(PAL::Logger::setEnabled):
(PAL::Logger::Logger):
(PAL::Logger::log):

Tools:

* TestWebKitAPI/Tests/WebCore/Logging.cpp:
(TestWebKitAPI::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Payment Request] Update to "In Development" in features.json
aestes@apple.com [Wed, 23 Aug 2017 19:50:42 +0000 (19:50 +0000)]
[Payment Request] Update to "In Development" in features.json
https://bugs.webkit.org/show_bug.cgi?id=175897

Reviewed by Sam Weinig.

* features.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[CacheAPI] Introduce a WebKit::CacheStorage namespace
commit-queue@webkit.org [Wed, 23 Aug 2017 19:45:48 +0000 (19:45 +0000)]
[CacheAPI] Introduce a WebKit::CacheStorage namespace
https://bugs.webkit.org/show_bug.cgi?id=175885

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-23
Reviewed by Alex Christensen.

Introducing WebKit::CacheStorage namespace.
Splitting CacheStorageEngine.h in three files.
Updating client code accordingly.

* NetworkProcess/cache/CacheStorage.h: Added.
* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::globalEngineMap):
(WebKit::CacheStorage::Engine::from):
(WebKit::CacheStorage::Engine::destroyEngine):
(WebKit::CacheStorage::Engine::defaultEngine):
(WebKit::CacheStorage::Engine::open):
(WebKit::CacheStorage::Engine::remove):
(WebKit::CacheStorage::Engine::retrieveCaches):
(WebKit::CacheStorage::Engine::retrieveRecords):
(WebKit::CacheStorage::Engine::putRecords):
(WebKit::CacheStorage::Engine::deleteMatchingRecords):
(WebKit::CacheStorage::Engine::writeCachesToDisk):
(WebKit::CacheStorage::Engine::readCachesFromDisk):
(WebKit::CacheStorage::Engine::readCache):
(WebKit::CacheStorage::Engine::writeCacheRecords):
(WebKit::CacheStorage::Engine::removeCacheRecords):
(WebKit::CacheStorage::Engine::cache):
(WebKit::CacheStorage::Engine::caches const):
(WebKit::CacheStorage::Engine::queryCache):
* NetworkProcess/cache/CacheStorageEngineCache.h: Added.
* NetworkProcess/cache/CacheStorageEngineConnection.cpp:
(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::caches):
(WebKit::CacheStorageEngineConnection::records):
(WebKit::CacheStorageEngineConnection::deleteMatchingRecords):
(WebKit::CacheStorageEngineConnection::putRecords):
* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Cache/WebCacheStorageConnection.cpp:
(WebKit::WebCacheStorageConnection::openCompleted):
(WebKit::WebCacheStorageConnection::removeCompleted):
(WebKit::WebCacheStorageConnection::updateCaches):
(WebKit::WebCacheStorageConnection::updateRecords):
(WebKit::WebCacheStorageConnection::deleteRecordsCompleted):
(WebKit::WebCacheStorageConnection::putRecordsCompleted):
* WebProcess/Cache/WebCacheStorageConnection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoDefault passive touch event listeners on the root
dino@apple.com [Wed, 23 Aug 2017 19:22:28 +0000 (19:22 +0000)]
Default passive touch event listeners on the root
https://bugs.webkit.org/show_bug.cgi?id=175346
<rdar://problem/33164597>

Reviewed by Sam Weinig.

Source/WebCore:

Make any touchstart or touchmove event listeners passive by default
if they are on the document, window, body or document element targets.
This follows the "intervention" first implemented by Chrome/Blink:

https://github.com/WICG/interventions/issues/35
https://docs.google.com/document/d/1II7oSIpd8pK91V5kEM3tDLKcIj398jOJn8Niqy6_loI/edit
https://github.com/whatwg/dom/issues/365

If the event listener explicitly defines "passive" to false in their
options dictionary, then they'll still get a non-passive listener.

NOTE: Any fallout from this bug should be collected in:
https://bugs.webkit.org/show_bug.cgi?id=175869
Please do not revert this change just because a site is broken. We'll
gather the issues and see if we can evangelise or detect via code.

Tests: fast/events/touch/ios/passive-by-default-on-document-and-window.html
       fast/events/touch/ios/passive-by-default-overridden-on-document-and-window.html

* dom/EventNames.h:
(WebCore::EventNames::isTouchScrollBlockingEventType const): Added this helper
to identify the types of touches we want to check for.
* dom/EventTarget.cpp:
(WebCore::EventTarget::addEventListener): Check for the event being one of the touch-types
that we care about, and the target being one of the Node/Window types we care about. If
so, tell the event listener to be passive.
* dom/EventTarget.h: Use an optional for the passive member.
(WebCore::EventTarget::AddEventListenerOptions::AddEventListenerOptions):
* dom/EventTarget.idl: Change "passive" to not have a default value, so we
can detect if it was explicitly set to false.

LayoutTests:

* fast/events/touch/ios/passive-by-default-on-document-and-window-expected.txt: Added.
* fast/events/touch/ios/passive-by-default-on-document-and-window.html: Added.
* fast/events/touch/ios/passive-by-default-overridden-on-document-and-window-expected.txt: Added.
* fast/events/touch/ios/passive-by-default-overridden-on-document-and-window.html: Added.
* fast/events/touch/ios/tap-with-active-listener-on-window.html: Explicitly set passive to false.
* fast/events/touch/ios/touch-event-regions/document.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoWeb Inspector: Make lock icon crispier
nvasilyev@apple.com [Wed, 23 Aug 2017 18:47:34 +0000 (18:47 +0000)]
Web Inspector: Make lock icon crispier
https://bugs.webkit.org/show_bug.cgi?id=175868

Reviewed by Matt Baker.

* UserInterface/Images/Locked.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAccess expectations path through apple_additions
jbedard@apple.com [Wed, 23 Aug 2017 18:35:15 +0000 (18:35 +0000)]
Access expectations path through apple_additions
https://bugs.webkit.org/show_bug.cgi?id=174800
<rdar://problem/33498899>

Unreviewed follow-up fix for r221087.

* Scripts/webkitpy/port/ios.py:
(IOSPort._apple_additions_path): Use iOS mapping instead of Mac mapping.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoTry to fix the WinCairo build after r221068
timothy_horton@apple.com [Wed, 23 Aug 2017 18:14:39 +0000 (18:14 +0000)]
Try to fix the WinCairo build after r221068

* platform/win/PlatformScreenWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAccess expectations path through apple_additions
jbedard@apple.com [Wed, 23 Aug 2017 18:09:06 +0000 (18:09 +0000)]
Access expectations path through apple_additions
https://bugs.webkit.org/show_bug.cgi?id=174800
<rdar://problem/33498899>

Reviewed by David Kilzer.

Follow-up fix. Mapping of operating system names was done incorrectly.

* Scripts/webkitpy/port/ios.py:
(IOSPort._apple_additions_path): Correctly find the operating system to be replaced.
* Scripts/webkitpy/port/ios_device_unittest.py:
(IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Add test for operating
system name replacement.
* Scripts/webkitpy/port/ios_simulator_unittest.py:
(IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Add test for operating
system name replacement.
* Scripts/webkitpy/port/mac.py: Correctly find the operating system to be replaced.
(MacPort._apple_additions_path):
* Scripts/webkitpy/port/mac_unittest.py:
(MacTest.test_layout_test_searchpath_with_apple_additions): Add test for operating system
name replacement.
* Scripts/webkitpy/port/port_testcase.py:
(bind_mock_apple_additions.MockAppleAdditions.ios_os_name): Change the passed name so that
operating system name replacement can be tested.
(bind_mock_apple_additions.MockAppleAdditions.mac_os_name): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Cache API] Enable persistent coder to encode FetchOptions
commit-queue@webkit.org [Wed, 23 Aug 2017 17:54:03 +0000 (17:54 +0000)]
[Cache API] Enable persistent coder to encode FetchOptions
https://bugs.webkit.org/show_bug.cgi?id=175883

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-23
Reviewed by Alex Christensen.

Source/WebCore:

No change of behavior.
Adding encode/decode routines for FetchOptions.

* loader/FetchOptions.h:
(WebCore::FetchOptions::encode const):
(WebCore::FetchOptions::decode):
* platform/ReferrerPolicy.h:

Source/WebKit:

Removing FetchOptions related ArgumentCoders specific code.

* Shared/WebCoreArgumentCoders.cpp:
* Shared/WebCoreArgumentCoders.h:

Source/WTF:

Enabling encoding/decoding of enums with EnumTraits.
This code is similar to the one of IPC encoder/decoder.

* wtf/persistence/PersistentDecoder.h:
(WTF::Persistence::Decoder::decode):
* wtf/persistence/PersistentEncoder.h:
(WTF::Persistence::Encoder::encode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoCacheStorageEngine readCachesFromDisk callback should return the read Caches
commit-queue@webkit.org [Wed, 23 Aug 2017 17:52:56 +0000 (17:52 +0000)]
CacheStorageEngine readCachesFromDisk callback should return the read Caches
https://bugs.webkit.org/show_bug.cgi?id=175882

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-23
Reviewed by Alex Christensen.

Callback of readCachesFromDisk takes now a Caches or error parameter.

* NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorageEngine::open):
(WebKit::CacheStorageEngine::retrieveCaches):
(WebKit::CacheStorageEngine::readCachesFromDisk):
* NetworkProcess/cache/CacheStorageEngine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoJSTests:
commit-queue@webkit.org [Wed, 23 Aug 2017 17:41:48 +0000 (17:41 +0000)]
JSTests:
Add a micro-benchmark for checking that accessing a variable within a 'with'
block does not automatically prevent type prediction.
https://bugs.webkit.org/show_bug.cgi?id=175738

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-23
Reviewed by Saam Barati.

* stress/with_and_arith.js: Added.
(with):

Source/JavaScriptCore:
Make GetDynamicVar propagate heap predictions instead of saying HeapTop
https://bugs.webkit.org/show_bug.cgi?id=175738

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-23
Reviewed by Saam Barati.

The heap prediction always end up in m_opInfo2. But GetDynamicVar was already storing getPutInfo in there.
So we move that one into m_opInfo. We can do this because it is 32-bit, and the already present identifierNumber
is also 32-bit, so we can pack both in m_opInfo (which is 64 bits).

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::makeDynamicVarOpInfo):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
(JSC::DFG::Node::getPutInfo):
(JSC::DFG::Node::hasHeapPrediction):
* dfg/DFGPredictionPropagationPhase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRace condition in StartWebThread causing crash
utatane.tea@gmail.com [Wed, 23 Aug 2017 17:41:39 +0000 (17:41 +0000)]
Race condition in StartWebThread causing crash
https://bugs.webkit.org/show_bug.cgi?id=175852

Reviewed by Mark Lam.

When starting web thread, the main thread waits for completion of web thread initialization
by using pthread_cond_t. However, the main thread may be woken up due to the existence of
the spurious wake up of pthread_cond_t.

Instead, we should use WTF::Lock and WTF::Condition. Since our StartWebThread already calls
WTF::initializeThreading, it is safe to use WTF::Lock and WTF::Condition. And our WTF::Condition
does not have the spurious wake up problem as described in Condition.h.

* platform/ios/wak/WebCoreThread.mm:
(RunWebThread):
(StartWebThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoMarked imported/w3c/web-platform-tests/html/webappapis/timers/type-long-settimeout...
jlewis3@apple.com [Wed, 23 Aug 2017 17:16:51 +0000 (17:16 +0000)]
Marked imported/w3c/web-platform-tests/html/webappapis/timers/type-long-settimeout.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173780

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoRegression(r221059): NetworkDataTask::didReceiveResponse() should not use PolicyUse...
cdumez@apple.com [Wed, 23 Aug 2017 17:14:09 +0000 (17:14 +0000)]
Regression(r221059): NetworkDataTask::didReceiveResponse() should not use PolicyUse for HTTP/0.9
https://bugs.webkit.org/show_bug.cgi?id=175872

Reviewed by Daniel Bates.

r221059 was calling the ResponseCompletionHandler with {} which ended up being
PolicyUse. Since this is an error case and do not want to receive the data, it
makes more sense to use PolicyIgnore instead. There should not be a behavior
change on WebKit side though since we are cancelling the load right after
calling the completion handler anyway.

Tests under http/tests/security/http-0.9/ are still passing.

* NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::didReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[ESNext] Async iteration - Implement Async Generator - runtime
gskachkov@gmail.com [Wed, 23 Aug 2017 17:05:33 +0000 (17:05 +0000)]
[ESNext] Async iteration - Implement Async Generator - runtime
https://bugs.webkit.org/show_bug.cgi?id=175240

Reviewed by Yusuke Suzuki.

JSTests:

* stress/async-iteration-async-from-sync.js: Added.
(assert):
(const.Logger):
(this.fullfilled):
(this.fullfilledDone):
(this.rejected):
(this.catched):
(this.isFinal):
(_assertLogger):
(const.assertLogger):
(const.getPromise.promiseHolder.return.new.Promise):
(foo):
(async.boo):
(bar):
(async.baz):
(async.goo):
* stress/async-iteration-basic.js: Added.
(assert):
(const.Logger):
(this.fullfilled):
(this.fullfilledDone):
(this.rejected):
(this.catched):
(this.isFinal):
(_assertLogger):
(const.assertLogger):
(const.getPromise.promiseHolder.return.new.Promise):
(async.generator):
(iterator.next.then):
(async.baz):
(async.boo):
(async.foo):
(async.goo):
(A.prototype.async.foo):
(A.prototype.async.boo):
(A):
(asyncGenExp.async):
(async.joo):
(j.next.then):
(then):
(async.koo):
(async.loo):
(async.moo):
(async.noo):
(async.ooo):
(async.roo):
(async.poo):
(async.soo):
(async.too):
* stress/async-iteration-evaluation.js: Added.
(assert):
(async.foo):
(catch):
* stress/async-iteration-syntax.js:
* stress/async-iteration-yield-promise.js: Added.
(assert):
(const.Logger):
(this.fullfilled):
(this.fullfilledDone):
(this.rejected):
(this.catched):
(this.isFinal):
(_assertLogger):
(const.assertLogger):
(const.getPromise.promiseHolder.return.new.Promise):
(async.foo):
(async.boo):
(async.bar):
* stress/async-iteration-yield-star-interface.js: Added.
(assert):
(const.getPromise.promiseHolder.return.new.Promise):
(const.Logger):
(this.fullfilled):
(this.fullfilledDone):
(this.rejected):
(this.catched):
(this.custom):
(this.isFinal):
(_assertLogger):
(const.assertLogger):
(let.asyncIter.Symbol.asyncIterator):
(let.asyncIter.next):
(let.asyncIter.throw):
(let.asyncIter.return):
(async.foo):
(asyncIter.Symbol.asyncIterator):
(asyncIter.next):
(async.boo):
(asyncIter.return):
(async.bar):
(async.baz):
(async.foobar):
* stress/async-iteration-yield-star.js: Added.
(assert):
(const.Logger):
(this.fullfilled):
(this.fullfilledDone):
(this.rejected):
(this.catched):
(this.custom):
(this.isFinal):
(_assertLogger):
(const.assertLogger):
(const.getPromise.promiseHolder.return.new.Promise):
(async.foo):
(async.boo):
(async.bar):
(async.baz):
(async.joo):
(async.goo):
(async.koo):
(async.loo):
(let.asyncIter.Symbol.asyncIterator):
(let.asyncIter.next):
(let.asyncIter.throw):
(let.asyncIter.return):
(async.moo):
(async.noo):
* test262.yaml:

Source/JavaScriptCore:

Current implementation is draft version of Async Iteration.
Link to spec https://tc39.github.io/proposal-async-iteration/

To implement async generator added new states that show reason why async generator was suspended:

The main difference between async function and async generator is that,
async function returns promise but async generator returns
object with methods (next, throw and return) that return promise that
can be resolved with pair of properties value and done.
Async generator functions are similar to generator functions, with the following differences:
whose methods (next, throw, and return) return promises for { value, done },
instead of directly returning { value, done }.
This automatically makes the returned async generator objects async iterators.
  delegation to sync and async iterables

* CMakeLists.txt:
* DerivedSources.make:
* JavaScriptCore.xcodeproj/project.pbxproj:
* builtins/AsyncFromSyncIteratorPrototype.js: Added.
(next.try):
(next):
(return.try):
(return):
(throw.try):
(throw):
(globalPrivate.createAsyncFromSyncIterator):
(globalPrivate.AsyncFromSyncIteratorConstructor):
* builtins/AsyncGeneratorPrototype.js: Added.
(globalPrivate.createAsyncGeneratorQueue):
(globalPrivate.asyncGeneratorQueueIsEmpty):
(globalPrivate.asyncGeneratorQueueCreateItem):
(globalPrivate.asyncGeneratorQueueEnqueue):
(globalPrivate.asyncGeneratorQueueDequeue):
(globalPrivate.asyncGeneratorQueueGetFirstValue):
(globalPrivate.asyncGeneratorDequeue):
(globalPrivate.isExecutionState):
(globalPrivate.isSuspendYieldState):
(globalPrivate.asyncGeneratorReject):
(globalPrivate.asyncGeneratorResolve):
(asyncGeneratorYieldAwaited):
(globalPrivate.asyncGeneratorYield):
(const.onRejected):
(globalPrivate.awaitValue):
(const.onFulfilled):
(globalPrivate.doAsyncGeneratorBodyCall):
(globalPrivate.asyncGeneratorResumeNext.):
(globalPrivate.asyncGeneratorResumeNext):
(globalPrivate.asyncGeneratorEnqueue):
(next):
(return):
(throw):
* builtins/AsyncIteratorPrototype.js: Added.
(symbolAsyncIteratorGetter):
* builtins/BuiltinNames.h:
* bytecode/BytecodeDumper.cpp:
(JSC::BytecodeDumper<Block>::dumpBytecode):
* bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
* bytecode/BytecodeIntrinsicRegistry.h:
* bytecode/BytecodeList.json:
* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCreateAsyncGeneratorQueue):
(JSC::BytecodeGenerator::emitPutAsyncGeneratorFields):
(JSC::BytecodeGenerator::emitNewFunctionExpressionCommon):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitIteratorNextWithValue):
(JSC::BytecodeGenerator::emitIteratorClose):
(JSC::BytecodeGenerator::emitYieldPoint):
(JSC::BytecodeGenerator::emitYield):
(JSC::BytecodeGenerator::emitCallIterator):
(JSC::BytecodeGenerator::emitAwait):
(JSC::BytecodeGenerator::emitGetIterator):
(JSC::BytecodeGenerator::emitGetAsyncIterator):
(JSC::BytecodeGenerator::emitDelegateYield):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::ReturnNode::emitBytecode):
(JSC::FunctionNode::emitBytecode):
(JSC::YieldExprNode::emitBytecode):
(JSC::AwaitExprNode::emitBytecode):
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGClobbersExitState.cpp:
(JSC::DFG::clobbersExitState):
* dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGMayExit.cpp:
* dfg/DFGNode.h:
(JSC::DFG::Node::convertToPhantomNewFunction):
(JSC::DFG::Node::convertToPhantomNewAsyncGeneratorFunction):
(JSC::DFG::Node::hasCellOperand):
(JSC::DFG::Node::isFunctionAllocation):
(JSC::DFG::Node::isPhantomFunctionAllocation):
(JSC::DFG::Node::isPhantomAllocation):
* dfg/DFGNodeType.h:
* dfg/DFGObjectAllocationSinkingPhase.cpp:
* dfg/DFGPredictionPropagationPhase.cpp:
* dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNewFunction):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStoreBarrierInsertionPhase.cpp:
* dfg/DFGValidate.cpp:
* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):
* ftl/FTLOperations.cpp:
(JSC::FTL::operationPopulateObjectInOSR):
(JSC::FTL::operationMaterializeObjectInOSR):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emitNewFuncCommon):
(JSC::JIT::emit_op_new_async_generator_func):
(JSC::JIT::emit_op_new_async_func):
(JSC::JIT::emitNewFuncExprCommon):
(JSC::JIT::emit_op_new_async_generator_func_exp):
* jit/JITOperations.cpp:
* jit/JITOperations.h:
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LLIntSlowPaths.h:
* llint/LowLevelInterpreter.asm:
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createFunctionMetadata):
* runtime/AsyncFromSyncIteratorPrototype.cpp: Added.
(JSC::AsyncFromSyncIteratorPrototype::AsyncFromSyncIteratorPrototype):
(JSC::AsyncFromSyncIteratorPrototype::finishCreation):
(JSC::AsyncFromSyncIteratorPrototype::create):
* runtime/AsyncFromSyncIteratorPrototype.h: Added.
(JSC::AsyncFromSyncIteratorPrototype::createStructure):
* runtime/AsyncGeneratorFunctionConstructor.cpp: Added.
(JSC::AsyncGeneratorFunctionConstructor::AsyncGeneratorFunctionConstructor):
(JSC::AsyncGeneratorFunctionConstructor::finishCreation):
(JSC::callAsyncGeneratorFunctionConstructor):
(JSC::constructAsyncGeneratorFunctionConstructor):
(JSC::AsyncGeneratorFunctionConstructor::getCallData):
(JSC::AsyncGeneratorFunctionConstructor::getConstructData):
* runtime/AsyncGeneratorFunctionConstructor.h: Added.
(JSC::AsyncGeneratorFunctionConstructor::create):
(JSC::AsyncGeneratorFunctionConstructor::createStructure):
* runtime/AsyncGeneratorFunctionPrototype.cpp: Added.
(JSC::AsyncGeneratorFunctionPrototype::AsyncGeneratorFunctionPrototype):
(JSC::AsyncGeneratorFunctionPrototype::finishCreation):
* runtime/AsyncGeneratorFunctionPrototype.h: Added.
(JSC::AsyncGeneratorFunctionPrototype::create):
(JSC::AsyncGeneratorFunctionPrototype::createStructure):
* runtime/AsyncGeneratorPrototype.cpp: Added.
(JSC::AsyncGeneratorPrototype::finishCreation):
* runtime/AsyncGeneratorPrototype.h: Added.
(JSC::AsyncGeneratorPrototype::create):
(JSC::AsyncGeneratorPrototype::createStructure):
(JSC::AsyncGeneratorPrototype::AsyncGeneratorPrototype):
* runtime/AsyncIteratorPrototype.cpp: Added.
(JSC::AsyncIteratorPrototype::finishCreation):
* runtime/AsyncIteratorPrototype.h: Added.
(JSC::AsyncIteratorPrototype::create):
(JSC::AsyncIteratorPrototype::createStructure):
(JSC::AsyncIteratorPrototype::AsyncIteratorPrototype):
* runtime/CommonIdentifiers.h:
* runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
* runtime/FunctionConstructor.h:
* runtime/FunctionExecutable.h:
* runtime/JSAsyncGeneratorFunction.cpp: Added.
(JSC::JSAsyncGeneratorFunction::JSAsyncGeneratorFunction):
(JSC::JSAsyncGeneratorFunction::createImpl):
(JSC::JSAsyncGeneratorFunction::create):
(JSC::JSAsyncGeneratorFunction::createWithInvalidatedReallocationWatchpoint):
* runtime/JSAsyncGeneratorFunction.h: Added.
(JSC::JSAsyncGeneratorFunction::allocationSize):
(JSC::JSAsyncGeneratorFunction::createStructure):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::asyncIteratorPrototype const):
(JSC::JSGlobalObject::asyncGeneratorPrototype const):
(JSC::JSGlobalObject::asyncGeneratorFunctionPrototype const):
(JSC::JSGlobalObject::asyncGeneratorFunctionStructure const):
* runtime/Options.h:

LayoutTests:

* js/Object-getOwnPropertyNames-expected.txt:
* js/script-tests/Object-getOwnPropertyNames.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoAccess expectations path through apple_additions
jbedard@apple.com [Wed, 23 Aug 2017 17:04:25 +0000 (17:04 +0000)]
Access expectations path through apple_additions
https://bugs.webkit.org/show_bug.cgi?id=174800
<rdar://problem/33498899>

Reviewed by Alexey Proskuryakov.

When external test expectations are imported through additional-platform-directory, they will
over-write any WebKit expectations. Access some expectations from apple_additions to correct
these precedence issues.

* Scripts/webkitpy/port/ios.py:
(IOSPort._apple_additions_path): Convert test expectation directory to a path
coming from apple_additions.
(IOSPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
path for layout test expectations.
* Scripts/webkitpy/port/ios_device_unittest.py:
(IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
* Scripts/webkitpy/port/ios_simulator_unittest.py:
(IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
* Scripts/webkitpy/port/mac.py:
(MacPort._apple_additions_path): Convert test expectation directory to a path
coming from apple_additions.
(MacPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
path for layout test expectations.
* Scripts/webkitpy/port/mac_unittest.py:
(MacTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.
* Scripts/webkitpy/port/port_testcase.py:
(bind_mock_apple_additions): Added to create mock apple_additions for a block.
(bind_mock_apple_additions.MockAppleAdditions): Contains apple_addition stubs for testing.
* Scripts/webkitpy/port/win.py:
(WinPort.default_baseline_search_path): Include apple_additions test expectation for Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoFix verbose in tests
jfbastien@apple.com [Wed, 23 Aug 2017 16:28:29 +0000 (16:28 +0000)]
Fix verbose in tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoEnsure media controls host exists before using it
bfulgham@apple.com [Wed, 23 Aug 2017 16:25:21 +0000 (16:25 +0000)]
Ensure media controls host exists before using it
https://bugs.webkit.org/show_bug.cgi?id=175833
<rdar://problem/34001219>

Reviewed by Jer Noble.

Source/WebCore:

Although we ensure that the media controls shadow root exists before updating the text track
container, we don't check that the media controls host has been created yet. We do check
and create in other places in HTMLMediaElement.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateTextTrackDisplay):

LayoutTests:

* media/track/track-display-before-controls-crash-expected.txt: Added.
* media/track/track-display-before-controls-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[Win] Compile error, include file <wtf/AVFoundationHeaderDetection.h> is not found.
pvollan@apple.com [Wed, 23 Aug 2017 16:21:43 +0000 (16:21 +0000)]
[Win] Compile error, include file <wtf/AVFoundationHeaderDetection.h> is not found.
https://bugs.webkit.org/show_bug.cgi?id=175853

Reviewed by Brent Fulgham.

Copy generated WTF header files to the same place as we copy forwarding headers.

* WTF.vcxproj/WTF.proj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[WPE] Some event handlers not working.
clopez@igalia.com [Wed, 23 Aug 2017 15:16:23 +0000 (15:16 +0000)]
[WPE] Some event handlers not working.
https://bugs.webkit.org/show_bug.cgi?id=175864

Reviewed by Michael Catanzaro.

Source/WebCore:

Share the EventHandler implementation with the GTK port and add ifdefs where needed.

Covered by existing tests.

* PlatformGTK.cmake:
* PlatformWPE.cmake:
* page/wpe/EventHandlerWPE.cpp: Removed.
* platform/glib/EventHandlerGlib.cpp: Renamed from Source/WebCore/page/gtk/EventHandlerGtk.cpp.
(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):

LayoutTests:

Remove expected failures for tests that now pass, add new expectation
for a test that is failing also on GTK+ and rebaseline a test with
the same expected result than on GTK+.

* platform/wpe/TestExpectations:
* platform/wpe/fast/events/focus-label-legend-elements-with-tab-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK] Remove some flaky annotations for passing tests.
commit-queue@webkit.org [Wed, 23 Aug 2017 13:02:00 +0000 (13:02 +0000)]
[GTK] Remove some flaky annotations for passing tests.
https://bugs.webkit.org/show_bug.cgi?id=175881

Unreviewed test gardening.

None of these tests have had their alternative status in months.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-23

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed WPE gardening. Unskipping tests under fast/canvas/, adding
zandobersek@gmail.com [Wed, 23 Aug 2017 12:56:27 +0000 (12:56 +0000)]
Unreviewed WPE gardening. Unskipping tests under fast/canvas/, adding
failure expectations for actual failures, and providing port-specific
baselines for tests that require them.

* platform/wpe/TestExpectations:
* platform/wpe/fast/canvas: Added.
* platform/wpe/fast/canvas/canvas-size-change-after-layout-expected.txt: Added.
* platform/wpe/fast/canvas/canvas-zoom-expected.txt: Added.
* platform/wpe/fast/canvas/webgl: Added.
* platform/wpe/fast/canvas/webgl/angle-instanced-arrays-expected.txt: Added.
* platform/wpe/fast/canvas/webgl/angle-instanced-arrays-out-of-bounds-expected.txt: Added.
* platform/wpe/fast/canvas/webgl/css-webkit-canvas-expected.txt: Added.
* platform/wpe/fast/canvas/webgl/css-webkit-canvas-repaint-expected.txt: Added.
* platform/wpe/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
* platform/wpe/fast/canvas/webgl/glsl-conformance-expected.txt: Added.
* platform/wpe/fast/canvas/webgl/oes-texture-half-float-expected.txt: Added.
* platform/wpe/fast/canvas/webgl/webgl-draw-buffers-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GStreamer][GTK][WPE] Move common things to GStreamer cmake files
calvaris@igalia.com [Wed, 23 Aug 2017 12:42:48 +0000 (12:42 +0000)]
[GStreamer][GTK][WPE] Move common things to GStreamer cmake files
https://bugs.webkit.org/show_bug.cgi?id=175625

Three files were created as kind of hooks for the GTK and WPE
CMake option files. The definitions one is to enable, disable and
create the common options (that can be and are actually overriden
in some cases. The dependencies one adds dependencies for the
option switches that are set. The checks one ensure the
dependencies are met depending on the option switches.

Reviewed by Carlos Alberto Lopez Perez.

* Source/cmake/GStreamerChecks.cmake: Added.
* Source/cmake/GStreamerDefinitions.cmake: Added.
* Source/cmake/GStreamerDependencies.cmake: Added.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago[GTK][WPE] Unreviewed test gardening
commit-queue@webkit.org [Wed, 23 Aug 2017 09:17:28 +0000 (09:17 +0000)]
[GTK][WPE] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=175878

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-23

* platform/gtk/TestExpectations:
  - Mark fast/mediastream/captureStream/canvas2d-heavy-drawing.html as flaky.
  - Add crash annotations for cache-storage tests.
* platform/gtk/http/wpt/beacon/beacon-async-error-logging-expected.txt:
  Added: logs a different error message to the console on GTK.
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  Update for the disabling of the CSS Regions code in r220870.
* platform/wpe/js/dom/global-constructors-attributes-expected.txt:
  Update for the disabling of the CSS Regions code in r220870.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoDisable intermittently crashing CSS Regions tests.
commit-queue@webkit.org [Wed, 23 Aug 2017 09:16:18 +0000 (09:16 +0000)]
Disable intermittently crashing CSS Regions tests.
https://bugs.webkit.org/show_bug.cgi?id=135051

Unreviewed test gardening.

They have been failing since the CSS Regions code was disabled in r220870.
That commit also skipped these tests, but the older crash expectation
overrode the skipping.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-23

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years agoUnreviewed. The WPE port should build TestWebKitAPI with the same
zandobersek@gmail.com [Wed, 23 Aug 2017 06:45:42 +0000 (06:45 +0000)]
Unreviewed. The WPE port should build TestWebKitAPI with the same
compiler flags as the GTK+ port, disabling a few flags that are
sprouting a lot of warning output.

* TestWebKitAPI/PlatformWPE.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3 years ago_WKThumbnailView should use the screen color space instead of sRGB
timothy_horton@apple.com [Wed, 23 Aug 2017 04:59:30 +0000 (04:59 +0000)]
_WKThumbnailView should use the screen color space instead of sRGB
https://bugs.webkit.org/show_bug.cgi?id=175858
<rdar://problem/33925559>

Reviewed by Dean Jackson.

Currently, _WKThumbnailView uses software snapshotting via
WebPage's takeSnapshot and friends, which always use sRGB.
However, it is immediately presented in display space, which
causes an expensive color conversion, which could have been avoided
if the snapshot was instead originally taken in display space.

To solve this, add:

- a mechanism allowing ShareableBitmap to be constructed with a
  configuration, which can include a color space as well as the
  existing flags (flipping SupportsAlpha to be IsOpaque instead
  because most callers want alpha)

- a WebImage constructor allowing callers to pass a ShareableBitmap
  configuration through

- a bit in SnapshotOptions for callers to indicate that they
  want to snapshot in the display's color space (repurposed
  from the ExtendedColor bit)

And then make use of that bit in _WKThumbnailView.

* Shared/API/c/WKSharedAPICast.h:
(WebKit::snapshotOptionsFromImageOptions):
Remove this incorrect conversion (WKImageOptions doesn't include
kWKSnapshotOptionsExtendedColor).

(WebKit::toSnapshotOptions):
Plumb kWKSnapshotOptionsExtendedColor to WebKit::SnapshotOptions
as the "UseScreenColorSpace". Leave the SPI name intact because
it has clients, but the difference isn't so huge that it will be
a problem.

* Shared/ImageOptions.h:
(WebKit::snapshotOptionsToImageOptions):
Remove ImageOptionsExtendedColor, and rename
SnapshotOptionsExtendedColor to SnapshotOptionsUseScreenColorSpace.

* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::Handle::Handle):
(WebKit::ShareableBitmap::Handle::encode const):
(WebKit::ShareableBitmap::Handle::decode):
(WebKit::ShareableBitmap::Handle::clear):
(WebKit::ShareableBitmap::Configuration::encode const):
(WebKit::ShareableBitmap::Configuration::decode):
(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
(WebKit::ShareableBitmap::createHandle const):
(WebKit::ShareableBitmap::ShareableBitmap):
(WebKit::ShareableBitmap::calculateBytesPerPixel):
(WebKit::calculateBytesPerPixel): Deleted.
* Shared/ShareableBitmap.h:
(WebKit::ShareableBitmap::numBytesForSize):
(WebKit::ShareableBitmap::sizeInBytes const):
* Shared/cg/ShareableBitmapCG.cpp:
(WebKit::colorSpace):
(WebKit::bitmapInfo):
(WebKit::ShareableBitmap::calculateBytesPerPixel):
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::createCGImage const):
Remove ShareableBitmap's flags parameter, and replace it with
a configuration parameter. Configuration is a struct that currently
encompasses the newly-flipped IsOpaque bit and (on Cocoa platforms)
a platform colorspace object. Compute bytesPerPixel dynamically
based on the colorspace and whether it uses extended colors or not.

* Shared/WebImage.cpp:
(WebKit::WebImage::create):
* Shared/WebImage.h:
Pass ShareableBitmap::Configuration through to the ShareableBitmap
constructor, if provided.

* UIProcess/API/Cocoa/_WKThumbnailView.mm:
(-[_WKThumbnailView requestSnapshot]):
Make use of the new bit, and use the screen's color space.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::snapshotOptionsToBitmapConfiguration):
(WebKit::WebPage::snapshotAtSize):
(WebKit::WebPage::snapshotNode):
If the snapshot option to use the display color space is set,
fill in the colorSpace field in the ShareableBitmap::Configuration
with the screen's color space.

(WebKit::WebPage::drawRectToImage):
* Shared/WebCoreArgumentCoders.cpp:
(IPC::encodeImage):
* Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::ContextMenuContextData):
* Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
* WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::renderedImage):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::snapshot):
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::snapshot):
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::updateBackingStore):
* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap):
(WebKit::convertCGImageToBitmap):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createSelectionSnapshot const):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
Adopt ShareableBitmap::Configuration. Since IsOpaque
defaults to false, all callers who previously constructed
ShareableBitmap with SupportsAlpha now don't have to do anything.

* platform/PlatformScreen.h:
* platform/ios/PlatformScreenIOS.mm:
(WebCore::screenColorSpace):
* platform/mac/PlatformScreenMac.mm:
(WebCore::screenColorSpace):
(WebCore::screenSupportsExtendedColor):
* platform/win/PlatformScreenWin.cpp:
(WebCore::screenColorSpace):
Add screenColorSpace, which returns the active color space for the
given Widget's screen. On Windows, just fall back to sRGB like we usually do.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221068 268f45cc-cd09-0410-ab3c-d52691b4dbfc