WebKit-https.git
8 years ago2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 13 Jun 2011 09:35:30 +0000 (09:35 +0000)]
2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add context menu support for Webkit2
        https://bugs.webkit.org/show_bug.cgi?id=54827

        * platform/ContextMenuItem.h: Add gtkAction().
        * platform/gtk/ContextMenuGtk.cpp:
        (WebCore::ContextMenu::ContextMenu): Implement constructor that
        receives a platform menu.
        (WebCore::ContextMenu::setPlatformDescription): Make sure we don't
        destroy the menu if the new context menu is the current one.
        (WebCore::contextMenuItemVector): Implement this method to return
        the list of menu items in the given context menu, required by WebKit2.
        (WebCore::platformMenuDescription): Implement this method to
        return a platform menu for the given menu items.
        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::createPlatformMenuItemDescription): Helper function to
        create a platform context menu item.
        (WebCore::ContextMenuItem::ContextMenuItem): Use
        createPlatformMenuItemDescription().
        (WebCore::ContextMenuItem::title): Convert the title from UTF-8.
        (WebCore::ContextMenuItem::setTitle): Use gtkAction().
        (WebCore::ContextMenuItem::setSubMenu): Implement setSubMenu()
        that receives a list of items.
        (WebCore::ContextMenuItem::setChecked): Use gtkAction().
        (WebCore::ContextMenuItem::checked): Implement this, required by WebKit2.
        (WebCore::ContextMenuItem::enabled): Ditto.
        (WebCore::ContextMenuItem::setEnabled): Use gtkAction().
        (WebCore::ContextMenuItem::gtkAction): Return the GtkAction
        associated to the context menu item.
2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Add context menu support for Webkit2
        https://bugs.webkit.org/show_bug.cgi?id=54827

        * GNUmakefile.am: Add new files to compilation.
        * UIProcess/API/gtk/PageClientImpl.cpp:
        (WebKit::PageClientImpl::createContextMenuProxy): Create a context
        menu proxy.
        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (globalPointForClientPoint): Function copied from webkit1 to
        convert a point in widget coordinates to global coordinates.
        (popupMenuPositionFunction):
        (webkitWebViewBaseShowContextMenu): Show the given context menu at
        the given position.
        * UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
        * UIProcess/gtk/WebContextMenuProxyGtk.cpp: Added.
        (WebKit::contextMenuItemActivatedCallback):
        (WebKit::WebContextMenuProxyGtk::createGtkMenu):
        (WebKit::WebContextMenuProxyGtk::showContextMenu):
        (WebKit::WebContextMenuProxyGtk::hideContextMenu):
        (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk):
        (WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk):
        * UIProcess/gtk/WebContextMenuProxyGtk.h: Copied from Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBasePrivate.h.
        (WebKit::WebContextMenuProxyGtk::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-13 Keishi Hattori <keishi@webkit.org (:keishi) (c)>
keishi@webkit.org [Mon, 13 Jun 2011 09:03:15 +0000 (09:03 +0000)]
2011-06-13 Keishi Hattori <keishi@webkit.org (:keishi) (c)>

    Fix mistake I made in 88632

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-13 Keishi Hattori <keishi@webkit.org>
keishi@webkit.org [Mon, 13 Jun 2011 09:00:32 +0000 (09:00 +0000)]
2011-06-13  Keishi Hattori  <keishi@webkit.org>

    Sort WebCore.xcodeproj

    Accomplished using sort-Xcode-project-file.

    * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 13 Jun 2011 08:56:53 +0000 (08:56 +0000)]
2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Export an API similar to WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=57820

        * GNUmakefile.am: Add webkitwebviewcommon.h to public header list.
        * webkit/webkitwebview.h: Move declarations common to WebKit2 to
        webkitwebviewcommon.h.
        * webkit/webkitwebviewcommon.h: Added.
2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Export an API similar to WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=57820

        Add first implementation of WebKitWebView, a class with the same
        API than webkit1, that wraps the C API to provide a high level
        WebKit2 API for GTK port.

        * GNUmakefile.am: Add new files to compilation.
        * UIProcess/API/gtk/WebKitWebView.cpp: Added.
        (webkit_web_view_init):
        (webkit_web_view_class_init):
        (webkit_web_view_new):
        (webkit_web_view_load_uri):
        (webkit_web_view_go_back):
        (webkit_web_view_go_forward):
        * UIProcess/API/gtk/WebKitWebView.h: Added.
        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
        (webkitWebViewBaseCreate):
        (webkitWebViewBaseCreateWebPage):
        * UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
        * UIProcess/API/gtk/webkit/webkit.h: Added.
2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Export an API similar to WebKit1
        https://bugs.webkit.org/show_bug.cgi?id=57820

        Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
        code, but linking to libwebkit2gtk.

        * GNUmakefile.am:
        * GtkLauncher/main.c:
        (createBrowser):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 MORITA Hajime <morrita@google.com>
morrita@google.com [Mon, 13 Jun 2011 06:38:38 +0000 (06:38 +0000)]
2011-06-12  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r88625.
        http://trac.webkit.org/changeset/88625
        https://bugs.webkit.org/show_bug.cgi?id=61073

        Breaks SL Webkit2 Tests

        * platform/mac-wk2/Skipped:
2011-06-12  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r88625.
        http://trac.webkit.org/changeset/88625
        https://bugs.webkit.org/show_bug.cgi?id=61073

        Breaks SL Webkit2 Tests

        * WebKit.vcproj/WebKit.sln:
2011-06-12  MORITA Hajime  <morrita@google.com>

        Unreviewed, rolling out r88625.
        http://trac.webkit.org/changeset/88625
        https://bugs.webkit.org/show_bug.cgi?id=61073

        Breaks SL Webkit2 Tests

        * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
        * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
        * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::didClearWindowForFrame):
        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Mon, 13 Jun 2011 06:20:45 +0000 (06:20 +0000)]
2011-06-12  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (full screen video): Watch Again button is obscured after full screen playback ends at Apple trailers page
        https://bugs.webkit.org/show_bug.cgi?id=62507

        No new tests; DRT would have to be modified to delay between receiving exitFullScreenForElement() and calling
        webkitWillExitFullScreenForElement() to be able to test this.

        If the full-screen element is removed, and webkitWillExitFullScreenForElement() is not called before
        fullScreenElementRemoved() returns, then ancestors of the full-screen element will not have their
        containsFullScreenElement property removed.  To protect against this, reset the property by calling
        setContainsFullScreenElementRecursively() from within fullScreenElementRemoved().

        * dom/Document.cpp:
        (WebCore::Document::fullScreenElementRemoved): Added call to setContainsFullScreenElementRecursively.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 13 Jun 2011 05:15:19 +0000 (05:15 +0000)]
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        As requested by Alexey in https://bugs.webkit.org/show_bug.cgi?id=62510.

        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::interruptedForPolicyChangeError):
        * loader/FrameLoaderClient.h:
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::interruptedForPolicyChangeError):
        (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/MainResourceLoader.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::interruptedForPolicyChangeError):
        * src/FrameLoaderClientImpl.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::interruptedForPolicyChangeError):
        * WebCoreSupport/FrameLoaderClientEfl.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::interruptedForPolicyChangeError):
        * WebCoreSupport/FrameLoaderClientGtk.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebCoreSupport/FrameLoaderClientHaiku.cpp:
        (WebCore::FrameLoaderClientHaiku::interruptedForPolicyChangeError):
        * WebCoreSupport/FrameLoaderClientHaiku.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::interruptedForPolicyChangeError):
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
        * WebCoreSupport/FrameLoaderClientQt.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebFrame.cpp:
        (WebFrame::interruptedForPolicyChangeError):
        * WebFrame.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebCoreSupport/FrameLoaderClientWinCE.cpp:
        (WebKit::FrameLoaderClientWinCE::interruptedForPolicyChangeError):
        * WebCoreSupport/FrameLoaderClientWinCE.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebKitSupport/FrameLoaderClientWx.cpp:
        (WebCore::FrameLoaderClientWx::interruptedForPolicyChangeError):
        * WebKitSupport/FrameLoaderClientWx.h:
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
        https://bugs.webkit.org/show_bug.cgi?id=62516

        * WebProcess/WebCoreSupport/WebErrors.h:
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::interruptedForPolicyChangeError):
        * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
        * WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:
        (WebKit::interruptedForPolicyChangeError):
        * WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:
        (WebKit::interruptedForPolicyChangeError):
        * WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:
        (WebKit::interruptedForPolicyChangeError):
        * WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
        (WebKit::interruptedForPolicyChangeError):
        * WebProcess/WebCoreSupport/win/WebErrorsWin.cpp:
        (WebKit::interruptedForPolicyChangeError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Hironori Bono <hbono@chromium.org>
commit-queue@webkit.org [Mon, 13 Jun 2011 04:55:42 +0000 (04:55 +0000)]
2011-06-12  Hironori Bono  <hbono@chromium.org>

        Reviewed by Hajime Morita.

        Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
        https://bugs.webkit.org/show_bug.cgi?id=62526

        This change adds null checks to the following function to prevent crashes
        when calling removeSpellcheckRange() with null:
        HTMLTextAreaElement::removeSpellcheckRange(),
        HTMLInputElement::removeSpellcheckRange(), and
        HTMLDivElement::removeSpellcheckRange().

        * editing/spelling/spellcheck-api-crash-expected.txt: Added.
        * editing/spelling/spellcheck-api-crash.html: Added.
2011-06-12  Hironori Bono  <hbono@chromium.org>

        Reviewed by Hajime Morita.

        Add null checks to HTMLTextAreaElement::removeSpellcheckRange().
        https://bugs.webkit.org/show_bug.cgi?id=62526

        This change adds null checks to the following function to prevent crashes
        when calling removeSpellcheckRange() with null:
        HTMLTextAreaElement::removeSpellcheckRange(),
        HTMLInputElement::removeSpellcheckRange(), and
        HTMLDivElement::removeSpellcheckRange().

        Test: editing/spelling/spellcheck-api-crash.html

        * html/HTMLDivElement.cpp:
        (WebCore::HTMLDivElement::removeSpellcheckRange):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::removeSpellcheckRange):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::removeSpellcheckRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
mahesh.kulkarni@nokia.com [Mon, 13 Jun 2011 04:13:16 +0000 (04:13 +0000)]
2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] LayoutTestController needs setTextDirection implementation
        https://bugs.webkit.org/show_bug.cgi?id=62442

        Implements LayoutController.setTextDirection.

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setTextDirection):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] LayoutTestController needs setTextDirection implementation
        https://bugs.webkit.org/show_bug.cgi?id=62442

        Unskipping fast/html/set-text-direction.html.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Dominic Cooney <dominicc@chromium.org>
dominicc@chromium.org [Mon, 13 Jun 2011 03:05:02 +0000 (03:05 +0000)]
2011-06-12  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Hajime Morita.

        Add window.internals to WebKit2's WebKitTestRunner.
        https://bugs.webkit.org/show_bug.cgi?id=61073

        * platform/mac-wk2/Skipped: unskip fast/harness/internals-object.html
2011-06-12  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Hajime Morita.

        Add window.internals to WebKit2's WebKitTestRunner.
        https://bugs.webkit.org/show_bug.cgi?id=61073

        * WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport
2011-06-12  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Hajime Morita.

        Add window.internals to WebKit2's WebKitTestRunner.
        https://bugs.webkit.org/show_bug.cgi?id=61073

        Test: fast/harness/internals-object.html

        * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
        * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
        * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
        * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 13 Jun 2011 02:17:23 +0000 (02:17 +0000)]
2011-06-12  Adam Barth  <abarth@webkit.org>

        Attempt to fix Qt build.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (drtPrintFrameUserGestureStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 13 Jun 2011 02:05:29 +0000 (02:05 +0000)]
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        DocumentParser::appendBytes should use size_t for length instead of int
        https://bugs.webkit.org/show_bug.cgi?id=62508

        size_t is the proper type for distances in memory, especially on 64 bit
        machines.

        * dom/DecodedDataDocumentParser.cpp:
        (WebCore::DecodedDataDocumentParser::appendBytes):
        * dom/DecodedDataDocumentParser.h:
        * dom/DocumentParser.h:
        * html/ImageDocument.cpp:
        (WebCore::ImageDocumentParser::appendBytes):
        * html/MediaDocument.cpp:
        (WebCore::MediaDocumentParser::appendBytes):
        * html/PluginDocument.cpp:
        (WebCore::PluginDocumentParser::appendBytes):
        * loader/SinkDocument.cpp:
        (WebCore::SinkDocumentParser::appendBytes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 13 Jun 2011 02:03:25 +0000 (02:03 +0000)]
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=62519

        This function is a remnant of the old user gesture design, which
        involved per-frame state stored on FrameLoader.  Now that we're using
        static state, we don't need this function anymore.

        This function used to check whether JavaScript was enabled for the
        top-level frame, but that check doesn't make any sense (like much of
        the old user gesture code).

        * WebCore.exp.in:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::processingUserGesture):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::submitForm):
        * loader/FrameLoader.h:
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::click):
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=62519

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::isProcessingUserGesture):
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=62519

        * WebView/WebView.mm:
        (-[WebView _isProcessingUserGesture]):
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=62519

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (drtPrintFrameUserGestureStatus):
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove FrameLoader::isProcessingUserGesture
        https://bugs.webkit.org/show_bug.cgi?id=62519

        Instead of asking the gesture indicator directly, ask the
        ScriptController, like everyone else.  The gesture indicator is just
        one of the piece of information we use to determine whether we're
        processing a user gesture.

        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::isProcessingUserGesture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Sun, 12 Jun 2011 23:34:10 +0000 (23:34 +0000)]
2011-06-12  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Remove webkit_web_view_get_selected_text
        https://bugs.webkit.org/show_bug.cgi?id=62512

        It's no longer used and it's a private method, so it can be
        removed.

        * webkit/webkitwebview.cpp: kill it.
        * webkit/webkitwebviewprivate.h: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sun, 12 Jun 2011 21:24:09 +0000 (21:24 +0000)]
2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r88616.
        http://trac.webkit.org/changeset/88616
        https://bugs.webkit.org/show_bug.cgi?id=62517

        It broke editing/text-iterator/findString.html (Requested by
        tonikitoo on #webkit).

        * platform/qt/Skipped:
2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r88616.
        http://trac.webkit.org/changeset/88616
        https://bugs.webkit.org/show_bug.cgi?id=62517

        It broke editing/text-iterator/findString.html (Requested by
        tonikitoo on #webkit).

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 12 Jun 2011 20:01:41 +0000 (20:01 +0000)]
2011-06-12  Adam Barth  <abarth@webkit.org>

        Fix fullscreen/full-screen-iframe-legacy.html.

        * html/HTMLVideoElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 12 Jun 2011 19:21:49 +0000 (19:21 +0000)]
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Remove trival "forward-to-client" member functions from FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=62510

        Update to call the FrameLoaderClient directly.  Also, remove cargo-cult
        code that checks whether FrameLoader is null.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_stop_loading):
        (webkit_web_view_can_show_mime_type):
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Remove trival "forward-to-client" member functions from FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=62510

        * WebCoreSupport/WebFrameNetworkingContext.cpp:
        (WebFrameNetworkingContext::blockedError):
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Remove trival "forward-to-client" member functions from FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=62510

        * WebCoreSupport/WebFrameNetworkingContext.mm:
        (WebFrameNetworkingContext::blockedError):
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Remove trival "forward-to-client" member functions from FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=62510

        Originally, FrameLoader was supposed to abstract FrameLoaderClient, but
        we lost that battle log ago.  Nowadays, it's easier if folks just call
        into FrameLoaderClient directly.  Many of these functions have direct
        callers already anyway.

        * WebCore.exp.in:
        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::createRenderer):
        (WebCore::HTMLMediaElement::attach):
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::setRequest):
        (WebCore::DocumentLoader::setMainDocumentError):
        (WebCore::DocumentLoader::setupForReplaceByMIMEType):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::didFirstLayout):
        * loader/FrameLoader.h:
            - cancelledError is slightly more delicate, so I'm going to move it in
              a separate patch.
        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::interruptForPolicyChangeError):
        (WebCore::MainResourceLoader::stopLoadingForPolicyChange):
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        (WebCore::MainResourceLoader::handleEmptyLoad):
        (WebCore::MainResourceLoader::loadNow):
        * loader/MainResourceLoader.h:
        * loader/NetscapePlugInStreamLoader.cpp:
        (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
        * loader/PingLoader.cpp:
        (WebCore::PingLoader::PingLoader):
        * loader/PolicyChecker.cpp:
        (WebCore::PolicyChecker::continueAfterNavigationPolicy):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::blockedError):
        (WebCore::ResourceLoader::cannotShowURLError):
        (WebCore::ResourceLoader::shouldUseCredentialStorage):
        (WebCore::ResourceLoader::canAuthenticateAgainstProtectionSpace):
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::populate):
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Remove trival "forward-to-client" member functions from FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=62510

        * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
        (WebKit::WebFrameNetworkingContext::blockedError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9513180> REGRESSION (r84166): recalcStyle for display:inline to displ...
mitz@apple.com [Sun, 12 Jun 2011 18:27:00 +0000 (18:27 +0000)]
<rdar://problem/9513180> REGRESSION (r84166): recalcStyle for display:inline to display:none transition has complexity N^2 where N is the number of child Text nodes
https://bugs.webkit.org/show_bug.cgi?id=61557

Reviewed by Darin Adler.

Replaced the fix for bug 58500 with a refined version.

* rendering/RenderText.cpp:
(WebCore::RenderText::clippedOverflowRectForRepaint): Use the containing block unless it is
across a layer boundary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] LayoutTestController needs setTextDirection implementation
mahesh.kulkarni@nokia.com [Sun, 12 Jun 2011 17:23:28 +0000 (17:23 +0000)]
[Qt] LayoutTestController needs setTextDirection implementation
https://bugs.webkit.org/show_bug.cgi?id=62442

Reviewed by Antonio Gomes.

Tools:

Implements LayoutController.setTextDirection.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::setTextDirection):
* DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests:

Unskipping fast/html/set-text-direction.html.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 12 Jun 2011 16:57:54 +0000 (16:57 +0000)]
2011-06-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Andreas Kling.

        Minor user-gesture related cleanup
        https://bugs.webkit.org/show_bug.cgi?id=62511

        In reading the user gesture code, I noticed that these lines of code
        should be deleted because they don't do anything.

        * bindings/v8/NPV8Object.cpp:
        * html/HTMLAnchorElement.cpp:
        * html/HTMLVideoElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Sun, 12 Jun 2011 14:52:55 +0000 (14:52 +0000)]
2011-06-12  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed. Build fix for !ENABLE(JIT) after r88604.

        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::visitAggregate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-11 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sun, 12 Jun 2011 12:40:40 +0000 (12:40 +0000)]
2011-06-11  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Add TextRun charactersLength member
        https://bugs.webkit.org/show_bug.cgi?id=62501

        Preparation patch 2: Propagate the maximum length of the characters buffer the TextRun operates on, even when we're only measuring a substring.
        For example: In RenderText when we're measuring 'len' characters starting from "text()->characters() + start", there's a portion
        of "textLength() - start" characters that we're not processing. In order to support ligatures when integrating SVG Fonts
        within the GlyphPage concept, we need this extra information, to lookup ligatures even when single chars are measured.
        If a font defines an eg "ffl" ligature, and we're measuring the "f" of "ffl", it shall looukp the "ffl" glyph from the font,
        and skip the next two characters (this will be done in WidthIterator).

        This doesn't yet affect any test, the new SVG Fonts code is not merged yet, this is the preparaion patch 2.

        * platform/graphics/Font.h: Add yet-unused "const TextRun&" parameter to drawGlyphBuffer/drawEmphasisMarks.
        * platform/graphics/FontFastPath.cpp: Ditto. This parameter will be used to looukp the TextRunRenderingContext in a follow-up patch.
        (WebCore::Font::drawSimpleText):
        (WebCore::Font::drawEmphasisMarksForSimpleText):
        (WebCore::Font::drawGlyphBuffer):
        (WebCore::Font::drawEmphasisMarks):
        * platform/graphics/TextRun.h: Add "int m_charactersLength", similar to "int m_len". It denotes the maximum length of the characters buffer
                                       that we're holding. It defaults to the passed "len" value, but is overriden by explicit setCharactersLength calls.
        (WebCore::TextRun::TextRun):
        (WebCore::TextRun::charactersLength):
        (WebCore::TextRun::setCharactersLength):
        * platform/graphics/mac/FontComplexTextMac.cpp: Pass TextRun do drawGlyphBuffer/drawEmphasisMarks.
        (WebCore::Font::drawComplexText):
        (WebCore::Font::drawEmphasisMarksForComplexText):
        * platform/graphics/win/FontWin.cpp: Ditto.
        (WebCore::Font::drawComplexText):
        (WebCore::Font::drawEmphasisMarksForComplexText):
        * platform/graphics/wx/FontWx.cpp: Ditto.
        (WebCore::Font::drawComplexText):
        (WebCore::Font::drawEmphasisMarksForComplexText):
        * rendering/InlineTextBox.cpp: Call setCharactersLength on the processed TextRun.
        (WebCore::InlineTextBox::constructTextRun):
        * rendering/RenderBlockLineLayout.cpp: Ditto.
        (WebCore::textWidth):
        (WebCore::tryHyphenating):
        * rendering/RenderText.cpp: Ditto.
        (WebCore::RenderText::widthFromCache):
        (WebCore::RenderText::computePreferredLogicalWidths):
        (WebCore::RenderText::width):
        * rendering/svg/SVGInlineTextBox.cpp: Ditto.
        (WebCore::SVGInlineTextBox::constructTextRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-12 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 12 Jun 2011 11:51:45 +0000 (11:51 +0000)]
2011-06-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix methods.html and methods-lower-case.html
        https://bugs.webkit.org/show_bug.cgi?id=62221

        Our expectations for the unskipped tests have the following differences from the mac
        platform:
          - POST requests with no data get a default Content-Type of 'application/octet-stream' in
            Qt 4.8 and 'application/x-www-form-urlencoded' in Qt 4.7.3.
            This is Qt-defined behaviour in QNetworkAccessManager (see QHttpNetworkRequestPrivate::header
            in qhttpnetworkrequest.cpp)
          - DELETE and HEAD requests get their ContentType and ContentLength headers (if present) removed
            by QNetworkReplyHandler. QtWebKit does not send data for either of these request types.

        * platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Added.
        * platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
        * platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
        * platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
        * platform/qt/Skipped: Unskip: http/tests/xmlhttprequest/methods.html
                                       http/tests/xmlhttprequest/methods-lower-case.html
                                       http/tests/xmlhttprequest/workers/methods-async.html
                                       http/tests/xmlhttprequest/workers/methods.html
                                       http/tests/xmlhttprequest/workers/shared-worker-methods-async.html
        * platform/qt/http/tests/xmlhttprequest/methods-expected.txt: Added.
        * platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Added.
        * platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt: Added.
        * platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Added.
2011-06-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Fix methods.html and methods-lower-case.html
        https://bugs.webkit.org/show_bug.cgi?id=62221

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::clearContentsHeaders): Refactor code from sendNetworkRequest
        (WebCore::QNetworkReplyHandler::getIODevice): ditto
        (WebCore::QNetworkReplyHandler::sendNetworkRequest):
            - Remove ContentType and ContentLength headers from GET, DELETE and HEAD requests since
              we do not send data with any of these requests.
            - If a custom HTTP operation contains data, send it.
        * platform/network/qt/QNetworkReplyHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-11 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Sun, 12 Jun 2011 06:01:25 +0000 (06:01 +0000)]
2011-06-11  Michael Saboff  <msaboff@apple.com>

        Reviewed by James Robinson.

        REGRESSION(88260): 10-50% performance regression across many page cyclers
        https://bugs.webkit.org/show_bug.cgi?id=62349

        Made CHROMIUM platform specific values for cMaxInactiveFontData and
        cTargetInactiveFontData to mitigate the current performance issue on Chromium
        page cycler tests.  Made the chromium value for cMaxInactiveFontData 250 based
        on recommendation from James Robinson.  Changed cTargetInactiveFontData to 200
        so that 50 inactive fonts will be cleaned up at a time.

        Change made to address existing Chromium performance test regression.

        * platform/graphics/FontCache.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 12 Jun 2011 04:19:39 +0000 (04:19 +0000)]
2011-06-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Remove unnecessary strlen from DocumentWriter
        https://bugs.webkit.org/show_bug.cgi?id=62505

        This ugly piece of code appears not to be needed.  Rejoice.

        * WebCore.exp.in:
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::commitData):
        * loader/DocumentLoader.h:
        * loader/DocumentWriter.cpp:
        (WebCore::DocumentWriter::addData):
        * loader/DocumentWriter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-11 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 12 Jun 2011 00:51:11 +0000 (00:51 +0000)]
2011-06-11  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        DocumentParser::appendBytes shouldn't have a "flush" boolean parameter
        https://bugs.webkit.org/show_bug.cgi?id=62499

        This patch removes the "flush" Boolean parameter from
        DocumentParser::appendBytes in favor of a new flush method.  This makes
        some code in DocumentWriter look less ridiculous.

        There's still lots of on contorting to do here, but it's a start.

        * dom/DecodedDataDocumentParser.cpp:
        (WebCore::DecodedDataDocumentParser::appendBytes):
        (WebCore::DecodedDataDocumentParser::flush):
        * dom/DecodedDataDocumentParser.h:
        * dom/DocumentParser.h:
        * dom/RawDataDocumentParser.h:
        (WebCore::RawDataDocumentParser::flush):
        * html/ImageDocument.cpp:
        (WebCore::ImageDocumentParser::appendBytes):
        * html/MediaDocument.cpp:
        (WebCore::MediaDocumentParser::appendBytes):
        * html/PluginDocument.cpp:
        (WebCore::PluginDocumentParser::appendBytes):
        * loader/DocumentWriter.cpp:
        (WebCore::DocumentWriter::reportDataReceived):
        (WebCore::DocumentWriter::addData):
        (WebCore::DocumentWriter::endIfNotLoadingMainResource):
        * loader/DocumentWriter.h:
        * loader/SinkDocument.cpp:
        (WebCore::SinkDocumentParser::appendBytes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-11 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Jun 2011 20:34:42 +0000 (20:34 +0000)]
2011-06-11  Ryosuke Niwa  <rniwa@webkit.org>

        Chromium rebaseline after r85560.

        Also update test expectation for svg/W3C-SVG-1.1/text-intro-05-t.svg
        because it has been passing on Mac.

        * platform/chromium-linux/fast/forms/input-placeholder-text-indent-expected.png: Added.
        * platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.png: Added.
        * platform/chromium-win/fast/forms/input-placeholder-text-indent-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=62480
slewis@apple.com [Sat, 11 Jun 2011 20:28:54 +0000 (20:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=62480
part of <rdar://problem/8675177>
Add API to launch the WebProcess.  Launching it earlier can save time
when loading the first page.

Reviewed by Sam Weinig.

* UIProcess/API/C/WKContext.cpp:
(WKContextWarmInitialProcess):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::warmInitialProcess):
* UIProcess/WebContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 11 Jun 2011 20:21:55 +0000 (20:21 +0000)]
2011-06-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r88569.
        http://trac.webkit.org/changeset/88569
        https://bugs.webkit.org/show_bug.cgi?id=62398

        Broke Chromium browser test:
        IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

        * storage/indexeddb/database-name-undefined-expected.txt: Removed.
        * storage/indexeddb/database-name-undefined.html: Removed.
2011-06-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r88569.
        http://trac.webkit.org/changeset/88569
        https://bugs.webkit.org/show_bug.cgi?id=62398

        Broke Chromium browser test:
        IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

        * storage/IDBFactory.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=16777
barraclough@apple.com [Sat, 11 Jun 2011 20:16:46 +0000 (20:16 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=16777

Reviewed by Darin Adler.

Remove #define NaN per Darin's comments.

* runtime/JSGlobalObjectFunctions.cpp:
(JSC::parseIntOverflow):
(JSC::parseInt):
(JSC::jsStrDecimalLiteral):
(JSC::jsToNumber):
(JSC::parseFloat):
* wtf/DateMath.cpp:
(WTF::equivalentYearForDST):
(WTF::parseES5DateFromNullTerminatedCharacters):
(WTF::parseDateFromNullTerminatedCharacters):
(WTF::timeClip):
(JSC::parseDateFromNullTerminatedCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=62503
barraclough@apple.com [Sat, 11 Jun 2011 20:07:48 +0000 (20:07 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=62503
Remove JIT_OPTIMIZE_* switches

Rubber stamped by Geoff Garen.

The alternative code paths are untested, and not well maintained.
These were useful when there was more churn in the JIT, but now
are a maintenance overhead. Time to move on, removing.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
(JSC::JIT::linkConstruct):
* jit/JIT.h:
* jit/JITCall.cpp:
* jit/JITCall32_64.cpp:
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::softModulo):
* jit/JITPropertyAccess.cpp:
* jit/JITPropertyAccess32_64.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 11 Jun 2011 18:09:14 +0000 (18:09 +0000)]
2011-06-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove expectation of failure after clobber.
        https://bugs.webkit.org/show_bug.cgi?id=62364

        * platform/chromium/test_expectations.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-11 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 11 Jun 2011 17:12:52 +0000 (17:12 +0000)]
2011-06-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r88565.
        http://trac.webkit.org/changeset/88565
        https://bugs.webkit.org/show_bug.cgi?id=62401

        Broke Chromium browser test:
        IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

        * storage/indexeddb/setVersion-undefined-expected.txt: Removed.
        * storage/indexeddb/setVersion-undefined.html: Removed.
2011-06-11  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, rolling out r88565.
        http://trac.webkit.org/changeset/88565
        https://bugs.webkit.org/show_bug.cgi?id=62401

        Broke Chromium browser test:
        IndexedDBBrowserTestWithGCExposed.DatabaseCallbacksTest

        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::setVersion):
        * storage/IDBDatabase.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Sat, 11 Jun 2011 16:37:59 +0000 (16:37 +0000)]
2011-06-10  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Null parent element sheet pointers in CSSMutableStyleDeclaration consumers
        when removed from document, set them when reinserted into document.
        https://bugs.webkit.org/show_bug.cgi?id=62230

        When a HTMLBodyElement, StyledElement are removed from document,
        we didn't clear out the parent pointers from their link, style declarations.
        These parent pointers pointed to the document's element sheet which will
        get removed when document is getting destroyed. It does make sense to
        clear out parent pointers when we are getting removed from document and
        readd them when we get inserted again.

        Tests: fast/dom/body-link-decl-parent-crash.html
               fast/dom/styled-inline-style-decl-parent-crash.html

        * dom/StyledElement.cpp:
        (WebCore::StyledElement::insertedIntoDocument):
        (WebCore::StyledElement::removedFromDocument):
        * dom/StyledElement.h:
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute):
        (WebCore::HTMLBodyElement::insertedIntoDocument):
        (WebCore::HTMLBodyElement::removedFromDocument):
        (WebCore::HTMLBodyElement::didMoveToNewOwnerDocument):
        * html/HTMLBodyElement.h:
2011-06-10  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Simon Fraser.

        Tests that accessing the parent element sheet of an inline style, link
        declaration of styled, body elements which are removed from document,
        does not result in crash.
        https://bugs.webkit.org/show_bug.cgi?id=62230

        * fast/dom/body-link-decl-parent-crash-expected.txt: Added.
        * fast/dom/body-link-decl-parent-crash.html: Added.
        * fast/dom/styled-inline-style-decl-parent-crash-expected.txt: Added.
        * fast/dom/styled-inline-style-decl-parent-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 11 Jun 2011 06:45:02 +0000 (06:45 +0000)]
2011-06-10  Adam Barth  <abarth@webkit.org>

        Remove bogus ASSERTs.  These ASSERTs used to be correct before I
        changed DocumentWriter to put the onus for ignoring empty writes onto
        the parser.

        This patch should stop these test from triggering ASSERTs:

        plugins/plugin-document-back-forward.html
        plugins/return-error-from-new-stream-callback-in-full-frame-plugin.html
        userscripts/user-script-plugin-document.html

        * html/MediaDocument.cpp:
        (WebCore::MediaDocumentParser::appendBytes):
        * html/PluginDocument.cpp:
        (WebCore::PluginDocumentParser::appendBytes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sat, 11 Jun 2011 06:23:20 +0000 (06:23 +0000)]
2011-06-09  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        AVPlayerLayer is adding a "fade" animation during Safari full-screen
        https://bugs.webkit.org/show_bug.cgi?id=62433

        CoreAnimation will add default animations when certain properties are changed, unless
        those changes are wrapped in a CATransaction which has had its disableActions property set
        to true.  Wrap each of these three property changes in a CATransaction and disable its actions,
        so that the default "fade" animation is not created in response.

        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController enterFullScreen:]): Wrap with CATransaction.
        (-[WKFullScreenWindowController _swapView:with:]): Ditto:
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Jun 2011 06:04:28 +0000 (06:04 +0000)]
2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: 'images' links on results.html don't work
        https://bugs.webkit.org/show_bug.cgi?id=62194

        Use relative path when generating images-diffs.html

        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
        Added _output_testname.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Jun 2011 05:52:29 +0000 (05:52 +0000)]
2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>

        Skip inspector/profiler/cpu-profiler-profiling-without-inspector.html and
        svg/custom/focus-event-handling-keyboard.html on Mac WebKit2
        because they use DRT features not supported by WebKitTestRunner.

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Jun 2011 04:56:12 +0000 (04:56 +0000)]
2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>

        GTK and Qt rebaselines after r88555.

        * platform/gtk/svg/custom/focus-ring-expected.txt:
        * platform/qt/svg/custom/focus-ring-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 James Robinson <jamesr@chromium.org>
jamesr@google.com [Sat, 11 Jun 2011 04:53:36 +0000 (04:53 +0000)]
2011-06-10  James Robinson  <jamesr@chromium.org>

        [chromium] Update chromium gpu baselines

        * platform/chromium-gpu-linux/compositing/flat-with-transformed-child-expected.png: Removed.
        * platform/chromium-gpu-linux/compositing/geometry/clip-expected.txt: Removed.
        * platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.png: Removed.
        * platform/chromium-gpu-linux/compositing/geometry/repaint-foreground-layer-expected.png: Removed.
        * platform/chromium-gpu-linux/compositing/iframes/iframe-content-flipping-expected.png: Removed.
        * platform/chromium-gpu-linux/compositing/overflow/zero-size-overflow-expected.png: Removed.
        * platform/chromium-gpu-linux/compositing/reflections/backface-hidden-reflection-expected.png: Removed.
        * platform/chromium-gpu-linux/compositing/repaint/content-into-overflow-expected.png: Removed.
        * platform/chromium-gpu-linux/compositing/repaint/overflow-into-content-expected.png: Removed.
        * platform/chromium-gpu-win/compositing/geometry/clip-expected.txt: Removed.
        * platform/chromium-gpu-win/compositing/geometry/fixed-in-composited-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/foreground-layer-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
        * platform/chromium-gpu-win/compositing/overflow/clip-descendents-expected.txt:
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed-expected.png:
        * platform/chromium-gpu-win/compositing/reflections/nested-reflection-transformed2-expected.png:
        * platform/chromium-gpu-win/compositing/reflections/reflection-in-composited-expected.png:
        * platform/chromium-gpu-win/compositing/reflections/reflection-on-composited-expected.png:
        * platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png:
        * platform/chromium-gpu-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
        * platform/chromium-gpu-win/compositing/tiling/huge-layer-expected.txt:
        * platform/chromium-gpu-win/compositing/tiling/huge-layer-resize-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Jun 2011 04:35:30 +0000 (04:35 +0000)]
2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>

        Windows and Chromium rebaselines after r88592. Apparently, some tests are failing on Windows.

        * platform/chromium/fast/harness/results-expected.txt:
        * platform/win/fast/harness/results-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Jun 2011 04:14:26 +0000 (04:14 +0000)]
2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>

        Add fail expectation to fast/dom/navigator-detached-no-crash.htm on Chromium Mac
        because it has been failing on the bot; the failure is tracked by the bug 62364.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Sat, 11 Jun 2011 04:05:53 +0000 (04:05 +0000)]
2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Ojan Vafai.

        new-run-webkit-tests: results.html don't list the same list of failed tests as bots do
        https://bugs.webkit.org/show_bug.cgi?id=62425

        Fixed the bug by hiding expected crash, timeout, pass, etc... by default.

        * fast/harness/resources/results-test.js:
        * fast/harness/results-expected.txt:
        * fast/harness/results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sat, 11 Jun 2011 03:36:15 +0000 (03:36 +0000)]
2011-06-10  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        REGRESSION: End of apple.com video in full-screen mode leads to unusable page.
        https://bugs.webkit.org/show_bug.cgi?id=62411

        * fullscreen/full-screen-remove-ancestor-after-expected.txt: Added.
        * fullscreen/full-screen-remove-ancestor-after.html: Added.
        * platform/mac/fullscreen/full-screen-remove-ancestor-after-expected.png: Added.
2011-06-09  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        REGRESSION: End of apple.com video in full-screen mode leads to unusable page.
        https://bugs.webkit.org/show_bug.cgi?id=62411

        Test: fullscreen/full-screen-remove-ancestor-after.html

        The placeholder for RenderFullScreen was being created as a non-anonymous object, which led
        to the document's renderer being set to 0 when the placeholder was removed due to its parent
        being removed. Setting the placeholder to be anonymous, however, means that it will be
        coalesced with sibling anonymous blocks, so added the RenderFullScreenPlaceholder to the
        list of anonymous objects that are not considered anonymous blocks, to avoid the placeholder
        being so coalesced. To do so, made the placeholder object a true subclass, and add and
        override its destroy() function to notify the RenderFullScreen object that it has been
        destroyed.

        * rendering/RenderFullScreen.cpp:
        (RenderFullScreenPlaceholder::RenderFullScreenPlaceholder): Added.
        (RenderFullScreenPlaceholder::~RenderFullScreenPlaceholder): Added.
        (RenderFullScreenPlaceholder::isRenderFullScreenPlaceholder): Added.
        (RenderFullScreenPlaceholder::destroy): Notify the owner renderer that its placeholder
            has been destroyed.
        (RenderFullScreen::destroy): Assert that the m_placeholder ivar is 0 after destroying it.
        (RenderFullScreen::setPlaceholder): Added.
        (RenderFullScreen::createPlaceholder): Do not make the placeholder anonymous.
        * rendering/RenderFullScreen.h:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isRenderFullScreenPlaceholder): Added.
        (WebCore::RenderObject::isAnonymousBlock): Added the placeholder class to the list of
            objects which are not anonymous blocks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 James Robinson <jamesr@chromium.org>
jamesr@google.com [Sat, 11 Jun 2011 02:51:59 +0000 (02:51 +0000)]
2011-06-10  James Robinson  <jamesr@chromium.org>

        [chromium] Update chromium compositor baselines for r88580

        * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/clip-expected.txt: Added.
        * platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/foreground-layer-expected.txt: Added.
        * platform/chromium-gpu-linux/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
        * platform/chromium-gpu-linux/compositing/overflow/clip-descendents-expected.txt: Added.
        * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed-expected.png:
        * platform/chromium-gpu-linux/compositing/reflections/nested-reflection-transformed2-expected.png:
        * platform/chromium-gpu-linux/compositing/reflections/reflection-in-composited-expected.png:
        * platform/chromium-gpu-linux/compositing/reflections/reflection-on-composited-expected.png:
        * platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png:
        * platform/chromium-gpu-linux/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
        * platform/chromium-gpu-linux/compositing/tiling/huge-layer-expected.txt: Added.
        * platform/chromium-gpu-linux/compositing/tiling/huge-layer-resize-expected.txt: Added.
        * platform/chromium-gpu-mac/compositing/geometry/foreground-layer-expected.txt: Added.
        * platform/chromium-gpu-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed-expected.png:
        * platform/chromium-gpu-mac/compositing/reflections/nested-reflection-transformed2-expected.png:
        * platform/chromium-gpu-mac/compositing/reflections/reflection-in-composited-expected.png:
        * platform/chromium-gpu-mac/compositing/reflections/reflection-on-composited-expected.png:
        * platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png:
        * platform/chromium-gpu-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
        * platform/chromium-gpu-mac/compositing/tiling/huge-layer-expected.txt: Added.
        * platform/chromium-gpu-mac/compositing/tiling/huge-layer-resize-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Lucas Forschler <lforschler@apple.com>
lforschler@apple.com [Sat, 11 Jun 2011 02:06:42 +0000 (02:06 +0000)]
2011-06-10  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Stephanie Lewis.

        Script to kill old processes on Mac.
        This matches the windows version.
        https://bugs.webkit.org/show_bug.cgi?id=62479

        * BuildSlaveSupport/mac: Added.
        * BuildSlaveSupport/mac/kill-old-processes: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 11 Jun 2011 02:04:32 +0000 (02:04 +0000)]
2011-06-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        REGRESSION (WebKit2): window.showModalDialog() broken
        https://bugs.webkit.org/show_bug.cgi?id=62496
        <rdar://problem/9581492>

        If dispatching a message ends up creating a nested run loop, some incoming messages can end up not being
        delivered until we exit from the run loop.

        Fix this by using a Deque instead of a Vector for incoming messages, and get one message at a time and then
        dispatch it. That prevents us from having any lingering messages lying around in stack allocated space.

        * Platform/CoreIPC/Connection.cpp:
        (CoreIPC::Connection::waitForMessage):
        (CoreIPC::Connection::dispatchMessages):
        * Platform/CoreIPC/Connection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=16777
barraclough@apple.com [Sat, 11 Jun 2011 02:03:00 +0000 (02:03 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=16777
Eliminate JSC::NaN and JSC::Inf

Reviewed by Sam Weinig.

There's no good reason for -K-J-S- JSC to have its own NAN and infinity constants.
The ones in std::numeric_limits are perfectly good.
Remove JSC::Inf, JSC::NaN, switch some cases of (isnan || isinf) to !isfinite.

Source/JavaScriptCore:

* API/JSCallbackObjectFunctions.h:
(JSC::::toNumber):
* API/JSValueRef.cpp:
(JSValueMakeNumber):
(JSValueToNumber):
* JavaScriptCore.exp:
* runtime/CachedTranscendentalFunction.h:
(JSC::CachedTranscendentalFunction::initialize):
* runtime/DateConstructor.cpp:
(JSC::constructDate):
* runtime/DateInstanceCache.h:
(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):
* runtime/JSCell.cpp:
* runtime/JSCell.h:
(JSC::JSCell::JSValue::getPrimitiveNumber):
(JSC::JSCell::JSValue::toNumber):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::resetDateCache):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseInt):
(JSC::globalFuncIsFinite):
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::toNumber):
* runtime/JSValue.cpp:
* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:
(JSC::jsNaN):
* runtime/MathObject.cpp:
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
* runtime/NumberConstructor.cpp:
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):
* runtime/UString.cpp:
* wtf/DecimalNumber.h:
(WTF::DecimalNumber::DecimalNumber):
* wtf/dtoa.cpp:
(WTF::dtoa):

Source/WebCore:

* bindings/js/JSDataViewCustom.cpp:
(WebCore::getDataViewMember):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Sat, 11 Jun 2011 01:56:26 +0000 (01:56 +0000)]
2011-06-10  James Simonsen  <simonjam@chromium.org>

        Unreviewed, missing expectations for non-V8 from change 88584.
        https://bugs.webkit.org/show_bug.cgi?id=62412

        * html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 11 Jun 2011 01:18:43 +0000 (01:18 +0000)]
2011-06-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Unresponsive cursor is shown when displaying a modal dialog
        Part of <rdar://problem/9581492>
        https://bugs.webkit.org/show_bug.cgi?id=62494

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::runModal):
        * UIProcess/WebPageProxy.h:
        Stop the responsiveness timer when calling out to show a modal dialog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Sat, 11 Jun 2011 01:08:09 +0000 (01:08 +0000)]
2011-06-10  James Simonsen  <simonjam@chromium.org>

        Reviewed by Eric Seidel.

        <script> inside <svg> should be executed
        https://bugs.webkit.org/show_bug.cgi?id=62412

        * platform/chromium/html5lib/runner-expected.txt: Passes another test.
        * svg/dom/range-delete-expected.txt: Removed.
        * svg/dom/range-delete.html: Removed.
        * svg/dom/use-style-recalc-script-execute-crash-expected.txt: Now expected to execute script (and not crash).
        * svg/dom/use-style-recalc-script-execute-crash.html:
        * svg/in-html/resources/external.js: Added.
        * svg/in-html/script-expected.txt: Added.
        * svg/in-html/script-external-expected.txt: Added.
        * svg/in-html/script-external.html: Added.
        * svg/in-html/script-nested-expected.txt: Added.
        * svg/in-html/script-nested.html: Added.
        * svg/in-html/script-write-expected.txt: Added.
        * svg/in-html/script-write.html: Added.
        * svg/in-html/script.html: Added.
2011-06-10  James Simonsen  <simonjam@chromium.org>

        Reviewed by Eric Seidel.

        <script> inside <svg> should be executed
        https://bugs.webkit.org/show_bug.cgi?id=62412

        Tests: svg/in-html/script-external.html
               svg/in-html/script-nested.html
               svg/in-html/script-write.html
               svg/in-html/script.html

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processEndTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 11 Jun 2011 00:56:13 +0000 (00:56 +0000)]
2011-06-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Script-created parsers should ignore data from the network
        https://bugs.webkit.org/show_bug.cgi?id=62336

        Triggering this condition is very hard to do deterministically.  This
        test attempts to trigger the condition by sending exactly the right
        number of bytes for the Chromium network stack.  As network stacks vary
        and evolve, it's likely we'll lose test coverage for this issue, but
        this is the best test I could come up with.

        * fast/parser/document-write-ignores-later-network-bytes-expected.txt: Added.
        * fast/parser/document-write-ignores-later-network-bytes.html: Added.
2011-06-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Script-created parsers should ignore data from the network
        https://bugs.webkit.org/show_bug.cgi?id=62336

        If the network packet boundaries line up just right, we can end up
        feeding network data to a parser created by document.write (or
        document.open).  That's incorrect.

        This patch causes DocumentWriter to grab hold of the original parser
        and direct all input to that parser.

        Test: fast/parser/document-write-ignores-later-network-bytes.html

        * dom/Document.cpp:
        (WebCore::Document::explicitClose):
        * loader/DocumentWriter.cpp:
        (WebCore::DocumentWriter::begin):
        (WebCore::DocumentWriter::addData):
        (WebCore::DocumentWriter::endIfNotLoadingMainResource):
        (WebCore::DocumentWriter::setDocumentWasLoadedAsPartOfNavigation):
        * loader/DocumentWriter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Sat, 11 Jun 2011 00:39:10 +0000 (00:39 +0000)]
2011-06-10  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by James Robinson.

        Web Inspector: [Chromium] DevTools does not highlight elements when accelerated compositing is on.
        https://bugs.webkit.org/show_bug.cgi?id=62149

        Added page overlay for inspector highlight support.

        * WebKit.gyp:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::attachRootGraphicsLayer):
        * src/PageOverlay.cpp: Added.
        (WebKit::PageOverlay::create):
        (WebKit::PageOverlay::PageOverlay):
        (WebKit::OverlayGraphicsLayerClientImpl::create):
        (WebKit::OverlayGraphicsLayerClientImpl::~OverlayGraphicsLayerClientImpl):
        (WebKit::OverlayGraphicsLayerClientImpl::notifyAnimationStarted):
        (WebKit::OverlayGraphicsLayerClientImpl::notifySyncRequired):
        (WebKit::OverlayGraphicsLayerClientImpl::paintContents):
        (WebKit::OverlayGraphicsLayerClientImpl::showDebugBorders):
        (WebKit::OverlayGraphicsLayerClientImpl::showRepaintCounter):
        (WebKit::OverlayGraphicsLayerClientImpl::OverlayGraphicsLayerClientImpl):
        (WebKit::PageOverlay::clear):
        (WebKit::PageOverlay::update):
        (WebKit::PageOverlay::paintWebFrame):
        (WebKit::PageOverlay::invalidateWebFrame):
        * src/PageOverlay.h: Added.
        (WebKit::PageOverlay::~PageOverlay):
        (WebKit::PageOverlay::setClient):
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::paintPageOverlay):
        (WebKit::WebDevToolsAgentImpl::highlight):
        (WebKit::WebDevToolsAgentImpl::hideHighlight):
        * src/WebDevToolsAgentImpl.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::paintWithContext):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::setPageOverlayClient):
        (WebKit::WebViewImpl::setOverlayLayer):
        (WebKit::WebViewImpl::setRootGraphicsLayer):
        (WebKit::WebViewImpl::setRootPlatformLayer):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
        (WebKit::WebViewImpl::doComposite):
        (WebKit::WebViewImpl::reallocateRenderer):
        * src/WebViewImpl.h:
        (WebKit::WebViewImpl::pageOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 11 Jun 2011 00:38:26 +0000 (00:38 +0000)]
2011-06-10  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
        https://bugs.webkit.org/show_bug.cgi?id=62489

        * Scripts/webkitpy/tool/bot/sheriff.py:
        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 11 Jun 2011 00:22:29 +0000 (00:22 +0000)]
2011-06-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Keep overlap testing logic until real 3d transforms are being used
        https://bugs.webkit.org/show_bug.cgi?id=49857

        For pages that use the translateZ(0) hack to force compositing layers, it's
        advantageous to keep overlap testing, to avoid putting too many other
        elements into layers.

        Only turn off overlap testing if non-identity 3D transforms are used.

        Tests: compositing/layer-creation/rotate3d-overlap.html
               compositing/layer-creation/translatez-overlap.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateBacking):
        (WebCore::RenderLayerCompositor::hasNonIdentity3DTransform):
        * rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Worker fails to fire error event when a resource fetch fails.
levin@chromium.org [Sat, 11 Jun 2011 00:21:23 +0000 (00:21 +0000)]
Web Worker fails to fire error event when a resource fetch fails.
https://bugs.webkit.org/show_bug.cgi?id=62475

Reviewed by Dmitry Titov.

Source/WebCore:

Test: http/tests/workers/worker-workerScriptNotThere.html

* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::didFinishLoading): Ensure that
the client is notified of the error when it happens during loading.

LayoutTests:

* http/tests/workers/worker-workerScriptNotThere-expected.txt: Added.
* http/tests/workers/worker-workerScriptNotThere.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFetching a Worker with url that isn't allowed from a file based test causes DRT to...
levin@chromium.org [Sat, 11 Jun 2011 00:11:01 +0000 (00:11 +0000)]
Fetching a Worker with url that isn't allowed from a file based test causes DRT to crash.
https://bugs.webkit.org/show_bug.cgi?id=62469

Reviewed by Dmitry Titov.

Source/WebCore:

Test: fast/workers/worker-crash-with-invalid-location.html

* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::load): Changed to using the RefCounted version of WorkerScriptLoader.
* workers/Worker.cpp:
(WebCore::Worker::create): Ditto.
* workers/Worker.h: Ditto.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::importScripts):  Ditto.
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::~WorkerScriptLoader): Created to
allow removing some header includes in WorkerScriptLoader.h.
(WebCore::WorkerScriptLoader::loadAsynchronously): Fix the ordering
of setPendingActivity and keep WorkerScriptLoader alive during a
potential callback.
* workers/WorkerScriptLoader.h: Made this RefCounted to allow for
keeping it alive during callbacks. Also, removed unnecessary header
inclusions (and added a destructor to facilitate that).
(WebCore::WorkerScriptLoader::create):

Source/WebKit/chromium:

Test: fast/workers/worker-crash-with-invalid-location.html

* src/SharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed to using the RefCounted version
of WorkerScriptLoader.
(WebCore::SharedWorkerScriptLoader::load): Rearranged calls as done in similar places,
which allows for SharedWorkerScriptLoader to be deleted during the laodAsynchronously call
and for unsetPendingActivity to be called.
(WebCore::SharedWorkerScriptLoader::notifyFinished): Changed to using the RefCounted version
of WorkerScriptLoader.

LayoutTests:

* fast/workers/worker-crash-with-invalid-location-expected.txt: Added.
* fast/workers/worker-crash-with-invalid-location.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Alok Priyadarshi <alokp@chromium.org>
alokp@chromium.org [Fri, 10 Jun 2011 23:55:31 +0000 (23:55 +0000)]
2011-06-10  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by James Robinson.

        [chromium] Top portion of page is rendered messed up with accelerated drawing
        https://bugs.webkit.org/show_bug.cgi?id=62484

        Fixed the math in flipping the texture from bottom-up to top-down.
        Test: compositing/repaint/shrink-layer.html (existing)

        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 10 Jun 2011 23:35:46 +0000 (23:35 +0000)]
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add a compile guard ENABLE(FLEXBOX)
        https://bugs.webkit.org/show_bug.cgi?id=62049

        * Configurations/FeatureDefines.xcconfig:
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add a compile guard ENABLE(FLEXBOX)
        https://bugs.webkit.org/show_bug.cgi?id=62049

        * Configurations/FeatureDefines.xcconfig:
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add a compile guard ENABLE(FLEXBOX)
        https://bugs.webkit.org/show_bug.cgi?id=62049

        * Configurations/FeatureDefines.xcconfig:
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add a compile guard ENABLE(FLEXBOX)
        https://bugs.webkit.org/show_bug.cgi?id=62049

        * Configurations/FeatureDefines.xcconfig:
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add a compile guard ENABLE(FLEXBOX)
        https://bugs.webkit.org/show_bug.cgi?id=62049

        * Scripts/build-webkit:
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add a compile guard ENABLE(FLEXBOX)
        https://bugs.webkit.org/show_bug.cgi?id=62049

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 10 Jun 2011 23:27:50 +0000 (23:27 +0000)]
2011-06-10  David Levin  <levin@chromium.org>

        Reviewed by Adam Barth.

        Add tests for Web Workers at invalid urls.
        https://bugs.webkit.org/show_bug.cgi?id=62486

        * http/tests/workers/shared-worker-invalid-url-expected.txt: Added.
        * http/tests/workers/shared-worker-invalid-url.html: Added.
        * http/tests/workers/worker-invalid-url-expected.txt: Added.
        * http/tests/workers/worker-invalid-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 22:55:22 +0000 (22:55 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Turns out, linux baseline isn't spurious.

        * platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll out r88568. It is not the right fix for the problem.
weinig@apple.com [Fri, 10 Jun 2011 22:43:20 +0000 (22:43 +0000)]
Roll out r88568. It is not the right fix for the problem.

* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 22:21:46 +0000 (22:21 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove all spurious copies of test expectations that somehow made it into the tree.

        * platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
        * platform/chromium-mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
        * platform/chromium-mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
        * platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
mrowe@apple.com [Fri, 10 Jun 2011 22:20:24 +0000 (22:20 +0000)]
<rdar://problem/9562114> Fix DumpRenderTree build for production configuration.

Reviewed by Dimitri Glazkov.

Source/WebCore:

Rename the built WebCoreTestSupport dylib to libWebCoreTestSupport.dylib so
that it can be found via the library search path rather than requiring an
absolute path be passed to the linker.

Install the library and its associated header file in a more appropriate location
for the production configuration.

* Configurations/WebCoreTestSupport.xcconfig:

Tools:

Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
header file.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/mac/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 10 Jun 2011 21:53:49 +0000 (21:53 +0000)]
2011-06-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Add a scheduleSetNeedsStyleRecalc() method to ContainerNode for use by RenderLayerCompositor
        https://bugs.webkit.org/show_bug.cgi?id=62471

        RenderLayerCompositor had some code that did a setNeedsStyleRecalc(), but
        in a way that was safe to call during existing style recalc or layout.

        Move this code to ContainerElement so it can be called elsewhere.
        Also add a param to the node callback so we can pass the style change type.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::queuePostAttachCallback):
        (WebCore::ContainerNode::dispatchPostAttachCallbacks):
        (WebCore::needsStyleRecalcCallback):
        (WebCore::ContainerNode::scheduleSetNeedsStyleRecalc):
        * dom/ContainerNode.h:
        * dom/Node.h:
        (WebCore::Node::scheduleSetNeedsStyleRecalc):
        * html/HTMLFormControlElement.cpp:
        (WebCore::focusPostAttach):
        (WebCore::updateFromElementCallback):
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::updateWidgetCallback):
        * html/HTMLPlugInImageElement.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::attachRootPlatformLayer):
        (WebCore::RenderLayerCompositor::detachRootPlatformLayer):
        (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
        * rendering/RenderLayerCompositor.h:
        * svg/SVGUseElement.cpp:
        (WebCore::updateFromElementCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Fri, 10 Jun 2011 21:42:29 +0000 (21:42 +0000)]
2011-06-10  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB: indexedDB.open() name argument is required
        https://bugs.webkit.org/show_bug.cgi?id=62398

        * storage/indexeddb/database-name-undefined-expected.txt: Added.
        * storage/indexeddb/database-name-undefined.html: Added.
2011-06-10  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB: indexedDB.open() name argument is required
        https://bugs.webkit.org/show_bug.cgi?id=62398

        Test: storage/indexeddb/database-name-undefined.html

        * storage/IDBFactory.idl: use appropriate IDL magic to force undefined values to null, so we handle missing arguments as well as null arguments

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCommon crash in ApplicationCacheHost::isApplicationCacheEnabled
weinig@apple.com [Fri, 10 Jun 2011 21:34:20 +0000 (21:34 +0000)]
Common crash in ApplicationCacheHost::isApplicationCacheEnabled
<rdar://problem/9328684>

Reviewed by Beth Dakin.

* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
Speculative fix for a null frame on ApplicationCacheHost's DocumentLoader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Fri, 10 Jun 2011 21:25:17 +0000 (21:25 +0000)]
2011-06-10  Emil A Eklund  <eae@chromium.org>

        Land Windows expectations for new test added in r88556.

        * platform/win/printing/page-count-relayout-shrink-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 10 Jun 2011 21:16:20 +0000 (21:16 +0000)]
2011-06-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove Document::finishParsing
        https://bugs.webkit.org/show_bug.cgi?id=62474

        This function appears to exist only to confuse and befuddle us.  This
        patch prepares for DocumentWriter to grab hold of the parser.

        This patch removes one of the print statements from
        INSTRUMENT_LAYOUT_SCHEDULING, but I'm not sure
        INSTRUMENT_LAYOUT_SCHEDULING works anymore anyway.

        * dom/Document.cpp:
        * dom/Document.h:
        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::finish):
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::finish):
        * loader/DocumentWriter.cpp:
        (WebCore::DocumentWriter::addData):
        (WebCore::DocumentWriter::endIfNotLoadingMainResource):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Fri, 10 Jun 2011 21:14:14 +0000 (21:14 +0000)]
2011-06-10  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB: setVersion() version argument is required
        https://bugs.webkit.org/show_bug.cgi?id=62401

        * storage/indexeddb/setVersion-undefined-expected.txt: Added.
        * storage/indexeddb/setVersion-undefined.html: Added.
2011-06-10  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB: setVersion() version argument is required
        https://bugs.webkit.org/show_bug.cgi?id=62401

        Test: storage/indexeddb/setVersion-undefined.html

        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::setVersion): check for null version
        * storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 10 Jun 2011 21:04:28 +0000 (21:04 +0000)]
2011-06-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Null-check the layer owner again when painting layers
        https://bugs.webkit.org/show_bug.cgi?id=62473

        Speculative fix for a crash that occurs when the layer's owner
        gets destroyed during painting.

        * platform/graphics/mac/WebLayer.mm:
        (drawLayerContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 20:59:21 +0000 (20:59 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Land expectations for a test, added in r88556.

        * platform/chromium-mac/printing/page-count-relayout-shrink-expected.txt: Added.
        * platform/chromium-win/printing/page-count-relayout-shrink-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 20:54:48 +0000 (20:54 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        [V8] Add failure expectation for a test, added in r88559.

        * platform/chromium/test_expectations.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-08 Robert Hogan <robert@webkit.org>
robert@webkit.org [Fri, 10 Jun 2011 20:49:25 +0000 (20:49 +0000)]
2011-06-08  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Lighten the --no-svg build a little
        https://bugs.webkit.org/show_bug.cgi?id=62314

        Only generate source from SVG*.idl if the build is svg-enabled.

        * CodeGenerators.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 20:39:02 +0000 (20:39 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Remove expectation of crash, fixed in r88551.

        * platform/chromium/test_expectations.txt: Removed expectation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=55347
barraclough@apple.com [Fri, 10 Jun 2011 20:33:27 +0000 (20:33 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55347
"name" and "message" enumerable on *Error.prototype

Reviewed by Sam Weinig.

This arises from chapter 15 of the spec:
    "Every other property described in this clause has the attributes
    { [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }
    unless otherwise specified."
Standardized properties are not enumerable.

Source/JavaScriptCore:

* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):

LayoutTests:

* fast/js/exception-properties-expected.txt: Added.
* fast/js/exception-properties.html: Added.
* fast/js/script-tests/exception-properties.js: Added.
(enumerableProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 20:29:33 +0000 (20:29 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Update expectations after r88555.

        * platform/chromium-win/svg/custom/focus-ring-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 10 Jun 2011 20:15:10 +0000 (20:15 +0000)]
2011-06-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
        https://bugs.webkit.org/show_bug.cgi?id=59085

        Add glyph table to SVGFontElement mapping between SVGGlyph <-> Glyph
        https://bugs.webkit.org/show_bug.cgi?id=62441

        Preparation patch 1: Introduce the internal glyph table in SVGGlyphMap that will be used to identify each
        SVGGlyph identifier with a Glyph (which is just an ushort). It will be used by follow-up patches.

        Doesn't affect any test so far.

        * platform/graphics/SVGGlyph.h:
        (WebCore::SVGGlyph::SVGGlyph):
        (WebCore::SVGGlyph::operator==):
        * rendering/svg/SVGTextRunRenderingContext.cpp:
        (WebCore::SVGTextRunWalker::walk):
        * svg/SVGFontData.cpp:
        (WebCore::SVGFontData::initializeFontData):
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::SVGFontElement):
        (WebCore::SVGFontElement::registerLigaturesInGlyphCache):
        (WebCore::SVGFontElement::ensureGlyphCache):
        (WebCore::kerningForPairOfStringsAndGlyphs):
        (WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs):
        (WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs):
        (WebCore::SVGFontElement::collectGlyphsForString):
        (WebCore::SVGFontElement::collectGlyphsForGlyphName):
        (WebCore::SVGFontElement::svgGlyphForGlyph):
        (WebCore::SVGFontElement::missingGlyph):
        * svg/SVGFontElement.h:
        (WebCore::SVGKerningPair::SVGKerningPair):
        * svg/SVGGlyphMap.h:
        (WebCore::SVGGlyphMap::addGlyphByUnicodeString):
        (WebCore::SVGGlyphMap::addGlyphByName):
        (WebCore::SVGGlyphMap::appendToGlyphTable):
        (WebCore::SVGGlyphMap::collectGlyphsForString):
        (WebCore::SVGGlyphMap::clear):
        (WebCore::SVGGlyphMap::svgGlyphForGlyph):
        (WebCore::SVGGlyphMap::glyphIdentifierForGlyphName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Fri, 10 Jun 2011 19:44:39 +0000 (19:44 +0000)]
2011-06-10  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Regression r85573: Blank pages appear at the end of some wikipedia documents.
        https://bugs.webkit.org/show_bug.cgi?id=62343

        Fix regression caused by r85573. Cached document size not updated after layout.

        * platform/chromium-linux/printing/page-count-relayout-shrink-expected.txt: Added.
        * platform/mac/printing/page-count-relayout-shrink-expected.txt: Added.
        * printing/page-count-relayout-shrink.html: Added.
2011-06-10  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Regression r85573: Blank pages appear at the end of some wikipedia documents.
        https://bugs.webkit.org/show_bug.cgi?id=62343

        Fix regression caused by r85573. Cached document size not updated after layout.

        Test: printing/page-count-relayout-shrink.html

        * page/FrameView.cpp:
        (WebCore::FrameView::forceLayoutForPagination):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Fri, 10 Jun 2011 19:43:23 +0000 (19:43 +0000)]
2011-06-10  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        animation event handling broken: focusin
        https://bugs.webkit.org/show_bug.cgi?id=12894

        focusin, focusout, activate not implemented in SVG
        https://bugs.webkit.org/show_bug.cgi?id=40545

        Test whether focusin and focusout events are dispatched and seen in the focusin/focusout event handlers.

        * platform/mac/svg/custom/focus-ring-expected.txt:
        * svg/custom/focus-event-handling-expected.txt: Added.
        * svg/custom/focus-event-handling-keyboard-expected.txt: Added.
        * svg/custom/focus-event-handling-keyboard.xhtml: Added.
        * svg/custom/focus-event-handling.xhtml: Added.
        * svg/custom/resources/focus-event-handling-keyboard.js: Added.
        (focusinHandler):
        (focusoutHandler):
        * svg/custom/resources/focus-event-handling.js: Added.
        (clearFocusSeen):
        ():
        (focusoutHandler):
        (clickAt):
2011-06-10  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        amation event handling broken: focusin
        https://bugs.webkit.org/show_bug.cgi?id=12894

        focusin, focusout, activate not implemented in SVG
        https://bugs.webkit.org/show_bug.cgi?id=40545

        Make elements that should support GraphicalEventAttribute handle focussing, since focusin, focusout is part of that:

        http://www.w3.org/TR/SVG11/intro.html#TermGraphicalEventAttribute

        Match Opera behaviour ; elements that support GraphicalEventAttribute can receive visual mouse focus when having either a focusin or focusout event handler. Elements that support GraphicalEventAttribute can receive visual keyboard focus when having either a focusin or focusout event handler. Keyboard focus does not advance to SVG elements that are not focusable at the time.

        Tests: svg/custom/focus-event-handling-keyboard.xhtml
               svg/custom/focus-event-handling.xhtml

        * rendering/svg/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::computeRectForRepaint):
        * svg/SVGCircleElement.h:
        (WebCore::SVGCircleElement::supportsFocus):
        * svg/SVGEllipseElement.h:
        (WebCore::SVGEllipseElement::supportsFocus):
        * svg/SVGGElement.h:
        (WebCore::SVGGElement::supportsFocus):
        * svg/SVGImageElement.h:
        (WebCore::SVGImageElement::supportsFocus):
        * svg/SVGLineElement.h:
        (WebCore::SVGLineElement::supportsFocus):
        * svg/SVGPathElement.h:
        (WebCore::SVGPathElement::supportsFocus):
        * svg/SVGPolyElement.h:
        (WebCore::SVGPolyElement::supportsFocus):
        * svg/SVGRectElement.h:
        (WebCore::SVGRectElement::supportsFocus):
        * svg/SVGSVGElement.h:
        (WebCore::SVGSVGElement::supportsFocus):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::isMouseFocusable):
        (WebCore::SVGStyledElement::isKeyboardFocusable):
        * svg/SVGStyledElement.h:
        * svg/SVGSwitchElement.h:
        (WebCore::SVGSwitchElement::supportsFocus):
        * svg/SVGSymbolElement.h:
        (WebCore::SVGSymbolElement::supportsFocus):
        * svg/SVGTextElement.h:
        (WebCore::SVGTextElement::supportsFocus):
        * svg/SVGUseElement.h:
        (WebCore::SVGUseElement::supportsFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 10 Jun 2011 18:35:46 +0000 (18:35 +0000)]
2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>

        Rolled DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Luke Macpherson <macpherson@chromium.org>
macpherson@chromium.org [Fri, 10 Jun 2011 18:17:21 +0000 (18:17 +0000)]
2011-06-10  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Clean up CSSPrimitiveValue::computeLength*
        https://bugs.webkit.org/show_bug.cgi?id=61612

        No new tests as no functionality changed.

        * css/CSSGradientValue.cpp:
        Use new computeLength functions.
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
        Reduce to a single function using default parameter values.
        (WebCore::CSSPrimitiveValue::computeLength):
        Redefine existing functions with separate names as a single function using templated function specialization.
        * css/CSSPrimitiveValue.h:
        Prototypes for computeLengthIntForLength and computeLength.
        * css/CSSStyleApplyProperty.cpp:
        Use new computeLength functions.
        * css/CSSStyleSelector.cpp:
        Use new computeLength functions.
        * css/MediaQueryEvaluator.cpp:
        Use new computeLength functions.
        * css/SVGCSSStyleSelector.cpp:
        Use new computeLength functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 10 Jun 2011 18:10:37 +0000 (18:10 +0000)]
2011-06-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Beth Dakin.

        Add utility to RenderLayer to determine if the layer is scrollable
        https://bugs.webkit.org/show_bug.cgi?id=62467

        New method that returns true if either scrollbar is present and enabled.
        Not called anywhere yet.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::allowsScrolling):
        * rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 17:56:52 +0000 (17:56 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Tony Chang.

        REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges
        https://bugs.webkit.org/show_bug.cgi?id=62460

        Test: fast/dom/prototype-inheritance-2.html

        * dom/DocumentMarkerController.cpp:
        (WebCore::DocumentMarkerController::userSpellingMarkersForNode): Added an extra 0-check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 10 Jun 2011 17:31:29 +0000 (17:31 +0000)]
2011-06-10  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Tony Gentilcore.

        Tests that trying to remove all document children while building a svg <use>
        element shadow and instance tree does not result in crash.
        https://bugs.webkit.org/show_bug.cgi?id=62225

        * svg/dom/use-style-recalc-script-execute-crash-expected.txt: Added.
        * svg/dom/use-style-recalc-script-execute-crash.html: Added.
2011-06-10  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Gentilcore.

        Don't execute scripts in shadow SVG.
        https://bugs.webkit.org/show_bug.cgi?id=62225

        Test: svg/dom/use-style-recalc-script-execute-crash.html

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::prepareScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 10 Jun 2011 17:31:13 +0000 (17:31 +0000)]
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] make features.gypi the same as features_override.gypi
        https://bugs.webkit.org/show_bug.cgi?id=62399

        Make the file the same as chromium's features_override.gypi so we
        can remove features_override.gypi in chromium.

        Remove ENABLE_DATAGRID=0 since the define is gone and remove
        ENABLE_FULLSCREEN_API=1 since we want to disable it.

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Konstantin Tokarev <ktokarev@smartlabs.tv>
loislo@chromium.org [Fri, 10 Jun 2011 17:29:08 +0000 (17:29 +0000)]
2011-06-10  Konstantin Tokarev  <ktokarev@smartlabs.tv>

        Reviewed by Joseph Pecoraro.

        Fixed build with enabled workers and disabled inspector
        https://bugs.webkit.org/show_bug.cgi?id=62461

        * inspector/InspectorWorkerAgent.cpp: Added inspector guard

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 10 Jun 2011 17:05:31 +0000 (17:05 +0000)]
2011-06-10  Darin Adler  <darin@apple.com>

        Reviewed by Eric Carlson.

        REGRESSION: Fullscreen video controller can't be dragged
        https://bugs.webkit.org/show_bug.cgi?id=62462

        No regression test because we don't have machinery for testing the fullscreen
        mode. We may find a way to add this in the future.

        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlPanelElement::MediaControlPanelElement): Initialize new
        booleans related to dragging.
        (WebCore::MediaControlPanelElement::startDrag): Added. Starts drag if dragging
        is allowed and a drag isn't already in progress.
        (WebCore::MediaControlPanelElement::continueDrag): Added. Moves the window if
        dragging is already in progress.
        (WebCore::MediaControlPanelElement::endDrag): Added. Ends the capture that is
        done during the dragging process.
        (WebCore::MediaControlPanelElement::setPosition): Added. Positions the panel
        using explicit top/left.
        (WebCore::MediaControlPanelElement::resetPosition): Added. Removes the positioning
        done by setPosition.
        (WebCore::MediaControlPanelElement::defaultEventHandler): Added. Calls startDrag,
        continueDrag, and endDrag in response to mouse events.
        (WebCore::MediaControlPanelElement::setCanBeDragged): Added.
        * html/shadow/MediaControlElements.h: Added new function and data members
        as mentioned above.

        * html/shadow/MediaControlRootElement.cpp:
        (WebCore::MediaControlRootElement::enteredFullscreen): Call setCanBeDragged(true)
        so you can drag the panel while in fullscreen.
        (WebCore::MediaControlRootElement::exitedFullscreen): Call setCanBeDragged(false)
        so you can't drag the panel while not in fullscreen. Also call resetPosition so
        position changes from dragging don't affect the panel in other contexts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 17:00:17 +0000 (17:00 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove tests that are now passing.

        * platform/chromium/test_expectations.txt: Removed passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 10 Jun 2011 16:52:01 +0000 (16:52 +0000)]
2011-06-10  Darin Adler  <darin@apple.com>

        Reviewed by Eric Carlson.

        REGRESSION: Full screen video HUD is positioned too low for standalone video documents
        https://bugs.webkit.org/show_bug.cgi?id=62463

        No test because we don't currently have machinery for testing fullscreen.

        * css/fullscreen.css: Removed rule that said bottom: 0px for the control panel
        for full page media in full screen mode. This is not needed because the control
        panel for full screen mode already has style rules to set its vertical position.
        (:-webkit-full-screen-ancestor:not(iframe)): Fixed typo where it said
        -webkit-tranform. This will fix a potential problem where fullscreen would
        malfunction on a page that had a media element inside a transform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 10 Jun 2011 16:06:53 +0000 (16:06 +0000)]
2011-06-10  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Add support for non-ASCII filenames in Content-Disposition header
        https://bugs.webkit.org/show_bug.cgi?id=62454

        Try latin1 as fallback for header parameter values as some servers
        do not follow RFC 2045 for example with filename parameter in
        Content-Disposition.

        No new tests required as no functionality changed.

        * platform/network/soup/ResourceResponseSoup.cpp:
        (WebCore::ResourceResponse::updateFromSoupMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 15:55:36 +0000 (15:55 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges.
        https://bugs.webkit.org/show_bug.cgi?id=62460

        * platform/chromium/test_expectations.txt: Updated test expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 No'am Rosenthal <noam.rosenthal@nokia.com> and Viatcheslav Ostapenko...
commit-queue@webkit.org [Fri, 10 Jun 2011 11:56:37 +0000 (11:56 +0000)]
2011-06-10  No'am Rosenthal  <noam.rosenthal@nokia.com> and Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Add layer factory to GraphicsLayer for creating non-default layer type.
        https://bugs.webkit.org/show_bug.cgi?id=61925

        Added a static factory protected member to GraphicsLayer, which should be accessed from
        a port-specific implementation of GraphicsLayer::create. For now this is enabled for Qt only.

        This is needed for accelerated compositing across processes in WebKit2, since WebCore
        doesn't know in compile time whether it's in WebKit or WebKit2, which makes having two
        different implementations of GraphicsLayer coexist impossible without some runtime
        factory that can be overridden by the web process.

        Note that the use of the factory would be optional, and the port-specific GraphicsLayer::create
        would have to explicitly call it, in order to be unintrusive with current implementations.

        No new functionality, so no new tests.

        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::setGraphicsLayerFactory):
        * platform/graphics/GraphicsLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Fri, 10 Jun 2011 11:34:59 +0000 (11:34 +0000)]
2011-06-10  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL][WK2] Add dummy files in WebProcess/WebCoreSupport/efl
        https://bugs.webkit.org/show_bug.cgi?id=62346

        Add WebProcess/WebCoreSupport/efl directory and files.

        * WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp: Added.
        (WebKit::WebContextMenuClient::lookUpInDictionary):
        (WebKit::WebContextMenuClient::isSpeaking):
        (WebKit::WebContextMenuClient::speak):
        (WebKit::WebContextMenuClient::stopSpeaking):
        * WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp: Added.
        (WebKit::WebEditorClient::handleKeyboardEvent):
        (WebKit::WebEditorClient::handleInputMethodKeydown):
        * WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: Added.
        (WebKit::cancelledError):
        (WebKit::blockedError):
        (WebKit::cannotShowURLError):
        (WebKit::interruptForPolicyChangeError):
        (WebKit::cannotShowMIMETypeError):
        (WebKit::fileDoesNotExistError):
        (WebKit::pluginWillHandleLoadError):
        * WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Added.
        (WebFrameNetworkingContext::create):
        (WebFrameNetworkingContext::WebFrameNetworkingContext):
        * WebProcess/WebCoreSupport/efl/WebPopupMenuEfl.cpp: Added.
        (WebKit::WebPopupMenu::setUpPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Fri, 10 Jun 2011 11:32:38 +0000 (11:32 +0000)]
2011-06-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [CMAKE] Add generic support for building with WebGL
        https://bugs.webkit.org/show_bug.cgi?id=62376

        Add files that need to be compiled in every port for supporting WebGL.
        Each port still needs to add its specific files to
        CMakeLists${PORT}.txt. Therefore we do not enable WebGL in any port
        yet.

        * Source/CMakeLists.txt: Add files needed to support WebGL.
        * Source/cmake/OptionsCommon.cmake: Find required OpenGL package.
        * Source/cmakeconfig.h.cmake: define ENABLE_WEBGL this feature is
        enabled.
2011-06-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [CMAKE] Add generic support for building with WebGL
        https://bugs.webkit.org/show_bug.cgi?id=62376

        Set new THIRDPARTY_DIR variable to compile sources under ThirdParty.

        No change in functionality so no new tests.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Fri, 10 Jun 2011 11:31:23 +0000 (11:31 +0000)]
2011-06-10  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Fix 'headers' autotest when building inside Qt.
        https://bugs.webkit.org/show_bug.cgi?id=62449

        * Api/qwebkitplatformplugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 KwangHyuk Kim <hyuki.kim@samsung.com>
commit-queue@webkit.org [Fri, 10 Jun 2011 11:30:19 +0000 (11:30 +0000)]
2011-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL]add image content hint information for tile image object when it is created
        https://bugs.webkit.org/show_bug.cgi?id=62436

        When application is using opengl_x11 Ecore_Evas, it can be working as gl texture.
        In order to support this enhanced feature, image content hint information must be
        specified as EVAS_IMAGE_CONTENT_HINT_DYNAMIC

        * ewk/ewk_tiled_model.c:
        (ewk_tile_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Fri, 10 Jun 2011 11:23:38 +0000 (11:23 +0000)]
2011-06-10  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Andreas Kling.

        [GTK][EFL] m_imageInterpolationQuality is not initialized in PlatformContextCairo::PlatformContextCairo.
        https://bugs.webkit.org/show_bug.cgi?id=62435

        No new tests required as just fixed warning.

        * platform/graphics/cairo/PlatformContextCairo.cpp:
        (WebCore::PlatformContextCairo::PlatformContextCairo):

2011-06-11-06-09  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
        https://bugs.webkit.org/show_bug.cgi?id=62377

        * inspector/InspectorValues.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 10 Jun 2011 10:15:50 +0000 (10:15 +0000)]
2011-06-10  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
        https://bugs.webkit.org/show_bug.cgi?id=62377

        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:

2011-06-11-06-09  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
        https://bugs.webkit.org/show_bug.cgi?id=62377

        * inspector/InspectorValues.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 10 Jun 2011 10:06:41 +0000 (10:06 +0000)]
2011-06-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Keep ORIENTATION_EVENTS independent from DEVICE_ORIENTATION
        https://bugs.webkit.org/show_bug.cgi?id=62420

        ORIENTATION_EVENTS and DEVICE_ORIENTATION features are very similar
        but they meant to be independent.

        * Api/qwebframe.cpp:
        (QWebFramePrivate::_q_orientationChanged):
        (QWebFrame::QWebFrame):
        * Api/qwebframe_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88534 268f45cc-cd09-0410-ab3c-d52691b4dbfc