WebKit-https.git
6 years agofast/workers/storage/use-same-database-in-page-and-workers.html times out on the...
rniwa@webkit.org [Thu, 23 May 2013 19:37:55 +0000 (19:37 +0000)]
fast/workers/storage/use-same-database-in-page-and-workers.html times out on the lion bots
https://bugs.webkit.org/show_bug.cgi?id=81618

Add back the flaky test failure on Mac.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse correct stack size on Solaris and OpenBSD
paroga@webkit.org [Thu, 23 May 2013 19:19:10 +0000 (19:19 +0000)]
Use correct stack size on Solaris and OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=114978

Reviewed by Oliver Hunt.

Original patch by David Hill <david@wmol.com>.

Use stack_t.ss_size for getting the size of the stack.

* wtf/Platform.h:
* wtf/StackBounds.cpp:
(WTF):
(WTF::StackBounds::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoThe ellipsis in a text overflow should not avoid floats
robert@webkit.org [Thu, 23 May 2013 18:55:53 +0000 (18:55 +0000)]
The ellipsis in a text overflow should not avoid floats
https://bugs.webkit.org/show_bug.cgi?id=115746

Reviewed by David Hyatt.

Source/WebCore:

When placing an ellipsis for text overflow we shouldn't avoid any floats on the line.
That is to say, if there is a float in the box we overflow we should let our no-wrap text,
including the ellipsis, render inside the float just as we would if overflow was hidden but
a text-overflow rendering had not been specified.

Test: fast/css/text-overflow-ellipsis-behind-floats.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkLinesForTextOverflow):

LayoutTests:

* fast/css/text-overflow-ellipsis-behind-floats-expected.html: Added.
* fast/css/text-overflow-ellipsis-behind-floats.html: Added.
* fast/css/text-overflow-ellipsis-full-truncate-rtl-expected.html:
* fast/css/text-overflow-ellipsis-full-truncate-rtl.html:
  Change this test to expect the text to cross into the floating input element
  and render the ellipsis at the left extreme of the element. The previous expected
  rendering relied on the incorrect premise that an overflow ellipsis should avoid
  floated elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WIN] Implement correct detection of stack size
paroga@webkit.org [Thu, 23 May 2013 18:51:00 +0000 (18:51 +0000)]
[WIN] Implement correct detection of stack size
https://bugs.webkit.org/show_bug.cgi?id=116661

Reviewed by Oliver Hunt.

* wtf/StackBounds.cpp:
(WTF):
(WTF::StackBounds::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago <rdar://problem/13849260> Sandbox violations reading .CFUserTextEncoding
ap@apple.com [Thu, 23 May 2013 18:49:57 +0000 (18:49 +0000)]
    <rdar://problem/13849260> Sandbox violations reading .CFUserTextEncoding

        Reviewed by Dan Bernstein.

        * WebProcess/com.apple.WebProcess.sb.in: Allow this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Lion] [WK2] compositing/overflow/overflow-compositing-descendant.html
rniwa@webkit.org [Thu, 23 May 2013 18:30:34 +0000 (18:30 +0000)]
[Lion] [WK2] compositing/overflow/overflow-compositing-descendant.html
https://bugs.webkit.org/show_bug.cgi?id=116684

Add a timeout/failure test expectation. Also update the expected result since the first frame
of the video must be shown in this test.

* platform/mac-wk2/TestExpectations:
* platform/mac/compositing/overflow/overflow-compositing-descendant-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove posix_spawn onto a zero delay timer
barraclough@apple.com [Thu, 23 May 2013 18:03:02 +0000 (18:03 +0000)]
Move posix_spawn onto a zero delay timer
https://bugs.webkit.org/show_bug.cgi?id=116682

Reviewed by Anders Carlson.

<rdar://problem/13973468>

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
(ReexecInfo):
    - struct to hold info from the XPC message.
(WebKit::reexec):
    - moved call to posix_spawn out to this helper.
(WebKit::reexecCallBack):
    - calls reexec.
(WebKit::XPCServiceEventHandler):
    - removed call to posix_spawn; schedule a call to reexecCallBack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix loader/go-back-cached-main-resource.html test
commit-queue@webkit.org [Thu, 23 May 2013 17:52:52 +0000 (17:52 +0000)]
Fix loader/go-back-cached-main-resource.html test
https://bugs.webkit.org/show_bug.cgi?id=116670

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-05-23
Reviewed by Alexey Proskuryakov.

The page does not get an onload when being restored from page cache. The
test case case is modified to handle pageshow event instead.

* loader/go-back-cached-main-resource.html: Wait for the third
'first-page' message to finish the test.
* loader/resources/first-page.html: Use onpageshow instead of onload.
* loader/resources/other-page.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSeveral editing tests that copy & paste slow down Mac WK2 EWS
rniwa@webkit.org [Thu, 23 May 2013 17:50:03 +0000 (17:50 +0000)]
Several editing tests that copy & paste slow down Mac WK2 EWS
https://bugs.webkit.org/show_bug.cgi?id=116681

Reviewed by Anders Carlsson.

Move editing tests that trigger copy and paste from execCommand into pasteboard.
Since NWRT uses a single instance of WebKitTestRunner to run tests in single directory,
this should mitigate the issue for now.

In the long term, we should really mock out the clipboard in WebKitTestRunner.

* editing/execCommand/4128080-2-expected.txt: Removed.
* editing/execCommand/4128080-2.html: Removed.
* editing/execCommand/5939887-expected.txt: Removed.
* editing/execCommand/5939887.html: Removed.
* editing/execCommand/copy-without-selection-expected.txt: Removed.
* editing/execCommand/copy-without-selection.html: Removed.
* editing/execCommand/paste-2.html: Removed.
* editing/pasteboard/copy-cut-paste-events-fired-when-disabled-expected.txt: Copied from LayoutTests/editing/execCommand/5939887-expected.txt.
* editing/pasteboard/copy-cut-paste-events-fired-when-disabled.html: Copied from LayoutTests/editing/execCommand/5939887.html.
* editing/pasteboard/copy-inside-h1-preserves-h1-expected.txt: Copied from LayoutTests/editing/execCommand/4128080-2-expected.txt.
* editing/pasteboard/copy-inside-h1-preserves-h1.html: Copied from LayoutTests/editing/execCommand/4128080-2.html.
* editing/pasteboard/copy-without-selection-expected.txt: Copied from LayoutTests/editing/execCommand/copy-without-selection-expected.txt.
* editing/pasteboard/copy-without-selection.html: Copied from LayoutTests/editing/execCommand/copy-without-selection.html.
* editing/pasteboard/paste-2.html: Copied from LayoutTests/editing/execCommand/paste-2.html.
* platform/gtk/editing/execCommand/paste-2-expected.png: Removed.
* platform/gtk/editing/execCommand/paste-2-expected.txt: Removed.
* platform/gtk/editing/pasteboard/paste-2-expected.png: Copied from LayoutTests/platform/gtk/editing/execCommand/paste-2-expected.png.
* platform/gtk/editing/pasteboard/paste-2-expected.txt: Copied from LayoutTests/platform/gtk/editing/execCommand/paste-2-expected.txt.
* platform/mac/editing/execCommand/paste-2-expected.png: Removed.
* platform/mac/editing/execCommand/paste-2-expected.txt: Removed.
* platform/mac/editing/pasteboard/paste-2-expected.png: Copied from LayoutTests/platform/mac/editing/execCommand/paste-2-expected.png.
* platform/mac/editing/pasteboard/paste-2-expected.txt: Copied from LayoutTests/platform/mac/editing/execCommand/paste-2-expected.txt.
* platform/qt/editing/execCommand/paste-2-expected.png: Removed.
* platform/qt/editing/execCommand/paste-2-expected.txt: Removed.
* platform/qt/editing/pasteboard/paste-2-expected.png: Copied from LayoutTests/platform/qt/editing/execCommand/paste-2-expected.png.
* platform/qt/editing/pasteboard/paste-2-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/paste-2-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake default bug links in buildbot clickable
paroga@webkit.org [Thu, 23 May 2013 17:49:45 +0000 (17:49 +0000)]
Make default bug links in buildbot clickable
https://bugs.webkit.org/show_bug.cgi?id=116673

Reviewed by Ryosuke Niwa.

Use changecommentlink of html.WebStatus to make the links clickable.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEWS bubbles need more space
paroga@webkit.org [Thu, 23 May 2013 17:17:19 +0000 (17:17 +0000)]
EWS bubbles need more space
https://bugs.webkit.org/show_bug.cgi?id=116675

Reviewed by Andreas Kling.

* template/en/custom/attachment/list.html.tmpl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r150586.
ch.dumez@sisa.samsung.com [Thu, 23 May 2013 16:45:10 +0000 (16:45 +0000)]
Unreviewed, rolling out r150586.
http://trac.webkit.org/changeset/150586
https://bugs.webkit.org/show_bug.cgi?id=116660

Those constructors should be exposed on the WorkerContext, not
the DOMWindow

Source/WebCore:

* fileapi/FileReaderSync.idl:
* workers/WorkerLocation.idl:

LayoutTests:

* fast/js/global-constructors-attributes-expected.txt:
* platform/efl/fast/js/constructor-length-expected.txt:
* platform/efl/fast/js/global-constructors-attributes-expected.txt:
* platform/gtk/fast/js/constructor-length-expected.txt:
* platform/gtk/fast/js/global-constructors-attributes-expected.txt:
* platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
* platform/mac/fast/js/constructor-length-expected.txt:
* platform/qt/fast/js/constructor-length-expected.txt:
* platform/qt/fast/js/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions][Mac] [WK2] Layout Test fast/regions/fixed-pos-elem-in-region.html is...
commit-queue@webkit.org [Thu, 23 May 2013 16:13:35 +0000 (16:13 +0000)]
[CSS Regions][Mac] [WK2] Layout Test fast/regions/fixed-pos-elem-in-region.html is flaky on Debug builders
https://bugs.webkit.org/show_bug.cgi?id=114571

Tests seems to be passing now, removed from TestExpectations.

Patch by Radu Stavila <stavila@adobe.com> on 2013-05-23
Reviewed by Anders Carlsson.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] The web context does not contain any link properties if the context...
commit-queue@webkit.org [Thu, 23 May 2013 16:11:25 +0000 (16:11 +0000)]
[BlackBerry] The web context does not contain any link properties if the context node is an image enclosed by a link node
https://bugs.webkit.org/show_bug.cgi?id=116627

Patch by Ed Baker <edbaker@blackberry.com> on 2013-05-23
Reviewed by Xan Lopez.

PR #341084

If the context node has an image tag and an enclosing link node was detected then add the link properties to the context.

Internally Reviewed by Gen Mak.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Validate form data before doing direct submission.
mifenton@rim.com [Thu, 23 May 2013 15:55:18 +0000 (15:55 +0000)]
[BlackBerry] Validate form data before doing direct submission.
https://bugs.webkit.org/show_bug.cgi?id=116674

Reviewed by Xan Lopez.

PR 314202.

Check validation of the input form before triggering direct submission.

Internally Reviewed by Nima Ghanavatian.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::submitForm):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove [NoInterfaceObject] from FileReaderSync and WorkerLocation
ch.dumez@sisa.samsung.com [Thu, 23 May 2013 15:20:13 +0000 (15:20 +0000)]
Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation
https://bugs.webkit.org/show_bug.cgi?id=116660

Reviewed by Kentaro Hara.

Source/WebCore:

Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation to match their
respective specifications:
- http://dev.w3.org/2006/webapi/FileAPI/#FileReaderSync
- http://dev.w3.org/html5/workers/#workerlocation

No new tests, covered by existing tests.

* fileapi/FileReaderSync.idl:
* workers/WorkerLocation.idl:

LayoutTests:

Rebaseline a couple of test cases now that FileReaderSync and WorkerLocation
attributes are exposed on the global Window object.

* fast/js/global-constructors-attributes-expected.txt:
* platform/efl/fast/js/constructor-length-expected.txt:
* platform/efl/fast/js/global-constructors-attributes-expected.txt:
* platform/gtk/fast/js/constructor-length-expected.txt:
* platform/gtk/fast/js/global-constructors-attributes-expected.txt:
* platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
* platform/mac/fast/js/constructor-length-expected.txt:
* platform/qt/fast/js/constructor-length-expected.txt:
* platform/qt/fast/js/global-constructors-attributes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotSh...
commit-queue@webkit.org [Thu, 23 May 2013 14:14:52 +0000 (14:14 +0000)]
[BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
https://bugs.webkit.org/show_bug.cgi?id=116603

Patch by Rob Buis <rbuis@rim.com> on 2013-05-23
Reviewed by Xan Lopez.

PR 119789
Internally reviewed by Yong Li.

Provide a domain value for this ResourceError instance. Note that
this does not change behavior.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Thu, 23 May 2013 14:00:49 +0000 (14:00 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0-wk2/TestExpectations: Skip some failing test.
* platform/qt-5.0-wk2/fast/forms/select-baseline-expected.png: Rebaselined after r148594.
* platform/qt-5.0-wk2/fast/forms/select-baseline-expected.txt:
* platform/qt-5.0-wk2/fast/images/repaint-subrect-grid-expected.txt: Rebaselined after r149292.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[cmake] Fix generating-forwarding-headers rule after r150460
ossy@webkit.org [Thu, 23 May 2013 13:17:52 +0000 (13:17 +0000)]
[cmake] Fix generating-forwarding-headers rule after r150460
https://bugs.webkit.org/show_bug.cgi?id=116659

Reviewed by Christophe Dumez.

* CMakeLists.txt: Typo fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Remote Web Inspector sometimes won't serve any content
commit-queue@webkit.org [Thu, 23 May 2013 12:45:59 +0000 (12:45 +0000)]
[GTK] Remote Web Inspector sometimes won't serve any content
https://bugs.webkit.org/show_bug.cgi?id=116225

Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-05-23
Reviewed by Gustavo Noronha Silva.

Added an option to use environment variable to set up path to
inspector server files. Implementation is similar to InspectorClientGtk
implementation.

* UIProcess/InspectorServer/WebInspectorServer.h:
(WebInspectorServer):
* UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::inspectorServerFilesPath):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Use WK2 C API in ewk_view_pagination_mode_set|get
gyuyoung.kim@samsung.com [Thu, 23 May 2013 12:30:01 +0000 (12:30 +0000)]
[EFL][WK2] Use WK2 C API in ewk_view_pagination_mode_set|get
https://bugs.webkit.org/show_bug.cgi?id=116657

Reviewed by Christophe Dumez.

WKPageGet|SetPaginationMode APIs is present in WK2 C APIs. So, we need to use them for
ewk_view_pagination_mode_set|get.

Besides we don't need to use WebCore namespace anymore.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove special case for MessagePortArray from bindings generator
ch.dumez@sisa.samsung.com [Thu, 23 May 2013 12:22:23 +0000 (12:22 +0000)]
Remove special case for MessagePortArray from bindings generator
https://bugs.webkit.org/show_bug.cgi?id=116653

Reviewed by Kentaro Hara.

Use MessagePort[] instead of MessagePortArray type in the IDL as MessagePortArray
is not defined on IDL side. This allows us to remove the special case for
MessagePortArray from the bindings generator.

No new tests, no behavior change.

* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data):
* bindings/scripts/CodeGeneratorJS.pm:
(NativeToJSValue): Remove special case for MessagePortArray.
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::jsTestSerializedScriptValueInterfacePorts):
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
* bindings/scripts/test/TestSerializedScriptValueInterface.idl: Replace MessagePortArray
by MessagePort[].
* dom/MessageEvent.h:
(WebCore::MessageEvent::ports): The method should return a Vector, not a Vector*
as the array on JavaScript side is not nullable.
* dom/MessageEvent.idl: Replace MessagePortArray by MessagePort[].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agomedia/W3C/video/networkState/networkState_during_progress.html is flaky
kbalazs@webkit.org [Thu, 23 May 2013 10:32:51 +0000 (10:32 +0000)]
media/W3C/video/networkState/networkState_during_progress.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=76280

Unreviewed gardening.

Change expectation to the correct output and mark as flaky.

* TestExpectations:
* media/W3C/video/networkState/networkState_during_progress-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSupport frame instrumentation for coordinated graphics
kadam@inf.u-szeged.hu [Thu, 23 May 2013 09:26:28 +0000 (09:26 +0000)]
Support frame instrumentation for coordinated graphics
https://bugs.webkit.org/show_bug.cgi?id=115260

Patch by Roland Takacs <rtakacs@inf.u-szeged.hu> on 2013-05-23
Reviewed by Andreas Kling.

Enabled supportsFrameInstrumentation on ports that use coordinated graphics
by calling didBeginFrame().

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::supportsFrameInstrumentation):
(WebKit):
* WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::syncDisplayState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Thu, 23 May 2013 09:20:23 +0000 (09:20 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0-wk1/TestExpectations: Remove a test failure that skipped in qt.
* platform/qt/TestExpectations: Unskip now passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Thu, 23 May 2013 08:39:45 +0000 (08:39 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0-wk2/TestExpectations: Unskip after rebaseline.
* platform/qt/TestExpectations: Skip flaky test.
* platform/qt/plugins/mouse-events-expected.txt: Rebaselining after r150558.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Back, Forward and Stop should be hidden in context menu
commit-queue@webkit.org [Thu, 23 May 2013 07:06:30 +0000 (07:06 +0000)]
[EFL] Back, Forward and Stop should be hidden in context menu
https://bugs.webkit.org/show_bug.cgi?id=116615

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-05-23
Reviewed by Christophe Dumez.

Context menu items: Back, Forward, Stop, Reload, should be shown only when
they are able to perform action.

No new tests - no new functionality.

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdated the bug associated with the failure of media/context-menu-actions.html
rniwa@webkit.org [Thu, 23 May 2013 06:32:17 +0000 (06:32 +0000)]
Updated the bug associated with the failure of media/context-menu-actions.html
from the bug 45021 to the bug 116651 since the former is the bug for which this test was added.

Also skip this test it has been timing out intermittently.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate Mac test expectation for the bug 82980.
rniwa@webkit.org [Thu, 23 May 2013 06:22:54 +0000 (06:22 +0000)]
Update Mac test expectation for the bug 82980.
The test is consistently timing out instead of being flaky now.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd back two Lion test expectations after r150558 and r150559.
rniwa@webkit.org [Thu, 23 May 2013 06:20:28 +0000 (06:20 +0000)]
Add back two Lion test expectations after r150558 and r150559.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake the test expectation for the bug 116649 specific to WK2
rniwa@webkit.org [Thu, 23 May 2013 06:03:50 +0000 (06:03 +0000)]
Make the test expectation for the bug 116649 specific to WK2
as the test is passing on WK1.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMark media/audio-repaint.html as always failing on Mac.
rniwa@webkit.org [Thu, 23 May 2013 06:01:17 +0000 (06:01 +0000)]
Mark media/audio-repaint.html as always failing on Mac.

Also add back a failing test expectation to compositing/rtl/rtl-fixed-overflow-scrolled.html on Mac WK2.

Also add failing test expectation for the bug 116649.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse uninitialized register in "JIT::emit_op_neq_null" and "emit_op_eq_null"
commit-queue@webkit.org [Thu, 23 May 2013 05:18:36 +0000 (05:18 +0000)]
Use uninitialized register in "JIT::emit_op_neq_null" and "emit_op_eq_null"
https://bugs.webkit.org/show_bug.cgi?id=116593

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2013-05-22
Reviewed by Filip Pizlo.

Generated instructions using uninitialized register. It's caused by a mistake of r126494.

Source/JavaScriptCore:

* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

LayoutTests:

* fast/js/neq-null-crash-expected.txt: Added.
* fast/js/neq-null-crash.html: Added.
* fast/js/script-tests/neq-null-crash.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix indentation of CodeBlock.h
fpizlo@apple.com [Thu, 23 May 2013 05:00:01 +0000 (05:00 +0000)]
Fix indentation of CodeBlock.h

Rubber stampted by Mark Hahnenberg.

* bytecode/CodeBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
rniwa@webkit.org [Thu, 23 May 2013 04:26:59 +0000 (04:26 +0000)]
REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
https://bugs.webkit.org/show_bug.cgi?id=116595

Temporarily skip this test.

* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
gyuyoung.kim@samsung.com [Thu, 23 May 2013 03:41:20 +0000 (03:41 +0000)]
Unreviewed EFL gardening.

Skip 3 more tests which has problem related to ecore library.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRolling out r150555. It borked about 30 media tests.
dino@apple.com [Thu, 23 May 2013 03:36:15 +0000 (03:36 +0000)]
Rolling out r150555. It borked about 30 media tests.

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
* html/HTMLMediaElement.h:
* platform/audio/AudioSession.cpp:
(WebCore):
(WebCore::AudioSession::AudioSession):
(WebCore::AudioSession::preferredBufferDuration):
(WebCore::AudioSession::setPreferredBufferDuration):
* platform/audio/AudioSession.h:
* platform/audio/AudioSessionListener.h:
(AudioSessionListener):
* platform/audio/AudioSessionManager.cpp: Removed.
* platform/audio/AudioSessionManager.h: Removed.
* platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestinationIOS::configure):
* platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::preferredBufferDuration):
(WebCore::AudioSession::setPreferredBufferDuration):
* platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationMac::AudioDestinationMac):
(WebCore::AudioDestinationMac::configure):
* platform/audio/mac/AudioDestinationMac.h:
(AudioDestinationMac):
* platform/audio/mac/AudioSessionMac.cpp: Removed.
* platform/audio/mac/AudioSessionManagerMac.cpp: Removed.

Source/WTF:

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoActive DOM object resumption should match reason for suspending
jpfau@apple.com [Thu, 23 May 2013 01:11:33 +0000 (01:11 +0000)]
Active DOM object resumption should match reason for suspending
https://bugs.webkit.org/show_bug.cgi?id=116476

Add a reason to the arguments for resuming active DOM object and
scheduled tasks and ensure that it matches the suspend reason before
actually resuming the objects.

Reviewed by Joseph Pecoraro.

No new tests, no change in functionality.

* bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::setJavaScriptPaused): Add matching resume reason
* dom/Document.cpp:
(WebCore::Document::resumeActiveDOMObjects): Check for matching resume reason
(WebCore::Document::resumeScheduledTasks): Check for matching resume reason
* dom/Document.h:
(Document):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects): Check for matching resume reason
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
(WebCore::ScriptExecutionContext::reasonForSuspendingActiveDOMObjects): Expose suspend reason to subclasses
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore): Add matching resume reason
* page/Frame.cpp:
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations): Add matching resume reason
* page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): Add matching resume reason

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove even more stale Mac test expectations. These tests are passing now!
rniwa@webkit.org [Thu, 23 May 2013 01:07:45 +0000 (01:07 +0000)]
Remove even more stale Mac test expectations. These tests are passing now!

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEven more Mac test expectation updates.
rniwa@webkit.org [Thu, 23 May 2013 00:46:58 +0000 (00:46 +0000)]
Even more Mac test expectation updates.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
* platform/wk2/TestExpectations:
* plugins/mouse-events-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix; cast OSStatus to an int before passing it to printf.
jer.noble@apple.com [Thu, 23 May 2013 00:05:23 +0000 (00:05 +0000)]
Unreviewed build fix; cast OSStatus to an int before passing it to printf.

* platform/audio/mac/AudioSessionMac.cpp:
(WebCore::AudioSession::setPreferredBufferSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDon't snapshot plugins that can't be snapshotted
dino@apple.com [Thu, 23 May 2013 00:02:46 +0000 (00:02 +0000)]
Don't snapshot plugins that can't be snapshotted
https://bugs.webkit.org/show_bug.cgi?id=116490

Reviewed by Tim Horton.

Some plugins, such as QuickTime, don't support snapshotting. We're
planning on another way to capture snapshots, but in the meantime make
sure that they don't fail to initialise because they were told to
not use accelerated rendering.

Source/WebCore:

* WebCore.exp.in: Export restartSnapshottedPlugin so that it can be used from WK2.
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::restartSimilarPlugIns): Don't set the play state before restarting.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Make sure we indicated that this snapshotted plugin was clicked.
* html/HTMLPlugInImageElement.h: Move restartSnapshottedPlugin from protected to public.
* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::handleEvent): Don't set play state here. Let the restart functions do it.

Source/WebKit2:

Expose a new message on the plugins so that they can tell the PluginView
if they support snapshotting or not.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::supportsSnapshotting): New method.
* PluginProcess/PluginControllerProxy.h: Ditto.
* PluginProcess/PluginControllerProxy.messages.in: Message signature.

* WebProcess/Plugins/Netscape/NetscapePlugin.h: Add supportsSnapshotting.
* WebProcess/Plugins/PDF/SimplePDFPlugin.h: Ditto.
* WebProcess/Plugins/Plugin.h: Ditto - pure virtual here.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::supportsSnapshotting): Send the message to the plugin process and return the results.
* WebProcess/Plugins/PluginProxy.h:

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin): If the snapshotting plugin has a layer, make
    sure to add it to the tree.
(WebKit::PluginView::isAcceleratedCompositingEnabled): Snapshotting plugins can use
    accelerated compositing, just like normal plugins.
(WebKit::PluginView::pluginSnapshotTimerFired): If the plugin doesn't allow snapshotting,
    immediately restart it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMac: Set the default audio buffer size to a large value for <video> elements.
jer.noble@apple.com [Wed, 22 May 2013 23:43:33 +0000 (23:43 +0000)]
Mac: Set the default audio buffer size to a large value for <video> elements.
https://bugs.webkit.org/show_bug.cgi?id=116342

Reviewed by Eric Carlson.

Source/WebCore:

To enable power savings by waking up the audio hardware less often, set the
requested buffer frame size to a large value, such as 4096. Since this results
in approximately 100ms worth of buffer, set the buffer size to a much lower
value when playing WebAudio, which is much more sensitive to latency than video
or audio elements.

Introduce a new class, AudioSessionManager, as well as a helper class,
AudioSessionManagerToken. Audio elements, video elements, and WebAudio destination
nodes will create and retain a token, and release the token in their destructor.
This allows the AudioSessionManager to track how many of what type of audio-
generating objects are in existence.

This requires implementing AudioSession for Mac platforms. Move the implementation
for retrieving the hardware sample rate and setting the buffer duration into
AudioSessionMac from AudioDestinationMac, to be shared with AudioSessionManagerMac.

Change the AudioSession method preferredBufferLength() into preferredBufferSize(),
as the callers really want to specify a buffer size, not a buffer duration. On iOS,
where the available API requires a duration, perform the conversion from duration to
size on behalf of the caller.

* html/HTMLMediaElement.h:  Add a AudioSessionManagerToken member.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize the token.
* platform/audio/AudioSession.cpp:
(WebCore::AudioSession::preferredBufferSize): Renamed from preferredBufferLength.
(WebCore::AudioSession::setPreferredBufferSize): Renamed from setPreferredBufferLength.
* platform/audio/AudioSession.h:
* platform/audio/AudioSessionManager.cpp:
(AudioSessionManagerToken::create): Simple factory method.
(AudioSessionManagerToken::AudioSessionManagerToken): Call AudioSessionManager::incrementCount().
(AudioSessionManagerToken::~AudioSessionManagerToken): Call AudioSessionManager::decrementCount().
(AudioSessionManager::sharedManager): Simple singleton method.
(AudioSessionManager::AudioSessionManager): Simple constructor.
(AudioSessionManager::has): Return whether the type is present.
(AudioSessionManager::incrementCount): Increment, then call updateSessionState()
(AudioSessionManager::decrementCount): Decrement, then call updateSessionState()
(AudioSessionManager::updateSessionState): Stub, does nothing.
* platform/audio/AudioSessionManager.h:
* platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestinationIOS::configure): Call setPreferredBufferSize() instead of setPreferredBufferLength()
* platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::preferredBufferSize): Renamed from preferredBufferLength.
(WebCore::AudioSession::setPreferredBufferSize): Renamed from setPreferredBufferLength
* platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::hardwareSampleRate): Call AudioSession::sampleRate().
(WebCore::AudioDestinationMac::AudioDestinationMac): Create the AudioSessionManagerToken.
(WebCore::AudioDestinationMac::configure): Do not set the buffer size (this is done in AudioSessionManagerMac).
* platform/audio/mac/AudioDestinationMac.h:
* platform/audio/mac/AudioSessionMac.cpp: Added.
(WebCore::defaultDevice): Added, returns the default audio device.
(WebCore::AudioSession::AudioSession): Simple constructor.
(WebCore::AudioSession::~AudioSession): Simple destructor.
(WebCore::AudioSession::category): Stub, unimplemented.
(WebCore::AudioSession::setCategory): Ditto.
(WebCore::AudioSession::categoryOverride): Ditto.
(WebCore::AudioSession::setCategoryOverride): Ditto.
(WebCore::AudioSession::numberOfOutputChannels): Ditto.
(WebCore::AudioSession::setActive): Ditto.
(WebCore::AudioSession::sampleRate): Use the HAL to return the default audio device sample rate.
(WebCore::AudioSession::preferredBufferSize): Return the current HAL setting.
(WebCore::AudioSession::setPreferredBufferSize): Set the buffer size.
* platform/audio/mac/AudioSessionManagerMac.cpp:
(AudioSessionManager::updateSessionState): Set the buffer size depending on what audio outputs are present.
* WebCore.xcodeproj/project.pbxproj: Add the new files to the project.

Source/WTF:

* wtf/Platform.h: Add a WTF_USE_AUDIO_SESSION setting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shaders] valueForCustomFilterTransformParameter should check that renderer is...
mvujovic@adobe.com [Wed, 22 May 2013 23:42:57 +0000 (23:42 +0000)]
[CSS Shaders] valueForCustomFilterTransformParameter should check that renderer is a RenderBox
https://bugs.webkit.org/show_bug.cgi?id=116464

Reviewed by Alexandru Chiculita.

Source/WebCore:

If the renderer is not a RenderBox, we just use a zero size to compute the transform,
like in CSSComputedStyleDeclaration::computedTransform.

Test: css3/filters/custom/custom-filter-crash-inline-computed-style.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForCustomFilterTransformParameter):

LayoutTests:

* css3/filters/custom/custom-filter-crash-inline-computed-style-expected.txt: Added.
* css3/filters/custom/custom-filter-crash-inline-computed-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a missing result after r150551.
rniwa@webkit.org [Wed, 22 May 2013 23:27:54 +0000 (23:27 +0000)]
Add a missing result after r150551.

* http/tests/inspector/network/network-size-chunked-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMac test expectation corrections after r150545.
rniwa@webkit.org [Wed, 22 May 2013 23:24:51 +0000 (23:24 +0000)]
Mac test expectation corrections after r150545.

* platform/mac-lion/http/tests/multipart/policy-ignore-crash-expected.txt: Added.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore Mac test expectation cleanups.
rniwa@webkit.org [Wed, 22 May 2013 22:53:22 +0000 (22:53 +0000)]
More Mac test expectation cleanups.

* http/tests/inspector/network/network-size-sync-expected.txt:
* platform/mac/TestExpectations:
* platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix assertion in the getComputedStyle-background-shorthand.html test
simon.fraser@apple.com [Wed, 22 May 2013 22:19:18 +0000 (22:19 +0000)]
Fix assertion in the getComputedStyle-background-shorthand.html test
https://bugs.webkit.org/show_bug.cgi?id=116639

Reviewed by Ryosuke Niwa.

getComputedStyle-background-shorthand.html was asserting under the newly added
code in willBeRemovedFromTree(). The assertion was caused by too many calls to
FrameView::removeSlowRepaintObject(), which happened because we called it for
RenderTexts, which share style with their parent renderer.

RenderText overrides styleWillChange() to do nothing, so we never
call add/removeSlowRepaintObject() for them. Thus we should also skip this
work in willBeRemovedFromTree() for RenderTexts.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeRemovedFromTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION: fast/files/workers tests crash
rniwa@webkit.org [Wed, 22 May 2013 22:18:37 +0000 (22:18 +0000)]
REGRESSION: fast/files/workers tests crash
https://bugs.webkit.org/show_bug.cgi?id=45575

Unskip the test since they no longer crash. Also rebaseline two tests as needed.

* fast/files/workers/worker-read-blob-async-expected.txt:
* fast/files/workers/worker-read-blob-sync-expected.txt:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMac test expectation cleanups. Unskip a bunch of tests and rebaseline them as needed.
rniwa@webkit.org [Wed, 22 May 2013 22:11:07 +0000 (22:11 +0000)]
Mac test expectation cleanups. Unskip a bunch of tests and rebaseline them as needed.

* accessibility/aria-menubar-menuitems-expected.txt: Added.
* fast/replaced/border-radius-clip-expected.png:
* platform/mac/TestExpectations:
* platform/mac/fast/replaced/border-radius-clip-expected.txt:
* platform/mac/http/tests/multipart/policy-ignore-crash-expected.txt: Copied from LayoutTests/http/tests/multipart/policy-ignore-crash-expected.txt.
* platform/mac/media/video-volume-slider-expected.png: Added.
* platform/mac/media/video-volume-slider-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHeap-use-after-free in WebCore::RenderLayerModelObject::hasSelfPaintingLayer
commit-queue@webkit.org [Wed, 22 May 2013 22:08:21 +0000 (22:08 +0000)]
Heap-use-after-free in WebCore::RenderLayerModelObject::hasSelfPaintingLayer
https://bugs.webkit.org/show_bug.cgi?id=116626

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-05-22
Reviewed by David Hyatt.

This is a port of a Blink bug fix by Emil Eklund.

Account for saturated estimated position in RenderBlock::layoutBlockChild.

If the estimated top position is saturated the comparison with oldLogicalTop
might yield a false negative as adding and removing margins, borders etc from
a saturated number might yield incorrect results. If this is the case always
mark for layout.

Minimal test case impractical. See bug for raw fuzzer test case.

* platform/LayoutUnit.h:
(WebCore::LayoutUnit::mightBeSaturated): Add helper method for checking whether
    a number might be saturated.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChild): Check if logicalTopEstimate is likely
    to be saturated and if so mark for layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix crash when closing a page that's trying to access session storage
andersca@apple.com [Wed, 22 May 2013 21:25:22 +0000 (21:25 +0000)]
Fix crash when closing a page that's trying to access session storage
https://bugs.webkit.org/show_bug.cgi?id=116634
<rdar://problem/13904054>

Reviewed by Geoffrey Garen.

It is possible for the StorageManager to get messages from a web page that has already been closed by the UI process.
If that happens, just ignore the messages.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::getValues):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::removeItem):
(WebKit::StorageManager::clear):
(WebKit::StorageManager::destroySessionStorageNamespaceInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Exclusions] property parsing tests should be revised
hmuller@adobe.com [Wed, 22 May 2013 21:22:56 +0000 (21:22 +0000)]
[CSS Exclusions] property parsing tests should be revised
https://bugs.webkit.org/show_bug.cgi?id=116446

Reviewed by Alexandru Chiculita.

This is just a cleanup of the existing parsing tests. None of the tests have effectively
changed. The cleaned-up version should be simpler, more regular, and shorter:
- Moved all of parsing tests into a fast/exclusions/parsing subdirectory.
- Remove the obsolete "wrap-" prefix from file names.
- Eiminated excessive and needless stringification in many of the test functions.
- Moved common code into parsing-test-utils.js and refactored redundant code.

* fast/exclusions/parsing-wrap-shape-inside-expected.txt: Removed.
* fast/exclusions/parsing-wrap-shape-inside.html: Removed.
* fast/exclusions/parsing-wrap-shape-lengths-expected.txt: Removed.
* fast/exclusions/parsing-wrap-shape-lengths.html: Removed.
* fast/exclusions/parsing-wrap-shape-outside-expected.txt: Removed.
* fast/exclusions/parsing-wrap-shape-outside.html: Removed.
* fast/exclusions/parsing/parsing-shape-inside-expected.txt: Added.
* fast/exclusions/parsing/parsing-shape-inside.html: Added.
* fast/exclusions/parsing/parsing-shape-lengths-expected.txt: Added.
* fast/exclusions/parsing/parsing-shape-lengths.html: Added.
* fast/exclusions/parsing/parsing-shape-margin-expected.txt: Added.
* fast/exclusions/parsing/parsing-shape-margin.html: Added.
* fast/exclusions/parsing/parsing-shape-outside-expected.txt: Added.
* fast/exclusions/parsing/parsing-shape-outside.html: Added.
* fast/exclusions/parsing/parsing-shape-padding-expected.txt: Added.
* fast/exclusions/parsing/parsing-shape-padding.html: Added.
* fast/exclusions/parsing/parsing-wrap-flow-expected.txt: Added.
* fast/exclusions/parsing/parsing-wrap-flow.html: Added.
* fast/exclusions/parsing/parsing-wrap-through-expected.txt: Added.
* fast/exclusions/parsing/parsing-wrap-through.html: Added.
* fast/exclusions/parsing/script-tests/parsing-shape-inside.js: Added.
(string_appeared_here):
* fast/exclusions/parsing/script-tests/parsing-shape-lengths.js: Added.
(getStyleValue):
(testStyleValue):
(testComputedStyleValue):
(testInvalidValue):
* fast/exclusions/parsing/script-tests/parsing-shape-margin.js: Added.
(testShapeSpecifiedProperty):
* fast/exclusions/parsing/script-tests/parsing-shape-outside.js: Added.
(testShapePropertyParsingFailure):
* fast/exclusions/parsing/script-tests/parsing-shape-padding.js: Added.
(testShapeSpecifiedProperty):
* fast/exclusions/parsing/script-tests/parsing-test-utils.js: Added.
(getCSSText):
(getComputedStyleValue):
(getParentAndChildComputedStyles):
(getParentAndChildComputedStylesString):
(getChildComputedStyle):
(testShapeSpecifiedProperty):
(testShapeComputedProperty):
(testNotInheritedShapeChildProperty):
* fast/exclusions/parsing/script-tests/parsing-wrap-flow.js: Added.
* fast/exclusions/parsing/script-tests/parsing-wrap-through.js: Added.
* fast/exclusions/shape-margin-parsing-expected.txt: Removed.
* fast/exclusions/shape-margin-parsing.html: Removed.
* fast/exclusions/shape-padding-parsing-expected.txt: Removed.
* fast/exclusions/shape-padding-parsing.html: Removed.
* fast/exclusions/wrap-flow-parsing-expected.txt: Removed.
* fast/exclusions/wrap-flow-parsing.html: Removed.
* fast/exclusions/wrap-through-parsing-expected.txt: Removed.
* fast/exclusions/wrap-through-parsing.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove CSSPropertySourceData emptyCSSPropertySourceData
benjamin@webkit.org [Wed, 22 May 2013 20:52:07 +0000 (20:52 +0000)]
Remove CSSPropertySourceData emptyCSSPropertySourceData
https://bugs.webkit.org/show_bug.cgi?id=116517

Reviewed by Darin Adler.

This was added for chromium and does not seem to be used
anywhere anymore.

* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
* css/CSSPropertySourceData.cpp:
* css/CSSPropertySourceData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago Crashes in NetworkProcess due to incorrect private browsing session tracking
ap@apple.com [Wed, 22 May 2013 20:50:44 +0000 (20:50 +0000)]
    Crashes in NetworkProcess due to incorrect private browsing session tracking
        https://bugs.webkit.org/show_bug.cgi?id=116628

        Reviewed by Brady Eidson.

        The current API for private browsing makes it extremely difficult to track sessions.
        Private browsing is enabled via WKPreferences, but the session is shared, so it
        has to be maintained while there is any chance that any page group anywhere still
        needs it.

        This patch fixes some of the issues, but ultimately, I think that we'll just need
        to deprecate and replace the API.

        * NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::storageSession):
        There are valid scenarios where privateBrowsingEnabled is true, but there is no
        private browsing session. Handle that without crashing, although this unfortunately
        means that it will be harder to spot logic errors when using a wrong session.
        (WebKit::NetworkConnectionToWebProcess::registerBlobURL): Removed an obsolete FIXME.

        * NetworkProcess/mac/RemoteNetworkingContext.h: Changed privateBrowsingSession()
        to return a pointer, as no caller could know when it was safe to call it.

        * NetworkProcess/mac/RemoteNetworkingContext.mm:
        (WebKit::RemoteNetworkingContext::storageSession): Handle the case where private
        browsing session is unexpectedly missing without crashing.
        (WebKit::RemoteNetworkingContext::privateBrowsingSession): Changed to return a pointer.

        * UIProcess/WebContext.cpp: (WebKit::WebContext::ensureNetworkProcess):
        Actually initialize privateBrowsingEnabled creation parameter. It would be very
        difficult to figure out 100% reliably whether NetworkProcess needs a private browsing
        session with the current API, but for existing clients, looking at
        m_privateBrowsingEnterCount is good enough. Certainly better than not initializing.

        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::setPrivateBrowsingEnabled): Added a FIXME.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuildfix for !ENABLE(FULLSCREEN_API) platforms.
ossy@webkit.org [Wed, 22 May 2013 20:30:41 +0000 (20:30 +0000)]
Buildfix for !ENABLE(FULLSCREEN_API) platforms.

Rubber-stamped by Ryosuke Niwa.

* rendering/RenderInline.cpp: Missing #if guard added.
(WebCore::RenderInline::splitInlines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix a typo in 150469.
rniwa@webkit.org [Wed, 22 May 2013 20:11:56 +0000 (20:11 +0000)]
Fix a typo in 150469.

* editing/Editor.cpp:
(WebCore::dispatchEditableContentChangedEvents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[wk2] Should be able to make tiled WKViews clip to the view's exposed rect without...
timothy_horton@apple.com [Wed, 22 May 2013 19:48:26 +0000 (19:48 +0000)]
[wk2] Should be able to make tiled WKViews clip to the view's exposed rect without using autolayout
https://bugs.webkit.org/show_bug.cgi?id=116625
<rdar://problem/13962816>

Reviewed by Anders Carlsson.

The two modes are not dependent; it should be possible to enable
clips-to-exposed-rect without using autolayout. This enables apps to
make very large tiled WKViews that don't create tiles for the whole
area of the view (and also disables scrolling, since that is currently
incompatible with clipping to the exposed rect).

* UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView forceAsyncDrawingAreaSizeUpdate:]):
Rename _expandsToFitContentViaAutoLayout to _clipsToVisibleRect for accuracy.

(-[WKView setMinimumWidthForAutoLayout:]):
Factor clips-to-sisible-rect toggle out into setShouldClipToVisibleRect.

(-[WKView shouldClipToVisibleRect]):
(-[WKView setShouldClipToVisibleRect:]):
Allow setting clips-to-visible-rect without autolayout.

* UIProcess/API/mac/WKViewPrivate.h:
Add shouldClipToVisibleRect property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION: ASSERTION FAILED: obj->isRenderInline() || obj == this, Bad cast in WebCo...
rniwa@webkit.org [Wed, 22 May 2013 19:21:52 +0000 (19:21 +0000)]
REGRESSION: ASSERTION FAILED: obj->isRenderInline() || obj == this, Bad cast in WebCore::RenderBlock::createLineBoxes
https://bugs.webkit.org/show_bug.cgi?id=110622

Reviewed by David Hyatt.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/998ad358eed702b873dd54697b3fa3f952e0feb7

Inserting an element before the fullscreened element could crash if it caused a containing inline to be split,
since the splitting logic doesn't expect the fullscreened element to be wrapped in a RenderFullScreen. This patch changes
inline splitting to be aware of RenderFullScreen.

Test: fullscreen/full-screen-inline-split-crash.html

* rendering/RenderInline.cpp:
(WebCore::RenderInline::splitInlines):

LayoutTests:

Add a regression test.

* fullscreen/full-screen-inline-split-crash-expected.txt: Added.
* fullscreen/full-screen-inline-split-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix issues with focus rings on search fields
simon.fraser@apple.com [Wed, 22 May 2013 19:06:13 +0000 (19:06 +0000)]
Fix issues with focus rings on search fields
https://bugs.webkit.org/show_bug.cgi?id=116591

Source/WebCore:

Reviewed by Darin Adler.

On a future OS, the rect returned by _focusRingVisibleRect should
be in the coordinate system of the that NSView, not the base
coordinate system, so fix the code that sets and reads the global
focusRingClipRect variable accordingly.

* platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
* platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView _focusRingVisibleRect]):

Source/WebKit/mac:

Reviewed by Darin Adler.

In WebKit1, focus rings didn't render correctly on some OSes until
some other control drew a focus ring, which changes internal AppKit state
on the focused view. Fix by overriding an internal AppKit method to always
disable AppKit's "automatic" focus ring drawing.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _automaticFocusRingDisabled]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNew Flickr doesn't get fast scrolling but should
simon.fraser@apple.com [Wed, 22 May 2013 19:06:09 +0000 (19:06 +0000)]
New Flickr doesn't get fast scrolling but should
https://bugs.webkit.org/show_bug.cgi?id=116514

Source/WebCore:

Reviewed by Darin Adler.

RenderObject increments and decrements a counter of slow repaint objects on
FrameView when it sees style changes related to background-attachment:fixed.
However, it omitted to decrement the count when a renderer with a fixed background
was destroyed.

This caused Flickr to never fall into fast scrolling mode, since it toggled
display:none on an element with a fixed background during loading, then removed
the fixed background.

Did some minor cleanup of #ENABLE(FAST_MOBILE_SCROLLING) crap.

Tests: platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html
       platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html
       platform/mac-wk2/tiled-drawing/slow-scrolling.html

* rendering/RenderObject.cpp:
(WebCore::shouldRepaintFixedBackgroundsOnScroll):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::willBeRemovedFromTree):

LayoutTests:

Reviewed by Darin Adler.

slow-scrolling-hidden-background-toggle.html actually tests this patch. The other
two tests were added because there appear to be no tests for basic internals.mainThreadScrollingReasons()
functionality.

* platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html: Added.
* platform/mac-wk2/tiled-drawing/slow-scrolling-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle-expected.txt: Added.
* platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html: Added.
* platform/mac-wk2/tiled-drawing/slow-scrolling.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNeed to Remove Anonymous Wrappers When All Children Become Inline
robert@webkit.org [Wed, 22 May 2013 18:59:38 +0000 (18:59 +0000)]
Need to Remove Anonymous Wrappers When All Children Become Inline
https://bugs.webkit.org/show_bug.cgi?id=115687

Reviewed by David Hyatt.

Source/WebCore:

Remove a simple subset of anonymous wrappers, i.e. anonymous blocks without continuations,
when a block becoming float or positioned removes the need for them.

Test: fast/block/remove-anonymous-wrappers-when-element-changes-to-float-or-positioned.html

* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderObject.cpp:
(WebCore):
(WebCore::RenderObject::removeAnonymousWrappersFromLineIfNecessary):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):
* rendering/RenderObject.h:
(RenderObject):

LayoutTests:

* fast/block/remove-anonymous-wrappers-when-element-changes-to-float-or-positioned-expected.txt: Added.
* fast/block/remove-anonymous-wrappers-when-element-changes-to-float-or-positioned.html: Added.
* platform/qt/fast/block/float/float-not-removed-from-next-sibling2-expected.txt:
* platform/qt/fast/dynamic/002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[css] Update ETextDecorations enum to TextDecorations
bruno.abinader@basyskom.com [Wed, 22 May 2013 18:38:07 +0000 (18:38 +0000)]
[css] Update ETextDecorations enum to TextDecorations
https://bugs.webkit.org/show_bug.cgi?id=116581

Reviewed by Andreas Kling.

Currently, ETextDecorations enum uses a C-like coding style for its
enumeration values, as well as a 'E' prefix that surely had some meaning
in the past, but not nowadays.

No behavior changes, covered by existing tests.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::hasPlainText):
(WebCore::AccessibilityRenderObject::hasUnderline):
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(AXAttributeStringSetStyle):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(AXAttributeStringSetStyle):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationFlagsToCSSValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator TextDecoration):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyTextDecoration::createHandler):
* editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
* platform/mac/HTMLConverter.mm:
(+[WebHTMLConverter editingAttributedStringFromRange:]):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):
* rendering/InlineTextBox.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
(WebCore::operator|):
(WebCore::operator|=):
* rendering/style/StyleVisualData.h:
(StyleVisualData):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paint):
(WebCore::positionOffsetForDecoration):
(WebCore::thicknessForDecoration):
(WebCore::findRenderObjectDefininingTextDecoration):
(WebCore::SVGInlineTextBox::paintDecoration):
(WebCore::SVGInlineTextBox::paintDecorationWithStyle):
* rendering/svg/SVGInlineTextBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GStreamer] Allow multiple log levels in media player
commit-queue@webkit.org [Wed, 22 May 2013 18:30:55 +0000 (18:30 +0000)]
[GStreamer] Allow multiple log levels in media player
https://bugs.webkit.org/show_bug.cgi?id=116618

Patch by Lori Anderson <lori@rkymtnhi.com> on 2013-05-22
Reviewed by Philippe Normand.

No new tests, just changing logging.

* platform/graphics/gstreamer/GStreamerUtilities.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):
(WebCore::MediaPlayerPrivateGStreamer::pause):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Added myself to contributors.json.
achristensen@apple.com [Wed, 22 May 2013 18:13:32 +0000 (18:13 +0000)]
Unreviewed.  Added myself to contributors.json.

* Scripts/webkitpy/common/config/contributors.json:
Added myself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoThe LayoutMilestones didLayout callback sometimes fires with a milestone value of 0
bdakin@apple.com [Wed, 22 May 2013 18:06:23 +0000 (18:06 +0000)]
The LayoutMilestones didLayout callback sometimes fires with a milestone value of 0
https://bugs.webkit.org/show_bug.cgi?id=116623

Reviewed by Geoffrey Garen.

Make sure we have actually achieved some milestones before calling didLayout().
* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago Remove unused private browsing override support
ap@apple.com [Wed, 22 May 2013 17:09:13 +0000 (17:09 +0000)]
    Remove unused private browsing override support
        <rdar://problem/11969491>

        Rubber-stamped by Sam Weinig.

        Private browsing override is unused, and it complicates tracking of private
        browsing sessions in UI process (in fact, it doesn't plug into this tracking at all,
        so we would just assert if we used the API).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[sh4] Remove MacroAssemblerSH4.cpp file.
commit-queue@webkit.org [Wed, 22 May 2013 16:42:29 +0000 (16:42 +0000)]
[sh4] Remove MacroAssemblerSH4.cpp file.
https://bugs.webkit.org/show_bug.cgi?id=116596.

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-22
Reviewed by Geoffrey Garen.

Move linkCall and repatchCall implementations from MacroAssemblerSH4.cpp
to MacroAssemblerSH4.h and remove MacroAssemblerSH4.cpp, as it is done
for other architectures.

* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* assembler/MacroAssemblerSH4.cpp: Removed.
* assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::linkCall):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::repatchCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Reimplement atk_text_get_text_*_offset for CHAR boundary
mario@webkit.org [Wed, 22 May 2013 16:22:05 +0000 (16:22 +0000)]
[GTK] Reimplement atk_text_get_text_*_offset for CHAR boundary
https://bugs.webkit.org/show_bug.cgi?id=114870

Reviewed by Martin Robinson.

Re-implement this functions without using GailTextUtil nor Pango.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetChar): New function.
(webkitAccessibleTextGetTextForOffset): Call the new function for CHAR.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK2] Unreviewed gardening. Skipping failing printing tests after r150046.
zarvai@inf.u-szeged.hu [Wed, 22 May 2013 16:18:26 +0000 (16:18 +0000)]
[Qt][WK2] Unreviewed gardening. Skipping failing printing tests after r150046.
https://bugs.webkit.org/show_bug.cgi?id=116617

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Captions menu isn't internationalized, doesn't use rtl layout for rtl languages
graouts@apple.com [Wed, 22 May 2013 16:11:55 +0000 (16:11 +0000)]
[Mac] Captions menu isn't internationalized, doesn't use rtl layout for rtl languages
https://bugs.webkit.org/show_bug.cgi?id=116605

Reviewed by Eric Carlson.

Ensure that rtl languages are properly recognized by the captions menu such that text
layout and alignment is natural.

* css/mediaControls.css:
(::-webkit-media-controls):
Remove the forced "direction: ltr" property which was forcing all layout to be
left-to-right.

* css/mediaControlsQuickTime.css:
(video::-webkit-media-controls-closed-captions-track-list):
Remove the forced "text-align: left" property which was forcing all caption
titles to be left-aligned.

(video::-webkit-media-controls-closed-captions-track-list h3):
Use "-webkit-margin-start" instead of "padding-left" to position the heading
such that it adds the margin on the left for ltr languages and on the right
for rtl languages.

(video::-webkit-media-controls-closed-captions-track-list li):
Set "position: relative" such that the ::before pseudo-class can use "position: absolute"
to position itself relative to the caption title rather than the list element.

(video::-webkit-media-controls-closed-captions-track-list li.selected::before):
(video::-webkit-media-controls-closed-captions-track-list li.selected:hover::before):
Make the checkmarks a ::before pseudo-class rather than a background-image such that
we may control its positioning using the internationlization-friendly "-webkit-margin-start"
property.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsContainerElement::create):
Set the "dir" attribute to "auto" such that rtl languages are correctly handled. This
means that the first string displayed within the captions container, currently the
"Subtitles" <h3> element, defines the direction for the whole container. It is therefore
crucial that this string is properly localized in rtl languages as falling back to
english would mean the entire caption container is using ltr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Add sub menus to MiniBrowser
commit-queue@webkit.org [Wed, 22 May 2013 14:16:54 +0000 (14:16 +0000)]
[EFL][WK2] Add sub menus to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=114728

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-05-22
Reviewed by Christophe Dumez.

Elementary Ctxpopup widget API does not provide support for submenu item.
To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
Elementary Menu widget.

* MiniBrowser/efl/main.c:
(_Browser_Window):
(on_window_resize):
(window_free):
(context_menu_item_selected_cb):
(context_menu_populate):
(on_context_menu_show):
(on_context_menu_hide):
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Skip failing tests after r150065 and r150498.
kadam@inf.u-szeged.hu [Wed, 22 May 2013 14:15:31 +0000 (14:15 +0000)]
[Qt] Unreviewed gardening. Skip failing tests after r150065 and r150498.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebCore fails to compile with -Werror=maybe-uninitialized on GCC 4.8.0
hugo.lima@openbossa.org [Wed, 22 May 2013 13:45:15 +0000 (13:45 +0000)]
WebCore fails to compile with -Werror=maybe-uninitialized on GCC 4.8.0
https://bugs.webkit.org/show_bug.cgi?id=116340

Reviewed by Christophe Dumez.

No new tests, just a simple build fix.

* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem): Init frame variable.
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): Init frame variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] Remove platform-specific differences from offsetLeft/offsetTop tests
commit-queue@webkit.org [Wed, 22 May 2013 13:36:43 +0000 (13:36 +0000)]
[CSSRegions] Remove platform-specific differences from offsetLeft/offsetTop tests
https://bugs.webkit.org/show_bug.cgi?id=116607

Patch by Radu Stavila <stavila@adobe.com> on 2013-05-22
Reviewed by Antti Koivisto.

* fast/regions/offsetLeft-offsetTop-in-multiple-regions-expected.txt:
* fast/regions/offsetLeft-offsetTop-in-multiple-regions.html:
* fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl.html:
* fast/regions/offsetLeft-offsetTop-inlines-region-in-element.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Add command line option to MiniBrowser to set cookies policy.
commit-queue@webkit.org [Wed, 22 May 2013 12:49:15 +0000 (12:49 +0000)]
[EFL] Add command line option to MiniBrowser to set cookies policy.
https://bugs.webkit.org/show_bug.cgi?id=115028

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-05-22
Reviewed by Christophe Dumez.

Add command line option to MiniBrowser EFL to set cookies policy:
-p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).

* MiniBrowser/efl/main.c:
(elm_main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening, updating expected files after r150508.
zarvai@inf.u-szeged.hu [Wed, 22 May 2013 12:20:32 +0000 (12:20 +0000)]
[Qt] Unreviewed gardening, updating expected files after r150508.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22

* platform/qt-5.0-wk2/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
* platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHave IDL interface names match their global constructor
ch.dumez@sisa.samsung.com [Wed, 22 May 2013 12:04:35 +0000 (12:04 +0000)]
Have IDL interface names match their global constructor
https://bugs.webkit.org/show_bug.cgi?id=116520

Reviewed by Kentaro Hara.

Have IDL interface names match their global constructor name on DOMWindow.idl
using [InterfaceName] extended attribute. This affects in particular webkit
prefixed constructors. This is mandated by Web IDL specification:
http://dev.w3.org/2006/webapi/WebIDL/#es-interfaces

As a consequence, we can now get rid of [NoInterfaceObject] extended attribute
for those interfaces and have their global constructors automatically generated
by the bindings generator.

No new tests, no behavior change for layout tests.

* Modules/mediasource/MediaSource.idl:
* Modules/mediasource/SourceBuffer.idl:
* Modules/mediasource/SourceBufferList.idl:
* Modules/mediastream/MediaStream.idl:
* Modules/mediastream/RTCPeerConnection.idl:
* Modules/speech/SpeechGrammar.idl:
* Modules/speech/SpeechGrammarList.idl:
* Modules/speech/SpeechRecognition.idl:
* Modules/speech/SpeechRecognitionError.idl:
* Modules/speech/SpeechRecognitionEvent.idl:
* Modules/webaudio/OfflineAudioContext.idl:
* Modules/webaudio/PannerNode.idl:
* dom/ShadowRoot.idl:
* page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Unskipping some tests.
zarvai@inf.u-szeged.hu [Wed, 22 May 2013 11:42:40 +0000 (11:42 +0000)]
[Qt] Unreviewed gardening. Unskipping some tests.
https://bugs.webkit.org/show_bug.cgi?id=26830
https://bugs.webkit.org/show_bug.cgi?id=99870
https://bugs.webkit.org/show_bug.cgi?id=108429
https://bugs.webkit.org/show_bug.cgi?id=23166
https://bugs.webkit.org/show_bug.cgi?id=98523
https://bugs.webkit.org/show_bug.cgi?id=110654

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22

* platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
* platform/qt/TestExpectations:
* platform/qt/css2.1/20110323/replaced-elements-001-expected.png:
* platform/qt/css2.1/20110323/replaced-elements-001-expected.txt:
* platform/qt/css3/flexbox/button-expected.png: Added.
* platform/qt/css3/flexbox/button-expected.txt: Added.
* platform/qt/fast/css/background-clip-radius-values-expected.png: Added.
* platform/qt/fast/css/background-clip-radius-values-expected.txt: Added.
* platform/qt/fast/images/repaint-subrect-grid-expected.txt: Added.
* platform/qt/fast/multicol/single-line-expected.png: Added.
* platform/qt/fast/multicol/single-line-expected.txt: Added.
* platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png:
* platform/qt/svg/custom/foreign-object-skew-expected.txt:
* platform/qt/svg/custom/js-late-pattern-creation-expected.png:
* platform/qt/svg/custom/pattern-scaling-expected.png: Added.
* platform/qt/svg/custom/pattern-scaling-expected.txt: Added.
* platform/qt/svg/custom/pattern-skew-transformed-expected.png:
* platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Added.
* platform/qt/svg/custom/pattern-with-transformation-expected.png:
* platform/qt/svg/custom/text-ctm-expected.png:
* platform/qt/svg/custom/text-ctm-expected.txt:
* platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
* platform/qt/tables/mozilla/bugs/bug92647-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Change Ewk_Context_Menu_Item's parent menu to raw pointer
commit-queue@webkit.org [Wed, 22 May 2013 09:37:49 +0000 (09:37 +0000)]
[EFL][WK2] Change Ewk_Context_Menu_Item's parent menu to raw pointer
https://bugs.webkit.org/show_bug.cgi?id=116549

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-05-22
Reviewed by Christophe Dumez.

A context menu item should have only a pointer to parent menu instead
of owning parent menu.

* UIProcess/API/efl/ewk_context_menu_item.cpp:
(EwkContextMenuItem::EwkContextMenuItem):
* UIProcess/API/efl/ewk_context_menu_item_private.h:
(EwkContextMenuItem::create):
(EwkContextMenuItem::parentMenu):
(EwkContextMenuItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Unskipping some tests.
zarvai@inf.u-szeged.hu [Wed, 22 May 2013 09:25:55 +0000 (09:25 +0000)]
[Qt] Unreviewed gardening. Unskipping some tests.
https://bugs.webkit.org/show_bug.cgi?id=105437

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22

* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
* platform/qt/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.txt: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
* platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.txt: Added.
* platform/qt/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Copied from LayoutTests/platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.png.
* platform/qt/svg/filters/feImage-animated-transform-on-target-rect-expected.txt: Added.
* platform/qt/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
* platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
* platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
* platform/qt/svg/filters/feImage-late-indirect-update-expected.png:
* platform/qt/svg/filters/feImage-late-indirect-update-expected.txt: Added.
* platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.png:
* platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
* platform/qt/svg/filters/feImage-position-expected.png:
* platform/qt/svg/filters/feImage-position-expected.txt: Added.
* platform/qt/svg/filters/feImage-preserveAspectratio-expected.png:
* platform/qt/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
* platform/qt/svg/filters/feImage-reference-invalidation-expected.png:
* platform/qt/svg/filters/feImage-reference-invalidation-expected.txt: Added.
* platform/qt/svg/filters/feImage-subregions-expected.png:
* platform/qt/svg/filters/feImage-subregions-expected.txt: Added.
* platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
* platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.txt: Added.
* platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
* platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-add-to-document-expected.png:
* platform/qt/svg/filters/feImage-target-add-to-document-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-attribute-change-expected.png:
* platform/qt/svg/filters/feImage-target-attribute-change-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
* platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
* platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-changes-id-expected.png:
* platform/qt/svg/filters/feImage-target-changes-id-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-id-change-expected.png:
* platform/qt/svg/filters/feImage-target-id-change-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-inline-style-change-expected.png:
* platform/qt/svg/filters/feImage-target-inline-style-change-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-property-change-expected.png:
* platform/qt/svg/filters/feImage-target-property-change-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-reappend-to-document-expected.png:
* platform/qt/svg/filters/feImage-target-reappend-to-document-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-remove-from-document-expected.png:
* platform/qt/svg/filters/feImage-target-remove-from-document-expected.txt: Added.
* platform/qt/svg/filters/feImage-target-style-change-expected.png:
* platform/qt/svg/filters/feImage-target-style-change-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] accessibility/label-for-control-hittest.html is failing
commit-queue@webkit.org [Wed, 22 May 2013 07:24:14 +0000 (07:24 +0000)]
[EFL] accessibility/label-for-control-hittest.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112029

Unreviewed EFL gardening.

accessibility/label-for-control-hittest.html passes after r150439.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-05-22

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK2] Unreviewed buildfix after r150484.
ossy@webkit.org [Wed, 22 May 2013 07:07:15 +0000 (07:07 +0000)]
[Qt][WK2] Unreviewed buildfix after r150484.

* UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Update the background blending implementation to match the changes...
commit-queue@webkit.org [Wed, 22 May 2013 06:26:11 +0000 (06:26 +0000)]
Source/WebCore: Update the background blending implementation to match the changes done
in the spec. This implies that background color blending is removed and
the background layers won't blend with the content behind the element
any more.
https://bugs.webkit.org/show_bug.cgi?id=116212

Patch by Mihai Tica <mitica@adobe.com> on 2013-05-21
Reviewed by Dean Jackson.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

LayoutTests: Updating element background blending to conform to the changes in the spec.
This implies that the background layers won't longer blend with the content
behind the element.
Removing the background color tests, as background color blending is no longer
a valid use case, also modified the current background image tests.
https://bugs.webkit.org/show_bug.cgi?id=116212

Patch by Mihai Tica <mitica@adobe.com> on 2013-05-21
Reviewed by Dean Jackson.

* css3/compositing/effect-background-blend-mode-color-expected.txt: Removed.
* css3/compositing/effect-background-blend-mode-color.html: Removed.
* css3/compositing/effect-background-blend-mode-color2-expected.txt: Removed.
* css3/compositing/effect-background-blend-mode-color2.html: Removed.
* css3/compositing/effect-background-blend-mode-stacking-expected.png: Removed.
* css3/compositing/effect-background-blend-mode-stacking.html:
* platform/mac/css3/compositing/effect-background-blend-mode-color-expected.png: Removed.
* platform/mac/css3/compositing/effect-background-blend-mode-color2-expected.png: Removed.
* platform/mac/css3/compositing/effect-background-blend-mode-expected.png:
* platform/mac/css3/compositing/effect-background-blend-mode-stacking-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Cleanup TestExpectations to pass --lint-test-files
commit-queue@webkit.org [Wed, 22 May 2013 06:18:04 +0000 (06:18 +0000)]
[EFL] Cleanup TestExpectations to pass --lint-test-files
https://bugs.webkit.org/show_bug.cgi?id=116590

Unreviewed EFL gardening.

http/tests/websocket/tests/hybi/close-on-navigate-new-location.html was skipped in r150497.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-21

* platform/efl/TestExpectations: Remove duplicate entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Mac] inspector/geolocation-error.html is flaky
rniwa@webkit.org [Wed, 22 May 2013 06:09:57 +0000 (06:09 +0000)]
Web Inspector: [Mac] inspector/geolocation-error.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=116592

Add a flaky test expectation.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r150491): WebKit2.CloseThenTerminate asserting below WebContext::disconnec...
akling@apple.com [Wed, 22 May 2013 05:49:53 +0000 (05:49 +0000)]
REGRESSION(r150491): WebKit2.CloseThenTerminate asserting below WebContext::disconnectProcess().
<http://webkit.org/b/116588>

Reviewed by Sam Weinig.

Do an early return from WebProcessProxy::requestTermination() if there is no child process
connection to terminate.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::requestTermination):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows, curl] WebDownloadCurl.cpp should not include SystemTime.h
commit-queue@webkit.org [Wed, 22 May 2013 03:07:20 +0000 (03:07 +0000)]
[Windows, curl] WebDownloadCurl.cpp should not include SystemTime.h
https://bugs.webkit.org/show_bug.cgi?id=116584

Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-05-21
Reviewed by Brent Fulgham.

SystemTime header and implementation are no longer used and were removed
recently - http://trac.webkit.org/changeset/150216.

* WebDownloadCurl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse-after-free in DOMSelection::containsNode
rniwa@webkit.org [Wed, 22 May 2013 02:36:37 +0000 (02:36 +0000)]
Use-after-free in DOMSelection::containsNode
https://bugs.webkit.org/show_bug.cgi?id=116468

Reviewed by Andreas Kling.

Source/WebCore:

Retain the node pointer. Also bail out early if the node was not in the document
since Range::compareBoundaryPoints sets ec to WRONG_DOCUMENT_ERR otherwise.

Test: editing/selection/contains-node-crash.html

* page/DOMSelection.cpp:
(WebCore::DOMSelection::containsNode):
* page/DOMSelection.h:
(DOMSelection):

LayoutTests:

Add a regression test from https://chromium.googlesource.com/chromium/blink/+/40bb8089352b15dd034641b4c131111cd79b44f1.

* editing/selection/contains-node-crash-expected.txt: Added.
* editing/selection/contains-node-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
gyuyoung.kim@samsung.com [Wed, 22 May 2013 02:35:51 +0000 (02:35 +0000)]
Unreviewed EFL gardening.

Skip a test which has problem related to ecore library.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: InspectorFrontendHost::loadResourceSynchronously() builds ASCII-only...
commit-queue@webkit.org [Wed, 22 May 2013 02:13:58 +0000 (02:13 +0000)]
Web Inspector: InspectorFrontendHost::loadResourceSynchronously() builds ASCII-only results
https://bugs.webkit.org/show_bug.cgi?id=116569

Merge: https://chromium.googlesource.com/chromium/blink/+/7f1cfecfe34f4dbc6ce1ef0250b13f2058128eeb

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-05-21
Reviewed by Timothy Hatcher.

Source/WebCore:

Test: inspector/load-resource-synchronously-utf8.html

* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::loadResourceSynchronously):

LayoutTests:

* inspector/load-resource-synchronously-utf8-expected.txt: Added.
* inspector/load-resource-synchronously-utf8.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago<rdar://problem/13915556> Sluggish scrolling in web content
mrowe@apple.com [Wed, 22 May 2013 02:13:14 +0000 (02:13 +0000)]
<rdar://problem/13915556> Sluggish scrolling in web content

Reviewed by Gavin Barraclough.

* Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::setProcessSuppressionEnabled): When process suppression is disabled, low latency is important.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build break after r150484
gyuyoung.kim@samsung.com [Wed, 22 May 2013 01:47:39 +0000 (01:47 +0000)]
Fix build break after r150484

Unreviewed, fix build break on EFL, GTK.

* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
* UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r150369): WebKit2WillLoadTest tests are failing
rniwa@webkit.org [Wed, 22 May 2013 00:25:21 +0000 (00:25 +0000)]
REGRESSION(r150369): WebKit2WillLoadTest tests are failing
https://bugs.webkit.org/show_bug.cgi?id=116585

Reviewed by Alexey Proskuryakov.

willLoadURLRequest and willLoadDataRequest require the API version 6.

* TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCheck in the test and result I forgot to 'git add' before committing r150490.
aestes@apple.com [Wed, 22 May 2013 00:07:07 +0000 (00:07 +0000)]
Check in the test and result I forgot to 'git add' before committing r150490.

* http/tests/security/cross-origin-session-storage-third-party-blocked-expected.txt: Added.
* http/tests/security/cross-origin-session-storage-third-party-blocked.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPPT: Closing tab that is hung or chewing 100% CPU leaves abandoned WebProcess.
akling@apple.com [Wed, 22 May 2013 00:07:02 +0000 (00:07 +0000)]
PPT: Closing tab that is hung or chewing 100% CPU leaves abandoned WebProcess.
<http://webkit.org/b/116464>
<rdar://problem/10103795>

Reviewed by Anders Carlsson.

Simplify the web process sacrifice ritual. Instead of murderizing the process when its last tab closes,
just shut down the CoreIPC connection from the UI process. The web process, upon noticing this,
will start a 10 second watchdog timer, and if it hasn't shut down by the time it fires, well, it'll shut down.

(WebKit::WebProcessProxy::removeWebPage):

    When the last page is removed from a WebProcessProxy, disconnect the process so that it'll die off
    eventually, even if the WebPage::Close message never gets properly handled.

* Shared/ChildProcessProxy.h:
* Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::abortProcessLaunchIfNeeded):

    Added a helper to abort any in-progress launch of a new web process. Otherwise we'll have a race
    where the exiting web process may get re-used for a new tab.

* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::enableSuddenTermination):
(WebKit::WebProcessProxy::disableSuddenTermination):

    Remove WebProcessProxy's sudden termination counter. The web process will do what it needs in
    response to the WebPage::Close message. We still forward these calls to NSProcessInfo on Mac though.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAllow session storage for third-party origins even if third-party data access is...
aestes@apple.com [Wed, 22 May 2013 00:03:15 +0000 (00:03 +0000)]
Allow session storage for third-party origins even if third-party data access is blocked.
https://bugs.webkit.org/show_bug.cgi?id=116532

Reviewed by Anders Carlsson.

Source/WebCore:

In http://trac.webkit.org/changeset/149326 we relaxed our policy for
localStorage when third-party data blocking is enabled to create a
transient, session-scoped storage area for the third-party origin
instead of throwing an exception. Since this gives essentially the same
behavior as sessionStorage, we might as well also allow sessionStorage
for third-party origins.

Test: http/tests/security/cross-origin-session-storage-third-party-blocked.html

* WebCore.exp.in: Updated the symbol for
SecurityOrigin::canAccessStorage.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage): Called canAccessSessionStorage()
rather than canAccessLocalStorage().
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canAccessStorage): Passed in an enum
indicating if access should be allowed from third-party origins.
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canAccessSessionStorage): Called
canAccessStorage() with AlwaysAllowFromThirdParty.
(SecurityOrigin):

LayoutTests:

* http/tests/security/cross-origin-session-storage-third-party-blocked-expected.txt: Renamed from LayoutTests/http/tests/security/cross-origin-session-storage-expected.txt.
* http/tests/security/cross-origin-session-storage-third-party-blocked.html: Renamed from LayoutTests/http/tests/security/cross-origin-session-storage.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Windows] Unreviewed speculative fix for test-bots.
bfulgham@apple.com [Tue, 21 May 2013 23:53:49 +0000 (23:53 +0000)]
[Windows] Unreviewed speculative fix for test-bots.

Add export declaration for WTFInvokeCrashHook to avoid runtime
load error on test bots.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: inspector/styles/import-pseudoclass-crash.html intermittently hits...
rniwa@webkit.org [Tue, 21 May 2013 23:34:37 +0000 (23:34 +0000)]
Web Inspector: inspector/styles/import-pseudoclass-crash.html intermittently hits an assertion in HTMLLinkElement::startLoadingDynamicSheet
https://bugs.webkit.org/show_bug.cgi?id=116582

Add a flaky crash expectation.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate Mountain Lion test expectations per bug 116477.
rniwa@webkit.org [Tue, 21 May 2013 23:09:51 +0000 (23:09 +0000)]
Update Mountain Lion test expectations per bug 116477.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150487 268f45cc-cd09-0410-ab3c-d52691b4dbfc