WebKit-https.git
5 years agoRef-ify various Document-related things.
akling@apple.com [Fri, 19 Dec 2014 03:11:36 +0000 (03:11 +0000)]
Ref-ify various Document-related things.
<https://webkit.org/b/139796>

Reviewed by Anders Carlsson.

Source/WebCore:

* bindings/objc/DOMHTML.mm:
(-[DOMHTMLDocument createDocumentFragmentWithText:]):
* dom/CDATASection.cpp:
(WebCore::CDATASection::create):
(WebCore::CDATASection::virtualCreate):
* dom/CDATASection.h:
* dom/Comment.cpp:
(WebCore::Comment::create):
* dom/Comment.h:
* dom/Document.cpp:
(WebCore::Document::create):
(WebCore::Document::createDocumentFragment):
(WebCore::Document::createTextNode):
(WebCore::Document::createComment):
(WebCore::Document::createEditingTextNode):
(WebCore::Document::createCSSStyleDeclaration):
(WebCore::Document::createElement):
(WebCore::Document::createRange):
(WebCore::Document::createParser):
(WebCore::Document::cloneNodeInternal):
(WebCore::Document::cloneDocumentWithoutChildren):
* dom/Document.h:
(WebCore::Document::create):
(WebCore::Document::createXHTML):
(WebCore::Document::createNonRenderedPlaceholder):
* dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::create):
* dom/DocumentFragment.h:
* dom/DocumentType.h:
* dom/EntityReference.cpp:
(WebCore::EntityReference::create):
* dom/EntityReference.h:
* dom/Text.cpp:
(WebCore::Text::create):
(WebCore::Text::createEditingText):
(WebCore::Text::splitText):
(WebCore::Text::virtualCreate):
(WebCore::Text::createWithLengthLimit):
* dom/Text.h:
* editing/markup.cpp:
(WebCore::replaceChildrenWithText):
* html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocument::createParser):
* html/FTPDirectoryDocument.h:
* html/HTMLDocument.cpp:
(WebCore::HTMLDocument::createParser):
(WebCore::HTMLDocument::cloneDocumentWithoutChildren):
* html/HTMLDocument.h:
(WebCore::HTMLDocument::create):
(WebCore::HTMLDocument::createSynthesizedDocument):
* html/ImageDocument.cpp:
(WebCore::ImageDocument::createParser):
* html/ImageDocument.h:
* html/MediaDocument.cpp:
(WebCore::MediaDocument::createParser):
* html/MediaDocument.h:
* html/PluginDocument.cpp:
(WebCore::PluginDocument::createParser):
* html/PluginDocument.h:
* html/TextDocument.cpp:
(WebCore::TextDocument::createParser):
* html/TextDocument.h:
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertTextNode):
* html/parser/HTMLDocumentParser.h:
(WebCore::HTMLDocumentParser::create):
* loader/SinkDocument.cpp:
(WebCore::SinkDocument::createParser):
* loader/SinkDocument.h:
* svg/SVGDocument.cpp:
(WebCore::SVGDocument::cloneDocumentWithoutChildren):
* svg/SVGDocument.h:
* xml/parser/XMLDocumentParser.h:
(WebCore::XMLDocumentParser::create):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLParserContext::createStringParser):
(WebCore::XMLParserContext::createMemoryParser):

Source/WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):

Source/WebKit2:

* WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:
(-[WKDOMDocument createTextNode:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WinCairo] Compile error in code for creating GL context.
commit-queue@webkit.org [Fri, 19 Dec 2014 03:04:53 +0000 (03:04 +0000)]
[WinCairo] Compile error in code for creating GL context.
https://bugs.webkit.org/show_bug.cgi?id=139782

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-18
Reviewed by Alex Christensen.

The GLContext::createContextForWindow method has changed return type to std::unique_ptr.

* WebCoreSupport/AcceleratedCompositingContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSpeculative build fix.
bdakin@apple.com [Fri, 19 Dec 2014 02:11:58 +0000 (02:11 +0000)]
Speculative build fix.

* UIProcess/ProcessThrottler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd strong typing to RefCounter interface, return value as a bool.
barraclough@apple.com [Fri, 19 Dec 2014 01:42:20 +0000 (01:42 +0000)]
Add strong typing to RefCounter interface, return value as a bool.
https://bugs.webkit.org/show_bug.cgi?id=139776

Unreviewed style fixes.

* wtf/RefCounter.h:
(WTF::=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse MachSendRight in WebKit2
barraclough@apple.com [Fri, 19 Dec 2014 01:40:55 +0000 (01:40 +0000)]
Use MachSendRight in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=139800

Patch by Anders Carlsson <andersca@apple.com> on 2014-12-18
Reviewed by Tim Horton.

* Platform/IPC/ArgumentEncoder.h:
(IPC::ArgumentEncoder::encode):
(IPC::ArgumentEncoder::operator<<):
* Shared/WebCoreArgumentCoders.h:
* Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::encode):
(WebKit::RemoteLayerBackingStore::decode):
* Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<MachSendRight>::encode):
(IPC::ArgumentCoder<MachSendRight>::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Unreviewed build correction after r177513.
bfulgham@apple.com [Fri, 19 Dec 2014 01:28:46 +0000 (01:28 +0000)]
[Win] Unreviewed build correction after r177513.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Correct for new
method signature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix.
bfulgham@apple.com [Fri, 19 Dec 2014 01:17:53 +0000 (01:17 +0000)]
Unreviewed build fix.

* jsc.cpp: Remove typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Build correction after r177541.
bfulgham@apple.com [Fri, 19 Dec 2014 01:15:30 +0000 (01:15 +0000)]
[Win] Build correction after r177541.

* wtf/RefCounter.h:
(WTF::RefCounter::Token<T>::Token): Revise constructor inlines to correct
syntax error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse MachSendRight in WebKit2
andersca@apple.com [Fri, 19 Dec 2014 01:02:58 +0000 (01:02 +0000)]
Use MachSendRight in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=139800

Reviewed by Tim Horton.

Source/WebCore:

* WebCore.exp.in:
* platform/cocoa/MachSendRight.h:
(WebCore::MachSendRight::MachSendRight):
(WebCore::MachSendRight::sendRight):
* platform/graphics/cocoa/IOSurface.h:
* platform/graphics/cocoa/IOSurface.mm:
(IOSurface::createFromSendRight):
(IOSurface::createFromMachPort): Deleted.

Source/WebKit2:

* Platform/IPC/ArgumentEncoder.h:
(IPC::ArgumentEncoder::encode):
(IPC::ArgumentEncoder::operator<<):
* Shared/WebCoreArgumentCoders.h:
* Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::encode):
(WebKit::RemoteLayerBackingStore::decode):
* Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<MachSendRight>::encode):
(IPC::ArgumentCoder<MachSendRight>::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Update DumpRenderTree to more closely match Mac version
bfulgham@apple.com [Fri, 19 Dec 2014 01:00:23 +0000 (01:00 +0000)]
[Win] Update DumpRenderTree to more closely match Mac version
https://bugs.webkit.org/show_bug.cgi?id=139799

Reviewed by Tim Horton.

Source/WebKit/win:

* Interfaces/IWebSecurityOrigin.idl: Add initializer from URL.
* Interfaces/WebKit.idl: Add CLSID so we can instantiate a
WebSecurityOrigin from COM.
* WebApplicationCache.h: Decorate class declaration with CLSID
to support COM introspection.
* WebSecurityOrigin.cpp: Get rid of meaningless STDMETHODCALLTYPE
declarations inside implementation.
(WebSecurityOrigin::QueryInterface):
(WebSecurityOrigin::AddRef):
(WebSecurityOrigin::Release):
(WebSecurityOrigin::protocol):
(WebSecurityOrigin::host):
(WebSecurityOrigin::port):
(WebSecurityOrigin::usage):
(WebSecurityOrigin::quota):
(WebSecurityOrigin::setQuota):
(WebSecurityOrigin::initWithURL): Added.
* WebSecurityOrigin.h:

Tools:

* DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::accessibleElementById): Correct
use of BSTR to avoid leak.
* DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
update to match Mac version more closely.
(dumpFramesAsText):
(dump):
(resetDefaultsToConsistentValues):
(resetWebViewToConsistentStateBeforeTesting):
(sizeWebViewForCurrentTest):
(runTest):
(openWindows):
(windowToWebViewMap):
(createWebViewAndOffscreenWindow):
(sharedCFURLCache):
(initializeGlobalsFromCommandLineOptions):
(main):
* DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
(TestRunner::addDisallowedURL):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::syncLocalStorage):
(TestRunner::localStorageDiskUsageForOrigin):
(TestRunner::observeStorageTrackerNotifications):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::originsWithApplicationCache):
(TestRunner::deleteAllLocalStorage):
(TestRunner::setStorageDatabaseIdleInterval):
(TestRunner::closeIdleLocalStorageDatabases):
(TestRunner::originsWithLocalStorage):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::copyDecodedHostName):
(TestRunner::copyEncodedHostName):
(TestRunner::keepWebHistory):
(TestRunner::numberOfPendingGeolocationPermissionRequests):
(TestRunner::setAppCacheMaximumSize):
(TestRunner::setCustomPolicyDelegate):
(TestRunner::goBack):
(TestRunner::setDefersLoading):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::setMockDeviceOrientation):
(TestRunner::setMockGeolocationPosition):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setIconDatabaseEnabled):
(TestRunner::setMainFrameIsFirstResponder):
(TestRunner::setSpatialNavigationEnabled):
(TestRunner::setPluginsEnabled):
(TestRunner::setAutomaticLinkDetectionEnabled):
(TestRunner::setUseDashboardCompatibilityMode):
(TestRunner::dispatchPendingLoadRequests):
(TestRunner::findString):
(TestRunner::setCacheModel):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(TestRunner::setWebViewEditable):
(TestRunner::authenticateSession):
(TestRunner::abortModal):
(TestRunner::setSerializeHTTPLoads):
(TestRunner::addChromeInputField):
(TestRunner::removeChromeInputField):
(TestRunner::focusWebView):
(TestRunner::setBackingScaleFactor):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):
(TestRunner::removeAllWebNotificationPermissions):
(TestRunner::simulateWebNotificationClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd strong typing to RefCounter interface, return value as a bool.
barraclough@apple.com [Fri, 19 Dec 2014 00:51:47 +0000 (00:51 +0000)]
Add strong typing to RefCounter interface, return value as a bool.
https://bugs.webkit.org/show_bug.cgi?id=139776

Reviewed by Geoff Garen.

Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
This means there is no compile time type checking to prevent mistakes. Update the count()
method to token<>(), templated on type used to identify the token being returned.
Calls to token<T>() will return a result of type RefCounter::Token<T>.

There are a few problems with the fact the counter will return you an exact count of the
number of outstanding tokens:
  - It is desirable to only fire the callback on zero-edge changes; it is more consistent
    to do so if the value is only readable as a boolean.
  - It is desirable to provide the value as an argument to the callback, however to make
    this useful for integer values it is also necessary to indicate the direction of change
    (0->1 is often interesting where 2->1 is not).
  - There is a mismatch between the precision of returning a count, and the inherent
    imprecision of a token based mechanism, where it may be difficult to guarantee
    absolutely no unnecessary refcount churn, and thus unintentional counter values.

Source/WebCore:

* page/PageThrottler.cpp:
(WebCore::m_mediaActivityCounter):
(WebCore::m_pageLoadActivityCounter):
    - lambdas now passed the value.
(WebCore::PageThrottler::mediaActivityToken):
(WebCore::PageThrottler::pageLoadActivityToken):
    - count() -> token<>().
* page/PageThrottler.h:
    - specify tpoken type for PageActivityAssertionToken.

Source/WebKit2:

Removed PluginProcessManager::m_processSuppressionEnabled. Now the callback only fires on
zero-edge transitions we no longer need this to filter changes.

* UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::PluginProcessManager):
    - updateProcessSuppressionState -> updateProcessSuppressionDisabled.
* UIProcess/Plugins/PluginProcessManager.h:
(WebKit::PluginProcessManager::processSuppressionDisabledForPageCount): Deleted.
(WebKit::PluginProcessManager::processSuppressionDisabledToken):
    - processSuppressionDisabledForPageCount -> processSuppressionDisabledToken.
(WebKit::PluginProcessManager::processSuppressionEnabled): Deleted.
(WebKit::PluginProcessManager::processSuppressionDisabled):
    - processSuppressionEnabled -> processSuppressionDisabled.
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching):
    - processSuppressionEnabled -> processSuppressionDisabled.
* UIProcess/Plugins/mac/PluginProcessManagerMac.mm:
(WebKit::PluginProcessManager::updateProcessSuppressionState): Deleted.
(WebKit::PluginProcessManager::updateProcessSuppressionDisabled):
    - updateProcessSuppressionState -> updateProcessSuppressionDisabled
* UIProcess/ProcessThrottler.h:
    - added UserObservablePageToken, ProcessSuppressionDisabledToken types.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::m_processSuppressionDisabledForPageCounter):
    - lambda now has bool argument.
* UIProcess/WebContext.h:
(WebKit::WebContext::userObservablePageCount):
(WebKit::WebContext::processSuppressionDisabledForPageCount):
    - count() -> token<>(), changed return type.
* UIProcess/WebPageProxy.h:
    - changed types of token members.
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::updateProcessSuppressionState):
    renamed m_pluginProcessManagerProcessSuppressionDisabledCount -> m_pluginProcessManagerProcessSuppressionDisabledToken.

Source/WTF:

* wtf/RefCounter.cpp:
(WTF::RefCounter::Count::ref):
(WTF::RefCounter::Count::deref):
    - only call the callback on zero-edge changes; provide the value.
(WTF::RefCounter::RefCounter):
    - callback now takes a bool argument.
* wtf/RefCounter.h:
(WTF::RefCounter::Token::Token):
    - New opaque type to reference the RefCounter::Count.
(WTF::RefCounter::Token::operator!):
    - ! operator checks for null / anasigned Tokens.
(WTF::RefCounter::RefCounter):
    - callback now takes a bool argument.
(WTF::RefCounter::token):
    - renamed from count(), templated on type of token returned.
(WTF::RefCounter::value):
    - now returns a bool.
(WTF::RefCounter::Token<T>::Token):
(WTF::=):
    - Tokens can be copied & assigned.
(WTF::RefCounter::count): Deleted.
    - renamed to token<>().

Tools:

* TestWebKitAPI/Tests/WTF/RefCounter.cpp:
(TestWebKitAPI::TEST):
    - update API test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDisable retries on Mac Release WK2 testers
ap@apple.com [Fri, 19 Dec 2014 00:27:20 +0000 (00:27 +0000)]
Disable retries on Mac Release WK2 testers
https://bugs.webkit.org/show_bug.cgi?id=139798

Reviewed by Simon Fraser.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTry to fix some builds.
timothy_horton@apple.com [Fri, 19 Dec 2014 00:12:03 +0000 (00:12 +0000)]
Try to fix some builds.

* UIProcess/mac/WKPreviewPopoverAnimationController.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoHTMLFormControlElement and HTMLObjectElement need not to look for an ancestor on...
benjamin@webkit.org [Fri, 19 Dec 2014 00:03:08 +0000 (00:03 +0000)]
HTMLFormControlElement and HTMLObjectElement need not to look for an ancestor on construction
https://bugs.webkit.org/show_bug.cgi?id=139791

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-12-18
Reviewed by Alexey Proskuryakov.

The objects are being constructed, they have not been inserted into the tree yet.
There is not chance of finding the owner form at this point,
that is done when inserting the node into the tree.

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::HTMLObjectElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: Recursive crash at WebCore::accessibleNameForNode
cfleizach@apple.com [Thu, 18 Dec 2014 23:51:26 +0000 (23:51 +0000)]
AX: Recursive crash at WebCore::accessibleNameForNode
https://bugs.webkit.org/show_bug.cgi?id=139616

Reviewed by Mario Sanchez Prada.

Source/WebCore:

An image that uses aria-labelledby to reference its own parent can lead to a recursion crash.
There needs to be some information we can pass through these methods to ensure we don't hit this case.

Test: accessibility/accessibility-description-crash.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::textUnderElement):
(WebCore::accessibleNameForNode):
(WebCore::AccessibilityNodeObject::accessibilityDescriptionForElements):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityTextUnderElementMode::AccessibilityTextUnderElementMode):

LayoutTests:

* accessibility/accessibility-description-crash-expected.txt: Added.
* accessibility/accessibility-description-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: Heuristic: Avoid exposing an element as clickable if mouse event delegation is...
cfleizach@apple.com [Thu, 18 Dec 2014 23:25:27 +0000 (23:25 +0000)]
AX: Heuristic: Avoid exposing an element as clickable if mouse event delegation is handled on an element with any explicit ARIA role, including presentation.
https://bugs.webkit.org/show_bug.cgi?id=133613

Reviewed by Mario Sanchez Prada.

Source/WebCore:

This adds a heuristic to avoid a problem we have where too many objects that say they respond to press actions for accessibility.
It results from people installing click handlers on container nodes and then lots of static text objects are "clickable" in the eyes of VoiceOver.

What we can do is avoid this determination if the element is presentational.

Test: platform/mac/accessibility/press-action-for-presentational-descendants.html

* accessibility/AccessibilityObject.cpp:
(WebCore::nodeHasPresentationRole):
(WebCore::AccessibilityObject::supportsPressAction):
* accessibility/AccessibilityObject.h:
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):

LayoutTests:

* platform/mac/accessibility/press-action-for-presentational-descendants-expected.txt: Added.
* platform/mac/accessibility/press-action-for-presentational-descendants.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPerf tests frequently fail saying "build not up to date"
ap@apple.com [Thu, 18 Dec 2014 23:22:44 +0000 (23:22 +0000)]
Perf tests frequently fail saying "build not up to date"
https://bugs.webkit.org/show_bug.cgi?id=139786

Illegitimately yet authoritatively reviewed by Lucas Forschler.

Undo the rest of the first fix, and implement the behavior differently.

is_clean isn't automatically forwarded from config.json to properties.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CleanBuildUnconditionally):
(CleanBuildUnconditionally.start):
(DownloadAndPerfTestFactory.__init__):
(DownloadAndPerfTestWebKit2Factory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix build.
andersca@apple.com [Thu, 18 Dec 2014 23:14:23 +0000 (23:14 +0000)]
Fix build.

* UIProcess/API/mac/WKViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRoll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
ap@apple.com [Thu, 18 Dec 2014 23:06:18 +0000 (23:06 +0000)]
Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
found nothing.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(BuildAndPerfTestFactory):
(BuildAndPerfTestWebKit2Factory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAX: event.target should sometimes be a descendant element on AXPress-triggered mouse...
cfleizach@apple.com [Thu, 18 Dec 2014 22:59:22 +0000 (22:59 +0000)]
AX: event.target should sometimes be a descendant element on AXPress-triggered mouse clicks
https://bugs.webkit.org/show_bug.cgi?id=135689

Reviewed by Mario Sanchez Prada.

Source/WebCore:

When trying to find the right sub-node to target, we need to go back up the parent chain to find
an Element, in case we land on a Text node for example.

Test: accessibility/press-target-uses-text-descendant-node.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::press):

LayoutTests:

* accessibility/press-target-uses-text-descendant-node-expected.txt: Added.
* accessibility/press-target-uses-text-descendant-node.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd missing availability annotation on @property _featureCounterEnabled
cdumez@apple.com [Thu, 18 Dec 2014 22:59:15 +0000 (22:59 +0000)]
Add missing availability annotation on @property _featureCounterEnabled
https://bugs.webkit.org/show_bug.cgi?id=139794
<rdar://problem/19266254>

Rubber-stamped by Dan Bernstein.

Follow-up to r177526 adding availability annotation on @property
_featureCounterEnabled.

* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoNew perf dashboard should not duplicate author information in each commit
rniwa@webkit.org [Thu, 18 Dec 2014 22:53:52 +0000 (22:53 +0000)]
New perf dashboard should not duplicate author information in each commit
https://bugs.webkit.org/show_bug.cgi?id=139756

Reviewed by Darin Adler.

Instead of each commit having author name and email, make it reference a newly added committers table.
Also replace "email" by "account" since some repositories don't use emails as account names.

This improves the keyword search performance in commits.php since LIKE now runs on committers table,
which only contains as many rows as there are accounts in each repository, instead of commits table
which contains every commit ever happened in each repository.

To migrate an existing database into match the new schema, run:

BEGIN;

INSERT INTO committers (committer_repository, committer_name, committer_email)
    (SELECT DISTINCT commit_repository, commit_author_name, commit_author_email
        FROM commits WHERE commit_author_email IS NOT NULL);

ALTER TABLE commits ADD COLUMN commit_committer integer REFERENCES committers ON DELETE CASCADE;

UPDATE commits SET commit_committer = committer_id FROM committers
    WHERE commit_repository = committer_repository AND commit_author_email = committer_email;

ALTER TABLE commits DROP COLUMN commit_author_name CASCADE;
ALTER TABLE commits DROP COLUMN commit_author_email CASCADE;

COMMIT;

* init-database.sql: Added committers table, and replaced author columns in commits table by a foreign
reference to committers. Also added the missing drop table statements.

* public/api/commits.php:
(main): Fetch the corresponding committers row for a single commit. Also wrap a single commit by
an array here instead of doing it in format_commit.
(fetch_commits_between): Updated queries to JOIN commits with committers.
(format_commit): Takes both commit and committers rows. Also don't wrap the result in an array as that
is now done in main.

* public/api/report-commits.php:
(main): Store the reported committer information or update the existing entry if there is one.

* tests/admin-regenerate-manifest.js: Fixed tests.

* tests/api-report-commits.js: Ditto. Also added a test for updating an existing committer entry.

* tools/pull-svn.py: Renamed email to account.
(main):
(fetch_commit_and_resolve_author):
(fetch_commit):
(resolve_author_name_from_account):
(resolve_author_name_from_email): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPerf tests frequently fail saying "build not up to date"
ap@apple.com [Thu, 18 Dec 2014 22:51:09 +0000 (22:51 +0000)]
Perf tests frequently fail saying "build not up to date"
https://bugs.webkit.org/show_bug.cgi?id=139786

Reviewed by Ryosuke Niwa.

Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
directory to get rid of stale precompiled headers, and let it rebuild
DumpRenderTree each time, that's fast.

Also, removed unused "build and perf test" code.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoNeed to re-enable action menus
bdakin@apple.com [Thu, 18 Dec 2014 22:36:38 +0000 (22:36 +0000)]
Need to re-enable action menus
https://bugs.webkit.org/show_bug.cgi?id=139795
-and corresponding-
rdar://problem/19299367

Reviewed by Tim Horton.

Re-enable the menus by un-commenting the code to create the menu and controller.
Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit2:

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:context:configuration:webView:]):

performActionMenuHitTest already takes a parameter indicating whether the hit test
is for an immediate action or not. The callback didPerformActionMenuHitTest needs
that information too so that it knows whether to call into the
ActionMenuController or the ImmediateActionController.
(-[WKView _didPerformActionMenuHitTest:forImmediateAction:userData:]):
(-[WKView _didPerformActionMenuHitTest:userData:]): Deleted.
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didPerformActionMenuHitTest):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/mac/PageClientImpl.h:
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformActionMenuHitTest):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performActionMenuHitTestAtLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnify the Mac and iOS implementations of FontPlatformData a bit
weinig@apple.com [Thu, 18 Dec 2014 22:32:43 +0000 (22:32 +0000)]
Unify the Mac and iOS implementations of FontPlatformData a bit
https://bugs.webkit.org/show_bug.cgi?id=139721

Reviewed by Anders Carlsson.

Source/WebCore:

This is a first pass of unifying the Mac and iOS implementations of FontPlatformData.
Notable changes:
- Change the storage of the platform font to be CTFontRef across the board. Adds NSFont
  setter/getter/constructor as a temporary measures during the transition away from NSFont.
- Removes duplicate code that only differed by whether the type was NSFont or CTFontRef.
- Reduces the number of #ifdefs.

* platform/graphics/FontPlatformData.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::openTypeTable): Deleted.
* platform/graphics/FontPlatformData.h:
(WebCore::FontPlatformData::nsFont):
(WebCore::FontPlatformData::setNSFont):
(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::operator==):
(WebCore::FontPlatformData::isHashTableDeletedValue):
(WebCore::toCTFontRef): Deleted.
(WebCore::FontPlatformData::font): Deleted.
(WebCore::FontPlatformData::roundsGlyphAdvances): Deleted.
(WebCore::FontPlatformData::cgFont): Deleted.
(WebCore::FontPlatformData::hashTableDeletedFontValue): Deleted.
* platform/graphics/SimpleFontData.h:
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::setFont):
(WebCore::FontPlatformData::roundsGlyphAdvances):
(WebCore::FontPlatformData::allowsLigatures):
(WebCore::FontPlatformData::ctFont):
(WebCore::FontPlatformData::openTypeTable):
(WebCore::FontPlatformData::loadFont): Deleted.
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::systemFallbackForCharacters):
* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCompositeFontReferenceFontData):
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCreateScaledFontData):
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::renderingStyle):
(WebCore::SimpleFontData::advanceForColorBitmapFont):

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(fontNameForDescription):
Update for new function name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WK2] Stop using WKPreferencesPrivate API to toggle FeatureCounter support
cdumez@apple.com [Thu, 18 Dec 2014 22:32:37 +0000 (22:32 +0000)]
[WK2] Stop using WKPreferencesPrivate API to toggle FeatureCounter support
https://bugs.webkit.org/show_bug.cgi?id=139794
<rdar://problem/19266254>

Reviewed by Anders Carlsson.

Stop using WKPreferencesPrivate API to toggle FeatureCounter support
and use WKWebViewConfigurationPrivate API instead. FeatureCounter is
not meant to change state after the view has been created.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetFeatureCounterEnabled): Deleted.
(WKPreferencesGetFeatureCounterEnabled): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _featureCounterEnabled]): Deleted.
(-[WKPreferences _setFeatureCounterEnabled:]): Deleted.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _featureCounterEnabled]):
(-[WKWebViewConfiguration _setFeatureCounterEnabled:]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the build.
timothy_horton@apple.com [Thu, 18 Dec 2014 22:29:50 +0000 (22:29 +0000)]
Fix the build.

* UIProcess/API/mac/WKView.mm:
(-[WKView _setPreviewOverrideImage:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBuild fix.
andersca@apple.com [Thu, 18 Dec 2014 22:29:45 +0000 (22:29 +0000)]
Build fix.

* platform/cocoa/MachSendRight.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSimplify smart pointer classes by using std::exchange
andersca@apple.com [Thu, 18 Dec 2014 22:27:18 +0000 (22:27 +0000)]
Simplify smart pointer classes by using std::exchange
https://bugs.webkit.org/show_bug.cgi?id=139790

Reviewed by Andreas Kling.

* wtf/MallocPtr.h:
* wtf/OSObjectPtr.h:
* wtf/OwnPtr.h:
(WTF::OwnPtr<T>::clear):
(WTF::OwnPtr<T>::release):
(WTF::OwnPtr<T>::leakPtr):
(WTF::=):
* wtf/PassOwnPtr.h:
(WTF::PassOwnPtr<T>::leakPtr):
* wtf/PassRefPtr.h:
(WTF::PassRefPtr<T>::leakRef):
* wtf/Ref.h:
* wtf/RefPtr.h:
(WTF::RefPtr<T>::clear):
(WTF::RefPtr<T>::leakRef):
* wtf/RetainPtr.h:
(WTF::RetainPtr<T>::leakRef):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoChange page preview loading order, and add a TextIndicator
timothy_horton@apple.com [Thu, 18 Dec 2014 22:14:18 +0000 (22:14 +0000)]
Change page preview loading order, and add a TextIndicator
https://bugs.webkit.org/show_bug.cgi?id=139793
<rdar://problem/19288547>

Reviewed by Beth Dakin.

* Shared/mac/ActionMenuHitTestResult.h:
* Shared/mac/ActionMenuHitTestResult.mm:
(WebKit::ActionMenuHitTestResult::encode):
(WebKit::ActionMenuHitTestResult::decode):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performActionMenuHitTestAtLocation):
Build a TextIndicator for links.

* UIProcess/API/Cocoa/WKViewPrivate.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView _dismissContentRelativeChildWindows]):
(-[WKView _setPreviewTitle:]):
(-[WKView _setPreviewLoading:]):
Remove unneeded WK_API_ENABLED #ifs.

(-[WKView _setPreviewOverrideImage:]):
Add; forward to WKImmediateActionController.

* UIProcess/mac/WKImmediateActionController.h:
* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController willDestroyView:]):
Shut down the WKPreviewPopoverAnimationController.

(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):
Don't build an immediate action item here; we'll always build it in
willBeginAnimation, and the one we build here is likely to be wrong.

(-[WKImmediateActionController _defaultAnimationController]):
(-[WKImmediateActionController hidePreview]):
(-[WKImmediateActionController setPreviewTitle:]):
(-[WKImmediateActionController setPreviewLoading:]):
(-[WKImmediateActionController setPreviewOverrideImage:]):
(-[WKImmediateActionController _animationControllerForCustomPreview]):
(-[WKImmediateActionController _createPreviewPopoverIfNeededForURL:]): Deleted.
(-[WKImmediateActionController popoverWillClose:]): Deleted.
(targetSizeFitsInAvailableSpace): Deleted.
(-[WKImmediateActionController largestPopoverSize]): Deleted.
(-[WKImmediateActionController _preferredPopoverSizeWithPreviewPadding:]): Deleted.
(-[WKImmediateActionController pagePreviewViewController:viewForPreviewingURL:initialFrameSize:]): Deleted.
(-[WKImmediateActionController pagePreviewViewController:titleForPreviewOfURL:]): Deleted.
(-[WKImmediateActionController pagePreviewViewControllerWasClicked:]): Deleted.
Move preview popover code to WKPreviewPopoverAnimationController.
Install and uninstall the link text indicator when necessary.

* UIProcess/mac/WKPagePreviewViewController.h:
* UIProcess/mac/WKPagePreviewViewController.mm:
(-[WKPagePreviewViewController setLoading:]):
(-[WKPagePreviewViewController loadView]):
(-[WKPagePreviewViewController replacePreviewWithImage:atSize:]):
Allow overriding the preview with a full-view NSImage.
Hide the preview view until the loading spinner goes away.

* UIProcess/mac/WKPreviewPopoverAnimationController.h: Copied from Source/WebKit2/UIProcess/mac/WKImmediateActionController.h.
* UIProcess/mac/WKPreviewPopoverAnimationController.mm: Added.
(+[WKPreviewPopoverAnimationController _shouldImmediatelyShowPreview]):
(-[WKPreviewPopoverAnimationController initWithURL:view:page:originRect:eventLocationInView:]):
(-[WKPreviewPopoverAnimationController close]):
(-[WKPreviewPopoverAnimationController setPreviewLoading:]):
(-[WKPreviewPopoverAnimationController setPreviewOverrideImage:]):
If we have shown the popover, choose a size strictly smaller than
its current size.

(-[WKPreviewPopoverAnimationController _hidePreview]):
(-[WKPreviewPopoverAnimationController setPreviewTitle:]):
(-[WKPreviewPopoverAnimationController _createPreviewPopover]):
(-[WKPreviewPopoverAnimationController _showPreview]):
(targetSizeFitsInAvailableSpace):
(-[WKPreviewPopoverAnimationController largestPopoverSize]):
(-[WKPreviewPopoverAnimationController _targetSizeForPagePreview]):
(-[WKPreviewPopoverAnimationController _preferredPopoverSizeWithPreviewPadding:forTargetSize:]):
(-[WKPreviewPopoverAnimationController _previewWatchdogTimerFired:]):
(-[WKPreviewPopoverAnimationController recognizerWillBeginAnimation:]):
(-[WKPreviewPopoverAnimationController recognizerDidUpdateAnimation:]):
(-[WKPreviewPopoverAnimationController recognizerDidCancelAnimation:]):
(-[WKPreviewPopoverAnimationController recognizerDidCompleteAnimation:]):
(-[WKPreviewPopoverAnimationController recognizerDidDismissAnimation:]):
(-[WKPreviewPopoverAnimationController pagePreviewViewController:viewForPreviewingURL:initialFrameSize:]):
(-[WKPreviewPopoverAnimationController pagePreviewViewController:titleForPreviewOfURL:]):
(-[WKPreviewPopoverAnimationController pagePreviewViewControllerWasClicked:]):
(-[WKPreviewPopoverAnimationController popoverWillClose:]):
Move code in from WKImmediateActionController.
Forward NSImmediateActionAnimationControllerDelegate methods
to the popover's animation controller if we've popped it.
Pop the popover if we've loaded or 1 second has passed, whichever
comes first.

* WebKit2.xcodeproj/project.pbxproj:

* WebCore.exp.in:
* platform/spi/mac/NSPopoverSPI.h:
Add an export and some SPI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClean up MachSendRight and add a copySendRight member function
andersca@apple.com [Thu, 18 Dec 2014 21:31:03 +0000 (21:31 +0000)]
Clean up MachSendRight and add a copySendRight member function
https://bugs.webkit.org/show_bug.cgi?id=139788

Reviewed by Tim Horton.

Source/WebCore:

* platform/cocoa/MachSendRight.cpp:
(WebCore::retainSendRight):
(WebCore::releaseSendRight):
Use mach_error_string.

(WebCore::MachSendRight::copySendRight):
Create a new send right with the given mach port.

(WebCore::MachSendRight::leakSendRight):
Use std::exchange.

* platform/cocoa/MachSendRight.h:

Source/WTF:

* wtf/StdLibExtras.h:
(std::exchange):
Add an implementation of std::exchange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agomedia/media-controls-timeline-updates.html is flaky
ap@apple.com [Thu, 18 Dec 2014 21:29:23 +0000 (21:29 +0000)]
media/media-controls-timeline-updates.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139789

* platform/mac/TestExpectations: Mark it as such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Updated expected results for LayoutTests/editing
dbates@webkit.org [Thu, 18 Dec 2014 21:18:56 +0000 (21:18 +0000)]
[iOS] Updated expected results for LayoutTests/editing

* platform/ios-simulator-wk2/TestExpectations:
[...]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: ASSERT seen closing/opening multiple inspectors
commit-queue@webkit.org [Thu, 18 Dec 2014 20:45:19 +0000 (20:45 +0000)]
Web Inspector: ASSERT seen closing/opening multiple inspectors
https://bugs.webkit.org/show_bug.cgi?id=139783

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-12-18
Reviewed by Timothy Hatcher.

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::nodeForObjectId):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUpdate flaky media test expectations to what bots see now - mostly updating for
ap@apple.com [Thu, 18 Dec 2014 20:38:57 +0000 (20:38 +0000)]
Update flaky media test expectations to what bots see now - mostly updating for
better detection of timeouts.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a MachSendRight class to WebCore and use it in IOSurface
andersca@apple.com [Thu, 18 Dec 2014 20:29:19 +0000 (20:29 +0000)]
Add a MachSendRight class to WebCore and use it in IOSurface
https://bugs.webkit.org/show_bug.cgi?id=139787

Reviewed by Tim Horton.

Source/WebCore:

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* platform/cocoa/MachSendRight.cpp: Added.
(WebCore::retainSendRight):
(WebCore::releaseSendRight):
(WebCore::MachSendRight::adopt):
(WebCore::MachSendRight::create):
(WebCore::MachSendRight::MachSendRight):
(WebCore::MachSendRight::~MachSendRight):
(WebCore::MachSendRight::operator=):
(WebCore::MachSendRight::leakSendRight):
* platform/cocoa/MachSendRight.h: Added.
* platform/graphics/cocoa/IOSurface.h:
* platform/graphics/cocoa/IOSurface.mm:
(IOSurface::createSendRight):
(IOSurface::createMachPort): Deleted.

Source/WebKit2:

* Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::encode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Unreviewed gardening. Reorder file contents to match Mac version.
bfulgham@apple.com [Thu, 18 Dec 2014 20:25:21 +0000 (20:25 +0000)]
[Win] Unreviewed gardening. Reorder file contents to match Mac version.

Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
it easier to see what steps are missing when running under Windows.

* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::callShouldCloseOnWebView):
(TestRunner::clearAllApplicationCaches):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::syncLocalStorage):
(TestRunner::localStorageDiskUsageForOrigin):
(TestRunner::observeStorageTrackerNotifications):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::originsWithApplicationCache):
(TestRunner::clearAllDatabases):
(TestRunner::deleteAllLocalStorage):
(TestRunner::setStorageDatabaseIdleInterval):
(TestRunner::closeIdleLocalStorageDatabases):
(TestRunner::originsWithLocalStorage):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::numberOfPendingGeolocationPermissionRequests):
(jsStringRefToWString):
(TestRunner::setAppCacheMaximumSize):
(TestRunner::setDatabaseQuota):
(TestRunner::goBack):
(TestRunner::setDefersLoading):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::setAutomaticLinkDetectionEnabled):
(TestRunner::dispatchPendingLoadRequests):
(TestRunner::overridePreference):
(TestRunner::removeAllVisitedLinks):
(TestRunner::waitForPolicyDelegate):
(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):
(TestRunner::removeAllWebNotificationPermissions):
(TestRunner::simulateWebNotificationClick):
(TestRunner::simulateLegacyWebNotificationClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRef-ify DOMSettableTokenList.
akling@apple.com [Thu, 18 Dec 2014 20:22:50 +0000 (20:22 +0000)]
Ref-ify DOMSettableTokenList.
<https://webkit.org/b/139785>

Reviewed by Chris Dumez.

Make DOMSettableTokenList::create() return a Ref, and have its two client
elements store it in a Ref instead of a RefPtr (and fix their getter API
to return references.)

* html/DOMSettableTokenList.cpp:
(WebCore::DOMSettableTokenList::create): Deleted.
* html/DOMSettableTokenList.h:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::sizes): Deleted.
* html/HTMLLinkElement.h:
* html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::htmlFor): Deleted.
* html/HTMLOutputElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRef-ify ClientRectList.
akling@apple.com [Thu, 18 Dec 2014 20:21:24 +0000 (20:21 +0000)]
Ref-ify ClientRectList.
<https://webkit.org/b/139780>

Reviewed by Anders Carlsson.

Make the ClientRectList::create() helpers return Ref, along with a bunch
of other functions that always return non-null ClientRectLists.

Also make ClientRectList store a Vector<Ref<ClientRect>> internally since
entries in the Vector are never null.

* dom/ClientRectList.cpp:
(WebCore::ClientRectList::item):
* dom/ClientRectList.h:
(WebCore::ClientRectList::create):
* dom/Element.cpp:
(WebCore::Element::getClientRects):
* dom/Element.h:
* dom/Range.cpp:
(WebCore::Range::getClientRects):
* dom/Range.h:
* page/Page.cpp:
(WebCore::Page::nonFastScrollableRects):
* page/Page.h:
* testing/Internals.cpp:
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::nonFastScrollableRects):
* testing/Internals.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSource/WebKit:
bfulgham@apple.com [Thu, 18 Dec 2014 19:56:46 +0000 (19:56 +0000)]
Source/WebKit:
[Win] Correct Windows tests after Bug 139149.
https://bugs.webkit.org/show_bug.cgi?id=139781

Reviewed by Anders Carlsson.

* WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Add new interface.
* WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters: Ditto.
* WebKit.vcxproj/WebKit/WebKit.vcxproj: Add new application cache object.
* WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Ditto.

Source/WebKit/win:
[Win] Correct Windows tests after Bug 139149.
https://bugs.webkit.org/show_bug.cgi?id=139781

Reviewed by Anders Carlsson.

* Interfaces/IWebApplicationCache.idl: Added.
* Interfaces/WebKit.idl: Add new IDL file.
* WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read): Remove old debugging message.
* WebApplicationCache.cpp: Added.
(WebApplicationCache::WebApplicationCache):
(WebApplicationCache::~WebApplicationCache):
(WebApplicationCache::createInstance):
(WebApplicationCache::QueryInterface):
(WebApplicationCache::AddRef):
(WebApplicationCache::Release):
(WebApplicationCache::maximumSize):
(WebApplicationCache::setMaximumSize):
(WebApplicationCache::defaultOriginQuota):
(WebApplicationCache::setDefaultOriginQuota):
(WebApplicationCache::diskUsageForOrigin):
(WebApplicationCache::deleteAllApplicationCaches):
(WebApplicationCache::deleteCacheForOrigin):
(WebApplicationCache::originsWithCache):
* WebApplicationCache.h: Added.
* WebKitClassFactory.cpp: Add new interface header.

Tools:
[Win] Correct Windows tests after Bug 139149 (edit)
https://bugs.webkit.org/show_bug.cgi?id=139781

Reviewed by Anders Carlsson.

* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
interface.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAttempt to fix Windows build after Range::create() changes.
akling@apple.com [Thu, 18 Dec 2014 19:52:03 +0000 (19:52 +0000)]
Attempt to fix Windows build after Range::create() changes.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim...
simon.fraser@apple.com [Thu, 18 Dec 2014 19:50:04 +0000 (19:50 +0000)]
[iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
https://bugs.webkit.org/show_bug.cgi?id=139748

Reviewed by Daniel Bates.

Staging change to support --ios-sim and --ios-simulator temporarily until the bots
have all been updated.

* Scripts/webkitpy/port/factory.py:
(platform_options):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRef-ify ClientRect.
akling@apple.com [Thu, 18 Dec 2014 19:31:43 +0000 (19:31 +0000)]
Ref-ify ClientRect.
<https://webkit.org/b/139777>

Reviewed by Anders Carlsson.

Make the ClientRect::create() helpers return Ref, along with a bunch
of other functions that always return non-null ClientRects.

* dom/ClientRect.h:
(WebCore::ClientRect::create):
* dom/Element.cpp:
(WebCore::Element::getBoundingClientRect):
* dom/Element.h:
* dom/Range.cpp:
(WebCore::Range::getBoundingClientRect):
* dom/Range.h:
* html/track/VTTRegion.cpp:
(WebCore::VTTRegion::displayLastTextTrackCueBox):
* testing/Internals.cpp:
(WebCore::Internals::absoluteCaretBounds):
(WebCore::Internals::boundingBox):
(WebCore::Internals::selectionBounds):
* testing/Internals.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agohttps://bugs.webkit.org/show_bug.cgi?id=139779
ap@apple.com [Thu, 18 Dec 2014 19:24:08 +0000 (19:24 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=139779
Fullscreen tests use unreasonably short timeouts

Reviewed by Eric Carlson.

* fullscreen/exit-full-screen-iframe.html:
* fullscreen/full-screen-iframe-allowed-prefixed.html:
* fullscreen/full-screen-iframe-allowed.html:
* fullscreen/full-screen-iframe-legacy.html:
* fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html:
* fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html:
Removed the timeouts.

* platform/mac-wk1/TestExpectations: fullscreen/exit-full-screen-iframe.html
legitimately fails in DumpRenderTree, which we didn't know about.

* platform/mac/TestExpectations: Removed tests that should no longer be flaky now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoBuild more of TestWebKitAPI for iOS
simon.fraser@apple.com [Thu, 18 Dec 2014 19:22:48 +0000 (19:22 +0000)]
Build more of TestWebKitAPI for iOS
https://bugs.webkit.org/show_bug.cgi?id=139747

Reviewed by Daniel Bates.

Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
which excluded some tests that should be run for iOS.

Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
available (i.e. Mac OS X), and most files use that. Some files with Mac-only
functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).

Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
to share code between Mac and iOS.

* TestWebKitAPI/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
* TestWebKitAPI/InjectedBundleController.cpp:
* TestWebKitAPI/InjectedBundleMain.cpp:
* TestWebKitAPI/JavaScriptTest.cpp:
* TestWebKitAPI/PlatformUtilities.cpp:
* TestWebKitAPI/PlatformUtilities.h:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
* TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
* TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
* TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
* TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
* TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
* TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
* TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
* TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
* TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
* TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
* TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
* TestWebKitAPI/Tests/WebKit2/Find.cpp:
* TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
* TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
* TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
* TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
* TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
* TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
* TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
* TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
* TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
* TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
* TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
* TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
* TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
* TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
* TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
* TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
* TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
* TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
* TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
* TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
* TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
* TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
* TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
* TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
* TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
* TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
* TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
* TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
* TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
* TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
* TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
* TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
* TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
* TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
* TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
* TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
* TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/WKString.cpp:
* TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
* TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
* TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
* TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
* TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
* TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
(TEST):
* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
* TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
* TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
* TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
* TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
(TestWebKitAPI::Util::run):
(TestWebKitAPI::Util::sleep):
(TestWebKitAPI::Util::toSTD):
* TestWebKitAPI/config.h:
* TestWebKitAPI/mac/JavaScriptTestMac.mm:
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::run): Deleted.
(TestWebKitAPI::Util::sleep): Deleted.
(TestWebKitAPI::Util::toSTD): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Add support for FTL JIT on ARM64
dbatyai.u-szeged@partner.samsung.com [Thu, 18 Dec 2014 18:43:01 +0000 (18:43 +0000)]
[GTK] Add support for FTL JIT on ARM64
https://bugs.webkit.org/show_bug.cgi?id=139677

Reviewed by Csaba Osztrogon√°c.

* gtk/jhbuild-optional.modules:
* gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
* gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Log navigation types using FeatureCounter API
cdumez@apple.com [Thu, 18 Dec 2014 18:42:27 +0000 (18:42 +0000)]
[iOS] Log navigation types using FeatureCounter API
https://bugs.webkit.org/show_bug.cgi?id=139753

Reviewed by Darin Adler.

Log navigation types using FeatureCounter API.

No new tests, no behavior change other than additional feature
counting.

* loader/FrameLoader.cpp:
(WebCore::logNavigationWithFeatureCounter):
(WebCore::FrameLoader::loadWithDocumentLoader):
* platform/FeatureCounterKeys.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove 'font-weight' CSS property to the new StyleBuilder
cdumez@apple.com [Thu, 18 Dec 2014 18:36:22 +0000 (18:36 +0000)]
Move 'font-weight' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139765

Reviewed by Antti Koivisto.

Move 'font-weight' CSS property to the new StyleBuilder by using
custom code.

No new tests, no behavior change.

* css/CSSPropertyNames.in:
* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyFontWeight::applyValue): Deleted.
(WebCore::ApplyPropertyFontWeight::createHandler): Deleted.
* css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyInitialFontWeight):
(WebCore::StyleBuilderCustom::applyInheritFontWeight):
(WebCore::StyleBuilderCustom::applyValueFontWeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAttempt to fix the iOS build after <http://trac.webkit.org/changeset/177486>
dbates@webkit.org [Thu, 18 Dec 2014 18:23:18 +0000 (18:23 +0000)]
Attempt to fix the iOS build after <trac.webkit.org/changeset/177486>
(https://bugs.webkit.org/show_bug.cgi?id=139755)

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture): Wrap return value of Range::create() in RefPtr<Range>()
to make the the compiler happy since it wants clauses of the ternary operator to have the same data type
and Ref<Range> object does not support nullptr.
(WebKit::WebPage::selectWordBackward): Substitute Ref::ptr() for PassRefPtr::get().
(WebKit::WebPage::moveSelectionByOffset): Ditto.
(WebKit::WebPage::selectPositionAtPoint): Ditto.
(WebKit::WebPage::selectPositionAtBoundaryWithDirection): Ditto.
(WebKit::WebPage::requestDictationContext): Ditto.
(WebKit::computeAutocorrectionContext): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove timeout from shouldBecome* functions in js-test.js
g.czajkowski@samsung.com [Thu, 18 Dec 2014 17:44:18 +0000 (17:44 +0000)]
Remove timeout from shouldBecome* functions in js-test.js
https://bugs.webkit.org/show_bug.cgi?id=139767

Reviewed by Darin Adler.

r156678 has removed this timeout from shouldBecome* in js-test-pre.js.
Get rid of it from js-test.js as well to make shouldBecome* functions sync
between js-test.js and js-test-pre.js

Additionally, sync minor coding style changes between them.

* resources/js-test.js:
(_waitForCondition):
(.condition):
(shouldBecomeEqual):
(shouldBecomeEqualToString):
(shouldBecomeDifferent):
(._condition): Deleted.
(._failureHandler): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoInternals methods return 0 instead of false when they fail
g.czajkowski@samsung.com [Thu, 18 Dec 2014 17:44:09 +0000 (17:44 +0000)]
Internals methods return 0 instead of false when they fail
https://bugs.webkit.org/show_bug.cgi?id=139766

Reviewed by Darin Adler.

Some Internals method explicitly return 0 although
they expect boolean value.

No new tests, no behavior change.

* testing/Internals.cpp:
(WebCore::Internals::hasSpellingMarker):
(WebCore::Internals::hasAutocorrectedMarker):
(WebCore::Internals::isOverwriteModeEnabled):
(WebCore::Internals::hasGrammarMarker):
Return false instead of 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Log why cached resources are being revalidated using FeatureCounter API
cdumez@apple.com [Thu, 18 Dec 2014 17:21:03 +0000 (17:21 +0000)]
[iOS] Log why cached resources are being revalidated using FeatureCounter API
https://bugs.webkit.org/show_bug.cgi?id=139759
<rdar://problem/19288177>

Reviewed by Antti Koivisto.

Log why cached resources are being revalidated using FeatureCounter API.
Also log if revalidation is successful or not.

No new tests, no behavior change.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didReceiveResponse):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::mustRevalidateDueToCacheHeaders):
* loader/cache/CachedImage.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::failBeforeStarting):
(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::loader):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
* platform/FeatureCounterKeys.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove alwaysUseBaselineOfPrimaryFont setting
antti@apple.com [Thu, 18 Dec 2014 16:33:56 +0000 (16:33 +0000)]
Remove alwaysUseBaselineOfPrimaryFont setting
https://bugs.webkit.org/show_bug.cgi?id=139770

Reviewed by Anders Carlsson.

Source/WebCore:

"FIXME: This is unneeded and should be removed."

This iOS-only setting has no clients anymore.

* page/Settings.in:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::ascentAndDescentForBox):

Source/WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences _setAlwaysUseBaselineOfPrimaryFont:]): Deleted.
(-[WebPreferences _alwaysUseBaselineOfPrimaryFont]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView _preferencesChanged:]):

Source/WebKit2:

* Shared/WebPreferencesDefinitions.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Fix test expectations after r177363
ossy@webkit.org [Thu, 18 Dec 2014 15:30:00 +0000 (15:30 +0000)]
[EFL] Fix test expectations after r177363
https://bugs.webkit.org/show_bug.cgi?id=139772

Unreviewed gardening after r177363 - part II

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Implement webkit_web_view_is_playing_audio()
commit-queue@webkit.org [Thu, 18 Dec 2014 14:57:36 +0000 (14:57 +0000)]
[GTK] Implement webkit_web_view_is_playing_audio()
https://bugs.webkit.org/show_bug.cgi?id=138918

Patch by Adrian Perez de Castro <aperez@igalia.com> on 2014-12-18
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Implements webkit_web_view_is_playing_audio(), and overrides
UIClient::isPlayingAudioDidChange() to be able to emit change
notification signals for the new WebKitWebView::is-playing-audio
property.

* UIProcess/API/gtk/WebKitUIClient.cpp:
(isPlayingAudioDidChange): Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewIsPlayingAudioChanged): Helper function to emit the
emit the notify::is-playing-audio signal when needed.
(webkitWebViewGetProperty): Handle the WebKitWebView::is-playing-audio
property.
(webkit_web_view_class_init): Install the
WebKitWebView::is-playing-audio property.
(webkit_web_view_is_playing_audio): Added.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add
webkit_web_view_is_playing_audio() to the list of public API
functions.

Tools:

Add test case case for webkit_web_view_is_playing_audio() and the
WebKitWebView::is-playing-audio property.

* TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(urlForResource): Utility function to get URLs pointing to resources
under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
(testWebViewIsPlayingAudio): Added.
(beforeAll):
* TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
(getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
API tests resources directory, or the WebKit2 C API tests resources
directory. The default value of the flag is to use the WebKit2 GTK
one, to avoid having to change existing tests.
* TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
(isPlayingAudioChanged): Added.
(WebViewTest::waitUntilIsPlayingAudioChanged): Added.
* TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Allow to build with ENABLE_NETWORK_CACHE
carlosgc@webkit.org [Thu, 18 Dec 2014 14:41:44 +0000 (14:41 +0000)]
[GTK] Allow to build with ENABLE_NETWORK_CACHE
https://bugs.webkit.org/show_bug.cgi?id=139728

Reviewed by Antti Koivisto.

Just make it build for now.

* CMakeLists.txt: Add new files to compilation.
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry): Use
ENABLE(SHAREABLE_RESOURCE) when ShareableResource is used.
* NetworkProcess/cache/NetworkCache.cpp:
(WebKit::decodeStorageEntry): Ditto.
(WebKit::makeCacheKey): Use ENABLE(CACHE_PARTITIONING) for ResourceRequest::cachePartition().
* NetworkProcess/cache/NetworkCache.h:
* NetworkProcess/cache/NetworkCacheStorage.h:
(WebKit::NetworkCacheStorage::Data::isNull): Move implementation
to platform specific files.
* NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
(WebKit::NetworkCacheStorage::Data::isNull): Moved from the header.
* NetworkProcess/cache/NetworkCacheStorageSoup.cpp: Added.
(WebKit::NetworkCacheStorage::Data::Data):
(WebKit::NetworkCacheStorage::Data::data):
(WebKit::NetworkCacheStorage::Data::isNull):
(WebKit::NetworkCacheStorage::open):
(WebKit::NetworkCacheStorage::NetworkCacheStorage):
(WebKit::NetworkCacheStorage::initializeKeyFilter):
(WebKit::NetworkCacheStorage::removeEntry):
(WebKit::NetworkCacheStorage::dispatchRetrieveOperation):
(WebKit::NetworkCacheStorage::dispatchPendingRetrieveOperations):
(WebKit::NetworkCacheStorage::retrieve):
(WebKit::NetworkCacheStorage::store):
(WebKit::NetworkCacheStorage::setMaximumSize):
(WebKit::NetworkCacheStorage::clear):
* PlatformGTK.cmake: Add NetworkCacheStorageSoup.cpp.
* config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[SVG Masking] Enable the use of <mask> elements for -webkit-mask-image
stavila@adobe.com [Thu, 18 Dec 2014 13:41:59 +0000 (13:41 +0000)]
[SVG Masking] Enable the use of <mask> elements for -webkit-mask-image
https://bugs.webkit.org/show_bug.cgi?id=139294

Reviewed by Simon Fraser.

Source/WebCore:

This patch links together all parts required for the functionality which improves
the -webkit-mask-image property by allowing it to reference a <mask> element defined
in an inline or external SVG document.
Support for this new functionality has been added in a previous patch, under issue
https://bugs.webkit.org/show_bug.cgi?id=139092. A more detailed description of how
the new functionality works can be found in the ChangeLog for that commit.
The containsSVGDocument in ScrollView has been removed because it was added in the
previous patch but is no longer required.

Tests: css3/masking/mask-base64.html
       css3/masking/mask-multiple-values.html
       css3/masking/mask-svg-clipped-fragmentId.html
       css3/masking/mask-svg-fragmentId.html
       css3/masking/mask-svg-inline-fragmentId.html
       css3/masking/mask-svg-inline-invalid-fragmentId.html
       css3/masking/mask-svg-invalid-fragmentId.html
       css3/masking/mask-svg-no-fragmentId-tiled.html
       css3/masking/mask-svg-no-fragmentId.html
       css3/masking/mask-svg-script-entire-svg-to-mask.html
       css3/masking/mask-svg-script-mask-to-entire-svg.html
       css3/masking/mask-svg-script-mask-to-none.html
       css3/masking/mask-svg-script-mask-to-png.html
       css3/masking/mask-svg-script-none-to-mask.html
       css3/masking/mask-svg-script-none-to-png.html
       css3/masking/mask-svg-script-png-to-mask.html
       css3/masking/mask-svg-script-png-to-none.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseMaskImage):
* css/CSSParser.h:
* css/CSSValue.h:
* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustStyleForMaskImages):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::createMaskImageOperations):
(WebCore::StyleResolver::loadPendingImages):
* css/StyleResolver.h:
* page/FrameView.cpp:
(WebCore::FrameView::containsSVGDocument): Deleted.
* page/FrameView.h:
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
(WebCore::MaskImagePropertyWrapper::MaskImagePropertyWrapper):
(WebCore::MaskImagePropertyWrapper::equals):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* platform/ScrollView.h:
(WebCore::ScrollView::containsSVGDocument): Deleted.
* platform/graphics/MaskImageOperation.cpp:
(WebCore::MaskImageOperation::~MaskImageOperation):
(WebCore::MaskImageOperation::operator==):
* platform/graphics/MaskImageOperation.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::maskClipRect):
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::updateFillImages):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
* rendering/RenderLayer.h:
* rendering/RenderLayerMaskImageInfo.cpp:
(WebCore::RenderLayer::MaskImageInfo::~MaskImageInfo):
(WebCore::RenderLayer::MaskImageInfo::updateMaskImageClients):
(WebCore::RenderLayer::MaskImageInfo::removeMaskImageClients):
* rendering/RenderLayerMaskImageInfo.h:
* rendering/style/FillLayer.cpp:
(WebCore::FillLayer::hasImage):
* rendering/style/FillLayer.h:
(WebCore::FillLayer::image):
(WebCore::FillLayer::imageOrMaskImage): Deleted.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setMaskImage):
* rendering/style/RenderStyle.h:

LayoutTests:

Added tests for different situations using URLs with fragment id
for the -webkit-mask-image property.

* css3/masking/mask-base64-expected.html: Copied from LayoutTests/css3/masking/mask-repeat-space-padding-expected.html.
* css3/masking/mask-base64.html: Added.
* css3/masking/mask-multiple-values-expected.html: Added.
* css3/masking/mask-multiple-values.html: Added.
* css3/masking/mask-repeat-space-padding-expected.html:
* css3/masking/mask-repeat-space-padding.html:
* css3/masking/mask-svg-clipped-fragmentId-expected.html: Added.
* css3/masking/mask-svg-clipped-fragmentId.html: Added.
* css3/masking/mask-svg-fragmentId-expected.html: Added.
* css3/masking/mask-svg-fragmentId.html: Added.
* css3/masking/mask-svg-inline-fragmentId-expected.html: Added.
* css3/masking/mask-svg-inline-fragmentId.html: Added.
* css3/masking/mask-svg-inline-invalid-fragmentId-expected.html: Added.
* css3/masking/mask-svg-inline-invalid-fragmentId.html: Added.
* css3/masking/mask-svg-invalid-fragmentId-expected.html: Added.
* css3/masking/mask-svg-invalid-fragmentId.html: Added.
* css3/masking/mask-svg-no-fragmentId-expected.html: Added.
* css3/masking/mask-svg-no-fragmentId-tiled-expected.html: Added.
* css3/masking/mask-svg-no-fragmentId-tiled.html: Added.
* css3/masking/mask-svg-no-fragmentId.html: Added.
* css3/masking/mask-svg-script-entire-svg-to-mask-expected.html: Added.
* css3/masking/mask-svg-script-entire-svg-to-mask.html: Added.
* css3/masking/mask-svg-script-mask-to-entire-svg-expected.html: Added.
* css3/masking/mask-svg-script-mask-to-entire-svg.html: Added.
* css3/masking/mask-svg-script-mask-to-none-expected.html: Added.
* css3/masking/mask-svg-script-mask-to-none.html: Added.
* css3/masking/mask-svg-script-mask-to-png-expected.html: Added.
* css3/masking/mask-svg-script-mask-to-png.html: Added.
* css3/masking/mask-svg-script-none-to-mask-expected.html: Added.
* css3/masking/mask-svg-script-none-to-mask.html: Added.
* css3/masking/mask-svg-script-none-to-png-expected.html: Added.
* css3/masking/mask-svg-script-none-to-png.html: Added.
* css3/masking/mask-svg-script-png-to-mask-expected.html: Added.
* css3/masking/mask-svg-script-png-to-mask.html: Added.
* css3/masking/mask-svg-script-png-to-none-expected.html: Added.
* css3/masking/mask-svg-script-png-to-none.html: Added.
* css3/masking/resources/masks.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] [EFL] Enable per_test_timeout
clopez@igalia.com [Thu, 18 Dec 2014 13:32:36 +0000 (13:32 +0000)]
[GTK] [EFL] Enable per_test_timeout
https://bugs.webkit.org/show_bug.cgi?id=139771

Reviewed by Csaba Osztrogon√°c.

This is needed to make WKTR use either the default port timeout, or the
user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
Otherwise WTR will use the default (30 seconds after r177363 and r177471).

* Scripts/webkitpy/port/efl.py:
(EflPort.supports_per_test_timeout): Enabled.
* Scripts/webkitpy/port/gtk.py:
(GtkPort.supports_per_test_timeout): Enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL] Fix test expectations after r177363
ossy@webkit.org [Thu, 18 Dec 2014 13:15:11 +0000 (13:15 +0000)]
[EFL] Fix test expectations after r177363
https://bugs.webkit.org/show_bug.cgi?id=139772

Unreviewed gardening after r177363 - part I

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoanimations/cross-fade-webkit-mask-image.html is flaky
stavila@adobe.com [Thu, 18 Dec 2014 12:54:31 +0000 (12:54 +0000)]
animations/cross-fade-webkit-mask-image.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=139590

Reviewed by Andrei Bucur.

animations/cross-fade-webkit-mask-image.html became flaky after the way
masks are handled was changed in https://bugs.webkit.org/show_bug.cgi?id=139294.
Marking it flaky for now, pending investigation.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoStop returning GlyphPage from various Font functions
antti@apple.com [Thu, 18 Dec 2014 12:16:12 +0000 (12:16 +0000)]
Stop returning GlyphPage from various Font functions
https://bugs.webkit.org/show_bug.cgi?id=139627

Reviewed by Darin Adler.

Source/WebCore:

Make all

    std::pair<GlyphData, GlyphPage*> glyphDataAndPage*(...)

style functions to just return GlyphData only. The GlyphPage value was only used for an obscure SVG fallback case.

* platform/graphics/Font.h:
(WebCore::Font::glyphDataForCharacter):
(WebCore::Font::glyphDataAndPageForCharacter): Deleted.
* platform/graphics/FontGlyphs.cpp:
(WebCore::glyphDataForCJKCharacterWithoutSyntheticItalic):
(WebCore::glyphDataForNonCJKCharacterWithGlyphOrientation):
(WebCore::FontGlyphs::glyphDataForSystemFallback):
(WebCore::FontGlyphs::glyphDataForVariant):
(WebCore::FontGlyphs::glyphDataForCharacter):
(WebCore::glyphDataAndPageForCJKCharacterWithoutSyntheticItalic): Deleted.
(WebCore::glyphDataAndPageForNonCJKCharacterWithGlyphOrientation): Deleted.
(WebCore::FontGlyphs::glyphDataAndPageForSystemFallback): Deleted.
(WebCore::FontGlyphs::glyphDataAndPageForVariant): Deleted.
(WebCore::FontGlyphs::glyphDataAndPageForCharacter): Deleted.
* platform/graphics/FontGlyphs.h:
(WebCore::FontGlyphs::GlyphPagesStateSaver::GlyphPagesStateSaver): Deleted.
(WebCore::FontGlyphs::GlyphPagesStateSaver::~GlyphPagesStateSaver): Deleted.

    No longer needed.

* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):

    Simplify by not trying to resolve fallbacks in case context sensitive (based on lang attribute etc)
    glyph selection fails. Instead just fall back to a default font. This behavior is not specified
    anywhere as far as I can see. (normal non-context sensitive fallbacks will still work fine).
    This removes the need to hackishly mutate glyph pages.

    Also fix a bug where we didn't use the specified missing glyph when context sensitive selection failed.

LayoutTests:

These are progressions. We now correctly draw the specified missing glyph.

* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
* platform/mac/svg/custom/glyph-selection-lang-attribute-expected.png:
* svg/custom/glyph-selection-lang-attribute-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove 'list-style-image' CSS property to the new StyleBuilder
cdumez@apple.com [Thu, 18 Dec 2014 09:55:48 +0000 (09:55 +0000)]
Move 'list-style-image' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139763

Reviewed by Antti Koivisto.

Move 'list-style-image' CSS property to the new StyleBuilder
by reusing an existing Converter helper and renaming it for
clarity.

No new tests, no behavior change.

* css/CSSPropertyNames.in:
* css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyStyleImage::applyValue): Deleted.
(WebCore::ApplyPropertyStyleImage::createHandler): Deleted.
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertStyleImage):
(WebCore::StyleBuilderConverter::convertBorderImageSource): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoURTBF after r177452.
ossy@webkit.org [Thu, 18 Dec 2014 07:14:58 +0000 (07:14 +0000)]
URTBF after r177452.
https://bugs.webkit.org/show_bug.cgi?id=139752

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix.
rniwa@webkit.org [Thu, 18 Dec 2014 03:15:51 +0000 (03:15 +0000)]
Unreviewed build fix.

* public/v2/index.html: Include js files we extracted in r177424.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRef-ify Range::create().
akling@apple.com [Thu, 18 Dec 2014 03:06:00 +0000 (03:06 +0000)]
Ref-ify Range::create().
<https://webkit.org/b/139755>

Reviewed by Anders Carlsson.

Source/WebCore:

* dom/Document.cpp:
(WebCore::acceptsEditingFocus):
* dom/Element.cpp:
(WebCore::Element::innerText):
* dom/Range.cpp:
(WebCore::Range::create):
(WebCore::Range::cloneRange):
(WebCore::rangeOfContents):
* dom/Range.h:
* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
* editing/VisibleUnits.cpp:
(WebCore::charactersAroundPosition):
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::renderedText):
* page/FocusController.cpp:
(WebCore::relinquishesEditingFocus):

Source/WebKit/mac:

* WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation attributedStringFrom:startOffset:to:endOffset:]):
* WebView/WebHTMLView.mm:
(-[WebHTMLView attributedString]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnify -[WebResource description]
andersca@apple.com [Thu, 18 Dec 2014 02:12:18 +0000 (02:12 +0000)]
Unify -[WebResource description]
https://bugs.webkit.org/show_bug.cgi?id=139762

Reviewed by Dan Bernstein.

* WebView/WebResource.mm:
(-[WebResource description]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of an ugly #define hack in WebFrameLoaderClient
andersca@apple.com [Thu, 18 Dec 2014 02:09:50 +0000 (02:09 +0000)]
Get rid of an ugly #define hack in WebFrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=139761

Reviewed by Dan Bernstein.

Also replace @private with @package in all public headers, for consistency.

* History/WebBackForwardList.h:
* History/WebHistory.h:
* Misc/WebDownload.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebView/WebArchive.h:
* WebView/WebDataSource.h:
* WebView/WebFrame.h:
* WebView/WebFrameView.h:
* WebView/WebPreferences.h:
* WebView/WebResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago<rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
mitz@apple.com [Thu, 18 Dec 2014 02:02:46 +0000 (02:02 +0000)]
<rdar://problem/19282508> WebKitLegacy is unusable due to bad dylib identifier
https://bugs.webkit.org/show_bug.cgi?id=139760

Reviewed by Anders Carlsson.

Source/WebCore:

* Configurations/WebCore.xcconfig:

Source/WebKit/mac:

* Configurations/WebKitLegacy.xcconfig:

Source/WebKit2:

* Configurations/WebKit2.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of FrameLoader::defaultObjectContentType
andersca@apple.com [Thu, 18 Dec 2014 01:56:18 +0000 (01:56 +0000)]
Get rid of FrameLoader::defaultObjectContentType
https://bugs.webkit.org/show_bug.cgi?id=139758

Reviewed by Geoffrey Garen.

Source/WebCore:

Move the FrameLoader::defaultObjectContentType implementation to its only caller in WebKit/win.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::defaultObjectContentType): Deleted.
* loader/FrameLoader.h:

Source/WebKit/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::objectContentType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPage previews are sometimes sized much smaller than it seems they should be
bdakin@apple.com [Thu, 18 Dec 2014 00:15:19 +0000 (00:15 +0000)]
Page previews are sometimes sized much smaller than it seems they should be
https://bugs.webkit.org/show_bug.cgi?id=139754
-and corresponding-
rdar://problem/19286550

Reviewed by Tim Horton.

Increase the minimum size and add in a missing else!!
* UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _preferredPopoverSizeWithPreviewPadding:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove Apple buildbot slaves to their new home.
lforschler@apple.com [Thu, 18 Dec 2014 00:00:26 +0000 (00:00 +0000)]
Move Apple buildbot slaves to their new home.

Reviewed by Roger Fong.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r177363): Gtk and Efl testing is broken
ap@apple.com [Wed, 17 Dec 2014 23:57:06 +0000 (23:57 +0000)]
REGRESSION (r177363): Gtk and Efl testing is broken
https://bugs.webkit.org/show_bug.cgi?id=139734

Reviewed by Simon Fraser.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.__init__): Remove timeout adjustment from here, because it
affected both script and tool timeout. This is still the right place for this logic,
but it would be a larger refactoring than I can do right now.

* Scripts/webkitpy/port/base.py:
(Port.supports_per_test_timeout): Added a FIXME.
(Port.default_timeout_ms): Now that the effective timeout is longer, change this
to avoid making tests take more time.

* Scripts/webkitpy/port/driver.py:
(Driver.run_test): Adjust script timeout here.
(Driver._check_for_driver_timeout): Fix the timeout detection.
(Driver._read_block): Actually use the timeout detection code.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
Use TestRunner default timeout when there isn't a timeout passed from command line for the test.

* Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
Update results for the new default.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_hung_thread): Restore a test that I previously deleted, it was
actually a good one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRef-ify WebPageProxy and WebProcessProxy creation functions
andersca@apple.com [Wed, 17 Dec 2014 23:23:29 +0000 (23:23 +0000)]
Ref-ify WebPageProxy and WebProcessProxy creation functions
https://bugs.webkit.org/show_bug.cgi?id=139751

Reviewed by Andreas Kling.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::create):
(WebKit::WebProcessProxy::createWebPage):
* UIProcess/WebProcessProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed iOS Build Fix after r177459.
joepeck@webkit.org [Wed, 17 Dec 2014 23:16:21 +0000 (23:16 +0000)]
Unreviewed iOS Build Fix after r177459.

* UIProcess/ios/WebInspectorProxyIOS.mm:
(WebKit::WebInspectorProxy::platformInvalidate):
(WebKit::WebInspectorProxy::platformHide):
Add missing WebInspectorProxy platform methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r177456.
commit-queue@webkit.org [Wed, 17 Dec 2014 22:24:14 +0000 (22:24 +0000)]
Unreviewed, rolling out r177456.
https://bugs.webkit.org/show_bug.cgi?id=139749

Broke webkitpy and Mac tests (Requested by ap on #webkit).

Reverted changeset:

"REGRESSION (r177363): Gtk and Efl testing is broken"
https://bugs.webkit.org/show_bug.cgi?id=139734
http://trac.webkit.org/changeset/177456

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Define button and action should respect profile settings.
enrica@apple.com [Wed, 17 Dec 2014 21:56:33 +0000 (21:56 +0000)]
[iOS] Define button and action should respect profile settings.
https://bugs.webkit.org/show_bug.cgi?id=139739
rdar://problem/15461887

Reviewed by Joseph Pecoraro.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformAction:withSender:]):
(-[WKContentView _define:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] More test gardening
dbates@webkit.org [Wed, 17 Dec 2014 21:49:56 +0000 (21:49 +0000)]
[iOS] More test gardening

* platform/ios-simulator-wk2/TestExpectations:
[...]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTests with infinite recursion frequently crash
msaboff@apple.com [Wed, 17 Dec 2014 21:38:43 +0000 (21:38 +0000)]
Tests with infinite recursion frequently crash
https://bugs.webkit.org/show_bug.cgi?id=139548

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

While unwinding, if the call frame doesn't have a codeblock, then we
are in native code, handle appropriately.

* interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
(JSC::UnwindFunctor::operator()):
Added checks for null CodeBlock.

(JSC::Interpreter::unwind): Removed wrong ASSERT.

LayoutTests:

New test that exercises the various places that we do stack overflow checks.

* TestExpectations:
* js/regress-139548-expected.txt: Added.
* js/regress-139548.html: Added.
* js/script-tests/regress-139548.js: Added.
(ToStringObj):
(ToStringObj.prototype.toString):
(makeArgsArray):
(recurseNoDFG):
(recurse):
(probeAndRecurse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: [Mac] Occosional Crashes Closing Inspector
commit-queue@webkit.org [Wed, 17 Dec 2014 21:19:21 +0000 (21:19 +0000)]
Web Inspector: [Mac] Occosional Crashes Closing Inspector
https://bugs.webkit.org/show_bug.cgi?id=139740

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-12-17
Reviewed by Timothy Hatcher.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent):
The WebPageProxy could have gotten destroyed in handling (e.g. keyboard shortcut
to close the Inspector Window), so protect the object to avoid destruction
during handling.

* UIProcess/WebInspectorProxy.h:
* UIProcess/WebPageProxy.cpp:
Add platformInvalidate opportunity for the platform to do invalidation work.

* UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformInvalidate):
* UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformInvalidate):
Empty implementations, these ports do not need to do anything.

* UIProcess/WebInspectorProxy.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::closeTimerFired):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformInvalidate):
When closing / invalidating make sure we close the WKView to clear client
for any delayed callbacks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Curl] Compile error, setWasCached method has been removed.
commit-queue@webkit.org [Wed, 17 Dec 2014 21:15:41 +0000 (21:15 +0000)]
[Curl] Compile error, setWasCached method has been removed.
https://bugs.webkit.org/show_bug.cgi?id=139737

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-17
Reviewed by Alex Christensen.

The ResourceResponseBase::setWasCached() method has been replaced
with ResourceResponseBase::setSource().

* platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::setResponseFromCachedHeaders):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION (r177363): Gtk and Efl testing is broken
ap@apple.com [Wed, 17 Dec 2014 21:03:53 +0000 (21:03 +0000)]
REGRESSION (r177363): Gtk and Efl testing is broken
https://bugs.webkit.org/show_bug.cgi?id=139734

Reviewed by Simon Fraser.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner.__init__): Remove timeout adjustment from here, because it
affected both script and tool timeout. This is still the right place for this logic,
but it would be a larger refactoring than I can do right now.

* Scripts/webkitpy/port/base.py:
(Port.supports_per_test_timeout): Added a FIXME.
(Port.default_timeout_ms): Now that the effective timeout is longer, change this
to avoid making tests take more time.

* Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.

* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
Use TestRunner default timeout when there isn't a timeout passed from command line for the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Make it possible to toggle FeatureCounter support at runtime
cdumez@apple.com [Wed, 17 Dec 2014 21:03:51 +0000 (21:03 +0000)]
[iOS] Make it possible to toggle FeatureCounter support at runtime
https://bugs.webkit.org/show_bug.cgi?id=139688
<rdar://problem/19266254>

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Stop linking against AppSupport framework as the functionality is no
longer in WTF (it was moved to WebCore).

* Configurations/JavaScriptCore.xcconfig:

Source/WebCore:

Make it possible to toggle FeatureCounter support at runtime by adding
a setting (disabled by default) and moving the API to a new
FeatureCounter class under WebCore/plattorm which only logs if the
setting is enabled. For privacy reasons, FeatureCounter logging is also
disabled for private / ephemeral sessions.

No new tests, no behavior change.

* CMakeLists.txt:
* Configurations/WebCore.xcconfig:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
* page/Settings.in:
* platform/FeatureCounter.cpp: Renamed from Source/WTF/wtf/FeatureCounter.cpp.
(WebCore::FeatureCounter::shouldUseForPage):
(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):
* platform/FeatureCounter.h: Renamed from Source/WTF/wtf/FeatureCounter.h.
* platform/FeatureCounterKeys.h:
* platform/ios/FeatureCounter.mm: Renamed from Source/WTF/wtf/ios/FeatureCounter.mm.
(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):

Source/WebKit2:

Add private settings API to toggle FeatureCounter support on Safari and
MobileSafari.

* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetFeatureCounterEnabled):
(WKPreferencesGetFeatureCounterEnabled):
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _featureCounterEnabled]):
(-[WKPreferences _setFeatureCounterEnabled:]):
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Source/WTF:

Remove FeatureCounter API from WTF and move it to WebCore/platform
instead so that it can log conditionally based on a WebCore setting.

* WTF.vcxproj/WTF.vcxproj:
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClean up SQL statement building in SQLiteIDBCursor
andersca@apple.com [Wed, 17 Dec 2014 20:32:02 +0000 (20:32 +0000)]
Clean up SQL statement building in SQLiteIDBCursor
https://bugs.webkit.org/show_bug.cgi?id=139741

Reviewed by Andreas Kling.

This vastly simplifies the code and gets rid of the last
uses of DEPRECATED_DEFINE_STATIC_LOCAL in WebKit2.

* DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:
(WebKit::buildIndexStatement):
(WebKit::buildObjectStoreStatement):
(WebKit::SQLiteIDBCursor::establishStatement):
(WebKit::getIndexStatement): Deleted.
(WebKit::getObjectStoreStatement): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoGet rid of PluginPackageNone.cpp
andersca@apple.com [Wed, 17 Dec 2014 20:10:31 +0000 (20:10 +0000)]
Get rid of PluginPackageNone.cpp
https://bugs.webkit.org/show_bug.cgi?id=139735

Reviewed by Andreas Kling.

* CMakeLists.txt:
* PlatformEfl.cmake:
* PlatformGTK.cmake:
* PlatformWin.cmake:
* plugins/PluginPackageNone.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Unreviewed build fix (for full build)
bfulgham@apple.com [Wed, 17 Dec 2014 20:09:32 +0000 (20:09 +0000)]
[Win] Unreviewed build fix (for full build)

* win/tools/vsprops/FeatureDefines.props: Add missing export so the
derived sources are generated properly.
* win/tools/vsprops/FeatureDefinesCairo.props: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPurge PassRefPtr from Frame.
akling@apple.com [Wed, 17 Dec 2014 19:39:16 +0000 (19:39 +0000)]
Purge PassRefPtr from Frame.
<https://webkit.org/b/139731>

Reviewed by Anders Carlsson.

Source/WebCore:

Remove all use of PassRefPtr from the Frame class, instead using
Ref or RefPtr as appropriate.

* WebCore.exp.in:
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::begin):
* page/Frame.cpp:
(WebCore::Frame::create):
(WebCore::Frame::setView):
(WebCore::Frame::setDocument):
(WebCore::Frame::rangeForPoint):
(WebCore::Frame::createView):
* page/Frame.h:
* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):

Source/WebKit/mac:

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::transitionToCommittedForNewPage):
* WebView/WebFrame.mm:
(+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
(+[WebFrame _createSubframeWithOwnerElement:frameName:frameView:]):
* WebView/WebFrameInternal.h:

Source/WebKit2:

* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createSubframe):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTest fix after r177444.
mmaxfield@apple.com [Wed, 17 Dec 2014 18:56:59 +0000 (18:56 +0000)]
Test fix after r177444.

Unreviewed.

* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySliderThumb::elementRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Correct DebugSuffix builds under MSBuild
bfulgham@apple.com [Wed, 17 Dec 2014 18:26:51 +0000 (18:26 +0000)]
[Win] Correct DebugSuffix builds under MSBuild
https://bugs.webkit.org/show_bug.cgi?id=139733
<rdar://problem/19276880>

Reviewed by Simon Fraser.

../JavaScriptCore:

* JavaScriptCore.vcxproj/JavaScriptCore.proj: Make sure to use the
'_debug' suffix when building the DebugSuffix target.

../WebKit:

* WebKit.vcxproj/WebKit.proj: Make sure to use the '_debug' suffix
when building the DebugSuffix target.

../WTF:

* WTF.vcxproj/WTF.proj: Make sure to use the '_debug' suffix
when building the DebugSuffix target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoiOS build fix
mitz@apple.com [Wed, 17 Dec 2014 18:12:00 +0000 (18:12 +0000)]
iOS build fix

* UIProcess/ios/PageClientImplIOS.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::PageClient::setTextIndicatorAnimationProgress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[Win] Link errors.
commit-queue@webkit.org [Wed, 17 Dec 2014 17:46:17 +0000 (17:46 +0000)]
[Win] Link errors.
https://bugs.webkit.org/show_bug.cgi?id=139729

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-12-17
Reviewed by Anders Carlsson.

The list of exported symbols needs to be updated.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake Ref::copyRef const and ref-qualified
andersca@apple.com [Wed, 17 Dec 2014 17:02:11 +0000 (17:02 +0000)]
Make Ref::copyRef const and ref-qualified
https://bugs.webkit.org/show_bug.cgi?id=139730

Reviewed by Andreas Kling.

* wtf/Ref.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAddressing more post-review comments in r177035
mmaxfield@apple.com [Wed, 17 Dec 2014 16:33:31 +0000 (16:33 +0000)]
Addressing more post-review comments in r177035

* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySliderThumb::elementRect):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
carlosgc@webkit.org [Wed, 17 Dec 2014 12:03:18 +0000 (12:03 +0000)]
[GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=139725

Reviewed by Martin Robinson.

The timeout is already in milliseconds, so we don't need to do any conversion.

* WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[TexMap] Sprinkle range-based for-loops where still possible
zandobersek@gmail.com [Wed, 17 Dec 2014 11:44:49 +0000 (11:44 +0000)]
[TexMap] Sprinkle range-based for-loops where still possible
https://bugs.webkit.org/show_bug.cgi?id=138752

Reviewed by Chris Dumez.

Apply range-based for-loops where possible in the TextureMapper,
TextureMapperGL and TextureMapperTiledBackingStore classes.

Also prettify the loop in SharedGLData destructor and return
nullptr instead of explicitly constructing the empty PassRefPtr
object in TextureMapperTiledBackingStore::texture().

* platform/graphics/texmap/TextureMapper.cpp:
(WebCore::BitmapTexturePool::acquireTexture):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::SharedGLData::~SharedGLData):
(WebCore::TextureMapperGLData::~TextureMapperGLData):
* platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):
(WebCore::TextureMapperTiledBackingStore::drawBorder):
(WebCore::TextureMapperTiledBackingStore::drawRepaintCounter):
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):
(WebCore::TextureMapperTiledBackingStore::texture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoThe SVGDocument of an SVGImage should not perform any additional actions when the...
stavila@adobe.com [Wed, 17 Dec 2014 10:14:32 +0000 (10:14 +0000)]
The SVGDocument of an SVGImage should not perform any additional actions when the SVGImage is being destroyed
https://bugs.webkit.org/show_bug.cgi?id=139644

Reviewed by Antti Koivisto.

When an SVGImage is destroyed, having its SVGDocument perform style recalc and dispatching events is not only
useless but can also cause problems, such as re-entrancy in StyleResolver::loadPendingResources.

No new tests required, existing tests cover this change.

* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore::Document::isBeingDestroyed):
(WebCore::Document::setIsBeingDestroyed):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::closeURL):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::~SVGImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed. Fix GTK+ build after r177427.
carlosgc@webkit.org [Wed, 17 Dec 2014 09:51:01 +0000 (09:51 +0000)]
Unreviewed. Fix GTK+ build after r177427.

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::setTextIndicatorAnimationProgress):
* UIProcess/API/gtk/PageClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL]Fix build warning in MiniBrowser
commit-queue@webkit.org [Wed, 17 Dec 2014 08:45:22 +0000 (08:45 +0000)]
[EFL]Fix build warning in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=139723

Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2014-12-17
Reviewed by Darin Adler.

The warning is caused by the compiler wanting the first argument to be a
string literal, not a dynamically created string.

* MiniBrowser/efl/main.c:
(quit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDrop useless 'clipToContents' argument for windowClipRect()
cdumez@apple.com [Wed, 17 Dec 2014 08:03:44 +0000 (08:03 +0000)]
Drop useless 'clipToContents' argument for windowClipRect()
https://bugs.webkit.org/show_bug.cgi?id=139722

Reviewed by Darin Adler.

Drop useless 'clipToContents' argument for windowClipRect(). This
argument is never used.

No new tests, no behavior change.

* page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
* page/FrameView.h:
* platform/ScrollView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agotext node should not be created, On setting document.title to the empty string.
commit-queue@webkit.org [Wed, 17 Dec 2014 05:20:09 +0000 (05:20 +0000)]
text node should not be created, On setting document.title to the empty string.
https://bugs.webkit.org/show_bug.cgi?id=139121

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-12-16
Reviewed by Darin Adler.

Source/WebCore:

Do not create text node, On setting document.title to the empty string as in spec.
I have confirmed this matches the behavior of Firefox and Chrome.

Test: fast/dom/Document/document-set-title-no-child.html

* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::setText):

LayoutTests:

* fast/dom/Document/document-set-title-no-child-expected.txt: Added.
* fast/dom/Document/document-set-title-no-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTestWebKitAPI should use a static lib to support both Mac and iOS cleanly
weinig@apple.com [Wed, 17 Dec 2014 04:02:33 +0000 (04:02 +0000)]
TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
https://bugs.webkit.org/show_bug.cgi?id=139718

Reviewed by Mark Rowe.

Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
files into a static lib which the command line utility can link link against.
This will allow us to create a TestWebKitAPI.app that can run on iOS.

* TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
* TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177434 268f45cc-cd09-0410-ab3c-d52691b4dbfc