WebKit-https.git
5 years agoFix RenderFileUploadControl.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 05:50:41 +0000 (05:50 +0000)]
Fix RenderFileUploadControl.o for iOS. Unreviewed build fix.

WebCore::theme() returns a reference now, not a pointer.

* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix HTMLPlugInImageElement.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 05:45:18 +0000 (05:45 +0000)]
Fix HTMLPlugInImageElement.o for iOS. Unreviewed build fix.

Forgot to upstream YouTubeEmbedShadowElement.*. Do so and
add the files to the Xcode project so they build.

* WebCore.xcodeproj/project.pbxproj:
* html/shadow/YouTubeEmbedShadowElement.cpp: Added.
(WebCore::YouTubeEmbedShadowElement::create):
(WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
(WebCore::YouTubeEmbedShadowElement::pluginElement):
(WebCore::YouTubeEmbedShadowElement::shadowPseudoId):
* html/shadow/YouTubeEmbedShadowElement.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Update EditorIOS.mm to switch from pointers to references
ddkilzer@apple.com [Sat, 11 Jan 2014 05:34:14 +0000 (05:34 +0000)]
[iOS] Update EditorIOS.mm to switch from pointers to references

* editing/ios/EditorIOS.mm:
(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
(WebCore::Editor::insertParagraphSeparatorInQuotedContent):
(WebCore::styleForSelectionStart):
(WebCore::Editor::selectionInWebArchiveFormat):
(WebCore::Editor::writeImageToPasteboard):
(WebCore::Editor::WebContentReader::readWebArchive):
(WebCore::Editor::WebContentReader::readRTFD):
(WebCore::Editor::WebContentReader::readRTF):
(WebCore::uniqueURLWithRelativePart):
(WebCore::Editor::WebContentReader::readPlainText):
(WebCore::Editor::webContentFromPasteboard):
(WebCore::Editor::createFragmentAndAddResources):
(WebCore::Editor::createFragmentForImageResourceAndAddResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Push InspectorAgent down into JSC, give JSC an InspectorController
joepeck@webkit.org [Sat, 11 Jan 2014 05:18:34 +0000 (05:18 +0000)]
Web Inspector: Push InspectorAgent down into JSC, give JSC an InspectorController
https://bugs.webkit.org/show_bug.cgi?id=126763

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Introduce JSGlobalObjectInspectorController. This is the InspectorController
for a JSContext. It is created by the JSGlobalObject Remote Inspector Debuggable
when a remote frontend connects, and is destroyed when the remote frontend
disconnects of the JSGlobalObject is destroyed.

* inspector/JSGlobalObjectInspectorController.h: Added.
* inspector/JSGlobalObjectInspectorController.cpp: Added.
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
(Inspector::JSGlobalObjectInspectorController::dispatchMessageFromFrontend):
(Inspector::JSGlobalObjectInspectorController::functionCallHandler):
(Inspector::JSGlobalObjectInspectorController::evaluateHandler):
Create/destory agents, create/destroy dispatches, implement InspectorEnvironment.

* runtime/JSGlobalObjectDebuggable.h:
* runtime/JSGlobalObjectDebuggable.cpp:
(JSC::JSGlobalObjectDebuggable::~JSGlobalObjectDebuggable):
(JSC::JSGlobalObjectDebuggable::connect):
(JSC::JSGlobalObjectDebuggable::disconnect):
(JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemoteFrontend):
Forward actions to the InspectorController object.

* inspector/agents/InspectorAgent.h: Renamed from Source/WebCore/inspector/InspectorAgent.h.
* inspector/agents/InspectorAgent.cpp: Renamed from Source/WebCore/inspector/InspectorAgent.cpp.
(Inspector::InspectorAgent::InspectorAgent):
(Inspector::InspectorAgent::~InspectorAgent):
(Inspector::InspectorAgent::didCreateFrontendAndBackend):
(Inspector::InspectorAgent::inspect):
(Inspector::InspectorAgent::evaluateForTestInFrontend):
Implement InspectorAgent in JavaScriptCore in namespace Inspector.

* JavaScriptCore.xcodeproj/project.pbxproj:
* CMakeLists.txt:
* ChangeLog:
* GNUmakefile.am:
* GNUmakefile.list.am:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.vcxproj/copy-files.cmd:
Add files and new inspector/agents subdirectory.

Source/WebCore:

No new tests, no observable change in functionality.

* CMakeLists.txt:
* ForwardingHeaders/inspector/InspectorAgent.h: Added.
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorAllInOne.cpp:
InspectorAgent moved to JavaScriptCore.

* inspector/PageConsoleAgent.cpp:
(WebCore::PageConsoleAgent::PageConsoleAgent):
(WebCore::PageConsoleAgent::~PageConsoleAgent):
* inspector/PageConsoleAgent.h:
(WebCore::PageConsoleAgent::create):
* inspector/InspectorApplicationCacheAgent.cpp:
* inspector/InspectorApplicationCacheAgent.h:
InspectorAgent was not used by these files, remove it.

* inspector/CommandLineAPIHost.cpp:
* inspector/CommandLineAPIHost.h:
(WebCore::CommandLineAPIHost::init):
* inspector/InspectorInstrumentation.cpp:
* inspector/InstrumentingAgents.h:
(WebCore::InstrumentingAgents::inspectorAgent):
(WebCore::InstrumentingAgents::setInspectorAgent):
Switch to Inspector::InspectorAgent where applicable.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorController.h:
Manually add InspectorAgent to the InstrumentingAgents. It is one
of the agents that is always available in InstrumentingAgents.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd TextAutoSizing.* for iOS, and fix DeviceOrientationController creation.
simon.fraser@apple.com [Sat, 11 Jan 2014 05:02:01 +0000 (05:02 +0000)]
Add TextAutoSizing.* for iOS, and fix DeviceOrientationController creation.

* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::Document::Document):
* rendering/TextAutoSizing.cpp: Added.
(WebCore::cloneRenderStyleWithState):
(WebCore::TextAutoSizingKey::TextAutoSizingKey):
(WebCore::TextAutoSizingKey::~TextAutoSizingKey):
(WebCore::TextAutoSizingKey::operator=):
(WebCore::TextAutoSizingKey::ref):
(WebCore::TextAutoSizingKey::deref):
(WebCore::TextAutoSizingValue::numNodes):
(WebCore::TextAutoSizingValue::addNode):
(WebCore::TextAutoSizingValue::adjustNodeSizes):
(WebCore::TextAutoSizingValue::reset):
* rendering/TextAutoSizing.h: Added.
(WebCore::TextAutoSizingKey::doc):
(WebCore::TextAutoSizingKey::style):
(WebCore::TextAutoSizingKey::isValidDoc):
(WebCore::TextAutoSizingKey::isValidStyle):
(WebCore::TextAutoSizingKey::deletedKeyDoc):
(WebCore::TextAutoSizingKey::deletedKeyStyle):
(WebCore::operator==):
(WebCore::TextAutoSizingHash::hash):
(WebCore::TextAutoSizingHash::equal):
(WebCore::TextAutoSizingValue::create):
(WebCore::TextAutoSizingValue::TextAutoSizingValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix GraphicsLayerCA.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 04:44:31 +0000 (04:44 +0000)]
Fix GraphicsLayerCA.o for iOS. Unreviewed build fix.

Use of systemMemoryLevel was missing include of SystemMemory.h.

* platform/graphics/ca/GraphicsLayerCA.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix iOS build.
simon.fraser@apple.com [Sat, 11 Jan 2014 04:41:33 +0000 (04:41 +0000)]
Fix iOS build.

* bindings/objc/DOM.mm:
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
* bindings/objc/DOMExtensions.h:
* platform/DragImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix iOS build.
simon.fraser@apple.com [Sat, 11 Jan 2014 04:41:31 +0000 (04:41 +0000)]
Fix iOS build.

Generated DOMTouch* and DOMGesture* files need to be in the project.
Exclude them on Mac via EXCLUDED_SOURCE_FILE_NAMES_macosx.

Use TARGET_OS_IPHONE instead of TARGET_OS_EMBEDDED in DOMPrivate.h

* Configurations/WebCore.xcconfig:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOMPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix RenderThemeIOS.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 04:39:03 +0000 (04:39 +0000)]
Fix RenderThemeIOS.o for iOS. Unreviewed build fix.

Typo referring to generated name. Should be "iOS" not "IOS".

* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::mediaControlsScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix WebAccessibilityObjectWrapperIOS.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 04:31:53 +0000 (04:31 +0000)]
Fix WebAccessibilityObjectWrapperIOS.o for iOS. Unreviewed build fix.

The upstreamed WebAccessibilityObjectWrapperIOS.mm was out of date, e.g.
it was using GSFonts. Just upstream a newer version of the file. Also
explicitly namespace qualify std::pair.

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(AXAttributeStringSetStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove willRespondToTouchEvents() which was used by chromium port
jinwoo7.song@samsung.com [Sat, 11 Jan 2014 04:26:14 +0000 (04:26 +0000)]
Remove willRespondToTouchEvents() which was used by chromium port
https://bugs.webkit.org/show_bug.cgi?id=126739

Reviewed by Alexey Proskuryakov.

willRespondToTouchEvents() was added to check if a node listens to touch events in r126945.
However, it is not used anywhere after chromium port is removed.

* dom/Node.cpp:
* dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix SystemVersionMac.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 04:17:24 +0000 (04:17 +0000)]
Fix SystemVersionMac.o for iOS. Unreviewed build fix.

Add missing expected function. Maybe we can avoid including
this file entirely on iOS, there was already a FIXME.

* platform/mac/SystemVersionMac.mm:
(WebCore::systemMarketingVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix JSDOMWindowBase.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 04:13:18 +0000 (04:13 +0000)]
Fix JSDOMWindowBase.o for iOS. Unreviewed build fix.

Add missing iOS method declarations.

* bindings/js/JSDOMWindowBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r161702.
commit-queue@webkit.org [Sat, 11 Jan 2014 04:06:17 +0000 (04:06 +0000)]
Unreviewed, rolling out r161702.
http://trac.webkit.org/changeset/161702
https://bugs.webkit.org/show_bug.cgi?id=126803

Broke multiple tests (Requested by ap on #webkit).

Source/JavaScriptCore:

* runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):

LayoutTests:

* js/script-tests/typedarray-constructors.js: Removed.
* js/typedarray-constructors-expected.txt: Removed.
* js/typedarray-constructors.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix InputType.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 04:05:19 +0000 (04:05 +0000)]
Fix InputType.o for iOS. Unreviewed build fix.

The RuntimeEnabledFeatures function pointer type should have a
const qualifier, because the implementations are all const.

* html/InputType.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix MediaPlayerPrivateIOS.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 03:58:22 +0000 (03:58 +0000)]
Fix MediaPlayerPrivateIOS.o for iOS. Unreviewed build fix.

Add missing MediaPlayerProxy Objective C methods and forward declarations.

* platform/graphics/mac/MediaPlayerProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix FrameSelection.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 03:49:10 +0000 (03:49 +0000)]
Fix FrameSelection.o for iOS. Unreviewed build fix.

r160966 renamed rendererIsEditable to hasEditableStyle.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelectionFromNone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix DragData.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 03:46:20 +0000 (03:46 +0000)]
Fix DragData.o for iOS. Unreviewed build fix.

String m_pasteboardName is unused on iOS, so ifdef it out.

* platform/DragData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix FrameIOS.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 03:32:51 +0000 (03:32 +0000)]
Fix FrameIOS.o for iOS. Unreviewed build fix.

Remove stale include to file that no longer exists. It was not needed.

* page/ios/FrameIOS.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix MonthInputType.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 03:29:43 +0000 (03:29 +0000)]
Fix MonthInputType.o for iOS. Unreviewed build fix.

When ENABLE_INPUT_MULTIPLE_FIELDS_UI was removed in r150876,
the wrong class name lingered. Fix it to be the base class.

* html/TimeInputType.cpp:
(WebCore::TimeInputType::TimeInputType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Build fix: make sure WTF_PLATFORM_IOS is defined when preprocessing
aestes@apple.com [Sat, 11 Jan 2014 02:26:39 +0000 (02:26 +0000)]
[iOS] Build fix: make sure WTF_PLATFORM_IOS is defined when preprocessing

* DerivedSources.make:
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse TARGET_OS_IPHONE in this API file, and #if TARGET_OS_MAC
simon.fraser@apple.com [Sat, 11 Jan 2014 02:25:33 +0000 (02:25 +0000)]
Use TARGET_OS_IPHONE in this API file, and #if TARGET_OS_MAC
for a non-iOS function.

* bindings/objc/DOMExtensions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClean up architectures in xcconfig files
ddkilzer@apple.com [Sat, 11 Jan 2014 02:19:33 +0000 (02:19 +0000)]
Clean up architectures in xcconfig files
<http://webkit.org/b/126794>

Reviewed by Andy Estes.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:
* Configurations/JavaScriptCore.xcconfig: Remove armv6, ppc.
* Configurations/ToolExecutable.xcconfig: Sort.
- Add new arch.

Source/WebCore:

* Configurations/Base.xcconfig:
* Configurations/WebCore.xcconfig: Remove armv6.
* DerivedSources.make: Remove armv6, armv7f. Sort.
- Add new arch.

Source/WebKit/mac:

* Configurations/WebKit.xcconfig: Remove armv6, armv7f, ppc.
- Add new arch.

Source/WTF:

* Configurations/Base.xcconfig:
- Add new arch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix iOS build
simon.fraser@apple.com [Sat, 11 Jan 2014 02:16:22 +0000 (02:16 +0000)]
Fix iOS build

* Configurations/WebCore.xcconfig:
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix iOS build.
simon.fraser@apple.com [Sat, 11 Jan 2014 01:59:24 +0000 (01:59 +0000)]
Fix iOS build.

* html/DateTimeLocalInputType.h:
(WebCore::DateTimeLocalInputType::DateTimeLocalInputType):
* loader/ios/DiskImageCacheIOS.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoiOS build fix: add StyleRareInheritedData::compositionFillColor
simon.fraser@apple.com [Sat, 11 Jan 2014 01:59:21 +0000 (01:59 +0000)]
iOS build fix: add StyleRareInheritedData::compositionFillColor

* rendering/style/RenderStyle.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix MonthInputType.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 01:50:32 +0000 (01:50 +0000)]
Fix MonthInputType.o for iOS. Unreviewed build fix.

Incorrect base class name. Must have been typo'd when upstreaming.

* html/MonthInputType.h:
(WebCore::MonthInputType::MonthInputType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix RenderButton.o for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 01:33:47 +0000 (01:33 +0000)]
Fix RenderButton.o for iOS. Unreviewed build fix.

Missing prototype in header for override of the layout method.

* rendering/RenderButton.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoA couple of iOS build fixes.
simon.fraser@apple.com [Sat, 11 Jan 2014 01:29:51 +0000 (01:29 +0000)]
A couple of iOS build fixes.

* accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix iOS build.
simon.fraser@apple.com [Sat, 11 Jan 2014 01:29:49 +0000 (01:29 +0000)]
Fix iOS build.

* loader/ResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix PlatformScreenIOS.mm for iOS. Unreviewed build fix.
joepeck@webkit.org [Sat, 11 Jan 2014 01:26:40 +0000 (01:26 +0000)]
Fix PlatformScreenIOS.mm for iOS. Unreviewed build fix.

PlatformScreen.h removed screenVerticalDPI and screenHorizontalDPI in r132419,
so remove the stale implementations on iOS. Also, add a notImplemented version
of screenColorProfile, which matches Mac and is unused in WebCore for this port.

* platform/ios/PlatformScreenIOS.mm:
(WebCore::screenColorProfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCTTE FrameTree
andersca@apple.com [Sat, 11 Jan 2014 01:19:15 +0000 (01:19 +0000)]
CTTE FrameTree
https://bugs.webkit.org/show_bug.cgi?id=126795

Reviewed by Tim Horton.

* page/Frame.cpp:
(WebCore::Frame::Frame):
* page/FrameTree.cpp:
(WebCore::FrameTree::transferChild):
(WebCore::FrameTree::appendChild):
(WebCore::FrameTree::actuallyAppendChild):
(WebCore::FrameTree::uniqueChildName):
(WebCore::FrameTree::scopedChild):
(WebCore::FrameTree::scopedChildCount):
(WebCore::FrameTree::child):
(WebCore::FrameTree::find):
(WebCore::FrameTree::isDescendantOf):
(WebCore::FrameTree::traverseNext):
(WebCore::FrameTree::traverseNextWithWrap):
(WebCore::FrameTree::traversePreviousWithWrap):
(WebCore::FrameTree::deepLastChild):
(WebCore::FrameTree::top):
* page/FrameTree.h:
(WebCore::FrameTree::FrameTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
dino@apple.com [Sat, 11 Jan 2014 01:09:58 +0000 (01:09 +0000)]
[JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
https://bugs.webkit.org/show_bug.cgi?id=126754

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

The ECMAScript specification forbids calling the typed array
constructors without using "new". Change the call data to return
none so we throw and exception in these cases.

* runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):

LayoutTests:

New test which checks that we throw an exception when calling
any of the typed array constructors without using "new".

* js/script-tests/typedarray-constructors.js: Added.
* js/typedarray-constructors-expected.txt: Added.
* js/typedarray-constructors.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix iOS build.
simon.fraser@apple.com [Sat, 11 Jan 2014 01:05:18 +0000 (01:05 +0000)]
Fix iOS build.

* platform/graphics/ImageSource.h:
(WebCore::ImageSource::acceleratedImageDecodingEnabled):
(WebCore::ImageSource::setAcceleratedImageDecodingEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed EFL build fix after r161678.
joepeck@webkit.org [Sat, 11 Jan 2014 00:55:15 +0000 (00:55 +0000)]
Unreviewed EFL build fix after r161678.

static_cast a size_t to unsigned long for %lu format string.

* page/Console.cpp:
(WebCore::internalAddMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove the BlackBerry port from trunk
benjamin@webkit.org [Sat, 11 Jan 2014 00:53:54 +0000 (00:53 +0000)]
Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

.:

* CMakeLists.txt:
* Source/cmake/OptionsCommon.cmake:

Source/JavaScriptCore:

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::cacheFlush):
* assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
(JSC::ARMv7Assembler::cacheFlush):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):
* heap/MachineStackMarker.cpp:
(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
(JSC::freePlatformThreadRegisters):
* jit/ExecutableAllocator.h:

Source/WebCore:

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::readPixels):
* platform/graphics/ImageBuffer.cpp:
* platform/graphics/ImageBufferData.h:
* platform/graphics/IntPoint.h:
* platform/graphics/IntRect.h:
* platform/graphics/IntSize.h:
* platform/graphics/MediaPlayer.cpp:
* platform/graphics/NativeImagePtr.h:
* platform/graphics/OpenGLESShims.h:
* platform/graphics/Path.cpp:
(WebCore::Path::addPathForRoundedRect):
* platform/graphics/Path.h:
* platform/graphics/PlatformLayer.h:
* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
* platform/graphics/filters/CustomFilterValidatedProgram.h:
* platform/graphics/filters/FilterOperation.h:
* platform/graphics/gpu/DrawingBuffer.cpp:
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::getGraphicsResetStatusARB):
* platform/graphics/opengl/Extensions3DOpenGLES.h:
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::reshapeFBOs):
* platform/network/NetworkStateNotifier.h:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/ResourceRequestBase.cpp:

Tools:

* DumpRenderTree/DumpRenderTree.h:
* DumpRenderTree/PixelDumpSupport.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix CharsetData.cpp build for iOS
simon.fraser@apple.com [Sat, 11 Jan 2014 00:44:31 +0000 (00:44 +0000)]
Fix CharsetData.cpp build for iOS
https://bugs.webkit.org/show_bug.cgi?id=126792

Reviewed by Mark Rowe.

CharsetData.cpp should have an empty CharsetTable list for iOS.
Achieve this with an iOS-specific encodings.txt file.

* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* platform/text/mac/ios-encodings.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCTTE in NavigationScheduler
andersca@apple.com [Sat, 11 Jan 2014 00:38:16 +0000 (00:38 +0000)]
CTTE in NavigationScheduler
https://bugs.webkit.org/show_bug.cgi?id=126788

Reviewed by Tim Horton.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::frameScheduledNavigationImpl):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigationImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::frameScheduledNavigation):
(WebCore::InspectorPageAgent::frameClearedScheduledNavigation):
* inspector/InspectorPageAgent.h:
* loader/NavigationScheduler.cpp:
(WebCore::ScheduledNavigation::shouldStartTimer):
(WebCore::ScheduledNavigation::didStartTimer):
(WebCore::ScheduledNavigation::didStopTimer):
(WebCore::NavigationScheduler::NavigationScheduler):
(WebCore::NavigationScheduler::clear):
(WebCore::NavigationScheduler::shouldScheduleNavigation):
(WebCore::NavigationScheduler::scheduleRedirect):
(WebCore::NavigationScheduler::mustLockBackForwardList):
(WebCore::NavigationScheduler::scheduleLocationChange):
(WebCore::NavigationScheduler::scheduleFormSubmission):
(WebCore::NavigationScheduler::scheduleRefresh):
(WebCore::NavigationScheduler::scheduleHistoryNavigation):
(WebCore::NavigationScheduler::timerFired):
(WebCore::NavigationScheduler::schedule):
(WebCore::NavigationScheduler::startTimer):
(WebCore::NavigationScheduler::cancel):
* loader/NavigationScheduler.h:
* page/Frame.cpp:
(WebCore::Frame::Frame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCSS word-spacing property does not obey percentages
mmaxfield@apple.com [Sat, 11 Jan 2014 00:31:19 +0000 (00:31 +0000)]
CSS word-spacing property does not obey percentages
https://bugs.webkit.org/show_bug.cgi?id=126674

Reviewed by Simon Fraser.

Source/WebCore:

One change between CSS2.1 and CSS3 is that the word-spacing CSS property can
take percentages (of the width of the space character) in CSS3. In order to
implement this, the datatype must be changed from a float to a Length, which
can hold percentage values. Then, during layout, we can query the width of
the space character and update the Font's word-spacing value appropriately.
However, the RenderStyle still holds on to the Length (as a rare inherited
value).

Tests: fast/css3-text/css3-word-spacing-percentage/word-spacing-change-font.html
       fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-parse.html
       fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue): Use Font's computed value instead
of style's Length value.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): word-spacing and letter-spacing no longer are
parsed the same way.
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyWordSpacing::applyValue): Construct a length from a given
CSSValue and set the style's word spacing with it.
(WebCore::ApplyPropertyWordSpacing::createHandler):
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): Use ApplyPropertyWordSpacing.
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun): Use Font's computed value instead
of style's Length value.
* rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths): Ditto.
* rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor): Opt-out of the SimpleLineLayout
if either the percentage or the length is nonzero.
* rendering/line/BreakingContextInlineHeaders.h:
(WebCore::BreakingContext::handleText): Use Font's computed value instead
of style's Length value.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::wordSpacing):
(WebCore::RenderStyle::setWordSpacing): Consult the Font's space with to compute
percentage values, but hold on to the original Length.
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareInheritedData.cpp:
* rendering/style/StyleRareInheritedData.h: Hold on to the specified Length

LayoutTests:

See per-file description

* fast/css3-text/css3-word-spacing-percentage/word-spacing-change-font-expected.html: Added.
* fast/css3-text/css3-word-spacing-percentage/word-spacing-change-font.html: Added.
Make sure that if Javascript changes the font after initial layout, that the word-spacing
value gets appropriately updated.
* fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-expected.html: Added.
* fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-parse-expected.txt: Added.
* fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-parse.html: Added.
Make sure that the CSSOM yields the correct percentage values when queried.
* fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html: Added.
Try some specific values of percentages (-100%, 0%, and 100%).
* css1/text_properties/word_spacing.html: Updated to not disregard percentages
* css2.1/20110323/c541-word-sp-001-expected.html:
* css2.1/20110323/c541-word-sp-001.htm: Ditto
* platform/mac/css1/text_properties/word_spacing-expected.png:
* platform/mac/css1/text_properties/word_spacing-expected.txt: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the iOS build.
simon.fraser@apple.com [Sat, 11 Jan 2014 00:19:53 +0000 (00:19 +0000)]
Fix the iOS build.

* platform/audio/mac/MediaSessionManagerMac.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoiOS doesn't have <OpenGL/gl.h>; fix iOS build.
simon.fraser@apple.com [Sat, 11 Jan 2014 00:17:20 +0000 (00:17 +0000)]
iOS doesn't have <OpenGL/gl.h>; fix iOS build.

* platform/graphics/opengl/TemporaryOpenGLSetting.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Build Fix: Properly add $SDKROOT/usr/local/include/ to the search path when...
aestes@apple.com [Sat, 11 Jan 2014 00:16:25 +0000 (00:16 +0000)]
[iOS] Build Fix: Properly add $SDKROOT/usr/local/include/ to the search path when building PublicDOMInterfaces.h

* bindings/scripts/CodeGeneratorObjC.pm:
(ReadPublicInterfaces):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: Remove unimplemented or static ScriptDebugServer features
commit-queue@webkit.org [Fri, 10 Jan 2014 23:55:09 +0000 (23:55 +0000)]
Web Inspector: Remove unimplemented or static ScriptDebugServer features
https://bugs.webkit.org/show_bug.cgi?id=126784

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-10
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

* inspector/protocol/Debugger.json:

Source/WebCore:

These features are unimplemented in the backend, and unused by the
current frontend. Most deal with features that were supported by v8
and are as yet unimplemented by JSC. If we decide to add such features
we can reimplement without conforming to an old implementation.

* bindings/js/ScriptDebugServer.cpp:
* bindings/js/ScriptDebugServer.h:
* bindings/js/ScriptProfiler.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::disable):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::frameNavigated):
* inspector/InspectorPageAgent.h:
* inspector/InspectorProfilerAgent.cpp:
* inspector/InspectorProfilerAgent.h:
* inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::didClearMainFrameWindowObject):
* inspector/protocol/Page.json:
* inspector/protocol/Profiler.json:

Source/WebInspectorUI:

* UserInterface/InspectorJSBackendCommands.js:
* UserInterface/InspectorWebBackendCommands.js:
* UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
* UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
* Versions/Inspector-iOS-6.0.json:
* Versions/Inspector-iOS-7.0.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Remove unused variable from TileGrid::dropTilesBetweenRects()
ddkilzer@apple.com [Fri, 10 Jan 2014 23:54:34 +0000 (23:54 +0000)]
[iOS] Remove unused variable from TileGrid::dropTilesBetweenRects()

Fixes the following build error:

    WebCore/platform/ios/TileGrid.mm:88:23: error: unused variable 'end' [-Werror,-Wunused-variable]
        TileMap::iterator end = m_tiles.end();
                          ^

* platform/ios/TileGrid.mm:
(WebCore::TileGrid::dropTilesBetweenRects): Remove unused
variable now that the for loop uses an auto iterator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: support negative numbers in secondsToString and bytesToString.
timothy@apple.com [Fri, 10 Jan 2014 23:54:10 +0000 (23:54 +0000)]
Web Inspector: support negative numbers in secondsToString and bytesToString.

https://bugs.webkit.org/show_bug.cgi?id=125708

Reviewed by Joseph Pecoraro.

* UserInterface/Utilities.js:
(Number.secondsToString): Use Math.abs in the size checks.
(Number.bytesToString): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoImplement OES texture half float linear
dino@apple.com [Fri, 10 Jan 2014 23:53:04 +0000 (23:53 +0000)]
Implement OES texture half float linear
https://bugs.webkit.org/show_bug.cgi?id=125060

Reviewed by Brent Fulgham.

Source/WebCore:

Test: fast/canvas/webgl/oes-texture-half-float-linear.html

* CMakeLists.txt: Add new files.
* DerivedSources.cpp: Ditto.
* DerivedSources.make: Generate new file from IDL.
* GNUmakefile.list.am: Add new files.
* WebCore.vcxproj/WebCore.vcxproj: Ditto.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
* WebCore.xcodeproj/project.pbxproj: New files for OESTextureHalfFloatLinear.

* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS): Map from extension name to native object.

* html/canvas/OESTextureHalfFloatLinear.cpp: Added. New files. These are boiler-plate.
* html/canvas/OESTextureHalfFloatLinear.h: Added.
* html/canvas/OESTextureHalfFloatLinear.idl: Added.

* html/canvas/WebGLExtension.h: Add new enum for the new extension.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension): Create the extension object if the
context is asked for one.
(WebCore::WebGLRenderingContext::getSupportedExtensions): Add the new extension to the
list of supported extensions. Actually remember to do it this time :)
(WebCore::WebGLRenderingContext::checkTextureCompleteness): Need to check for the half-float
extension as well, and update the log message.
* html/canvas/WebGLRenderingContext.h: New extension object.

* html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::WebGLTexture):
(WebCore::WebGLTexture::needToUseBlackTexture): Check for half-float type.
(WebCore::WebGLTexture::update): Mark a texture as half-float if necessary.
* html/canvas/WebGLTexture.h:

* platform/graphics/Extensions3D.h: Add a comment about the new extension.
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension): This extension is available
when GL_ARB_texture_float is supported, so add the name to the translation.

LayoutTests:

Exercise the OES_texture_half_float_linear extension. The new test
is copied from the official Khronos WebGL repository.

* fast/canvas/webgl/oes-texture-float-linear-expected.txt: Change the console log
messages, which now also mention half float linear.
* fast/canvas/webgl/oes-texture-half-float-linear-expected.txt: Added.
* fast/canvas/webgl/oes-texture-half-float-linear.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoWeb Inspector: cycle clicked breakpoints between enabled, auto-continue, and disabled
bburg@apple.com [Fri, 10 Jan 2014 23:48:54 +0000 (23:48 +0000)]
Web Inspector: cycle clicked breakpoints between enabled, auto-continue, and disabled
https://bugs.webkit.org/show_bug.cgi?id=126669

Reviewed by Joseph Pecoraro.

It's time-consuming to change a breakpoint's auto-continue setting through the
breakpoint editor popup. This patch enables the user to toggle between enabled,
auto-continue, and disabled by clicking on the breakpoint wedge in the sidebar
tree and in the source text editor gutter. The auto-continue option is only
cycled when the breakpoint has associated actions.

Clean up the breakpoint editor dialog so it hides irrelevant options when
no breakpoint actions have been added.

Automatically unset auto-continue when the last breakpoint action is removed.

Rename the delegate textEditorBreakpointToggled to textEditorBreakpointClicked, since
the behavior of the click depends on breakpoint state not available in the text editor.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Breakpoint.js:
(WebInspector.Breakpoint.prototype.cycleToNextMode): Added.
(WebInspector.Breakpoint.prototype.toggleAutoContinue): Added.
(WebInspector.Breakpoint.prototype.appendContextMenuItems): Add auto-continue options.
(WebInspector.Breakpoint.prototype.removeAction):

(WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
(WebInspector.Breakpoint.prototype._popoverActionsAddActionButtonClicked):
(WebInspector.Breakpoint.prototype.breakpointActionViewAppendActionView):
(WebInspector.Breakpoint.prototype.breakpointActionViewRemoveActionView):
(WebInspector.Breakpoint.prototype.willDismissPopover):
* UserInterface/BreakpointTreeElement.css:
(.item.breakpoint .status > .status-image.auto-continue):
(.item.breakpoint .status > .status-image.disabled):
* UserInterface/BreakpointTreeElement.js:
(WebInspector.BreakpointTreeElement):
(WebInspector.BreakpointTreeElement.prototype.onenter):
(WebInspector.BreakpointTreeElement.prototype.onspace):
(WebInspector.BreakpointTreeElement.prototype._updateStatus):
(WebInspector.BreakpointTreeElement.prototype._breakpointLocationDidChange):
(WebInspector.BreakpointTreeElement.prototype._statusImageElementClicked):
* UserInterface/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.close):
(WebInspector.SourceCodeTextEditor.prototype._breakpointInfoForBreakpoint):
(WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointClicked):
* UserInterface/TextEditor.css:
(.text-editor > .CodeMirror .breakpoint-auto-continue:not(.breakpoint-disabled) .CodeMirror-linenumber::before):
* UserInterface/TextEditor.js:
(WebInspector.TextEditor.prototype._setBreakpointStylesOnLine.updateStyles):
(WebInspector.TextEditor.prototype._setBreakpointStylesOnLine):
(WebInspector.TextEditor.prototype.updateStyles):
(WebInspector.TextEditor.prototype._removeBreakpointFromLineAndColumn):
(WebInspector.TextEditor.prototype._documentMouseUp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoREGRESSION(C stack work): stack traces no longer work in CrashTracer, lldb, and other...
msaboff@apple.com [Fri, 10 Jan 2014 23:47:12 +0000 (23:47 +0000)]
REGRESSION(C stack work): stack traces no longer work in CrashTracer, lldb, and other tools
https://bugs.webkit.org/show_bug.cgi?id=126764

Reviewed by Geoffrey Garen.

Updated callToJavaScript and cllToNativeFunction to properly replicate the caller's
return PC and frame pointer in the sentinel frame.  For X86-64, added .cfi_
directives to create eh_frame info for all LLInt symbols so that the various
unwinding code understands that we are using a separate JS stack referenced
by BP and at what offsets in that frame the prior PC (register 16) and prior
BP (register 6) can be found.  These two changes are sufficient for stack tracing
to work for Mac OSX.

* llint/LowLevelInterpreter.cpp:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Fix project build order
dbates@webkit.org [Fri, 10 Jan 2014 23:36:58 +0000 (23:36 +0000)]
[iOS] Fix project build order

Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
time of writing.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSource/WebCore: [WebGL] Correct uniform input validation for texture sampler uniform
bfulgham@apple.com [Fri, 10 Jan 2014 23:28:29 +0000 (23:28 +0000)]
Source/WebCore: [WebGL] Correct uniform input validation for texture sampler uniform
https://bugs.webkit.org/show_bug.cgi?id=126775

Reviewed by Dean Jackson.

Added fast/canvas/webgl/uniform-samplers-test.html

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::uniform1iv): Access Int32Array data properly.

LayoutTests: [WebGL] Correct uniform input validation for texture sampler uniforms.
https://bugs.webkit.org/show_bug.cgi?id=126775

Reviewed by Dean Jackson.

* fast/canvas/webgl/uniform-samplers-test.html: Add a test that
shows that we can set sampler uniforms using Int32Array types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[GTK] Unreviewed build fix after r161644.
rego@igalia.com [Fri, 10 Jan 2014 22:54:16 +0000 (22:54 +0000)]
[GTK] Unreviewed build fix after r161644.

* Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::setFormat):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove an unused FrameLoader function
andersca@apple.com [Fri, 10 Jan 2014 22:52:14 +0000 (22:52 +0000)]
Remove an unused FrameLoader function
https://bugs.webkit.org/show_bug.cgi?id=126785

Reviewed by Beth Dakin.

* WebCore.exp.in:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::setState):
* loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove the BlackBerry port from trunk
benjamin@webkit.org [Fri, 10 Jan 2014 22:48:57 +0000 (22:48 +0000)]
Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypesForEncoding):
* platform/PlatformKeyboardEvent.h:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
* platform/PlatformMouseEvent.h:
* platform/PlatformTouchEvent.h:
(WebCore::PlatformTouchEvent::PlatformTouchEvent):
* platform/PlatformTouchPoint.h:
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimator::create):
* platform/URL.cpp:
(WebCore::URL::parse):
(WebCore::portAllowed):
* platform/Widget.h:
* platform/graphics/ANGLEWebKitBridge.h:
* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
* platform/graphics/DisplayRefreshMonitor.h:
* platform/graphics/FloatPoint.h:
* platform/graphics/FloatRect.h:
* platform/graphics/FloatSize.h:
* platform/graphics/FontCache.h:
* platform/graphics/FontPlatformData.h:
* platform/graphics/GlyphBuffer.h:
* platform/graphics/Gradient.cpp:
* platform/graphics/Gradient.h:
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove dead code
andersca@apple.com [Fri, 10 Jan 2014 22:24:00 +0000 (22:24 +0000)]
Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=126782

Reviewed by Tim Horton.

* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClean up and fix some issues with stdout formatting of console messages.
timothy@apple.com [Fri, 10 Jan 2014 22:16:17 +0000 (22:16 +0000)]
Clean up and fix some issues with stdout formatting of console messages.

* Fix URLs not printing line numbers unless column number is > 0.
* Change "CONSOLEAPI" to "CONSOLE" for the source.
* Clean up how console.trace outputs and print URL, line and column for each frame.
* Print "(unknown)" for anonymous and native code call frames.

https://bugs.webkit.org/show_bug.cgi?id=126767

Reviewed by Joseph Pecoraro.

* page/Console.cpp:
(WebCore::internalAddMessage):
* page/PageConsole.cpp:
(WebCore::PageConsole::printSourceURLAndPosition):
(WebCore::PageConsole::printMessageSourceAndLevelPrefix):
* page/PageConsole.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClean up some areas of TreeOutline.
timothy@apple.com [Fri, 10 Jan 2014 22:13:07 +0000 (22:13 +0000)]
Clean up some areas of TreeOutline.

https://bugs.webkit.org/show_bug.cgi?id=123924

Reviewed by Joseph Pecoraro.

* UserInterface/TreeOutline.js:
(TreeOutline.prototype.appendChild): Don't force create _childrenListNode, it will be created
when the tree element is expanded. Only attach if _childrenListNode already exists.
(TreeOutline.prototype.insertChild): Ditto.
(TreeOutline.prototype.getCachedTreeElement): Check the value of __treeElementIdentifier
not just the existence of the property. It should never be null/undefined/0, but be safe.
(TreeOutline.prototype.findTreeElement): Null check isAncestor, it isn't required.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Fill in missing WebCoreThread function pointers
commit-queue@webkit.org [Fri, 10 Jan 2014 22:11:53 +0000 (22:11 +0000)]
[iOS] Fill in missing WebCoreThread function pointers
https://bugs.webkit.org/show_bug.cgi?id=126776

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-10
Reviewed by Timothy Hatcher.

* platform/ios/wak/WebCoreThreadSystemInterface.cpp:
(InitWebCoreThreadSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoClear unparented tiled layers on memory pressure.
commit-queue@webkit.org [Fri, 10 Jan 2014 22:10:44 +0000 (22:10 +0000)]
Clear unparented tiled layers on memory pressure.
https://bugs.webkit.org/show_bug.cgi?id=126737

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-10
Reviewed by Simon Fraser.

Source/WebCore:

TileController hold unparented tiles for a short period of time (1 -3 sec); we should clear these unparented
tiles immediately if we are under memory pressure.

The patch does 3 things to improve the behavior:
1) When the system free memory is low (<35%), reduce the tiling threshold.  This could reduce
the peak memory usage when system is under low memory since we will convert more web layers into
tiled backing.
2) Under memory pressure, immediately clear all unparented tiles.
3) Add a cap (16 tiles) to limit the total number of unparented tiles in TileController's.

* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj: Add a new class TileControllerMemoryHandler.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::requiresTiledLayer):  Use a smaller tiling threshold if the system free memory is low.
* platform/graphics/ca/mac/TileController.h:
(WebCore::TileController::numberOfUnparentedTiles):
* platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::startedNewCohort):
(WebCore::TileController::removeUnparentedTilesNow): Remove all unparentd tiles.
* platform/ios/MemoryPressureHandlerIOS.mm:
* platform/ios/TileControllerMemoryHandlerIOS.cpp: Added.
(WebCore::TileControllerMemoryHandler::removeTileController):
(WebCore::TileControllerMemoryHandler::totalUnparentedTiledLayers):
(WebCore::TileControllerMemoryHandler::tileControllerGainUnparentedTiles):
(WebCore::TileControllerMemoryHandler::trimUnparentedTilesToTarget): Trims the number of unparented tiles until
    it reaches the target.
(WebCore::tileControllerMemoryHandler):
* platform/ios/TileControllerMemoryHandlerIOS.h: Added.
(WebCore::TileControllerMemoryHandler::TileControllerMemoryHandler):

Source/WebKit/mac:

* WebView/WebView.mm:
(+[WebView _handleMemoryWarning]): Clear all unparented tiles when under memory pressure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix an exception in WebInspector.Color.
timothy@apple.com [Fri, 10 Jan 2014 22:06:15 +0000 (22:06 +0000)]
Fix an exception in WebInspector.Color.

https://bugs.webkit.org/show_bug.cgi?id=126765

Reviewed by Joseph Pecoraro.

* UserInterface/Color.js:
(WebInspector.Color.fromString): Check hasOwnPrperty before using the nickname color array.
(WebInspector.Color.prototype._toNicknameString): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Blending] Log blending as a layer creation reason in the WI
commit-queue@webkit.org [Fri, 10 Jan 2014 21:42:07 +0000 (21:42 +0000)]
[CSS Blending] Log blending as a layer creation reason in the WI
https://bugs.webkit.org/show_bug.cgi?id=126159

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-10
Reviewed by Timothy Hatcher.

Source/WebCore:

* inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):
* inspector/protocol/LayerTree.json:

Source/WebInspectorUI:

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._populateListOfCompositingReasons):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[EFL][JSC] Enable udis86 disassembler on efl.
commit-queue@webkit.org [Fri, 10 Jan 2014 21:37:34 +0000 (21:37 +0000)]
[EFL][JSC] Enable udis86 disassembler on efl.
https://bugs.webkit.org/show_bug.cgi?id=125502

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-01-10
Reviewed by Michael Saboff.

Enable udis86 disassembler on efl and fix build warnings.

.:

* Source/cmake/OptionsEfl.cmake:
  Enable udis86 disassembler.

Source/JavaScriptCore:

* CMakeLists.txt:
  Add udis86 disassembler source files.
* disassembler/udis86/udis86_decode.c:
(decode_modrm_rm):
  Build warning fixes.
* disassembler/udis86/udis86_syn-att.c:
(gen_operand):
  Build warning fixes.
* disassembler/udis86/udis86_syn-intel.c:
(gen_operand):
  Build warning fixes.
* disassembler/udis86/udis86_types.h:
  Correct FMT64 for uint64_t.

Source/WTF:

* wtf/Platform.h:
  Enable udis86 disassembler on EFL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix some iOS build errors during bindings generation.
aestes@apple.com [Fri, 10 Jan 2014 21:37:19 +0000 (21:37 +0000)]
Fix some iOS build errors during bindings generation.

* bindings/objc/PublicDOMInterfaces.h: Included
WebKitAdditions/PublicDOMInterfacesIOS.h and change
-[DOMRGBColor color] to return a CGColorRef on iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPrevent some resources from showing up in Web Inspector as years in duration.
timothy@apple.com [Fri, 10 Jan 2014 21:31:42 +0000 (21:31 +0000)]
Prevent some resources from showing up in Web Inspector as years in duration.

No WebKit port passed a monotonic time to InspectorInstrumentation::didFinishLoading -- except Chromium.

https://bugs.webkit.org/show_bug.cgi?id=126760

Reviewed by Joseph Pecoraro.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
Revert part of r102961 to use finishTime as-is and not expect a monotonic time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMake clipping path from basic-shapes relative to <box> value
krit@webkit.org [Fri, 10 Jan 2014 21:29:59 +0000 (21:29 +0000)]
Make clipping path from basic-shapes relative to <box> value
https://bugs.webkit.org/show_bug.cgi?id=126206

Reviewed by Simon Fraser.

Source/WebCore:

Tests: css3/masking/clip-path-circle-border-box.html
       css3/masking/clip-path-circle-bounding-box.html
       css3/masking/clip-path-circle-content-box.html
       css3/masking/clip-path-circle-margin-box.html
       css3/masking/clip-path-circle-padding-box.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupClipPath): Add switch to differ between boxes
    and use different reference boxes to size the clipping path.

LayoutTests:

Add new tests to check that different reference boxes are chosen for sizing and
positioning the clipping path.

* css3/masking/clip-path-circle-border-box.html: Added.
* css3/masking/clip-path-circle-bounding-box.html: Added.
* css3/masking/clip-path-circle-content-box.html: Added.
* css3/masking/clip-path-circle-margin-box.html: Added.
* css3/masking/clip-path-circle-padding-box.html: Added.
* platform/mac/css3/masking/clip-path-circle-border-box-expected.png: Added.
* platform/mac/css3/masking/clip-path-circle-border-box-expected.txt: Added.
* platform/mac/css3/masking/clip-path-circle-bounding-box-expected.png: Added.
* platform/mac/css3/masking/clip-path-circle-bounding-box-expected.txt: Added.
* platform/mac/css3/masking/clip-path-circle-content-box-expected.png: Added.
* platform/mac/css3/masking/clip-path-circle-content-box-expected.txt: Added.
* platform/mac/css3/masking/clip-path-circle-margin-box-expected.png: Added.
* platform/mac/css3/masking/clip-path-circle-margin-box-expected.txt: Added.
* platform/mac/css3/masking/clip-path-circle-padding-box-expected.png: Added.
* platform/mac/css3/masking/clip-path-circle-padding-box-expected.txt: Added.
* platform/mac/css3/masking/mask-luminance-png-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSource/WebCore: Correctly set XHR loadend attributes (loaded and total).
commit-queue@webkit.org [Fri, 10 Jan 2014 21:22:18 +0000 (21:22 +0000)]
Source/WebCore: Correctly set XHR loadend attributes (loaded and total).
https://bugs.webkit.org/show_bug.cgi?id=120828

Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-10
Reviewed by Alexey Proskuryakov.

Added correct initialization of lengthComputable, loaded and total attributes
to XHR ProgressEvent events (load, loadstart, loadend, abort, error and timeout).

XMLHttpRequestProgressEventThrottle and XMLHttpRequestUpload now keep persistent knowledge
of m_loaded and m_total values with this patch.

Code refactoring to handle event dispatching in case of error in a single manner.
XMLHttpRequestProgressEventThrottle::dispatchProgressEvent is renamed as dispatchThrottledProgressEvent
XMLHttpRequestProgressEventThrottle::dispatchEventAndLoadend is replaced by dispatchProgressEvent(const AtomicString&)

Fixed assertion issues over bug 120828 patch

Tests: http/tests/xmlhttprequest/loadstart-event-init.html
       http/tests/xmlhttprequest/onabort-progressevent-attributes.html
       http/tests/xmlhttprequest/onload-progressevent-attributes.html
       http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html
       http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::callReadyStateChangeListener): changed readystatechange event from ProgressEvent to Event (not cancellable, not bubblable) to better match the spec
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::abort): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::networkError): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::abortError): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::didSendData):
(WebCore::XMLHttpRequest::didReceiveData):
(WebCore::XMLHttpRequest::dispatchErrorEvents): dispatch progress events in case of error
(WebCore::XMLHttpRequest::didTimeout): code refactoring to handle error event dispatching in a single way
* xml/XMLHttpRequest.h:
* xml/XMLHttpRequestProgressEventThrottle.cpp: before the patch, the fact that a progress event is being throttled is stored indirectly (m_loaded or m_total not equal to zero). With the patch, this information is stored in m_hasThrottledProgressEvent. The m_loaded and m_total values are no longer set back to zero after a progress event is dispatched. This allows using these values to correctly initialize other ProgressEvent events (in particular loadend, abort, timeout...)
(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent): always update the new m_loaded and m_total values. If progress event is not sent as part of the function call, store the fact that a progress event is being throttled through m_hasThrottledProgressEvent.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): used to send any ProgressEvent event that is not be throttled
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): after the call, no progress event is throttled anymore
(WebCore::XMLHttpRequestProgressEventThrottle::fired): after the call, no progress event is throttled anymore
(WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch):
(WebCore::XMLHttpRequestProgressEventThrottle::suspend):
* xml/XMLHttpRequestProgressEventThrottle.h: introduced m_hasThrottledProgressEvent which stores whether a progress event is being throttled and m_computableLength which is used to initialize ProgressEvent computableLength
* xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
(WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
* xml/XMLHttpRequestUpload.h: introduced m_loaded, m_total and m_lengthComputable, similarly to XMLHttpRequestProgressEventThrottle

LayoutTests: Correctly set XHR loadend event attributes (loaded and total).
https://bugs.webkit.org/show_bug.cgi?id=120828

Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-10
Reviewed by Alexey Proskuryakov.

Tests for abort, load, loadstart and loadend ProgressEvent events for XMLHttpRequest and XMLHttpRequestUpload

* fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Changed to correct event values
* http/tests/xmlhttprequest/loadstart-event-init-expected.txt: Added.
* http/tests/xmlhttprequest/loadstart-event-init.html: Added.
* http/tests/xmlhttprequest/onabort-progressevent-attributes-expected.txt: Added.
* http/tests/xmlhttprequest/onabort-progressevent-attributes.html: Added.
* http/tests/xmlhttprequest/onload-progressevent-attributes-expected.txt: Added.
* http/tests/xmlhttprequest/onload-progressevent-attributes.html: Added.
* http/tests/xmlhttprequest/upload-onabort-progressevent-attributes-expected.txt: Added.
* http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html: Added.
* http/tests/xmlhttprequest/upload-onload-progressevent-attributes-expected.txt: Added.
* http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Shapes] Change parseBasicShape to return a CSSPrimitiveValue
betravis@adobe.com [Fri, 10 Jan 2014 21:12:26 +0000 (21:12 +0000)]
[CSS Shapes] Change parseBasicShape to return a CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=126713

Reviewed by Dirk Schulze.

Avoid the duplicated code wrapping the CSSBasicShape in a CSSPrimitiveValue
by having parseBasicShape return a CSSPrimitiveValue reference.

Refactoring, no new tests.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseShapeProperty):
(WebCore::CSSParser::parseClipPath):
(WebCore::CSSParser::parseBasicShape):
* css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoMove platformName property from testRunner to accessibilityController
mario.prada@samsung.com [Fri, 10 Jan 2014 21:10:57 +0000 (21:10 +0000)]
Move platformName property from testRunner to accessibilityController
https://bugs.webkit.org/show_bug.cgi?id=126689

Reviewed by Chris Fleizach.

Tools:

Move the platformName property from the testRunner into
accessibilityController, since this is a concept that has only be
used by accessibility tests since it got added, and also because
the real intention was not to distinguish among "ports" (mac, win,
gtk, efl) but between platforms (atk, mac, win).

This change will be very useful to merge GTK's roles-exposed.html
and Mac's role-subrole-roledescription.html into one single test,
since we will be specifying in the test itself which elements are
supported in which accessibility "platform". In this context,
being able to check accessibilityController.platformName directly
against a list of supported accessibility platforms (e.g. "atk,mac")
will certainly maintain the code cleaner and simpler.

* DumpRenderTree/TestRunner.h:
(TestRunner::platformName): Removed.
* DumpRenderTree/TestRunner.cpp:
(getPlatformNameCallback): Removed.
(TestRunner::staticValues): Removed platformName
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::platformName): Removed.
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::platformName): Removed.
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::platformName): Removed.
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::platformName): Removed.

* DumpRenderTree/AccessibilityController.h:
(AccessibilityController::platformName): Added.
* DumpRenderTree/AccessibilityController.cpp:
(getPlatformNameCallback): Added.
(AccessibilityController::getJSClass): Added platformName.
* DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
(AccessibilityController::platformName): Added, returning "atk".
* DumpRenderTree/mac/AccessibilityControllerMac.mm:
(AccessibilityController::platformName): Ditto, returning "mac".
* DumpRenderTree/ios/AccessibilityControllerIOS.mm:
(AccessibilityController::platformName): Ditto, returning "ios".
* DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::platformName): Ditto, returning "win".

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
(platformName): Removed.
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner::platformName): Removed.
* WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
(TestRunner::platformName): Removed.
* WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
(TestRunner::platformName): Removed.
* WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
(TestRunner::platformName): Removed.
* WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
(TestRunner::platformName): Removed.

* WebKitTestRunner/InjectedBundle/AccessibilityController.h:
(WTR:AccessibilityController::platformName): Added.
* WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
(platformName): Added.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::platformName): Added, returning "atk".
* WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
(WTR::AccessibilityController::platformName): Added, returning "mac".

LayoutTests:

Updated tests and expectations affected by the move of
platformName from TestRunner to AccessibilityController.

* accessibility/canvas-fallback-content.html:
* accessibility/ignore-spacer-elements.html:
* accessibility/platform-name.html:
* platform/efl/accessibility/platform-name-expected.txt:
* platform/gtk/accessibility/platform-name-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoPossible crash in ApplicationCache::removeResource.
commit-queue@webkit.org [Fri, 10 Jan 2014 21:08:51 +0000 (21:08 +0000)]
Possible crash in ApplicationCache::removeResource.
https://bugs.webkit.org/show_bug.cgi?id=126695

Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-10
Reviewed by Alexey Proskuryakov.

No new tests.

Iterator variable was used after it was removed.

* loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::removeResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAnother build fix for the Production Mac build following <http://trac.webkit.org...
dbates@webkit.org [Fri, 10 Jan 2014 20:51:55 +0000 (20:51 +0000)]
Another build fix for the Production Mac build following <trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Move the logic for appending the port-specific IDL files {Touch, TouchEvent, TouchList}.idl to the
list of binding IDLs (BINDING_IDLS) before the definition of variables DOM_CLASSES and JS_DOM_HEADERS
so that we generate the DOM and JS bindings for these IDLs.

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove supportMultipleWindows setting
andersca@apple.com [Fri, 10 Jan 2014 20:47:48 +0000 (20:47 +0000)]
Remove supportMultipleWindows setting
https://bugs.webkit.org/show_bug.cgi?id=126772

Reviewed by Beth Dakin.

Source/WebCore:

This setting was added in https://bugs.webkit.org/show_bug.cgi?id=99716 for the Chromium port
and is unused by everyone else so get rid of it.

* loader/FrameLoader.cpp:
(WebCore::createWindow):
* page/ContextMenuController.cpp:
(WebCore::openNewWindow):
* page/Settings.in:

LayoutTests:

* fast/dom/HTMLAnchorElement/anchor-no-multiple-windows-expected.txt: Removed.
* fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html: Removed.
* fast/dom/Window/window-open-no-multiple-windows-expected.txt: Removed.
* fast/dom/Window/window-open-no-multiple-windows.html: Removed.
* fast/forms/post-popup-no-multiple-windows-expected.txt: Removed.
* fast/forms/post-popup-no-multiple-windows.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove the BlackBerry port from trunk
benjamin@webkit.org [Fri, 10 Jan 2014 20:41:20 +0000 (20:41 +0000)]
Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

Source/WebCore:

* dom/TouchEvent.cpp:
(WebCore::TouchEvent::TouchEvent):
(WebCore::TouchEvent::initTouchEvent):
* dom/TouchEvent.h:
* dom/ViewportArguments.cpp:
* dom/ViewportArguments.h:
* history/HistoryItem.h:
* loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::createResourceHandle):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading):
* page/NavigatorBase.cpp:
* page/Settings.cpp:
* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::create):
* platform/Cursor.cpp:
* platform/Cursor.h:
(WebCore::Cursor::Cursor):
* platform/DragData.h:
* platform/DragImage.h:
* plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintsIntoWindow):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):
* testing/Internals.cpp:
(WebCore::Internals::getCurrentCursorInfo):
* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::load):
* workers/Worker.cpp:
(WebCore::Worker::create):
* workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::importScripts):
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::createResourceRequest):
* workers/WorkerScriptLoader.h:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove the BlackBerry port from trunk
benjamin@webkit.org [Fri, 10 Jan 2014 20:40:28 +0000 (20:40 +0000)]
Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

.:

* CMakeLists.txt:

Source/WebCore:

* Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::initProtocolHandlerWhitelist):
* UseJSC.cmake:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
* bindings/js/GCController.cpp:
(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon):
* bindings/js/GCController.h:

Source/WebKit2:

* Scripts/generate-forwarding-headers.pl:

Tools:

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the WebCore, WebKit build targets following <http://trac.webkit.org/changeset...
dbates@webkit.org [Fri, 10 Jan 2014 20:38:41 +0000 (20:38 +0000)]
Fix the WebCore, WebKit build targets following <trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Source/WebCore:

Tell Xcode that the supported platforms for all WebKit targets are iOS and OS X.

* Configurations/Base.xcconfig:

Source/WebKit/mac:

Tell Xcode that the supported platforms for all WebCore targets are iOS and OS X.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove the BlackBerry files outside WebCore
benjamin@webkit.org [Fri, 10 Jan 2014 19:50:32 +0000 (19:50 +0000)]
Remove the BlackBerry files outside WebCore
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

.:

* ManualTests/blackberry: Removed.
* Source/cmake/OptionsBlackBerry.cmake: Removed.

Source/JavaScriptCore:

* PlatformBlackBerry.cmake: Removed.
* runtime/GCActivityCallbackBlackBerry.cpp: Removed.
* shell/PlatformBlackBerry.cmake: Removed.

Tools:

* DumpRenderTree/blackberry: Removed.

LayoutTests:

* platform/blackberry: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Upstream iOS changes to MigrateHeaders.make
aestes@apple.com [Fri, 10 Jan 2014 19:32:56 +0000 (19:32 +0000)]
[iOS] Upstream iOS changes to MigrateHeaders.make
https://bugs.webkit.org/show_bug.cgi?id=126731

Reviewed by David Kilzer.

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj: Mark an iOS-specific header at
Private that will later be migrated by WebKit.

Source/WebKit/mac:

* MigrateHeaders.make: Migrate iOS-specific headers when building for iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the Production Mac build following <http://trac.webkit.org/changeset/161638>
dbates@webkit.org [Fri, 10 Jan 2014 19:13:16 +0000 (19:13 +0000)]
Fix the Production Mac build following <trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Substitute JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production_ for JAVASCRIPTCORE_PRIVATE_HEADERS_Production_.

* Configurations/WebCore.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemove knowledge of Blackberry from build scripts
simon.fraser@apple.com [Fri, 10 Jan 2014 19:12:26 +0000 (19:12 +0000)]
Remove knowledge of Blackberry from build scripts
https://bugs.webkit.org/show_bug.cgi?id=126766

Reviewed by Anders Carlsson.

Remove isBlackBerry() and references to it, and rmeove
blackberry-related stuff from the watchlist.

* Scripts/build-webkit:
* Scripts/webkit-build-directory:
* Scripts/webkitdirs.pm:
(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(isAppleWebKit):
(buildCMakeProjectOrExit):
(cmakeBasedPortArguments):
(cmakeBasedPortName):
* Scripts/webkitperl/FeatureList.pm:
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAdd a missing include.
andersca@apple.com [Fri, 10 Jan 2014 19:07:55 +0000 (19:07 +0000)]
Add a missing include.

* Modules/webdatabase/DatabaseManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse STL threading primitives in DatabaseDetails and DatabaseManager
andersca@apple.com [Fri, 10 Jan 2014 19:02:43 +0000 (19:02 +0000)]
Use STL threading primitives in DatabaseDetails and DatabaseManager
https://bugs.webkit.org/show_bug.cgi?id=126759

Reviewed by Geoffrey Garen.

* Modules/webdatabase/DatabaseDetails.h:
(WebCore::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::threadID):
* Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::existingDatabaseContextFor):
(WebCore::DatabaseManager::registerDatabaseContext):
(WebCore::DatabaseManager::unregisterDatabaseContext):
(WebCore::DatabaseManager::didConstructDatabaseContext):
(WebCore::DatabaseManager::didDestructDatabaseContext):
(WebCore::DatabaseManager::addProposedDatabase):
(WebCore::DatabaseManager::removeProposedDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):
* Modules/webdatabase/DatabaseManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed, rolling out r161629.
commit-queue@webkit.org [Fri, 10 Jan 2014 18:59:28 +0000 (18:59 +0000)]
Unreviewed, rolling out r161629.
http://trac.webkit.org/changeset/161629
https://bugs.webkit.org/show_bug.cgi?id=126762

Fails svg/custom/conditional-processing-2.html (Requested by
ap on #webkit).

Source/WebCore:

* svg/SVGSwitchElement.cpp:
(WebCore::SVGSwitchElement::childShouldCreateRenderer):
* svg/SVGTests.cpp:
(WebCore::SVGTests::hasExtension):
(WebCore::SVGTests::isValid):

LayoutTests:

* svg/custom/conditional-processing-1-expected.txt: Removed.
* svg/custom/conditional-processing-1.svg: Removed.
* svg/custom/conditional-processing-2-expected.txt: Removed.
* svg/custom/conditional-processing-2.html: Removed.
* svg/dom/SVGTests-expected.txt: Removed.
* svg/dom/SVGTests.html: Removed.
* svg/dom/script-tests/SVGTests.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed build fix since r161589.
changseok.oh@collabora.com [Fri, 10 Jan 2014 18:53:12 +0000 (18:53 +0000)]
Unreviewed build fix since r161589.

The changeset causes a compile failure with --no-svg.

* platform/graphics/FontFastPath.cpp:
(WebCore::Font::drawGlyphBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Fix up simulator build and enable default features
dbates@webkit.org [Fri, 10 Jan 2014 18:49:22 +0000 (18:49 +0000)]
[iOS] Fix up simulator build and enable default features

Rubber-stamped by Joseph Pecoraro.

* Scripts/webkitdirs.pm:
(determineArchitecture):
(determinePassedArchitecture):
* Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
by default only in iOS).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoRemoved Blackberry #ifdefs and platform code from JavaScriptCore
ggaren@apple.com [Fri, 10 Jan 2014 18:38:41 +0000 (18:38 +0000)]
Removed Blackberry #ifdefs and platform code from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=126757

Reviewed by Sam Weinig.

* PlatformBlackBerry.cmake: Removed.
* heap/HeapTimer.cpp:
* heap/HeapTimer.h:
* heap/IncrementalSweeper.cpp:
* heap/IncrementalSweeper.h:
* jsc.cpp:
(main):
* runtime/GCActivityCallbackBlackBerry.cpp: Removed.
* runtime/MemoryStatistics.cpp:
(JSC::globalMemoryStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WebGL] Removing unnecessary pointer checks
bfulgham@apple.com [Fri, 10 Jan 2014 18:22:59 +0000 (18:22 +0000)]
[WebGL] Removing unnecessary pointer checks
https://bugs.webkit.org/show_bug.cgi?id=124046

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2014-01-10
Reviewed by Brent Fulgham.

We do not need to check for a null array three times in
the same call. Let's just do it once!

No new tests. Covered by existing ones.

* html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSpeculative build fix for Windows following <http://trac.webkit.org/changeset/161638>
bfulgham@apple.com [Fri, 10 Jan 2014 18:22:32 +0000 (18:22 +0000)]
Speculative build fix for Windows following <trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Patch by Daniel Bates <dabates@apple.com> on 2014-01-10
Reviewed by David Kilzer.

* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoSpeculative build fix for Windows following <http://trac.webkit.org/changeset/161638>
dbates@webkit.org [Fri, 10 Jan 2014 18:20:11 +0000 (18:20 +0000)]
Speculative build fix for Windows following <trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUnreviewed test correction after r161605.
bfulgham@apple.com [Fri, 10 Jan 2014 18:15:13 +0000 (18:15 +0000)]
Unreviewed test correction after r161605.

* platform/mac/TestExpectations: Reactivate tests fixed by
https://bugs.webkit.org/show_bug.cgi?id=126718.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WebGL] Wrong condition order in the if statement
bfulgham@apple.com [Fri, 10 Jan 2014 18:12:07 +0000 (18:12 +0000)]
[WebGL] Wrong condition order in the if statement
https://bugs.webkit.org/show_bug.cgi?id=125000

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2014-01-10
Reviewed by Brent Fulgham.

We should only pay the cost of string comparison once. The
current logic requires a string comparison every time we
pass through the function. Instead, by reordering the statements
we can short-circuit through the boolean test after the initial
setup is complete.

No new tests. No behaviour changes.

* platform/graphics/opengl/Extensions3DOpenGLES.cpp:
(WebCore::Extensions3DOpenGLES::supportsExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoCTTE in AudioContext::AutoLocker
andersca@apple.com [Fri, 10 Jan 2014 17:50:44 +0000 (17:50 +0000)]
CTTE in AudioContext::AutoLocker
https://bugs.webkit.org/show_bug.cgi?id=126758

Reviewed by Antti Koivisto.

* Modules/webaudio/AudioBasicInspectorNode.cpp:
(WebCore::AudioBasicInspectorNode::connect):
(WebCore::AudioBasicInspectorNode::disconnect):
* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::setBuffer):
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::refNode):
(WebCore::AudioContext::deleteMarkedNodes):
(WebCore::AudioContext::removeMarkedSummingJunction):
* Modules/webaudio/AudioContext.h:
(WebCore::AudioContext::AutoLocker::AutoLocker):
(WebCore::AudioContext::AutoLocker::~AutoLocker):
* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::setChannelCount):
(WebCore::AudioNode::setChannelCountMode):
(WebCore::AudioNode::setChannelInterpretation):
(WebCore::AudioNode::enableOutputsIfNecessary):
* Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::setFormat):
* Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::setOversample):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoUse element iterators more
antti@apple.com [Fri, 10 Jan 2014 17:45:19 +0000 (17:45 +0000)]
Use element iterators more
https://bugs.webkit.org/show_bug.cgi?id=126756

Reviewed by Anders Carlsson.

* dom/VisitedLinkState.cpp:
(WebCore::VisitedLinkState::invalidateStyleForAllLinks):
(WebCore::VisitedLinkState::invalidateStyleForLink):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::renderMeter):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::renderProgress):
* html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::ensureInsertionPointList):
* style/StyleResolveTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAttempt to fix the iOS build after <http://trac.webkit.org/changeset/161589>
dbates@webkit.org [Fri, 10 Jan 2014 17:37:35 +0000 (17:37 +0000)]
Attempt to fix the iOS build after <trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)

* platform/audio/ios/AudioSessionIOS.mm: Import header PassOwnPtr.h so that we can use adoptPtr().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoAttempt to fix the build after <http://trac.webkit.org/changeset/161638>
dbates@webkit.org [Fri, 10 Jan 2014 17:19:19 +0000 (17:19 +0000)]
Attempt to fix the build after <trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Substitute tab characters for space characters.

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WinCairo] Crash when rendering (in pixman dll)
commit-queue@webkit.org [Fri, 10 Jan 2014 17:17:23 +0000 (17:17 +0000)]
[WinCairo] Crash when rendering (in pixman dll)
https://bugs.webkit.org/show_bug.cgi?id=126750

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-10
Reviewed by Brent Fulgham.

Since we link with cairo.lib, and the gstreamer installation also comes with cairo.lib,
we link with the wrong cairo.lib, and loads gstreamers cairo dll, instead of our own.
We should user our own cairo dll for rendering.

* win/tools/vsprops/GStreamer32.props: Put gstreamer lib path last, so we link with the correct cairo.lib.
* win/tools/vsprops/GStreamer64.props: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoDOMWindow::showModalDialog should use std::function
andersca@apple.com [Fri, 10 Jan 2014 17:07:56 +0000 (17:07 +0000)]
DOMWindow::showModalDialog should use std::function
https://bugs.webkit.org/show_bug.cgi?id=126753

Reviewed by Antti Koivisto.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::DialogHandler::dialogCreated):
(WebCore::JSDOMWindow::showModalDialog):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::showModalDialog):
* page/DOMWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[iOS] Upstream WebCore and Tools miscellaneous changes
dbates@webkit.org [Fri, 10 Jan 2014 17:06:52 +0000 (17:06 +0000)]
[iOS] Upstream WebCore and Tools miscellaneous changes
https://bugs.webkit.org/show_bug.cgi?id=126698

Reviewed by David Kilzer.

Source/WebCore:

* Configurations/Base.xcconfig:
* Configurations/WebCore.xcconfig:
* Configurations/WebCoreTestSupport.xcconfig:
* Configurations/iOS.xcconfig: Added.
* DerivedSources.make:
* English.lproj/Localizable.strings:
* Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.cpp: Copied from Source/WebCore/editing/TextAffinity.h.
(WebCore::stringForPlaybackTargetAvailability):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::WebKitPlaybackTargetAvailabilityEvent):
* Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h: Added.
(WebCore::WebKitPlaybackTargetAvailabilityEventInit::WebKitPlaybackTargetAvailabilityEventInit):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::~WebKitPlaybackTargetAvailabilityEvent):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::create):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::availability):
* Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.idl: Copied from Source/WebCore/editing/DeleteButton.h.
* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::canSuspend):
(WebCore::Geolocation::suspend):
(WebCore::Geolocation::resume):
(WebCore::Geolocation::resumeTimerFired):
(WebCore::Geolocation::resetAllGeolocationPermission):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::positionChanged):
(WebCore::Geolocation::setError):
* Modules/geolocation/Geolocation.h:
* Modules/geolocation/NavigatorGeolocation.cpp:
(WebCore::NavigatorGeolocation::resetAllGeolocationPermission):
* Modules/geolocation/NavigatorGeolocation.h:
* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::speak):
* Modules/speech/SpeechSynthesis.h:
(WebCore::SpeechSynthesis::userGestureRequiredForSpeechStart):
(WebCore::SpeechSynthesis::removeBehaviorRestriction):
* Modules/webaudio/AudioContext.cpp:
* Modules/webaudio/AudioContext.h:
* Modules/webaudio/AudioScheduledSourceNode.cpp:
* Modules/webdatabase/Database.cpp:
* Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):
* Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::databaseThread):
(WebCore::DatabaseContext::setPaused):
* Modules/webdatabase/DatabaseContext.h:
* Modules/webdatabase/DatabaseManagerClient.h:
* Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseTask::performTask):
(WebCore::Database::DatabaseTransactionTask::shouldPerformWhilePaused):
* Modules/webdatabase/DatabaseTask.h:
* Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::DatabaseThread):
(WebCore::DatabaseThread::requestTermination):
(WebCore::DatabaseUnpauseTask::create):
(WebCore::DatabaseUnpauseTask::shouldPerformWhilePaused):
(WebCore::DatabaseUnpauseTask::DatabaseUnpauseTask):
(WebCore::DatabaseUnpauseTask::doPerformTask):
(WebCore::DatabaseUnpauseTask::debugTaskName):
(WebCore::DatabaseThread::setPaused):
(WebCore::DatabaseThread::handlePausedQueue):
(WebCore::DatabaseThread::databaseThread):
* Modules/webdatabase/DatabaseThread.h:
* Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):
(WebCore::DatabaseTracker::removeDeletedOpenedDatabases):
(WebCore::isZeroByteFile):
(WebCore::DatabaseTracker::deleteDatabaseFileIfEmpty):
(WebCore::DatabaseTracker::openDatabaseMutex):
(WebCore::DatabaseTracker::emptyDatabaseFilesRemovalTaskWillBeScheduled):
(WebCore::DatabaseTracker::emptyDatabaseFilesRemovalTaskDidFinish):
(WebCore::DatabaseTracker::setDatabasesPaused):
* Modules/webdatabase/DatabaseTracker.h:
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::shouldPerformWhilePaused):
* Modules/webdatabase/SQLTransactionBackend.h:
* Resources/DictationPhraseWithAlternativesDot.png: Added.
* Resources/DictationPhraseWithAlternativesDot@2x.png: Added.
* Resources/SpellingDot.png: Added.
* Resources/SpellingDot@2x.png: Added.
* Resources/decrementArrow.tiff: Added.
* Resources/hScrollControl_left.png: Added.
* Resources/hScrollControl_middle.png: Added.
* Resources/hScrollControl_right.png: Added.
* Resources/incrementArrow.tiff: Added.
* Resources/markedLeft.png: Added.
* Resources/markedMiddle.png: Added.
* Resources/markedRight.png: Added.
* Resources/vScrollControl_bottom.png: Added.
* Resources/vScrollControl_middle.png: Added.
* Resources/vScrollControl_top.png: Added.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectNow):
(WebCore::GCController::releaseExecutableMemory):
* bindings/js/GCController.h:
* bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::~JSCallbackData):
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::supportsProfiling):
(WebCore::JSDOMWindowBase::shouldInterruptScriptBeforeTimeout):
(WebCore::JSDOMWindowBase::commonVM):
(WebCore::JSDOMWindowBase::commonVMExists):
(WebCore::JSDOMWindowBase::commonVMInternal):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::touch):
(WebCore::JSDOMWindow::touchList):
* bindings/js/JSDeviceOrientationEventCustom.cpp:
(WebCore::JSDeviceOrientationEvent::webkitCompassHeading):
(WebCore::JSDeviceOrientationEvent::webkitCompassAccuracy):
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):
* bindings/js/JSMainThreadExecState.h:
* bindings/js/JSTouchCustom.cpp:
* bindings/js/JSTouchListCustom.cpp:
* bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::didContinue):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::initializeThreading):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::handlePause):
* bindings/js/ios/TouchConstructors.cpp: Added.
* bindings/objc/DOM.mm:
(WebCore::wkQuadFromFloatQuad):
(WebCore::kit):
(WebCore::min4):
(WebCore::max4):
(WebCore::emptyQuad):
(-[WKQuadObject initWithQuad:]):
(-[WKQuadObject quad]):
(-[WKQuadObject boundingBox]):
(-[DOMNode boundingBox]):
(-[DOMNode absoluteQuad]):
(-[DOMNode absoluteQuadAndInsideFixedPosition:]):
(-[DOMNode boundingBoxUsingTransforms]):
(-[DOMNode lineBoxQuads]):
(-[DOMNode _linkElement]):
(-[DOMNode hrefURL]):
(-[DOMNode hrefTarget]):
(-[DOMNode hrefFrame]):
(-[DOMNode hrefLabel]):
(-[DOMNode hrefTitle]):
(-[DOMNode boundingFrame]):
(-[DOMNode innerFrameQuad]):
(-[DOMNode computedFontSize]):
(-[DOMNode nextFocusNode]):
(-[DOMNode previousFocusNode]):
(-[DOMRange boundingBox]):
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
(-[DOMElement _font]):
(-[DOMHTMLLinkElement _mediaQueryMatchesForOrientation:]):
(-[DOMHTMLLinkElement _mediaQueryMatches]):
* bindings/objc/DOMEvents.h:
* bindings/objc/DOMEvents.mm:
(kitClass):
* bindings/objc/DOMExtensions.h:
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLElement scrollYOffset]):
(-[DOMHTMLElement setScrollXOffset:scrollYOffset:]):
(-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
(-[DOMHTMLElement absolutePosition::::]):
(-[DOMHTMLInputElement _autocapitalizeType]):
(-[DOMHTMLTextAreaElement _autocapitalizeType]):
(-[DOMHTMLInputElement setValueWithChangeEvent:]):
(-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]):
* bindings/objc/DOMInternal.h:
* bindings/objc/DOMInternal.mm:
(wrapperCacheLock):
(getDOMWrapper):
(addDOMWrapper):
(removeDOMWrapper):
* bindings/objc/DOMPrivate.h:
* bindings/objc/DOMUIKitExtensions.h: Added.
* bindings/objc/DOMUIKitExtensions.mm: Added.
* bindings/objc/PublicDOMInterfaces.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackImplementation):
* bindings/scripts/CodeGeneratorObjC.pm:
(ReadPublicInterfaces):
(GetClassName):
(IsCoreFoundationType):
(GetObjCType):
(AddIncludesForType):
(GenerateHeader):
(GenerateImplementation):
(WriteData):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):
* bridge/objc/objc_class.mm:
(JSC::Bindings::ObjcClass::fieldNamed):
* bridge/objc/objc_instance.mm:
* config.h:
* dom/Document.cpp:
(WebCore::Document::addAutoSizingNode):
* dom/Document.h:
* dom/Document.idl:
* dom/ios/TouchEvents.cpp: Added.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle):
* editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::unapply):
(WebCore::CompositeEditCommand::apply):
(WebCore::CompositeEditCommand::inputText):
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
(WebCore::CompositeEditCommand::moveParagraphs):
* editing/CompositeEditCommand.h:
* editing/DeleteButton.h:
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::enable):
(WebCore::DeleteButtonController::disable):
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::doApply):
* editing/DeleteSelectionCommand.h:
* editing/EditAction.h:
* editing/EditCommand.h:
(WebCore::EditCommand::isInsertTextCommand):
* editing/EditingStyle.cpp:
* editing/Editor.cpp:
(WebCore::ClearTextCommand::ClearTextCommand):
(WebCore::ClearTextCommand::editingAction):
(WebCore::ClearTextCommand::CreateAndApply):
(WebCore::Editor::handleTextEvent):
(WebCore::Editor::clearText):
(WebCore::Editor::insertDictationPhrases):
(WebCore::Editor::setDictationPhrasesAsChildOfElement):
(WebCore::Editor::confirmMarkedText):
(WebCore::Editor::setTextAsChildOfElement):
(WebCore::Editor::notifyComponentsOnChangedSelection):
(WebCore::Editor::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping):
(WebCore::Editor::copy):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::setComposition):
(WebCore::Editor::showSpellingGuessPanel):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markMisspellingsOrBadGrammar):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
(WebCore::Editor::setIgnoreCompositionSelectionChange):
(WebCore::Editor::changeSelectionAfterCommand):
(WebCore::Editor::shouldChangeSelection):
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::resolveTextCheckingTypeMask):
* editing/Editor.h:
* editing/EditorCommand.cpp:
(WebCore::executeClearText):
(WebCore::enabledCopy):
(WebCore::enabledCut):
(WebCore::enabledClearText):
(WebCore::createCommandMap):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::modifyExtendingRight):
(WebCore::FrameSelection::modifyExtendingForward):
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyExtendingLeft):
(WebCore::FrameSelection::modifyExtendingBackward):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::modifyMovingBackward):
(WebCore::FrameSelection::setSelectedRange):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::updateAppearance):
(WebCore::FrameSelection::shouldDeleteSelection):
(WebCore::FrameSelection::revealSelection):
(WebCore::FrameSelection::setSelectionFromNone):
(WebCore::FrameSelection::shouldChangeSelection):
(WebCore::FrameSelection::expandSelectionToElementContainingCaretSelection):
(WebCore::FrameSelection::elementRangeContainingCaretSelection):
(WebCore::FrameSelection::expandSelectionToWordContainingCaretSelection):
(WebCore::FrameSelection::wordRangeContainingCaretSelection):
(WebCore::FrameSelection::expandSelectionToStartOfWordContainingCaretSelection):
(WebCore::FrameSelection::characterInRelationToCaretSelection):
(WebCore::FrameSelection::characterBeforeCaretSelection):
(WebCore::FrameSelection::characterAfterCaretSelection):
(WebCore::FrameSelection::wordOffsetInRange):
(WebCore::FrameSelection::spaceFollowsWordInRange):
(WebCore::FrameSelection::selectionAtDocumentStart):
(WebCore::FrameSelection::selectionAtSentenceStart):
(WebCore::FrameSelection::selectionAtWordStart):
(WebCore::FrameSelection::rangeByMovingCurrentSelection):
(WebCore::FrameSelection::rangeByExtendingCurrentSelection):
(WebCore::FrameSelection::selectRangeOnElement):
(WebCore::FrameSelection::wordSelectionContainingCaretSelection):
(WebCore::FrameSelection::actualSelectionAtSentenceStart):
(WebCore::FrameSelection::rangeByAlteringCurrentSelection):
(WebCore::FrameSelection::clearCurrentSelection):
(WebCore::FrameSelection::setCaretBlinks):
(WebCore::FrameSelection::setCaretColor):
* editing/FrameSelection.h:
(WebCore::FrameSelection::suppressCloseTyping):
(WebCore::FrameSelection::restoreCloseTyping):
(WebCore::FrameSelection::setUpdateAppearanceEnabled):
(WebCore::FrameSelection::suppressScrolling):
(WebCore::FrameSelection::restoreScrolling):
* editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doReapply):
* editing/InsertIntoTextNodeCommand.h:
* editing/InsertTextCommand.h:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):
* editing/TextAffinity.h:
* editing/TextCheckingHelper.cpp:
* editing/TextGranularity.h:
* editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping):
(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::FriendlyEditCommand::setEndingSelection):
(WebCore::TypingCommand::setEndingSelectionOnLastInsertCommand):
* editing/TypingCommand.h:
* editing/VisiblePosition.h:
(WebCore::operator<):
(WebCore::operator>):
(WebCore::operator<=):
(WebCore::operator>=):
* editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):
* editing/VisibleUnits.cpp:
(WebCore::previousBoundary):
(WebCore::nextBoundary):
(WebCore::startOfDocument):
(WebCore::endOfDocument):
(WebCore::directionIsDownstream):
(WebCore::atBoundaryOfGranularity):
(WebCore::withinTextUnitOfGranularity):
(WebCore::nextCharacterBoundaryInDirection):
(WebCore::nextWordBoundaryInDirection):
(WebCore::nextSentenceBoundaryInDirection):
(WebCore::nextLineBoundaryInDirection):
(WebCore::nextParagraphBoundaryInDirection):
(WebCore::nextDocumentBoundaryInDirection):
(WebCore::positionOfNextBoundaryOfGranularity):
(WebCore::enclosingTextUnitOfGranularity):
(WebCore::distanceBetweenPositions):
(WebCore::wordRangeFromPosition):
(WebCore::closestWordBoundaryForPosition):
* editing/VisibleUnits.h:
* editing/ios/DictationCommandIOS.cpp: Added.
* editing/ios/DictationCommandIOS.h: Added.
(WebCore::DictationCommandIOS::create):
(WebCore::DictationCommandIOS::editingAction):
* editing/mac/FrameSelectionMac.mm:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
* fileapi/AsyncFileStream.cpp:
* generate-export-file: Added.
* inspector/InspectorCounters.h:
* inspector/InspectorFrontendHost.h:
* make-export-file-generator:
* plugins/PluginPackage.h:
* plugins/PluginViewBase.h:
(WebCore::PluginViewBase::willProvidePluginLayer):
(WebCore::PluginViewBase::attachPluginLayer):
(WebCore::PluginViewBase::detachPluginLayer):
* style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
* style/StyleResolveTree.cpp:
(WebCore::Style::elementImplicitVisibility):
* testing/Internals.cpp:
(WebCore::Internals::getCurrentCursorInfo):
(WebCore::Internals::isSelectPopupVisible):
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* MigrateHeaders.make:

Tools:

* Scripts/check-for-inappropriate-objc-class-names:
* Scripts/check-for-webkit-framework-include-consistency:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoFix the iOS build after <http://trac.webkit.org/changeset/161589>
dbates@webkit.org [Fri, 10 Jan 2014 16:55:05 +0000 (16:55 +0000)]
Fix the iOS build after <trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)

* platform/graphics/ios/MediaPlayerPrivateIOS.h:
(WebCore::MediaPlayerPrivateIOS::engineDescription): Adding missing return keyword.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[CSS Regions] Remove unused CSSParser::parseFlowThread
abucur@adobe.com [Fri, 10 Jan 2014 16:31:13 +0000 (16:31 +0000)]
[CSS Regions] Remove unused CSSParser::parseFlowThread
https://bugs.webkit.org/show_bug.cgi?id=126749

Reviewed by Antti Koivisto.

There are two versions of CSSParser::parseFlowThread. Remove the unused one:
bool parseFlowThread(const String& flowName);

Tests: No tests, code cleanup.

* css/CSSParser.cpp:
* css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years ago[WinCairo] Build fix after r161589.
commit-queue@webkit.org [Fri, 10 Jan 2014 16:27:32 +0000 (16:27 +0000)]
[WinCairo] Build fix after r161589.
https://bugs.webkit.org/show_bug.cgi?id=126747

Patch by Alex Christensen <achristensen@webkit.org> on 2014-01-10
Reviewed by Anders Carlsson.

* platform/network/ResourceHandle.cpp:
Include NotImplemented.h for all platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoConvert some for loops over to range-based for
andersca@apple.com [Fri, 10 Jan 2014 16:19:06 +0000 (16:19 +0000)]
Convert some for loops over to range-based for
https://bugs.webkit.org/show_bug.cgi?id=126752

Reviewed by Antti Koivisto.

* inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):
* loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::clearStorageID):
* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::clearStorageID):
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::fillResourceList):
* loader/appcache/ApplicationCacheResource.cpp:
(WebCore::ApplicationCacheResource::estimatedSizeInStorage):
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
* loader/archive/ArchiveFactory.cpp:
(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::styleAvailable):
(WebCore::AnimationControllerPrivate::startTimeResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5 years agoTighten up two functions in the inspector code
andersca@apple.com [Fri, 10 Jan 2014 15:40:52 +0000 (15:40 +0000)]
Tighten up two functions in the inspector code
https://bugs.webkit.org/show_bug.cgi?id=126751

Reviewed by Antti Koivisto.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::frameStartedLoadingImpl):
(WebCore::InspectorInstrumentation::frameStoppedLoadingImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore::InspectorInstrumentation::frameStoppedLoading):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::frameStartedLoading):
(WebCore::InspectorPageAgent::frameStoppedLoading):
* inspector/InspectorPageAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161633 268f45cc-cd09-0410-ab3c-d52691b4dbfc